From owner-freebsd-mips@FreeBSD.ORG Sun Apr 7 02:57:07 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 907F8CC7; Sun, 7 Apr 2013 02:57:07 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) by mx1.freebsd.org (Postfix) with ESMTP id 00D28EDD; Sun, 7 Apr 2013 02:57:06 +0000 (UTC) Received: by mail-wi0-f169.google.com with SMTP id c10so2882877wiw.0 for ; Sat, 06 Apr 2013 19:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=N1VmtVnD/whI0oyYLyMT1q+HSwnaBWs7nGVx8hW3CCU=; b=KRCn55vAUS7t9RTiSf04EPq0yVTf1hXS69PffYZe+nddCU6PndPrJH7VB7yO8Tzbp4 wzminnWkDzT0hwjnpTqx+Z0f4QxOWaKozFFhBSj0d/hgLPu6LebuY7Z7DlMf5tjklEOT 18sM1YZ4EgW45L9WtgxXp6YmM2pizywWUyFr01hVcssBB+pC+WObTJv5RaCDlmXv06ta U1azhh0Hync1MPcYuw0EZMwNqRnuXaLEzoV+bQ/3p38zkVB/zEdSHlmGkZY0eEj67iVq f7p1hUHrkf+go1BKsJACl865lQf3mT+Fqpo334d/GJL3egIS/xR3ABXzly+q7E7Oyjdo ZLXA== MIME-Version: 1.0 X-Received: by 10.194.143.50 with SMTP id sb18mr24548497wjb.44.1365303425801; Sat, 06 Apr 2013 19:57:05 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Sat, 6 Apr 2013 19:57:05 -0700 (PDT) In-Reply-To: <20130407022428.86a66c6a.ray@freebsd.org> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> Date: Sat, 6 Apr 2013 19:57:05 -0700 X-Google-Sender-Auth: pR8l-masNElpvkyLbp6DDvGxqto Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Aleksandr Rybalko Content-Type: text/plain; charset=ISO-8859-1 Cc: Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2013 02:57:07 -0000 On 6 April 2013 16:24, Aleksandr Rybalko wrote: >> The other question is how we implement it. You've implemented a "get >> block" device method. That's a very atheros chipset specific hack just >> to get accelerated flash IO. Is there perhaps a better way to approach >> this? > > As I see, no way to put data back to flash. Well, look at the Linux code. If there's a read that can be satisfied by a copy, it: * puts the flash device back into mapped mode; * does the transfer; * puts the flash device back into SPI mode. That way both can occur independently. >> What about the 8 versus 32 bit shifting that I see in the driver? Are >> we able to actually shift 32 bits at a time? > > Currently we do 1 bit shifting :))) Pure, 1-bit control. > Maybe you (as Atheros guy) know how to shift more :))) Writes are clocked out like that, sure. But if I read the linux code right, they do up to 32 bits of shifting at once, then do a 32 bit read. Rather than us shifting a byte in/out at a time over SPI. Adrian From owner-freebsd-mips@FreeBSD.ORG Mon Apr 8 11:06:48 2013 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 889FB22B for ; Mon, 8 Apr 2013 11:06:48 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 79F5735C for ; Mon, 8 Apr 2013 11:06:48 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r38B6m25057297 for ; Mon, 8 Apr 2013 11:06:48 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r38B6mA7057295 for freebsd-mips@FreeBSD.org; Mon, 8 Apr 2013 11:06:48 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 8 Apr 2013 11:06:48 GMT Message-Id: <201304081106.r38B6mA7057295@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-mips@FreeBSD.org Subject: Current problem reports assigned to freebsd-mips@FreeBSD.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 11:06:48 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/177032 mips [arge] arge1 fails to attach on UBNT Routerstation o kern/165951 mips [ar913x] [ath] DDR flush isn't being done for the WMAC p kern/163670 mips [mips][arge] arge can't allocate ring buffer on multip 3 problems total. From owner-freebsd-mips@FreeBSD.ORG Mon Apr 8 12:32:14 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A7C2ADF8; Mon, 8 Apr 2013 12:32:14 +0000 (UTC) (envelope-from ray@freebsd.org) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 63AA5AE9; Mon, 8 Apr 2013 12:32:14 +0000 (UTC) Received: from terran (unknown [192.168.99.1]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPA id D39CEC492D; Mon, 8 Apr 2013 15:32:06 +0300 (EEST) Date: Mon, 8 Apr 2013 15:33:34 +0300 From: Aleksandr Rybalko To: Adrian Chadd Subject: Re: [PATCH] MMC/SD SPI-mode driver Message-Id: <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> In-Reply-To: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.6; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 12:32:14 -0000 On Sat, 6 Apr 2013 19:57:05 -0700 Adrian Chadd wrote: > On 6 April 2013 16:24, Aleksandr Rybalko wrote: > > >> The other question is how we implement it. You've implemented a "get > >> block" device method. That's a very atheros chipset specific hack just > >> to get accelerated flash IO. Is there perhaps a better way to approach > >> this? > > > > As I see, no way to put data back to flash. > > Well, look at the Linux code. If there's a read that can be satisfied > by a copy, it: > > * puts the flash device back into mapped mode; > * does the transfer; > * puts the flash device back into SPI mode. > > That way both can occur independently. Agree, but you forget to say about lock/unlock :) > > >> What about the 8 versus 32 bit shifting that I see in the driver? Are > >> we able to actually shift 32 bits at a time? > > > > Currently we do 1 bit shifting :))) Pure, 1-bit control. > > Maybe you (as Atheros guy) know how to shift more :))) > > Writes are clocked out like that, sure. But if I read the linux code > right, they do up to 32 bits of shifting at once, then do a 32 bit > read. I don't think we will get much progress here. if we will do it with 32bit width, we will do same GPIO stuff, but plus care about alignment. > > Rather than us shifting a byte in/out at a time over SPI. 90%/10% - find easiest way :-P :) > > > > Adrian -- Aleksandr Rybalko From owner-freebsd-mips@FreeBSD.ORG Mon Apr 8 18:32:12 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 949AF769; Mon, 8 Apr 2013 18:32:12 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by mx1.freebsd.org (Postfix) with ESMTP id 04A95FBD; Mon, 8 Apr 2013 18:32:11 +0000 (UTC) Received: by mail-wg0-f53.google.com with SMTP id c11so6248196wgh.20 for ; Mon, 08 Apr 2013 11:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=I4J+NZqg8XBn5CjEPy7XK48+guJ6PHiVI7ehJr/N7+M=; b=kghsQwByanBRQzcL/9DG3lgr5PzSkWvmUiESTQS41b8NsHLnkdByc9NQMefganE8yC CBKtCVdcvtx7Pb57nXpSbtumUKSwJAeKUd8iwfTbVoHKODc9/u/QfUhXvRClJc9uRnMK dhzZwTct1HYvROMaP/nB5BIKmMvjmWOY3zzV07CRuX6Iz9Py9nWZoGd3Y+Zu8VXK2+Kt 5R5b4X4tobKd5ENAs2yZGi7R5UoFWYQ+CxVMirL0QaSyToK5E8jYELqARr18ojz3Ckvr FRbgHEI6KmAuzp4J4CrDDfbira72WO+7jOFb9i8A7uc9fKuhod1bTjr4Id4w30jzi2P8 60HA== MIME-Version: 1.0 X-Received: by 10.194.88.138 with SMTP id bg10mr33602297wjb.13.1365445930535; Mon, 08 Apr 2013 11:32:10 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Mon, 8 Apr 2013 11:32:10 -0700 (PDT) In-Reply-To: <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> Date: Mon, 8 Apr 2013 11:32:10 -0700 X-Google-Sender-Auth: ggvX5yoZpclZl4ZOfcbs1kh10m0 Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Aleksandr Rybalko Content-Type: text/plain; charset=ISO-8859-1 Cc: Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2013 18:32:12 -0000 On 8 April 2013 05:33, Aleksandr Rybalko wrote: >> That way both can occur independently. > > Agree, but you forget to say about lock/unlock :) Yup, locking is implied. :-) I don't have any problem with extending the bus with this particular method hack to allow the driver to implement an alternate read method. Anyone else? I'm happy to review a patch against -HEAD that does this: * add that new method, same as zrouter * add the code to the flash driver, same as zrouter * add spi locking in ar71xx_spi to ensure that entire transfers are done inside a lock; * for that copy read method, have it lock the device, put it back into mapped mode, do the copy, put it into SPI mode, unlock the device. I think that should make it kick ass. Any takers? :) adrian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 01:22:55 2013 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A730FE25; Wed, 10 Apr 2013 01:22:55 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by mx1.freebsd.org (Postfix) with ESMTP id 7EF8BA32; Wed, 10 Apr 2013 01:22:55 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r3A1MsvX091249; Tue, 9 Apr 2013 21:22:54 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r3A1Msg9091245; Wed, 10 Apr 2013 01:22:54 GMT (envelope-from tinderbox@freebsd.org) Date: Wed, 10 Apr 2013 01:22:54 GMT Message-Id: <201304100122.r3A1Msg9091245@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on mips/mips Precedence: bulk X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 01:22:55 -0000 TB --- 2013-04-10 00:20:03 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-04-10 00:20:03 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-04-10 00:20:03 - starting HEAD tinderbox run for mips/mips TB --- 2013-04-10 00:20:03 - cleaning the object tree TB --- 2013-04-10 00:20:03 - /usr/local/bin/svn stat /src TB --- 2013-04-10 00:20:06 - At svn revision 249318 TB --- 2013-04-10 00:20:07 - building world TB --- 2013-04-10 00:20:07 - CROSS_BUILD_TESTING=YES TB --- 2013-04-10 00:20:07 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-10 00:20:07 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-10 00:20:07 - SRCCONF=/dev/null TB --- 2013-04-10 00:20:07 - TARGET=mips TB --- 2013-04-10 00:20:07 - TARGET_ARCH=mips TB --- 2013-04-10 00:20:07 - TZ=UTC TB --- 2013-04-10 00:20:07 - __MAKE_CONF=/dev/null TB --- 2013-04-10 00:20:07 - cd /src TB --- 2013-04-10 00:20:07 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Wed Apr 10 00:20:12 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything >>> World build completed on Wed Apr 10 01:21:21 UTC 2013 TB --- 2013-04-10 01:21:21 - cd /src/sys/mips/conf TB --- 2013-04-10 01:21:21 - /usr/sbin/config -m ADM5120 TB --- 2013-04-10 01:21:21 - skipping ADM5120 kernel TB --- 2013-04-10 01:21:21 - cd /src/sys/mips/conf TB --- 2013-04-10 01:21:21 - /usr/sbin/config -m ALCHEMY TB --- 2013-04-10 01:21:21 - skipping ALCHEMY kernel TB --- 2013-04-10 01:21:21 - cd /src/sys/mips/conf TB --- 2013-04-10 01:21:21 - /usr/sbin/config -m AP121 TB --- 2013-04-10 01:21:21 - building AP121 kernel TB --- 2013-04-10 01:21:21 - CROSS_BUILD_TESTING=YES TB --- 2013-04-10 01:21:21 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-10 01:21:21 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-10 01:21:21 - SRCCONF=/dev/null TB --- 2013-04-10 01:21:21 - TARGET=mips TB --- 2013-04-10 01:21:21 - TARGET_ARCH=mips TB --- 2013-04-10 01:21:21 - TZ=UTC TB --- 2013-04-10 01:21:21 - __MAKE_CONF=/dev/null TB --- 2013-04-10 01:21:21 - cd /src TB --- 2013-04-10 01:21:21 - /usr/bin/make -B buildkernel KERNCONF=AP121 >>> Kernel build for AP121 started on Wed Apr 10 01:21:21 UTC 2013 >>> stage 1: configuring the kernel >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything [...] /src/sys/kern/uipc_socket.c:357: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c:366: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c:366: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c: In function 'sodealloc': /src/sys/kern/uipc_socket.c:382: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c:382: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c:390: error: invalid use of undefined type 'struct so_global_mtx' /src/sys/kern/uipc_socket.c:390: error: invalid use of undefined type 'struct so_global_mtx' *** [uipc_socket.o] Error code 1 Stop in /obj/mips.mips/src/sys/AP121. *** [buildkernel] Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2013-04-10 01:22:54 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-04-10 01:22:54 - ERROR: failed to build AP121 kernel TB --- 2013-04-10 01:22:54 - 2747.77 user 650.99 system 3771.35 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-mips-mips.full From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 09:03:34 2013 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 57BB239F; Wed, 10 Apr 2013 09:03:34 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by mx1.freebsd.org (Postfix) with ESMTP id 2BB91EF5; Wed, 10 Apr 2013 09:03:34 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r3A93XK2077822; Wed, 10 Apr 2013 05:03:33 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r3A93XiY077819; Wed, 10 Apr 2013 09:03:33 GMT (envelope-from tinderbox@freebsd.org) Date: Wed, 10 Apr 2013 09:03:33 GMT Message-Id: <201304100903.r3A93XiY077819@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on mips/mips Precedence: bulk X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 09:03:34 -0000 TB --- 2013-04-10 08:00:01 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-04-10 08:00:01 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-04-10 08:00:01 - starting HEAD tinderbox run for mips/mips TB --- 2013-04-10 08:00:01 - cleaning the object tree TB --- 2013-04-10 08:00:41 - /usr/local/bin/svn stat /src TB --- 2013-04-10 08:00:44 - At svn revision 249323 TB --- 2013-04-10 08:00:45 - building world TB --- 2013-04-10 08:00:45 - CROSS_BUILD_TESTING=YES TB --- 2013-04-10 08:00:45 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-10 08:00:45 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-10 08:00:45 - SRCCONF=/dev/null TB --- 2013-04-10 08:00:45 - TARGET=mips TB --- 2013-04-10 08:00:45 - TARGET_ARCH=mips TB --- 2013-04-10 08:00:45 - TZ=UTC TB --- 2013-04-10 08:00:45 - __MAKE_CONF=/dev/null TB --- 2013-04-10 08:00:45 - cd /src TB --- 2013-04-10 08:00:45 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Wed Apr 10 08:00:49 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything >>> World build completed on Wed Apr 10 09:02:05 UTC 2013 TB --- 2013-04-10 09:02:05 - cd /src/sys/mips/conf TB --- 2013-04-10 09:02:05 - /usr/sbin/config -m ADM5120 TB --- 2013-04-10 09:02:05 - skipping ADM5120 kernel TB --- 2013-04-10 09:02:05 - cd /src/sys/mips/conf TB --- 2013-04-10 09:02:05 - /usr/sbin/config -m ALCHEMY TB --- 2013-04-10 09:02:05 - skipping ALCHEMY kernel TB --- 2013-04-10 09:02:05 - cd /src/sys/mips/conf TB --- 2013-04-10 09:02:05 - /usr/sbin/config -m AP121 TB --- 2013-04-10 09:02:05 - building AP121 kernel TB --- 2013-04-10 09:02:05 - CROSS_BUILD_TESTING=YES TB --- 2013-04-10 09:02:05 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-10 09:02:05 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-10 09:02:05 - SRCCONF=/dev/null TB --- 2013-04-10 09:02:05 - TARGET=mips TB --- 2013-04-10 09:02:05 - TARGET_ARCH=mips TB --- 2013-04-10 09:02:05 - TZ=UTC TB --- 2013-04-10 09:02:05 - __MAKE_CONF=/dev/null TB --- 2013-04-10 09:02:05 - cd /src TB --- 2013-04-10 09:02:05 - /usr/bin/make -B buildkernel KERNCONF=AP121 >>> Kernel build for AP121 started on Wed Apr 10 09:02:05 UTC 2013 >>> stage 1: configuring the kernel >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3.1: making dependencies >>> stage 3.2: building everything [...] cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_domain.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_mbuf.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_mbuf2.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_shm.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_sockbuf.c cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs -fdiagnostics-show-option -nostdinc -I. -I/src/sys -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=10000 --param large-function-growth=100000 --param max-inline-insns-single=10000 -fno-pic -mno-abicalls -G0 -DKERNLOADADDR=0x80050000 -march=mips32 -msoft-float -ffreestanding -Werror /src/sys/kern/uipc_socket.c /src/sys/kern/uipc_socket.c:243: error: conflicting types for 'accept_mtx' /src/sys/sys/socketvar.h:136: error: previous declaration of 'accept_mtx' was here *** [uipc_socket.o] Error code 1 Stop in /obj/mips.mips/src/sys/AP121. *** [buildkernel] Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2013-04-10 09:03:33 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-04-10 09:03:33 - ERROR: failed to build AP121 kernel TB --- 2013-04-10 09:03:33 - 2745.98 user 643.59 system 3812.28 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-mips-mips.full From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 14:45:56 2013 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B8D0A48C; Wed, 10 Apr 2013 14:45:56 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) by mx1.freebsd.org (Postfix) with ESMTP id 9203B2A8; Wed, 10 Apr 2013 14:45:56 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1UPwHW-0005Ar-CA; Wed, 10 Apr 2013 14:45:50 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r3AEjlD9029814; Wed, 10 Apr 2013 08:45:47 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX193Uz15yCbNoOBmo/pJouBf Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Ian Lepore To: Adrian Chadd In-Reply-To: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Wed, 10 Apr 2013 08:45:47 -0600 Message-ID: <1365605147.41399.227.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@FreeBSD.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 14:45:56 -0000 On Mon, 2013-04-08 at 11:32 -0700, Adrian Chadd wrote: > On 8 April 2013 05:33, Aleksandr Rybalko wrote: > > >> That way both can occur independently. > > > > Agree, but you forget to say about lock/unlock :) > > Yup, locking is implied. :-) > > I don't have any problem with extending the bus with this particular > method hack to allow the driver to implement an alternate read method. > > Anyone else? > > I'm happy to review a patch against -HEAD that does this: > > * add that new method, same as zrouter > * add the code to the flash driver, same as zrouter > * add spi locking in ar71xx_spi to ensure that entire transfers are > done inside a lock; > * for that copy read method, have it lock the device, put it back into > mapped mode, do the copy, put it into SPI mode, unlock the device. > > I think that should make it kick ass. > > Any takers? :) Why does this need a new method? Couldn't this be handled as a platform-specific optimized implementation of a regular transfer, after Aleksandr's pending changes that make simultaneous bi-directional transfers optional? -- Ian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 15:42:19 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 6E5B8F5F; Wed, 10 Apr 2013 15:42:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-x22a.google.com (mail-wg0-x22a.google.com [IPv6:2a00:1450:400c:c00::22a]) by mx1.freebsd.org (Postfix) with ESMTP id A92B46E1; Wed, 10 Apr 2013 15:42:18 +0000 (UTC) Received: by mail-wg0-f42.google.com with SMTP id k13so6142632wgh.3 for ; Wed, 10 Apr 2013 08:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=lZGqnAi3g8EhnRn5QMgpDLifLsBC81m0Qn+qT+h62EM=; b=Hws1yNf1Tz+EVW3L5gPRCmfhEXZ1vf4Cw1eu5FVaopgzFmP47ubV4fTT7SxRYq74Ez 0f3FbIEUkZKo9L81XReQowlSS73pn1HH6/rj69dasfeW5pipqeBbgeYWvAMAE8A0nVpA /sMs/vqnF6q9qFprAYsuzDeBFiASc74FlJNUtaazOOWOt4PoJnb5p6we/JgzKQ/tJBNV 9ks6uvboi5MbINFiJP6aW6jEaSj1JgHuhM4fZ8ImB8I0sBIrlxS5YsW24MZUUx1YlOL0 EBElTXv/GHowcXxhXMeN4OkHuhQnzi5joWYcNkWFmVZKLxjn9kXiHXJGCCPm/j53XPpI 8SOg== MIME-Version: 1.0 X-Received: by 10.180.109.197 with SMTP id hu5mr4164403wib.22.1365608537755; Wed, 10 Apr 2013 08:42:17 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Wed, 10 Apr 2013 08:42:17 -0700 (PDT) In-Reply-To: <1365605147.41399.227.camel@revolution.hippie.lan> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> Date: Wed, 10 Apr 2013 08:42:17 -0700 X-Google-Sender-Auth: P30qHwV0c-ckZ7LlCl9gclEKk9E Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 15:42:19 -0000 On 10 April 2013 07:45, Ian Lepore wrote: > Why does this need a new method? Couldn't this be handled as a > platform-specific optimized implementation of a regular transfer, after > Aleksandr's pending changes that make simultaneous bi-directional > transfers optional? Because its for a data region SPI read command, not a generic SPI command.. ? Adrian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 16:00:50 2013 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9B431538; Wed, 10 Apr 2013 16:00:50 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) by mx1.freebsd.org (Postfix) with ESMTP id 73C4A81D; Wed, 10 Apr 2013 16:00:50 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1UPxS0-000LjS-Gb; Wed, 10 Apr 2013 16:00:44 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r3AG0ggm029894; Wed, 10 Apr 2013 10:00:42 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1+tLOJaYylxB82oUhuYYSZh Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Ian Lepore To: Adrian Chadd In-Reply-To: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> Content-Type: text/plain; charset="us-ascii" Date: Wed, 10 Apr 2013 10:00:42 -0600 Message-ID: <1365609642.41399.237.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@FreeBSD.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 16:00:50 -0000 On Wed, 2013-04-10 at 08:42 -0700, Adrian Chadd wrote: > On 10 April 2013 07:45, Ian Lepore wrote: > > > Why does this need a new method? Couldn't this be handled as a > > platform-specific optimized implementation of a regular transfer, after > > Aleksandr's pending changes that make simultaneous bi-directional > > transfers optional? > > Because its for a data region SPI read command, not a generic SPI command.. ? > I don't understand how reading is not a generic spi command (presupposing the existance of the proposed changes that allow for a spi read without a concurrent write and vice versa). The patch referenced earlier in this thread changes the dev/flash/mx25l driver to make a special new spibus call. The default implementation of that call is to return failure, and only one mips platform will implement that call. But the mx25l is not a mips-specific part, what happens when I want to read from the mx25l that's in my DreamPlug box? It seems to me that the only layer at which the right decision can be made is where the low-level hardware driver can say "hey, this is a read on the chip select that's hard-wired to the spi flash part that I can do mapped reads on." Upper layers don't need to know anything about the underlying hardware or make any special calls. -- Ian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 17:21:29 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id DF44C622; Wed, 10 Apr 2013 17:21:29 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44]) by mx1.freebsd.org (Postfix) with ESMTP id 25C16B90; Wed, 10 Apr 2013 17:21:28 +0000 (UTC) Received: by mail-wg0-f44.google.com with SMTP id z11so749466wgg.23 for ; Wed, 10 Apr 2013 10:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=XSAtPrstqgW+8mmA7MKYeC6HF1uTWIXAJVRlOtP2mKI=; b=Nlvnv6fyTHqp/853ws64xtsph1SF98Sj/iyXe3it+JFdxH+b+VqZmmQB/83hAQf7MQ ggxgkQyEULRCiGIzyO7ZnQpUjSzyzH/E0XCZ5UHYCBT9K75ndxUl9sHJFcSDZH/qQAp3 FeSBNgvpBaUudbp+RXFfJZWLw50JwF/WXrHm3WJ5+D5keSIdMBQtY7mclLn2ssPUe52m mzWAU+GU6EIA88Crujt1yASdEBhcNwNuYRJGf+JPC7+ugK0Z05tlXlp/mHdEspAAaxp1 KvLlhiPJEduwppGiONRxS7Lw5QtjT0MB2HCQkao1ZSHAoDmUomhvDpEW4k0vRPPfMcqG YnJg== MIME-Version: 1.0 X-Received: by 10.180.109.197 with SMTP id hu5mr4785518wib.22.1365614487816; Wed, 10 Apr 2013 10:21:27 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Wed, 10 Apr 2013 10:21:27 -0700 (PDT) In-Reply-To: <1365609642.41399.237.camel@revolution.hippie.lan> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> Date: Wed, 10 Apr 2013 10:21:27 -0700 X-Google-Sender-Auth: X3D0OTVcdS1CJnaeWvPbUVpszjs Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 17:21:29 -0000 On 10 April 2013 09:00, Ian Lepore wrote: > I don't understand how reading is not a generic spi command > (presupposing the existance of the proposed changes that allow for a spi > read without a concurrent write and vice versa). No. Reading is an SPI method. But the SPI flash command for reading data is different than other SPI commands. The only thing we should be doing this for is SPI _flash reads_. Not SPI reads. Just data area reads from a directly attached flash chip. It's dirty or inefficient any way we do this. Either we special case spibus drivers, or we expose a SPI read / SPI write 'command' that knows it's not a generic SPI bus transaction but specifically a read-this-flash-data-from-this-offset-and-length transaction. Or some other kind of dirty hack. Adrian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 18:51:00 2013 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3167F4AF; Wed, 10 Apr 2013 18:51:00 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) by mx1.freebsd.org (Postfix) with ESMTP id 098321EF; Wed, 10 Apr 2013 18:50:59 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1UQ06k-000DgC-Bx; Wed, 10 Apr 2013 18:50:58 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r3AIouIH030047; Wed, 10 Apr 2013 12:50:56 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19f+OQ6qu22rd9vaAoy1A3d Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Ian Lepore To: Adrian Chadd In-Reply-To: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> Content-Type: text/plain; charset="us-ascii" Date: Wed, 10 Apr 2013 12:50:56 -0600 Message-ID: <1365619856.41399.242.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@FreeBSD.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 18:51:00 -0000 On Wed, 2013-04-10 at 10:21 -0700, Adrian Chadd wrote: > On 10 April 2013 09:00, Ian Lepore wrote: > > > I don't understand how reading is not a generic spi command > > (presupposing the existance of the proposed changes that allow for a spi > > read without a concurrent write and vice versa). > > No. Reading is an SPI method. But the SPI flash command for reading > data is different than other SPI commands. > > The only thing we should be doing this for is SPI _flash reads_. Not > SPI reads. Just data area reads from a directly attached flash chip. > > It's dirty or inefficient any way we do this. Either we special case > spibus drivers, or we expose a SPI read / SPI write 'command' that > knows it's not a generic SPI bus transaction but specifically a > read-this-flash-data-from-this-offset-and-length transaction. Or some > other kind of dirty hack. > Maybe something like this could work? static int ar71xx_spi_transfer(device_t dev, device_t child, struct spi_command *cmd) { if (cmd->cs == sc->magic_mapped_flash_chipsel && cmd->tx_cmd == NULL && cmd->tx_data == NULL && *(uint8_t *)cmd->rx_cmd == SPIFLASH_READ_OPCODE && /* maybe some other constraints I don't know about */ /* maybe even check that child is the mx25l driver */) return do_magic_mapped_read(...); else return do_mundane_nonmapped_transfer(...); } -- Ian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 22:07:53 2013 Return-Path: Delivered-To: freebsd-mips@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id DE82693C; Wed, 10 Apr 2013 22:07:53 +0000 (UTC) (envelope-from ray@freebsd.org) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 92C86DB0; Wed, 10 Apr 2013 22:07:53 +0000 (UTC) Received: from rnote.ddteam.net (146-209-201-46.pool.ukrtel.net [46.201.209.146]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPSA id 15663C496C; Thu, 11 Apr 2013 01:07:46 +0300 (EEST) Date: Thu, 11 Apr 2013 01:07:38 +0300 From: Aleksandr Rybalko To: Ian Lepore Subject: Re: [PATCH] MMC/SD SPI-mode driver Message-Id: <20130411010738.9a775853.ray@freebsd.org> In-Reply-To: <1365619856.41399.242.camel@revolution.hippie.lan> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> <1365619856.41399.242.camel@revolution.hippie.lan> Organization: FreeBSD.ORG X-Mailer: Sylpheed 3.1.2 (GTK+ 2.24.5; amd64-portbld-freebsd9.0) X-Operating-System: FreeBSD Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Dmytro , Aleksandr Rybalko , freebsd-mips@FreeBSD.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 22:07:53 -0000 Hi, sorry guys, I'm too late for main flame :) On Wed, 10 Apr 2013 12:50:56 -0600 Ian Lepore wrote: > On Wed, 2013-04-10 at 10:21 -0700, Adrian Chadd wrote: > > On 10 April 2013 09:00, Ian Lepore wrote: > > > > > I don't understand how reading is not a generic spi command > > > (presupposing the existance of the proposed changes that allow > > > for a spi read without a concurrent write and vice versa). > > > > No. Reading is an SPI method. But the SPI flash command for reading > > data is different than other SPI commands. > > > > The only thing we should be doing this for is SPI _flash reads_. Not > > SPI reads. Just data area reads from a directly attached flash chip. > > > > It's dirty or inefficient any way we do this. Either we special case > > spibus drivers, or we expose a SPI read / SPI write 'command' that > > knows it's not a generic SPI bus transaction but specifically a > > read-this-flash-data-from-this-offset-and-length transaction. Or > > some other kind of dirty hack. > > > > Maybe something like this could work? > > static int > ar71xx_spi_transfer(device_t dev, device_t child, struct spi_command > *cmd) { > if (cmd->cs == sc->magic_mapped_flash_chipsel && > cmd->tx_cmd == NULL && cmd->tx_data == NULL && > *(uint8_t *)cmd->rx_cmd == SPIFLASH_READ_OPCODE && > /* maybe some other constraints I don't know about */ > /* maybe even check that child is the mx25l driver */) > return do_magic_mapped_read(...); > else > return do_mundane_nonmapped_transfer(...); > } > > -- Ian > Yeah, I like that one. It's well enclose chip specific ability inside chip specific driver. I see only one problem: what we will do if some hypothetical will send command similar to SPI flash command? And theoretical, SPI flash driver allowed to ask next block of data with just empty command (tx_cmd_sz is 0), with CS hold of course. /me will not count that SPI flash can use two command for read (READ + FAST_READ). Do we able to replace one of newbus methods for single driver instance? Thanks. WBW -- Aleksandr Rybalko From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 23:22:51 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E5FE2969; Wed, 10 Apr 2013 23:22:51 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-x236.google.com (mail-we0-x236.google.com [IPv6:2a00:1450:400c:c03::236]) by mx1.freebsd.org (Postfix) with ESMTP id 2B85711B; Wed, 10 Apr 2013 23:22:51 +0000 (UTC) Received: by mail-we0-f182.google.com with SMTP id k14so802482wer.13 for ; Wed, 10 Apr 2013 16:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=3Md5WeJXTkcBEip16slf90CqBSqRfZL0L9lIuqBIgmM=; b=TD0zu7I0DyRi3uvhUOH5QytNntUq/yyaXixNzYq8KBoNnFYYd3rEScrBFACx+iPeIi f6weM/gVyXQfSUnaw7PjlR/ohm1PzQ+IuTFy+niu6oF4E+O8hi+ewm34l4AWtiS5vttH xbN4eJlyO4Nj4ej7wabses1CxlI/LXINW7pb0g3cvM6S6OUNFcZByiJ7JLJf/oaXFf7W 2mpoO0S6bi57v5XWjH5wwfNE+1VLLK4Sp559EtuemS/V7UpKNr+Fga9B9kOCMcMROZ4k B24/2gQyjI8ZkwJIJE+VLR6yPnLAkohDl9TbciVHqSSxgpTUj64EEz0G0shco794Oxg0 RWYA== MIME-Version: 1.0 X-Received: by 10.194.88.138 with SMTP id bg10mr6752300wjb.13.1365636169603; Wed, 10 Apr 2013 16:22:49 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Wed, 10 Apr 2013 16:22:49 -0700 (PDT) In-Reply-To: <1365619856.41399.242.camel@revolution.hippie.lan> References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> <1365619856.41399.242.camel@revolution.hippie.lan> Date: Wed, 10 Apr 2013 16:22:49 -0700 X-Google-Sender-Auth: gh8em2IsmuQF1lUaz5gdmCrwx5A Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Ian Lepore Content-Type: text/plain; charset=ISO-8859-1 Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@freebsd.org X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 23:22:52 -0000 On 10 April 2013 11:50, Ian Lepore wrote: > Maybe something like this could work? > > static int > ar71xx_spi_transfer(device_t dev, device_t child, struct spi_command *cmd) > { > if (cmd->cs == sc->magic_mapped_flash_chipsel && > cmd->tx_cmd == NULL && cmd->tx_data == NULL && > *(uint8_t *)cmd->rx_cmd == SPIFLASH_READ_OPCODE && > /* maybe some other constraints I don't know about */ > /* maybe even check that child is the mx25l driver */) > return do_magic_mapped_read(...); > else > return do_mundane_nonmapped_transfer(...); > } So you're special casing it in the bus code rather than the driver code. It's still ugly, but it's hid from the driver. Adrian From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 23:51:38 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id CB62E1DC for ; Wed, 10 Apr 2013 23:51:38 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-yh0-x231.google.com (mail-yh0-x231.google.com [IPv6:2607:f8b0:4002:c01::231]) by mx1.freebsd.org (Postfix) with ESMTP id 87D09231 for ; Wed, 10 Apr 2013 23:51:38 +0000 (UTC) Received: by mail-yh0-f49.google.com with SMTP id q14so168102yhf.22 for ; Wed, 10 Apr 2013 16:51:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to:x-mailer:x-gm-message-state; bh=JhbOpSbMpQXEI7rtJypkuvKftgkd4NT9Rnw7wcgKGSk=; b=DsHwWyk9SsgCCl7I6dR1aw+uG77kE/U0q/fl+LAz55rk87wjQuGqMUrFsB/1QcYpbH qEdti04WGBg7sXZ1ahGTBnCgKrSZ2vvdUHh7hLzbG7fsqbj14GQNz0ZbwQUXtsByMLhc thy4aTz3z52rVAo5ZOwW35AvcjABVRFghhB1leLcJoGWdHLbzozgjZ4K6EEJJx+GcrfK Jx9HHnLysw9g8UFvHZsN++S8shDOU8RVa5LyMWr6tQwFXXcdd6h6UhxzEUphopWMArvS MepLP3Pv7Jxw1pr7DpKLahXWp1UWYHFNSKA+T6Bdm6BhbajjbQ//cNYq7tSpRKTRiO96 QhJg== X-Received: by 10.236.28.75 with SMTP id f51mr2708547yha.4.1365637567400; Wed, 10 Apr 2013 16:46:07 -0700 (PDT) Received: from monkey-bot.int.fusionio.com ([209.117.142.2]) by mx.google.com with ESMTPS id v48sm2919051yhi.26.2013.04.10.16.46.04 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 10 Apr 2013 16:46:06 -0700 (PDT) Sender: Warner Losh Subject: Re: [PATCH] MMC/SD SPI-mode driver Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: Date: Wed, 10 Apr 2013 17:45:59 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> <1365619856.41399.242.camel@revolution.hippie.lan> To: Adrian Chadd X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQkv/obZ00cnadGUJjhO63EB/B2TSGWUsCj1EcrtmD1JjhpeSKS3xnhs7C/pqm831cymRyvb Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@freebsd.org, Ian Lepore X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 23:51:38 -0000 On Apr 10, 2013, at 5:22 PM, Adrian Chadd wrote: > On 10 April 2013 11:50, Ian Lepore wrote: >> Maybe something like this could work? >>=20 >> static int >> ar71xx_spi_transfer(device_t dev, device_t child, struct spi_command = *cmd) >> { >> if (cmd->cs =3D=3D sc->magic_mapped_flash_chipsel && >> cmd->tx_cmd =3D=3D NULL && cmd->tx_data =3D=3D NULL && >> *(uint8_t *)cmd->rx_cmd =3D=3D SPIFLASH_READ_OPCODE && >> /* maybe some other constraints I don't know about */ >> /* maybe even check that child is the mx25l driver */) >> return do_magic_mapped_read(...); >> else >> return do_mundane_nonmapped_transfer(...); >> } >=20 > So you're special casing it in the bus code rather than the driver > code. It's still ugly, but it's hid from the driver. At least in the bus code we won't have to put this code into each of our = SPI flash drivers... Warner From owner-freebsd-mips@FreeBSD.ORG Wed Apr 10 23:56:16 2013 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 702B1404; Wed, 10 Apr 2013 23:56:16 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wi0-x232.google.com (mail-wi0-x232.google.com [IPv6:2a00:1450:400c:c05::232]) by mx1.freebsd.org (Postfix) with ESMTP id A9414260; Wed, 10 Apr 2013 23:56:15 +0000 (UTC) Received: by mail-wi0-f178.google.com with SMTP id ez12so1109wid.5 for ; Wed, 10 Apr 2013 16:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=kPorltgDN2CW95HMiQOqP1eTeEPuwsAaQGIC4DBX/wY=; b=MI7l6LNLvMWyqRcdteWHDELpJg63GQAFIC+bB3FVCA7VYWBajJz7yEKEOB5bZDDjMg BzXEKby5KAxfjCPQVpmJmA7ZNdOUBA6GcCu5+ibkCHSuCAPm5OGuA3oPrtLnaoowRagf tvNDZZaFPiNGcoAl9p7JhnCFEVjmMRLpJ1xo7JJMAnCNs+fGiXZsCFiqAKJA7Qdp9zml Twc2oBvEphbUnPKmv6+jJ9BZ4FuDXmSk+PvKvUBirqJWkjo/YUPVjyVMJre+mEI/Px6/ RiErS5KiHEUNLziu4Si6hbDJDhuO3Iy4QO+Eb4kFQQUh4VS8+1Gx+JK1CNdjtGnpwSR9 s6kg== MIME-Version: 1.0 X-Received: by 10.180.38.105 with SMTP id f9mr6628550wik.15.1365638174796; Wed, 10 Apr 2013 16:56:14 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.121.136 with HTTP; Wed, 10 Apr 2013 16:56:14 -0700 (PDT) In-Reply-To: References: <20130407011307.9a9a9d64.ray@freebsd.org> <20130407022428.86a66c6a.ray@freebsd.org> <20130408153334.9cc11688aedbf32dcbf83a7b@freebsd.org> <1365605147.41399.227.camel@revolution.hippie.lan> <1365609642.41399.237.camel@revolution.hippie.lan> Date: Wed, 10 Apr 2013 16:56:14 -0700 X-Google-Sender-Auth: hFbXvF_hoTkS_AV3pYD4SyWn4uo Message-ID: Subject: Re: [PATCH] MMC/SD SPI-mode driver From: Adrian Chadd To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Cc: Aleksandr Rybalko , Dmytro , freebsd-mips@freebsd.org, Ian Lepore X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2013 23:56:16 -0000 On 10 April 2013 16:45, Warner Losh wrote: >> So you're special casing it in the bus code rather than the driver >> code. It's still ugly, but it's hid from the driver. > > At least in the bus code we won't have to put this code into each of our SPI flash drivers... *nod* I know. I'm happy with the bus doing this, as long as we do have that flag. :-) adrian From owner-freebsd-mips@FreeBSD.ORG Thu Apr 11 02:53:22 2013 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 39871E96; Thu, 11 Apr 2013 02:53:22 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by mx1.freebsd.org (Postfix) with ESMTP id DFBA39F8; Thu, 11 Apr 2013 02:53:21 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r3B2rLtT014381; Wed, 10 Apr 2013 22:53:21 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r3B2rKKX014377; Thu, 11 Apr 2013 02:53:20 GMT (envelope-from tinderbox@freebsd.org) Date: Thu, 11 Apr 2013 02:53:20 GMT Message-Id: <201304110253.r3B2rKKX014377@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on mips/mips Precedence: bulk X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 02:53:22 -0000 TB --- 2013-04-11 01:58:05 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-04-11 01:58:05 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-04-11 01:58:05 - starting HEAD tinderbox run for mips/mips TB --- 2013-04-11 01:58:05 - cleaning the object tree TB --- 2013-04-11 01:58:05 - /usr/local/bin/svn stat /src TB --- 2013-04-11 01:58:09 - At svn revision 249347 TB --- 2013-04-11 01:58:10 - building world TB --- 2013-04-11 01:58:10 - CROSS_BUILD_TESTING=YES TB --- 2013-04-11 01:58:10 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-11 01:58:10 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-11 01:58:10 - SRCCONF=/dev/null TB --- 2013-04-11 01:58:10 - TARGET=mips TB --- 2013-04-11 01:58:10 - TARGET_ARCH=mips TB --- 2013-04-11 01:58:10 - TZ=UTC TB --- 2013-04-11 01:58:10 - __MAKE_CONF=/dev/null TB --- 2013-04-11 01:58:10 - cd /src TB --- 2013-04-11 01:58:10 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Thu Apr 11 01:58:14 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything [...] gzip -cn /src/usr.bin/su/su.1 > su.1.gz ===> usr.bin/systat (all) cc -O -pipe -G0 -DINET6 -std=gnu99 -Wno-pointer-sign -c /src/usr.bin/systat/cmds.c cc -O -pipe -G0 -DINET6 -std=gnu99 -Wno-pointer-sign -c /src/usr.bin/systat/cmdtab.c In file included from /src/usr.bin/systat/extern.h:35, from /src/usr.bin/systat/cmdtab.c:39: /obj/mips.mips/src/tmp/usr/include/kvm.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'kvm_counter_u64_fetch' /obj/mips.mips/src/tmp/usr/include/kvm.h:91: error: expected declaration specifiers or '...' before 'u_long' *** [cmdtab.o] Error code 1 Stop in /src/usr.bin/systat. *** [all] Error code 1 Stop in /src/usr.bin. *** [usr.bin.all__D] Error code 1 Stop in /src. *** [everything] Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2013-04-11 02:53:20 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-04-11 02:53:20 - ERROR: failed to build world TB --- 2013-04-11 02:53:20 - 2471.66 user 527.59 system 3315.04 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-mips-mips.full From owner-freebsd-mips@FreeBSD.ORG Thu Apr 11 08:54:38 2013 Return-Path: Delivered-To: mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D13F982E; Thu, 11 Apr 2013 08:54:38 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by mx1.freebsd.org (Postfix) with ESMTP id 85B1BB59; Thu, 11 Apr 2013 08:54:38 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r3B8sbEQ053109; Thu, 11 Apr 2013 04:54:37 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r3B8sb0R053106; Thu, 11 Apr 2013 08:54:37 GMT (envelope-from tinderbox@freebsd.org) Date: Thu, 11 Apr 2013 08:54:37 GMT Message-Id: <201304110854.r3B8sb0R053106@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on mips/mips Precedence: bulk X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2013 08:54:38 -0000 TB --- 2013-04-11 07:56:39 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-04-11 07:56:39 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-04-11 07:56:39 - starting HEAD tinderbox run for mips/mips TB --- 2013-04-11 07:56:39 - cleaning the object tree TB --- 2013-04-11 07:58:17 - /usr/local/bin/svn stat /src TB --- 2013-04-11 07:58:20 - At svn revision 249351 TB --- 2013-04-11 07:58:21 - building world TB --- 2013-04-11 07:58:21 - CROSS_BUILD_TESTING=YES TB --- 2013-04-11 07:58:21 - MAKEOBJDIRPREFIX=/obj TB --- 2013-04-11 07:58:21 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-04-11 07:58:21 - SRCCONF=/dev/null TB --- 2013-04-11 07:58:21 - TARGET=mips TB --- 2013-04-11 07:58:21 - TARGET_ARCH=mips TB --- 2013-04-11 07:58:21 - TZ=UTC TB --- 2013-04-11 07:58:21 - __MAKE_CONF=/dev/null TB --- 2013-04-11 07:58:21 - cd /src TB --- 2013-04-11 07:58:21 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Thu Apr 11 07:58:25 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything [...] gzip -cn /src/usr.bin/su/su.1 > su.1.gz ===> usr.bin/systat (all) cc -O -pipe -G0 -DINET6 -std=gnu99 -Wno-pointer-sign -c /src/usr.bin/systat/cmds.c cc -O -pipe -G0 -DINET6 -std=gnu99 -Wno-pointer-sign -c /src/usr.bin/systat/cmdtab.c In file included from /src/usr.bin/systat/extern.h:35, from /src/usr.bin/systat/cmdtab.c:39: /obj/mips.mips/src/tmp/usr/include/kvm.h:81: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'kvm_counter_u64_fetch' /obj/mips.mips/src/tmp/usr/include/kvm.h:91: error: expected declaration specifiers or '...' before 'u_long' *** [cmdtab.o] Error code 1 Stop in /src/usr.bin/systat. *** [all] Error code 1 Stop in /src/usr.bin. *** [usr.bin.all__D] Error code 1 Stop in /src. *** [everything] Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2013-04-11 08:54:37 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-04-11 08:54:37 - ERROR: failed to build world TB --- 2013-04-11 08:54:37 - 2496.98 user 536.05 system 3478.55 real http://tinderbox.freebsd.org/tinderbox-head-build-HEAD-mips-mips.full