From owner-freebsd-pkg@FreeBSD.ORG  Mon Oct 21 10:56:21 2013
Return-Path: <owner-freebsd-pkg@FreeBSD.ORG>
Delivered-To: freebsd-pkg@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 080E1482;
 Mon, 21 Oct 2013 10:56:21 +0000 (UTC) (envelope-from me@janh.de)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
 [212.227.126.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9334F2D1D;
 Mon, 21 Oct 2013 10:56:20 +0000 (UTC)
Received: from pc1111.math.uni-hamburg.de (pc1111.math.uni-hamburg.de
 [134.100.220.119])
 by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis)
 id 0Mhrl9-1VLNN23gJf-00MtxM; Mon, 21 Oct 2013 12:56:12 +0200
Message-ID: <52650843.2020203@janh.de>
Date: Mon, 21 Oct 2013 12:56:03 +0200
From: Jan Henrik Sylvester <me@janh.de>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0.1
MIME-Version: 1.0
To: pkg-list freebsd <freebsd-pkg@freebsd.org>
Subject: Re: pkg shlib -R and -P swapped
References: <525541B2.5040507@janh.de>
In-Reply-To: <525541B2.5040507@janh.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:9bQZpN/j8N5CdUhUKHZSCO1D3SjDX4Js7VXK5RfpV7q
 FpHdkwk/pjMeUa1sLOW0bgLmMLypKsn5rkrApD/aGVpCf+H0Ch
 b+wrILQ7CxSRVaaitmHIT4HN/b34T7y1qjCbfyDFSUe8rdUOLn
 J6D0iGVZHGNjuvd44+MUlhiVKaCpj/yFhwuu3Sp664KSYYZfmx
 A+zAcFOFfBg78R2pJBCJeOatyzgfiWjHpuxWOZj6EO+Zx35dUK
 Pr+3sTX5pxoiGU9LRdPSCjrO011QS13+sy+tmJuqhF+zzQFHzz
 a+wkCsYKMAnOcTQZiTcb3vPgOQVNHwISZ3gsWZ9molDvk5m+E/
 lRyKn/I/7fwjsHsabZes=
Cc: Bryan Drewery <bdrewery@FreeBSD.org>
X-BeenThere: freebsd-pkg@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Binary package management and package tools discussion
 <freebsd-pkg.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pkg>
List-Post: <mailto:freebsd-pkg@freebsd.org>
List-Help: <mailto:freebsd-pkg-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-pkg>,
 <mailto:freebsd-pkg-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Oct 2013 10:56:21 -0000

On 10/09/2013 13:44, Jan Henrik Sylvester wrote:
> With pkg-1.1.4_7, "pkg shlib -P libx264.so.136" displays "libx264.so.136
> is linked to by the following packages:"...
> 
> "pkg shlib -P" should be "pkg shlib -R" and vice versa.
> 
> shlib.c has the logic backwards: "!provides_only" leads to
> "pkgs_providing_lib".
> 
> The patch attached fixes it.

bdrewery@ just told me that the patch did not make it through the list.
(It is always had to know, which lists allow attachments and which do not.)

Here is patch-pkg__shlib.c inline in hope that my email program does not
change any characters or line breaks:

--- pkg/shlib.c~	2013-07-06 12:48:19.000000000 +0200
+++ pkg/shlib.c	2013-10-09 13:28:42.000000000 +0200
@@ -175,10 +175,10 @@

 	retcode = pkgdb_open(&db, PKGDB_DEFAULT);

-	if (retcode == EPKG_OK && !provides_only)
+	if (retcode == EPKG_OK && !requires_only)
 		retcode = pkgs_providing_lib(db, libname);

-	if (retcode == EPKG_OK && !requires_only)
+	if (retcode == EPKG_OK && !provides_only)
 		retcode = pkgs_requiring_lib(db, libname);

 	if (retcode != EPKG_OK)

If this is not readable, I will put it on a webpage next time.

> Cheers,
> Jan Henrik