Date: Sun, 03 Aug 2014 00:43:26 +0000 From: bugzilla-noreply@freebsd.org To: apache@FreeBSD.org Subject: [Bug 191471] [patch] www/mod_perl2 does not build against apache24 Message-ID: <bug-191471-16115-knK2PxywGh@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-191471-16115@https.bugs.freebsd.org/bugzilla/> References: <bug-191471-16115@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191471 papowell@astart.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |papowell@astart.com --- Comment #13 from papowell@astart.com --- With respect to your patches, I went to the SVN respository http://svn.apache.org/repos/asf/perl/modperl/branches/httpd24/ downloaded this version and discovered that the patch-pre-hook already appears to be applied: The second patch, mp24-apache24.patch is interesting. +.if ${APACHE_VERSION} > 22 + ${REINPLACE_CMD} -e "s,remote_addr,client_addr,g" \ + -e "s,remote_ip,client_ip,g" \ + -e "s/'loglevel'/'log.level'/g" \ + ${WRKSRC}/xs/maps/apache2_structures.map + ${REINPLACE_CMD} -e "s,remote_addr,client_addr,g" \ + -e "s,remote_ip,client_ip,g" \ + -e "s/'loglevel'/'log.level'/g" \ + ${WRKSRC}/xs/tables/current/Apache2/StructureTable.pm +.endif This is changing the remote_addr to client_addr, remote_ip to client_ip, and loglevel to log.level. I am afraid I am not a Perl/XS wizard, so I am having a bit of a problem deciding if this is needed or has already been done in the CSV download. There already seem to be some client_addr, client_ip symbols in those files. Where does the log.level come in? Question: what changes in the API (yeah I looked at http://httpd.apache.org/docs/current/developer/new_api_2_4.html, they sure did not spare the hot sauce on this one) required these changes? -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191471-16115-knK2PxywGh>