From owner-freebsd-mobile@FreeBSD.ORG Mon Sep 22 15:42:13 2014 Return-Path: Delivered-To: freebsd-mobile@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DAEB296D for ; Mon, 22 Sep 2014 15:42:13 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C164CB72 for ; Mon, 22 Sep 2014 15:42:13 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8MFgDuL043124 for ; Mon, 22 Sep 2014 15:42:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-mobile@FreeBSD.org Subject: [Bug 193720] Adopt a new acpi_quirk from DragonflyBSD Date: Mon, 22 Sep 2014 15:42:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: freebsd-mobile@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2014 15:42:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193720 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jhb@FreeBSD.org --- Comment #3 from John Baldwin --- It's hard to verify that the fix is correct unless someone has a busted laptop it can be tested on. Note that the patch adjusts bst[i].rate after it has been added into valid_rate which seems incorrect. (I suspect it should be adjusted before, not after.) -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-mobile@FreeBSD.ORG Mon Sep 22 19:22:05 2014 Return-Path: Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C12F2D1E for ; Mon, 22 Sep 2014 19:22:05 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95448AA2 for ; Mon, 22 Sep 2014 19:22:05 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net [173.70.85.31]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 7AD78B9AE; Mon, 22 Sep 2014 15:22:04 -0400 (EDT) From: John Baldwin To: freebsd-mobile@freebsd.org Subject: Re: ThinkPad support Date: Mon, 22 Sep 2014 11:33:39 -0400 Message-ID: <7201933.PvsbptGSG2@ralph.baldwin.cx> User-Agent: KMail/4.10.5 (FreeBSD/10.0-STABLE; KDE/4.10.5; amd64; ; ) In-Reply-To: <20140917193232.K61666@sola.nimnet.asn.au> References: <20140916213835.GA4575@localhost.localdomain> <20140917193232.K61666@sola.nimnet.asn.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 22 Sep 2014 15:22:04 -0400 (EDT) Cc: isdtor , Ian Smith X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Sep 2014 19:22:05 -0000 On Wednesday, September 17, 2014 08:09:17 PM Ian Smith wrote: > On Tue, 16 Sep 2014 22:38:35 +0100, isdtor wrote: > > [.. I can't comment on your devd issue/s ..] > > > Sep 16 21:48:23 host kernel: pci0: failed to set ACPI power state D2 on > > \_SB_.PCI0.EXP1: AE_BAD_PARAMETER > > This appears to be common to all Thinkpads for the last 6 years or so, > when booting with verbose messages. This message is emitted late on the > suspend path, and seems to indicate some device that has advertised D2 > as an available state, where D2 isn't apparently really supported. > > On the resume path, not much later in the messages sequence, you should > see power being set back to D0 state, successfully. Perhaps - as in the > case of my X200 - twice in a row, for devices \_SB_.PCI0.EXP0 thru .EXP3 > > I don't know if this failure means that the device was left in D0 state > (run) or in D3 state (off) when power was removed in S3 suspend state. The kernel probably left them in D0, but I'm sure the hardware removed power in S3. > I never have been able to connect the dots between these .EXPn devices > and particular PCI devices in dmesg. So far they appear to be harmless. devinfo -v shows you ACPI namespace names for new-bus devices: % devinfo -v | grep EXP pcib1 pnpinfo vendor=0x8086 device=0x1c10 subvendor=0x17aa subdevice=0x21da class=0x060400 at slot=28 function=0 handle=\_SB_.PCI0.EXP1 pcib2 pnpinfo vendor=0x8086 device=0x1c12 subvendor=0x17aa subdevice=0x21da class=0x060400 at slot=28 function=1 handle=\_SB_.PCI0.EXP2 pcib3 pnpinfo vendor=0x8086 device=0x1c16 subvendor=0x17aa subdevice=0x21da class=0x060400 at slot=28 function=3 handle=\_SB_.PCI0.EXP4 pcib4 pnpinfo vendor=0x8086 device=0x1c18 subvendor=0x17aa subdevice=0x21da class=0x060400 at slot=28 function=4 handle=\_SB_.PCI0.EXP5 sdhci_pci0 pnpinfo vendor=0x1180 device=0xe823 subvendor=0x17aa subdevice=0x21da class=0x088001 at slot=0 function=0 handle=\_SB_.PCI0.EXP5.SLOT Certainly these root-ports do not support D2: pcib1@pci0:0:28:0: class=0x060400 card=0x21da17aa chip=0x1c108086 rev=0xb4 hdr=0x01 cap 10[40] = PCI-Express 2 root port slot max data 128(128) link x0(x1) speed 0.0(5.0) ASPM L0s/L1(L0s/L1) cap 05[80] = MSI supports 1 message cap 0d[90] = PCI Bridge card=0x21da17aa cap 01[a0] = powerspec 2 supports D0 D3 current D0 -- John Baldwin