From owner-freebsd-rc@FreeBSD.ORG Sun Sep 21 21:00:22 2014 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0844D37 for ; Sun, 21 Sep 2014 21:00:22 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A6F1E89C for ; Sun, 21 Sep 2014 21:00:22 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s8LL0MC0018907 for ; Sun, 21 Sep 2014 21:00:22 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201409212100.s8LL0MC0018907@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-rc@FreeBSD.org Subject: Problem reports for freebsd-rc@FreeBSD.org that need special attention X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Date: Sun, 21 Sep 2014 21:00:22 +0000 Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 21:00:22 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ----------------+-----------+------------------------------------------------- Patch Ready | 169047 | [rc.subr] [patch] /etc/rc.subr not checking som 1 problems total for which you should take action. From owner-freebsd-rc@FreeBSD.ORG Tue Sep 23 08:41:24 2014 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4A67366; Tue, 23 Sep 2014 08:41:24 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A6762BD; Tue, 23 Sep 2014 08:41:24 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id ey11so6837809pad.35 for ; Tue, 23 Sep 2014 01:41:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:from:content-type:message-id:date:cc :content-transfer-encoding:to; bh=pU3QLtMnzP5H44m0jiy031GDmTYPXW9x/e45wcudt+o=; b=uZhMm1hhLWsIYT1hmnAkn2NBMeV80K0j0IIQb2QkMTPQBHRHWt54kxleNrQIw23m+a IrQt02cgk+Uo8qiVtDv8WzI/NBHrliywR3+W/IHXTY78xpOjxiZPdID8WglTI1W/cOas jHrmpn3spTBaJBXxBzvcbt7w8eyUFgXtwSQKTL5pQQ/14QbCVtFz2/BCi/EOHLTU1tnr svWk/m2lAfrdZpRkddEdBFoP/UgzBG5G5aTnZZYiBB1KJLiW02h3Ual5u751/yf8X0/s 22ZaqBks6c/Ot6so4ay9cgXdzdi0Zyq140/47i3KIqgUxz0ChHGtZAl31u55EAUgmjxG 0EvA== X-Received: by 10.68.139.163 with SMTP id qz3mr32408754pbb.26.1411461683702; Tue, 23 Sep 2014 01:41:23 -0700 (PDT) Received: from [192.168.20.11] (c-98-247-240-204.hsd1.wa.comcast.net. [98.247.240.204]) by mx.google.com with ESMTPSA id yh3sm11402865pbb.38.2014.09.23.01.41.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Sep 2014 01:41:22 -0700 (PDT) Subject: [RFC] fully integrate etc/Makefile into bsd.prog.mk Mime-Version: 1.0 (1.0) From: Garrett Cooper Content-Type: text/plain; charset=us-ascii X-Mailer: iPhone Mail (11D257) Message-Id: <11E49217-8154-47AC-8D39-68256017D3A8@gmail.com> Date: Tue, 23 Sep 2014 01:41:22 -0700 Content-Transfer-Encoding: quoted-printable To: "freebsd-rc@freebsd.org" Cc: Mark Johnston , Benno Rice , "freebsd-arch@FreeBSD.org Arch" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 08:41:24 -0000 Hi all, I was wondering if anyone would have any serious objections to me conver= ting etc/Makefile . The rationale for doing this work would be to ease maint= enance/customization. Thanks! -Garrett= From owner-freebsd-rc@FreeBSD.ORG Tue Sep 23 15:15:30 2014 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0E363D98 for ; Tue, 23 Sep 2014 15:15:30 +0000 (UTC) Received: from mail-ie0-f172.google.com (mail-ie0-f172.google.com [209.85.223.172]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C6662C18 for ; Tue, 23 Sep 2014 15:15:29 +0000 (UTC) Received: by mail-ie0-f172.google.com with SMTP id rp18so7722167iec.3 for ; Tue, 23 Sep 2014 08:15:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=1G2Adxmbt9XHPLSZEK/PZZxN0W30Ab1Okd5k8tDtCts=; b=Fq26C05w1uxqWI5kh90MnLhzNgpeubiVglD84pk+f6MCfs+zkh78ZE3K52kIcIrv+H aBHuOgRZl3OBjJ3MqA65lBc2W3NAhDU42oU4gl8KfGEjoxNy2KC+WoHhrMSjj91sfNY+ 1vp1AgI1Ssj4747+gshpM09CB7kecXZYEpW5nf+KBzszVFV405Fsx4dcNKCk+DJcsr81 YqaByoZA9lmyhD8SYwDDlhvWo2ShMJJuGX9/uFEyt2qKDqu2+Vps/gRdPCqcn6T2Kq7q siJukqO2WlET8VA0lqyLjCOO0rDAeCjqmSjNwA4javUVpsCweG9YWGi07f9p6xBgf+Z4 bJhg== X-Gm-Message-State: ALoCoQmho1o10QE25VZqsSr5kjW59n7Jn/HaT7rhezJfE46C5jVBnAkZCYn8IICjaa0+9hKqtnJx X-Received: by 10.51.17.2 with SMTP id ga2mr22906282igd.12.1411484829396; Tue, 23 Sep 2014 08:07:09 -0700 (PDT) Received: from [10.1.10.70] ([50.253.99.174]) by mx.google.com with ESMTPSA id mj4sm1878187igb.2.2014.09.23.08.07.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 23 Sep 2014 08:07:08 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_75473453-65BF-4882-BBE0-56A8BBD4C51A"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [RFC] fully integrate etc/Makefile into bsd.prog.mk From: Warner Losh In-Reply-To: <11E49217-8154-47AC-8D39-68256017D3A8@gmail.com> Date: Tue, 23 Sep 2014 09:07:06 -0600 Message-Id: <0A216B9F-3437-461E-A52A-032F6B86B5F2@bsdimp.com> References: <11E49217-8154-47AC-8D39-68256017D3A8@gmail.com> To: Garrett Cooper X-Mailer: Apple Mail (2.1878.6) Cc: Mark Johnston , "freebsd-rc@freebsd.org" , Benno Rice , "freebsd-arch@FreeBSD.org Arch" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 15:15:30 -0000 --Apple-Mail=_75473453-65BF-4882-BBE0-56A8BBD4C51A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Sep 23, 2014, at 2:41 AM, Garrett Cooper = wrote: > Hi all, > I was wondering if anyone would have any serious objections to me = converting etc/Makefile . The rationale for doing this work would be to = ease maintenance/customization. Converting it from what to what? Warner --Apple-Mail=_75473453-65BF-4882-BBE0-56A8BBD4C51A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJUIYyaAAoJEGwc0Sh9sBEANG0P/Rsawvcj41cbDFWb8MuoPEcK Rv92qOEsEoD4CJuJ268f4YQi7eXRVY+RAchYM0vDRg9J+ne3jqYteJOqHoO36quF ZnfA3fD9eC9n+iQ+UOetfdW8Y0l03Jtq/BliVycxWAc7P1STmU7xA6ZpQJGp8q1v hKd7Gd+1wCOCfi3FyR5GbD+KETXKGRY6LEicvcrLY+wCfKZLyiLucAdG2uIwIYY4 0yWsCELP4C8TfrhbXTWu1Yd/fKr5NHMNMTW3p6bAsL53SloSbBoEEAxTtLLwmsf9 uPw/ZMi4RLqwsusPOetYpOdxDOG+rPzLIAGnfuI9v/jms5B3kP6evq5xwdxLl6ky IITMb/U1iUalwMwTsgAWSTVKp+mxSdBu5prqYm0QXmQMiqWrI5qjRzmp9wb5OqvB NNhGjleXcnbja/I4uN/7Z4XIHQdfkrG9YIGTNQAlwBqLHSpZS7IO/J0rqc2xU1YF g2LnDMKWxSlFxj5sT+ZBFrdE22EPPXAxtQ0b+RsBLU+MBk9jMvRP+0hrLTlyx7n+ HyAJ6LLJMspES2ldDdbOlyLbPagAP7/AHNJRe+TkpaDKDYUaecO9N0TKpdcUWTN3 iMgdoTClf+QPZTKpqH3ve6k+kvpjjthJTDllB+Q68hINdIdMYkfoS/6+v8IKMmeK u43+Mxq+wejK+7QEZV6h =ezXq -----END PGP SIGNATURE----- --Apple-Mail=_75473453-65BF-4882-BBE0-56A8BBD4C51A-- From owner-freebsd-rc@FreeBSD.ORG Tue Sep 23 22:01:04 2014 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88E17FA4; Tue, 23 Sep 2014 22:01:04 +0000 (UTC) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 365F5F76; Tue, 23 Sep 2014 22:01:04 +0000 (UTC) Received: by mail-ig0-f171.google.com with SMTP id hn15so5450947igb.16 for ; Tue, 23 Sep 2014 15:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=lcgRhTcQ+QYFMaJQoN14jE4xo/+Rpllm4CRzneWYDlo=; b=HAFWsWiZbrFy5Zzrf3Jai+Nfk/40mOaqEIbgafHguCQ8COFhIdK6mXrseii17uz9t3 NGxYxi601VT0gFzyUY1PEz1axYvBBi32/0389GewJSgls94GXBJQ0RakdBHZ02yCsI4U Z7xcj4OcqnMpQr6s4f+CszAz6Br/T3gBruZ/kLTF455X6CkkKm7f+jVtdhVJOEgUCahU u+q7yRwbcx3e6QV9xI1fKv/kB2HBByI5JUaRGXoh6hSPp/I/dHfDzaYIY0/0zUntbLZt 7xijI2AbJN25H1gyzhkAAxn8q3RXNXXOu+cIE8j6cHKEn9qQoDUW9rjQ19ep0HdX4ogz FueQ== MIME-Version: 1.0 X-Received: by 10.42.63.129 with SMTP id c1mr3805530ici.82.1411509663565; Tue, 23 Sep 2014 15:01:03 -0700 (PDT) Received: by 10.50.72.69 with HTTP; Tue, 23 Sep 2014 15:01:03 -0700 (PDT) In-Reply-To: <0A216B9F-3437-461E-A52A-032F6B86B5F2@bsdimp.com> References: <11E49217-8154-47AC-8D39-68256017D3A8@gmail.com> <0A216B9F-3437-461E-A52A-032F6B86B5F2@bsdimp.com> Date: Tue, 23 Sep 2014 15:01:03 -0700 Message-ID: Subject: Re: [RFC] fully integrate etc/Makefile into bsd.prog.mk From: NGie Cooper To: Warner Losh Content-Type: text/plain; charset=UTF-8 Cc: Mark Johnston , "freebsd-rc@freebsd.org" , Benno Rice , "freebsd-arch@FreeBSD.org Arch" X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 22:01:04 -0000 On Tue, Sep 23, 2014 at 8:07 AM, Warner Losh wrote: > > On Sep 23, 2014, at 2:41 AM, Garrett Cooper wrote: > >> Hi all, >> I was wondering if anyone would have any serious objections to me converting etc/Makefile . The rationale for doing this work would be to ease maintenance/customization. > > Converting it from what to what? Looking at etc/Makefile , there are a lot of "custom" targets/ad hoc install rules for installing things like kerberos, openssh, sendmail, etc, in the distribution target: 259 .if ${MK_SENDMAIL} != "no" 260 ${_+_}cd ${.CURDIR}/sendmail; ${MAKE} distribution 261 .endif 262 .if ${MK_OPENSSH} != "no" 263 cd ${.CURDIR}; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 264 ${SSH} ${DESTDIR}/etc/ssh 265 .endif 266 .if ${MK_OPENSSL} != "no" 267 cd ${.CURDIR}; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 268 ${SSL} ${DESTDIR}/etc/ssl 269 .endif 270 .if ${MK_KERBEROS} != "no" 271 cd ${.CURDIR}/root; \ 272 ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 273 dot.k5login ${DESTDIR}/root/.k5login; 274 .endif 275 cd ${.CURDIR}/root; \ 276 ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 277 dot.profile ${DESTDIR}/root/.profile; \ 278 rm -f ${DESTDIR}/.profile; \ 279 ln ${DESTDIR}/root/.profile ${DESTDIR}/.profile 280 .if ${MK_TCSH} != "no" 281 cd ${.CURDIR}/root; \ 282 ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 283 dot.cshrc ${DESTDIR}/root/.cshrc; \ 284 ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 644 \ 285 dot.login ${DESTDIR}/root/.login; \ 286 rm -f ${DESTDIR}/.cshrc; \ 287 ln ${DESTDIR}/root/.cshrc ${DESTDIR}/.cshrc 288 .endif 289 cd ${.CURDIR}/mtree; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 444 \ 290 ${MTREE} ${DESTDIR}/etc/mtree 291 .if ${MK_PPP} != "no" 292 cd ${.CURDIR}/ppp; ${INSTALL} -o ${BINOWN} -g ${BINGRP} -m 600 \ 293 ${PPPCNF} ${DESTDIR}/etc/ppp 294 .endif 1. Some of these items can be easily pushed into SUBDIRs with an appropriate knob to say "I am running make distribution", as they leverage the system Makefiles. Having a cleaner layout would improve maintenance and make the code clearer to follow and it encourages others to not make a mess because it would follow patterns throughout other portions of the tree. 2. Some of these pieces should be placed under knobs because they aren't needed in all configurations. 3. Using variables to specify the install files will allow people/organizations customizing FreeBSD to better leverage make logic and variables (say via custom make.conf/src.conf hooks) to avoid installing the entire "make distribution" kitchensink with ${BIN1:N*firewall*}, etc. The Isilon etc/Makefile for instance is convoluted, in part because of 2. and in part because we have dropped things into /etc/ in non-standard ways in the past. The three observations above are separate items and somewhat orthogonal/parallel to the work being discussed above (maybe I should have titled the thread "cleaning up the etc/Makefile kitchensink", but I was trying to be less bikesheddy). Thanks, -Garrett