From owner-freebsd-arch@FreeBSD.ORG Mon Mar 16 10:29:05 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A83C2C0B; Mon, 16 Mar 2015 10:29:05 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 12B1D787; Mon, 16 Mar 2015 10:29:04 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t2GA5w3m049360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 16 Mar 2015 13:05:58 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t2GA5vM2049359; Mon, 16 Mar 2015 13:05:57 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 16 Mar 2015 13:05:57 +0300 From: Gleb Smirnoff To: John Baldwin Subject: Re: Adding new media types to if_media.h Message-ID: <20150316100557.GS17947@glebius.int.ru> References: <20150226230031.GN17947@glebius.int.ru> <1919032.aFEK3un8ig@ralph.baldwin.cx> <5501ABCA.7020203@selasky.org> <1740987.7L4GidWlzm@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1740987.7L4GidWlzm@ralph.baldwin.cx> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Hans Petter Selasky , Adrian Chadd , mike@karels.net, "freebsd-net@freebsd.org" , Jack Vogel , freebsd-arch@freebsd.org, Eric Joyner X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 10:29:05 -0000 On Thu, Mar 12, 2015 at 12:01:13PM -0400, John Baldwin wrote: J> On Thursday, March 12, 2015 04:07:54 PM Hans Petter Selasky wrote: J> > On 02/28/15 13:28, John Baldwin wrote: J> > > On Friday, February 27, 2015 10:23:10 PM Gleb Smirnoff wrote: J> > >> On Thu, Feb 26, 2015 at 08:25:59PM -0800, Adrian Chadd wrote: J> > >> A> [snip] J> > >> A> J> > >> A> I think Mike's approach is good - it makes it easy to MFC to 10.2 J> > >> A> since there's extended lifecycle stuff to do there - and then we can J> > >> A> plan out how do the "betterer" fix after it's landed and churned J> > >> A> things. J> > >> J> > >> ... and we will be ought to support the "betterer" fix along with J> > >> the "not so betterer" for a very long time. J> > >> J> > >> The rock on which we split in this argument is that some developers J> > >> write their code for stable/x and then forward-port it to head, J> > >> focused on quality of result for stable/x; while other developers J> > >> do the opposite: write code to head, then consider or not consider J> > >> merging it stable/x. J> > > J> > > No, this is not quite true. Some folks have to write drivers on HEAD but also J> > > support running those drivers on older branches. The MFC's get harder when J> > > you have very different APIs on the different branches. It's already harder J> > > to test stat changes now since it requires completely different patches for J> > > <= 10 (the only thing people are supposed to use in production) vs head due to J> > > if_getcounter() and friends. Also, since 11 won't be out until 2016, that is J> > > far, far too long to wait for more media types. The stuff we need to support J> > > is already shipping in products today. We can't not support these in 10 (and J> > > possibly 9). J> > > J> > J> > Any news on this issue? Is anyone working on a solution for -head ? J> J> I believe a variant of Mike's patch is in phabricator now? There is also my patch in phab: https://reviews.freebsd.org/D2008 Mike already gave feedback on it, but I didn'y yet respond. -- Totus tuus, Glebius. From owner-freebsd-arch@FreeBSD.ORG Mon Mar 16 18:14:31 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFDE2302 for ; Mon, 16 Mar 2015 18:14:31 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2A252C0B for ; Mon, 16 Mar 2015 18:14:31 +0000 (UTC) Received: by wgbcc7 with SMTP id cc7so46790340wgb.0 for ; Mon, 16 Mar 2015 11:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:reply-to:from:to:subject:date:mime-version:content-type :content-transfer-encoding; bh=+lNeyUHPKMLjt35dgFvCu2QceP2WlKVBGrl5LNiw1nA=; b=YnX4VvjOy+rYprxFLdei9Z0OgGsOdpxTZMixnz24bahOY6oQ/v2ZVoAGH9fivQxQN3 XZEp6ckotzP0gD8qHmywPocgoQu+1GDzpEQ+Fpwd/RzW1gNXBL4r6Xqcnjp1L9yoovQy b5F7wIPeWALpS+UYEDC3uVekh8qXMHvD5q4GKKINSiVycDQ1wElQYiOmW2R7paGh29kd j/g6p3pcYxCkA09qlXkSD8Wvw8NhtQqNdNyt9HDu0wVlYXwQJ6ayj4PvJjU7BPQzjfge 8JdJLwbcr/VNll4u2W1c+HabFwX7d9ujzb74D4qVugW5H9QctuheESlvQNIj7uLP5OSi 1/3w== X-Received: by 10.180.198.110 with SMTP id jb14mr123688023wic.57.1426529669515; Mon, 16 Mar 2015 11:14:29 -0700 (PDT) Received: from almani ([5.222.59.233]) by mx.google.com with ESMTPSA id ax10sm16449670wjc.26.2015.03.16.11.14.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 16 Mar 2015 11:14:26 -0700 (PDT) Message-ID: <017301d3-42079-01539058364005@almani> Reply-To: "Global Researchers Journals" From: "Global Researchers Journals" To: freebsd-arch@freebsd.org Subject: Call for Paper {March 2015 | Vol 05-Issue 03} Date: Mon, 16 Mar 2015 21:44:26 +0330 X-Priority: 3 MIME-Version: 1.0 Content-Type: text/plain X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 18:14:31 -0000 Call for Paper Dear Colleagues You are cordially invited to submit or recommend papers to: [1]http://www.grjournals.com (March 2015 (Volume 05 | Issue 03) Journal of Physiology and Pharmacology Advances (JPPA) [2]http://grjournals.com/Default.aspx?tabid=6537 · Journal of Animal Production Advances (JAPA) [3]http://grjournals.com/Default.aspx?tabid=6538 Journal of Animal Science Advances (JASA) [4]http://grjournals.com/Default.aspx?tabid=6401 Journal of Veterinary Advances (JVA) [5]http://grjournals.com/Default.aspx?tabid=6536 Journal of Recent Advances in Agriculture (JRAA) [6]http://grjournals.com/Default.aspx?tabid=6878 Global Researchers Journals, a fast track peer-reviewed and open access academic journal published by Grjournals Publishing, which is one of the largest open access journal publishers around the world Grjournals is using online article submission, review and tracking system for quality and quick review processing. Journal provides rapid publication of research article. After 30 days Rapid Review Process by the editorial/review board members or outside experts, an accepted paper will be placed under In Press within 24 hours and will be published in the next issue. Instructions for authors are available on our website: [7]http://www.grjournals.com Submitted papers must follow the Instructions to authors to be considered for review and publication. Refereeing of manuscripts is conducted anonymously and the identity of the referees is not disclosed. The manuscripts which get an acceptance will publish with DOI number. Your Manuscript(s) can be one of these kinds: Review, Original Article, Case Report, Short Communications, Technical Notes, Mini Review Article and Hypothesis. Some of Abstracted/Index in: CAB reviews, Chemical Abstract Service (CAS), Genamics JournalSeek, Index Directory of Open Access Journals (DOAJ), Index Electronic Journals Library SCIRUS, ISC and the World most Popular University and Electronic Library. [8]http://grjournals.com/Default.aspx?tabid=732 9 Now you can clear the clutter by accessing your favorite journals online: Full text, full archive that's always there when you need it Easy access anywhere, anytime and anyhow · Impact your practice, not the environment NOTICE: Authors that cite [9]www.grjournals.com manuscripts as reference in their ISI articles, they can send their manuscripts to one of above journals as FREE of charge. After evaluation and get an acceptance it will publish without any Article Processing Fee with DOI. .We apologize if you have received this email twice, or our journal is not your field With Warm Regards ,Sincerely Grjournals Team Site: [10]www.grjournals.com E_Mail: [11]grjournals@gmail.com References 1. http://www.grjournals.com/ 2. http://grjournals.com/Default.aspx?tabid=6537 3. http://grjournals.com/Default.aspx?tabid=6538 4. http://grjournals.com/Default.aspx?tabid=6401 5. http://grjournals.com/Default.aspx?tabid=6536 6. http://grjournals.com/Default.aspx?tabid=6878 7. http://www.grjournals.com/ 8. http://grjournals.com/Default.aspx?tabid=7329 9. http://www.grjournals.com/ 10. http://www.grjournals.com/ 11. mailto:grjournals@gmail.com From owner-freebsd-arch@FreeBSD.ORG Mon Mar 16 21:04:01 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5DF898B4 for ; Mon, 16 Mar 2015 21:04:01 +0000 (UTC) Received: from mail.techlistingz.com (mail.techlistingz.com [60.243.245.61]) by mx1.freebsd.org (Postfix) with ESMTP id B7286786 for ; Mon, 16 Mar 2015 21:04:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.techlistingz.com (Postfix) with ESMTP id EE6201A91884 for ; Mon, 16 Mar 2015 23:41:35 +0530 (IST) Received: from mail.techlistingz.com ([127.0.0.1]) by localhost (mail.localdomain [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7l+fPTwLu9dT for ; Mon, 16 Mar 2015 23:41:35 +0530 (IST) Received: from WSA41 (unknown [125.99.249.7]) by mail.techlistingz.com (Postfix) with ESMTPSA id 2D6AC1A81B07 for ; Mon, 16 Mar 2015 23:41:34 +0530 (IST) From: "Jennifer Matthews" To: Subject: Hitachi Users Date: Mon, 16 Mar 2015 23:36:55 +0530 Message-ID: MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-Language: en-us Thread-Index: AdBgE/yDn/tY16zHSUCzptbaj8DQGg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2015 21:04:01 -0000 Hi, Greetings, Would you be interested to reach out to your target market for your Marketing Initiatives like Email Marketing, Tele Marketing, Direct Mailing and Fax Campaigns? We have 80 Million contacts for all industry in our master database for North America, Europe, Asia, Australia and Middle East. All the contacts include opt-in or permission based Emails, Phone numbers and direct mailing addresses. The contacts are provided for your perpetual use with complete usage license. Title Reach in these lists:- . C-level executives- CEO, CFO, COO, CPO, CIO, CTO, . VP- level- Exec VP, VP/Asst VP . D Level Titles . Multi Executive . Board Members . Vendor/Supplier Technology/Software Lists: Oracle, Cisco, Hitachi, ARM, SAP, Microsoft, IBM, PeopleSoft, JD Edwards, Citrix, Sales force, CRM, ERP, Mobile apps, cloud applications and other software application users etc. Healthcare/Dental Lists: GP, Family Practitioner, Health Institutions, Bio-Technology, Pharmaceuticals, Medical Supplies/Medical Device Manufacturers, etc. Kindly fill your industrial requirements below,if you are interested in our service. Industry : _________ (Any Industry); Geography : _________ (All Over The World); Job Title : __________ (CEO, CFO, CTO, VP/Director, etc..); Let me know your interest, so that I can send you few sample data for your reference. Or let me know a convenient time to schedule for a quick call to discuss further. Thank you and I look forward to hear from you. Jennifer Matthews, Online Marketing Manager. From owner-freebsd-arch@FreeBSD.ORG Wed Mar 18 20:57:59 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BC4E93CB; Wed, 18 Mar 2015 20:57:59 +0000 (UTC) Received: from mail-ie0-x235.google.com (mail-ie0-x235.google.com [IPv6:2607:f8b0:4001:c03::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 83A08A2D; Wed, 18 Mar 2015 20:57:59 +0000 (UTC) Received: by iegc3 with SMTP id c3so49939330ieg.3; Wed, 18 Mar 2015 13:57:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=Ia1N5MFcFNMrIzL7i2KgVoi8va/CxbGU8AtEv4aliR4=; b=PfM0urc/+qOk46A3LTaZd8KDcZvSGhqgNqi2qL7z8tSdORE2ewUleVVo9eiMxYG87t oW0TL73pmrMeWX21dbKOfpWvtSAqZR14PJY3HEEiANHmv5dJ2FgAUVObxepsNVh+nD7g M1aSY3rvn8bQOMZBmxAwO887tJxwYXC/bHaAVZO16188DMEju1DaFeBJkbGEBZL3LfbN /t0q6QTdjbIW+Bw97RsCBjn030iiIoW/7BvvO8Y7rP1jRvS71aPUVHXMQ3fndz4mwL4y +WwJc4nwshDbYSPqCQBvyyazBAB+gn0rnfXVGO/3EaIlMJiIIpK/W8Bb+Un2ULIfhMy4 k4QQ== MIME-Version: 1.0 X-Received: by 10.50.43.201 with SMTP id y9mr10642372igl.6.1426712278878; Wed, 18 Mar 2015 13:57:58 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Wed, 18 Mar 2015 13:57:58 -0700 (PDT) Date: Wed, 18 Mar 2015 13:57:58 -0700 X-Google-Sender-Auth: WJWsGTk-ZZnWpL6Gj9l95rWNTto Message-ID: Subject: RFT: break out IPv4 fragment reassembly locking into per-bucket locks From: Adrian Chadd To: "freebsd-arch@freebsd.org" , FreeBSD Net Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 20:57:59 -0000 Hi, I've created a review for this: https://reviews.freebsd.org/D2095 It does a couple things: * The IPv4 reassembly locking is now per-bucket, rather than global * If space needs to be made, it's made /after/ the reassembly queue manipulation is done. This way it's done without the queue lock held, rather than trying to grab a lock for bucket X whilst doing work in bucket Y. This dramatically reduces the lock contention when doing IPv4 fragment reassembly. I'd prefer this to be done along RSS bucket lines so there's /no/ lock contention during RSS based IPv4 fragment reassembly, but this is a good first step and applies even if RSS isn't being done. I'd appreciate any testing/reviews people may have. Thanks, -adrian From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 15:43:23 2015 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 27249B28; Thu, 19 Mar 2015 15:43:23 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A38F728A; Thu, 19 Mar 2015 15:43:18 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t2JFh9Kq072445 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 19 Mar 2015 18:43:09 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t2JFh9RM072444; Thu, 19 Mar 2015 18:43:09 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 19 Mar 2015 18:43:09 +0300 From: Gleb Smirnoff To: net@FreeBSD.org, arch@FreeBSD.org Subject: opaque ifnet progress Message-ID: <20150319154309.GT64665@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 15:43:23 -0000 Hi! It is already several years as the "opaque ifnet" has been discussed, and almost a year since it was announced to be worked on. For now I've got a branch in svn, where some proof of concept is done: http://svn.freebsd.org/base/projects/ifnet I've described what's going on in wiki: https://wiki.freebsd.org/projects/ifnet If you are writing/maintaining a NIC driver, you must look there and share your opinion with me. You should also look at already converted drivers and again share your opinion. At current stage I need feeling of approvement and agreement from people who write drivers, since being on my own I don't feel confident that I am doing things right. So, please look at wiki and code! P.S. Of course job of converting all drivers to new KPI is extremely heavy lifting, so any help with the project if very much appreciated. -- Totus tuus, Glebius. From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 18:53:43 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34FAB7CB for ; Thu, 19 Mar 2015 18:53:43 +0000 (UTC) Received: from mail-ig0-x22c.google.com (mail-ig0-x22c.google.com [IPv6:2607:f8b0:4001:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F0C043F8 for ; Thu, 19 Mar 2015 18:53:42 +0000 (UTC) Received: by igbqf9 with SMTP id qf9so32071775igb.1 for ; Thu, 19 Mar 2015 11:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=aIt8vvr1KvhSTDmalN8IyJwF9RIjIbxLYE0fcILe8P8=; b=EptETewMNhF+RK6sopLPE1LynMaxvZmK15GCM9qAcL9wrsDvKkujHt5zrDNsQffMcT 6oMQ6Dv2KRo3n4cpwQUwCfe6vaOQikg+KM1NnbFczgKqGUAF+HvScAHgN4VQQaYPNQk6 o4wd2tqR2ePCl2y8e0ffY73Uw+WbS+szqM27FeizJZyfHNXWYSgBNSbTFVyJpqVC4Y15 kEeVduZcY+nBTjdu/bQ0UT3ZbfIyuDITJsUVeQ8YMjevBlveYZBda/AYsXbpoQioWxYY VZsR/T91kGdTKFFmnLwW51PWBAx3T7FFOiBO0nrT9RykL7iyovMM4EvFT72Sb0JwpmaI bfHQ== MIME-Version: 1.0 X-Received: by 10.107.136.206 with SMTP id s75mr105173838ioi.8.1426791222354; Thu, 19 Mar 2015 11:53:42 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Thu, 19 Mar 2015 11:53:42 -0700 (PDT) Date: Thu, 19 Mar 2015 11:53:42 -0700 X-Google-Sender-Auth: AQDXdg-vQNrh6lKHkmmSq0WeJH4 Message-ID: Subject: ASLR work into -HEAD ? From: Adrian Chadd To: "freebsd-arch@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 18:53:43 -0000 Hi, Apparently this is done but has stalled: https://reviews.freebsd.org/D473 Does anyone have any strong objections to it landing in the tree as-is? -adrian From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 20:04:59 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 48E17654 for ; Thu, 19 Mar 2015 20:04:59 +0000 (UTC) Received: from mail-ig0-x231.google.com (mail-ig0-x231.google.com [IPv6:2607:f8b0:4001:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C395FBF for ; Thu, 19 Mar 2015 20:04:59 +0000 (UTC) Received: by igbud6 with SMTP id ud6so35307328igb.1 for ; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=SLb6lR+ADYVkohz51RTjmkxFNPzf5V0EDhYZHK41+rc=; b=DUYT6+u1/bVAgEA/fUEQpcoKx4gp/VuofujI6dGpVaaImkAoLFdnvRtDYwxE+x+Y88 11hnbguDk6B365Yk0+Dahk9uAEM8Sqa/1/tGvpGpSg9fiPzsRv5QYUNDnOE6Ad5TVJGM 6uWa7IAtHZiZ1c+iJyS19g6BHyz7KhKFpe9JqH3vouVPZw+4ijVH1ulqD4BxWrnVnBIi 5RwGajc2R2CDG5pMA6GhQAg16BRHWz/7bYZGM9nUSNQOgSO0sUTGLTI2dzx3IVhktxT8 8y6eoUJOQiqjPvz7FFVr7WqIMtOnEMvjB8anzm12Vrjlk6UV0BLZ7ffSYzArI25o5UhX cdrw== MIME-Version: 1.0 X-Received: by 10.50.36.65 with SMTP id o1mr19704703igj.32.1426795498383; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Thu, 19 Mar 2015 13:04:58 -0700 (PDT) In-Reply-To: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> Date: Thu, 19 Mar 2015 13:04:58 -0700 X-Google-Sender-Auth: aZw9uptOYlImjtP6kjcS11AKlmA Message-ID: Subject: Re: ASLR work into -HEAD ? From: Adrian Chadd To: Warner Losh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 20:04:59 -0000 On 19 March 2015 at 12:56, Warner Losh wrote: > >> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrote: >> >> Hi, >> >> Apparently this is done but has stalled: >> >> https://reviews.freebsd.org/D473 >> >> Does anyone have any strong objections to it landing in the tree as-is? > > There=E2=80=99s rather a lot of them specifically spelled out in the code= review. > > Many of the earlier ones were kinda blown off, so I=E2=80=99ve not been i= nclined > to take the time to re-review it. Glancing at it, I see several minor iss= ues > that should be cleaned up. Cool. Thanks for taking the time to look at it again. Shawn is in #freebsd on freenode irc, so if you/others want a more interactive review then he's there during the day. -a From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 20:28:25 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C5A90D74 for ; Thu, 19 Mar 2015 20:28:25 +0000 (UTC) Received: from mail-pd0-f171.google.com (mail-pd0-f171.google.com [209.85.192.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 91BDD26F for ; Thu, 19 Mar 2015 20:28:25 +0000 (UTC) Received: by pdnc3 with SMTP id c3so86405642pdn.0 for ; Thu, 19 Mar 2015 13:28:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=vZ+sM2TD5frH8rT6Ru2yYqhcoeQBYz4KiKCdHCa1j0c=; b=EoiIkvGx2m9Z2YCZ3RzIov8Owi66FpHxPUUBj3uug94YeoQoul2EbyjJwT3PwbjooF lo3VdZZdd+8Uv/2ikk4gGyUU6P1vhg2+eMjoWJc/FJW2x70lPJk68EFHLvU8dLxuLPTI HSrpED350WTeBZn2KL/WUMwDmZfHeAC8BbztmwIZ/Q+wLit37ZSt+/WAngVTA7kBGamY aNuOQ9oRgjsKX4qnc3FVavTXbD+q5G8JhpviU0egP0zRVS4cxY9f+qNBxreS5oqyoLQO ze58PaEQlYfkEJnL2yvSuQj8BslfGGjZeW5Ch11fljawfPVP6Z/8JNg99W4vGrS/TZQE lt4A== X-Gm-Message-State: ALoCoQmRe1Ke2zOZqfvnGJBWmIilSED1oaZjMafaLn7m91qwJcUKXEMnRNhyNB922t5r2zEQNc70 X-Received: by 10.66.234.2 with SMTP id ua2mr157125550pac.137.1426795016141; Thu, 19 Mar 2015 12:56:56 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id fl4sm4437686pab.8.2015.03.19.12.56.54 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Mar 2015 12:56:55 -0700 (PDT) Sender: Warner Losh Subject: Re: ASLR work into -HEAD ? Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_4E5FE1D9-DC77-4B9A-8F96-D1466726B2FD"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b5 From: Warner Losh In-Reply-To: Date: Thu, 19 Mar 2015 13:56:50 -0600 Message-Id: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> References: To: Adrian Chadd X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 20:28:26 -0000 --Apple-Mail=_4E5FE1D9-DC77-4B9A-8F96-D1466726B2FD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrote: >=20 > Hi, >=20 > Apparently this is done but has stalled: >=20 > https://reviews.freebsd.org/D473 >=20 > Does anyone have any strong objections to it landing in the tree = as-is? There=E2=80=99s rather a lot of them specifically spelled out in the = code review. Many of the earlier ones were kinda blown off, so I=E2=80=99ve not been = inclined to take the time to re-review it. Glancing at it, I see several minor = issues that should be cleaned up. Warner --Apple-Mail=_4E5FE1D9-DC77-4B9A-8F96-D1466726B2FD Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVCyoDAAoJEGwc0Sh9sBEAhGkQAJOwEY39IZb+liQVE/6l3B2b 3yLWojSR2HibrF6EA7fhXq+nDahlQwvG2qZexTw0GovQQ05/BW5qbBs3UowbeWKt MOleDa/AwNZs2wUaTlak+2xodI3We+QcApyZjOgOWPsVbfWeZOhdUK63Kiz9PD0J 6UQQEjG+HtpRByHmGsiJ8S1g9T6skz79fPfuqL/p6yDS1GMYWMF30P+Qf14UWCaP fkTkM8rx8GhUc35pL+FMqnV+DIoYqt6A1OVbs1H09Pcdrh4z1xefy4xNgXMQ9oXD 11g0Lbk3XNDSPBHYObNoUYvpdcU6l9lcygyOItrD1f9EAQ6qez9RFgOMLatI20Ru TcUQNHVDmLFd3OdMdLGAoWx9cbqqFkYgV5yOYT5M85BggkIQ1CfQgWCJAGByypk4 oUX9Bjg2/HjSNyQo9IReU4ZanTJ0yjOEN/bXIMv1ZiK7Vy93BHLn6qdQFo/I3ulc ZHcJBmZFYK41uFzz2n33MOz9mdjDHJXYV0IFC2ZHUe21edPH62YtxxQktxk3Xovv tVPNugLV7fgbE+IJygmjCuv8uCVd/jnwEccGLJeyIRal0+68fr0Hj8cDBrtLUJjI 1+CanqCN6xvEwGiXe7Jjgaw44INeEwDylYPxaOf5N4gvD6sAbNw2kp5SU7EiHPY1 7tPeSqtgwPGVc9/giPYq =9S0v -----END PGP SIGNATURE----- --Apple-Mail=_4E5FE1D9-DC77-4B9A-8F96-D1466726B2FD-- From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 20:36:37 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F11C21B9 for ; Thu, 19 Mar 2015 20:36:37 +0000 (UTC) Received: from mail-yk0-f169.google.com (mail-yk0-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B758C383 for ; Thu, 19 Mar 2015 20:36:37 +0000 (UTC) Received: by ykfs63 with SMTP id s63so32966801ykf.2 for ; Thu, 19 Mar 2015 13:36:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/eD6oUUR1f0EOGeMjuhxvjjR2RQsH8iKb6G+ZOLRebU=; b=Dilr2pmHHEFUUS4mCxxWjH4SXyGZh0a90AjaPYX5tf7j1uj223zMNB27+5aTjiZ4OH TyWXey6f4CaH9R68PUhcknMIZqOusHMcPqL72LLU2nrxtMQraXAlfPatcaegG4gOHGQX f9U10OW1oTVCVPAa4+ynbt1hnrslJoCz9G+ciB6L9n8Io4+PnnbVvozYSjeQaQMpgnaP kmGVdKNDXHT7hY7l/L0DQsC5fa56DZioNx637kNl9QSvr37jTl94+lhejq/qP44rVQCA gIDFA4ZJx86b7hEDdVn5VUaXkbkh4l1xX6IsQ9lNqrvmiDLXCzFc7BHkInK4jhhMi5D6 NTKQ== X-Gm-Message-State: ALoCoQkpiAgZlbqRy9swTPB+nyO0+jCAQfaK7hSfMmmnUHvgKlzEwbXhZaklxDkDORK6XCwfw+cg MIME-Version: 1.0 X-Received: by 10.170.44.86 with SMTP id 83mr79797654ykm.101.1426797089853; Thu, 19 Mar 2015 13:31:29 -0700 (PDT) Received: by 10.170.104.86 with HTTP; Thu, 19 Mar 2015 13:31:29 -0700 (PDT) In-Reply-To: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> Date: Thu, 19 Mar 2015 21:31:29 +0100 Message-ID: Subject: Re: ASLR work into -HEAD ? From: Oliver Pinter To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: HardenedBSD Core , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 20:36:38 -0000 On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd wrote: > On 19 March 2015 at 12:56, Warner Losh wrote: >> >>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrote: >>> >>> Hi, >>> >>> Apparently this is done but has stalled: >>> >>> https://reviews.freebsd.org/D473 >>> >>> Does anyone have any strong objections to it landing in the tree as-is? >> >> There=E2=80=99s rather a lot of them specifically spelled out in the cod= e review. >> >> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not been = inclined >> to take the time to re-review it. Glancing at it, I see several minor is= sues >> that should be cleaned up. > > Cool. Thanks for taking the time to look at it again. > > Shawn is in #freebsd on freenode irc, so if you/others want a more > interactive review then he's there during the day. Please CC the core@hardenedbsd.org in future please, when you are talking about this issue. Adrian: do you able to review the MIPS or ARM part especially or test them? > > > > -a > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" From owner-freebsd-arch@FreeBSD.ORG Thu Mar 19 21:51:33 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 406C6485 for ; Thu, 19 Mar 2015 21:51:33 +0000 (UTC) Received: from mail-ie0-x232.google.com (mail-ie0-x232.google.com [IPv6:2607:f8b0:4001:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 00647E03 for ; Thu, 19 Mar 2015 21:51:33 +0000 (UTC) Received: by iecsl2 with SMTP id sl2so78113761iec.1 for ; Thu, 19 Mar 2015 14:51:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=BX1VDTu+x3Ru9IGkVmax3FEjYu3lPfD7nGxdkuoi59E=; b=dq5BVfPepdowjzHBTXUqRzVYS76XOOuQHAvbcaqFGWhPELayFw+1KW3XZkRQ5jjMdF L8gixgKLPFJaRxgpXjEW5iwO1+V6WK9pcvH9MsO+TsHWtvVvVGK06F7RkHzi4zbU39Lc 2PCWrfDmF9KpFyoivFW86yo2wCihmxe/le1pvWZCj/5QN8OL9P9+aYK/47LoaxqI6LT1 AlxTdSrAl+xaBCOWiAAbvKD5mvUbAgJXqyzqGx9l2N5rO0VE2nbABgsM07rFVcMO6y0f uXa0ed7L0YyEnHixXdkychI0WRLUz7x4t8I6c6gBbhFiB0vdQfbX5Je1ed4cDEJDyYUw BTCA== MIME-Version: 1.0 X-Received: by 10.42.109.12 with SMTP id j12mr286454icp.22.1426801892417; Thu, 19 Mar 2015 14:51:32 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Thu, 19 Mar 2015 14:51:32 -0700 (PDT) In-Reply-To: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> Date: Thu, 19 Mar 2015 14:51:32 -0700 X-Google-Sender-Auth: 14gnEEIvymTsPeYSOMd2K6VQ0Ks Message-ID: Subject: Re: ASLR work into -HEAD ? From: Adrian Chadd To: Oliver Pinter Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: HardenedBSD Core , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 21:51:33 -0000 On 19 March 2015 at 13:31, Oliver Pinter wr= ote: > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd wrote: >> On 19 March 2015 at 12:56, Warner Losh wrote: >>> >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrote: >>>> >>>> Hi, >>>> >>>> Apparently this is done but has stalled: >>>> >>>> https://reviews.freebsd.org/D473 >>>> >>>> Does anyone have any strong objections to it landing in the tree as-is= ? >>> >>> There=E2=80=99s rather a lot of them specifically spelled out in the co= de review. >>> >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not been= inclined >>> to take the time to re-review it. Glancing at it, I see several minor i= ssues >>> that should be cleaned up. >> >> Cool. Thanks for taking the time to look at it again. >> >> Shawn is in #freebsd on freenode irc, so if you/others want a more >> interactive review then he's there during the day. > > Please CC the core@hardenedbsd.org in future please, when you are > talking about this issue. > > Adrian: do you able to review the MIPS or ARM part especially or test the= m? I'm out of spare cycles to poke at the MIPS stuff, sorry. All I can suggest in the short term is that you fire it up in a mips32 / mips64 emulator environment. FreeBSD works fine in qemu-devel in all four modes (32, 64 bit; big/little endian.) YOu should be able to get high test coverage that way. -adrian From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 00:54:16 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB42438F; Fri, 20 Mar 2015 00:54:16 +0000 (UTC) Received: from mail-yk0-x231.google.com (mail-yk0-x231.google.com [IPv6:2607:f8b0:4002:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 895693B0; Fri, 20 Mar 2015 00:54:16 +0000 (UTC) Received: by ykfc206 with SMTP id c206so35432765ykf.1; Thu, 19 Mar 2015 17:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=PUTkHMZs+aQxKAJhEJQVZMoxOfSzoO82jn3vaLBkKV0=; b=npdz8daGNNDgQ2/WU+6iLAt+gnM3gNfzokYAM0ihOX73ZOu8VzMX6cgNUF7N4OGOhh 0NNDo/vCAmFboOZEkQikCYN0s8xjVvJYXUNiHs3+/ojAHqXX9QQFyMiwP0dqLNff66zO ybLiBiaTotuUWlZK0WcSl5TYs2mT85ZjPQA0Drhv4DSdmKog/ODBuyKy39CntZgRjtQt Zr1L+n+92UbaoiWjPjEi1XyqHwMo8HhAbbYcR0EzJXIKpm/KYqaxZL/0/rKN513H9zPR 6CrnUw5Ih7Q5rTwLhalXevvl0gNouPsG9YW2wroKjXE27a9ZoyDd70mvcJu3u2WfXkX6 HZKw== MIME-Version: 1.0 X-Received: by 10.236.53.66 with SMTP id f42mr81712838yhc.92.1426812855687; Thu, 19 Mar 2015 17:54:15 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.170.205.193 with HTTP; Thu, 19 Mar 2015 17:54:15 -0700 (PDT) Date: Thu, 19 Mar 2015 17:54:15 -0700 X-Google-Sender-Auth: -a08iDtYgFJMxnVZVAmDkHamcWQ Message-ID: Subject: LOCAL_CPUS vs INTR_CPUS From: "K. Macy" To: "freebsd-arch@freebsd.org" , John Baldwin Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 00:54:16 -0000 I haven't been able to get an answer out of the usual suspects so I thought I'd ask here. In reference to: https://github.com/freebsd/freebsd/compare/master...bsdjhb:numa_bus_get_cpus The LOCAL_CPUS option will return the cpuset corresponding to the NUMA (_pxm) domain id of a given device. INTR_CPUS can narrow that further. However, in this particular branch INTR_CPUS will only ever return the value given by LOCAL_CPUS. When and where would this come in to effect? Do the new Haswells have cores in the same memory domain but with non-uniform access to the PCIe bus? Thanks. From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 12:38:33 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 53B1C94D; Fri, 20 Mar 2015 12:38:33 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A9EE67E; Fri, 20 Mar 2015 12:38:33 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1YYwBz-000DRo-PE; Fri, 20 Mar 2015 15:38:23 +0300 Date: Fri, 20 Mar 2015 15:38:23 +0300 From: Slawa Olhovchenkov To: John Baldwin Subject: Re: RFC: Simplfying hyperthreading distinctions Message-ID: <20150320123823.GA49621@zxy.spb.ru> References: <1640664.8z9mx3EOQs@ralph.baldwin.cx> <54FA1180.3080605@astrodoggroup.com> <1526311.uylCbgv5VB@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526311.uylCbgv5VB@ralph.baldwin.cx> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: Harrison Grundy , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 12:38:33 -0000 On Fri, Mar 06, 2015 at 04:17:37PM -0500, John Baldwin wrote: > On Friday, March 06, 2015 12:43:44 PM Harrison Grundy wrote: > > On 03/06/15 12:44, John Baldwin wrote: > > > Currently we go out of our way a bit to distinguish Pentium4-era > > > hyperthreading from more recent ("modern") hyperthreading. I > > > suspect that this distinction probably results in confusion more > > > than anything else. Intel's documentation does not make near as > > > broad a distinction as far as I can tell. Both types of SMT are > > > called hyperthreading in the SDM for example. However, we have the > > > astonishing behavior that 'machdep.hyperthreading_allowed' only > > > affects "old" hyperthreads, but not "new" ones. We also try to be > > > overly cute in our dmesg output by using HTT for "old" > > > hyperthreading, and SMT for "new" hyperthreading. I propose the > > > following changes to simplify things a bit: > > > > > > 1) Call both "old" and "new" hyperthreading HTT in dmesg. > > > > > > 2) Change machdep.hyperthreading_allowed to apply to both new and > > > old HTT. However, doing this means a POLA violation in that we > > > would now disable modern HTT by default. Balanced against > > > re-enabling "old" HTT by default on an increasingly-shrinking pool > > > of old hardware, I think the better approach here would be to also > > > change the default to allow HTT. > > > > > > 3) Possibly add a different knob (or change the behavior of > > > machdep.hyperthreading_allowed) to still bring up hyperthreads, but > > > leave them out of the default cpuset (set 1). This would allow > > > those threads to be re-enabled dynamically at runtime by adjusting > > > the mask on set 1. The original htt settings back when > > > 'hyperthreading_allowed' was introduced actually permitted this via > > > by adjusting 'machdep.hlt_cpus' at runtime. > > > > > > What do people think? > > > > I'm not sure of how interrupt handling works as it relates to HTT, but > > wouldn't using cpuset potentially leave them active for interrupt > > handling? > > > > Other than that question, this all makes sense to me. > > Interrupt handling works differently. Per my commit a few minutes ago, we do > not send interrupts to hyperthreads by default (either old or new). However, > ithreads that are not explicitly bound to a specific CPU will "float" among > all the CPUs in set 1 so 3) would affect that. Eventually I want to use a > separate cpuset for interrupts that ithreads inherit from (rather than > belonging to set 1). Can you explain interrupt handling some more? How routing real interrupt? Can be real interrupt routing to specific core? Is real interrupt and `cpuset -x irq` is same (I see interrup from chelsio on cpu other then pinned)? From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 15:34:19 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3A4D1F87 for ; Fri, 20 Mar 2015 15:34:19 +0000 (UTC) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04382CC6 for ; Fri, 20 Mar 2015 15:34:18 +0000 (UTC) Received: by pagj4 with SMTP id j4so21028087pag.2 for ; Fri, 20 Mar 2015 08:34:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=k9LL/xmAkE1PKHuJTv9UJ3RFkyns4M0J6xjIL1u+LYc=; b=dm6JDiQHSTbo4zlerNfODz+WFY2jGnEmF6/TtrtsrVqPQlbxLdjpJ8MsecvCC6LOJR zcyWAlGiTv61VeOrLUxQl0asuCVhFU8m00h0Arz/FEiEpuNmkwfva129T4cVdcGOSc7a JPufPJMUPenN6xCQhUYWfDxAIo2MkOtLNNnGXNaKaZUzaGUuZjvcyUZYYSAAUuAO0mB4 rNiTBUcF3dJhbDCqOrl1Bq5nNu3S69uHOJz3XzylwrJRbU0zRXp38+uSj5RNHpLNea5A LwJUx5kEQtxVar9wYXlKhOf7D/SncHHwHNilZLwnQXA5Ym70Zj1xujrHsSSQDT1TjeWT 8tuQ== X-Gm-Message-State: ALoCoQmZBF6JmkpZp2YmCUhLO1duz9Sf2npZwwgu1FWyDl01xkydPGmIaUw6DWPDMn4eAZHdqaKz X-Received: by 10.70.51.197 with SMTP id m5mr188975962pdo.90.1426865346742; Fri, 20 Mar 2015 08:29:06 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id fu14sm8710195pad.44.2015.03.20.08.29.05 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Mar 2015 08:29:05 -0700 (PDT) Sender: Warner Losh Subject: Re: ASLR work into -HEAD ? Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: Date: Fri, 20 Mar 2015 09:28:59 -0600 Message-Id: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> To: Oliver Pinter X-Mailer: Apple Mail (2.2070.6) Cc: Adrian Chadd , HardenedBSD Core , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 15:34:19 -0000 --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 19, 2015, at 2:31 PM, Oliver Pinter = wrote: >=20 > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd = wrote: >> On 19 March 2015 at 12:56, Warner Losh wrote: >>>=20 >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd = wrote: >>>>=20 >>>> Hi, >>>>=20 >>>> Apparently this is done but has stalled: >>>>=20 >>>> https://reviews.freebsd.org/D473 >>>>=20 >>>> Does anyone have any strong objections to it landing in the tree = as-is? >>>=20 >>> There=E2=80=99s rather a lot of them specifically spelled out in the = code review. >>>=20 >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not = been inclined >>> to take the time to re-review it. Glancing at it, I see several = minor issues >>> that should be cleaned up. >>=20 >> Cool. Thanks for taking the time to look at it again. >>=20 >> Shawn is in #freebsd on freenode irc, so if you/others want a more >> interactive review then he's there during the day. >=20 > Please CC the core@hardenedbsd.org in future please, when you are > talking about this issue. >=20 > Adrian: do you able to review the MIPS or ARM part especially or test = them? Adrian: Do not commit the changes. I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather long = review and it appears that virtually none of that has been addressed. Until it is, do not = commit it. This code interacts with dangerous parts of the system, and the default = cannot be to just let it in because no one has objected recently. Objections have = been made, they have been quantified, they haven=E2=80=99t been answered or acted = upon. Until that changes, you can assume the objections remain in place and asking again = without fixing them isn=E2=80=99t going to change the answer. Warner --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDDy7AAoJEGwc0Sh9sBEAteUP+wRwNQxW6HO25JahREu0H7tr d5FVhWHqPRvpzNFHZsg4r4PRBkVdePoHoUDBhm8WHwKLOWsEN2349fZqn5V4XCfp J7ER5k7YQg8pToCHC15j7L6swTN1BWx+SwPPStiozvlqPfLM3IQm62UBjNpR+Por Lx/DVc8fdd5JmO8lMZ3G7GmgL5k9f3MsmnPhrpwe8E0a5qMJ2Yv9jDXZmP4wcuRA 9b6H10iY1QvX5kP/QMjqPcbxY3M9d03JXWQOnlrOr9DcYSWmebFaQvtqugmKViV5 iCBWbuHVowrUamQ6ZA74xO/4cN1cBkRe4GF2UEy+a8xkIhEUp/MpFtQtQwfJLtsN HllMtIzDRNLfcZE372gc5T8PnqBKeLsDtgdlkqy8XLA213pHxWeP81v3GjlYY5dS jABuNtVUuiIwsM6r0CMEbMGJqVokTmzOA7bzIB93b+qw/2T/1eEr0gRnC27idoPy k0EydEFitDWAOjTYSDKA4I1G7vz6NSyDT/9W3Ngv+VDOme4xm+qTUBpVTeQMFoN+ Npr0yl06tM8Bt7an+hNYnB2vg28T/hJpU/6SrwiQCF++OR8eBlyRBUTtMG2WRdy8 KEUu3mVNGF4AB7TiIxEEGxlflEOF3MWNq7FYL6xMvJgGVn8PZaavVsLQfYTAQSmx /vp9K10avrnmgecEoz60 =tWKJ -----END PGP SIGNATURE----- --Apple-Mail=_0EF5B861-6D0D-4553-91F8-0BE639528AB1-- From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 18:17:47 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9A4AFB68 for ; Fri, 20 Mar 2015 18:17:47 +0000 (UTC) Received: from mail-qc0-f176.google.com (mail-qc0-f176.google.com [209.85.216.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4351CA for ; Fri, 20 Mar 2015 18:17:46 +0000 (UTC) Received: by qcbkw5 with SMTP id kw5so100401049qcb.2 for ; Fri, 20 Mar 2015 11:17:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:content-type:mime-version; bh=acbTBXlYJOTEiU1vsEg35jZOateT6T4ZLckAR1sRZXE=; b=So8IdjS78jY06msmTyM1ibkXpMLPajInJwzroWe7CbcLFeSmKMpQsq+lL1N0tmgccF 6b9oaB6mSS1JqS047JHZ53tFk8D6TiNeqXL6DNLSavQs8JDvhLxkhqZ/pm+qp5xuUgc7 rpFbrM/iZJywXElWX4xa8/E1T03ZUGvwoVyDmuXOs35+f+1+dDvx0IeSFyNt06ArcPpn omUp8/VUGwc7EoznZ8ES79J2N47IShnaRPQZb860Bmdea9SAr12HnFmGZ+zVkHaYDIox maYDF0Q7IXWXeijN8rsuukYgZ/kHF5j90d+RZzsCRRO7PlEVHYjI3nQ14Fd0ujbc6zW7 CHdA== X-Gm-Message-State: ALoCoQndrwkURed+IGr99Ambrx98R23NqeMipt9f3N4vrEKOsSso+MXsPuLj1ODRAxhbASvryS3S X-Received: by 10.55.17.164 with SMTP id 36mr115257846qkr.18.1426875460168; Fri, 20 Mar 2015 11:17:40 -0700 (PDT) Received: from [10.3.0.21] ([63.88.83.66]) by mx.google.com with ESMTPSA id k127sm3500986qhc.42.2015.03.20.11.17.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 11:17:39 -0700 (PDT) Message-ID: <1426875464.5550.26.camel@hardenedbsd.org> Subject: Re: ASLR work into -HEAD ? From: Shawn Webb To: Warner Losh Date: Fri, 20 Mar 2015 14:17:44 -0400 In-Reply-To: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> Organization: HardenedBSD Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-hlLhQWqJYtOKnTorZO2D" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Adrian Chadd , HardenedBSD Core , Oliver Pinter , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 18:17:47 -0000 --=-hlLhQWqJYtOKnTorZO2D Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-03-20 at 09:28 -0600, Warner Losh wrote: > > On Mar 19, 2015, at 2:31 PM, Oliver Pinter wrote: > >=20 > > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd wrot= e: > >> On 19 March 2015 at 12:56, Warner Losh wrote: > >>>=20 > >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wrot= e: > >>>>=20 > >>>> Hi, > >>>>=20 > >>>> Apparently this is done but has stalled: > >>>>=20 > >>>> https://reviews.freebsd.org/D473 > >>>>=20 > >>>> Does anyone have any strong objections to it landing in the tree as-= is? > >>>=20 > >>> There=E2=80=99s rather a lot of them specifically spelled out in the = code review. > >>>=20 > >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not be= en inclined > >>> to take the time to re-review it. Glancing at it, I see several minor= issues > >>> that should be cleaned up. > >>=20 > >> Cool. Thanks for taking the time to look at it again. > >>=20 > >> Shawn is in #freebsd on freenode irc, so if you/others want a more > >> interactive review then he's there during the day. > >=20 > > Please CC the core@hardenedbsd.org in future please, when you are > > talking about this issue. > >=20 > > Adrian: do you able to review the MIPS or ARM part especially or test t= hem? >=20 > Adrian: Do not commit the changes. >=20 > I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather long re= view and it appears > that virtually none of that has been addressed. Until it is, do not commi= t it. This > code interacts with dangerous parts of the system, and the default cannot= be > to just let it in because no one has objected recently. Objections have b= een made, > they have been quantified, they haven=E2=80=99t been answered or acted up= on. Until that > changes, you can assume the objections remain in place and asking again w= ithout > fixing them isn=E2=80=99t going to change the answer. >=20 > Warner Warner, We've fixed the vast majority of the concerns raised in that review. To say "virtually none of that has been addressed" and "they haven't been answered or acted upon" is a blatant lie. The fact that there are so many revisions of the patch is proof. We even made our ASLR implementation for FreeBSD less secure by providing a mechanism in ptrace() to disable it as requested by a member of the FreeBSD Foundation. (This "feature" doesn't exist in HardenedBSD's implementation.) If comments like these continue, I will remove the diff from Phabricator and close the BugZilla ticket. FreeBSD can feel free to pull from us, but we won't make any effort to proactively upstream our work. With that said, I have missed a few of the concerns raised. There's so many comments/concerns in that review that it's easy to miss a few. I will address them tonight and upload a new patch tomorrow. Thanks, Shawn Webb HardenedBSD --=-hlLhQWqJYtOKnTorZO2D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJVDGRJAAoJEGqEZY9SRW7u4LQP/2wleg2q2F+Tla+hOLCX5QKo /WaT2mNnm6RxnACOIfYtdR36c6Hpd9+YbhDNu1Lf/mNJ6Qrs4eSVdez2gCRzwzBi L6zNaq5CDjrUCWEHntT6zKV571RAB3u9sAPATAV/1EYrbS7u+fZW6RA1IU1qWm2z JHLH9SPm8aBK1bZfJKVQJTj9LKjA6W0are55nbo6TFnrFjKJbgVZW9JGoeNZ9W40 AzcVSKV/XAWvm5ryS8B1F5TOpAkyfrTOUHv0oXWAonZ1aq2FVN9TeYgDiMTx7Z4i iuGwdh9goUtOlbQnA406aTAh0wnaIhnyPHoUjF4NuA4y8CE+92HTanGisv3uG/jy 3kj45loJFWMFUjlSV23g3jqKoekx7DiTzj4iyjgSJYwTWbY1vOH9xhRKeSVH9Rgf W9ujFqZMtmBpDYRTABOxuPgkZm3ykXNBQSLy58m/8qL8RSdzW18s94Wnck+5AsWT dvmBrwmB0By55y5BVFqpzlUB9i+XkctqvzDnc8j4o0xXk/IG6nfcUq+99Fm7fygo 6UfIKZxvoYD3G0Zfzrf2eL+T2CfQswa9/bUMc0U50LPMCCQp3AmYglSenDV2sUbF hw7pWLTXWVWQAeDNFiFsOgz5BCeO6pRcQ3Q9Lx3K3MZnZTPnyrMxcNfuMqAgUjBW 13EqtI4scXCeVGX3/vwO =AKR2 -----END PGP SIGNATURE----- --=-hlLhQWqJYtOKnTorZO2D-- From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 19:05:42 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 41A84ADB for ; Fri, 20 Mar 2015 19:05:42 +0000 (UTC) Received: from mail-qg0-f51.google.com (mail-qg0-f51.google.com [209.85.192.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E3AD0ACE for ; Fri, 20 Mar 2015 19:05:41 +0000 (UTC) Received: by qgew92 with SMTP id w92so25674238qge.2 for ; Fri, 20 Mar 2015 12:05:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:content-type:mime-version; bh=ASA4uERTvyhnq5wtFDQttkBYWWl189u5IkELgSYAZ/0=; b=mrwiJFm7Yz/+XF+WIhr0kFtzDrhB7YipsmfVK8SVEVf1MC0mYGmrhiTQCRvS6/g//N K90KQv8tV90iow79ybsBeUh+lk1qdpEPhczgADWOowaBgOj/ZhUuInA2ubbm6ZPdiSRd a6TkRNT8jpQagLiid8y1UYyLu51YhYo/Au/9pKugxj626ke/NLpdsFc6oQXUP9pKrUah 6+RtNpUkQoOn4CgVttMSHgH7eOa8lDOr5/1XEAGJN4640eeIYHKwLlRE8MqQGQWmPbbI UYCKV4pA9Kc1eUcKSzJ00JtNBKhE1QHcHJ9lzLaVy/KBpksQd1UopTO7E8BUkU2YcmAI puEg== X-Gm-Message-State: ALoCoQlnJ+XqMmBYDGtbOikk8C+HThe3MBLUU5ypkk+Ku0dYn9D1ilg3AmMgRs6ysIs7uuQ6eo39 X-Received: by 10.55.24.159 with SMTP id 31mr106639775qky.74.1426878335496; Fri, 20 Mar 2015 12:05:35 -0700 (PDT) Received: from [10.3.0.21] ([63.88.83.66]) by mx.google.com with ESMTPSA id p8sm3599254qha.20.2015.03.20.12.05.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Mar 2015 12:05:34 -0700 (PDT) Message-ID: <1426878339.5550.29.camel@hardenedbsd.org> Subject: Re: ASLR work into -HEAD ? From: Shawn Webb To: Warner Losh Date: Fri, 20 Mar 2015 15:05:39 -0400 In-Reply-To: <1426875464.5550.26.camel@hardenedbsd.org> References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> <1426875464.5550.26.camel@hardenedbsd.org> Organization: HardenedBSD Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-17Fk+7cjDbIAFS40BrYA" X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Cc: Adrian Chadd , HardenedBSD Core , Oliver Pinter , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 19:05:42 -0000 --=-17Fk+7cjDbIAFS40BrYA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-03-20 at 14:17 -0400, Shawn Webb wrote: > On Fri, 2015-03-20 at 09:28 -0600, Warner Losh wrote: > > > On Mar 19, 2015, at 2:31 PM, Oliver Pinter wrote: > > >=20 > > > On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd wr= ote: > > >> On 19 March 2015 at 12:56, Warner Losh wrote: > > >>>=20 > > >>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd wr= ote: > > >>>>=20 > > >>>> Hi, > > >>>>=20 > > >>>> Apparently this is done but has stalled: > > >>>>=20 > > >>>> https://reviews.freebsd.org/D473 > > >>>>=20 > > >>>> Does anyone have any strong objections to it landing in the tree a= s-is? > > >>>=20 > > >>> There=E2=80=99s rather a lot of them specifically spelled out in th= e code review. > > >>>=20 > > >>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve not = been inclined > > >>> to take the time to re-review it. Glancing at it, I see several min= or issues > > >>> that should be cleaned up. > > >>=20 > > >> Cool. Thanks for taking the time to look at it again. > > >>=20 > > >> Shawn is in #freebsd on freenode irc, so if you/others want a more > > >> interactive review then he's there during the day. > > >=20 > > > Please CC the core@hardenedbsd.org in future please, when you are > > > talking about this issue. > > >=20 > > > Adrian: do you able to review the MIPS or ARM part especially or test= them? > >=20 > > Adrian: Do not commit the changes. > >=20 > > I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather long = review and it appears > > that virtually none of that has been addressed. Until it is, do not com= mit it. This > > code interacts with dangerous parts of the system, and the default cann= ot be > > to just let it in because no one has objected recently. Objections have= been made, > > they have been quantified, they haven=E2=80=99t been answered or acted = upon. Until that > > changes, you can assume the objections remain in place and asking again= without > > fixing them isn=E2=80=99t going to change the answer. > >=20 > > Warner >=20 > Warner, >=20 > We've fixed the vast majority of the concerns raised in that review. To > say "virtually none of that has been addressed" and "they haven't been > answered or acted upon" is a blatant lie. The fact that there are so > many revisions of the patch is proof. We even made our ASLR > implementation for FreeBSD less secure by providing a mechanism in > ptrace() to disable it as requested by a member of the FreeBSD > Foundation. (This "feature" doesn't exist in HardenedBSD's > implementation.) If comments like these continue, I will remove the diff > from Phabricator and close the BugZilla ticket. FreeBSD can feel free to > pull from us, but we won't make any effort to proactively upstream our > work. >=20 > With that said, I have missed a few of the concerns raised. There's so > many comments/concerns in that review that it's easy to miss a few. I > will address them tonight and upload a new patch tomorrow. I've updated the patch. Is there anything I've missed? Thanks, Shawn Webb HardenedBSD --=-17Fk+7cjDbIAFS40BrYA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJVDG+DAAoJEGqEZY9SRW7uHesP/1C0dn7RTMwgC5i4trRLvxWN F40qlP3c0VQnfUiC6+/NT9kupIR17cecnqsB6MYT2axa4+pw8uIV4sHK1ZwEaw/O VXAPR7u9HznTR8earpaj1W36FZWLfuCgaGTxvTwzboqNwm6goIFBJogq46Pjgh7G MZ2NVSIy5+hUErMc6+7k9NwdnGNY8av4V+8ThgiTuE3ezQ2cTF4bv2FyG/eapbSf AVy5cOdO8DSxBSNvLr26vHNzt4YygakPuIbH+JEaGDflUoG0IXDIp6h5RE5NzXk+ CiBOZLHoFSM1oa74njGVB736KCUH/lcX4wCblX14VDu3Z0m4Fsj/9fNBWDTIwioS RvfFf5YzD9IC7vOroVZa3h55qE7X0A4Rg4yJrHNY9UDH91JDSGMqbQCLpdMQvcix npAWL6dr59j+GoSKR49lWklV0k9Bysj1LBlxhoNOko42OuaCDcGUoMgFeXVF6HOs 3wYRS5BXS0olW22sBvtufENqq6Z6Q9wFdsW4A8nWApyJmGrNFaOgxT9FFKxu9Xww quF+hUuPUvcMDPgttfzoQRCao2ad9ibiSLleph2Gp0Lri7r2iSvjX3sZXOw8GjLO MDQ4OpTfJ7I7wYZRvFVR4YjlSeENFyE+E9RPGbJtuuTe/TLkfOLa2tlqGdXl+ubN 7HJIz0eFUlK7BJGNq4Ql =3y95 -----END PGP SIGNATURE----- --=-17Fk+7cjDbIAFS40BrYA-- From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 21:14:44 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D0CF9EB9 for ; Fri, 20 Mar 2015 21:14:44 +0000 (UTC) Received: from mail-pd0-f175.google.com (mail-pd0-f175.google.com [209.85.192.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97204CF7 for ; Fri, 20 Mar 2015 21:14:44 +0000 (UTC) Received: by pdbcz9 with SMTP id cz9so119270630pdb.3 for ; Fri, 20 Mar 2015 14:14:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=w3v36h3qbr8DGU8VmnflaMoSGL1MPBFlhwvdXGduBno=; b=mX9nRzbXpy8LPT0FUWc6Wzqd6iRTVzihUfGIHY9uSb+lvzLjzpOz8xNR7VToix77o3 clpqV7HWEDKXy99l89mwhRFuiVeMYPUk6EXG3v1QxCdz7pBNu1JDHDJoMNjG5Tx72ejW tOifvF3cqRm8tKOx1MseXRijN7gRaAjzXZP3Ita6n/Bzm+Fgs2926j6pzGnNiXy6q4RB V2ARbNzKGDRutGnuzouCmoifhFaGWgM0x8Vk/SuuK3ISPRagafEeAp4ZLlzzdBAUF0rK gsRwBLLsX3PhXXokC+P8+6WSxkF/SfQRiYkSMq1xcyW3s5/jWG5RFjfWQVI5RijG8sQ0 +EGA== X-Gm-Message-State: ALoCoQm6tPs2s6q8gb1E9+1pvXdmAxvwNT3lI+HRX6vCLf/r1ZrxzoW82A8WZPI2KeXZhuyElc2h X-Received: by 10.70.132.36 with SMTP id or4mr121880113pdb.59.1426886078507; Fri, 20 Mar 2015 14:14:38 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id qo4sm9658771pab.33.2015.03.20.14.14.36 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 20 Mar 2015 14:14:37 -0700 (PDT) Sender: Warner Losh Subject: Re: ASLR work into -HEAD ? Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <1426878339.5550.29.camel@hardenedbsd.org> Date: Fri, 20 Mar 2015 15:14:30 -0600 Message-Id: References: <7C64CB2B-3FD0-434C-A11A-2A841537220F@bsdimp.com> <1426875464.5550.26.camel@hardenedbsd.org> <1426878339.5550.29.camel@hardenedbsd.org> To: Shawn Webb X-Mailer: Apple Mail (2.2070.6) Cc: Adrian Chadd , HardenedBSD Core , Oliver Pinter , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 21:14:45 -0000 --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 20, 2015, at 1:05 PM, Shawn Webb = wrote: >=20 > On Fri, 2015-03-20 at 14:17 -0400, Shawn Webb wrote: >> On Fri, 2015-03-20 at 09:28 -0600, Warner Losh wrote: >>>> On Mar 19, 2015, at 2:31 PM, Oliver Pinter = wrote: >>>>=20 >>>> On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd = wrote: >>>>> On 19 March 2015 at 12:56, Warner Losh wrote: >>>>>>=20 >>>>>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd = wrote: >>>>>>>=20 >>>>>>> Hi, >>>>>>>=20 >>>>>>> Apparently this is done but has stalled: >>>>>>>=20 >>>>>>> https://reviews.freebsd.org/D473 >>>>>>>=20 >>>>>>> Does anyone have any strong objections to it landing in the tree = as-is? >>>>>>=20 >>>>>> There=E2=80=99s rather a lot of them specifically spelled out in = the code review. >>>>>>=20 >>>>>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve = not been inclined >>>>>> to take the time to re-review it. Glancing at it, I see several = minor issues >>>>>> that should be cleaned up. >>>>>=20 >>>>> Cool. Thanks for taking the time to look at it again. >>>>>=20 >>>>> Shawn is in #freebsd on freenode irc, so if you/others want a more >>>>> interactive review then he's there during the day. >>>>=20 >>>> Please CC the core@hardenedbsd.org in future please, when you are >>>> talking about this issue. >>>>=20 >>>> Adrian: do you able to review the MIPS or ARM part especially or = test them? >>>=20 >>> Adrian: Do not commit the changes. >>>=20 >>> I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather = long review and it appears >>> that virtually none of that has been addressed. Until it is, do not = commit it. This >>> code interacts with dangerous parts of the system, and the default = cannot be >>> to just let it in because no one has objected recently. Objections = have been made, >>> they have been quantified, they haven=E2=80=99t been answered or = acted upon. Until that >>> changes, you can assume the objections remain in place and asking = again without >>> fixing them isn=E2=80=99t going to change the answer. >>>=20 >>> Warner >>=20 >> Warner, >>=20 >> We've fixed the vast majority of the concerns raised in that review. = To >> say "virtually none of that has been addressed" and "they haven't = been >> answered or acted upon" is a blatant lie. The fact that there are so >> many revisions of the patch is proof. We even made our ASLR >> implementation for FreeBSD less secure by providing a mechanism in >> ptrace() to disable it as requested by a member of the FreeBSD >> Foundation. (This "feature" doesn't exist in HardenedBSD's >> implementation.) If comments like these continue, I will remove the = diff >> from Phabricator and close the BugZilla ticket. FreeBSD can feel free = to >> pull from us, but we won't make any effort to proactively upstream = our >> work. >>=20 >> With that said, I have missed a few of the concerns raised. There's = so >> many comments/concerns in that review that it's easy to miss a few. I >> will address them tonight and upload a new patch tomorrow. >=20 > I've updated the patch. Is there anything I've missed? I=E2=80=99ve taken a look at the updated patch and see that it addressed = the issues I raised. It almost looks like the update to the review a month ago was the wrong version, since so many more of the original comments appear to be addressed than when I looked. Thanks! Warner --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDI22AAoJEGwc0Sh9sBEAu+8QALGiZEBaYbyODq+zgT93HuIS CU7/NCaiVOVk2A6GqLEUgrxqFfGT306BqlJK4omsShzpSzadGs73yv2xJjqxZAVH MOlUUcJ/xvK1NZIvOU5K7r8ey9rtdk59X7R1zBzjGpi2TN6GDVhZ9MzvCciJsAUe OGkFni6Oe3bYhOVFRDX7Y0Q6gVF+m8ZkDqMbSi4QqoIQOGdia7Ijc1+6G0ZLSa1f VE7mcG0iXgFdi/xB7RDYE4xOzegDKzbxWqfBVGX5qWxm5Q3vbIpMFVoEXNAO7umK i23Z3f+EdnrunLcK7d51XdMccuXwI3nMIpdgs0DOPnbWNupBu+/YIFuxflG+FAsF iQferoEeECCSaxImH0SJd5wsQrXD0pLl6Zv1nsoKe6hoPC+RECaDJ0370p7pBvg4 wt6YlUqSNANuA4h1hE6Uetu3n6M41uNnLEWBTnOtQZhxVsUcC4m4jqtR59VwG5MF ZjLZAox4IPlzMt50P3ziueMKwgiVk9SZ4g9BN1v7v9O7tcl3HLZ/Yt1blibwjyUT dx3RvkbQ6iucjqyUfRmZjZAmnOOT0zNNcxxnVMBVR2O29fYNau41QFkdVOPnazzc LaeiUC7II+Y/ZA6jyB7O49+S77c9/INPlzJrAZTAsytZuwU91QUeIj/1lKdi1c6Q WTe946Ytb2LrCU+zvMyl =zHEy -----END PGP SIGNATURE----- --Apple-Mail=_D7C94696-EF5C-4348-9F24-E05CC351FC5C-- From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 11:53:40 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4AEAC9A9 for ; Sat, 21 Mar 2015 11:53:40 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 82495CED for ; Sat, 21 Mar 2015 11:53:38 +0000 (UTC) Received: (qmail 94838 invoked by uid 89); 21 Mar 2015 11:26:54 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@185.17.207.96) by mail.grem.de with ESMTPA; 21 Mar 2015 11:26:54 -0000 Date: Sat, 21 Mar 2015 12:26:53 +0100 From: Michael Gmelin To: freebsd-arch@freebsd.org Subject: Changing smbus ABI Message-ID: <20150321122653.3e9a9ece@bsd64.grem.de> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; amd64-portbld-freebsd10.0) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 11:53:40 -0000 I'm planning to change the smbcmd structure in an incompatible way (see 'man smb' and https://reviews.freebsd.org/D1955?id=4055#inline-12187) in HEAD. I'm not aware of any applications relying on this ABI and adding a compatibility wrapper later shouldn't be a big deal either. I would prefer to avoid the additional complexity introduced by such wrapper if it isn't required anyway. - Michael -- Michael Gmelin From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 12:01:50 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08189F49 for ; Sat, 21 Mar 2015 12:01:50 +0000 (UTC) Received: from mail-pa0-f42.google.com (mail-pa0-f42.google.com [209.85.220.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C97C5DF0 for ; Sat, 21 Mar 2015 12:01:49 +0000 (UTC) Received: by pacwe9 with SMTP id we9so136594478pac.1 for ; Sat, 21 Mar 2015 05:01:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=BIDwxD4Vu85W/hc9XaVH8bj7lh4hQJHMyn0uPa0hx1E=; b=YnjsYia9jvo88xVvMzUsTE/khJb7sjoOD/Fh7hcpxXrQGBGAn22YbdDATGT/HeRNb0 uPibuScpQD5ch0M1csNieHQm6CWeJ+/VgQgkfYrxnw8Gl9Y9EkvJomR8YlOQHhMnSodC 2WY4+GoMD1z3qAZ8WV+6bNChgyDkcwQLVPEFXsiETHJzbKuvP7lowzztEBOQt6AXt4Up X6kkXkh90vpRe7up4LMQ1TC5W2QZnf5KLnCvL/wWLBwh9mSoF3hzXBlqsfphUlktEmyo 01Y2BXVx9h9EAfJLwnKhpZEzEJTFu2vfk5P4fYO2vGJcovVQjeWdaXwkkGzt9dBVzkvB Xj1g== X-Gm-Message-State: ALoCoQl9B0YCynFz/SoxZ/zpkdXLLHO1AmPZbVbZAH8Q4iaK4nYy6Tv1LkgPC8J2ngHYTiWTcj2u X-Received: by 10.70.128.97 with SMTP id nn1mr125444083pdb.53.1426939303475; Sat, 21 Mar 2015 05:01:43 -0700 (PDT) Received: from [10.64.25.47] ([69.53.236.236]) by mx.google.com with ESMTPSA id dk3sm1778509pbb.91.2015.03.21.05.01.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 21 Mar 2015 05:01:42 -0700 (PDT) Sender: Warner Losh Subject: Re: Changing smbus ABI Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_43C4F719-A2A9-43DD-B9FA-6720E00C8204"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b6 From: Warner Losh In-Reply-To: <20150321122653.3e9a9ece@bsd64.grem.de> Date: Sat, 21 Mar 2015 06:01:34 -0600 Message-Id: <4BA6E6D9-B66B-499F-BDCA-34BD98E4A7DB@bsdimp.com> References: <20150321122653.3e9a9ece@bsd64.grem.de> To: Michael Gmelin X-Mailer: Apple Mail (2.2070.6) Cc: freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 12:01:50 -0000 --Apple-Mail=_43C4F719-A2A9-43DD-B9FA-6720E00C8204 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 21, 2015, at 5:26 AM, Michael Gmelin wrote: >=20 > I'm planning to change the smbcmd structure in an incompatible way = (see > 'man smb' and https://reviews.freebsd.org/D1955?id=3D4055#inline-12187) = in > HEAD. >=20 > I'm not aware of any applications relying on this ABI and adding a > compatibility wrapper later shouldn't be a big deal either. I would > prefer to avoid the additional complexity introduced by such wrapper = if > it isn't required anyway. We have compete code for FreeBSD 4.x in the driver now. Don=E2=80=99t = know why it was added. IIRC, this interface is used by the X server on some cards to get data from the smbus that=E2=80=99s behind the video chips, = which would likely make compat interface almost required. Warner --Apple-Mail=_43C4F719-A2A9-43DD-B9FA-6720E00C8204 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVDV2eAAoJEGwc0Sh9sBEA1CAP+gIG5dXydFaSRBpqmulSAP2x F9pJU9B8M8AgCJstR3Rwg5qZ4bzryFYcheY9emwf+oi9w0uNKbJW2rhiTAz1suBw EaenGMi8pDzAozE5UsWtZcrSik8WNMdj76XnW2VsXNnVrd90Q7p9Sp8sDjRPZbNC soQtdd9Q2nLHYGeGY/3+78Uwl39fN8BexNC073j36j17hbWQ65Q3PS/KYc+osYZJ d3cdClZJV5hLtma3WfgoU0yLQPo2iTTiKY0wXtVbYq9KRdMSYjS+pufR0gaYnGf9 RenOqEpFDJE4xwsiLa9apPQMVUAm0sYT9toVpNeGh/4DwLpxW37HfNdctdKh/6Y0 6kn1cCI+QgnlShLv7ZepBXBxFRzU1nE68TlM06f8/9VaRMJqoXyrFXqXf7MP7hKI /C4zZRexIOQGeieRupl1PU/QT/i9cL0hPptF+LWjz8OYHs8XM1egQ4Bf7tb/ErL3 isTUHLOB2ckQolQTU0oTreAUheIFenU+X37hAs3sVYZRptQjjOQvjPlf+XSB6dJt S+aNNzJfDy2anhO4W6dNrLzBlRZebi3k5ZzdAAo2BmdVjUEcNMidpjQYihIXVRfp 10Z8SOlAKm/hT5NF6xb0+2CGU+bscWt187Eo14aRw+nJ3BWiT/MsEgIOPhMNY8WR tcGwvN1KiUl/iQRwJCKZ =uzcI -----END PGP SIGNATURE----- --Apple-Mail=_43C4F719-A2A9-43DD-B9FA-6720E00C8204-- From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 12:20:48 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A91543C2 for ; Sat, 21 Mar 2015 12:20:48 +0000 (UTC) Received: from mail.grem.de (outcast.grem.de [213.239.217.27]) by mx1.freebsd.org (Postfix) with SMTP id 0A103F03 for ; Sat, 21 Mar 2015 12:20:47 +0000 (UTC) Received: (qmail 95436 invoked by uid 89); 21 Mar 2015 12:20:46 -0000 Received: from unknown (HELO bsd64.grem.de) (mg@grem.de@185.17.207.96) by mail.grem.de with ESMTPA; 21 Mar 2015 12:20:46 -0000 Date: Sat, 21 Mar 2015 13:20:42 +0100 From: Michael Gmelin To: Warner Losh Subject: Re: Changing smbus ABI Message-ID: <20150321132042.141a6b40@bsd64.grem.de> In-Reply-To: <4BA6E6D9-B66B-499F-BDCA-34BD98E4A7DB@bsdimp.com> References: <20150321122653.3e9a9ece@bsd64.grem.de> <4BA6E6D9-B66B-499F-BDCA-34BD98E4A7DB@bsdimp.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; amd64-portbld-freebsd10.0) X-Face: $wrgCtfdVw_H9WAY?S&9+/F"!41z'L$uo*WzT8miX?kZ~W~Lr5W7v?j0Sde\mwB&/ypo^}> +a'4xMc^^KroE~+v^&^#[B">soBo1y6(TW6#UZiC]o>C6`ej+i Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWJBwe5BQDl LASZU0/LTEWEfHbyj0Txi32+sKrp1Mv944X8/fm1rS+cAAAACXBIWXMAAAsTAAAL EwEAmpwYAAAAB3RJTUUH3wESCxwC7OBhbgAAACFpVFh0Q29tbWVudAAAAAAAQ3Jl YXRlZCB3aXRoIFRoZSBHSU1QbbCXAAAAAghJREFUOMu11DFvEzEUAGCfEhBVFzuq AKkLd0O6VrIQsLXVSZXoWE5N1K3DobBBA9fQpRWc8OkWouaIjedWKiyREOKs+3PY fvalCNjgLVHeF7/3bMtBzV8C/VsQ8tecEgCcDgrzjekwKZ7TwsJZd/ywEKwwP+ZM 8P3drTsAwWn2mpWuDDuYiK1bFs6De0KUUFw0tWxm+D4AIhuuvZqtyWYeO7jQ4Aea 7jUqI+ixhQoHex4WshEvSXdood7stlv4oSuFOC4tqGcr0NjEqXgV4mMJO38nld4+ xKNxRDon7khyKVqY7YR4d+Cg0OMrkWXZOM7YDkEfKiilCn1qYv4mighZiynuHHOA Wq9QJq+BIES7lMFUtcikMnkDGHUoncA+uHgrP0ctIEqfwLHzeSo+eUA66AqzwN6n 2ZHJhw6Qh/PoyC/QENyEyC/AyNjq74Bs+3UH0xYwzDUC4B97HgLocg1QLYgDDO1v f3UX9Y307Ew4AHh67YAFFsxEpkXwpXY3eIgMhAAE3R19L919nNnuD2wlPcDE3UeT L2ytEICQib9BXgS2fU8PrD82ToYO1OEmMSnYTjSqSv9wdC0tPYC+rQRQD9ESnldF CyqfmiYW+tlALt8gH2xrMdC/youbjzPXEun+/ReXsMCDyve3dZc09fn2Oas8oXGc Jj6/fOeK5UmSMPmf/jL+GD8BEj0k/Fn6IO4AAAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/+FzrNXiaB=dZdwAc/_LK/Q+"; protocol="application/pgp-signature" Cc: freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 12:20:48 -0000 --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sat, 21 Mar 2015 06:01:34 -0600 Warner Losh wrote: >=20 > > On Mar 21, 2015, at 5:26 AM, Michael Gmelin wrote: > >=20 > > I'm planning to change the smbcmd structure in an incompatible way > > (see 'man smb' and > > https://reviews.freebsd.org/D1955?id=3D4055#inline-12187) in HEAD. > >=20 > > I'm not aware of any applications relying on this ABI and adding a > > compatibility wrapper later shouldn't be a big deal either. I would > > prefer to avoid the additional complexity introduced by such > > wrapper if it isn't required anyway. >=20 > We have compete code for FreeBSD 4.x in the driver now. Don=E2=80=99t know > why it was added. IIRC, this interface is used by the X server on some > cards to get data from the smbus that=E2=80=99s behind the video chips, w= hich > would likely make compat interface almost required. >=20 I couldn't smbcmd used anywhere, maybe you could point to the correct ports. I checked the sources of x11-drivers/xf86-video* and x11-servers/* (after running make patch on each port). The only file that uses smb is: xf86-video-trident/work/xf86-video-trident-1.3.6/src/trident_tv.c and a couple of pciids mentioning SMBbus, but nothing relying on FreeBSD's native smbus driver. - Michael --=20 Michael Gmelin --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJVDWIdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFODQyNDA4MjEyRDI3NjdBRTI5RUZDQTQ2 ODk3RjhDMTZCRkFGRjlGAAoJEGiX+MFr+v+fufEIAJrOgSSS+P4aX3d34VfSuCTE 2eBWoztF311zsBhr15+vBxZ7Mb9oiGjun6+Xjab2XWE1x+qOo7tHkMbBH1RG2Ea/ N/mbJe5KBE25D+cjw0iNQCq/QiOkZERaOOoTkHWjRyzK7wPmRXKksHFS0veEU+zM 1wX815I3l7QEuURp9ZVkJHMwuRVO4Wp5R+AyUT5T47UjNBlelnqQN6W3X0OyudgC F9WtSTZfWQBfAqD9AyZMSCAJ2+Ta0PXNiL35FEUS7TROsJkVq8ptEWwGOlwwZCd0 dL/9mSAlJkMtoANR5bD8kye9aNqutrkod1RnsgfXrYvbN1ov4V4eY30jjatlXLA= =zAEx -----END PGP SIGNATURE----- --Sig_/+FzrNXiaB=dZdwAc/_LK/Q+-- From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 15:23:41 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6C1F0BF4 for ; Sat, 21 Mar 2015 15:23:41 +0000 (UTC) Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com [209.85.216.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 20C5E21C for ; Sat, 21 Mar 2015 15:23:40 +0000 (UTC) Received: by qcto4 with SMTP id o4so115524485qct.3 for ; Sat, 21 Mar 2015 08:23:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version:content-type; bh=BFZNXeUDPyP26RP5XEEK5j7boriK2SMZe8KqHBkuoqc=; b=gU1AU2ibklcVyfzaonHWRhBeV7S3K9nXjmTw/Zx1qxgawSWD2NhUT9OoUrUI/E+5tZ f+EjO9YQoYAli78DLQIzLmDjVut8TxDdoZp3EADYiPvV/++vZbrzZbnAdsNPzREn3YGv +4RykkQ7FVpn23LK4rVXOhauqR/qwBjR6OzHmAoygA3IR+3u6vKMfEp3gYHXkdLgm6Rx Z9LnTkJciJbpTyrr9RZAlpwRXr3VhfO2HjTYGe2Ln1oMADRJnKhp4D/3j6qp/pr5wmmC dioS+vEa334bGgRv0OKfZCmVuBDZGp3tBLHtiA1nT1JtzM4Zrc22dbyxXt0ZVM20o2Jk SqRQ== X-Gm-Message-State: ALoCoQmYhnwfavM4evcX1Tjf+RDSbeiFgHOIHuUTHIYlZj3fHndHk1QfqYpHmIHuVwZETITp6QVX X-Received: by 10.55.31.97 with SMTP id f94mr126019983qkf.10.1426949975615; Sat, 21 Mar 2015 07:59:35 -0700 (PDT) Received: from shawnwebb-laptop.localnet ([73.173.99.185]) by mx.google.com with ESMTPSA id n20sm5267776qgd.48.2015.03.21.07.59.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Mar 2015 07:59:34 -0700 (PDT) From: Shawn Webb To: Warner Losh Subject: Re: ASLR work into -HEAD ? Date: Sat, 21 Mar 2015 10:43:40 -0400 Message-ID: <9043388.Uf7dufN8KZ@shawnwebb-laptop> Organization: HardenedBSD User-Agent: KMail/4.14.2 (FreeBSD/11.0-CURRENT; KDE/4.14.2; amd64; ; ) In-Reply-To: References: <1426878339.5550.29.camel@hardenedbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2422452.N10iFPSzQD"; micalg="pgp-sha256"; protocol="application/pgp-signature" Cc: Adrian Chadd , HardenedBSD Core , Oliver Pinter , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 15:23:41 -0000 --nextPart2422452.N10iFPSzQD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On Friday, March 20, 2015 03:14:30 PM Warner Losh wrote: > > On Mar 20, 2015, at 1:05 PM, Shawn Webb > > wrote: > >=20 > > On Fri, 2015-03-20 at 14:17 -0400, Shawn Webb wrote: > >> On Fri, 2015-03-20 at 09:28 -0600, Warner Losh wrote: > >>>> On Mar 19, 2015, at 2:31 PM, Oliver Pinter > >>>> wrote:>>>>=20 > >>>> On Thu, Mar 19, 2015 at 9:04 PM, Adrian Chadd =20 wrote: > >>>>> On 19 March 2015 at 12:56, Warner Losh wrote: > >>>>>>> On Mar 19, 2015, at 12:53 PM, Adrian Chadd > >>>>>>> wrote: > >>>>>>>=20 > >>>>>>> Hi, > >>>>>>>=20 > >>>>>>> Apparently this is done but has stalled: > >>>>>>>=20 > >>>>>>> https://reviews.freebsd.org/D473 > >>>>>>>=20 > >>>>>>> Does anyone have any strong objections to it landing in the t= ree > >>>>>>> as-is? > >>>>>>=20 > >>>>>> There=E2=80=99s rather a lot of them specifically spelled out = in the code > >>>>>> review. > >>>>>>=20 > >>>>>> Many of the earlier ones were kinda blown off, so I=E2=80=99ve= not been > >>>>>> inclined > >>>>>> to take the time to re-review it. Glancing at it, I see severa= l minor > >>>>>> issues that should be cleaned up. > >>>>>=20 > >>>>> Cool. Thanks for taking the time to look at it again. > >>>>>=20 > >>>>> Shawn is in #freebsd on freenode irc, so if you/others want a m= ore > >>>>> interactive review then he's there during the day. > >>>>=20 > >>>> Please CC the core@hardenedbsd.org in future please, when you ar= e > >>>> talking about this issue. > >>>>=20 > >>>> Adrian: do you able to review the MIPS or ARM part especially or= test > >>>> them? > >>>=20 > >>> Adrian: Do not commit the changes. > >>>=20 > >>> I=E2=80=99ve gone back and re-read Robert Watson=E2=80=99s rather= long review and it > >>> appears that virtually none of that has been addressed. Until it = is, do > >>> not commit it. This code interacts with dangerous parts of the sy= stem, > >>> and the default cannot be to just let it in because no one has ob= jected > >>> recently. Objections have been made, they have been quantified, t= hey > >>> haven=E2=80=99t been answered or acted upon. Until that changes, = you can assume > >>> the objections remain in place and asking again without fixing th= em > >>> isn=E2=80=99t going to change the answer. > >>>=20 > >>> Warner > >>=20 > >> Warner, > >>=20 > >> We've fixed the vast majority of the concerns raised in that revie= w. To > >> say "virtually none of that has been addressed" and "they haven't = been > >> answered or acted upon" is a blatant lie. The fact that there are = so > >> many revisions of the patch is proof. We even made our ASLR > >> implementation for FreeBSD less secure by providing a mechanism in= > >> ptrace() to disable it as requested by a member of the FreeBSD > >> Foundation. (This "feature" doesn't exist in HardenedBSD's > >> implementation.) If comments like these continue, I will remove th= e diff > >> from Phabricator and close the BugZilla ticket. FreeBSD can feel f= ree to > >> pull from us, but we won't make any effort to proactively upstream= our > >> work. > >>=20 > >> With that said, I have missed a few of the concerns raised. There'= s so > >> many comments/concerns in that review that it's easy to miss a few= . I > >> will address them tonight and upload a new patch tomorrow. > >=20 > > I've updated the patch. Is there anything I've missed? >=20 > I=E2=80=99ve taken a look at the updated patch and see that it addres= sed the > issues I raised. It almost looks like the update to the review a mont= h > ago was the wrong version, since so many more of the original > comments appear to be addressed than when I looked. Thanks! >=20 > Warner I've updated the patch again. Please let me know if there's anything I'= ve=20 missed. Otherwise, I'd love to see this committed in HEAD. :-) =2D-=20 Shawn Webb HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --nextPart2422452.N10iFPSzQD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVDYOcAAoJEGqEZY9SRW7uTDMP/ikvBOG9SJ3C3fipDtg+968D 5WtFqQw3AMqfzf6h1ixhB0FXOC27gBFpGvy4Hy5WG8U5l8E06aB24fyqQi6U6MUt Brb8aJg1VpjxRec2+rmPz/TbVu0LaTXgn1RnY2fVurG846ehz0e8OE09jGHbWz3u gx9Rn1yj6DAe8xeTfrEMIwhSctZgd6bjahCuPjuID3Rz0f/9RrGd7XTpClwCosWA IjrpOPdxcS5Uy0x+givcGt/1rqHVBlDMcZDQ1kcomzN6MEEe/J94N939ah4Asn3B ZoEuLeqcc8E7rqixaXbmktNfVCS2/jtdzmeChDw5isO47MUJExkwkHVneSV3ZQ0z eU1c6jL7XpD4lZqaVNYy/CCYDQW0VCi7J1W5ZYYfpDY0lzLzP8L84+iACuwNG7Xp W3wMnMOkxz9QVlxUHlsuQCMp1TZA9HTRSi9VwpoDv2mrEz8boTpwbvu928mOLrFT V5BV8nbanWgYl07duMEZ+Hto+gBeWgJF8h3OsShSNQh1+7y0r9bD+3mOr/h+tXV3 q5Dg56hNg1LOH8KNeY4yWCmxcI4aWI+GWu0qKBIY/mfMr9Yn7sMK4b498iP1fFl5 Qw/FeI5EaTdXY4wLaQPQVJH6OwRV+72Wk+BkT5OQfpcywegLZdcwzUmIgZ8sCeLA vlZX2PdT26KQFQiVB1g5 =HsOX -----END PGP SIGNATURE----- --nextPart2422452.N10iFPSzQD-- From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 15:48:22 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 13212138; Sat, 21 Mar 2015 15:48:22 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF5105F0; Sat, 21 Mar 2015 15:48:21 +0000 (UTC) Received: from John-Baldwins-MacBook-Pro.local (d-69-161-105-82.cpe.metrocast.net [69.161.105.82]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 362D3B915; Sat, 21 Mar 2015 11:48:20 -0400 (EDT) Message-ID: <550D92C6.1080002@FreeBSD.org> Date: Sat, 21 Mar 2015 11:48:22 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "K. Macy" , "freebsd-arch@freebsd.org" Subject: Re: LOCAL_CPUS vs INTR_CPUS References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Sat, 21 Mar 2015 11:48:20 -0400 (EDT) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 15:48:22 -0000 On 3/19/15 8:54 PM, K. Macy wrote: > I haven't been able to get an answer out of the usual suspects so I > thought I'd ask here. > > In reference to: > https://github.com/freebsd/freebsd/compare/master...bsdjhb:numa_bus_get_cpus > > > The LOCAL_CPUS option will return the cpuset corresponding to the NUMA > (_pxm) domain id of a given device. INTR_CPUS can narrow that further. > However, in this particular branch INTR_CPUS will only ever return the > value given by LOCAL_CPUS. When and where would this come in to > effect? Do the new Haswells have cores in the same memory domain but > with non-uniform access to the PCIe bus? On x86 this means that INTR_CPUS only includes one thread per core in a the NUMA domain a device belongs to whereas LOCAL_CPUS will include all threads in the domain. So if you have a dual-socket 8-core SB/IB system for example, a device on the IO hub for the first processor would use CPUs 0-15 for LOCAL_CPUS and 0,2,4,6,8,10,12,14 for INTR_CPUS if HTT is enabled. If it is disabled, both requests would return CPUs 0-7. For the Haswell CPUs with dual rings, my understanding is that those will be represented as two NUMA domains (since there are two memory controllers) and that _PXM for the Host-PCI bridge will reflect the NUMA domain of the ring that contains the IO Hub. This means that LOCAL_CPUS/INTR_CPUS would only return CPUs on the ring that contains the IO Hub, but not other CPUs in the same package on the second ring. However, I would need to see an acpidump from such a machine to confirm that this what ACPI actually tells us. (I think it kind of has to in that the SRAT will have to treat the memory controllers as separate domains and _PXM can only return a single domain, not a list.) -- John Baldwin From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 19:24:26 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC25AD6C; Sat, 21 Mar 2015 19:24:26 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id B6C3DDEE; Sat, 21 Mar 2015 19:24:26 +0000 (UTC) Received: from AlfredMacbookAir.local (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id 91E81341F869; Sat, 21 Mar 2015 12:24:20 -0700 (PDT) Message-ID: <550DC564.5020802@freebsd.org> Date: Sat, 21 Mar 2015 12:24:20 -0700 From: Alfred Perlstein Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Slawa Olhovchenkov , John Baldwin Subject: Re: RFC: Simplfying hyperthreading distinctions References: <1640664.8z9mx3EOQs@ralph.baldwin.cx> <54FA1180.3080605@astrodoggroup.com> <1526311.uylCbgv5VB@ralph.baldwin.cx> <20150320123823.GA49621@zxy.spb.ru> In-Reply-To: <20150320123823.GA49621@zxy.spb.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Harrison Grundy , freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 19:24:27 -0000 John, Just a quick note on this, hopefully it's not too off-topic... We need to detect if HTT or SMT is enabled, right now there are no sysctl nodes to detect this and instead we have to parse xml out of the scheduler... Does it make sense to have a basic sysctl tree for this? hw.cpu.threading.smt=0 hw.cpu.threading.htt=0 or something? On 3/20/15 5:38 AM, Slawa Olhovchenkov wrote: > On Fri, Mar 06, 2015 at 04:17:37PM -0500, John Baldwin wrote: > >> On Friday, March 06, 2015 12:43:44 PM Harrison Grundy wrote: >>> On 03/06/15 12:44, John Baldwin wrote: >>>> Currently we go out of our way a bit to distinguish Pentium4-era >>>> hyperthreading from more recent ("modern") hyperthreading. I >>>> suspect that this distinction probably results in confusion more >>>> than anything else. Intel's documentation does not make near as >>>> broad a distinction as far as I can tell. Both types of SMT are >>>> called hyperthreading in the SDM for example. However, we have the >>>> astonishing behavior that 'machdep.hyperthreading_allowed' only >>>> affects "old" hyperthreads, but not "new" ones. We also try to be >>>> overly cute in our dmesg output by using HTT for "old" >>>> hyperthreading, and SMT for "new" hyperthreading. I propose the >>>> following changes to simplify things a bit: >>>> >>>> 1) Call both "old" and "new" hyperthreading HTT in dmesg. >>>> >>>> 2) Change machdep.hyperthreading_allowed to apply to both new and >>>> old HTT. However, doing this means a POLA violation in that we >>>> would now disable modern HTT by default. Balanced against >>>> re-enabling "old" HTT by default on an increasingly-shrinking pool >>>> of old hardware, I think the better approach here would be to also >>>> change the default to allow HTT. >>>> >>>> 3) Possibly add a different knob (or change the behavior of >>>> machdep.hyperthreading_allowed) to still bring up hyperthreads, but >>>> leave them out of the default cpuset (set 1). This would allow >>>> those threads to be re-enabled dynamically at runtime by adjusting >>>> the mask on set 1. The original htt settings back when >>>> 'hyperthreading_allowed' was introduced actually permitted this via >>>> by adjusting 'machdep.hlt_cpus' at runtime. >>>> >>>> What do people think? >>> I'm not sure of how interrupt handling works as it relates to HTT, but >>> wouldn't using cpuset potentially leave them active for interrupt >>> handling? >>> >>> Other than that question, this all makes sense to me. >> Interrupt handling works differently. Per my commit a few minutes ago, we do >> not send interrupts to hyperthreads by default (either old or new). However, >> ithreads that are not explicitly bound to a specific CPU will "float" among >> all the CPUs in set 1 so 3) would affect that. Eventually I want to use a >> separate cpuset for interrupts that ithreads inherit from (rather than >> belonging to set 1). > Can you explain interrupt handling some more? > How routing real interrupt? Can be real interrupt routing to specific > core? > Is real interrupt and `cpuset -x irq` is same (I see interrup from > chelsio on cpu other then pinned)? > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 19:43:51 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18FAA56E; Sat, 21 Mar 2015 19:43:51 +0000 (UTC) Received: from frv158.fwdcdn.com (frv158.fwdcdn.com [212.42.77.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 74E4075; Sat, 21 Mar 2015 19:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ukr.net; s=fsm; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date; bh=rPGLg7fLGKkSja4ih4ts1qofj4tT6IGE0Ij9z5Gsoyc=; b=vNgXUsWcDH70AfLLhEoKXe82h++ynPwDBbIuwciFaLE3kcv2OEAUrijtNIU57lgFcDlKOExOlMXQ2/PmJfqw3rBcXqvLjNFdSzf453oMjNsb8LVthMjUmtOe4RDiBjUEeid1Qv8f3bXBnAVwdz0CwgAwNlDGzW0Bl0Mrx+MCA9I=; Received: from [46.211.113.164] (helo=nonamehost.local) by frv158.fwdcdn.com with esmtpsa ID 1YZPJ8-000PlF-1A ; Sat, 21 Mar 2015 21:43:42 +0200 Date: Sat, 21 Mar 2015 21:43:35 +0200 From: Ivan Klymenko To: Alfred Perlstein Subject: Re: RFC: Simplfying hyperthreading distinctions Message-ID: <20150321214336.334eaea5@nonamehost.local> In-Reply-To: <550DC564.5020802@freebsd.org> References: <1640664.8z9mx3EOQs@ralph.baldwin.cx> <54FA1180.3080605@astrodoggroup.com> <1526311.uylCbgv5VB@ralph.baldwin.cx> <20150320123823.GA49621@zxy.spb.ru> <550DC564.5020802@freebsd.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Authentication-Result: IP=46.211.113.164; mail.from=fidaj@ukr.net; dkim=pass; header.d=ukr.net Cc: Harrison Grundy , freebsd-arch@freebsd.org, Slawa Olhovchenkov X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 19:43:51 -0000 =D0=92 Sat, 21 Mar 2015 12:24:20 -0700 Alfred Perlstein =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > John, >=20 > Just a quick note on this, hopefully it's not too off-topic... >=20 > We need to detect if HTT or SMT is enabled, right now there are no=20 > sysctl nodes to detect this and instead we have to parse xml out of > the scheduler... >=20 > Does it make sense to have a basic sysctl tree for this? >=20 > hw.cpu.threading.smt=3D0 > hw.cpu.threading.htt=3D0 >=20 > or something? >=20 I am sorry that I interfere Why then not use kern.smp.topology for this purpose? From owner-freebsd-arch@FreeBSD.ORG Sat Mar 21 22:26:26 2015 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8344553E; Sat, 21 Mar 2015 22:26:26 +0000 (UTC) Received: from mail-yk0-x233.google.com (mail-yk0-x233.google.com [IPv6:2607:f8b0:4002:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3EE5E273; Sat, 21 Mar 2015 22:26:26 +0000 (UTC) Received: by ykfs63 with SMTP id s63so57353080ykf.2; Sat, 21 Mar 2015 15:26:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=ScRJX2EjEYkxcdXp3vitmPLMsVkDIEik4iyHINp6fc4=; b=P8NjzzuVd3Vp0A4z9ROVfuNllJT3VEmx6x57BY/RNpVrYdWO7uS5S+KpxeRoouWknl +5RIvpa32oylBfeRYMZMWR1xnzYRQhrutD/5KmSVkz70xVAulI8S2qd0XLZL2ZV4Lq0A vYYV21zLmSDOvPq6bYL8S7fZMOcRMIJif8QCXF3/aDFKQh5pf3Vfg0/2robr1efam5ht YwJPEqNvyvuTuU+OLm5nvRuD24h6od3gwDDf88G+m/IQQY8yCBJvC1LdZH8in0dtoBOw 0oW52GdvzHQxtTUUDJeEvC0XJfKcIgw/uQMNe5aBINEC5MnWnhQx2akiUoU7UWB4q1Ht kKMQ== MIME-Version: 1.0 X-Received: by 10.170.98.133 with SMTP id p127mr53401872yka.115.1426976785325; Sat, 21 Mar 2015 15:26:25 -0700 (PDT) Sender: kmacybsd@gmail.com Received: by 10.170.205.193 with HTTP; Sat, 21 Mar 2015 15:26:25 -0700 (PDT) In-Reply-To: <550D92C6.1080002@FreeBSD.org> References: <550D92C6.1080002@FreeBSD.org> Date: Sat, 21 Mar 2015 15:26:25 -0700 X-Google-Sender-Auth: kKyJfirJKfKZyd5GDl-OMpz3DoA Message-ID: Subject: Re: LOCAL_CPUS vs INTR_CPUS From: "K. Macy" To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2015 22:26:26 -0000 >> In reference to: >> https://github.com/freebsd/freebsd/compare/master...bsdjhb:numa_bus_get_cpus >> >> >> The LOCAL_CPUS option will return the cpuset corresponding to the NUMA >> (_pxm) domain id of a given device. INTR_CPUS can narrow that further. >> However, in this particular branch INTR_CPUS will only ever return the >> value given by LOCAL_CPUS. When and where would this come in to >> effect? Do the new Haswells have cores in the same memory domain but >> with non-uniform access to the PCIe bus? > > On x86 this means that INTR_CPUS only includes one thread per core in a > the NUMA domain a device belongs to whereas LOCAL_CPUS will include all > threads in the domain. So if you have a dual-socket 8-core SB/IB system > for example, a device on the IO hub for the first processor would use > CPUs 0-15 for LOCAL_CPUS and 0,2,4,6,8,10,12,14 for INTR_CPUS if HTT is > enabled. If it is disabled, both requests would return CPUs 0-7. > I was confused by the fact that it was propagating it up the chain only to have the nexus return intr_cpus and was in turn overlooking intr_cpus being initialized in set_interrupt_apic_ids . The appearance being that it was leaving the door open for some intermediate node to narrow the cpuset - and nexus was just the default. As it stands now just directly OR'ing LOCAL_CPUS with intr_cpus now that you've made it a global would make more sense. But perhaps the added flexibility will prove useful in the future. Thanks.