Date: Tue, 19 May 2015 17:29:36 -0400 From: John Baldwin <jhb@freebsd.org> To: 'freebsd-arch' <freebsd-arch@freebsd.org> Subject: Expand ktr mask to 64 bits Message-ID: <15438042.GxsTiGo31d@ralph.baldwin.cx>
next in thread | raw e-mail | index | archive | help
A common topic has been that the current set of KTR masks is bursting at the seams. I've wanted to fix it by providing some sort of per-class mask and other stuff in the past. However, just changing the masks from int to uint64_t will double the bits we have to work with. It's also a very simple change. It turns out we don't actually need to update the mask with atomic ops anyway since the downside of losing races while changing ktr_mask is pretty minor (may get fewer or more traces). Plus, we don't mark ktr_mask as volatile, so the compiler is free to cache its value anyway making several of those races far wider than worrying about changes to two adjacent words. I've put the diff up at https://reviews.freebsd.org/D2595 for anyone who'd like to review. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15438042.GxsTiGo31d>