From owner-freebsd-geom@freebsd.org Mon Jun 29 01:38:11 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A5B598C53A for ; Mon, 29 Jun 2015 01:38:11 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 27889165E for ; Mon, 29 Jun 2015 01:38:07 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id E5C2037B402 for ; Sun, 28 Jun 2015 20:30:11 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mKWTb2MC7z14q; Sun, 28 Jun 2015 20:30:11 -0500 (CDT) Date: Sun, 28 Jun 2015 20:30:11 -0500 From: "Matthew D. Fuller" To: freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150629013011.GN50491@over-yonder.net> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150615060128.GC1733@over-yonder.net> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 01:38:11 -0000 On Mon, Jun 15, 2015 at 01:01:28AM -0500 I heard the voice of Matthew D. Fuller, and lo! it spake thus: > > But presumably geli should treat that spoil event the same as an > orpah, which at least avoids the panic and does the least wrong > thing in the circumstances. Since the events DO occur (the code > suggests the original thought was that they couldn't), we might as > well deal with them as gracefully as possible. Patch stuck in bugzilla at to not get lost. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Mon Jun 29 01:38:43 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F4C798C562 for ; Mon, 29 Jun 2015 01:38:43 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E531169A for ; Mon, 29 Jun 2015 01:38:43 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 61F9F37B403 for ; Sun, 28 Jun 2015 20:38:42 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mKWgP6Cv7z150; Sun, 28 Jun 2015 20:38:41 -0500 (CDT) Date: Sun, 28 Jun 2015 20:38:41 -0500 From: "Matthew D. Fuller" To: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150629013841.GO50491@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150324021924.GQ52331@over-yonder.net> <20150502125220.GS78376@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150502125220.GS78376@over-yonder.net> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 01:38:43 -0000 > > Stuffed into bugzilla as > > > [...] > > After last round, everybody seems happy enough with this, so I've > > filed it as > > . > > Does anybody have outstanding concerns on these? Or, if not, what > else do we need to move them along? They're working fine for me > here... Ping... still working fine here, and I'm pretty sure I've addressed every concern anybody's raised. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Wed Jul 1 15:41:26 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7930999187B for ; Wed, 1 Jul 2015 15:41:26 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id 441DE2CFD for ; Wed, 1 Jul 2015 15:41:25 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 20983586; Wed, 1 Jul 2015 17:41:18 +0200 (CEST) Date: Wed, 1 Jul 2015 17:42:33 +0200 From: Pawel Jakub Dawidek To: "Matthew D. Fuller" Cc: freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150701154233.GA1456@garage.freebsd.pl> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline In-Reply-To: <20150629013011.GN50491@over-yonder.net> X-OS: FreeBSD 11.0-CURRENT amd64 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 15:41:26 -0000 --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 28, 2015 at 08:30:11PM -0500, Matthew D. Fuller wrote: > On Mon, Jun 15, 2015 at 01:01:28AM -0500 I heard the voice of > Matthew D. Fuller, and lo! it spake thus: > >=20 > > But presumably geli should treat that spoil event the same as an > > orpah, which at least avoids the panic and does the least wrong > > thing in the circumstances. Since the events DO occur (the code > > suggests the original thought was that they couldn't), we might as > > well deal with them as gracefully as possible. >=20 > Patch stuck in bugzilla at > to not get > lost. Hi Matthew. The spoil event happens when provider is open for writting for the first time (its open-for-write counter goes from 0 to >0). Since GELI opens its providers always exclusively there can be no write opens, thus the spoil event is unexpected. To see what exactly is happening I'd need to see the console output from before that happens with kern.geom.debugflags set to 5. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVlAppAAoJEJVLhSuxKFt1lR8QAKQN7uxuB4VTmtLr2h9yyqM7 lcJdJri2PHKCkrlfKpymVYcHf/uYXR3XDvXQ4znJ/tpWjloIJoTo9kLN/6WkzyxD sCPBLPIhzJB/uXoMjo2mLSJsX6Xshl5w1P18nkdnyqUMtaexPBq2QcYbkDYQjNbs P3BogzxaTwUyco8ah01BKiZOzgW4KH7zmeWT/Bc7XrfEiuSm5oZpq3qO5+/8AQxo Z3qo5rye/CXvuNFQX1k3L3yqYo0+yzQ9ssJv/mjE9wclg8x9ZnIVPhtxSza1aHR8 Z/VeEnoNw1+AWhBWGQPpiVrl+lhCg67Sn9iHCV9HnFEJhC4XF6c0GTIX3nQnqLBE 0cFDiMGOPcymuVNo2v7/nJ5+wgcOVE6PMy9sXDcg30SQvg9Bfq9AkGrwYK5SoyFW fNEVYs/NpXLmHUVOMMp8oQNhOvMLnUxbLobGgIQD3gbt3k+WnZFm+WugTVKWtMU4 PL2rJLETtw75tRoZDkJDI+pB4hrK4cv0SAYXW2JQXMKFF62g52B5HRHuIWg/oEYn cyb2EZ+1GpzCJo0040L2RFLKIVJ9lkV7wkRKFbmjauaMAoYKzvJfmJ5FlfcYbDox UIVtov7VQ7y+0A5yJR5Il1dgrDZDjQxx4oRafBk11iAKop+rhUE1RAbw6aL4lNsM gGWZ40Ga8zhxXfvopBKt =9qRB -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5-- From owner-freebsd-geom@freebsd.org Wed Jul 1 19:30:35 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDAFE991B17 for ; Wed, 1 Jul 2015 19:30:35 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98BE52938; Wed, 1 Jul 2015 19:30:35 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 078DD37B54F; Wed, 1 Jul 2015 14:30:28 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mMCM72W5yz2Xh; Wed, 1 Jul 2015 14:30:27 -0500 (CDT) Date: Wed, 1 Jul 2015 14:30:27 -0500 From: "Matthew D. Fuller" To: Pawel Jakub Dawidek Cc: =?iso-8859-1?Q?Jos=E9_Garc=EDa?= Juanino , freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150701193027.GT50491@over-yonder.net> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150701154233.GA1456@garage.freebsd.pl> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 19:30:35 -0000 On Wed, Jul 01, 2015 at 05:42:33PM +0200 I heard the voice of Pawel Jakub Dawidek, and lo! it spake thus: > > The spoil event happens when provider is open for writting for the > first time (its open-for-write counter goes from 0 to >0). Since > GELI opens its providers always exclusively there can be no write > opens, thus the spoil event is unexpected. Well, from OP (https://lists.freebsd.org/pipermail/freebsd-current/2015-June/056193.html) it's coming from a CD media change event. The BT linked from the mail shows. panic() at panic+0x43/frame 0xfffffe011ba81b00 g_eli_orphan_spoil_assert() at g_eli_orphan_spoil_assert+0x1f/frame 0xfffffe011ba81b10 g_spoil_event() at g_spoil_event+0x72/frame 0xfffffe011ba81b40 g_media_changed_event() at g_media_changed_event+0x68/frame 0xfffffe011ba81b70 g_run_events() at g_run_events+0x1a7/frame 0xfffffe011ba81bb0 > To see what exactly is happening I'd need to see the console output > from before that happens with kern.geom.debugflags set to 5. 'd have to talk to José for that; added him back to CC. -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Wed Jul 1 22:53:13 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81FB3992E00 for ; Wed, 1 Jul 2015 22:53:13 +0000 (UTC) (envelope-from jjuanino@gmail.com) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 447492E07; Wed, 1 Jul 2015 22:53:13 +0000 (UTC) (envelope-from jjuanino@gmail.com) Received: by igblr2 with SMTP id lr2so45185120igb.0; Wed, 01 Jul 2015 15:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=HiWvevZGsX2irJWw/nDPG5NJMpEEY8B41WLcH+sAb7I=; b=R5eG2CRiENIG9EvuMr+7y45j1gmgodoGYa684XlqrhXr07647JuotR4BYhrMd8ezjq VFw+REfQC4N0+QnOk1doXprJbWYWhQ4JHBmtSkJcSUmv9894a1oL+acyDORYNHKMz5MW KG8ang8hcKjpYkrA+UBbmFGRqzr41FZ42aQuzzI+tXU0k8R6jtQgsdMhGeGJk7d8Xh4P FQn8sl5G6lNbvWvuPUHNnhPWPJJtzFyirJonv+m0ViJ20mXBuUNh8FbefEImgqo8rVRA AdjdBTBFcKfjsHy3UUwEPSb2NQUuftgNjxuSLBuNAI7LiN6jAvo/lNCMe42CAEFM++7I ke0A== MIME-Version: 1.0 X-Received: by 10.107.38.139 with SMTP id m133mr41610769iom.51.1435791192492; Wed, 01 Jul 2015 15:53:12 -0700 (PDT) Received: by 10.64.76.13 with HTTP; Wed, 1 Jul 2015 15:53:12 -0700 (PDT) In-Reply-To: <20150701193027.GT50491@over-yonder.net> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> <20150701193027.GT50491@over-yonder.net> Date: Thu, 2 Jul 2015 00:53:12 +0200 Message-ID: Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli From: =?UTF-8?B?Sm9zw6kgR2FyY8OtYSBKdWFuaW5v?= To: "Matthew D. Fuller" Cc: Pawel Jakub Dawidek , freebsd-geom@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2015 22:53:13 -0000 On 1 July 2015 at 21:30, Matthew D. Fuller wrote= : > On Wed, Jul 01, 2015 at 05:42:33PM +0200 I heard the voice of > Pawel Jakub Dawidek, and lo! it spake thus: >> >> The spoil event happens when provider is open for writting for the >> first time (its open-for-write counter goes from 0 to >0). Since >> GELI opens its providers always exclusively there can be no write >> opens, thus the spoil event is unexpected. > > Well, from OP > (https://lists.freebsd.org/pipermail/freebsd-current/2015-June/056193.htm= l) > it's coming from a CD media change event. The BT linked from the mail > shows. > > panic() at panic+0x43/frame 0xfffffe011ba81b00 > g_eli_orphan_spoil_assert() at g_eli_orphan_spoil_assert+0x1f/frame 0xfff= ffe011ba81b10 > g_spoil_event() at g_spoil_event+0x72/frame 0xfffffe011ba81b40 > g_media_changed_event() at g_media_changed_event+0x68/frame 0xfffffe011ba= 81b70 > g_run_events() at g_run_events+0x1a7/frame 0xfffffe011ba81bb0 > > >> To see what exactly is happening I'd need to see the console output >> from before that happens with kern.geom.debugflags set to 5. > > 'd have to talk to Jos=C3=A9 for that; added him back to CC. Hi, thanks for your support! You can see the console output here, after setting kern.geom.debugflags=3D5 in /boot/loader.conf: http://picpaste.com/panic_geli.jpg Previously, I ran: # geli attach -r /dev/cd0 # mount /dev/cd0.eli /cdrom ### close the laptop lid and waits a few seconds. The system suspends. ### open the laptop again. The system resumes. Wait a few seconds: the system panics. Best regards From owner-freebsd-geom@freebsd.org Thu Jul 2 09:47:55 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1D073991D93 for ; Thu, 2 Jul 2015 09:47:55 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (garage.dawidek.net [91.121.88.72]) by mx1.freebsd.org (Postfix) with ESMTP id AF3BF1B79 for ; Thu, 2 Jul 2015 09:47:54 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id 96E187CF; Thu, 2 Jul 2015 11:47:51 +0200 (CEST) Date: Thu, 2 Jul 2015 11:49:10 +0200 From: Pawel Jakub Dawidek To: =?iso-8859-1?Q?Jos=E9_Garc=EDa?= Juanino Cc: "Matthew D. Fuller" , freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150702094909.GA1186@garage.freebsd.pl> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> <20150701193027.GT50491@over-yonder.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Content-Disposition: inline In-Reply-To: X-OS: FreeBSD 11.0-CURRENT amd64 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2015 09:47:55 -0000 --envbJBWh7q8WU6mo Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 02, 2015 at 12:53:12AM +0200, Jos=E9 Garc=EDa Juanino wrote: > On 1 July 2015 at 21:30, Matthew D. Fuller wro= te: > > On Wed, Jul 01, 2015 at 05:42:33PM +0200 I heard the voice of > > Pawel Jakub Dawidek, and lo! it spake thus: > >> > >> The spoil event happens when provider is open for writting for the > >> first time (its open-for-write counter goes from 0 to >0). Since > >> GELI opens its providers always exclusively there can be no write > >> opens, thus the spoil event is unexpected. > > > > Well, from OP > > (https://lists.freebsd.org/pipermail/freebsd-current/2015-June/056193.h= tml) > > it's coming from a CD media change event. The BT linked from the mail > > shows. > > > > panic() at panic+0x43/frame 0xfffffe011ba81b00 > > g_eli_orphan_spoil_assert() at g_eli_orphan_spoil_assert+0x1f/frame 0xf= ffffe011ba81b10 > > g_spoil_event() at g_spoil_event+0x72/frame 0xfffffe011ba81b40 > > g_media_changed_event() at g_media_changed_event+0x68/frame 0xfffffe011= ba81b70 > > g_run_events() at g_run_events+0x1a7/frame 0xfffffe011ba81bb0 > > > > > >> To see what exactly is happening I'd need to see the console output > >> from before that happens with kern.geom.debugflags set to 5. > > > > 'd have to talk to Jos=E9 for that; added him back to CC. >=20 > Hi, thanks for your support! >=20 > You can see the console output here, after setting > kern.geom.debugflags=3D5 in /boot/loader.conf: >=20 > http://picpaste.com/panic_geli.jpg >=20 > Previously, I ran: >=20 > # geli attach -r /dev/cd0 > # mount /dev/cd0.eli /cdrom >=20 > ### close the laptop lid and waits a few seconds. The system suspends. > ### open the laptop again. The system resumes. Wait a few seconds: the > system panics. THank you for the screenshot. My assumptions are out-dated. With g_media_changed() we can get spoil event even if we hold provider exclusively open. Your patch, Matthew, is correct, but could you also update the comment there to take into account g_media_changed() addition? Thanks. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://mobter.com --envbJBWh7q8WU6mo Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJVlQkVAAoJEJVLhSuxKFt1HJQP/iftlt4LxBN5jaiucb0XCiBj PB7CU35Fg202KOaKpYOhGpl3NutaoVgDbrdXsrYzdB6ScjlT5h+r0pa+NP3a4SGZ y9JLdkGtjGm/JZxGRubHnydfzVPRG7QKXN1dThxW96pAQDi5FXD+SDevZqIueoOg HGeFq8Dgda+57qvJzh1sezEsLQjRS7BxYIT6dKegbe1sqRvzc6XecS5OeB9XzNtw 3mIrfXtnEtbqlFpIs8wwiNClQhv8vAaUw+Lqvau11uyich0pFfI/R5/YFFvEIkTH 0VunN1gtlFMoUDlWbT46TjsAWRAjZN7ZpOu1v2O2Ww94a/PMy/uRrRfiu1C8NSQf Nn1vf56+tVIYd1A3TQlssvqkYrGUvQDuuf1kCqE7aJTHiDmIxO0OovNVp2igDOXK R0Ym95pp6mPcPvsFgt3tTpx2yPZze38wU+IoFCoKz67wbWjWK5N8xnUDd+iKpvQl iJ4P29FlsQSw49xagZHDahtOKR7EGmbNejFHlrdOnasqVhdTcd1E7k0bI2dUy+qY OgtoF67RiCq9gUKKwtfKne5eYaY57pNbG9tMoqQjsYxH9njVDPBAS615mXIF+QRS IcxIY2SI7OSodZDuZHgxf57RT6K+IYySj7OO6B9+uhNYpoIhO8JAA2qw2MEIUfPL qenK0M0KcoGCt3yZhq7a =5wuw -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo-- From owner-freebsd-geom@freebsd.org Thu Jul 2 20:01:18 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 03C5F993D16 for ; Thu, 2 Jul 2015 20:01:18 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from thyme.infocus-llc.com (thyme.infocus-llc.com [199.15.120.10]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D1F521B89; Thu, 2 Jul 2015 20:01:17 +0000 (UTC) (envelope-from fullermd@over-yonder.net) Received: from draco.over-yonder.net (c-75-65-60-66.hsd1.ms.comcast.net [75.65.60.66]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by thyme.infocus-llc.com (Postfix) with ESMTPSA id 667F837B567; Thu, 2 Jul 2015 15:01:10 -0500 (CDT) Received: by draco.over-yonder.net (Postfix, from userid 100) id 3mMr0563gFz1fH; Thu, 2 Jul 2015 15:01:09 -0500 (CDT) Date: Thu, 2 Jul 2015 15:01:09 -0500 From: "Matthew D. Fuller" To: Pawel Jakub Dawidek Cc: =?iso-8859-1?Q?Jos=E9_Garc=EDa?= Juanino , freebsd-geom@freebsd.org Subject: Re: geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli Message-ID: <20150702200109.GC50491@over-yonder.net> References: <20150613224602.GB1733@over-yonder.net> <20150615060128.GC1733@over-yonder.net> <20150629013011.GN50491@over-yonder.net> <20150701154233.GA1456@garage.freebsd.pl> <20150701193027.GT50491@over-yonder.net> <20150702094909.GA1186@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150702094909.GA1186@garage.freebsd.pl> X-Editor: vi X-OS: FreeBSD User-Agent: Mutt/1.5.23-fullermd.4 (2014-03-12) X-Virus-Scanned: clamav-milter 0.98.7 at thyme.infocus-llc.com X-Virus-Status: Clean X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2015 20:01:18 -0000 On Thu, Jul 02, 2015 at 11:49:10AM +0200 I heard the voice of Pawel Jakub Dawidek, and lo! it spake thus: > > With g_media_changed() we can get spoil event even if we hold > provider exclusively open. Your patch, Matthew, is correct, but > could you also update the comment there to take into account > g_media_changed() addition? Sure, you mean replacing the comment saying spoiling can't happen? Something like: Index: g_eli.c =================================================================== --- g_eli.c (revision 285057) +++ g_eli.c (working copy) @@ -730,10 +730,10 @@ sc = malloc(sizeof(*sc), M_ELI, M_WAITOK | M_ZERO); gp->start = g_eli_start; /* - * Spoiling cannot happen actually, because we keep provider open for - * writing all the time or provider is read-only. + * Spoiling can happen even though we have the provider open + * exclusively, e.g. through media change events. */ - gp->spoiled = g_eli_orphan_spoil_assert; + gp->spoiled = g_eli_orphan; gp->orphan = g_eli_orphan; gp->dumpconf = g_eli_dumpconf; /* I did leave alone the asserting on both orphan and spoil in g_eli_read_metadata(). Since that's creating and destroying the consumer all in one straight-line function, it makes sense to be "impossible". I s'pose it's possible a race with media change could cause it to happen, but I'm willing to ignore that for now :) -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream. From owner-freebsd-geom@freebsd.org Fri Jul 3 03:24:11 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DBB1994565 for ; Fri, 3 Jul 2015 03:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B50A195B for ; Fri, 3 Jul 2015 03:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t633OBmb015573 for ; Fri, 3 Jul 2015 03:24:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 201185] [patch] geli: don't panic on spoil events Date: Fri, 03 Jul 2015 03:24:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 03:24:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201185 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-geom@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 3 03:28:47 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 822C39945CC for ; Fri, 3 Jul 2015 03:28:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E7CD1A32 for ; Fri, 3 Jul 2015 03:28:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t633SlWu020239 for ; Fri, 3 Jul 2015 03:28:47 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 200740] work around KASSERT panic due to race between GEOM tasting and withering Date: Fri, 03 Jul 2015 03:28:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to short_desc keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 03:28:47 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200740 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-geom@FreeBSD.org Summary|KASSERT panic due to race |work around KASSERT panic |between GEOM tasting and |due to race between GEOM |withering |tasting and withering Keywords| |patch -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 3 05:05:43 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A4CA993500 for ; Fri, 3 Jul 2015 05:05:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B87221D8 for ; Fri, 3 Jul 2015 05:05:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t6355gT0023187 for ; Fri, 3 Jul 2015 05:05:42 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 197309] ggatec broken since r238119 (ioctl(/dev/ggctl): Invalid argument) Date: Fri, 03 Jul 2015 05:05:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.1-STABLE X-Bugzilla-Keywords: easy, needs-qa, patch, patch-ready, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: mfc-stable10? X-Bugzilla-Changed-Fields: cc version bug_status short_desc flagtypes.name bug_file_loc keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 05:05:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197309 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koobs@FreeBSD.org, | |pjd@FreeBSD.org Version|10.0-RELEASE |10.1-STABLE Status|New |Open Summary|ggatec has been broken |ggatec broken since r238119 |since rev 238119 |(ioctl(/dev/ggctl): Invalid | |argument) Flags| |mfc-stable10? URL| |https://svnweb.freebsd.org/ | |base?view=revision&revision | |=238119 Keywords| |easy, needs-qa, | |patch-ready, regression --- Comment #8 from Kubilay Kocak --- Thank you for the patch Fabian. CC original committer (pjd) for what appears to be very simple (and confirmed) fix, for resolution in 10.2-RELEASE -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-geom@freebsd.org Fri Jul 3 08:22:50 2015 Return-Path: Delivered-To: freebsd-geom@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BBE3993116 for ; Fri, 3 Jul 2015 08:22:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 183521F32 for ; Fri, 3 Jul 2015 08:22:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t638MnNu031867 for ; Fri, 3 Jul 2015 08:22:49 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-geom@FreeBSD.org Subject: [Bug 200740] work around KASSERT panic due to race between GEOM tasting and withering Date: Fri, 03 Jul 2015 08:22:49 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: avg@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-geom@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 08:22:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200740 Andriy Gapon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |avg@FreeBSD.org --- Comment #1 from Andriy Gapon --- I once wrote the following patch: http://thread.gmane.org/gmane.os.freebsd.devel.geom/5280 but never committed it. I wonder if the patch would help here as well. Could you please test? P.S. If you have any problem adapting the patch to the current code please let me know and I will do it. -- You are receiving this mail because: You are the assignee for the bug.