From owner-freebsd-net@FreeBSD.ORG Sun Feb 15 03:23:05 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D61F37E9 for ; Sun, 15 Feb 2015 03:23:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B43D5E5C for ; Sun, 15 Feb 2015 03:23:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1F3N5eh061577 for ; Sun, 15 Feb 2015 03:23:05 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1F3N5a3061576; Sun, 15 Feb 2015 03:23:05 GMT (envelope-from root) Date: Sun, 15 Feb 2015 03:23:05 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Updated, 4 lines] D1648: Add stubs for deprecated VC messages Message-ID: <28753fa59c2d06e3e13e846e99bcdbde@localhost.localdomain> X-Priority: 3 Thread-Topic: D1648: Add stubs for deprecated VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2MyNjI4YjVjODUwMDVhYzYxNTNkMjEyYzRlIFTgERk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 03:23:05 -0000 rstone updated this revision to Diff 3772. rstone added a comment. Remove unnecessary code and remove reference to Linux driver CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1648?vs=3401&id=3772 BRANCH review_D1648 REVISION DETAIL https://reviews.freebsd.org/D1648 AFFECTED FILES sys/dev/ixl/if_ixl.c To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Sun Feb 15 15:41:08 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F6C478F for ; Sun, 15 Feb 2015 15:41:08 +0000 (UTC) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com [209.85.215.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D504F648 for ; Sun, 15 Feb 2015 15:41:07 +0000 (UTC) Received: by labpv20 with SMTP id pv20so24085049lab.8 for ; Sun, 15 Feb 2015 07:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berentweb.com; s=google; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=uPyJeJee1qGa6EuGjvW0ZLF1HtifZ5+T9d9cgXpZKHo=; b=MKWGAIy6mnWhZNEgpFwnoMBTzVIHBtgHnZgfSmZdBfQZgB1hcxhYZ9wQfXOOOyFx5z I56lis3gQFjt2A2KRBBziO6w2uWoO4DGK0XY5bQwzIPd+Q5XFjmKo7MhuW+0PYbJSle8 8y4+VpwcGkVm0njeaT2TocqkXp1a99oc1xijQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=uPyJeJee1qGa6EuGjvW0ZLF1HtifZ5+T9d9cgXpZKHo=; b=iIdBULHaxGvIHCAGMIVU7a9AdDiS0tVcPI2qX9VnCIWBfQGcXiWoRCaGg0SJ6QMSJF DulAhnSUBOvKsteO1FgRV80sqiIoyT65BjE8P9S752+GlN+FUv8tbhipxQLM0Ex27aDq dTRNLajCclhHj0MNYBjB0ChikQrfI5YWB4E1sg6EykkQ8Da/yNVJ2TImQfX8hoN1gReS p3MPqSjWwFyhM9Rk9vkugo+t4P+lTB+UD28lBsdLMU4YuelT/2gMPJXvoI8XuuvK/Bpq IFL0x411Aj+AR+h2jdyG3Oqi8ZdaD/GfsRch6ckclh0mea73xpsuk8VCJeTqduyhi4Dy Z9yQ== X-Gm-Message-State: ALoCoQlqiA+V1JVVKv2VzYKdBhEu/jmJh9F3B+5t0RrKxODvbrf5j/chWN8dCCWL03zOxChBD9kp X-Received: by 10.152.7.204 with SMTP id l12mr17732170laa.1.1424014859395; Sun, 15 Feb 2015 07:40:59 -0800 (PST) Received: from rsbsd.rsb ([31.200.18.113]) by mx.google.com with ESMTPSA id m8sm2459607laj.29.2015.02.15.07.40.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 15 Feb 2015 07:40:58 -0800 (PST) Date: Sun, 15 Feb 2015 17:40:56 +0200 From: Beeblebrox To: freebsd-net@freebsd.org Subject: NFS and diskless: some questions re nfs_diskless.c Message-ID: <20150215174056.34912959@rsbsd.rsb> In-Reply-To: <20150214145309.38238df2@rsbsd.rsb> References: <20150213142516.569ecc44@rsbsd.rsb> <1957238464.3335859.1423879252335.JavaMail.root@uoguelph.ca> <20150214145309.38238df2@rsbsd.rsb> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Feb 2015 15:41:08 -0000 I have several questions on implementing the features in nfs_diskless.c. Un= derstanding these parameters are necessary to get a decent menu-driven (gru= b2) boot process working for clients. 1. for diskless clients get mounted as V2 instead of V3. I have defi= ned { boot.nfsroot.options=3D"nfsv3" }, but has no effect. Does the kernel = need (options BOOTP_NFSV3)? Considering that nfs_diskless.c routine checks = "get handle size. If this succeeds, it's an NFSv3 setup" and {nd3->root_fhs= ize =3D len; is_nfsv3 =3D 1;} might there be easier solution? 2. My DHCP server has {option root-path} defined and correctly mounts the N= FS root. However, I would like to offer amd64/i386 choice from menu, which = requires different root-path. I therefore plan to remove {option root-path}= from dhcp.conf and pass nfsroot parameter in the boot menu using params ( = boot.nfsroot.server=3D"192.168.2.1" \ boot.nfsroot.path=3D"/data/amd64" ) Yet when I do that, the kernel is booted, NIC goes up but: re0 link state changed to UP Received DHCP Ack packet on re0 from 192.168.2.1 (accepted) DHCP/BOOTP timeout for server 255.255.255.255 The client is on 192.168.2.0/26 (broadcast is 192.168.2.63), Kernel has (op= tions BOOTP/ options BOOTP_NFSROOT). Is there a solution to this? Regards. --=20 FreeBSD_amd64_11-Current_RadeonKMS From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 00:56:40 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4A3B453F for ; Mon, 16 Feb 2015 00:56:40 +0000 (UTC) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id ECA66EC8 for ; Mon, 16 Feb 2015 00:56:39 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BJBQCAP+FU/95baINcg1haBIJ/vy8KhSdKAoFYAQEBAQEBfIQMAQEBAwEBAQEgBCcgCwUWGAICDRkCKQEJJgYIBwQBGgIEiAQIDbYCljYBAQEBAQEEAQEBAQEBAQEagSGJa4QcAQEbNAeCaIFCBYo6iFWDQYNviQKIOyKEDCAxB4EEOX8BAQE X-IronPort-AV: E=Sophos;i="5.09,584,1418101200"; d="scan'208";a="192738011" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-annu.net.uoguelph.ca with ESMTP; 15 Feb 2015 19:56:32 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 7E2BAB3F4D; Sun, 15 Feb 2015 19:56:32 -0500 (EST) Date: Sun, 15 Feb 2015 19:56:32 -0500 (EST) From: Rick Macklem To: Beeblebrox Message-ID: <424747461.3929611.1424048192500.JavaMail.root@uoguelph.ca> In-Reply-To: <20150215174056.34912959@rsbsd.rsb> Subject: Re: NFS and diskless: some questions re nfs_diskless.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.10] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 00:56:40 -0000 Beeblebrox wrote: > I have several questions on implementing the features in > nfs_diskless.c. Understanding these parameters are necessary to get > a decent menu-driven (grub2) boot process working for clients. > > 1. for diskless clients get mounted as V2 instead of V3. I > have defined { boot.nfsroot.options="nfsv3" }, but has no effect. > Does the kernel need (options BOOTP_NFSV3)? Considering that > nfs_diskless.c routine checks "get handle size. If this succeeds, > it's an NFSv3 setup" and {nd3->root_fhsize = len; is_nfsv3 = 1;} > might there be easier solution? > Well, after r212125 (about 4.5yrs ago) in head/lib/libstand/nfs.c, this code knows how to do NFSv3. If you are using a pxeboot built with this code, I don't know why you would still get NFSv2 instead of NFSv3. (Check the line for "/" in the diskless root's /etc/fstab to see if a version of NFS is specified there. If not, you could try adding the "nfsv3" option to that line.) However, from what you say below, it doesn't sound like you are using the info that pxeboot sets up. > 2. My DHCP server has {option root-path} defined and correctly mounts > the NFS root. However, I would like to offer amd64/i386 choice from > menu, which requires different root-path. I therefore plan to remove > {option root-path} from dhcp.conf and pass nfsroot parameter in the > boot menu using params ( boot.nfsroot.server="192.168.2.1" \ > boot.nfsroot.path="/data/amd64" ) > Yet when I do that, the kernel is booted, NIC goes up but: > re0 link state changed to UP > Received DHCP Ack packet on re0 from 192.168.2.1 (accepted) > DHCP/BOOTP timeout for server 255.255.255.255 > The client is on 192.168.2.0/26 (broadcast is 192.168.2.63), Kernel > has (options BOOTP/ options BOOTP_NFSROOT). Is there a solution to > this? > There are 2 different ways the kernel can be built for a diskless NFS root. 1 - options NFS_ROOT (but not BOOTP + BOOTP_NFSROOT) For this case, the kernel expects a bunch of boot environment variables to be set and a function (called nfs_diskless(), I think?) fills in a structure called nfs_diskless or nfsv3_diskless from these environment variables. Although it could be done other ways, normally these environment variables are filled in by pxeboot from the DHCP server's info plus what the files in the diskless root fs say. (It uses lib/libstand/nfs.c to talk to the diskless root fs on the NFS server.) 2 - options BOOTP + BOOTP_NFSROOT For this case, code in the kernel sys/nfs/bootp_subr.c talks to the DHCP server and the diskless root fs to find out what it needs to fill in the structure (nfs_diskless or nfsv3_diskless). 1 and 2 are independent. Depending on the kernel config options, the code does one or the other. (Take a look at the beginning of nfs_mountroot() in sys/fs/nfsclient/nfs_clvfsops.c.) Although this stuff is confusing and convoluted, I think if you build a kernel with "options NFS_ROOT" (but bot the others), a boot loader can fill in the environment variables and have them used, just like pxeboot does. Look in sys/nfs/nfs_diskless.c for the comment at the beginning of nfs_setup_diskless() to see what these environment variables are. (Remember this won't be called if BOOTP + BOOTP_NFSROOT kernel options are specified.) Good luck with it. You will probably want to add a bunch of printf()s to the above mentioned functions to try and figure out what gets executed and what gets set. rick > Regards. > -- > FreeBSD_amd64_11-Current_RadeonKMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to > "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 01:08:40 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4ED01696 for ; Mon, 16 Feb 2015 01:08:40 +0000 (UTC) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 14D7EFA7 for ; Mon, 16 Feb 2015 01:08:39 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2DWBABxQuFU/95baINcg1haBIJ/vy8KhSdKAoFYAQEBAQEBfIQMAQEBAwEBAQEgBCcgCwUuAgINGQIpAQkmBggHBAEaAgSIBAgNtgOWNwEBAQEBAQQBAQEBAQEBARqBIY4HAQEbNAeCaIFCBYo6iFWDQYNviQKIOyKEDCAxB4EEOX8BAQE X-IronPort-AV: E=Sophos;i="5.09,584,1418101200"; d="scan'208";a="191005533" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-jnhn.mail.uoguelph.ca with ESMTP; 15 Feb 2015 20:08:33 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 3192AB3F35; Sun, 15 Feb 2015 20:08:33 -0500 (EST) Date: Sun, 15 Feb 2015 20:08:33 -0500 (EST) From: Rick Macklem To: Beeblebrox Message-ID: <553358175.3932227.1424048913197.JavaMail.root@uoguelph.ca> In-Reply-To: <20150215174056.34912959@rsbsd.rsb> Subject: more re: NFS and diskless: some questions re nfs_diskless.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.12] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 01:08:40 -0000 Beeblebrox wrote: > I have several questions on implementing the features in > nfs_diskless.c. Understanding these parameters are necessary to get > a decent menu-driven (grub2) boot process working for clients. > > 1. for diskless clients get mounted as V2 instead of V3. I > have defined { boot.nfsroot.options="nfsv3" }, but has no effect. > Does the kernel need (options BOOTP_NFSV3)? If you are using the BOOTP + BOOTP_NFSROOT case then, yes, you also need "options BOOTP_NFSV3" to get it to use NFSv3 instead of NFSv2. The environment variables (except vfs.root.mountfrom, see below) are ignored for the BOOTP + BOOTP_NFSROOT case. > Considering that > nfs_diskless.c routine checks "get handle size. If this succeeds, > it's an NFSv3 setup" and {nd3->root_fhsize = len; is_nfsv3 = 1;} > might there be easier solution? This executes for the "options NFSROOT" case, not the BOOTP + BOOTP_NFSROOT one. > > 2. My DHCP server has {option root-path} defined and correctly mounts > the NFS root. However, I would like to offer amd64/i386 choice from > menu, which requires different root-path. I therefore plan to remove > {option root-path} from dhcp.conf and pass nfsroot parameter in the > boot menu using params ( boot.nfsroot.server="192.168.2.1" \ > boot.nfsroot.path="/data/amd64" ) > Yet when I do that, the kernel is booted, NIC goes up but: > re0 link state changed to UP > Received DHCP Ack packet on re0 from 192.168.2.1 (accepted) > DHCP/BOOTP timeout for server 255.255.255.255 > The client is on 192.168.2.0/26 (broadcast is 192.168.2.63), Kernel > has (options BOOTP/ options BOOTP_NFSROOT). Is there a solution to > this? > Oh, if the only thing you want to override is the root fs, I think you can set this environment variable (look at bootpc_init() in sys/nfs/bootp_subr.c) if you are using the BOOTP + BOOTP_NFSROOT case. vfs.root.mountfrom rick > Regards. > -- > FreeBSD_amd64_11-Current_RadeonKMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to > "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 01:30:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C0BF7FBA for ; Mon, 16 Feb 2015 01:30:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A05221B5 for ; Mon, 16 Feb 2015 01:30:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G1UFjN085294 for ; Mon, 16 Feb 2015 01:30:15 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G1UFep085293; Mon, 16 Feb 2015 01:30:15 GMT (envelope-from root) Date: Mon, 16 Feb 2015 01:30:15 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Accepted] D1764: Factor out ip6_deletefraghdr() Message-ID: <67f1594c70b093ef32690315cdef1752@localhost.localdomain> X-Priority: 3 Thread-Topic: D1764: Factor out ip6_deletefraghdr() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZDE3NDlmNTBjMTFkOWUxZjE5ZTU2MDhhM2Q4IFThSCc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 01:30:15 -0000 glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, ae, glebius Cc: ae, glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 01:32:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F1A1CE0 for ; Mon, 16 Feb 2015 01:32:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D158425C for ; Mon, 16 Feb 2015 01:32:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G1WWSa089676 for ; Mon, 16 Feb 2015 01:32:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G1WWUd089675; Mon, 16 Feb 2015 01:32:32 GMT (envelope-from root) Date: Mon, 16 Feb 2015 01:32:32 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Commented On] D1764: Factor out ip6_deletefraghdr() Message-ID: X-Priority: 3 Thread-Topic: D1764: Factor out ip6_deletefraghdr() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZDE3NDlmNTBjMTFkOWUxZjE5ZTU2MDhhM2Q4IFThSLA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 01:32:33 -0000 glebius added a comment. Damn f*ckbrikator doesn't allow me to close the revision, since I don't own it. Kristof, looks like you will need to manually close all your revisions as I commit them. Or we can just leave some trash in this "pretty" software. REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, ae, glebius Cc: ae, glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 01:46:41 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0A7494DD for ; Mon, 16 Feb 2015 01:46:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DDDAF38E for ; Mon, 16 Feb 2015 01:46:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G1kerq003441 for ; Mon, 16 Feb 2015 01:46:40 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G1keDQ003440; Mon, 16 Feb 2015 01:46:40 GMT (envelope-from root) Date: Mon, 16 Feb 2015 01:46:40 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Commented On] D1765: PF: Handle fragmented IPv6 packets Message-ID: X-Priority: 3 Thread-Topic: D1765: PF: Handle fragmented IPv6 packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzdiMDI4N2YyYWVmNTFkOWE2N2EwODM4MzY0IFThTAA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 01:46:41 -0000 glebius added a comment. Thanks. Now let me complete universe with anonymous structs/unions on. INLINE COMMENTS sys/netpfil/pf/pf_norm.c:88 This line looks like cut-n-paste typo. Don't hurry to fix, I am about to improve the code to use anonymous structure, which, I hope, will be enabled for the whole kernel build soon. REVISION DETAIL https://reviews.freebsd.org/D1765 To: kristof, glebius Cc: glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 03:35:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2E4AFA73 for ; Mon, 16 Feb 2015 03:35:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E57582 for ; Mon, 16 Feb 2015 03:35:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G3ZWT0068314 for ; Mon, 16 Feb 2015 03:35:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G3ZWdv068313; Mon, 16 Feb 2015 03:35:32 GMT (envelope-from root) Date: Mon, 16 Feb 2015 03:35:32 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Accepted] D1765: PF: Handle fragmented IPv6 packets Message-ID: <53273e7ee7a9a3685dbf34d0183c5e18@localhost.localdomain> X-Priority: 3 Thread-Topic: D1765: PF: Handle fragmented IPv6 packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzdiMDI4N2YyYWVmNTFkOWE2N2EwODM4MzY0IFThZYQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 03:35:34 -0000 glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1765 To: kristof, glebius Cc: glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 03:56:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CD54E188; Mon, 16 Feb 2015 03:56:51 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id BA44523C; Mon, 16 Feb 2015 03:56:51 +0000 (UTC) Received: from [100.68.22.162] (70.sub-70-211-71.myvzw.com [70.211.71.70]) by elvis.mu.org (Postfix) with ESMTPSA id 17E01341F8AC; Sun, 15 Feb 2015 19:56:44 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [Differential] [Commented On] D1764: Factor out ip6_deletefraghdr() From: Alfred Perlstein X-Mailer: iPhone Mail (12B440) In-Reply-To: Date: Sun, 15 Feb 2015 19:56:42 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <762617EF-99BB-40C6-AD73-5C77E5DF7069@mu.org> References: To: Gleb Smirnoff Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 03:56:51 -0000 Can you use the commit log string and try that?=20 Sent from my iPhone > On Feb 15, 2015, at 5:32 PM, glebius (Gleb Smirnoff) wrote: >=20 > glebius added a comment. >=20 > Damn f*ckbrikator doesn't allow me to close the revision, since I don't ow= n it. >=20 > Kristof, looks like you will need to manually close all your revisions as I= commit them. Or we can just leave some trash in this "pretty" software. >=20 > REVISION DETAIL > https://reviews.freebsd.org/D1764 >=20 > To: kristof, ae, glebius > Cc: ae, glebius, freebsd-net > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >=20 From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 06:21:01 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A5548DA for ; Mon, 16 Feb 2015 06:21:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE645231 for ; Mon, 16 Feb 2015 06:21:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G6L0Ee040955 for ; Mon, 16 Feb 2015 06:21:00 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G6L0FM040954; Mon, 16 Feb 2015 06:21:00 GMT (envelope-from root) Date: Mon, 16 Feb 2015 06:21:00 +0000 To: freebsd-net@freebsd.org From: "kristof (Kristof Provost)" Subject: [Differential] [Closed] D1764: Factor out ip6_deletefraghdr() Message-ID: X-Priority: 3 Thread-Topic: D1764: Factor out ip6_deletefraghdr() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZDE3NDlmNTBjMTFkOWUxZjE5ZTU2MDhhM2Q4IFThjEw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 06:21:01 -0000 kristof closed this revision. kristof added a comment. Submitted as r278828 - head/sys/netinet6 REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, ae, glebius Cc: ae, glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 06:21:30 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 69E6396C for ; Mon, 16 Feb 2015 06:21:30 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48C2B2F0 for ; Mon, 16 Feb 2015 06:21:30 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G6LUnl042479 for ; Mon, 16 Feb 2015 06:21:30 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G6LU60042478; Mon, 16 Feb 2015 06:21:30 GMT (envelope-from root) Date: Mon, 16 Feb 2015 06:21:30 +0000 To: freebsd-net@freebsd.org From: "rpaulo (Rui Paulo)" Subject: [Differential] [Changed Subscribers] D1764: Factor out ip6_deletefraghdr() Message-ID: X-Priority: 3 Thread-Topic: D1764: Factor out ip6_deletefraghdr() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZDE3NDlmNTBjMTFkOWUxZjE5ZTU2MDhhM2Q4IFThjGo= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 06:21:30 -0000 rpaulo added a subscriber: rpaulo. rpaulo added a comment. >>! In D1764#17, @glebius wrote: > Damn f*ckbrikator doesn't allow me to close the revision, since I don't own it. > > Kristof, looks like you will need to manually close all your revisions as I commit them. Or we can just leave some trash in this "pretty" software. You need to use the full URL in your commit log in order to trigger the script that closes revisions. That's how it was setup for FreeBSD and is unrelated to the Phabricator software. I agree it shouldn't be possible to close revisions that you don't own, otherwise it would be extremely easy to screw up the system. REVISION DETAIL https://reviews.freebsd.org/D1764 To: kristof, ae, glebius Cc: rpaulo, ae, glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 06:21:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F7739FF for ; Mon, 16 Feb 2015 06:21:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 303742FC for ; Mon, 16 Feb 2015 06:21:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G6Lw8Y042728 for ; Mon, 16 Feb 2015 06:21:58 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G6LwQi042727; Mon, 16 Feb 2015 06:21:58 GMT (envelope-from root) Date: Mon, 16 Feb 2015 06:21:58 +0000 To: freebsd-net@freebsd.org From: "kristof (Kristof Provost)" Subject: [Differential] [Closed] D1765: PF: Handle fragmented IPv6 packets Message-ID: <49a022e9c736efea7c2344205cdf685b@localhost.localdomain> X-Priority: 3 Thread-Topic: D1765: PF: Handle fragmented IPv6 packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzdiMDI4N2YyYWVmNTFkOWE2N2EwODM4MzY0IFThjIY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 06:21:59 -0000 kristof closed this revision. kristof added a comment. Submitted as r278831 - head/sys/netpfil/pf REVISION DETAIL https://reviews.freebsd.org/D1765 To: kristof, glebius Cc: glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 06:30:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BEB1FB0D for ; Mon, 16 Feb 2015 06:30:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9FE28341 for ; Mon, 16 Feb 2015 06:30:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G6UF5W050707 for ; Mon, 16 Feb 2015 06:30:15 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G6UFp4050704; Mon, 16 Feb 2015 06:30:15 GMT (envelope-from root) Date: Mon, 16 Feb 2015 06:30:15 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Accepted] D1766: Factor out ip6_fragment() Message-ID: <4229b074841b2f057c9745ff27867ec7@localhost.localdomain> X-Priority: 3 Thread-Topic: D1766: Factor out ip6_fragment() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzZhYWI5M2ViMzc5NTk2YmY1MjY3NGQ3NjcxIFThjnc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 06:30:15 -0000 glebius accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1766 To: kristof, glebius Cc: glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 06:34:29 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3552D34 for ; Mon, 16 Feb 2015 06:34:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C45B05F5 for ; Mon, 16 Feb 2015 06:34:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1G6YTu5055513 for ; Mon, 16 Feb 2015 06:34:29 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1G6YTW6055512; Mon, 16 Feb 2015 06:34:29 GMT (envelope-from root) Date: Mon, 16 Feb 2015 06:34:29 +0000 To: freebsd-net@freebsd.org From: "kristof (Kristof Provost)" Subject: [Differential] [Closed] D1766: Factor out ip6_fragment() Message-ID: <000a23a5c4defdcda0096cd33efad11b@localhost.localdomain> X-Priority: 3 Thread-Topic: D1766: Factor out ip6_fragment() X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzZhYWI5M2ViMzc5NTk2YmY1MjY3NGQ3NjcxIFThj3U= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 06:34:30 -0000 kristof closed this revision. kristof added a comment. Submitted as r278842 - head/sys/netinet6 REVISION DETAIL https://reviews.freebsd.org/D1766 To: kristof, glebius Cc: glebius, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 09:30:03 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9AB68D67 for ; Mon, 16 Feb 2015 09:30:03 +0000 (UTC) Received: from mail-la0-f42.google.com (mail-la0-f42.google.com [209.85.215.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1CF3CA2B for ; Mon, 16 Feb 2015 09:30:02 +0000 (UTC) Received: by labgd6 with SMTP id gd6so27189653lab.7 for ; Mon, 16 Feb 2015 01:29:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berentweb.com; s=google; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=XxwqgNGoj6EJ5IbCQLy9yRpnuPzqIHSRPniApccy4nc=; b=CLXk0Ybh3WYrpgJ7Lv4w4cYrFSGfFZaaDSNCT9gcmxmLvzpwBYLdOAEMvbg7KpRTmM G8MpzJ6Tplfejkm+0Kr6N4swwgMfAmMT68xEYgNYF01BmWoo9s2ZrLt0cEz1DEe8Z8Ey BoglU6Dj52gEqutIw8RxJY66VvmgwecBx3V98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=XxwqgNGoj6EJ5IbCQLy9yRpnuPzqIHSRPniApccy4nc=; b=gwAxxMGPG9s2zVsFIxTz0RPEcKy8mPk3TmKoWnqgTw6YgDhgPclFokISCSbdtNlGyl Y6Ldi5OnG3ItxucFJEHd41ypVRp4mLgSRaFof2Gniw14NN+DozhU04z0EYk6OnCdLiMe cjEqiiE9l5OUUQt3t2bwC4ZSjqy7TGTr1Q1J43S5i0Lnf5k0mVZpszoScbVQcXbel5Fh d0+OtcnjALW8szsXHtZ/xDd6iF4N123RTaspmYqE7ocMmu763o3vMaflcY2vtgxk03mh 4tvwGd2W2I2glRBr7/HrBDRiNm5g3Rq4zbuGGnPsvD0YLZPVFO5A9iVDkUd/siM2fKrb PRHQ== X-Gm-Message-State: ALoCoQksYe8a8RiYf3e+Ln35lE7qm8zuiIDY/cf6DIOkf2KSEkJNnmeZkEImCU5ivdc/qOzsExqw X-Received: by 10.152.10.98 with SMTP id h2mr14072480lab.18.1424078995076; Mon, 16 Feb 2015 01:29:55 -0800 (PST) Received: from rsbsd.rsb ([31.200.16.157]) by mx.google.com with ESMTPSA id ud4sm1181854lac.28.2015.02.16.01.29.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 01:29:54 -0800 (PST) Date: Mon, 16 Feb 2015 11:29:51 +0200 From: Beeblebrox To: Rick Macklem Subject: Re: NFS and diskless: some questions re nfs_diskless.c Message-ID: <20150216112951.0b4ff5cd@rsbsd.rsb> In-Reply-To: <424747461.3929611.1424048192500.JavaMail.root@uoguelph.ca> References: <20150215174056.34912959@rsbsd.rsb> <424747461.3929611.1424048192500.JavaMail.root@uoguelph.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 09:30:03 -0000 Hi again, Rick. > If you are using a pxeboot built with this code, I don't know why you > would still get NFSv2 instead of NFSv3. (Check the line for "/" in > the diskless root's /etc/fstab try adding the "nfsv3" option. * I added nfsv3 to the client fstab as advised, but get same result (V2). T= ested separately with Grub AND FreeBSD's pxeboot file. * The probable reason is that my kernel has everything thrown in, but not B= OOTP_NFSV3: { NFSCL, NFS_ROOT, KRPC, BOOTP, BOOTP_NFSROOT } (NFSD NFSLOCKD get loaded a= s modules). This is based on a prior discussion on the lists, one which in = retrospect I seem to have mis-understood (http://freebsd.1045724.n5.nabble.= com/PXE-boot-using-Grub-bootloader-fails-at-mountroot-no-PXE-devs-td5924518= .html#a5925420) In that discussion, while trying to use Grub as my pxeboot, I thought the s= olution was "build your kernel with BOOTP, BOOTP_NFSROOT"; whereas the more= elegant solution was perhaps to find a way to "fill in the structure nfsv3= _diskless" in grub.cfg or elsewhere. So I think I'll try to fix this by you= r suggestion of: > I think if you build a kernel with "options NFS_ROOT" (but not the > others), a boot loader can fill in the environment variables and have > them used, just like pxeboot does. Unless, above solution conflicts with my other objective, which is to "over= ride the root fs" > you can set this environment variable (look at bootpc_init() > if you are using the BOOTP + BOOTP_NFSROOT You mean using vfs.root.mountfrom I assume? But please clarify: Do you mean= I can "override the root fs" if only I'm using BOOTP and not when using NF= S_ROOT? Thanks and Regards. From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 20:50:24 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 51B8F8C0 for ; Mon, 16 Feb 2015 20:50:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 24B6CE11 for ; Mon, 16 Feb 2015 20:50:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1GKoNHu003696 for ; Mon, 16 Feb 2015 20:50:23 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1GKoNss003695; Mon, 16 Feb 2015 20:50:23 GMT (envelope-from root) Date: Mon, 16 Feb 2015 20:50:23 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTiWA8= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 20:50:24 -0000 hiren added a comment. @rrs: Looks like we've come full circle back to the very first crash reported. We are on stable10 with all relevant fixes. Sanitized panic #4 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 6764437504B (6451 MB) Blocksize: 512 Dumptime: Mon Feb 16 02:54:11 2015 Hostname: xxxxxxxxxxxxxxx Magic: FreeBSD Kernel Dump Version String: FreeBSD 10.1-STABLE-llnw12 #0: Fri Feb 13 02:22:48 MST 2015 jason@xxxxxxxxxxxxx:/usr/obj/usr/src/sys/SIXFOUR Panic String: spin lock held too long Dump Parity: 1861214463 Bounds: 0 Dump Status: good Backtrace: Reading symbols from /boot/kernel/cc_cubic.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cubic.ko.symbols Reading symbols from /boot/kernel/cc_cdg.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cdg.ko.symbols Reading symbols from /boot/kernel/h_ertt.ko.symbols...done. Loaded symbols for /boot/kernel/h_ertt.ko.symbols Reading symbols from /boot/kernel/ftcp.ko...done. Loaded symbols for /boot/kernel/ftcp.ko #0 doadump (textdump=1) at pcpu.h:219 in pcpu.h (kgdb) #0 doadump (textdump=1) at pcpu.h:219 #1 0xffffffff80749c17 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:452 #2 0xffffffff80749ff4 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:759 #3 0xffffffff80735683 in _mtx_lock_spin_cookie (c=, tid=, opts=, file=, line=) at /usr/src/sys/kern/kern_mutex.c:561 #4 0xffffffff80760064 in callout_lock (c=0xfffff80870266e80) at /usr/src/sys/kern/kern_timeout.c:530 #5 0xffffffff8075fc62 in callout_reset_sbt_on (c=0xfffff80870266e80, sbt=, precision=, ftn=0xffffffff808bcfe0 , arg=0xfffff80870266c00, cpu=, flags=) at /usr/src/sys/kern/kern_timeout.c:975 #6 0xffffffff808bd807 in tcp_timer_activate (tp=0x0, timer_type=, delta=) at /usr/src/sys/netinet/tcp_timer.c:883 #7 0xffffffff808b3ce0 in tcp_output (tp=0xfffff80870266c00) at /usr/src/sys/netinet/tcp_output.c:1579 #8 0xffffffff808bfa41 in tcp_usr_send (so=, flags=, m=, nam=, control=, td=) at /usr/src/sys/netinet/tcp_usrreq.c:887 #9 0xffffffff807c2535 in sosend_generic (so=0xfffff80678731000, addr=0x0, uio=0xfffffe2021072960, top=, control=, flags=, td=0x143) at /usr/src/sys/kern/uipc_socket.c:1284 #10 0xffffffff807a3fc3 in soo_write (fp=, uio=0xfffffe2021072960, active_cred=, flags=, td=) at /usr/src/sys/kern/sys_socket.c:103 #11 0xffffffff8079cb47 in dofilewrite (td=0xfffff8011c9c7920, fd=323, fp=0xfffff804c4c17870, auio=0xfffffe2021072960, offset=, flags=0) at file.h:304 #12 0xffffffff8079c878 in kern_writev (td=0xfffff8011c9c7920, fd=323, auio=0xfffffe2021072960) at /usr/src/sys/kern/sys_generic.c:481 #13 0xffffffff8079c803 in sys_write (td=, uap=) at /usr/src/sys/kern/sys_generic.c:396 #14 0xffffffff80b059ca in amd64_syscall (td=0xfffff8011c9c7920, traced=0) at subr_syscall.c:134 #15 0xffffffff80aeae3b in Xfast_syscall () at /usr/src/sys/amd64/amd64/exception.S:396 #16 0x0000000801640b8a in ?? () Current language: auto; currently minimal (kgdb) REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 20:54:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 392ADA50 for ; Mon, 16 Feb 2015 20:54:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0CBA7EDC for ; Mon, 16 Feb 2015 20:54:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1GKsJRx009527 for ; Mon, 16 Feb 2015 20:54:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1GKsJ7t009524; Mon, 16 Feb 2015 20:54:19 GMT (envelope-from root) Date: Mon, 16 Feb 2015 20:54:19 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTiWPs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 20:54:20 -0000 hiren added a comment. @rrs: One more Sanitized panic #5 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 1694281728B (1615 MB) Blocksize: 512 Dumptime: Sun Feb 15 18:03:14 2015 Hostname: xxxxxxxxxxxxxxxxx Magic: FreeBSD Kernel Dump Version String: FreeBSD 10.1-STABLE-llnw12 #0: Fri Feb 13 02:22:48 MST 2015 jason@xxxxxxxxxxxx:/usr/obj/usr/src/sys/SIXFOUR Panic String: spin lock held too long Dump Parity: 4219482370 Bounds: 0 Dump Status: good Backtrace: Reading symbols from /boot/kernel/cc_cubic.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cubic.ko.symbols Reading symbols from /boot/kernel/cc_cdg.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cdg.ko.symbols Reading symbols from /boot/kernel/h_ertt.ko.symbols...done. Loaded symbols for /boot/kernel/h_ertt.ko.symbols Reading symbols from /boot/kernel/if_gif.ko.symbols...done. Loaded symbols for /boot/kernel/if_gif.ko.symbols Reading symbols from /boot/kernel/ftcp.ko...done. Loaded symbols for /boot/kernel/ftcp.ko #0 doadump (textdump=1) at pcpu.h:219 in pcpu.h (kgdb) #0 doadump (textdump=1) at pcpu.h:219 #1 0xffffffff80749c17 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:452 #2 0xffffffff80749ff4 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:759 #3 0xffffffff80735683 in _mtx_lock_spin_cookie (c=, tid=, opts=, file=, line=) at /usr/src/sys/kern/kern_mutex.c:561 #4 0xffffffff80760064 in callout_lock (c=0xfffffe000092f6d0) at /usr/src/sys/kern/kern_timeout.c:530 #5 0xffffffff8076019c in _callout_stop_safe (c=0xfffffe000092f6d0, safe=0) at /usr/src/sys/kern/kern_timeout.c:1119 #6 0xffffffff80557202 in mpt_scsi_reply_handler (mpt=0xfffffe0000900000, req=0xfffffe000092f678, reply_desc=0, reply_frame=0x0) at /usr/src/sys/dev/mpt/mpt_cam.c:2599 #7 0xffffffff805509a7 in mpt_intr (arg=0xfffffe0000900000) at /usr/src/sys/dev/mpt/mpt.c:823 #8 0xffffffff8055d9d6 in mpt_pci_intr (arg=0xfffffe0000900000) at /usr/src/sys/dev/mpt/mpt_pci.c:802 #9 0xffffffff8071a7fb in intr_event_execute_handlers ( p=, ie=0xfffff80008532e00) at /usr/src/sys/kern/kern_intr.c:1264 #10 0xffffffff8071b196 in ithread_loop (arg=0xfffff8000857bc00) at /usr/src/sys/kern/kern_intr.c:1277 #11 0xffffffff8071841a in fork_exit ( callout=0xffffffff8071b100 , arg=0xfffff8000857bc00, frame=0xfffffe064b1edc00) at /usr/src/sys/kern/kern_fork.c:1017 #12 0xffffffff80aeb08e in fork_trampoline () at /usr/src/sys/amd64/amd64/exception.S:611 #13 0x0000000000000000 in ?? () Current language: auto; currently minimal (kgdb) REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 22:43:09 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A368429A for ; Mon, 16 Feb 2015 22:43:09 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 63E5CD83 for ; Mon, 16 Feb 2015 22:43:09 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1GMh97s049977 for ; Mon, 16 Feb 2015 22:43:09 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1GMh9e5049973; Mon, 16 Feb 2015 22:43:09 GMT (envelope-from root) Date: Mon, 16 Feb 2015 22:43:09 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <622d8d528cec367ceca219e2df32a1f0@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTicn0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 22:43:09 -0000 hiren added a comment. @hps: cc_cpu[MAXCPU] info as you requested on IRC. Let me know if you need more info. (kgdb) backtrace #0 doadump (textdump=1) at pcpu.h:219 #1 0xffffffff80749c17 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:452 #2 0xffffffff80749ff4 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:759 #3 0xffffffff80735683 in _mtx_lock_spin_cookie (c=, tid=, opts=, file=, line=) at /usr/src/sys/kern/kern_mutex.c:561 #4 0xffffffff80760064 in callout_lock (c=0xfffff8000d81dc98) at /usr/src/sys/kern/kern_timeout.c:530 #5 0xffffffff8075fc62 in callout_reset_sbt_on (c=0xfffff8000d81dc98, sbt=, precision=, ftn=0xffffffff8082a610 , arg=0xfffff8000d81dc00, cpu=, flags=) at /usr/src/sys/kern/kern_timeout.c:975 #6 0xffffffff8082b878 in arpintr (m=) at /usr/src/sys/netinet/if_ether.c:781 #7 0xffffffff808189d2 in netisr_dispatch_src (proto=, source=, m=0x0) at /usr/src/sys/net/netisr.c:972 #8 0xffffffff80811396 in ether_demux (ifp=, m=0xfffff8005c1e8000) at /usr/src/sys/net/if_ethersubr.c:851 #9 0xffffffff80812029 in ether_nh_input (m=) at /usr/src/sys/net/if_ethersubr.c:646 #10 0xffffffff808189d2 in netisr_dispatch_src (proto=, source=, m=0x0) at /usr/src/sys/net/netisr.c:972 #11 0xffffffff80425f9b in em_rxeof (count=99) at /usr/src/sys/dev/e1000/if_em.c:4532 #12 0xffffffff80426373 in em_msix_rx (arg=0xfffff8000c53a200) at /usr/src/sys/dev/e1000/if_em.c:1600 #13 0xffffffff8071a7fb in intr_event_execute_handlers (p=, ie=0xfffff8000c4ac300) at /usr/src/sys/kern/kern_intr.c:1264 #14 0xffffffff8071b196 in ithread_loop (arg=0xfffff8000c5166e0) at /usr/src/sys/kern/kern_intr.c:1277 #15 0xffffffff8071841a in fork_exit (callout=0xffffffff8071b100 , arg=0xfffff8000c5166e0, frame=0xfffffe0c23fccc00) at /usr/src/sys/kern/kern_fork.c:1017 #16 0xffffffff80aeb08e in fork_trampoline () at /usr/src/sys/amd64/amd64/exception.S:611 #17 0x0000000000000000 in ?? () (kgdb) p * cc_cpu@8 [1/18608] $2 = {{cc_lock = {lock_object = {lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{ cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0xfffffe00006a4000, cc_callwheel = 0xfffffe00007c6000, cc_expireq = { tqh_first = 0x0, tqh_last = 0xffffffff81364288}, cc_callfree = {slh_first = 0xfffffe00007c5240}, cc_firstevent = 899380454888656, cc_lastscan = 899380454354416, cc_cookie = 0xfffff8000c34f100, cc_bucket = 31391, cc_ktr_event_name = "callwheel cpu 0\000\000\000\000"}, {cc_lock = { lock_object = {lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe000085a000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364408}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899620856539720, cc_lastscan = 899620209076539, cc_cookie = 0xfffff8000c34f080, cc_bucket = 13092, cc_ktr_event_name = "callwheel cpu 1\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe000089a000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364588}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899446753609881, cc_lastscan = 899445618670680, cc_cookie = 0xfffff8000c34f000, cc_bucket = 2680, cc_ktr_event_name = "callwheel cpu 2\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe00008da000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364708}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899622088212480, cc_lastscan = 899619941714270, cc_cookie = 0xfffff8000c34ef00, cc_bucket = 13079, cc_ktr_event_name = "callwheel cpu 3\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe000091a000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364888}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899622239207424, cc_lastscan = 899620104922681, cc_cookie = 0xfffff8000c34ee80, cc_bucket = 10843, cc_ktr_event_name = "callwheel cpu 4\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe000095a000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364a08}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899622004326400, cc_lastscan = 899619864406244, cc_cookie = 0xfffff8000c34ee00, cc_bucket = 10380, cc_ktr_event_name = "callwheel cpu 5\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe000099a000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364b88}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899709111631872, cc_lastscan = 899706966335378, cc_cookie = 0xfffff8000c34ed80, cc_bucket = 17431, cc_ktr_event_name = "callwheel cpu 6\000\000\000\000"}, {cc_lock = {lock_object = { lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0x0, cc_callwheel = 0xfffffe00009da000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364d08}, cc_callfree = {slh_first = 0x0}, cc_firstevent = 899621360124557, cc_lastscan = 899620209077230, cc_cookie = 0xfffff8000c34e400, cc_bucket = 13086, cc_ktr_event_name = "callwheel cpu 7\000\000\000\000"}} REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Mon Feb 16 23:33:04 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 335D58F2 for ; Mon, 16 Feb 2015 23:33:04 +0000 (UTC) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A5214256 for ; Mon, 16 Feb 2015 23:33:03 +0000 (UTC) Received: by labgq15 with SMTP id gq15so32751703lab.6 for ; Mon, 16 Feb 2015 15:33:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=berentweb.com; s=google; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=BN3T3mDC+19/4xWQnL3pBIpu3zSYk+RnebG6PXBF8cs=; b=DhYEfV0ynruBWE0aFJu1b/k3xRuAYLtbiDJuJlZIYa9LuznInUXRNSOlkyA3IjOxTr ErJ/D2FsWJiSGQrzDMS4tD80vE2EhM8qr4HvjHjRslmUVyC/MMgdmE/huJiJveVrKwdU WnStuWIDiumtYOY5/niRiGAK7Nz3MAplBw0JA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=BN3T3mDC+19/4xWQnL3pBIpu3zSYk+RnebG6PXBF8cs=; b=UMJs8rv6frU3qoHi9WiIN28dhA43Bn8ZUOaujT3oh7x1ctNB6uu9r1hNEY/mBocmxZ nDoC/FGtj9kDGaE/Fcc+eXRs0zKGmoT85SbF059NIfKAiJ6nvGOOOC4bCenZIoUtq4pQ rhtjq7u7w/WFnA3fNVOBKvOetLmkThQ5kG3st581ZnWva7eHgzfM2UgU9hITa0GfTcbE tFWFXfGka5mmbTT7VOxpm8X81tj1wsPAh/mkqivEMYRDRNdq7l4b6W08vSIe9112iG6j UjNKcVKxL8Q+wPwWzpusakSkbxaQ8tO4XrpU/6nuLy5fJ66SH/1BYRCFT9Tm8OoIDCVZ 18jA== X-Gm-Message-State: ALoCoQnQZK5oGhzqd/jtocCj3znh99pqcaQuxdWAW7BDF+DC6pZ6KXWr7TI4A86zuwF2QCe23XEE X-Received: by 10.112.72.132 with SMTP id d4mr25896409lbv.70.1424129581171; Mon, 16 Feb 2015 15:33:01 -0800 (PST) Received: from rsbsd.rsb ([31.200.16.157]) by mx.google.com with ESMTPSA id jk7sm1408460lbc.14.2015.02.16.15.32.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Feb 2015 15:33:00 -0800 (PST) Date: Tue, 17 Feb 2015 01:32:56 +0200 From: Beeblebrox To: Rick Macklem Subject: Re: NFS and diskless: some questions re nfs_diskless.c Message-ID: <20150217013256.668aa838@rsbsd.rsb> In-Reply-To: <20150216112951.0b4ff5cd@rsbsd.rsb> References: <20150215174056.34912959@rsbsd.rsb> <424747461.3929611.1424048192500.JavaMail.root@uoguelph.ca> <20150216112951.0b4ff5cd@rsbsd.rsb> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 23:33:04 -0000 Well, I removed all the BOOTP* items from config and re-built kernel. * With FreeBSD's pxeboot everything works normally and root is mounted as N= FSv3. dhcp.conf has option root-path defined. * When trying to use Grub, boot stops at the "mountroot>" prompt, wich was = the original problem as far as I recall. The grub.cfg file already passes t= hese params to the FreeBSD kernel to no avail: vfs.root.mountfrom=3D"nfs:192.168.2.1:/data/amd64" boot.nfsroot.server=3D"192.168.2.1" boot.nfsroot.path=3D"/data/amd64" --=20 FreeBSD_amd64_11-Current_RadeonKMS From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 01:57:03 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 67117F6F for ; Tue, 17 Feb 2015 01:57:03 +0000 (UTC) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 0CF7A276 for ; Tue, 17 Feb 2015 01:57:02 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2D/BACEn+JU/95baINbg1haBIJ/vzUKhSdKAoFXAQEBAQEBfIQNAQEEAQEBICsgCxsYAgINGQIpAQkmBggHBAEcBIgMDbcRlxsBAQEBAQUBAQEBAQEBARqBIYlrhBwBARs0B4JogUIFijqIVYNBgzc4iQKEfYM+IoICHIFuIDEHgQQ5fwEBAQ X-IronPort-AV: E=Sophos;i="5.09,591,1418101200"; d="scan'208";a="191284162" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-jnhn.mail.uoguelph.ca with ESMTP; 16 Feb 2015 20:56:56 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id D6058B3F31; Mon, 16 Feb 2015 20:56:55 -0500 (EST) Date: Mon, 16 Feb 2015 20:56:55 -0500 (EST) From: Rick Macklem To: Beeblebrox Message-ID: <2127899926.4385980.1424138215864.JavaMail.root@uoguelph.ca> In-Reply-To: <20150217013256.668aa838@rsbsd.rsb> Subject: Re: NFS and diskless: some questions re nfs_diskless.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.10] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 01:57:03 -0000 Beeblebrox wrote: > Well, I removed all the BOOTP* items from config and re-built kernel. > > * With FreeBSD's pxeboot everything works normally and root is > mounted as NFSv3. dhcp.conf has option root-path defined. > > * When trying to use Grub, boot stops at the "mountroot>" prompt, > wich was the original problem as far as I recall. The grub.cfg file > already passes these params to the FreeBSD kernel to no avail: > vfs.root.mountfrom="nfs:192.168.2.1:/data/amd64" I believe the syntax for this is: vfs.root.mountfrom=nfs:/data/amd64 but I'm not sure. Here`s the comment from vfs_mountroot.c for this: * The root filesystem is detailed in the kernel environment variable 72 * vfs.root.mountfrom, which is expected to be in the general format 73 * 74 * :[][ :[] ...] 75 * vfsname := the name of a VFS known to the kernel and capable 76 * of being mounted as root 77 * path := disk device name or other data used by the filesystem 78 * to locate its physical store 79 * 80 * If the environment variable vfs.root.mountfrom is a space separated list, 81 * each list element is tried in turn and the root filesystem will be mounted 82 * from the first one that suceeds. 83 * 84 * The environment variable vfs.root.mountfrom.options is a comma delimited 85 * set of string mount options. These mount options must be parseable 86 * by nmount() in the kernel. > boot.nfsroot.server="192.168.2.1" > boot.nfsroot.path="/data/amd64" > These 2 lines cover the information and are used for NFS_ROOT. (I'd just get rid of vfs.root.mountfrom if you are going to use NFS_ROOT.) >From nfs_diskless.c, here is the list of environment variables used by the NFS_ROOT case: * Populate the essential fields in the nfsv3_diskless structure. 147 * 148 * The loader is expected to export the following environment variables: 149 * 150 * boot.netif.name name of boot interface 151 * boot.netif.ip IP address on boot interface 152 * boot.netif.netmask netmask on boot interface 153 * boot.netif.gateway default gateway (optional) 154 * boot.netif.hwaddr hardware address of boot interface 155 * boot.nfsroot.server IP address of root filesystem server 156 * boot.nfsroot.path path of the root filesystem on server 157 * boot.nfsroot.nfshandle NFS handle for root filesystem on server 158 * boot.nfsroot.nfshandlelen and length of this handle (for NFSv3 only) 159 * boot.nfsroot.options NFS options for the root filesystem Alternately, set vfs.root.mountfrom and put all three of these options back in your kernel config. options BOOTP options BOOTP_NFSROOT options BOOTP_NFSV3 <-- this one gets the BOOTP* case to use NFSv3 rick ps: All I do when trying to answer these questions is look in the sources. (To me, that`s what open source is all about.) > -- > FreeBSD_amd64_11-Current_RadeonKMS > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to > "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 02:10:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E2D41152; Tue, 17 Feb 2015 02:10:15 +0000 (UTC) Received: from mail.karels.net (mail.karels.net [63.231.190.5]) by mx1.freebsd.org (Postfix) with ESMTP id 637F63B7; Tue, 17 Feb 2015 02:10:15 +0000 (UTC) Received: from mail.karels.net (localhost [127.0.0.1]) by mail.karels.net (8.14.7/8.14.7) with ESMTP id t1H1ouxM020621; Mon, 16 Feb 2015 19:50:57 -0600 (CST) (envelope-from mike@karels.net) Message-Id: <201502170150.t1H1ouxM020621@mail.karels.net> To: "George Neville-Neil" From: Mike Karels Reply-to: mike@karels.net Subject: Re: Adding new media types to if_media.h In-reply-to: Your message of Mon, 09 Feb 2015 21:08:41 +0000. Date: Mon, 16 Feb 2015 19:50:56 -0600 Cc: "freebsd-net@freebsd.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 02:10:16 -0000 On Feb 9, gnn wrote: > On 8 Feb 2015, at 22:41, Mike Karels wrote: > > Sorry to reply to a thread after such a long delay, but I think it is > > unresolved, and needs more discussion. I'd like to elaborate a bit on > > my goals and proposal. I believe Adrian has newer thoughts than have > > been > > circulated here as well. > > > > The last message(s) have gone to freebsd-arch and freebsd-net. If > > someone > > wants to pick one, we could consolidate, but this seems relevant to > > both. > > > > I'm going to top-post to try to summarize and extend the discussion, > > but the > > preceding emails follow for reference. > > > > To recap: the existing if_media interface is running out of steam, at > > least > > in that the "Media variant" field, with 5 bits, is going to be > > insufficient > > to express existing 40 Gb/s variants. The if_media media type is a > > 32-bit > > int with a bunch of sub-fields for type (e.g. Ethernet), > > subtype/variant > > (e.g. 10baseT, 10base5, 1000baseT, etc), flags, and some MII-related > > fields. > > > > I made a proposal to extend the interface in a small way, specifically > > to > > replace the "media word" with a 64-bit int that is mostly the same, > > but > > has a new, larger variant/subtype field. The main reason for this > > proposal > > is to maintain the driver KPI (glimpse showed me 240 inclusions of > > if_media.h > > in the kernel in 8.2). That interface includes an initialization > > using a > > scalar value of fields ORed with each other. It would also be easy to > > preserve a 32-bit user-level API/ABI that can express most of the > > current > > state, with a subtype/variant field value reserved for "other" (there > > is > > already one for "unknown", but that is not quite the same). fwiw, I > > found 45 references to this user-level API in our tree, including both > > base and "ports"-type software, which includes libpcap, snmpd, > > dhclient, > > quagga, xorp, atm, devd, and rtsold, which argues for a > > backward-compatible > > API/ABI as well as a more-complete current interface for ifconfig at > > least. > > > > More generally, I see two problems with the existing if_media > > interface: > > > > 1. It doesn't have enough bits for all the fields, in particular, > > variant/ > > subtype for Ethernet. That is the immediate issue. > > > > 2. The interface is not sufficiently generic; it was designed around > > Ethernet > > including MII, token ring, FDDI, and a few other interface types. > > Some of > > the fields like "instance" are primarily for MII as far as I know, and > > are > > basically unused. It is definitely not sufficient for 802.11, which > > has > > rolled its own interfaces. > > > > To solve the second problem, I think the right approach would be to > > reduce > > this interface to a truly generic one, such as media type (e.g. > > Ethernet), > > generic flags, and perhaps generic status. Then there should be a > > separate > > media-specific interface for each type, such as Ethernet and 802.11. > > To a > > small extent, we already have that. Solving the second, more general > > problem, > > requires a whole new driver KPI that will require surgery to every > > driver, > > which is not an exercise that I would consider. > > > > Using a separate int for each existing field, as proposed, would break > > the > > driver KPI, but would not really make the interface generic. Trying > > to > > make a single interface with the union of all network interface > > requirements > > seems like a bad idea to me (we failed last time; the "we" is BSDi, > > where > > I was the architect when this interface was first designed). (No, I > > didn't > > design this interface.) > > > > Solving the first problem only, I think it is preferable to preserve a > > compatible driver KPI, which means using a scalar value encoding what > > is > > necessary. Although that interface is rather Ethernet-centric, that > > is > > really what it is used for. > > > > An additional, selfish goal is to make it easy to back-port drivers > > using > > the new interface to older versions (which I am quite likely to do). > > Preserving the KPI and general user API will be highly useful there. > > I'd be likely to do a 11-style version of ifconfig personally, but it > > might not be difficult to do in a more general way. > > > > I am willing to do a prototype for -current for evaluation. > > > > Comments, alternatives, ? > I agree with your statements above and I'd like to see the prototype. Well, I developed the prototype as I had planned, using a 64-bit media word, and found that I got about 100 files in GENERIC that didn't compile; they attempted to store "media words" in an int. My kingdom for a typedef. That didn't meet my goal of KPI compatibility, so I went to Plan B. Plan B is to steal an unused bit (RFU) to indicate an "extended" media type. I then used the variant/subtype field to store the extended type. Effectively, the previously unused bit doubles the effective size of the subtype field. Given that the previous 5-bit field lasted us 18 years, I figured that doubling it would last a while. I also changed the SIOGGIFMEDIA ioctl, splitting it for binary compatibility; extended types are all mapped to IFM_OTHER (31) using the old interface, but are visible using the new one. With these changes, I modified one driver (vtnet) to use an extended type, and the rest of GENERIC is happy. The changes to ifconfig are also fairly small. The patch is appended, where email programs will screw it up, or at ftp://ftp.karels.net/outgoing/if_media.patch. The VFAST subtype is a throw-away for testing. This seems like a reasonably pragmatic change to support the new 40 Gb/s media types until someone wants to design an improved but non-backward- compatible interface. I think it meets the goal of suitability for back-porting; it could be MFCed. Mike Index: sys/net/if_media.h =================================================================== --- sys/net/if_media.h (revision 278804) +++ sys/net/if_media.h (working copy) @@ -120,15 +120,29 @@ * 5-7 Media type * 8-15 Type specific options * 16-18 Mode (for multi-mode devices) - * 19 RFU + * 19 "extended" bit for media variant * 20-27 Shared (global) options * 28-31 Instance */ /* + * As we have used all of the original values for the media variant (subtype) + * for Ethernet, extended subtypes have been added, marked with XSUBTYPE, + * which is effectively the "high bit" of the media variant (subtype) field. + * IFM_OTHER (the highest basic type) is reserved to indicate use of an + * extended type when using an old SIOCGIFMEDIA operation. This is true + * for all media types, not just Ethernet. + */ +#define XSUBTYPE 0x80000 /* extended variant high bit */ +#define _X(var) ((var) | XSUBTYPE) /* extended variant */ +#define IFM_OTHER 31 /* Other: some extended type */ +#define OMEDIA(var) (((var) & XSUBTYPE) ? IFM_OTHER : (var)) + +/* * Ethernet */ #define IFM_ETHER 0x00000020 +/* NB: 0,1,2 are auto, manual, none defined below */ #define IFM_10_T 3 /* 10BaseT - RJ45 */ #define IFM_10_2 4 /* 10Base2 - Thinnet */ #define IFM_10_5 5 /* 10Base5 - AUI */ @@ -156,11 +170,17 @@ #define IFM_40G_CR4 27 /* 40GBase-CR4 */ #define IFM_40G_SR4 28 /* 40GBase-SR4 */ #define IFM_40G_LR4 29 /* 40GBase-LR4 */ +#define IFM_AVAIL30 30 /* available */ +/* #define IFM_OTHER 31 Other: some extended type */ +/* note 31 is the max! */ + +/* Extended variants/subtypes */ +#define IFM_VFAST _X(0) /* test "V.fast" */ +/* note _X(31) is the max! */ /* * Please update ieee8023ad_lacp.c:lacp_compose_key() * after adding new Ethernet media types. */ -/* note 31 is the max! */ #define IFM_ETH_MASTER 0x00000100 /* master mode (1000baseT) */ #define IFM_ETH_RXPAUSE 0x00000200 /* receive PAUSE frames */ @@ -170,6 +190,7 @@ * Token ring */ #define IFM_TOKEN 0x00000040 +/* NB: 0,1,2 are auto, manual, none defined below */ #define IFM_TOK_STP4 3 /* Shielded twisted pair 4m - DB9 */ #define IFM_TOK_STP16 4 /* Shielded twisted pair 16m - DB9 */ #define IFM_TOK_UTP4 5 /* Unshielded twisted pair 4m - RJ45 */ @@ -187,6 +208,7 @@ * FDDI */ #define IFM_FDDI 0x00000060 +/* NB: 0,1,2 are auto, manual, none defined below */ #define IFM_FDDI_SMF 3 /* Single-mode fiber */ #define IFM_FDDI_MMF 4 /* Multi-mode fiber */ #define IFM_FDDI_UTP 5 /* CDDI / UTP */ @@ -220,6 +242,7 @@ #define IFM_IEEE80211_OFDM27 23 /* OFDM 27Mbps */ /* NB: not enough bits to express MCS fully */ #define IFM_IEEE80211_MCS 24 /* HT MCS rate */ +/* #define IFM_OTHER 31 Other: some extended type */ #define IFM_IEEE80211_ADHOC 0x00000100 /* Operate in Adhoc mode */ #define IFM_IEEE80211_HOSTAP 0x00000200 /* Operate in Host AP mode */ @@ -241,6 +264,7 @@ * ATM */ #define IFM_ATM 0x000000a0 +/* NB: 0,1,2 are auto, manual, none defined below */ #define IFM_ATM_UNKNOWN 3 #define IFM_ATM_UTP_25 4 #define IFM_ATM_TAXI_100 5 @@ -277,7 +301,7 @@ * Masks */ #define IFM_NMASK 0x000000e0 /* Network type */ -#define IFM_TMASK 0x0000001f /* Media sub-type */ +#define IFM_TMASK 0x0008001f /* Media sub-type */ #define IFM_IMASK 0xf0000000 /* Instance */ #define IFM_ISHIFT 28 /* Instance shift */ #define IFM_OMASK 0x0000ff00 /* Type specific options */ @@ -372,6 +396,7 @@ { IFM_40G_CR4, "40Gbase-CR4" }, \ { IFM_40G_SR4, "40Gbase-SR4" }, \ { IFM_40G_LR4, "40Gbase-LR4" }, \ + { IFM_VFAST, "V.fast" }, \ { 0, NULL }, \ } @@ -603,6 +628,7 @@ { IFM_AUTO, "autoselect" }, \ { IFM_MANUAL, "manual" }, \ { IFM_NONE, "none" }, \ + { IFM_OTHER, "other" }, \ { 0, NULL }, \ } @@ -673,6 +699,7 @@ { IFM_ETHER | IFM_40G_CR4, IF_Gbps(40ULL) }, \ { IFM_ETHER | IFM_40G_SR4, IF_Gbps(40ULL) }, \ { IFM_ETHER | IFM_40G_LR4, IF_Gbps(40ULL) }, \ + { IFM_ETHER | IFM_VFAST, IF_Gbps(40ULL) }, \ \ { IFM_TOKEN | IFM_TOK_STP4, IF_Mbps(4) }, \ { IFM_TOKEN | IFM_TOK_STP16, IF_Mbps(16) }, \ Index: sys/sys/sockio.h =================================================================== --- sys/sys/sockio.h (revision 278810) +++ sys/sys/sockio.h (working copy) @@ -128,5 +128,6 @@ #define SIOCGIFGROUP _IOWR('i', 136, struct ifgroupreq) /* get ifgroups */ #define SIOCDIFGROUP _IOW('i', 137, struct ifgroupreq) /* delete ifgroup */ #define SIOCGIFGMEMB _IOWR('i', 138, struct ifgroupreq) /* get members */ +#define SIOCGIFXMEDIA _IOWR('i', 139, struct ifmediareq) /* get net xmedia */ #endif /* !_SYS_SOCKIO_H_ */ Index: sys/net/if.c =================================================================== --- sys/net/if.c (revision 278749) +++ sys/net/if.c (working copy) @@ -2561,6 +2561,7 @@ case SIOCGIFPSRCADDR: case SIOCGIFPDSTADDR: case SIOCGIFMEDIA: + case SIOCGIFXMEDIA: case SIOCGIFGENERIC: if (ifp->if_ioctl == NULL) return (EOPNOTSUPP); Index: sys/net/if_media.c =================================================================== --- sys/net/if_media.c (revision 278804) +++ sys/net/if_media.c (working copy) @@ -67,7 +67,9 @@ static struct ifmedia_entry *ifmedia_match(struct ifmedia *ifm, int flags, int mask); +#define IFMEDIA_DEBUG #ifdef IFMEDIA_DEBUG +#include int ifmedia_debug = 0; SYSCTL_INT(_debug, OID_AUTO, ifmedia, CTLFLAG_RW, &ifmedia_debug, 0, "if_media debugging msgs"); @@ -271,6 +273,7 @@ * Get list of available media and current media on interface. */ case SIOCGIFMEDIA: + case SIOCGIFXMEDIA: { struct ifmedia_entry *ep; int *kptr, count; @@ -278,8 +281,13 @@ kptr = NULL; /* XXX gcc */ - ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? - ifm->ifm_cur->ifm_media : IFM_NONE; + if (cmd == SIOCGIFMEDIA) { + ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? + OMEDIA(ifm->ifm_cur->ifm_media) : IFM_NONE; + } else { + ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? + ifm->ifm_cur->ifm_media : IFM_NONE; + } ifmr->ifm_mask = ifm->ifm_mask; ifmr->ifm_status = 0; (*ifm->ifm_status)(ifp, ifmr); @@ -317,7 +325,10 @@ ep = LIST_FIRST(&ifm->ifm_list); for (; ep != NULL && count < ifmr->ifm_count; ep = LIST_NEXT(ep, ifm_list), count++) - kptr[count] = ep->ifm_media; + if (cmd == SIOCGIFMEDIA) + kptr[count] = OMEDIA(ep->ifm_media); + else + kptr[count] = ep->ifm_media; if (ep != NULL) error = E2BIG; /* oops! */ @@ -505,7 +516,7 @@ printf("\n"); return; } - printf(desc->ifmt_string); + printf("%s", desc->ifmt_string); /* Any mode. */ for (desc = ttos->modes; desc && desc->ifmt_string != NULL; desc++) Index: sys/dev/virtio/network/if_vtnet.c =================================================================== --- sys/dev/virtio/network/if_vtnet.c (revision 278749) +++ sys/dev/virtio/network/if_vtnet.c (working copy) @@ -938,6 +938,7 @@ ifmedia_init(&sc->vtnet_media, IFM_IMASK, vtnet_ifmedia_upd, vtnet_ifmedia_sts); ifmedia_add(&sc->vtnet_media, VTNET_MEDIATYPE, 0, NULL); + ifmedia_add(&sc->vtnet_media, IFM_ETHER | IFM_VFAST, 0, NULL); ifmedia_set(&sc->vtnet_media, VTNET_MEDIATYPE); /* Read (or generate) the MAC address for the adapter. */ @@ -1103,6 +1104,7 @@ case SIOCSIFMEDIA: case SIOCGIFMEDIA: + case SIOCGIFXMEDIA: error = ifmedia_ioctl(ifp, ifr, &sc->vtnet_media, cmd); break; Index: sbin/ifconfig/ifmedia.c =================================================================== --- sbin/ifconfig/ifmedia.c (revision 278749) +++ sbin/ifconfig/ifmedia.c (working copy) @@ -109,11 +109,17 @@ { struct ifmediareq ifmr; int *media_list, i; + int xmedia = 1; (void) memset(&ifmr, 0, sizeof(ifmr)); (void) strncpy(ifmr.ifm_name, name, sizeof(ifmr.ifm_name)); - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { + /* + * Check if interface supports extended media types. + */ + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) + xmedia = 0; + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { /* * Interface doesn't support SIOC{G,S}IFMEDIA. */ @@ -130,8 +136,13 @@ err(1, "malloc"); ifmr.ifm_ulist = media_list; - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) - err(1, "SIOCGIFMEDIA"); + if (xmedia) { + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) + err(1, "SIOCGIFXMEDIA"); + } else { + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) + err(1, "SIOCGIFMEDIA"); + } printf("\tmedia: "); print_media_word(ifmr.ifm_current, 1); @@ -194,6 +205,7 @@ { static struct ifmediareq *ifmr = NULL; int *mwords; + int xmedia = 1; if (ifmr == NULL) { ifmr = (struct ifmediareq *)malloc(sizeof(struct ifmediareq)); @@ -213,7 +225,10 @@ * the current media type and the top-level type. */ - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) { + xmedia = 0; + } + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { err(1, "SIOCGIFMEDIA"); } @@ -225,8 +240,13 @@ err(1, "malloc"); ifmr->ifm_ulist = mwords; - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) - err(1, "SIOCGIFMEDIA"); + if (xmedia) { + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) + err(1, "SIOCGIFXMEDIA"); + } else { + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) + err(1, "SIOCGIFMEDIA"); + } } return ifmr; From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 02:59:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E60AB8E for ; Tue, 17 Feb 2015 02:59:59 +0000 (UTC) Received: from esa-annu.net.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 35B30AC5 for ; Tue, 17 Feb 2015 02:59:58 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2C7BAAJruJU/95baINbhDaCf8UxgVkBAQEBAQF8hA4oVhsYAgINGQJfiEC3GZcYAQEBAQYBAQEBAQEcgSGJa4Q5NIJvgUIFijqPTYk6hH2DPiKEDCCBdX8BAQE X-IronPort-AV: E=Sophos;i="5.09,591,1418101200"; d="scan'208";a="192985978" Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.222]) by esa-annu.net.uoguelph.ca with ESMTP; 16 Feb 2015 21:59:51 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 8983FB3FE4; Mon, 16 Feb 2015 21:59:51 -0500 (EST) Date: Mon, 16 Feb 2015 21:59:51 -0500 (EST) From: Rick Macklem To: Beeblebrox Message-ID: <1571544718.4405548.1424141991551.JavaMail.root@uoguelph.ca> Subject: Re: NFS and diskless: some questions re nfs_diskless.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.95.12] X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926) Cc: freebsd-net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 02:59:59 -0000 I wrote: > > * When trying to use Grub, boot stops at the "mountroot>" prompt, > > wich was the original problem as far as I recall. The grub.cfg file > > already passes these params to the FreeBSD kernel to no avail: > > vfs.root.mountfrom="nfs:192.168.2.1:/data/amd64" > I believe the syntax for this is: > vfs.root.mountfrom=nfs:/data/amd64 > but I'm not sure. Oops, I think your syntax is correct, but vfs.root.mountfrom only works for the BOOTP + BOOTP_NFSROOT case. rick From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 07:17:11 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E6135DB8; Tue, 17 Feb 2015 07:17:11 +0000 (UTC) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B75EF6C3; Tue, 17 Feb 2015 07:17:10 +0000 (UTC) Received: from julian-mbp3.pixel8networks.com (50-196-156-133-static.hfc.comcastbusiness.net [50.196.156.133]) (authenticated bits=0) by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t1H7H9K2003756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 16 Feb 2015 23:17:09 -0800 (PST) (envelope-from julian@freebsd.org) Message-ID: <54E2EAEF.5050201@freebsd.org> Date: Mon, 16 Feb 2015 23:17:03 -0800 From: Julian Elischer User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: mike@karels.net, George Neville-Neil Subject: Re: Adding new media types to if_media.h References: <201502170150.t1H1ouxM020621@mail.karels.net> In-Reply-To: <201502170150.t1H1ouxM020621@mail.karels.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@freebsd.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 07:17:12 -0000 On 2/16/15 5:50 PM, Mike Karels wrote: > Well, I developed the prototype as I had planned, using a 64-bit > media word, and found that I got about 100 files in GENERIC that > didn't compile; [...] > so I went to Plan B. Plan B is to steal an unused bit (RFU) to > indicate an "extended" media type. I then used the variant/subtype > field to store the extended type. [...] > I modified one driver (vtnet) to use an extended type, and the rest > of GENERIC is happy. The changes to ifconfig are also fairly small. > The patch is appended, where email programs will screw it up, or at > ftp://ftp.karels.net/outgoing/if_media.patch. The VFAST subtype is a > throw-away for testing. This seems like a reasonably pragmatic > change to support the new 40 Gb/s media types until someone wants to > design an improved but non-backward- compatible interface. I think > it meets the goal of suitability for back-porting; it could be > MFCed. Mike Index: sys/net/if_media.h I like it.. The patch seems appropriately manageable. From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 07:32:37 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B31EF90; Tue, 17 Feb 2015 07:32:37 +0000 (UTC) Received: from mail-wg0-x230.google.com (mail-wg0-x230.google.com [IPv6:2a00:1450:400c:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E4C38A9; Tue, 17 Feb 2015 07:32:36 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id l18so30390752wgh.7; Mon, 16 Feb 2015 23:32:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=34WzF5RUBamMbdaJIWuyO+Wy32LXuXeKKCKXIrV9oAA=; b=cighN67Ic2UYhwiTfNnr2KE3sD2VqDoPe8GxZHF5K/oI3npFyKBwLVL2X7r35MFY+2 x6rk9JvZ0DIubrjjS01WBzW6BihzmJchXhfB3mnIyLjScKEtfaq7Wk9fLgZjZq3CSsos oPg0iIdTGbL2LOgzzhThtfonRUp7uz4Je0rs2fRNfZaiv/eDvluOd+nfdAgCPrd2W24L cn+WF+ggpQN0MzsDsRCDaelpaPNGoXlN+FmGTymBrn3TFbTHSSfjcEV6idsu+BG8CPNz q4Hug307dJJwje0bOXWHRsY+vkITuG5AbPGSnPhk4gEupg9+cnlwCCvhuy3RlFdyaWwg pxvg== MIME-Version: 1.0 X-Received: by 10.180.73.205 with SMTP id n13mr22583500wiv.64.1424158354832; Mon, 16 Feb 2015 23:32:34 -0800 (PST) Received: by 10.194.101.106 with HTTP; Mon, 16 Feb 2015 23:32:34 -0800 (PST) In-Reply-To: <201502170150.t1H1ouxM020621@mail.karels.net> References: <201502170150.t1H1ouxM020621@mail.karels.net> Date: Mon, 16 Feb 2015 23:32:34 -0800 Message-ID: Subject: Re: Adding new media types to if_media.h From: Jack Vogel To: Mike Karels Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-net@freebsd.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 07:32:37 -0000 Nice Mike, I like it also. Jack On Mon, Feb 16, 2015 at 5:50 PM, Mike Karels wrote: > On Feb 9, gnn wrote: > > > On 8 Feb 2015, at 22:41, Mike Karels wrote: > > > > Sorry to reply to a thread after such a long delay, but I think it is > > > unresolved, and needs more discussion. I'd like to elaborate a bit on > > > my goals and proposal. I believe Adrian has newer thoughts than have > > > been > > > circulated here as well. > > > > > > The last message(s) have gone to freebsd-arch and freebsd-net. If > > > someone > > > wants to pick one, we could consolidate, but this seems relevant to > > > both. > > > > > > I'm going to top-post to try to summarize and extend the discussion, > > > but the > > > preceding emails follow for reference. > > > > > > To recap: the existing if_media interface is running out of steam, at > > > least > > > in that the "Media variant" field, with 5 bits, is going to be > > > insufficient > > > to express existing 40 Gb/s variants. The if_media media type is a > > > 32-bit > > > int with a bunch of sub-fields for type (e.g. Ethernet), > > > subtype/variant > > > (e.g. 10baseT, 10base5, 1000baseT, etc), flags, and some MII-related > > > fields. > > > > > > I made a proposal to extend the interface in a small way, specifically > > > to > > > replace the "media word" with a 64-bit int that is mostly the same, > > > but > > > has a new, larger variant/subtype field. The main reason for this > > > proposal > > > is to maintain the driver KPI (glimpse showed me 240 inclusions of > > > if_media.h > > > in the kernel in 8.2). That interface includes an initialization > > > using a > > > scalar value of fields ORed with each other. It would also be easy to > > > preserve a 32-bit user-level API/ABI that can express most of the > > > current > > > state, with a subtype/variant field value reserved for "other" (there > > > is > > > already one for "unknown", but that is not quite the same). fwiw, I > > > found 45 references to this user-level API in our tree, including both > > > base and "ports"-type software, which includes libpcap, snmpd, > > > dhclient, > > > quagga, xorp, atm, devd, and rtsold, which argues for a > > > backward-compatible > > > API/ABI as well as a more-complete current interface for ifconfig at > > > least. > > > > > > More generally, I see two problems with the existing if_media > > > interface: > > > > > > 1. It doesn't have enough bits for all the fields, in particular, > > > variant/ > > > subtype for Ethernet. That is the immediate issue. > > > > > > 2. The interface is not sufficiently generic; it was designed around > > > Ethernet > > > including MII, token ring, FDDI, and a few other interface types. > > > Some of > > > the fields like "instance" are primarily for MII as far as I know, and > > > are > > > basically unused. It is definitely not sufficient for 802.11, which > > > has > > > rolled its own interfaces. > > > > > > To solve the second problem, I think the right approach would be to > > > reduce > > > this interface to a truly generic one, such as media type (e.g. > > > Ethernet), > > > generic flags, and perhaps generic status. Then there should be a > > > separate > > > media-specific interface for each type, such as Ethernet and 802.11. > > > To a > > > small extent, we already have that. Solving the second, more general > > > problem, > > > requires a whole new driver KPI that will require surgery to every > > > driver, > > > which is not an exercise that I would consider. > > > > > > Using a separate int for each existing field, as proposed, would break > > > the > > > driver KPI, but would not really make the interface generic. Trying > > > to > > > make a single interface with the union of all network interface > > > requirements > > > seems like a bad idea to me (we failed last time; the "we" is BSDi, > > > where > > > I was the architect when this interface was first designed). (No, I > > > didn't > > > design this interface.) > > > > > > Solving the first problem only, I think it is preferable to preserve a > > > compatible driver KPI, which means using a scalar value encoding what > > > is > > > necessary. Although that interface is rather Ethernet-centric, that > > > is > > > really what it is used for. > > > > > > An additional, selfish goal is to make it easy to back-port drivers > > > using > > > the new interface to older versions (which I am quite likely to do). > > > Preserving the KPI and general user API will be highly useful there. > > > I'd be likely to do a 11-style version of ifconfig personally, but it > > > might not be difficult to do in a more general way. > > > > > > I am willing to do a prototype for -current for evaluation. > > > > > > Comments, alternatives, ? > > > I agree with your statements above and I'd like to see the prototype. > > Well, I developed the prototype as I had planned, using a 64-bit media > word, and found that I got about 100 files in GENERIC that didn't compile; > they attempted to store "media words" in an int. My kingdom for a typedef. > That didn't meet my goal of KPI compatibility, so I went to Plan B. > > Plan B is to steal an unused bit (RFU) to indicate an "extended" media > type. I then used the variant/subtype field to store the extended type. > Effectively, the previously unused bit doubles the effective size of the > subtype field. Given that the previous 5-bit field lasted us 18 years, > I figured that doubling it would last a while. I also changed the > SIOGGIFMEDIA ioctl, splitting it for binary compatibility; extended > types are all mapped to IFM_OTHER (31) using the old interface, but > are visible using the new one. > > With these changes, I modified one driver (vtnet) to use an extended type, > and the rest of GENERIC is happy. The changes to ifconfig are also fairly > small. The patch is appended, where email programs will screw it up, > or at ftp://ftp.karels.net/outgoing/if_media.patch. > > The VFAST subtype is a throw-away for testing. > > This seems like a reasonably pragmatic change to support the new 40 Gb/s > media types until someone wants to design an improved but non-backward- > compatible interface. I think it meets the goal of suitability for > back-porting; it could be MFCed. > > Mike > > Index: sys/net/if_media.h > =================================================================== > --- sys/net/if_media.h (revision 278804) > +++ sys/net/if_media.h (working copy) > @@ -120,15 +120,29 @@ > * 5-7 Media type > * 8-15 Type specific options > * 16-18 Mode (for multi-mode devices) > - * 19 RFU > + * 19 "extended" bit for media variant > * 20-27 Shared (global) options > * 28-31 Instance > */ > > /* > + * As we have used all of the original values for the media variant > (subtype) > + * for Ethernet, extended subtypes have been added, marked with XSUBTYPE, > + * which is effectively the "high bit" of the media variant (subtype) > field. > + * IFM_OTHER (the highest basic type) is reserved to indicate use of an > + * extended type when using an old SIOCGIFMEDIA operation. This is true > + * for all media types, not just Ethernet. > + */ > +#define XSUBTYPE 0x80000 /* extended variant high > bit */ > +#define _X(var) ((var) | XSUBTYPE) /* extended > variant */ > +#define IFM_OTHER 31 /* Other: some > extended type */ > +#define OMEDIA(var) (((var) & XSUBTYPE) ? IFM_OTHER : (var)) > + > +/* > * Ethernet > */ > #define IFM_ETHER 0x00000020 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_10_T 3 /* 10BaseT - RJ45 */ > #define IFM_10_2 4 /* 10Base2 - Thinnet */ > #define IFM_10_5 5 /* 10Base5 - AUI */ > @@ -156,11 +170,17 @@ > #define IFM_40G_CR4 27 /* 40GBase-CR4 */ > #define IFM_40G_SR4 28 /* 40GBase-SR4 */ > #define IFM_40G_LR4 29 /* 40GBase-LR4 */ > +#define IFM_AVAIL30 30 /* available */ > +/* #define IFM_OTHER 31 Other: some extended type */ > +/* note 31 is the max! */ > + > +/* Extended variants/subtypes */ > +#define IFM_VFAST _X(0) /* test "V.fast" */ > +/* note _X(31) is the max! */ > /* > * Please update ieee8023ad_lacp.c:lacp_compose_key() > * after adding new Ethernet media types. > */ > -/* note 31 is the max! */ > > #define IFM_ETH_MASTER 0x00000100 /* master mode (1000baseT) > */ > #define IFM_ETH_RXPAUSE 0x00000200 /* receive PAUSE frames */ > @@ -170,6 +190,7 @@ > * Token ring > */ > #define IFM_TOKEN 0x00000040 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_TOK_STP4 3 /* Shielded twisted pair > 4m - DB9 */ > #define IFM_TOK_STP16 4 /* Shielded twisted pair > 16m - DB9 */ > #define IFM_TOK_UTP4 5 /* Unshielded twisted pair > 4m - RJ45 */ > @@ -187,6 +208,7 @@ > * FDDI > */ > #define IFM_FDDI 0x00000060 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_FDDI_SMF 3 /* Single-mode fiber */ > #define IFM_FDDI_MMF 4 /* Multi-mode fiber */ > #define IFM_FDDI_UTP 5 /* CDDI / UTP */ > @@ -220,6 +242,7 @@ > #define IFM_IEEE80211_OFDM27 23 /* OFDM 27Mbps */ > /* NB: not enough bits to express MCS fully */ > #define IFM_IEEE80211_MCS 24 /* HT MCS rate */ > +/* #define IFM_OTHER 31 Other: some extended type */ > > #define IFM_IEEE80211_ADHOC 0x00000100 /* Operate in > Adhoc mode */ > #define IFM_IEEE80211_HOSTAP 0x00000200 /* Operate in Host > AP mode */ > @@ -241,6 +264,7 @@ > * ATM > */ > #define IFM_ATM 0x000000a0 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_ATM_UNKNOWN 3 > #define IFM_ATM_UTP_25 4 > #define IFM_ATM_TAXI_100 5 > @@ -277,7 +301,7 @@ > * Masks > */ > #define IFM_NMASK 0x000000e0 /* Network type */ > -#define IFM_TMASK 0x0000001f /* Media sub-type */ > +#define IFM_TMASK 0x0008001f /* Media sub-type */ > #define IFM_IMASK 0xf0000000 /* Instance */ > #define IFM_ISHIFT 28 /* Instance shift */ > #define IFM_OMASK 0x0000ff00 /* Type specific options */ > @@ -372,6 +396,7 @@ > { IFM_40G_CR4, "40Gbase-CR4" }, \ > { IFM_40G_SR4, "40Gbase-SR4" }, \ > { IFM_40G_LR4, "40Gbase-LR4" }, \ > + { IFM_VFAST, "V.fast" }, \ > { 0, NULL }, \ > } > > @@ -603,6 +628,7 @@ > { IFM_AUTO, "autoselect" }, \ > { IFM_MANUAL, "manual" }, \ > { IFM_NONE, "none" }, \ > + { IFM_OTHER, "other" }, \ > { 0, NULL }, \ > } > > @@ -673,6 +699,7 @@ > { IFM_ETHER | IFM_40G_CR4, IF_Gbps(40ULL) }, \ > { IFM_ETHER | IFM_40G_SR4, IF_Gbps(40ULL) }, \ > { IFM_ETHER | IFM_40G_LR4, IF_Gbps(40ULL) }, \ > + { IFM_ETHER | IFM_VFAST, IF_Gbps(40ULL) }, \ > \ > { IFM_TOKEN | IFM_TOK_STP4, IF_Mbps(4) }, \ > { IFM_TOKEN | IFM_TOK_STP16, IF_Mbps(16) }, \ > Index: sys/sys/sockio.h > =================================================================== > --- sys/sys/sockio.h (revision 278810) > +++ sys/sys/sockio.h (working copy) > @@ -128,5 +128,6 @@ > #define SIOCGIFGROUP _IOWR('i', 136, struct ifgroupreq) /* get > ifgroups */ > #define SIOCDIFGROUP _IOW('i', 137, struct ifgroupreq) /* > delete ifgroup */ > #define SIOCGIFGMEMB _IOWR('i', 138, struct ifgroupreq) /* get > members */ > +#define SIOCGIFXMEDIA _IOWR('i', 139, struct ifmediareq) /* get > net xmedia */ > > #endif /* !_SYS_SOCKIO_H_ */ > Index: sys/net/if.c > =================================================================== > --- sys/net/if.c (revision 278749) > +++ sys/net/if.c (working copy) > @@ -2561,6 +2561,7 @@ > case SIOCGIFPSRCADDR: > case SIOCGIFPDSTADDR: > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > case SIOCGIFGENERIC: > if (ifp->if_ioctl == NULL) > return (EOPNOTSUPP); > Index: sys/net/if_media.c > =================================================================== > --- sys/net/if_media.c (revision 278804) > +++ sys/net/if_media.c (working copy) > @@ -67,7 +67,9 @@ > static struct ifmedia_entry *ifmedia_match(struct ifmedia *ifm, > int flags, int mask); > > +#define IFMEDIA_DEBUG > #ifdef IFMEDIA_DEBUG > +#include > int ifmedia_debug = 0; > SYSCTL_INT(_debug, OID_AUTO, ifmedia, CTLFLAG_RW, &ifmedia_debug, > 0, "if_media debugging msgs"); > @@ -271,6 +273,7 @@ > * Get list of available media and current media on interface. > */ > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > { > struct ifmedia_entry *ep; > int *kptr, count; > @@ -278,8 +281,13 @@ > > kptr = NULL; /* XXX gcc */ > > - ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? > - ifm->ifm_cur->ifm_media : IFM_NONE; > + if (cmd == SIOCGIFMEDIA) { > + ifmr->ifm_active = ifmr->ifm_current = > ifm->ifm_cur ? > + OMEDIA(ifm->ifm_cur->ifm_media) : IFM_NONE; > + } else { > + ifmr->ifm_active = ifmr->ifm_current = > ifm->ifm_cur ? > + ifm->ifm_cur->ifm_media : IFM_NONE; > + } > ifmr->ifm_mask = ifm->ifm_mask; > ifmr->ifm_status = 0; > (*ifm->ifm_status)(ifp, ifmr); > @@ -317,7 +325,10 @@ > ep = LIST_FIRST(&ifm->ifm_list); > for (; ep != NULL && count < ifmr->ifm_count; > ep = LIST_NEXT(ep, ifm_list), count++) > - kptr[count] = ep->ifm_media; > + if (cmd == SIOCGIFMEDIA) > + kptr[count] = > OMEDIA(ep->ifm_media); > + else > + kptr[count] = ep->ifm_media; > > if (ep != NULL) > error = E2BIG; /* oops! */ > @@ -505,7 +516,7 @@ > printf("\n"); > return; > } > - printf(desc->ifmt_string); > + printf("%s", desc->ifmt_string); > > /* Any mode. */ > for (desc = ttos->modes; desc && desc->ifmt_string != NULL; desc++) > > Index: sys/dev/virtio/network/if_vtnet.c > =================================================================== > --- sys/dev/virtio/network/if_vtnet.c (revision 278749) > +++ sys/dev/virtio/network/if_vtnet.c (working copy) > @@ -938,6 +938,7 @@ > ifmedia_init(&sc->vtnet_media, IFM_IMASK, vtnet_ifmedia_upd, > vtnet_ifmedia_sts); > ifmedia_add(&sc->vtnet_media, VTNET_MEDIATYPE, 0, NULL); > + ifmedia_add(&sc->vtnet_media, IFM_ETHER | IFM_VFAST, 0, NULL); > ifmedia_set(&sc->vtnet_media, VTNET_MEDIATYPE); > > /* Read (or generate) the MAC address for the adapter. */ > @@ -1103,6 +1104,7 @@ > > case SIOCSIFMEDIA: > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > error = ifmedia_ioctl(ifp, ifr, &sc->vtnet_media, cmd); > break; > Index: sbin/ifconfig/ifmedia.c > =================================================================== > --- sbin/ifconfig/ifmedia.c (revision 278749) > +++ sbin/ifconfig/ifmedia.c (working copy) > @@ -109,11 +109,17 @@ > { > struct ifmediareq ifmr; > int *media_list, i; > + int xmedia = 1; > > (void) memset(&ifmr, 0, sizeof(ifmr)); > (void) strncpy(ifmr.ifm_name, name, sizeof(ifmr.ifm_name)); > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > + /* > + * Check if interface supports extended media types. > + */ > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > + xmedia = 0; > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > /* > * Interface doesn't support SIOC{G,S}IFMEDIA. > */ > @@ -130,8 +136,13 @@ > err(1, "malloc"); > ifmr.ifm_ulist = media_list; > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > - err(1, "SIOCGIFMEDIA"); > + if (xmedia) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > + err(1, "SIOCGIFXMEDIA"); > + } else { > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > + err(1, "SIOCGIFMEDIA"); > + } > > printf("\tmedia: "); > print_media_word(ifmr.ifm_current, 1); > @@ -194,6 +205,7 @@ > { > static struct ifmediareq *ifmr = NULL; > int *mwords; > + int xmedia = 1; > > if (ifmr == NULL) { > ifmr = (struct ifmediareq *)malloc(sizeof(struct > ifmediareq)); > @@ -213,7 +225,10 @@ > * the current media type and the top-level type. > */ > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) { > + xmedia = 0; > + } > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < > 0) { > err(1, "SIOCGIFMEDIA"); > } > > @@ -225,8 +240,13 @@ > err(1, "malloc"); > > ifmr->ifm_ulist = mwords; > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > - err(1, "SIOCGIFMEDIA"); > + if (xmedia) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) > + err(1, "SIOCGIFXMEDIA"); > + } else { > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > + err(1, "SIOCGIFMEDIA"); > + } > } > > return ifmr; > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 10:57:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6363A118 for ; Tue, 17 Feb 2015 10:57:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 224ED1000 for ; Tue, 17 Feb 2015 10:57:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HAvXNH074776 for ; Tue, 17 Feb 2015 10:57:33 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HAvXdH074775; Tue, 17 Feb 2015 10:57:33 GMT (envelope-from root) Date: Tue, 17 Feb 2015 10:57:33 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 2, 470 lines] D1438: FreeBSD callout rewrite and cleanup Message-ID: <8322390f870a03fb9227480eeb8c5826@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTjHp0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 10:57:34 -0000 hselasky updated this revision to Diff 3809. hselasky added a comment. Update diff after r278623. No other changes. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3734&id=3809 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/man/man9/timeout.9 sys/kern/init_main.c sys/kern/kern_condvar.c sys/kern/kern_lock.c sys/kern/kern_switch.c sys/kern/kern_synch.c sys/kern/kern_thread.c sys/kern/kern_timeout.c sys/kern/subr_sleepqueue.c sys/ofed/include/linux/completion.h sys/sys/_callout.h sys/sys/callout.h sys/sys/proc.h To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 11:26:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1E324454 for ; Tue, 17 Feb 2015 11:26:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CD8DC356 for ; Tue, 17 Feb 2015 11:26:14 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HBQEP5005146 for ; Tue, 17 Feb 2015 11:26:14 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HBQEWX005145; Tue, 17 Feb 2015 11:26:14 GMT (envelope-from root) Date: Tue, 17 Feb 2015 11:26:14 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjJVY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 11:26:15 -0000 hselasky added a comment. Hi, rrs + hiren: I think the problem is this: In "_callout_stop_safe()" we sometimes exit having "cc_migration_cpu(cc, direct) = CPUBLOCK;". Now if a second call to "_callout_stop_safe()" happens before the pending callback has returned, which is using a mutex, we are deadlocked, because "_callout_stop_safe()" is called having the same lock locked which the callback needs to aquire aswell. Because the callout subsystem cannot aquire the mutex during the callback function, it can neither reach the migration code which resets the cc_migration_cpu() variable. hiren: Can you backtrace all the softclock processes in your dump? --HPS REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 11:39:03 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 62594635 for ; Tue, 17 Feb 2015 11:39:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1BEA969F for ; Tue, 17 Feb 2015 11:39:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HBd2mm017210 for ; Tue, 17 Feb 2015 11:39:02 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HBd2OE017209; Tue, 17 Feb 2015 11:39:02 GMT (envelope-from root) Date: Tue, 17 Feb 2015 11:39:02 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <21edbf0bb02ee4cb52e5ca43cb3e2d0a@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjKFY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 11:39:03 -0000 hselasky added a comment. If you change how "cc_migration_cpu(cc, direct)" works, the "cc_cce_migrating()" checks become invalid. I think you need to introduce yet another callout flag .... REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 16:39:42 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F18A8C4 for ; Tue, 17 Feb 2015 16:39:42 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BCAF4D77 for ; Tue, 17 Feb 2015 16:39:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HGdfOL028795 for ; Tue, 17 Feb 2015 16:39:41 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HGdfEY028794; Tue, 17 Feb 2015 16:39:41 GMT (envelope-from root) Date: Tue, 17 Feb 2015 16:39:41 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjbs0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 16:39:42 -0000 rrs added a comment. Hans: I don't get your call sequence, I sent you an email on it.. Hiren: Can you go up the call chain and dump the callout structure c in 0xffffffff80760064 in callout_lock (c=0xfffff8000d81dc98) at /usr/src/sys/kern/kern_timeout.c:530 There is something funny here, because the lock's listed (which is what the spin lock panic was on) are all mtx_lock=4.. which means they are un-locked. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:10:44 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5460C1C1 for ; Tue, 17 Feb 2015 17:10:44 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28CAC130 for ; Tue, 17 Feb 2015 17:10:44 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHAhj3061575 for ; Tue, 17 Feb 2015 17:10:43 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHAhAu061574; Tue, 17 Feb 2015 17:10:43 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:10:43 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjdhM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:10:44 -0000 hiren added a comment. >>! In D1711#88, @rrs wrote: > Hans: > > I don't get your call sequence, I sent you an email on it.. > > Hiren: > > Can you go up the call chain and dump the callout structure > c in > 0xffffffff80760064 in callout_lock (c=0xfffff8000d81dc98) at /usr/src/sys/kern/kern_timeout.c:530 (kgdb) frame 4 #4 0xffffffff80760064 in callout_lock (c=0xfffff8000d81dc98) at /usr/src/sys/kern/kern_timeout.c:530 530 CC_LOCK(cc); (kgdb) p *c $1 = {c_links = {le = {le_next = 0x0, le_prev = 0xfffffe0000804db8}, sle = {sle_next = 0x0}, tqe = {tqe_next = 0x0, tqe_prev = 0xfffffe0000804db8}}, c_time = 903238992575048, c_precision = 241591893750, c_arg = 0xfffff8000d81dc00, c_func = 0xffffffff8082a610 , c_lock = 0x0, c_flags = 22, c_cpu = 0} > > There is something funny here, because the lock's listed (which is what the spin lock panic was on) > are all mtx_lock=4.. which means they are un-locked. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:13:33 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D9E729A for ; Tue, 17 Feb 2015 17:13:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 079211F2 for ; Tue, 17 Feb 2015 17:13:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHDWZw065907 for ; Tue, 17 Feb 2015 17:13:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHDWM8065906; Tue, 17 Feb 2015 17:13:32 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:13:32 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <44c0f2b41c21d17b7d3665b0187da173@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjdrw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:13:33 -0000 hiren added a comment. >>! In D1711#86, @hselasky wrote: > Hi, > > rrs + hiren: > > I think the problem is this: > > In "_callout_stop_safe()" we sometimes exit having "cc_migration_cpu(cc, direct) = CPUBLOCK;". Now if a second call to "_callout_stop_safe()" happens before the pending callback has returned, which is using a mutex, we are deadlocked, because "_callout_stop_safe()" is called having the same lock locked which the callback needs to aquire aswell. Because the callout subsystem cannot aquire the mutex during the callback function, it can neither reach the migration code which resets the cc_migration_cpu() variable. > > hiren: Can you backtrace all the softclock processes in your dump? How exactly do I do it? I do not see any explicit mention of softclock in the dump. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:17:16 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 82CCB37B; Tue, 17 Feb 2015 17:17:16 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5961422B; Tue, 17 Feb 2015 17:17:16 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 742CDB91F; Tue, 17 Feb 2015 12:17:15 -0500 (EST) From: John Baldwin To: freebsd-arch@freebsd.org, mike@karels.net Subject: Re: Adding new media types to if_media.h Date: Tue, 17 Feb 2015 10:44:21 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; ) References: <201502170150.t1H1ouxM020621@mail.karels.net> In-Reply-To: <201502170150.t1H1ouxM020621@mail.karels.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201502171044.21319.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 17 Feb 2015 12:17:15 -0500 (EST) Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:17:16 -0000 On Monday, February 16, 2015 8:50:56 pm Mike Karels wrote: > On Feb 9, gnn wrote: > > > On 8 Feb 2015, at 22:41, Mike Karels wrote: > > > > Sorry to reply to a thread after such a long delay, but I think it is > > > unresolved, and needs more discussion. I'd like to elaborate a bit on > > > my goals and proposal. I believe Adrian has newer thoughts than have > > > been > > > circulated here as well. > > > > > > The last message(s) have gone to freebsd-arch and freebsd-net. If > > > someone > > > wants to pick one, we could consolidate, but this seems relevant to > > > both. > > > > > > I'm going to top-post to try to summarize and extend the discussion, > > > but the > > > preceding emails follow for reference. > > > > > > To recap: the existing if_media interface is running out of steam, at > > > least > > > in that the "Media variant" field, with 5 bits, is going to be > > > insufficient > > > to express existing 40 Gb/s variants. The if_media media type is a > > > 32-bit > > > int with a bunch of sub-fields for type (e.g. Ethernet), > > > subtype/variant > > > (e.g. 10baseT, 10base5, 1000baseT, etc), flags, and some MII-related > > > fields. > > > > > > I made a proposal to extend the interface in a small way, specifically > > > to > > > replace the "media word" with a 64-bit int that is mostly the same, > > > but > > > has a new, larger variant/subtype field. The main reason for this > > > proposal > > > is to maintain the driver KPI (glimpse showed me 240 inclusions of > > > if_media.h > > > in the kernel in 8.2). That interface includes an initialization > > > using a > > > scalar value of fields ORed with each other. It would also be easy to > > > preserve a 32-bit user-level API/ABI that can express most of the > > > current > > > state, with a subtype/variant field value reserved for "other" (there > > > is > > > already one for "unknown", but that is not quite the same). fwiw, I > > > found 45 references to this user-level API in our tree, including both > > > base and "ports"-type software, which includes libpcap, snmpd, > > > dhclient, > > > quagga, xorp, atm, devd, and rtsold, which argues for a > > > backward-compatible > > > API/ABI as well as a more-complete current interface for ifconfig at > > > least. > > > > > > More generally, I see two problems with the existing if_media > > > interface: > > > > > > 1. It doesn't have enough bits for all the fields, in particular, > > > variant/ > > > subtype for Ethernet. That is the immediate issue. > > > > > > 2. The interface is not sufficiently generic; it was designed around > > > Ethernet > > > including MII, token ring, FDDI, and a few other interface types. > > > Some of > > > the fields like "instance" are primarily for MII as far as I know, and > > > are > > > basically unused. It is definitely not sufficient for 802.11, which > > > has > > > rolled its own interfaces. > > > > > > To solve the second problem, I think the right approach would be to > > > reduce > > > this interface to a truly generic one, such as media type (e.g. > > > Ethernet), > > > generic flags, and perhaps generic status. Then there should be a > > > separate > > > media-specific interface for each type, such as Ethernet and 802.11. > > > To a > > > small extent, we already have that. Solving the second, more general > > > problem, > > > requires a whole new driver KPI that will require surgery to every > > > driver, > > > which is not an exercise that I would consider. > > > > > > Using a separate int for each existing field, as proposed, would break > > > the > > > driver KPI, but would not really make the interface generic. Trying > > > to > > > make a single interface with the union of all network interface > > > requirements > > > seems like a bad idea to me (we failed last time; the "we" is BSDi, > > > where > > > I was the architect when this interface was first designed). (No, I > > > didn't > > > design this interface.) > > > > > > Solving the first problem only, I think it is preferable to preserve a > > > compatible driver KPI, which means using a scalar value encoding what > > > is > > > necessary. Although that interface is rather Ethernet-centric, that > > > is > > > really what it is used for. > > > > > > An additional, selfish goal is to make it easy to back-port drivers > > > using > > > the new interface to older versions (which I am quite likely to do). > > > Preserving the KPI and general user API will be highly useful there. > > > I'd be likely to do a 11-style version of ifconfig personally, but it > > > might not be difficult to do in a more general way. > > > > > > I am willing to do a prototype for -current for evaluation. > > > > > > Comments, alternatives, ? > > > I agree with your statements above and I'd like to see the prototype. > > Well, I developed the prototype as I had planned, using a 64-bit media > word, and found that I got about 100 files in GENERIC that didn't compile; > they attempted to store "media words" in an int. My kingdom for a typedef. > That didn't meet my goal of KPI compatibility, so I went to Plan B. > > Plan B is to steal an unused bit (RFU) to indicate an "extended" media > type. I then used the variant/subtype field to store the extended type. > Effectively, the previously unused bit doubles the effective size of the > subtype field. Given that the previous 5-bit field lasted us 18 years, > I figured that doubling it would last a while. I also changed the > SIOGGIFMEDIA ioctl, splitting it for binary compatibility; extended > types are all mapped to IFM_OTHER (31) using the old interface, but > are visible using the new one. > > With these changes, I modified one driver (vtnet) to use an extended type, > and the rest of GENERIC is happy. The changes to ifconfig are also fairly > small. The patch is appended, where email programs will screw it up, > or at ftp://ftp.karels.net/outgoing/if_media.patch. > > The VFAST subtype is a throw-away for testing. > > This seems like a reasonably pragmatic change to support the new 40 Gb/s > media types until someone wants to design an improved but non-backward- > compatible interface. I think it meets the goal of suitability for > back-porting; it could be MFCed. Seems like a reasonable next step to me. -- John Baldwin From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:26:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BB156626; Tue, 17 Feb 2015 17:26:34 +0000 (UTC) Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com [209.85.223.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87E05337; Tue, 17 Feb 2015 17:26:34 +0000 (UTC) Received: by iecar1 with SMTP id ar1so42527763iec.11; Tue, 17 Feb 2015 09:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=4Z0iZzhq7+jYIAMhFOUrSE6McX7/QGXYbQmkB9g1wJo=; b=HcCTU3hwb0tJ2MLmAqw5u/bFJWzOBDOZ9/jk/zWdmZhjmdwjQwr9tVL84znTNMvFiK wgn3p+I0q0ZgeN+fCckqkxkyrVQHm0GeSxkX9YrZnqTOQ7EStzqifyOa5xs4wBL+LhK3 xI86D688HKQinSodoQ5exVrS+eSrjRa2dBO9KTU+mtH4MQnnEPYtNoWwrb9gJ131TMk3 Ja7NkuQsY+5Irx5g0wXIw+Vvz4D4Hz+ywfvLr3j5YCMqOsq+eCKmNr9GBctGI3q8m9Y7 d+hQuFPf4NazGQESGuWEZ8nu8SkCYyhOH5KRnsc+C5bCLAdNdweH0HXAdFqJmBQats6F /GQA== MIME-Version: 1.0 X-Received: by 10.107.31.16 with SMTP id f16mr36729262iof.88.1424193993379; Tue, 17 Feb 2015 09:26:33 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.17.66 with HTTP; Tue, 17 Feb 2015 09:26:33 -0800 (PST) In-Reply-To: <201502170150.t1H1ouxM020621@mail.karels.net> References: <201502170150.t1H1ouxM020621@mail.karels.net> Date: Tue, 17 Feb 2015 09:26:33 -0800 X-Google-Sender-Auth: bHYrDhSSF6iSYhcho5QOaxKGc6Q Message-ID: Subject: Re: Adding new media types to if_media.h From: Adrian Chadd To: mike@karels.net Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-net@freebsd.org" , "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:26:34 -0000 Looks good to me. Thanks for doing this! -a On 16 February 2015 at 17:50, Mike Karels wrote: > On Feb 9, gnn wrote: > >> On 8 Feb 2015, at 22:41, Mike Karels wrote: > >> > Sorry to reply to a thread after such a long delay, but I think it is >> > unresolved, and needs more discussion. I'd like to elaborate a bit on >> > my goals and proposal. I believe Adrian has newer thoughts than have >> > been >> > circulated here as well. >> > >> > The last message(s) have gone to freebsd-arch and freebsd-net. If >> > someone >> > wants to pick one, we could consolidate, but this seems relevant to >> > both. >> > >> > I'm going to top-post to try to summarize and extend the discussion, >> > but the >> > preceding emails follow for reference. >> > >> > To recap: the existing if_media interface is running out of steam, at >> > least >> > in that the "Media variant" field, with 5 bits, is going to be >> > insufficient >> > to express existing 40 Gb/s variants. The if_media media type is a >> > 32-bit >> > int with a bunch of sub-fields for type (e.g. Ethernet), >> > subtype/variant >> > (e.g. 10baseT, 10base5, 1000baseT, etc), flags, and some MII-related >> > fields. >> > >> > I made a proposal to extend the interface in a small way, specifically >> > to >> > replace the "media word" with a 64-bit int that is mostly the same, >> > but >> > has a new, larger variant/subtype field. The main reason for this >> > proposal >> > is to maintain the driver KPI (glimpse showed me 240 inclusions of >> > if_media.h >> > in the kernel in 8.2). That interface includes an initialization >> > using a >> > scalar value of fields ORed with each other. It would also be easy to >> > preserve a 32-bit user-level API/ABI that can express most of the >> > current >> > state, with a subtype/variant field value reserved for "other" (there >> > is >> > already one for "unknown", but that is not quite the same). fwiw, I >> > found 45 references to this user-level API in our tree, including both >> > base and "ports"-type software, which includes libpcap, snmpd, >> > dhclient, >> > quagga, xorp, atm, devd, and rtsold, which argues for a >> > backward-compatible >> > API/ABI as well as a more-complete current interface for ifconfig at >> > least. >> > >> > More generally, I see two problems with the existing if_media >> > interface: >> > >> > 1. It doesn't have enough bits for all the fields, in particular, >> > variant/ >> > subtype for Ethernet. That is the immediate issue. >> > >> > 2. The interface is not sufficiently generic; it was designed around >> > Ethernet >> > including MII, token ring, FDDI, and a few other interface types. >> > Some of >> > the fields like "instance" are primarily for MII as far as I know, and >> > are >> > basically unused. It is definitely not sufficient for 802.11, which >> > has >> > rolled its own interfaces. >> > >> > To solve the second problem, I think the right approach would be to >> > reduce >> > this interface to a truly generic one, such as media type (e.g. >> > Ethernet), >> > generic flags, and perhaps generic status. Then there should be a >> > separate >> > media-specific interface for each type, such as Ethernet and 802.11. >> > To a >> > small extent, we already have that. Solving the second, more general >> > problem, >> > requires a whole new driver KPI that will require surgery to every >> > driver, >> > which is not an exercise that I would consider. >> > >> > Using a separate int for each existing field, as proposed, would break >> > the >> > driver KPI, but would not really make the interface generic. Trying >> > to >> > make a single interface with the union of all network interface >> > requirements >> > seems like a bad idea to me (we failed last time; the "we" is BSDi, >> > where >> > I was the architect when this interface was first designed). (No, I >> > didn't >> > design this interface.) >> > >> > Solving the first problem only, I think it is preferable to preserve a >> > compatible driver KPI, which means using a scalar value encoding what >> > is >> > necessary. Although that interface is rather Ethernet-centric, that >> > is >> > really what it is used for. >> > >> > An additional, selfish goal is to make it easy to back-port drivers >> > using >> > the new interface to older versions (which I am quite likely to do). >> > Preserving the KPI and general user API will be highly useful there. >> > I'd be likely to do a 11-style version of ifconfig personally, but it >> > might not be difficult to do in a more general way. >> > >> > I am willing to do a prototype for -current for evaluation. >> > >> > Comments, alternatives, ? > >> I agree with your statements above and I'd like to see the prototype. > > Well, I developed the prototype as I had planned, using a 64-bit media > word, and found that I got about 100 files in GENERIC that didn't compile; > they attempted to store "media words" in an int. My kingdom for a typedef. > That didn't meet my goal of KPI compatibility, so I went to Plan B. > > Plan B is to steal an unused bit (RFU) to indicate an "extended" media > type. I then used the variant/subtype field to store the extended type. > Effectively, the previously unused bit doubles the effective size of the > subtype field. Given that the previous 5-bit field lasted us 18 years, > I figured that doubling it would last a while. I also changed the > SIOGGIFMEDIA ioctl, splitting it for binary compatibility; extended > types are all mapped to IFM_OTHER (31) using the old interface, but > are visible using the new one. > > With these changes, I modified one driver (vtnet) to use an extended type, > and the rest of GENERIC is happy. The changes to ifconfig are also fairly > small. The patch is appended, where email programs will screw it up, > or at ftp://ftp.karels.net/outgoing/if_media.patch. > > The VFAST subtype is a throw-away for testing. > > This seems like a reasonably pragmatic change to support the new 40 Gb/s > media types until someone wants to design an improved but non-backward- > compatible interface. I think it meets the goal of suitability for > back-porting; it could be MFCed. > > Mike > > Index: sys/net/if_media.h > =================================================================== > --- sys/net/if_media.h (revision 278804) > +++ sys/net/if_media.h (working copy) > @@ -120,15 +120,29 @@ > * 5-7 Media type > * 8-15 Type specific options > * 16-18 Mode (for multi-mode devices) > - * 19 RFU > + * 19 "extended" bit for media variant > * 20-27 Shared (global) options > * 28-31 Instance > */ > > /* > + * As we have used all of the original values for the media variant (subtype) > + * for Ethernet, extended subtypes have been added, marked with XSUBTYPE, > + * which is effectively the "high bit" of the media variant (subtype) field. > + * IFM_OTHER (the highest basic type) is reserved to indicate use of an > + * extended type when using an old SIOCGIFMEDIA operation. This is true > + * for all media types, not just Ethernet. > + */ > +#define XSUBTYPE 0x80000 /* extended variant high bit */ > +#define _X(var) ((var) | XSUBTYPE) /* extended variant */ > +#define IFM_OTHER 31 /* Other: some extended type */ > +#define OMEDIA(var) (((var) & XSUBTYPE) ? IFM_OTHER : (var)) > + > +/* > * Ethernet > */ > #define IFM_ETHER 0x00000020 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_10_T 3 /* 10BaseT - RJ45 */ > #define IFM_10_2 4 /* 10Base2 - Thinnet */ > #define IFM_10_5 5 /* 10Base5 - AUI */ > @@ -156,11 +170,17 @@ > #define IFM_40G_CR4 27 /* 40GBase-CR4 */ > #define IFM_40G_SR4 28 /* 40GBase-SR4 */ > #define IFM_40G_LR4 29 /* 40GBase-LR4 */ > +#define IFM_AVAIL30 30 /* available */ > +/* #define IFM_OTHER 31 Other: some extended type */ > +/* note 31 is the max! */ > + > +/* Extended variants/subtypes */ > +#define IFM_VFAST _X(0) /* test "V.fast" */ > +/* note _X(31) is the max! */ > /* > * Please update ieee8023ad_lacp.c:lacp_compose_key() > * after adding new Ethernet media types. > */ > -/* note 31 is the max! */ > > #define IFM_ETH_MASTER 0x00000100 /* master mode (1000baseT) */ > #define IFM_ETH_RXPAUSE 0x00000200 /* receive PAUSE frames */ > @@ -170,6 +190,7 @@ > * Token ring > */ > #define IFM_TOKEN 0x00000040 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_TOK_STP4 3 /* Shielded twisted pair 4m - DB9 */ > #define IFM_TOK_STP16 4 /* Shielded twisted pair 16m - DB9 */ > #define IFM_TOK_UTP4 5 /* Unshielded twisted pair 4m - RJ45 */ > @@ -187,6 +208,7 @@ > * FDDI > */ > #define IFM_FDDI 0x00000060 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_FDDI_SMF 3 /* Single-mode fiber */ > #define IFM_FDDI_MMF 4 /* Multi-mode fiber */ > #define IFM_FDDI_UTP 5 /* CDDI / UTP */ > @@ -220,6 +242,7 @@ > #define IFM_IEEE80211_OFDM27 23 /* OFDM 27Mbps */ > /* NB: not enough bits to express MCS fully */ > #define IFM_IEEE80211_MCS 24 /* HT MCS rate */ > +/* #define IFM_OTHER 31 Other: some extended type */ > > #define IFM_IEEE80211_ADHOC 0x00000100 /* Operate in Adhoc mode */ > #define IFM_IEEE80211_HOSTAP 0x00000200 /* Operate in Host AP mode */ > @@ -241,6 +264,7 @@ > * ATM > */ > #define IFM_ATM 0x000000a0 > +/* NB: 0,1,2 are auto, manual, none defined below */ > #define IFM_ATM_UNKNOWN 3 > #define IFM_ATM_UTP_25 4 > #define IFM_ATM_TAXI_100 5 > @@ -277,7 +301,7 @@ > * Masks > */ > #define IFM_NMASK 0x000000e0 /* Network type */ > -#define IFM_TMASK 0x0000001f /* Media sub-type */ > +#define IFM_TMASK 0x0008001f /* Media sub-type */ > #define IFM_IMASK 0xf0000000 /* Instance */ > #define IFM_ISHIFT 28 /* Instance shift */ > #define IFM_OMASK 0x0000ff00 /* Type specific options */ > @@ -372,6 +396,7 @@ > { IFM_40G_CR4, "40Gbase-CR4" }, \ > { IFM_40G_SR4, "40Gbase-SR4" }, \ > { IFM_40G_LR4, "40Gbase-LR4" }, \ > + { IFM_VFAST, "V.fast" }, \ > { 0, NULL }, \ > } > > @@ -603,6 +628,7 @@ > { IFM_AUTO, "autoselect" }, \ > { IFM_MANUAL, "manual" }, \ > { IFM_NONE, "none" }, \ > + { IFM_OTHER, "other" }, \ > { 0, NULL }, \ > } > > @@ -673,6 +699,7 @@ > { IFM_ETHER | IFM_40G_CR4, IF_Gbps(40ULL) }, \ > { IFM_ETHER | IFM_40G_SR4, IF_Gbps(40ULL) }, \ > { IFM_ETHER | IFM_40G_LR4, IF_Gbps(40ULL) }, \ > + { IFM_ETHER | IFM_VFAST, IF_Gbps(40ULL) }, \ > \ > { IFM_TOKEN | IFM_TOK_STP4, IF_Mbps(4) }, \ > { IFM_TOKEN | IFM_TOK_STP16, IF_Mbps(16) }, \ > Index: sys/sys/sockio.h > =================================================================== > --- sys/sys/sockio.h (revision 278810) > +++ sys/sys/sockio.h (working copy) > @@ -128,5 +128,6 @@ > #define SIOCGIFGROUP _IOWR('i', 136, struct ifgroupreq) /* get ifgroups */ > #define SIOCDIFGROUP _IOW('i', 137, struct ifgroupreq) /* delete ifgroup */ > #define SIOCGIFGMEMB _IOWR('i', 138, struct ifgroupreq) /* get members */ > +#define SIOCGIFXMEDIA _IOWR('i', 139, struct ifmediareq) /* get net xmedia */ > > #endif /* !_SYS_SOCKIO_H_ */ > Index: sys/net/if.c > =================================================================== > --- sys/net/if.c (revision 278749) > +++ sys/net/if.c (working copy) > @@ -2561,6 +2561,7 @@ > case SIOCGIFPSRCADDR: > case SIOCGIFPDSTADDR: > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > case SIOCGIFGENERIC: > if (ifp->if_ioctl == NULL) > return (EOPNOTSUPP); > Index: sys/net/if_media.c > =================================================================== > --- sys/net/if_media.c (revision 278804) > +++ sys/net/if_media.c (working copy) > @@ -67,7 +67,9 @@ > static struct ifmedia_entry *ifmedia_match(struct ifmedia *ifm, > int flags, int mask); > > +#define IFMEDIA_DEBUG > #ifdef IFMEDIA_DEBUG > +#include > int ifmedia_debug = 0; > SYSCTL_INT(_debug, OID_AUTO, ifmedia, CTLFLAG_RW, &ifmedia_debug, > 0, "if_media debugging msgs"); > @@ -271,6 +273,7 @@ > * Get list of available media and current media on interface. > */ > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > { > struct ifmedia_entry *ep; > int *kptr, count; > @@ -278,8 +281,13 @@ > > kptr = NULL; /* XXX gcc */ > > - ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? > - ifm->ifm_cur->ifm_media : IFM_NONE; > + if (cmd == SIOCGIFMEDIA) { > + ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? > + OMEDIA(ifm->ifm_cur->ifm_media) : IFM_NONE; > + } else { > + ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? > + ifm->ifm_cur->ifm_media : IFM_NONE; > + } > ifmr->ifm_mask = ifm->ifm_mask; > ifmr->ifm_status = 0; > (*ifm->ifm_status)(ifp, ifmr); > @@ -317,7 +325,10 @@ > ep = LIST_FIRST(&ifm->ifm_list); > for (; ep != NULL && count < ifmr->ifm_count; > ep = LIST_NEXT(ep, ifm_list), count++) > - kptr[count] = ep->ifm_media; > + if (cmd == SIOCGIFMEDIA) > + kptr[count] = OMEDIA(ep->ifm_media); > + else > + kptr[count] = ep->ifm_media; > > if (ep != NULL) > error = E2BIG; /* oops! */ > @@ -505,7 +516,7 @@ > printf("\n"); > return; > } > - printf(desc->ifmt_string); > + printf("%s", desc->ifmt_string); > > /* Any mode. */ > for (desc = ttos->modes; desc && desc->ifmt_string != NULL; desc++) > > Index: sys/dev/virtio/network/if_vtnet.c > =================================================================== > --- sys/dev/virtio/network/if_vtnet.c (revision 278749) > +++ sys/dev/virtio/network/if_vtnet.c (working copy) > @@ -938,6 +938,7 @@ > ifmedia_init(&sc->vtnet_media, IFM_IMASK, vtnet_ifmedia_upd, > vtnet_ifmedia_sts); > ifmedia_add(&sc->vtnet_media, VTNET_MEDIATYPE, 0, NULL); > + ifmedia_add(&sc->vtnet_media, IFM_ETHER | IFM_VFAST, 0, NULL); > ifmedia_set(&sc->vtnet_media, VTNET_MEDIATYPE); > > /* Read (or generate) the MAC address for the adapter. */ > @@ -1103,6 +1104,7 @@ > > case SIOCSIFMEDIA: > case SIOCGIFMEDIA: > + case SIOCGIFXMEDIA: > error = ifmedia_ioctl(ifp, ifr, &sc->vtnet_media, cmd); > break; > Index: sbin/ifconfig/ifmedia.c > =================================================================== > --- sbin/ifconfig/ifmedia.c (revision 278749) > +++ sbin/ifconfig/ifmedia.c (working copy) > @@ -109,11 +109,17 @@ > { > struct ifmediareq ifmr; > int *media_list, i; > + int xmedia = 1; > > (void) memset(&ifmr, 0, sizeof(ifmr)); > (void) strncpy(ifmr.ifm_name, name, sizeof(ifmr.ifm_name)); > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > + /* > + * Check if interface supports extended media types. > + */ > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > + xmedia = 0; > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > /* > * Interface doesn't support SIOC{G,S}IFMEDIA. > */ > @@ -130,8 +136,13 @@ > err(1, "malloc"); > ifmr.ifm_ulist = media_list; > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > - err(1, "SIOCGIFMEDIA"); > + if (xmedia) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > + err(1, "SIOCGIFXMEDIA"); > + } else { > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > + err(1, "SIOCGIFMEDIA"); > + } > > printf("\tmedia: "); > print_media_word(ifmr.ifm_current, 1); > @@ -194,6 +205,7 @@ > { > static struct ifmediareq *ifmr = NULL; > int *mwords; > + int xmedia = 1; > > if (ifmr == NULL) { > ifmr = (struct ifmediareq *)malloc(sizeof(struct ifmediareq)); > @@ -213,7 +225,10 @@ > * the current media type and the top-level type. > */ > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) { > + xmedia = 0; > + } > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { > err(1, "SIOCGIFMEDIA"); > } > > @@ -225,8 +240,13 @@ > err(1, "malloc"); > > ifmr->ifm_ulist = mwords; > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > - err(1, "SIOCGIFMEDIA"); > + if (xmedia) { > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) > + err(1, "SIOCGIFXMEDIA"); > + } else { > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > + err(1, "SIOCGIFMEDIA"); > + } > } > > return ifmr; > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:36:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 212BAE69 for ; Tue, 17 Feb 2015 17:36:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEF01671 for ; Tue, 17 Feb 2015 17:36:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHao9O089064 for ; Tue, 17 Feb 2015 17:36:50 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHaoC9089063; Tue, 17 Feb 2015 17:36:50 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:36:50 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <063f5de83a7a002f029adecf5a667314@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjfDI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:36:51 -0000 rrs added a comment. Hiren: Thats helpful.. as I said this is strange. The callout you posted shows its associated with CPU 0, (c_cpu == 0), and yet the mtx on that (which is what we are spinning on) is free (its owned == 4). So why would we have crashed holding the spin lock too long? Unless just as we decided to panic the owner released it. Hmm there is code in there to check that though.. td = mtx_owner() if (td == NULL) return... The c_flags = 22 which is PENDING/ACTIVE and Return unlocked. That means it is *supposed* to be on the callout wheel someplace. The linked list used is then the LLIST.. i.e. {le_next = 0x0, le_prev = 0xfffffe0000804db8} Now if le_next is 0, its the end of the list. Can you look back a the previous.. i.e. walk it back print *(struct callout *)0xfffffe0000804db8 That should print a valid callout as well.. and we should be able to walk back to the top of the wheel.. by keeping on moving back. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:43:04 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 22F502E7 for ; Tue, 17 Feb 2015 17:43:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 048A67A0 for ; Tue, 17 Feb 2015 17:43:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHh3QD096510 for ; Tue, 17 Feb 2015 17:43:03 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHh3sW096509; Tue, 17 Feb 2015 17:43:03 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:43:03 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 7 lines] D1868: Make libnv headers includable from C++ Message-ID: X-Priority: 3 Thread-Topic: D1868: Make libnv headers includable from C++ X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: OWRjMTRmYjQ5YzQ2YzVmY2VhMGEzM2Q1YTg1 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:43:04 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1868 AFFECTED FILES lib/libnv/dnv.h lib/libnv/nv.h To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:43:50 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 050FA3C7 for ; Tue, 17 Feb 2015 17:43:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB53B7B0 for ; Tue, 17 Feb 2015 17:43:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHhnmV097033 for ; Tue, 17 Feb 2015 17:43:49 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHhnsR097032; Tue, 17 Feb 2015 17:43:49 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:43:49 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 309 lines] D1869: Tests of basic nvlist add functions Message-ID: X-Priority: 3 Thread-Topic: D1869: Tests of basic nvlist add functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: YmI4OTE5NjAxYjk3NGQwNTQ3YmRmODFjMzVk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:43:50 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1869 AFFECTED FILES lib/libnv/Makefile lib/libnv/tests/Makefile lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:43:50 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BD8E03CE for ; Tue, 17 Feb 2015 17:43:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A01B87B5 for ; Tue, 17 Feb 2015 17:43:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHhoSR097077 for ; Tue, 17 Feb 2015 17:43:50 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHhoaU097076; Tue, 17 Feb 2015 17:43:50 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:43:50 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 120 lines] D1870: Add tests for nvlist_clone Message-ID: X-Priority: 3 Thread-Topic: D1870: Add tests for nvlist_clone X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: YzdhNWFmMzVlZWYzY2IzNDlmMTM3MmY4ZjU0 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:43:50 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:01 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 860064E9 for ; Tue, 17 Feb 2015 17:44:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 689D77C0 for ; Tue, 17 Feb 2015 17:44:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHi141097304 for ; Tue, 17 Feb 2015 17:44:01 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHi14g097303; Tue, 17 Feb 2015 17:44:01 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:01 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 185 lines] D1871: Add tests for nvlist_pack/unpack Message-ID: X-Priority: 3 Thread-Topic: D1871: Add tests for nvlist_pack/unpack X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: ZjE0ZjFmNGMwMDdhNWFlNTZiMmMyYzFlOWZh X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:01 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1871 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 190C357B for ; Tue, 17 Feb 2015 17:44:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EFAF27CA for ; Tue, 17 Feb 2015 17:44:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHi6Vl097376 for ; Tue, 17 Feb 2015 17:44:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHi6qK097375; Tue, 17 Feb 2015 17:44:06 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:06 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 82 lines] D1872: Add test cases for nvlist_move_* Message-ID: X-Priority: 3 Thread-Topic: D1872: Add test cases for nvlist_move_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: NmEyYzJiMjM0NjMwMTZiZjkyMmIzOThiYTIx X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:07 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1872 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:17 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 73C9560C for ; Tue, 17 Feb 2015 17:44:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 564587D5 for ; Tue, 17 Feb 2015 17:44:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHiHbi097537 for ; Tue, 17 Feb 2015 17:44:17 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHiHkR097536; Tue, 17 Feb 2015 17:44:17 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:17 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 292 lines] D1873: Add tests for nvlist_take_* Message-ID: X-Priority: 3 Thread-Topic: D1873: Add tests for nvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: ZmVhMDUyMmU1Y2QxYzQxY2VkNWZiMDUyYmE4 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:17 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1873 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:22 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C4F5D69B for ; Tue, 17 Feb 2015 17:44:22 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A75017DB for ; Tue, 17 Feb 2015 17:44:22 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHiMm2097589 for ; Tue, 17 Feb 2015 17:44:22 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHiMia097588; Tue, 17 Feb 2015 17:44:22 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:22 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 206 lines] D1874: Add tests for nvlist_free* functions Message-ID: X-Priority: 3 Thread-Topic: D1874: Add tests for nvlist_free* functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: MzZkMTAwZDc4MmI2OWExNDZiN2EwMDcyZjUz X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:22 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1874 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:33 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 42FFB732 for ; Tue, 17 Feb 2015 17:44:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 233837E6 for ; Tue, 17 Feb 2015 17:44:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHiWuH097855 for ; Tue, 17 Feb 2015 17:44:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHiW7W097854; Tue, 17 Feb 2015 17:44:32 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:32 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1661: Add some security-related config parameters Message-ID: <8db5a2acdd5679958aba0c787107792c@localhost.localdomain> X-Priority: 3 Thread-Topic: D1661: Add some security-related config parameters X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MjUxNWUxN2JmMmRmYzQ5MzQyZmZlNzZlOTY2IFTjfgA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:33 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1661 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED17672A for ; Tue, 17 Feb 2015 17:44:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEE897E2 for ; Tue, 17 Feb 2015 17:44:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHiWbP097843 for ; Tue, 17 Feb 2015 17:44:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHiWdk097840; Tue, 17 Feb 2015 17:44:32 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:32 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 290 lines] D1875: Add tests for dnv_get_* Message-ID: X-Priority: 3 Thread-Topic: D1875: Add tests for dnv_get_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: MDdlZjc2MzE0YTE1YzZlZTQ2MDIzYTVjMjRj X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:33 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1875 AFFECTED FILES lib/libnv/tests/Makefile lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:39 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC42E84B for ; Tue, 17 Feb 2015 17:44:39 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8E5327EC for ; Tue, 17 Feb 2015 17:44:39 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHidUe097940 for ; Tue, 17 Feb 2015 17:44:39 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHid4v097939; Tue, 17 Feb 2015 17:44:39 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:39 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 288 lines] D1876: Add tests for dnvlist_take_* Message-ID: X-Priority: 3 Thread-Topic: D1876: Add tests for dnvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: MDBkNDVlNDM2OWUwZjdhM2U4YjdkNzA1Y2Q2 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:39 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1876 AFFECTED FILES lib/libnv/tests/dnv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:46 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 727A08DF for ; Tue, 17 Feb 2015 17:44:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 54D6E7F8 for ; Tue, 17 Feb 2015 17:44:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHik7B098105 for ; Tue, 17 Feb 2015 17:44:46 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHikSi098104; Tue, 17 Feb 2015 17:44:46 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:46 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1660: Add support for mac-addr parameter Message-ID: <1e9a345a42a896c37d9e18008bdd1a1f@localhost.localdomain> X-Priority: 3 Thread-Topic: D1660: Add support for mac-addr parameter X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZWE5ZGNjNWRmODc2N2E5NGNhNGQwMTExOWMxIFTjfg4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:46 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1660 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:49 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EC07996D for ; Tue, 17 Feb 2015 17:44:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CEBEB800 for ; Tue, 17 Feb 2015 17:44:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHinvT098178 for ; Tue, 17 Feb 2015 17:44:49 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHincr098175; Tue, 17 Feb 2015 17:44:49 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:49 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 82 lines] D1877: Implement asprintf in libkern Message-ID: X-Priority: 3 Thread-Topic: D1877: Implement asprintf in libkern X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: N2UzMzZkZWVmYzI1ZDNmYzIzZDNmMmU4YzAx X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:50 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1877 AFFECTED FILES sys/conf/files sys/libkern/asprintf.c sys/sys/systm.h To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:53 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 56D1C9FB for ; Tue, 17 Feb 2015 17:44:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3849B806 for ; Tue, 17 Feb 2015 17:44:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHiquu098229 for ; Tue, 17 Feb 2015 17:44:52 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHiqDW098226; Tue, 17 Feb 2015 17:44:52 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:52 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1659: Register ixl as an SR-IOV-capable driver during attach Message-ID: <2654bfe13fc8a8740f8b42edc9513f1d@localhost.localdomain> X-Priority: 3 Thread-Topic: D1659: Register ixl as an SR-IOV-capable driver during attach X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MWEzYTlmNjM0ZjU1ZjZiMTRhYzdkZDlmYjZkIFTjfhQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:53 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1659 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:44:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A4E80A8D for ; Tue, 17 Feb 2015 17:44:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8403280F for ; Tue, 17 Feb 2015 17:44:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHixt3098349 for ; Tue, 17 Feb 2015 17:44:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHix2i098347; Tue, 17 Feb 2015 17:44:59 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:59 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 60 lines] D1878: Add function to force an nvlist into the error state Message-ID: X-Priority: 3 Thread-Topic: D1878: Add function to force an nvlist into the error state X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: M2JhMDMyYjI3NjA3ZWFkYTcyMjkzMmZmMjk0 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:44:59 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Add an nvlist_set_error() function that can be used to force an nvlist into the error state. This is useful both for writing tests and for writing APIs that use nvlists internally. REVISION DETAIL https://reviews.freebsd.org/D1878 AFFECTED FILES lib/libnv/Makefile lib/libnv/nv.3 lib/libnv/nv.h lib/libnv/nvlist.c lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:00 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B9D3A93 for ; Tue, 17 Feb 2015 17:45:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0CC25812 for ; Tue, 17 Feb 2015 17:45:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHixGB098363 for ; Tue, 17 Feb 2015 17:44:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHix0i098362; Tue, 17 Feb 2015 17:44:59 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:44:59 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1658: Add sysctls for per-VF hardware counters Message-ID: <120fa37504be508bc455bd39f3f4ea46@localhost.localdomain> X-Priority: 3 Thread-Topic: D1658: Add sysctls for per-VF hardware counters X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OWE0YzQwMmZkYjZmN2FjNjA4MWQ1MGYxZmY1IFTjfhs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:00 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1658 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5F1A5C90 for ; Tue, 17 Feb 2015 17:45:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 40BE981B for ; Tue, 17 Feb 2015 17:45:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHj6iC098527 for ; Tue, 17 Feb 2015 17:45:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHj6p0098526; Tue, 17 Feb 2015 17:45:06 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:06 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 395 lines] D1879: Don't allocate memory for operations that do not insert Message-ID: X-Priority: 3 Thread-Topic: D1879: Don't allocate memory for operations that do not insert X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: MDkxYjIwNjU5MjIyMTY3Zjg4MGE2Y2JhMzdk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:07 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Almost every operation performed on an nvlist was allocating a new string to hold the key name. The nvlist_exists* family of functions would always return false if they failed to allocate the string. The rest of the functions would outright abort(). Fix the non-varargs variants of the functions to perform the requested operations directly and the varargs versions to allocate the string and call into the non-varargs versions. The varargs versions are still broken and really can't be fixed, so we might consider axing them entirely. However, now the non- varargs functions are always safe to call. REVISION DETAIL https://reviews.freebsd.org/D1879 AFFECTED FILES lib/libnv/dnvlist.c lib/libnv/nv_impl.h lib/libnv/nvlist.c To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:16 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9ECF4D36 for ; Tue, 17 Feb 2015 17:45:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80E88826 for ; Tue, 17 Feb 2015 17:45:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjGbc098638 for ; Tue, 17 Feb 2015 17:45:16 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjG9U098637; Tue, 17 Feb 2015 17:45:16 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:16 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 39 lines] D1880: Prevent creation of an invalid nvlist Message-ID: X-Priority: 3 Thread-Topic: D1880: Prevent creation of an invalid nvlist X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: NDc0MzY1NWE0OGUwMDY2MmUyOTI4NDYxZjhl X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:16 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY If an nvlist is set as a child of another nvlist with nvlist_move_nvlist then fail the operation and set the parent nvlist to the error state. REVISION DETAIL https://reviews.freebsd.org/D1880 AFFECTED FILES lib/libnv/nvpair.c lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 54B98DC6 for ; Tue, 17 Feb 2015 17:45:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3679782C for ; Tue, 17 Feb 2015 17:45:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjJ6X098660 for ; Tue, 17 Feb 2015 17:45:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjJXa098659; Tue, 17 Feb 2015 17:45:19 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:19 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1657: Allow VFs to run while the PF is admin down Message-ID: X-Priority: 3 Thread-Topic: D1657: Allow VFs to run while the PF is admin down X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2EyNmJlZTU5MWYxMjQxNTNiNmRlMzQzYjQxIFTjfi8= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:20 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1657 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9656CE5E for ; Tue, 17 Feb 2015 17:45:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 78409837 for ; Tue, 17 Feb 2015 17:45:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjRNn098698 for ; Tue, 17 Feb 2015 17:45:27 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjRVT098697; Tue, 17 Feb 2015 17:45:27 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:27 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1656: Handle VFLR events from VFs Message-ID: <5d6ae518be151fb819c9a0fef51f8b23@localhost.localdomain> X-Priority: 3 Thread-Topic: D1656: Handle VFLR events from VFs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MjAxYmVkMTcyNjY3NDZhMmYxYWVkM2NmMGRiIFTjfjc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:27 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1656 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:26 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E998DE54 for ; Tue, 17 Feb 2015 17:45:26 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CBC6C831 for ; Tue, 17 Feb 2015 17:45:26 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjQjH098682 for ; Tue, 17 Feb 2015 17:45:26 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjQlc098681; Tue, 17 Feb 2015 17:45:26 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:26 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 259 lines] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJm X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:27 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1881 AFFECTED FILES sys/cddl/compat/opensolaris/sys/nvpair.h To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F9C1F72 for ; Tue, 17 Feb 2015 17:45:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 11BCC83C for ; Tue, 17 Feb 2015 17:45:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjXOK098747 for ; Tue, 17 Feb 2015 17:45:33 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjXQD098746; Tue, 17 Feb 2015 17:45:33 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:33 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1655: Add support for GET_STATS VC message Message-ID: X-Priority: 3 Thread-Topic: D1655: Add support for GET_STATS VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2VlZmI5Nzk5ZGE5MDQ2YzE4OWMyZjdiMDU1IFTjfj0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:34 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1655 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9B7DF77 for ; Tue, 17 Feb 2015 17:45:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9BBB383F for ; Tue, 17 Feb 2015 17:45:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjYLH098759 for ; Tue, 17 Feb 2015 17:45:34 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjYbk098758; Tue, 17 Feb 2015 17:45:34 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:34 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 471 lines] D1882: Add macros to make code compile in kernel Message-ID: X-Priority: 3 Thread-Topic: D1882: Add macros to make code compile in kernel X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: YzM1ZTc3MTdjMzBlN2YyNTZkMjI0ODE2M2Ew X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:34 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION SUMMARY Make it possible to compile libnv in the kernel. Mostly this involves wrapping functions that have a different signature in the kernel and in userland (e.g. malloc()) in a macro that will conditionally expand to the right API depending on whether the code is being compiled for the kernel or not. I have also #ifdef'ed out all of file descriptor-handling code, as well as the unsafe varargs functions. REVISION DETAIL https://reviews.freebsd.org/D1882 AFFECTED FILES lib/libnv/dnv.h lib/libnv/dnvlist.c lib/libnv/nv.h lib/libnv/nv_impl.h lib/libnv/nvlist.c lib/libnv/nvlist_impl.h lib/libnv/nvpair.c lib/libnv/nvpair_impl.h To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:50 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 93DC511D for ; Tue, 17 Feb 2015 17:45:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 74F00849 for ; Tue, 17 Feb 2015 17:45:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjoqi098997 for ; Tue, 17 Feb 2015 17:45:50 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjo7a098996; Tue, 17 Feb 2015 17:45:50 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:50 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Request, 1, 516 lines] D1883: Move libnv into the kernel and hook it into the kernel build Message-ID: X-Priority: 3 Thread-Topic: D1883: Move libnv into the kernel and hook it into the kernel build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: Thread-Index: N2Q5ZWNkMThmZjdlZTk0ZDk5ZmI5ODEzODU4 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:50 -0000 rstone created this revision. rstone added a reviewer: jfvogel. rstone added subscribers: pjd, freebsd-net. REVISION DETAIL https://reviews.freebsd.org/D1883 AFFECTED FILES lib/libnv/Makefile lib/libnv/dnv.h lib/libnv/dnvlist.c lib/libnv/nv.h lib/libnv/nv_impl.h lib/libnv/nvlist.c lib/libnv/nvlist_impl.h lib/libnv/nvpair.c lib/libnv/nvpair_impl.h sys/conf/files sys/kern/subr_dnvlist.c sys/kern/subr_nvlist.c sys/kern/subr_nvpair.c sys/sys/dnv.h sys/sys/nv.h sys/sys/nv_impl.h sys/sys/nvlist_impl.h sys/sys/nvpair_impl.h To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:45:57 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4A3A61AC for ; Tue, 17 Feb 2015 17:45:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2B9E8850 for ; Tue, 17 Feb 2015 17:45:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHjuK7099158 for ; Tue, 17 Feb 2015 17:45:56 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHjued099157; Tue, 17 Feb 2015 17:45:56 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:45:56 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message Message-ID: <404119931dd7f6cdba0081ff5dfcccf3@localhost.localdomain> X-Priority: 3 Thread-Topic: D1654: Add support for CONFIG_PROMISCUOUS_MODE VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ODZlMGNmMmIwNjllNDI3NzNjZDY5MDBlOTFhIFTjflQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:45:57 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1654 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:03 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6B446212 for ; Tue, 17 Feb 2015 17:46:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4AF58859 for ; Tue, 17 Feb 2015 17:46:03 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHk3kZ099226 for ; Tue, 17 Feb 2015 17:46:03 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHk3uF099225; Tue, 17 Feb 2015 17:46:03 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:03 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1653: Add support for ADD/DEL_VLAN VC messages Message-ID: <733ce74b791e69be149629c790e1c673@localhost.localdomain> X-Priority: 3 Thread-Topic: D1653: Add support for ADD/DEL_VLAN VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2ZkZmUyNmRjYTBlOGYyYTlmNjY4MTQyOTZlIFTjfls= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:03 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1653 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EE4252CB for ; Tue, 17 Feb 2015 17:46:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CFB3785D for ; Tue, 17 Feb 2015 17:46:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHk7OE099298 for ; Tue, 17 Feb 2015 17:46:07 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHk7KS099297; Tue, 17 Feb 2015 17:46:07 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:07 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages Message-ID: <5c41e5ddbbed61bda3feff1fb19eaebc@localhost.localdomain> X-Priority: 3 Thread-Topic: D1652: Add support for ADD/DEL_ETHER_ADDRESS VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzM5Y2U0ZjQwMTJmYWViOTFkMDMyZmM4NGIzIFTjfl8= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:08 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1652 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:25 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3821835E for ; Tue, 17 Feb 2015 17:46:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 16BCA865 for ; Tue, 17 Feb 2015 17:46:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkOTr099464 for ; Tue, 17 Feb 2015 17:46:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkOnx099442; Tue, 17 Feb 2015 17:46:24 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:24 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1651: Add support for ENABLE/DISABLE_QUEUES VC messages Message-ID: <9ecb7a24fbcff89236a739ca07c59197@localhost.localdomain> X-Priority: 3 Thread-Topic: D1651: Add support for ENABLE/DISABLE_QUEUES VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NzRiMTE2MzFlMGU1Yzg4ZDYyZDE0NWY0ZTZlIFTjfnA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:25 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1651 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:31 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 770F13F0 for ; Tue, 17 Feb 2015 17:46:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5956D86D for ; Tue, 17 Feb 2015 17:46:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkV6D099584 for ; Tue, 17 Feb 2015 17:46:31 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkVv8099583; Tue, 17 Feb 2015 17:46:31 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:31 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1650: Add support for CONFIG_IRQ_MAP VC message Message-ID: <395e5fa9254289d676fd0f9cdd035f47@localhost.localdomain> X-Priority: 3 Thread-Topic: D1650: Add support for CONFIG_IRQ_MAP VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGIzNWI2MTYxYWRjMTI0NjU4YTJkZTYwY2Q2IFTjfnc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:31 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1650 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2E44595 for ; Tue, 17 Feb 2015 17:46:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B34BC871 for ; Tue, 17 Feb 2015 17:46:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkY3l099649 for ; Tue, 17 Feb 2015 17:46:34 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkYDm099646; Tue, 17 Feb 2015 17:46:34 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:34 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1649: Add support for CONFIG_VSI_QUEUES VC message Message-ID: X-Priority: 3 Thread-Topic: D1649: Add support for CONFIG_VSI_QUEUES VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NzBjMzdhMjA1NGRjOGJkMTFiY2ViZGYyMDRkIFTjfno= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:34 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1649 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:49 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B8B2644 for ; Tue, 17 Feb 2015 17:46:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0D11887A for ; Tue, 17 Feb 2015 17:46:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkm9w099853 for ; Tue, 17 Feb 2015 17:46:48 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkmDv099852; Tue, 17 Feb 2015 17:46:48 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:48 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1647: Add support for GET_VF_RESOURCES VC message Message-ID: <455169eaa90002216b110f1dcf3b8618@localhost.localdomain> X-Priority: 3 Thread-Topic: D1647: Add support for GET_VF_RESOURCES VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmFkOTJjNjIzYWI1MTUxNDE0ZGM3MmQ2MTc0IFTjfog= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:49 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1647 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:55 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9F036D4 for ; Tue, 17 Feb 2015 17:46:55 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABD8D880 for ; Tue, 17 Feb 2015 17:46:55 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkte9000174 for ; Tue, 17 Feb 2015 17:46:55 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkttP000173; Tue, 17 Feb 2015 17:46:55 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:55 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1646: Add support for RESET_VF VC message Message-ID: <4f3426671b5690976879c3c96c90e857@localhost.localdomain> X-Priority: 3 Thread-Topic: D1646: Add support for RESET_VF VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZTA1MzIxZDNjN2MzMDRiYzg0ZWYwMDZjYmQwIFTjfo8= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:55 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1646 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:46:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 68F5475F for ; Tue, 17 Feb 2015 17:46:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 497F8884 for ; Tue, 17 Feb 2015 17:46:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHkxNg000186 for ; Tue, 17 Feb 2015 17:46:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHkx9Y000185; Tue, 17 Feb 2015 17:46:59 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:46:58 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1645: Add support for VERSION VC message Message-ID: <67c0b31b0fce2f9d5e2265d03309c460@localhost.localdomain> X-Priority: 3 Thread-Topic: D1645: Add support for VERSION VC message X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MjYzNzUyNDQxYTA3Y2RhZGM3M2FmMDUwYmQwIFTjfpI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:46:59 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1645 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:47:11 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5739C7F9 for ; Tue, 17 Feb 2015 17:47:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3852B88D for ; Tue, 17 Feb 2015 17:47:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHlA2I000387 for ; Tue, 17 Feb 2015 17:47:10 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHlAvR000380; Tue, 17 Feb 2015 17:47:10 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:47:10 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1644: Add infrastructure for handling the VC msg channel from VFs Message-ID: X-Priority: 3 Thread-Topic: D1644: Add infrastructure for handling the VC msg channel from VFs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NWFiMWUzZDU0ODgxNGJiOTVkN2EzZDdiZjI3IFTjfp4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:47:11 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1644 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:47:21 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15A77888 for ; Tue, 17 Feb 2015 17:47:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA6F0891 for ; Tue, 17 Feb 2015 17:47:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHlKBE000585 for ; Tue, 17 Feb 2015 17:47:20 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHlKxv000584; Tue, 17 Feb 2015 17:47:20 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:47:20 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1643: Implement resetting a VF Message-ID: <7d8cf7a2c5060e6d6c07a7a1aa23cf56@localhost.localdomain> X-Priority: 3 Thread-Topic: D1643: Implement resetting a VF X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDJmMjIzMGI5NWVmMGNmNjI3NTcwNmNhOWQ0IFTjfqg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:47:21 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1643 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:47:24 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D147C914 for ; Tue, 17 Feb 2015 17:47:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2C7E894 for ; Tue, 17 Feb 2015 17:47:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHlOa6000605 for ; Tue, 17 Feb 2015 17:47:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHlO3Z000604; Tue, 17 Feb 2015 17:47:24 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:47:24 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1642: Implement PCI SR-IOV method to initialize individual VFs Message-ID: <08cba9d84a175af9a591965cfbb17cd5@localhost.localdomain> X-Priority: 3 Thread-Topic: D1642: Implement PCI SR-IOV method to initialize individual VFs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmZlNzY0OTVkYmNlM2JkOWFhZWQ3MjBhMjA1IFTjfqw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:47:24 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1642 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:47:57 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5DB509B7 for ; Tue, 17 Feb 2015 17:47:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E56C8A1 for ; Tue, 17 Feb 2015 17:47:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHlusK001122 for ; Tue, 17 Feb 2015 17:47:56 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHlufT001121; Tue, 17 Feb 2015 17:47:56 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:47:56 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1640: Refactor network stack state separate from VSI state Message-ID: <43c0025ad5d918f19581001305959572@localhost.localdomain> X-Priority: 3 Thread-Topic: D1640: Refactor network stack state separate from VSI state X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2JmNDRjOWRkY2RlYmQ2NjRjZDUxYzYxNjBmIFTjfsw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:47:57 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1640 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:48:01 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5AF3A44 for ; Tue, 17 Feb 2015 17:48:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C77448A4 for ; Tue, 17 Feb 2015 17:48:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHm19Z001184 for ; Tue, 17 Feb 2015 17:48:01 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHm1G9001183; Tue, 17 Feb 2015 17:48:01 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:48:01 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1641: Implement PCI SR-IOV initialization methods Message-ID: X-Priority: 3 Thread-Topic: D1641: Implement PCI SR-IOV initialization methods X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZWFiODdhYWU0YTRhNWFiMzk2YmRlMzA0YTZlIFTjftE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:48:02 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1641 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:50:11 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C8F5DB24 for ; Tue, 17 Feb 2015 17:50:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 830388D3 for ; Tue, 17 Feb 2015 17:50:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHoBFi003239 for ; Tue, 17 Feb 2015 17:50:11 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHoB99003238; Tue, 17 Feb 2015 17:50:11 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:50:11 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <8ea9c2935d1adfeeceb29ea19aeffca2@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjf1M= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:50:11 -0000 rrs added a comment. Hiren: There also should have been a printf before the panic string printf( "spin lock %p (%s) held by %p (tid %d) too long\n", m, m->lock_object.lo_name, td, td->td_tid); Can we see what that lovely printf has displayed? In theory the lo_name should be "callout" and the %p should point to &cc_cpu[0].cc_lock Can we validate that these align correctly too? REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 17:58:59 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D7A97DF9 for ; Tue, 17 Feb 2015 17:58:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABC9D9D1 for ; Tue, 17 Feb 2015 17:58:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HHwxnT012639 for ; Tue, 17 Feb 2015 17:58:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HHwxlo012638; Tue, 17 Feb 2015 17:58:59 GMT (envelope-from root) Date: Tue, 17 Feb 2015 17:58:59 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <3cda038b82b597dca5eb5409987900c6@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjgWM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 17:59:00 -0000 hiren added a comment. >>! In D1711#91, @rrs wrote: > Hiren: > > Thats helpful.. as I said this is strange. The callout you posted shows its associated with CPU 0, (c_cpu == 0), and yet > the mtx on that (which is what we are spinning on) is free (its owned == 4). So why would we have crashed > holding the spin lock too long? Unless just as we decided to panic the owner released it. Hmm there is > code in there to check that though.. td = mtx_owner() if (td == NULL) return... > > The c_flags = 22 which is PENDING/ACTIVE and Return unlocked. That means it is *supposed* to be on the > callout wheel someplace. The linked list used is then the LLIST.. i.e. {le_next = 0x0, le_prev = 0xfffffe0000804db8} > > Now if le_next is 0, its the end of the list. > > Can you look back a the previous.. i.e. walk it back > > print *(struct callout *)0xfffffe0000804db8 > > That should print a valid callout as well.. and we should be able to walk back to > the top of the wheel.. by keeping on moving back. Hrm, are there only 2 entries here? (kgdb) print *(struct callout *)0xfffffe0000804db8 $4 = {c_links = {le = {le_next = 0xfffff8000d81dc98, le_prev = 0x0}, sle = {sle_next = 0xfffff8000d81dc98}, tqe = {tqe_next = 0xfffff8000d81dc98, tqe_prev = 0x0}}, c_time = 0, c_precision = 0, c_arg = 0x0, c_func = 0, c_lock = 0x0, c_flags = 0, c_cpu = 0} le_next is back to 0xfffff8000d81dc98. Anything else I should look at? REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 18:07:19 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23342262 for ; Tue, 17 Feb 2015 18:07:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA459AFC for ; Tue, 17 Feb 2015 18:07:18 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HI7Ijw021726 for ; Tue, 17 Feb 2015 18:07:18 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HI7Ibs021725; Tue, 17 Feb 2015 18:07:18 GMT (envelope-from root) Date: Tue, 17 Feb 2015 18:07:18 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <605e6b6bb917b389bcc33d39c04388a3@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjg1Y= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 18:07:19 -0000 hiren added a comment. >>! In D1711#92, @rrs wrote: > Hiren: > > There also should have been a printf before the panic string > printf( "spin lock %p (%s) held by %p (tid %d) too long\n", > m, m->lock_object.lo_name, td, td->td_tid); > > Can we see what that lovely printf has displayed? Ah, my bad for not providing that earlier here: spin lock 0xffffffff81364180 (callout) held by 0xfffff8000dc0e920 (tid 100111) too long panic: spin lock held too long Now, (kgdb) print *(struct callout *)0xffffffff81364180 $8 = {c_links = {le = {le_next = 0xffffffff80d03d28, le_prev = 0xb0000}, sle = {sle_next = 0xffffffff80d03d28}, tqe = {tqe_next = 0xffffffff80d03d28, tqe_prev = 0xb0000}}, c_time = 0, c_precision = 4, c_arg = 0x0, c_func = 0, c_lock = 0x0, c_flags = 0, c_cpu = 0} if I print it's le_next, that node's le_prev is not pointing to 0xffffffff81364180 (kgdb) print *(struct callout *)0xffffffff80d03d28 $9 = {c_links = {le = {le_next = 0x74756f6c6c6163, le_prev = 0x6f207265626d754e}, sle = {sle_next = 0x74756f6c6c6163}, tqe = {tqe_next = 0x74756f6c6c6163, tqe_prev = 0x6f207265626d754e}}, c_time = 7307497714779234406, c_precision = 7809632219779637363, c_arg = 0x61206c656568776c, c_func = 0x20657a697320646e, c_lock = 0x6f656d697420666f, c_flags = 690517109, c_cpu = 1701998624} Also, trying to print le_next or le_prev is not working: (kgdb) print *(struct callout *)0x6f207265626d754e Cannot access memory at address 0x6f207265626d754e (kgdb) print *(struct callout *)0x74756f6c6c6163 Cannot access memory at address 0x74756f6c6c6163 Is something wrong here or I am failing to understand this. (The latter has a higher probability) > > In theory the lo_name should be "callout" and the %p should point to &cc_cpu[0].cc_lock > > Can we validate that these align correctly too? How do I validate it? REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 18:09:06 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E358B342 for ; Tue, 17 Feb 2015 18:09:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98C6EB22 for ; Tue, 17 Feb 2015 18:09:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HI96rW023270 for ; Tue, 17 Feb 2015 18:09:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HI96kp023268; Tue, 17 Feb 2015 18:09:06 GMT (envelope-from root) Date: Tue, 17 Feb 2015 18:09:06 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <183a768dbd885e956fcad97efa81e207@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjg8I= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 18:09:07 -0000 rrs added a comment. Wow, but look at the flags here. They are cc_flags == 0. That means its *not* on the wheel and yet the thing it points to (our victim) *thinks* its on the wheel. This is not good.. We are stuck in a lock trying to reschedule the timeout (a lock that is not locked by the way yet we kept spinning).. but PENDING/ACTIVE flag are set. Those should be off if it was not on the callout wheel. Compound that with the fact that the previous callout entry on the "wheel" is not on the wheel having cc_flags == 0.. thats really strange.. This is really bizarre. Let me think about this for a while.. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 18:44:28 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B8E71B0 for ; Tue, 17 Feb 2015 18:44:28 +0000 (UTC) Received: from MXMEG5.TechMahindra.com (mxmeg5.techmahindra.com [203.143.186.185]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.TechMahindra.com", Issuer "DigiCert High Assurance CA-3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9F523F50 for ; Tue, 17 Feb 2015 18:44:25 +0000 (UTC) Received: from NODEXCHMBX003.TechMahindra.com (unknown [10.13.0.156]) by MXMEG5.TechMahindra.com with smtp (TLS: TLSv1/SSLv3,256bits,AES256-SHA) id 6271_0704_3c1c1e70_2fcf_426c_b02b_627144d62785; Tue, 17 Feb 2015 23:59:51 +0530 Received: from NODEXCHMBX002.TechMahindra.com (10.13.0.154) by NODEXCHMBX003.TechMahindra.com (10.13.0.156) with Microsoft SMTP Server (TLS) id 15.0.847.32; Tue, 17 Feb 2015 23:59:07 +0530 Received: from NODEXCHMBX002.TechMahindra.com ([fe80::156c:ea25:3630:ed38]) by NODEXCHMBX002.TechMahindra.com ([fe80::156c:ea25:3630:ed38%14]) with mapi id 15.00.0847.030; Tue, 17 Feb 2015 23:59:07 +0530 From: Ashutosh Kumar To: "freebsd-net@freebsd.org" Subject: FreeBSD 10.1-RC4-p1 Thread-Topic: FreeBSD 10.1-RC4-p1 Thread-Index: AdBK35rDEPcN3vAKROGVA2c+3mMMCg== Date: Tue, 17 Feb 2015 18:29:06 +0000 Message-ID: <66f6827f57ed4c4184ba35036d1e9670@NODEXCHMBX002.TechMahindra.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-cr-puzzleid: {471E6F48-3CD4-488B-91C2-5B90E54468B3} x-cr-hashedpuzzle: AD0N AYri Akv1 AzHL BApk Bh6z C0SW DguR Dj8W EzOX FYHG FoAF HCnQ H/bP Jzo8 KuMf; 1; ZgByAGUAZQBiAHMAZAAtAG4AZQB0AEAAZgByAGUAZQBiAHMAZAAuAG8AcgBnAA==; Sosha1_v1; 7; {471E6F48-3CD4-488B-91C2-5B90E54468B3}; YQBrADAAMAAzADcANAA0ADcAQAB0AGUAYwBoAG0AYQBoAGkAbgBkAHIAYQAuAGMAbwBtAA==; Tue, 17 Feb 2015 18:29:02 GMT; RgByAGUAZQBCAFMARAAgADEAMAAuADEALQBSAEMANAAtAHAAMQA= x-originating-ip: [10.13.124.72] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 18:44:28 -0000 Hi, I hope this is correct mailing list to report an issue in network.subr. At line 764 in function ipv6_down() & file /etc/network.subr , shouldn't = the statement 'case $_inet in ' be 'case $_inet6 in'. Thanks Ashutosh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D Disclaimer: This message and the information contained herein is proprie= tary and confidential and subject to the Tech Mahindra policy statement, = you may review the policy at http://www.techmahindra.com/Disclaimer.html = externally http://tim.techmahindra.com/tim/disclaimer.html internally wit= hin TechMahindra.=0D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 18:49:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2DD062D4 for ; Tue, 17 Feb 2015 18:49:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DBEB8F89 for ; Tue, 17 Feb 2015 18:49:26 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HInQhj064826 for ; Tue, 17 Feb 2015 18:49:26 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HInQX2064825; Tue, 17 Feb 2015 18:49:26 GMT (envelope-from root) Date: Tue, 17 Feb 2015 18:49:26 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <27b97b9f73bfea74a7ca1020c345b736@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjjTY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 18:49:27 -0000 rrs added a comment. Hiren: You have the wrong structure type. In the printf before panic it is giving you the lock that was spinning.. that would be in the callout_cpu structure I bet.. I mis-told you in email. So if you did print *(struct callout_cpu *)0xffffffff81364180 It should show you our CPU structure .. and I believe the lock should be un-held owner = 4 Either that or 0xffffffff81364180 does not equal &cc_cpu[0] REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 19:36:44 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4FD854C8 for ; Tue, 17 Feb 2015 19:36:44 +0000 (UTC) Received: from MXMEG2.techmahindra.com (mxmeg2.techmahindra.com [119.151.17.92]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.TechMahindra.com", Issuer "DigiCert High Assurance CA-3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 10558875 for ; Tue, 17 Feb 2015 19:36:41 +0000 (UTC) Received: from NODEXCHMBX003.TechMahindra.com (unknown [10.13.0.156]) by MXMEG2.techmahindra.com with smtp (TLS: TLSv1/SSLv3,256bits,AES256-SHA) id 689f_0109_7db1acf5_e48c_4abd_848a_4c972c984a8c; Wed, 18 Feb 2015 00:59:48 +0530 Received: from NODEXCHMBX002.TechMahindra.com (10.13.0.154) by NODEXCHMBX003.TechMahindra.com (10.13.0.156) with Microsoft SMTP Server (TLS) id 15.0.847.32; Wed, 18 Feb 2015 01:06:34 +0530 Received: from NODEXCHMBX002.TechMahindra.com ([fe80::156c:ea25:3630:ed38]) by NODEXCHMBX002.TechMahindra.com ([fe80::156c:ea25:3630:ed38%14]) with mapi id 15.00.0847.030; Wed, 18 Feb 2015 01:06:33 +0530 From: Ashutosh Kumar To: "freebsd-net@freebsd.org" Subject: FreeBSD 10.1-RC4-p1 - issue in ipv6_down() in /etc/network.subr Thread-Topic: FreeBSD 10.1-RC4-p1 - issue in ipv6_down() in /etc/network.subr Thread-Index: AdBK35rDEPcN3vAKROGVA2c+3mMMCgACUO4w Date: Tue, 17 Feb 2015 19:36:33 +0000 Message-ID: References: <66f6827f57ed4c4184ba35036d1e9670@NODEXCHMBX002.TechMahindra.com> In-Reply-To: <66f6827f57ed4c4184ba35036d1e9670@NODEXCHMBX002.TechMahindra.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.13.124.72] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-NAIMIME-Disclaimer: 1 X-NAIMIME-Modified: 1 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 19:36:44 -0000 Just modified the subject for more relevance. Thanks, Ashutosh +91 9899653573 -----Original Message----- From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org= ] On Behalf Of Ashutosh Kumar Sent: Tuesday, February 17, 2015 11:59 PM To: freebsd-net@freebsd.org Subject: FreeBSD 10.1-RC4-p1 Hi, I hope this is correct mailing list to report an issue in network.subr. At line 764 in function ipv6_down() & file /etc/network.subr , shouldn't = the statement 'case $_inet in ' be 'case $_inet6 in'. Thanks Ashutosh _______________________________________________ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D Disclaimer: This message and the information contained herein is proprie= tary and confidential and subject to the Tech Mahindra policy statement, = you may review the policy at http://www.techmahindra.com/Disclaimer.html = externally http://tim.techmahindra.com/tim/disclaimer.html internally wit= hin TechMahindra.=0D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0D From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 20:03:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2A95FA9 for ; Tue, 17 Feb 2015 20:03:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 76A6FC26 for ; Tue, 17 Feb 2015 20:03:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HK3pqo043922 for ; Tue, 17 Feb 2015 20:03:51 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HK3pjd043921; Tue, 17 Feb 2015 20:03:51 GMT (envelope-from root) Date: Tue, 17 Feb 2015 20:03:51 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <25eb27dc94dd739a862629d5aff6d86f@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjnqc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 20:03:51 -0000 hiren added a comment. >>! In D1711#96, @rrs wrote: > Hiren: > > You have the wrong structure type. > > In the printf before panic it is giving you the lock that was spinning.. that > would be in the callout_cpu structure I bet.. I mis-told you in email. > > So if you did > > print *(struct callout_cpu *)0xffffffff81364180 > > It should show you our CPU structure .. and I believe the lock should be un-held owner = 4 > Either that or 0xffffffff81364180 does not equal > > &cc_cpu[0] bah , right. (kgdb) print *(struct callout_cpu *)0xffffffff81364180 $5 = {cc_lock = {lock_object = {lo_name = 0xffffffff80d03d28 "callout", lo_flags = 720896, lo_data = 0, lo_witness = 0x0}, mtx_lock = 4}, cc_exec_entity = {{ cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}, {cc_curr = 0x0, ce_migration_func = 0, ce_migration_arg = 0x0, ce_migration_cpu = 64, ce_migration_time = 0, ce_migration_prec = 0, cc_cancel = false, cc_waiting = false}}, cc_next = 0x0, cc_callout = 0xfffffe00006a4000, cc_callwheel = 0xfffffe00007c6000, cc_expireq = {tqh_first = 0x0, tqh_last = 0xffffffff81364288}, cc_callfree = {slh_first = 0xfffffe00007c5240}, cc_firstevent = 899380454888656, cc_lastscan = 899380454354416, cc_cookie = 0xfffff8000c34f100, cc_bucket = 31391, cc_ktr_event_name = "callwheel cpu 0\000\000\000\000"} REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 20:05:36 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 600B1ED for ; Tue, 17 Feb 2015 20:05:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1618FC42 for ; Tue, 17 Feb 2015 20:05:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HK5Zkh045267 for ; Tue, 17 Feb 2015 20:05:35 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HK5Zui045266; Tue, 17 Feb 2015 20:05:35 GMT (envelope-from root) Date: Tue, 17 Feb 2015 20:05:35 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <03a0edb3b8bd68541c132c9156c389a6@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjnw8= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 20:05:36 -0000 hselasky added a comment. randall: Let me try to explain a bit slower: Assume that a callout has been cancelled and is now migrating to another CPU. c->c_cpu = CPUBLOCK. Upon calling _callout_stop_safe() we will enter the callout_lock() function which will wait for the condition "c->c_cpu == CPUBLOCK" to disappear. Thread 1: mtx_lock(xxx); _callout_stop_safe(struct callout *c, int safe) callout_lock(); while(c->c_cpu == CPUBLOCK) ; mtx_unlock(xxx); Thread 2: softclock_call_cc() if (c_lock != NULL) class->lc_lock(xxx); /* stuck forever */ In softclock_call_cc() c->c_cpu is only updated _after_ that class->lc_lock() has been locked / unlocked. Especially this is critical if the callback function locks and unlocks the "xxx" lock multiple times. Do you get it? Or do you want me to explain more. Sorry I am not so good communicating with you. --HPS REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 20:24:55 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1395682F for ; Tue, 17 Feb 2015 20:24:55 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45B90E50 for ; Tue, 17 Feb 2015 20:24:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HKOsxX073406 for ; Tue, 17 Feb 2015 20:24:54 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HKOsce073402; Tue, 17 Feb 2015 20:24:54 GMT (envelope-from root) Date: Tue, 17 Feb 2015 20:24:54 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <83057c35f7cae6e0411aaa2e4f1370aa@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjo5Y= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 20:24:55 -0000 rrs added a comment. Hans: Let me explain to you how I think you are wrong, you are missing a small subtle thing here.... When we do the callout_stop we set cc_migration_cpu() = CPUBLOCK *NOT* c->c_cpu = CPUBLOCK; You are confusing the two things. The CPUBLOCK is used in two different places. The loop in callout_lock() is looking for c->c_cpu != CPUBLOCK This only gets set when callout_cpu_switch() is called *not* when callout_reset or callout_stop is called. So I think you have the wrong fish in the net. What Hiren is seeing is something completely different. What is strange is the cc_cpu[] structures he dumped has *no* locks present.. Look back above and see the cc_lock structures of the cc_cpu's.. all of the owners are 4.. i.e. MTX_UNLOCKED. So how in the world are we getting a "thread holds spin lock too long". Worse the callout that was being "inserted" is ACTIVE and PENDING, which means it should be on the wheel, but it is *not* on the wheel .. at least not that I can see... since Hiren has traced back on that callout and the previous one on the list (which points to it) has a c_flags of 0.. This is very very odd. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 21:11:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C3681BB0 for ; Tue, 17 Feb 2015 21:11:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 979563D6 for ; Tue, 17 Feb 2015 21:11:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HLBWFX042376 for ; Tue, 17 Feb 2015 21:11:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HLBWaL042375; Tue, 17 Feb 2015 21:11:32 GMT (envelope-from root) Date: Tue, 17 Feb 2015 21:11:32 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjroQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 21:11:32 -0000 hselasky added a comment. randall: You are right I confused the two c_cpu values. Let my try to shoot again: static struct callout_cpu * callout_cpu_switch(struct callout *c, struct callout_cpu *cc, int new_cpu) { struct callout_cpu *new_cc; MPASS(c != NULL && cc != NULL); CC_LOCK_ASSERT(cc); /* * Avoid interrupts and preemption firing after the callout cpu * is blocked in order to avoid deadlocks as the new thread * may be willing to acquire the callout cpu lock. */ c->c_cpu = CPUBLOCK; spinlock_enter(); CC_UNLOCK(cc); new_cc = CC_CPU(new_cpu); CC_LOCK(new_cc); spinlock_exit(); c->c_cpu = new_cpu; return (new_cc); } spinlock_enter() is not an SMP lock. It only protects the executing CPU from interrupts and task switching. Basically that means two threads can be stuck at: new_cc = CC_CPU(new_cpu), meaning a single callout can be switched to multiple different CPU's at the same time? Or am I wrong? --HPS REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 21:26:17 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE459267 for ; Tue, 17 Feb 2015 21:26:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8254C76D for ; Tue, 17 Feb 2015 21:26:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HLQHit057021 for ; Tue, 17 Feb 2015 21:26:17 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HLQHQf057020; Tue, 17 Feb 2015 21:26:17 GMT (envelope-from root) Date: Tue, 17 Feb 2015 21:26:17 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <6a7bdec57d66259006badc37482dd8f7@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTjsfk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 21:26:17 -0000 rrs added a comment. Hans: I think your wrong here. The caller of callout_cpu_switch() is holding the CC_LOCK(). Now there are only two callers of this function. Either the actual callout code itself (softclock_call_cc()) or the callout_reset_sbt_on(). In the case of callout_reset_sbt_on(). So lets look at these two cases Case 1: soft clock_call_cc() - In this case the callout is finished and is being migrated to a different CPU. This would have happened only because we had the case of doing a callout_reset_sbt_on() and finding the callout executing on the wheel *is* the callout running now and we can't do the migration, so the CPU is set and the PENDING/MIGRATION/ACTVIE flags are also present. The callout lock is held from the perspective of the original CPU, and the code goes through and releases the lock only after setting in the c_lock = CPUBLOCK which will prevent any other running callout_reset_sbt_on() from moving forward, they will be stuck waiting for the c_lock to clear to a CPU number. When the migration is complete the function restores the cpu and the other guy can proceed. It may be moving to yet another CPU, that would be fine too since it now has the lock on the new CPU and moves forward out of callout_reset_sbt_on() 2) callout_reset_sbt_on() - here again we have the current CPU callout lock, and we will only do the switch if the callout is not the current guy executing, if it is we set the flags so <1> above occurs. If its not we move it.. again we set the CPUBLOCK on the callout so no there callout_reset_sbt_on() can get in until after we move it. So there is no way we can have two guys moving at the same time. The CPUBLOCK on the c->c_cpu is used to serialize the two guys. This of course is all noise, since it is *not* related in any shape or form to what Hiren is seeing. If it was you would have seen the panic not at line 530 but above that.. So the question is what is happening.. I am still contemplating it.. and hopefully I can figure out a way to recreate it.. without a vmcore/kernel.debug its pretty hard to decipher these things.. Hiren has been a wonderful help but I am afraid I am about out of question to ask for now.. Its very very strange. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 23:28:34 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B6168984 for ; Tue, 17 Feb 2015 23:28:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8D7646D6 for ; Tue, 17 Feb 2015 23:28:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HNSYkO082914 for ; Tue, 17 Feb 2015 23:28:34 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HNSYgf082913; Tue, 17 Feb 2015 23:28:34 GMT (envelope-from root) Date: Tue, 17 Feb 2015 23:28:34 +0000 To: freebsd-net@freebsd.org From: "wblock (Warren Block)" Subject: [Differential] [Changed Subscribers] D1438: FreeBSD callout rewrite and cleanup Message-ID: <55424bb6afde62db71124c0bd96403f3@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTjzqI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 23:28:34 -0000 wblock added a subscriber: wblock. wblock added a comment. This is as much as I have time for at the moment. I'll add doc to the reviewers list INLINE COMMENTS share/man/man9/timeout.9:73 That is kind of a difficult sentence to parse. Does this retain the meaning? API is used to schedule a one-time call to an arbitrary function at a specific future time. share/man/man9/timeout.9:76 The original is an "aside": Consumers of this API are required to allocate a callout structure (struct callout) for each pending function invocation. The parentheses are probably the wrong markup for the new form, and "struct callout structure" is redundant. Maybe this: Consumers of this API are required to allocate a .Ft struct callout for each pending function invocation. share/man/man9/timeout.9:79 As above, use .Ft and the word "structure" is redundant. share/man/man9/timeout.9:80 "should be" is a recommendation. Does it mean I ought to call those functions before freeing, but will work fine without it? Otherwise, consider "must be drained by a call to". share/man/man9/timeout.9:85 The rule is to use American English spellings unless the entire document was written with British spellings. See https://www.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-guidelines.html share/man/man9/timeout.9:88 It would be better to say .Pq Deprecated, see blahblah for current usage. This function is used to prepare a share/man/man9/timeout.9:90 Use .Ft and remove the redundant word "structure". share/man/man9/timeout.9:94 "Was" is a little odd here, but "were" is not quite right either. How about: function will return as if no timeout was pending. share/man/man9/timeout.9:97 Again, better to say the function is deprecated and give a pointer to the replacement in a separate sentence. Then explain what this one does in the next sentence. share/man/man9/timeout.9:101 .Ft and s/structure// share/man/man9/timeout.9:107 .Ft and s/structure// share/man/man9/timeout.9:114 Possessive: application's share/man/man9/timeout.9:116 Comma: functions, including the share/man/man9/timeout.9:121 s/Else/Otherwise,/ share/man/man9/timeout.9:122 Avoid simultaneous access by obtaining an exclusive lock share/man/man9/timeout.9:132 Split this long sentence: function is called. It is also expected, but currently not share/man/man9/timeout.9:135 This last part needs to be split out into a separate sentence, starting with ", except when the". share/man/man9/timeout.9:144 .Ft and s/structure// share/man/man9/timeout.9:149 Passive "should be" and should, and "specify a pointer"... How about: argument is a non-zero pointer to a valid share/man/man9/timeout.9:153 The specified mutex is expected to be locked when calling any share/man/man9/timeout.9:155 functions other than the share/man/man9/timeout.9:159 functions. share/man/man9/timeout.9:165 The callout function is assumed to have released the specified share/man/man9/timeout.9:167 s/Else/Otherwise,/ share/man/man9/timeout.9:173 This function is similar to the share/man/man9/timeout.9:175 function, but accepts a read-mostly type of lock. share/man/man9/timeout.9:176 s/initialised/initialized/ share/man/man9/timeout.9:182 This function is similar to the share/man/man9/timeout.9:184 function, but accepts a reader-writer type of lock. Should that be "read/write" instead? share/man/man9/timeout.9:188 As above, separate sentence to say it is deprecated and point to the replacement. share/man/man9/timeout.9:199 argument is a valid pointer to a function that takes a single share/man/man9/timeout.9:223 "canceled" is spelled "cancelled" elsewhere in this man page. The first is modern American. share/man/man9/timeout.9:243 s/Else/Otherwise,/ share/man/man9/timeout.9:246 s/called/called,/ share/man/man9/timeout.9:249 s/words/words,/ share/man/man9/timeout.9:250 s/Else/Otherwise,/ share/man/man9/timeout.9:273 s/Else/Otherwise,/ share/man/man9/timeout.9:295 s/Else/Otherwise,/ share/man/man9/timeout.9:309 .Fa pr argument. is redundant, and can be just .Fa pr . (There are lots of these.) share/man/man9/timeout.9:310 Avoid the informal use of "you": This function is used when high precision timeouts are needed. share/man/man9/timeout.9:313 Again, redundant. Can be just If .Fa sbt specifies... share/man/man9/timeout.9:324 "the" is not needed here. share/man/man9/timeout.9:334 Again, can just be By default, .Fa sbt is treated... Also, "is treated *as*". share/man/man9/timeout.9:346 Needs a serial comma before "and": ...1/4, and so on. share/man/man9/timeout.9:362 This function works like share/man/man9/timeout.9:363 .Fn callout_reset_sbt , share/man/man9/timeout.9:364 except the callback function given by share/man/man9/timeout.9:366 will be executed on the CPU which called this function. share/man/man9/timeout.9:375 Otherwise, the callback function given by share/man/man9/timeout.9:377 will be executed on the same CPU... The rest of that line is unclear. As shown previously in the man page? As run previously on the CPU? share/man/man9/timeout.9:382 This function works like .Fn callout_reset_sbt , except the callback function given by .Fa func will be executed on the CPU given by .Fa cpu . share/man/man9/timeout.9:392 Refer to .Fa callout_init . REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Tue Feb 17 23:28:58 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 40F8CB41 for ; Tue, 17 Feb 2015 23:28:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1263F757 for ; Tue, 17 Feb 2015 23:28:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1HNSvfm083541 for ; Tue, 17 Feb 2015 23:28:57 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1HNSvLS083540; Tue, 17 Feb 2015 23:28:57 GMT (envelope-from root) Date: Tue, 17 Feb 2015 23:28:57 +0000 To: freebsd-net@freebsd.org From: "wblock (Warren Block)" Subject: [Differential] [Updated] D1438: FreeBSD callout rewrite and cleanup Message-ID: X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTjzrk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Feb 2015 23:28:58 -0000 wblock added a reviewer: doc. REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 03:47:50 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9217FF for ; Wed, 18 Feb 2015 03:47:50 +0000 (UTC) Received: from st11p02mm-asmtp002.mac.com (st11p02mm-asmtp002.mac.com [17.172.220.237]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B762240 for ; Wed, 18 Feb 2015 03:47:49 +0000 (UTC) Received: from fukuyama.hsd1.ca.comcast.net (unknown [73.162.13.215]) by st11p02mm-asmtp002.mac.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Dec 4 2014)) with ESMTPSA id <0NJY00BMM7UCX700@st11p02mm-asmtp002.mac.com> for freebsd-net@freebsd.org; Wed, 18 Feb 2015 03:47:02 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68,1.0.33,0.0.0000 definitions=2015-02-18_02:2015-02-17,2015-02-18,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1412110000 definitions=main-1502180040 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Subject: Re: FreeBSD 10.1-RC4-p1 From: Rui Paulo In-reply-to: <66f6827f57ed4c4184ba35036d1e9670@NODEXCHMBX002.TechMahindra.com> Date: Tue, 17 Feb 2015 19:47:00 -0800 Content-transfer-encoding: quoted-printable Message-id: <02A54BA0-048E-4F58-BCC9-20A88379857E@me.com> References: <66f6827f57ed4c4184ba35036d1e9670@NODEXCHMBX002.TechMahindra.com> To: Ashutosh Kumar X-Mailer: Apple Mail (2.2070.6) Cc: "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 03:47:50 -0000 On Feb 17, 2015, at 10:29, Ashutosh Kumar = wrote: > At line 764 in function ipv6_down() & file /etc/network.subr , = shouldn't the statement 'case $_inet in ' be 'case $_inet6 in'. You are correct. I just fixed this. Thanks! -- Rui Paulo From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 08:50:27 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6E64384C for ; Wed, 18 Feb 2015 08:50:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 291E9658 for ; Wed, 18 Feb 2015 08:50:27 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1I8oQiw034764 for ; Wed, 18 Feb 2015 08:50:26 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1I8oQ7A034763; Wed, 18 Feb 2015 08:50:26 GMT (envelope-from root) Date: Wed, 18 Feb 2015 08:50:26 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTkUlI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 08:50:27 -0000 hselasky added a comment. Randall: Shooting again: Thread 1 is executing in "softclock_call_cc()" in the "new_cc = callout_cpu_switch(c, cc, new_cpu)" it has set "c->c_cpu = CPUBLOCK;" Thread 2 is now executing callout_reset(). As you can see in the implementation detail, it is reading "c_cpu" without CC_LOCK() locked and without checking if it was reading the c_cpu while it was equal to CPUBLOCK ! #define callout_reset(c, on_tick, fn, arg) \ callout_reset_on((c), (on_tick), (fn), (arg), (c)->c_cpu) This results in migrating the callout to CPUBLOCK, and subsequent calls will hang in callout_lock() like in hirens panic. --HPS REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 10:11:47 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A56ED8D4 for ; Wed, 18 Feb 2015 10:11:47 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 629C2F1B for ; Wed, 18 Feb 2015 10:11:47 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IABlO0021060 for ; Wed, 18 Feb 2015 10:11:47 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IABlLN021059; Wed, 18 Feb 2015 10:11:47 GMT (envelope-from root) Date: Wed, 18 Feb 2015 10:11:47 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 4 lines] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets Message-ID: <52e0dc3366fa4a29f6b12dddb22ec8c4@localhost.localdomain> X-Priority: 3 Thread-Topic: D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTM5NTRkZmFhY2M5ZGMyZjg3NmZhODJjMjFlIFTkZWM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 10:11:47 -0000 hselasky added reviewers: network, glebius. hselasky added a subscriber: freebsd-net. hselasky set the repository for this revision to rS (FreeBSD src repository). hselasky updated this revision to Diff 3838. hselasky added a comment. Add full context. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1893?vs=3837&id=3838 REVISION DETAIL https://reviews.freebsd.org/D1893 AFFECTED FILES sys/netinet/ip_output.c To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 10:14:21 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 23F349CC for ; Wed, 18 Feb 2015 10:14:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EF41DF58 for ; Wed, 18 Feb 2015 10:14:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IAEKMr023078 for ; Wed, 18 Feb 2015 10:14:20 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IAEKV2023077; Wed, 18 Feb 2015 10:14:20 GMT (envelope-from root) Date: Wed, 18 Feb 2015 10:14:20 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 4 lines] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets Message-ID: X-Priority: 3 Thread-Topic: D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTM5NTRkZmFhY2M5ZGMyZjg3NmZhODJjMjFlIFTkZfw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 10:14:21 -0000 hselasky updated this revision to Diff 3839. hselasky added a comment. Use MIN() macro. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1893?vs=3838&id=3839 REVISION DETAIL https://reviews.freebsd.org/D1893 AFFECTED FILES sys/netinet/ip_output.c To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 11:38:00 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EF4D1725 for ; Wed, 18 Feb 2015 11:37:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5E2BA60 for ; Wed, 18 Feb 2015 11:37:59 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IBbxbl008536 for ; Wed, 18 Feb 2015 11:37:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IBbxcR008535; Wed, 18 Feb 2015 11:37:59 GMT (envelope-from root) Date: Wed, 18 Feb 2015 11:37:59 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <953272367a10765054ccf4e0b5d231ba@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTkeZc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 11:38:00 -0000 rrs added a comment. I have thought long and hard about this. I don't think its a bug. But to know for sure I will need to add some instrumentation. I suspect what is happening is a tremendous number of callouts all come due at the same time. The three back traces trying to stop or reset a callout are just unlucky in they don't get the lock as the callout code works through doing its loops of CC_LOCK(cc) while there is more on the list prepare callout CC_UNLOCK(cc) call_callout_function CC_LOCK(cc) done CC_UNLOCK(cc) The spin-mtx has (from what I can see) no awareness of the fact that you might have lost several bids to get the lock. It just crashes if it spins for too long and cannot get the lock. The previous problem is fixed, which I could reproduce, where the callout temp-list was corrupt and pointing to itself.. thus the soft clock looped forever... Hiren/Sbruno: Let me make a special patch that includes some counts in the cpu_cc structure that we can find out 1) For both callout loops how many the last call had 2) For both callout loops what was the max ever seen This will give us a hint if I am correct. I have also asked jhb on his thoughts for this in email. R REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 12:02:33 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DA3C8EBA for ; Wed, 18 Feb 2015 12:02:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9527BDD7 for ; Wed, 18 Feb 2015 12:02:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IC2XIe035528 for ; Wed, 18 Feb 2015 12:02:33 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IC2X6W035527; Wed, 18 Feb 2015 12:02:33 GMT (envelope-from root) Date: Wed, 18 Feb 2015 12:02:33 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 2, 449 lines] D1438: FreeBSD callout rewrite and cleanup Message-ID: <3903d6279ddcf40a6b7887da8c2a4de3@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTkf1k= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 12:02:33 -0000 hselasky updated this revision to Diff 3840. hselasky added a comment. Integrate manual page comments from Warren Block. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3809&id=3840 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/man/man9/timeout.9 sys/kern/init_main.c sys/kern/kern_condvar.c sys/kern/kern_lock.c sys/kern/kern_switch.c sys/kern/kern_synch.c sys/kern/kern_thread.c sys/kern/kern_timeout.c sys/kern/subr_sleepqueue.c sys/ofed/include/linux/completion.h sys/sys/_callout.h sys/sys/callout.h sys/sys/proc.h To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 12:05:23 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BFCA8F88 for ; Wed, 18 Feb 2015 12:05:23 +0000 (UTC) Received: from mail.bsdinfo.com.br (mail.bsdinfo.com.br [67.212.89.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7EFE3DFE for ; Wed, 18 Feb 2015 12:05:23 +0000 (UTC) Received: from mail.bsdinfo.com.br (mail.bsdinfo.com.br [127.0.0.1]) by mail.bsdinfo.com.br (Postfix) with ESMTP id 29E53139EC for ; Wed, 18 Feb 2015 09:57:43 -0200 (BRST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bsdinfo.com.br; h=content-transfer-encoding:content-type:content-type :in-reply-to:references:subject:subject:to:mime-version :user-agent:from:from:date:date:message-id; s=dkim; t= 1424260655; x=1425124656; bh=KVNcaeUQlX83Ofgc76yfSy3e4awsfsCEvVY 1UuIFdaw=; b=A3rkIXrBYL54u1PcWwE27MeczqBe0iDnHZ5Qz0FoE5lf7FhefoN nrL5cQ7DlLYSLcY56gU2vJHHxTucZ0iXyEw/vUdSLMkYnAy5JLFfFQa1dFmNExpk hgogGax9pMvZm8zpWSpqewJsyC3VFsBe3dcyPRmCNimYkXfBUVQFXCK0= X-Virus-Scanned: amavisd-new at mail.bsdinfo.com.br Received: from mail.bsdinfo.com.br ([127.0.0.1]) by mail.bsdinfo.com.br (mail.bsdinfo.com.br [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cRLZValnmncT for ; Wed, 18 Feb 2015 09:57:35 -0200 (BRST) Received: from [192.168.10.208] (unknown [186.193.54.69]) by mail.bsdinfo.com.br (Postfix) with ESMTPSA id 8BAA7139CA; Wed, 18 Feb 2015 09:57:34 -0200 (BRST) Message-ID: <54E47E1D.1030201@bsdinfo.com.br> Date: Wed, 18 Feb 2015 09:57:17 -0200 From: Marcelo Gondim User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Pieper, Jeffrey E" , "freebsd-net@freebsd.org" Subject: Re: Problems with Intel X520-SR2 [RESOLVED] References: <547B3BFB.5000503@bsdinfo.com.br> <547B4033.1060504@FreeBSD.org> <547BB862.6080801@bsdinfo.com.br> <547CC35A.1080108@bsdinfo.com.br> <2A35EA60C3C77D438915767F458D65687E987C2A@ORSMSX111.amr.corp.intel.com> In-Reply-To: <2A35EA60C3C77D438915767F458D65687E987C2A@ORSMSX111.amr.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 12:05:23 -0000 Hi All, Problem resolved with: FreeBSD rt01.xxx.xxx.xxx 10.1-STABLE FreeBSD 10.1-STABLE #3 r276979: Wed Jan 21 14:04:54 BRST 2015 root@rt01.xxx.xxx.xxx:/usr/obj/usr/src/sys/GONDIM amd64 No more errors and stops. On 01/12/2014 19:29, Pieper, Jeffrey E wrote: > Hi Marcelo, > > A couple of questions - you are using 1310nm fiber on ix0, correct? The difference seems to be that ix0 is LR and ix1 is SR. Also, is there a reason that the interrupt rate is set higher for ix0? > > dev.ix.0.queue0.interrupt_rate: 50000 > dev.ix.1.queue0.interrupt_rate: 11627 > > Jeff > > -----Original Message----- > From: owner-freebsd-net@freebsd.org [mailto:owner-freebsd-net@freebsd.org] On Behalf Of Marcelo Gondim > Sent: Monday, December 01, 2014 11:37 AM > To: freebsd-net@freebsd.org > Subject: Re: Problems with Intel X520-SR2 > > On 30/11/2014 22:37, Marcelo Gondim wrote: >> Hi Jack, >> >> On 30/11/2014 16:20, Jack Vogel wrote: >>> Good suggestions, do you ever see any 'interrupt throttled' messages? >>> You >>> might >>> want to change the storm threshold to 0 and disable it. >> I can try this: >> >> sysctl hw.intr_storm_threshold=0 > Hi Jack, > > Same problem with hw.intr_storm_threshold=0 > I still think it might be something in my traffic that the driver is not > dealing properly. > > # netstat -idn > . > . > . > ix0 1500 00:1b:21:89:25:32 18446739080975184057 268 > 5876340155018 18446742570019979938 0 0 0 > ix0 - fe80::21b:21f fe80::21b:21ff:fe 0 - - > 1 - - - > ix1 1500 00:1b:21:89:25:33 18446730999135967066 0 > 13653533351669 18446742457148273271 0 0 0 > ix1 - fe80::21b:21f fe80::21b:21ff:fe 0 - - > 0 - - - > . > . > . > > Are 5876340155018 dropped packets in ix0 and 13653533351669 dropped > packets in ix1 > > # w -n > 5:35PM up 15 days, 20:29, 2 users, load averages: 8.96, 9.03, 8.84 > USER TTY FROM LOGIN@ IDLE WHAT > gondim pts/1 186.xxx.48.8 5:22PM - w -n > > >>> I too would like to know if there are any messages when the 'hang' >>> happens. >> Nope. No message. :( >> >>> I don't know much about lagg, is it responsible for link events?? Its >>> not a >>> normal >>> situation to be having so many :( >>> >>> Jack >>> >>> >>> On Sun, Nov 30, 2014 at 10:01 AM, Adrian Chadd >>> wrote: >>> >>>> Your link_irq value is way too high. I think you're exposing some >>>> unhandled corner case in the driver (as I had this issue when I had >>>> some badly cabled up ixgbe NICs) but it doesn't happen when the ixgbe >>>> driver isn't getting link events. >>>> >>>> My test setup at home has link_irq=1 on both sides, and it runs >>>> full-duplex 10GE (1 mil pps transmit/receive on each NIC) traffic for >>>> RSS testing for weeks at a time. I have no issues and no hiccups. >>>> So, I think there's two problems: >>>> >>>> * you're still seeing way too many link_irq events; and >>>> * i think there's some bad handling when it comes to link_irq events. >>>> >>>> I wonder if we're still clearing some of the interrupt register bits >>>> incorrectly in ixgbe_msix_link(). >>>> >>>> >>>> -adrian >>>> >>>> >>>> >>>> >>>> -adrian >>>> >>>> >>>> On 30 November 2014 at 08:05, Alexander V. Chernikov >>>> wrote: >>>>> On 30.11.2014 18:47, Marcelo Gondim wrote: >>>>>> Dear, >>>>>> >>>>>> Unfortunately I have more options to resolve this problem I'm having >>>> with >>>>>> Intel X520-SR2. Have we changed the X520, we exchange the optical >>>>>> cords, >>>>>> exchanged optical modules, we changed the entire server, we reduce >>>>>> the >>>>>> temperature inside the equipment, made some attempts to tunning >>>>>> the site >>>>>> calomel[1]. We spend a lot of money and do not solve the problem. >>>>>> >>>>>> What happens is that when there is a traffic above 1.2Gbps with PPS >>>> above >>>>>> 700kpps in sometimes almost daily there is a lock in two 10GbE >>>>>> ports the >>>>>> X520-SR interface. Where I am obliged to leave a script running in >>>>>> the >>>>>> background doing just that: >>>>> What does this "lock" looks like? >>>>> Do you using jumbo frames? >>>>> Is this IPv4 or IPv4+IPv6 ? >>>>> Can you share "netstat -m" output? >>>>> Do you use ipfw dynamic states? >>>>> Are sure you're not hitting "net.inet.ip.fw.dyn_max=65536" ? >>>>> >>>>> dev.ix.0.queue0.no_desc_avail: 3322269 >>>>> dev.ix.0.queue1.no_desc_avail: 5254761 >>>>> >>>>> Looks suspicious. Either you're running out of mbufs due to total mbuf >>>>> number is small, or system is very busy sometimes. >>>>> What does you "top -HPSzs1" output look like? >>>>> >>>>> >>>>>> ifconfig ix0 down; ifconfig ix0 up; ifconfig ix1 down; ifconfig >>>>>> ix1 up >>>>>> >>>>>> Made it back to the interface function normally. It's already so for >>>>>> months and have not tried the latest driver from Intel because I >>>>>> do not >>>> see >>>>>> anything related to this issue. >>>>>> >>>>>> These 2-port 10GbE are my backbone linking the four cities that >>>>>> attend >>>> to >>>>>> our main router. One is backup to other but when the problem occurs, >>>> the two >>>>>> ports stop working and at the moment I have a break in my Internet >>>>>> >>>>>> I can only conclude that the problem is one of the things below: >>>>>> >>>>>> 1 - Intel Interface X520-SR2 has a problem with certain types of >>>>>> traffic >>>>>> and then hangs. >>>>>> 2 - The ixgbe driver has a bug that is causing it. >>>>>> 3 - Problem with FreeBSD 10.x. Not tested with FreeBSD 9.3 because it >>>>>> would be a regression and the equipment is very far away from me if I >>>> need >>>>>> to move me. >>>>>> >>>>>> Honestly I'm almost going on a Juniper closed solution. I would >>>>>> not want >>>>>> to do this because I love FreeBSD and I can not believe that he >>>>>> does not >>>>>> support a 2.7Gbps traffic, which is my peak traffic without getting >>>> having >>>>>> these falls. My hardware today is this: >>>>>> >>>>>> hw.machine: amd64 >>>>>> hw.model: Intel(R) Xeon(R) CPU E5-2630 v2 @ 2.60GHz >>>>>> hw.ncpu: 12 >>>>>> hw.byteorder: 1234 >>>>>> hw.physmem: 17083641856 >>>>>> hw.usermem: 15741001728 >>>>>> >>>>>> Hardware all Intel with motherboard S2600COE [2] and with network >>>>>> interfaces offboard: >>>>>> >>>>>> 1x - X520-SR2 [3] >>>>>> 2x - I350-T2 [4] >>>>>> >>>>>> My loader.conf: >>>>>> >>>>>> loader_logo="beastie" >>>>>> if_lagg_load="YES" >>>>>> speaker_load="YES" >>>>>> aio_load="YES" >>>>>> autoboot_delay="5" >>>>>> net.fibs=1 >>>>>> >>>>>> My sysctl.conf: >>>>>> >>>>>> net.inet.ip.forwarding=1 >>>>>> net.inet.ip.fastforwarding=1 >>>>>> net.inet6.ip6.forwarding=1 >>>>>> kern.ipc.somaxconn=4096 >>>>>> net.inet.tcp.syncookies=1 >>>>>> net.inet.ip.redirect=1 >>>>>> net.inet.ip.accept_sourceroute=0 >>>>>> net.inet.ip.sourceroute=0 >>>>>> net.inet.tcp.drop_synfin=1 >>>>>> net.inet.udp.blackhole=1 >>>>>> net.inet.tcp.blackhole=2 >>>>>> security.bsd.see_other_uids=0 >>>>>> net.inet.ip.fw.dyn_buckets=65536 >>>>>> net.inet.ip.fw.dyn_max=65536 >>>>>> hw.intr_storm_threshold=9000 >>>>>> net.inet.ip.dummynet.pipe_slot_limit=800 >>>>>> net.inet.icmp.icmplim=2000 >>>>>> >>>>>> # sysctl dev.ix. >>>>>> dev.ix.%parent: >>>>>> dev.ix.0.%desc: Intel(R) PRO/10GbE PCI-Express Network Driver, >>>>>> Version - >>>>>> 2.5.15 >>>>>> dev.ix.0.%driver: ix >>>>>> dev.ix.0.%location: slot=0 function=0 handle=\_SB_.PCI1.BR42.S4F0 >>>>>> dev.ix.0.%pnpinfo: vendor=0x8086 device=0x10fb subvendor=0x8086 >>>>>> subdevice=0x7a11 class=0x020000 >>>>>> dev.ix.0.%parent: pci129 >>>>>> dev.ix.0.fc: 3 >>>>>> dev.ix.0.enable_aim: 1 >>>>>> dev.ix.0.advertise_speed: 0 >>>>>> dev.ix.0.dropped: 0 >>>>>> dev.ix.0.mbuf_defrag_failed: 0 >>>>>> dev.ix.0.watchdog_events: 0 >>>>>> dev.ix.0.link_irq: 193783 >>>>>> dev.ix.0.queue0.interrupt_rate: 50000 >>>>>> dev.ix.0.queue0.irqs: 12029604413 >>>>>> dev.ix.0.queue0.txd_head: 1517 >>>>>> dev.ix.0.queue0.txd_tail: 1517 >>>>>> dev.ix.0.queue0.tso_tx: 85 >>>>>> dev.ix.0.queue0.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue0.no_desc_avail: 3322269 >>>>>> dev.ix.0.queue0.tx_packets: 15392658033 >>>>>> dev.ix.0.queue0.rxd_head: 709 >>>>>> dev.ix.0.queue0.rxd_tail: 707 >>>>>> dev.ix.0.queue0.rx_packets: 21762427837 >>>>>> dev.ix.0.queue0.rx_bytes: 56918345381 >>>>>> dev.ix.0.queue0.rx_copies: 124289013 >>>>>> dev.ix.0.queue0.lro_queued: 0 >>>>>> dev.ix.0.queue0.lro_flushed: 0 >>>>>> dev.ix.0.queue1.interrupt_rate: 500000 >>>>>> dev.ix.0.queue1.irqs: 11482146431 >>>>>> dev.ix.0.queue1.txd_head: 731 >>>>>> dev.ix.0.queue1.txd_tail: 731 >>>>>> dev.ix.0.queue1.tso_tx: 1442 >>>>>> dev.ix.0.queue1.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue1.no_desc_avail: 5254761 >>>>>> dev.ix.0.queue1.tx_packets: 15835062632 >>>>>> dev.ix.0.queue1.rxd_head: 685 >>>>>> dev.ix.0.queue1.rxd_tail: 681 >>>>>> dev.ix.0.queue1.rx_packets: 21220715209 >>>>>> dev.ix.0.queue1.rx_bytes: 54351679461 >>>>>> dev.ix.0.queue1.rx_copies: 120833356 >>>>>> dev.ix.0.queue1.lro_queued: 0 >>>>>> dev.ix.0.queue1.lro_flushed: 0 >>>>>> dev.ix.0.queue2.interrupt_rate: 5319 >>>>>> dev.ix.0.queue2.irqs: 11532560324 >>>>>> dev.ix.0.queue2.txd_head: 501 >>>>>> dev.ix.0.queue2.txd_tail: 501 >>>>>> dev.ix.0.queue2.tso_tx: 2474 >>>>>> dev.ix.0.queue2.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue2.no_desc_avail: 429244 >>>>>> dev.ix.0.queue2.tx_packets: 15772209238 >>>>>> dev.ix.0.queue2.rxd_head: 246 >>>>>> dev.ix.0.queue2.rxd_tail: 244 >>>>>> dev.ix.0.queue2.rx_packets: 21408648299 >>>>>> dev.ix.0.queue2.rx_bytes: 56862350194 >>>>>> dev.ix.0.queue2.rx_copies: 124973551 >>>>>> dev.ix.0.queue2.lro_queued: 0 >>>>>> dev.ix.0.queue2.lro_flushed: 0 >>>>>> dev.ix.0.queue3.interrupt_rate: 20833 >>>>>> dev.ix.0.queue3.irqs: 11557466322 >>>>>> dev.ix.0.queue3.txd_head: 773 >>>>>> dev.ix.0.queue3.txd_tail: 773 >>>>>> dev.ix.0.queue3.tso_tx: 40 >>>>>> dev.ix.0.queue3.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue3.no_desc_avail: 665620 >>>>>> dev.ix.0.queue3.tx_packets: 16479111658 >>>>>> dev.ix.0.queue3.rxd_head: 1858 >>>>>> dev.ix.0.queue3.rxd_tail: 1854 >>>>>> dev.ix.0.queue3.rx_packets: 21412821769 >>>>>> dev.ix.0.queue3.rx_bytes: 52796089467 >>>>>> dev.ix.0.queue3.rx_copies: 127385950 >>>>>> dev.ix.0.queue3.lro_queued: 0 >>>>>> dev.ix.0.queue3.lro_flushed: 0 >>>>>> dev.ix.0.queue4.interrupt_rate: 11363 >>>>>> dev.ix.0.queue4.irqs: 10824852635 >>>>>> dev.ix.0.queue4.txd_head: 1711 >>>>>> dev.ix.0.queue4.txd_tail: 1713 >>>>>> dev.ix.0.queue4.tso_tx: 581 >>>>>> dev.ix.0.queue4.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue4.no_desc_avail: 115346803 >>>>>> dev.ix.0.queue4.tx_packets: 16100396810 >>>>>> dev.ix.0.queue4.rxd_head: 244 >>>>>> dev.ix.0.queue4.rxd_tail: 243 >>>>>> dev.ix.0.queue4.rx_packets: 21240995210 >>>>>> dev.ix.0.queue4.rx_bytes: 58726730771 >>>>>> dev.ix.0.queue4.rx_copies: 124872141 >>>>>> dev.ix.0.queue4.lro_queued: 0 >>>>>> dev.ix.0.queue4.lro_flushed: 0 >>>>>> dev.ix.0.queue5.interrupt_rate: 500000 >>>>>> dev.ix.0.queue5.irqs: 10955464761 >>>>>> dev.ix.0.queue5.txd_head: 75 >>>>>> dev.ix.0.queue5.txd_tail: 77 >>>>>> dev.ix.0.queue5.tso_tx: 1758 >>>>>> dev.ix.0.queue5.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue5.no_desc_avail: 4759 >>>>>> dev.ix.0.queue5.tx_packets: 16267888038 >>>>>> dev.ix.0.queue5.rxd_head: 905 >>>>>> dev.ix.0.queue5.rxd_tail: 904 >>>>>> dev.ix.0.queue5.rx_packets: 21381144028 >>>>>> dev.ix.0.queue5.rx_bytes: 61800291690 >>>>>> dev.ix.0.queue5.rx_copies: 129684798 >>>>>> dev.ix.0.queue5.lro_queued: 0 >>>>>> dev.ix.0.queue5.lro_flushed: 0 >>>>>> dev.ix.0.queue6.interrupt_rate: 33333 >>>>>> dev.ix.0.queue6.irqs: 11081350674 >>>>>> dev.ix.0.queue6.txd_head: 1744 >>>>>> dev.ix.0.queue6.txd_tail: 1746 >>>>>> dev.ix.0.queue6.tso_tx: 38 >>>>>> dev.ix.0.queue6.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue6.no_desc_avail: 18381 >>>>>> dev.ix.0.queue6.tx_packets: 15376961749 >>>>>> dev.ix.0.queue6.rxd_head: 1783 >>>>>> dev.ix.0.queue6.rxd_tail: 1782 >>>>>> dev.ix.0.queue6.rx_packets: 21381814216 >>>>>> dev.ix.0.queue6.rx_bytes: 56828960117 >>>>>> dev.ix.0.queue6.rx_copies: 130194429 >>>>>> dev.ix.0.queue6.lro_queued: 0 >>>>>> dev.ix.0.queue6.lro_flushed: 0 >>>>>> dev.ix.0.queue7.interrupt_rate: 5319 >>>>>> dev.ix.0.queue7.irqs: 11014043865 >>>>>> dev.ix.0.queue7.txd_head: 1545 >>>>>> dev.ix.0.queue7.txd_tail: 1545 >>>>>> dev.ix.0.queue7.tso_tx: 59 >>>>>> dev.ix.0.queue7.no_tx_dma_setup: 0 >>>>>> dev.ix.0.queue7.no_desc_avail: 5497 >>>>>> dev.ix.0.queue7.tx_packets: 15283534142 >>>>>> dev.ix.0.queue7.rxd_head: 184 >>>>>> dev.ix.0.queue7.rxd_tail: 182 >>>>>> dev.ix.0.queue7.rx_packets: 21431994087 >>>>>> dev.ix.0.queue7.rx_bytes: 57942270182 >>>>>> dev.ix.0.queue7.rx_copies: 128363306 >>>>>> dev.ix.0.queue7.lro_queued: 0 >>>>>> dev.ix.0.queue7.lro_flushed: 0 >>>>>> dev.ix.0.mac_stats.crc_errs: 268 >>>>>> dev.ix.0.mac_stats.ill_errs: 33 >>>>>> dev.ix.0.mac_stats.byte_errs: 55 >>>>>> dev.ix.0.mac_stats.short_discards: 0 >>>>>> dev.ix.0.mac_stats.local_faults: 3484 >>>>>> dev.ix.0.mac_stats.remote_faults: 121 >>>>>> dev.ix.0.mac_stats.rec_len_errs: 0 >>>>>> dev.ix.0.mac_stats.xon_txd: 1602713563748 >>>>>> dev.ix.0.mac_stats.xon_recvd: 0 >>>>>> dev.ix.0.mac_stats.xoff_txd: 108342810167 >>>>>> dev.ix.0.mac_stats.xoff_recvd: 0 >>>>>> dev.ix.0.mac_stats.total_octets_rcvd: 63648882812602 >>>>>> dev.ix.0.mac_stats.good_octets_rcvd: 63546482402023 >>>>>> dev.ix.0.mac_stats.total_pkts_rcvd: 171545277533 >>>>>> dev.ix.0.mac_stats.good_pkts_rcvd: 18446739236268246350 >>>>>> dev.ix.0.mac_stats.mcast_pkts_rcvd: 3724952 >>>>>> dev.ix.0.mac_stats.bcast_pkts_rcvd: 467054852 >>>>>> dev.ix.0.mac_stats.rx_frames_64: 5356098 >>>>>> dev.ix.0.mac_stats.rx_frames_65_127: 122019038388 >>>>>> dev.ix.0.mac_stats.rx_frames_128_255: 7578829973 >>>>>> dev.ix.0.mac_stats.rx_frames_256_511: 3450564281 >>>>>> dev.ix.0.mac_stats.rx_frames_512_1023: 5011796430 >>>>>> dev.ix.0.mac_stats.rx_frames_1024_1522: 33195848924 >>>>>> dev.ix.0.mac_stats.recv_undersized: 0 >>>>>> dev.ix.0.mac_stats.recv_fragmented: 0 >>>>>> dev.ix.0.mac_stats.recv_oversized: 244078 >>>>>> dev.ix.0.mac_stats.recv_jabberd: 4 >>>>>> dev.ix.0.mac_stats.management_pkts_rcvd: 0 >>>>>> dev.ix.0.mac_stats.management_pkts_drpd: 0 >>>>>> dev.ix.0.mac_stats.checksum_errs: 897344641 >>>>>> dev.ix.0.mac_stats.good_octets_txd: 126768678455085 >>>>>> dev.ix.0.mac_stats.total_pkts_txd: 126508073823 >>>>>> dev.ix.0.mac_stats.good_pkts_txd: 18446742557880728233 >>>>>> dev.ix.0.mac_stats.bcast_pkts_txd: 1828364 >>>>>> dev.ix.0.mac_stats.mcast_pkts_txd: 18446742431373346680 >>>>>> dev.ix.0.mac_stats.management_pkts_txd: 0 >>>>>> dev.ix.0.mac_stats.tx_frames_64: 18446742440306683787 >>>>>> dev.ix.0.mac_stats.tx_frames_65_127: 24188318255 >>>>>> dev.ix.0.mac_stats.tx_frames_128_255: 5808482194 >>>>>> dev.ix.0.mac_stats.tx_frames_256_511: 2729252777 >>>>>> dev.ix.0.mac_stats.tx_frames_512_1023: 3029688617 >>>>>> dev.ix.0.mac_stats.tx_frames_1024_1522: 81818302620 >>>>>> dev.ix.1.%desc: Intel(R) PRO/10GbE PCI-Express Network Driver, >>>>>> Version - >>>>>> 2.5.15 >>>>>> dev.ix.1.%driver: ix >>>>>> dev.ix.1.%location: slot=0 function=1 handle=\_SB_.PCI1.BR42.S4F1 >>>>>> dev.ix.1.%pnpinfo: vendor=0x8086 device=0x10fb subvendor=0x8086 >>>>>> subdevice=0x7a11 class=0x020000 >>>>>> dev.ix.1.%parent: pci129 >>>>>> dev.ix.1.fc: 3 >>>>>> dev.ix.1.enable_aim: 1 >>>>>> dev.ix.1.advertise_speed: 0 >>>>>> dev.ix.1.dropped: 0 >>>>>> dev.ix.1.mbuf_defrag_failed: 0 >>>>>> dev.ix.1.watchdog_events: 0 >>>>>> dev.ix.1.link_irq: 127925 >>>>>> dev.ix.1.queue0.interrupt_rate: 11627 >>>>>> dev.ix.1.queue0.irqs: 6686088831 >>>>>> dev.ix.1.queue0.txd_head: 1618 >>>>>> dev.ix.1.queue0.txd_tail: 1620 >>>>>> dev.ix.1.queue0.tso_tx: 28 >>>>>> dev.ix.1.queue0.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue0.no_desc_avail: 0 >>>>>> dev.ix.1.queue0.tx_packets: 13527334563 >>>>>> dev.ix.1.queue0.rxd_head: 1715 >>>>>> dev.ix.1.queue0.rxd_tail: 1714 >>>>>> dev.ix.1.queue0.rx_packets: 1503775702 >>>>>> dev.ix.1.queue0.rx_bytes: 1069295301 >>>>>> dev.ix.1.queue0.rx_copies: 2983480 >>>>>> dev.ix.1.queue0.lro_queued: 0 >>>>>> dev.ix.1.queue0.lro_flushed: 0 >>>>>> dev.ix.1.queue1.interrupt_rate: 5319 >>>>>> dev.ix.1.queue1.irqs: 6546967336 >>>>>> dev.ix.1.queue1.txd_head: 1812 >>>>>> dev.ix.1.queue1.txd_tail: 1812 >>>>>> dev.ix.1.queue1.tso_tx: 6 >>>>>> dev.ix.1.queue1.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue1.no_desc_avail: 0 >>>>>> dev.ix.1.queue1.tx_packets: 13475453794 >>>>>> dev.ix.1.queue1.rxd_head: 1246 >>>>>> dev.ix.1.queue1.rxd_tail: 1245 >>>>>> dev.ix.1.queue1.rx_packets: 1506444917 >>>>>> dev.ix.1.queue1.rx_bytes: 783064190 >>>>>> dev.ix.1.queue1.rx_copies: 2881513 >>>>>> dev.ix.1.queue1.lro_queued: 0 >>>>>> dev.ix.1.queue1.lro_flushed: 0 >>>>>> dev.ix.1.queue2.interrupt_rate: 5319 >>>>>> dev.ix.1.queue2.irqs: 6574615190 >>>>>> dev.ix.1.queue2.txd_head: 1494 >>>>>> dev.ix.1.queue2.txd_tail: 1494 >>>>>> dev.ix.1.queue2.tso_tx: 33 >>>>>> dev.ix.1.queue2.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue2.no_desc_avail: 0 >>>>>> dev.ix.1.queue2.tx_packets: 13555495169 >>>>>> dev.ix.1.queue2.rxd_head: 438 >>>>>> dev.ix.1.queue2.rxd_tail: 437 >>>>>> dev.ix.1.queue2.rx_packets: 1501380848 >>>>>> dev.ix.1.queue2.rx_bytes: 1008544082 >>>>>> dev.ix.1.queue2.rx_copies: 2660960 >>>>>> dev.ix.1.queue2.lro_queued: 0 >>>>>> dev.ix.1.queue2.lro_flushed: 0 >>>>>> dev.ix.1.queue3.interrupt_rate: 5319 >>>>>> dev.ix.1.queue3.irqs: 6617964401 >>>>>> dev.ix.1.queue3.txd_head: 1853 >>>>>> dev.ix.1.queue3.txd_tail: 1855 >>>>>> dev.ix.1.queue3.tso_tx: 10 >>>>>> dev.ix.1.queue3.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue3.no_desc_avail: 0 >>>>>> dev.ix.1.queue3.tx_packets: 13561212942 >>>>>> dev.ix.1.queue3.rxd_head: 429 >>>>>> dev.ix.1.queue3.rxd_tail: 428 >>>>>> dev.ix.1.queue3.rx_packets: 1498117903 >>>>>> dev.ix.1.queue3.rx_bytes: 784881986 >>>>>> dev.ix.1.queue3.rx_copies: 2695475 >>>>>> dev.ix.1.queue3.lro_queued: 0 >>>>>> dev.ix.1.queue3.lro_flushed: 0 >>>>>> dev.ix.1.queue4.interrupt_rate: 5319 >>>>>> dev.ix.1.queue4.irqs: 6575752163 >>>>>> dev.ix.1.queue4.txd_head: 902 >>>>>> dev.ix.1.queue4.txd_tail: 902 >>>>>> dev.ix.1.queue4.tso_tx: 5 >>>>>> dev.ix.1.queue4.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue4.no_desc_avail: 0 >>>>>> dev.ix.1.queue4.tx_packets: 13478514009 >>>>>> dev.ix.1.queue4.rxd_head: 536 >>>>>> dev.ix.1.queue4.rxd_tail: 535 >>>>>> dev.ix.1.queue4.rx_packets: 1476720084 >>>>>> dev.ix.1.queue4.rx_bytes: 944967171 >>>>>> dev.ix.1.queue4.rx_copies: 2650672 >>>>>> dev.ix.1.queue4.lro_queued: 0 >>>>>> dev.ix.1.queue4.lro_flushed: 0 >>>>>> dev.ix.1.queue5.interrupt_rate: 10416 >>>>>> dev.ix.1.queue5.irqs: 6578099670 >>>>>> dev.ix.1.queue5.txd_head: 1996 >>>>>> dev.ix.1.queue5.txd_tail: 1996 >>>>>> dev.ix.1.queue5.tso_tx: 663 >>>>>> dev.ix.1.queue5.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue5.no_desc_avail: 0 >>>>>> dev.ix.1.queue5.tx_packets: 13516483196 >>>>>> dev.ix.1.queue5.rxd_head: 1296 >>>>>> dev.ix.1.queue5.rxd_tail: 1295 >>>>>> dev.ix.1.queue5.rx_packets: 1496584151 >>>>>> dev.ix.1.queue5.rx_bytes: 810434347 >>>>>> dev.ix.1.queue5.rx_copies: 2899315 >>>>>> dev.ix.1.queue5.lro_queued: 0 >>>>>> dev.ix.1.queue5.lro_flushed: 0 >>>>>> dev.ix.1.queue6.interrupt_rate: 5319 >>>>>> dev.ix.1.queue6.irqs: 6624395782 >>>>>> dev.ix.1.queue6.txd_head: 1058 >>>>>> dev.ix.1.queue6.txd_tail: 1058 >>>>>> dev.ix.1.queue6.tso_tx: 20 >>>>>> dev.ix.1.queue6.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue6.no_desc_avail: 0 >>>>>> dev.ix.1.queue6.tx_packets: 13491315217 >>>>>> dev.ix.1.queue6.rxd_head: 1550 >>>>>> dev.ix.1.queue6.rxd_tail: 1549 >>>>>> dev.ix.1.queue6.rx_packets: 1510907490 >>>>>> dev.ix.1.queue6.rx_bytes: 719914325 >>>>>> dev.ix.1.queue6.rx_copies: 2712955 >>>>>> dev.ix.1.queue6.lro_queued: 0 >>>>>> dev.ix.1.queue6.lro_flushed: 0 >>>>>> dev.ix.1.queue7.interrupt_rate: 29411 >>>>>> dev.ix.1.queue7.irqs: 6573304834 >>>>>> dev.ix.1.queue7.txd_head: 784 >>>>>> dev.ix.1.queue7.txd_tail: 786 >>>>>> dev.ix.1.queue7.tso_tx: 2 >>>>>> dev.ix.1.queue7.no_tx_dma_setup: 0 >>>>>> dev.ix.1.queue7.no_desc_avail: 0 >>>>>> dev.ix.1.queue7.tx_packets: 13587681458 >>>>>> dev.ix.1.queue7.rxd_head: 1489 >>>>>> dev.ix.1.queue7.rxd_tail: 1488 >>>>>> dev.ix.1.queue7.rx_packets: 1504712031 >>>>>> dev.ix.1.queue7.rx_bytes: 1216803328 >>>>>> dev.ix.1.queue7.rx_copies: 2976103 >>>>>> dev.ix.1.queue7.lro_queued: 0 >>>>>> dev.ix.1.queue7.lro_flushed: 0 >>>>>> dev.ix.1.mac_stats.crc_errs: 0 >>>>>> dev.ix.1.mac_stats.ill_errs: 0 >>>>>> dev.ix.1.mac_stats.byte_errs: 0 >>>>>> dev.ix.1.mac_stats.short_discards: 0 >>>>>> dev.ix.1.mac_stats.local_faults: 0 >>>>>> dev.ix.1.mac_stats.remote_faults: 12 >>>>>> dev.ix.1.mac_stats.rec_len_errs: 0 >>>>>> dev.ix.1.mac_stats.xon_txd: 1714791401322 >>>>>> dev.ix.1.mac_stats.xon_recvd: 0 >>>>>> dev.ix.1.mac_stats.xoff_txd: 41095995010 >>>>>> dev.ix.1.mac_stats.xoff_recvd: 0 >>>>>> dev.ix.1.mac_stats.total_octets_rcvd: 4335824523464 >>>>>> dev.ix.1.mac_stats.good_octets_rcvd: 4335686239235 >>>>>> dev.ix.1.mac_stats.total_pkts_rcvd: 12020354631 >>>>>> dev.ix.1.mac_stats.good_pkts_rcvd: 18446730999130315370 >>>>>> dev.ix.1.mac_stats.mcast_pkts_rcvd: 737 >>>>>> dev.ix.1.mac_stats.bcast_pkts_rcvd: 295580 >>>>>> dev.ix.1.mac_stats.rx_frames_64: 73447 >>>>>> dev.ix.1.mac_stats.rx_frames_65_127: 8714296833 >>>>>> dev.ix.1.mac_stats.rx_frames_128_255: 478134642 >>>>>> dev.ix.1.mac_stats.rx_frames_256_511: 232994605 >>>>>> dev.ix.1.mac_stats.rx_frames_512_1023: 341753974 >>>>>> dev.ix.1.mac_stats.rx_frames_1024_1522: 2251178850 >>>>>> dev.ix.1.mac_stats.recv_undersized: 0 >>>>>> dev.ix.1.mac_stats.recv_fragmented: 0 >>>>>> dev.ix.1.mac_stats.recv_oversized: 0 >>>>>> dev.ix.1.mac_stats.recv_jabberd: 0 >>>>>> dev.ix.1.mac_stats.management_pkts_rcvd: 0 >>>>>> dev.ix.1.mac_stats.management_pkts_drpd: 0 >>>>>> dev.ix.1.mac_stats.checksum_errs: 85432477 >>>>>> dev.ix.1.mac_stats.good_octets_txd: 110334688606644 >>>>>> dev.ix.1.mac_stats.total_pkts_txd: 108193846110 >>>>>> dev.ix.1.mac_stats.good_pkts_txd: 18446742447490837867 >>>>>> dev.ix.1.mac_stats.bcast_pkts_txd: 595976 >>>>>> dev.ix.1.mac_stats.mcast_pkts_txd: 18446742339297559869 >>>>>> dev.ix.1.mac_stats.management_pkts_txd: 0 >>>>>> dev.ix.1.mac_stats.tx_frames_64: 18446742346194685024 >>>>>> dev.ix.1.mac_stats.tx_frames_65_127: 19859540709 >>>>>> dev.ix.1.mac_stats.tx_frames_128_255: 5129619113 >>>>>> dev.ix.1.mac_stats.tx_frames_256_511: 2384651426 >>>>>> dev.ix.1.mac_stats.tx_frames_512_1023: 2651547352 >>>>>> dev.ix.1.mac_stats.tx_frames_1024_1522: 71270794251 >>>>>> >>>>>> # cat /var/run/dmesg.boot >>>>>> >>>>>> Copyright (c) 1992-2014 The FreeBSD Project. >>>>>> Copyright (c) 1979, 1980, 1983, 1986, 1988, 1989, 1991, 1992, >>>>>> 1993, 1994 >>>>>> The Regents of the University of California. All rights >>>> reserved. >>>>>> FreeBSD is a registered trademark of The FreeBSD Foundation. >>>>>> FreeBSD 10.1-RELEASE #2 r274375: Tue Nov 11 10:24:44 BRST 2014 >>>>>> root@rt01.intnet.com.br:/usr/obj/usr/src/sys/INTNET10 amd64 >>>>>> FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) >>>>>> 20140512 >>>>>> CPU: Intel(R) Xeon(R) CPU E5-2630 v2 @ 2.60GHz (2593.80-MHz K8-class >>>> CPU) >>>>>> Origin = "GenuineIntel" Id = 0x306e4 Family = 0x6 Model = 0x3e >>>>>> Stepping = 4 >>>>>> >>>>>> >>>> Features=0xbfebfbff >>>> >>>> Features2=0x7fbee3ff >>>> >>>>>> AMD Features=0x2c100800 >>>>>> AMD Features2=0x1 >>>>>> Structured Extended Features=0x281 >>>>>> VT-x: (disabled in BIOS) >>>>>> PAT,HLT,MTF,PAUSE,EPT,UG,VPID,VID,PostIntr >>>>>> TSC: P-state invariant, performance statistics >>>>>> real memory = 17179869184 (16384 MB) >>>>>> avail memory = 16515358720 (15750 MB) >>>>>> Event timer "LAPIC" quality 600 >>>>>> ACPI APIC Table: >>>>>> FreeBSD/SMP: Multiprocessor System Detected: 12 CPUs >>>>>> FreeBSD/SMP: 2 package(s) x 6 core(s) >>>>>> cpu0 (BSP): APIC ID: 0 >>>>>> cpu1 (AP): APIC ID: 2 >>>>>> cpu2 (AP): APIC ID: 4 >>>>>> cpu3 (AP): APIC ID: 6 >>>>>> cpu4 (AP): APIC ID: 8 >>>>>> cpu5 (AP): APIC ID: 10 >>>>>> cpu6 (AP): APIC ID: 32 >>>>>> cpu7 (AP): APIC ID: 34 >>>>>> cpu8 (AP): APIC ID: 36 >>>>>> cpu9 (AP): APIC ID: 38 >>>>>> cpu10 (AP): APIC ID: 40 >>>>>> cpu11 (AP): APIC ID: 42 >>>>>> ACPI BIOS Warning (bug): Invalid length for FADT/Pm1aControlBlock: >>>>>> 32, >>>>>> using default 16 (20130823/tbfadt-682) >>>>>> ioapic0 irqs 0-23 on motherboard >>>>>> ioapic1 irqs 24-47 on motherboard >>>>>> ioapic2 irqs 48-71 on motherboard >>>>>> kbd1 at kbdmux0 >>>>>> random: initialized >>>>>> cryptosoft0: on motherboard >>>>>> acpi0: on motherboard >>>>>> acpi0: Power Button (fixed) >>>>>> acpi0: reservation of 0, 9d000 (3) failed >>>>>> cpu0: on acpi0 >>>>>> cpu1: on acpi0 >>>>>> cpu2: on acpi0 >>>>>> cpu3: on acpi0 >>>>>> cpu4: on acpi0 >>>>>> cpu5: on acpi0 >>>>>> cpu6: on acpi0 >>>>>> cpu7: on acpi0 >>>>>> cpu8: on acpi0 >>>>>> cpu9: on acpi0 >>>>>> cpu10: on acpi0 >>>>>> cpu11: on acpi0 >>>>>> hpet0: iomem 0xfed00000-0xfed003ff on >>>>>> acpi0 >>>>>> Timecounter "HPET" frequency 14318180 Hz quality 950 >>>>>> Event timer "HPET" frequency 14318180 Hz quality 350 >>>>>> Event timer "HPET1" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET2" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET3" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET4" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET5" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET6" frequency 14318180 Hz quality 340 >>>>>> Event timer "HPET7" frequency 14318180 Hz quality 340 >>>>>> atrtc0: port 0x70-0x77 irq 8 on acpi0 >>>>>> atrtc0: Warning: Couldn't map I/O. >>>>>> Event timer "RTC" frequency 32768 Hz quality 0 >>>>>> attimer0: port 0x40-0x43,0x50-0x53 irq 0 on acpi0 >>>>>> Timecounter "i8254" frequency 1193182 Hz quality 0 >>>>>> Event timer "i8254" frequency 1193182 Hz quality 100 >>>>>> Timecounter "ACPI-fast" frequency 3579545 Hz quality 900 >>>>>> acpi_timer0: <24-bit timer at 3.579545MHz> port 0x408-0x40b on acpi0 >>>>>> pcib0: port 0xcf8-0xcff on acpi0 >>>>>> pci0: on pcib0 >>>>>> pcib1: irq 47 at device 1.0 on pci0 >>>>>> pci1: on pcib1 >>>>>> pcib2: irq 47 at device 1.1 on pci0 >>>>>> pci2: on pcib2 >>>>>> igb0: port >>>>>> 0x1060-0x107f mem 0xd0f60000-0xd0f7ffff,0xd0fb0000-0xd0fb3fff irq >>>>>> 27 at >>>>>> device 0.0 on pci2 >>>>>> igb0: Using MSIX interrupts with 9 vectors >>>>>> igb0: Ethernet address: 00:1e:67:9a:d5:88 >>>>>> igb0: Bound queue 0 to cpu 0 >>>>>> igb0: Bound queue 1 to cpu 1 >>>>>> igb0: Bound queue 2 to cpu 2 >>>>>> igb0: Bound queue 3 to cpu 3 >>>>>> igb0: Bound queue 4 to cpu 4 >>>>>> igb0: Bound queue 5 to cpu 5 >>>>>> igb0: Bound queue 6 to cpu 6 >>>>>> igb0: Bound queue 7 to cpu 7 >>>>>> igb1: port >>>>>> 0x1040-0x105f mem 0xd0f40000-0xd0f5ffff,0xd0fa0000-0xd0fa3fff irq >>>>>> 30 at >>>>>> device 0.1 on pci2 >>>>>> igb1: Using MSIX interrupts with 9 vectors >>>>>> igb1: Ethernet address: 00:1e:67:9a:d5:89 >>>>>> igb1: Bound queue 0 to cpu 8 >>>>>> igb1: Bound queue 1 to cpu 9 >>>>>> igb1: Bound queue 2 to cpu 10 >>>>>> igb1: Bound queue 3 to cpu 11 >>>>>> igb1: Bound queue 4 to cpu 0 >>>>>> igb1: Bound queue 5 to cpu 1 >>>>>> igb1: Bound queue 6 to cpu 2 >>>>>> igb1: Bound queue 7 to cpu 3 >>>>>> igb2: port >>>>>> 0x1020-0x103f mem 0xd0f20000-0xd0f3ffff,0xd0f90000-0xd0f93fff irq >>>>>> 28 at >>>>>> device 0.2 on pci2 >>>>>> igb2: Using MSIX interrupts with 9 vectors >>>>>> igb2: Ethernet address: 00:1e:67:9a:d5:8a >>>>>> igb2: Bound queue 0 to cpu 4 >>>>>> igb2: Bound queue 1 to cpu 5 >>>>>> igb2: Bound queue 2 to cpu 6 >>>>>> igb2: Bound queue 3 to cpu 7 >>>>>> igb2: Bound queue 4 to cpu 8 >>>>>> igb2: Bound queue 5 to cpu 9 >>>>>> igb2: Bound queue 6 to cpu 10 >>>>>> igb2: Bound queue 7 to cpu 11 >>>>>> igb3: port >>>>>> 0x1000-0x101f mem 0xd0f00000-0xd0f1ffff,0xd0f80000-0xd0f83fff irq >>>>>> 29 at >>>>>> device 0.3 on pci2 >>>>>> igb3: Using MSIX interrupts with 9 vectors >>>>>> igb3: Ethernet address: 00:1e:67:9a:d5:8b >>>>>> igb3: Bound queue 0 to cpu 0 >>>>>> igb3: Bound queue 1 to cpu 1 >>>>>> igb3: Bound queue 2 to cpu 2 >>>>>> igb3: Bound queue 3 to cpu 3 >>>>>> igb3: Bound queue 4 to cpu 4 >>>>>> igb3: Bound queue 5 to cpu 5 >>>>>> igb3: Bound queue 6 to cpu 6 >>>>>> igb3: Bound queue 7 to cpu 7 >>>>>> pcib3: irq 47 at device 2.0 on pci0 >>>>>> pci4: on pcib3 >>>>>> igb4: mem >>>>>> 0xd0d00000-0xd0dfffff,0xd0e10000-0xd0e13fff irq 32 at device 0.0 >>>>>> on pci4 >>>>>> igb4: Using MSIX interrupts with 9 vectors >>>>>> igb4: Ethernet address: a0:36:9f:37:82:7e >>>>>> igb4: Bound queue 0 to cpu 8 >>>>>> igb4: Bound queue 1 to cpu 9 >>>>>> igb4: Bound queue 2 to cpu 10 >>>>>> igb4: Bound queue 3 to cpu 11 >>>>>> igb4: Bound queue 4 to cpu 0 >>>>>> igb4: Bound queue 5 to cpu 1 >>>>>> igb4: Bound queue 6 to cpu 2 >>>>>> igb4: Bound queue 7 to cpu 3 >>>>>> igb5: mem >>>>>> 0xd0c00000-0xd0cfffff,0xd0e00000-0xd0e03fff irq 36 at device 0.1 >>>>>> on pci4 >>>>>> igb5: Using MSIX interrupts with 9 vectors >>>>>> igb5: Ethernet address: a0:36:9f:37:82:7f >>>>>> igb5: Bound queue 0 to cpu 4 >>>>>> igb5: Bound queue 1 to cpu 5 >>>>>> igb5: Bound queue 2 to cpu 6 >>>>>> igb5: Bound queue 3 to cpu 7 >>>>>> igb5: Bound queue 4 to cpu 8 >>>>>> igb5: Bound queue 5 to cpu 9 >>>>>> igb5: Bound queue 6 to cpu 10 >>>>>> igb5: Bound queue 7 to cpu 11 >>>>>> pcib4: irq 16 at device 3.0 on pci0 >>>>>> pci6: on pcib4 >>>>>> igb6: mem >>>>>> 0xd0a00000-0xd0afffff,0xd0b10000-0xd0b13fff irq 40 at device 0.0 >>>>>> on pci6 >>>>>> igb6: Using MSIX interrupts with 9 vectors >>>>>> igb6: Ethernet address: a0:36:9f:37:82:8a >>>>>> igb6: Bound queue 0 to cpu 0 >>>>>> igb6: Bound queue 1 to cpu 1 >>>>>> igb6: Bound queue 2 to cpu 2 >>>>>> igb6: Bound queue 3 to cpu 3 >>>>>> igb6: Bound queue 4 to cpu 4 >>>>>> igb6: Bound queue 5 to cpu 5 >>>>>> igb6: Bound queue 6 to cpu 6 >>>>>> igb6: Bound queue 7 to cpu 7 >>>>>> igb7: mem >>>>>> 0xd0900000-0xd09fffff,0xd0b00000-0xd0b03fff irq 44 at device 0.1 >>>>>> on pci6 >>>>>> igb7: Using MSIX interrupts with 9 vectors >>>>>> igb7: Ethernet address: a0:36:9f:37:82:8b >>>>>> igb7: Bound queue 0 to cpu 8 >>>>>> igb7: Bound queue 1 to cpu 9 >>>>>> igb7: Bound queue 2 to cpu 10 >>>>>> igb7: Bound queue 3 to cpu 11 >>>>>> igb7: Bound queue 4 to cpu 0 >>>>>> igb7: Bound queue 5 to cpu 1 >>>>>> igb7: Bound queue 6 to cpu 2 >>>>>> igb7: Bound queue 7 to cpu 3 >>>>>> pcib5: irq 16 at device 17.0 on pci0 >>>>>> pci8: on pcib5 >>>>>> pci0: at device 22.0 (no driver attached) >>>>>> pci0: at device 22.1 (no driver attached) >>>>>> ehci0: mem >>>>>> 0xd1220000-0xd12203ff irq >>>>>> 22 at device 26.0 on pci0 >>>>>> usbus0: EHCI version 1.0 >>>>>> usbus0 on ehci0 >>>>>> pcib6: irq 16 at device 28.0 on pci0 >>>>>> pci9: on pcib6 >>>>>> pcib7: irq 17 at device 28.5 on pci0 >>>>>> pci10: on pcib7 >>>>>> pci10: at device 0.0 (no driver attached) >>>>>> pcib8: irq 19 at device 28.7 on pci0 >>>>>> pci11: on pcib8 >>>>>> vgapci0: mem >>>>>> 0xea000000-0xeaffffff,0xd0810000-0xd0813fff,0xd0000000-0xd07fffff irq >>>> 19 at >>>>>> device 0.0 on pci11 >>>>>> vgapci0: Boot video device >>>>>> ehci1: mem >>>>>> 0xd1210000-0xd12103ff irq >>>>>> 20 at device 29.0 on pci0 >>>>>> usbus1: EHCI version 1.0 >>>>>> usbus1 on ehci1 >>>>>> pcib9: at device 30.0 on pci0 >>>>>> pci12: on pcib9 >>>>>> isab0: at device 31.0 on pci0 >>>>>> isa0: on isab0 >>>>>> ahci0: port >>>>>> 0x2070-0x2077,0x2060-0x2063,0x2050-0x2057,0x2040-0x2043,0x2020-0x203f >>>> mem >>>>>> 0xd1200000-0xd12007ff irq 21 at device 31.2 on pci0 >>>>>> ahci0: AHCI v1.30 with 6 6Gbps ports, Port Multiplier not supported >>>>>> ahcich0: at channel 0 on ahci0 >>>>>> ahcich1: at channel 1 on ahci0 >>>>>> ahcich2: at channel 2 on ahci0 >>>>>> ahcich3: at channel 3 on ahci0 >>>>>> ahcich4: at channel 4 on ahci0 >>>>>> ahcich5: at channel 5 on ahci0 >>>>>> ahciem0: on ahci0 >>>>>> pcib10: on acpi0 >>>>>> pci128: on pcib10 >>>>>> pcib11: irq 71 at device 1.0 on pci128 >>>>>> pci129: on pcib11 >>>>>> ix0: >>>>> 2.5.15> >>>>>> port 0xc020-0xc03f mem 0xec180000-0xec1fffff,0xec210000-0xec213fff >>>>>> irq >>>> 50 at >>>>>> device 0.0 on pci129 >>>>>> ix0: Using MSIX interrupts with 9 vectors >>>>>> ix0: Ethernet address: 00:1b:21:89:25:32 >>>>>> ix0: PCI Express Bus: Speed 5.0GT/s Width x8 >>>>>> ix1: >>>>> 2.5.15> >>>>>> port 0xc000-0xc01f mem 0xec080000-0xec0fffff,0xec200000-0xec203fff >>>>>> irq >>>> 52 at >>>>>> device 0.1 on pci129 >>>>>> ix1: Using MSIX interrupts with 9 vectors >>>>>> ix1: Ethernet address: 00:1b:21:89:25:33 >>>>>> ix1: PCI Express Bus: Speed 5.0GT/s Width x8 >>>>>> pcib12: irq 71 at device 2.0 on pci128 >>>>>> pci131: on pcib12 >>>>>> pcib13: irq 71 at device 3.0 on pci128 >>>>>> pci132: on pcib13 >>>>>> acpi_button0: on acpi0 >>>>>> pcib14: on acpi0 >>>>>> pci127: on pcib14 >>>>>> pcib15: on acpi0 >>>>>> pci255: on pcib15 >>>>>> uart0: <16550 or compatible> port 0x3f8-0x3ff irq 4 flags 0x10 on >>>>>> acpi0 >>>>>> uart1: <16550 or compatible> port 0x2f8-0x2ff irq 3 on acpi0 >>>>>> orm0: at iomem >>>>>> >>>> 0xc0000-0xc7fff,0xc8000-0xc8fff,0xc9000-0xc9fff,0xca000-0xcafff,0xcb000-0xcbfff,0xcc000-0xccfff,0xcd000-0xcdfff,0xce000-0xcefff,0xcf000-0xcffff >>>> >>>>>> on isa0 >>>>>> sc0: at flags 0x100 on isa0 >>>>>> sc0: VGA <16 virtual consoles, flags=0x300> >>>>>> vga0: at port 0x3c0-0x3df iomem 0xa0000-0xbffff on >>>> isa0 >>>>>> est0: on cpu0 >>>>>> p4tcc0: on cpu0 >>>>>> est1: on cpu1 >>>>>> p4tcc1: on cpu1 >>>>>> est2: on cpu2 >>>>>> p4tcc2: on cpu2 >>>>>> est3: on cpu3 >>>>>> p4tcc3: on cpu3 >>>>>> est4: on cpu4 >>>>>> p4tcc4: on cpu4 >>>>>> est5: on cpu5 >>>>>> p4tcc5: on cpu5 >>>>>> est6: on cpu6 >>>>>> p4tcc6: on cpu6 >>>>>> est7: on cpu7 >>>>>> p4tcc7: on cpu7 >>>>>> est8: on cpu8 >>>>>> p4tcc8: on cpu8 >>>>>> est9: on cpu9 >>>>>> p4tcc9: on cpu9 >>>>>> est10: on cpu10 >>>>>> p4tcc10: on cpu10 >>>>>> est11: on cpu11 >>>>>> p4tcc11: on cpu11 >>>>>> random: unblocking device. >>>>>> usbus0: 480Mbps High Speed USB v2.0 >>>>>> Timecounters tick every 1.000 msec >>>>>> IPsec: Initialized Security Association Processing. >>>>>> ipfw2 (+ipv6) initialized, divert enabled, nat enabled, default to >>>> accept, >>>>>> logging disabled >>>>>> usbus1: 480Mbps High Speed USB v2.0 >>>>>> ugen1.1: at usbus1 >>>>>> uhub0: on >>>>>> usbus1 >>>>>> ugen0.1: at usbus0 >>>>>> uhub1: on >>>>>> usbus0 >>>>>> ada0 at ahcich0 bus 0 scbus0 target 0 lun 0 >>>>>> ada0: ATA-9 SATA 3.x device >>>>>> ada0: Serial Number S1D5NSAF687077K >>>>>> ada0: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 512bytes) >>>>>> ada0: Command Queueing enabled >>>>>> ada0: 114473MB (234441648 512 byte sectors: 16H 63S/T 16383C) >>>>>> ada0: quirks=0x1<4K> >>>>>> ada0: Previously was known as ad4 >>>>>> ses0 at ahciem0 bus 0 scbus6 target 0 lun 0 >>>>>> ses0: SEMB S-E-S 2.00 device >>>>>> ses0: SEMB SES Device >>>>>> SMP: AP CPU #6 Launched! >>>>>> SMP: AP CPU #3 Launched! >>>>>> SMP: AP CPU #11 Launched! >>>>>> SMP: AP CPU #5 Launched! >>>>>> SMP: AP CPU #9 Launched! >>>>>> SMP: AP CPU #1 Launched! >>>>>> SMP: AP CPU #10 Launched! >>>>>> SMP: AP CPU #2 Launched! >>>>>> SMP: AP CPU #8 Launched! >>>>>> SMP: AP CPU #4 Launched! >>>>>> SMP: AP CPU #7 Launched! >>>>>> Timecounter "TSC-low" frequency 1296902002 Hz quality 1000 >>>>>> Root mount waiting for: usbus1 usbus0 >>>>>> uhub1: 2 ports with 2 removable, self powered >>>>>> uhub0: 2 ports with 2 removable, self powered >>>>>> Root mount waiting for: usbus1 usbus0 >>>>>> ugen1.2: at usbus1 >>>>>> uhub2: >>>>> addr 2> >>>> on >>>>>> usbus1 >>>>>> ugen0.2: at usbus0 >>>>>> uhub3: >>>>> addr 2> >>>> on >>>>>> usbus0 >>>>>> Root mount waiting for: usbus1 usbus0 >>>>>> uhub3: 6 ports with 6 removable, self powered >>>>>> uhub2: 8 ports with 8 removable, self powered >>>>>> ugen1.3: at usbus1 >>>>>> ukbd0: on usbus1 >>>>>> kbd0 at ukbd0 >>>>>> Root mount waiting for: usbus1 >>>>>> ugen1.4: at usbus1 >>>>>> ukbd1: on usbus1 >>>>>> kbd2 at ukbd1 >>>>>> Trying to mount root from ufs:/dev/label/rootfs [rw]... >>>>>> lagg0: IPv6 addresses on igb6 have been removed before adding it as a >>>>>> member to prevent IPv6 address scope violation. >>>>>> lagg0: IPv6 addresses on igb7 have been removed before adding it as a >>>>>> member to prevent IPv6 address scope violation. >>>>>> ums0: on usbus1 >>>>>> ums0: 3 buttons and [Z] coordinates ID=0 >>>>>> uhid0: on usbus1 >>>>>> >>>>>> # uname -a >>>>>> FreeBSD rt01.xxxxx.com.br 10.1-RELEASE FreeBSD 10.1-RELEASE #2 >>>>>> r274375: >>>>>> Tue Nov 11 10:24:44 BRST 2014 >>>>>> root@rt01.xxxxx.com.br:/usr/obj/usr/src/sys/GONDIM10 amd64 >>>>>> >>>>>> [1] https://calomel.org/freebsd_network_tuning.html >>>>>> [2] http://ark.intel.com/products/63157 >>>>>> [3] >>>>>> >>>> http://ark.intel.com/pt-br/products/39774/Intel-Ethernet-Converged-Network-Adapter-X520-SR2 >>>> >>>>>> [4] http://ark.intel.com/products/59062/ >>>>>> >>>>>> Please I need a help! and sorry my english :) >>>>>> From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 12:15:50 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 650F91A8 for ; Wed, 18 Feb 2015 12:15:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1EBD9F24 for ; Wed, 18 Feb 2015 12:15:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1ICFnjn048344 for ; Wed, 18 Feb 2015 12:15:49 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1ICFnkD048343; Wed, 18 Feb 2015 12:15:49 GMT (envelope-from root) Date: Wed, 18 Feb 2015 12:15:49 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <6fe00fbf0b80b91c8237836569fdcee5@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTkgnU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 12:15:50 -0000 hselasky added a comment. Let me re-phrase if I was unclear: I see nothing preventing the callout_reset() macro from reading (c)->c_cpu lock when it is equal to CPUBLOCK while another CPU is calling callout_cpu_switch() on the same callout. Especially in the case of a migration case done by the callout_process(), because there is no common "c->c_lock" so-to-speak for the two pieces of code. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 13:43:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 328DED67 for ; Wed, 18 Feb 2015 13:43:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1C88A73 for ; Wed, 18 Feb 2015 13:43:14 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IDhEfU043823 for ; Wed, 18 Feb 2015 13:43:14 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IDhEBa043822; Wed, 18 Feb 2015 13:43:14 GMT (envelope-from root) Date: Wed, 18 Feb 2015 13:43:14 +0000 To: freebsd-net@freebsd.org From: "rrs (Randall Stewart)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <3ad1f30dc0d12c22d7fee945242fd476@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTklvI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 13:43:15 -0000 rrs added a comment. Ok after much discussion with Hans, we *could* have an issue where the user sends in an invalid CPU. This is *not* what I think is happening with Hiren since the cc_cpu and lock is all sane (it would be a invalid index to cc_cpu which would not have an init'd lock). But I have created a new review since this one is already committed https://reviews.freebsd.org/D1894 To add verification and correction code for just in case the callers of the callout system mix the callout_reset callout_reset_on within the same callout structure. No system that I can find currently does this, but it is best to have the protection. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 14:27:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ACA9B2EF for ; Wed, 18 Feb 2015 14:27:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 87FE9EB5 for ; Wed, 18 Feb 2015 14:27:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IERWGZ089167 for ; Wed, 18 Feb 2015 14:27:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IERWIX089166; Wed, 18 Feb 2015 14:27:32 GMT (envelope-from root) Date: Wed, 18 Feb 2015 14:27:32 +0000 To: freebsd-net@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <37008dc884df20c8c64a8a3c84e7f39f@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTkoVQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 14:27:32 -0000 emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 19:54:16 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CD17441D for ; Wed, 18 Feb 2015 19:54:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AC925E84 for ; Wed, 18 Feb 2015 19:54:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IJsGFI035738 for ; Wed, 18 Feb 2015 19:54:16 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IJsGXj035737; Wed, 18 Feb 2015 19:54:16 GMT (envelope-from root) Date: Wed, 18 Feb 2015 19:54:16 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1648: Add stubs for deprecated VC messages Message-ID: X-Priority: 3 Thread-Topic: D1648: Add stubs for deprecated VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2MyNjI4YjVjODUwMDVhYzYxNTNkMjEyYzRlIFTk7eg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 19:54:16 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. BRANCH review_D1648 REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 19:55:19 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 69A724BB for ; Wed, 18 Feb 2015 19:55:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4844EE92 for ; Wed, 18 Feb 2015 19:55:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IJtIpI036806 for ; Wed, 18 Feb 2015 19:55:18 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IJtImZ036805; Wed, 18 Feb 2015 19:55:18 GMT (envelope-from root) Date: Wed, 18 Feb 2015 19:55:18 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1648: Add stubs for deprecated VC messages Message-ID: X-Priority: 3 Thread-Topic: D1648: Add stubs for deprecated VC messages X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2MyNjI4YjVjODUwMDVhYzYxNTNkMjEyYzRlIFTk7iY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 19:55:19 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1648 To: rstone, jfvogel Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 19:59:38 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 207A65AC for ; Wed, 18 Feb 2015 19:59:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2B07EBD for ; Wed, 18 Feb 2015 19:59:37 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IJxbtN040036 for ; Wed, 18 Feb 2015 19:59:37 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IJxbo6040035; Wed, 18 Feb 2015 19:59:37 GMT (envelope-from root) Date: Wed, 18 Feb 2015 19:59:37 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1868: Make libnv headers includable from C++ Message-ID: <18577f0d958489a75043c03912959680@localhost.localdomain> X-Priority: 3 Thread-Topic: D1868: Make libnv headers includable from C++ X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OWRjMTRmYjQ5YzQ2YzVmY2VhMGEzM2Q1YTg1IFTk7yk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 19:59:38 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 20:32:25 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 50AA0D10 for ; Wed, 18 Feb 2015 20:32:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 302483B4 for ; Wed, 18 Feb 2015 20:32:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IKWOjE075979 for ; Wed, 18 Feb 2015 20:32:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IKWOk5075978; Wed, 18 Feb 2015 20:32:24 GMT (envelope-from root) Date: Wed, 18 Feb 2015 20:32:24 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1869: Tests of basic nvlist add functions Message-ID: <257d78f242e323f437b5f5c643033833@localhost.localdomain> X-Priority: 3 Thread-Topic: D1869: Tests of basic nvlist add functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmI4OTE5NjAxYjk3NGQwNTQ3YmRmODFjMzVkIFTk9tg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 20:32:25 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 21:20:19 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 305CBDAB for ; Wed, 18 Feb 2015 21:20:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E304DCC2 for ; Wed, 18 Feb 2015 21:20:18 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1ILKIJO024441 for ; Wed, 18 Feb 2015 21:20:18 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1ILKI88024440; Wed, 18 Feb 2015 21:20:18 GMT (envelope-from root) Date: Wed, 18 Feb 2015 21:20:18 +0000 To: freebsd-net@freebsd.org From: "glebius (Gleb Smirnoff)" Subject: [Differential] [Updated] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets Message-ID: X-Priority: 3 Thread-Topic: D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTM5NTRkZmFhY2M5ZGMyZjg3NmZhODJjMjFlIFTlAhI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 21:20:19 -0000 glebius added a reviewer: ken. glebius added a comment. This is Ken's code, we probably want him to look at. Looks like a remnant from zero copy era. REVISION DETAIL https://reviews.freebsd.org/D1893 To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson, ken Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:12:09 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D97B8576 for ; Wed, 18 Feb 2015 22:12:09 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B954E66C for ; Wed, 18 Feb 2015 22:12:09 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMC9fv079524 for ; Wed, 18 Feb 2015 22:12:09 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMC970079522; Wed, 18 Feb 2015 22:12:09 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:12:09 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1870: Add tests for nvlist_clone Message-ID: X-Priority: 3 Thread-Topic: D1870: Add tests for nvlist_clone X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzdhNWFmMzVlZWYzY2IzNDlmMTM3MmY4ZjU0IFTlDjk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:12:09 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:18:57 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 768A3926 for ; Wed, 18 Feb 2015 22:18:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5553178D for ; Wed, 18 Feb 2015 22:18:57 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMIvLi084477 for ; Wed, 18 Feb 2015 22:18:57 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMIvfY084476; Wed, 18 Feb 2015 22:18:57 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:18:57 +0000 To: freebsd-net@freebsd.org From: "will (Will Andrews)" Subject: [Differential] [Changed Subscribers] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTlD9E= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:18:57 -0000 will added a subscriber: will. will added a comment. What testing has been done with this change? REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:20:29 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45075B15 for ; Wed, 18 Feb 2015 22:20:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E90B07AB for ; Wed, 18 Feb 2015 22:20:28 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMKSED085805 for ; Wed, 18 Feb 2015 22:20:28 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMKStJ085804; Wed, 18 Feb 2015 22:20:28 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:20:28 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1871: Add tests for nvlist_pack/unpack Message-ID: X-Priority: 3 Thread-Topic: D1871: Add tests for nvlist_pack/unpack X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjE0ZjFmNGMwMDdhNWFlNTZiMmMyYzFlOWZhIFTlECw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:20:29 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:20:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6289ABAC for ; Wed, 18 Feb 2015 22:20:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 42CC0845 for ; Wed, 18 Feb 2015 22:20:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMKpUq086172 for ; Wed, 18 Feb 2015 22:20:51 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMKpFD086171; Wed, 18 Feb 2015 22:20:51 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:20:50 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1872: Add test cases for nvlist_move_* Message-ID: <628f225551937d3574bbc10d1635f7fd@localhost.localdomain> X-Priority: 3 Thread-Topic: D1872: Add test cases for nvlist_move_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NmEyYzJiMjM0NjMwMTZiZjkyMmIzOThiYTIxIFTlEEI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:20:51 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:21:31 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DC8D3C4A for ; Wed, 18 Feb 2015 22:21:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD4B6857 for ; Wed, 18 Feb 2015 22:21:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMLVPo088795 for ; Wed, 18 Feb 2015 22:21:31 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMLV36088794; Wed, 18 Feb 2015 22:21:31 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:21:31 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1873: Add tests for nvlist_take_* Message-ID: <461d0ab0eb33233eda9ea74e9a6a2c23@localhost.localdomain> X-Priority: 3 Thread-Topic: D1873: Add tests for nvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmVhMDUyMmU1Y2QxYzQxY2VkNWZiMDUyYmE4IFTlEGs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:21:31 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:22:08 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C7487CE8 for ; Wed, 18 Feb 2015 22:22:08 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A776B867 for ; Wed, 18 Feb 2015 22:22:08 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMM84G089915 for ; Wed, 18 Feb 2015 22:22:08 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMM8va089914; Wed, 18 Feb 2015 22:22:08 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:22:08 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1874: Add tests for nvlist_free* functions Message-ID: <62440565a931ba71617f9f71ce9cb477@localhost.localdomain> X-Priority: 3 Thread-Topic: D1874: Add tests for nvlist_free* functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzZkMTAwZDc4MmI2OWExNDZiN2EwMDcyZjUzIFTlEJA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:22:08 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:23:04 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A8009D8F for ; Wed, 18 Feb 2015 22:23:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 88BAF87C for ; Wed, 18 Feb 2015 22:23:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMN42j090697 for ; Wed, 18 Feb 2015 22:23:04 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMN4Gp090696; Wed, 18 Feb 2015 22:23:04 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:23:04 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1875: Add tests for dnv_get_* Message-ID: X-Priority: 3 Thread-Topic: D1875: Add tests for dnv_get_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDdlZjc2MzE0YTE1YzZlZTQ2MDIzYTVjMjRjIFTlEMg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:23:04 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:23:25 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C3854F0B for ; Wed, 18 Feb 2015 22:23:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A4122890 for ; Wed, 18 Feb 2015 22:23:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMNPNF090933 for ; Wed, 18 Feb 2015 22:23:25 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMNPvr090932; Wed, 18 Feb 2015 22:23:25 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:23:25 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1876: Add tests for dnvlist_take_* Message-ID: <0ec75b9d83baefbe5fa83602776f3d00@localhost.localdomain> X-Priority: 3 Thread-Topic: D1876: Add tests for dnvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDBkNDVlNDM2OWUwZjdhM2U4YjdkNzA1Y2Q2IFTlEN0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:23:25 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:24:22 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 15827FBD for ; Wed, 18 Feb 2015 22:24:22 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA58E8A5 for ; Wed, 18 Feb 2015 22:24:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMOLR3091547 for ; Wed, 18 Feb 2015 22:24:21 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMOLiv091546; Wed, 18 Feb 2015 22:24:21 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:24:21 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1877: Implement asprintf in libkern Message-ID: X-Priority: 3 Thread-Topic: D1877: Implement asprintf in libkern X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2UzMzZkZWVmYzI1ZDNmYzIzZDNmMmU4YzAxIFTlERU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:24:22 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:25:11 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4E410F8 for ; Wed, 18 Feb 2015 22:25:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E17E8C0 for ; Wed, 18 Feb 2015 22:25:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMPAq8092461 for ; Wed, 18 Feb 2015 22:25:10 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMPARk092460; Wed, 18 Feb 2015 22:25:10 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:25:10 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1878: Add function to force an nvlist into the error state Message-ID: <688238eb4113d1bead535026100188dd@localhost.localdomain> X-Priority: 3 Thread-Topic: D1878: Add function to force an nvlist into the error state X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2JhMDMyYjI3NjA3ZWFkYTcyMjkzMmZmMjk0IFTlEUY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:25:11 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:27:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 434BC2BE for ; Wed, 18 Feb 2015 22:27:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 22BD18F4 for ; Wed, 18 Feb 2015 22:27:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMR6e3094054 for ; Wed, 18 Feb 2015 22:27:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMR6PG094053; Wed, 18 Feb 2015 22:27:06 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:27:06 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1879: Don't allocate memory for operations that do not insert Message-ID: X-Priority: 3 Thread-Topic: D1879: Don't allocate memory for operations that do not insert X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDkxYjIwNjU5MjIyMTY3Zjg4MGE2Y2JhMzdkIFTlEbo= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:27:07 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1879 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:27:53 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 051E53CA for ; Wed, 18 Feb 2015 22:27:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D67AA91C for ; Wed, 18 Feb 2015 22:27:52 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMRqBb094547 for ; Wed, 18 Feb 2015 22:27:52 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMRqqY094546; Wed, 18 Feb 2015 22:27:52 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:27:52 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1880: Prevent creation of an invalid nvlist Message-ID: <099a93331d8c8381b03e294b6e64df05@localhost.localdomain> X-Priority: 3 Thread-Topic: D1880: Prevent creation of an invalid nvlist X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NDc0MzY1NWE0OGUwMDY2MmUyOTI4NDYxZjhlIFTlEeg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:27:53 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1880 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:29:24 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F223C4B8 for ; Wed, 18 Feb 2015 22:29:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D1FAD932 for ; Wed, 18 Feb 2015 22:29:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMTOXS095704 for ; Wed, 18 Feb 2015 22:29:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMTOWX095703; Wed, 18 Feb 2015 22:29:24 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:29:24 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1882: Add macros to make code compile in kernel Message-ID: <1c0b0f6119793418f405214628489a76@localhost.localdomain> X-Priority: 3 Thread-Topic: D1882: Add macros to make code compile in kernel X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzM1ZTc3MTdjMzBlN2YyNTZkMjI0ODE2M2EwIFTlEkQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:29:25 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1882 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:30:01 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A786C709 for ; Wed, 18 Feb 2015 22:30:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 85CC194B for ; Wed, 18 Feb 2015 22:30:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMU1B0096468 for ; Wed, 18 Feb 2015 22:30:01 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMU1XA096467; Wed, 18 Feb 2015 22:30:01 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:30:01 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1883: Move libnv into the kernel and hook it into the kernel build Message-ID: <12241679d6250231e684a36a3ae87705@localhost.localdomain> X-Priority: 3 Thread-Topic: D1883: Move libnv into the kernel and hook it into the kernel build X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2Q5ZWNkMThmZjdlZTk0ZDk5ZmI5ODEzODU4IFTlEmk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:30:01 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1883 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:30:31 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8F87189B for ; Wed, 18 Feb 2015 22:30:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6DA98965 for ; Wed, 18 Feb 2015 22:30:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMUVYG097426 for ; Wed, 18 Feb 2015 22:30:31 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMUVeE097425; Wed, 18 Feb 2015 22:30:31 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:30:31 +0000 To: freebsd-net@freebsd.org From: "jfvogel (Jack Vogel)" Subject: [Differential] [Accepted] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <04df0c3e6622f988df1b37dbe8813b7d@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTlEoc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:30:31 -0000 jfvogel accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 22:55:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1BBEA157 for ; Wed, 18 Feb 2015 22:55:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E6A2FCD5 for ; Wed, 18 Feb 2015 22:55:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1IMt6Sc024035 for ; Wed, 18 Feb 2015 22:55:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1IMt6HT024034; Wed, 18 Feb 2015 22:55:06 GMT (envelope-from root) Date: Wed, 18 Feb 2015 22:55:06 +0000 To: freebsd-net@freebsd.org From: "ken (Ken Merry)" Subject: [Differential] [Updated] D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets Message-ID: <978ba84471490ba0672ab6a0c688d0b7@localhost.localdomain> X-Priority: 3 Thread-Topic: D1893: Fix special case in ip_fragment() to produce a more sensible chain of packets X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NTM5NTRkZmFhY2M5ZGMyZjg3NmZhODJjMjFlIFTlGEo= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 22:55:07 -0000 ken added a comment. It looks okay to me. The surrounding code has changed a good bit since that was committed in 2002. By the way, I think Drew Gallatin originally wrote that chunk of code, but I can't remember for sure. REVISION DETAIL https://reviews.freebsd.org/D1893 To: hselasky, pluknet, ae, np, melifaro, glebius, hrs, wollman, bryanv, rpaulo, adrian, bz, gnn, hiren, rwatson, ken Cc: freebsd-net From owner-freebsd-net@FreeBSD.ORG Wed Feb 18 23:33:06 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC954D89 for ; Wed, 18 Feb 2015 23:33:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8BB72149 for ; Wed, 18 Feb 2015 23:33:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1INX6c1063806 for ; Wed, 18 Feb 2015 23:33:06 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1INX6DZ063805; Wed, 18 Feb 2015 23:33:06 GMT (envelope-from root) Date: Wed, 18 Feb 2015 23:33:06 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <94ba4a9397228ebe2b4865991bd75a9d@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTlITI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Feb 2015 23:33:06 -0000 rstone added a comment. The primary testing that I did was to ensure that a kernel with "device zfs" would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that I could run? REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 00:38:01 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C87FB51B for ; Thu, 19 Feb 2015 00:38:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A7AC1BE8 for ; Thu, 19 Feb 2015 00:38:01 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J0c1kI034608 for ; Thu, 19 Feb 2015 00:38:01 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J0c1t2034607; Thu, 19 Feb 2015 00:38:01 GMT (envelope-from root) Date: Thu, 19 Feb 2015 00:38:01 +0000 To: freebsd-net@freebsd.org From: "will (Will Andrews)" Subject: [Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <4ea2101a196d5ce2819139f81d7887cb@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTlMGk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 00:38:01 -0000 will added a comment. >>! In D1881#9, @rstone wrote: > The primary testing that I did was to ensure that a kernel with "device zfs" would still link. However, I suppose that doesn't exclude the possibility of their being an zfs source file that is built wrong and doesn't include this header. Is there a zfs test suite that I could run? Not yet, unfortunately. It's in the zfsd project branch, but needs some work so it can be pushed into head. It'd probably be sufficient to load zfs and create pools/filesystems, and a few other basic tests. Are the userland bits covered (and tested) with this change? This is a overload (effectively), which may be pulled into the userland zfs builds. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:23:04 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C83E86CA for ; Thu, 19 Feb 2015 07:23:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A78E79C4 for ; Thu, 19 Feb 2015 07:23:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7N30f065649 for ; Thu, 19 Feb 2015 07:23:03 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7N3Kh065648; Thu, 19 Feb 2015 07:23:03 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:23:03 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1868: Make libnv headers includable from C++ Message-ID: X-Priority: 3 Thread-Topic: D1868: Make libnv headers includable from C++ X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OWRjMTRmYjQ5YzQ2YzVmY2VhMGEzM2Q1YTg1IFTlj1c= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:23:04 -0000 pjd added a comment. Looks good to me, apart from the small nit above. INLINE COMMENTS lib/libnv/nv.h:66 Could you please add an empty line after this one for consistency? Thanks. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:36:38 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5B8348C6 for ; Thu, 19 Feb 2015 07:36:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3C848AC0 for ; Thu, 19 Feb 2015 07:36:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7abXQ078273 for ; Thu, 19 Feb 2015 07:36:37 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7abrA078272; Thu, 19 Feb 2015 07:36:37 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:36:37 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1869: Tests of basic nvlist add functions Message-ID: X-Priority: 3 Thread-Topic: D1869: Tests of basic nvlist add functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmI4OTE5NjAxYjk3NGQwNTQ3YmRmODFjMzVkIFTlkoU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:36:38 -0000 pjd added a comment. I like it. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:41:47 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B9259B1 for ; Thu, 19 Feb 2015 07:41:47 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08BF7BC3 for ; Thu, 19 Feb 2015 07:41:47 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7fkIG084378 for ; Thu, 19 Feb 2015 07:41:46 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7fkZ3084366; Thu, 19 Feb 2015 07:41:46 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:41:46 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1870: Add tests for nvlist_clone Message-ID: <7fed1dc88c3e23fe64ea4dc97923e0a4@localhost.localdomain> X-Priority: 3 Thread-Topic: D1870: Add tests for nvlist_clone X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzdhNWFmMzVlZWYzY2IzNDlmMTM3MmY4ZjU0IFTlk7o= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:41:47 -0000 pjd added inline comments. INLINE COMMENTS lib/libnv/tests/nv_tests.cc:324-331 Don't you want to test the clone here? If the values wre properly copied, if there is only one element, etc.? Now you are testing the source nvlist. REVISION DETAIL https://reviews.freebsd.org/D1870 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:48:17 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A916ADFB for ; Thu, 19 Feb 2015 07:48:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A7C1C10 for ; Thu, 19 Feb 2015 07:48:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7mHkg090005 for ; Thu, 19 Feb 2015 07:48:17 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7mHf6090004; Thu, 19 Feb 2015 07:48:17 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:48:17 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1871: Add tests for nvlist_pack/unpack Message-ID: <0003c3a657fce76c8d0387e16ae6d24c@localhost.localdomain> X-Priority: 3 Thread-Topic: D1871: Add tests for nvlist_pack/unpack X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjE0ZjFmNGMwMDdhNWFlNTZiMmMyYzFlOWZhIFTllUE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:48:17 -0000 pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:49:49 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C5F61EA6 for ; Thu, 19 Feb 2015 07:49:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A59C0C25 for ; Thu, 19 Feb 2015 07:49:49 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7nnTL091217 for ; Thu, 19 Feb 2015 07:49:49 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7nnSh091216; Thu, 19 Feb 2015 07:49:49 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:49:49 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1872: Add test cases for nvlist_move_* Message-ID: X-Priority: 3 Thread-Topic: D1872: Add test cases for nvlist_move_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NmEyYzJiMjM0NjMwMTZiZjkyMmIzOThiYTIxIFTllZ0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:49:49 -0000 pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 07:58:36 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 60AAE11E for ; Thu, 19 Feb 2015 07:58:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 40BD6D04 for ; Thu, 19 Feb 2015 07:58:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J7wZKS000527 for ; Thu, 19 Feb 2015 07:58:35 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J7wZrm000524; Thu, 19 Feb 2015 07:58:35 GMT (envelope-from root) Date: Thu, 19 Feb 2015 07:58:35 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1871: Add tests for nvlist_pack/unpack Message-ID: X-Priority: 3 Thread-Topic: D1871: Add tests for nvlist_pack/unpack X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjE0ZjFmNGMwMDdhNWFlNTZiMmMyYzFlOWZhIFTll6s= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 07:58:36 -0000 pjd accepted this revision. pjd added a reviewer: pjd. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:31:58 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E6A648EE for ; Thu, 19 Feb 2015 08:31:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C5DB8121 for ; Thu, 19 Feb 2015 08:31:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8Vwof036627 for ; Thu, 19 Feb 2015 08:31:58 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8VwtL036626; Thu, 19 Feb 2015 08:31:58 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:31:58 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1873: Add tests for nvlist_take_* Message-ID: <5f94162da613a1ac0cc3055d4628a0b6@localhost.localdomain> X-Priority: 3 Thread-Topic: D1873: Add tests for nvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmVhMDUyMmU1Y2QxYzQxY2VkNWZiMDUyYmE4IFTln34= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:31:59 -0000 pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:32:54 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BEB599B4 for ; Thu, 19 Feb 2015 08:32:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9E4D712A for ; Thu, 19 Feb 2015 08:32:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8WsC3037110 for ; Thu, 19 Feb 2015 08:32:54 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8WsT2037109; Thu, 19 Feb 2015 08:32:54 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:32:54 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1874: Add tests for nvlist_free* functions Message-ID: <9b4c89ec70155df42d24a838f60adfd7@localhost.localdomain> X-Priority: 3 Thread-Topic: D1874: Add tests for nvlist_free* functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzZkMTAwZDc4MmI2OWExNDZiN2EwMDcyZjUzIFTln7Y= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:32:54 -0000 pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:37:41 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CB559A67 for ; Thu, 19 Feb 2015 08:37:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AB09F145 for ; Thu, 19 Feb 2015 08:37:41 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8bfRA040811 for ; Thu, 19 Feb 2015 08:37:41 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8bfIC040810; Thu, 19 Feb 2015 08:37:41 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:37:41 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1875: Add tests for dnv_get_* Message-ID: <0d06c92fdaf4151366f855d697e0507c@localhost.localdomain> X-Priority: 3 Thread-Topic: D1875: Add tests for dnv_get_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDdlZjc2MzE0YTE1YzZlZTQ2MDIzYTVjMjRjIFTloNU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:37:41 -0000 pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:39:42 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 71D72B09 for ; Thu, 19 Feb 2015 08:39:42 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 51B71155 for ; Thu, 19 Feb 2015 08:39:42 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8dgHp042200 for ; Thu, 19 Feb 2015 08:39:42 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8dgZr042199; Thu, 19 Feb 2015 08:39:42 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:39:42 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Accepted] D1876: Add tests for dnvlist_take_* Message-ID: X-Priority: 3 Thread-Topic: D1876: Add tests for dnvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDBkNDVlNDM2OWUwZjdhM2U4YjdkNzA1Y2Q2IFTloU4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:39:42 -0000 pjd accepted this revision. pjd added a reviewer: pjd. pjd added a comment. Looks good. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:41:43 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6963CBF2 for ; Thu, 19 Feb 2015 08:41:43 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4AB3720C for ; Thu, 19 Feb 2015 08:41:43 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8fh5s046226 for ; Thu, 19 Feb 2015 08:41:43 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8fhV9046225; Thu, 19 Feb 2015 08:41:43 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:41:43 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1877: Implement asprintf in libkern Message-ID: X-Priority: 3 Thread-Topic: D1877: Implement asprintf in libkern X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2UzMzZkZWVmYzI1ZDNmYzIzZDNmMmU4YzAxIFTlocc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:41:43 -0000 pjd added inline comments. INLINE COMMENTS sys/conf/files:3185 Please sort properly (asprintf.c goes after arc4random.c). REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:44:18 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0C681CCD for ; Thu, 19 Feb 2015 08:44:18 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DE7A8220 for ; Thu, 19 Feb 2015 08:44:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8iG09048243 for ; Thu, 19 Feb 2015 08:44:16 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8iGi2048241; Thu, 19 Feb 2015 08:44:16 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:44:16 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1878: Add function to force an nvlist into the error state Message-ID: <668084a5af0c45bc9035ced244b60a2a@localhost.localdomain> X-Priority: 3 Thread-Topic: D1878: Add function to force an nvlist into the error state X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2JhMDMyYjI3NjA3ZWFkYTcyMjkzMmZmMjk0IFTlomA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:44:18 -0000 pjd added a comment. Other that the minor nit above, it looks good. INLINE COMMENTS lib/libnv/nvlist.c:144 I'd assert that error is != 0. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 08:50:36 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D85BEE97 for ; Thu, 19 Feb 2015 08:50:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B21C226C for ; Thu, 19 Feb 2015 08:50:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1J8oaiN053983 for ; Thu, 19 Feb 2015 08:50:36 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1J8oadk053982; Thu, 19 Feb 2015 08:50:36 GMT (envelope-from root) Date: Thu, 19 Feb 2015 08:50:36 +0000 To: freebsd-net@freebsd.org From: "pjd (Pawel Jakub Dawidek)" Subject: [Differential] [Commented On] D1879: Don't allocate memory for operations that do not insert Message-ID: X-Priority: 3 Thread-Topic: D1879: Don't allocate memory for operations that do not insert X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDkxYjIwNjU5MjIyMTY3Zjg4MGE2Y2JhMzdkIFTlo9w= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 08:50:36 -0000 pjd added inline comments. INLINE COMMENTS lib/libnv/nvlist.c:276 'false' should be returned here. lib/libnv/nvlist.c:1094 'false' instead of '0'. lib/libnv/nvlist.c:1111 'false', not '0'. REVISION DETAIL https://reviews.freebsd.org/D1879 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 16:16:23 2015 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 97D8A974 for ; Thu, 19 Feb 2015 16:16:23 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E5D6AB0 for ; Thu, 19 Feb 2015 16:16:23 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1JGGNJt076051 for ; Thu, 19 Feb 2015 16:16:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 197059] network locks up with IPv6 udp traffic Date: Thu, 19 Feb 2015 16:16:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ae@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 16:16:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197059 --- Comment #4 from Andrey V. Elsukov --- Created attachment 153179 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=153179&action=edit On output path send IPV6_PATHMTU ancillary data only to the socket, that had initiated an error (In reply to Robert Watson from comment #3) > A further note on the problem: > > A good question is whether the current behaviour actually makes sense: do we > really need to notify all sockets of a change in MTU discovered by one > socket on transmit? Or can we just let the others sockets discover the > change on demand as they next try to transmit? > > (I don't take a strong view on the answer, except to point out that it would > be simpler if, as in IPv4, we didn't try to notify all sockets of the event.) I think this was implemented according to what RFC3542 says (p. 11.3):" Note that this also means an application that sets the option may receive an IPV6_MTU ancillary data item for each ICMP too big error the node receives, including such ICMP errors caused by other applications on the node." But this doesn't mean we should send these ancillary data, when message size exceeds link MTU. So, I propose the following patch for testing -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 16:33:19 2015 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AF3CE3A3 for ; Thu, 19 Feb 2015 16:33:19 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 95F46D1D for ; Thu, 19 Feb 2015 16:33:19 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1JGXJvj094532 for ; Thu, 19 Feb 2015 16:33:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 197059] network locks up with IPv6 udp traffic Date: Thu, 19 Feb 2015 16:33:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: demon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ae@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 16:33:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197059 --- Comment #5 from Dmitry Sivachenko --- I can confirm this patch fixes my problem. -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 18:37:21 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7B1652E6 for ; Thu, 19 Feb 2015 18:37:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4EB52E6B for ; Thu, 19 Feb 2015 18:37:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1JIbL3Y068699 for ; Thu, 19 Feb 2015 18:37:21 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1JIbLrG068698; Thu, 19 Feb 2015 18:37:21 GMT (envelope-from root) Date: Thu, 19 Feb 2015 18:37:21 +0000 To: freebsd-net@freebsd.org From: "hiren (hiren panchasara)" Subject: [Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <94f9319f4a55d6e4b8bc056831570dbc@localhost.localdomain> X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTmLWE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 18:37:21 -0000 hiren added a comment. Another panic from an almost *idle* box: Sanitized panic #6 Dump header from device /dev/da0s1b Architecture: amd64 Architecture Version: 2 Dump Length: 6525980672B (6223 MB) Blocksize: 512 Dumptime: Thu Feb 19 06:16:57 2015 Hostname: xxxxxxxxxxxxxxxxxx Magic: FreeBSD Kernel Dump Version String: FreeBSD 10.1-STABLE-llnw12 #0: Fri Feb 13 02:22:48 MST 2015 jason@xxxxxxxxxxxx:/usr/obj/usr/src/sys/SIXFOUR Panic String: spin lock held too long Dump Parity: 1313546413 Bounds: 0 Dump Status: good Backtrace: Reading symbols from /boot/kernel/cc_cubic.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cubic.ko.symbols Reading symbols from /boot/kernel/cc_cdg.ko.symbols...done. Loaded symbols for /boot/kernel/cc_cdg.ko.symbols Reading symbols from /boot/kernel/h_ertt.ko.symbols...done. Loaded symbols for /boot/kernel/h_ertt.ko.symbols Reading symbols from /boot/kernel/ftcp.ko...done. Loaded symbols for /boot/kernel/ftcp.ko #0 doadump (textdump=1) at pcpu.h:219 in pcpu.h (kgdb) #0 doadump (textdump=1) at pcpu.h:219 #1 0xffffffff80749c17 in kern_reboot (howto=260) at /usr/src/sys/kern/kern_shutdown.c:452 #2 0xffffffff80749ff4 in panic (fmt=) at /usr/src/sys/kern/kern_shutdown.c:759 #3 0xffffffff80735683 in _mtx_lock_spin_cookie (c=, tid=, opts=, file=, line=) at /usr/src/sys/kern/kern_mutex.c:561 #4 0xffffffff80af3fc1 in smp_tlb_shootdown (vector=246, pmap=0xffffffff81391ae0, addr1=18446742009410568192, addr2=18446742009410572288) at /usr/src/sys/amd64/amd64/mp_machdep.c:1145 #5 0xffffffff80af5d3c in pmap_invalidate_range (pmap=, sva=, eva=) at /usr/src/sys/amd64/amd64/pmap.c:1480 #6 0xffffffff807d57ef in vfs_vmio_release (bp=0xfffffe1f298bd000) at /usr/src/sys/kern/vfs_bio.c:1861 #7 0xffffffff807d622b in getnewbuf (maxsize=, gbflags=) at /usr/src/sys/kern/vfs_bio.c:2149 #8 0xffffffff807d3791 in getblk (vp=0xfffff802a158f3b0, blkno=0, size=4096, slpflag=0, slptimeo=0, flags=) at /usr/src/sys/kern/vfs_bio.c:3210 #9 0xffffffff807d41dd in breadn_flags (vp=0xfffff802a158f3b0, blkno=0, size=0, rablkno=0x0, rabsize=0x0, cnt=0, cred=0xfffffe2020f6e670, flags=0, bpp=0xfffffe2020f6e670) at /usr/src/sys/kern/vfs_bio.c:1127 #10 0xffffffff8095c84a in ffs_blkatoff (vp=0x0, offset=0, res=0x0, bpp=0xfffffe2020f6e7f8) at /usr/src/sys/ufs/ffs/ffs_subr.c:86 #11 0xffffffff8096ef92 in ufs_readdir (ap=0xfffffe2020f6e900) at /usr/src/sys/ufs/ufs/ufs_vnops.c:2177 #12 0xffffffff80c2af07 in VOP_READDIR_APV (vop=, a=) at vnode_if.c:1821 #13 0xffffffff807f9aaa in kern_getdirentries (td=0xfffff800230a8000, fd=, buf=0x8022a9000
, count=, basep=0xfffffe2020f6e980, residp=0x0) at vnode_if.h:758 #14 0xffffffff807f9888 in sys_getdirentries (td=0x0, uap=0xfffffe2020f6ea40) at /usr/src/sys/kern/vfs_syscalls.c:4030 #15 0xffffffff80b059ca in amd64_syscall (td=0xfffff800230a8000, traced=0) at subr_syscall.c:134 #16 0xffffffff80aeae3b in Xfast_syscall () at /usr/src/sys/amd64/amd64/exception.S:396 #17 0x0000000801588efa in ?? () Current language: auto; currently minimal (kgdb) @rrs This does not have your patch so we won't get any more interesting data but I wanted to show that we get the panic on almost idle boxes too. What does that tell us? REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, lstewart, jhb, kostikbel, sbruno, imp, adrian, hselasky Cc: julian, hiren, jhb, kostikbel, emaste, delphij, neel, erj, freebsd-net From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 20:49:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3FDC9EDD for ; Thu, 19 Feb 2015 20:49:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FDBBF7A for ; Thu, 19 Feb 2015 20:49:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1JKno6T012530 for ; Thu, 19 Feb 2015 20:49:50 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1JKnoZS012529; Thu, 19 Feb 2015 20:49:50 GMT (envelope-from root) Date: Thu, 19 Feb 2015 20:49:50 +0000 To: freebsd-net@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Changed Subscribers] D1869: Tests of basic nvlist add functions Message-ID: X-Priority: 3 Thread-Topic: D1869: Tests of basic nvlist add functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmI4OTE5NjAxYjk3NGQwNTQ3YmRmODFjMzVkIFTmTG4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 20:49:51 -0000 emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Thu Feb 19 21:53:00 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 93DF3CA9; Thu, 19 Feb 2015 21:53:00 +0000 (UTC) Received: from mail-pa0-x22e.google.com (mail-pa0-x22e.google.com [IPv6:2607:f8b0:400e:c03::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B63B984; Thu, 19 Feb 2015 21:53:00 +0000 (UTC) Received: by pabkx10 with SMTP id kx10so2708661pab.13; Thu, 19 Feb 2015 13:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=VOBohlgkbCpSdImO5xaCN8gCyxGFILXlek7q2elYk44=; b=D6VzpP9AyLfTaJar9JwD9MSrqQIuRNHIrMuuBxoBTJyvIeHt7//0ZI/X1cqdZYeVj+ 2eL7XuePOjYqaTe1SVmbl3bauUh+95GGQHRiZ8DGkoyOSbg7SGbOtMv7AMwu6VbJIvl+ dghjOAGx2biRjmYb6krWvcAVWWEoaIOSrQsbPxbSKVmK2o3dHTOQdF+Ygo09xG7e/gA4 Irhk+6RnBoExlDVUATFjkVoS5rLluTLRj2G41YGDggDZAe/5T83pU+H6DoI1ntH7AiP8 S4NFYkSyzTPbyKqNjCyRBSxP9EN6qRgK+V12np27PnTi+49PFLKU49rhXspG15TMLPvP JKcg== X-Received: by 10.68.65.36 with SMTP id u4mr10911317pbs.91.1424382779973; Thu, 19 Feb 2015 13:52:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.70.89.108 with HTTP; Thu, 19 Feb 2015 13:52:19 -0800 (PST) In-Reply-To: References: <201502170150.t1H1ouxM020621@mail.karels.net> From: Eric Joyner Date: Thu, 19 Feb 2015 13:52:19 -0800 Message-ID: Subject: Re: Adding new media types to if_media.h To: Adrian Chadd Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-net@freebsd.org" , mike@karels.net, "freebsd-arch@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Feb 2015 21:53:00 -0000 It does look good! We already have at least a half-dozen new media types to add. --- - Eric Joyner On Tue, Feb 17, 2015 at 9:26 AM, Adrian Chadd wrote: > Looks good to me. > > Thanks for doing this! > > > -a > > > On 16 February 2015 at 17:50, Mike Karels wrote: > > On Feb 9, gnn wrote: > > > >> On 8 Feb 2015, at 22:41, Mike Karels wrote: > > > >> > Sorry to reply to a thread after such a long delay, but I think it is > >> > unresolved, and needs more discussion. I'd like to elaborate a bit on > >> > my goals and proposal. I believe Adrian has newer thoughts than have > >> > been > >> > circulated here as well. > >> > > >> > The last message(s) have gone to freebsd-arch and freebsd-net. If > >> > someone > >> > wants to pick one, we could consolidate, but this seems relevant to > >> > both. > >> > > >> > I'm going to top-post to try to summarize and extend the discussion, > >> > but the > >> > preceding emails follow for reference. > >> > > >> > To recap: the existing if_media interface is running out of steam, at > >> > least > >> > in that the "Media variant" field, with 5 bits, is going to be > >> > insufficient > >> > to express existing 40 Gb/s variants. The if_media media type is a > >> > 32-bit > >> > int with a bunch of sub-fields for type (e.g. Ethernet), > >> > subtype/variant > >> > (e.g. 10baseT, 10base5, 1000baseT, etc), flags, and some MII-related > >> > fields. > >> > > >> > I made a proposal to extend the interface in a small way, specifically > >> > to > >> > replace the "media word" with a 64-bit int that is mostly the same, > >> > but > >> > has a new, larger variant/subtype field. The main reason for this > >> > proposal > >> > is to maintain the driver KPI (glimpse showed me 240 inclusions of > >> > if_media.h > >> > in the kernel in 8.2). That interface includes an initialization > >> > using a > >> > scalar value of fields ORed with each other. It would also be easy to > >> > preserve a 32-bit user-level API/ABI that can express most of the > >> > current > >> > state, with a subtype/variant field value reserved for "other" (there > >> > is > >> > already one for "unknown", but that is not quite the same). fwiw, I > >> > found 45 references to this user-level API in our tree, including both > >> > base and "ports"-type software, which includes libpcap, snmpd, > >> > dhclient, > >> > quagga, xorp, atm, devd, and rtsold, which argues for a > >> > backward-compatible > >> > API/ABI as well as a more-complete current interface for ifconfig at > >> > least. > >> > > >> > More generally, I see two problems with the existing if_media > >> > interface: > >> > > >> > 1. It doesn't have enough bits for all the fields, in particular, > >> > variant/ > >> > subtype for Ethernet. That is the immediate issue. > >> > > >> > 2. The interface is not sufficiently generic; it was designed around > >> > Ethernet > >> > including MII, token ring, FDDI, and a few other interface types. > >> > Some of > >> > the fields like "instance" are primarily for MII as far as I know, and > >> > are > >> > basically unused. It is definitely not sufficient for 802.11, which > >> > has > >> > rolled its own interfaces. > >> > > >> > To solve the second problem, I think the right approach would be to > >> > reduce > >> > this interface to a truly generic one, such as media type (e.g. > >> > Ethernet), > >> > generic flags, and perhaps generic status. Then there should be a > >> > separate > >> > media-specific interface for each type, such as Ethernet and 802.11. > >> > To a > >> > small extent, we already have that. Solving the second, more general > >> > problem, > >> > requires a whole new driver KPI that will require surgery to every > >> > driver, > >> > which is not an exercise that I would consider. > >> > > >> > Using a separate int for each existing field, as proposed, would break > >> > the > >> > driver KPI, but would not really make the interface generic. Trying > >> > to > >> > make a single interface with the union of all network interface > >> > requirements > >> > seems like a bad idea to me (we failed last time; the "we" is BSDi, > >> > where > >> > I was the architect when this interface was first designed). (No, I > >> > didn't > >> > design this interface.) > >> > > >> > Solving the first problem only, I think it is preferable to preserve a > >> > compatible driver KPI, which means using a scalar value encoding what > >> > is > >> > necessary. Although that interface is rather Ethernet-centric, that > >> > is > >> > really what it is used for. > >> > > >> > An additional, selfish goal is to make it easy to back-port drivers > >> > using > >> > the new interface to older versions (which I am quite likely to do). > >> > Preserving the KPI and general user API will be highly useful there. > >> > I'd be likely to do a 11-style version of ifconfig personally, but it > >> > might not be difficult to do in a more general way. > >> > > >> > I am willing to do a prototype for -current for evaluation. > >> > > >> > Comments, alternatives, ? > > > >> I agree with your statements above and I'd like to see the prototype. > > > > Well, I developed the prototype as I had planned, using a 64-bit media > > word, and found that I got about 100 files in GENERIC that didn't > compile; > > they attempted to store "media words" in an int. My kingdom for a > typedef. > > That didn't meet my goal of KPI compatibility, so I went to Plan B. > > > > Plan B is to steal an unused bit (RFU) to indicate an "extended" media > > type. I then used the variant/subtype field to store the extended type. > > Effectively, the previously unused bit doubles the effective size of the > > subtype field. Given that the previous 5-bit field lasted us 18 years, > > I figured that doubling it would last a while. I also changed the > > SIOGGIFMEDIA ioctl, splitting it for binary compatibility; extended > > types are all mapped to IFM_OTHER (31) using the old interface, but > > are visible using the new one. > > > > With these changes, I modified one driver (vtnet) to use an extended > type, > > and the rest of GENERIC is happy. The changes to ifconfig are also > fairly > > small. The patch is appended, where email programs will screw it up, > > or at ftp://ftp.karels.net/outgoing/if_media.patch. > > > > The VFAST subtype is a throw-away for testing. > > > > This seems like a reasonably pragmatic change to support the new 40 Gb/s > > media types until someone wants to design an improved but non-backward- > > compatible interface. I think it meets the goal of suitability for > > back-porting; it could be MFCed. > > > > Mike > > > > Index: sys/net/if_media.h > > =================================================================== > > --- sys/net/if_media.h (revision 278804) > > +++ sys/net/if_media.h (working copy) > > @@ -120,15 +120,29 @@ > > * 5-7 Media type > > * 8-15 Type specific options > > * 16-18 Mode (for multi-mode devices) > > - * 19 RFU > > + * 19 "extended" bit for media variant > > * 20-27 Shared (global) options > > * 28-31 Instance > > */ > > > > /* > > + * As we have used all of the original values for the media variant > (subtype) > > + * for Ethernet, extended subtypes have been added, marked with > XSUBTYPE, > > + * which is effectively the "high bit" of the media variant (subtype) > field. > > + * IFM_OTHER (the highest basic type) is reserved to indicate use of an > > + * extended type when using an old SIOCGIFMEDIA operation. This is true > > + * for all media types, not just Ethernet. > > + */ > > +#define XSUBTYPE 0x80000 /* extended variant high > bit */ > > +#define _X(var) ((var) | XSUBTYPE) /* extended > variant */ > > +#define IFM_OTHER 31 /* Other: some > extended type */ > > +#define OMEDIA(var) (((var) & XSUBTYPE) ? IFM_OTHER : (var)) > > + > > +/* > > * Ethernet > > */ > > #define IFM_ETHER 0x00000020 > > +/* NB: 0,1,2 are auto, manual, none defined below */ > > #define IFM_10_T 3 /* 10BaseT - RJ45 */ > > #define IFM_10_2 4 /* 10Base2 - Thinnet */ > > #define IFM_10_5 5 /* 10Base5 - AUI */ > > @@ -156,11 +170,17 @@ > > #define IFM_40G_CR4 27 /* 40GBase-CR4 */ > > #define IFM_40G_SR4 28 /* 40GBase-SR4 */ > > #define IFM_40G_LR4 29 /* 40GBase-LR4 */ > > +#define IFM_AVAIL30 30 /* available */ > > +/* #define IFM_OTHER 31 Other: some extended type */ > > +/* note 31 is the max! */ > > + > > +/* Extended variants/subtypes */ > > +#define IFM_VFAST _X(0) /* test "V.fast" */ > > +/* note _X(31) is the max! */ > > /* > > * Please update ieee8023ad_lacp.c:lacp_compose_key() > > * after adding new Ethernet media types. > > */ > > -/* note 31 is the max! */ > > > > #define IFM_ETH_MASTER 0x00000100 /* master mode > (1000baseT) */ > > #define IFM_ETH_RXPAUSE 0x00000200 /* receive PAUSE frames > */ > > @@ -170,6 +190,7 @@ > > * Token ring > > */ > > #define IFM_TOKEN 0x00000040 > > +/* NB: 0,1,2 are auto, manual, none defined below */ > > #define IFM_TOK_STP4 3 /* Shielded twisted pair > 4m - DB9 */ > > #define IFM_TOK_STP16 4 /* Shielded twisted pair > 16m - DB9 */ > > #define IFM_TOK_UTP4 5 /* Unshielded twisted > pair 4m - RJ45 */ > > @@ -187,6 +208,7 @@ > > * FDDI > > */ > > #define IFM_FDDI 0x00000060 > > +/* NB: 0,1,2 are auto, manual, none defined below */ > > #define IFM_FDDI_SMF 3 /* Single-mode fiber */ > > #define IFM_FDDI_MMF 4 /* Multi-mode fiber */ > > #define IFM_FDDI_UTP 5 /* CDDI / UTP */ > > @@ -220,6 +242,7 @@ > > #define IFM_IEEE80211_OFDM27 23 /* OFDM 27Mbps */ > > /* NB: not enough bits to express MCS fully */ > > #define IFM_IEEE80211_MCS 24 /* HT MCS rate */ > > +/* #define IFM_OTHER 31 Other: some extended type */ > > > > #define IFM_IEEE80211_ADHOC 0x00000100 /* Operate in > Adhoc mode */ > > #define IFM_IEEE80211_HOSTAP 0x00000200 /* Operate in > Host AP mode */ > > @@ -241,6 +264,7 @@ > > * ATM > > */ > > #define IFM_ATM 0x000000a0 > > +/* NB: 0,1,2 are auto, manual, none defined below */ > > #define IFM_ATM_UNKNOWN 3 > > #define IFM_ATM_UTP_25 4 > > #define IFM_ATM_TAXI_100 5 > > @@ -277,7 +301,7 @@ > > * Masks > > */ > > #define IFM_NMASK 0x000000e0 /* Network type */ > > -#define IFM_TMASK 0x0000001f /* Media sub-type */ > > +#define IFM_TMASK 0x0008001f /* Media sub-type */ > > #define IFM_IMASK 0xf0000000 /* Instance */ > > #define IFM_ISHIFT 28 /* Instance shift */ > > #define IFM_OMASK 0x0000ff00 /* Type specific options > */ > > @@ -372,6 +396,7 @@ > > { IFM_40G_CR4, "40Gbase-CR4" }, \ > > { IFM_40G_SR4, "40Gbase-SR4" }, \ > > { IFM_40G_LR4, "40Gbase-LR4" }, \ > > + { IFM_VFAST, "V.fast" }, \ > > { 0, NULL }, \ > > } > > > > @@ -603,6 +628,7 @@ > > { IFM_AUTO, "autoselect" }, \ > > { IFM_MANUAL, "manual" }, \ > > { IFM_NONE, "none" }, \ > > + { IFM_OTHER, "other" }, \ > > { 0, NULL }, \ > > } > > > > @@ -673,6 +699,7 @@ > > { IFM_ETHER | IFM_40G_CR4, IF_Gbps(40ULL) }, \ > > { IFM_ETHER | IFM_40G_SR4, IF_Gbps(40ULL) }, \ > > { IFM_ETHER | IFM_40G_LR4, IF_Gbps(40ULL) }, \ > > + { IFM_ETHER | IFM_VFAST, IF_Gbps(40ULL) }, \ > > \ > > { IFM_TOKEN | IFM_TOK_STP4, IF_Mbps(4) }, \ > > { IFM_TOKEN | IFM_TOK_STP16, IF_Mbps(16) }, \ > > Index: sys/sys/sockio.h > > =================================================================== > > --- sys/sys/sockio.h (revision 278810) > > +++ sys/sys/sockio.h (working copy) > > @@ -128,5 +128,6 @@ > > #define SIOCGIFGROUP _IOWR('i', 136, struct ifgroupreq) /* > get ifgroups */ > > #define SIOCDIFGROUP _IOW('i', 137, struct ifgroupreq) /* > delete ifgroup */ > > #define SIOCGIFGMEMB _IOWR('i', 138, struct ifgroupreq) /* > get members */ > > +#define SIOCGIFXMEDIA _IOWR('i', 139, struct ifmediareq) /* > get net xmedia */ > > > > #endif /* !_SYS_SOCKIO_H_ */ > > Index: sys/net/if.c > > =================================================================== > > --- sys/net/if.c (revision 278749) > > +++ sys/net/if.c (working copy) > > @@ -2561,6 +2561,7 @@ > > case SIOCGIFPSRCADDR: > > case SIOCGIFPDSTADDR: > > case SIOCGIFMEDIA: > > + case SIOCGIFXMEDIA: > > case SIOCGIFGENERIC: > > if (ifp->if_ioctl == NULL) > > return (EOPNOTSUPP); > > Index: sys/net/if_media.c > > =================================================================== > > --- sys/net/if_media.c (revision 278804) > > +++ sys/net/if_media.c (working copy) > > @@ -67,7 +67,9 @@ > > static struct ifmedia_entry *ifmedia_match(struct ifmedia *ifm, > > int flags, int mask); > > > > +#define IFMEDIA_DEBUG > > #ifdef IFMEDIA_DEBUG > > +#include > > int ifmedia_debug = 0; > > SYSCTL_INT(_debug, OID_AUTO, ifmedia, CTLFLAG_RW, &ifmedia_debug, > > 0, "if_media debugging msgs"); > > @@ -271,6 +273,7 @@ > > * Get list of available media and current media on interface. > > */ > > case SIOCGIFMEDIA: > > + case SIOCGIFXMEDIA: > > { > > struct ifmedia_entry *ep; > > int *kptr, count; > > @@ -278,8 +281,13 @@ > > > > kptr = NULL; /* XXX gcc */ > > > > - ifmr->ifm_active = ifmr->ifm_current = ifm->ifm_cur ? > > - ifm->ifm_cur->ifm_media : IFM_NONE; > > + if (cmd == SIOCGIFMEDIA) { > > + ifmr->ifm_active = ifmr->ifm_current = > ifm->ifm_cur ? > > + OMEDIA(ifm->ifm_cur->ifm_media) : IFM_NONE; > > + } else { > > + ifmr->ifm_active = ifmr->ifm_current = > ifm->ifm_cur ? > > + ifm->ifm_cur->ifm_media : IFM_NONE; > > + } > > ifmr->ifm_mask = ifm->ifm_mask; > > ifmr->ifm_status = 0; > > (*ifm->ifm_status)(ifp, ifmr); > > @@ -317,7 +325,10 @@ > > ep = LIST_FIRST(&ifm->ifm_list); > > for (; ep != NULL && count < ifmr->ifm_count; > > ep = LIST_NEXT(ep, ifm_list), count++) > > - kptr[count] = ep->ifm_media; > > + if (cmd == SIOCGIFMEDIA) > > + kptr[count] = > OMEDIA(ep->ifm_media); > > + else > > + kptr[count] = ep->ifm_media; > > > > if (ep != NULL) > > error = E2BIG; /* oops! */ > > @@ -505,7 +516,7 @@ > > printf("\n"); > > return; > > } > > - printf(desc->ifmt_string); > > + printf("%s", desc->ifmt_string); > > > > /* Any mode. */ > > for (desc = ttos->modes; desc && desc->ifmt_string != NULL; > desc++) > > > > Index: sys/dev/virtio/network/if_vtnet.c > > =================================================================== > > --- sys/dev/virtio/network/if_vtnet.c (revision 278749) > > +++ sys/dev/virtio/network/if_vtnet.c (working copy) > > @@ -938,6 +938,7 @@ > > ifmedia_init(&sc->vtnet_media, IFM_IMASK, vtnet_ifmedia_upd, > > vtnet_ifmedia_sts); > > ifmedia_add(&sc->vtnet_media, VTNET_MEDIATYPE, 0, NULL); > > + ifmedia_add(&sc->vtnet_media, IFM_ETHER | IFM_VFAST, 0, NULL); > > ifmedia_set(&sc->vtnet_media, VTNET_MEDIATYPE); > > > > /* Read (or generate) the MAC address for the adapter. */ > > @@ -1103,6 +1104,7 @@ > > > > case SIOCSIFMEDIA: > > case SIOCGIFMEDIA: > > + case SIOCGIFXMEDIA: > > error = ifmedia_ioctl(ifp, ifr, &sc->vtnet_media, cmd); > > break; > > Index: sbin/ifconfig/ifmedia.c > > =================================================================== > > --- sbin/ifconfig/ifmedia.c (revision 278749) > > +++ sbin/ifconfig/ifmedia.c (working copy) > > @@ -109,11 +109,17 @@ > > { > > struct ifmediareq ifmr; > > int *media_list, i; > > + int xmedia = 1; > > > > (void) memset(&ifmr, 0, sizeof(ifmr)); > > (void) strncpy(ifmr.ifm_name, name, sizeof(ifmr.ifm_name)); > > > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > > + /* > > + * Check if interface supports extended media types. > > + */ > > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > > + xmedia = 0; > > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) { > > /* > > * Interface doesn't support SIOC{G,S}IFMEDIA. > > */ > > @@ -130,8 +136,13 @@ > > err(1, "malloc"); > > ifmr.ifm_ulist = media_list; > > > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > > - err(1, "SIOCGIFMEDIA"); > > + if (xmedia) { > > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)&ifmr) < 0) > > + err(1, "SIOCGIFXMEDIA"); > > + } else { > > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)&ifmr) < 0) > > + err(1, "SIOCGIFMEDIA"); > > + } > > > > printf("\tmedia: "); > > print_media_word(ifmr.ifm_current, 1); > > @@ -194,6 +205,7 @@ > > { > > static struct ifmediareq *ifmr = NULL; > > int *mwords; > > + int xmedia = 1; > > > > if (ifmr == NULL) { > > ifmr = (struct ifmediareq *)malloc(sizeof(struct > ifmediareq)); > > @@ -213,7 +225,10 @@ > > * the current media type and the top-level type. > > */ > > > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) { > > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) { > > + xmedia = 0; > > + } > > + if (xmedia == 0 && ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) > < 0) { > > err(1, "SIOCGIFMEDIA"); > > } > > > > @@ -225,8 +240,13 @@ > > err(1, "malloc"); > > > > ifmr->ifm_ulist = mwords; > > - if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > > - err(1, "SIOCGIFMEDIA"); > > + if (xmedia) { > > + if (ioctl(s, SIOCGIFXMEDIA, (caddr_t)ifmr) < 0) > > + err(1, "SIOCGIFXMEDIA"); > > + } else { > > + if (ioctl(s, SIOCGIFMEDIA, (caddr_t)ifmr) < 0) > > + err(1, "SIOCGIFMEDIA"); > > + } > > } > > > > return ifmr; > > _______________________________________________ > > freebsd-net@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-net > > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:56:52 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B2920551 for ; Fri, 20 Feb 2015 00:56:52 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 93027F80 for ; Fri, 20 Feb 2015 00:56:52 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0uqln076810 for ; Fri, 20 Feb 2015 00:56:52 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0uq5q076809; Fri, 20 Feb 2015 00:56:52 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:56:52 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1876: Add tests for dnvlist_take_* Message-ID: <179e9651412562696cad6af367eee5c1@localhost.localdomain> X-Priority: 3 Thread-Topic: D1876: Add tests for dnvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDBkNDVlNDM2OWUwZjdhM2U4YjdkNzA1Y2Q2IFTmhlQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:56:52 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1876 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:57:07 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B5D715E1 for ; Fri, 20 Feb 2015 00:57:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 969AFF8C for ; Fri, 20 Feb 2015 00:57:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0v7c9077052 for ; Fri, 20 Feb 2015 00:57:07 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0v7C5077051; Fri, 20 Feb 2015 00:57:07 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:57:07 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1875: Add tests for dnv_get_* Message-ID: <241b455cf84c59a6e9a0362d34f0de52@localhost.localdomain> X-Priority: 3 Thread-Topic: D1875: Add tests for dnv_get_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MDdlZjc2MzE0YTE1YzZlZTQ2MDIzYTVjMjRjIFTmhmM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:57:07 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1875 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:57:23 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9DE6A674 for ; Fri, 20 Feb 2015 00:57:23 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7DF6EF96 for ; Fri, 20 Feb 2015 00:57:23 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0vNBi077238 for ; Fri, 20 Feb 2015 00:57:23 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0vNIG077237; Fri, 20 Feb 2015 00:57:23 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:57:23 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1874: Add tests for nvlist_free* functions Message-ID: X-Priority: 3 Thread-Topic: D1874: Add tests for nvlist_free* functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzZkMTAwZDc4MmI2OWExNDZiN2EwMDcyZjUzIFTmhnM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:57:23 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1874 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:57:45 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8E5AC70A for ; Fri, 20 Feb 2015 00:57:45 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6F19CFA0 for ; Fri, 20 Feb 2015 00:57:45 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0vjwD077434 for ; Fri, 20 Feb 2015 00:57:45 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0vjmN077433; Fri, 20 Feb 2015 00:57:45 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:57:45 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1873: Add tests for nvlist_take_* Message-ID: <12c7db745ef5d8b7b88be7312493e140@localhost.localdomain> X-Priority: 3 Thread-Topic: D1873: Add tests for nvlist_take_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmVhMDUyMmU1Y2QxYzQxY2VkNWZiMDUyYmE4IFTmhok= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:57:45 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1873 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:58:24 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DE794832 for ; Fri, 20 Feb 2015 00:58:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE278FAD for ; Fri, 20 Feb 2015 00:58:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0wOQI077839 for ; Fri, 20 Feb 2015 00:58:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0wOUh077838; Fri, 20 Feb 2015 00:58:24 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:58:24 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1871: Add tests for nvlist_pack/unpack Message-ID: <36631de84ab81255c86c19d28c1f0853@localhost.localdomain> X-Priority: 3 Thread-Topic: D1871: Add tests for nvlist_pack/unpack X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZjE0ZjFmNGMwMDdhNWFlNTZiMmMyYzFlOWZhIFTmhrA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:58:25 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1871 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 00:58:46 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BB95E8CA for ; Fri, 20 Feb 2015 00:58:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9AD30FBA for ; Fri, 20 Feb 2015 00:58:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K0wklE078250 for ; Fri, 20 Feb 2015 00:58:46 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K0wkSN078249; Fri, 20 Feb 2015 00:58:46 GMT (envelope-from root) Date: Fri, 20 Feb 2015 00:58:46 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1872: Add test cases for nvlist_move_* Message-ID: <868cd268624780227c7b2b8106d262f7@localhost.localdomain> X-Priority: 3 Thread-Topic: D1872: Add test cases for nvlist_move_* X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NmEyYzJiMjM0NjMwMTZiZjkyMmIzOThiYTIxIFTmhsY= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 00:58:46 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1872 To: rstone, jfvogel, pjd Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 01:09:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6747BD13 for ; Fri, 20 Feb 2015 01:09:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48398177 for ; Fri, 20 Feb 2015 01:09:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K19WVN092948 for ; Fri, 20 Feb 2015 01:09:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K19WA6092947; Fri, 20 Feb 2015 01:09:32 GMT (envelope-from root) Date: Fri, 20 Feb 2015 01:09:32 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1868: Make libnv headers includable from C++ Message-ID: X-Priority: 3 Thread-Topic: D1868: Make libnv headers includable from C++ X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OWRjMTRmYjQ5YzQ2YzVmY2VhMGEzM2Q1YTg1IFTmiUw= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 01:09:32 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1868 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 01:16:08 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F2A0D2BC for ; Fri, 20 Feb 2015 01:16:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C485B27C for ; Fri, 20 Feb 2015 01:16:07 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K1G7Z5000527 for ; Fri, 20 Feb 2015 01:16:07 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K1G7tI000526; Fri, 20 Feb 2015 01:16:07 GMT (envelope-from root) Date: Fri, 20 Feb 2015 01:16:07 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1869: Tests of basic nvlist add functions Message-ID: <1a9b686157fb86e8db0fee2616b9f468@localhost.localdomain> X-Priority: 3 Thread-Topic: D1869: Tests of basic nvlist add functions X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YmI4OTE5NjAxYjk3NGQwNTQ3YmRmODFjMzVkIFTmitc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 01:16:08 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1869 To: rstone, jfvogel Cc: emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 01:22:54 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 108173A1 for ; Fri, 20 Feb 2015 01:22:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E5396358 for ; Fri, 20 Feb 2015 01:22:53 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K1Mrg2008778 for ; Fri, 20 Feb 2015 01:22:53 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K1Mr5a008777; Fri, 20 Feb 2015 01:22:53 GMT (envelope-from root) Date: Fri, 20 Feb 2015 01:22:53 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1878: Add function to force an nvlist into the error state Message-ID: <72128c60d6873cc312bfc2d2851d41ef@localhost.localdomain> X-Priority: 3 Thread-Topic: D1878: Add function to force an nvlist into the error state X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2JhMDMyYjI3NjA3ZWFkYTcyMjkzMmZmMjk0IFTmjG0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 01:22:54 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1878 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 01:24:40 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 87AAC44F for ; Fri, 20 Feb 2015 01:24:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6923436D for ; Fri, 20 Feb 2015 01:24:40 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K1OeUr010084 for ; Fri, 20 Feb 2015 01:24:40 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K1OeKo010083; Fri, 20 Feb 2015 01:24:40 GMT (envelope-from root) Date: Fri, 20 Feb 2015 01:24:40 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1877: Implement asprintf in libkern Message-ID: <87ef1672fa4bf714d502400987644c51@localhost.localdomain> X-Priority: 3 Thread-Topic: D1877: Implement asprintf in libkern X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2UzMzZkZWVmYzI1ZDNmYzIzZDNmMmU4YzAxIFTmjNg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 01:24:40 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1877 To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 01:28:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5D3715BA for ; Fri, 20 Feb 2015 01:28:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3CCB03B0 for ; Fri, 20 Feb 2015 01:28:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K1SJc2012999 for ; Fri, 20 Feb 2015 01:28:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K1SJeg012998; Fri, 20 Feb 2015 01:28:19 GMT (envelope-from root) Date: Fri, 20 Feb 2015 01:28:19 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Updated, 120 lines] D1870: Add tests for nvlist_clone Message-ID: <3c8d91e6bbde81b25105c5b1b6a24f95@localhost.localdomain> X-Priority: 3 Thread-Topic: D1870: Add tests for nvlist_clone X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzdhNWFmMzVlZWYzY2IzNDlmMTM3MmY4ZjU0IFTmjbM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 01:28:20 -0000 rstone updated this revision to Diff 3862. rstone added a comment. This revision now requires review to proceed. Fix the test case to actually test the clone CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1870?vs=3813&id=3862 BRANCH review_D1870 REVISION DETAIL https://reviews.freebsd.org/D1870 AFFECTED FILES lib/libnv/tests/nv_tests.cc To: rstone, jfvogel Cc: freebsd-net, pjd From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 02:06:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 58C74F80 for ; Fri, 20 Feb 2015 02:06:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 15227A0C for ; Fri, 20 Feb 2015 02:06:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K26JZP053102 for ; Fri, 20 Feb 2015 02:06:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K26JmZ053101; Fri, 20 Feb 2015 02:06:19 GMT (envelope-from root) Date: Fri, 20 Feb 2015 02:06:19 +0000 To: freebsd-net@freebsd.org From: "wblock (Warren Block)" Subject: [Differential] [Commented On] D1438: FreeBSD callout rewrite and cleanup Message-ID: <29ec736ba26cbbc4fd86895a120c57df@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTmlps= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 02:06:20 -0000 wblock added inline comments. INLINE COMMENTS share/man/man9/timeout.9:98 Missing the word "if". share/man/man9/timeout.9:126 British->American: s/behaviour/behavior/ share/man/man9/timeout.9:140 Add comma after "zero". share/man/man9/timeout.9:295 Use "cannot". "can not" with a space means "not doing it is allowed". share/man/man9/timeout.9:308 s/timeouts./timeouts are needed./ share/man/man9/timeout.9:362 s/by/by the/ share/man/man9/timeout.9:364 s/CPU/the CPU/ share/man/man9/timeout.9:370 If this means "CPU selection cannot be changed while the callout subsystem is processing the callback for completion.", then s/can not/cannot/. share/man/man9/timeout.9:378 s/by the/by/ Either "given by the func argument will" or "given by func will". The second is less wordy, REVISION DETAIL https://reviews.freebsd.org/D1438 To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 03:34:02 2015 Return-Path: Delivered-To: freebsd-net@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E5A44D0A for ; Fri, 20 Feb 2015 03:34:02 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CB75A632 for ; Fri, 20 Feb 2015 03:34:02 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K3Y2Ix075800 for ; Fri, 20 Feb 2015 03:34:02 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 194314] [ixgbe] driver makes some dangerous assumptions with struct mbuf sizing with IXGBE_RX_COPY_LEN Date: Fri, 20 Feb 2015 03:34:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: jfv@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 03:34:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194314 Garrett Cooper,425-314-3911 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erj@freebsd.org Assignee|freebsd-net@FreeBSD.org |jfv@FreeBSD.org --- Comment #16 from Garrett Cooper,425-314-3911 --- Ping. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 03:55:15 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 77F182D1 for ; Fri, 20 Feb 2015 03:55:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 57CBF868 for ; Fri, 20 Feb 2015 03:55:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K3tFHn073044 for ; Fri, 20 Feb 2015 03:55:15 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K3tFAv073035; Fri, 20 Feb 2015 03:55:15 GMT (envelope-from root) Date: Fri, 20 Feb 2015 03:55:15 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTmsCM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 03:55:15 -0000 rstone added a comment. Ok, I did a full buildworld/buildkernel (with device zfs in my kernel config) and installed it into a couple of zfs. I tested creating a zpool out of a mfs disk, creating filesystems, setting some properties, doing a git clone into a file system, and then doing a zfs send of the result from one vm to the problem. No problems cropped up. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 03:57:17 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7FE403B0 for ; Fri, 20 Feb 2015 03:57:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 60338888 for ; Fri, 20 Feb 2015 03:57:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K3vHYE074641 for ; Fri, 20 Feb 2015 03:57:17 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K3vHGd074640; Fri, 20 Feb 2015 03:57:17 GMT (envelope-from root) Date: Fri, 20 Feb 2015 03:57:17 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Commented On] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <1df9aa23b0177cb3377c751d428239bb@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTmsJ0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 03:57:17 -0000 rstone added a comment. Err, that was supposed to be "installed it into a couple of *VMs*" REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 04:14:05 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC6F973D for ; Fri, 20 Feb 2015 04:14:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8B8FFA28 for ; Fri, 20 Feb 2015 04:14:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K4E5Pv092715 for ; Fri, 20 Feb 2015 04:14:05 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K4E5cp092714; Fri, 20 Feb 2015 04:14:05 GMT (envelope-from root) Date: Fri, 20 Feb 2015 04:14:05 +0000 To: freebsd-net@freebsd.org From: "will (Will Andrews)" Subject: [Differential] [Accepted] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTmtI0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 04:14:05 -0000 will accepted this revision. will added a reviewer: will. will added a comment. Ok, LGTM. Thanks for your effort! REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel, will Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 09:09:21 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C1A98D18 for ; Fri, 20 Feb 2015 09:09:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B882AC5 for ; Fri, 20 Feb 2015 09:09:21 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1K99L7M027837 for ; Fri, 20 Feb 2015 09:09:21 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1K99LN3027836; Fri, 20 Feb 2015 09:09:21 GMT (envelope-from root) Date: Fri, 20 Feb 2015 09:09:21 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 2, 449 lines] D1438: FreeBSD callout rewrite and cleanup Message-ID: X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTm+cE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 09:09:21 -0000 hselasky updated this revision to Diff 3868. hselasky added a comment. Integrate manual page comments from Warren Block. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3840&id=3868 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/man/man9/timeout.9 sys/kern/init_main.c sys/kern/kern_condvar.c sys/kern/kern_lock.c sys/kern/kern_switch.c sys/kern/kern_synch.c sys/kern/kern_thread.c sys/kern/kern_timeout.c sys/kern/subr_sleepqueue.c sys/ofed/include/linux/completion.h sys/sys/_callout.h sys/sys/callout.h sys/sys/proc.h To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 14:10:38 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0CC12785 for ; Fri, 20 Feb 2015 14:10:38 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DFC1BEEA for ; Fri, 20 Feb 2015 14:10:37 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1KEAbD7067793 for ; Fri, 20 Feb 2015 14:10:37 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1KEAbie067790; Fri, 20 Feb 2015 14:10:37 GMT (envelope-from root) Date: Fri, 20 Feb 2015 14:10:37 +0000 To: freebsd-net@freebsd.org From: "rstone (Ryan Stone)" Subject: [Differential] [Closed] D1881: Allow Illumos code to co-exist with nv(9) Message-ID: <6f177f9c8b165d94a26ddca28b9b8fdb@localhost.localdomain> X-Priority: 3 Thread-Topic: D1881: Allow Illumos code to co-exist with nv(9) X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: OGQwMzFkNjQ5NDRkZTRmM2I0ZmU5NDZhMGJmIFTnQF0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 14:10:38 -0000 rstone closed this revision. REVISION DETAIL https://reviews.freebsd.org/D1881 To: rstone, jfvogel, will Cc: will, emaste, pjd, freebsd-net From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 17:13:51 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 68511704 for ; Fri, 20 Feb 2015 17:13:51 +0000 (UTC) Received: from mail-ig0-x22a.google.com (mail-ig0-x22a.google.com [IPv6:2607:f8b0:4001:c05::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 24752AB0 for ; Fri, 20 Feb 2015 17:13:51 +0000 (UTC) Received: by mail-ig0-f170.google.com with SMTP id l13so8412421iga.1 for ; Fri, 20 Feb 2015 09:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=Z6cjq1SL94ivXPsMTMFKTOu3H0AZ7xCMjJdUFcmv38s=; b=MID4W0Vvp0pcUARCx9GlU6yrLHG1Och9lPvmDpuPJNGVJM+F1RgnH/7wQEMABvB92P MmmkeiVt/c2YNel8aw3cEB3UTpoGauVZ05k+CMUEBDMPiXB/VgmitPKhxl9EbgBOVFvf 0Zf0xxUj6B/L6Ol4+r2eewyzDwg/LudhY21MGVbDu8h02mGp1LYukk4vsVNGKBa8i2rH pCbWJpjwS1YWzxU46VfHg9o/E2/dKcDpGinDd7y/95QHIW9ozJmy9NWQVyoOWNY/tgzH Sz6n4W9W50GeJFR/+UmXxMs1F0WODeeKVJi3TUbTalTEhL7QbyuWZtJYfunKNPl4+cZ1 eK6Q== X-Received: by 10.107.137.101 with SMTP id l98mr6121254iod.23.1424452430455; Fri, 20 Feb 2015 09:13:50 -0800 (PST) Received: from [10.1.69.81] (gs-sv-1-49-ac1.gsfc.nasa.gov. [198.119.56.43]) by mx.google.com with ESMTPSA id t41sm17290785ioi.0.2015.02.20.09.13.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Feb 2015 09:13:46 -0800 (PST) Message-ID: <54E76B47.8080907@gmail.com> Date: Fri, 20 Feb 2015 12:13:43 -0500 From: John Jasen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Jack Vogel Subject: Re: FreeBSD 10.1: Intel dual port 10GbE card (82599EB) second port not present? References: <54DCB8F2.5090809@gmail.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 17:13:51 -0000 I'll also note this seems to be somewhat unpredictable. I installed a dual port intel 10GbE card into one of the systems, I have not plugged SFP+ modules into them, and three out of four interfaces were available with the fourth completely AWOL. Rebooting with hw.ix.unsupported_sfp=1 presented all four, as expected. As for a use case as to why someone would want this, building out systems before deployment comes to mind. Thanks! On 02/12/2015 11:11 AM, Jack Vogel wrote: > > > On Thu, Feb 12, 2015 at 6:30 AM, John Jasen > wrote: > > > > Date: Wed, 11 Feb 2015 20:47:15 +0000 > > From: Steven Hartland > > > To: freebsd-net@freebsd.org > > Subject: Re: FreeBSD 10.1: Intel dual port 10GbE card (82599EB): > > second port not present? > > Message-ID: <54DBBFD3.7010801@multiplay.co.uk > > > > Content-Type: text/plain; charset=windows-1252; format=flowed > > > > > Your problem looks like its the SFP's which are "unsupported" to > which > > the attach will fail with error EIO (5). > > > > You can set hw.ix.unsupported_sfp=1 in /boot/loader.conf to enable > > unsupported SFP's but be aware you "doing so your on your own". > > Thanks! hw.ix.unsupported_sfp=1 corrected the immediate problem. > > The network port that didn't come up does not yet have an SFP module > installed > > It seems the default behavior in FreeBSD is to not have the interface > available until a SFP is inserted. While a corner case, this does make > configuration prior to installation a bit more annoying. > > > Well, exactly what use would there be in having it "available" > with no media, its like saying you want your car available with > no wheels :) The media can make operation quite different, it > could be copper it could be fiber, the driver won't know until > there is something actually present, hence it cannot really do > "init" until then. > > Jack > > > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to > "freebsd-net-unsubscribe@freebsd.org > " > > From owner-freebsd-net@FreeBSD.ORG Fri Feb 20 19:02:05 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2A25573A for ; Fri, 20 Feb 2015 19:02:05 +0000 (UTC) Received: from mail-la0-x232.google.com (mail-la0-x232.google.com [IPv6:2a00:1450:4010:c03::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C6E297A for ; Fri, 20 Feb 2015 19:02:04 +0000 (UTC) Received: by lams18 with SMTP id s18so8018323lam.11 for ; Fri, 20 Feb 2015 11:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2n6Qmkb2PPCllSXVp0F59VTm6eWzZ3kpmu/viRg0ApA=; b=JB6QJCw0jNMm/E6z94gW2TpMef1GKaDeyRmYJVWXUtnRGo02grk2HJKbt4gjGVL9HC JwrSyaK3AdxiOzhIjpSUe2kBeuDHfBiPv0WPZP0ZH3UwG4u9CFoBMLbwDrzd2WZ1vvyU FPbcRycUw+ZCBB262/UpYIwSAPXVdGAXf2jsTcxA+ACMY9WDgWRAI56EYs5Yk/FwQKyf THI4jdkf0CEi0WpM44XZFGjFQGJzeEMM7o+Q0zHI5x7flyuwcSJKwyn6DVzSgtDOkto4 lakr7mZd4cw3pkaU1EjD9TLxVSPDIa0TOe1itT93FyYOqabIVeF8rDKkT12CuV1xkV2L EB+Q== MIME-Version: 1.0 X-Received: by 10.112.135.196 with SMTP id pu4mr9622025lbb.41.1424458922690; Fri, 20 Feb 2015 11:02:02 -0800 (PST) Received: by 10.114.78.131 with HTTP; Fri, 20 Feb 2015 11:02:02 -0800 (PST) In-Reply-To: <54E76B47.8080907@gmail.com> References: <54DCB8F2.5090809@gmail.com> <54E76B47.8080907@gmail.com> Date: Fri, 20 Feb 2015 14:02:02 -0500 Message-ID: Subject: Re: FreeBSD 10.1: Intel dual port 10GbE card (82599EB) second port not present? From: Ryan Stone To: John Jasen Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Net , Jack Vogel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 19:02:05 -0000 I think that you might be a bit confused about the behaviour. An ix port will only be missing if a) You have a non-Intel SFP+ installed b) hw.ix.unsupported_sfp=1 is not set in loader.conf ix ports that have no SFP+ installed do show up in ifconfig From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 02:10:43 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 05C374B1 for ; Sat, 21 Feb 2015 02:10:43 +0000 (UTC) Received: from phlegethon.blisses.org (phlegethon.blisses.org [50.56.97.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DAE09D49 for ; Sat, 21 Feb 2015 02:10:42 +0000 (UTC) Received: from blisses.org (cocytus.blisses.org [23.25.209.73]) by phlegethon.blisses.org (Postfix) with ESMTPSA id 3877C148F85 for ; Fri, 20 Feb 2015 21:08:20 -0500 (EST) Date: Fri, 20 Feb 2015 21:08:18 -0500 From: Mason Loring Bliss To: freebsd-net@freebsd.org Subject: NAT question Message-ID: <20150221020818.GY24491@blisses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 02:10:43 -0000 Hi all. With iptables, I can say something like: -t nat -A POSTROUTING -o eth0 -s 4.5.6.7/32 -d 0/0 -j SNAT --to-source 1.2.3.4 -t nat -A POSTROUTING -o eth0 -s 4.5.6.0/24 -d 0/0 -j SNAT --to-source 1.2.3.5 -t nat -A POSTROUTING -o eth0 -s 8.9.0.0/24 -d 0/0 -j SNAT --to-source 1.2.3.6 So, traffic going out from 4.5.6.7 goes into the world sourced from 1.2.3.4, whereas the rest of 4.5.6/24 goes as 1.2.3.5, and all of 8.9.0/24 comes out from 1.2.3.6. I don't see how to do this with IPFW. I assume there's some way to do it with the GENERIC kernel, so I'm assuming natd is deprecated, as it requires a custom kernel, as far as I can see. How do I accomplish this with IPFW? Or do I need to use PF for this? Or are those independent of the NAT after all and I want to use something else? If that's the case, does it require natd and a custom kernel, or is there something that works with a GENERIC kernel? (This will be 10.1, FWIW.) Thanks. -- Love is a snowmobile racing across the tundra and then suddenly it flips over, pinning you underneath. At night, the ice weasels come. From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 13:39:55 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 68E4CEFE for ; Sat, 21 Feb 2015 13:39:55 +0000 (UTC) Received: from mail-qc0-x22c.google.com (mail-qc0-x22c.google.com [IPv6:2607:f8b0:400d:c01::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18A46765 for ; Sat, 21 Feb 2015 13:39:55 +0000 (UTC) Received: by qcrw7 with SMTP id w7so4922324qcr.4 for ; Sat, 21 Feb 2015 05:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=51mKOaJSfsdR3wlgModPHQqKrJsLJt7JgmeTEPbg2j8=; b=Gl3c0Y87MCua+h3rPrEBrimskKZnTNKlgEnKt7uyGYbIE0Hqv9enAxF+sg4I5Fj1jh mp16gpLXgUpSeRdBuJ+km8D2vUwOcO00tqXKAdS3luomcfjZH9/0MqU2hf5hDdrU77UG PcqvUogVrQDw845BSJ4N0TFbWJ4/u4wW1oLzDEY4pASh1axkrXGxSMJKdL4k3BVLYTOm er2o9txv0/t+ZLr7nThLCRHBsb0AyCd5apoMfrO4EVoBZ+DYkTOYOPnjVF51UOD62Vkr rzhCs9pH3NgkDwSyFXxZkzDTJ+Xjly7eT+FIGQAMBtp4vbJnl8EvZWEEBgUzqruTmLYo Pmyg== X-Received: by 10.140.232.197 with SMTP id d188mr5806285qhc.80.1424525994164; Sat, 21 Feb 2015 05:39:54 -0800 (PST) Received: from [10.0.0.230] (pool-74-103-59-158.bltmmd.fios.verizon.net. [74.103.59.158]) by mx.google.com with ESMTPSA id c8sm23828988qgf.14.2015.02.21.05.39.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Feb 2015 05:39:52 -0800 (PST) Message-ID: <54E88AA6.3000902@gmail.com> Date: Sat, 21 Feb 2015 08:39:50 -0500 From: John Jasen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ryan Stone Subject: Re: FreeBSD 10.1: Intel dual port 10GbE card (82599EB) second port not present? References: <54DCB8F2.5090809@gmail.com> <54E76B47.8080907@gmail.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: FreeBSD Net , Jack Vogel X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 13:39:55 -0000 Well, oops. That would indeed explain the behavior. Thanks! On 02/20/2015 02:02 PM, Ryan Stone wrote: > I think that you might be a bit confused about the behaviour. An ix > port will only be missing if > > a) You have a non-Intel SFP+ installed > b) hw.ix.unsupported_sfp=1 is not set in loader.conf > > ix ports that have no SFP+ installed do show up in ifconfig From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 16:29:24 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EAEE062D for ; Sat, 21 Feb 2015 16:29:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A571F931 for ; Sat, 21 Feb 2015 16:29:24 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1LGTOkH068968 for ; Sat, 21 Feb 2015 16:29:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1LGTOcV068967; Sat, 21 Feb 2015 16:29:24 GMT (envelope-from root) Date: Sat, 21 Feb 2015 16:29:24 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 2, 475 lines] D1438: FreeBSD callout rewrite and cleanup Message-ID: X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTosmQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 16:29:25 -0000 hselasky updated this revision to Diff 3896. hselasky added a comment. Disallow task switching during hard tick interrupts. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3868&id=3896 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/man/man9/timeout.9 sys/kern/init_main.c sys/kern/kern_clocksource.c sys/kern/kern_condvar.c sys/kern/kern_lock.c sys/kern/kern_switch.c sys/kern/kern_synch.c sys/kern/kern_thread.c sys/kern/kern_timeout.c sys/kern/subr_sleepqueue.c sys/ofed/include/linux/completion.h sys/sys/_callout.h sys/sys/callout.h sys/sys/proc.h To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 16:30:32 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 54EC46EE for ; Sat, 21 Feb 2015 16:30:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0F3DA953 for ; Sat, 21 Feb 2015 16:30:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t1LGUVBS070201 for ; Sat, 21 Feb 2015 16:30:31 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t1LGUVLF070200; Sat, 21 Feb 2015 16:30:31 GMT (envelope-from root) Date: Sat, 21 Feb 2015 16:30:31 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Updated, 2, 481 lines] D1438: FreeBSD callout rewrite and cleanup Message-ID: <086c70fb4a45380c6030794c04815e10@localhost.localdomain> X-Priority: 3 Thread-Topic: D1438: FreeBSD callout rewrite / cleanup X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YzU3ODk0MGM0Y2E4NmE3NjY4YjJlZmFkM2UyIFTosqc= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 16:30:32 -0000 hselasky updated this revision to Diff 3897. hselasky added a comment. Add context to diff. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1438?vs=3896&id=3897 REVISION DETAIL https://reviews.freebsd.org/D1438 AFFECTED FILES share/man/man9/Makefile share/man/man9/timeout.9 sys/kern/init_main.c sys/kern/kern_clocksource.c sys/kern/kern_condvar.c sys/kern/kern_lock.c sys/kern/kern_switch.c sys/kern/kern_synch.c sys/kern/kern_thread.c sys/kern/kern_timeout.c sys/kern/subr_sleepqueue.c sys/ofed/include/linux/completion.h sys/sys/_callout.h sys/sys/callout.h sys/sys/proc.h To: hselasky, jhb, adrian, markj, emaste, sbruno, imp, lstewart, rwatson, gnn, rrs, kostikbel, delphij, neel, erj, remkolodder, bcr, brueffer, brd, allanjude, wblock Cc: wblock, freebsd-net From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 18:28:18 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1FDFBE3 for ; Sat, 21 Feb 2015 18:28:18 +0000 (UTC) Received: from phlegethon.blisses.org (phlegethon.blisses.org [50.56.97.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80F346A9 for ; Sat, 21 Feb 2015 18:28:18 +0000 (UTC) Received: from blisses.org (cocytus.blisses.org [23.25.209.73]) by phlegethon.blisses.org (Postfix) with ESMTPSA id 681E4148960; Sat, 21 Feb 2015 13:28:16 -0500 (EST) Date: Sat, 21 Feb 2015 13:28:14 -0500 From: Mason Loring Bliss To: "Paul A. Procacci" Subject: Re: NAT question Message-ID: <20150221182814.GZ24491@blisses.org> References: <20150221020818.GY24491@blisses.org> <20150221054604.GD14405@freenx.int.smq.datapipe.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150221054604.GD14405@freenx.int.smq.datapipe.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 18:28:18 -0000 On Sat, Feb 21, 2015 at 12:46:04AM -0500, Paul A. Procacci wrote: > There is a section in ipfw(8) labeled: 'NETWORK ADDRESS TRANSLATION (NAT)' > In that section it details how to bind a nat instance to an ip address. > (Namely, the ip argument) I'm not sure how I missed that there can be multiple NAT instances, seeing that they're numbered. =cough= > Then you can use ipfw to throw packets at whatever nat instance you want. It looks like I do this with ipfw add nat all from to any to tie to the external address I'll later specify with "config ip foo", if I'm reading this correctly. It'll be easy enough to test. Another question comes up - to do DNAT and pass inbound connections back to different hosts depending on which external address is used, do I want to set up something like ipfw add nat all from any to ...or do I want to do something with the "reverse" config element? the man page is light on description for "reverse". Anyway, thank you for orienting me. -- Mason Loring Bliss (( "In the drowsy dark cave of the mind dreams mason@blisses.org )) build their nest with fragments dropped http://blisses.org/ (( from day's caravan." - Rabindranath Tagore From owner-freebsd-net@FreeBSD.ORG Sat Feb 21 18:55:47 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7CBAADA for ; Sat, 21 Feb 2015 18:55:47 +0000 (UTC) Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com [IPv6:2607:f8b0:4001:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 43FAA976 for ; Sat, 21 Feb 2015 18:55:47 +0000 (UTC) Received: by iecat20 with SMTP id at20so15047277iec.12 for ; Sat, 21 Feb 2015 10:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=dtldVFWlu36GfNvPgyu8Pf90SAEVlQqrfjLmk/rJBDQ=; b=BjFUFIX8BlJU8mznDPr+BecP5sKi33FYeg27oF0lEb1H0iLmwuB0zhZ39fEpk43VLS 8BJPIDRGEv0QPJ70aDOp2IvP0j1tgzWTsQNYXn2mcQNZqRACg5CnUkQCbFEBupV5yqMo 7piNqmHx6uRFecfCft+WwZRzN+cERgN1KN1T27Vfkjmnfjd7LfwtQ0NWpaAwbAGt9SgA STLWgcwDHu1FHSXHLgXyWLufP2PJLAAQBg+McW10NH9uEoyO87ALEiwboWOZaeM1gfFc F4FYzc9+TdHcyvSyKezFmnmvewKZ9ewgke19PxdMBzJJnEGgq9o2SqKkcd+vuUCiJMx2 sqQA== X-Received: by 10.51.17.1 with SMTP id ga1mr3852384igd.33.1424544946461; Sat, 21 Feb 2015 10:55:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.36.71.72 with HTTP; Sat, 21 Feb 2015 10:55:26 -0800 (PST) In-Reply-To: <20150221020818.GY24491@blisses.org> References: <20150221020818.GY24491@blisses.org> From: Konstantin Kulikov Date: Sat, 21 Feb 2015 22:55:26 +0400 Message-ID: Subject: Re: NAT question To: Mason Loring Bliss Content-Type: text/plain; charset=UTF-8 Cc: freebsd-net@freebsd.org X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2015 18:55:47 -0000 Hello. ipfw nat 1 config ip 1.2.3.4 ipfw nat 2 config ip 1.2.3.5 ipfw nat 3 config ip 1.2.3.6 ipfw add nat 1 ip from 4.5.6.7/32 to any out via $ext ipfw add nat 2 ip from 4.5.6.0/24 to any out via $ext ipfw add nat 3 ip from 8.9.0.0/24 to any out via $ext ipfw add nat 1 ip from any to 1.2.3.4 in via $ext ipfw add nat 2 ip from any to 1.2.3.5 in via $ext ipfw add nat 3 ip from any to 1.2.3.6 in via $ext Should work (untested though). As for your dnat questing I think you want redirect_addr nat option. On Sat, Feb 21, 2015 at 5:08 AM, Mason Loring Bliss wrote: > Hi all. > > With iptables, I can say something like: > > -t nat -A POSTROUTING -o eth0 -s 4.5.6.7/32 -d 0/0 -j SNAT --to-source 1.2.3.4 > -t nat -A POSTROUTING -o eth0 -s 4.5.6.0/24 -d 0/0 -j SNAT --to-source 1.2.3.5 > -t nat -A POSTROUTING -o eth0 -s 8.9.0.0/24 -d 0/0 -j SNAT --to-source 1.2.3.6 > > So, traffic going out from 4.5.6.7 goes into the world sourced from 1.2.3.4, > whereas the rest of 4.5.6/24 goes as 1.2.3.5, and all of 8.9.0/24 comes out > from 1.2.3.6. > > I don't see how to do this with IPFW. I assume there's some way to do it with > the GENERIC kernel, so I'm assuming natd is deprecated, as it requires a > custom kernel, as far as I can see. > > How do I accomplish this with IPFW? Or do I need to use PF for this? Or are > those independent of the NAT after all and I want to use something else? If > that's the case, does it require natd and a custom kernel, or is there > something that works with a GENERIC kernel? (This will be 10.1, FWIW.) > > Thanks. > > -- > Love is a snowmobile racing across the tundra and then suddenly it > flips over, pinning you underneath. At night, the ice weasels come. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"