From owner-freebsd-net@FreeBSD.ORG Sun Jun 14 09:53:11 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 750F4265 for ; Sun, 14 Jun 2015 09:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5F096DE1 for ; Sun, 14 Jun 2015 09:53:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5E9rBAG091906 for ; Sun, 14 Jun 2015 09:53:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Sun, 14 Jun 2015 09:53:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 09:53:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-qa, patch -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Sun Jun 14 11:28:26 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B35C3BAC; Sun, 14 Jun 2015 11:28:26 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from mail.tdx.com (mail.tdx.com [62.13.128.18]) by mx1.freebsd.org (Postfix) with ESMTP id 7E0C2669; Sun, 14 Jun 2015 11:28:25 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from [10.12.30.100] (vpn01-01.tdx.co.uk [62.13.130.213]) (authenticated bits=0) by mail.tdx.com (8.14.3/8.14.3/) with ESMTP id t5EBSGJ2097665 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 Jun 2015 12:28:17 +0100 (BST) Date: Sun, 14 Jun 2015 12:28:16 +0100 From: Karl Pielorz To: Adrian Chadd , Julian Kornberger cc: FreeBSD Net Subject: Re: Realtek Issues (re) on PC Engines APU1 Board... Message-ID: In-Reply-To: References: <557AAE18.1040902@tzi.de> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 11:28:26 -0000 --On 12 June 2015 08:53:03 -0700 Adrian Chadd wrote: > Hi, > > If this works for people then we should document this somewhere and > include the firmware/tool. > I upgraded the firmware (board shipped with 'production 4/5/2014') - upgraded to '9/8/2014 "beta"' - and so far, this does appear to have fixed the problem. The 'TinyCore Linux installer' PC Engines have on their site (as a windows .exe that creates a bootable USB) comes with the latest 'beta' firmware [which I installed]. I've let PC Engines know as well that (touch wood!) - this seems to fix the issue... -Karl From owner-freebsd-net@FreeBSD.ORG Sun Jun 14 12:10:21 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F5E5332 for ; Sun, 14 Jun 2015 12:10:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8947EF6C for ; Sun, 14 Jun 2015 12:10:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5ECALmp018879 for ; Sun, 14 Jun 2015 12:10:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200629] ether_type not set in ether header in mbuf for vlan packet Date: Sun, 14 Jun 2015 12:10:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 12:10:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200629 Hans Petter Selasky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hselasky@FreeBSD.org --- Comment #1 from Hans Petter Selasky --- Hi, Does MFC'ing this patch to 10-stable solve the issue? https://svnweb.freebsd.org/changeset/base/280991 --HPS -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Sun Jun 14 14:15:04 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8349CE95; Sun, 14 Jun 2015 14:15:04 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from mail.tdx.com (mail.tdx.com [62.13.128.18]) by mx1.freebsd.org (Postfix) with ESMTP id 4DCB1110; Sun, 14 Jun 2015 14:15:03 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from [10.12.30.100] (vpn01-01.tdx.co.uk [62.13.130.213]) (authenticated bits=0) by mail.tdx.com (8.14.3/8.14.3/) with ESMTP id t5EEF1WG009627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 14 Jun 2015 15:15:01 +0100 (BST) Date: Sun, 14 Jun 2015 15:15:01 +0100 From: Karl Pielorz To: Adrian Chadd , Julian Kornberger cc: FreeBSD Net Subject: Re: Realtek Issues (re) on PC Engines APU1 Board... Message-ID: <0B94D81A4C009BC726E078C1@Karls-Mac-mini.local> In-Reply-To: References: <557AAE18.1040902@tzi.de> X-Mailer: Mulberry/4.0.8 (Mac OS X) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 14:15:04 -0000 Spoke to soon... It copes with the traffic now (I ran test after test), but the idle box just locked up hours later (no console output, no panic, nothing). I've disconnected 're1' again (as before) to see if that stops it locking up. There were no watchdog timeout errors logged at all for the time it had been up. -Karl --On 14 June 2015 12:28:16 +0100 Karl Pielorz wrote: > > > --On 12 June 2015 08:53:03 -0700 Adrian Chadd wrote: > >> Hi, >> >> If this works for people then we should document this somewhere and >> include the firmware/tool. >> > > I upgraded the firmware (board shipped with 'production 4/5/2014') - > upgraded to '9/8/2014 "beta"' - and so far, this does appear to have > fixed the problem. > > The 'TinyCore Linux installer' PC Engines have on their site (as a > windows .exe that creates a bootable USB) comes with the latest 'beta' > firmware [which I installed]. > > I've let PC Engines know as well that (touch wood!) - this seems to fix > the issue... > > -Karl > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Sun Jun 14 21:00:28 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1F61E90A for ; Sun, 14 Jun 2015 21:00:28 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EA9E7A26 for ; Sun, 14 Jun 2015 21:00:27 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5EL0R8v002869 for ; Sun, 14 Jun 2015 21:00:27 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201506142100.t5EL0R8v002869@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-net@FreeBSD.org Subject: Problem reports for freebsd-net@FreeBSD.org that need special attention X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 Date: Sun, 14 Jun 2015 21:00:27 +0000 Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2015 21:00:28 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 197535 | [re] [panic] if_re (Realtek 8168) causes memory w Open | 194515 | Fatal Trap 12 Kernel with vimage Open | 199136 | [if_tap] Added down_on_close sysctl variable to t 3 problems total for which you should take action. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 11:14:09 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D088D2B5 for ; Mon, 15 Jun 2015 11:14:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BB3B0E3D for ; Mon, 15 Jun 2015 11:14:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FBE988010124 for ; Mon, 15 Jun 2015 11:14:09 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 11:14:09 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 11:14:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #5 from Michael Tuexen --- Hi Craig, when setting up two VMs as suggested, they can just reach each other. Even ping 172.8.1.4 works, I don't need setfib 2 ping 172.8.1.4. What config do I need to test the fib stuff. I don't think storing it in the inp is the way, since this values wouldn't be updated if a setsockopt() operation is performed. So I think just using the fibnum from the socket in the SCTP_RTALLOC macro is the way to go. But I want to test it before committing it. Best regards Michael -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 12:06:51 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6136AA7B for ; Mon, 15 Jun 2015 12:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BB6ECE3 for ; Mon, 15 Jun 2015 12:06:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FC6p9h059756 for ; Mon, 15 Jun 2015 12:06:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 12:06:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 12:06:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Andrey V. Elsukov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ae@FreeBSD.org --- Comment #2 from Andrey V. Elsukov --- Taking into account your description, this patch looks very strange. Can you show some core.txt.N files from described panics? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 14:36:05 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF7FF91 for ; Mon, 15 Jun 2015 14:36:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A96D9800 for ; Mon, 15 Jun 2015 14:36:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FEa5PB061963 for ; Mon, 15 Jun 2015 14:36:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 14:36:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eri@pfsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 14:36:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323 --- Comment #3 from Ermal Lu=C3=A7i --- Here is a patch against HEAD of FreeBSD. Also take a look at this link for a trace https://redmine.pfsense.org/issues/4685 If its ok with you Andrey i would like to commit this one. diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c index fec6aa0..91e9568 100644 --- a/sys/netinet/if_ether.c +++ b/sys/netinet/if_ether.c @@ -364,6 +364,10 @@ retry: if ((la->la_flags & LLE_VALID) && ((la->la_flags & LLE_STATIC) || la->la_expire > time_uptime)) { bcopy(&la->ll_addr, desten, ifp->if_addrlen); + if (flags & LLE_EXCLUSIVE) + LLE_WUNLOCK(la); + else + LLE_RUNLOCK(la); /* * If entry has an expiry time and it is approaching, * see if we need to send an ARP request within this @@ -377,8 +381,7 @@ retry: if (pflags !=3D NULL) *pflags =3D la->la_flags; - error =3D 0; - goto done; + return (0); } if (la->la_flags & LLE_STATIC) { /* should not happen! */ --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 14:58:59 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C1555EA5 for ; Mon, 15 Jun 2015 14:58:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AB756CD1 for ; Mon, 15 Jun 2015 14:58:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FEwxp7088573 for ; Mon, 15 Jun 2015 14:58:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 14:58:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 14:58:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #4 from Franco Fichtner --- la is being read and modified after unlock with the attached patch. Though it looks like arprequest() may indeed work as expected without the lock held. Not sure if unlock/lock around arprequest is advisable; there may be a more fundamental issue with the code block itself? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 15:11:26 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DEF10516 for ; Mon, 15 Jun 2015 15:11:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C916513C for ; Mon, 15 Jun 2015 15:11:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FFBQxC049589 for ; Mon, 15 Jun 2015 15:11:26 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 15:11:27 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rodrigc@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 15:11:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #6 from Craig Rodrigues --- You need to set up a default IP address and routing table on em0 that is *not* a 172 address. That way, if you do: netstat -r you will see the default routing table, and if you do setfib 2 netstat -r you will see the routing table for the 172 addresses -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 15:22:30 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4CAD6A6B for ; Mon, 15 Jun 2015 15:22:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36AFD645 for ; Mon, 15 Jun 2015 15:22:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FFMUCe001520 for ; Mon, 15 Jun 2015 15:22:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 15:22:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 15:22:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #5 from Franco Fichtner --- https://github.com/freebsd/freebsd/commit/ec826ad5c7f97de814529d3b3bae7950f91d9a5d#diff-e08033318b7a3c6cc3ffb3e431a0f8f2L461 vs. https://github.com/freebsd/freebsd/commit/ec826ad5c7f97de814529d3b3bae7950f91d9a5d#diff-e08033318b7a3c6cc3ffb3e431a0f8f2R359 -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 15:47:45 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 62D8916D for ; Mon, 15 Jun 2015 15:47:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CF1AB93 for ; Mon, 15 Jun 2015 15:47:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FFljRr025928 for ; Mon, 15 Jun 2015 15:47:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 15:47:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eri@pfsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 15:47:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323 --- Comment #6 from Ermal Lu=C3=A7i --- (In reply to Franco Fichtner from comment #4) Yeah but its a very quick read to me which does not create any race of sort from what i could tell. For sure la will be there when the fields are accessed. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:06:19 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3D705C72 for ; Mon, 15 Jun 2015 16:06:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 276B51D7 for ; Mon, 15 Jun 2015 16:06:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FG6JI7078159 for ; Mon, 15 Jun 2015 16:06:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 16:06:19 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:06:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #7 from Michael Tuexen --- Here is what I do and what happens to the routing table. As you see, a route gets added to fib 0. Is this expected? Intended? > ifconfig em0 em0: flags=8843 metric 0 mtu 1500 options=9b ether 00:0c:29:8a:89:10 inet 192.168.115.171 netmask 0xffffff00 broadcast 192.168.115.255 nd6 options=29 media: Ethernet autoselect (1000baseT ) status: active > netstat -nrfinet Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.115.2 UGS em0 127.0.0.1 link#2 UH lo0 192.168.115.0/24 link#1 U em0 192.168.115.171 link#1 UHS lo0 > sudo ifconfig em0.3275 create name craig0 fib 2 Password: > netstat -nrfinet Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.115.2 UGS em0 127.0.0.1 link#2 UH lo0 192.168.115.0/24 link#1 U em0 192.168.115.171 link#1 UHS lo0 > sudo ifconfig craig0 inet6 ifdisabled fib 2 > netstat -nrfinet Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.115.2 UGS em0 127.0.0.1 link#2 UH lo0 192.168.115.0/24 link#1 U em0 192.168.115.171 link#1 UHS lo0 > sudo ifconfig craig0 inet 172.8.1.3/16 up fib 2 > sudo ifconfig craig0 craig0: flags=8843 metric 0 mtu 1500 options=3 ether 00:0c:29:8a:89:10 inet 172.8.1.3 netmask 0xffff0000 broadcast 172.8.255.255 nd6 options=29 media: Ethernet autoselect (1000baseT ) status: active fib: 2 vlan: 3275 parent interface: em0 groups: vlan > netstat -nrfinet Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.115.2 UGS em0 127.0.0.1 link#2 UH lo0 172.8.0.0/16 link#3 U craig0 192.168.115.0/24 link#1 U em0 192.168.115.171 link#1 UHS lo0 > setfib 2 netstat -nrfinet Routing tables (fib: 2) Internet: Destination Gateway Flags Netif Expire 127.0.0.1 link#2 UH lo0 172.8.0.0/16 link#3 U craig0 172.8.1.3 link#3 UHS lo0 192.168.115.0/24 link#1 U em0 > sudo route add 127.0.0.0/8 -interface lo0 -fib 2 add net 127.0.0.0: gateway lo0 fib 2 > setfib 2 netstat -nrfinet Routing tables (fib: 2) Internet: Destination Gateway Flags Netif Expire 127.0.0.0/8 lo0 US lo0 127.0.0.1 link#2 UH lo0 172.8.0.0/16 link#3 U craig0 172.8.1.3 link#3 UHS lo0 192.168.115.0/24 link#1 U em0 > netstat -nrfinet Routing tables Internet: Destination Gateway Flags Netif Expire default 192.168.115.2 UGS em0 127.0.0.1 link#2 UH lo0 172.8.0.0/16 link#3 U craig0 192.168.115.0/24 link#1 U em0 192.168.115.171 link#1 UHS lo0 -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:17:08 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F1C821A1 for ; Mon, 15 Jun 2015 16:17:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DBE0C658 for ; Mon, 15 Jun 2015 16:17:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGH8Q5090036 for ; Mon, 15 Jun 2015 16:17:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 16:17:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:17:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #7 from Franco Fichtner --- You read a value from a lock-protected entity, you acquire a (read) lock. You write a value to a lock-protected entity, you acquire a (write) lock. After the patch, there is neither. Do you want to risk pushing a regression into production code? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:22:22 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 261F589C for ; Mon, 15 Jun 2015 16:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1035D958 for ; Mon, 15 Jun 2015 16:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGMLPi098334 for ; Mon, 15 Jun 2015 16:22:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 16:22:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eri@pfsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:22:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323 --- Comment #8 from Ermal Lu=C3=A7i --- (In reply to Franco Fichtner from comment #7) Oh you refer to the decrement of the la preempt value. Yeah but i highly dislike unlock and relock again code paths, that can be a solution. Or moving this to atomics or even to a taskqueue might be better than this. Still since the entry is just going to be updated or removed shortly after timeout/reply i am not sure the implications if any there. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:33:14 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 10B20F52 for ; Mon, 15 Jun 2015 16:33:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE9A4BD8 for ; Mon, 15 Jun 2015 16:33:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGXDpV009745 for ; Mon, 15 Jun 2015 16:33:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 16:33:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:33:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #9 from Franco Fichtner --- The previous code in place before the "bad" revision in 2008 accessed la, made its changes and called arprequest() after releasing the lock, like the other code block still does. You can maybe set a temporary variable inside the locked area that calls arprequest() and afterwards trigger the function based on the value of the temporary variable? -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:49:55 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 060BCAA4 for ; Mon, 15 Jun 2015 16:49:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E4407ECA for ; Mon, 15 Jun 2015 16:49:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGnsHf025338 for ; Mon, 15 Jun 2015 16:49:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 16:49:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:49:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koobs@FreeBSD.org --- Comment #10 from Kubilay Kocak --- Phabricator (reviews.freebsd.org) looks like the perfect place for this changeset/discussion, and it is open for !committer registrations and accounts :) -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:51:18 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0AAAFB66 for ; Mon, 15 Jun 2015 16:51:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D007BB6 for ; Mon, 15 Jun 2015 16:51:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGpHdV028927 for ; Mon, 15 Jun 2015 16:51:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 16:51:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eri@pfsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:51:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323 --- Comment #11 from Ermal Lu=C3=A7i --- (In reply to Kubilay Kocak from comment #10) Ok i am posting this to phabricator since i am a freebsd developer :) Just for the reference here is another iteration of the patch diff --git a/sys/netinet/if_ether.c b/sys/netinet/if_ether.c index fec6aa0..aa370d6 100644 --- a/sys/netinet/if_ether.c +++ b/sys/netinet/if_ether.c @@ -364,6 +364,7 @@ retry: if ((la->la_flags & LLE_VALID) && ((la->la_flags & LLE_STATIC) || la->la_expire > time_uptime)) { bcopy(&la->ll_addr, desten, ifp->if_addrlen); + renew =3D 0; /* * If entry has an expiry time and it is approaching, * see if we need to send an ARP request within this @@ -371,14 +372,22 @@ retry: */ if (!(la->la_flags & LLE_STATIC) && time_uptime + la->la_preempt > la->la_expire) { - arprequest(ifp, NULL, &SIN(dst)->sin_addr, NULL); + renew =3D 1; la->la_preempt--; } if (pflags !=3D NULL) *pflags =3D la->la_flags; - error =3D 0; - goto done; + + if (flags & LLE_EXCLUSIVE) + LLE_WUNLOCK(la); + else + LLE_RUNLOCK(la); + + if (renew =3D=3D 1) + arprequest(ifp, NULL, &SIN(dst)->sin_addr, NULL); + + return (0); } if (la->la_flags & LLE_STATIC) { /* should not happen! */ --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 16:57:16 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AE67AE65 for ; Mon, 15 Jun 2015 16:57:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 988D2198 for ; Mon, 15 Jun 2015 16:57:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FGvGNw035541 for ; Mon, 15 Jun 2015 16:57:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 16:57:16 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 16:57:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 Michael Tuexen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 17:00:08 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 027D7F58 for ; Mon, 15 Jun 2015 17:00:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E0C9F1DD for ; Mon, 15 Jun 2015 17:00:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FH07Gc039442 for ; Mon, 15 Jun 2015 17:00:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 17:00:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: eri@pfsense.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 17:00:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200323 --- Comment #12 from Ermal Lu=C3=A7i --- Moved to https://reviews.freebsd.org/D2828 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 17:05:13 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C90ED3DF for ; Mon, 15 Jun 2015 17:05:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2E8662C for ; Mon, 15 Jun 2015 17:05:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FH5Dxk077441 for ; Mon, 15 Jun 2015 17:05:13 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 17:05:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status bug_file_loc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 17:05:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open URL| |https://reviews.freebsd.org | |/D2828 -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 17:35:08 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 41BE86D6 for ; Mon, 15 Jun 2015 17:35:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2C1A0DEB for ; Mon, 15 Jun 2015 17:35:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FHZ8Tw010241 for ; Mon, 15 Jun 2015 17:35:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Mon, 15 Jun 2015 17:35:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: franco@opnsense.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 17:35:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #13 from Franco Fichtner --- Looks good now, thanks Ermal. :) -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 19:46:41 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9FD19150 for ; Mon, 15 Jun 2015 19:46:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A0B6236 for ; Mon, 15 Jun 2015 19:46:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FJkfxg067893 for ; Mon, 15 Jun 2015 19:46:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 19:46:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 19:46:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #8 from Michael Tuexen --- OK, I need sysctl -w net.add_addr_allfibs=0 to reproduce your problem. Best regards Michael -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 19:56:31 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94118663 for ; Mon, 15 Jun 2015 19:56:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7E8FA6D0 for ; Mon, 15 Jun 2015 19:56:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5FJuVKi078239 for ; Mon, 15 Jun 2015 19:56:31 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Mon, 15 Jun 2015 19:56:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 19:56:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 Alan Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asomers@FreeBSD.org --- Comment #9 from Alan Somers --- BTW, I wrote some FIB-related tests in tests/sys/netinet. They use tap(4) interfaces so they don't need two machines. If you look at the udp_dontroute test, you can see an example that passes traffic from one to the other. -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 22:13:37 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C7714984; Mon, 15 Jun 2015 22:13:37 +0000 (UTC) (envelope-from chris@vindaloo.com) Received: from geonosis.vindaloo.com (geonosis.vindaloo.com [IPv6:2001:470:1f07:26b:0:ac18:9026:1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smtp.vindaloo.com", Issuer "Vindaloo CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CC79DC7; Mon, 15 Jun 2015 22:13:37 +0000 (UTC) (envelope-from chris@vindaloo.com) Received: from kessel.vindaloo.com (kessel.vindaloo.com [172.24.145.71]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by geonosis.vindaloo.com (Postfix) with ESMTPSA id 6082DBFBC; Mon, 15 Jun 2015 18:13:35 -0400 (EDT) Subject: Re: pf block policy for IPv6 and IPv4 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_FD43E0AD-A5A3-4CD6-8CB0-041A831C7F54"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Pgp-Agent: GPGMail 2.5 From: Christopher Hilton In-Reply-To: <20150610211226.GA35372@kessel.vindaloo.com> Date: Mon, 15 Jun 2015 18:13:32 -0400 Message-Id: <553873FD-ABD5-46C2-9542-CA5FC0146A71@vindaloo.com> References: <20150610211226.GA35372@kessel.vindaloo.com> To: freebsd-questions@freebsd.org, freebsd-net@freebsd.org X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 22:13:37 -0000 --Apple-Mail=_FD43E0AD-A5A3-4CD6-8CB0-041A831C7F54 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Jun 10, 2015, at 5:12 PM, Christopher Sean Hilton = wrote: > Good afternoon and thank you in advance. >=20 > I'm running FreeBSD 9.3-STABLE: >=20 > FreeBSD anza.example.com 9.3-STABLE \ > FreeBSD 9.3-STABLE #0 r269627: Wed Aug 6 13:48:46 EDT 2014 \ > root@dagobah:/usr/obj/amd64/usr/src/sys/GENERIC amd64 >=20 > on my imap mailserver. It's dual homed and has both A and AAAA records > in DNS: >=20 > $ host anza.example.com > anza.example.com has address 10.17.53.96 > anza.example.com has IPv6 address fe80::aaaa:bbbb:60:0 >=20 >=20 > My pf.conf seems to be pretty standard... >=20 > ext_if=3D"em0" > int_if=3D"em1" >=20 > set skip on { lo $int_if } >=20 > table persist const { em0:network } > table persist file "/etc/pf/table/friends" >=20 > table persist >=20 > scrub in no-df >=20 > ## Block inbound packets by default. Use return rather than drop > ## to make debugging easier as this server is currently internal > ## only. >=20 > block return log > block drop log quick from >=20 > pass out >=20 > antispoof quick for { lo $int_if } >=20 > ## Pass ssh but treat jerks and a*holes accordingly. >=20 > pass in on $ext_if proto tcp from to ($ext_if) port ssh = \ > keep state >=20 > pass in on $ext_if proto tcp from ! to ($ext_if) port ssh = \ > keep state \ > (max-src-conn 5, max-src-conn-rate 5/30, \ > overload flush global) >=20 > ... >=20 > Last night as I was testing the configuration of the imap server, I > tripped over some unexpected behaviour. *** The issue was that I had > forgotten to add rules for imap to my pf.conf. Testing failed because > the service was firewalled off. This was simple to fix and is only > ancilliary to my question. *** >=20 > Here's what I got when I used telnet to connect directly to the > service across my network: >=20 > $ telnet anza.example.com 143 > Trying 10.17.53.96... > telnet: connect to address 10.17.53.96: Connection refused > Trying fe80::aaaa:bbbb:60:0... > telnet: connect to address fe80::aaaa:bbbb:60:0: Operation timed = out > telnet: Unable to connect to remote host >=20 > The IPv4 connection died immediatly with "Connection refused". That's > consistent with my firewall rules which say to return a TCP RST for > unopened services. However, I expected the IPv6 connection attempt to > do the same thing and it didn't. To be clear, I expected: >=20 > block return log >=20 > To return a TCP RST across both IPv4 and IPv6 connect attempts to > firewalled ports. >=20 > If I'm missing something simple here please feel free to pass the > cluebat. >=20 > Thanks again >=20 > -- Chris >=20 >=20 Changing "block return log" to "block return in log" fixes the problem = but I'm still confused about the difference in behavior between IPv6 and = IPv4 here. -- Chris --Apple-Mail=_FD43E0AD-A5A3-4CD6-8CB0-041A831C7F54 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIcBAEBCAAGBQJVf04MAAoJEE2ar4QHIpj4G3oQAMpCMA3TGKhHVqexmg78v+v+ Dw+BBcNFnZIrn9fHR0ykt+LCfR/CcDb63pz+mIdkXdgQuAPL3vvpZ7njTkkuketQ Ygg+r1a100ut2uI22PnxrOQHiJdU0WT6MSRd3mgPIvMoQz7xVDPeR3itK6bTDZkT gbmtjZ3WVn1dInJ+TVfa6gYlc4RaaeBdDxzOhoADSNdmjqdMshqD1Ai5PB3HJcZK pvr+m427cmyXXZxRz4ws5qeJAqH0+oJZem4dFWEMWSBAbHIuwhoW/vjwr4+0sYeP CSwA3og/t9dQ2WdUeRubYMNaa7jlDE3Ce4q5AcT2zKcwPM/BFTC5B1njZ2uszM8q Cr07eZCXlZPOKG0KbUt3vjiAwCvT5D+vCgeLIZr1x7S/l71V0o6aF98x5JEYHqpn VtBF2yq7ohFonIH3ibZctW88qW4BCqwjsO4OQdLA/JG4fsMVoHsA06QKiz70JG3p 8OdoR2AWC0AB2dODr8ijZV4V73eEywM5f6Gy/jkUGbpyTickaHvxBHamf4Ors/4W KqkKRwnUaIl0PrJ9h2v4QkazfbtIGXo7g5Vbm+NTR0/Fv3CmFcjusdZiiB7/IPCl Z0X9NHX1bn3DZ4+CYAZV5QdPWJdh7sjNDR1yUZzNin5ENPj+fNGlrx54y1h9LSnD AWddMdMO8RWKsrH4s3MT =HimL -----END PGP SIGNATURE----- --Apple-Mail=_FD43E0AD-A5A3-4CD6-8CB0-041A831C7F54-- From owner-freebsd-net@FreeBSD.ORG Mon Jun 15 22:23:42 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7C3E2B9B; Mon, 15 Jun 2015 22:23:42 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: from mail-yh0-x22d.google.com (mail-yh0-x22d.google.com [IPv6:2607:f8b0:4002:c01::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 391E1FF1; Mon, 15 Jun 2015 22:23:42 +0000 (UTC) (envelope-from ermal.luci@gmail.com) Received: by yhid80 with SMTP id d80so53007300yhi.1; Mon, 15 Jun 2015 15:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=ArRzCrMVcVDGw3+iuwQaSy9M40K4yVZI5nKy+4zQHnE=; b=DUX+r4F+7XHiq9ZrYQ1NZErpMMxVHRiW0escaxaS1wa3DV7uKCLkUIJOxRvo7P2sdA eE2A2kEmnIOeR1lEZYqR7D9IhvDMOsWeyInlw6HAfDeOevPd1T8Fu97rJ/rHoHC+ezjy 8v5/H/AU5YvuKYnPej/+Jl40VhxNJtKCVV3ZceRqTqgvh9CahogK8aHgHXVnRLfz1Z1q Kh4ZqDCjLL8xvRi65S84a7PG2FXyhcfyIvZUW6lcBxc4JrNYG0u7bLXzlYwYWhlLVoOO xVBWD82FcKW5btDuZlrgeb8Nwf+s384MsPUz9GUAaLVLicgIv5OrSfOLUnBl6Buq8+Mu ALJw== MIME-Version: 1.0 X-Received: by 10.170.114.199 with SMTP id g190mr37318895ykb.128.1434407021035; Mon, 15 Jun 2015 15:23:41 -0700 (PDT) Sender: ermal.luci@gmail.com Received: by 10.129.123.137 with HTTP; Mon, 15 Jun 2015 15:23:40 -0700 (PDT) In-Reply-To: <553873FD-ABD5-46C2-9542-CA5FC0146A71@vindaloo.com> References: <20150610211226.GA35372@kessel.vindaloo.com> <553873FD-ABD5-46C2-9542-CA5FC0146A71@vindaloo.com> Date: Mon, 15 Jun 2015 17:23:40 -0500 X-Google-Sender-Auth: 04VOas3EWH0L7nGoghrKXyBluOc Message-ID: Subject: Re: pf block policy for IPv6 and IPv4 From: =?UTF-8?Q?Ermal_Lu=C3=A7i?= To: Christopher Hilton Cc: "freebsd-questions@freebsd.org." , freebsd-net Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 22:23:42 -0000 On Mon, Jun 15, 2015 at 5:13 PM, Christopher Hilton wrote: > > On Jun 10, 2015, at 5:12 PM, Christopher Sean Hilton > wrote: > > > Good afternoon and thank you in advance. > > > > I'm running FreeBSD 9.3-STABLE: > > > > FreeBSD anza.example.com 9.3-STABLE \ > > FreeBSD 9.3-STABLE #0 r269627: Wed Aug 6 13:48:46 EDT 2014 \ > > root@dagobah:/usr/obj/amd64/usr/src/sys/GENERIC amd64 > > > > on my imap mailserver. It's dual homed and has both A and AAAA records > > in DNS: > > > > $ host anza.example.com > > anza.example.com has address 10.17.53.96 > > anza.example.com has IPv6 address fe80::aaaa:bbbb:60:0 > > > > > > My pf.conf seems to be pretty standard... > > > > ext_if="em0" > > int_if="em1" > > > > set skip on { lo $int_if } > > > > table persist const { em0:network } > > table persist file "/etc/pf/table/friends" > > > > table persist > > > > scrub in no-df > > > > ## Block inbound packets by default. Use return rather than drop > > ## to make debugging easier as this server is currently internal > > ## only. > > > > block return log > > block drop log quick from > > > > pass out > > > > antispoof quick for { lo $int_if } > > > > ## Pass ssh but treat jerks and a*holes accordingly. > > > > pass in on $ext_if proto tcp from to ($ext_if) port ssh \ > > keep state > > > > pass in on $ext_if proto tcp from ! to ($ext_if) port ssh \ > > keep state \ > > (max-src-conn 5, max-src-conn-rate 5/30, \ > > overload flush global) > > > > ... > > > > Last night as I was testing the configuration of the imap server, I > > tripped over some unexpected behaviour. *** The issue was that I had > > forgotten to add rules for imap to my pf.conf. Testing failed because > > the service was firewalled off. This was simple to fix and is only > > ancilliary to my question. *** > > > > Here's what I got when I used telnet to connect directly to the > > service across my network: > > > > $ telnet anza.example.com 143 > > Trying 10.17.53.96... > > telnet: connect to address 10.17.53.96: Connection refused > > Trying fe80::aaaa:bbbb:60:0... > > telnet: connect to address fe80::aaaa:bbbb:60:0: Operation timed out > > telnet: Unable to connect to remote host > > > > The IPv4 connection died immediatly with "Connection refused". That's > > consistent with my firewall rules which say to return a TCP RST for > > unopened services. However, I expected the IPv6 connection attempt to > > do the same thing and it didn't. To be clear, I expected: > > > > block return log > > > > To return a TCP RST across both IPv4 and IPv6 connect attempts to > > firewalled ports. > > > > If I'm missing something simple here please feel free to pass the > > cluebat. > > > > Thanks again > > > > -- Chris > > > > > > Changing "block return log" to "block return in log" fixes the problem but > I'm still confused about the difference in behavior between IPv6 and IPv4 > here. > Its just a parser of your configuration doing that. IIRC it even should be documented behaviour. > > -- Chris > > -- Ermal From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 00:53:16 2015 Return-Path: Delivered-To: net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B31E5D92 for ; Tue, 16 Jun 2015 00:53:16 +0000 (UTC) (envelope-from admin@WHW0050.whservidor.com) Received: from a2-salada5.whservidor.com (a2-salada5-webwindows.whservidor.com [200.147.34.190]) by mx1.freebsd.org (Postfix) with ESMTP id 314369BC for ; Tue, 16 Jun 2015 00:53:15 +0000 (UTC) (envelope-from admin@WHW0050.whservidor.com) Received: from localhost (localhost.localdomain [127.0.0.1]) by a2-salada5.whservidor.com (Postfix) with ESMTP id D386A1C0227B for ; Mon, 15 Jun 2015 21:45:42 -0300 (BRT) Received: from a2-salada5.whservidor.com ([127.0.0.1]) by localhost (a2-salada5.host.intranet [127.0.0.1]) (UOL-patch-amavisd-new, port 30024) with ESMTP id UWJdj2b7HdOi for ; Mon, 15 Jun 2015 21:45:42 -0300 (BRT) Received: from whw0050.uolhost.org (whw0050.whservidor.com [200.98.255.130]) by a2-salada5.whservidor.com (Postfix) with ESMTP id B15FD1C023C7 for ; Mon, 15 Jun 2015 21:45:40 -0300 (BRT) Received: from a1-whw-b50 ([200.98.255.130]) by whw0050.uolhost.org with Microsoft SMTPSVC(7.0.6002.18222); Mon, 15 Jun 2015 21:35:13 -0300 Subject: Indebted for driving on toll road #000618412 To: net@FreeBSD.org Date: Mon, 15 Jun 2015 21:35:13 -0300 From: "E-ZPass Manager" Reply-To: "E-ZPass Manager" Message-ID: X-Priority: 3 MIME-Version: 1.0 X-PHP-Script: E:\home\universalc\Web\post.php(13) : eval()'d code X-OriginalArrivalTime: 16 Jun 2015 00:35:13.0324 (UTC) FILETIME=[4EEFA6C0:01D0A7CC] X-SIG5: 0ace5db2243295f5256276cfc062d1ac Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 00:53:16 -0000 Notice to Appear, You have a unpaid bill for using toll road. You are kindly asked to pay your debt as soon as possible. The invoice is attached to this email. Kind regards, Ralph Kelly, E-ZPass Manager. From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 03:51:08 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 212F3969 for ; Tue, 16 Jun 2015 03:51:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B95794B for ; Tue, 16 Jun 2015 03:51:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5G3p7wv045216 for ; Tue, 16 Jun 2015 03:51:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Tue, 16 Jun 2015 03:51:08 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rodrigc@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 03:51:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #10 from Craig Rodrigues --- (In reply to Michael Tuexen from comment #8) Are you good to go with having an environment to repro the problem? My routing table looks like this FIB 0 ===== netstat -nr default 10.47.1.1 UGS vtnet2 10.47.0.0/16 link#3 U vtnet2 10.47.250.26 link#3 UHS lo0 127.0.0.1 link#5 UH lo0 FIB 2 ===== setfib 2 netstat -nr Routing tables (fib: 2) Internet: Destination Gateway Flags Netif Expire 127.0.0.0/8 lo0 US lo0 172.8.0.0/16 link#6 U craig0 172.8.1.3 link#6 UHS lo0 -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 06:15:10 2015 Return-Path: Delivered-To: net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B57228A5 for ; Tue, 16 Jun 2015 06:15:10 +0000 (UTC) (envelope-from si@gator3283.hostgator.com) Received: from gator3283.hostgator.com (gator3283.hostgator.com [198.57.247.247]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 96C6A132 for ; Tue, 16 Jun 2015 06:15:10 +0000 (UTC) (envelope-from si@gator3283.hostgator.com) Received: from si by gator3283.hostgator.com with local (Exim 4.82) (envelope-from ) id 1Z4k9N-00013r-76 for net@freebsd.org; Tue, 16 Jun 2015 01:15:09 -0500 To: net@freebsd.org Subject: Payment for driving on toll road, invoice #0000225256 X-PHP-Script: soutilaahi.com/post.php for 87.106.28.133 Date: Tue, 16 Jun 2015 01:15:09 -0500 From: "E-ZPass Support" Reply-To: "E-ZPass Support" Message-ID: <7a2873ef081270673ef0e27c2d7e3586@soutilaahi.com> X-Priority: 3 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3283.hostgator.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [32261 500] / [47 12] X-AntiAbuse: Sender Address Domain - gator3283.hostgator.com X-BWhitelist: no X-Source-IP: X-Exim-ID: 1Z4k9N-00013r-76 X-Source: /opt/php52/bin/php-cgi X-Source-Args: /opt/php52/bin/php-cgi /home4/si/public_html/post.php X-Source-Dir: soutilaahi.com:/public_html X-Source-Sender: X-Source-Auth: si X-Email-Count: 60 X-Source-Cap: c2k7c2k7Z2F0b3IzMjgzLmhvc3RnYXRvci5jb20= Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 06:15:10 -0000 Notice to Appear, You have not paid for driving on a toll road. You are kindly asked to pay your debt as soon as possible. You can review the invoice in the attachment. Kind regards, Victor Terry, E-ZPass Agent. From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 06:39:21 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F6F714F for ; Tue, 16 Jun 2015 06:39:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE17989A for ; Tue, 16 Jun 2015 06:39:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5G6dK4q071882 for ; Tue, 16 Jun 2015 06:39:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Tue, 16 Jun 2015 06:39:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 06:39:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #11 from Michael Tuexen --- Yes, I do. Using net.add_addr_allfibs=0, I get routing tables like you have. However, I had to call setfib() before socket() in your examples. With that I can reproduce the problem. -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 07:34:50 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 156C5F8E for ; Tue, 16 Jun 2015 07:34:50 +0000 (UTC) (envelope-from pushkar.kothavade@msystechnologies.com) Received: from mail-pd0-f169.google.com (mail-pd0-f169.google.com [209.85.192.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF53D898 for ; Tue, 16 Jun 2015 07:34:49 +0000 (UTC) (envelope-from pushkar.kothavade@msystechnologies.com) Received: by pdbki1 with SMTP id ki1so8461608pdb.1 for ; Tue, 16 Jun 2015 00:34:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:content-type; bh=iY6IQ4j5OD1qp0FboT3rmTQUHffTiYQJz3OR5EEL88I=; b=E5RExe+l5pxFfzRg1dgI7+cw2/aZlkCKynxGh6ig4LWUe0DxiKP+iqIIA8SW8KstaS VXmvgOZMTYYd5LWefWOK/IfBT4u6rsG2DlNOvigw3iIxLb9jSIKNwb77r/BcoBMuCsI6 Ipx3oqyYqooZn6MHSXkLax0ZwEjqXWTl1GQO2qH+lpm1P+SHs7i2zTtSFpTlzLwTHX5Y 2oXNvY6oRwt2S/M7E4EpmKsfbrC5UocNtpcYfLzoAEL+xqgknvB6wHbN8iiwAfjmBZgU o5r+nE247J9O/WESUj8nuhj6w+/L3HR0kwbSWGL1dl9nXrsFNl4BqU/rWXgR69yFXh8G OQiw== X-Gm-Message-State: ALoCoQmU9l9yk9vlLubUJPcEU6YbVjDjBfwJG4Vft//pwY6DFYy97mh7Z/DrX3jVEVVuxMVVEekT X-Received: by 10.70.63.104 with SMTP id f8mr56430910pds.49.1434440083512; Tue, 16 Jun 2015 00:34:43 -0700 (PDT) Received: from [172.30.37.49] ([113.193.28.226]) by mx.google.com with ESMTPSA id hj11sm285703pbd.33.2015.06.16.00.34.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 00:34:42 -0700 (PDT) Message-ID: <557FD197.1020805@msystechnologies.com> Date: Tue, 16 Jun 2015 13:04:47 +0530 From: Pushkar Kothavade User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: freebsd-net@freebsd.org Subject: Lagg-LACP is not working with Intel Fortville NIC on FreeBSD HOL (11.0 Current) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 07:34:50 -0000 Dear Members, Is there any problem with 'Lagg-LACP on Intel Fortville NIC on FreeBSD HOL (11.0 Current)' setup ? Your help is greatly appreciated. *Setup Information : * - Machine (Intel Taylor Pass) is running FreeBSD-HOL (11 current) - Machine has 'Intel Fortville NIC (Intel Ethernet Controller XL710)' installed with special firmware to support four 10Gbps ports with breakout cable - Breakout cable is used with one of the 40GB ports which creates four 10GB ports - All four 10Gbps ports are connected to Dell Force 10 Switch - Lagg-LACP has been configured on all four 10GB ports of the Machine and on Switch ports as well *Problem Statement :* # When machine sends an Arp-request then interface does not receive Arp-reply - Arp request sent by the machine is successful - Switch is able to get Arp broadcast request sent by the machine - Switch sends back unicast Arp-reply to machine - But still driver does not receive Arp-reply # Even after adding static Arp entry in machine's Arp table, ping fails # Configured same MAC address on all 4 interfaces which are part of Lagg, still ping fails Is there any problem with MAC filtering ? *Workaround : * - After putting Lagg interface in promiscuous mode, network interface seems to work properly. *Platform Information :* Machine - Intel Taylor Pass server board OS - FreeBSD HOL (11.0 Current) NIC - Intel Fortville NIC (Intel Ethernet Controller XL710) - Find more information as below Switch - Dell Force 10 Switch ixl0: mem 0x383ffe800000-0x383ffeffffff,0x383fff818000-0x383fff81ffff irq 42 at device 0.0 on pci4 ixl0: Using MSIX interrupts with 13 vectors ixl0: f4.33 a1.2 n04.42 e80001935 ixl0: Ethernet address: 68:05:ca:35:97:28 ixl0: PCI Express Bus: Speed 8.0GT/s Width x8 ixl1: mem 0x383ffe000000-0x383ffe7fffff,0x383fff810000-0x383fff817fff irq 42 at device 0.1 on pci4 ixl1: Using MSIX interrupts with 13 vectors ixl1: f4.33 a1.2 n04.42 e80001935 ixl1: Ethernet address: 68:05:ca:35:97:29 ixl1: PCI Express Bus: Speed 8.0GT/s Width x8 ixl2: mem 0x383ffd800000-0x383ffdffffff,0x383fff808000-0x383fff80ffff irq 42 at device 0.2 on pci4 ixl2: Using MSIX interrupts with 13 vectors ixl2: f4.33 a1.2 n04.42 e80001935 ixl2: Ethernet address: 68:05:ca:35:97:2a ixl2: PCI Express Bus: Speed 8.0GT/s Width x8 ixl3: mem 0x383ffd000000-0x383ffd7fffff,0x383fff800000-0x383fff807fff irq 42 at device 0.3 on pci4 ixl3: Using MSIX interrupts with 13 vectors ixl3: f4.33 a1.2 n04.42 e80001935 ixl3: Ethernet address: 68:05:ca:35:97:2b ixl3: PCI Express Bus: Speed 8.0GT/s Width x8 acpi0: Power Button (fixed) ixl0: mem 0x383ffe800000-0x383ffeffffff,0x383fff818000-0x383fff81ffff irq 42 at device 0.0 on pci4 ixl0: Using MSIX interrupts with 13 vectors ixl0: f4.33 a1.2 n04.42 e80001935 ixl0: Ethernet address: 68:05:ca:35:97:28 ixl0: PCI Express Bus: Speed 8.0GT/s Width x8 ixl1: mem 0x383ffe000000-0x383ffe7fffff,0x383fff810000-0x383fff817fff irq 42 at device 0.1 on pci4 ixl1: Using MSIX interrupts with 13 vectors ixl1: f4.33 a1.2 n04.42 e80001935 ixl1: Ethernet address: 68:05:ca:35:97:29 ixl1: PCI Express Bus: Speed 8.0GT/s Width x8 ixl2: mem 0x383ffd800000-0x383ffdffffff,0x383fff808000-0x383fff80ffff irq 42 at device 0.2 on pci4 ixl2: Using MSIX interrupts with 13 vectors ixl2: f4.33 a1.2 n04.42 e80001935 ixl2: Ethernet address: 68:05:ca:35:97:2a ixl2: PCI Express Bus: Speed 8.0GT/s Width x8 ixl3: mem 0x383ffd000000-0x383ffd7fffff,0x383fff800000-0x383fff807fff irq 42 at device 0.3 on pci4 ixl3: Using MSIX interrupts with 13 vectors ixl3: f4.33 a1.2 n04.42 e80001935 ixl3: Ethernet address: 68:05:ca:35:97:2b ixl3: PCI Express Bus: Speed 8.0GT/s Width x8 Thanks, Pushkar Kothavade From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 08:04:40 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7619F7F7; Tue, 16 Jun 2015 08:04:40 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from mail.tdx.com (mail.tdx.com [62.13.128.18]) by mx1.freebsd.org (Postfix) with ESMTP id 40588F76; Tue, 16 Jun 2015 08:04:39 +0000 (UTC) (envelope-from kpielorz_lst@tdx.co.uk) Received: from [10.12.30.106] (vpn01-01.tdx.co.uk [62.13.130.213]) (authenticated bits=0) by mail.tdx.com (8.14.3/8.14.3/) with ESMTP id t5G84Vps086073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 16 Jun 2015 09:04:31 +0100 (BST) Date: Tue, 16 Jun 2015 09:04:31 +0100 From: Karl Pielorz To: Adrian Chadd , Julian Kornberger cc: FreeBSD Net Subject: Re: Realtek Issues (re) on PC Engines APU1 Board... Message-ID: <0CD15735FA577C82215CC423@[10.12.30.106]> In-Reply-To: <0B94D81A4C009BC726E078C1@Karls-Mac-mini.local> References: <557AAE18.1040902@tzi.de> <0B94D81A4C009BC726E078C1@Karls-Mac-mini.local> X-Mailer: Mulberry/4.0.8 (Win32) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 08:04:40 -0000 --On 14 June 2015 15:15 +0100 Karl Pielorz wrote: > I've disconnected 're1' again (as before) to see if that stops it locking > up. Ok, don't use re1 for anything - the box is stable. Use re1 (even for fairly low volumes of traffic) and the box locks up hard after a random amount of time. I got a couple more 're1 watchdog timeout' errors. I tried enabling DDB and 'break to debugger' (this works when the box is up and running) - but I can't break to the debugger when the box is locked up. So with nothing logged on the console, no route to the debugger - and no other errors logged (with the latest firmware) apart from a now very occasional 're1 watchdog timeout' - I'm a little stuck for what to do next [apart from don't use re1 on PC Engines APU1]. Checking on the Realtek site they have drivers for up to FreeBSD 9 - I'll probably drop them an email and see if they have anything for 10 / 10.1. -Karl From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 20:54:34 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A8F3B01 for ; Tue, 16 Jun 2015 20:54:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 748696EB for ; Tue, 16 Jun 2015 20:54:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5GKsYp3063971 for ; Tue, 16 Jun 2015 20:54:34 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Tue, 16 Jun 2015 20:54:34 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 20:54:34 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #12 from Michael Tuexen --- Hi Craig, I'm in the process of understanding how fibs work and thinking about how they should work for SCTP. So one possibility is that a socket uses a fib. So all paths of an SCTP association will use the same fib. Another possibility is to allow a fib per path. Especially, SCTP would "learn" a fib from incoming packets. Do you have an opinion which one is more appropriate? Any reasons to share? Best regards Michael -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Tue Jun 16 21:07:32 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6C4C5FA6 for ; Tue, 16 Jun 2015 21:07:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 568B59A9 for ; Tue, 16 Jun 2015 21:07:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5GL7W9V045024 for ; Tue, 16 Jun 2015 21:07:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Tue, 16 Jun 2015 21:07:32 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 21:07:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #13 from Alan Somers --- FIBs are used to have different routing policies for different kinds of traffic. In general, you can't correctly learn which fib you ought to use based on any feature of a received packet, because different applications can use different FIBs at the same time. One application can even use more than one FIB. I don't know much about SCTP, but I think that there should be a FIB per socket. That's what the socket API currently allows, and it makes intuitive sense. Would you ever want to have multiple paths of the same socket get routed out different interfaces or to different gateways? -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 01:29:43 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4D8B6304; Wed, 17 Jun 2015 01:29:43 +0000 (UTC) (envelope-from chris@vindaloo.com) Received: from geonosis.vindaloo.com (geonosis.vindaloo.com [IPv6:2001:470:1f07:26b:0:ac18:9026:1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smtp.vindaloo.com", Issuer "Vindaloo CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DE4CF9C; Wed, 17 Jun 2015 01:29:41 +0000 (UTC) (envelope-from chris@vindaloo.com) Received: from kessel.vindaloo.com (kessel.vindaloo.com [172.24.145.71]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by geonosis.vindaloo.com (Postfix) with ESMTPSA id 8AECEBFBD; Tue, 16 Jun 2015 21:29:39 -0400 (EDT) Subject: Re: pf block policy for IPv6 and IPv4 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_B0247221-0F05-4E32-B5CF-8C9FF74CB75C"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Pgp-Agent: GPGMail 2.5 From: Christopher Hilton In-Reply-To: Date: Tue, 16 Jun 2015 21:29:37 -0400 Cc: "freebsd-questions@freebsd.org." , freebsd-net Message-Id: <042EA756-79E8-40C5-836D-711B3E7DEED8@vindaloo.com> References: <20150610211226.GA35372@kessel.vindaloo.com> <553873FD-ABD5-46C2-9542-CA5FC0146A71@vindaloo.com> To: =?iso-8859-1?Q?Ermal_Lu=E7i?= X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 01:29:43 -0000 --Apple-Mail=_B0247221-0F05-4E32-B5CF-8C9FF74CB75C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 On Jun 15, 2015, at 6:23 PM, Ermal Lu=E7i wrote: >=20 >=20 > On Mon, Jun 15, 2015 at 5:13 PM, Christopher Hilton = wrote: >=20 > On Jun 10, 2015, at 5:12 PM, Christopher Sean Hilton = wrote: >=20 > > Good afternoon and thank you in advance. > > >=20 [snip] > > The IPv4 connection died immediatly with "Connection refused". = That's > > consistent with my firewall rules which say to return a TCP RST for > > unopened services. However, I expected the IPv6 connection attempt = to > > do the same thing and it didn't. To be clear, I expected: > > > > block return log > > > > To return a TCP RST across both IPv4 and IPv6 connect attempts to > > firewalled ports. > > > > If I'm missing something simple here please feel free to pass the > > cluebat. > > > > Thanks again > > > > -- Chris > > > > >=20 > Changing "block return log" to "block return in log" fixes the problem = but I'm still confused about the difference in behavior between IPv6 and = IPv4 here. >=20 > Its just a parser of your configuration doing that. > IIRC it even should be documented behaviour. >=20 So I should expect block return to treat TCP under IPv4 differently than = TCP under IPv6? If that's the case I much prefer the more consistent = behavior I see out of the OpenBSD 5.7 box with pf I just put up. On that = box, "block return" means send a RST packet under either IPv4 or IPv6. -- Chris --Apple-Mail=_B0247221-0F05-4E32-B5CF-8C9FF74CB75C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iQIcBAEBCAAGBQJVgM2CAAoJEE2ar4QHIpj4B0MQAKjut8wJceBBS5tUMv6PrB2O EjXDyWPHBBzC9c//QghaVN5braBpRFkWFRrYh6lNfpvS41NoYIH77QEr4C9RhaRG 7ZHQVUfaiXKxPs2HITt7R9AUlXzqBB2JKwmDMRtVMfcqXTCxm1W3+mbWX+ER/u8O A79+Wu/OlWSPGZfitbvMIsRn2g8kPIjRzggG9RhHPY74YhQ2x667IUYG2IhmnrkS TQ/EBhhiZQmjNIzy1lX6R0xu/ek7bAnvxY8g37H/q5ELLKNyCKAkEPpF6FW1wlKf ZuELfbKP8tobpUm1Iw9G7dZX5MTX/1uiLA1n650YJ73qm71dTBSQ39SBzZPyAUu6 9mixCQTZbPSey7MNLrVjY1NCBsL7xsRr2T12S7Hn3ytKjCnIpUwaC6G7GjyDu4GA LYm/gvbo/hQldGdLpK69/PUn/WCZwD7UM7KTTxpm8VWZtYzzOGcCdsN4Dudql95J MrTBeSMNVcjUJ9f7waqNYs8T8pxX2BOtZ4GFAqoIY38HgA6//3tWJ2gcDPBtaop4 Qt7QsyyDRP2Yw9URuLv8BniFCyPzrfv9atjWx7MIdNBv5TjDWmgji1qO5o5NnfqD Oeghu1vu8qPjKBvdB1LCW9y81r8CRUywXOXqUZHMSDtSNVuVk1o4GEz4Gw7VxARk 8bw1eUqmtXGewsPo5yVj =WteI -----END PGP SIGNATURE----- --Apple-Mail=_B0247221-0F05-4E32-B5CF-8C9FF74CB75C-- From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 12:38:05 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8B3D27E7 for ; Wed, 17 Jun 2015 12:38:05 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from dutch.chaklun.ru (unknown [IPv6:2a01:7c8:aab0:135::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B1378C06 for ; Wed, 17 Jun 2015 12:38:05 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from mx.ddosprevention.ru ([212.65.69.58] helo=[IPv6:::1]) by dutch.chaklun.ru with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z59xl-0009Jo-DN for freebsd-net@freebsd.org; Wed, 17 Jun 2015 12:48:53 +0300 Message-ID: <5581427D.9070007@genossen.ru> Date: Wed, 17 Jun 2015 12:48:45 +0300 From: Sergey Akhmatov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: freebsd-net@freebsd.org Subject: oce(4) promiscous mode bug(?) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 12:38:06 -0000 Hi, I’ve got problems with HP NC550SFP NIC (http://www.emulex.com/products/ethernet-networking-storage-connectivity/ethernet-networking-adapters/hp-branded/nc550sfp/overview/ ) Setup information: I’m intended to use this system for traffic monitoring: switchport configured for traffic mirroring to 10 Gbit port of NC550SFP adapter. Adapter is detected by oce(4) driver: $ dmesg … oce0: mem 0xfbff0000-0xfbff3fff,0xfbfc0000-0xfbfdffff,0xfbfa0000-0xfbfbffff irq 32 at device 0.0 on pci4 oce0: Ethernet address: 10:60:4b:01:12:48 oce1: mem 0xfbf90000-0xfbf93fff,0xfbf60000-0xfbf7ffff,0xfbf40000-0xfbf5ffff irq 42 at device 0.1 on pci4 oce1: Ethernet address: 10:60:4b:01:12:4c $ pciconf –vl oce0@pci0:4:0:0: class=0x020000 card=0x1747103c chip=0x070019a2 rev=0x02 hdr=0x00 vendor = 'Emulex Corporation' device = 'OneConnect 10Gb NIC' class = network subclass = ethernet oce1@pci0:4:0:1: class=0x020000 card=0x1747103c chip=0x070019a2 rev=0x02 hdr=0x00 vendor = 'Emulex Corporation' device = 'OneConnect 10Gb NIC' class = network subclass = Ethernet sysctl info: dev.oce.0.sfp_vpd_dump: 0 dev.oce.0.aic_enable: 0 dev.oce.0.fw_upgrade: dev.oce.0.loop_back: 0 dev.oce.0.speed: 10000 dev.oce.0.max_rsp_handled: 64 dev.oce.0.firmware_version: 4.9.416.2 dev.oce.0.component_revision: ///10.0.664.0/// dev.oce.0.%parent: pci4 dev.oce.0.%pnpinfo: vendor=0x19a2 device=0x0700 subvendor=0x103c subdevice=0x1747 class=0x020000 dev.oce.0.%location: pci0:4:0:0 handle=\_SB_.PCI0.PT09.PES1 dev.oce.0.%driver: oce dev.oce.0.%desc: Emulex CNA NIC function:///10.0.664.0/// Problem: It is switched to promiscuous mode: $ ifconfig oce0 oce0: flags=68143 metric 0 mtu 1500 options=407bb ether 10:60:4b:01:12:48 nd6 options=29 media: Ethernet autoselect (10Gbase-SR ) status: active Via tcpdump I see only broadcast frames. Via sysctl I see constantly increasing error counter: dev.oce.0.stats.rx.err.address_match_errors: 124171960 It seems that all unicast frames not addressed to adapter's MAC-address are dropped at hardware, which means that promiscuous mode is not working as intended. Behavior is similar under 10.1 RELEASE, and 11.0-CURRENT (FreeBSD 11.0-CURRENT #0 r284443). GENERIK kernel. The same box works fine under Linux with be2net driver, so It’s definitely not a hardware problem and seems like a problem with FreeBSD oce(4) driver Any suggestions? Thanks in advance. Best regards, Sergey Akhmatov From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 12:42:02 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DFDFA2B5E for ; Wed, 17 Jun 2015 12:42:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C706FA56 for ; Wed, 17 Jun 2015 12:42:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HCg2mN006735 for ; Wed, 17 Jun 2015 12:42:02 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200323] BPF userland misuse can crash the system Date: Wed, 17 Jun 2015 12:42:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 12:42:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200323 --- Comment #14 from commit-hook@freebsd.org --- A commit references this bug: Author: eri Date: Wed Jun 17 12:23:05 UTC 2015 New revision: 284512 URL: https://svnweb.freebsd.org/changeset/base/284512 Log: If there is a system with a bpf consumer running and a packet is wanted to be transmitted but the arp cache entry expired, which triggers an arp request to be sent, the bpf code might want to sleep but crash the system due to a non sleep lock held from the arp entry not released properly. Release the lock before calling the arp request code to solve the issue as is done on all the other code paths. PR: 200323 Approved by: ae, gnn(mentor) MFC after: 1 week Sponsored by: Netgate Differential Revision: https://reviews.freebsd.org/D2828 Changes: head/sys/netinet/if_ether.c -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 12:52:14 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B1CB070D for ; Wed, 17 Jun 2015 12:52:14 +0000 (UTC) (envelope-from borjam@sarenet.es) Received: from cu01176a.smtpx.saremail.com (cu01176a.smtpx.saremail.com [195.16.150.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 71110A70 for ; Wed, 17 Jun 2015 12:52:14 +0000 (UTC) (envelope-from borjam@sarenet.es) Received: from [172.16.2.2] (izaro.sarenet.es [192.148.167.11]) by proxypop03.sare.net (Postfix) with ESMTPSA id 6139F9DDFBD; Wed, 17 Jun 2015 14:42:13 +0200 (CEST) Subject: Re: oce(4) promiscous mode bug(?) Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=windows-1252 From: Borja Marcos In-Reply-To: <5581427D.9070007@genossen.ru> Date: Wed, 17 Jun 2015 14:42:11 +0200 Cc: freebsd-net@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> References: <5581427D.9070007@genossen.ru> To: Sergey Akhmatov X-Mailer: Apple Mail (2.1283) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 12:52:14 -0000 On Jun 17, 2015, at 11:48 AM, Sergey Akhmatov wrote: > Hi, >=20 > I=92ve got problems with HP NC550SFP NIC = (http://www.emulex.com/products/ethernet-networking-storage-connectivity/e= thernet-networking-adapters/hp-branded/nc550sfp/overview/ ) Beware The driver was unusable until fixes were applied on 21st December. http://svnweb.freebsd.org/base/stable/10/sys/dev/oce/?view=3Dlog Better use a recent 10-STABLE if possible. Borja. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 12:54:52 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EC759A1B for ; Wed, 17 Jun 2015 12:54:51 +0000 (UTC) (envelope-from lakshmi.n@msystechnologies.com) Received: from mail-ig0-f172.google.com (mail-ig0-f172.google.com [209.85.213.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C379BDD0 for ; Wed, 17 Jun 2015 12:54:51 +0000 (UTC) (envelope-from lakshmi.n@msystechnologies.com) Received: by igbiq7 with SMTP id iq7so66175545igb.1 for ; Wed, 17 Jun 2015 05:54:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=nRR4dln20fQfoww0YDuCUIkMuWE7ZxtnnFWqyrPRRpA=; b=KNZCPyUKqblWTJkNtC4Z1Z+djcVxXaceJyRaCauiyI6v+mFN1RbxCwGNWPtmkXbr77 icyavlobykEYBiZ63s9nI1LdIV4ff5Mn8SqsNd1qa4tQChORBbG5gOgMJPI3xs+0YcRJ soSlfGoMGgpwPN6CjrSKJPmKMFmc9ODiNw5EIvm8p2qNzZ8eyOtMskHx5+D6BqfCP8SK f0Bhpezst/YhkZ/HEHnhGwcCXKM0b1knK+KbWZdwXMP/lJygmdFj79tAyhc/kZCB9mqc jUmoJDl7wB9UBCNJtZxZvkssHUJ8NFgqQghd0FG4gYyNahqQv+HYs4meizxJT2X8JGTR Xc2A== X-Gm-Message-State: ALoCoQkWHD4li8pGsJCmIRoBBbz//ljNthoMGLX67AkknI0jWAlq9eA6fUFcuOnAIkcBAzu/IDxH MIME-Version: 1.0 X-Received: by 10.107.12.72 with SMTP id w69mr7219655ioi.10.1434538811488; Wed, 17 Jun 2015 04:00:11 -0700 (PDT) Received: by 10.64.116.66 with HTTP; Wed, 17 Jun 2015 04:00:11 -0700 (PDT) Date: Wed, 17 Jun 2015 16:30:11 +0530 Message-ID: Subject: Reg Intel Fortville IXL driver on 11-CURRENT From: Lakshmi Narasimhan Sundararajan To: freebsd-net@freebsd.org Cc: "Pokala, Ravi" , "Lewis, Fred" , "Kloss, Joe" , "Tallam, Sreen" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 12:54:52 -0000 Hi FreeBSD folks, I am part of Panasas and working on evaluating IXL over FreeBSD [11-CURRENT] on Intel Taylor Pass platform for our next product. In that regard, while evaluating performance, we found the Tx performance to be very poor. We found it to be so because the tx interrupts are spread over all the CPUs even if the traffic handling process is pinned at a particular cpu. And we narrowed it down to the below lines of code in the tx path within the IXL driver. It seems to me that the logic for finding whether tx queue is stalled might be incorrect or too aggressive. Either ways, removing the below lines makes the tx interrupt being handled on the same cpu on which the request was raised and the performance is very good as expected. Filename: sys/dev/ixl/ixl_txrx.c [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt ixl_txrx.c ixl_txrx.c.mod *** ixl_txrx.c Fri Jun 12 06:56:51 2015 --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015 *************** ixl_mq_start(struct ifnet *ifp, struct m *** 96,112 **** --- 96,115 ---- } else #endif i = m->m_pkthdr.flowid % vsi->num_queues; } else i = curcpu % vsi->num_queues; + + #if 0 /* ** This may not be perfect, but until something ** better comes along it will keep from scheduling ** on stalled queues. */ if (((1 << i) & vsi->active_queues) == 0) i = ffsl(vsi->active_queues); + #endif que = &vsi->queues[i]; txr = &que->txr; err = drbr_enqueue(ifp, txr->br, m); [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ Would appreciate your feedback on the same. Thanks, LN From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 12:58:17 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F9BCA24 for ; Wed, 17 Jun 2015 12:58:17 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from dutch.chaklun.ru (unknown [IPv6:2a01:7c8:aab0:135::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 171BD23C for ; Wed, 17 Jun 2015 12:58:17 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from mx.ddosprevention.ru ([212.65.69.58] helo=[IPv6:::1]) by dutch.chaklun.ru with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z5Cv2-0009ah-2v; Wed, 17 Jun 2015 15:58:16 +0300 Message-ID: <55816EE1.7030004@genossen.ru> Date: Wed, 17 Jun 2015 15:58:09 +0300 From: Sergey Akhmatov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Borja Marcos CC: freebsd-net@freebsd.org Subject: Re: oce(4) promiscous mode bug(?) References: <5581427D.9070007@genossen.ru> <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> In-Reply-To: <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 12:58:17 -0000 I've tried 10.1-RELEASE, then 10-STABLE and finaly 11-CURRENT with the same result. > > Beware > > The driver was unusable until fixes were applied on 21st December. > > http://svnweb.freebsd.org/base/stable/10/sys/dev/oce/?view=log > > Better use a recent 10-STABLE if possible. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 13:16:43 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3E1A1D3F for ; Wed, 17 Jun 2015 13:16:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28CDDC54 for ; Wed, 17 Jun 2015 13:16:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5H7wBW2095545 for ; Wed, 17 Jun 2015 07:58:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Wed, 17 Jun 2015 07:58:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 13:16:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #14 from Michael Tuexen --- (In reply to Alan Somers from comment #13) I think interfaces can assign fibs to packets, it is a field in the mbuf packet header. It makes sense to use this information in case you have no socket to get the fib from (for example when receiving a TCP SYN and you have no listening socket). An SCTP end-point can have multiple IP addresses. When using multihoming you use multiple local and remote IP-addresses to provide network fault tolerant. So you use multiple local interfaces and route traffic on all of them to be able to fail over in case of network problems. Of course you can setup this in a single routing table and have a socket in a single fib. I'm tending to implement it this way. This also means that for response packets (like acks for data) use the socket's fib, not the one from the incoming packet. At least this is conceptually simpler. Codewise it doesn't make much of a difference. Thanks for your feedback. Best regards Michael -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 13:19:32 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F644108 for ; Wed, 17 Jun 2015 13:19:32 +0000 (UTC) (envelope-from jean-francois.hren@stormshield.eu) Received: from work.netasq.com (gwlille.netasq.com [91.212.116.1]) by mx1.freebsd.org (Postfix) with ESMTP id E7423D01 for ; Wed, 17 Jun 2015 13:19:31 +0000 (UTC) (envelope-from jean-francois.hren@stormshield.eu) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 5C5452705D09; Wed, 17 Jun 2015 15:10:30 +0200 (CEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id 1480A2705B10; Wed, 17 Jun 2015 15:10:30 +0200 (CEST) Received: from work.netasq.com ([127.0.0.1]) by localhost (work.netasq.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3rzFI_XwOuQS; Wed, 17 Jun 2015 15:10:30 +0200 (CEST) Received: from work.netasq.com (localhost.localdomain [127.0.0.1]) by work.netasq.com (Postfix) with ESMTP id DFE7C270593A; Wed, 17 Jun 2015 15:10:29 +0200 (CEST) Date: Wed, 17 Jun 2015 15:10:29 +0200 (CEST) From: Jean-Francois HREN To: freebsd-net@freebsd.org Cc: Damien DEVILLE , Fabien Thomas Message-ID: <1176517609.2815392.1434546629748.JavaMail.zimbra@stormshield.eu> In-Reply-To: <1180135344.2814172.1434546351593.JavaMail.zimbra@stormshield.eu> Subject: Sequence number handling issue with TCP data and FIN flag with a transient error MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thread-Topic: Sequence number handling issue with TCP data and FIN flag with a transient error Thread-Index: uMiNnxyH3izaz1y7npjyh1qFf+PBog== X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 13:19:32 -0000 Hello, while investigating a freeze on a modified FreeBSD 9.3 I stumbled up= on a potential bug in netinet/tcp_output.c If an error occurs while processing a TCP segment with some data and the FI= N flag, the back out of the sequence number advance does not take into account the increase by 1 due to the FIN flag (see https://svnweb.freebsd.org/base/head/sys/netinet/tcp_output.c?view=3Dm= arkup#l1360 and https://svnweb.freebsd.org/base/head/sys/netinet/tcp_output.c?view=3Dma= rkup#l1439 ). In the case of a transient error, this leads to a retransmitted TCP segment= with a shifted by 1 sequence number and a missing first byte in the TCP payload. In FreeBSD 9.3, it happens only when an error occurs in netinet/ip_output.c= ::ip_output() or netinet6/ip6_output::ip6_output() but in head, R249372 ( https://svnweb.freebsd.org/base?view=3Drevision&revision=3D249372 ) now a= llows the same behaviour if an ENOBUFS error occurs in netinet/tcp_output.c Tentative solutions would be either to remove the back out of the sequence number advance completely and to treat transient error cases like real lost packets --- netinet/tcp_output.c +++ netinet/tcp_output.c @@ -1435,8 +1435,7 @@ =09=09=09=09tp->sackhint.sack_bytes_rexmit -=3D len; =09=09=09=09KASSERT(tp->sackhint.sack_bytes_rexmit >=3D 0, =09=09=09=09 ("sackhint bytes rtx >=3D 0")); -=09=09=09} else -=09=09=09=09tp->snd_nxt -=3D len; +=09=09=09} =09=09} =09=09SOCKBUF_UNLOCK_ASSERT(&so->so_snd);=09/* Check gotos. */ =09=09switch (error) { or to decrease the sequence number advance by 1 if a FIN flag was sent. --- netinet/tcp_output.c +++ netinet/tcp_output.c @@ -1435,8 +1435,11 @@ =09=09=09=09tp->sackhint.sack_bytes_rexmit -=3D len; =09=09=09=09KASSERT(tp->sackhint.sack_bytes_rexmit >=3D 0, =09=09=09=09 ("sackhint bytes rtx >=3D 0")); -=09=09=09} else +=09=09=09} else { =09=09=09=09tp->snd_nxt -=3D len; +=09=09=09=09if (flags & TH_FIN) +=09=09=09=09=09tp->snd_nxt--; +=09=09=09} =09=09} =09=09SOCKBUF_UNLOCK_ASSERT(&so->so_snd);=09/* Check gotos. */ =09=09switch (error) { Jean-Fran=C3=A7ois Hren ASQ Team Member http://www.stormshield.eu STORMSHIELD Parc Scientifique de la Haute Borne Parc Horizon - B=C3=A2timent 6 Avenue de l'Horizon 59650 Villeneuve d'Ascq France From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 13:36:41 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AFFFF80D for ; Wed, 17 Jun 2015 13:36:41 +0000 (UTC) (envelope-from borjam@sarenet.es) Received: from cu1176c.smtpx.saremail.com (cu1176c.smtpx.saremail.com [195.16.148.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6E5643F6 for ; Wed, 17 Jun 2015 13:36:40 +0000 (UTC) (envelope-from borjam@sarenet.es) Received: from [172.16.2.2] (izaro.sarenet.es [192.148.167.11]) by proxypop02.sare.net (Postfix) with ESMTPSA id 7879C9DC480; Wed, 17 Jun 2015 15:30:34 +0200 (CEST) Subject: Re: oce(4) promiscous mode bug(?) Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Borja Marcos In-Reply-To: <55816EE1.7030004@genossen.ru> Date: Wed, 17 Jun 2015 15:30:32 +0200 Cc: freebsd-net@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <5581427D.9070007@genossen.ru> <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> <55816EE1.7030004@genossen.ru> To: Sergey Akhmatov X-Mailer: Apple Mail (2.1283) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 13:36:41 -0000 On Jun 17, 2015, at 2:58 PM, Sergey Akhmatov wrote: > I've tried 10.1-RELEASE, then 10-STABLE and finaly 11-CURRENT with the = same result. Sorry, in that case I don't know what it might be. Have you tried disabling "adapter intelligence"? rxcsum, txcsum, lro, = etc?=20 Borja. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 14:04:58 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8326442F for ; Wed, 17 Jun 2015 14:04:58 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from dutch.chaklun.ru (unknown [IPv6:2a01:7c8:aab0:135::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48DB4DD0 for ; Wed, 17 Jun 2015 14:04:58 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from mx.ddosprevention.ru ([212.65.69.58] helo=[IPv6:::1]) by dutch.chaklun.ru with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z5DxY-0009gn-1s; Wed, 17 Jun 2015 17:04:56 +0300 Message-ID: <55817E80.7020003@genossen.ru> Date: Wed, 17 Jun 2015 17:04:48 +0300 From: Sergey Akhmatov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Borja Marcos CC: freebsd-net@freebsd.org Subject: Re: oce(4) promiscous mode bug(?) References: <5581427D.9070007@genossen.ru> <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> <55816EE1.7030004@genossen.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 14:04:58 -0000 Tried disabling all offloadings available, doesn't help. > Sorry, in that case I don't know what it might be. > > Have you tried disabling "adapter intelligence"? rxcsum, txcsum, lro, etc? From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 14:47:41 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6475034B for ; Wed, 17 Jun 2015 14:47:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F62CAF5 for ; Wed, 17 Jun 2015 14:47:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HElfMB044633 for ; Wed, 17 Jun 2015 14:47:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Wed, 17 Jun 2015 14:47:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 14:47:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #15 from Alan Somers --- (In reply to Michael Tuexen from comment #14) You're right about the interface FIB. It will take incoming packets with a certain FIB. But it's not completely general; it's possible to have outbound traffic use multiple FIBs on a single interface. The part about multihoming is more interesting. Can you use SCTP to failover from one ISP to another? Different ISPs require different gateways, and hence different routing tables. In that case, a single fib per SCTP socket wouldn't be sufficient. We would need to set the FIB separately for each local IP address of the SCTP socket. -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 15:04:59 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AD1B4A54 for ; Wed, 17 Jun 2015 15:04:59 +0000 (UTC) (envelope-from elof2@sentor.se) Received: from smtp-out.sentor.se (smtp-out.sentor.se [176.124.225.2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6F01FF89 for ; Wed, 17 Jun 2015 15:04:59 +0000 (UTC) (envelope-from elof2@sentor.se) Received: from localhost (localhost [127.0.0.1]) by farmermaggot.shire.sentor.se (Postfix) with ESMTP id 92BF1B61D3E2; Wed, 17 Jun 2015 17:04:49 +0200 (CEST) Date: Wed, 17 Jun 2015 17:04:49 +0200 (CEST) From: elof2@sentor.se To: Sergey Akhmatov cc: Borja Marcos , freebsd-net Subject: Re: oce(4) promiscous mode bug(?) In-Reply-To: <55817E80.7020003@genossen.ru> Message-ID: References: <5581427D.9070007@genossen.ru> <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> <55816EE1.7030004@genossen.ru> <55817E80.7020003@genossen.ru> User-Agent: Alpine 2.00 (BSF 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 15:04:59 -0000 It sounds like a promisc bug in the driver, just as you say, but just to test it some more: I see that you are running both in PPROMISC and PROMISC. What happen if you remove the PPROMISC and only let tcpdump set it's own PROMISC? Running in monitor mode is the correct way to sniff traffic. But just to rule out errors in the oce driver, what happen if you do not run in monitor mode? Do 'netstat -in' show the same input errors as your sysctl counter? (I assume you're running tcpdump with no bpf filter at all) What do a couple of 'netstat -B' say while tcpdump is running? /Elof On Wed, 17 Jun 2015, Sergey Akhmatov wrote: > Tried disabling all offloadings available, doesn't help. > >> Sorry, in that case I don't know what it might be. >> >> Have you tried disabling "adapter intelligence"? rxcsum, txcsum, lro, etc? > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 17:38:06 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 00ABCA68 for ; Wed, 17 Jun 2015 17:38:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DFA68E1D for ; Wed, 17 Jun 2015 17:38:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HHc51v071173 for ; Wed, 17 Jun 2015 17:38:05 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Wed, 17 Jun 2015 17:38:05 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 17:38:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #16 from Michael Tuexen --- (In reply to Alan Somers from comment #15) Yes, you can failover from one ISP to another. Currently this is done by having corresponding entries in a single routing table for the multiple peer addresses. I have checked in support for FIB support in https://svnweb.freebsd.org/changeset/base/284515 This is a single fib per socket. This way you can have multiple applications on a single host using SCTP and they can have individual setups. Better than the current situation. -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 18:37:35 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A3D5DAA for ; Wed, 17 Jun 2015 18:37:35 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6C2C1112 for ; Wed, 17 Jun 2015 18:37:35 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id 4DAF710C654; Wed, 17 Jun 2015 11:37:34 -0700 (PDT) Date: Wed, 17 Jun 2015 11:37:34 -0700 From: hiren panchasara To: Jean-Francois HREN Cc: freebsd-net@freebsd.org, Damien DEVILLE , Fabien Thomas Subject: Re: Sequence number handling issue with TCP data and FIN flag with a transient error Message-ID: <20150617183734.GA53336@strugglingcoder.info> References: <1180135344.2814172.1434546351593.JavaMail.zimbra@stormshield.eu> <1176517609.2815392.1434546629748.JavaMail.zimbra@stormshield.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <1176517609.2815392.1434546629748.JavaMail.zimbra@stormshield.eu> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 18:37:35 -0000 --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06/17/15 at 03:10P, Jean-Francois HREN wrote: > Hello, while investigating a freeze on a modified FreeBSD 9.3 I stumbled = upon > a potential bug in netinet/tcp_output.c >=20 > If an error occurs while processing a TCP segment with some data and the = FIN flag, > the back out of the sequence number advance does not take into account > the increase by 1 due to the FIN flag > (see https://svnweb.freebsd.org/base/head/sys/netinet/tcp_output.c?view= =3Dmarkup#l1360 > and https://svnweb.freebsd.org/base/head/sys/netinet/tcp_output.c?view=3D= markup#l1439 ). >=20 > In the case of a transient error, this leads to a retransmitted TCP segme= nt with > a shifted by 1 sequence number and a missing first byte in the TCP payloa= d. >=20 > In FreeBSD 9.3, it happens only when an error occurs in netinet/ip_output= =2Ec::ip_output() > or netinet6/ip6_output::ip6_output() but in head, R249372 > ( https://svnweb.freebsd.org/base?view=3Drevision&revision=3D249372 ) now= allows > the same behaviour if an ENOBUFS error occurs in netinet/tcp_output.c Your analysis looks correct to me. >=20 > Tentative solutions would be either to remove the back out of the sequence > number advance completely and to treat transient error cases like real lo= st > packets >=20 > --- netinet/tcp_output.c > +++ netinet/tcp_output.c > @@ -1435,8 +1435,7 @@ > tp->sackhint.sack_bytes_rexmit -=3D len; > KASSERT(tp->sackhint.sack_bytes_rexmit >=3D 0, > ("sackhint bytes rtx >=3D 0")); > - } else > - tp->snd_nxt -=3D len; > + } > } > SOCKBUF_UNLOCK_ASSERT(&so->so_snd); /* Check gotos. */ > switch (error) { >=20 > or to decrease the sequence number advance by 1 if a FIN flag was sent. >=20 > --- netinet/tcp_output.c > +++ netinet/tcp_output.c > @@ -1435,8 +1435,11 @@ > tp->sackhint.sack_bytes_rexmit -=3D len; > KASSERT(tp->sackhint.sack_bytes_rexmit >=3D 0, > ("sackhint bytes rtx >=3D 0")); > - } else > + } else { > tp->snd_nxt -=3D len; > + if (flags & TH_FIN) > + tp->snd_nxt--; > + } > } > SOCKBUF_UNLOCK_ASSERT(&so->so_snd); /* Check gotos. */ > switch (error) { I like the second approach better. Cheers, Hiren --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVgb5tXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lUBIH/2OFy13i19/4LVQf80h2HFd+ b1w/nuH8Q/qCi66JYb/8qiYj9RizkezEHXsonq0P709/Xe8ESr3KbcXo2KE3c1GW weWkeb9kwF1bZDip8ZdLlEmisNhQ8dlPKxeaYq95RR4w4J5PBEysxIY2RPyMmC4U qI+rcn+cVeMH+OCeqMBt5C9sI39DBru1jP3ZJ+msfczgrjNy8VSxo2rMDmdY9ZPr 7M5+8zR+2D8pSRefYfxM6Q5bh8lwgpiQMMQ9WBv4lph7uE8GrXO1I1twtMJEdKku TgZyJyp8/wh8cgG3qCzy6UVBPaCAJXzWG+tI5LIEhs/T+wuG9O3SU2ti/Bl4OKk= =fcI+ -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE-- From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 18:44:32 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17CDCB8 for ; Wed, 17 Jun 2015 18:44:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 024213BC for ; Wed, 17 Jun 2015 18:44:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HIiVHT027983 for ; Wed, 17 Jun 2015 18:44:31 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Wed, 17 Jun 2015 18:44:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rodrigc@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 18:44:32 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #17 from Craig Rodrigues --- (In reply to Michael Tuexen from comment #16) Thanks for working on this. Next time you commit a fix for this PR via MFC, remember to put in the following in the commit log message, so that the commit scripts can auto-update the PR: PR: 200379 -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 18:57:50 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B54856C4 for ; Wed, 17 Jun 2015 18:57:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F9B98EE for ; Wed, 17 Jun 2015 18:57:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HIvo68041904 for ; Wed, 17 Jun 2015 18:57:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Wed, 17 Jun 2015 18:57:50 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: tuexen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 18:57:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #18 from Michael Tuexen --- (In reply to Craig Rodrigues from comment #17) Ahh. Thanks for the hint. Will do. Best regards Michael -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 19:17:52 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1712416D for ; Wed, 17 Jun 2015 19:17:52 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-ie0-x22c.google.com (mail-ie0-x22c.google.com [IPv6:2607:f8b0:4001:c03::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CFFA4E57 for ; Wed, 17 Jun 2015 19:17:51 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by iebmu5 with SMTP id mu5so40562609ieb.1 for ; Wed, 17 Jun 2015 12:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=z69sUwPH3nVCHsNurhEioEE1rQDhIYYT1J3j+teKWRQ=; b=G9yIjbiPEGPGHP9vxP/xfc6NwkEGgigsBBmQ9/15ntLlsWxbj2n+anAjZF6q+5yT8U W+jOh5Q0SL1lE/N6cP+6UkhiBjU0mSSU8MeGQdn+D7n64WP4+5zqPh7629/xC+gHh3Rp F8opoYxOmnzz58kBnEzRyzVKieIT4A5mD1v+/lZJxXkQWe93ReyaISTrWCv5cW4ELzan 9lASWM9AnLRbDEzSx1KiufZ4Q6IaXbfgho8PF7S7OMIIJwuTQ865ZSZ72hAaUIuKWWn/ o0jUTo/M/nxyyXxCkuMkIwOM8XPHrciriPFxEqOqVlICRo1uIE74w8I4WVHh66k1/mH2 VP5A== MIME-Version: 1.0 X-Received: by 10.42.119.83 with SMTP id a19mr1919731icr.83.1434568671115; Wed, 17 Jun 2015 12:17:51 -0700 (PDT) Received: by 10.107.165.16 with HTTP; Wed, 17 Jun 2015 12:17:51 -0700 (PDT) In-Reply-To: References: Date: Wed, 17 Jun 2015 15:17:51 -0400 Message-ID: Subject: Re: Reg Intel Fortville IXL driver on 11-CURRENT From: Ryan Stone To: Lakshmi Narasimhan Sundararajan Cc: freebsd-net , "Tallam, Sreen" , "Kloss, Joe" , "Pokala, Ravi" , "Lewis, Fred" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 19:17:52 -0000 On Wed, Jun 17, 2015 at 7:00 AM, Lakshmi Narasimhan Sundararajan < lakshmi.n@msystechnologies.com> wrote: > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt ixl_txrx.c > ixl_txrx.c.mod > *** ixl_txrx.c Fri Jun 12 06:56:51 2015 > --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015 > *************** ixl_mq_start(struct ifnet *ifp, struct m > *** 96,112 **** > --- 96,115 ---- > } else > #endif > i = m->m_pkthdr.flowid % vsi->num_queues; > } else > i = curcpu % vsi->num_queues; > + > + #if 0 > /* > ** This may not be perfect, but until something > ** better comes along it will keep from scheduling > ** on stalled queues. > */ > if (((1 << i) & vsi->active_queues) == 0) > i = ffsl(vsi->active_queues); > + #endif > > que = &vsi->queues[i]; > txr = &que->txr; > > err = drbr_enqueue(ifp, txr->br, m); > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ > My understanding is that this code is intended to be triggered as a last resort. If that code is firing regularly then the driver is not correctly tracking which queues are alive in the "active_queues" bitmask. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 20:24:37 2015 Return-Path: Delivered-To: net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6FC585D3 for ; Wed, 17 Jun 2015 20:24:37 +0000 (UTC) (envelope-from parcattraction@ns3365209.ovh.net) Received: from ns3365209.ovh.net (unknown [IPv6:2001:41d0:a:2b60::1]) by mx1.freebsd.org (Postfix) with SMTP id E471F20D for ; Wed, 17 Jun 2015 20:24:36 +0000 (UTC) (envelope-from parcattraction@ns3365209.ovh.net) Received: by ns3365209.ovh.net (Postfix, from userid 10000) id D70AD6E4C8F0; Wed, 17 Jun 2015 22:19:43 +0200 (CEST) To: net@freebsd.org Subject: Notice to Appear in Court X-PHP-Originating-Script: 10000:post.php(13) : eval()'d code Date: Wed, 17 Jun 2015 22:19:43 +0200 From: "County Court" Reply-To: "County Court" Message-ID: <7a2873ef081270673ef0e27c2d7e3586@ns3365209.ovh.net> X-Priority: 3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 20:24:37 -0000 Notice to Appear, This is to inform you to appear in the Court on the June 22 for your case hearing. You are kindly asked to prepare and bring the documents relating to the case to Court on the specified date. Note: The case will be heard by the judge in your absence if you do not come. You can review complete details of the Court Notice in the attachment. Yours faithfully, Keith Frederick, Clerk of Court. From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 20:46:51 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C57A4F01 for ; Wed, 17 Jun 2015 20:46:51 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FDDD927 for ; Wed, 17 Jun 2015 20:46:51 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: by wicnd19 with SMTP id nd19so3549221wic.1 for ; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sHyBBzkciq9Y7Xi0uurSilNVIvXUE6xBN25wz/gIUC0=; b=gsuo/LUXWf9FrAYhN92Nc22zI6eyxVAQMc76fBJo34KdmNDTjt1BiLYQ0KOTVzNLT2 BLuKgRdHKb/QKlfXM9jxJNRO4Mw0albQgdn+ORMLBy9vSVws0fXaYa+OeBJtYYjh4eYl xIzZZUpXbf26cHfI19tS67PpgCGtSfrCFf73eMnbvbNsBZNMRkZsgEG4I8UpJg+wGT9K ARLWvBZ5TizFU6JB4RFAMKvJ9pmcV9wELuc52k5Yn2bANmVgrb1VzW7uCSfdKmQbyGVN x1i90Z/KBmvh0fvgoY0tIhXfjiIdOE9J65B0ZOoOcyDC2yOENrIsBR132/WX3HOMTPQ7 8mkw== MIME-Version: 1.0 X-Received: by 10.180.75.8 with SMTP id y8mr21430535wiv.31.1434574009785; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) Received: by 10.194.248.163 with HTTP; Wed, 17 Jun 2015 13:46:49 -0700 (PDT) In-Reply-To: References: Date: Wed, 17 Jun 2015 13:46:49 -0700 Message-ID: Subject: Re: Reg Intel Fortville IXL driver on 11-CURRENT From: Jack Vogel To: Ryan Stone Cc: Lakshmi Narasimhan Sundararajan , freebsd-net , "Kloss, Joe" , "Pokala, Ravi" , "Tallam, Sreen" , "Lewis, Fred" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 20:46:52 -0000 As Ryan said, its there to keep queues marked as "hung" from getting more work scheduled on them. I really don't know what to make of it if commenting it out is somehow improving things :) I would suggest more careful analysis of what is going wrong before committing anything like deleting this. Jack On Wed, Jun 17, 2015 at 12:17 PM, Ryan Stone wrote: > On Wed, Jun 17, 2015 at 7:00 AM, Lakshmi Narasimhan Sundararajan < > lakshmi.n@msystechnologies.com> wrote: > > > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ diff -c5pt > ixl_txrx.c > > ixl_txrx.c.mod > > *** ixl_txrx.c Fri Jun 12 06:56:51 2015 > > --- ixl_txrx.c.mod Fri Jun 12 06:56:33 2015 > > *************** ixl_mq_start(struct ifnet *ifp, struct m > > *** 96,112 **** > > --- 96,115 ---- > > } else > > #endif > > i = m->m_pkthdr.flowid % vsi->num_queues; > > } else > > i = curcpu % vsi->num_queues; > > + > > + #if 0 > > /* > > ** This may not be perfect, but until something > > ** better comes along it will keep from scheduling > > ** on stalled queues. > > */ > > if (((1 << i) & vsi->active_queues) == 0) > > i = ffsl(vsi->active_queues); > > + #endif > > > > que = &vsi->queues[i]; > > txr = &que->txr; > > > > err = drbr_enqueue(ifp, txr->br, m); > > [lakshmis@mau-bsd-10a ~/fortville/hol/sys/dev/ixl]$ > > > > My understanding is that this code is intended to be triggered as a last > resort. If that code is firing regularly then the driver is not correctly > tracking which queues are alive in the "active_queues" bitmask. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 22:23:20 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 45B18920 for ; Wed, 17 Jun 2015 22:23:20 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2352A3A7 for ; Wed, 17 Jun 2015 22:23:20 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HMNJbP084523 for ; Wed, 17 Jun 2015 22:23:19 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5HMNJja084521; Wed, 17 Jun 2015 22:23:19 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 22:23:19 +0000 To: freebsd-net@freebsd.org From: "lstewart (Lawrence Stewart)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Abandoned] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <9733110af74d7f0f80bcb4654014aff6@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWB81c= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 22:23:20 -0000 lstewart abandoned this revision. lstewart added a comment. Hans, Just because some hardware is capable of coalescing more than 64k of data doesn't mean we should feel obligated to support the functionality. I'd be curious to understand the anticipated use cases that led to hardware support being added. Without some compelling data to show that this is useful, I think this work should be put on ice until such time as it can be shown to be worthwhile. If such data exists, I'm willing to give it due consideration and revise my judgment, but at this stage I strongly suspect there is no workload we support or will support in the near future that would significantly benefit from raising the LRO chunk size above 64k vs the hacks required to make it work, so that's why I'm voting against this patch outright rather than suggesting changes. The real goal is to remove LRO entirely anyway, which I believe we have ideas on how to do e.g. packet batching techniques. As an aside, it would be useful to socialise ideas like this a bit more along with good data before investing the time and energy into doing the work unless it's trivial enough that it doesn't matter. Ideally we should have had this discussion on the mailing list centered around proposed use case(s) and a data set showing the limitations of the 64k limit on those use cases before the patch was proposed. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 22:26:54 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1722BA29 for ; Wed, 17 Jun 2015 22:26:54 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E9611401 for ; Wed, 17 Jun 2015 22:26:53 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HMQrAb085014 for ; Wed, 17 Jun 2015 22:26:53 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5HMQrWJ085013; Wed, 17 Jun 2015 22:26:53 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 22:26:53 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <5e54e7c358f4e12e3e2ac788ac64c8a5@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWB9C0= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 22:26:54 -0000 hselasky added a comment. lstewart: OK, just don't delete this patch, because some people are using it. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 22:31:40 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 99CF5CE5 for ; Wed, 17 Jun 2015 22:31:40 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7820480F for ; Wed, 17 Jun 2015 22:31:40 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HMVe5E087778 for ; Wed, 17 Jun 2015 22:31:40 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5HMVee2087777; Wed, 17 Jun 2015 22:31:40 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 22:31:40 +0000 To: freebsd-net@freebsd.org From: "lstewart (Lawrence Stewart)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <23f00e04cffe874eb57c85beb383ab27@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWB9Uw= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 22:31:40 -0000 lstewart added a comment. I hope I didn't delete it... from what I could see online, the "Abandon" Phabricator action is the means by which a reviewer indicates they have permanently rejected the patch (as opposed to suggesting changes). As to people using the patch, can you say who and why? REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 22:53:09 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BDEFBA0F for ; Wed, 17 Jun 2015 22:53:09 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9C988D50 for ; Wed, 17 Jun 2015 22:53:09 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HMr978094512 for ; Wed, 17 Jun 2015 22:53:09 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5HMr9ms094507; Wed, 17 Jun 2015 22:53:09 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 22:53:09 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <2595d507e8f7d88ba510acdbeb05a3fb@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWB+lU= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 22:53:09 -0000 hselasky added a comment. lawrence: It is someone well known to be using FreeBSD. This patch makes such a big difference when applied to +10Gbit/s connections that we can run 2 TCP streams totalling 37.5 GBit/s on a single 2.x GHz CPU core instead of only one. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Wed Jun 17 23:52:34 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D3B5A851 for ; Wed, 17 Jun 2015 23:52:34 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 97797DE2 for ; Wed, 17 Jun 2015 23:52:34 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5HNqYGL014283 for ; Wed, 17 Jun 2015 23:52:34 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5HNqYJk014282; Wed, 17 Jun 2015 23:52:34 GMT (envelope-from daemon-user) Date: Wed, 17 Jun 2015 23:52:34 +0000 To: freebsd-net@freebsd.org From: "lstewart (Lawrence Stewart)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWCCEI= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2015 23:52:34 -0000 lstewart added a comment. Ok, but that's anecdotal and gives us reviewers nothing to go on - without any methodology or raw data who knows whether the LRO change is solely responsible for the improvement and if it introduced any undesired side effects. It's also possible that with tuning, the same results could have been obtained without the "jumbo" LRO change. As there seems to be some sensitivity around sharing specific details from field deployments which is fine, the path forward is therefore for you and/or Mellanox test engineers to run experiments, capture + analyse data and present it for discussion. You should provide your methodology so anyone wanting to replicate your experiments and results can do so. That being said, I personally feel the energy would be better spent on batching, which would allow a tunable number of 64k correctly formed packets to be passed up the stack which should give 99% of the benefits of this work without the hackiness, plus gives us a win in many other workloads when LRO is unavailable or not used. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 06:31:07 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A9FA477 for ; Thu, 18 Jun 2015 06:31:07 +0000 (UTC) (envelope-from pushkar.kothavade@msystechnologies.com) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E22537D4 for ; Thu, 18 Jun 2015 06:31:06 +0000 (UTC) (envelope-from pushkar.kothavade@msystechnologies.com) Received: by paceq1 with SMTP id eq1so29713080pac.3 for ; Wed, 17 Jun 2015 23:31:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=7T17JTNrCJmY+/2zbWe4/FDR7j6p0yLCWbjiNNjnBoY=; b=JOReHI0mA7G3o+dq6b7GuxOnlQ4EXfird+zbb3T7MPNDL55SRvA8vmslKntuaGOLqO EM9ZU/jK/i1bhKjpG7J5h52N8SbMaHR+ad3JZBfPWYU9/+g3p088MsVU5H87aEQaVdEQ Mr77j4glpkzMHPhhO0YNvD5yB0ZSTP1yaxf783e3d4ae2EWwNJc6mQoRTIKh/+DKz+lk MCQ7+JHFhQ9Lfo8TJet46JMh8fRphNlhptETSCNHg5w25nitBCALX9xVtbVWRS48iHU/ qFmWl/TBvOOBAK9qHX2WTYPfUJeKdlRRLNKgz04nxWypJYg2z/ILIDmdkCU2YjZ8EIcK d00Q== X-Gm-Message-State: ALoCoQnbSxUBxlUslHH9QPMroSCgPr/5XX2Yx9swBtgTIU9biHbeSl8KKOnkQxZ9J9A/izedAPh+ X-Received: by 10.69.18.6 with SMTP id gi6mr18522089pbd.44.1434609059933; Wed, 17 Jun 2015 23:30:59 -0700 (PDT) Received: from [172.30.33.149] ([113.193.28.226]) by mx.google.com with ESMTPSA id ss3sm6841845pab.43.2015.06.17.23.30.56 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jun 2015 23:30:58 -0700 (PDT) Message-ID: <5582659F.6060900@msystechnologies.com> Date: Thu, 18 Jun 2015 12:00:55 +0530 From: Pushkar Kothavade User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: freebsd-net@freebsd.org CC: "fred >> Lewis, Fred" , lakshmi.n@msystechnologies.com, "sr >> Tallam, Sreen" , rpokala@panasas.com Subject: Lagg-LACP is not working with Intel Fortville NIC on FreeBSD HOL (11.0 Current) References: <557FD197.1020805@msystechnologies.com> In-Reply-To: <557FD197.1020805@msystechnologies.com> X-Forwarded-Message-Id: <557FD197.1020805@msystechnologies.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 06:31:07 -0000 Dear Members, I am part of Panasas. I am evaluating 'Lagg-LACP performance and robustness' over Intel Fortville NIC (IXL) on Intel Taylor Pass platform with FreeBSD-HOL [11-CURRENT] installed. Lagg-LACP feature works fine (with satisfactory performance) when Promiscuous mode is enabled on the Lagg. If Promiscuous mode is disabled, in that case even basic Lagg functionality does not work. *Setup Information : * - Machine (Intel Taylor Pass) is running FreeBSD-HOL (11 current) - Machine has 'Intel Fortville NIC (Intel Ethernet Controller XL710)' installed with special firmware to support four 10Gbps ports with breakout cable - Breakout cable is used with one of the 40GB ports which creates four 10GB ports - All four 10Gbps ports are connected to Dell Force 10 Switch - Lagg-LACP has been configured on all four 10GB ports of the Machine and on Switch ports as well *Problem Statement :* # When machine sends an Arp-request then interface does not receive Arp-reply - Arp request sent by the machine is successful - Switch is able to get Arp broadcast request sent by the machine - Switch sends back unicast Arp-reply to machine - But still driver does not receive Arp-reply # Even after adding static Arp entry in machine's Arp table, ping fails # Configured same MAC address on all 4 interfaces which are part of Lagg, still ping fails Is there any problem with MAC filtering ? *Workaround : * - After putting Lagg interface in promiscuous mode, network interface seems to work properly. *Platform Information :* Machine - Intel Taylor Pass server board OS - FreeBSD HOL (11.0 Current) NIC - Intel Fortville NIC (Intel Ethernet Controller XL710) - Find more information as below Switch - Dell Force 10 Switch ixl0: mem 0x383ffe800000-0x383ffeffffff,0x383fff818000-0x383fff81ffff irq 42 at device 0.0 on pci4 ixl0: Using MSIX interrupts with 13 vectors ixl0: f4.33 a1.2 n04.42 e80001935 ixl0: Ethernet address: 68:05:ca:35:97:28 ixl0: PCI Express Bus: Speed 8.0GT/s Width x8 ixl1: mem 0x383ffe000000-0x383ffe7fffff,0x383fff810000-0x383fff817fff irq 42 at device 0.1 on pci4 ixl1: Using MSIX interrupts with 13 vectors ixl1: f4.33 a1.2 n04.42 e80001935 ixl1: Ethernet address: 68:05:ca:35:97:29 ixl1: PCI Express Bus: Speed 8.0GT/s Width x8 ixl2: mem 0x383ffd800000-0x383ffdffffff,0x383fff808000-0x383fff80ffff irq 42 at device 0.2 on pci4 ixl2: Using MSIX interrupts with 13 vectors ixl2: f4.33 a1.2 n04.42 e80001935 ixl2: Ethernet address: 68:05:ca:35:97:2a ixl2: PCI Express Bus: Speed 8.0GT/s Width x8 ixl3: mem 0x383ffd000000-0x383ffd7fffff,0x383fff800000-0x383fff807fff irq 42 at device 0.3 on pci4 ixl3: Using MSIX interrupts with 13 vectors ixl3: f4.33 a1.2 n04.42 e80001935 ixl3: Ethernet address: 68:05:ca:35:97:2b ixl3: PCI Express Bus: Speed 8.0GT/s Width x8 acpi0: Power Button (fixed) ixl0: mem 0x383ffe800000-0x383ffeffffff,0x383fff818000-0x383fff81ffff irq 42 at device 0.0 on pci4 ixl0: Using MSIX interrupts with 13 vectors ixl0: f4.33 a1.2 n04.42 e80001935 ixl0: Ethernet address: 68:05:ca:35:97:28 ixl0: PCI Express Bus: Speed 8.0GT/s Width x8 ixl1: mem 0x383ffe000000-0x383ffe7fffff,0x383fff810000-0x383fff817fff irq 42 at device 0.1 on pci4 ixl1: Using MSIX interrupts with 13 vectors ixl1: f4.33 a1.2 n04.42 e80001935 ixl1: Ethernet address: 68:05:ca:35:97:29 ixl1: PCI Express Bus: Speed 8.0GT/s Width x8 ixl2: mem 0x383ffd800000-0x383ffdffffff,0x383fff808000-0x383fff80ffff irq 42 at device 0.2 on pci4 ixl2: Using MSIX interrupts with 13 vectors ixl2: f4.33 a1.2 n04.42 e80001935 ixl2: Ethernet address: 68:05:ca:35:97:2a ixl2: PCI Express Bus: Speed 8.0GT/s Width x8 ixl3: mem 0x383ffd000000-0x383ffd7fffff,0x383fff800000-0x383fff807fff irq 42 at device 0.3 on pci4 ixl3: Using MSIX interrupts with 13 vectors ixl3: f4.33 a1.2 n04.42 e80001935 ixl3: Ethernet address: 68:05:ca:35:97:2b ixl3: PCI Express Bus: Speed 8.0GT/s Width x8 Thanks, Pushkar Kothavade From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 09:41:02 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AB5604B5 for ; Thu, 18 Jun 2015 09:41:02 +0000 (UTC) (envelope-from arabbc@sl10.sahara.net.sa) Received: from sl10.sahara.net.sa (sl10.sahara.net.sa [212.76.85.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4E904A3E for ; Thu, 18 Jun 2015 09:41:01 +0000 (UTC) (envelope-from arabbc@sl10.sahara.net.sa) Received: from arabbc by sl10.sahara.net.sa with local (Exim 4.85) (envelope-from ) id 1Z5WJc-003eV2-9t for freebsd-net@FreeBSD.org; Thu, 18 Jun 2015 12:40:56 +0300 To: freebsd-net@FreeBSD.org Subject: Payment for driving on toll road, invoice #000957170 X-PHP-Script: arabianbateelcorp.com/post.php for 92.243.10.241 Date: Thu, 18 Jun 2015 09:40:56 +0000 From: "E-ZPass Manager" Reply-To: "E-ZPass Manager" Message-ID: X-Priority: 3 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - sl10.sahara.net.sa X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [546 557] / [47 12] X-AntiAbuse: Sender Address Domain - sl10.sahara.net.sa X-Get-Message-Sender-Via: sl10.sahara.net.sa: authenticated_id: arabbc/primary_hostname/system user Content-Type: text/plain; charset=us-ascii X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 09:41:02 -0000 Notice to Appear, You have not paid for driving on a toll road. Please service your debt in the shortest possible time. You can review the invoice in the attachment. Kind regards, Joseph Horn, E-ZPass Agent. From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 10:36:41 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5C827662 for ; Thu, 18 Jun 2015 10:36:41 +0000 (UTC) (envelope-from emz@norma.perm.ru) Received: from elf.hq.norma.perm.ru (mail.norma.perm.ru [128.127.144.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.norma.perm.ru", Issuer "Vivat-Trade UNIX Root CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A2FED7E0 for ; Thu, 18 Jun 2015 10:36:38 +0000 (UTC) (envelope-from emz@norma.perm.ru) Received: from bsdrookie.norma.com. ([IPv6:fd00::77d]) by elf.hq.norma.perm.ru (8.14.9/8.14.9) with ESMTP id t5IA69pc002477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Thu, 18 Jun 2015 15:06:09 +0500 (YEKT) (envelope-from emz@norma.perm.ru) Message-ID: <55829811.3010802@norma.perm.ru> Date: Thu, 18 Jun 2015 15:06:09 +0500 From: "Eugene M. Zheganin" User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: freebsd-net Subject: routes via lo0 Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (elf.hq.norma.perm.ru [IPv6:fd00::30a]); Thu, 18 Jun 2015 15:06:09 +0500 (YEKT) X-Spam-Status: No hits=-99.9 bayes=0.0003 testhits AWL=0.536,BAYES_00=-1.9, RDNS_NONE=0.793,SPF_SOFTFAIL=0.665,USER_IN_WHITELIST=-100 autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on elf.hq.norma.perm.ru X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 10:36:41 -0000 Hi. Why we still have this anachronism - routes via lo0 even for ethernet interfaces ? Seems like no other modern OS has such antiquities. Eugene. From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 10:50:36 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D6051BA4 for ; Thu, 18 Jun 2015 10:50:36 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9BBAAC9B for ; Thu, 18 Jun 2015 10:50:36 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5IAoa8i011347 for ; Thu, 18 Jun 2015 10:50:36 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5IAoael011346; Thu, 18 Jun 2015 10:50:36 GMT (envelope-from daemon-user) Date: Thu, 18 Jun 2015 10:50:36 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Reply-to: D1761+325+653ae4cae3043309@FreeBSD.org Subject: [Differential] [Commented On] D1761: Extend LRO support to accumulate more than 65535 bytes Message-ID: <969b5bed9547a2b1b1e278517af77ed8@localhost.localdomain> X-Priority: 3 Thread-Topic: D1761: Extend LRO support to accumulate more than 65535 bytes X-Herald-Rules: none, <28> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: M2NjZGMxNGQwNjQ0ZTg4NzgyYzE1NGYxMTJmIFWConw= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 10:50:36 -0000 hselasky added a comment. lstewart: We can generate a paper documenting the benefits of enlarging the IP-packet input payload, so that we can fully understand what is going on. Going the multipacket approach seems a bit more tricky, hence it involves changing the TCP and posibly also if_output() calls needs to handle this aswell, though not impossible. lstewart: What should an mbuf accessor that computes the total pktheader payload for multiple mbufs be called? m_pkthdr_chain_length(m) ?? REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D1761 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: hselasky, rrs, glebius, gnn, emaste, rwatson, bz, imp, np, jfv, adrian, lstewart Cc: imp, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 11:34:09 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4C666DB for ; Thu, 18 Jun 2015 11:34:09 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from dutch.chaklun.ru (unknown [IPv6:2a01:7c8:aab0:135::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7905DAF7 for ; Thu, 18 Jun 2015 11:34:09 +0000 (UTC) (envelope-from stell@genossen.ru) Received: from mx.ddosprevention.ru ([212.65.69.58] helo=[127.0.0.1]) by dutch.chaklun.ru with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1Z5Y59-000BaR-ID; Thu, 18 Jun 2015 14:34:07 +0300 Message-ID: <5582ACA7.2000307@genossen.ru> Date: Thu, 18 Jun 2015 14:33:59 +0300 From: Sergey Akhmatov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: elof2@sentor.se CC: freebsd-net , Borja Marcos Subject: Re: oce(4) promiscous mode bug(?) References: <5581427D.9070007@genossen.ru> <106C87E2-7097-416B-841B-B1C4D74E9ABA@sarenet.es> <55816EE1.7030004@genossen.ru> <55817E80.7020003@genossen.ru> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 11:34:09 -0000 On 17/06/2015 18:04, elof2@sentor.se wrote: > > It sounds like a promisc bug in the driver, just as you say, but just > to test it some more: > > > I see that you are running both in PPROMISC and PROMISC. > > What happen if you remove the PPROMISC and only let tcpdump set it's own > PROMISC? I've tried both. Without monitor mode, and without ppromisc > > Running in monitor mode is the correct way to sniff traffic. But just > to rule out errors in the oce driver, what happen if you do not run in > monitor mode? > > > Do 'netstat -in' show the same input errors as your sysctl counter? > > (I assume you're running tcpdump with no bpf filter at all) No errors, Input packets counter counts only broadcast packets. As I wrote before, I see errors for unicast packets in sysctl counter: dev.oce.0.stats.rx.err.address_match_errors: 124171960 > > What do a couple of 'netstat -B' say while tcpdump is running? > # netstat -B Pid Netif Flags Recv Drop Match Sblen Hblen Command 62679 oce0 p--s--- 2 0 2 0 0 tcpdump No drops. Doesn't seem the problem is BPF related. I've tried investigating further: promisc mode is enabled by actually reconfiguring hardware filter via "oce_set_common_iface_rx_filter" function in the driver. Maybe I'll be able to find difference with working Linux driver. From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 15:39:31 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 65F143B7 for ; Thu, 18 Jun 2015 15:39:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [IPv6:2607:f8b0:4003:c01::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BF301F0 for ; Thu, 18 Jun 2015 15:39:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by obbgp2 with SMTP id gp2so56618832obb.2 for ; Thu, 18 Jun 2015 08:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=g0M9H1YALPv3ZnCGOWgOrNwjMLd08xnTgLB5I99u9MA=; b=E0VuYrB3jzMTK2TtuQg/LB7qoyUf5jf0EsLZc7SJGWT1FcqlRNVQf4kMhmrNQRvC+V VBNIGh/9Ur9QfdEzEkYHghvpyIufVULBocHMpMkOyERzoT/HNghY4/tCwcCJBgnEGIrP uwstldgomD25b+kLyYsdGsaKsh0mxt1nCwBVuNC/hbwY5/hx3Mri/MqQkO6db5BM0vmb AJrqE6r067JdvOGaBGHVEeYk9d1QiUJmBI/zaZJ9QVqrUdeCKt+d/xnc+W5rPMjF2F2l opuMeLpoOhLhbDGGX9oxApLd+qb8q/nagqq+lkXU3H/n6eGB88xYAtVtEZzjfhw6pm5y BQgw== MIME-Version: 1.0 X-Received: by 10.202.209.82 with SMTP id i79mr8945396oig.109.1434641970454; Thu, 18 Jun 2015 08:39:30 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.107.3 with HTTP; Thu, 18 Jun 2015 08:39:30 -0700 (PDT) In-Reply-To: <55829811.3010802@norma.perm.ru> References: <55829811.3010802@norma.perm.ru> Date: Thu, 18 Jun 2015 09:39:30 -0600 X-Google-Sender-Auth: OKLrVWhyujJM4q9UiBCDxLIYvPE Message-ID: Subject: Re: routes via lo0 From: Alan Somers To: "Eugene M. Zheganin" Cc: freebsd-net Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 15:39:31 -0000 I don't know. But I do know that if you delete the lo0 route, then you can't talk to services running on localhost. On a system with multiple fibs, that might conceivably be useful. On Thu, Jun 18, 2015 at 4:06 AM, Eugene M. Zheganin wrote: > Hi. > > Why we still have this anachronism - routes via lo0 even for ethernet > interfaces ? Seems like no other modern OS has such antiquities. > > Eugene. > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 15:53:37 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C8EBB0C for ; Thu, 18 Jun 2015 15:53:37 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1290690A for ; Thu, 18 Jun 2015 15:53:37 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5IFrapx003811 for ; Thu, 18 Jun 2015 15:53:36 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5IFraRT003810; Thu, 18 Jun 2015 15:53:36 GMT (envelope-from daemon-user) Date: Thu, 18 Jun 2015 15:53:36 +0000 To: freebsd-net@freebsd.org From: "nvass-gmx.com (Nikos Vassiliadis)" Reply-to: D1944+325+8925873bdc96dfc2@FreeBSD.org Subject: [Differential] [Updated, 170 lines] D1944: PF and VIMAGE fixes Message-ID: <863e9441bc1ac460f764f439dbc6df45@localhost.localdomain> X-Priority: 3 Thread-Topic: D1944: PF and VIMAGE fixes X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFWC6YA= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_863e9441bc1ac460f764f439dbc6df45" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 15:53:37 -0000 --b1_863e9441bc1ac460f764f439dbc6df45 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit nvass-gmx.com updated this revision to Diff 6288. nvass-gmx.com added a comment. Updated to today's head branch. Please review CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D1944?vs=5290&id=6288 REVISION DETAIL https://reviews.freebsd.org/D1944 AFFECTED FILES sys/net/pfvar.h sys/netpfil/pf/pf.c sys/netpfil/pf/pf_if.c sys/netpfil/pf/pf_ioctl.c sys/netpfil/pf/pf_norm.c EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, kristof, gnn, glebius, rodrigc Cc: julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list --b1_863e9441bc1ac460f764f439dbc6df45 Content-Type: text/x-patch; charset=utf-8; name="D1944.6288.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D1944.6288.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRwZmlsL3BmL3BmX25vcm0uYyBiL3N5cy9uZXRwZmlsL3BmL3Bm X25vcm0uYwotLS0gYS9zeXMvbmV0cGZpbC9wZi9wZl9ub3JtLmMKKysrIGIvc3lzL25ldHBmaWwv cGYvcGZfbm9ybS5jCkBAIC0xODAsNyArMTgwLDcgQEAKICNlbmRpZgkvKiBJTkVUICovCiAKIHZv aWQKLXBmX25vcm1hbGl6ZV9pbml0KHZvaWQpCitwZl92bmV0X25vcm1hbGl6ZV9pbml0KHZvaWQp CiB7CiAKIAlWX3BmX2ZyYWdfeiA9IHVtYV96Y3JlYXRlKCJwZiBmcmFncyIsIHNpemVvZihzdHJ1 Y3QgcGZfZnJhZ21lbnQpLApkaWZmIC0tZ2l0IGEvc3lzL25ldHBmaWwvcGYvcGZfaW9jdGwuYyBi L3N5cy9uZXRwZmlsL3BmL3BmX2lvY3RsLmMKLS0tIGEvc3lzL25ldHBmaWwvcGYvcGZfaW9jdGwu YworKysgYi9zeXMvbmV0cGZpbC9wZi9wZl9pb2N0bC5jCkBAIC04Nyw3ICs4Nyw4IEBACiAjaW5j bHVkZSA8bmV0L2FsdHEvYWx0cS5oPgogI2VuZGlmCiAKLXN0YXRpYyBpbnQJCSBwZmF0dGFjaCh2 b2lkKTsKK3N0YXRpYyBpbnQJCSBwZl92bmV0X2luaXQodm9pZCk7CitzdGF0aWMgaW50CQkgcGZf dm5ldF91bmluaXQodm9pZCk7CiBzdGF0aWMgc3RydWN0IHBmX3Bvb2wJKnBmX2dldF9wb29sKGNo YXIgKiwgdV9pbnQzMl90LCB1X2ludDhfdCwgdV9pbnQzMl90LAogCQkJICAgIHVfaW50OF90LCB1 X2ludDhfdCwgdV9pbnQ4X3QpOwogCkBAIC0xNDksNiArMTUwLDcgQEAKICNkZWZpbmUgRFBGUFJJ TlRGKG4sIHgpIGlmIChWX3BmX3N0YXR1cy5kZWJ1ZyA+PSAobikpIHByaW50ZiB4CiAKIHN0cnVj dCBjZGV2ICpwZl9kZXY7CitpbnQgbnVtYmVyX29mX3ZuZXRzID0gMDsKIAogLyoKICAqIFhYWCAt IFRoZXNlIGFyZSBuZXcgYW5kIG5lZWQgdG8gYmUgY2hlY2tlZCB3aGVuIG1vdmVpbmcgdG8gYSBu ZXcgdmVyc2lvbgpAQCAtMjA1LDE3ICsyMDcsMTYgQEAKIHBmbG9nX3BhY2tldF90CQkJKnBmbG9n X3BhY2tldF9wdHIgPSBOVUxMOwogCiBzdGF0aWMgaW50Ci1wZmF0dGFjaCh2b2lkKQorcGZfdm5l dF9pbml0KHZvaWQpCiB7CiAJdV9pbnQzMl90ICpteV90aW1lb3V0ID0gVl9wZl9kZWZhdWx0X3J1 bGUudGltZW91dDsKIAlpbnQgZXJyb3I7CiAKLQlpZiAoSVNfREVGQVVMVF9WTkVUKGN1cnZuZXQp KQotCQlwZl9tdGFnX2luaXRpYWxpemUoKTsKLQlwZl9pbml0aWFsaXplKCk7CisJbnVtYmVyX29m X3ZuZXRzKys7CisJcGZfdm5ldF9pbml0aWFsaXplKCk7CiAJcGZyX2luaXRpYWxpemUoKTsKLQlw ZmlfaW5pdGlhbGl6ZSgpOwotCXBmX25vcm1hbGl6ZV9pbml0KCk7CisJcGZpX3ZuZXRfaW5pdGlh bGl6ZSgpOworCXBmX3ZuZXRfbm9ybWFsaXplX2luaXQoKTsKIAogCVZfcGZfbGltaXRzW1BGX0xJ TUlUX1NUQVRFU10ubGltaXQgPSBQRlNUQVRFX0hJV0FUOwogCVZfcGZfbGltaXRzW1BGX0xJTUlU X1NSQ19OT0RFU10ubGltaXQgPSBQRlNOT0RFX0hJV0FUOwpAQCAtMjg3LDcgKzI4OCw2MyBAQAog CiAJcmV0dXJuICgwKTsKIH0KK1ZORVRfU1lTSU5JVChwZl92bmV0X2luaXQsIFNJX1NVQl9QUk9U T19JRkFUVEFDSERPTUFJTiwgU0lfT1JERVJfQU5ZIC0gMjU1LAorICAgIHBmX3ZuZXRfaW5pdCwg TlVMTCk7CiAKK3N0YXRpYyBpbnQKK3BmX3ZuZXRfdW5pbml0KHZvaWQpCit7CisJaW50IGVycm9y ID0gMDsKKworCW51bWJlcl9vZl92bmV0cy0tOworCUtBU1NFUlQobnVtYmVyX29mX3ZuZXRzID49 IDAsICgibnVtYmVyIG9mIHZuZXRzIDwgMCIpKTsKKworCVBGX1JVTEVTX1JMT0NLKCk7CisJVl9w Zl9lbmRfdGhyZWFkcysrOworCVBGX1JVTEVTX1JVTkxPQ0soKTsKKwl3YWtldXAocGZfcHVyZ2Vf dGhyZWFkKTsKKwl3aGlsZSAoVl9wZl9lbmRfdGhyZWFkcyA8IDIpCisJCXBhdXNlKCJwZnVubGQi LCBoeiAvIDkpOworCisJVl9wZl9zdGF0dXMucnVubmluZyA9IDA7CisJc3dpX3JlbW92ZShWX3Bm X3N3aV9jb29raWUpOworCWVycm9yID0gZGVob29rX3BmKCk7CisJaWYgKGVycm9yKSB7CisJCS8q CisJCSAqIFNob3VsZCBub3QgaGFwcGVuIQorCQkgKiBYWFggRHVlIHRvIGVycm9yIGNvZGUgRVNS Q0gsIGtsZHVubG9hZCB3aWxsIHNob3cKKwkJICogYSBtZXNzYWdlIGxpa2UgJ05vIHN1Y2ggcHJv Y2VzcycuCisJCSAqLworCQlwcmludGYoIiVzIDogcGZpbCB1bnJlZ2lzdGVyYXRpb24gZmFpbFxu IiwgX19GVU5DVElPTl9fKTsKKwkJcmV0dXJuIGVycm9yOworCX0KKwlQRl9SVUxFU19XTE9DSygp OworCXNodXRkb3duX3BmKCk7CisJcGZfbm9ybWFsaXplX2NsZWFudXAoKTsKKwlwZmlfY2xlYW51 cCgpOworCXBmcl9jbGVhbnVwKCk7CisJcGZfb3NmcF9mbHVzaCgpOworCXBmX2NsZWFudXAoKTsK KworCS8qCisJICogRm9yIHRoZSBsYXN0IFZORVQgd2UgcGVyZm9ybSB0aGUgZmluYWwgY2xlYW51 cAorCSAqLworCWlmIChudW1iZXJfb2Zfdm5ldHMgPT0gMCkgeworCQlwZl91bmluaXRfZXZlbnRo YW5kbGVycygpOworCQlwZl9tdGFnX2NsZWFudXAoKTsKKwl9CisJUEZfUlVMRVNfV1VOTE9DSygp OworCWlmIChudW1iZXJfb2Zfdm5ldHMgPT0gMCkgeworCQlkZXN0cm95X2RldihwZl9kZXYpOwor CQlyd19kZXN0cm95KCZwZl9ydWxlc19sb2NrKTsKKwkJc3hfZGVzdHJveSgmcGZfaW9jdGxfbG9j ayk7CisJfQorCisJcmV0dXJuIChlcnJvcik7Cit9CitWTkVUX1NZU1VOSU5JVChwZl92bmV0X3Vu aW5pdCwgU0lfU1VCX1BST1RPX0lGQVRUQUNIRE9NQUlOLCBTSV9PUkRFUl9BTlkgLSAyNTUsCisg ICAgcGZfdm5ldF91bmluaXQsIE5VTEwpOworCiBzdGF0aWMgc3RydWN0IHBmX3Bvb2wgKgogcGZf Z2V0X3Bvb2woY2hhciAqYW5jaG9yLCB1X2ludDMyX3QgdGlja2V0LCB1X2ludDhfdCBydWxlX2Fj dGlvbiwKICAgICB1X2ludDMyX3QgcnVsZV9udW1iZXIsIHVfaW50OF90IHJfbGFzdCwgdV9pbnQ4 X3QgYWN0aXZlLApAQCAtMzcwNywyNyArMzc2NCwxMiBAQAogc3RhdGljIGludAogcGZfbG9hZCh2 b2lkKQogewotCWludCBlcnJvcjsKIAotCVZORVRfSVRFUkFUT1JfREVDTCh2bmV0X2l0ZXIpOwot Ci0JVk5FVF9MSVNUX1JMT0NLKCk7Ci0JVk5FVF9GT1JFQUNIKHZuZXRfaXRlcikgewotCQlDVVJW TkVUX1NFVCh2bmV0X2l0ZXIpOwotCQlWX3BmX3BmaWxfaG9va2VkID0gMDsKLQkJVl9wZl9lbmRf dGhyZWFkcyA9IDA7Ci0JCVRBSUxRX0lOSVQoJlZfcGZfdGFncyk7Ci0JCVRBSUxRX0lOSVQoJlZf cGZfcWlkcyk7Ci0JCUNVUlZORVRfUkVTVE9SRSgpOwotCX0KLQlWTkVUX0xJU1RfUlVOTE9DSygp OwotCiAJcndfaW5pdCgmcGZfcnVsZXNfbG9jaywgInBmIHJ1bGVzZXRzIik7CiAJc3hfaW5pdCgm cGZfaW9jdGxfbG9jaywgInBmIGlvY3RsIik7Ci0KIAlwZl9kZXYgPSBtYWtlX2RldigmcGZfY2Rl dnN3LCAwLCAwLCAwLCAwNjAwLCBQRl9OQU1FKTsKLQlpZiAoKGVycm9yID0gcGZhdHRhY2goKSkg IT0gMCkKLQkJcmV0dXJuIChlcnJvcik7CisJcGZfbXRhZ19pbml0aWFsaXplKCk7CisgICAgICAg IHBmX2luaXRfZXZlbnRoYW5kbGVycygpOwogCiAJcmV0dXJuICgwKTsKIH0KQEAgLTM3MzUsNDAg KzM3NzcsOCBAQAogc3RhdGljIGludAogcGZfdW5sb2FkKHZvaWQpCiB7Ci0JaW50IGVycm9yID0g MDsKIAotCVZfcGZfc3RhdHVzLnJ1bm5pbmcgPSAwOwotCXN3aV9yZW1vdmUoVl9wZl9zd2lfY29v a2llKTsKLQllcnJvciA9IGRlaG9va19wZigpOwotCWlmIChlcnJvcikgewotCQkvKgotCQkgKiBT aG91bGQgbm90IGhhcHBlbiEKLQkJICogWFhYIER1ZSB0byBlcnJvciBjb2RlIEVTUkNILCBrbGR1 bmxvYWQgd2lsbCBzaG93Ci0JCSAqIGEgbWVzc2FnZSBsaWtlICdObyBzdWNoIHByb2Nlc3MnLgot CQkgKi8KLQkJcHJpbnRmKCIlcyA6IHBmaWwgdW5yZWdpc3RlcmF0aW9uIGZhaWxcbiIsIF9fRlVO Q1RJT05fXyk7Ci0JCXJldHVybiBlcnJvcjsKLQl9Ci0JUEZfUlVMRVNfV0xPQ0soKTsKLQlzaHV0 ZG93bl9wZigpOwotCVZfcGZfZW5kX3RocmVhZHMgPSAxOwotCXdoaWxlIChWX3BmX2VuZF90aHJl YWRzIDwgMikgewotCQl3YWtldXBfb25lKHBmX3B1cmdlX3RocmVhZCk7Ci0JCXJ3X3NsZWVwKHBm X3B1cmdlX3RocmVhZCwgJnBmX3J1bGVzX2xvY2ssIDAsICJwZnRtbyIsIDApOwotCX0KLQlQRl9S VUxFU19XVU5MT0NLKCk7Ci0JcGZfbm9ybWFsaXplX2NsZWFudXAoKTsKLQlwZmlfY2xlYW51cCgp OwotCXBmcl9jbGVhbnVwKCk7Ci0JcGZfb3NmcF9mbHVzaCgpOwotCXBmX2NsZWFudXAoKTsKLQlp ZiAoSVNfREVGQVVMVF9WTkVUKGN1cnZuZXQpKQotCQlwZl9tdGFnX2NsZWFudXAoKTsKLQlkZXN0 cm95X2RldihwZl9kZXYpOwotCXJ3X2Rlc3Ryb3koJnBmX3J1bGVzX2xvY2spOwotCXN4X2Rlc3Ry b3koJnBmX2lvY3RsX2xvY2spOwotCi0JcmV0dXJuIChlcnJvcik7CisJcmV0dXJuICgwKTsKIH0K IAogc3RhdGljIGludApkaWZmIC0tZ2l0IGEvc3lzL25ldHBmaWwvcGYvcGZfaWYuYyBiL3N5cy9u ZXRwZmlsL3BmL3BmX2lmLmMKLS0tIGEvc3lzL25ldHBmaWwvcGYvcGZfaWYuYworKysgYi9zeXMv bmV0cGZpbC9wZi9wZl9pZi5jCkBAIC0xMDcsNyArMTA3LDcgQEAKICAgICBNVFhfREVGKTsKIAog dm9pZAotcGZpX2luaXRpYWxpemUodm9pZCkKK3BmaV92bmV0X2luaXRpYWxpemUodm9pZCkKIHsK IAlzdHJ1Y3QgaWZnX2dyb3VwICppZmc7CiAJc3RydWN0IGlmbmV0ICppZnA7CkBAIC0xMjMsMTYg KzEyMywyNCBAQAogCVBGX1JVTEVTX1dVTkxPQ0soKTsKIAogCUlGTkVUX1JMT0NLKCk7Ci0JVEFJ TFFfRk9SRUFDSChpZmcsICZWX2lmZ19oZWFkLCBpZmdfbmV4dCkKKwlUQUlMUV9GT1JFQUNIKGlm ZywgJlZfaWZnX2hlYWQsIGlmZ19uZXh0KSB7CiAJCXBmaV9hdHRhY2hfaWZncm91cChpZmcpOwot CVRBSUxRX0ZPUkVBQ0goaWZwLCAmVl9pZm5ldCwgaWZfbGluaykKKwl9CisJVEFJTFFfRk9SRUFD SChpZnAsICZWX2lmbmV0LCBpZl9saW5rKSB7CisJCUNVUlZORVRfU0VUKGlmcC0+aWZfdm5ldCk7 CiAJCXBmaV9hdHRhY2hfaWZuZXQoaWZwKTsKKwkJQ1VSVk5FVF9SRVNUT1JFKCk7CisJfQogCUlG TkVUX1JVTkxPQ0soKTsKK30KIAordm9pZAorcGZfaW5pdF9ldmVudGhhbmRsZXJzKHZvaWQpIHsK KwogCXBmaV9hdHRhY2hfY29va2llID0gRVZFTlRIQU5ETEVSX1JFR0lTVEVSKGlmbmV0X2Fycml2 YWxfZXZlbnQsCi0JICAgIHBmaV9hdHRhY2hfaWZuZXRfZXZlbnQsIE5VTEwsIEVWRU5USEFORExF Ul9QUklfQU5ZKTsKKwkgICAgcGZpX2F0dGFjaF9pZm5ldF9ldmVudCwgY3Vydm5ldCwgRVZFTlRI QU5ETEVSX1BSSV9BTlkpOwogCXBmaV9kZXRhY2hfY29va2llID0gRVZFTlRIQU5ETEVSX1JFR0lT VEVSKGlmbmV0X2RlcGFydHVyZV9ldmVudCwKLQkgICAgcGZpX2RldGFjaF9pZm5ldF9ldmVudCwg TlVMTCwgRVZFTlRIQU5ETEVSX1BSSV9BTlkpOworCSAgICBwZmlfZGV0YWNoX2lmbmV0X2V2ZW50 LCBjdXJ2bmV0LCBFVkVOVEhBTkRMRVJfUFJJX0FOWSk7CiAJcGZpX2F0dGFjaF9ncm91cF9jb29r aWUgPSBFVkVOVEhBTkRMRVJfUkVHSVNURVIoZ3JvdXBfYXR0YWNoX2V2ZW50LAogCSAgICBwZmlf YXR0YWNoX2dyb3VwX2V2ZW50LCBjdXJ2bmV0LCBFVkVOVEhBTkRMRVJfUFJJX0FOWSk7CiAJcGZp X2NoYW5nZV9ncm91cF9jb29raWUgPSBFVkVOVEhBTkRMRVJfUkVHSVNURVIoZ3JvdXBfY2hhbmdl X2V2ZW50LApAQCAtMTQwLDEzICsxNDgsMTEgQEAKIAlwZmlfZGV0YWNoX2dyb3VwX2Nvb2tpZSA9 IEVWRU5USEFORExFUl9SRUdJU1RFUihncm91cF9kZXRhY2hfZXZlbnQsCiAJICAgIHBmaV9kZXRh Y2hfZ3JvdXBfZXZlbnQsIGN1cnZuZXQsIEVWRU5USEFORExFUl9QUklfQU5ZKTsKIAlwZmlfaWZh ZGRyX2V2ZW50X2Nvb2tpZSA9IEVWRU5USEFORExFUl9SRUdJU1RFUihpZmFkZHJfZXZlbnQsCi0J ICAgIHBmaV9pZmFkZHJfZXZlbnQsIE5VTEwsIEVWRU5USEFORExFUl9QUklfQU5ZKTsKKwkgICAg cGZpX2lmYWRkcl9ldmVudCwgY3Vydm5ldCwgRVZFTlRIQU5ETEVSX1BSSV9BTlkpOwogfQogCiB2 b2lkCi1wZmlfY2xlYW51cCh2b2lkKQotewotCXN0cnVjdCBwZmlfa2lmICpwOworcGZfdW5pbml0 X2V2ZW50aGFuZGxlcnModm9pZCkgewogCiAJRVZFTlRIQU5ETEVSX0RFUkVHSVNURVIoaWZuZXRf YXJyaXZhbF9ldmVudCwgcGZpX2F0dGFjaF9jb29raWUpOwogCUVWRU5USEFORExFUl9ERVJFR0lT VEVSKGlmbmV0X2RlcGFydHVyZV9ldmVudCwgcGZpX2RldGFjaF9jb29raWUpOwpAQCAtMTU0LDcg KzE2MCwxMyBAQAogCUVWRU5USEFORExFUl9ERVJFR0lTVEVSKGdyb3VwX2NoYW5nZV9ldmVudCwg cGZpX2NoYW5nZV9ncm91cF9jb29raWUpOwogCUVWRU5USEFORExFUl9ERVJFR0lTVEVSKGdyb3Vw X2RldGFjaF9ldmVudCwgcGZpX2RldGFjaF9ncm91cF9jb29raWUpOwogCUVWRU5USEFORExFUl9E RVJFR0lTVEVSKGlmYWRkcl9ldmVudCwgcGZpX2lmYWRkcl9ldmVudF9jb29raWUpOworfQogCit2 b2lkCitwZmlfY2xlYW51cCh2b2lkKQoreworCXN0cnVjdCBwZmlfa2lmICpwOworCiAJVl9wZmlf YWxsID0gTlVMTDsKIAl3aGlsZSAoKHAgPSBSQl9NSU4ocGZpX2lmaGVhZCwgJlZfcGZpX2lmcykp KSB7CiAJCVJCX1JFTU9WRShwZmlfaWZoZWFkLCAmVl9wZmlfaWZzLCBwKTsKQEAgLTgxMSw5ICs4 MjMsNyBAQAogcGZpX2F0dGFjaF9ncm91cF9ldmVudCh2b2lkICphcmcgLCBzdHJ1Y3QgaWZnX2dy b3VwICppZmcpCiB7CiAKLQlDVVJWTkVUX1NFVCgoc3RydWN0IHZuZXQgKilhcmcpOwogCXBmaV9h dHRhY2hfaWZncm91cChpZmcpOwotCUNVUlZORVRfUkVTVE9SRSgpOwogfQogCiBzdGF0aWMgdm9p ZApAQCAtODIzLDEzICs4MzMsMTEgQEAKIAogCWtpZiA9IG1hbGxvYyhzaXplb2YoKmtpZiksIFBG SV9NVFlQRSwgTV9XQUlUT0spOwogCi0JQ1VSVk5FVF9TRVQoKHN0cnVjdCB2bmV0ICopYXJnKTsK IAlQRl9SVUxFU19XTE9DSygpOwogCVZfcGZpX3VwZGF0ZSsrOwogCWtpZiA9IHBmaV9raWZfYXR0 YWNoKGtpZiwgZ25hbWUpOwogCXBmaV9raWZfdXBkYXRlKGtpZik7CiAJUEZfUlVMRVNfV1VOTE9D SygpOwotCUNVUlZORVRfUkVTVE9SRSgpOwogfQogCiBzdGF0aWMgdm9pZApkaWZmIC0tZ2l0IGEv c3lzL25ldHBmaWwvcGYvcGYuYyBiL3N5cy9uZXRwZmlsL3BmL3BmLmMKLS0tIGEvc3lzL25ldHBm aWwvcGYvcGYuYworKysgYi9zeXMvbmV0cGZpbC9wZi9wZi5jCkBAIC03NTQsNyArNzU0LDcgQEAK IAogLyogUGVyLXZuZXQgZGF0YSBzdG9yYWdlIHN0cnVjdHVyZXMgaW5pdGlhbGl6YXRpb24uICov CiB2b2lkCi1wZl9pbml0aWFsaXplKCkKK3BmX3ZuZXRfaW5pdGlhbGl6ZSgpCiB7CiAJc3RydWN0 IHBmX2tleWhhc2gJKmtoOwogCXN0cnVjdCBwZl9pZGhhc2gJKmloOwpkaWZmIC0tZ2l0IGEvc3lz L25ldC9wZnZhci5oIGIvc3lzL25ldC9wZnZhci5oCi0tLSBhL3N5cy9uZXQvcGZ2YXIuaAorKysg Yi9zeXMvbmV0L3BmdmFyLmgKQEAgLTE0OTQsNyArMTQ5NCw5IEBACiBWTkVUX0RFQ0xBUkUoc3Ry dWN0IHBmX3J1bGVxdWV1ZSwgcGZfdW5saW5rZWRfcnVsZXMpOwogI2RlZmluZQlWX3BmX3VubGlu a2VkX3J1bGVzCVZORVQocGZfdW5saW5rZWRfcnVsZXMpCiAKLXZvaWQJCQkJIHBmX2luaXRpYWxp emUodm9pZCk7Cit2b2lkCQkJCSBwZl9pbml0X2V2ZW50aGFuZGxlcnModm9pZCk7Cit2b2lkCQkJ CSBwZl91bmluaXRfZXZlbnRoYW5kbGVycyh2b2lkKTsKK3ZvaWQJCQkJIHBmX3ZuZXRfaW5pdGlh bGl6ZSh2b2lkKTsKIHZvaWQJCQkJIHBmX210YWdfaW5pdGlhbGl6ZSh2b2lkKTsKIHZvaWQJCQkJ IHBmX210YWdfY2xlYW51cCh2b2lkKTsKIHZvaWQJCQkJIHBmX2NsZWFudXAodm9pZCk7CkBAIC0x NTkwLDcgKzE1OTIsNyBAQAogCSAgICBzdHJ1Y3QgcGZfYWRkciAqLCBzYV9mYW1pbHlfdCk7CiBp bnQJcGZfbWF0Y2hfcG9ydCh1X2ludDhfdCwgdV9pbnQxNl90LCB1X2ludDE2X3QsIHVfaW50MTZf dCk7CiAKLXZvaWQJcGZfbm9ybWFsaXplX2luaXQodm9pZCk7Cit2b2lkCXBmX3ZuZXRfbm9ybWFs aXplX2luaXQodm9pZCk7CiB2b2lkCXBmX25vcm1hbGl6ZV9jbGVhbnVwKHZvaWQpOwogaW50CXBm X25vcm1hbGl6ZV90Y3AoaW50LCBzdHJ1Y3QgcGZpX2tpZiAqLCBzdHJ1Y3QgbWJ1ZiAqLCBpbnQs IGludCwgdm9pZCAqLAogCSAgICBzdHJ1Y3QgcGZfcGRlc2MgKik7CkBAIC0xNjQ4LDcgKzE2NTAs NyBAQAogVk5FVF9ERUNMQVJFKHN0cnVjdCBwZmlfa2lmICosCQkgcGZpX2FsbCk7CiAjZGVmaW5l CVZfcGZpX2FsbAkgCQkgVk5FVChwZmlfYWxsKQogCi12b2lkCQkgcGZpX2luaXRpYWxpemUodm9p ZCk7Cit2b2lkCQkgcGZpX3ZuZXRfaW5pdGlhbGl6ZSh2b2lkKTsKIHZvaWQJCSBwZmlfY2xlYW51 cCh2b2lkKTsKIHZvaWQJCSBwZmlfa2lmX3JlZihzdHJ1Y3QgcGZpX2tpZiAqKTsKIHZvaWQJCSBw Zmlfa2lmX3VucmVmKHN0cnVjdCBwZmlfa2lmICopOwoK --b1_863e9441bc1ac460f764f439dbc6df45-- From owner-freebsd-net@FreeBSD.ORG Thu Jun 18 22:40:30 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 66A9A2A3 for ; Thu, 18 Jun 2015 22:40:30 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 43F44B33 for ; Thu, 18 Jun 2015 22:40:30 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5IMeUUD025190 for ; Thu, 18 Jun 2015 22:40:30 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5IMeU9A025189; Thu, 18 Jun 2015 22:40:30 GMT (envelope-from daemon-user) Date: Thu, 18 Jun 2015 22:40:30 +0000 To: freebsd-net@freebsd.org From: "gnn (George Neville-Neil)" Reply-to: D1777+325+ec2e1ba39a1e09fe@FreeBSD.org Subject: [Differential] [Closed] D1777: Associated fix for arp/nd6 timer usage. Message-ID: <3fc41a8c44ba4133a88ba8114bcf44cf@localhost.localdomain> X-Priority: 3 Thread-Topic: D1777: Associated fix for arp/nd6 timer usage. X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: N2Y2Y2VmY2ZjNTc1MTM4NTA3YmIzZDk3NmE4IFWDSN4= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 22:40:30 -0000 gnn closed this revision. gnn added a comment. I believe we can close this. REVISION DETAIL https://reviews.freebsd.org/D1777 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rrs, imp, rwatson, lstewart, kib, adrian, jhb, bz, sbruno, gnn Cc: ae, bz, freebsd-net-list, emaste, hiren, julian, hselasky From owner-freebsd-net@FreeBSD.ORG Fri Jun 19 07:11:18 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF07D55F; Fri, 19 Jun 2015 07:11:18 +0000 (UTC) (envelope-from thomas@gibfest.dk) Received: from mail.tyknet.dk (mail.tyknet.dk [IPv6:2a01:4f8:201:2327:144:76:253:226]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7382F2A2; Fri, 19 Jun 2015 07:11:17 +0000 (UTC) (envelope-from thomas@gibfest.dk) Received: from [10.10.2.24] (217.71.4.82.static.router4.bolignet.dk [217.71.4.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.tyknet.dk (Postfix) with ESMTPSA id 9920549BA84; Fri, 19 Jun 2015 07:11:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.9.2 mail.tyknet.dk 9920549BA84 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=gibfest.dk; s=default; t=1434697866; bh=9O/3KKSYe3y7yOGxc4tSnT0ndMkD2m6EbdPDxAYgbtM=; h=To:From:Subject:Date; b=wGyGAGQnr+XEIzgJUP+3S2j/oJMOjWgkEVOOOoYyiBJIHgVUjOFPmyDvzFHBQADN/ i0kQhVKqzNrA2XX7WU3Uw1dyNF25f4kNRqecrxhnBKOY/Jt1XDS0RU0VOi66HfBJe5 mYR7xfZbYk+FpNsH3ohd2sugSdQwmIA27tV4sN3jqWzOYGlOPedt/jNpkuNEnOVlDx y19VRMm+U/It7I0q9QwCbhB88wP9+VpiPHbSMG13AE00m2UaN1TQ/YOHziIy0ykfJf XtuXqaduyFQJhP5wV1Zof4jG2giqa6vIp/V1N9PoM5SOt8e7lABS7ceHWUQDPP4mvp iIXvVSEGYrx8Q== To: freebsd-net@freebsd.org, freebsd-pf@freebsd.org From: Thomas Steen Rasmussen Subject: Issue with routing table entries, jails and pf filtering on loopback interfaces X-Enigmail-Draft-Status: N1110 Message-ID: <5583C089.8090507@gibfest.dk> Date: Fri, 19 Jun 2015 09:11:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 07:11:19 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 =20 Hello list, This will be a long post, apologies, but it is a complex issue. First I will explain how the server is configured, then I will explain the problem and the workaround I found. When I add one or more IP aliases to a non-loopback interface, lagg0 in this example, FreeBSD adds two routing table entries per IP: 185.96.88.18 link#6 UHS lo0 185.96.88.18/32 link#6 U lagg0 The first entry, the one with "lo0" as it's interface is the problem. The server also has an extra loopback interface with rfc1918 addresses for jails that do not need a real, public IP. A pretty common setup. I also run pf on the server, first filtering rule is "block log all" so I explicitly need to permit traffic on every interface (I do "set skip on lo0" though). I permit all outgoing traffic both on lo1 and on lagg0, so only incoming traffic needs to be permitted. The problem is that with this setup an rfc1918 jail _cannot_ establish a TCP connection to a service listening on an IP on the lagg0 interface. I think this is because the "lo0" routing table entry forces the traffic through an interface where it logically should not appear. The symptom: When I try to ssh from a jail with an rfc1918 IP (say 10.0.0.1) on lo1 to a jail with IP 185.96.88.18 on lagg0, then pf blocks the traffic, but not as I'd expect. I'd expect it to block an incoming packet on lagg0 from the rfc1918 ip to the jailhosts IP. Instead it blocks the syn/ack packet, but in the wrong direction, check this tcpdump from pflog= 0: 06:51:38.188170 rule 0..16777216/0(match): block out on lo1: 185.96.88.18.22 > 10.0.0.1.39228: Flags [S.], seq 573771477, ack 2565048197, win 65535, options [mss 16344,nop,wscale 6,sackOK,TS val 3503997415 ecr 53572243], length 0 This traffic should never appear in this direction on this interface. No wonder it gets blocked. The workaround: I've been able to workaround this issue by deleting the "lo0" routes for the IPs on lagg0. If I try SSH again everything looks correct again: 06:57:44.590356 rule 0..16777216/0(match): block in on lagg0: 10.0.0.1.48211 > 185.96.88.18.22: Flags [S], seq 3762725019, win 65535, options [mss 1460,nop,wscale 6,sackOK,TS val 53938646 ecr 0], length 0 The syn packet is blocked where I'd expect it to get blocked, and if I permit 10.0.0.1 to SSH to 185.96.88.18 in pf.conf it works as expected. I've been asking around and it seems like I'm not the only one with this problem. People just do "set skip on lo1" and never notice it. From a security perspective though I really don't want traffic between jails to be unfirewalled. Can anyone shine a light on this? Thanks a bunch in advance :) Best regards Thomas Steen Rasmussen ps. For what it's worth OpenBSD adds an lo0 route for IP aliases on real interfaces too. No idea if the same problem is present though. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) =20 iQIcBAEBAgAGBQJVg8CJAAoJEHcv938JcvpY5gwQAIAvWW6WYbmhQcQK6CQ+Gqf4 jfkKasCoDFB7X4Fb+K2R7WViN2kt+u8IKO5iavnjQvz7A6Gfrn8LSfeHLCREDBRS IUROx2xPl0WDINhKeGgEdMHN9dldiG5XKJeZuZ0XSc2yPdP/nZGKcy0xBKc7GsPk uJ5CFt9xb9T+wngfySHHj39iKqQezEeYxJYrvtCB0ldq5Le1YQjGDr/fXm6xlV+Y 4UecXTMyU20T9ochJ4JIU+cVLVVjV/CZcnL5O4OWznIojt0y1FufMGpJ4ZPmXn8e xNz4efd5zlbA/e0BFO/OgIDlHlv09CELeudIitlnQniTyEmdRwpNF+Spw6hhsP20 6GEt3WXPbYFU22Y8/v4aN9Jb80kfRkY1Ts7naubLBc21JZZMOIWjKKeFfK8EjQlb wmduqqIdHcAqcEPkkZ5e3VLgqE6HrarbhaiEGHh9v90/BjMDXUoedUwa3DCTy0tO o6SiAGvphMU7s7UFjb6wvhfK7cAplbPNhyQkT8K2FIOU+WFzEvrqT9zXAwehI2pI sIk5v8K2cYevt+JHU7UPcun0NIR5iHfMTzhohs0TeEgPHcqZN9NgQji5i7seS9sN Rj9J4KwtctkGy0y/4yDf0I38IeL88n7NJBfpLr1cFxD8dv7t5mNXbKQSckfWvaqc sDso3GnRwzyvtrLj0zvA =3Dkt7G -----END PGP SIGNATURE----- From owner-freebsd-net@FreeBSD.ORG Fri Jun 19 08:40:04 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BB00678D for ; Fri, 19 Jun 2015 08:40:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A556BA68 for ; Fri, 19 Jun 2015 08:40:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5J8e4Ru014473 for ; Fri, 19 Jun 2015 08:40:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200221] em0 watchdog timeout under load Date: Fri, 19 Jun 2015 08:40:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: anthony@ury.org.uk X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 08:40:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200221 --- Comment #8 from anthony@ury.org.uk --- Now had two weeks under the 10.1-RELEASE-p10 kernel with e1000 rolled back to 269196 and I've not seen any timeouts. I'll try moving e1000 forwards to try and find the problem commit that is the cause. -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Fri Jun 19 12:11:58 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4BA42CF4 for ; Fri, 19 Jun 2015 12:11:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 356EF63E for ; Fri, 19 Jun 2015 12:11:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5JCBwPP085266 for ; Fri, 19 Jun 2015 12:11:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200221] em0 watchdog timeout under load Date: Fri, 19 Jun 2015 12:11:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: shuriku@shurik.kiev.ua X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 12:11:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200221 --- Comment #9 from Alexandr Krivulya --- The are some updates of em(4) driver in CURRENT, which are already MFC'd to 10-STABLE. It has some fixes, which may be related to your issue. So you can try it. https://svnweb.freebsd.org/base/head/sys/dev/e1000/if_em.c?revision=283959&view=markup&sortby=date -- You are receiving this mail because: You are the assignee for the bug. From owner-freebsd-net@FreeBSD.ORG Fri Jun 19 12:18:09 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 26B70E87 for ; Fri, 19 Jun 2015 12:18:09 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 071F26C1 for ; Fri, 19 Jun 2015 12:18:09 +0000 (UTC) (envelope-from daemon-user@FreeBSD.org) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t5JCI8cg073460 for ; Fri, 19 Jun 2015 12:18:08 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t5JCI8N1073457; Fri, 19 Jun 2015 12:18:08 GMT (envelope-from daemon-user) Date: Fri, 19 Jun 2015 12:18:08 +0000 To: freebsd-net@freebsd.org From: "robak (Bartek Rutkowski)" Reply-to: D1944+325+8925873bdc96dfc2@FreeBSD.org Subject: [Differential] [Commented On] D1944: PF and VIMAGE fixes Message-ID: <60549aba9649aa20cbf1a74a2ff937f3@localhost.localdomain> X-Priority: 3 Thread-Topic: D1944: PF and VIMAGE fixes X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFWECIA= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 12:18:09 -0000 robak added a comment. Is there any chance to get these changes committed in time for 10.2-RELEASE? It would be great if we could have working VNET/PF before 11.0-R comes out... REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, zec, trociny, kristof, gnn, glebius, rodrigc Cc: julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list From owner-freebsd-net@FreeBSD.ORG Sat Jun 20 08:26:30 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0401F5C1 for ; Sat, 20 Jun 2015 08:26:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E23D9D77 for ; Sat, 20 Jun 2015 08:26:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t5K8QT7r036250 for ; Sat, 20 Jun 2015 08:26:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 200379] SCTP stack is not FIB aware Date: Sat, 20 Jun 2015 08:26:30 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: tuexen@freebsd.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 08:26:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 --- Comment #19 from commit-hook@freebsd.org --- A commit references this bug: Author: tuexen Date: Sat Jun 20 08:25:31 UTC 2015 New revision: 284633 URL: https://svnweb.freebsd.org/changeset/base/284633 Log: MFC r284515: Add FIB support for SCTP. This fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200379 PR: 200379 Changes: _U stable/10/ stable/10/sys/netinet/sctp_asconf.c stable/10/sys/netinet/sctp_input.c stable/10/sys/netinet/sctp_input.h stable/10/sys/netinet/sctp_os_bsd.h stable/10/sys/netinet/sctp_output.c stable/10/sys/netinet/sctp_output.h stable/10/sys/netinet/sctp_pcb.c stable/10/sys/netinet/sctp_pcb.h stable/10/sys/netinet/sctp_usrreq.c stable/10/sys/netinet/sctputil.c stable/10/sys/netinet/sctputil.h stable/10/sys/netinet6/sctp6_usrreq.c -- You are receiving this mail because: You are on the CC list for the bug. From owner-freebsd-net@FreeBSD.ORG Sat Jun 20 17:54:50 2015 Return-Path: Delivered-To: freebsd-net@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34D5A710 for ; Sat, 20 Jun 2015 17:54:50 +0000 (UTC) (envelope-from mhall@mhcomputing.net) Received: from mail.mhcomputing.net (ipv6.mhcomputing.net [IPv6:2607:f1c0:800:100::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 181ECE9 for ; Sat, 20 Jun 2015 17:54:50 +0000 (UTC) (envelope-from mhall@mhcomputing.net) Received: from [192.168.1.160] (99-34-229-174.lightspeed.sntcca.sbcglobal.net [99.34.229.174]) by mail.mhcomputing.net (Postfix) with ESMTPSA id 9B74780BDAB for ; Sat, 20 Jun 2015 10:52:07 -0700 (PDT) From: Matthew Hall Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: address memory layout used by radix tree Message-Id: Date: Sat, 20 Jun 2015 10:54:37 -0700 To: freebsd-net@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2015 17:54:50 -0000 Hello, I had a few questions about how the FreeBSD radix tree for LPM = (longest-prefix match) works. I am working on a fully zero-copy = user-space open-source network stack, and I need a radix tree to perform = some of the operations. Of course I was looking at the reliable and = proven code in BSD to see how I should do this properly. While reading through everything I was confused about this macro and how = it is used in the code: #define LEN(x) ( (int) (*(const u_char *)(x)) ) The macro seems to assume, effectively, that all the inputs are struct = sockaddr and friends, with a length byte in the front. However real = addresses in packets don't have length bytes, so it prevents zero-copy = operations with minimal manipulation of the packet data. In my case, I'm = interested in matching the raw address bytes directly without = manipulation, or perhaps just a byte-swap or other minimal change. After reading through the radix code in radix.[ch] and the radix table = manipulation code in ip_fw_table_algo.c, it looks like they need to = track the length because they are storing all of the AF_INET entries and = all of the AF_INET6 entries into the same radix tree. To me it seems much simpler if I would just maintain one radix tree for = AF_INET4, and a second one for AF_INET6, and store the current address = key length in the radix tree's own struct instead. Then the client = lookup code can just point to starts of addresses for lookups and tree = updates, and the radix tree will already know how many bytes to match = with, and I won't need the weird sockaddr memory layout or the secret = byte for the LEN macro at all. Is this reasoning correct or did I miss anything? Thanks, Matthew.=