From owner-freebsd-toolchain@FreeBSD.ORG Sun Apr 12 21:42:58 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A9734207 for ; Sun, 12 Apr 2015 21:42:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 826ECC65 for ; Sun, 12 Apr 2015 21:42:58 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3CLgwUH042567 for ; Sun, 12 Apr 2015 21:42:58 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3CLgwv2042566; Sun, 12 Apr 2015 21:42:58 GMT (envelope-from root) Date: Sun, 12 Apr 2015 21:42:58 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Request, 16 lines] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhm X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Apr 2015 21:42:58 -0000 rodrigc created this revision. rodrigc added a reviewer: jmg. rodrigc added a subscriber: freebsd-toolchain. REVISION SUMMARY In the version of gcc in the FreeBSD tree, this modification was made to the compiler: https://svnweb.freebsd.org/base?view=revision&revision=r242182 #if __STDC_HOSTED__ #include #endif A similar change was done to clang in the FreeBSD tree: https://svnweb.freebsd.org/base?view=revision&revision=r218893 However, for external gcc toolchains, this patch is not in the compiler's header file. This patch to FreeBSD's aesni code allows compilation with an external gcc toolchain REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES sys/crypto/aesni/aesencdec.h sys/crypto/aesni/aesni_ghash.c sys/crypto/aesni/aesni_wrap.c To: rodrigc, jmg Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 13 16:18:29 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 648DC8B5 for ; Mon, 13 Apr 2015 16:18:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 461CC97 for ; Mon, 13 Apr 2015 16:18:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3DGITwO086406 for ; Mon, 13 Apr 2015 16:18:29 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3DGITMj086405; Mon, 13 Apr 2015 16:18:29 GMT (envelope-from root) Date: Mon, 13 Apr 2015 16:18:28 +0000 To: freebsd-toolchain@freebsd.org From: "jmg (John-Mark Gurney)" Subject: [Differential] [Updated] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <458b091c8dbb6507c11d4dbffed2a6d2@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUr7FQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 16:18:29 -0000 jmg added a comment. hmm.. maybe we should put this hack into a different header file and just include that one… since all these files are in crypto/aesni, why not a local header (use quotes) that is named gnuhack.h or something (can't think of a good name right now)? Right now it's only three files, but I have work that may expand the number of files that this hack is required to be added too, and if we need to add hacks for other compilers, or if gnu changes how things are, then we can update the hacks in one location, instead of n locations. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 13 19:35:13 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A400EF2C for ; Mon, 13 Apr 2015 19:35:13 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7977DC3B for ; Mon, 13 Apr 2015 19:35:13 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3DJZD7i041242 for ; Mon, 13 Apr 2015 19:35:13 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3DJZDm3041241; Mon, 13 Apr 2015 19:35:13 GMT (envelope-from root) Date: Mon, 13 Apr 2015 19:35:13 +0000 To: freebsd-toolchain@freebsd.org From: "dim (Dimitry Andric)" Subject: [Differential] [Changed Subscribers] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <9988070e4c3a671332111b1d6c271546@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUsGnE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2015 19:35:13 -0000 dim added a subscriber: dim. INLINE COMMENTS sys/crypto/aesni/aesni_wrap.c:49 This part seems to be superfluous, since "aesencdec.h", just two files above this one, already defines _MM_MALLOC_INCLUDED. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 14 13:05:45 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B8E6A12C for ; Tue, 14 Apr 2015 13:05:45 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 91A8CE05 for ; Tue, 14 Apr 2015 13:05:45 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3ED5jm0089321 for ; Tue, 14 Apr 2015 13:05:45 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3ED5jmD089320; Tue, 14 Apr 2015 13:05:45 GMT (envelope-from root) Date: Tue, 14 Apr 2015 13:05:45 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Changed Subscribers] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUtEKk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 13:05:45 -0000 emaste added a subscriber: emaste. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 14 17:19:31 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4C623F8 for ; Tue, 14 Apr 2015 17:19:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9253FEE for ; Tue, 14 Apr 2015 17:19:31 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3EHJVaK028005 for ; Tue, 14 Apr 2015 17:19:31 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3EHJV4w028004; Tue, 14 Apr 2015 17:19:31 GMT (envelope-from root) Date: Tue, 14 Apr 2015 17:19:31 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Updated, 36 lines] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUtTCM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 17:19:31 -0000 rodrigc updated this revision to Diff 4825. rodrigc added a comment. OK, here's an updated diff where things are separate out into a different header file. CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2285?vs=4798&id=4825 REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES sys/crypto/aesni/aesencdec.h sys/crypto/aesni/aesni_ghash.c sys/crypto/aesni/aesni_os.h To: rodrigc, jmg Cc: emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Tue Apr 14 17:33:33 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 53209863 for ; Tue, 14 Apr 2015 17:33:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3238E35B for ; Tue, 14 Apr 2015 17:33:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3EHXWM9033103 for ; Tue, 14 Apr 2015 17:33:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3EHXWjQ033102; Tue, 14 Apr 2015 17:33:32 GMT (envelope-from root) Date: Tue, 14 Apr 2015 17:33:32 +0000 To: freebsd-toolchain@freebsd.org From: "kostikbel (Konstantin Belousov)" Subject: [Differential] [Changed Subscribers] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <6244ccadb844442a33ff8d7f8afc3a56@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUtT2w= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 17:33:33 -0000 kostikbel added a subscriber: kostikbel. INLINE COMMENTS sys/crypto/aesni/aesencdec.h:30 Why this line uses "" ? REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 15 07:08:18 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CE55ECE7 for ; Wed, 15 Apr 2015 07:08:18 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ABD3AAA6 for ; Wed, 15 Apr 2015 07:08:18 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3F78I4d062557 for ; Wed, 15 Apr 2015 07:08:18 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3F78IMn062556; Wed, 15 Apr 2015 07:08:18 GMT (envelope-from root) Date: Wed, 15 Apr 2015 07:08:18 +0000 To: freebsd-toolchain@freebsd.org From: "jmg (John-Mark Gurney)" Subject: [Differential] [Commented On] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <92586b83086865f5ac779e6de23a45c2@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUuDmI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 07:08:18 -0000 jmg added a comment. we should either include both w/ quotes or both w/ angle braces… I personally would prefer quotes, but that's me, but I won't object to angle braces. INLINE COMMENTS sys/crypto/aesni/aesencdec.h:30 so it looks like the same directory as the file instead of having to specify a full path.. similar to how this header is included in aesni_wrap.c... REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 15 17:02:29 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A44385DF for ; Wed, 15 Apr 2015 17:02:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7B1B5DBF for ; Wed, 15 Apr 2015 17:02:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3FH2Tq8025569 for ; Wed, 15 Apr 2015 17:02:29 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3FH2Tfd025568; Wed, 15 Apr 2015 17:02:29 GMT (envelope-from root) Date: Wed, 15 Apr 2015 17:02:29 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Updated, 36 lines] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUumaU= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 17:02:29 -0000 rodrigc updated this revision to Diff 4840. rodrigc added a comment. Change to <> CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2285?vs=4825&id=4840 REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES sys/crypto/aesni/aesencdec.h sys/crypto/aesni/aesni_ghash.c sys/crypto/aesni/aesni_os.h To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Wed Apr 15 17:55:55 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A9983928 for ; Wed, 15 Apr 2015 17:55:55 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 881F1685 for ; Wed, 15 Apr 2015 17:55:55 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3FHttA0039676 for ; Wed, 15 Apr 2015 17:55:55 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3FHtt6D039675; Wed, 15 Apr 2015 17:55:55 GMT (envelope-from root) Date: Wed, 15 Apr 2015 17:55:55 +0000 To: freebsd-toolchain@freebsd.org From: "dim (Dimitry Andric)" Subject: [Differential] [Commented On] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <6777e692841320c4b9e8427d61ee8ef8@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUupis= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 17:55:55 -0000 dim added a comment. LGTM. REVISION DETAIL https://reviews.freebsd.org/D2285 To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 14:06:05 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 42F45A1C for ; Thu, 16 Apr 2015 14:06:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 24C00FB2 for ; Thu, 16 Apr 2015 14:06:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GE64ww047747 for ; Thu, 16 Apr 2015 14:06:04 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GE644b047746; Thu, 16 Apr 2015 14:06:04 GMT (envelope-from root) Date: Thu, 16 Apr 2015 14:06:04 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 6 lines] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1Yzdi X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 14:06:05 -0000 emaste created this revision. emaste added reviewers: imp, andrew. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY arm64 relies on an external binutils port or package because the in-tree linker from binutils 2.17.50 does not support arm64. Add arm64 to universe if the linker is available. buildworld and buildkernel use the external binutils automatically, so `pkg install aarch64-binutils` is sufficient for building FreeBSD/arm64. REVISION DETAIL https://reviews.freebsd.org/D2302 AFFECTED FILES Makefile To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 14:24:34 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 81AE9DEB for ; Thu, 16 Apr 2015 14:24:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6277C2A9 for ; Thu, 16 Apr 2015 14:24:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GEOYmL053883 for ; Thu, 16 Apr 2015 14:24:34 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GEOYDO053882; Thu, 16 Apr 2015 14:24:34 GMT (envelope-from root) Date: Thu, 16 Apr 2015 14:24:34 +0000 To: freebsd-toolchain@freebsd.org From: "andrew (Andrew Turner)" Subject: [Differential] [Updated] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUvxiI= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 14:24:34 -0000 andrew added a comment. Would it be difficult to have a warning if the package is not installed? REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 14:32:50 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3D72BE91 for ; Thu, 16 Apr 2015 14:32:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1D9753B2 for ; Thu, 16 Apr 2015 14:32:50 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GEWn0b056669 for ; Thu, 16 Apr 2015 14:32:49 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GEWnUW056668; Thu, 16 Apr 2015 14:32:49 GMT (envelope-from root) Date: Thu, 16 Apr 2015 14:32:49 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUvyBE= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 14:32:50 -0000 emaste added a comment. >>! In D2302#4, @andrew wrote: > Would it be difficult to have a warning if the package is not installed? Perhaps ``` .else @echo ">> arm64 skipped - install aarch64-binutils port or package to build" ``` REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 14:56:11 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 25AC7168 for ; Thu, 16 Apr 2015 14:56:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F2591850 for ; Thu, 16 Apr 2015 14:56:10 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GEuA5m062342 for ; Thu, 16 Apr 2015 14:56:10 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GEuAWV062341; Thu, 16 Apr 2015 14:56:10 GMT (envelope-from root) Date: Thu, 16 Apr 2015 14:56:10 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated, 10 lines] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUvzYo= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 14:56:11 -0000 emaste updated this revision to Diff 4849. emaste added a comment. Add a message if we skip arm64 because we don't have binutils CHANGES SINCE LAST UPDATE https://reviews.freebsd.org/D2302?vs=4846&id=4849 REVISION DETAIL https://reviews.freebsd.org/D2302 AFFECTED FILES Makefile To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 15:00:19 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D245F286 for ; Thu, 16 Apr 2015 15:00:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B318C892 for ; Thu, 16 Apr 2015 15:00:19 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GF0JbW062992 for ; Thu, 16 Apr 2015 15:00:19 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GF0JE0062991; Thu, 16 Apr 2015 15:00:19 GMT (envelope-from root) Date: Thu, 16 Apr 2015 15:00:19 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUvzoM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 15:00:19 -0000 emaste added inline comments. INLINE COMMENTS Makefile:383 Also add ``` universe_epilogue: universe_arm64_skip ``` REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 17:43:11 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F3FDCB2 for ; Thu, 16 Apr 2015 17:43:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E17FDE3F for ; Thu, 16 Apr 2015 17:43:10 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GHhAsN011837 for ; Thu, 16 Apr 2015 17:43:10 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GHhARD011836; Thu, 16 Apr 2015 17:43:10 GMT (envelope-from root) Date: Thu, 16 Apr 2015 17:43:10 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Closed] D2285: gcc 4.9.1 compilation fixes for aesni Message-ID: <49721f2a2e8bbaf2d961c065827494ea@localhost.localdomain> X-Priority: 3 Thread-Topic: D2285: gcc 4.9.1 compilation fixes for aesni X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MmIyNDI1MWVlZGY5MTMzMjJkZjYzZDBmNzhmIFUv9K4= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 17:43:11 -0000 rodrigc closed this revision. rodrigc updated this revision to Diff 4852. rodrigc added a comment. Closed by commit rS281606 (authored by @rodrigc). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2285?vs=4840&id=4852#toc REVISION DETAIL https://reviews.freebsd.org/D2285 AFFECTED FILES head/sys/crypto/aesni/aesencdec.h head/sys/crypto/aesni/aesni_ghash.c head/sys/crypto/aesni/aesni_os.h To: rodrigc, jmg Cc: kostikbel, emaste, dim, freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 18:22:51 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 35C974B8 for ; Thu, 16 Apr 2015 18:22:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1767839D for ; Thu, 16 Apr 2015 18:22:51 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GIMo53022537 for ; Thu, 16 Apr 2015 18:22:50 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GIMoIl022536; Thu, 16 Apr 2015 18:22:50 GMT (envelope-from root) Date: Thu, 16 Apr 2015 18:22:50 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Request, 6 lines] D2305: Fix bootstraping of crunchide Message-ID: X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRi X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 18:22:51 -0000 rodrigc created this revision. rodrigc added reviewers: emaste, imp. rodrigc added a subscriber: freebsd-toolchain. REVISION SUMMARY When using an external gcc 4.9 toolchain on a FreeBSD 10.1 build host, building of the CURRENT branch failed when trying to build rescue. See this discussion: https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001614.html https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001616.html REVISION DETAIL https://reviews.freebsd.org/D2305 AFFECTED FILES Makefile.inc1 To: rodrigc, emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 19:10:33 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9F5B41A5 for ; Thu, 16 Apr 2015 19:10:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F446A83 for ; Thu, 16 Apr 2015 19:10:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GJAXcV043633 for ; Thu, 16 Apr 2015 19:10:33 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GJAXnc043632; Thu, 16 Apr 2015 19:10:33 GMT (envelope-from root) Date: Thu, 16 Apr 2015 19:10:33 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Accepted] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUwCSk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 19:10:33 -0000 imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. I like this... REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, andrew, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 19:18:06 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 393CC45C for ; Thu, 16 Apr 2015 19:18:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 12642BB5 for ; Thu, 16 Apr 2015 19:18:06 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GJI5KJ046120 for ; Thu, 16 Apr 2015 19:18:05 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GJI5cL046119; Thu, 16 Apr 2015 19:18:05 GMT (envelope-from root) Date: Thu, 16 Apr 2015 19:18:05 +0000 To: freebsd-toolchain@freebsd.org From: "andrew (Andrew Turner)" Subject: [Differential] [Accepted] D2302: Add arm64 to universe if binutils is available Message-ID: X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUwCu0= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 19:18:06 -0000 andrew accepted this revision. REVISION DETAIL https://reviews.freebsd.org/D2302 To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Thu Apr 16 22:35:33 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D1DF993 for ; Thu, 16 Apr 2015 22:35:33 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F1225C8 for ; Thu, 16 Apr 2015 22:35:32 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3GMZWbZ002314 for ; Thu, 16 Apr 2015 22:35:32 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3GMZWnA002313; Thu, 16 Apr 2015 22:35:32 GMT (envelope-from root) Date: Thu, 16 Apr 2015 22:35:32 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Closed] D2302: Add arm64 to universe if binutils is available Message-ID: <0f877f165bafc9affc4683f17ced4543@localhost.localdomain> X-Priority: 3 Thread-Topic: D2302: Add arm64 to universe if binutils is available X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: NjBiMmQ3YjA1ZGY5ZjIxZDQ5NWNkZTY1YzdiIFUwOTQ= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 22:35:33 -0000 emaste closed this revision. emaste updated this revision to Diff 4865. emaste added a comment. Closed by commit rS281629 (authored by @emaste). CHANGED PRIOR TO COMMIT https://reviews.freebsd.org/D2302?vs=4849&id=4865#toc REVISION DETAIL https://reviews.freebsd.org/D2302 AFFECTED FILES head/Makefile To: emaste, imp, andrew Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 13:01:16 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 093EBEBE for ; Fri, 17 Apr 2015 13:01:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E2D4BD86 for ; Fri, 17 Apr 2015 13:01:15 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HD1F9Z085641 for ; Fri, 17 Apr 2015 13:01:15 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HD1FZZ085640; Fri, 17 Apr 2015 13:01:15 GMT (envelope-from root) Date: Fri, 17 Apr 2015 13:01:15 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2305: Fix bootstraping of crunchide Message-ID: X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxBBs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 13:01:16 -0000 emaste added inline comments. INLINE COMMENTS Makefile.inc1:1469 I believe @imp suggested we still need it unconditionally when crossbuilding, and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} < 1000014` in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an unconditional build tool? REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 13:18:34 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 614AE579 for ; Fri, 17 Apr 2015 13:18:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46682EF2 for ; Fri, 17 Apr 2015 13:18:34 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HDIYA0090328 for ; Fri, 17 Apr 2015 13:18:34 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HDIYfL090327; Fri, 17 Apr 2015 13:18:34 GMT (envelope-from root) Date: Fri, 17 Apr 2015 13:18:34 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Updated] D2305: Fix bootstraping of crunchide Message-ID: <68a379341a1ccbad91b903dc504a1726@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxCCo= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 13:18:34 -0000 emaste added a comment. >>! In D2305#4, @emaste wrote: > I believe @imp suggested we still need it unconditionally when crossbuilding, and also note that usr.sbin/crunch is added for `${BOOTSTRAPPING} < 1000014` in bootstrap-tools. I wonder if we can just promote usr.sbin/crunch to an unconditional build tool? Indeed, crunchide is built with only 32- or 64-bit ELF support depending on the target. I'll see about always compiling in both instead. If that works we can drop this part and change the `${BOOTSTRAPPING}` test below. Or just make it unconditional below. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 14:06:29 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A74E1858 for ; Fri, 17 Apr 2015 14:06:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8D092793 for ; Fri, 17 Apr 2015 14:06:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HE6Tho003395 for ; Fri, 17 Apr 2015 14:06:29 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HE6TfH003394; Fri, 17 Apr 2015 14:06:29 GMT (envelope-from root) Date: Fri, 17 Apr 2015 14:06:29 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Updated] D2305: Fix bootstraping of crunchide Message-ID: <5aad4c0f25ac29184d5bf730516ecddf@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxE2U= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 14:06:29 -0000 imp added a comment. I think that we've stumbled on more stuff we can just kill :) INLINE COMMENTS Makefile.inc1:1469 I'd be inclined to promote it. Makefile.inc1:1470 Can you tell me where in the tree we define RELEASEDIR? Is it still even a thing? Makefile.inc1:1475 I'd love to know why this is needed. (1) It is tiny, so building on 386 is fine, and the next line catches it. (2) Cross building, the next line would catch it. Makefile.inc1:1476 Not withstanding my silly nitpicking above, I think this whole thing can be removed. RELEASEDIR isn't defined anywhere grep -r kgzip shows this is the only place that we build it or reference it in the tree Therefore, since the witch weights the same as a duck, it is deadwood and can be burned. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 16:04:11 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 90A279AF for ; Fri, 17 Apr 2015 16:04:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7442484D for ; Fri, 17 Apr 2015 16:04:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HG4BkY038545 for ; Fri, 17 Apr 2015 16:04:11 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HG4BPj038544; Fri, 17 Apr 2015 16:04:11 GMT (envelope-from root) Date: Fri, 17 Apr 2015 16:04:11 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Requested Changes To] D2305: Fix bootstraping of crunchide Message-ID: <157a46cb8573732a79fc0b31b6b18835@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxLvs= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 16:04:11 -0000 emaste requested changes to this revision. emaste added a comment. This revision now requires changes to proceed. `_crunchide` here is still needed for cross-builds (but should be addressed by D2314). `_crunch` in the context not provided in this diff is the one that needs to be updated I updated it in rS281659 REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 16:09:29 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 37E94A80 for ; Fri, 17 Apr 2015 16:09:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1D5228A0 for ; Fri, 17 Apr 2015 16:09:29 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HG9SkU038803 for ; Fri, 17 Apr 2015 16:09:28 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HG9SjV038802; Fri, 17 Apr 2015 16:09:28 GMT (envelope-from root) Date: Fri, 17 Apr 2015 16:09:28 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Commented On] D2305: Fix bootstraping of crunchide Message-ID: <5222c346f225969421ec67fb0d111346@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxMDg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 16:09:29 -0000 imp added inline comments. INLINE COMMENTS Makefile.inc1:1476 kgzip is actually old, detritus, so I removed it in D2313. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 16:10:25 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 212D2AB7 for ; Fri, 17 Apr 2015 16:10:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 073698A8 for ; Fri, 17 Apr 2015 16:10:25 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HGAObH039004 for ; Fri, 17 Apr 2015 16:10:24 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HGAO0w039003; Fri, 17 Apr 2015 16:10:24 GMT (envelope-from root) Date: Fri, 17 Apr 2015 16:10:24 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Commented On] D2305: Fix bootstraping of crunchide Message-ID: X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxMHA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 16:10:25 -0000 imp added inline comments. INLINE COMMENTS Makefile.inc1:1470 RELEASEDIR is detritus, so I removed it in D2313. It hasn't been a thing since FreeBSD 9's rewrite of the release process. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 16:11:54 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C308AFF for ; Fri, 17 Apr 2015 16:11:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B701953 for ; Fri, 17 Apr 2015 16:11:54 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HGBrmc041234 for ; Fri, 17 Apr 2015 16:11:53 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HGBrv5041233; Fri, 17 Apr 2015 16:11:53 GMT (envelope-from root) Date: Fri, 17 Apr 2015 16:11:53 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Commented On] D2305: Fix bootstraping of crunchide Message-ID: <5d347cd14aefe644053975bb539c4115@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxMMk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 16:11:54 -0000 emaste added a comment. This review can be abandoned - the original issue is now fixed. We can open another review for a future change to make it unconditional. REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 17:45:00 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 44339AD2 for ; Fri, 17 Apr 2015 17:45:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 289F5366 for ; Fri, 17 Apr 2015 17:45:00 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HHixGI066669 for ; Fri, 17 Apr 2015 17:44:59 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HHixpe066668; Fri, 17 Apr 2015 17:44:59 GMT (envelope-from root) Date: Fri, 17 Apr 2015 17:44:59 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 13 lines] D2317: readelf: Validate MIPS option header Message-ID: X-Priority: 3 Thread-Topic: D2317: readelf: Validate MIPS option header X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Thread-Index: MTAzZmZlMTU5ODU1ODVlZWMxOTNkMDNkOTM0 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 17:45:00 -0000 emaste created this revision. emaste added a reviewer: imp. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Reported by antiAgainst in ELF Tool Chain ticket 442 https://sourceforge.net/p/elftoolchain/tickets/442/ REVISION DETAIL https://reviews.freebsd.org/D2317 AFFECTED FILES readelf/readelf.c To: emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 17:48:04 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 416FDB38 for ; Fri, 17 Apr 2015 17:48:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 23F5538C for ; Fri, 17 Apr 2015 17:48:04 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HHm34u066817 for ; Fri, 17 Apr 2015 17:48:03 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HHm3lK066816; Fri, 17 Apr 2015 17:48:03 GMT (envelope-from root) Date: Fri, 17 Apr 2015 17:48:03 +0000 To: freebsd-toolchain@freebsd.org From: "imp (Warner Losh)" Subject: [Differential] [Accepted] D2317: readelf: Validate MIPS option header Message-ID: X-Priority: 3 Thread-Topic: D2317: readelf: Validate MIPS option header X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTAzZmZlMTU5ODU1ODVlZWMxOTNkMDNkOTM0IFUxR1M= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 17:48:04 -0000 imp accepted this revision. imp added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2317 To: emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 19:37:05 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 392FCD49 for ; Fri, 17 Apr 2015 19:37:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1DE60180 for ; Fri, 17 Apr 2015 19:37:05 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HJb4kE018406 for ; Fri, 17 Apr 2015 19:37:04 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HJb4SD018405; Fri, 17 Apr 2015 19:37:04 GMT (envelope-from root) Date: Fri, 17 Apr 2015 19:37:04 +0000 To: freebsd-toolchain@freebsd.org From: "rodrigc (Craig Rodrigues)" Subject: [Differential] [Abandoned] D2305: Fix bootstraping of crunchide Message-ID: <3fb116db04d4ac8992895068b2642e14@localhost.localdomain> X-Priority: 3 Thread-Topic: D2305: Fix bootstraping of crunchide X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: YTkwMGQ4YTA3NGJiOTY4OTQ0ZWQwY2UwYzRiIFUxYOA= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 19:37:05 -0000 rodrigc abandoned this revision. rodrigc added a comment. Fixed by rS281659 REVISION DETAIL https://reviews.freebsd.org/D2305 To: rodrigc, imp, emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 20:13:44 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8F725E1A; Fri, 17 Apr 2015 20:13:44 +0000 (UTC) Received: from mail-la0-x22c.google.com (mail-la0-x22c.google.com [IPv6:2a00:1450:4010:c03::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 134FD809; Fri, 17 Apr 2015 20:13:44 +0000 (UTC) Received: by laat2 with SMTP id t2so88653681laa.1; Fri, 17 Apr 2015 13:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:content-type; bh=riqYKm0PmBg6wZIxxtcZXjggwVP7BqQnzW2aGcibQVk=; b=rAnCjB+4XIlskN74Shl/YtF9AuWFJFrsf6Ajbmc9eSsXCsOBsTUJ6UJCdHQXfvk7Nu YInp9DsJaZ1MQFL7AaX5Hdk7QHr7jkvFw1ukKw9ZxC8qwmVxzPDlkMB9oKCg4ftpHJTQ 61En4qFkg+m9RS79/7RGuKAcNOoGbY72frPJkFVO8RJHp4Q7VN7mK2wyDUT3ADumdPSQ 3M2nytEL5u8ZvpsI4dlkaJVE4heC3cI5T+4XoQ4kd/dnMHcuHKZq33nzoBtFWAfK8OML YBXMdAmOAAV0AUiJDCY3oAtWFnb4Y11g5K/WypqtyUo7gB35pspJzihGPgi8b2mCcMTf 5WCA== MIME-Version: 1.0 X-Received: by 10.112.16.97 with SMTP id f1mr5789668lbd.26.1429301621962; Fri, 17 Apr 2015 13:13:41 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.108.168 with HTTP; Fri, 17 Apr 2015 13:13:41 -0700 (PDT) In-Reply-To: References: Date: Fri, 17 Apr 2015 13:13:41 -0700 X-Google-Sender-Auth: 5g_Fs6hu0e4St_rXrYfKDQPmSaY Message-ID: Subject: Re: Fails to build sys/i386/boot2 with gcc 4.9 From: Craig Rodrigues To: FreeBSD Toolchain , "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 20:13:44 -0000 On Sat, Mar 28, 2015 at 4:05 PM, Craig Rodrigues wrote: > Hi, > > To work around the problems build rescue, this time I used a build host > running FreeBSD-CURRENT at svn revision r280353 > > I took this patch for libc++ and applied it to my tree: > > http://reviews.llvm.org/D8461 > > I used this script to build with gcc 4.9: > > > https://github.com/freebsd/freebsd-ci/blob/master/scripts/build/cross-build.sh > > Buildling sys/i386/boot2 failed: > > ===> sys/boot/i386/boot2 (all) > objcopy -S -O binary boot1.out boot1 > dd if=/dev/zero of=boot2.ldr bs=512 count=1 > 1+0 records in > 1+0 records out > 512 bytes transferred in 0.000034 secs (14989607 bytes/sec) > /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem > /usr/obj/opt2/branches/head/tmp/usr/include > -L/usr/obj/opt2/branches/head/tmp/usr/lib > --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ > -fomit-frame-pointer -mrtd -mregparm=3 -DUSE_XREAD -DUFS1_AND_UFS2 > -DFLAGS=0x80 -DSIOPRT=0x3f8 -DSIOFMT=0x3 -DSIOSPD=9600 > -I/opt2/branches/head/sys/boot/i386/boot2/../../common > -I/opt2/branches/head/sys/boot/i386/boot2/../btx/lib -I. -Wall > -Waggregate-return -Wbad-function-cast -Wcast-align -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow > -Wstrict-prototypes -Wwrite-strings -Winline -march=i386 -ffreestanding > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float -m32 > -std=gnu99 -Os -fno-guess-branch-probability -fno-unit-at-a-time > --param max-inline-insns-single=100 -mpreferred-stack-boundary=2 -S -o > boot2.s.tmp /opt2/branches/head/sys/boot/i386/boot2/boot2.c > /opt2/branches/head/sys/boot/i386/boot2/boot2.c: In function 'parse': > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:484:6: warning: suggest > parentheses around assignment used as truth value [-Wparentheses] > if (k = ep - arg) { > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c: In function 'load': > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:334:9: warning: called > from here [-Winline] > if (xfsread(ino, &hdr, sizeof(hdr))) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:341:6: warning: called > from here [-Winline] > if (xfsread(ino, p, hdr.ex.a_text)) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:344:6: warning: called > from here [-Winline] > if (xfsread(ino, p, hdr.ex.a_data)) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:349:10: warning: called > from here [-Winline] > if (xfsread(ino, ep + j, sizeof(ep[0]))) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:357:10: warning: called > from here [-Winline] > if (xfsread(ino, p, ep[i].p_filesz)) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:365:10: warning: called > from here [-Winline] > if (xfsread(ino, &es, sizeof(es))) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:187:1: warning: inlining > failed in call to 'xfsread': call is unlikely and code size would grow > [-Winline] > xfsread(ufs_ino_t inode, void *buf, size_t nbyte) > ^ > /opt2/branches/head/sys/boot/i386/boot2/boot2.c:371:7: warning: called > from here [-Winline] > if (xfsread(ino, p, es[i].sh_size)) > ^ > sed -e '/align/d' -e '/nop/d' < boot2.s.tmp > boot2.s > rm -f boot2.s.tmp > /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem > /usr/obj/opt2/branches/head/tmp/usr/include > -L/usr/obj/opt2/branches/head/tmp/usr/lib > --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ > -m32 -c boot2.s > /usr/local/bin/x86_64-portbld-freebsd11.0-gcc -isystem > /usr/obj/opt2/branches/head/tmp/usr/include > -L/usr/obj/opt2/branches/head/tmp/usr/lib > --sysroot=/usr/obj/opt2/branches/head/tmp -B/usr/local/x86_64-freebsd/bin/ > -fomit-frame-pointer -mrtd -mregparm=3 -DUSE_XREAD -DUFS1_AND_UFS2 > -DFLAGS=0x80 -DSIOPRT=0x3f8 -DSIOFMT=0x3 -DSIOSPD=9600 > -I/opt2/branches/head/sys/boot/i386/boot2/../../common > -I/opt2/branches/head/sys/boot/i386/boot2/../btx/lib -I. -Wall > -Waggregate-return -Wbad-function-cast -Wcast-align -Wmissing-declarations > -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wshadow > -Wstrict-prototypes -Wwrite-strings -Winline -march=i386 -ffreestanding > -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -msoft-float -m32 > -std=gnu99 -Os -fno-guess-branch-probability -fno-unit-at-a-time > --param max-inline-insns-single=100 -mpreferred-stack-boundary=2 -m32 -c > /opt2/branches/head/sys/boot/i386/boot2/sio.S -o sio.o > /usr/local/x86_64-freebsd/bin/ld -static -N --gc-sections -m elf_i386_fbsd > -Ttext 0x2000 -o boot2.out > /usr/obj/opt2/branches/head/sys/boot/i386/boot2/../btx/lib/crt0.o boot2.o > sio.o > objcopy -S -O binary boot2.out boot2.bin > btxld -v -E 0x2000 -f bin -b > /usr/obj/opt2/branches/head/sys/boot/i386/boot2/../btx/btx/btx -l > boot2.ldr -o boot2.ld -P 1 boot2.bin > kernel: ver=1.02 size=690 load=9000 entry=9010 map=16M pgctl=1:1 > client: fmt=bin size=195f text=0 data=0 bss=0 entry=0 > output: fmt=bin size=21ef text=200 data=1fef org=0 entry=0 > -1007 bytes available > *** Error code 1 > > Stop. > make[6]: stopped in /opt2/branches/head/sys/boot/i386/boot2 > *** Error code 1 > > Stop. > make[5]: stopped in /opt2/branches/head/sys/boot/i386 > *** Error code 1 > > Stop. > make[4]: stopped in /opt2/branches/head/sys/boot > *** Error code 1 > > Stop. > make[3]: stopped in /opt2/branches/head/sys > *** Error code 1 > > Stop. > make[2]: stopped in /opt2/branches/head > *** Error code 1 > > Stop. > make[1]: stopped in /opt2/branches/head > *** Error code 1 > > Stop. > make: stopped in /opt2/branches/head > > Script done on Sat Mar 28 13:44:24 2015 > > In sys/boot/i386/boot2/Makefile, I saw this section: # Decide level of UFS support. BOOT2_UFS?= UFS1_AND_UFS2 #BOOT2_UFS?= UFS2_ONLY #BOOT2_UFS?= UFS1_ONLY I tried setting just UFS2_ONLY, but I still couldn't build boot2 with gcc 4.9 due to taking too much space. I then tried setting just UFS1_ONLY, but even then I still couldn't build boot2 with gcc 4.9. So I'm really stuck here. I'm curious how the assembly of boot2 is different between gcc 4.2.1 and gcc 4.9. I didn't try compiling with gcc 4.2.1 yet. -- Craig > -- > Craig > From owner-freebsd-toolchain@FreeBSD.ORG Fri Apr 17 23:25:46 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 86526FA0 for ; Fri, 17 Apr 2015 23:25:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 64872DD8 for ; Fri, 17 Apr 2015 23:25:46 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3HNPj8F086400 for ; Fri, 17 Apr 2015 23:25:45 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3HNPjCU086399; Fri, 17 Apr 2015 23:25:45 GMT (envelope-from root) Date: Fri, 17 Apr 2015 23:25:45 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Closed] D2317: readelf: Validate MIPS option header Message-ID: <5a3ea45431ecd265cbeff8f2a7d3c8a4@localhost.localdomain> X-Priority: 3 Thread-Topic: D2317: readelf: Validate MIPS option header X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MTAzZmZlMTU5ODU1ODVlZWMxOTNkMDNkOTM0IFUxlnk= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 23:25:46 -0000 emaste closed this revision. emaste added a comment. Committed here: https://sourceforge.net/p/elftoolchain/code/3187, will come into FreeBSD with the next ELF Tool Chain import REVISION DETAIL https://reviews.freebsd.org/D2317 To: emaste, imp Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Sat Apr 18 18:12:34 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 18F1D665; Sat, 18 Apr 2015 18:12:34 +0000 (UTC) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 935C6E56; Sat, 18 Apr 2015 18:12:33 +0000 (UTC) Received: by labbd9 with SMTP id bd9so101118980lab.2; Sat, 18 Apr 2015 11:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:cc:content-type; bh=c/Ezh9LREUTOhlqM7vqwMi8ZYku7K+glrbfVsat9bsw=; b=kTGG+XTp4KhH/JtiTe0BflskDGCrjfPk3BseukSiAgjKVSqnR2OLAcpLEbOb27Iwpp YWXXB1PeAl6/Cu5uCWyvrBKUv5kh9DxlHcjLwp8sPC+OlN2ovAuuA51xJoP6Z1oQMFuO ysKwQSJwACMviZoXSr72FqEoY4swuZsgfIc0Ac7fh47Dap8tKaDEHTNhz7aF76ZOY/YT X3q3UsSWOiZOpuCQ+/ch7s99RdlEe2Z5uyk52SCwmrPTVyQ5/RKKF53k8fHG/vHO6i/p RTKSagS4dD5t18/ZQC182OJ/UbTr0EouICZc/IV7bUsrMUQw6wGUZr9DGOMF+ue6kS7S IHtA== MIME-Version: 1.0 X-Received: by 10.152.205.106 with SMTP id lf10mr9126400lac.89.1429380751781; Sat, 18 Apr 2015 11:12:31 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.164.38 with HTTP; Sat, 18 Apr 2015 11:12:31 -0700 (PDT) Date: Sat, 18 Apr 2015 11:12:31 -0700 X-Google-Sender-Auth: 6st8hkg0Il_k6jw2VOCX4WCg41E Message-ID: Subject: [Request for Help] Reducing gcc 4.9 compilation warnings From: Craig Rodrigues To: freebsd-current Current Cc: "freebsd-testing@freebsd.org" , FreeBSD Toolchain Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 18:12:34 -0000 Hi, After the latest commits by members of freebsd-toolchain@ , I have managed to compile latest CURRENT world and GENERIC kernel on amd64 with an gcc 4.9 external toolchain by doing: pkg install devel/amd64-xtoolchain-gcc cd /usr/src sed -i "" -e 's/boot2//' sys/boot/i386/Makefile make buildworld CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= make buildkernel CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= It was necessary to skip boot2 from building because of errors reported here: https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001658.html The boot2 compilation errors still need to be worked on. However, most other things compile with warnings. If folks are interested in looking at the warnings, you can see them here: https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc4.9/warnings17 Please look at these warnings, and if you see places to patch the code to eliminate the warnings, please submit patches and commit them if you can. clang is still going to be the default compiler in the base system, but it is nice to have FreeBSD compilable by multiple compilers. -- Craig From owner-freebsd-toolchain@FreeBSD.ORG Sat Apr 18 20:41:45 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3689441A for ; Sat, 18 Apr 2015 20:41:45 +0000 (UTC) Received: from asp.reflexion.net (outbound-243.asp.reflexion.net [69.84.129.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D29D7EDA for ; Sat, 18 Apr 2015 20:41:44 +0000 (UTC) Received: (qmail 18329 invoked from network); 18 Apr 2015 20:35:03 -0000 Received: from unknown (HELO rtc-sm-01.app.dca.reflexion.local) (10.81.150.1) by 0 (rfx-qmail) with SMTP; 18 Apr 2015 20:35:03 -0000 Received: by rtc-sm-01.app.dca.reflexion.local (Reflexion email security v7.51.0) with SMTP; Sat, 18 Apr 2015 16:35:03 -0400 (EDT) Received: (qmail 16224 invoked from network); 18 Apr 2015 20:35:02 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (DHE-RSA-AES256-SHA encrypted) SMTP; 18 Apr 2015 20:35:02 -0000 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.8] (c-67-189-19-145.hsd1.or.comcast.net [67.189.19.145]) by iron2.pdx.net (Postfix) with ESMTPSA id 5B468B1E001; Sat, 18 Apr 2015 13:34:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: Shorter version: -m elf32ppc_fbsd (and elf_i386_fbsd ?) vs. -Wl, -m, elf32ppc_fbsd problems (11.0-CURRENT and 10.1-STABLE) From: Mark Millard In-Reply-To: Date: Sat, 18 Apr 2015 13:35:01 -0700 Cc: freebsd-toolchain@freebsd.org, FreeBSD PowerPC ML Content-Transfer-Encoding: quoted-printable Message-Id: References: <0D8F0A9A-593E-4FEE-8F01-20799DE946B2@dsl-only.net> <7049E178-9FC8-4590-95AD-F80A2BBC3F01@dsl-only.net> To: Warner Losh X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 20:41:45 -0000 [Looks like I'll soon be mostly suspending my FreeBSD explorations for a = notable time again. So this completes my notes for the subject and = related material. It includes only what I concluded should be changed.] The following are all appropriate Makefile.inc changes as far as I can = tell. The i386 case uses LD_FLAGS instead and is commented indicating = that it uses ${LD} directly and does not use ${CC}. So chaining it is = not appropriate. # svnlite diff sys/boot/ofw/Makefile.inc sys/boot/powerpc/Makefile.inc = sys/boot/uboot/Makefile.inc Index: sys/boot/ofw/Makefile.inc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/boot/ofw/Makefile.inc (revision 281630) +++ sys/boot/ofw/Makefile.inc (working copy) @@ -2,7 +2,7 @@ =20 .if ${MACHINE_ARCH} =3D=3D "powerpc64" CFLAGS+=3D -m32 -mcpu=3Dpowerpc -LDFLAGS+=3D -m elf32ppc_fbsd +LDFLAGS+=3D -Wl,-m -Wl,elf32ppc_fbsd .endif =20 .include "../Makefile.inc" Index: sys/boot/powerpc/Makefile.inc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/boot/powerpc/Makefile.inc (revision 281630) +++ sys/boot/powerpc/Makefile.inc (working copy) @@ -2,7 +2,7 @@ =20 .if ${MACHINE_ARCH} =3D=3D "powerpc64" CFLAGS+=3D -m32 -mcpu=3Dpowerpc -LDFLAGS+=3D -m elf32ppc_fbsd +LDFLAGS+=3D -Wl,-m -Wl,elf32ppc_fbsd .endif =20 .include "../Makefile.inc" Index: sys/boot/uboot/Makefile.inc =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/boot/uboot/Makefile.inc (revision 281630) +++ sys/boot/uboot/Makefile.inc (working copy) @@ -2,7 +2,7 @@ =20 .if ${MACHINE_ARCH} =3D=3D "powerpc64" CFLAGS+=3D -m32 -mcpu=3Dpowerpc -LDFLAGS+=3D -m elf32ppc_fbsd +LDFLAGS+=3D -Wl,-m -Wl,elf32ppc_fbsd .endif =20 .include "../Makefile.inc" =3D=3D=3D Mark Millard markmi at dsl-only.net From owner-freebsd-toolchain@FreeBSD.ORG Sat Apr 18 21:00:54 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B9294B59 for ; Sat, 18 Apr 2015 21:00:54 +0000 (UTC) Received: from asp.reflexion.net (outbound-243.asp.reflexion.net [69.84.129.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 62621109 for ; Sat, 18 Apr 2015 21:00:53 +0000 (UTC) Received: (qmail 8078 invoked from network); 18 Apr 2015 21:00:53 -0000 Received: from unknown (HELO mail-cs-02.app.dca.reflexion.local) (10.81.19.2) by 0 (rfx-qmail) with SMTP; 18 Apr 2015 21:00:53 -0000 Received: by mail-cs-02.app.dca.reflexion.local (Reflexion email security v7.51.0) with SMTP; Sat, 18 Apr 2015 17:00:53 -0400 (EDT) Received: (qmail 26693 invoked from network); 18 Apr 2015 21:00:52 -0000 Received: from unknown (HELO iron2.pdx.net) (69.64.224.71) by 0 (rfx-qmail) with (DHE-RSA-AES256-SHA encrypted) SMTP; 18 Apr 2015 21:00:52 -0000 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Received: from [192.168.1.8] (c-67-189-19-145.hsd1.or.comcast.net [67.189.19.145]) by iron2.pdx.net (Postfix) with ESMTPSA id 092AAB1E001; Sat, 18 Apr 2015 14:00:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: gcc-4.9.1/gcc/config/rs6000/freebsd64.h vs. FreeBSD's powerpc (non-64) L"..." and wchar_t (other gcc ports too?) From: Mark Millard In-Reply-To: <3734A273-6178-4AF5-B066-DEEB6CFC7F1C@dsl-only.net> Date: Sat, 18 Apr 2015 14:00:51 -0700 Cc: freebsd-toolchain@freebsd.org, FreeBSD PowerPC ML Content-Transfer-Encoding: quoted-printable Message-Id: <5994D629-964B-4394-B6DD-2C2D6907882F@dsl-only.net> References: <5B228278-A967-46D4-8F56-08E47008D009@dsl-only.net> <3734A273-6178-4AF5-B066-DEEB6CFC7F1C@dsl-only.net> To: freebsd-ports@freebsd.org X-Mailer: Apple Mail (2.2098) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 21:00:54 -0000 [Looks like I'll soon be suspending my FreeBSD explorations for a time = again. So this completes my notes for the subject and related material.] Reminder of the "long int" issue in = gcc-4.9.1/gcc/config/rs6000/freebsd64.h that gets the wrong type for L" = . . . " notation for FreeBSD: > /* rs6000.h gets this wrong for FreeBSD. We use the GCC defaults = instead. */ > #undef WCHAR_TYPE > #define WCHAR_TYPE (TARGET_64BIT ? "int" : "long int") > #undef WCHAR_TYPE_SIZE > #define WCHAR_TYPE_SIZE 32 I did try changing my = /usr/obj/portswork/usr/ports/devel/powerpc64-gcc/work/gcc-4.9.1/gcc/config= /rs6000/freebsd64.h so that WCHAR_TYPE would always use "int" and = rebuilding powerpc64-gcc. With that I was able to compile lib32, no = longer having a bad type for the L prefix notation on string literals. So I expect that requesting a fix upstream and/or patching such files in = gcc ports that have such a "long int" for powerpc FreeBSD targets is = appropriate. Side note likely specific to my context in some way . . . Unfortunately that lib32 built did not mean that using it worked. A -g = -m32 compile/link of > int main() > { > return 0; > } produces something for which ./a.out segmentation faults in a way that = neither the system nor the port gdb can report on where. For now it looks like I'm not going to have the time to work on figuring = out any of the issues involved. =3D=3D=3D Mark Millard markmi at dsl-only.net