From owner-freebsd-toolchain@FreeBSD.ORG Sun Apr 19 09:10:49 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 27785287 for ; Sun, 19 Apr 2015 09:10:49 +0000 (UTC) Received: from mail-wg0-x231.google.com (mail-wg0-x231.google.com [IPv6:2a00:1450:400c:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C067BDFA for ; Sun, 19 Apr 2015 09:10:48 +0000 (UTC) Received: by wgyo15 with SMTP id o15so150986338wgy.2 for ; Sun, 19 Apr 2015 02:10:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=jGf6EJebwz2ND6YXXKVas8GEARpT2ZW2sgqU85dzA2U=; b=VmL0//eKiIwYnFby8pyQyL5syY6DPJyIKtNiL1IS6H3A/s0U6hWZl61VjCE1M+STrP QAGeH9sbxi2ThXavxdMhEi9A7qUu23Dn3eoItGfSmbLTNdre3ERZKnHYbrHTdqB3eC3h 3See6NajWbnuH66XH4SAG4NYnjnaGyBZ2k6OM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=jGf6EJebwz2ND6YXXKVas8GEARpT2ZW2sgqU85dzA2U=; b=WUt22xBB6zOXhzilpfHbLu0ctEHjbYLtsrG2pKPIwUnfRjAugVFRDJOXO+AaW/mD2F dEP0iNvbvOQ/u4Twc/3BsQiv3lmcV0sWAOkcnXi6UbyQYEl7LRT/on8PBlS0z7jDl/uM Gn/EoRLRqpVeTtBWk8WaMjiES63dm/p5yTVIjteqVwgmiQaK18whw7OHeudVYCCglROu iFJFfcTIwrf71Xqv5q30PRBRm7qYbFQTo8Y53wM01JK9JXFFGWW1CnLAtngDQXM8ikIx Z8xSIUgQ7AUKrEWxs1CfIU6A/EjHPtnifSIWDngXieu1XtcMnbtn93QnayWMTpW0/3dq VUQQ== X-Gm-Message-State: ALoCoQmAp6axtxL8GjFWVFIekRUoLYHSSJyeW/UOFQu5uKhoJSsjJ0/evgwxyYrSRKxXvr2vgtdj X-Received: by 10.194.237.34 with SMTP id uz2mr20632972wjc.157.1429434647286; Sun, 19 Apr 2015 02:10:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.211.135 with HTTP; Sun, 19 Apr 2015 02:10:16 -0700 (PDT) In-Reply-To: References: From: Eitan Adler Date: Sun, 19 Apr 2015 02:10:16 -0700 Message-ID: Subject: Re: [Request for Help] Reducing gcc 4.9 compilation warnings To: Craig Rodrigues Cc: freebsd-current Current , "freebsd-testing@freebsd.org" , FreeBSD Toolchain Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 09:10:49 -0000 " On 18 April 2015 at 11:12, Craig Rodrigues wrote: > Hi, > > After the latest commits by members of freebsd-toolchain@ , > I have managed to compile latest CURRENT world and GENERIC > kernel on amd64 with an gcc 4.9 external toolchain by doing: > > pkg install devel/amd64-xtoolchain-gcc > cd /usr/src > sed -i "" -e 's/boot2//' sys/boot/i386/Makefile > make buildworld CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= > make buildkernel CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= > > > It was necessary to skip boot2 from building because of errors > reported here: > https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001658.html > > The boot2 compilation errors still need to be worked on. > > However, most other things compile with warnings. If folks are > interested in looking at the warnings, you can see them here: > > https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc4.9/warnings17 > > Please look at these warnings, and if you see places to > patch the code to eliminate the warnings, please submit patches > and commit them if you can. Some time ago I tried to do something similar, but with gcc4.6 instead of gcc4.9. The vast majority of warnings (1548) are "unused-but-set-variable" and it may be worthwhile to just silence this warning, at least at low WARNS levels. It has caught real errors but is quite noisy and can cause quite a bit of churn. "inline" (count 515) is generally pure noise, and I think we should disable it. It can be helpful to find certain types of performance optimizations, but it should be opt-in. "strict-aliasing" (154) are likely all real bugs of some form. Very few exist in contrib code, and it would be good to fix them. "Warning" (111) seem to be a mix of warnings, but mostly in contrib code. "maybe-uninitialized" (111) is often noisy, and in a spot check were all false positives. "deprecated-declarations" (22) is all in contrib code Many of these are useful though and I've already fixed a few of the bugs reported. Perhaps it would be useful to do a second run of this, but with a modified share/mk to silence the most useless of these warnings? -- Eitan Adler From owner-freebsd-toolchain@FreeBSD.ORG Sun Apr 19 15:19:31 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 855EC847; Sun, 19 Apr 2015 15:19:31 +0000 (UTC) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E42C80B; Sun, 19 Apr 2015 15:19:31 +0000 (UTC) Received: by igbhj9 with SMTP id hj9so43507055igb.1; Sun, 19 Apr 2015 08:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=MlxL5kvb8OhxHBeLDUfegcL4jFp5Llf5rOxVfrrsh1k=; b=Hin6jQNXkDncUwYMT9Wwhypo092j+S0yqgvo5BJy/5/O733iFrq6FrPmGS0iXxloCn ZureQBJZitaxrSUiKkHbVqeFOxbKsrjM5Rmhd5STWxfITryZKQfPbl+i5FRlOQZLlrSp Sy9Nv9aBMXN1OYFA6icFLnq16K5eIHkM10UHXpF6CqxJjzhA78C6qkopiaYpHCG5HHNM HfkxdIxgZC5hNVH1kGT2B250gAIx14+jJMVJL67QCQDaeaL3O1Bfwvlk0v/t4eSySWtt xr0alirS/oEMrXB7EiYvhakZvezHZDoKWpXAbvF5HNBJ0axQtiengdfVKOvzqpxf8qcw S9VA== MIME-Version: 1.0 X-Received: by 10.42.137.202 with SMTP id z10mr14162619ict.37.1429456770652; Sun, 19 Apr 2015 08:19:30 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.17.194 with HTTP; Sun, 19 Apr 2015 08:19:30 -0700 (PDT) In-Reply-To: References: Date: Sun, 19 Apr 2015 08:19:30 -0700 X-Google-Sender-Auth: 6h0qlEIN0qAEhgNNivNX9lp3JT8 Message-ID: Subject: Re: [Request for Help] Reducing gcc 4.9 compilation warnings From: Adrian Chadd To: Eitan Adler Cc: Craig Rodrigues , freebsd-current Current , "freebsd-testing@freebsd.org" , FreeBSD Toolchain Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2015 15:19:31 -0000 On 19 April 2015 at 02:10, Eitan Adler wrote: > " > > On 18 April 2015 at 11:12, Craig Rodrigues wrote: >> Hi, >> >> After the latest commits by members of freebsd-toolchain@ , >> I have managed to compile latest CURRENT world and GENERIC >> kernel on amd64 with an gcc 4.9 external toolchain by doing: >> >> pkg install devel/amd64-xtoolchain-gcc >> cd /usr/src >> sed -i "" -e 's/boot2//' sys/boot/i386/Makefile >> make buildworld CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= >> make buildkernel CROSS_TOOLCHAIN=amd64-gcc NO_WERROR=yes WERROR= >> >> >> It was necessary to skip boot2 from building because of errors >> reported here: >> https://lists.freebsd.org/pipermail/freebsd-toolchain/2015-April/001658.html >> >> The boot2 compilation errors still need to be worked on. >> >> However, most other things compile with warnings. If folks are >> interested in looking at the warnings, you can see them here: >> >> https://jenkins.freebsd.org/job/FreeBSD_HEAD_amd64_gcc4.9/warnings17 >> >> Please look at these warnings, and if you see places to >> patch the code to eliminate the warnings, please submit patches >> and commit them if you can. > > Some time ago I tried to do something similar, but with gcc4.6 instead > of gcc4.9. > > The vast majority of warnings (1548) are "unused-but-set-variable" and > it may be worthwhile to just silence this warning, at least at low > WARNS levels. It has caught real errors but is quite noisy and can > cause quite a bit of churn. > > "inline" (count 515) is generally pure noise, and I think we should > disable it. It can be helpful to find certain types of performance > optimizations, but it should be opt-in. > > "strict-aliasing" (154) are likely all real bugs of some form. Very > few exist in contrib code, and it would be good to fix them. > > "Warning" (111) seem to be a mix of warnings, but mostly in contrib code. > > "maybe-uninitialized" (111) is often noisy, and in a spot check were > all false positives. > > "deprecated-declarations" (22) is all in contrib code > > Many of these are useful though and I've already fixed a few of the > bugs reported. > > Perhaps it would be useful to do a second run of this, but with a > modified share/mk to silence the most useless of these warnings? I just got a booting mips32 kernel using gcc-4.9.2, and boy are there a lot of warnings. I'm going to start fixing the ones I find - cleaner code is better code. Mostly. (I'd be happy with -Wall -Werror.) -adrian From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 20 16:46:42 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A2EEA324; Mon, 20 Apr 2015 16:46:42 +0000 (UTC) Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu [18.9.25.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E145DDD2; Mon, 20 Apr 2015 16:46:41 +0000 (UTC) X-AuditID: 1209190d-f79676d000000da0-49-55352d691540 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) (using TLS with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP id E5.7A.03488.A6D25355; Mon, 20 Apr 2015 12:46:34 -0400 (EDT) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id t3KGkWMK010733; Mon, 20 Apr 2015 12:46:33 -0400 Received: from multics.mit.edu (system-low-sipb.mit.edu [18.187.2.37]) (authenticated bits=56) (User authenticated as kaduk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id t3KGkUXR000539 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 20 Apr 2015 12:46:31 -0400 Received: (from kaduk@localhost) by multics.mit.edu (8.12.9.20060308) id t3KGkToZ011605; Mon, 20 Apr 2015 12:46:29 -0400 (EDT) Date: Mon, 20 Apr 2015 12:46:29 -0400 (EDT) From: Benjamin Kaduk X-X-Sender: kaduk@multics.mit.edu To: Adrian Chadd cc: Eitan Adler , Craig Rodrigues , freebsd-current Current , "freebsd-testing@freebsd.org" , FreeBSD Toolchain Subject: Re: [Request for Help] Reducing gcc 4.9 compilation warnings In-Reply-To: Message-ID: References: User-Agent: Alpine 1.10 (GSO 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOKsWRmVeSWpSXmKPExsUixCmqrJulaxpqcH8Di8XerduZLOa8+cBk 0T2lk83i19djjBaLTrQzWezt7WFzYPOYtvkgm8eMT/NZApiiuGxSUnMyy1KL9O0SuDKuTvnH XrCdpWJq4xKWBsYDzF2MnBwSAiYS2/6fYoSwxSQu3FvPBmILCSxmkvj0pKCLkQvI3sgo0Xt1 PiOEc4hJ4t3hmSwQTgOjRNv00+wgLSwC2hJf/2wBs9kE1CQe721mhRirKLH51CSgdRwcIgKq Ep3znUHCzAL9TBLfboaB2MICrhL/7iwEK+cUCJTou3mbFaScV8BR4vjxWIiDbjFKrLuiC2KL CuhIrN4/hQXE5hUQlDg58wkLxEgtieXTt7FMYBSahSQ1C0lqASPTKkbZlNwq3dzEzJzi1GTd 4uTEvLzUIl0jvdzMEr3UlNJNjOAwl+TdwfjuoNIhRgEORiUeXglDk1Ah1sSy4srcQ4ySHExK orxztU1DhfiS8lMqMxKLM+KLSnNSiw8xSnAwK4nwCrID5XhTEiurUovyYVLSHCxK4rybfvCF CAmkJ5akZqemFqQWwWRlODiUJHiNdIAaBYtS01Mr0jJzShDSTBycIMN5gIZHgdTwFhck5hZn pkPkTzHqctyZ8n8RkxBLXn5eqpQ4rzVIkQBIUUZpHtwcWHp6xSgO9JYw73SQKh5gaoOb9Apo CRPQkrhtJiBLShIRUlINjHE7XdYE1yXd7v7feCf7t2CNZXLl9Cl2zPrS23Pm+HaU/Co/wiF+ bvbOyd2x1koBqdGybZfsXubfLJ1WIVy66PEmL5V5VZ/NSk/Vz0vzrUz5L77yuLLfAs3bwu3u 6r3OfTf/xcRUnaljudx9Jkb8mRHPmZ9THVc7nTv7+VyDudnqMFXzK3YLlViKMxINtZiLihMB Tvoi8CoDAAA= X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 16:46:42 -0000 On Sun, 19 Apr 2015, Adrian Chadd wrote: > I just got a booting mips32 kernel using gcc-4.9.2, and boy are there > a lot of warnings. I'm going to start fixing the ones I find - cleaner > code is better code. Mostly. > > (I'd be happy with -Wall -Werror.) I thought that -Wall was a fixed set of warnings nowhere close to all of them (to avoid breaking peoples' builds as new warnings are introduced), and a larger set would be better. (Things like -Wmaybe-uninitialized have too many false positives to be a desirable -Werror target, though.) -Ben From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 20 18:09:47 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3E650850; Mon, 20 Apr 2015 18:09:47 +0000 (UTC) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com [IPv6:2a00:1450:4010:c04::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BB9CFA34; Mon, 20 Apr 2015 18:09:46 +0000 (UTC) Received: by lbbqq2 with SMTP id qq2so136999725lbb.3; Mon, 20 Apr 2015 11:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=BwYe0a/lHGeVQc1OIKATxTmD2ANZNbAdUqR3e0/M9oc=; b=VEO5tFU8r7qH+PwiIauJ4D02PvmkyJ4a2xfGs1CY7VhJ2SntPwK325sZV4JQMNtptW AaW16qg103Y6MB/uZkqaXBoZUgqZcyHtC8wC/zpzN2PsHTQVvN9vJNqrvkIZfpuAY5LC yw0nhZmqKO7Zx2CVSu01wcIXpgkHmq3IJbCm5Ebh+fhYXgF1WGEdxvl0WqvQNO+/hduH mWUG6qiW/csONyY0WHWqFBIDZCp5hjOb+dzqye3pvDrEejd5UTqmgsvjs+sw5QhnqCUH GRHf+GwroxQV3ow9WOGqYyN1P3qhNI6n55qQfQkZSuJTWtJJZbERBU0jyyy69Wdy89q4 LL2Q== MIME-Version: 1.0 X-Received: by 10.152.120.163 with SMTP id ld3mr16921654lab.59.1429553384754; Mon, 20 Apr 2015 11:09:44 -0700 (PDT) Sender: crodr001@gmail.com Received: by 10.112.164.38 with HTTP; Mon, 20 Apr 2015 11:09:44 -0700 (PDT) In-Reply-To: References: Date: Mon, 20 Apr 2015 11:09:44 -0700 X-Google-Sender-Auth: kcv7M7sj21mCbHnZAgkZ-K9drG0 Message-ID: Subject: Re: [Request for Help] Reducing gcc 4.9 compilation warnings From: Craig Rodrigues To: Eitan Adler Cc: freebsd-current Current , "freebsd-testing@freebsd.org" , FreeBSD Toolchain Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 18:09:47 -0000 On Sun, Apr 19, 2015 at 2:10 AM, Eitan Adler wrote: > > Perhaps it would be useful to do a second run of this, but with a > modified share/mk to silence the most useless of these warnings? > > Sure, that's fine. Can you provide a modified share/mk which you think does the right thing? We can try it. -- Craig From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 20 20:43:39 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CC1105A2 for ; Mon, 20 Apr 2015 20:43:39 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B20A0F3C for ; Mon, 20 Apr 2015 20:43:39 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3KKhdAa045180 for ; Mon, 20 Apr 2015 20:43:39 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3KKhdCd045179; Mon, 20 Apr 2015 20:43:39 GMT (envelope-from root) Date: Mon, 20 Apr 2015 20:43:39 +0000 To: freebsd-toolchain@freebsd.org From: "emaste (Ed Maste)" Subject: [Differential] [Request, 32 lines] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-Cc: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEw X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 20:43:39 -0000 emaste created this revision. emaste added a subscriber: freebsd-toolchain. REVISION SUMMARY Variations reported in: https://sourceforge.net/p/elftoolchain/tickets/439 https://sourceforge.net/p/elftoolchain/tickets/444 https://sourceforge.net/p/elftoolchain/tickets/445 https://sourceforge.net/p/elftoolchain/tickets/467 REVISION DETAIL https://reviews.freebsd.org/D2338 AFFECTED FILES readelf/readelf.c To: emaste Cc: freebsd-toolchain From owner-freebsd-toolchain@FreeBSD.ORG Mon Apr 20 20:50:44 2015 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6863F936 for ; Mon, 20 Apr 2015 20:50:44 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ACDBFAC for ; Mon, 20 Apr 2015 20:50:44 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t3KKohui046219 for ; Mon, 20 Apr 2015 20:50:43 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t3KKoh3I046218; Mon, 20 Apr 2015 20:50:43 GMT (envelope-from root) Date: Mon, 20 Apr 2015 20:50:43 +0000 To: freebsd-toolchain@freebsd.org From: "brooks (Brooks Davis)" Subject: [Differential] [Accepted] D2338: readelf: avoid division by zero for files with invalid sh_entsize Message-ID: X-Priority: 3 Thread-Topic: D2338: readelf: avoid division by zero for files with invalid sh_entsize X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmMzNDdkZjZhNjRlYTVmZjk2ZjhhYzllZGEwIFU1ZqM= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 20:50:44 -0000 brooks added a subscriber: brooks. brooks accepted this revision. brooks added a reviewer: brooks. brooks added a comment. This revision is now accepted and ready to land. Looks good to me. REVISION DETAIL https://reviews.freebsd.org/D2338 To: emaste, brooks Cc: brooks, freebsd-toolchain