Date: Sat, 18 Apr 2015 19:01:31 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281719 - head/bin/ed Message-ID: <5532F05B.2070204@FreeBSD.org> In-Reply-To: <201504182356.t3INu4HD008807@svn.freebsd.org> References: <201504182356.t3INu4HD008807@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Oh yes ... On 04/18/15 18:56, Eitan Adler wrote: > Author: eadler > Date: Sat Apr 18 23:56:04 2015 > New Revision: 281719 > URL: https://svnweb.freebsd.org/changeset/base/281719 > > Log: > bin/ed: use correct type in multiplication > The result is line_t** so the multiplication should be size * > sizeof(line_t*) > > MFC After: 1 month > > Modified: > head/bin/ed/glbl.c > > Modified: head/bin/ed/glbl.c > ============================================================================== > --- head/bin/ed/glbl.c Sat Apr 18 23:49:57 2015 (r281718) > +++ head/bin/ed/glbl.c Sat Apr 18 23:56:04 2015 (r281719) > @@ -153,7 +153,7 @@ set_active_node(line_t *lp) > if (active_list != NULL) { > #endif > if ((ts = (line_t **) realloc(active_list, > - (ti += MINBUFSZ) * sizeof(line_t **))) == NULL) { > + (ti += MINBUFSZ) * sizeof(line_t *))) == NULL) { > fprintf(stderr, "%s\n", strerror(errno)); > errmsg = "out of memory"; > SPL0(); > Found by: clang static checker http://scan.freebsd.org/scan-build/bin/2015-04-18-amd64/report-9ba1bb.html#EndPath ;) Thanks, Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5532F05B.2070204>