Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Sep 2015 09:59:14 +0000 (UTC)
From:      Andriy Gapon <avg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-vendor@freebsd.org
Subject:   svn commit: r287817 - vendor-sys/illumos/dist/uts/common/fs/zfs
Message-ID:  <201509150959.t8F9xETC099116@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: avg
Date: Tue Sep 15 09:59:13 2015
New Revision: 287817
URL: https://svnweb.freebsd.org/changeset/base/287817

Log:
  6220 memleak in l2arc on debug build
  
  https://github.com/illumos/illumos-gate/commit/c546f36aa898d913ff77674fb5ff97f15b2e08b4
  https://www.illumos.org/issues/6220
    5408 introduced a memleak in l2arc, namely the member b_thawed gets leaked when
    an arc_hdr is realloced from full to l2only.
  
  Reviewed by: Saso Kiselkov <saso.kiselkov@nexenta.com>
  Reviewed by: Simon Klinkert <simon.klinkert@gmail.com>
  Reviewed by: George Wilson <george@delphix.com>
  Approved by: Robert Mustacchi <rm@joyent.com>
  Author: Arne Jansen <sensille@gmx.net>

Modified:
  vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c

Modified: vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c
==============================================================================
--- vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c	Tue Sep 15 09:36:46 2015	(r287816)
+++ vendor-sys/illumos/dist/uts/common/fs/zfs/arc.c	Tue Sep 15 09:59:13 2015	(r287817)
@@ -1305,6 +1305,13 @@ arc_hdr_realloc(arc_buf_hdr_t *hdr, kmem
 		VERIFY(!HDR_L2_WRITING(hdr));
 		VERIFY3P(hdr->b_l1hdr.b_tmp_cdata, ==, NULL);
 
+#ifdef ZFS_DEBUG
+		if (hdr->b_l1hdr.b_thawed != NULL) {
+			kmem_free(hdr->b_l1hdr.b_thawed, 1);
+			hdr->b_l1hdr.b_thawed = NULL;
+		}
+#endif
+
 		nhdr->b_flags &= ~ARC_FLAG_HAS_L1HDR;
 	}
 	/*



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201509150959.t8F9xETC099116>