Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Mar 2016 01:47:22 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Greg 'groggy' Lehey <grog@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r410937 - head/graphics/hugin-2016
Message-ID:  <CBAE56BBC69E2F394CB287D0@atuin.in.mat.cc>
In-Reply-To: <20160312233654.GH89167@eureka.lemis.com>
References:  <201603122236.u2CMaBVf039238@repo.freebsd.org> <DCFAAA6DD9AAC26F0C17C90C@atuin.in.mat.cc> <20160312233654.GH89167@eureka.lemis.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--==========D9F194EA98FE95368516==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

+--On 13 mars 2016 10:36:54 +1100 Greg 'groggy' Lehey <grog@FreeBSD.org>
wrote:
| On Saturday, 12 March 2016 at 23:44:26 +0100, Mathieu Arnold wrote:
|> Hi,
|> 
|> +--On 12 mars 2016 22:36:11 +0000 Greg Lehey <grog@FreeBSD.org> wrote:
|>> Author: grog (src committer)
|>> Date: Sat Mar 12 22:36:11 2016
|>> New Revision: 410937
|>> URL: https://svnweb.freebsd.org/changeset/ports/410937
|>> 
|>> Log:
|>>   Upgrade to 2016.0.0 RC2.
|>>   Remove repetitive PKGNAMESUFFIX.
|> 
|> It looks like it was not reviewed by a ports committer, which explains
|> the mistakes, could you please get all your following ports commits
|> reviewed by a ports committer ?
| 
| I am a ports committer, as my ex-mentors edwin@ and itetcu@ should
| confirm, though it seems that the appropriate lists haven't been
| updated.  I'm also MAINTAINER for this port.  And I see no mistakes.
| If you see any, it would have been helpful for you to explain, not to
| revert without discussion.
| 
| What's your problem?  I see that you committed this change originally
| port without consulting me, assigning me a pointy hat (which I find
| somewhat offensive), with an inappropriate commit message, and
| presumably without testing.  The result is a package called
| hugin-2016-2016.0.0.r1.  Reverting your commit gave a more logical
| hugin-2016.0.0.r1.
| 
| I also see that, rather than discussing this matter with me first, you
| reverted my commit.  That's the beginning of a commit war.  I consider
| your behaviour impolite.  Please back it out.

Well, I am sorry if I offended you.

According to the access file, your ports commit bit was take in for safe
keeping in 2008, seems nobody put you back there when you got back in 2013.
Thus my confusion.

There already is a port that has "hugin" as PKGBASE, it is graphcis/hugin.
And it is forbidden to have two ports with the same PKGBASE.  I can refer
you to the "PORTNAME And PORTREVISION" section of the Porter's Handbook:
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html

If hugin-2016 does not seem right, feel free to change the -2016 to
something else, but do not remove it again.

Regards,

-- 
Mathieu Arnold
--==========D9F194EA98FE95368516==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQJ8BAEBCgBmBQJW5LiaXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ID7cP/2OKk4F5JewgsojVsLAWpMl/
qvnHsdxXjG+lYw8su4j8kGqajujkeUZwZq8uXOGFeNuDXJVq1ioDQAwX37YwsAqH
vk4soVPJrql0NXxkeDSUXGbra5RsMvdVQrbOMV/w744TJFqV8ryVawNSISfSXZiA
/qJyR1D2k2lKmGLC+UgSVgA8x/OkEMvUEVIPXTLYm6Hp2UtPJa3GHMrHgzHmU/wE
M7DCrpBIFMPrGTqZ8pWyavOnoV55mYbv+7reL+FoSiiyCXi+BrQR5xnU4hN1y4yC
ilDQBXNuDM9v0bl4jiS0OPo5dDSFAa4ASn2q9oke0o9fnYZaCaWixmF+oDMX5nxY
My39ldXX0ImdY84FXBIPasUVXuEwQfzWJ+7vXuLSS15JJeZpTMeCrH8BN+BE9gF2
gIT2O8IY3h+k4DR31bWhXy8N6Ig4WTd3z3nZRbs4o4z1lYtxBqUEV8NDRcnjaAFL
ajJD2U/EX31Vp4HEcSrj5/70KhUm2/JLFJlVHOeKVUQ5g3/A58FirCbqtdpb7ptJ
swIwqOkDvxYyypfhacuh6+xszKL+rFtNzmxU4kYbKekVRJyd+JF+JL66ggZo91hZ
NWNC808vrPcP/Sx4PHEwF+hAjyr1D0QaaWdd6LHIyA2rifOg8sMRN9inVLcO/8qA
Q2AIka91RwFroueFO/Ex
=46VZ
-----END PGP SIGNATURE-----

--==========D9F194EA98FE95368516==========--




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CBAE56BBC69E2F394CB287D0>