From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 04:35:05 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDFCFBB9903; Sun, 14 Aug 2016 04:35:05 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADC44178E; Sun, 14 Aug 2016 04:35:05 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7E4Z4JV022555; Sun, 14 Aug 2016 04:35:04 GMT (envelope-from gjb@FreeBSD.org) Received: (from gjb@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7E4Z4Fm022554; Sun, 14 Aug 2016 04:35:04 GMT (envelope-from gjb@FreeBSD.org) Message-Id: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gjb set sender to gjb@FreeBSD.org using -f From: Glen Barber Date: Sun, 14 Aug 2016 04:35:04 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r304070 - svnadmin/conf X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 04:35:06 -0000 Author: gjb Date: Sun Aug 14 04:35:04 2016 New Revision: 304070 URL: https://svnweb.freebsd.org/changeset/base/304070 Log: Do not include C function changes by default in svn commit email. No objection: svnadmin Submitted by: des Sponsored by: The FreeBSD Foundation Modified: svnadmin/conf/mailer.conf Modified: svnadmin/conf/mailer.conf ============================================================================== --- svnadmin/conf/mailer.conf Sun Aug 14 04:11:36 2016 (r304069) +++ svnadmin/conf/mailer.conf Sun Aug 14 04:35:04 2016 (r304070) @@ -143,7 +143,7 @@ # This is not passed to the shell, so do not use shell metacharacters. # The command is split around whitespace, so if you want to include # whitespace in the command, then ### something ###. -diff = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s +diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s # The default prefix for the Subject: header for commits. commit_subject_prefix = svn commit: From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 04:39:18 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27375BB99AF; Sun, 14 Aug 2016 04:39:18 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f170.google.com (mail-io0-f170.google.com [209.85.223.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EFC94194C; Sun, 14 Aug 2016 04:39:17 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f170.google.com with SMTP id m101so56879420ioi.2; Sat, 13 Aug 2016 21:39:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=dwYJJwsWEVY2EA2JWI/cxjwKQ22jagiQI2AUdPVffdc=; b=CZFn8RIXidR0ZJqn/1CqbAbM4uKiB3Rw9NocBIpyHwTr5sMNX0P1xjvXliPEe7uo5i gT3ezqZg0u5u6o4X5EIRUd8VziZhVudhhp9HIYP+ESpmFxWoeLGLnzZgZR8yh5TMkwua oPCmcR9v1IySgIJyuKDiHEKuGNBNz5rrHzBWdSaKl69fCKoFYgKOM9WRYd0YqDu/1EiD jn0OoC+am7brzTJhRPcb6ysJigJ7PZvjsJMzW0DMRirDK+FLMXeQV3Ml9I7KXva2ClPK if6MgtvhNWm28sSQbiKVEAfv94KKSMMdpwlQylx60+w9uoJUWIhDenoLArUjoK5zldsl zYhw== X-Gm-Message-State: AEkoousX3Xzoi3MP7HdwrCX89N//RoWZRXgWs5hd/1Y09vg0lkM3D6V4ct7SJnKAw0oRPw== X-Received: by 10.107.135.142 with SMTP id r14mr28564346ioi.133.1471149555714; Sat, 13 Aug 2016 21:39:15 -0700 (PDT) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com. [209.85.214.44]) by smtp.gmail.com with ESMTPSA id h99sm7036380iod.9.2016.08.13.21.39.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Aug 2016 21:39:15 -0700 (PDT) Received: by mail-it0-f44.google.com with SMTP id c13so5485941ith.1; Sat, 13 Aug 2016 21:39:15 -0700 (PDT) X-Received: by 10.36.76.16 with SMTP id a16mr6977454itb.86.1471149555229; Sat, 13 Aug 2016 21:39:15 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sat, 13 Aug 2016 21:39:14 -0700 (PDT) In-Reply-To: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> From: Conrad Meyer Date: Sat, 13 Aug 2016 21:39:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf To: Glen Barber Cc: src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 04:39:18 -0000 Wait, what? Why not? This option provides useful context for reviewing changes. Best, Conrad On Sat, Aug 13, 2016 at 9:35 PM, Glen Barber wrote: > Author: gjb > Date: Sun Aug 14 04:35:04 2016 > New Revision: 304070 > URL: https://svnweb.freebsd.org/changeset/base/304070 > > Log: > Do not include C function changes by default in svn commit > email. > > No objection: svnadmin > Submitted by: des > Sponsored by: The FreeBSD Foundation > > Modified: > svnadmin/conf/mailer.conf > > Modified: svnadmin/conf/mailer.conf > ============================================================================== > --- svnadmin/conf/mailer.conf Sun Aug 14 04:11:36 2016 (r304069) > +++ svnadmin/conf/mailer.conf Sun Aug 14 04:35:04 2016 (r304070) > @@ -143,7 +143,7 @@ > # This is not passed to the shell, so do not use shell metacharacters. > # The command is split around whitespace, so if you want to include > # whitespace in the command, then ### something ###. > -diff = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s > +diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s > > # The default prefix for the Subject: header for commits. > commit_subject_prefix = svn commit: > From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 04:47:25 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49E24BB9B27; Sun, 14 Aug 2016 04:47:25 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 210871D33; Sun, 14 Aug 2016 04:47:25 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id B8E0A1FB7; Sun, 14 Aug 2016 04:47:24 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Sun, 14 Aug 2016 04:47:23 +0000 From: Glen Barber To: Conrad Meyer Cc: src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@FreeBSD.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160814044723.GF11079@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1RkCiX/UEfbG28Bk" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 04:47:25 -0000 --1RkCiX/UEfbG28Bk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Quoting the original request to remove this, which I tend to agree: -------------------------- begin quoted text --------------------------- The svn commit mail script uses some form of 'diff -p' (or 'svn diff -x-p') to include function names at the top of each hunk. The problem is that diff gets it wrong more often than not, especially (but not only) when functions are added or renamed, or outside a funciton, or in headers, or in code that makes heavy use of macros, or in files that aren't C-like source code: shell scripts, man pages, Makefiles... All it really does is clutter up the patch and mislead the reader. --------------------------- end quoted text ---------------------------- Glen On Sat, Aug 13, 2016 at 09:39:14PM -0700, Conrad Meyer wrote: > Wait, what? Why not? This option provides useful context for > reviewing changes. >=20 > Best, > Conrad >=20 > On Sat, Aug 13, 2016 at 9:35 PM, Glen Barber wrote: > > Author: gjb > > Date: Sun Aug 14 04:35:04 2016 > > New Revision: 304070 > > URL: https://svnweb.freebsd.org/changeset/base/304070 > > > > Log: > > Do not include C function changes by default in svn commit > > email. > > > > No objection: svnadmin > > Submitted by: des > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > svnadmin/conf/mailer.conf > > > > Modified: svnadmin/conf/mailer.conf > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- svnadmin/conf/mailer.conf Sun Aug 14 04:11:36 2016 (r30406= 9) > > +++ svnadmin/conf/mailer.conf Sun Aug 14 04:35:04 2016 (r30407= 0) > > @@ -143,7 +143,7 @@ > > # This is not passed to the shell, so do not use shell metacharacters. > > # The command is split around whitespace, so if you want to include > > # whitespace in the command, then ### something ###. > > -diff =3D /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s = %(to)s > > +diff =3D /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %= (to)s > > > > # The default prefix for the Subject: header for commits. > > commit_subject_prefix =3D svn commit: > > >=20 --1RkCiX/UEfbG28Bk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXr/fbAAoJEAMUWKVHj+KTlKEP/1u+vpJnUQrFYWaIcyOWK2lU BrkyaMFah00I0ih+4rFLPAWfGSEi0Gi8EPGsv4YuTRU+yFwBXhYfnmTDGI9lSeq6 LJr826+3yDhpoJr+Ck58UVS59PhXpHSExZbrGragRg770HsbYLT1b4ufglcqOtSc ExTwBnM3FJNvI5JqtCL7ySV6xMmCHkA24iRDhQpjRv2pKGCE2qLDVXd5fBdrGnuz +SYPA0+685CPbB0Akge08bGOBX2EfcW8UC0plAhc5UB/e4LO04rXtCL7Dvzby41I YuhrUg3DZc1SBpiYzhePuSF/txfmYD+9C7wQtHFVhzzfrtFl8MHEPYVaoLSYXuvl Tf/vVQldXCTOcAw+h2VLhi6S+4ZF738z2yofZ0woEZcW+Bvr0nQL06uLOGaXS6DU 5iqy74bTtyiCIb48BVtZCfSI635hg4oLEXorHPDj72iHgQP5rC5Jpo9AgWqJ01vz CxzMiNeAoXUhh+1tCPtulplaIicy6mOZJ85kRvD08SclnMU7TpNue0OjJjzur6Ht 2Xt1nuQhhhy/+6dsiwS4145yE1HPN8IVt+pDp8m12Z9KcHSW1+HZpJ9KKfBKKLsW obBDOq7Zj0GsTZrFDRcobfyTalo+sNKZgPbUcCzefem2OcNmdYXYdgSPN12gejGh NiAqNaZOQ4PItXTf0FAa =xHml -----END PGP SIGNATURE----- --1RkCiX/UEfbG28Bk-- From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 05:48:39 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A253CBB9453 for ; Sun, 14 Aug 2016 05:48:39 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 756DE15DB for ; Sun, 14 Aug 2016 05:48:39 +0000 (UTC) (envelope-from juli@clockworksquid.com) Received: by mail-qk0-x235.google.com with SMTP id l2so20528806qkf.3 for ; Sat, 13 Aug 2016 22:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=clockworksquid.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Moy1h3uh+zEiyxmzGsPaFIHn0ohNu09AMyAIUGBwj88=; b=d1TH0OICkq/bCc/4IIBXgQHWRgBhsaraY/taxfhduJDRdSGNupZ6iBlGzP1Mvgi8uf WjFQ0PF6dL9fE1GL8ruILmNLjTzJ0b9sKZNz8wsDxYUBf6OddSuegbfkKZjYj6b4jmyF 2eDQAXvjZ8SNPz59sEg5i0MGqZWp/IwnSjLSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Moy1h3uh+zEiyxmzGsPaFIHn0ohNu09AMyAIUGBwj88=; b=Mmk/LF3InzslsFGNFLXurn58QjeoNx/Ed+bCzVrKKdpTEwjAJTXMpQhM3ODHhqQ4eb hn3WQ5AgO44Era1HkcjRrTHsVltE43AhkZyuUNtwnS+FGx69SjfSbmW6Ym3ltwdduVqT /VXheXg1HVyNWM4AKz74CdWRqgSx0SrR7GSFG6sVONS5+tcRvpINsJX4/NiZ32cXODjb 4Dlcr1LjwN8BshqqH4qN9DggFATVusfkniLYy9AZhiAx8yFnBfikptExsvtUVBpnkW++ gbyPyCLKd16X7tgRG2G8AmYkf/4hmAthLuPGf1O+5bgNzT+1HbOv8snOw/HHfp77Ejno dWJg== X-Gm-Message-State: AEkoouvMssq30h9vbXl+cK1eVFp1yLMEHgvLGceIkjr9UFSw9V941Fe8BVdYoA96dD+PWRho2kAC6IUcB1a5+Q== X-Received: by 10.55.5.17 with SMTP id 17mr25420905qkf.280.1471153718522; Sat, 13 Aug 2016 22:48:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.56.105 with HTTP; Sat, 13 Aug 2016 22:48:18 -0700 (PDT) In-Reply-To: <20160814044723.GF11079@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> From: Juli Mallett Date: Sat, 13 Aug 2016 22:48:18 -0700 Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf To: Glen Barber Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 05:48:39 -0000 On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > Quoting the original request to remove this, which I tend to agree: > > -------------------------- begin quoted text --------------------------- > The svn commit mail script uses some form of 'diff -p' (or 'svn diff > -x-p') to include function names at the top of each hunk. The problem > is that diff gets it wrong more often than not, especially (but not > only) when functions are added or renamed, or outside a funciton, or in > headers, or in code that makes heavy use of macros, or in files that > aren't C-like source code: shell scripts, man pages, Makefiles... All > it really does is clutter up the patch and mislead the reader. > --------------------------- end quoted text ---------------------------- :( I'm deeply skeptical that the described conditions add up to "more often than not," and that tangible harm is done in those cases, outweighing benefit added in the other, ostensibly rarer, case (changes in ordinary C source files, which are actually fairly abundant in FreeBSD.) Juli. From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 05:52:02 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32830BB95F2; Sun, 14 Aug 2016 05:52:02 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f178.google.com (mail-io0-f178.google.com [209.85.223.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 04BF2195A; Sun, 14 Aug 2016 05:52:01 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f178.google.com with SMTP id 38so57651313iol.0; Sat, 13 Aug 2016 22:52:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=ZXGSn10+pCzoSv4vmJZ5WZaFTrNb1FE/od16kTktGCQ=; b=O5/W+UEQd0HqOik2hqOiBb1j1SGEI9Rc4fEzQG9f4JjEkdXSNcQ0+taHNs4XA6pD+h ZZNJkWWRiSIckUE88NZjLe5yYAjg/rTLNXWVmBWc22WN8Vg9ZxWyOdUbMPRQY6NmeUvp QzISdLKChXcS03mSiDnvs5/lS5KvgrU9HR2CL/Ipfw4ya3CRSNBAhf/rklKjlHBTCLHl omyF14pD8CnVUIMUzHjG6xvGWkUvEUkJ/OIsSa5ENymR41Zjo5tS014tXLFwysIvVGBH 4FLcVvQPxQhd7HbVAtLUwctBtbZnbQ5RvwPw8p2G1Dzl7avppaxAn0HuX3SicbMSxsVa eBGQ== X-Gm-Message-State: AEkoout/DPZxuYeYksCWntvAPQ6M/VgfMArDQmE7tVStgq3fYpAFDeDUVye5IK77swgwRg== X-Received: by 10.107.195.14 with SMTP id t14mr29928472iof.175.1471153920495; Sat, 13 Aug 2016 22:52:00 -0700 (PDT) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com. [209.85.214.41]) by smtp.gmail.com with ESMTPSA id h67sm7110878ioe.40.2016.08.13.22.52.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 13 Aug 2016 22:52:00 -0700 (PDT) Received: by mail-it0-f41.google.com with SMTP id c13so6100407ith.1; Sat, 13 Aug 2016 22:52:00 -0700 (PDT) X-Received: by 10.36.227.130 with SMTP id d124mr6798285ith.97.1471153919950; Sat, 13 Aug 2016 22:51:59 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.36.220.129 with HTTP; Sat, 13 Aug 2016 22:51:59 -0700 (PDT) In-Reply-To: References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> From: Conrad Meyer Date: Sat, 13 Aug 2016 22:51:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf To: Juli Mallett Cc: Glen Barber , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 05:52:02 -0000 On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett wrote: > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: >> Quoting the original request to remove this, which I tend to agree: >> >> -------------------------- begin quoted text --------------------------- >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff >> -x-p') to include function names at the top of each hunk. The problem >> is that diff gets it wrong more often than not, especially (but not >> only) when functions are added or renamed, or outside a funciton, or in >> headers, or in code that makes heavy use of macros, or in files that >> aren't C-like source code: shell scripts, man pages, Makefiles... All >> it really does is clutter up the patch and mislead the reader. >> --------------------------- end quoted text ---------------------------- > > :( > > I'm deeply skeptical that the described conditions add up to "more > often than not," and that tangible harm is done in those cases, > outweighing benefit added in the other, ostensibly rarer, case > (changes in ordinary C source files, which are actually fairly > abundant in FreeBSD.) Exactly. Yes, it gets it wrong sometimes. But not enough to make it more harmful than beneficial. Best, Conrad From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 06:06:11 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3781FBB9AC4; Sun, 14 Aug 2016 06:06:11 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 00A331FAB; Sun, 14 Aug 2016 06:06:10 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7E66AlE055955; Sun, 14 Aug 2016 06:06:10 GMT (envelope-from gjb@FreeBSD.org) Received: (from gjb@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7E66Ah5055954; Sun, 14 Aug 2016 06:06:10 GMT (envelope-from gjb@FreeBSD.org) Message-Id: <201608140606.u7E66Ah5055954@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: gjb set sender to gjb@FreeBSD.org using -f From: Glen Barber Date: Sun, 14 Aug 2016 06:06:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: svn commit: r304073 - svnadmin/conf X-SVN-Group: svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 06:06:11 -0000 Author: gjb Date: Sun Aug 14 06:06:09 2016 New Revision: 304073 URL: https://svnweb.freebsd.org/changeset/base/304073 Log: Revert r304070. I have more important things to deal with than bikesheds. With hat: svnadm Modified: svnadmin/conf/mailer.conf Modified: svnadmin/conf/mailer.conf ============================================================================== --- svnadmin/conf/mailer.conf Sun Aug 14 05:18:38 2016 (r304072) +++ svnadmin/conf/mailer.conf Sun Aug 14 06:06:09 2016 (r304073) @@ -143,7 +143,7 @@ mail_command = /usr/sbin/sendmail # This is not passed to the shell, so do not use shell metacharacters. # The command is split around whitespace, so if you want to include # whitespace in the command, then ### something ###. -diff = /usr/bin/diff -u -L %(label_from)s -L %(label_to)s %(from)s %(to)s +diff = /usr/bin/diff -up -L %(label_from)s -L %(label_to)s %(from)s %(to)s # The default prefix for the Subject: header for commits. commit_subject_prefix = svn commit: From owner-svn-src-svnadmin@freebsd.org Sun Aug 14 06:06:42 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B881BB9B06; Sun, 14 Aug 2016 06:06:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 095D1125E; Sun, 14 Aug 2016 06:06:42 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id 9609B1C50; Sun, 14 Aug 2016 06:06:41 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Sun, 14 Aug 2016 06:06:39 +0000 From: Glen Barber To: Conrad Meyer Cc: Juli Mallett , src-committers , svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org, svnadm@freebsd.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160814060639.GG11079@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <20160814044723.GF11079@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GN/IAAAoV4GJoJGS" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Aug 2016 06:06:42 -0000 --GN/IAAAoV4GJoJGS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 13, 2016 at 10:51:59PM -0700, Conrad Meyer wrote: > On Sat, Aug 13, 2016 at 10:48 PM, Juli Mallett = wrote: > > On Sat, Aug 13, 2016 at 9:47 PM, Glen Barber wrote: > >> Quoting the original request to remove this, which I tend to agree: > >> > >> -------------------------- begin quoted text -------------------------= -- > >> The svn commit mail script uses some form of 'diff -p' (or 'svn diff > >> -x-p') to include function names at the top of each hunk. The problem > >> is that diff gets it wrong more often than not, especially (but not > >> only) when functions are added or renamed, or outside a funciton, or = in > >> headers, or in code that makes heavy use of macros, or in files that > >> aren't C-like source code: shell scripts, man pages, Makefiles... All > >> it really does is clutter up the patch and mislead the reader. > >> --------------------------- end quoted text --------------------------= -- > > > > :( > > > > I'm deeply skeptical that the described conditions add up to "more > > often than not," and that tangible harm is done in those cases, > > outweighing benefit added in the other, ostensibly rarer, case > > (changes in ordinary C source files, which are actually fairly > > abundant in FreeBSD.) >=20 > Exactly. Yes, it gets it wrong sometimes. But not enough to make it > more harmful than beneficial. >=20 Reverted. I won't deal with this topic further. Glen --GN/IAAAoV4GJoJGS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXsApvAAoJEAMUWKVHj+KTGHwP/14XNX/9qwt5ZV6YRJA3JywA DvztMwltIvKI7G3ki5ZEwouOR40e+Mq57cAfVVlQVCY56wckflQoOdIyWi+KW26W b2WxQ5ZZApZYSRw2KPYJcL9i7fxih5sbE+pfJq77WOj9Uze7jQ1CblLHavFwTjee VGe+ePH5uGNUY0KBfgmR0SHgrGWWzS8SHB2GIZzG9CPnqGLkfaSdeMlBMcw9CBc1 1asX+1HkiN4B0oogCnYQSWcLsNCl5BhDhG3gtZxSfssxJZnh4qxND9x29wKKaZsz NiUYylpYWFJ3Ub39Aq4SB7tYmx4uLGI3gctyolp3tkAhcT3MVNgBFX/5uF1rSjaF QTBKqOQNTr5/nhWtCD3SQ07cm7SEnhK2ig87WL+V+vUr0xtbIVcGrYVObFWTKM/N ruGXidTO2rywkWxUqTdn5tiREe3bTAGHKhrkXSGSywhzo1p6fEMThLpf6Ytce+Pe 9x5JqIQERvNClisQjSyBRkxk0H1V5WXFKtdxu/jPHWlzT0TEPNLCvpv+Temhgtmi Yc1EbqdbRvynwfq2FIOKsr+cEx2DjgrCYRiL24p7JnQnOmNb6qVyI8Zy9HyGs2zg oLscvU+oWqUMQSWzkZmo4I3i8wqC4dQZssyDX4Vj8EUkqkqSbdf0/oRcrPYXeCgc sqDvZuU5pL3zjWKBr9kq =ah93 -----END PGP SIGNATURE----- --GN/IAAAoV4GJoJGS-- From owner-svn-src-svnadmin@freebsd.org Tue Aug 16 08:00:44 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 458FDBBB59C; Tue, 16 Aug 2016 08:00:44 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1C22118C9; Tue, 16 Aug 2016 08:00:43 +0000 (UTC) (envelope-from bms@fastmail.net) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id A1CA3206F8; Tue, 16 Aug 2016 04:00:42 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Tue, 16 Aug 2016 04:00:42 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=fastmail.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=MIKhY3/2dP/h9R924J18/ZXRcpY=; b=CRcquC UGw/UagHMtBnH2GwEk5Uegoi6FXVrRAmG485xxFhJ35CLB2HgtC5cZy8A5o4JzmP NVHAJ3s/nUYDUGzTArkCBq/JRIMBpOkzTpTKhcYD0qZV0yuaJsBJibf2/fbUOzka IN9zhDoaoW6jJNvnP5s6OAmULxpAzitigbW88= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=MIKhY3/2dP/h9R9 24J18/ZXRcpY=; b=FEjEes/CiW+3yUuXz+N33Faqytrgmb85cLdom5XZoSgGp8N Ajs/ztfsuFBvp+K4cWWyyVvjIVkMZJNv79yuDLihH9qESaASzlJOBVmId+TVwEnc rDm2hc1bHTiMiVLg6/+QZ3RRnPspeJtjlv1d2MEl58RXIyFeEcncS4I5JwXQ= X-Sasl-enc: o9ejMMoyGaWST5bEOP0cBm2xQhPRO1iq0T3xAi5EAmrG 1471334442 Received: from pion.local (global-5-182.nat-2.net.cam.ac.uk [131.111.5.182]) by mail.messagingengine.com (Postfix) with ESMTPA id E14ABCCE69; Tue, 16 Aug 2016 04:00:41 -0400 (EDT) Subject: Re: svn commit: r304070 - svnadmin/conf To: Glen Barber , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> From: Bruce Simpson Message-ID: <5a2ebac7-1909-75c2-2c10-502c735df1be@fastmail.net> Date: Tue, 16 Aug 2016 09:00:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 08:00:44 -0000 On 14/08/16 05:35, Glen Barber wrote: > Author: gjb > Date: Sun Aug 14 04:35:04 2016 > New Revision: 304070 > URL: https://svnweb.freebsd.org/changeset/base/304070 > > Log: > Do not include C function changes by default in svn commit > email. Please back out -- this makes the diff output much less useful. From owner-svn-src-svnadmin@freebsd.org Tue Aug 16 08:14:53 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C07ECBBB951; Tue, 16 Aug 2016 08:14:53 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id B11461199; Tue, 16 Aug 2016 08:14:53 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from FreeBSD.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by freefall.freebsd.org (Postfix) with ESMTP id AF4CD11E6; Tue, 16 Aug 2016 08:14:52 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Date: Tue, 16 Aug 2016 08:14:51 +0000 From: Glen Barber To: Bruce Simpson Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Subject: Re: svn commit: r304070 - svnadmin/conf Message-ID: <20160816081451.GB46720@FreeBSD.org> References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <5a2ebac7-1909-75c2-2c10-502c735df1be@fastmail.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bn2rw/3z4jIqBvZU" Content-Disposition: inline In-Reply-To: <5a2ebac7-1909-75c2-2c10-502c735df1be@fastmail.net> X-Operating-System: FreeBSD 11.0-CURRENT amd64 X-SCUD-Definition: Sudden Completely Unexpected Dataloss X-SULE-Definition: Sudden Unexpected Learning Event X-PEKBAC-Definition: Problem Exists, Keyboard Between Admin/Computer User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 08:14:53 -0000 --Bn2rw/3z4jIqBvZU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 16, 2016 at 09:00:34AM +0100, Bruce Simpson wrote: > On 14/08/16 05:35, Glen Barber wrote: > >Author: gjb > >Date: Sun Aug 14 04:35:04 2016 > >New Revision: 304070 > >URL: https://svnweb.freebsd.org/changeset/base/304070 > > > >Log: > > Do not include C function changes by default in svn commit > > email. >=20 > Please back out -- this makes the diff output much less useful. >=20 https://svnweb.freebsd.org/changeset/base/304073 Glen --Bn2rw/3z4jIqBvZU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXsst2AAoJEAMUWKVHj+KTg/wP/2o1TWukuOWzjLYTjPCInZqb LtRUYzmOl5TdOfVbWzamHwjr4cG6L0MhwJiTzSA39rEAUuYL/AfSI4o35yN0U30E FpEQjG7M2okoh1rcoT6/LjiUZKREYxZ2sw7zpWrAF01TKBcDuQooJQzUU3bexwwS HnTkFGzxQ7nvD+8zN5ksihN3ywRxgv45ynGxzkAP/6c3boZCThvA3EQc/eaWxx3l tFeUVR4Ni1hGIWUP03DckU9Py01ElIlbF54RszZb7sEiI/D+rQNO32o/+UmbAElx 22zBPmWvhjp2e2L//nz+8XYr5LhT1unyuOgUm1vGOPB6hoZ1yP7GX3HyWJgzT/pF 0ce3FvRBeVE0bSSjk+qlPGg/TE/3WSTdYdk2aTwFYS9wuu82WB8thRIHN8LOfVd4 I4zQrylJhRoky1wMKVwURXeY5tampEpi+3AwScHFaJiPbVzLPBhWThbREClJa2gS /X2PAiq8IBrCzaiGpZqdLvBttMKHuwLX0dg/GWdKBeNGA6Gr5ejom+v44iHhAVLZ xKsQ3tkaRu3814AXNiMMVvsid5PDvkVEaalt7WVfgHZW9K2zxmdIWPOtm96UgnhM 7QgGCuSOGWQugZCglo+a2O+9BQ4VhCER/JdxySUEzCs4g/xvxPXOihmSx/LNncWR 2xj+JBYnf3OoZ0WfZqTy =ajDU -----END PGP SIGNATURE----- --Bn2rw/3z4jIqBvZU-- From owner-svn-src-svnadmin@freebsd.org Tue Aug 16 13:51:39 2016 Return-Path: Delivered-To: svn-src-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E942CBBBD55; Tue, 16 Aug 2016 13:51:39 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id CFAF6197C; Tue, 16 Aug 2016 13:51:39 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id C66C01233; Tue, 16 Aug 2016 13:51:39 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 5882C1AA1E; Tue, 16 Aug 2016 13:51:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id P_7qDseGQTlN; Tue, 16 Aug 2016 13:51:36 +0000 (UTC) Subject: Re: svn commit: r304070 - svnadmin/conf DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 010561AA14 To: Glen Barber , Bruce Simpson References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <5a2ebac7-1909-75c2-2c10-502c735df1be@fastmail.net> <20160816081451.GB46720@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Tue, 16 Aug 2016 14:51:31 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160816081451.GB46720@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AgPGab3k8gT3FpO94sPnGNEFf8oTgvtwh" X-BeenThere: svn-src-svnadmin@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the admin / configuration tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2016 13:51:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AgPGab3k8gT3FpO94sPnGNEFf8oTgvtwh Content-Type: multipart/mixed; boundary="cNjnQQondc6kX1BLnTCUrsX6NNmiBiaOd" From: Bryan Drewery To: Glen Barber , Bruce Simpson Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-svnadmin@freebsd.org Message-ID: Subject: Re: svn commit: r304070 - svnadmin/conf References: <201608140435.u7E4Z4Fm022554@repo.freebsd.org> <5a2ebac7-1909-75c2-2c10-502c735df1be@fastmail.net> <20160816081451.GB46720@FreeBSD.org> In-Reply-To: <20160816081451.GB46720@FreeBSD.org> --cNjnQQondc6kX1BLnTCUrsX6NNmiBiaOd Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/16/16 9:14 AM, Glen Barber wrote: > On Tue, Aug 16, 2016 at 09:00:34AM +0100, Bruce Simpson wrote: >> On 14/08/16 05:35, Glen Barber wrote: >>> Author: gjb >>> Date: Sun Aug 14 04:35:04 2016 >>> New Revision: 304070 >>> URL: https://svnweb.freebsd.org/changeset/base/304070 >>> >>> Log: >>> Do not include C function changes by default in svn commit >>> email. >> >> Please back out -- this makes the diff output much less useful. >> >=20 > https://svnweb.freebsd.org/changeset/base/304073 >=20 Thank you. This is incredibly useful, despite being wrong sometimes. We've recently made ports use this by default for 'make makepatch'. --=20 Regards, Bryan Drewery --cNjnQQondc6kX1BLnTCUrsX6NNmiBiaOd-- --AgPGab3k8gT3FpO94sPnGNEFf8oTgvtwh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXsxpkAAoJEDXXcbtuRpfPtiYH/00bdJ6YSUbP0JyNg8Mu46J3 fBXMicsojUpBp+qRfTB+1X/amdodR2558erSp9iNsT6JPiEM0CYTVTPFc+N1mYDK jggHdYmbHrpeOOUDtRAswUO/AtBYykZ7Ebr1oLNefoSmrKsWv4k0MKGMMASmc3Lx 0JNKYUJRhu8i1ThuaTi01nb1J+zEu2Me5myIaTlwpakDsKUfqEf0tEURyBBJ5SxX pGApQEWxIY2kHlAk1n0XTK3YdFarwla8QUE2ZK7FD21OIYhQkEcegaW0cmGQUrYj XYw2hDGXvtrU6bQ71j4dLkGZhwG1s72AsE5T8f+vObk3l2l4FvTr+ULax97JzfY= =5T70 -----END PGP SIGNATURE----- --AgPGab3k8gT3FpO94sPnGNEFf8oTgvtwh--