From owner-freebsd-drivers@freebsd.org Mon Mar 6 02:04:36 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F476CF9356; Mon, 6 Mar 2017 02:04:36 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1622B13B0; Mon, 6 Mar 2017 02:04:36 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-lf0-x243.google.com with SMTP id r36so11841439lfi.0; Sun, 05 Mar 2017 18:04:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:subject:message-id:mime-version :content-transfer-encoding; bh=GKSfGgQELCSXXlBDzNPpVmHKV6xKu25oExl3UY7c0Q4=; b=VYyzgKi7v8jKpByEGeMECIdaEjuxUFkyNon0xqSufmkh3jkFDGEugLsY0zWNafKzOO oHy7BjSMuX7OWgOd2OaR6qQ19AetkBfvIickCUh5jnxdWgLjqCiXBhbgSuqCikonEyW1 SWUmpDj626AVDdxBzxlNqxj1BZOHaW5O4nwdO9WmM6l8Fmh5Wp5tXdy6QR5WVSxYPibF WwvpsawulVuuVP3FIIA0qsAv4FdRPBABSNlDlAhabyecoqoIgARg8H80awnbCGWadZmw xugCGmqrzb2Sk02KFV4HeXdlnFizgiOUAQpcKWtan4FXZ8XnDZxaq2QpOAdb5D0jvP+9 f/tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:subject:message-id:mime-version :content-transfer-encoding; bh=GKSfGgQELCSXXlBDzNPpVmHKV6xKu25oExl3UY7c0Q4=; b=f2P9csya9dFQm7AihTJssgIR2ce0J6CpJlgpiIpDysdxnhSeB36VThu45HOOi9GslZ q2Dyt9hiAs1eOwkPBomzTMrD2fByAaYbnNr6f8jYcqMEQnUkmMxjR4kwGv0M7lwkU3fX I1QEne2ULXXix+1XP8FoKU1ZGTg/tCkB4jz9wIwacyzn4nvLQtw6w7AVSMOD6B/b6FlL iMeJ2hbsPUgH5SnZBuuNbj82jMsH7MGklXTzJBrRj5uCGcxVP66rKiJCkBr4EGXHWkyI +QD0ZJ9S99C6dnw9j6Yf/NMq2kBbtBVcY1RCnQlf4FztcuBmhskHuNyeW6fgb/Osgej/ a/Tg== X-Gm-Message-State: AMke39lHlwHnsBiOSvfHFvQh2F/7ZZod++TZEdDCVje/IHxk3gkcbGP0Bnow0E9DmmbZaQ== X-Received: by 10.46.80.16 with SMTP id e16mr4515394ljb.33.1488765873884; Sun, 05 Mar 2017 18:04:33 -0800 (PST) Received: from rimwks ([2001:470:28:81a:6ef0:49ff:fe75:38e3]) by smtp.gmail.com with ESMTPSA id l2sm478393lfe.69.2017.03.05.18.04.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Mar 2017 18:04:33 -0800 (PST) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Mon, 6 Mar 2017 05:04:31 +0300 To: freebsd-current@freebsd.org, freebsd-drivers@freebsd.org, Rozhuk Ivan Subject: AMD CPU/APU temperature driver Message-ID: <20170306050431.6fff2cbe@rimwks> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 02:04:36 -0000 Hi! New amdtemp driver needs more testers! https://reviews.freebsd.org/D9759 Fast buld/install: ...download and apply patch... kldunload amdtemp cd /usr/src/sys/modules/amdtemp/ make make install make cleandir kldload amdtemp rus/eng: http://netlab.dhis.org/wiki/ru:software:freebsd:amdtemp Read methods: - D18F3xE4 Thermtrip Status Register (TTS) - D18F3x64 Hardware Thermal Control (HTC) - tunables only, no temperature - D18F3xA4 Reported Temperature Control Register (RTC) - SB-TSI - Temperature Sensor Interface via CPU registers (TSI) - TSI via SMBus - not supported yet Tunables: D18F3xE4 Thermtrip Status Register - TjOffset (RD) - This field is the offset from CurTmp used to normalize to Tcontrol. - DiodeOffset (RD) - Thermal diode offset is used to correct the measurement made by an external temperature sensor. - ThermtpEn (RD) - The THERMTRIP state is supported by the processor. - Thermtrip (RD) - The processor has entered the THERMTRIP state. D18F3x64 Hardware Thermal Control (HTC) - HtcTmpLmt (RD, Kelvin) - HTC temperature limit - HtcHystLmt (RW, Kelvin) - HTC hysteresis. The processor exits the HTC active state when the temperature selected by HtcSlewSel is less than the HTC temperature limit (HtcTmpLmt) minus the HTC hysteresis (HtcHystLmt). - HtcEn (RW) - HTC is enabled; the processor is capable of entering the HTC-active state. - HtcLock (RW) - HtcPstateLimit, HtcHystLmt, HtcTmpLmt, and HtcEn are read-only. - HtcSlewSel (RW) - HTC slew-controlled temperature select. - HtcPstateLimit (RW) - HTC P-state limit select. - HtcAct (RW) - The processor is currently in the HTC-active state. - HtcActSts (RW) - set-by-hardware; write-1-to-clear. Reset: 0. This bit is set by hardware when the processor enters the HTC-active state. It is cleared by writing a 1 to it. - PslApicHiEn (RW) - P-state limit higher value change APIC interrupt enable. - PslApicLoEn (RW) - P-state limit lower value change APIC interrupt enable. D18F3xA4 Reported Temperature Control Register - CurTmp (RD, Kelvin) - Provides the current control temperature, Tctl, after the slew-rate controls have been applied. - CurTmpTjSel (RW, Kelvin) - Specifies a value used to create Tctl. - TmpSlewDnEn (RW) - Temperature slew downward enable. - TmpMaxDiffUp (RW) - Specifies the maximum difference, (Tctlm - Tctl), when Tctl immediatly updates to Tctlm. - PerStepTimeDn (RW) - Specifies the time that Tctlm must remain below Tctl before applying a 0.125 downward step. - PerStepTimeUp (RW) - Specifies the time that Tctlm must remain above Tctl before applying a 0.125 upward step. SB-TSI registers - cpu_temperature (RD, Kelvin) - CPU Temperature - high_temperature_threshold (RD, Kelvin) - High Temperature Threshold - low_temperature_threshold (RD, Kelvin) - Low Temperature Threshold - cpu_temperature_offset_hi (RW) - CPU Temperature Offset High Byte - cpu_temperature_offset_lo (RW) - CPU Temperature Offset Low Byte - status (RW) - SB-TSI Status - cfg3 (RW) - SB-TSI Configuration Register 0x03 - cfg9 (RW) - SB-TSI Configuration Register 0x09 - upd_rate (RW) - Update Rate - timeout_cfg (RW) - Timeout Configuration - alert_threshold (RW) - Alert Threshold - alert_cfg (RW) - Alert Configuration - manufacture_id (RD) - Manufacture ID - revision (RD) - SB-TSI Revision From owner-freebsd-drivers@freebsd.org Mon Mar 6 09:04:39 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA051CFB882; Mon, 6 Mar 2017 09:04:39 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from ms-10.1blu.de (ms-10.1blu.de [178.254.4.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 803A016BF; Mon, 6 Mar 2017 09:04:39 +0000 (UTC) (envelope-from guru@unixarea.de) Received: from [88.217.109.93] (helo=localhost.unixarea.de) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1ckoZB-0005iE-Kg; Mon, 06 Mar 2017 10:04:29 +0100 Received: from localhost.my.domain (c720-r292778-amd64 [127.0.0.1]) by localhost.unixarea.de (8.15.2/8.14.9) with ESMTPS id v26948Bm001997 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 6 Mar 2017 10:04:10 +0100 (CET) (envelope-from guru@unixarea.de) Received: (from guru@localhost) by localhost.my.domain (8.15.2/8.14.9/Submit) id v26946J8001996; Mon, 6 Mar 2017 10:04:06 +0100 (CET) (envelope-from guru@unixarea.de) X-Authentication-Warning: localhost.my.domain: guru set sender to guru@unixarea.de using -f Date: Mon, 6 Mar 2017 10:04:06 +0100 From: Matthias Apitz To: Rozhuk Ivan Cc: freebsd-current@freebsd.org, freebsd-drivers@freebsd.org Subject: Re: AMD CPU/APU temperature driver Message-ID: <20170306090406.GA1869@c720-r292778-amd64> Reply-To: Matthias Apitz Mail-Followup-To: Matthias Apitz , Rozhuk Ivan , freebsd-current@freebsd.org, freebsd-drivers@freebsd.org References: <20170306050431.6fff2cbe@rimwks> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170306050431.6fff2cbe@rimwks> X-Operating-System: FreeBSD 11.0-CURRENT r292778 (amd64) User-Agent: Mutt/1.5.24 (2015-08-30) X-Con-Id: 51246 X-Con-U: 0-guru X-Originating-IP: 88.217.109.93 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 09:04:39 -0000 El día Monday, March 06, 2017 a las 05:04:31AM +0300, Rozhuk Ivan escribió: > Hi! > > > New amdtemp driver needs more testers! > > > https://reviews.freebsd.org/D9759 > > Fast buld/install: > ...download and apply patch... > kldunload amdtemp > cd /usr/src/sys/modules/amdtemp/ > make > make install > make cleandir > kldload amdtemp > > > rus/eng: http://netlab.dhis.org/wiki/ru:software:freebsd:amdtemp Hi, The English version of the Wiki gives only: This topic does not exist yet. Is there an English version? Thanks matthias -- Matthias Apitz, ✉ guru@unixarea.de, ⌂ http://www.unixarea.de/ ☎ +49-176-38902045 Aus "Nie wieder Krieg!" wurde "Nie wieder Krieg ohne Deutschlands Truppen" The "No wars anymore!" changed now to "No wars anymore without German battle groups!" El "¡Nunca jamás guerra!" ha cambiado a "¡Nunca jamás guerra sin tropas alemanas!" From owner-freebsd-drivers@freebsd.org Mon Mar 6 12:31:43 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DD02CFAB18 for ; Mon, 6 Mar 2017 12:31:43 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from smtp.smtpout.orange.fr (smtp06.smtpout.orange.fr [80.12.242.128]) by mx1.freebsd.org (Postfix) with ESMTP id B7F2C1397 for ; Mon, 6 Mar 2017 12:31:41 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from mail-yw0-f177.google.com ([209.85.161.177]) by mwinf5d29 with ME id scQ11u00F3pwwoH03cQ1pD; Mon, 06 Mar 2017 13:24:02 +0100 X-ME-Helo: mail-yw0-f177.google.com X-ME-Auth: Y29jaGFyZC1sYWJiZS5vbGl2aWVyQG9yYW5nZS5mcg== X-ME-Date: Mon, 06 Mar 2017 13:24:02 +0100 X-ME-IP: 209.85.161.177 Received: by mail-yw0-f177.google.com with SMTP id p77so117758613ywg.1; Mon, 06 Mar 2017 04:24:01 -0800 (PST) X-Gm-Message-State: AMke39nZqHFYNMdPIlKVlwpnRvbL7khjc7l0yV3c6u6x6XXqpCkI7SARzEjHGxM8ynbyN00ZyS7GoEDVFDayXQ== X-Received: by 10.129.107.137 with SMTP id g131mr12500770ywc.2.1488803040824; Mon, 06 Mar 2017 04:24:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.178.4 with HTTP; Mon, 6 Mar 2017 04:23:40 -0800 (PST) In-Reply-To: <20170306050431.6fff2cbe@rimwks> References: <20170306050431.6fff2cbe@rimwks> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Mon, 6 Mar 2017 13:23:40 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: AMD CPU/APU temperature driver To: Rozhuk Ivan Cc: "freebsd-current@freebsd.org" , freebsd-drivers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 12:31:43 -0000 On Mon, Mar 6, 2017 at 3:04 AM, Rozhuk Ivan wrote: > Hi! > > > New amdtemp driver needs more testers! > > > https://reviews.freebsd.org/D9759 > > =E2=80=8B This patch apply correctly (on 12-head r314770), but a "make buildkernel" failed with =E2=80=8B--- all_subdir_amdtemp --- /usr/src/sys/modules/amdtemp/../../dev/amdtemp/amdtemp.c:1083:54: error: too few arguments to function call, expected 11, have 10 regs[i].oid_handler, regs[i].fmt, regs[i].descr); ^ /usr/src/sys/sys/sysctl.h:1017:1: note: 'sysctl_add_oid' declared here struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, ^ /usr/src/sys/modules/amdtemp/../../dev/amdtemp/amdtemp.c:1099:54: error: too few arguments to function call, expected 11, have 10 regs[i].oid_handler, regs[i].fmt, regs[i].descr); ^ /usr/src/sys/sys/sysctl.h:1017:1: note: 'sysctl_add_oid' declared here struct sysctl_oid *sysctl_add_oid(struct sysctl_ctx_list *clist, ^ 2 errors generated. *** [amdtemp.o] Error code 1 =E2=80=8B From owner-freebsd-drivers@freebsd.org Mon Mar 6 13:49:16 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0D79CFB2B8; Mon, 6 Mar 2017 13:49:16 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AA97175A; Mon, 6 Mar 2017 13:49:16 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id kt0icMbkvC3JIkt0jcSsSv; Mon, 06 Mar 2017 06:49:14 -0700 X-Authority-Analysis: v=2.2 cv=XbT59Mx5 c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=8nJEP1OIZ-IA:10 a=6Iz7jQTuP9IA:10 a=6I5d2MoRAAAA:8 a=KX5F_3eTAAAA:8 a=YxBL1-UpAAAA:8 a=1xDYi0WicIQ_NOs6B-cA:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=LwAMKloAkmM9fMPfJcdO:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 1B70C4CF; Mon, 6 Mar 2017 05:49:12 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v26DnALl022852; Mon, 6 Mar 2017 05:49:10 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201703061349.v26DnALl022852@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Matthias Apitz , Rozhuk Ivan , freebsd-current@freebsd.org, freebsd-drivers@freebsd.org Subject: Re: AMD CPU/APU temperature driver In-Reply-To: Message from Matthias Apitz of "Mon, 06 Mar 2017 10:04:06 +0100." <20170306090406.GA1869@c720-r292778-amd64> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Mon, 06 Mar 2017 05:49:10 -0800 X-CMAE-Envelope: MS4wfIwxwU1Azb77OfpuZY+0vmvvLikHiqlsjbstyUzuZY/g0n80LpM1TM91m/dIl9Kz59KnQjWEEVzFwSP+qAAywb4QYdkJMTyltChzsW7UP7abJkk8bnHh EBQEYJiVidXpMckm3DjMhcF9h+JLOc60dz8wvsjk6Ugyb/xbVwXrk8RNvzZJsdR7RB5u4tWonjKNcgbbcES95MOb4qKbaIr0K2CQFXngC27+mzeuKven68k6 kzxE2MjYw/BLtClsUOQqO/B3cKSJDlX8KsU/x5rNQZjeUqGbTMuoEs8CHc81fdQC X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 13:49:16 -0000 In message <20170306090406.GA1869@c720-r292778-amd64>, Matthias Apitz writes: > El día Monday, March 06, 2017 a las 05:04:31AM +0300, Rozhuk Ivan escribió: > > > Hi! > > > > > > New amdtemp driver needs more testers! > > > > > > https://reviews.freebsd.org/D9759 > > > > Fast buld/install: > > ...download and apply patch... > > kldunload amdtemp > > cd /usr/src/sys/modules/amdtemp/ > > make > > make install > > make cleandir > > kldload amdtemp > > > > > > rus/eng: http://netlab.dhis.org/wiki/ru:software:freebsd:amdtemp > > Hi, > > The English version of the Wiki gives only: This topic does not exist > yet. Is there an English version? I get the following: This topic does not exist yet You've followed a link to a topic that doesn't exist yet. If permissions allow, you may create it by clicking on \u201cCreate this page\u201d. I have three older AMD X2 boxes in my basement. I could give it a spin when I get a chance. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-freebsd-drivers@freebsd.org Wed Mar 8 06:27:06 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E85BBD0257E; Wed, 8 Mar 2017 06:27:06 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-lf0-x241.google.com (mail-lf0-x241.google.com [IPv6:2a00:1450:4010:c07::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6D2CE158D; Wed, 8 Mar 2017 06:27:06 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-lf0-x241.google.com with SMTP id y193so1660090lfd.1; Tue, 07 Mar 2017 22:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SCIVEcwLWDtuvVSluNzctVEI5vOdRB1TLF90+NGh6j4=; b=DxIlJE2vqCS+SfTnnrx9hAjJ49KnVvEgGZ8zAZN4B57NViumJIRIgFD0uL+mCCxJDq mWIfowuO0OIFoq8TMT7XMtgLoj46e1sROOiZ4tDbB/sp6OWliKwVKXUb2MZxuFwOSn24 Pe7+APPoLsaux/8KN4kU2QQ8B6xtfTON67IiB1w55N5XGgOm3CfFB2dk9/YElu6pvmla 2rBziMsTuWMwz49d7KQHmoYSWOk1+dQ3wmW6ZSoS8pc70X/WXOZpSVIWiF3q2kY4Y2+w vkr4+XoErjoUbfHukUIWHqM74V7h/Pi7Vax8dDIu+jRhffR1ozx8l28x6UJb3O7eqLDP 3O5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SCIVEcwLWDtuvVSluNzctVEI5vOdRB1TLF90+NGh6j4=; b=G8VlCOKrxvefkk0Qg3W+IjWR7nXjLPANZAPiYeyihPfXJE3dUS/0ivb1nifvzr++yp d9V2m/eMPb4iO04kGZ6elNo1mTSi6WGGBQlHiVPPw99qXccV24Nv783GbRm21MkEic6x xlRJz48SD4pEjPzSAGbsPwO+W38efoEx25SZWcUm4lFKVfCt/Ee+a3Eqnb+rzYp67cPK SVKGE5piZa3LUZnTpp3bVGJaKgT0I9We8jhG7UMi8sgkUtevLd6inifnOZoxhq9QGaXM 5Z2HhdaovruM0XGvacsgLKTpulwEPebCyKwjOT9FoTNby4PRqCHmiRqiyx4KKUplhhZO GLpg== X-Gm-Message-State: AMke39msIQjx8V2UMPPIru7QUexs3WK4O0SrGNaKOibYwqSucJhlJ8o6oU2ZmmVULxQuzQ== X-Received: by 10.46.71.148 with SMTP id u142mr1433818lja.65.1488954424575; Tue, 07 Mar 2017 22:27:04 -0800 (PST) Received: from rimwks ([2001:470:28:81a:6ef0:49ff:fe75:38e3]) by smtp.gmail.com with ESMTPSA id x64sm423773lfd.15.2017.03.07.22.27.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2017 22:27:03 -0800 (PST) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Wed, 8 Mar 2017 09:27:01 +0300 To: Matthias Apitz Cc: freebsd-current@freebsd.org, freebsd-drivers@freebsd.org Subject: Re: AMD CPU/APU temperature driver Message-ID: <20170308092701.472f2efc@rimwks> In-Reply-To: <20170306090406.GA1869@c720-r292778-amd64> References: <20170306050431.6fff2cbe@rimwks> <20170306090406.GA1869@c720-r292778-amd64> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 06:27:07 -0000 On Mon, 6 Mar 2017 10:04:06 +0100 Matthias Apitz wrote: > > rus/eng: http://netlab.dhis.org/wiki/ru:software:freebsd:amdtemp > > The English version of the Wiki gives only: This topic does not exist > yet. Is there an English version? > Sory, now avaible. From owner-freebsd-drivers@freebsd.org Wed Mar 8 06:29:24 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE7DCD026A7; Wed, 8 Mar 2017 06:29:24 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62B031729; Wed, 8 Mar 2017 06:29:24 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-lf0-x242.google.com with SMTP id r36so1669510lfi.0; Tue, 07 Mar 2017 22:29:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qn8DX8DnRRANVPl0iHRQxqqOJlOslYN7Qv+3Qg/iHa8=; b=ofMIwSrJXW+IbVvQpi/rg9sjvyvB2sHI3T2MZC0P8B6ULObps2i4Obb2uWV+n68SlL YtGEhpdhErI8C53fd740pbDbEe0OkMFwLQq1z74FM/+19lGrn4bbN48MjjFZgvCYXEsJ t3DO9g/Cbp3v/ILfxjQp7E1shUeD2lxbKRJjOC+oL4Wauke5MRiPTr6OD9dq3FTgIaXS 9mE0sdPF1Qk9kJ1TaH1D6v7utz+3EuTTVLaV2m6aa2PgSeBRFK1qxxhaal0RJZ9QI8jv Z4GubY6jfpRPZhSjK0mHhmyEld8pzosc96IEpj7NTEXf7EfurJ6Yyawihvn5WQjweLAB hypQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qn8DX8DnRRANVPl0iHRQxqqOJlOslYN7Qv+3Qg/iHa8=; b=HNcfDaw7Oj5o1OI8MTdB6j1qb+VP91+S0nPrvK8hH5Gi/3dk1iJq48Ni+rSJdn6SaQ 3wuOa7HBpMjfZOJ9eBQ4D1JKSI4UlRhN8rG6ttvlHCmFbrh4k04Vj62KFHGL8sSRb5Pm 0kmj+UbWON0BmqFICaN5+wLaacnXYik5iFDzNkqe+/1Z9H7k7mXNfgpK9htt4W4b0Qqc v+OGa71kwOEQm4l6pEPzmwOKQC0O8FDasKiaMqt61tyz0wNuHAG0Mmid0bIvoyM+yxDo MCgJ33cdE/v6gCerYXpzof0H71Wmp3LGSfyFBAldVenX3rtP0MtnWN1GXeu8wIe7/Ft9 Uhzw== X-Gm-Message-State: AMke39lOuW8uhbZY81+/YLsceBA+a++D8oF89uI7KN75C8gWft5SRZ5YbAq+16I1qwd12A== X-Received: by 10.25.204.9 with SMTP id c9mr1051934lfg.107.1488954562349; Tue, 07 Mar 2017 22:29:22 -0800 (PST) Received: from rimwks ([2001:470:28:81a:6ef0:49ff:fe75:38e3]) by smtp.gmail.com with ESMTPSA id 34sm422122lfv.48.2017.03.07.22.29.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Mar 2017 22:29:21 -0800 (PST) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Wed, 8 Mar 2017 09:29:19 +0300 To: Olivier =?UTF-8?B?Q29jaGFyZC1MYWJiw6k=?= Cc: "freebsd-current@freebsd.org" , freebsd-drivers@freebsd.org Subject: Re: AMD CPU/APU temperature driver Message-ID: <20170308092919.54eb97b5@rimwks> In-Reply-To: References: <20170306050431.6fff2cbe@rimwks> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 06:29:25 -0000 T24gTW9uLCA2IE1hciAyMDE3IDEzOjIzOjQwICswMTAwDQpPbGl2aWVyIENvY2hhcmQtTGFiYsOp IDxvbGl2aWVyQGZyZWVic2Qub3JnPiB3cm90ZToNCg0KPiA+IE5ldyBhbWR0ZW1wIGRyaXZlciBu ZWVkcyBtb3JlIHRlc3RlcnMhDQo+ID4gaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5NzU5 DQo+IOKAiw0KPiBUaGlzIHBhdGNoIGFwcGx5IGNvcnJlY3RseSAob24gMTItaGVhZCByMzE0Nzcw KSwgYnV0IGEgIm1ha2UNCj4gYnVpbGRrZXJuZWwiIGZhaWxlZCB3aXRoDQo+IA0KPiDigIstLS0g YWxsX3N1YmRpcl9hbWR0ZW1wIC0tLQ0KPiAvdXNyL3NyYy9zeXMvbW9kdWxlcy9hbWR0ZW1wLy4u Ly4uL2Rldi9hbWR0ZW1wL2FtZHRlbXAuYzoxMDgzOjU0Og0KPiBlcnJvcjogdG9vIGZldyBhcmd1 bWVudHMgdG8gZnVuY3Rpb24gY2FsbCwgZXhwZWN0ZWQgMTEsIGhhdmUgMTANCj4gICAgICAgICAg ICAgICAgICAgICByZWdzW2ldLm9pZF9oYW5kbGVyLCByZWdzW2ldLmZtdCwgcmVnc1tpXS5kZXNj cik7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBeDQoNClRyeSBub3cgd2l0aCBsYXN0IHZlcnNpb24gb2YgcGF0Y2gu DQoNCg== From owner-freebsd-drivers@freebsd.org Wed Mar 8 08:02:43 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0BCB5D002E3 for ; Wed, 8 Mar 2017 08:02:43 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from smtp.smtpout.orange.fr (smtp06.smtpout.orange.fr [80.12.242.128]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client CN "Bizanga Labs SMTP Client Certificate", Issuer "Bizanga Labs CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B6481912 for ; Wed, 8 Mar 2017 08:02:41 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from mail-qk0-f177.google.com ([209.85.220.177]) by mwinf5d63 with ME id tL2W1u00e3qEqs103L2XA3; Wed, 08 Mar 2017 09:02:31 +0100 X-ME-Helo: mail-qk0-f177.google.com X-ME-Auth: Y29jaGFyZC1sYWJiZS5vbGl2aWVyQG9yYW5nZS5mcg== X-ME-Date: Wed, 08 Mar 2017 09:02:31 +0100 X-ME-IP: 209.85.220.177 Received: by mail-qk0-f177.google.com with SMTP id 1so51129966qkl.3; Wed, 08 Mar 2017 00:02:31 -0800 (PST) X-Gm-Message-State: AMke39mk/K0lOvVNIyprnbybF9ioLTCnI+wiQ+lVy1/U+GKpM2BtGO44wEyrVU8ZuslZgW76nMks3taaTU85bA== X-Received: by 10.129.107.137 with SMTP id g131mr1131957ywc.2.1488960145696; Wed, 08 Mar 2017 00:02:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.178.4 with HTTP; Wed, 8 Mar 2017 00:02:05 -0800 (PST) In-Reply-To: <20170308092919.54eb97b5@rimwks> References: <20170306050431.6fff2cbe@rimwks> <20170308092919.54eb97b5@rimwks> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Wed, 8 Mar 2017 09:02:05 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: AMD CPU/APU temperature driver To: Rozhuk Ivan Cc: "freebsd-current@freebsd.org" , freebsd-drivers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 08:02:43 -0000 On Wed, Mar 8, 2017 at 7:29 AM, Rozhuk Ivan wrote: > > Try now with last version of patch. > > =E2=80=8BCompile now and works on PC Engine APU1 and APU2: [root@APU]~# kenv smbios.planar.product APU [root@APU]~# kldload amdtemp amdtemp0: on hostb4 [root@APU]~# sysctl dev.amdtemp dev.amdtemp.0.rtc.sensor_offset: 0 dev.amdtemp.0.rtc.PerStepTimeUp: 15 dev.amdtemp.0.rtc.PerStepTimeDn: 15 dev.amdtemp.0.rtc.TmpMaxDiffUp: 3 dev.amdtemp.0.rtc.TmpSlewDnEn: 1 dev.amdtemp.0.rtc.CurTmpTjSel: -1.4C dev.amdtemp.0.rtc.CurTmp: 47.6C dev.amdtemp.0.htc.PslApicLoEn: 0 dev.amdtemp.0.htc.PslApicHiEn: 0 dev.amdtemp.0.htc.HtcActSts: 0 dev.amdtemp.0.htc.HtcAct: 0 dev.amdtemp.0.htc.HtcPstateLimit: 2 dev.amdtemp.0.htc.HtcSlewSel: 0 dev.amdtemp.0.htc.HtcLock: 0 dev.amdtemp.0.htc.HtcEn: 1 dev.amdtemp.0.htc.HtcHystLmt: 3.1C dev.amdtemp.0.htc.HtcTmpLmt: 100.1C dev.amdtemp.0.%parent: hostb4 dev.amdtemp.0.%pnpinfo: dev.amdtemp.0.%location: dev.amdtemp.0.%driver: amdtemp dev.amdtemp.0.%desc: AMD CPU On-Die Thermal Sensors dev.amdtemp.%parent: =E2=80=8B [root@apu2]~# kenv smbios.planar.product apu2 [root@apu2]~# kldload amdtemp amdtemp0: on hostb5 [root@apu2]~# sysctl dev.cpu.0.temperature dev.cpu.0.temperature: 53.9C [root@apu2]~# sysctl dev.amdtemp dev.amdtemp.0.rtc.sensor_offset: 0 dev.amdtemp.0.rtc.PerStepTimeUp: 15 dev.amdtemp.0.rtc.PerStepTimeDn: 15 dev.amdtemp.0.rtc.TmpMaxDiffUp: 3 dev.amdtemp.0.rtc.TmpSlewDnEn: 1 dev.amdtemp.0.rtc.CurTmpTjSel: 4.6C dev.amdtemp.0.rtc.CurTmp: 53.6C dev.amdtemp.0.htc.PslApicLoEn: 0 dev.amdtemp.0.htc.PslApicHiEn: 0 dev.amdtemp.0.htc.HtcActSts: 1 dev.amdtemp.0.htc.HtcAct: 0 dev.amdtemp.0.htc.HtcPstateLimit: 4 dev.amdtemp.0.htc.HtcSlewSel: 0 dev.amdtemp.0.htc.HtcLock: 0 dev.amdtemp.0.htc.HtcEn: 1 dev.amdtemp.0.htc.HtcHystLmt: 1.1C dev.amdtemp.0.htc.HtcTmpLmt: 105.1C dev.amdtemp.0.%parent: hostb5 dev.amdtemp.0.%pnpinfo: dev.amdtemp.0.%location: dev.amdtemp.0.%driver: amdtemp dev.amdtemp.0.%desc: AMD CPU On-Die Thermal Sensors dev.amdtemp.%parent: From owner-freebsd-drivers@freebsd.org Wed Mar 8 08:11:56 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE49DD00810; Wed, 8 Mar 2017 08:11:56 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-lf0-x242.google.com (mail-lf0-x242.google.com [IPv6:2a00:1450:4010:c07::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 74F6510F7; Wed, 8 Mar 2017 08:11:56 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-lf0-x242.google.com with SMTP id r36so1818862lfi.0; Wed, 08 Mar 2017 00:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fCSnk42sBqqMvHDDQ+fnJ/gKowTDH49R46uDm0zi8No=; b=Aw2urlQ9LtFfHlcndtFDD+ftzbk50jnvhy7oOPtgeIDo/H9yGafcfjFPYN00eIjRPg 1A5f0wek497T83I0xcNmOScLm+cKd3lGllsejnEdxhfzyJ1UPAbrZo5uUkDYaH3OvYqT Oo1Mj0H4BtowRnnMpuVdpobIzZ9NUIigyTjUbcVZjS1WuSJERlpVLJQHY3605nJrxNjs Z17t83XT4I3ELg7dqYeAMpb9CnGiOCGL08+Yg351m9SkAXjO55EsglYhisx+n7e3ll77 2h4rDFKIfH6xG9bXvOkAtfQOVoc7tMZPQQ5efoj6oTF/cMNYTt/pqrTMZ0vr3oRAdoHy g3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fCSnk42sBqqMvHDDQ+fnJ/gKowTDH49R46uDm0zi8No=; b=jAXXP5EImAeY6vaS7tLszlphYmNQ8uI3DQPlGlJoPnxW4xxCe7FiTN5bjsW4nXFAwC KGT903QcY5XwpPX4UunmPAAbG0p7Kk4eud/1A47q+7+ENMNNl8Guph6x1b/lA99m7025 qVrog5p5TRoA++/9ZfqpCYGfcBjZ7V5vDVQ7m28N05MynYcaW0mav9uKkLXOlgHxd8jk Te+JwDmtQ+E4zpQBwkCX8mz0ZpcJvTQeP2xpeZeISMGzGKKXrYYFwdMMCbToGRSkhS4Z F0RjUZRhzOPQVwL+H1wwgMT0ve52Vs0Qo99H+pydf5yjTjyv1+SOTzPgbeSHm0ZFi2cc riUg== X-Gm-Message-State: AMke39mHWBsXWqWh+unbilzwQDNfxDc8i39NcXrntfOcIoKYWtHIHE3oUYRgp1mK/6FKrA== X-Received: by 10.25.201.74 with SMTP id z71mr1278876lff.108.1488960714519; Wed, 08 Mar 2017 00:11:54 -0800 (PST) Received: from rimwks ([2001:470:28:81a:6ef0:49ff:fe75:38e3]) by smtp.gmail.com with ESMTPSA id m16sm478797lfj.3.2017.03.08.00.11.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Mar 2017 00:11:53 -0800 (PST) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Wed, 8 Mar 2017 11:11:51 +0300 To: Olivier =?UTF-8?B?Q29jaGFyZC1MYWJiw6k=?= Cc: "freebsd-current@freebsd.org" , freebsd-drivers@freebsd.org Subject: Re: AMD CPU/APU temperature driver Message-ID: <20170308111151.7e0bede8@rimwks> In-Reply-To: References: <20170306050431.6fff2cbe@rimwks> <20170308092919.54eb97b5@rimwks> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 08:11:57 -0000 T24gV2VkLCA4IE1hciAyMDE3IDA5OjAyOjA1ICswMTAwDQpPbGl2aWVyIENvY2hhcmQtTGFiYsOp IDxvbGl2aWVyQGZyZWVic2Qub3JnPiB3cm90ZToNCg0KPiBPbiBXZWQsIE1hciA4LCAyMDE3IGF0 IDc6MjkgQU0sIFJvemh1ayBJdmFuIDxyb3podWsuaW1AZ21haWwuY29tPg0KPiB3cm90ZToNCj4g DQo+ID4NCj4gPiBUcnkgbm93IHdpdGggbGFzdCB2ZXJzaW9uIG9mIHBhdGNoLg0KPiA+DQo+ID4g 4oCLQ29tcGlsZSBub3cgYW5kIHdvcmtzIG9uIFBDIEVuZ2luZSBBUFUxIGFuZCBBUFUyOg0KPiAN Cg0KVGhhbmtzIQ0KDQpzeXNjdGwgaHcubW9kZWwNCnBsZWFzZS4NCg== From owner-freebsd-drivers@freebsd.org Wed Mar 8 09:32:07 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4EECD027BE for ; Wed, 8 Mar 2017 09:32:07 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from smtp.smtpout.orange.fr (smtp07.smtpout.orange.fr [80.12.242.129]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client CN "Bizanga Labs SMTP Client Certificate", Issuer "Bizanga Labs CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 468351156 for ; Wed, 8 Mar 2017 09:32:06 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from mail-ua0-f175.google.com ([209.85.217.175]) by mwinf5d13 with ME id tMXx1u00N3nebah03MXxcz; Wed, 08 Mar 2017 10:31:58 +0100 X-ME-Helo: mail-ua0-f175.google.com X-ME-Auth: Y29jaGFyZC1sYWJiZS5vbGl2aWVyQG9yYW5nZS5mcg== X-ME-Date: Wed, 08 Mar 2017 10:31:58 +0100 X-ME-IP: 209.85.217.175 Received: by mail-ua0-f175.google.com with SMTP id q7so25281089uaf.2; Wed, 08 Mar 2017 01:31:57 -0800 (PST) X-Gm-Message-State: AMke39kMXRTouap+zh2l01IJ/b0Q361g5l7Rl2j/sce042bZ+MxDoCGJTJxu64R6qPOOTQz/rMYUsAb+dZo6WA== X-Received: by 10.129.84.196 with SMTP id i187mr1381489ywb.42.1488965516850; Wed, 08 Mar 2017 01:31:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.178.4 with HTTP; Wed, 8 Mar 2017 01:31:36 -0800 (PST) In-Reply-To: <20170308111151.7e0bede8@rimwks> References: <20170306050431.6fff2cbe@rimwks> <20170308092919.54eb97b5@rimwks> <20170308111151.7e0bede8@rimwks> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Wed, 8 Mar 2017 10:31:36 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: AMD CPU/APU temperature driver To: Rozhuk Ivan Cc: "freebsd-current@freebsd.org" , freebsd-drivers@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 09:32:08 -0000 On Wed, Mar 8, 2017 at 9:11 AM, Rozhuk Ivan wrote: > > sysctl hw.model > please. > =E2=80=8B[root@APU]~# sysctl hw.model hw.model: AMD G-T40E Processor [root@apu2]~# sysctl hw.model hw.model: AMD GX-412TC SOC =E2=80=8B From owner-freebsd-drivers@freebsd.org Thu Mar 9 20:50:02 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A741D05883 for ; Thu, 9 Mar 2017 20:50:02 +0000 (UTC) (envelope-from anindya49@hotmail.com) Received: from COL004-OMC3S16.hotmail.com (col004-omc3s16.hotmail.com [65.55.34.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 147E38BC for ; Thu, 9 Mar 2017 20:50:01 +0000 (UTC) (envelope-from anindya49@hotmail.com) Received: from NAM04-BN3-obe.outbound.protection.outlook.com ([65.55.34.137]) by COL004-OMC3S16.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Thu, 9 Mar 2017 12:49:55 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mbu7/abV6kAHLXY45FXtIS6IuIir/AxflU8LO9eIIZ0=; b=R4xfbsBZErLB+rsYIPfyk3x1cYMj7VLBds5cixw1wzMH1ekudsKh5C/HWa8FCoz1D2Fe+u+8CPOSy5UXrKPME7x9iRUFUYDNbbgzc+m99/lfOO3xHzY6/c2dET+wyZd/+gyGE/hLc7El6WszULJGkzaa7CS9Wz8vh95vpv8GDabjYT+9TPcmiVpLt3uIIreBSmFOSjkwoi0Oi6DxjenbL7P91IG5Ihhu+k3/HtN9w+Miz6CgXySaJY6pp36pB5xmzFi4mCc/MGOHDs+C4kIU4IoJB4hfgfPw9ajkunBt5YRJ4WVrkoJ/F7OwZU8IQ65VJD175jCNJ8m4jIPz3U9OiQ== Received: from SN1NAM04FT011.eop-NAM04.prod.protection.outlook.com (10.152.88.54) by SN1NAM04HT160.eop-NAM04.prod.protection.outlook.com (10.152.89.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7; Thu, 9 Mar 2017 20:49:53 +0000 Received: from MWHPR2201MB1389.namprd22.prod.outlook.com (10.152.88.54) by SN1NAM04FT011.mail.protection.outlook.com (10.152.88.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7 via Frontend Transport; Thu, 9 Mar 2017 20:49:53 +0000 Received: from MWHPR2201MB1389.namprd22.prod.outlook.com ([10.172.63.7]) by MWHPR2201MB1389.namprd22.prod.outlook.com ([10.172.63.7]) with mapi id 15.01.0947.020; Thu, 9 Mar 2017 20:49:53 +0000 From: Anindya Mukherjee To: "freebsd-drivers@freebsd.org" Subject: uiomove question Thread-Topic: uiomove question Thread-Index: AQHSmRaz97BbjjTePUWUIWXrakMIPA== Date: Thu, 9 Mar 2017 20:49:53 +0000 Message-ID: Accept-Language: en-CA, en-US Content-Language: en-CA X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=hotmail.com; x-incomingtopheadermarker: OriginalChecksum:5E72ACB1481BD16BD87426F8C096BEF1D06A3A1EC66D4C74CFAB4A1728EF6E15; UpperCasedChecksum:EFFD16B3844282D88F298ED8FB17657CAD474FF0C942049198F889CAEF60055D; SizeAsReceived:7548; Count:36 x-tmn: [F2SbqQErnEtX+F+1bfa4vPp2AEcMBbm4] x-incomingheadercount: 36 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; SN1NAM04HT160; 5:RG/xpi4c/ktVEI8AiIDt8kLs7H3SOqz/imD63MZD09VYBEOLzTm2NVbvIChsn+InE85GQzngTJPAQUmvp7RvrMwj7PsBSO7untuPGti7uiU2lN6nE0O/yknanbq1EAXF0kDE2zCJAg1qP6Fvu5cJHA==; 24:72gZwHpO32E3HmrITzy+7cUMhtz2ZhJKFJg18e9kJkrzL7HoacP0SLf4neN96cOPDxHwoRe6CaA7Ngjzs7mPLEmOmohxAq5vrMf4VysSyQ4=; 7:WTb2xvYzmNTGN0hbuleASaoBVTO+4m2dszbLqSL/l92/9qOaJhVdSq9ilzgJnIembggT5sOg1rtMKHQkL1YlibtSa+qj372ZZBDQHlwCbCYGjlMaIi2Fv+LEXrxMV6W3JNcXU2YPucfRqxamyQ0LkGIz5wmsahDB+TVfTuGpvGUOvQYG5bIrRFm7eVcZ/NruVdRo8ee53G+jeE4dwx0RMU1h+b7ztyegxIxXuWY0O2c0znpRSBUCVyuwIlqnAzmXCPVags/NLUKMfaHHnX2Oi52gG7QQrgVrEmuU/d8iwanmGtqKg1d+KO3AVOGgjDoV x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900016); DIR:OUT; SFP:1102; SCL:1; SRVR:SN1NAM04HT160; H:MWHPR2201MB1389.namprd22.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 16d9ce99-0c75-41a5-7c33-08d4672dd67b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(1601125254)(1603101448)(1701031045); SRVR:SN1NAM04HT160; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015087)(444000031); SRVR:SN1NAM04HT160; BCL:0; PCL:0; RULEID:; SRVR:SN1NAM04HT160; x-forefront-prvs: 0241D5F98C spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2017 20:49:53.5220 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT160 X-OriginalArrivalTime: 09 Mar 2017 20:49:55.0115 (UTC) FILETIME=[B4F067B0:01D29916] X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 20:50:02 -0000 Hi, I have been reading Joseph Kong's book: "FreeBSD Device Drivers - A Gui= de for the Intrepid". I have a confusion about the way uiomove() is being u= sed in the code examples, such as the xxx_read() and xxx_write() routines. As I understand, from reading /usr/src/sys/kern/subr_uio.c around line 248,= uiomove() does not offset the kernel buffer automatically. The programmer = has to add the offset from the uio structure. In the xxx_read() code in the= book, this offset is applied correctly. However, in all the xxx_write() examples, the amount to be written is calcu= lated assuming the write is going to happen at a certain offset in the buff= er, but in the actual call to uiomove() the offset is not applied. Is this = a typo or am I missing something here? Thanks for reading!= From owner-freebsd-drivers@freebsd.org Sat Mar 11 14:04:16 2017 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35E64D0673D for ; Sat, 11 Mar 2017 14:04:16 +0000 (UTC) (envelope-from anindya49@hotmail.com) Received: from BAY004-OMC3S18.hotmail.com (bay004-omc3s18.hotmail.com [65.54.190.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 080D917A1 for ; Sat, 11 Mar 2017 14:04:15 +0000 (UTC) (envelope-from anindya49@hotmail.com) Received: from NAM04-BN3-obe.outbound.protection.outlook.com ([65.54.190.187]) by BAY004-OMC3S18.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sat, 11 Mar 2017 06:03:10 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9QXf3a7SlEImDbQgBcNLd/GQ9wgP0VH+Jmkyy9qjcyE=; b=JQ01wRpsipaHvHZ1fWvy4qw1D6sZO/i7oM51SEnZlFrEq9fOcpQIx3cELED9TUOPuLm64opf+TFUJzqYkxaPu1mZTzp90G7oLfZHwkzqDwMksMx77XVF1D5JqjLWpObTl4i9g5cMu2CgVRep+dLjLnPvfxYQCsFvNgtvf26b6RFejypMUgS/nHIyZBCMyzX5XVk+p/WDDWqe/oXpo6JPJVcOiDZRN5f6oQCvv94KFELbjyw3/G0RNQufc3UVN8dt0oaO+HP00deG5J4e6OAlmfooEZrLeBpjiI3sGm20UfdWDV3LoEUvOU+F9A/orKs3w0NrKMKWptxS9OPNF+6Ewg== Received: from CO1NAM04FT041.eop-NAM04.prod.protection.outlook.com (10.152.90.58) by CO1NAM04HT078.eop-NAM04.prod.protection.outlook.com (10.152.91.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.7; Sat, 11 Mar 2017 14:03:06 +0000 Received: from MWHPR2201MB1389.namprd22.prod.outlook.com (10.152.90.54) by CO1NAM04FT041.mail.protection.outlook.com (10.152.91.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.961.10 via Frontend Transport; Sat, 11 Mar 2017 14:03:06 +0000 Received: from MWHPR2201MB1389.namprd22.prod.outlook.com ([10.172.63.7]) by MWHPR2201MB1389.namprd22.prod.outlook.com ([10.172.63.7]) with mapi id 15.01.0947.020; Sat, 11 Mar 2017 14:03:06 +0000 From: Anindya Mukherjee To: "freebsd-drivers@freebsd.org" Subject: RE: uiomove question Thread-Topic: uiomove question Thread-Index: AQHSmRaz97BbjjTePUWUIWXrakMIPKGPrdau Date: Sat, 11 Mar 2017 14:03:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-CA, en-US Content-Language: en-CA X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=hotmail.com; x-incomingtopheadermarker: OriginalChecksum:B4FDF5A14BABA7386E0C5AD50D3501E1CEAD92082F0D434371DC0700EEEF135A; UpperCasedChecksum:E538CA4D011F18F41087337C78940575B726D376FA2A8FF3F63CBFE76F7D4299; SizeAsReceived:7798; Count:39 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [a0HjNfSOc3P/gbfpcWx6FKLAsfxnPYhs] x-incomingheadercount: 39 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1; CO1NAM04HT078; 5:LZltYrBI6mIMhF8jU1u361u7ze12N0S5L5IOo9DyEFZJ+OCqvSxQkgfc1OYTN6P3igjKm367pE3a+SvPShXs1C2bA6unY1el0A+gELMXYGTB+gQzYwAlSXIfIxioxgN65Rf5bXhCoyzKBkosY+qwjmEO2HygwR+yT95Y+WYZC2A=; 24:jsNRfRpZC6l7MRMrUAHpawpcI03qvDg9WKEcS2+0pjSzs6y/s4NG+M2Yc4cYV5Z3zk4fXu5Gs0HMAHA8DFMvwcV05Qip2dg5LVQbSSBlrb0=; 7:5otrhmCvQbAm5LExHNg9/jX2TXjS0fOVSd+AojqKWqwQZkUBkdB5NUEmSJWnwPRaBSxeNejyvA9iILrEsWu5PjYzBLESdI21dhB4sqdTVkpmYJLx5SQyqPPVgp4QivqW2Ssq9SEs23V8msAichlI/TQ9bjVTsoYDiOsjgeQsUQvxvMJ94NZWx7brftHAtHWfCHOsi31MwEmdXcdCXUVf724GQRsndedGUd2ZcYzhHuFJU//heuNjmK7ezgcT2FYcCBOfKxhCmZQqQ85OMh5FSytKjkxG9mZtj+XCozpDqMDrlwuGzKvXz6ta3tNXjSt+ x-forefront-antispam-report: EFV:NLI; SFV:NSPM; SFS:(10019020)(98900016); DIR:OUT; SFP:1102; SCL:1; SRVR:CO1NAM04HT078; H:MWHPR2201MB1389.namprd22.prod.outlook.com; FPR:; SPF:None; LANG:en; x-ms-office365-filtering-correlation-id: 5cb0345a-4d58-40cc-fc18-08d4688757b6 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702061074)(5061506573)(5061507331)(1603103135)(1603101448)(1601125254)(1701031045); SRVR:CO1NAM04HT078; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(432015087)(444000031); SRVR:CO1NAM04HT078; BCL:0; PCL:0; RULEID:; SRVR:CO1NAM04HT078; x-forefront-prvs: 0243E5FD68 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2017 14:03:06.6472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM04HT078 X-OriginalArrivalTime: 11 Mar 2017 14:03:10.0380 (UTC) FILETIME=[3768DEC0:01D29A70] X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Mar 2017 14:04:16 -0000 An example of the usage I am talking about: xxx_write(...) { ... amount =3D MIN(uio->uio_resid, // 0. This is the no of bytes in the uio le= ft to write (BUFFER_SIZE - 1 - uio->uio_offset > 0) ? BUFFER_SIZE - 1 - uio->uio_offset : 0); // 1. amount to write = is computed //assuming write will happen at uio_offset in sc_buffer if (amount =3D=3D 0) return (error); error =3D uiomove(sc->sc_buffer, amount, uio); // 2. sc_buffer is not offs= et ... } xxx_read(...) { ... amount =3D MIN(uio->uio_resid, (sc->sc_length - uio->uio_offset > 0) ? sc->sc_length - uio->uio_offset : 0); // 3. Same as comment 1 = above error =3D uiomove(sc->sc_buffer + uio->uio_offset, amount, uio); // 4. Here= buffer is offset ... } Anindya=