From owner-freebsd-git@freebsd.org Wed Mar 1 00:16:53 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B886ACF1429 for ; Wed, 1 Mar 2017 00:16:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9AE6B6B5 for ; Wed, 1 Mar 2017 00:16:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 96FC3CF1425; Wed, 1 Mar 2017 00:16:53 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96A09CF1424 for ; Wed, 1 Mar 2017 00:16:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CD416B4 for ; Wed, 1 Mar 2017 00:16:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22c.google.com with SMTP id h10so87593890ith.1 for ; Tue, 28 Feb 2017 16:16:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:from:date:message-id:subject:to; bh=J/RX5TrIli3mqwbI4XxNmzi+pt9xih7IUwTRttnq/s4=; b=q12AFSfAxKKCtVSMTptIumJOwbnff2Oe8VLChmTeSid3anotzqmVTjE8XDmQhmLzXq SOMibZgYIFNnHyRiWYysxZU6M2ze3VKTYqiF6Ox1m8qAx9XMv8cB3CY6+/or0uPfIvn3 rscrzgHJbebhACxRiuQ/JdXq1W903Zzc5TU5P0hSBohR13NaNNCUfHqtYH3miX9jflau dgpMVk25nF7auUHPsehU0IJJo0KJw9XxalSf1O3OIo6f0tIZhb/J/1e8l2jR9P5/WVDL m5B80DLMlTjGAB5hSPTRNpRB0XnlwDfFi8c54WAm+ln0eZ8KFSPcgurB2qIpJ+PA1k+j 8VdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=J/RX5TrIli3mqwbI4XxNmzi+pt9xih7IUwTRttnq/s4=; b=oOru4xIoYFoXjTI6Mvy4JY1EcNOxkleDtYfbFCx0a2q3bNE1ENFdDNifVNO//goVxM 2FRLy5SA8O4kcQl83pglAxdH2MIYh+4uX4tX1ftfcpG4Hrs8B5VUPUmBajvQvI7/DKqn 4d8mkFxBo9uDObLWDpCXo3VQCP/R0mpSV6PHuUkzFWUYhT3QZS96iUwRjkrGZiN2Kwmt Uzva9DLLAbY9z0csGzDBwjZeia6gES6esRZQrSDjhh8OR0g5t75qxZ5vA68QkmbSN6WG GHC//odgi20KWs3resRZlX3W3QIratQ37tzXm8kjZv9Zy1WwZj7f/iUzk+h9qpF0nsVs vZyw== X-Gm-Message-State: AMke39kEVELtmaIlkhERubZx0ptlUnQeUh5Q1f/WWU+cw+sjecIKDRieDmi2qM4H3CyJvOubjrhN7vlQTaWyOg== X-Received: by 10.36.147.71 with SMTP id y68mr1521127itd.85.1488327412231; Tue, 28 Feb 2017 16:16:52 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Tue, 28 Feb 2017 16:16:51 -0800 (PST) X-Originating-IP: [50.253.99.174] From: Warner Losh Date: Tue, 28 Feb 2017 17:16:51 -0700 X-Google-Sender-Auth: 7PTxEshgTCjYHxwDunwultRFlSk Message-ID: Subject: pull requests To: git@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 00:16:53 -0000 So, policy on github pull requests. Do we have one? If not, I'm going to set a sensible one and publish. Or set one and get you folks to review. I'd like to see us down to 0 open pull requests by the end of March. Warner From owner-freebsd-git@freebsd.org Wed Mar 1 09:36:55 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA4ABCF378F for ; Wed, 1 Mar 2017 09:36:55 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A944CC8 for ; Wed, 1 Mar 2017 09:36:55 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mailman.ysv.freebsd.org (Postfix) id A584BCF378E; Wed, 1 Mar 2017 09:36:55 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A52A7CF378D for ; Wed, 1 Mar 2017 09:36:55 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com [209.85.213.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 67CC9C6 for ; Wed, 1 Mar 2017 09:36:54 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mail-vk0-f47.google.com with SMTP id k127so6167741vke.0 for ; Wed, 01 Mar 2017 01:36:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uDmmVrQwzOSnbQYsQYzYkmA+45eBWugKfgEypQU0+0s=; b=N5cBSNY5hM/8g8Jt42jRY5UKU+yx+zchSHih/2NS7vRqsnLfrqB3j8GavfryYtit9d 1jnOdobwbQfeyBn2S5oQaXW19wIeLI5yGL5JYiAIF0iwOPl07gzRVPs+7kPSwQMNma/C 6cBNBhjkN+FKkJR4WEmib5eriZVafTF5sneWr3szY9C9hwKcLXDtRzwmctFnUFlgUPvR QKYntr9/rII9EWcbJjFutDQYVZNyXjZkVqeOUIBmIGF76F//cfvHDbFYjA5XNjeS5D4d Uy+iIVahtQ2uU5ppg1H+WdW+aXygO0a3eHlCHUkjNM4nxTwDgqqBdhrBdNIDe9rk0vDc 9xpQ== X-Gm-Message-State: AMke39l4DqDk5ZkvdkA60fCZSN0dtSGZEtbmMAbL+4QsW+vyc/eEgwlBz+noocuw4FMZZA== X-Received: by 10.31.236.6 with SMTP id k6mr2693223vkh.144.1488361008005; Wed, 01 Mar 2017 01:36:48 -0800 (PST) Received: from mail-vk0-f43.google.com (mail-vk0-f43.google.com. [209.85.213.43]) by smtp.gmail.com with ESMTPSA id x31sm897994uax.9.2017.03.01.01.36.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 01:36:47 -0800 (PST) Received: by mail-vk0-f43.google.com with SMTP id t8so6186157vke.3 for ; Wed, 01 Mar 2017 01:36:47 -0800 (PST) X-Received: by 10.31.93.66 with SMTP id r63mr3196829vkb.126.1488361007165; Wed, 01 Mar 2017 01:36:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.11.6 with HTTP; Wed, 1 Mar 2017 01:36:26 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Date: Wed, 1 Mar 2017 09:36:26 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pull requests To: Warner Losh Cc: git@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 09:36:55 -0000 On Wed, Mar 1, 2017 at 12:16 AM, Warner Losh wrote: > So, policy on github pull requests. > > Do we have one? > > If not, I'm going to set a sensible one and publish. Or set one and > get you folks to review. I'd like to see us down to 0 open pull > requests by the end of March. > > Warner > What kind of policy, regarding what and 'policing' what and how exactly? Who and how will enforce such policy and on whom? In the end, "we can't force anyone to do anything" so unless we commit to do something on GitHub, I'd see it as a dead law. Not to mention I've got a feeling this is completely disconnected from the general direction that I think has been 'agreed', that is we'll have a software solution getting GH PR's into Phabric reviews and GH Issues into Bugzilla PR's automatically. What then, shouldn't it be more like Phabric reviews/Bugzilla PR policy instead? Kind regards, Bartek Rutkowski From owner-freebsd-git@freebsd.org Wed Mar 1 11:51:55 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD145CF395C for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id CAE53BBB for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id CA2A6CF395B; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C823BCF395A for ; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 848BBBB8; Wed, 1 Mar 2017 11:51:55 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 057441EC6F; Wed, 1 Mar 2017 12:51:52 +0100 (CET) From: "Kristof Provost" To: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" Cc: "Warner Losh" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 12:52:13 +0100 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 11:51:56 -0000 On 1 Mar 2017, at 10:36, Bartłomiej Rutkowski wrote: > What kind of policy, regarding what and 'policing' what and how > exactly? > Who and how will enforce such policy and on whom? In the end, "we > can't > force anyone to do anything" so unless we commit to do something on > GitHub, > I'd see it as a dead law. > There is an official FreeBSD account on GitHub and I don’t expect that to go away. See https://github.com/freebsd/freebsd/pulls (As an aside, I note that someone has been cleaning these up. Awesome.) We are getting pull requests there and something should be done with them. > Not to mention I've got a feeling this is completely disconnected from > the > general direction that I think has been 'agreed', that is we'll have a > software solution getting GH PR's into Phabric reviews and GH Issues > into > Bugzilla PR's automatically. What then, shouldn't it be more like > Phabric > reviews/Bugzilla PR policy instead? > This is probably a good answer to the question of what to do with those pull requests. As the current situation is “they’re completely ignored” anything would be an improvement. Even automatically closing them with “Go to instead.” would be an improvement. It might be nice to document a review policy (usable for GitHub, Phabricator, e-mail reviews, …) somewhere. Things like “How long do I wait for reviews?”, “Who do I subscribe/cc/…?”, “What should be done with abandoned reviews?” … I fully support Warner’s efforts. Regards, Krsitof From owner-freebsd-git@freebsd.org Wed Mar 1 12:06:58 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1A23CF2478 for ; Wed, 1 Mar 2017 12:06:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 8E4F6764 for ; Wed, 1 Mar 2017 12:06:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8D923CF2477; Wed, 1 Mar 2017 12:06:58 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8A7F7CF2475 for ; Wed, 1 Mar 2017 12:06:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5692B763; Wed, 1 Mar 2017 12:06:58 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 3EEE81ECD6; Wed, 1 Mar 2017 13:06:56 +0100 (CET) From: "Kristof Provost" To: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" Cc: "Warner Losh" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 13:07:16 +0100 Message-ID: <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:06:58 -0000 On 1 Mar 2017, at 13:00, Bartłomiej Rutkowski wrote: > Don't get me wrong, I am simply trying to understand what exactly > would > that accomplish - see https://reviews.freebsd.org/D9649. Lets, for a > fun > thought experiment, imagine it was an GH pull request that was > transferred > to Phabric. What now? 2 weeks passed and nothing happened. Would any > policy > fix that? > No, the best policy in the world isn’t going to fix lack of time. It might help a little if these at least all land on the same pile, but it’s not going to magic up reviewers. I’m not sure anything would. A possibly policy answer would be that reviews are automatically closed after a while. It’s not great, but at least the submitter knows that nothing is going to happen. Leaving it open forever also accomplishes nothing. Regards, Kristof From owner-freebsd-git@freebsd.org Wed Mar 1 12:08:00 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB296CF24AF for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A7B437AB for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mailman.ysv.freebsd.org (Postfix) id A6B4ACF24AE; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A630ACF24AD for ; Wed, 1 Mar 2017 12:08:00 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com [209.85.217.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6661F7AA for ; Wed, 1 Mar 2017 12:07:59 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mail-ua0-f177.google.com with SMTP id f54so39595620uaa.1 for ; Wed, 01 Mar 2017 04:07:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kKkaoK7czDzx9X6Cb2AxBhZL3+jLdtiybf3QIDiiYRw=; b=T0bUZBivyGjltsJjI9ZAXynq4anImZoOPDpnfNLDn68+gXCOJrLqhegcpanO+UYqMc jITcY9mo90yFtz0NSiCgIKkH9aGu2gx9utXpaYBZ11/OhT8yl0YraUzB5gvqxmeRDt6b ikGlha54lb5XYYHDBFb1dkqy6xD6JgaeNulNjPJkmQy4/IfIx3IwK9WH9NmI7XvMY7IR oco+b68b5zO3ISVkgAVvVmaq1Br5wZ/oKNMk1e8OIlUuw6tApOvmW1JbZzOKS9oyavom jfHQ1GeI4NyAQAjYgaNgEA2qj4ROWN5aqT9uRW2oaYN0aef3DAmNDI/KPErrHeQuGjyO Z4hw== X-Gm-Message-State: AMke39lryl2sGigNEe9z/0JuR+2IZMSPv+6GhGKsCDeUe5dNUMNkcnJiKJKinDgWy6p2gA== X-Received: by 10.176.82.86 with SMTP id j22mr3125447uaa.126.1488369670335; Wed, 01 Mar 2017 04:01:10 -0800 (PST) Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com. [209.85.217.177]) by smtp.gmail.com with ESMTPSA id n9sm37178vkc.25.2017.03.01.04.01.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 04:01:09 -0800 (PST) Received: by mail-ua0-f177.google.com with SMTP id x24so39509226uab.0 for ; Wed, 01 Mar 2017 04:01:09 -0800 (PST) X-Received: by 10.176.1.5 with SMTP id 5mr3080438uak.30.1488369669344; Wed, 01 Mar 2017 04:01:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.11.6 with HTTP; Wed, 1 Mar 2017 04:00:48 -0800 (PST) In-Reply-To: References: From: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Date: Wed, 1 Mar 2017 12:00:48 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pull requests To: Kristof Provost Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= , Warner Losh , git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:08:00 -0000 On Wed, Mar 1, 2017 at 11:52 AM, Kristof Provost wrote: > On 1 Mar 2017, at 10:36, Bart=C5=82omiej Rutkowski wrote: > >> What kind of policy, regarding what and 'policing' what and how exactly? >> Who and how will enforce such policy and on whom? In the end, "we can't >> force anyone to do anything" so unless we commit to do something on >> GitHub, >> I'd see it as a dead law. >> >> There is an official FreeBSD account on GitHub and I don=E2=80=99t expec= t that to > go > away. > > See > https://github.com/freebsd/freebsd/pulls > > (As an aside, I note that someone has been cleaning these up. Awesome.) > > We are getting pull requests there and something should be done with them= . > > Not to mention I've got a feeling this is completely disconnected from th= e >> general direction that I think has been 'agreed', that is we'll have a >> software solution getting GH PR's into Phabric reviews and GH Issues int= o >> Bugzilla PR's automatically. What then, shouldn't it be more like Phabri= c >> reviews/Bugzilla PR policy instead? >> >> This is probably a good answer to the question of what to do with those > pull > requests. > > As the current situation is =E2=80=9Cthey=E2=80=99re completely ignored= =E2=80=9D anything would be > an > improvement. Even automatically closing them with =E2=80=9CGo to in= stead.=E2=80=9D > would > be an improvement. > > It might be nice to document a review policy (usable for GitHub, > Phabricator, > e-mail reviews, =E2=80=A6) somewhere. Things like =E2=80=9CHow long do I = wait for > reviews?=E2=80=9D, > =E2=80=9CWho do I subscribe/cc/=E2=80=A6?=E2=80=9D, =E2=80=9CWhat should = be done with abandoned reviews?=E2=80=9D =E2=80=A6 > > I fully support Warner=E2=80=99s efforts. > > Regards, > Krsitof > Don't get me wrong, I am simply trying to understand what exactly would that accomplish - see https://reviews.freebsd.org/D9649. Lets, for a fun thought experiment, imagine it was an GH pull request that was transferred to Phabric. What now? 2 weeks passed and nothing happened. Would any policy fix that? Kind regards, Bartek Rutkowski From owner-freebsd-git@freebsd.org Wed Mar 1 12:16:56 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 677E8CF27DE for ; Wed, 1 Mar 2017 12:16:56 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 42CF1E47 for ; Wed, 1 Mar 2017 12:16:56 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mailman.ysv.freebsd.org (Postfix) id 3EE47CF27DB; Wed, 1 Mar 2017 12:16:56 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E8C7CF27DA for ; Wed, 1 Mar 2017 12:16:56 +0000 (UTC) (envelope-from r@robakdesign.com) Received: from mail-vk0-f52.google.com (mail-vk0-f52.google.com [209.85.213.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F21D7E45 for ; Wed, 1 Mar 2017 12:16:55 +0000 (UTC) (envelope-from r@robakdesign.com) Received: by mail-vk0-f52.google.com with SMTP id x75so7887178vke.2 for ; Wed, 01 Mar 2017 04:16:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ywX04CiBmlhXUUv/OkPnrF0JjJvxD+7/B+iXil6XMCQ=; b=jxhE6qtpRrAyX2mLYXm+M158cQCrNZ1jU6gZZRRfdEay+i7Kj/Kb8v+nIYg/UFgp5e 0zDuf/ivtzhXGsapIw2wFFcl7hIMcooUSmi/bEegsvRgqo5mNbQzOaal/BCe1m+ie/Rs EXQMvu8+mEW2bHmDu4pZX2lbAdsgUf8q1TBXD2ESj4OiYiumBx1EuL9Ql/0wiaCiTfXE Obd8R5cno1stD90PD/ks2DjnJZU7uHsUa1xBIN0A8ZPz6pXnOeZoG05W+2auIergg6RD N0SBDikGKfnLScQzk5NvSs6EL9QNDaPmO3TlUCi4R9Z4vcs5sTKgJ9a/LE4/2nClvxZ6 PKEg== X-Gm-Message-State: AMke39n5Yt2UaCpuVWReXcFG0gkzH/f6K/cfPtrf+8v7lQ4Qw0hqssUU/Ecj10cYwf0q7g== X-Received: by 10.31.166.7 with SMTP id p7mr172525vke.136.1488370608609; Wed, 01 Mar 2017 04:16:48 -0800 (PST) Received: from mail-ua0-f179.google.com (mail-ua0-f179.google.com. [209.85.217.179]) by smtp.gmail.com with ESMTPSA id d78sm46287vke.18.2017.03.01.04.16.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 04:16:48 -0800 (PST) Received: by mail-ua0-f179.google.com with SMTP id q7so8875566uaf.2 for ; Wed, 01 Mar 2017 04:16:48 -0800 (PST) X-Received: by 10.176.69.5 with SMTP id r5mr3905694uar.56.1488370608001; Wed, 01 Mar 2017 04:16:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.11.6 with HTTP; Wed, 1 Mar 2017 04:16:27 -0800 (PST) In-Reply-To: <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org> References: <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org> From: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Date: Wed, 1 Mar 2017 12:16:27 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: pull requests To: Kristof Provost Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= , Warner Losh , git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:16:56 -0000 On Wed, Mar 1, 2017 at 12:07 PM, Kristof Provost wrote: > On 1 Mar 2017, at 13:00, Bart=C5=82omiej Rutkowski wrote: > >> Don't get me wrong, I am simply trying to understand what exactly would >> that accomplish - see https://reviews.freebsd.org/D9649. Lets, for a fun >> thought experiment, imagine it was an GH pull request that was transferr= ed >> to Phabric. What now? 2 weeks passed and nothing happened. Would any >> policy >> fix that? >> >> No, the best policy in the world isn=E2=80=99t going to fix lack of time= . > > It might help a little if these at least all land on the same pile, but > it=E2=80=99s > not going to magic up reviewers. I=E2=80=99m not sure anything would. > > A possibly policy answer would be that reviews are automatically closed > after a > while. It=E2=80=99s not great, but at least the submitter knows that noth= ing is > going > to happen. Leaving it open forever also accomplishes nothing. > Well, have you seen Bugzilla recently, or ever? :) We've THOUSANDS open PR's (literally, ~2300 for ports, ~6800 for src, with oldest ones going back as far as to 2001). Does it make any sense to waste time to write such policies for Phabric but not for Bugzilla? And if you're about to write one for both, good luck convincing people that bugs shouldn't just lay around forever 'just in case'... In any case, if you'd happen to me successful with that, I'd support it. While 'just in case' argument makes some sense, I still think that keeping more PR's open than we can really handle causes cognitive load and discouragement in taking care of them just by sheer looking at the number of PR's. Kind regards, Bartek Rutkowski From owner-freebsd-git@freebsd.org Wed Mar 1 12:20:20 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E6DCCF28C3 for ; Wed, 1 Mar 2017 12:20:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 59AE1EC0 for ; Wed, 1 Mar 2017 12:20:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 56257CF28C2; Wed, 1 Mar 2017 12:20:20 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55B91CF28C1 for ; Wed, 1 Mar 2017 12:20:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DEC0EBF; Wed, 1 Mar 2017 12:20:20 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 2560A1ED04; Wed, 1 Mar 2017 13:20:18 +0100 (CET) From: "Kristof Provost" To: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" Cc: "Warner Losh" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 13:20:38 +0100 Message-ID: <7E0AA99C-6CC8-4CBB-83E4-264B3D5EFA0B@FreeBSD.org> In-Reply-To: References: <5D8FF3CD-422C-489A-B009-454CA1031E5E@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 12:20:20 -0000 On 1 Mar 2017, at 13:16, Bartłomiej Rutkowski wrote: > Well, have you seen Bugzilla recently, or ever? :) We've THOUSANDS > open > PR's (literally, ~2300 for ports, ~6800 for src, with oldest ones > going > back as far as to 2001). Does it make any sense to waste time to write > such > policies for Phabric but not for Bugzilla? And if you're about to > write one > for both, good luck convincing people that bugs shouldn't just lay > around > forever 'just in case'... > You certainly have a point there, although Mark Linimon does great work trying to improve matters. I’d also argue that just because we have a problem in bugzilla it doesn’t mean we shouldn’t try to avoid it in Phabricator/GitHub/… Regards, Kristof From owner-freebsd-git@freebsd.org Wed Mar 1 14:48:03 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E9D8CF0709 for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 5D40686F for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5CA4FCF0708; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C535CF0707 for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2EC4786D for ; Wed, 1 Mar 2017 14:48:03 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id l7so32272354ioe.3 for ; Wed, 01 Mar 2017 06:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=PllTfJ7qGu/aZJ3oDfrOBU3bFJjg+QKjmZ4AktPptAE=; b=LRBZbzhv20v4HWivHUItHV1s7nVgJbEDR7uVhgrOIOazkns8KxoVBiGciJqmDJOuUV 16dOk0JwKOqiwD4yBTGZanUoK2yDi1kK1jY0J67bqlemdenJgYx8d56OFXyl3q0LeANG 5jm5TKt/hWv5H2fviNlAG5db1ZTKcqqjao37B/FMOM0vPdw4oAUSt+AUYGQr46IaHD4w p2GZ70216ycppJMv5g17CnHxxxKYBk8cg57rtfOk4AjImTm3dAez7zqX/0UBxjVM/aNJ tMpqdG4NDoDrjJ4h06fxEzQq56OIwAFxJqRayEvF5IecIMet7X4e6WeHkryqFBEVXGPc ZjSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=PllTfJ7qGu/aZJ3oDfrOBU3bFJjg+QKjmZ4AktPptAE=; b=U6CX36s3VW0+g1GB1PnpizGMUGJ7nFvB8fzHUBnejvWMNrrXUZ9rwKtgPeYm7km2UI 6ezoWniuo65TP1bBWn/wDILRoa0OjNjRRI0PMWekJ4j6eH11bqhnqGzQndivCqX3xm/z 4/L9DWwQHEAQFjonL5NK5hi4R76EHwJ1BxG7n6B+N5DIN46H10GUf/C914tZCJJrLJGt uGjqJ+ZYiIoxI7UySE4B0HRs67J8t8AuCOrBH4p2Kji9ZiJmFQtOKRFK8LtctW8lJyah hmrsv+c+wzJcSED7bNNAyfcsDBcmfEoqw5fWPp8l3R8p1lqaC8aEJ3dNdcse75l7s3dv WreQ== X-Gm-Message-State: AMke39mMWyenOqeH0HD2n8WGaEQ54AraSWjfnr/l4JWm2rFOHbUqtGfvMkOpbl0d0aqTJF8IgWeaYiX5FaWmpw== X-Received: by 10.107.134.94 with SMTP id i91mr8679018iod.0.1488379682306; Wed, 01 Mar 2017 06:48:02 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Wed, 1 Mar 2017 06:48:01 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: References: From: Warner Losh Date: Wed, 1 Mar 2017 07:48:01 -0700 X-Google-Sender-Auth: W_acLikViitTUuMvNR4ceqqDxcA Message-ID: Subject: Re: pull requests To: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= Cc: git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 14:48:03 -0000 On Wed, Mar 1, 2017 at 2:36 AM, Bart=C5=82omiej Rutkowski wrote: > > > On Wed, Mar 1, 2017 at 12:16 AM, Warner Losh wrote: >> >> So, policy on github pull requests. >> >> Do we have one? >> >> If not, I'm going to set a sensible one and publish. Or set one and >> get you folks to review. I'd like to see us down to 0 open pull >> requests by the end of March. >> >> Warner > > > What kind of policy, regarding what and 'policing' what and how exactly? = Who > and how will enforce such policy and on whom? In the end, "we can't force > anyone to do anything" so unless we commit to do something on GitHub, I'd > see it as a dead law. This answer wins my "Least helpful answer of the year award." Insert rant h= ere. > Not to mention I've got a feeling this is completely disconnected from th= e > general direction that I think has been 'agreed', that is we'll have a > software solution getting GH PR's into Phabric reviews and GH Issues into > Bugzilla PR's automatically. What then, shouldn't it be more like Phabric > reviews/Bugzilla PR policy instead? It certainly doesn't. It documents what we do with them today. Anyway, I got bored waiting for people to answer, so I did this https://wiki.freebsd.org/GithubPullRequests Which basically says if it is committable, we'll channel it in, otherwise we won't. And we'll close after a month by pushing it off to bugzilla. I'd like useful feedback on that. And if things change, we change the above. It's not like we have to guarantee anything. We just have to document what people can expect. If others make it more automated or better than my efforts, great. We document that when it comes along. Warner From owner-freebsd-git@freebsd.org Wed Mar 1 16:08:09 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BEC2CE457A for ; Wed, 1 Mar 2017 16:08:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 59165BF5 for ; Wed, 1 Mar 2017 16:08:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5877ACE4579; Wed, 1 Mar 2017 16:08:09 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5825BCE4578 for ; Wed, 1 Mar 2017 16:08:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 24BFBBF4; Wed, 1 Mar 2017 16:08:09 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 1DBA91F945; Wed, 1 Mar 2017 17:08:06 +0100 (CET) From: "Kristof Provost" To: "Warner Losh" Cc: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 17:08:04 +0100 Message-ID: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:08:09 -0000 On 1 Mar 2017, at 15:48, Warner Losh wrote: > Anyway, I got bored waiting for people to answer, so I did this > > https://wiki.freebsd.org/GithubPullRequests > > Which basically says if it is committable, we'll channel it in, > otherwise we won't. And we'll close after a month by pushing it off to > bugzilla. > > I'd like useful feedback on that. > > Pull requests older than 18 months will be converted to bugzilla items > to not lose them. I’m not sure I understand what you’re getting at here. Presumably it doesn’t mean that pull requests without activity will sit around for 18 months before they’re archived in bugzilla. Is this about pull requests that have been closed? Is there any reason to migrate those? Regards, Kristof From owner-freebsd-git@freebsd.org Wed Mar 1 16:14:25 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9F6DCE4A32 for ; Wed, 1 Mar 2017 16:14:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 875B2697 for ; Wed, 1 Mar 2017 16:14:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.ysv.freebsd.org (Postfix) id 86C33CE4A31; Wed, 1 Mar 2017 16:14:25 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86707CE4A2F for ; Wed, 1 Mar 2017 16:14:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5B3696 for ; Wed, 1 Mar 2017 16:14:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id 90so34299304ios.1 for ; Wed, 01 Mar 2017 08:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=vKW/5Z2bG7wH4geV30klDNMC0OdCdlH4SjWd96uVP4g=; b=GU0Op8wOPHve6GCW4G5zMuoOXovdau//Zw1wmtmd0bML24ERF3+VGMFICFNptwQWJh 1XuZNl77A7Ende7EXoJCPp8BknS2wKggIXv8pl/qdX/7zvK6U4ZeB9n1/Sc62W/TmWMF Xc1xi2kIl2GZIqNteLbn49emYKQ3r1t/TdmQEOZg16BrezluKDFtcbpD6OaeVkRCRs99 of0RSZz6nCInjPpuokxvesbU0cr8PWxgEKkszhl1CgiXoR7E5iv9PYtDkjWEVxBaDuFi v8e4bCulaKV0wyElyy67z/rB2wYgatiOT7IQ/re8tT8AFmIgP9E2qanuOcTPlDOvf75f w5RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=vKW/5Z2bG7wH4geV30klDNMC0OdCdlH4SjWd96uVP4g=; b=TL1n+NnGEFBG35HxnQSbIUSNl10UXh56MrMNeRwliCJftwSj9SR7gorUHrUSX2sjDG K1nRUFJm1g1zRCGWzZBAgexiGbs86N3ysfuNo8amJOQGCobDfG+5Hx1YJ40pMON2IwmB ATYRopw6+KSydsTiUHoC2yNhWaFsu2w4bjd4Xiozqs2EfJHd+BG0ucU0K9htAa8r37Yf /SXJRLUo54GT+Yqx8Sd1f173bo86zZR/w2yB6pAhDMLAEIHkhCY16gtLELKJDGZFg208 l1M4uhM8gZGDlq62bVthJ00atWGLS5MAVMMKvfktJ0GgFR1krgeZTLTvP4EAxqPJ700a KSLA== X-Gm-Message-State: AMke39k1Rhix3UUkguGUehuGdpCzJYYr8+5tO6Z3DRPtfFoxtefS+ON2Xmhz/j4jaqVljX52OJr+g7ujW8xa6g== X-Received: by 10.107.174.220 with SMTP id n89mr10041489ioo.166.1488384863669; Wed, 01 Mar 2017 08:14:23 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.129 with HTTP; Wed, 1 Mar 2017 08:14:23 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> References: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> From: Warner Losh Date: Wed, 1 Mar 2017 09:14:23 -0700 X-Google-Sender-Auth: hErKMYjElOwSEomK6azOo_PuxZA Message-ID: Subject: Re: pull requests To: Kristof Provost Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= , git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:14:25 -0000 On Wed, Mar 1, 2017 at 9:08 AM, Kristof Provost wrote: > On 1 Mar 2017, at 15:48, Warner Losh wrote: >> >> Anyway, I got bored waiting for people to answer, so I did this >> >> https://wiki.freebsd.org/GithubPullRequests >> >> Which basically says if it is committable, we'll channel it in, >> otherwise we won't. And we'll close after a month by pushing it off to >> bugzilla. >> >> I'd like useful feedback on that. >> > >> Pull requests older than 18 months will be converted to bugzilla items t= o >> not lose them. > > > I=E2=80=99m not sure I understand what you=E2=80=99re getting at here. Pr= esumably it doesn=E2=80=99t > mean that pull requests without activity will sit around for 18 months > before > they=E2=80=99re archived in bugzilla. Is this about pull requests that h= ave been > closed? Is there any reason to migrate those? The idea is that after a while pull requests are too stale. Now that I think about it, maybe 18 months is far too long and I should say something smaller, or have some other criteria more directly related to it being actually stale. But there's no value to keeping pull requests open just in case. That degrades the value of having this as a service for simple, ready to go things. If it gets too old, it no longer fits that definition. Warner From owner-freebsd-git@freebsd.org Wed Mar 1 16:14:33 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0108FCE4A52 for ; Wed, 1 Mar 2017 16:14:33 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D33176A8 for ; Wed, 1 Mar 2017 16:14:32 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id D2954CE4A51; Wed, 1 Mar 2017 16:14:32 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2483CE4A50 for ; Wed, 1 Mar 2017 16:14:32 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57F0E6A7; Wed, 1 Mar 2017 16:14:32 +0000 (UTC) (envelope-from uspoerlein@gmail.com) Received: by mail-lf0-x234.google.com with SMTP id z127so21741477lfa.2; Wed, 01 Mar 2017 08:14:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=FgIkK2wz5AkGovvR2up0/kKvuaZPl1F1Tk/bQnt86rA=; b=DRJ+PzkVSdogpbWC15ioeSEL/bLWDWljrMQN2Pe+xExjgZAIkxT4/LGyIIZ20lMlyT 3OoNGt1hudWYFYvb4XygPxZdnAPcy/EectTyDzLN5nNB3JjsA3MgvnLluasBSX+MnZwt 10ktzdBkGHwMzDznJ+trcNnduTYW/AMdUC7we848zAYeM/2PAHIb8VHaItm9dkLMbKS9 yF5fh7zg69pZM/tQuqxrzpHqiINnIStg6ieFvZZwaB6h49944mshoa8KNnWquXdWV4c3 f+L+D8WPm9mUkPhIGRRWqmwuDlUX0aYuMB+XwyMif63prpOI9uoLyB+RLbXJQrcpdbE6 2FHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=FgIkK2wz5AkGovvR2up0/kKvuaZPl1F1Tk/bQnt86rA=; b=ehJn/LIQQe1vi1wkie3FaU4bsioIfdS1dQbM9GqV5V6inj6VYHIBBB/1tEl9YHsbGY Exdx6tNrf7FbsuMiuFtUFhRX89vQq2sG5Nd4QXhs4HIwUYqfj9pyhLZVSKDSjotIEf82 OGSqn2XyjH8pJdsmRBAQ63kpFz041EsnWv+yO8kMfoCIvO2fHteB6YLR5h8D2ODjnFYo bGAHj+qV4XxoWSJFgkN0A+Mn9WOXzN8RBK8zpEgeFylnL3pp68vszfHhXC/memv6HH5l jZSASrJPJuFyrrOZk76KKms+LI8APua7Tw4C9MFy0URpdHKLIdqZyEIOzWiATXU+cJzK ZxaQ== X-Gm-Message-State: AMke39nqsewr54dzA2ZCeHFbsTIa8tGexHjb5CNbk3MozZmPWRIg1lK6UCSABpje0amEzvHtIIws9WAITrrIYw== X-Received: by 10.25.145.2 with SMTP id t2mr3151173lfd.91.1488384869908; Wed, 01 Mar 2017 08:14:29 -0800 (PST) MIME-Version: 1.0 Sender: uspoerlein@gmail.com Received: by 10.25.207.130 with HTTP; Wed, 1 Mar 2017 08:14:29 -0800 (PST) In-Reply-To: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> References: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> From: =?UTF-8?Q?Ulrich_Sp=C3=B6rlein?= Date: Wed, 1 Mar 2017 17:14:29 +0100 X-Google-Sender-Auth: hygOcUQLLe1jaEw8E1vVY32BMTs Message-ID: Subject: Re: pull requests To: Kristof Provost , Warner Losh Cc: git@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:14:33 -0000 2017-03-01 17:08 GMT+01:00 Kristof Provost : > On 1 Mar 2017, at 15:48, Warner Losh wrote: >> >> Anyway, I got bored waiting for people to answer, so I did this >> >> https://wiki.freebsd.org/GithubPullRequests >> >> Which basically says if it is committable, we'll channel it in, >> otherwise we won't. And we'll close after a month by pushing it off to >> bugzilla. >> >> I'd like useful feedback on that. >> > >> Pull requests older than 18 months will be converted to bugzilla items t= o >> not lose them. > > > I=E2=80=99m not sure I understand what you=E2=80=99re getting at here. Pr= esumably it doesn=E2=80=99t > mean that pull requests without activity will sit around for 18 months > before > they=E2=80=99re archived in bugzilla. Is this about pull requests that h= ave been > closed? Is there any reason to migrate those? There are a couple of redundant points in the list. It lacks links into anything (what's a Phabricator, where's the Bugzilla, etc.), so for non-project contributors it is not all too helpful. I would drop all policy and promises about some magical sync into Bugzilla. What's the point? If things get no attention in Github, they'll likely get no attention in Bugzilla. It also makes updating the pull request hard to impossible, or will the pull-request to Bugzilla bridge update the diffs in Bugzilla whenever something new is pushed? From owner-freebsd-git@freebsd.org Wed Mar 1 16:17:13 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73397CE4ACD for ; Wed, 1 Mar 2017 16:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 5F28375C for ; Wed, 1 Mar 2017 16:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5E846CE4ACC; Wed, 1 Mar 2017 16:17:13 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E2A5CE4ACA for ; Wed, 1 Mar 2017 16:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [IPv6:2a01:4f8:162:1127::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.codepro.be", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2988A75B; Wed, 1 Mar 2017 16:17:13 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from [172.16.5.2] (vega.codepro.be [IPv6:2a01:4f8:162:1127::3]) (Authenticated sender: kp) by venus.codepro.be (Postfix) with ESMTPSA id 2B77C1E0E4; Wed, 1 Mar 2017 17:17:11 +0100 (CET) From: "Kristof Provost" To: "Warner Losh" Cc: "=?utf-8?q?Bart=C5=82omiej?= Rutkowski" , git@freebsd.org Subject: Re: pull requests Date: Wed, 01 Mar 2017 17:17:10 +0100 Message-ID: <55C1C6E9-5162-4175-BCFB-675E42F697B3@FreeBSD.org> In-Reply-To: References: <0CA10CBB-89EA-4D0D-97AF-F1AE7DD91833@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed; markup=markdown Content-Transfer-Encoding: 8bit X-Mailer: MailMate (2.0BETAr6080) X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 16:17:13 -0000 On 1 Mar 2017, at 17:14, Warner Losh wrote: > On Wed, Mar 1, 2017 at 9:08 AM, Kristof Provost > wrote: >> On 1 Mar 2017, at 15:48, Warner Losh wrote: >>> Pull requests older than 18 months will be converted to bugzilla >>> items to >>> not lose them. >> >> >> I’m not sure I understand what you’re getting at here. Presumably >> it doesn’t >> mean that pull requests without activity will sit around for 18 >> months >> before >> they’re archived in bugzilla. Is this about pull requests that >> have been >> closed? Is there any reason to migrate those? > > The idea is that after a while pull requests are too stale. Now that I > think about it, maybe 18 months is far too long and I should say > something smaller, or have some other criteria more directly related > to it being actually stale. > Right, so that’s covered better (and with a more reasonable timeframe) by “Issues unresolved on github after about a month will result in the pull request being transitioned to bugzilla or closed at the discretion of the project.” > But there's no value to keeping pull requests open just in case. That > degrades the value of having this as a service for simple, ready to go > things. If it gets too old, it no longer fits that definition. > Agreed. Regards, Kristof From owner-freebsd-git@freebsd.org Wed Mar 1 22:31:46 2017 Return-Path: Delivered-To: freebsd-git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59C64CF3450 for ; Wed, 1 Mar 2017 22:31:46 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 373BEE87 for ; Wed, 1 Mar 2017 22:31:46 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 33ACBCF344F; Wed, 1 Mar 2017 22:31:46 +0000 (UTC) Delivered-To: git@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 332F3CF344E for ; Wed, 1 Mar 2017 22:31:46 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0C2BE85; Wed, 1 Mar 2017 22:31:45 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-qk0-x230.google.com with SMTP id n127so95548429qkf.0; Wed, 01 Mar 2017 14:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AFDY8x9xisIMlvmIoQY1ZYVKLFe7JEmw2foz/GGECR8=; b=PvNGnC/kct2yG3sDqUFyAUda1frDfTS+20SGqL6lxhxCed9HRLDL3+jlEfpIYv/iN+ GIbNmiIk1okW/L0n/9XMR+Mz0C5I72DL2HjzLARePu7+RtfCr+6V1G4H8FHk/ZMxQ/Dr 2YH3grNMtzH5FsFjIznuktcrxPoqm+j5qLIs+Tm0AL4utbRqwuIFsv8pYkwK8DaP25nq dF4sBHT+Be4wq+deZo2xntUKAuR5FGU4RrvJ//LW0kOL2aJOp6Urpm88bv7z18JsCsXt IbmKmi8pHLAlaq2SzxRX/t9DmjpLbA8XsNnIWcMQUNgiwIK+DjWglB01zKfZn6oFSq34 Uegw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AFDY8x9xisIMlvmIoQY1ZYVKLFe7JEmw2foz/GGECR8=; b=dpaVw/VBdzHvssk2a89FohBVgK6Is6EXslBbyvDydyAUOAcbKfmVUvNc6Rkgv8f6Ai zCd6qSFm943IzqFZ2Ki05wVU+hCdRajKDMW2Bio9SPkvHUaz894dbA6OG0eeu+8VyAac u5JbINsXaKaYZVM08kIpQkLM1qieTAzaM+d5H/NcK4Lr+hNPUH71u8ikmJX12ryQ/xwh jMDAW+c6GXhOYeNnmcFIOFFlg+mlPsxgwZ7uI+qXMyTmCm3n9eEwyF9fErs0d4jZy1lP g8zZcYFBtXay91GL6aCU2Zmnxyx9XDTcdVnbfELAk69jMUx8WeViacp+KAv1zsBnBPuE OTVQ== X-Gm-Message-State: AMke39k/Tsrw/OYQaMwgyhvUuy+V8ntUxS5aI52LPeZKokC//R3w2Usiu+9+VShlyyQClKRITycDfc8j25AClw== X-Received: by 10.55.153.2 with SMTP id b2mr12826615qke.314.1488407504979; Wed, 01 Mar 2017 14:31:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.88.200 with HTTP; Wed, 1 Mar 2017 14:31:04 -0800 (PST) In-Reply-To: References: From: Kubilay Kocak Date: Thu, 2 Mar 2017 09:31:04 +1100 Message-ID: Subject: Re: pull requests To: Warner Losh Cc: =?UTF-8?Q?Bart=C5=82omiej_Rutkowski?= , git@freebsd.org, bdrewery@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-git@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion of git use in the FreeBSD project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 22:31:46 -0000 On 2 March 2017 at 01:48, Warner Losh wrote: > On Wed, Mar 1, 2017 at 2:36 AM, Bart=C5=82omiej Rutkowski > wrote: > > > > > > On Wed, Mar 1, 2017 at 12:16 AM, Warner Losh wrote: > >> > >> So, policy on github pull requests. > >> > >> Do we have one? > >> > >> If not, I'm going to set a sensible one and publish. Or set one and > >> get you folks to review. I'd like to see us down to 0 open pull > >> requests by the end of March. > >> > >> Warner > > > It certainly doesn't. It documents what we do with them today. > > Anyway, I got bored waiting for people to answer, so I did this > > https://wiki.freebsd.org/GithubPullRequests > > This already exists as https://wiki.freebsd.org/GitHub Other notes/messaging may (I think) also exist in the README or CONTRIBUTING file in the repositories (cc bdrewery) It could be improved by **highlighting** or =3D=3D sectioning =3D=3D off t= he Pull Requests bit Please merge your additions (where not conflicting) from the newly created article into the existing one Which basically says if it is committable, we'll channel it in, > otherwise we won't. And we'll close after a month by pushing it off to > bugzilla. > > I'd like useful feedback on that. > And if things change, we change the above. It's not like we have to > guarantee anything. We just have to document what people can expect. > If others make it more automated or better than my efforts, great. We > document that when it comes along. > > Warner > _______________________________________________ > freebsd-git@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-git > To unsubscribe, send any mail to "freebsd-git-unsubscribe@freebsd.org" >