From owner-freebsd-net@freebsd.org Mon Sep 18 17:00:20 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57CA1E1EBBD for ; Mon, 18 Sep 2017 17:00:20 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F16B371A15; Mon, 18 Sep 2017 17:00:19 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-wm0-x22d.google.com with SMTP id r68so4521701wmg.3; Mon, 18 Sep 2017 10:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Htlm12XY8qQ+5IvZoqRfJ/G8bn515XRtk/vw10sAJlQ=; b=jE1NgtZBIsJT9VanSn7dVbHovjvnxSqsLNYSieEiJH0nDa67Fzd/NKfqjvUj0gZT5g NCrO3GDXv4cRhVe5OEpPBcIUkGOKD8GrE3RCrdjPKl9SS8W9rDtl5iM3Si7gNw49Zwoi hrKCo5M8838mZdqMmjfkpVpmVilYHXJJzmHmhpWUEWAKmH2tamgDZVsM5eGNco/TzNFI qXHvn0wnqu5jCaDtbmOT1URpjDeJCAlujK9ela3iZ1cnjXALCRg24l4zCiFYhA9Hu5jb jY6U8KXerjNlK2n+DZjkFWDBDEdZyVEP+BXyb1Jo0rm25aGKPGuo0mHeVtHeMdPyDnFo 1jZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Htlm12XY8qQ+5IvZoqRfJ/G8bn515XRtk/vw10sAJlQ=; b=tSccouEDTTkX9/v+XLzW+0PT4fsshpcA1auQcFNRqWwizJnQettiXCQXkq6w/MnAvm I+kEW3Ba2jbeleQQ5V/50A3xFpNupCvj4MzlPBiJzJqy0ZuaHdQDeYmQnpA+5btlmzZC jJy+R2yBSuYiSY4VuxdWGf7R25I9aUFjhiZ0CG1v9XV9kewmaiacYdJjrBo4Bv7u3h8Q DOhe9musWOAZ9yUXJKjJR/jHj6EzKqLBMZCh+aQJG4heTbf1ceFVCwRxQ3bqi7qJUr1J 4NTitEXwf/ukj6TIFbv3aFjWB+/xuoupx26tICJWmt5snwl8Sru/ykHt6zGxwsC/NaGI F+dQ== X-Gm-Message-State: AHPjjUikLTWKlpQIZXVnbNqTybCYbG7AOTPWSojIMdYhZ4EnUmb5/gA8 AOM30+GlktiOGzoXs+479YCN7dk37idvZnTvT6hSCw== X-Google-Smtp-Source: AOwi7QAy5P7qfz/yOm+dp/d+RsgKvnwE1cFESOYMKXiid/MziWUnfGIcygM/aRUNFryUcWcEoFI1BzSJA0tDnmz/yww= X-Received: by 10.28.45.5 with SMTP id t5mr8904649wmt.108.1505754017599; Mon, 18 Sep 2017 10:00:17 -0700 (PDT) MIME-Version: 1.0 Sender: adrian.chadd@gmail.com Received: by 10.28.56.71 with HTTP; Mon, 18 Sep 2017 10:00:16 -0700 (PDT) In-Reply-To: References: From: Adrian Chadd Date: Mon, 18 Sep 2017 10:00:16 -0700 X-Google-Sender-Auth: fRk9w9RcPyYnWI0tTD7rUKuk7M0 Message-ID: Subject: Re: ixl(4) RSS hash type To: Eric Joyner Cc: Sepherosa Ziehau , "freebsd-net@freebsd.org" , Sean Bruno , Robert Watson , Andrew Gallatin Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 17:00:20 -0000 hi! please do fix it. I'm way busy with life right now. :) -a On 11 September 2017 at 10:18, Eric Joyner wrote: > I think that sounds right; but Adrian is the one who put the code in the > #ifdef RSS blocks in. We don't have it enabled/defined in our testing here. > > - Eric > > On Sun, Sep 10, 2017 at 8:01 PM Sepherosa Ziehau > wrote: >> >> Hi all, >> >> I am on the way to cleanup the UDP_IPV4_EX bit. The only effective >> consumer of this undefined RSS hash type is ixl. >> >> So I took a bit close look at it, then I have several question about >> its hash type configuration: >> >> ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if >> RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 >> fragments: >> >> https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex >> >> ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag >> means "outer packet header indicates a fragment", which has nothing to >> do with the any of the IPV6_EX related bits: >> >> https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types >> >> I believe these all should be fixed. >> >> Thanks, >> sephe >> >> -- >> Tomorrow Will Never Die