From owner-freebsd-scsi@freebsd.org Sun Mar 19 09:37:52 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AFC1D08DA4 for ; Sun, 19 Mar 2017 09:37:52 +0000 (UTC) (envelope-from jasondqq@blackyun.net) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2B3D71501 for ; Sun, 19 Mar 2017 09:37:52 +0000 (UTC) (envelope-from jasondqq@blackyun.net) Received: by mailman.ysv.freebsd.org (Postfix) id 27AF6D08DA3; Sun, 19 Mar 2017 09:37:52 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27582D08DA2 for ; Sun, 19 Mar 2017 09:37:52 +0000 (UTC) (envelope-from jasondqq@blackyun.net) Received: from mx024.blackyun.net (mx024.blackyun.net [59.110.50.13]) by mx1.freebsd.org (Postfix) with ESMTP id D26711500 for ; Sun, 19 Mar 2017 09:37:51 +0000 (UTC) (envelope-from jasondqq@blackyun.net) Received: from mx024.blackyun.net (localhost [127.0.0.1]) by mx024.blackyun.net (Postfix) with ESMTPA id CBFC728554E for ; Fri, 17 Mar 2017 12:15:52 +0800 (CST) To: scsi@freebsd.org Subject: Re:Re Aluminum cases Message-ID: <0748ba3347c0b48b1bcf0d340be5a21a@mx024.blackyun.net> Date: Fri, 17 Mar 2017 09:25:06 +0800 From: "jasondqq" Reply-To: csorpkalu@126.com MIME-Version: 1.0 X-Mailer-LID: 110 X-Mailer-RecptId: 1213512 X-Mailer-SID: 92 X-Mailer-Sent-By: 5 Content-Type: text/plain; format=flowed; charset="UTF-8" Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Mar 2017 09:37:52 -0000 Hi, This is Jason from MSAC CO., LTD China. As an aluminum case factory our main products as below. 1, Custom Made Aluminum Cases 2, Aluminum Makeup Cases, beauty cases 3, Tool Storage Cases 4, Aluminum Carrying Boxes 5, Aluminum Transport Cases 6, Aluminum Attache Cases 7, Aluminum First Aid box MSAC will offer competitive price and good quality whom have been got REACH and ROSH report. Please be kindly email me back if you are interestd in our cases. Thanks ____________________________ Best Wishes Jason MSAC CO., LTD Email: jason {at} ms-aluminumcase {dot} com Tel: + 86 159 2039 5657 Skype: jason_du_qq Powered by Blackyun Email Marketer From owner-freebsd-scsi@freebsd.org Tue Mar 21 14:01:45 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 280C9D162BE for ; Tue, 21 Mar 2017 14:01:45 +0000 (UTC) (envelope-from jwd@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 094CE1950 for ; Tue, 21 Mar 2017 14:01:45 +0000 (UTC) (envelope-from jwd@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 821) id 515AC58D9; Tue, 21 Mar 2017 14:01:44 +0000 (UTC) Date: Tue, 21 Mar 2017 14:01:44 +0000 From: John To: FreeBSD-SCSI Subject: mpr driver allocating 1 irq? Message-ID: <20170321140144.GA25836@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 14:01:45 -0000 --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Folks, The following define is in sys/dev/mpr/mprvar.h: #define MPR_MSI_COUNT 1 Is there a particular reason it's hard-coded to 1 and not a tunable? if ((sc->disable_msix == 0) && ((msgs = pci_msix_count(dev)) >= MPR_MSI_COUNT)) error = mpr_alloc_msix(sc, MPR_MSI_COUNT); Or am I completely misreading the code? The code appears to support a value other than 1. Thanks, John with verbose=1: mpr0: attempting to allocate 1 MSI-X vectors (96 supported) mpr1: attempting to allocate 1 MSI-X vectors (96 supported) mpr2: attempting to allocate 1 MSI-X vectors (96 supported) mpr3: attempting to allocate 1 MSI-X vectors (96 supported) --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQF8BAEBCgBmBQJY0TJGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwNDBGOTgxNzM0NzQ3OEFBNDYyODNGQzVC NjI0OTlBMTQyNEY3RjgxAAoJELYkmaFCT3+BGt4H/Rfe4a3DxWXy4lK/4qqqk6I2 C9twuItNysmUrMeQxM2JY5+NKEU2BjUglx9yii9s/4qO6T9uPheJ8XTa+5w8gCFD F8WfX+EJWpo2t5+fG7ftaRRfs67Yw6SnHEhQLQxVgYRXutIbSuq+hLl63QLidsTo TZI5TZSR/r8MV86ZTbWOa2VY6bTLVjpoBm6EVeXLV7t+jECde1+OiPvmcEre58J7 +ssMn33UASN4p8t3OnKWzgDHGPpcp9xjnlTlaG3ZZmCjJT1NhcSR+f32h8I3zCA6 LmZSHPehiDZZ2kbo6BXRKGxL32cqyJNx1GAoqT9/7MBYT3eti7O3jdb7sw3YEjg= =xLtQ -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK-- From owner-freebsd-scsi@freebsd.org Tue Mar 21 16:06:14 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 074E0D169AA for ; Tue, 21 Mar 2017 16:06:14 +0000 (UTC) (envelope-from stephen.mcconnell@broadcom.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D1F3912E4 for ; Tue, 21 Mar 2017 16:06:13 +0000 (UTC) (envelope-from stephen.mcconnell@broadcom.com) Received: by mail-io0-x233.google.com with SMTP id b140so51325583iof.1 for ; Tue, 21 Mar 2017 09:06:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to; bh=g4FefZWalMGZH7h7YZVJAnACevNMUfQY2qWp2U2NR8M=; b=Y2nHpfR6Jp9pVmCNLpbLQ6wJBUJSBtQEu9doSbO8nVLPri0JRlwneZhLatKnKABKMF Jpenfds78sp3HjItzKpTNc/UI0pOvuobU8pVTH7SLzQXHL/MLHiUlapeg+izzgCbrm2Q U8nxhvoSJlXHd0TxkDaq78Dv5MWK4KKJIX0so= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to; bh=g4FefZWalMGZH7h7YZVJAnACevNMUfQY2qWp2U2NR8M=; b=GBb0grDW14e9pYHaLMnP5x76j0Jr5DMAsI2y2GBCJUwz29vSXQa/LlL9ANrON9xo6e pI42cXuDNIYNKzqBUCB4ShxWY8EzUpTnUx5bA3wf5zuS/2XRYIArierf8jOXxpLGh+Ms oyYEe7pbInJXT8Z9soTVLSv9SxQugOZWsfwJi/VUWtlpiYlbRFljW/aVcagjfEN3DvSp aXTocdwfUandlSajKhvGnMa0WgX8Es1bgnWjxEW+Huj5Uf2X293m5ZEu5D3T/lQ9gcas AvuPQgQpADof+pGlw3zyawkd32rsaUXnk79Qy8xzH9+evQwFaPPssE4iw+1/0Szethga Le4w== X-Gm-Message-State: AFeK/H26mrMZx/qFFWQxi6dIiowm8i8hcVUd/rm1e8fE1+T8WWbML7hU23020UFDg09gw5Xz13XmfZIpgIwU+YDa X-Received: by 10.107.170.12 with SMTP id t12mr32307231ioe.113.1490112373080; Tue, 21 Mar 2017 09:06:13 -0700 (PDT) From: Stephen Mcconnell References: <20170321140144.GA25836@FreeBSD.org> In-Reply-To: <20170321140144.GA25836@FreeBSD.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKzDrr2wDH3IFMOrbJdjTfza+PyUZ/emqdw Date: Tue, 21 Mar 2017 10:06:11 -0600 Message-ID: Subject: RE: mpr driver allocating 1 irq? To: John , FreeBSD-SCSI , scottl@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 16:06:14 -0000 I think the problem is that there is no improvement when using MSIx. scottl@ was working on a finer grained locking mechanism that would help. Maybe he can comment. Steve > -----Original Message----- > From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- > scsi@freebsd.org] On Behalf Of John > Sent: Tuesday, March 21, 2017 8:02 AM > To: FreeBSD-SCSI > Subject: mpr driver allocating 1 irq? > > Hi Folks, > > The following define is in sys/dev/mpr/mprvar.h: > > #define MPR_MSI_COUNT 1 > > Is there a particular reason it's hard-coded to 1 and not a tunable? > > if ((sc->disable_msix == 0) && > ((msgs = pci_msix_count(dev)) >= MPR_MSI_COUNT)) > error = mpr_alloc_msix(sc, MPR_MSI_COUNT); > > Or am I completely misreading the code? > > The code appears to support a value other than 1. > > Thanks, > John > > with verbose=1: > > mpr0: attempting to allocate 1 MSI-X vectors (96 supported) > mpr1: attempting to allocate 1 MSI-X vectors (96 supported) > mpr2: attempting to allocate 1 MSI-X vectors (96 supported) > mpr3: attempting to allocate 1 MSI-X vectors (96 supported) From owner-freebsd-scsi@freebsd.org Thu Mar 23 21:48:41 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BECFACA1440 for ; Thu, 23 Mar 2017 21:48:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ADDAD1906 for ; Thu, 23 Mar 2017 21:48:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v2NLmf6w076008 for ; Thu, 23 Mar 2017 21:48:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 218006] sys/dev/isci/scil/sati_util.c: PVS-Studio: V764: Possible incorrect order of arguments passed Date: Thu, 23 Mar 2017 21:48:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to short_desc keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 21:48:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218006 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-scsi@FreeBSD.org Summary|sys/dev/isci/scil/sati_util |sys/dev/isci/scil/sati_util |.c: PVS-Studio: V764 |.c: PVS-Studio: V764: | |Possible incorrect order of | |arguments passed Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.=