From owner-freebsd-scsi@freebsd.org Wed May 10 15:20:56 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 431C2D6611E for ; Wed, 10 May 2017 15:20:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 29442194E for ; Wed, 10 May 2017 15:20:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4AFKtT8023752 for ; Wed, 10 May 2017 15:20:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 218572] pass(4) driver sometimes does error recovery when CAM_PASS_ERR_RECOVER is not set Date: Wed, 10 May 2017 15:20:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ken@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 15:20:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218572 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: ken Date: Wed May 10 15:20:38 UTC 2017 New revision: 318139 URL: https://svnweb.freebsd.org/changeset/base/318139 Log: MFC r317775: Fix error recovery behavior in the pass(4) driver. After FreeBSD SVN revision 236814, the pass(4) driver changed from only doing error recovery when the CAM_PASS_ERR_RECOVER flag was set on a CCB to sometimes doing error recovery if the passed in retry count was non-zero. Error recovery would happen if two conditions were met: 1. The error recovery action was simply a retry. (Which is most cases.) 2. The retry_count is non-zero. (Which happened a lot because of cut-and-pasted code.) This explains a bug I noticed in with camcontrol: # camcontrol tur da34 -v Unit is ready # camcontrol reset da34 Reset of 1:172:0 was successful At this point, there should be a Unit Attention: # camcontrol tur da34 -v Unit is ready No Unit Attention. Try it again: # camcontrol reset da34 Reset of 1:172:0 was successful Now set the retry_count to 0 for the TUR: # camcontrol tur da34 -v -C 0 Unit is not ready (pass42:mps1:0:172:0): TEST UNIT READY. CDB: 00 00 00 00 00 00 (pass42:mps1:0:172:0): CAM status: SCSI Status Error (pass42:mps1:0:172:0): SCSI status: Check Condition (pass42:mps1:0:172:0): SCSI sense: UNIT ATTENTION asc:29,2 (SCSI bus re= set occurred) (pass42:mps1:0:172:0): Field Replaceable Unit: 2 There is the unit attention. camcontrol(8) has a default retry_count of 1, in case someone sets the -E flag without setting -C. The CAM_PASS_ERR_RECOVER behavior was only broken with the CAMIOCOMMAND ioctl, which is the synchronous pass(4) API. It has worked as intended (error recovery is only done when the flag is set) in the asynchronous API (CAMIOQUEUE ioctl). sys/cam/scsi/scsi_pass.c: In passsendccb(), when calling cam_periph_runccb(), only specify the error routine when CAM_PASS_ERR_RECOVER is set. share/man/man4/pass.4: Document that CAM_PASS_ERR_RECOVER is needed to enable error recovery. Reported by: Terry Kennedy PR: kern/218572 Sponsored by: Spectra Logic Changes: _U stable/11/ stable/11/share/man/man4/pass.4 stable/11/sys/cam/scsi/scsi_pass.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-scsi@freebsd.org Wed May 10 15:20:58 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20C3BD6612D for ; Wed, 10 May 2017 15:20:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 078EE1983 for ; Wed, 10 May 2017 15:20:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4AFKvHX025160 for ; Wed, 10 May 2017 15:20:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 218572] pass(4) driver sometimes does error recovery when CAM_PASS_ERR_RECOVER is not set Date: Wed, 10 May 2017 15:20:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ken@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 15:20:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218572 --- Comment #4 from commit-hook@freebsd.org --- A commit references this bug: Author: ken Date: Wed May 10 15:20:40 UTC 2017 New revision: 318140 URL: https://svnweb.freebsd.org/changeset/base/318140 Log: MFC r317775: Fix error recovery behavior in the pass(4) driver. After FreeBSD SVN revision 236814, the pass(4) driver changed from only doing error recovery when the CAM_PASS_ERR_RECOVER flag was set on a CCB to sometimes doing error recovery if the passed in retry count was non-zero. Error recovery would happen if two conditions were met: 1. The error recovery action was simply a retry. (Which is most cases.) 2. The retry_count is non-zero. (Which happened a lot because of cut-and-pasted code.) This explains a bug I noticed in with camcontrol: # camcontrol tur da34 -v Unit is ready # camcontrol reset da34 Reset of 1:172:0 was successful At this point, there should be a Unit Attention: # camcontrol tur da34 -v Unit is ready No Unit Attention. Try it again: # camcontrol reset da34 Reset of 1:172:0 was successful Now set the retry_count to 0 for the TUR: # camcontrol tur da34 -v -C 0 Unit is not ready (pass42:mps1:0:172:0): TEST UNIT READY. CDB: 00 00 00 00 00 00 (pass42:mps1:0:172:0): CAM status: SCSI Status Error (pass42:mps1:0:172:0): SCSI status: Check Condition (pass42:mps1:0:172:0): SCSI sense: UNIT ATTENTION asc:29,2 (SCSI bus re= set occurred) (pass42:mps1:0:172:0): Field Replaceable Unit: 2 There is the unit attention. camcontrol(8) has a default retry_count of 1, in case someone sets the -E flag without setting -C. The CAM_PASS_ERR_RECOVER behavior was only broken with the CAMIOCOMMAND ioctl, which is the synchronous pass(4) API. It has worked as intended (error recovery is only done when the flag is set) in the asynchronous API (CAMIOQUEUE ioctl). sys/cam/scsi/scsi_pass.c: In passsendccb(), when calling cam_periph_runccb(), only specify the error routine when CAM_PASS_ERR_RECOVER is set. share/man/man4/pass.4: Document that CAM_PASS_ERR_RECOVER is needed to enable error recovery. Reported by: Terry Kennedy PR: kern/218572 Sponsored by: Spectra Logic Changes: _U stable/10/ stable/10/share/man/man4/pass.4 stable/10/sys/cam/scsi/scsi_pass.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-scsi@freebsd.org Wed May 10 15:23:06 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 598B4D66238 for ; Wed, 10 May 2017 15:23:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48FB51CC9 for ; Wed, 10 May 2017 15:23:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4AFN5cn035236 for ; Wed, 10 May 2017 15:23:06 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 218572] pass(4) driver sometimes does error recovery when CAM_PASS_ERR_RECOVER is not set Date: Wed, 10 May 2017 15:23:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ken@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ken@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 15:23:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D218572 Kenneth D. Merry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|New |Closed --- Comment #5 from Kenneth D. Merry --- Fixed in head, stable/11 and stable 10. Thank you for the report! --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-scsi@freebsd.org Thu May 11 14:16:38 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9758BD680B8 for ; Thu, 11 May 2017 14:16:38 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4492710EB for ; Thu, 11 May 2017 14:16:38 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: by mail-wm0-x22f.google.com with SMTP id b84so42993349wmh.0 for ; Thu, 11 May 2017 07:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=F6ynulhQxJtIWKMuRpyG67wGHdA/rmB9umF/o/9CcjE=; b=OoyhoThU9nKWfO2VWRoYWLsDdjiqerfT8BScwmCpTk9cZsXD2ME4Q0tyREWPeu6LRb bryW4M0h1/qI4wUW8ZKRevi8wwojiLMHxhMHIrTSvn8XaSJ5dVeGLkyWa0IcptViDhDE tVU8y19xNLpG5X6E9stffs8DcCIRZdTOkxFAI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=F6ynulhQxJtIWKMuRpyG67wGHdA/rmB9umF/o/9CcjE=; b=RFeDkEwlQUhZXudkYh1E+yEWjemx5toCW5ZR4khUnw2Ct8po2ewpXuG+k1cbnqrsJl ov3CsN/NYqSvIfCICU8us1inNSf4k7sESWkL5nU9p4AtEjiqpGzEeno88nhL3PuuWyOS pf0pNsQDuYGSsgXQEWoyfPN4nal2krlWf2Fg1/C9DruNF/1K94xYpl2UNklvr54xtJe4 a5n7Gvdb+rvtGCRoe0BW5rWsj1J/7h+6soFhh/4WLPXbGhWRMIacnOrmDe+CekZez1QO 11cd1LoVkEgiE8n7MHcooGD9q49NENJMJW363t/gCEf5fgnYjm24YsfZ+tWXwc6sM7qB XEIA== X-Gm-Message-State: AODbwcBCpDMrYU8YFlOZ7fF9E311jxfgMZpWBkRbVxmZiKug0gYdC2R3 V/Vo0/ygofB3wVSYc2wY/Cb9ZNz6ygqaVWE= X-Received: by 10.25.233.68 with SMTP id g65mr186240lfh.161.1494512196109; Thu, 11 May 2017 07:16:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.80.70 with HTTP; Thu, 11 May 2017 07:16:35 -0700 (PDT) From: Ram Kishore Vegesna Date: Thu, 11 May 2017 19:46:35 +0530 Message-ID: Subject: Fiber channel driver for Broadcom/Emulex FC host bus adapters. To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 14:16:38 -0000 Hi all, We are planning to upstream/inbox our FreeBSD cam driver which supports Emulex FC host bus adapters (LPe16xx and LPe32xx family). Please provide me the inputs on process of up-streaming driver. If you can share any documents related to that will be of great help. Note: Please correct me if I am posting the request on wrong mailing list. If possible provide the maintainer contact. Thanks, Ram From owner-freebsd-scsi@freebsd.org Thu May 11 19:03:36 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE869D69389 for ; Thu, 11 May 2017 19:03:36 +0000 (UTC) (envelope-from ken@freebsd.org) Received: from mithlond.kdm.org (mithlond.kdm.org [96.89.93.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "A1-33714", Issuer "A1-33714" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A7FD19EC for ; Thu, 11 May 2017 19:03:36 +0000 (UTC) (envelope-from ken@freebsd.org) Received: from [10.0.0.27] (mbp2013-wired.int.kdm.org [10.0.0.27]) (authenticated bits=0) by mithlond.kdm.org (8.15.2/8.14.9) with ESMTPSA id v4BJ3RHu031858 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 11 May 2017 15:03:28 -0400 (EDT) (envelope-from ken@freebsd.org) From: Ken Merry Message-Id: <964F0DBF-DEEB-4CD8-844D-1099FF5AB383@freebsd.org> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Fiber channel driver for Broadcom/Emulex FC host bus adapters. Date: Thu, 11 May 2017 15:03:27 -0400 In-Reply-To: Cc: freebsd-scsi@freebsd.org To: Ram Kishore Vegesna References: X-Mailer: Apple Mail (2.3273) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mithlond.kdm.org [96.89.93.250]); Thu, 11 May 2017 15:03:28 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 May 2017 19:03:36 -0000 That is good news! It will be good to have the driver in the tree. As for how to get it into FreeBSD: 1. Make sure it is BSD-licsened. GPLed code isn=E2=80=99t allowed in = the kernel. Other licenses (MIT, CDDL) might be possible. Here is an = example license: = https://svnweb.freebsd.org/base/head/share/examples/etc/bsd-style-copyrigh= t?revision=3D180207&view=3Dmarkup = 2. Get a committer to review it. I can do that if you like. I may = still have some 16Gb boards from when I was reviewing the Emulex FC = driver in 2012. 3. Once you get past the review, you can either have the committer put = it in the tree, or wait until we get one or more Emulex developers = approved as committers. See #4. 4. Decide on one or more Emulex developers to maintain the driver as = FreeBSD committers. These should be people who are likely to stay on = the project for a while, so new folks don=E2=80=99t need to be brought = up to speed too often. The new committers will need one or more current = committers as mentors, and all commits will have to be approved until = the mentor is satisfied that the new committer is ready to go on their = own. The committers=E2=80=99 guide will give you an idea of what is = involved: https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ = The eventual goal will be to have one or more Emulex folks who are = committers and can maintain the driver in the FreeBSD tree. There are two FreeBSD committers (at least) from Broadcom, Steve = McConnell and Kashyap Desai. They work on the SAS and MegaRAID = products. As for timelines, we=E2=80=99re about to start the process for FreeBSD = 11.1. Depending on the state of the driver, it may be possible to get = it into 11.1, but it=E2=80=99s hard to say that with any certainty until = we see the driver. Ken =E2=80=94=20 Ken Merry ken@FreeBSD.ORG > On May 11, 2017, at 10:16 AM, Ram Kishore Vegesna via freebsd-scsi = wrote: >=20 > Hi all, >=20 > We are planning to upstream/inbox our FreeBSD cam driver which = supports > Emulex FC host bus adapters (LPe16xx and LPe32xx family). >=20 > Please provide me the inputs on process of up-streaming driver. If you = can > share any documents related to that will be of great help. >=20 > Note: Please correct me if I am posting the request on wrong mailing = list. > If possible provide the maintainer contact. >=20 > Thanks, > Ram > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to = "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@freebsd.org Fri May 12 06:09:36 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D1E5D69B51 for ; Fri, 12 May 2017 06:09:36 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FA8B124C for ; Fri, 12 May 2017 06:09:36 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: by mail-wr0-x22e.google.com with SMTP id l50so36637054wrc.3 for ; Thu, 11 May 2017 23:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zI3DjAYSEC0m9SRcQvo5lAEgqzLTcCpScMxIBsGU8rQ=; b=Ow2Qxa18PvNx3Nc+8w3PFktWAHfi+Gb069+P/+TiTiduZDI4wsqgFGw+IH4I137pdL LP4aup821E+HOv1lIy8y1DkBejOFLbYwCX3t/aXA/C5IqY9L0pW2nHqtHGu8OzaVGpb2 EdMswRmD4Zw08hnAclC95/br+WgVsBU5qqzbI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zI3DjAYSEC0m9SRcQvo5lAEgqzLTcCpScMxIBsGU8rQ=; b=ui43OQ2hZHCkD5xgdH7p3D5YhvX+6tYU23YNQ/b09uImXoHKc6l1E0NSwf6xYAYgoC ZaYvzrL0GysNcGPPKTXCfUEPgeAYs7toqZtMPK2XbVgmr42fpfMxzzCvmm6w5qJWWauG MzoYMq0egguJ8v47INGtSjJgCssIg6q1yyyk+rhG5Qo4ObbpWkiuKCUi8/jbAt28gCq1 rNg9aJocsNnUCgrUuknpjmJrYT4tlitrZR3ZihfCu4hCsBwWc1Wr0nLBwOgAH0qbIcxx y/n4XdfpR/+U4sRNKThZ4bIHjOtRR5J+LbcAh8YR0so4wS4/kKlDNHPTHkjNUWpMMOLH 9OZw== X-Gm-Message-State: AODbwcCzviteJDgY4uBVXex7nRsJh73vyHHgbpnOY9NM/GI0SFKHPizG RRI8Tiwx6oYzI/phLCzYTG5zbJ9DHCCK X-Received: by 10.46.21.15 with SMTP id s15mr535232ljd.50.1494569374275; Thu, 11 May 2017 23:09:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.46.80.70 with HTTP; Thu, 11 May 2017 23:09:33 -0700 (PDT) In-Reply-To: <964F0DBF-DEEB-4CD8-844D-1099FF5AB383@freebsd.org> References: <964F0DBF-DEEB-4CD8-844D-1099FF5AB383@freebsd.org> From: Ram Kishore Vegesna Date: Fri, 12 May 2017 11:39:33 +0530 Message-ID: Subject: Re: Fiber channel driver for Broadcom/Emulex FC host bus adapters. To: Ken Merry Cc: freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 06:09:36 -0000 Hi Ken, Thanks for the quick response. I am working on restructuring the driver code which will be good for integrating into FreeBSD. Will post the driver for review once its done. -Ram On Fri, May 12, 2017 at 12:33 AM, Ken Merry wrote: > That is good news! It will be good to have the driver in the tree. > > As for how to get it into FreeBSD: > > 1. Make sure it is BSD-licsened. GPLed code isn=E2=80=99t allowed in the= kernel. > Other licenses (MIT, CDDL) might be possible. Here is an example license= : > > https://svnweb.freebsd.org/base/head/share/examples/etc/ > bsd-style-copyright?revision=3D180207&view=3Dmarkup > > 2. Get a committer to review it. I can do that if you like. I may still > have some 16Gb boards from when I was reviewing the Emulex FC driver in > 2012. > > 3. Once you get past the review, you can either have the committer put it > in the tree, or wait until we get one or more Emulex developers approved = as > committers. See #4. > > 4. Decide on one or more Emulex developers to maintain the driver as > FreeBSD committers. These should be people who are likely to stay on the > project for a while, so new folks don=E2=80=99t need to be brought up to = speed too > often. The new committers will need one or more current committers as > mentors, and all commits will have to be approved until the mentor is > satisfied that the new committer is ready to go on their own. The > committers=E2=80=99 guide will give you an idea of what is involved: > > https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ > > The eventual goal will be to have one or more Emulex folks who are > committers and can maintain the driver in the FreeBSD tree. > > There are two FreeBSD committers (at least) from Broadcom, Steve McConnel= l > and Kashyap Desai. They work on the SAS and MegaRAID products. > > As for timelines, we=E2=80=99re about to start the process for FreeBSD 11= .1. > Depending on the state of the driver, it may be possible to get it into > 11.1, but it=E2=80=99s hard to say that with any certainty until we see t= he driver. > > Ken > =E2=80=94 > Ken Merry > ken@FreeBSD.ORG > > > > On May 11, 2017, at 10:16 AM, Ram Kishore Vegesna via freebsd-scsi < > freebsd-scsi@freebsd.org> wrote: > > Hi all, > > We are planning to upstream/inbox our FreeBSD cam driver which supports > Emulex FC host bus adapters (LPe16xx and LPe32xx family). > > Please provide me the inputs on process of up-streaming driver. If you ca= n > share any documents related to that will be of great help. > > Note: Please correct me if I am posting the request on wrong mailing list= . > If possible provide the maintainer contact. > > Thanks, > Ram > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" > > > From owner-freebsd-scsi@freebsd.org Fri May 12 15:09:10 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E617D69A9C for ; Fri, 12 May 2017 15:09:10 +0000 (UTC) (envelope-from scottl@netflix.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5569519D2 for ; Fri, 12 May 2017 15:09:10 +0000 (UTC) (envelope-from scottl@netflix.com) Received: by mail-io0-x231.google.com with SMTP id p24so41885323ioi.0 for ; Fri, 12 May 2017 08:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RY9te9bIy/rkNRFRTDR9va6thT9RM1myNI2/tX3+SNI=; b=RclqvWD6cleoN81fuP974v5U666Ej1ekI5zC3o+ta5iykFNSvEInZ2yukrDJ5w7UT9 Ks+2IQBGKXMkaTeDuvrUiAkI0b8igeNpxsXuY7YajdxwU/rGeoF8cnCtn1OjSM8+AoLn oASoE2Gc+Vj5ud9I6PJG9KE4gIj3g3D0hOg2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=RY9te9bIy/rkNRFRTDR9va6thT9RM1myNI2/tX3+SNI=; b=kJAempdQeB69eLzRw5i3Lm0j45BH+8/Jyhi4UfreNqmb6nnrMJdwbk6fvM3xp6sCjm /8slhK+7ww+ov8EjmWRelxyrLo0QdcUpeCkLAxQfU210Qzcg2ztzY1b3k0tXPHp9BGgH 7hLXpxKP4F4uHXyT2XbZh8t3Ew6IhP+5GCNhRY/wsIjE/36Xjhg/oV0nLhR2x6JMlGmV iibT1HO9FCQsd9okThhVrAUobj/rFoipezYKkdHCGwF+fFdZrMIycrtkRJ6+5ZdNPwJl MkYhGo4A8gxQ6eeq9/QWMKqQLuttopjMhoOQxlXibVdSvPXywQw/8+3ZOaVFgRLliYGX +j6Q== X-Gm-Message-State: AODbwcDAHpG55nkdo92iHI1A2AWZmUdGg0KLD5TPoELYbgi5v+I+Q+8z 8F4mwEAKHGtw+Ig8 X-Received: by 10.107.20.13 with SMTP id 13mr4405726iou.185.1494601749578; Fri, 12 May 2017 08:09:09 -0700 (PDT) Received: from [192.168.0.119] ([161.97.210.12]) by smtp.gmail.com with ESMTPSA id u200sm1687769itb.29.2017.05.12.08.09.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 May 2017 08:09:09 -0700 (PDT) From: Scott Long X-Google-Original-From: Scott Long Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Fiber channel driver for Broadcom/Emulex FC host bus adapters. In-Reply-To: Date: Fri, 12 May 2017 09:09:08 -0600 Cc: Ken Merry , freebsd-scsi@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <50900206-D63B-4A66-8E3D-51BF77CA520B@yahoo.com> References: <964F0DBF-DEEB-4CD8-844D-1099FF5AB383@freebsd.org> To: Ram Kishore Vegesna X-Mailer: Apple Mail (2.3273) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 15:09:10 -0000 Hi Ram, Great to hear. Might I suggest that you post the code for review via = the Phabricator system? Instructions for doing this are here: https://wiki.freebsd.org/Phabricator Thanks, Scott > On May 12, 2017, at 12:09 AM, Ram Kishore Vegesna via freebsd-scsi = wrote: >=20 > Hi Ken, >=20 > Thanks for the quick response. >=20 > I am working on restructuring the driver code which will be good for > integrating into FreeBSD. Will post the driver for review once its = done. >=20 > -Ram >=20 >=20 >=20 > On Fri, May 12, 2017 at 12:33 AM, Ken Merry wrote: >=20 >> That is good news! It will be good to have the driver in the tree. >>=20 >> As for how to get it into FreeBSD: >>=20 >> 1. Make sure it is BSD-licsened. GPLed code isn=E2=80=99t allowed in = the kernel. >> Other licenses (MIT, CDDL) might be possible. Here is an example = license: >>=20 >> https://svnweb.freebsd.org/base/head/share/examples/etc/ >> bsd-style-copyright?revision=3D180207&view=3Dmarkup >>=20 >> 2. Get a committer to review it. I can do that if you like. I may = still >> have some 16Gb boards from when I was reviewing the Emulex FC driver = in >> 2012. >>=20 >> 3. Once you get past the review, you can either have the committer = put it >> in the tree, or wait until we get one or more Emulex developers = approved as >> committers. See #4. >>=20 >> 4. Decide on one or more Emulex developers to maintain the driver as >> FreeBSD committers. These should be people who are likely to stay on = the >> project for a while, so new folks don=E2=80=99t need to be brought up = to speed too >> often. The new committers will need one or more current committers = as >> mentors, and all commits will have to be approved until the mentor is >> satisfied that the new committer is ready to go on their own. The >> committers=E2=80=99 guide will give you an idea of what is involved: >>=20 >> = https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ >>=20 >> The eventual goal will be to have one or more Emulex folks who are >> committers and can maintain the driver in the FreeBSD tree. >>=20 >> There are two FreeBSD committers (at least) from Broadcom, Steve = McConnell >> and Kashyap Desai. They work on the SAS and MegaRAID products. >>=20 >> As for timelines, we=E2=80=99re about to start the process for = FreeBSD 11.1. >> Depending on the state of the driver, it may be possible to get it = into >> 11.1, but it=E2=80=99s hard to say that with any certainty until we = see the driver. >>=20 >> Ken >> =E2=80=94 >> Ken Merry >> ken@FreeBSD.ORG >>=20 >>=20 >>=20 >> On May 11, 2017, at 10:16 AM, Ram Kishore Vegesna via freebsd-scsi < >> freebsd-scsi@freebsd.org> wrote: >>=20 >> Hi all, >>=20 >> We are planning to upstream/inbox our FreeBSD cam driver which = supports >> Emulex FC host bus adapters (LPe16xx and LPe32xx family). >>=20 >> Please provide me the inputs on process of up-streaming driver. If = you can >> share any documents related to that will be of great help. >>=20 >> Note: Please correct me if I am posting the request on wrong mailing = list. >> If possible provide the maintainer contact. >>=20 >> Thanks, >> Ram >> _______________________________________________ >> freebsd-scsi@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> To unsubscribe, send any mail to = "freebsd-scsi-unsubscribe@freebsd.org" >>=20 >>=20 >>=20 > _______________________________________________ > freebsd-scsi@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > To unsubscribe, send any mail to = "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@freebsd.org Fri May 12 17:26:17 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C710D69D35 for ; Fri, 12 May 2017 17:26:17 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: from mail-lf0-x231.google.com (mail-lf0-x231.google.com [IPv6:2a00:1450:4010:c07::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 866F16BD for ; Fri, 12 May 2017 17:26:16 +0000 (UTC) (envelope-from ram.vegesna@broadcom.com) Received: by mail-lf0-x231.google.com with SMTP id j1so4848833lfh.2 for ; Fri, 12 May 2017 10:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=azlojfEa/XIemsW+UcjKvwscnU0x32Rg+6nowZ39nqA=; b=JGaTpSsiE9bkny03E7cGtWLCmVaU6zSoqXYkQxcabYnpK3CnjwpSCvOg4G2VWRe5V6 mb8Gjzi43IjML4/7mA2frGv2jwIGuO3bDRoi3ImMn685wvlaOm0hQK5sK0ChLGrsb0kv 1M7WZKrIbMXVLJyUM98RHdoS/MzpXldjn3YO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=azlojfEa/XIemsW+UcjKvwscnU0x32Rg+6nowZ39nqA=; b=JCfRGSaqmjRfJw85eLQBTdUSwmEGOvvayGAStaYN1Ij/9RIEGyCr5DUBvvBSpZ+Xtg 7S9bjxwEMRne91fIWIKkZaqo8vT8iTpdgcce6aXvjZaIa0NNmg35qYuA/kjTj/3Jwhjs xtfDdnGFdfqoJq1xrsG1XeE9ya2vGqPcnADnXevzbiogd9RrX5R8d0oVDOavXrbMjLZS CDUYnSTSjV0WieFcKls7t+OieQp9RuSzkepj90IPAYm5lMxE7esCoEcJFwkhMC345CgQ dQRqCzNhO9uTXflo06g+lxWI6DKB1vSwBLfeMsrvX+jY+wkzUgIdLgPAcEmcJdwKqxgV u8lw== X-Gm-Message-State: AODbwcClNORcjyv3chwS/k0SG2bInP4eNtuBlHZ1/jG3XMAZ6HtCagWe /QZlx8K7U6StCZMiQvfPbtETY5Gx/oCY X-Received: by 10.25.16.161 with SMTP id 33mr1594319lfq.3.1494609973992; Fri, 12 May 2017 10:26:13 -0700 (PDT) MIME-Version: 1.0 References: <964F0DBF-DEEB-4CD8-844D-1099FF5AB383@freebsd.org> <50900206-D63B-4A66-8E3D-51BF77CA520B@yahoo.com> In-Reply-To: <50900206-D63B-4A66-8E3D-51BF77CA520B@yahoo.com> From: Ram Kishore Vegesna Date: Fri, 12 May 2017 17:26:03 +0000 Message-ID: Subject: Re: Fiber channel driver for Broadcom/Emulex FC host bus adapters. To: Scott Long Cc: Ken Merry , freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 May 2017 17:26:17 -0000 Thanks Scott, will post the code via the Phabricator system. On Fri, 12 May 2017 at 8:39 PM, Scott Long wrote: > Hi Ram, > > Great to hear. Might I suggest that you post the code for review via the > Phabricator system? Instructions > for doing this are here: > > https://wiki.freebsd.org/Phabricator > > Thanks, > Scott > > > On May 12, 2017, at 12:09 AM, Ram Kishore Vegesna via freebsd-scsi < > freebsd-scsi@freebsd.org> wrote: > > > > Hi Ken, > > > > Thanks for the quick response. > > > > I am working on restructuring the driver code which will be good for > > integrating into FreeBSD. Will post the driver for review once its done= . > > > > -Ram > > > > > > > > On Fri, May 12, 2017 at 12:33 AM, Ken Merry wrote: > > > >> That is good news! It will be good to have the driver in the tree. > >> > >> As for how to get it into FreeBSD: > >> > >> 1. Make sure it is BSD-licsened. GPLed code isn=E2=80=99t allowed in = the > kernel. > >> Other licenses (MIT, CDDL) might be possible. Here is an example > license: > >> > >> https://svnweb.freebsd.org/base/head/share/examples/etc/ > >> bsd-style-copyright?revision=3D180207&view=3Dmarkup > >> > >> 2. Get a committer to review it. I can do that if you like. I may > still > >> have some 16Gb boards from when I was reviewing the Emulex FC driver i= n > >> 2012. > >> > >> 3. Once you get past the review, you can either have the committer put > it > >> in the tree, or wait until we get one or more Emulex developers > approved as > >> committers. See #4. > >> > >> 4. Decide on one or more Emulex developers to maintain the driver as > >> FreeBSD committers. These should be people who are likely to stay on > the > >> project for a while, so new folks don=E2=80=99t need to be brought up = to speed > too > >> often. The new committers will need one or more current committers as > >> mentors, and all commits will have to be approved until the mentor is > >> satisfied that the new committer is ready to go on their own. The > >> committers=E2=80=99 guide will give you an idea of what is involved: > >> > >> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ > >> > >> The eventual goal will be to have one or more Emulex folks who are > >> committers and can maintain the driver in the FreeBSD tree. > >> > >> There are two FreeBSD committers (at least) from Broadcom, Steve > McConnell > >> and Kashyap Desai. They work on the SAS and MegaRAID products. > >> > >> As for timelines, we=E2=80=99re about to start the process for FreeBSD= 11.1. > >> Depending on the state of the driver, it may be possible to get it int= o > >> 11.1, but it=E2=80=99s hard to say that with any certainty until we se= e the > driver. > >> > >> Ken > >> =E2=80=94 > >> Ken Merry > >> ken@FreeBSD.ORG > >> > >> > >> > >> On May 11, 2017, at 10:16 AM, Ram Kishore Vegesna via freebsd-scsi < > >> freebsd-scsi@freebsd.org> wrote: > >> > >> Hi all, > >> > >> We are planning to upstream/inbox our FreeBSD cam driver which support= s > >> Emulex FC host bus adapters (LPe16xx and LPe32xx family). > >> > >> Please provide me the inputs on process of up-streaming driver. If you > can > >> share any documents related to that will be of great help. > >> > >> Note: Please correct me if I am posting the request on wrong mailing > list. > >> If possible provide the maintainer contact. > >> > >> Thanks, > >> Ram > >> _______________________________________________ > >> freebsd-scsi@freebsd.org mailing list > >> https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > >> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org= " > >> > >> > >> > > _______________________________________________ > > freebsd-scsi@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi > > To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" > >