From owner-freebsd-scsi@freebsd.org Mon Sep 11 22:40:49 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B34FCE043A7 for ; Mon, 11 Sep 2017 22:40:49 +0000 (UTC) (envelope-from cgull@glup.org) Received: from glup.org (e6.glup.org [IPv6:2001:470:8bf0:1::3]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8B9DA76537; Mon, 11 Sep 2017 22:40:49 +0000 (UTC) (envelope-from cgull@glup.org) Received: from lister.boston.niksun.com (unknown [IPv6:2001:470:8bf0:2::1000]) by glup.org (Postfix) with ESMTPSA id 4D4C4854DE; Mon, 11 Sep 2017 18:40:39 -0400 (EDT) Authentication-Results: glup.org; dmarc=none header.from=glup.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=glup.org; s=201009; t=1505169639; bh=At/iJ6OXIngdWjHzdTTaYAtT7PYZF8u7l6cQI9U5rIg=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=kV7qLj127hGZlRXLPuTXCAyNCNwsOlfybkO/6lW4Sz6xSYVEqSfjo1tx+B//FqtK1 nsfzk3cCFKcOq+2KLlFSa0vx1ZpYZWUI+5szF8VmKn7mczAjKiRd5KKge5Xc8sf1Up 5/YoyeCWvQVTbkVKyT7rIt/Xhg2cjeN11bo9Dsp7Wc99wBAxqw40sVLFNfi1Q911Bx 9DQ9BK5uVpHVGhTLpfTZHplKidTdukmFektrzR71LUJp9itbrmZ/4I8SRqBCO6at6d ERG7CKRAk+sAa72OyFN+HyfWFRBbMr0xsL9MBLrzi79neEAi2tmkka3ipIJ77w5u1W lgXb2RAhvOH7g== Subject: Re: GEOM probes fail on aac with EARLY_AP_STARTUP To: Scott Long Cc: freebsd-scsi@freebsd.org, jhb@freebsd.org, jkim@freebsd.org References: From: John Hood Message-ID: <4e5b5b44-5880-59be-3411-eb2e81a9e6a5@glup.org> Date: Mon, 11 Sep 2017 18:40:39 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 22:40:49 -0000 To follow up now that you've committed my fix, and more for amr and the LSI drivers:  I compiled a kernel at r323459 and rebooted it on my system about five times, all the boots succeeded. Thanks!  (also for the fixes to other drivers, which are more likely to be meaningful for us) regards,   --jh From owner-freebsd-scsi@freebsd.org Mon Sep 11 22:45:27 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E603E048BE for ; Mon, 11 Sep 2017 22:45:27 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3DB6176889; Mon, 11 Sep 2017 22:45:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6FC3720C6D; Mon, 11 Sep 2017 18:45:25 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Mon, 11 Sep 2017 18:45:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=tnC8AUIvDsh4JoTz1J A1K4i4ya5e+CwrSS0wc2+SS1A=; b=HDlAUn6+U/wELA88KmWOrkkyAh3W9X9e8U SncYRhTnybYuqDFgR/T6VO3DUkM2pSy3eltSWwA9wPJjPAoFE0pMFGvBdGsnrrpz jKnt8MHx9GCgXdjfQcqhkACtHahsPhieg482rEUyHDA7sCGW8c2eh0InEgHYis2f jamq7dk2dlmasWJd4QQKD4U6BHMVDaYeL3A7c+sx59lbXv4MICGJnYgJdbUK+TeI JVolWktPh3OGwpldSwN4eO2+hvltUkQVa6oKMmN/zua4BTtTdErWLA0YOHQojdH8 cHHUn09QHQWKOGh0QFZarlXoxFtmku/efPA5zxMym9cm+EJmTGFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=tnC8AUIvDsh4JoTz1JA1K4i4ya5e+CwrSS0wc2+SS1A=; b=opW8Xl0N EmkSFjFmfKQjPjaTaizTAemg24wkRslGRzjOLYGvRmaKiqGppl5/j/ZHh5/uTX2d 1Ts148rujAGuJBEPWWipd7j1IInYUYFImt/OAQm+Gx1FwijmjD2SeP5ghUg6kxv+ QpPJJP83yo97AYanejr8jLBsjSIFK7l7XNhCI0slle4FCYGdnBfT7l0qa6zrQL7r LwhyhXqjJFeFxxuodhKELJeSwo+O/Eg/Xi1eiYs1/o1d8JSO0tmJtIgTbCjhUN98 0wrpKY4GEVF61wcP0Aox3PGSxMWF7vExhiDeVl0BQPcSNhk8DN+2opJPmj71c8Hv fJei7CViXEpRyw== X-ME-Sender: X-Sasl-enc: 0xj5p8rEGCUvHwHgB7aVziwiPo62OatA6NqnFkkQxpJf 1505169925 Received: from [192.168.0.117] (unknown [161.97.249.191]) by mail.messagingengine.com (Postfix) with ESMTPA id EA87A7E22F; Mon, 11 Sep 2017 18:45:24 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: GEOM probes fail on aac with EARLY_AP_STARTUP From: Scott Long In-Reply-To: <4e5b5b44-5880-59be-3411-eb2e81a9e6a5@glup.org> Date: Mon, 11 Sep 2017 16:45:22 -0600 Cc: freebsd-scsi@freebsd.org, jhb@freebsd.org, jkim@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <4e5b5b44-5880-59be-3411-eb2e81a9e6a5@glup.org> To: John Hood X-Mailer: Apple Mail (2.3273) X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 22:45:27 -0000 Thanks again for the great analysis and solution. Scott > On Sep 11, 2017, at 4:40 PM, John Hood wrote: >=20 > To follow up now that you've committed my fix, and more for amr and = the LSI drivers: I compiled a kernel at r323459 and rebooted it on my = system about five times, all the boots succeeded. Thanks! (also for the = fixes to other drivers, which are more likely to be meaningful for us) >=20 > regards, >=20 > --jh >=20 >=20 From owner-freebsd-scsi@freebsd.org Mon Sep 11 23:52:45 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDA1FE0841E for ; Mon, 11 Sep 2017 23:52:45 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B77357CB86 for ; Mon, 11 Sep 2017 23:52:45 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-io0-x233.google.com with SMTP id y123so36841123iod.0 for ; Mon, 11 Sep 2017 16:52:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7mTleEpXNo2xcWkagGw5NCfKoi04aAiKQYt0bufK+Iw=; b=qMy/Np5G6T7NVS2mBs1HXtDyFpD1Q1Qk0E6aIUOK2Bve5SRDj6ORl9iABKzTnhrS7P Nsx9rDj5cGrpufCk06fCiyxzhlkhfoXBZ+mmSLcnnS0t6MoNkcRuWOi16q5T6dBhNNOq ks13yOhXTlESD3/w9PGZSEDvwsur8bsImzj3I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7mTleEpXNo2xcWkagGw5NCfKoi04aAiKQYt0bufK+Iw=; b=Fp9CqM4NIHPbhUgho5vfoxkaCejV1z2K8544PlJut6zjt2G3OopbZRLsecAsAZmglA pmmUZub3/mVzmZR6/GvnD81Ur7tbEo5Wp0LQR2vbSD0BPyknfBj4ScKD+97BoIx++HMK aBRaKx5yJEgG5edVUul+utHelwXFGHKxWP2Q0VP0gMCMznTR41Bk2oljUkxBAoqqmG8c k37pIViS32tkPjH14yhmIjipBnKwgO70PTfRYPAd1ML2FmD6Qjxs+60B3ZRJz44Hmr0q f0PyxMBqsw9jg6awG0I3SQsvrIElg73sL0Wq17pzvLE2gnAgRkkpVfRJ/EUoMw3F8haD ZQbg== X-Gm-Message-State: AHPjjUgxWS7JluIb9/8IgcdBO5tTd8JM6zaS0GQSH29ON6JDB6ZkYufX mvmrFlV2rBSSzMJXaFZmuGRGLKYg3B/n X-Google-Smtp-Source: AOwi7QDzRlxozFzMRrSwc6SyIpXhWU3AGckroo8/OLETbri8uW25nhePmiWno20eCKuqjCLhfErcW4TQ3NzfXuC7sYY= X-Received: by 10.202.79.206 with SMTP id d197mr14526632oib.192.1505173965102; Mon, 11 Sep 2017 16:52:45 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.57.200 with HTTP; Mon, 11 Sep 2017 16:52:44 -0700 (PDT) In-Reply-To: <63b26ecc55d5f7a3152af6c26aba18a2@mail.gmail.com> References: <1112cc2edb666ce7fa9c72c11cdd284c@nitrology.com> <63b26ecc55d5f7a3152af6c26aba18a2@mail.gmail.com> From: Kevin Bowling Date: Mon, 11 Sep 2017 16:52:44 -0700 Message-ID: Subject: Re: Disk reordering on LSI SAS2008/mps(4) To: Stephen Mcconnell Cc: FreeBSD-scsi , John Baldwin Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 23:52:46 -0000 https://svnweb.freebsd.org/base?view=revision&revision=323384 fixed it for us On Mon, Aug 28, 2017 at 8:08 AM, Stephen Mcconnell wrote: > I'm assuming that the dubug_level is in hex, right? If it is than the run > where debug_level is 0x583 should be showing some Mapping debug output, > but I don't see any. Do you have mapping enabled in the controller? You > can see the mapping flags in IOC Page 8 in the Flags field. Do you have a > way to look at the controller pages? You'd need either lsiutil or maybe > mpsutil will work (Scott Long wrote mpsutil and I don't know anything > about it). > > If you don't have mapping enabled, you won't be guaranteed that the > devices will be discovered in the same order over a controller reset or > reboot. > > Steve > >> -----Original Message----- >> From: owner-freebsd-scsi@freebsd.org [mailto:owner-freebsd- >> scsi@freebsd.org] On Behalf Of Kevin Bowling >> Sent: Sunday, August 27, 2017 8:51 PM >> To: FreeBSD-scsi >> Cc: John Baldwin >> Subject: Re: Disk reordering on LSI SAS2008/mps(4) >> >> Note that we only see this bug with EARLY_AP_STARTUP enabled >> >> Regards, >> >> On Fri, Aug 25, 2017 at 2:11 PM, Jason Wolfe wrote: >> >> > Attachments are useful. >> > >> > >> > On 2017-08-25 13:58, Jason Wolfe wrote: >> > >> >> Hi! >> >> >> >> We've been having an issue where we see some disk reordering on boot >> >> on HEAD from mid July on LSI controllers, maybe 5% of the time. We >> >> brought mps current as of r322364 with no change behavior. >> >> >> >> I have a few logs attached with various debug output. In all cases >> >> I've seen the pass ordering to be proper, and cam does try to resolve >> >> the da ordering, but the device it tries to reassign to is already >> >> taken. Attached is the full output, and listing some relevant bits >> >> below for the casual reader. Being that the functionality in >> >> scsi_da.c has been fairly static, and it's attempting to reassign, it >> >> seems more likely we are running into something in mps here. The >> >> targets always look to be proper. >> >> >> >> The various settings of hw.mps.use_phy_num (-1/0/1) don't change the >> >> behavior, and neither does hw.mps.enable_ssu=0. We have machines over >> >> various FW versions (15/16) that see the issue. I'm wondering if the >> >> fact that we see this issue over soft reboots means that the firmware >> >> isn't coming into play. To confirm, we are booting from the >> >> controller, so the LSI BIOS is enabled. >> >> >> >> mps0@pci0:3:0:0: class=0x010700 card=0x040015d9 > chip=0x00721000 >> >> rev=0x03 hdr=0x00 >> >> vendor = 'LSI Logic / Symbios Logic' >> >> device = 'SAS2008 PCI-Express Fusion-MPT SAS-2 [Falcon]' >> >> class = mass storage >> >> subclass = SAS >> >> >> >> reorder-verbose.txt: >> >> boot_verbose="YES" >> >> hw.mps.debug_level="71" >> >> >> >> da0 at mps0 bus 0 scbus0 target 17 lun 0 >> >> cam_periph_alloc: attempt to re-allocate valid device da0 rejected >> >> flags 0x102 refcount 4 >> >> da1 at mps0 bus 0 scbus0 target 8 lun 0 >> >> daasync: Unable to attach to new device due to status 0x6 >> >> da2 at mps0 bus 0 scbus0 target 9 lun 0 ... >> >> da8 at mps0 bus 0 scbus0 target 15 lun 0 >> >> da9 at mps0 bus 0 scbus0 target 16 lun 0 >> >> da10 at mps0 bus 0 scbus0 target 18 lun 0 >> >> da11 at mps0 bus 0 scbus0 target 19 lun 0 >> >> >> >> pass0 at mps0 bus 0 scbus0 target 8 lun 0 >> >> pass1 at mps0 bus 0 scbus0 target 9 lun 0 ... >> >> pass9 at mps0 bus 0 scbus0 target 17 lun 0 >> >> pass10 at mps0 bus 0 scbus0 target 18 lun 0 >> >> pass11 at mps0 bus 0 scbus0 target 19 lun 0 >> >> >> >> >> >> >> >> >> >> reorder-mps-mapping.txt: >> >> hw.mps.debug_level="583" >> >> >> >> da0 at mps0 bus 0 scbus0 target 19 lun 0 >> >> da1 at mps0 bus 0 scbus0 target 8 lun 0 >> >> da2 at mps0 bus 0 scbus0 target 9 lun 0 >> >> ... >> >> da9 at mps0 bus 0 scbus0 target 16 lun 0 >> >> da10 at mps0 bus 0 scbus0 target 17 lun 0 >> >> da11 at mps0 bus 0 scbus0 target 18 lun 0 >> >> cam_periph_alloc: attempt to re-allocate valid device da0 rejected >> >> flags 0x106 refcount 6 >> >> daasync: Unable to attach to new device due to status 0x6 >> >> >> >> ses0: da1,pass0: Element descriptor: 'Slot 01' >> >> ses0: da1,pass0: SAS Device Slot Element: 1 Phys at Slot 0 >> >> ses0: da0,pass11: Element descriptor: 'Slot 12' >> >> ses0: da0,pass11: SAS Device Slot Element: 1 Phys at Slot 11 >> >> >> >> >> >> Luckily we have found a way to fairly easily repro it over a few >> >> hours, so we are open to any suggestions. >> >> >> >> Thanks! >> >> Jason >> > >> > >> > _______________________________________________ >> > freebsd-scsi@freebsd.org mailing list >> > https://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> > To unsubscribe, send any mail to > "freebsd-scsi-unsubscribe@freebsd.org" >> > >> _______________________________________________ >> freebsd-scsi@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-scsi >> To unsubscribe, send any mail to "freebsd-scsi-unsubscribe@freebsd.org" From owner-freebsd-scsi@freebsd.org Tue Sep 12 14:21:52 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18A06E0BD80; Tue, 12 Sep 2017 14:21:52 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 2BE6973B45; Tue, 12 Sep 2017 14:21:47 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id RAA13294; Tue, 12 Sep 2017 17:21:46 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1drm4Q-000Nyp-9w; Tue, 12 Sep 2017 17:21:46 +0300 Subject: Re: "unspoilable" geom labels To: Warner Losh Cc: freebsd-geom@FreeBSD.org, freebsd-scsi@FreeBSD.org References: <648bcd86-5ef8-b58e-ed04-48880f867fc0@FreeBSD.org> From: Andriy Gapon Message-ID: Date: Tue, 12 Sep 2017 17:20:50 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 14:21:52 -0000 On 12/09/2017 16:28, Warner Losh wrote: > The CAM code expects to be able to map the name 'da0' to 'pass14' so it can send > the passthrough devices. It has no clue about device names, apart from passXXX > it has to open to send the commands for the thing named 'da0'. In fact, it has > no clue at all about the upper layers at all. I would argue that it would be > quite difficult, given the current state of geom, to properly guess. It > shouldn't even try. Bad things can only come from accidentally guessing wrong. I mean that maybe it's not exactly the job of a function like cam_get_device(), maybe it's a job if its callers (like camcontrol), but at the very least we could check if /dev/$name is a symlink and resolve it. I assume that the valid device names always corresponding devices entries under /dev. And, yes, mapping a GEOM label to an original name is harder than it should be with the current implementation. Maybe it would be easier with labels implemented as aliases. > Instead, if you really want this functionality, we should create either an ioctl > to get this information (perhaps in a list for the case of gmirror, but perhaps > not) or a bio attribute that could be synthesized properly. The third vehicle > for this would be to put the attribute in the config for geom, but that's a bit > of a pain. I agree. Maybe such a method would be a good thing to have regardless of the labels implementation. > Then again, you can't easily map an entry from /dev into a device_t that > implements it (if any). You can't map a cam device, even, to a device_t either, > just as far as the SIM if you look hard enough. I think that this is a little bit different issue. I think that getting from e.g. /dev/diskid/DISK-MK0351YVKNNX3A to e.g. /dev/ada77 should be sufficient for most userland utilities. -- Andriy Gapon From owner-freebsd-scsi@freebsd.org Tue Sep 12 23:47:20 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C46D8E256A3 for ; Tue, 12 Sep 2017 23:47:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B2D5469705 for ; Tue, 12 Sep 2017 23:47:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8CNlJN4012947 for ; Tue, 12 Sep 2017 23:47:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 221953] cam iosched: Limit the quanta default to hz if it's below 200 Date: Tue, 12 Sep 2017 23:47:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 23:47:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221953 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: imp Date: Tue Sep 12 23:46:33 UTC 2017 New revision: 323511 URL: https://svnweb.freebsd.org/changeset/base/323511 Log: cam iosched: Limit the quanta default to hz if it's below 200 The cam_iosched_ticker() can't be scheduled more than once per tick. Some limiters depend on quanta matching the number of calls per second to enforce the proper limits. Limit the quanta to no faster than 1 per clock tick. This fixes some features when running in VMs where the default HZ is 100. PR: 221953 Obtained from: ElectroBSD Differential Revision: https://reviews.freebsd.org/D12337 Submitted by: Fabian Keil Changes: head/sys/cam/cam_iosched.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-scsi@freebsd.org Thu Sep 14 05:51:14 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8861AE01687 for ; Thu, 14 Sep 2017 05:51:14 +0000 (UTC) (envelope-from sthaug@nethelp.no) Received: from bizet.nethelp.no (bizet.nethelp.no [IPv6:2001:8c0:9e04:500::1]) by mx1.freebsd.org (Postfix) with ESMTP id 4D64465D7A; Thu, 14 Sep 2017 05:51:13 +0000 (UTC) (envelope-from sthaug@nethelp.no) Received: from localhost (bizet.nethelp.no [IPv6:2001:8c0:9e04:500::1]) by bizet.nethelp.no (Postfix) with ESMTP id 4732DE6077; Thu, 14 Sep 2017 07:51:12 +0200 (CEST) Date: Thu, 14 Sep 2017 07:51:12 +0200 (CEST) Message-Id: <20170914.075112.74745398.sthaug@nethelp.no> To: scottl@samsco.org Cc: cgull@glup.org, freebsd-scsi@freebsd.org, jhb@freebsd.org Subject: Re: GEOM probes fail on aac with EARLY_AP_STARTUP From: sthaug@nethelp.no In-Reply-To: <0D188193-4562-483A-B123-6117CC65AF01@samsco.org> References: <20170908.151504.74703639.sthaug@nethelp.no> <0c73b27e-d4ac-4003-81df-b2d9a0a63a81@glup.org> <0D188193-4562-483A-B123-6117CC65AF01@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 05:51:14 -0000 > > Your issue isn't obviously directly related to mine. mps is a CAM driver > > and aac is not (at least not for normal block volumes), which makes disk > > probe/attach quite different. I also don't see an obvious driver flag > > like the one in aac. > > > > It's a different pattern in CAM, and CAM itself looks to be safe. MPS and MPR > have their own intrhooks, and on review just now I see a potential for a similar > problem to what you saw and that would match Steinar's symptoms. Please > try the following patch: I have applied the patch and verified that my 11.1 server boots nicely with this patch. However, my original problem turned out to have a different cause (config error on my part), and thus I cannot verify that this patch actually *fixes* a problem. Steinar Haug, Nethelp consulting, sthaug@nethelp.no From owner-freebsd-scsi@freebsd.org Thu Sep 14 08:39:17 2017 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C673DE0847C for ; Thu, 14 Sep 2017 08:39:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B47AC6A98F for ; Thu, 14 Sep 2017 08:39:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8E8dHux027963 for ; Thu, 14 Sep 2017 08:39:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-scsi@FreeBSD.org Subject: [Bug 221953] cam iosched: Limit the quanta default to hz if it's below 200 Date: Thu, 14 Sep 2017 08:39:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-scsi@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 08:39:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221953 Fabian Keil changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|New |Closed --=20 You are receiving this mail because: You are the assignee for the bug.=