From owner-freebsd-testing@freebsd.org Sun Sep 24 07:16:09 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DCE9E211F2 for ; Sun, 24 Sep 2017 07:16:09 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gate2.funkthat.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3801A6C9C8 for ; Sun, 24 Sep 2017 07:16:05 +0000 (UTC) (envelope-from jmg@gold.funkthat.com) Received: from gold.funkthat.com (localhost [127.0.0.1]) by gold.funkthat.com (8.15.2/8.15.2) with ESMTPS id v8O757EU021304 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sun, 24 Sep 2017 00:05:07 -0700 (PDT) (envelope-from jmg@gold.funkthat.com) Received: (from jmg@localhost) by gold.funkthat.com (8.15.2/8.15.2/Submit) id v8O757gA021303 for freebsd-testing@freebsd.org; Sun, 24 Sep 2017 00:05:07 -0700 (PDT) (envelope-from jmg) Date: Sun, 24 Sep 2017 00:05:07 -0700 From: John-Mark Gurney To: freebsd-testing@freebsd.org Subject: suggestion library for mocking C functions Message-ID: <20170924070506.GQ64616@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: FreeBSD 11.0-RELEASE-p7 amd64 X-PGP-Fingerprint: D87A 235F FB71 1F3F 55B7 ED9B D5FF 5A51 C0AC 3D65 X-Files: The truth is out there X-URL: https://www.funkthat.com/ X-Resume: https://www.funkthat.com/~jmg/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (gold.funkthat.com [127.0.0.1]); Sun, 24 Sep 2017 00:05:07 -0700 (PDT) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Sep 2017 07:16:09 -0000 Is there a recommended/supported library for mocking C functions? I want to write some test cases for functions that call other code in the same compilation unit that I want to be able to mock. There are a few out there, but was wondering if anyone has suggestions? Thanks. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not." From owner-freebsd-testing@freebsd.org Sun Sep 24 16:22:31 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64D66E2AF26 for ; Sun, 24 Sep 2017 16:22:31 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-wr0-x22e.google.com (mail-wr0-x22e.google.com [IPv6:2a00:1450:400c:c0c::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EE1DD7E2D8 for ; Sun, 24 Sep 2017 16:22:30 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-wr0-x22e.google.com with SMTP id g29so4182540wrg.11 for ; Sun, 24 Sep 2017 09:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=wEkU7AEHDBE4/x79tAEZgPT143Hk2HHhFje5CIMMttQ=; b=bmEj/DRoCFdUgwMnEGXFqVVKT3ZwVQsAL70mcHJ2kQHXjZ5NnKMxVKAO3nG1PVdVvu DOf0P1AYjs0zYntsRffpuhVogpaRyB8oksmSjzFR79B4GvRhn7GwgLpyeoSV75zatUxH DrwUadcwcnPyZ39zB1lvbKrlZKDyPwbU2C5hkQyK0K4/OLzy2j0YtI+po6T8yPp33+6v t+tqF3mtkPZqASF2jD+IRLfcOF0wa4F12HwXvmtdqgeZcI2oPQYqwR8uTpiA4aDu+O54 juIPwJjceEDuwuLcQLNdXqaaBnEdOTjKlEtwaxgzaBTuOXrDjYL0B82NMIz6LM5Mxkrr 8FqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=wEkU7AEHDBE4/x79tAEZgPT143Hk2HHhFje5CIMMttQ=; b=ml7bL0fSDRWOGboiqd6/GqcdPzuUpbtp6gRdJdnYmqYYD+ASWxpcLANm1/1yn+RuKH JhFGTeRvvztj3E8fBHqPiNkZYNN/qbw0ptln4TKh9MNOHsezx9AhZ/Nczo911cyq+qAf lW4Hf2AHpVnQwXTJ6nphgHp1mpsLpUHhAZb7qPVhss/VsCni0VyfpUrWg87rqRgNqiVd 09WtP6Kcpl6d568m/ZpeHrKdrm10iWiUVV5y+rnJ8IRxsVJkeRUy7vMjNzRwqLQ2Xt1v zKJgJ+HOcso/lYMK7vnIh1Jf3DA9+wIbBkoPtt4qMcovBmOJVe7EaiWUVHphhcAooPX2 +hjA== X-Gm-Message-State: AHPjjUhjBYHy07gPwGesZdPA2KHnNOebZJFacgx0uD/a+KIQI/DQCb2E NIMtiiK2XZQjOlyDl0a2KR0ZEk8ATBIhuwrGypmcZA== X-Google-Smtp-Source: AOwi7QBFqdnxEdJY4UcWJm81rML/FjwaqFhrACJGUGShMiS71UC7HgzUk2fd1sd14q1OYWSWGJlx0bjC6MhquvOgQ3w= X-Received: by 10.46.88.22 with SMTP id m22mr1914603ljb.15.1506270148991; Sun, 24 Sep 2017 09:22:28 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.26.6 with HTTP; Sun, 24 Sep 2017 09:22:28 -0700 (PDT) In-Reply-To: <20170924070506.GQ64616@funkthat.com> References: <20170924070506.GQ64616@funkthat.com> From: Alan Somers Date: Sun, 24 Sep 2017 10:22:28 -0600 X-Google-Sender-Auth: 8bYhsZyTNTKdl-TOiGBIrkHGmDA Message-ID: Subject: Re: suggestion library for mocking C functions To: John-Mark Gurney Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Sep 2017 16:22:31 -0000 On Sun, Sep 24, 2017 at 1:05 AM, John-Mark Gurney wrote: > Is there a recommended/supported library for mocking C functions? > > I want to write some test cases for functions that call other code > in the same compilation unit that I want to be able to mock. > > There are a few out there, but was wondering if anyone has suggestions? > > Thanks. > > -- > John-Mark Gurney Voice: +1 415 225 5579 There is no good C mocking library. The language simply doesn't provide a good way to do it. CMockery is the best I've seen. However, it's got some big limitations because it relies on the linker to swap out function implementations. Your other option is to use a C++ mocking library. It's usually possible to build your application as C, but build the tests as C++. However, you'll still need to make a few modifications to the application source to be able to mock functions. You can probably hide it all in the preprocessor. If you go this route, I recommend googletest, which nowadays includes mocking functionality too. https://github.com/google/cmockery https://github.com/google/googletest -Alan From owner-freebsd-testing@freebsd.org Mon Sep 25 20:20:07 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FD31E23341 for ; Mon, 25 Sep 2017 20:20:07 +0000 (UTC) (envelope-from jollyrogue@dangertoaster.com) Received: from relay-direct1.mxroute.com (unknown [IPv6:2001:19f0:6401:3ef:5400:ff:fe78:2734]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49D786735F for ; Mon, 25 Sep 2017 20:20:07 +0000 (UTC) (envelope-from jollyrogue@dangertoaster.com) Received: from filter001.mxroute.com (filter001.mxroute.com [45.32.201.234]) by relay-direct1.mxroute.com (Postfix) with ESMTP id 4D5783EC04 for ; Mon, 25 Sep 2017 20:20:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by filter001.mxroute.com (Postfix) with ESMTP id 252BF41183 for ; Mon, 25 Sep 2017 20:20:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at filter001.mxroute.com Received: from filter001.mxroute.com ([127.0.0.1]) by localhost (filter001.mxroute.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aBpdey7r-MBm for ; Mon, 25 Sep 2017 20:20:03 +0000 (UTC) Received: from ocean.mxroute.com (ocean-ptr.mxroute.com [107.155.71.150]) by filter001.mxroute.com (Postfix) with ESMTPS id C26CB4147D for ; Mon, 25 Sep 2017 20:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dangertoaster.com; s=default; h=To:Date:Message-Id:Subject:Mime-Version: Content-Transfer-Encoding:Content-Type:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=G5d5vclQXPFj/sFJB2SHdf6hbSkDTEUgPN/sDyLOVIA=; b=iL/7qxjHyV7cm2bB0ixnQsbgFB VVa4MrW4M2LzMKEAfP2LRkgKIDyvsoroTocHdKRoBSuDoFIPc8iFBqa0KjoSvio8xpbVPbO0UAMcF 8hJ1su2L8DUmUbpuCxfvoIbb7UzHXxCSJSfIESRtvd4sKZIdX4iwoYuVeyXyaFdSCEb8HP0ZFAhni lq7Ibk8a4f3c00kIfbyrA3UFKfhLIackXTOaSS89fsW9Y1hyKuFByNBQzBzM1m8BdBt8d6Tyn/LiV 9OGEEfmV3EHFuiNGduZbxQZYESsAFBgqgdHmIFzfczn24iwd+Dq8zR+BtwLt3hPIFZqF5X0StxplB x2LUntig==; From: Ryan Quinn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Joining the Testing Team Message-Id: <3FF4070D-7174-4943-A1CB-BED910B4BB25@dangertoaster.com> Date: Mon, 25 Sep 2017 15:20:01 -0500 To: freebsd-testing@freebsd.org X-Mailer: Apple Mail (2.3273) X-AuthUser: jollyrogue@dangertoaster.com X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 20:20:07 -0000 Hello, I=E2=80=99m interested in joining the FreeBSD Testing team. I=E2=80=99ve = been reading over the TestSuite Wiki, but I=E2=80=99m not sure where to = start. How can I get started? Ryan From owner-freebsd-testing@freebsd.org Mon Sep 25 20:40:21 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55A10E23C62 for ; Mon, 25 Sep 2017 20:40:21 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD211684B9 for ; Mon, 25 Sep 2017 20:40:20 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-wr0-x230.google.com with SMTP id w12so9971351wrc.7 for ; Mon, 25 Sep 2017 13:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=WoUPLSjr58aoVjXDvvsRE6148JfgADq7QOQ/rk5LQsM=; b=S3muENbmsrpfw4xBojGKXID0EOuAEBE3w8+k8340mR4fXUxXwvZso5UV/W7QU3N30Z mPTwWMt4ldx6/9jc90zqMJC4i4PYFXqxn4G74RC1u+I0B1qK2iNzaZY/PkiovrMhJZWK QYmXcNjJls1BvBblPQYlHmy4qacIc39bCsLHvsT+5Fyq8xuL0eNnQcs+v1JJeUWf6nrJ ScfYykeqXUaLs7+koQ6inNRQF4YBh19vPa9dPUsLMbBt5ujKgZE+vAkZA3o8miUc2dDZ WSaLWAELEQ2r6IELtvpbIQGJo0MdiEq0dSDIROdwrSGwlwadTPaWjMy36jzHZ6ltwEgd D9iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=WoUPLSjr58aoVjXDvvsRE6148JfgADq7QOQ/rk5LQsM=; b=PRbCM57bffUZVsPpa1P4/NyK0j/1cVnUjpWBDBHooawa5m1kb6XlwcE/Vb0FJuzIzN kIB6dsjsn5OB7YxG/FAARVp6Irr/HEBuThukCcKWBaRmqB9hz6RjMdb6xykg89gcylLm X7JxCMRGpkirKQ65UnD3sS2k5qCEo/admmrqvGuw8ZcV2MS58fDomNDgHpjsQZA5y+a/ I1Ew3o3EMwzltrF35AgKXQ4M8B9aytvJZ8idpapjQsOKvNLN/ZAjZuDAmM8Wy2NGRdAY V5Ig2uIcqgo4BZmaeHltdcKJq8Kx4l1/tz9TT+AhBVjY09z4CPHk27VGdnp5hnRbGbuT ChpA== X-Gm-Message-State: AHPjjUiMCRObf+eUXdzdokkq3cLfAPmHnlPU2h/IgeKnCKF2nyyl4EVP njHJkk0Kj0B20X4SvkM+ZJppLcBUybmm/Z6kV9yqEg== X-Google-Smtp-Source: AOwi7QBppNoKOBGTDg0icw7YSilLDh4yapHpv9SkpG7LjRfhuKpGj9t4Z73pcWkqmHnBHjjsUaNQwW2LlMNhIjYcCVc= X-Received: by 10.25.23.95 with SMTP id n92mr2606793lfi.95.1506372018815; Mon, 25 Sep 2017 13:40:18 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.26.38 with HTTP; Mon, 25 Sep 2017 13:40:17 -0700 (PDT) In-Reply-To: <3FF4070D-7174-4943-A1CB-BED910B4BB25@dangertoaster.com> References: <3FF4070D-7174-4943-A1CB-BED910B4BB25@dangertoaster.com> From: Alan Somers Date: Mon, 25 Sep 2017 14:40:17 -0600 X-Google-Sender-Auth: Rq6HmH3Yn9yUqB6QWPdqzZeH8NQ Message-ID: Subject: Re: Joining the Testing Team To: Ryan Quinn Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 20:40:21 -0000 Wherever you like! One thing to do would be to watch Jenkins and fix failing or intermittent tests. Another would be to write more tests. Of our ~670 builtin utilities, only ~85 have any tests at all. We could always use more coverage. Speaking of coverage, ngie@ is working on integrating a coverage checker for the test suite. Ask her for details if that interests you. We're glad for help, whatever you choose to work on. https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4448/testReport/ -Alan On Mon, Sep 25, 2017 at 2:20 PM, Ryan Quinn wrote: > Hello, > > I=E2=80=99m interested in joining the FreeBSD Testing team. I=E2=80=99ve = been reading over the TestSuite Wiki, but I=E2=80=99m not sure where to sta= rt. > > How can I get started? > > Ryan > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org= " From owner-freebsd-testing@freebsd.org Tue Sep 26 09:03:30 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41F43E03CFD for ; Tue, 26 Sep 2017 09:03:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E2B08186B for ; Tue, 26 Sep 2017 09:03:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v8Q93T9q010884 for ; Tue, 26 Sep 2017 09:03:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-testing@freebsd.org Subject: [Bug 205446] tools/regression/lib/msun/test-ctrig.t fails on i386, but not on amd64 Date: Tue, 26 Sep 2017 09:03:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: tests X-Bugzilla-Version: 10.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-testing@freebsd.org X-Bugzilla-Flags: mfc-stable9- mfc-stable10- mfc-stable11+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 09:03:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205446 --- Comment #11 from commit-hook@freebsd.org --- A commit references this bug: Author: dim Date: Tue Sep 26 09:02:00 UTC 2017 New revision: 324006 URL: https://svnweb.freebsd.org/changeset/base/324006 Log: Synchronize most of libm with head as of r323004. This excludes a few arch-specific updates for powerpcspe, mips and riscv, for which support has not been merged yet. Bump __FreeBSD_version for the addition of cacoshl, cacosl, casinhl, casinl, catanl, catanhl, sincos, sincosf, and sincosl. MFC r305382 (by bde): Add asm versions of fmod(), fmodf() and fmodl() on amd64. Add asm versions of fmodf() amd fmodl() on i387. fmod is similar to remainder, and the C versions are 3 to 9 times slower than the asm versions on x86 for both, but we had the strange mixture of all 6 variants of remainder in asm and only 1 of 6 variants of fmod in asm. MFC r305384 (by bde): Disconnect the "optimized" asm variants of cos(), sin() and tan() from the build on i386. Leave them in the source tree for regression tests. The asm functions were always much less accurate (by a factor of more than 10**18 in the worst case). They were faster on old CPUs. But with each new generation of CPUs they get relatively slower. The double precision C version's average advantage is about a factor of 2 on Haswell. The asm functions were already intentionally avoided in float and long double precision on i386 and in all precisions on amd64. Float precision and amd64 give larger advantages to the C version. The long double precision C code and compilers' understanding of long double precision are not so good, so the i387 is still slightly faster for long double precision, except for the unimportant subcase of huge args where the sub-optimal C code now somehow beats the i387 by about a factor of 2. MFC r305385 (by bde): Oops, the previous i386 version of e_fmodf.S and e_fmodl.S was actually the amd64 version. MFC r306409 (by emaste): libm: fix some unused variable (rcsid) and dangling else warnings s_{fabs,fmax,logb,scalb}{,f,l}.c may be built elsewhere with a higher WARNS setting. Reviewed by: ed Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D8061 MFC r306410 (by emaste): libm: simplify i387 subdir logic with make's :S substitution MFC r306527 (by emaste): libm: remove unused variables for LDBL_MANT_DIG !=3D 113 Sponsored by: The FreeBSD Foundation MFC r306709 (by emaste): libm: remove unused variables Sponsored by: The FreeBSD Foundation MFC r307066 (by br): Don't use fmaxl/fminl on platforms with no long double support, use fmax/fmin instead. This fixes fmaxmin test failure on MIPS64. Reviewed by: emaste Sponsored by: DARPA, AFRL Sponsored by: HEIF5 Differential Revision: https://reviews.freebsd.org/D8216 MFC r308172 (by emaste): libm: add braces around initialization of subobjects This cleans up a warning when building libm at higher WARNS levels and makes the intent more clear. By the C standard the values are assigned to subobject members in order so this change introduces no functional change. (6.7.9 20) Reviewed by: kib Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D8333 MFC r313761 (by mmokhi): Add casinl() cacosl() catanl() casinhl() cacoshl() catanhl() APIs to ms= un to improve C11 conformance. PR: 216850 216851 216852 216856 216857 216858 Submitted by: mmokhi Reported by: sgk@troutmask.apl.washington.edu Reviewed by: bde, mat, theraven Approved by: bde (src committer), mat (mentor) Differential Revision: https://reviews.freebsd.org/D9491 MFC r313863 (by mmokhi): Fix building of r313761 on platforms that `long double` is alias of `double` (MIPS, etc) PR: 216850 216851 216852 216856 216857 216858 Reported by: emsate Reviewed by: bde emaste hselasky Approved by: bde emaste hselasky Differential Revision: https://reviews.freebsd.org/D9491 MFC r313864 (by mmokhi): Add documentations related to new APIs of r313761 PR: 216850 216851 216852 216856 216857 216858 Submitted by: sgk@troutmask.apl.washington.edu Reported by: sgk@troutmask.apl.washington.edu Reviewed by: bde emaste hselasky Approved by: bde emaste hselasky Differential Revision: https://reviews.freebsd.org/D9491 MFC r314950 (by ngie): Don't expect :test_large_inputs to fail with i386 anymore Recent changes (maybe a side-effect of the ATF-ification in r314649) invalidate the failure expectation. PR: 205446 Sponsored by: Dell EMC Isilon MFC r317349 (by pfg): msun: Remove trailing space in Sunsoft copyright statement. Submittedby: kargl MFC r319047 (by mmel): Implement sincos, sincosf, and sincosl. The primary benefit of these functions is that argument reduction is done once instead of twice in independent calls to sin() and cos(). * lib/msun/Makefile: . Add s_sincos[fl].c to the build. . Add sincos.3 documentation. . Add appropriate MLINKS. * lib/msun/Symbol.map: . Expose sincos[fl] symbols in dynamic libm.so. * lib/msun/man/sincos.3: . Documentation for sincos[fl]. * lib/msun/src/k_sincos.h: . Kernel for sincos() function. This merges the individual kernels for sin() and cos(). The merger offered an opportunity to re-arran= ge the individual kernels for better performance. * lib/msun/src/k_sincosf.h: . Kernel for sincosf() function. This merges the individual kernels for sinf() and cosf(). The merger offered an opportunity to re-arr= ange the individual kernels for better performance. * lib/msun/src/k_sincosl.h: . Kernel for sincosl() function. This merges the individual kernels for sinl() and cosl(). The merger offered an opportunity to re-arr= ange the individual kernels for better performance. * lib/msun/src/math.h: . Add prototytpes for sincos[fl](). * lib/msun/src/math_private.h: . Add RETURNV macros. This is needed to reset fpsetprec on I386 hardware for a function with type void. * lib/msun/src/s_sincos.c: . Implementation of sincos() where sin() and cos() were merged into one routine and possibly re-arranged for better performance. * lib/msun/src/s_sincosf.c: . Implementation of sincosf() where sinf() and cosf() were merged into one routine and possibly re-arranged for better performance. * lib/msun/src/s_sincosl.c: . Implementation of sincosl() where sinl() and cosl() were merged into one routine and possibly re-arranged for better performance. PR: 215977, 218300 Submitted by: Steven G. Kargl Differential Revision: https://reviews.freebsd.org/D10765 MFC r321457 (by ngie): Mark :reduction as an expected failure It fails with clang 5.0+. PR: 220989 Reported by: Jenkins MFC r322418 (by rlibby): lib/msun: avoid referring to broken LDBL_MAX LDBL_MAX is broken on i386: =20=20=20 https://lists.freebsd.org/pipermail/freebsd-numerics/2012-September/000288.= html Gcc has produced +Infinity for LDBL_MAX on i386 and amd64 with -m32 for some time, and newer versions of gcc are now warning that the "floating constant exceeds range of 'long double'". Avoid this by referring to half the value of LDBL_MAX instead. Reviewed by: bde Approved by: markj (mentor) Sponsored by: Dell EMC Isilon MFC r322435 (by rlibby): Revert r322418, LDBL_MAX_EXP unsuitable for macro pasting on some arches Either need a different way to spell HALF_LDBL_MAX, or a different way to spell LDBL_MAX_EXP, or a different approach. Reported by: ian MFC r322921 (by ngie): Revert r321457 It doesn't fail after ^/head@r322855 (the releng_50 clang merge). PR: 220989 Changes: _U stable/11/ stable/11/lib/msun/Makefile stable/11/lib/msun/Symbol.map stable/11/lib/msun/amd64/Makefile.inc stable/11/lib/msun/amd64/e_fmod.S stable/11/lib/msun/amd64/e_fmodf.S stable/11/lib/msun/amd64/e_fmodl.S stable/11/lib/msun/i387/Makefile.inc stable/11/lib/msun/i387/e_fmodf.S stable/11/lib/msun/i387/e_fmodl.S stable/11/lib/msun/ld80/e_lgammal_r.c stable/11/lib/msun/ld80/k_expl.h stable/11/lib/msun/ld80/s_logl.c stable/11/lib/msun/man/cacos.3 stable/11/lib/msun/man/sincos.3 stable/11/lib/msun/src/catrig.c stable/11/lib/msun/src/catrigl.c stable/11/lib/msun/src/e_asin.c stable/11/lib/msun/src/e_coshl.c stable/11/lib/msun/src/e_lgammaf_r.c stable/11/lib/msun/src/e_sinhl.c stable/11/lib/msun/src/k_sincos.h stable/11/lib/msun/src/k_sincosf.h stable/11/lib/msun/src/k_sincosl.h stable/11/lib/msun/src/math.h stable/11/lib/msun/src/math_private.h stable/11/lib/msun/src/s_fabs.c stable/11/lib/msun/src/s_fmax.c stable/11/lib/msun/src/s_fmin.c stable/11/lib/msun/src/s_logbl.c stable/11/lib/msun/src/s_scalbn.c stable/11/lib/msun/src/s_scalbnf.c stable/11/lib/msun/src/s_scalbnl.c stable/11/lib/msun/src/s_sincos.c stable/11/lib/msun/src/s_sincosf.c stable/11/lib/msun/src/s_sincosl.c stable/11/lib/msun/src/s_tanhl.c stable/11/lib/msun/tests/ctrig_test.c stable/11/sys/sys/param.h --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-testing@freebsd.org Wed Sep 27 15:51:39 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE419E07BB4 for ; Wed, 27 Sep 2017 15:51:39 +0000 (UTC) (envelope-from jollyrogue@dangertoaster.com) Received: from nov-007-i543.relay.mailchannels.net (nov-007-i543.relay.mailchannels.net [46.232.183.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 519E77C7A3; Wed, 27 Sep 2017 15:51:36 +0000 (UTC) (envelope-from jollyrogue@dangertoaster.com) X-Sender-Id: mxroute|x-authuser|jollyrogue@dangertoaster.com Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E05E57CAF0C; Wed, 27 Sep 2017 15:51:26 +0000 (UTC) Received: from relay007.localdomain (unknown [100.96.140.210]) (Authenticated sender: mxroute) by relay.mailchannels.net (Postfix) with ESMTPA id 5AB337C94E9; Wed, 27 Sep 2017 15:51:26 +0000 (UTC) X-Sender-Id: mxroute|x-authuser|jollyrogue@dangertoaster.com Received: from relay007.localdomain (relay007.mxroute.com [172.20.72.20]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.9.14); Wed, 27 Sep 2017 15:51:26 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: mxroute|x-authuser|jollyrogue@dangertoaster.com X-MailChannels-Auth-Id: mxroute X-Vacuous-Illegal: 4ea83c5212210014_1506527486673_1593989293 X-MC-Loop-Signature: 1506527486673:2939724307 X-MC-Ingress-Time: 1506527486673 Received: from ocean.mxroute.com (ocean-ptr.mxroute.com [107.155.71.150]) by relay007.localdomain (Postfix) with ESMTPS id 6CC5F40339; Wed, 27 Sep 2017 15:51:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dangertoaster.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PkWzGrmo18nHkMKrmfLi5NbJSFAR8aFNi+pPs255EvI=; b=iICCOhaMSdDaL6sknnU3MVq/Hg ptRNyApo/bpYBMxp09voPXFqIUSObXteMDolqgr1VcmO36l4Pi3FVqCsSNOApzwT5ME7kRHA6HlQT /atHw488APB6gKhNna6ebEamPiB0UjYDLbAU2DyxBnz3YnYMSmJV7C+98efhgkOqxA8OiCMm9JS/z EmhyHSn78EH9Es8GmfQ19Cmyigw6m60nliit68ttXKfzTjFzzcAUmOrGQdB9w8z4XC9dXZ8P2a053 PbaksZdRDe0TDXT6lbmoTwhg1QEIcc+yO9T61Y/OynOMAqbGljxeJrl0zHZC9cQzh92MVfC25I0A1 uNw4CTDg==; Subject: Re: Joining the Testing Team To: Alan Somers Cc: "freebsd-testing@freebsd.org" References: <3FF4070D-7174-4943-A1CB-BED910B4BB25@dangertoaster.com> From: Ryan Quinn Message-ID: <25bd8f5d-9ad7-66e8-e7a7-1e9fc4ea65b5@dangertoaster.com> Date: Wed, 27 Sep 2017 10:51:24 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-AuthUser: jollyrogue@dangertoaster.com Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 15:51:39 -0000 Excellent. Thank you! I might be interested in working on a coverage checker. I'll get in=20 touch with Ngie. Is there a ticket tracker? Ryan On 09/25/2017 03:40 PM, Alan Somers wrote: > Wherever you like! One thing to do would be to watch Jenkins and fix > failing or intermittent tests. Another would be to write more tests. > Of our ~670 builtin utilities, only ~85 have any tests at all. We > could always use more coverage. Speaking of coverage, ngie@ is > working on integrating a coverage checker for the test suite. Ask her > for details if that interests you. We're glad for help, whatever you > choose to work on. > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4448/testReport/ > > -Alan > > On Mon, Sep 25, 2017 at 2:20 PM, Ryan Quinn > wrote: >> Hello, >> >> I=E2=80=99m interested in joining the FreeBSD Testing team. I=E2=80=99= ve been reading over the TestSuite Wiki, but I=E2=80=99m not sure where t= o start. >> >> How can I get started? >> >> Ryan >> _______________________________________________ >> freebsd-testing@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-testing >> To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.= org" From owner-freebsd-testing@freebsd.org Wed Sep 27 15:56:26 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF66AE07E25 for ; Wed, 27 Sep 2017 15:56:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-wr0-x22f.google.com (mail-wr0-x22f.google.com [IPv6:2a00:1450:400c:c0c::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6227E7CC72 for ; Wed, 27 Sep 2017 15:56:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-wr0-x22f.google.com with SMTP id h16so3088580wrf.6 for ; Wed, 27 Sep 2017 08:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=Xl9n5iWcFQPyct7NoVC2TSPqDZUhiFbClhCjzWsMO4M=; b=FCwovaau1sPwX77tzst7Tq6/qOX+yn0r81Upsw0+EZfGq2MWRHTc1isfwdLsQKQC3G A+FLjWtlPyRbL68dbT8FvRZhu89T19DoRhIa8SFFL9jZxI5LAKKyc1Er7zwyNffdi+nD ha5YdI8gnlFOjUkD74fbmhREpvYCoYIOwErnIdRP/8EwTntlqMDZVLCAvdWGIxoJbSUd sRCOqb71XakjgbPWm0+6wvWlAcUiiDJSoVGbUYfC5MaMNHF3m5aqhHtxKl2akTEMBygQ 097wssaRyp7lNR09L+/nbeIBfGrEcaGMl96XcN3CmyoRIzcQbx+LEnt5bFeUMeCPAmx/ xGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=Xl9n5iWcFQPyct7NoVC2TSPqDZUhiFbClhCjzWsMO4M=; b=Ik/B/g+IgSztLbZPhYXT754kVkjSuZiENjMVOfrEIZNN4yKpslvJ45Ju3jvQhj92Pi cZ+tVbt+v+fHiXVIkQYsRNlU0WcuWPa2L6odiLkjLUciM1opzcUUzssPiVJoOKZxrA+2 8Dpg+KFE6ILr7V2OvWFpaTSuopsZbP28jW+uI4CRmMQ6ngddCui3tvn5M5K7mt66Z48h SiFiTZlxHGPJIgJwYThZ80g5q6mJz3G9x4SCp0Wryd9MWjlP//R0MSVW0bW4RkZWwWdX 43bkYz9M2gG8H0N4fu6aPhmy+cClM4J/nx1uQZ4WAIQtuuNIcvAMqViT1Wvg/LlsLDxE 57gg== X-Gm-Message-State: AHPjjUi1N2H0Q+VIpsf70sFmssNHgspEZRZFGx0ZD+OQV4N0b7MyHPpf vki5gkMVeClgEZPiLGVr/DCDtA5qvO2pTaHJQW5jDQ== X-Google-Smtp-Source: AOwi7QClwE1uldD8iMFnDLtx/XmJ9UelBkvWXveZhVg/P5yTnP+/iOahOm5/CZpfi+8csibnU/moXXP4qfxboXhSzMQ= X-Received: by 10.46.67.22 with SMTP id q22mr862737lja.99.1506527784194; Wed, 27 Sep 2017 08:56:24 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.26.38 with HTTP; Wed, 27 Sep 2017 08:56:23 -0700 (PDT) In-Reply-To: <25bd8f5d-9ad7-66e8-e7a7-1e9fc4ea65b5@dangertoaster.com> References: <3FF4070D-7174-4943-A1CB-BED910B4BB25@dangertoaster.com> <25bd8f5d-9ad7-66e8-e7a7-1e9fc4ea65b5@dangertoaster.com> From: Alan Somers Date: Wed, 27 Sep 2017 09:56:23 -0600 X-Google-Sender-Auth: DjqypBGpxYLuhmV6vYKyIRnjhL8 Message-ID: Subject: Re: Joining the Testing Team To: Ryan Quinn Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2017 15:56:26 -0000 Here's our bug tracker. I don't think there's an open issue for the coverage checker yet. https://bugs.freebsd.org/bugzilla/ -Alan On Wed, Sep 27, 2017 at 9:51 AM, Ryan Quinn wrote: > Excellent. Thank you! > > I might be interested in working on a coverage checker. I'll get in touch > with Ngie. > > Is there a ticket tracker? > > Ryan > > > > On 09/25/2017 03:40 PM, Alan Somers wrote: >> >> Wherever you like! One thing to do would be to watch Jenkins and fix >> failing or intermittent tests. Another would be to write more tests. >> Of our ~670 builtin utilities, only ~85 have any tests at all. We >> could always use more coverage. Speaking of coverage, ngie@ is >> working on integrating a coverage checker for the test suite. Ask her >> for details if that interests you. We're glad for help, whatever you >> choose to work on. >> >> https://ci.freebsd.org/job/FreeBSD-head-amd64-test/4448/testReport/ >> >> -Alan >> >> On Mon, Sep 25, 2017 at 2:20 PM, Ryan Quinn >> wrote: >>> >>> Hello, >>> >>> I=E2=80=99m interested in joining the FreeBSD Testing team. I=E2=80=99v= e been reading >>> over the TestSuite Wiki, but I=E2=80=99m not sure where to start. >>> >>> How can I get started? >>> >>> Ryan >>> _______________________________________________ >>> freebsd-testing@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-testing >>> To unsubscribe, send any mail to >>> "freebsd-testing-unsubscribe@freebsd.org" > > From owner-freebsd-testing@freebsd.org Thu Sep 28 06:42:52 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7300DE2A8D1 for ; Thu, 28 Sep 2017 06:42:52 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: from mail-yw0-f175.google.com (mail-yw0-f175.google.com [209.85.161.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3822472420; Thu, 28 Sep 2017 06:42:51 +0000 (UTC) (envelope-from shivanshrai84@gmail.com) Received: by mail-yw0-f175.google.com with SMTP id u205so347744ywa.5; Wed, 27 Sep 2017 23:42:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QLQBst0OWQ3q2TTxVNLwYGA+T+gJvBVyyFon8QpS6l4=; b=SUc3DNNyeZhUpqQdTLnTwmEd9k1FwvkUGO+CCHfIeEM0tjP+dQDjW+zDLS0AEpeg6B AxgbBtZog2Ch0gB3OjENexNN3uJ5rgRiBAvjUSZpBlQtJJJ9AeZF2o7b5E/Gopd21Tl9 AuEgATQWgsOG/YltPPIiK0tE19YtLLsOwcRAmfi+JQyhhA5fh7i7pnUIvBKXwsgEx2AT FXTJAgPJRamJ5IW1egK7vBVSbY2rxnBxRVkpOh3fRd7o6+Sifb/cUgZoKSpVHzJ3H9G9 bMXaIRcbPIrSF+qY/4KI433NqFnmx+xA5wcxkxYp7UVW5Gb6xOsHu9Xyx9zy3+goRhZ5 mYiw== X-Gm-Message-State: AHPjjUgH0Y+7X54v+NCIMTu2tnyDI88XeLfmRlMEw2AQc5mIV8MwuIBv kxvGQIjhIn7+cYwPuNl/CWU4QA== X-Received: by 10.37.14.67 with SMTP id 64mr2996288ybo.122.1506580576616; Wed, 27 Sep 2017 23:36:16 -0700 (PDT) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com. [209.85.223.174]) by smtp.gmail.com with ESMTPSA id n131sm293822ywb.107.2017.09.27.23.36.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Sep 2017 23:36:15 -0700 (PDT) Received: by mail-io0-f174.google.com with SMTP id w94so694797ioi.7; Wed, 27 Sep 2017 23:36:15 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCgM4PWn4WAgLiICAzMMP/mCKObz4qCkGkP9FonRqWSVDjiWsjsFLJzh71pBZo+Esb1KRXUtEv4ZcGn466JxN8= X-Received: by 10.107.181.138 with SMTP id e132mr5785767iof.53.1506580574743; Wed, 27 Sep 2017 23:36:14 -0700 (PDT) MIME-Version: 1.0 References: <20170924070506.GQ64616@funkthat.com> In-Reply-To: From: Shivansh Rai Date: Thu, 28 Sep 2017 06:36:03 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: suggestion library for mocking C functions To: Alan Somers , John-Mark Gurney Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 06:42:52 -0000 To add to the information by asomers@, this comment [1] might also be relevant. [1]: https://github.com/google/cmockery/pull/30#issuecomment-251064107 Regards, -- Shivansh On Sun, Sep 24, 2017 at 9:52 PM Alan Somers wrote: > On Sun, Sep 24, 2017 at 1:05 AM, John-Mark Gurney > wrote: > > Is there a recommended/supported library for mocking C functions? > > > > I want to write some test cases for functions that call other code > > in the same compilation unit that I want to be able to mock. > > > > There are a few out there, but was wondering if anyone has suggestions? > > > > Thanks. > > > > -- > > John-Mark Gurney Voice: +1 415 225 5579 > <(415)%20225-5579> > > There is no good C mocking library. The language simply doesn't > provide a good way to do it. CMockery is the best I've seen. > However, it's got some big limitations because it relies on the linker > to swap out function implementations. Your other option is to use a > C++ mocking library. It's usually possible to build your application > as C, but build the tests as C++. However, you'll still need to make > a few modifications to the application source to be able to mock > functions. You can probably hide it all in the preprocessor. If you > go this route, I recommend googletest, which nowadays includes mocking > functionality too. > > https://github.com/google/cmockery > https://github.com/google/googletest > > -Alan > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org" > From owner-freebsd-testing@freebsd.org Fri Sep 29 19:57:01 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9696DE3405B for ; Fri, 29 Sep 2017 19:57:01 +0000 (UTC) (envelope-from zakharov.vv@gmail.com) Received: from mail-lf0-x234.google.com (mail-lf0-x234.google.com [IPv6:2a00:1450:4010:c07::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1B19F73677 for ; Fri, 29 Sep 2017 19:57:01 +0000 (UTC) (envelope-from zakharov.vv@gmail.com) Received: by mail-lf0-x234.google.com with SMTP id 80so670123lfy.4 for ; Fri, 29 Sep 2017 12:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=VkIiP9ZsBHk+QcmP05eXP9tQlAzrFuiEzt3dGTEGijs=; b=dM/fSlVKCG8zgBLnmU6MNBoyvNLN7rTXDdzgwQBoW6fMPf+7YKPHPJiYjr5fKj+0iV qRYqFBUEBGTkumOlNHCFyIrPy+03LZzqrq9/5kzBwsX/K6CHWOizhOnHKoUhOEtWqa67 BgbrB/QpF/b1jWUR+IqzmH6FNDLPaPSvY241Kp12B0nmjfyJBvlDvtU/FTy7THdqzdcA Rat2U0/D4Qm4KpVpJQda+KHL9t0gyCCEBLYQlq/pHYCSrr3o2jbu+3+l9l7HDRGXte1b 8AaJS4CzCelg+UNa/TMbWhZpR9VmHtlRPuk2ILYI+U4qiYZ5c6vIRXxvTMKvrvrR6iCI Tdmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=VkIiP9ZsBHk+QcmP05eXP9tQlAzrFuiEzt3dGTEGijs=; b=qk7s7Ghun81Fua5/dVzAHifkOYZdwE7NOSxi7/A73P4BnfKTMXEf6EH6WyYdaPSL1X xZRfup4/T0SLCF6naM5e+DPUL8MmO0Q6OKKxpIAzx9sPchpBw/DQLXGUYRAeRQnqkPe9 z6GHJlT7C6EEKcdfQh4xPF7MD4MudOUZpfgIzbUFCOLB+9TgSWS70XSbIdCBVKWSxWKo YGtiXjHjwPMocjS5AF32CbF4y4MVw2GqFBVeCm42Z2QI3Gp1XKqwWgAu1l8fJbsaBIdw pPNIY28sL4VQw6ii6/YMYodHZbxaAmngpMUUVltYmzAZBUYV5UTQy/6Qnev7Dsirc2mK dQ6Q== X-Gm-Message-State: AHPjjUicLD2oTCANp2xAdrMAl7mIi6WxeI3i+MQuh9zf2WNWTONuLmMk QpieO9ynSVs4n+vIgOXIRXUdEjdt X-Google-Smtp-Source: AOwi7QCsedBmjKTyGWRICT9ix4Vlu1VXdZB9Hw4RP0Ndnof0363CT3A09/05Stv9QvMPcXcvTur8og== X-Received: by 10.25.212.195 with SMTP id l186mr1747751lfg.179.1506715019104; Fri, 29 Sep 2017 12:56:59 -0700 (PDT) Received: from localhost (ppp109-252-75-110.pppoe.spdop.ru. [109.252.75.110]) by smtp.gmail.com with ESMTPSA id b8sm935094ljf.60.2017.09.29.12.56.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Sep 2017 12:56:58 -0700 (PDT) Date: Fri, 29 Sep 2017 22:56:57 +0300 From: Vladimir Zakharov To: freebsd-testing@freebsd.org Subject: [PATCH] Install recently added tests Message-ID: <20170929195657.7u4ldyenygkhbiba@vzakharov> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Operating-System: FreeBSD 12.0-CURRENT amd64 X-PGP-Key: http://vzakharov.ru/pubkey.asc User-Agent: NeoMutt/20170912 (1.9.0) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 19:57:01 -0000 Hello! r323275 added basic tests for chflags, mkdir, rcp and rmdir. But these tests are not installed to /usr/tests. # kyua test -k /usr/tests/Kyuafile bin/chflags Results file id is usr_tests.20170929-195409-880951 Results saved to /root/.kyua/store/results.usr_tests.20170929-195409-880951.db kyua: W: No test cases matched by the filter 'bin/chflags'. # ls /usr/tests/bin/chflags/ # Attached patch fixes this problem. Index: bin/chflags/Makefile =================================================================== --- bin/chflags/Makefile (revision 324095) +++ bin/chflags/Makefile (working copy) @@ -1,6 +1,8 @@ # @(#)Makefile 8.1 (Berkeley) 6/6/93 # $FreeBSD$ +.include + PACKAGE=runtime PROG= chflags Index: bin/mkdir/Makefile =================================================================== --- bin/mkdir/Makefile (revision 324095) +++ bin/mkdir/Makefile (working copy) @@ -1,6 +1,8 @@ # @(#)Makefile 8.1 (Berkeley) 5/31/93 # $FreeBSD$ +.include + PACKAGE=runtime PROG= mkdir Index: bin/rcp/Makefile =================================================================== --- bin/rcp/Makefile (revision 324095) +++ bin/rcp/Makefile (working copy) @@ -1,6 +1,8 @@ # @(#)Makefile 8.1 (Berkeley) 7/19/93 # $FreeBSD$ +.include + PACKAGE=rcmds PROG= rcp SRCS= rcp.c util.c Index: bin/rmdir/Makefile =================================================================== --- bin/rmdir/Makefile (revision 324095) +++ bin/rmdir/Makefile (working copy) @@ -1,6 +1,8 @@ # @(#)Makefile 8.1 (Berkeley) 5/31/93 # $FreeBSD$ +.include + PACKAGE=runtime PROG= rmdir -- Regards, | "In theory there is no difference between theory Vladimir Zakharov | and practice. In practice there is."- Yogi Berra From owner-freebsd-testing@freebsd.org Fri Sep 29 20:28:04 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3B23E349BE for ; Fri, 29 Sep 2017 20:28:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x22c.google.com (mail-pg0-x22c.google.com [IPv6:2607:f8b0:400e:c05::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A30B3746FB; Fri, 29 Sep 2017 20:28:04 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x22c.google.com with SMTP id b11so358855pgn.12; Fri, 29 Sep 2017 13:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rxkAfait0awrem0IUSejxVz2YuCW5eYo7BYWPQOUhkU=; b=TOXmmXczkSwSqCWBAvR22268dx7rGMapGN5cTIQwe8iYbYrDd9A+gV5mTk3WUZNyh9 m7mko3/NIwRy1W/EcRQ92kJ9jhJ52gpkzpUrbvmlWbGfyTyTCAXUDXFLO7E608Nx2rrY VJ+zzDXc2ZecU/mf0TXcsyWTd0n7et86zdThXiNv87evRy640QEoK2PWXy8N4reJZi5k 0FOG5F6f2Xff6S/iO2RH6aXeDyupfROugl+MtdQ5jTKJdQmJnpdgwkdeYVjlAz3xBNOo MQZT1lWPsDpv2izXz6fXToLpkCj7f++RHzJuXIaciYLGeKJ3wlwQBM8V5DW7Fd8tpz0D y6Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rxkAfait0awrem0IUSejxVz2YuCW5eYo7BYWPQOUhkU=; b=gSrNJ6jkExW5Sn4xY95rCJq3BxKhmBrwwdZLiXc8lc/hmczvtiuANVRMNCc7dLUO1P tCQTeEmO0Zj8U1STq3c5sWPGzG/iG20CcxOfHfSd+VgSM874ayEexahTKKPRcXKdzIqB LXejV8Jhfdu8FEeTTnXiXDjOmuUhKEgfgEBt9vbjmiwMMwjdAlXUiJDhbIJk+563HlVQ 3KykpCI4vTDx5YFjPQtLLw/d3e54ov+47ZpQ8IYVqqYdEc6uL/qxD2mvgGFZJkDhJTyH xEJIZtvE4Q0v+HeSQW+YQrbRuRhy519ESeQk0aC4eUhw0FIvgXQoRQ/am4JS9LRxHSR0 iZOA== X-Gm-Message-State: AHPjjUghyGwmQGtadmG5K6j+veBLeuzZvFNON4yrDswYAgUeFdkd14wR g2pHKEzmUUh1elHqGOeInlM= X-Google-Smtp-Source: AOwi7QDajtKeTtCoectIpNEoL0jE+75bG81to3RwAY5g+ddosiqY35Ny5cqq8OgJCY3MmV91j1nlAg== X-Received: by 10.84.130.35 with SMTP id 32mr8057285plc.368.1506716884036; Fri, 29 Sep 2017 13:28:04 -0700 (PDT) Received: from ?IPv6:2620:10d:c096:106:5568:34b0:343e:beea? ([2620:10d:c090:380::2:9f17]) by smtp.gmail.com with ESMTPSA id s76sm8886321pfj.119.2017.09.29.13.28.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Sep 2017 13:28:03 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] Install recently added tests From: Ngie Cooper X-Mailer: iPhone Mail (14G60) In-Reply-To: <20170929195657.7u4ldyenygkhbiba@vzakharov> Date: Fri, 29 Sep 2017 13:28:02 -0700 Cc: freebsd-testing@freebsd.org, imp@bsdimp.com, Ed Maste Content-Transfer-Encoding: quoted-printable Message-Id: <4FD3917E-0A54-49C3-AC09-EA95AF4EA071@gmail.com> References: <20170929195657.7u4ldyenygkhbiba@vzakharov> To: Vladimir Zakharov X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 20:28:04 -0000 > On Sep 29, 2017, at 12:56, Vladimir Zakharov wrote= : >=20 > Hello! >=20 > r323275 added basic tests for chflags, mkdir, rcp and rmdir. But these > tests are not installed to /usr/tests. LGTM. This is the bad downside of the SUBDIR.yes pattern that's bitten me in the a= ss a couple times now. > # kyua test -k /usr/tests/Kyuafile bin/chflags > Results file id is usr_tests.20170929-195409-880951 > Results saved to /root/.kyua/store/results.usr_tests.20170929-195409-88095= 1.db > kyua: W: No test cases matched by the filter 'bin/chflags'. > # ls /usr/tests/bin/chflags/ > # >=20 > Attached patch fixes this problem. >=20 > Index: bin/chflags/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bin/chflags/Makefile (revision 324095) > +++ bin/chflags/Makefile (working copy) > @@ -1,6 +1,8 @@ > # @(#)Makefile 8.1 (Berkeley) 6/6/93 > # $FreeBSD$ >=20 > +.include > + > PACKAGE=3Druntime > PROG=3D chflags >=20 > Index: bin/mkdir/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bin/mkdir/Makefile (revision 324095) > +++ bin/mkdir/Makefile (working copy) > @@ -1,6 +1,8 @@ > # @(#)Makefile 8.1 (Berkeley) 5/31/93 > # $FreeBSD$ >=20 > +.include > + > PACKAGE=3Druntime > PROG=3D mkdir >=20 > Index: bin/rcp/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bin/rcp/Makefile (revision 324095) > +++ bin/rcp/Makefile (working copy) > @@ -1,6 +1,8 @@ > # @(#)Makefile 8.1 (Berkeley) 7/19/93 > # $FreeBSD$ >=20 > +.include > + > PACKAGE=3Drcmds > PROG=3D rcp > SRCS=3D rcp.c util.c > Index: bin/rmdir/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- bin/rmdir/Makefile (revision 324095) > +++ bin/rmdir/Makefile (working copy) > @@ -1,6 +1,8 @@ > # @(#)Makefile 8.1 (Berkeley) 5/31/93 > # $FreeBSD$ >=20 > +.include > + > PACKAGE=3Druntime > PROG=3D rmdir >=20 > --=20 > Regards, | "In theory there is no difference between theor= y > Vladimir Zakharov | and practice. In practice there is."- Yogi Berra= > _______________________________________________ > freebsd-testing@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-testing > To unsubscribe, send any mail to "freebsd-testing-unsubscribe@freebsd.org"= From owner-freebsd-testing@freebsd.org Fri Sep 29 23:48:29 2017 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB5DCE3739F for ; Fri, 29 Sep 2017 23:48:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x243.google.com (mail-lf0-x243.google.com [IPv6:2a00:1450:4010:c07::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5FDDA7D6E1 for ; Fri, 29 Sep 2017 23:48:29 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x243.google.com with SMTP id b127so1065263lfe.9 for ; Fri, 29 Sep 2017 16:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=qUi1ehdOgnhonobkwpR18KBp8NJuWDdPDkCUFsoNhK0=; b=u1LzFhLVoKk8QwTGD5eE+RNPsxGJ3XWLVf5Ba6BdUxt05lqRNktbx95uNbIs2IQbnb 2lPV52Wd44p5qu3B1YOYQXVmJsYxqzfHlReLV3TL0T5abznmlMrQ2apyNQuSQ4DUcHTD OdbaVD9uLHnoOHIPTpudqmJKwp0RIFsbL08eIkOqvJwvUROJ4N9Dp9dmRchYnOiMlPvP iFOHUGJiyIK1/l5rt9jDsynZwAreJn2XGQCmcPQnPuU2GSSHvH8IoGBvrRG8frKHT4/J BN0p7H+us93HcbUHz+kVbrRanZKJGO1IW95iUcIvxLx6d8rMreecy+76vaxNhGwC5V32 30bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=qUi1ehdOgnhonobkwpR18KBp8NJuWDdPDkCUFsoNhK0=; b=bRJY/KawjZmqYyMa8A+cOfBvm6kCmFa02xIcgX3zYa+MS7qdLT1s7OJagVCFBqdBaI 7kpCA9cggQjqHin1XoSZO6oYTfsgopDXscAOWHPs5oEUyi4pF/VkbtKZGP4kUbEQE8j8 KtU9WHaYlEd3K6nE/WFlGTHQJ6ObPgMnuwlbXyz8vC2uhdL9diYp1R5/bzqfGWW9bkRl TGAWJtKvfl4Ffs7/4dZmeRiA18UNt0bmxeF107TEihfWDcTAo6pEHbqEoYwOa27mPdur +JNJTOpspwifs6V7KttyU2gJxixCpebXGG06uDC9cfJwhydVlRSPBs6y4h83+y3T5yuU tKOQ== X-Gm-Message-State: AHPjjUjZVQ6FBHpVy2lt8TGj3zlTv4d2IUpz4b4PsSX8+NWUMaAkva1a m7BcPd7g69NtyVcVPpmkO3ftEhZuQOFlK2EOzFo= X-Google-Smtp-Source: AOwi7QDoi4xB+Yz/KedjMT3yKRFba12168YAzkQnlLnDa+OV4cAM1UfSQ3QocgX0p/YEoqPh9zp8LJ615l5gpTNlxKs= X-Received: by 10.25.23.95 with SMTP id n92mr1829853lfi.95.1506728907177; Fri, 29 Sep 2017 16:48:27 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.7.153 with HTTP; Fri, 29 Sep 2017 16:48:26 -0700 (PDT) In-Reply-To: <4FD3917E-0A54-49C3-AC09-EA95AF4EA071@gmail.com> References: <20170929195657.7u4ldyenygkhbiba@vzakharov> <4FD3917E-0A54-49C3-AC09-EA95AF4EA071@gmail.com> From: Alan Somers Date: Fri, 29 Sep 2017 17:48:26 -0600 X-Google-Sender-Auth: 3Bm2EiY6T-gQK3mShgO9akFNfkI Message-ID: Subject: Re: [PATCH] Install recently added tests To: Ngie Cooper Cc: Vladimir Zakharov , "freebsd-testing@freebsd.org" , Warner Losh Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 23:48:30 -0000 On Fri, Sep 29, 2017 at 2:28 PM, Ngie Cooper wrote: > >> On Sep 29, 2017, at 12:56, Vladimir Zakharov wrote: >> >> Hello! >> >> r323275 added basic tests for chflags, mkdir, rcp and rmdir. But these >> tests are not installed to /usr/tests. > > LGTM. > > This is the bad downside of the SUBDIR.yes pattern that's bitten me in the ass a couple times now. > >> # kyua test -k /usr/tests/Kyuafile bin/chflags >> Results file id is usr_tests.20170929-195409-880951 >> Results saved to /root/.kyua/store/results.usr_tests.20170929-195409-880951.db >> kyua: W: No test cases matched by the filter 'bin/chflags'. >> # ls /usr/tests/bin/chflags/ >> # >> >> Attached patch fixes this problem. Fixed in 324112. Thanks for the bug report.