From owner-freebsd-wireless@freebsd.org Sun Oct 29 06:34:23 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6AC85E5B334 for ; Sun, 29 Oct 2017 06:34:23 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-qk0-x233.google.com (mail-qk0-x233.google.com [IPv6:2607:f8b0:400d:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 209E76DEB3 for ; Sun, 29 Oct 2017 06:34:23 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-qk0-x233.google.com with SMTP id b15so12695016qkg.9 for ; Sat, 28 Oct 2017 23:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=nRDwpN9G3SEB/DR918VrRoLgnqkz+OUJiEgnmKBVzdw=; b=NT4mCFGxW9CEe3scmuoatuVlFoXVXnpKnBElIN1eCQufkq1U7gb9A/3ISVG5VXXYRD PWeUOR/2zfxGG3dVsovNoZuNjGRqLwb8wgY2lFpmRVnO8QlEiCZbIc6V68l0Oit93X3C 7LCKCFbSFF/oYlLGbIxotUSYJZOw2vxx6Eq7vkXZnjPPyJ+pjXl/GwfnVkTz3T7NtFFk TcPK1PiMZSW75dxI4NsUc3KxhxGO3kRsLLG1v1THCmxJ2we1y4slbv2GkCWNrb8OZYtR GsOZLL0FVDB7Dwx3PlLZw5zA40bzgsrUscTs34Ug6ZY8DyXZg78/wkyn83zTUt0qgLLf a1Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=nRDwpN9G3SEB/DR918VrRoLgnqkz+OUJiEgnmKBVzdw=; b=kWAepsU5FcSQ0VG3cs9TSKt6GsOOHXQnQAFSHqCvJMpaxbSYWER+fmGAZjhGTm0cxE 4kxb0OKiUEtdRzrjPmaQAfkNdMgRwJnHHgwBWN+rTiFptzv59gjlqxPuawONc/ShlDjV 7id5MmtiR/E27Zrqy6MZbgafdf/tbvgw+ah5vvcwh+NsoJUqZ68X4hxe5IgQccpsJ+cx kqGNfm8Ytns70g/8bEn542vekhsz/NwpTNj9yZcfagVElQUP8vsYZxrNzPrPHYUB5eER hgB81Kg3BRmbx535GxX3AY7Xm++i089DqHfKmmgsm+QDYKmsEe8AxP9R81pCFtGFRDu0 dC5w== X-Gm-Message-State: AMCzsaVwRayM3FjIM2+e3a/1r/O7xFNQS++zePGzthMLVg8MeYFrMiVU 1G9UJt9vPbWuuqCFN1ClS7/p8uzk X-Google-Smtp-Source: ABhQp+QyL/2TEZVOQqFyD8/G8ELMvRAObfXZrGrsg/SDEsMGOAMKpLABbayvSKX4MfPBfiST234DXw== X-Received: by 10.55.59.131 with SMTP id i125mr7830810qka.93.1509258862056; Sat, 28 Oct 2017 23:34:22 -0700 (PDT) Received: from pc.farhan.codes ([2001:470:8:209::dead:c0de]) by smtp.gmail.com with ESMTPSA id v21sm8227227qtv.21.2017.10.28.23.34.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Oct 2017 23:34:21 -0700 (PDT) To: freebsd-wireless@freebsd.org From: Farhan Khan Subject: C2H on rtwn not handled Message-ID: <96dc159c-1d56-5bea-7100-75dd117d828d@gmail.com> Date: Sun, 29 Oct 2017 02:34:21 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 06:34:23 -0000 Hi all, I am trying to extend the rtwn driver to add RTL8188EE support. I am still getting this error whenever I enable the WiFi card: rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled From my reading of the code, it appears that the driver is trying to read a status-value from the card, but it fails to return a valid result. Is there something that I need to do to initialize this? If so, what exactly? This appears to be a firmware-specific routine and I have enabled the firmware. I have been on this for an extended period of time and am stuck :( Thank you! -- Farhan Khan PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE From owner-freebsd-wireless@freebsd.org Sun Oct 29 23:49:39 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAB5FE4F598 for ; Sun, 29 Oct 2017 23:49:39 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5DF196B81E for ; Sun, 29 Oct 2017 23:49:39 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: by mail-lf0-x22f.google.com with SMTP id a132so12907634lfa.7 for ; Sun, 29 Oct 2017 16:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=5/lxzA30Umc04yTnn36RY3i5OQ5VP8+Ew8jaoq2R8kw=; b=E6sfGUtsdLiCLIdsSOv8js6hg7zy1TCeAyfAXHGzVvMZGNF+IqAm3HjYhrliTdXEel EiPXqxs75WTxGrKZIyXUyhDpg+Y5mZynl02fEoSU4TjHWGPhXdP/a3bHlYYdn7YGGXhM 7fiyVEBT/1zYtFgRzPcwUN8UGG73f2ZEQgvRpGbzqYNz1ngLvIL7aDbhBF+NCOa+RfFe 1dxUtjKqvL/kk2Of6nlbUGasXdHTWnrFLJDsbEshyF47mrFy0LNU61+pSHw7DTQoSbKJ iBGIAbnnDFaKMbwFZ2I51/3TRYO5JNBozyhWVtgenqd6Rm2pESBHOeDF/ak3OKzAvDgD S5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:references:date:cc:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=5/lxzA30Umc04yTnn36RY3i5OQ5VP8+Ew8jaoq2R8kw=; b=YwmMHRlBzkXMPMrRRvxG8FVv/uq+GJ96C4PIWi9nYzZUyYdPoHqf700/EQyRvFZWEK K8b/cYC0Q6TIo7XDeJIc0mhW7RynUr5exr4WIAsiTG99isv+z9TNFgD8FUT1zaf4dQzU NMT7U6Z4i55hdfsRMye7kvmW5pTaSBbq+1cSV7hZvmdd/XlPsPRjeq2Bbxpo/0NNYwc2 E1Mh0IMRVZfFH22fmLUTZTaO+zwPoJUd0trCLjJ3ZS1ZJcbiMYe+E/iUkFCQ+IjprzXf TLu1kJZ4EcmeHdC/oAfAx83h6f4cgAtjMgRuYhshkp1BZIv8Bv0ERCFBh5fFt9uN1gL1 K02g== X-Gm-Message-State: AMCzsaX7EejTYpGccc+ZSgGx9JyU/bKJmRcrwNCQnUU1zW0z5F+J1zVy v3SofnFPblLJE5ZcGJVA9hE= X-Google-Smtp-Source: ABhQp+QlbG/Usiu0vpVG0YpATJjtFuyLZJEYy/xjI4DY7FtVM8q7AvikZnClrdl7Qqs+GePWK/Gx6w== X-Received: by 10.46.16.218 with SMTP id 87mr3230740ljq.115.1509320977263; Sun, 29 Oct 2017 16:49:37 -0700 (PDT) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id k37sm2396831lfi.27.2017.10.29.16.49.36 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 29 Oct 2017 16:49:36 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Farhan Khan" Subject: Re: C2H on rtwn not handled References: <96dc159c-1d56-5bea-7100-75dd117d828d@gmail.com> Date: Mon, 30 Oct 2017 01:46:45 +0200 Cc: freebsd-wireless@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <96dc159c-1d56-5bea-7100-75dd117d828d@gmail.com> User-Agent: Opera Mail/12.15 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 23:49:40 -0000 Sun, 29 Oct 2017 08:34:21 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Farhan Khan = : Hi, You should not use polling for RTL8188EE - it was mainly used for RTL8192C* (since there is no documented way to get events from it) and can be enabled on RTL881(1,2)A (but just is not needed here). Look into rtwn/rtl8188e/r88e_rx.c - I think you can call r88e_ratectl_tx_complete() and/or r88e_handle_c2h_report() indirectly from rtwn_pci_intr() when C2H event arrives. > Hi all, > > I am trying to extend the rtwn driver to add RTL8188EE support. I am = > still getting this error whenever I enable the WiFi card: > > rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled > > From my reading of the code, it appears that the driver is trying to = = > read a status-value from the card, but it fails to return a valid = > result. Is there something that I need to do to initialize this? If s= o, = > what exactly? This appears to be a firmware-specific routine and I hav= e = > enabled the firmware. > > I have been on this for an extended period of time and am stuck :( > > Thank you! > > -- > Farhan Khan > PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to = > "freebsd-wireless-unsubscribe@freebsd.org" From owner-freebsd-wireless@freebsd.org Mon Oct 30 04:28:17 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB8F0E53B42 for ; Mon, 30 Oct 2017 04:28:17 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-qk0-x22b.google.com (mail-qk0-x22b.google.com [IPv6:2607:f8b0:400d:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8124272E6F for ; Mon, 30 Oct 2017 04:28:17 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-qk0-x22b.google.com with SMTP id x82so14617572qkb.12 for ; Sun, 29 Oct 2017 21:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oydEeqqWJUxPrDulyzpTg4kDz5wxLR5Gui4/TcmrWug=; b=ge72n36LrnGEEzU4YaVDeTbwrOUjLLllqZ1f8qhNX7FmTZmNHiwkeABVVnXV75q6AH AcP6m7wgcqJ8+Mxn1PTCvs1BcM++gqiY1l524MdLtKLB7w9GRCX84aXuY8R380DwfZXe 9QTDdi/s7rvXj27r9jWjAtASxSWhfRZbDwwHxbXF8mPRDWOulSn8R5cebYclAUb04V6Z 45eWXbmTjoZyDiqjUDGt+MbFDo6H3FW1i66hgAJljhTGN/XdP7YFTAcSC5MVsHhPBQ1y W8FCPN9RiXQNEOMe/mEXQu8ID4eOYQ1As0TuSeZXr0rF/cUbGH/x3Dwnc1BYcD4c5FPD 5+8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oydEeqqWJUxPrDulyzpTg4kDz5wxLR5Gui4/TcmrWug=; b=scMVTJt9nTF1vyYQ4cBITCEdUa1Pr2EatXJuBc7AlH5LIMTaPgNGoEcW9T+JLkqJSA HliYncGY8V3BnE4arqzyaGfqWqo0Toqv4miA02yeIYgrZ1fnveW1UYe3txQP0zehepGe Zql1I4pmsrKXb2ezGXlyIdhYGGTEikbTMPzScBH3e2VoCO7ht1qzK8j1i+k6AC0rGSCA FLMm7C2TEJZ2yLXO+9qRCgJM8AkqzGqSpvRTMQWdcGKS46JvJQObrgMav1TOW0L91AgP f6ITUlUOq+Yo1jptgIq0sKtivY+X9iV9UvqzOGCO6bFIVt3cxvXz+OqHXa9RDStxX0el rt6g== X-Gm-Message-State: AMCzsaVezqdBl19C1BvmttrSKKztOcp/W7lvWTMceK1CYvfi5+hXiJVN 4xr33uWOor5pFkKDDLijedp2VTS0 X-Google-Smtp-Source: ABhQp+QUUjRN15zS1uO1zftmOKPDjwHogkHOFLuCuD1B3EE2cZyz9yUSyU63O80lHjYdjMBnHDKG3A== X-Received: by 10.55.167.22 with SMTP id q22mr11066549qke.234.1509337696329; Sun, 29 Oct 2017 21:28:16 -0700 (PDT) Received: from pc.farhan.codes ([2001:470:8:209::dead:c0de]) by smtp.gmail.com with ESMTPSA id u127sm8812316qkf.79.2017.10.29.21.28.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Oct 2017 21:28:15 -0700 (PDT) Subject: Re: C2H on rtwn not handled To: Andriy Voskoboinyk Cc: freebsd-wireless@freebsd.org References: <96dc159c-1d56-5bea-7100-75dd117d828d@gmail.com> From: Farhan Khan Message-ID: <9485c341-52db-5cab-b9da-25f3ecc16c13@gmail.com> Date: Mon, 30 Oct 2017 00:28:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 04:28:17 -0000 Hi Andriy, Just to be clear, this would mean that in my sc_post_init, I should not utilize callout_reset, which utilizes r92c_handle_c2h_report, correct? This appears to be how rtl If so, how do I know when a C2H event arrives? (I am not too familiar with C2H or how it works yet). As always, thank you very much. On 10/29/2017 07:46 PM, Andriy Voskoboinyk wrote: > Sun, 29 Oct 2017 08:34:21 +0200 було написано Farhan Khan > : > > Hi, > > You should not use polling for RTL8188EE - it was mainly used for > RTL8192C* (since there is no documented way to get events from it) > and can be enabled on RTL881(1,2)A (but just is not needed here). > > Look into rtwn/rtl8188e/r88e_rx.c - I think you can call > r88e_ratectl_tx_complete() and/or r88e_handle_c2h_report() indirectly > from rtwn_pci_intr() when C2H event arrives. > >> Hi all, >> >> I am trying to extend the rtwn driver to add RTL8188EE support. I am >> still getting this error whenever I enable the WiFi card: >> >> rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled >> >>  From my reading of the code, it appears that the driver is trying to >> read a status-value from the card, but it fails to return a valid >> result. Is there something that I need to do to initialize this?  If >> so, what exactly? This appears to be a firmware-specific routine and I >> have enabled the firmware. >> >> I have been on this for an extended period of time and am stuck :( >> >> Thank you! >> >> -- >> Farhan Khan >> PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE >> _______________________________________________ >> freebsd-wireless@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-wireless >> To unsubscribe, send any mail to >> "freebsd-wireless-unsubscribe@freebsd.org" From owner-freebsd-wireless@freebsd.org Mon Oct 30 08:15:49 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE518E5712E for ; Mon, 30 Oct 2017 08:15:49 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: from mail-lf0-x230.google.com (mail-lf0-x230.google.com [IPv6:2a00:1450:4010:c07::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 507437CF35 for ; Mon, 30 Oct 2017 08:15:49 +0000 (UTC) (envelope-from s3erios@gmail.com) Received: by mail-lf0-x230.google.com with SMTP id k40so13889271lfi.4 for ; Mon, 30 Oct 2017 01:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=y9c3AKnNyl0yLHCRheVBUn3+9UpsmSOsflMEZfLC8Y4=; b=oXxW7Sp3cEGmlOlFBPcPFr/XUIdXVDy93FO9J6eSNyPFuRRZ84j/U21jT6EEZCpuVn k7wXxtR+CtaXNBkRtrjfUNRha9d5ONDpfNnmHuBi8UJedLkdi4Cuj50W/R9uYAFVd0Vd ZQg52OtZPaffhSEn05/Y5FYNh+ZofzIeaUDaEcQiFueZgYiQb5VJvfWt5NMaAd5r3MoL zCYnce7xXDAZILhQPDJjRV8FG8p+SJrEmNnTsyYYxyyqmN0wBdfpngjOo0xvwOXOxD4K R5ExPitUY5sybZyXOlOZUQl4mGIr8PT3bJgvqvngYGxxhgY+WnKnsd9t852ywsLJxDSJ Kb6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:subject:references:date:mime-version :content-transfer-encoding:from:message-id:in-reply-to:user-agent; bh=y9c3AKnNyl0yLHCRheVBUn3+9UpsmSOsflMEZfLC8Y4=; b=Ck3c7mKSaPTYL8VB42nrHCk1yMBDC8pVJjGhbhVFBIM6pl1i0djqY6gnZBPADrzlTr v9FhRPzFCcxNAdX15aYAztE65OrwWXwj1LKmU+5qjnWhLxdWHR/unMGaTgRR1x7nNpMM GI362f83sjfdhkJYgKFBu72740wV6VNOUV96dIQuWkdFlvN7aP62zcaPDEv1Ycyumwmf rZuEVJUSr7uTxUEDgpsmXEoOfKZuq1pFrDJADsVyrOQ44isCI2iCZkqtRbOHnHYtxZUT 0UMyH29Nq2TmX3lKL8/YHmvugEzuF46yihzRTPtBrkP2D77DHK8JecUaZ6gQ3/5oRIO+ oZ3A== X-Gm-Message-State: AMCzsaVN18V8Se+bnhkzi8or8SbSzy/wry3CXzaNQKBK1nRgmfAh0fRj QamBFm7DGqzGq9dHq3rqjOg= X-Google-Smtp-Source: ABhQp+RluWIVjAlKDawKkgKdQF+1eF8tU8jT4tzUvcjSu+sk6+msuQKOE5y7pNxXy2m4rhZC4tsXdA== X-Received: by 10.25.150.10 with SMTP id y10mr2772360lfd.91.1509351346670; Mon, 30 Oct 2017 01:15:46 -0700 (PDT) Received: from localhost (host-176-37-109-22.la.net.ua. [176.37.109.22]) by smtp.gmail.com with ESMTPSA id b14sm3356383ljb.74.2017.10.30.01.15.45 (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 30 Oct 2017 01:15:45 -0700 (PDT) Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Farhan Khan" Cc: freebsd-wireless@freebsd.org Subject: Re: C2H on rtwn not handled References: <96dc159c-1d56-5bea-7100-75dd117d828d@gmail.com> <9485c341-52db-5cab-b9da-25f3ecc16c13@gmail.com> Date: Mon, 30 Oct 2017 10:12:53 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: Quoted-Printable From: "Andriy Voskoboinyk" Message-ID: In-Reply-To: <9485c341-52db-5cab-b9da-25f3ecc16c13@gmail.com> User-Agent: Opera Mail/12.15 (FreeBSD) X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Oct 2017 08:15:49 -0000 Mon, 30 Oct 2017 06:28:15 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0=D0= =BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Farhan Khan = : > Hi Andriy, > > Just to be clear, this would mean that in my sc_post_init, I should no= t = > utilize callout_reset, which utilizes r92c_handle_c2h_report, correct?= Yeah, rs_c2h_* fields are not used on RTL8188E* > This appears to be how rtl > > If so, how do I know when a C2H event arrives? (I am not too familiar = = > with C2H or how it works yet). Just check if IMR_TXCCK_88E / IMR_C2HCMD_88E bits are set in interrupt status (R88E_HIMR register, see r92ce_classify_intr() as an example). > > As always, thank you very much. > > On 10/29/2017 07:46 PM, Andriy Voskoboinyk wrote: >> Sun, 29 Oct 2017 08:34:21 +0200 =D0=B1=D1=83=D0=BB=D0=BE =D0=BD=D0=B0= =D0=BF=D0=B8=D1=81=D0=B0=D0=BD=D0=BE Farhan Khan = >> : >> Hi, >> You should not use polling for RTL8188EE - it was mainly used for >> RTL8192C* (since there is no documented way to get events from it) >> and can be enabled on RTL881(1,2)A (but just is not needed here). >> Look into rtwn/rtl8188e/r88e_rx.c - I think you can call >> r88e_ratectl_tx_complete() and/or r88e_handle_c2h_report() indirectly= >> from rtwn_pci_intr() when C2H event arrives. >> >>> Hi all, >>> >>> I am trying to extend the rtwn driver to add RTL8188EE support. I am= = >>> still getting this error whenever I enable the WiFi card: >>> >>> rtwn0: r92c_handle_c2h_task: C2H report 0 (len 0) was not handled >>> >>> From my reading of the code, it appears that the driver is trying t= o = >>> read a status-value from the card, but it fails to return a valid = >>> result. Is there something that I need to do to initialize this? If= = >>> so, what exactly? This appears to be a firmware-specific routine and= I = >>> have enabled the firmware. >>> >>> I have been on this for an extended period of time and am stuck :( >>> >>> Thank you! >>> >>> -- Farhan Khan >>> PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE >>> _______________________________________________ >>> freebsd-wireless@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-wireless >>> To unsubscribe, send any mail to = >>> "freebsd-wireless-unsubscribe@freebsd.org" From owner-freebsd-wireless@freebsd.org Sat Nov 4 23:49:51 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 484B9E59EB4 for ; Sat, 4 Nov 2017 23:49:51 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-qt0-x22c.google.com (mail-qt0-x22c.google.com [IPv6:2607:f8b0:400d:c0d::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A18C3FCD for ; Sat, 4 Nov 2017 23:49:50 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-qt0-x22c.google.com with SMTP id v41so7166554qtv.12 for ; Sat, 04 Nov 2017 16:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=GVRfiAU7kVila5T9DWtffO456BE92F6qWuV9WxzoU+8=; b=mYKWdm7ciSyv6OWO50vE6PlkjqycpjeS516yD6CyKOfIoudOjqMb77mrcZUZn7ZrKE /Xeb0/M5z3B0pXGvdXYBsEbX4+2sL6AAbopMud2iwHJYmXKu9rrViicxcfel1MiFlf5v AVyMP5RsRnNqqh3/UFE5fB9mqhUmGDhBltPFV4qhJyPLxKM0z2T8HZnEffM7ZUJSrNXC Q/zZHm36T0yZm6P5AJ5znGPkU4YfK2Hzgb8fsje+Ci17dFcpt850G3AHyizrIpBiwlPc 7cSG8jdl6v6c0K9IF8VFFOVX1xGEwyaTGkOLtG6FJB0yuyVHNV5E+h6km8tRGdSqDEIj Z+0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=GVRfiAU7kVila5T9DWtffO456BE92F6qWuV9WxzoU+8=; b=tNs49lJ4EnH3Lobh+3lN+/B9TuFPlu9cwUUCttaYM/PMaiIR6sMhQr4H56rP/FZPUn 2Ijsy/c1pzOumR/jJvUbI1sfq1Jy8YP1uAbqo20H7uX/q9X1ylJ9tfLhRE5PZDhvcv/U GXPCQnrDYSo1REHJTkdlAh3dUD/eTeYuW15o7cmAfg6S5VHeNVJny5u0Noqqzb0WwAzy JFjMLvp5fHa+Wtd+QREdG1l+PLiF9vT2mpDBBkcfs+caygeXWAjo8aixziIwKgPivMrf WCIGNW0G42bCBJW7A7yk3dMUiuOCgGgbN9gWk8SQSaftVeEZHBOxYa14nXGkZkklc14Z lQmA== X-Gm-Message-State: AMCzsaVhE4u7F6scbiJpx4aXSTWmxFMjvKgFznIb93AkXdhzUGFzObCN cTpdaDvk1XRwOhNG9UsnJtcqeK8K X-Google-Smtp-Source: ABhQp+QFJzwoCPeybAGk2BBpag80eEutp6UYvzCw77Ie9mOjiQXDuwjDy1u2QKyVjh+BrqcmI5i7IQ== X-Received: by 10.237.37.76 with SMTP id w12mr16656278qtc.201.1509839389777; Sat, 04 Nov 2017 16:49:49 -0700 (PDT) Received: from pc.farhan.codes ([2001:470:8:209::dead:c0de]) by smtp.gmail.com with ESMTPSA id y15sm6223338qtc.11.2017.11.04.16.49.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Nov 2017 16:49:48 -0700 (PDT) To: freebsd-wireless@freebsd.org From: Farhan Khan Subject: Identify cause of ieee80211_get_counter Message-ID: <9f785504-1920-dee3-b3d7-55538b538c9f@gmail.com> Date: Sat, 4 Nov 2017 19:49:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2017 23:49:51 -0000 Hi everyone. I am working through the driver, and running into some ieee80211_get_counter()'s. Per sys/net80211/ieee80211.c, the comment says "Add underlying device errors to vap errors", which implies that it will only trigger when an error occurs. Is there a way to identify what the cause of the function call is? I ran dtrace against "fbt:kernel:ieee80211_get_counter:entry" with a stack() trace as follows: CPU ID FUNCTION:NAME 3 17127 ieee80211_get_counter:entry kernel`if_data_copy+0xa1 kernel`sysctl_rtsock+0x2b6 kernel`sysctl_root_handler_locked+0x7b kernel`sysctl_root+0x1c6 kernel`userland_sysctl+0x148 kernel`sys___sysctl+0x5f kernel`amd64_syscall+0x79b kernel`0xffffffff80ed07bb Is there an efficient way to identify what the cause of the error is? Thank you, -- Farhan Khan PGP Fingerprint: B28D 2726 E2BC A97E 3854 5ABE 9A9F 00BC D525 16EE