From owner-freebsd-current@freebsd.org Sun Jul 15 01:19:22 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 484571046970 for ; Sun, 15 Jul 2018 01:19:22 +0000 (UTC) (envelope-from lars@gustik.eu) Received: from madarka.gustik.eu (madarka.gustik.eu [IPv6:2a01:4f8:150:80b1:fe57:f772:524c:99d0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B2AC70CE5 for ; Sun, 15 Jul 2018 01:19:21 +0000 (UTC) (envelope-from lars@gustik.eu) Received: from romy.j20.helspy.pw (unknown [IPv6:2a01:c844:106d:4420:df9b:a36f:cb77:f65e]) by madarka.gustik.eu (Postfix) with ESMTPSA id 015DE16272 for ; Sun, 15 Jul 2018 03:19:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gustik.eu; s=mail; t=1531617552; bh=Bl2R43vuX+MUCQUKZ1MElU2OxmzZvlVs0XHDNPiYJ68=; h=Date:From:To:Subject:In-Reply-To:References; b=kuw7HfNKbdalSoBV4AJbpvdQEVjnoy4BWrzTam+GWLkD/eWgEZj+4fw3U2sxOPvvz /gOh/4dBkh4BM0PIPEZwwx0zm87tCXSf0+X/epwPIYSHDzIK79V7QbEyzVA8+9qJE2 DbyB4SFGUQ7hVbkbksseUweIdS1JULI49kizOniQ= Date: Sun, 15 Jul 2018 03:19:11 +0200 From: Lars Schotte To: freebsd-current@freebsd.org Subject: Re: local_unbound segfaults at boot Message-ID: <20180715031911.2ec8af3d@romy.j20.helspy.pw> In-Reply-To: References: X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 01:19:22 -0000 I see segfaulting too: FreeBSD wasp.2km.casa 12.0-CURRENT FreeBSD 12.0-CURRENT #6 r336229: Fri Jul 13 01:51:31 CEST 2018 root@wasp.2km.casa:/usr/obj/usr/src/amd64.amd64/sys/GUSTIK amd64 # service local_unbound restart local_unbound not running? (check /var/run/local_unbound.pid). Starting local_unbound. Segmentation fault (core dumped) /etc/rc.d/local_unbound: WARNING: failed to start local_unbound # du -sh unbound.core 23M unbound.core On Sun, 3 Jun 2018 14:09:45 -0500 Patrick McMunn wrote: > I believe the problem of local_unbound segfaulting began after I > compiled the source after the large commit to unbound on Saturday, > May 12, 2018 (about 3 weeks ago). > > I assumed the problem was probably common if I was experiencing it, > but I've seen no other mentions of it. I'm not sure what info I need > to provide, but will do so upon request. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" -- Lars Schotte Mudroňova 13 92101 PieÅ¡Å¥any From owner-freebsd-current@freebsd.org Sun Jul 15 03:09:15 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 538C2104C336 for ; Sun, 15 Jul 2018 03:09:15 +0000 (UTC) (envelope-from lars@gustik.eu) Received: from madarka.gustik.eu (madarka.gustik.eu [IPv6:2a01:4f8:150:80b1:fe57:f772:524c:99d0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3370750F3 for ; Sun, 15 Jul 2018 03:09:14 +0000 (UTC) (envelope-from lars@gustik.eu) Received: from romy.j20.helspy.pw (unknown [IPv6:2a01:c844:106d:4420:df9b:a36f:cb77:f65e]) by madarka.gustik.eu (Postfix) with ESMTPSA id 618C716282 for ; Sun, 15 Jul 2018 05:09:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gustik.eu; s=mail; t=1531624153; bh=i2xcqCTbTq83QNDpLXyYdOWzu94yARxx6y9dhHOqEsU=; h=Date:From:To:Subject; b=XKh4lqnES1BSdMmbTTtH8JgqupYjG+zqn99/gtpmvnNi7/28zbYcjgcWimNGzQt/X enC4mvuxYJZQTzvHusjHXjiWeR4Xo5I1R+WiUyuxzfTCFAZFG33nrlDhaYxqrRYgSR J2v29pRr1ksURXDaxLcSlHs/4cRgK1TbtU8ZfMSs= Date: Sun, 15 Jul 2018 05:09:12 +0200 From: Lars Schotte To: freebsd-current@freebsd.org Subject: PF synproxy 12 seems to work now Message-ID: <20180715050912.1047123c@romy.j20.helspy.pw> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 03:09:15 -0000 PF synproxy seems to work now on 12. It would be nice to move those changes to 11-stable, because there it is still broken. Just saying. -- Lars Schotte Mudroňova 13 92101 PieÅ¡Å¥any From owner-freebsd-current@freebsd.org Sun Jul 15 08:16:15 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89B49103001B for ; Sun, 15 Jul 2018 08:16:15 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [IPv6:2a01:4f8:191:217b::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.bsd4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 23D277DB05 for ; Sun, 15 Jul 2018 08:16:14 +0000 (UTC) (envelope-from herbert@gojira.at) Date: Sun, 15 Jul 2018 10:16:05 +0200 Message-ID: <87601g29tm.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: freebsd-current@freebsd.org Subject: Re: PF synproxy 12 seems to work now In-Reply-To: <20180715050912.1047123c@romy.j20.helspy.pw> References: <20180715050912.1047123c@romy.j20.helspy.pw> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 08:16:15 -0000 On Sun, 15 Jul 2018 05:09:12 +0200, Lars Schotte wrote: > > PF synproxy seems to work now on 12. > It would be nice to move those changes to 11-stable, because there it > is still broken. Just saying. Are you talking about the following changes? https://lists.freebsd.org/pipermail/svn-src-all/2018-July/167217.html https://lists.freebsd.org/pipermail/svn-src-all/2018-July/167219.html They are marked "MFC after: 1 week", so they should appear in stable/11 soon. -- Herbert From owner-freebsd-current@freebsd.org Sun Jul 15 08:40:13 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49E1D1031214 for ; Sun, 15 Jul 2018 08:40:13 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [144.76.30.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.bsd4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C79B57E962 for ; Sun, 15 Jul 2018 08:40:12 +0000 (UTC) (envelope-from herbert@gojira.at) Date: Sun, 15 Jul 2018 10:40:10 +0200 Message-ID: <874lh028ph.wl-herbert@gojira.at> From: "Herbert J. Skuhra" To: freebsd-current@freebsd.org Subject: Re: local_unbound segfaults at boot In-Reply-To: <20180715031911.2ec8af3d@romy.j20.helspy.pw> References: <20180715031911.2ec8af3d@romy.j20.helspy.pw> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/27.0 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 08:40:13 -0000 On Sun, 15 Jul 2018 03:19:11 +0200, Lars Schotte wrote: > > I see segfaulting too: > > FreeBSD wasp.2km.casa 12.0-CURRENT FreeBSD 12.0-CURRENT #6 r336229: Fri Jul 13 01:51:31 CEST 2018 root@wasp.2km.casa:/usr/obj/usr/src/amd64.amd64/sys/GUSTIK amd64 > # service local_unbound restart > local_unbound not running? (check /var/run/local_unbound.pid). > Starting local_unbound. > Segmentation fault (core dumped) > /etc/rc.d/local_unbound: WARNING: failed to start local_unbound > > # du -sh unbound.core > 23M unbound.core unbound binaries were renamed to local-unbound. https://svnweb.freebsd.org/base?view=revision&revision=333573 # ls -l /usr/sbin/*unbound* -r-xr-xr-x 1 root wheel 150416 Jul 10 16:17 /usr/sbin/local-unbound -r-xr-xr-x 1 root wheel 47944 Jul 10 16:17 /usr/sbin/local-unbound-anchor -r-xr-xr-x 1 root wheel 35608 Jul 10 16:17 /usr/sbin/local-unbound-checkconf -r-xr-xr-x 1 root wheel 39736 Jul 10 16:17 /usr/sbin/local-unbound-control -r-xr-xr-x 1 root wheel 11030 Jul 10 16:17 /usr/sbin/local-unbound-setup Did you forget to run mergemaster, 'make delete-old' and 'make delete-old-libs' after the upgrade? -- Herbert From owner-freebsd-current@freebsd.org Sun Jul 15 14:49:34 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E213010419FD for ; Sun, 15 Jul 2018 14:49:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic302-3.consmr.mail.bf2.yahoo.com (sonic302-3.consmr.mail.bf2.yahoo.com [74.6.135.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 81DD38A68D for ; Sun, 15 Jul 2018 14:49:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 3PO7Pw4VM1nHe8dOAotzxuQCl0mYKFG.hFhIJniFpk13RD.PdULp9sSg7GqUW9w YeFs4s0hXSmsyDJeZHLQ0.mzHtCoMmBm.q42dvKeplkiG12L3BLzHab1IWiRnFGX_qQ1pJn1VSu8 6n1F3.cDXDidR8uUJGwHOvRrvlFgK.8ZrKr098U04xg6tt0eADpWMLz0OjqUdTsq_TRDMd11cVxz qR85LuUnkW0hwAa2HboOTgoWd60Q5TkHfnPYrPgEFgpxaWoeR2DnfLlhzRemFcn1uXlVw2EOB1qk 19LJ8dedMYuclUWJDRrWP0U85NKklmo.nUpu4PynBADdWVRrt4aEKerxmrneXHay6JdgWx8sbbUE 5yn3DbkgAK5C6OS0QuYfpE3LcEf6GHZ_Cns7JSoHARDByl2OYAfbnxRgWO30TWemno2hqSjPHeUN FZJ6ZP7rkjIP7ZRyDqYK_Fv0jDYUtBtnKGmz0Kw5nh_.b1h4J.NUhrzVN5WCmOucdMzqKytFiX57 KbpXlse2ZQlmnx.h.vOPFp5F6Y48OjXUWdTpGOa4uwea0hd1604lbpy22weOesj_Y6hGjwXVRbcl 1vwPG1__x4lJ87IusPEwNwweVCte6IME.Rwjny2n_KZYNdhHxsgBhOgj5R9hc3_wWG_zlUO9ML5C hfSJ.4nTw_hbVrK71JZwyJUMThMXEfbGndfGx11aGhitBcvYeUEnwBvJZ5vaCK01o.lS8hh__F58 AdIB.pacKqkgQZTcKg62L5yErrPxmpHcHWdrurG1He8D9L.kqweKt5UfuhZw4oigIS2kfdkFTh4E IHLCZPPXgDnUaPL3Wbe72RnHO25fwtGl0Gi1flOglk7VhChSnRNQMYDKF_9.ldhOE.O0Qrd0z2H3 VuvN0vYfNF.0ix74GN43zxSXVMh0aGDfk3VOy3iEZ.W51JO7BGIaJMJhfE4uGQbI1oAzJ5MkePQF 1MsyyS.WvRbNC1BxzF3VxQ2mxJjQi0_CWI8eBkEYiTbmaKw2P6mYFbMQsBrCCdwnH Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.bf2.yahoo.com with HTTP; Sun, 15 Jul 2018 14:49:33 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp425.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 85e73594894aeb508d4b36d434c87148; Sun, 15 Jul 2018 14:49:31 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: emulators/virtualbox-ose-additions-nox11 fails to build in poudriere-devel for amd64 context: fails CTASSERT(sizeof(struct pcpu) == UMA_PCPU_ALLOC_SIZE) Message-Id: Date: Sun, 15 Jul 2018 07:49:29 -0700 To: jkim@FreeBSD.org, FreeBSD Current , FreeBSD Ports X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 14:49:34 -0000 The failure: kBuild: Compiling VBoxGuestR0Lib - = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibPhysHeap.cp= p In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/GuestHost/HGSMI/HGSMIMemAlloc.cpp:55: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/HGSMIMemAlloc.h:31: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/HGSMIDefs.h:35: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/VBoxVideoIPRT.h:32: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/iprt/string.h:45: In file included from /usr/src/sys/sys/libkern.h:41: In file included from /usr/src/sys/sys/systm.h:112: /usr/src/sys/sys/pcpu.h:207:1: error: static_assert failed "compile-time = assertion failed" CTASSERT(sizeof(struct pcpu) =3D=3D UMA_PCPU_ALLOC_SIZE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/src/sys/sys/systm.h:107:21: note: expanded from macro 'CTASSERT' #define CTASSERT(x) _Static_assert(x, "compile-time assertion = failed") ^ ~ (There are other example places that fail the same assert condition.) There is also a warning for PAGE_SIZE being redefined: In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibInit.cpp:33= : In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/iprt/string.h:45: In file included from /usr/src/sys/sys/libkern.h:41: In file included from /usr/src/sys/sys/systm.h:111: In file included from /usr/src/sys/sys/param.h:141: /usr/include/machine/param.h:101:9: warning: 'PAGE_SIZE' macro redefined = [-Wmacro-redefined] #define PAGE_SIZE (1< Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79C23104250D for ; Sun, 15 Jul 2018 15:07:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 14A068B16F for ; Sun, 15 Jul 2018 15:07:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FF6cid030179 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sun, 15 Jul 2018 08:06:38 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FF6cT7030178 for freebsd-current@freebsd.org; Sun, 15 Jul 2018 08:06:38 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 08:06:38 -0700 From: Steve Kargl To: freebsd-current@freebsd.org Subject: [PATCH] Recent libm additions Message-ID: <20180715150638.GA30154@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 15:07:04 -0000 Apparently, the recents additions to libm were not subject to any code review. The following patch does two things. First, it works around https://bugs.llvm.org/show_bug.cgi?id=8532 Second, it removes the pollution of libm with the polevll.c functions. Those functions are used only in ld80/e_powl.c, and those functions should be inlined. Index: Makefile =================================================================== --- Makefile (revision 336304) +++ Makefile (working copy) @@ -56,7 +56,6 @@ imprecise.c \ k_cos.c k_cosf.c k_exp.c k_expf.c k_rem_pio2.c k_sin.c k_sinf.c \ k_tan.c k_tanf.c \ - polevll.c \ s_asinh.c s_asinhf.c s_atan.c s_atanf.c s_carg.c s_cargf.c s_cargl.c \ s_cbrt.c s_cbrtf.c s_ceil.c s_ceilf.c s_clog.c s_clogf.c \ s_copysign.c s_copysignf.c s_cos.c s_cosf.c \ Index: ld80/e_powl.c =================================================================== --- ld80/e_powl.c (revision 336304) +++ ld80/e_powl.c (working copy) @@ -77,6 +77,7 @@ #include #include "math_private.h" +#include "polevll.c" /* Table size */ #define NXT 32 Index: src/math_private.h =================================================================== --- src/math_private.h (revision 336304) +++ src/math_private.h (working copy) @@ -828,7 +828,4 @@ long double __kernel_cosl(long double, long double); long double __kernel_tanl(long double, long double, int); -long double __p1evll(long double, void *, int); -long double __polevll(long double, void *, int); - #endif /* !_MATH_PRIVATE_H_ */ Index: src/polevll.c =================================================================== --- src/polevll.c (revision 336304) +++ src/polevll.c (working copy) @@ -69,7 +69,7 @@ * Polynomial evaluator: * P[0] x^n + P[1] x^(n-1) + ... + P[n] */ -long double +static inline long double __polevll(long double x, void *PP, int n) { long double y; @@ -88,7 +88,7 @@ * Polynomial evaluator: * x^n + P[0] x^(n-1) + P[1] x^(n-2) + ... + P[n] */ -long double +static inline long double __p1evll(long double x, void *PP, int n) { long double y; Index: src/s_cpow.c =================================================================== --- src/s_cpow.c (revision 336304) +++ src/s_cpow.c (working copy) @@ -60,7 +60,7 @@ y = cimag (z); absa = cabs (a); if (absa == 0.0) { - return (0.0 + 0.0 * I); + return (CMPLX(0.0, 0.0)); } arga = carg (a); r = pow (absa, x); @@ -69,6 +69,6 @@ r = r * exp (-y * arga); theta = theta + y * log (absa); } - w = r * cos (theta) + (r * sin (theta)) * I; + w = CMPLX(r * cos (theta), r * sin (theta)); return (w); } Index: src/s_cpowf.c =================================================================== --- src/s_cpowf.c (revision 336304) +++ src/s_cpowf.c (working copy) @@ -59,7 +59,7 @@ y = cimagf(z); absa = cabsf (a); if (absa == 0.0f) { - return (0.0f + 0.0f * I); + return (CMPLXF(0.0f, 0.0f)); } arga = cargf (a); r = powf (absa, x); @@ -68,6 +68,6 @@ r = r * expf (-y * arga); theta = theta + y * logf (absa); } - w = r * cosf (theta) + (r * sinf (theta)) * I; + w = CMPLXF(r * cosf (theta), r * sinf (theta)); return (w); } Index: src/s_cpowl.c =================================================================== --- src/s_cpowl.c (revision 336304) +++ src/s_cpowl.c (working copy) @@ -59,7 +59,7 @@ y = cimagl(z); absa = cabsl(a); if (absa == 0.0L) { - return (0.0L + 0.0L * I); + return (CMPLXL(0.0L, 0.0L)); } arga = cargl(a); r = powl(absa, x); @@ -68,6 +68,6 @@ r = r * expl(-y * arga); theta = theta + y * logl(absa); } - w = r * cosl(theta) + (r * sinl(theta)) * I; + w = CMPLXL(r * cosl(theta), r * sinl(theta)); return (w); } -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 16:15:10 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 974871045055 for ; Sun, 15 Jul 2018 16:15:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 323B58D47E for ; Sun, 15 Jul 2018 16:15:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id s7-v6so17552166itb.4 for ; Sun, 15 Jul 2018 09:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6gWWC0KK1R1pzTAoR95oft0jQbu+wb97Fz+t03XhiUM=; b=n3aQh6kL7DPtHkGY891USUYVpjmxrY5Le0zqL2TmajZq/xrTrsy8fvAL4nmZ47KpRN hWKt4rZ+AL6CJgAhOGu7vP64Ei/PFX2dpUR4lxdezxQGeYoPWUFou3iY/VPDYuc8Y00J NRdWH+UvKuJjlejNgOklWEIm4Oq5VgjuE0rwO1WgNCES1deMyxLxuwVcxlb9IHu++bnC SdjAxaSSHWz61daOub/PiILMYIr1MqdL6TyrHM52dmwWu9QJp3lJIlgALlHfd9WDZcLY QTx8mUnortlsDgufQ9JPVlklZFggrRr7u/SBCrhJoeK30Af/3q4de1rr+uTv4XV6ykbe jPaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6gWWC0KK1R1pzTAoR95oft0jQbu+wb97Fz+t03XhiUM=; b=A85BJUAiP6jgLtv8t7sQcUGD99aYwqrjiF0+nOekkgI9YNvDIsuF2nV+5ha+E/sE9o DSuZxyMtvC0uHdoYCJ5VdBgikDO0Oap+AiWFI1Ki78fl5xtlOfkoYe51gjBjQkdJmQZc AmwKMsB5iLo/rxs3E5fSRBlVoxnQo2bUDbIfEVEvCvPuv9wKRLI2Be/3I/+rBVmdtPlp TqDTM7B6V3BMHzazQGfhO/68PdUKjRnEKKegoZlw/8ptwmx6K5kCgG97lH3QBY6LzdmP AgSl0Hg/RD238tvEtlM9G3ShOeDjOCjSl3wdXOMJ9ppAAnfosfbCxum9ku1yf5AcoB+B K8IA== X-Gm-Message-State: AOUpUlECheUdksTd8yTI0fdFHBhXLcP0TR2Hgz+1yhAkzDW1otjmXr74 5K/GQ3QzeJtqEMWvb80QELlOhJ9TbobdOfXeqNuKxg== X-Google-Smtp-Source: AAOMgpdRXteneQ48qQ8qeh+H6WKfSDRCveH5tch8DqyWNxna8xz+RQQppJzRTk+Y9T1BeATLIlktbpGBT99HpZXS+uM= X-Received: by 2002:a24:ad28:: with SMTP id c40-v6mr10277027itf.36.1531671309409; Sun, 15 Jul 2018 09:15:09 -0700 (PDT) MIME-Version: 1.0 References: <20180715150638.GA30154@troutmask.apl.washington.edu> In-Reply-To: <20180715150638.GA30154@troutmask.apl.washington.edu> From: Warner Losh Date: Sun, 15 Jul 2018 10:14:57 -0600 Message-ID: Subject: Re: [PATCH] Recent libm additions To: Steve Kargl Cc: FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 16:15:10 -0000 These changes look perfect to me. Warner On Sun, Jul 15, 2018, 9:08 AM Steve Kargl wrote: > Apparently, the recents additions to libm were not > subject to any code review. The following patch > does two things. First, it works around > > https://bugs.llvm.org/show_bug.cgi?id=8532 > > Second, it removes the pollution of libm with the > polevll.c functions. Those functions are used > only in ld80/e_powl.c, and those functions should > be inlined. > > Index: Makefile > =================================================================== > --- Makefile (revision 336304) > +++ Makefile (working copy) > @@ -56,7 +56,6 @@ > imprecise.c \ > k_cos.c k_cosf.c k_exp.c k_expf.c k_rem_pio2.c k_sin.c k_sinf.c \ > k_tan.c k_tanf.c \ > - polevll.c \ > s_asinh.c s_asinhf.c s_atan.c s_atanf.c s_carg.c s_cargf.c > s_cargl.c \ > s_cbrt.c s_cbrtf.c s_ceil.c s_ceilf.c s_clog.c s_clogf.c \ > s_copysign.c s_copysignf.c s_cos.c s_cosf.c \ > Index: ld80/e_powl.c > =================================================================== > --- ld80/e_powl.c (revision 336304) > +++ ld80/e_powl.c (working copy) > @@ -77,6 +77,7 @@ > #include > > #include "math_private.h" > +#include "polevll.c" > > /* Table size */ > #define NXT 32 > Index: src/math_private.h > =================================================================== > --- src/math_private.h (revision 336304) > +++ src/math_private.h (working copy) > @@ -828,7 +828,4 @@ > long double __kernel_cosl(long double, long double); > long double __kernel_tanl(long double, long double, int); > > -long double __p1evll(long double, void *, int); > -long double __polevll(long double, void *, int); > - > #endif /* !_MATH_PRIVATE_H_ */ > Index: src/polevll.c > =================================================================== > --- src/polevll.c (revision 336304) > +++ src/polevll.c (working copy) > @@ -69,7 +69,7 @@ > * Polynomial evaluator: > * P[0] x^n + P[1] x^(n-1) + ... + P[n] > */ > -long double > +static inline long double > __polevll(long double x, void *PP, int n) > { > long double y; > @@ -88,7 +88,7 @@ > * Polynomial evaluator: > * x^n + P[0] x^(n-1) + P[1] x^(n-2) + ... + P[n] > */ > -long double > +static inline long double > __p1evll(long double x, void *PP, int n) > { > long double y; > Index: src/s_cpow.c > =================================================================== > --- src/s_cpow.c (revision 336304) > +++ src/s_cpow.c (working copy) > @@ -60,7 +60,7 @@ > y = cimag (z); > absa = cabs (a); > if (absa == 0.0) { > - return (0.0 + 0.0 * I); > + return (CMPLX(0.0, 0.0)); > } > arga = carg (a); > r = pow (absa, x); > @@ -69,6 +69,6 @@ > r = r * exp (-y * arga); > theta = theta + y * log (absa); > } > - w = r * cos (theta) + (r * sin (theta)) * I; > + w = CMPLX(r * cos (theta), r * sin (theta)); > return (w); > } > Index: src/s_cpowf.c > =================================================================== > --- src/s_cpowf.c (revision 336304) > +++ src/s_cpowf.c (working copy) > @@ -59,7 +59,7 @@ > y = cimagf(z); > absa = cabsf (a); > if (absa == 0.0f) { > - return (0.0f + 0.0f * I); > + return (CMPLXF(0.0f, 0.0f)); > } > arga = cargf (a); > r = powf (absa, x); > @@ -68,6 +68,6 @@ > r = r * expf (-y * arga); > theta = theta + y * logf (absa); > } > - w = r * cosf (theta) + (r * sinf (theta)) * I; > + w = CMPLXF(r * cosf (theta), r * sinf (theta)); > return (w); > } > Index: src/s_cpowl.c > =================================================================== > --- src/s_cpowl.c (revision 336304) > +++ src/s_cpowl.c (working copy) > @@ -59,7 +59,7 @@ > y = cimagl(z); > absa = cabsl(a); > if (absa == 0.0L) { > - return (0.0L + 0.0L * I); > + return (CMPLXL(0.0L, 0.0L)); > } > arga = cargl(a); > r = powl(absa, x); > @@ -68,6 +68,6 @@ > r = r * expl(-y * arga); > theta = theta + y * logl(absa); > } > - w = r * cosl(theta) + (r * sinl(theta)) * I; > + w = CMPLXL(r * cosl(theta), r * sinl(theta)); > return (w); > } > > -- > Steve > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-current@freebsd.org Sun Jul 15 16:26:50 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7505010457FB for ; Sun, 15 Jul 2018 16:26:50 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-21.consmr.mail.bf2.yahoo.com (sonic312-21.consmr.mail.bf2.yahoo.com [74.6.128.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0A52C8DA34 for ; Sun, 15 Jul 2018 16:26:49 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: exeg_OkVM1m0d7X4XourVLGn56JJBxpRTDCx_1taecAlawhW0OsOAa7csO1jSH3 M_E4Or1v3YKs_S9UYq5UhsQ7BMqamjYPCbTHtMCUwTQm4W4hKuxVwgrYxAVZTcdFl19sbBYfULX1 IdkR0alRvtdLaR4LswC9F1jZYFZexREfdN1LbQQ0VDrYm2OUu3MmDMGd8irNf_QsH9NLANXY2WTe PI1LLAbEGJfRKID6FkrNxvTrWmzOQw14NCsvHR.WCRChEoxA398Ks0zD6AdCPNmq1VxOZXWAYsuy ZBdVZUWvkoFdQyAStOmUuZt7QfpJaM02bKIt3dBVHLe_fLHKgXrkpKUDiixgIakVr.iQFk952VFo 3hJplt9psQIX47_OFMHjk_Q2Hpc.LRT.sokO4f7NVqacgem.WeF9I3fKTZ5V2NSxdMkbaaapQHCd RwEOSZBIDBxCdekWPF0fC1zjxFm7h7T5pw990ksvqQCZKBqQoNLRzWE.0hy1raM70k9jaM5erytL 6jHDBcjgIBXsxNEHEcIiilql6bxWEr0lbVfJJSg_h9.ituos6DozHbr0rm6AvbjLaUbapE6Uzp_C PCqUoCV3MuXsWqbks9mkt.qrrrnlNPOz7i1YDbkW6A9h4cdiPqldoaxC_22XxfTsaQrp7IALP.HQ hK4XzkHkaCKAbQFIwRT71fgL3b2h2ivyFrKtEZdd9C.inzM4iSbwFwlHs1llr1sx7G8SQkbJuysO SOrHbLUZdhE0wNJ4fO5of8FgretsjtMDI0MgznAyi.Jx8BQuztpbH4bRjeqzltnk_Mh7mCHy.vUr bhiu8R2IrXUX.4EIBp3UuTQ76Toj1ksr58OjeAuqeuAlgk0G_l_1D3hBRJB_tST.bcGq7978Qup9 EhJYboEtsS2ujOI9pZlYrzkMogQXvqxq.pIiMPD6j4K7pu.5xNiChHaljbnzBoef3pUjJJGAIzDt egga67kxFKQdzZMWWQKTQBh_XtseBCP2u7WcIzKBTOUOQrJ_EkN48UJ93OfvUI8A- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.bf2.yahoo.com with HTTP; Sun, 15 Jul 2018 16:26:43 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp431.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 083c9ef6050fad2f377dee34875f1311; Sun, 15 Jul 2018 16:26:41 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: emulators/virtualbox-ose-additions-nox11 fails to build in poudriere-devel for amd64 context: fails CTASSERT(sizeof(struct pcpu) == UMA_PCPU_ALLOC_SIZE) Date: Sun, 15 Jul 2018 09:26:39 -0700 References: To: jkim@FreeBSD.org, FreeBSD Current , FreeBSD Ports In-Reply-To: Message-Id: <73DCC023-F5DF-47C2-A1F9-2893924DCC7D@yahoo.com> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 16:26:50 -0000 [The build got to emulators/virtualbox-ose-additions and it also failed this way. The PAGE_SIZE warning did not occur. More notes added after the quoted history.] On 2018-Jul-15, at 7:49 AM, Mark Millard wrote: > The failure: >=20 > kBuild: Compiling VBoxGuestR0Lib - = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibPhysHeap.cp= p > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/GuestHost/HGSMI/HGSMIMemAlloc.cpp:55: > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/HGSMIMemAlloc.h:31: > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/HGSMIDefs.h:35: > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/VBox/Graphics/VBoxVideoIPRT.h:32: > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/iprt/string.h:45: > In file included from /usr/src/sys/sys/libkern.h:41: > In file included from /usr/src/sys/sys/systm.h:112: > /usr/src/sys/sys/pcpu.h:207:1: error: static_assert failed = "compile-time assertion failed" > CTASSERT(sizeof(struct pcpu) =3D=3D UMA_PCPU_ALLOC_SIZE); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /usr/src/sys/sys/systm.h:107:21: note: expanded from macro 'CTASSERT' > #define CTASSERT(x) _Static_assert(x, "compile-time assertion = failed") > ^ ~ >=20 > (There are other example places that fail the same assert condition.) >=20 > There is also a warning for PAGE_SIZE being redefined: >=20 > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/src/VBox/Additions/common/VBoxGuest/lib/VBoxGuestR0LibInit.cpp:33= : > In file included from = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/iprt/string.h:45: > In file included from /usr/src/sys/sys/libkern.h:41: > In file included from /usr/src/sys/sys/systm.h:111: > In file included from /usr/src/sys/sys/param.h:141: > /usr/include/machine/param.h:101:9: warning: 'PAGE_SIZE' macro = redefined [-Wmacro-redefined] > #define PAGE_SIZE (1< ^ > = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions-nox11/work/VirtualBo= x-5.2.14/include/iprt/param.h:52:10: note: previous definition is here > # define PAGE_SIZE 4096 > ^ >=20 >=20 > Context: >=20 >=20 > # uname -apKU > FreeBSD FBSDUSSD 12.0-CURRENT FreeBSD 12.0-CURRENT r336301M amd64 = amd64 1200072 1200072 >=20 >=20 >=20 > # svnlite info /usr/ports | grep "Re[plv]" > Relative URL: ^/head > Repository Root: svn://svn.freebsd.org/ports > Repository UUID: 35697150-7ecd-e111-bb59-0022644237b5 > Revision: 474654 > Last Changed Rev: 474654 >=20 >=20 >=20 > The "M" in r336301M is mostly for use with powerpc* family experiments = based > on modern C/C++ compilers: >=20 > # svnlite status /usr/src/ | sort > ? /usr/src/sys/amd64/conf/GENERIC-DBG > ? /usr/src/sys/amd64/conf/GENERIC-NODBG > ? /usr/src/sys/arm/conf/GENERIC-DBG > ? /usr/src/sys/arm/conf/GENERIC-NODBG > ? /usr/src/sys/arm64/conf/GENERIC-DBG > ? /usr/src/sys/arm64/conf/GENERIC-NODBG > ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-DBG > ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-NODBG > ? /usr/src/sys/powerpc/conf/GENERICvtsc-DBG > ? /usr/src/sys/powerpc/conf/GENERICvtsc-NODBG > M /usr/src/Makefile.libcompat > M /usr/src/contrib/llvm/lib/Target/PowerPC/PPCFrameLowering.cpp > M /usr/src/contrib/llvm/tools/lld/ELF/Arch/PPC64.cpp > M /usr/src/crypto/openssl/crypto/armcap.c > M /usr/src/lib/libkvm/kvm_powerpc.c > M /usr/src/lib/libkvm/kvm_private.c > M /usr/src/release/Makefile.vm > M /usr/src/release/scripts/mk-vmimage.sh > M /usr/src/release/tools/vmimage.subr > M /usr/src/secure/lib/libcrypto/Makefile > M /usr/src/stand/defs.mk > M /usr/src/stand/powerpc/boot1.chrp/Makefile > M /usr/src/stand/powerpc/kboot/Makefile > M /usr/src/sys/arm64/arm64/identcpu.c > M /usr/src/sys/conf/kmod.mk > M /usr/src/sys/conf/ldscript.powerpc > M /usr/src/sys/powerpc/aim/mmu_oea64.c > M /usr/src/sys/powerpc/ofw/ofw_machdep.c emulators/virtualbox-ose-additions also got the error. But it did not get the PAGE_SIZE warning. There was also in both variants the likes of (3 times for each): = /wrkdirs/usr/ports/emulators/virtualbox-ose-additions/work/VirtualBox-5.2.= 14/src/VBox/Runtime/common/asm/ASMSerializeInstruction-iret.asm:46: = warning: `ss' segment register ignored in 64-bit mode And there were lots of notices for: warning: flexible array members are a C99 feature [-Wc99-extensions] warning: 'register' storage class specifier is deprecated and = incompatible with C++17 [-Wdeprecated-register] =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Sun Jul 15 17:00:54 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7AB351046DA1 for ; Sun, 15 Jul 2018 17:00:54 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B37C8EBA4 for ; Sun, 15 Jul 2018 17:00:53 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 9b3366f1-8850-11e8-aa1a-954dbaed88ca X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 9b3366f1-8850-11e8-aa1a-954dbaed88ca; Sun, 15 Jul 2018 17:00:44 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6FH0fxG049589; Sun, 15 Jul 2018 11:00:41 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1531674041.26036.1.camel@freebsd.org> Subject: Re: [PATCH] Recent libm additions From: Ian Lepore To: sgk@troutmask.apl.washington.edu, freebsd-current@freebsd.org Date: Sun, 15 Jul 2018 11:00:41 -0600 In-Reply-To: <20180715150638.GA30154@troutmask.apl.washington.edu> References: <20180715150638.GA30154@troutmask.apl.washington.edu> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:00:54 -0000 On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote: > Apparently, the recents additions to libm were not > subject to any code review.  The following patch  > does two things.  First, it works around > > https://bugs.llvm.org/show_bug.cgi?id=8532 > > Second, it removes the pollution of libm with the > polevll.c functions.  Those functions are used  > only in ld80/e_powl.c, and those functions should > be inlined. > > Index: Makefile > =================================================================== > --- Makefile (revision 336304) > +++ Makefile (working copy) > @@ -56,7 +56,6 @@ >   imprecise.c \ >   k_cos.c k_cosf.c k_exp.c k_expf.c k_rem_pio2.c k_sin.c k_sinf.c \ >   k_tan.c k_tanf.c \ > - polevll.c \ >   s_asinh.c s_asinhf.c s_atan.c s_atanf.c s_carg.c s_cargf.c s_cargl.c \ >   s_cbrt.c s_cbrtf.c s_ceil.c s_ceilf.c s_clog.c s_clogf.c \ >   s_copysign.c s_copysignf.c s_cos.c s_cosf.c \ > Index: ld80/e_powl.c > =================================================================== > --- ld80/e_powl.c (revision 336304) > +++ ld80/e_powl.c (working copy) > @@ -77,6 +77,7 @@ >  #include >   >  #include "math_private.h" > +#include "polevll.c" >   >  /* Table size */ >  #define NXT 32 > Index: src/math_private.h > =================================================================== > --- src/math_private.h (revision 336304) > +++ src/math_private.h (working copy) > @@ -828,7 +828,4 @@ >  long double __kernel_cosl(long double, long double); >  long double __kernel_tanl(long double, long double, int); >   > -long double __p1evll(long double, void *, int); > -long double __polevll(long double, void *, int); > - >  #endif /* !_MATH_PRIVATE_H_ */ > Index: src/polevll.c > =================================================================== > --- src/polevll.c (revision 336304) > +++ src/polevll.c (working copy) > @@ -69,7 +69,7 @@ >   * Polynomial evaluator: >   *  P[0] x^n  +  P[1] x^(n-1)  +  ...  +  P[n] >   */ > -long double > +static inline long double >  __polevll(long double x, void *PP, int n) >  { >   long double y; > @@ -88,7 +88,7 @@ >   * Polynomial evaluator: >   *  x^n  +  P[0] x^(n-1)  +  P[1] x^(n-2)  +  ...  +  P[n] >   */ > -long double > +static inline long double >  __p1evll(long double x, void *PP, int n) >  { >   long double y; > Index: src/s_cpow.c > =================================================================== > --- src/s_cpow.c (revision 336304) > +++ src/s_cpow.c (working copy) > @@ -60,7 +60,7 @@ >   y = cimag (z); >   absa = cabs (a); >   if (absa == 0.0) { > - return (0.0 + 0.0 * I); > + return (CMPLX(0.0, 0.0)); >   } >   arga = carg (a); >   r = pow (absa, x); > @@ -69,6 +69,6 @@ >   r = r * exp (-y * arga); >   theta = theta + y * log (absa); >   } > - w = r * cos (theta) + (r * sin (theta)) * I; > + w = CMPLX(r * cos (theta),  r * sin (theta)); >   return (w); >  } > Index: src/s_cpowf.c > =================================================================== > --- src/s_cpowf.c (revision 336304) > +++ src/s_cpowf.c (working copy) > @@ -59,7 +59,7 @@ >   y = cimagf(z); >   absa = cabsf (a); >   if (absa == 0.0f) { > - return (0.0f + 0.0f * I); > + return (CMPLXF(0.0f, 0.0f)); >   } >   arga = cargf (a); >   r = powf (absa, x); > @@ -68,6 +68,6 @@ >   r = r * expf (-y * arga); >   theta = theta + y * logf (absa); >   } > - w = r * cosf (theta) + (r * sinf (theta)) * I; > + w = CMPLXF(r * cosf (theta), r * sinf (theta)); >   return (w); >  } > Index: src/s_cpowl.c > =================================================================== > --- src/s_cpowl.c (revision 336304) > +++ src/s_cpowl.c (working copy) > @@ -59,7 +59,7 @@ >   y = cimagl(z); >   absa = cabsl(a); >   if (absa == 0.0L) { > - return (0.0L + 0.0L * I); > + return (CMPLXL(0.0L, 0.0L)); >   } >   arga = cargl(a); >   r = powl(absa, x); > @@ -68,6 +68,6 @@ >   r = r * expl(-y * arga); >   theta = theta + y * logl(absa); >   } > - w = r * cosl(theta) + (r * sinl(theta)) * I; > + w = CMPLXL(r * cosl(theta), r * sinl(theta)); >   return (w); >  } > If a file contains inline function definitions and is intended only to be included into another file and not compiled separately, shouldn't its name be spelled polevll.h ? -- Ian From owner-freebsd-current@freebsd.org Sun Jul 15 17:17:39 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 86E8F1047757 for ; Sun, 15 Jul 2018 17:17:39 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 185BA8F626; Sun, 15 Jul 2018 17:17:39 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FHHbhY031212 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 10:17:37 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FHHbkn031211; Sun, 15 Jul 2018 10:17:37 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 10:17:37 -0700 From: Steve Kargl To: Ian Lepore Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715171737.GA31164@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1531674041.26036.1.camel@freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:17:39 -0000 On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote: > On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote: > > Index: ld80/e_powl.c > > =================================================================== > > --- ld80/e_powl.c (revision 336304) > > +++ ld80/e_powl.c (working copy) > > @@ -77,6 +77,7 @@ > >  #include > >   > >  #include "math_private.h" > > +#include "polevll.c" > > If a file contains inline function definitions and is intended only to > be included into another file and not compiled separately, shouldn't > its name be spelled polevll.h ? > Well, actually, the functions in polevll.c should have been copied into ld80/e_powl.c, and polevall.c should never have been committed. Unfortunately, the code was not reviewed for correctness. I've made the minimum changes to address the two issues I've noted. Feel free to either copy the functions and delete the polevall.c or rename it. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 17:21:29 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63F2710479EE for ; Sun, 15 Jul 2018 17:21:29 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE0818F96D; Sun, 15 Jul 2018 17:21:28 +0000 (UTC) (envelope-from kmacybsd@gmail.com) Received: by mail-lj1-x243.google.com with SMTP id r13-v6so27999557ljg.10; Sun, 15 Jul 2018 10:21:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=dLzkpXqTZLk2cah4oLKjW26s0brQ285w8ajBwxtF5N0=; b=IUaP5BEuFzD9VVRCg51cAjwlm9jyXAm5nm/RH6C8QPPsiNYGujSGbo9QwsbejYzHdf cI1Gwy6C0z9zyC8HSWEqhohpMYwALEFQsBQMzvUJXSxyCvIa8WQwoWGh2vQO3yfvGOyw Vp34R7dstDFEdtf1x3hCGvsm7NcCSwC9+kvTI5j/sFdxwYLVwRsKKkL55kCKh2Gp/K5Q hR12n5Rq3iVXUSebh1imSjUF1QAac2KjEOxTyneoodAS2sCeWOtyZx7QsrWPe84qrK14 5RXY7SBjC2DOM8gfM8RmtLSam4Sgismc0c+DiM2gm4ihpX5V9CKbfWB3lXQd5QhUdNYD TYrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=dLzkpXqTZLk2cah4oLKjW26s0brQ285w8ajBwxtF5N0=; b=PQJe25O1hq4bRAnR0QlRxIVP3Yio1xeEgxg/w116T6q2OUxSauRKzcfdNCSdpRqmsm i6d32oShB3nHe3jS1l9jRi/Q6BumtrFk3nT2fZoIdiSuVSHhSITWX7F84rJnzsOAz7nL 6ffpemIDETy8TXkQ3+MZwxTQ+jjZodgPVisvHO5T99Aip92pxp+iif0bdiRFxX8aosYO FWS6sna7M/9e40yyCwjSlH3ZEFP0tSJHbYZ6NBLidiVPXjilsyfCnDyFKVFj5cmGszkD kEbUdzAj77VK7yrsyUPWA45dpgosNsqgEGLHFGEHXRmX4QnMGMfBGwRr8YOKtS9aSPzC zTxg== X-Gm-Message-State: AOUpUlGAtsRhiXJeuJ6cfg/diIumi/9pnrmxIVogKbZOSvY3mz8fQhTa 424fMQm9+m3bO2DOjawF70/8qpuAbLaulP7IkeUzN9M8 X-Google-Smtp-Source: AAOMgpeqTTAkbHuplkTWLrysUnASIrtMF0Eqeuy3B2q9r2BCAMZSYhestAcsgHkzPjVmDiTJf5WKlI99N/plCPTf+Qs= X-Received: by 2002:a2e:44c6:: with SMTP id b67-v6mr8521961ljf.102.1531675286182; Sun, 15 Jul 2018 10:21:26 -0700 (PDT) MIME-Version: 1.0 Sender: kmacybsd@gmail.com Received: by 2002:a2e:5b06:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 10:21:25 -0700 (PDT) In-Reply-To: <20180715171737.GA31164@troutmask.apl.washington.edu> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> From: "K. Macy" Date: Sun, 15 Jul 2018 10:21:25 -0700 X-Google-Sender-Auth: lmhEEu2SSaGpj4uqabcqeWCMXYk Message-ID: Subject: Re: [PATCH] Recent libm additions To: Steve Kargl Cc: Ian Lepore , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:21:29 -0000 > > Well, actually, the functions in polevll.c should have been copied > into ld80/e_powl.c, and polevall.c should never have been committed. > Unfortunately, the code was not reviewed for correctness. That is not correct. Please stop repeating it. Bruce Evans and John Baldwin were both looped in. Neither made this observation. From owner-freebsd-current@freebsd.org Sun Jul 15 17:56:07 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9001710489F4 for ; Sun, 15 Jul 2018 17:56:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E1F290A0E for ; Sun, 15 Jul 2018 17:56:07 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x241.google.com with SMTP id g11-v6so2318656ioq.9 for ; Sun, 15 Jul 2018 10:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=brOxAyH01yXs0LKp0hAjyU3y6O4QOEB/YO/bPDfYbXE=; b=zmHXQVpZQ5T8kfWlml5yzxUtBdXezObTEjdAt/8mnG0oFu2Z/FDtqrhVMYuXBSWhhe uvmz7c3iiImBzS0oDvs0xE+FIC6LlIq1B3T+3j8GGLrV9oH5WBgyVJ82iT9Ycl1RTPUV bO9YgBdiXBx0iUwYZcXREPt0Fv/z6mGOHkaDcEQwVknyZVn3mkLVGkIBnWeQcivHNP2p W40SRVFLPCgiwt6KCceYgsabf5e+LTJL8wfnCmu2Vv8N8A7l2GLDotl2N6NjlwTUDyKU wI+GDmnH4yUaYsBd4ecE1wE07O6KbV7+a6tulNVk3NSC8Ec2bzWitIJCa0MpJDf1KroB 4UJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=brOxAyH01yXs0LKp0hAjyU3y6O4QOEB/YO/bPDfYbXE=; b=mNSprYAb7pKYdxbPGXvjF62MOAnU7SVF29lQ0GSIPvFBYKISSuW1cN96dyYe5YPNGD uEMEX0U2E090QeHPq2hno+A7muXLlhfnxV3MpTT9VlkDPiCqVzBC+tfC+TMO0QYXaMyf X5j4RUuNejCUbmh1x3O+e9XuU1SdGb8HsBrfuPrHZMT8eJN2rULWZSg0GqWlCPGADJb1 nKoz1VAV9baiVA6TCUSckBHdYA1uPwtHHwju1hYQSxhAIFBUigYPqr8ra/9L7I0RDhHD DI/ljdq82p4MY44hVuf5yPjfR1Ec9AzOBWAAywimevP/yWKSHSXE9fBmnDcZjX2whHYy +BYQ== X-Gm-Message-State: AOUpUlHVDVe7jEh54oa2kFbJ0Mk4B1qPxkoSu++EvHw2Je23qpu/F8t5 ays55IHr+9Cu904tUIuPPPImGwHp9dSJWYeDqheExg== X-Google-Smtp-Source: AAOMgpfiivYJuSzCrmGLNdVf9cdvv3wFUfQ4Jp+pxBsRGcb/Ql9wZEFzbR0BDhNNAd5qUz0dwlfnCwqHOS5ydKeBdq0= X-Received: by 2002:a6b:3902:: with SMTP id g2-v6mr30486077ioa.168.1531677366323; Sun, 15 Jul 2018 10:56:06 -0700 (PDT) MIME-Version: 1.0 References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> In-Reply-To: From: Warner Losh Date: Sun, 15 Jul 2018 11:55:54 -0600 Message-ID: Subject: Re: [PATCH] Recent libm additions To: "K. Macy" Cc: Steve Kargl , Ian Lepore , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:56:07 -0000 On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: > > > > Well, actually, the functions in polevll.c should have been copied > > into ld80/e_powl.c, and polevall.c should never have been committed. > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > Baldwin were both looped in. Neither made this observation. > Steve is the fp guy these days. And it wasn't reviewed by him. He's mad you cut him out of the loop. Arguing about pedantic points of process does no one any good. Warner _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-current@freebsd.org Sun Jul 15 18:03:54 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2FBA01049118 for ; Sun, 15 Jul 2018 18:03:54 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D2CC491177; Sun, 15 Jul 2018 18:03:53 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 9469C237F4; Sun, 15 Jul 2018 18:03:53 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-it0-f53.google.com with SMTP id 198-v6so9777026ite.4; Sun, 15 Jul 2018 11:03:53 -0700 (PDT) X-Gm-Message-State: AOUpUlFMHjJI82DhAGN5SrLd28uXFPnn5KG4LBhCwpuS2yLyuyjgl3/S wtEW5NJyp4ZfmRykqCyFC7lVy3wGK2VDG593/0g= X-Google-Smtp-Source: AAOMgpedsNO06O70us9+SwcETX9AXje4XmHmAB0QvuXbvlSl4xxV5Q+dGE8cobypvOMEhTj4+ynK4tt3+YAVOyY1w5w= X-Received: by 2002:a24:6c04:: with SMTP id w4-v6mr10403787itb.4.1531677832708; Sun, 15 Jul 2018 11:03:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 11:03:52 -0700 (PDT) In-Reply-To: References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> From: Matthew Macy Date: Sun, 15 Jul 2018 11:03:52 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Recent libm additions To: Warner Losh Cc: Steve Kargl , Ian Lepore , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:03:54 -0000 On Sun, Jul 15, 2018 at 10:55 AM, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: > >> > >> > Well, actually, the functions in polevll.c should have been copied >> > into ld80/e_powl.c, and polevall.c should never have been committed. >> > Unfortunately, the code was not reviewed for correctness. >> >> That is not correct. Please stop repeating it. Bruce Evans and John >> Baldwin were both looped in. Neither made this observation. >> > > Steve is the fp guy these days. And it wasn't reviewed by him. He's mad you > cut him out of the loop. Arguing about pedantic points of process does no > one any good. Thanks for the tip. I'm sorry. I was under the impression that he gave up his bit: https://reviews.freebsd.org/rD46886 So we have a maintainer who has opted to not have a bit. So be it. Nonetheless, reviews.freebsd.org is the established channel by which the project does code reviews. I stand by my recommendation and will add him to reviews in the future. From owner-freebsd-current@freebsd.org Sun Jul 15 18:06:50 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D333910493D8 for ; Sun, 15 Jul 2018 18:06:50 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6568791510 for ; Sun, 15 Jul 2018 18:06:50 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: d7428e51-8859-11e8-8837-614b7c574d04 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id d7428e51-8859-11e8-8837-614b7c574d04; Sun, 15 Jul 2018 18:06:48 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6FI6lLe049730; Sun, 15 Jul 2018 12:06:47 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1531678007.26036.10.camel@freebsd.org> Subject: Re: [PATCH] Recent libm additions From: Ian Lepore To: Warner Losh , "K. Macy" Cc: Steve Kargl , FreeBSD Current Date: Sun, 15 Jul 2018 12:06:47 -0600 In-Reply-To: References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:06:51 -0000 On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: > > > > > > > > > > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > > > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. > > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian From owner-freebsd-current@freebsd.org Sun Jul 15 18:26:04 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D6841049EAA for ; Sun, 15 Jul 2018 18:26:04 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9808F91E7E; Sun, 15 Jul 2018 18:26:03 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FIQ0X6031766 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 11:26:00 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FIQ0l4031765; Sun, 15 Jul 2018 11:26:00 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 11:26:00 -0700 From: Steve Kargl To: "K. Macy" Cc: Ian Lepore , FreeBSD Current Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715182600.GB31164@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:26:04 -0000 On Sun, Jul 15, 2018 at 10:21:25AM -0700, K. Macy wrote: > > > > Well, actually, the functions in polevll.c should have been copied > > into ld80/e_powl.c, and polevall.c should never have been committed. > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > Baldwin were both looped in. Neither made this observation. I read the differential review. The code was not reviewed by John. He reviewed how it was hooked into the build. Bruce does not appear in the differential review. There is no record on freebsd-numerics about the patch. powl on i686-class hardware is likely broken as it does not use the LD80C macro to construct literal constants. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 18:33:39 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA62F104A31C for ; Sun, 15 Jul 2018 18:33:39 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4975092647; Sun, 15 Jul 2018 18:33:39 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FIXbLe031877 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 11:33:37 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FIXbeE031876; Sun, 15 Jul 2018 11:33:37 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 11:33:37 -0700 From: Steve Kargl To: Ian Lepore Cc: Warner Losh , "K. Macy" , FreeBSD Current Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715183337.GC31164@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> <1531678007.26036.10.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531678007.26036.10.camel@freebsd.org> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:33:39 -0000 On Sun, Jul 15, 2018 at 12:06:47PM -0600, Ian Lepore wrote: > > On the other hand, what information is there for someone to know that > Steve should be involved in a review? There is nothing in MAINTAINERS. > The review was on phab for almost a month, and phab is supposedly the > preferred way to do reviews these days. > > Steve is no longer a committer, but that doesn't preclude him having a > phab account and participating in reviews. If he doesn't like using > phab (and I can certainly understand that POV), an entry in MAINTAINERS > would still be helpful, unless we have a rule that only committers can > be listed in there. > Patch should be sent the the freebsd-numeric mailing list. phab appear after I was forced to hand in my commit bit, so I don't have a phab account. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 18:38:54 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0C32104A56F for ; Sun, 15 Jul 2018 18:38:54 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 654DA92802; Sun, 15 Jul 2018 18:38:54 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FIcrMa031944 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 11:38:53 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FIcrCE031943; Sun, 15 Jul 2018 11:38:53 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 11:38:53 -0700 From: Steve Kargl To: Matthew Macy Cc: Ian Lepore , freebsd-current Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715183853.GD31164@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:38:55 -0000 On Sun, Jul 15, 2018 at 10:44:28AM -0700, Matthew Macy wrote: > > In the bug report you cite, Chris Lattner states: "This is actually an > unspecified feature of C99 (whether it supports the _Imaginary type). > It is desirable to support this, but not a regression. > Chris Lattner is wrong when the use of I in an express gives the wrong answer. He can claim Annex F and G are non-normative, but a wrong answer is still wrong. Go read msun/src/math_private.h. FreeBSD clearly does not use I in libm code, because it has consequences for floating point numerical code. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 17:44:30 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01C6B104866B for ; Sun, 15 Jul 2018 17:44:30 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CEFE90631; Sun, 15 Jul 2018 17:44:29 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-it0-x241.google.com with SMTP id v71-v6so17973320itb.3; Sun, 15 Jul 2018 10:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0gzE8Xpbkd4B3CEowvZJQ6uftitCzna94IN9wQ1brRE=; b=a65sHbwYQsbZPAzrsGDNPOeLPNd9pHGRFbKIpGNprJUMgNPnPB9bU+QNxJmRxNnhfQ EFIiS8mOYjzYhVg4LqL7ViKNjjC1hiSwk545V2SJpfy1ziaZyLuqW1dWr0eCcojOvAeF Pj3QNJ2GapfhnyIpe9SjsRjfRdNtYmMnoLdR1Hz2w2UL1qI3PcAGgfEJLIkt5MKeA0ST PqVLHR5A1ofVGIMHlVR4x+mUvoFs5fyyArHGDa/eVtaZVKlgh+NR33PnpcAm6pNfoQJf 5RAs81hb+jvtV9a1VuyUlR9zbV0P9e+Dz3W84LqtC+1B/huAn0R3BrunmlXXcs2g2GkZ 8+oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0gzE8Xpbkd4B3CEowvZJQ6uftitCzna94IN9wQ1brRE=; b=KJ847HwYe5P7IYMUUwJ88k0fBu3KBxkdSADyyPdTLyHfdvwEOpKK71QSDPcTKsdBdh hXNRdmhIBL0QdsRgTYj+XQ+vovMuSTThqOb4hbQKzjpqMzCeJRJnAp7e9iNqbvjJymhL 2wTW3cXHJiSZJU5jMxio8hB9QBCAskOc1pkJhp8/UvJXymDj5uqeXwNltIaYcexDlsPn WBY6mWuh5+SNIx0XWX6Ixx4zcKTCt3Tisu24Gfyd2wT10rYEEtcrPrSntLjabo4xdzRL mPD8mdX2qKZmD9T0XJAKxKukst6Ctg9VUgBpJos21o85FxNe1DycOsjFbl6PGIbMPp0n WVjw== X-Gm-Message-State: AOUpUlE4ibBhYuCZjTkaaPkCEsonrO+gr2EVzXFL9XHMV5Fy0svAdpaO AxvDiAY96ldKbIvwePLWuBvC9+sR43UZDscNYTAAZg== X-Google-Smtp-Source: AAOMgpdnlh7Rb6BLWwznYiBNUzpUBVusaSqs2Q1xxaPtCUxtw+44d0W+Fd7QovpmhkxXp2YZwnZjAs/HmYMaUpnp/s0= X-Received: by 2002:a24:1dd6:: with SMTP id 205-v6mr10233139itj.132.1531676668625; Sun, 15 Jul 2018 10:44:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 10:44:28 -0700 (PDT) In-Reply-To: <20180715171737.GA31164@troutmask.apl.washington.edu> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> From: Matthew Macy Date: Sun, 15 Jul 2018 10:44:28 -0700 Message-ID: Subject: Re: [PATCH] Recent libm additions To: sgk@troutmask.apl.washington.edu Cc: Ian Lepore , freebsd-current Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 15 Jul 2018 18:40:51 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 17:44:30 -0000 On Sun, Jul 15, 2018 at 10:17 AM, Steve Kargl wrote: > On Sun, Jul 15, 2018 at 11:00:41AM -0600, Ian Lepore wrote: >> On Sun, 2018-07-15 at 08:06 -0700, Steve Kargl wrote: >> > Index: ld80/e_powl.c >> > =================================================================== >> > --- ld80/e_powl.c (revision 336304) >> > +++ ld80/e_powl.c (working copy) >> > @@ -77,6 +77,7 @@ >> > #include >> > >> > #include "math_private.h" >> > +#include "polevll.c" >> >> If a file contains inline function definitions and is intended only to >> be included into another file and not compiled separately, shouldn't >> its name be spelled polevll.h ? >> > > Well, actually, the functions in polevll.c should have been copied > into ld80/e_powl.c, and polevall.c should never have been committed. > Unfortunately, the code was not reviewed for correctness. I've > made the minimum changes to address the two issues I've noted. > Feel free to either copy the functions and delete the polevall.c > or rename it. > In the bug report you cite, Chris Lattner states: "This is actually an unspecified feature of C99 (whether it supports the _Imaginary type). It is desirable to support this, but not a regression. I'm more than happy to commit these changes, but neither including a .c file nor compensating for the absence of a gcc feature in clang is a correctness fix. In the future you might wish to subscribe to phab reviews so that you can be notified when changes like this are under consideration. Thank you for your input. -M From owner-freebsd-current@freebsd.org Sun Jul 15 18:41:03 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26188104A6BE for ; Sun, 15 Jul 2018 18:41:03 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C847992980; Sun, 15 Jul 2018 18:41:02 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: mmacy) by smtp.freebsd.org (Postfix) with ESMTPSA id 8B6D223B04; Sun, 15 Jul 2018 18:41:02 +0000 (UTC) (envelope-from mmacy@freebsd.org) Received: by mail-io0-f182.google.com with SMTP id q4-v6so35714770iob.2; Sun, 15 Jul 2018 11:41:02 -0700 (PDT) X-Gm-Message-State: AOUpUlFpIx40zro9oeg3dLG6fzbsSjEY5cUEQUS5pec2tDLbSIATw4qp i9S1zyRWSFUItdynl3ixn8tnU1CdjIFNUnrhTYc= X-Google-Smtp-Source: AAOMgpfetim0rzMiKyNTwcT8ivxnzKj1uePX0MA5V+C+6dXkqCeo+ltUEEz4VLjYFhST/ccmNRSp2PLEXIJ4H0xvX8U= X-Received: by 2002:a5e:dc49:: with SMTP id s9-v6mr26001694iop.237.1531680061931; Sun, 15 Jul 2018 11:41:01 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 11:41:01 -0700 (PDT) In-Reply-To: <20180715183337.GC31164@troutmask.apl.washington.edu> References: <20180715150638.GA30154@troutmask.apl.washington.edu> <1531674041.26036.1.camel@freebsd.org> <20180715171737.GA31164@troutmask.apl.washington.edu> <1531678007.26036.10.camel@freebsd.org> <20180715183337.GC31164@troutmask.apl.washington.edu> From: Matthew Macy Date: Sun, 15 Jul 2018 11:41:01 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] Recent libm additions To: Steve Kargl Cc: Ian Lepore , Warner Losh , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:41:03 -0000 On Sun, Jul 15, 2018 at 11:33 AM, Steve Kargl wrote: > On Sun, Jul 15, 2018 at 12:06:47PM -0600, Ian Lepore wrote: >> >> On the other hand, what information is there for someone to know that >> Steve should be involved in a review? There is nothing in MAINTAINERS. >> The review was on phab for almost a month, and phab is supposedly the >> preferred way to do reviews these days. >> >> Steve is no longer a committer, but that doesn't preclude him having a >> phab account and participating in reviews. If he doesn't like using >> phab (and I can certainly understand that POV), an entry in MAINTAINERS >> would still be helpful, unless we have a rule that only committers can >> be listed in there. >> > > Patch should be sent the the freebsd-numeric mailing list. > phab appear after I was forced to hand in my commit bit, so > I don't have a phab account. Anyone can have a phab account. -M From owner-freebsd-current@freebsd.org Sun Jul 15 18:43:07 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA028104A92C for ; Sun, 15 Jul 2018 18:43:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B28C92CF6; Sun, 15 Jul 2018 18:43:06 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id elyxfrTfP5HxqelyzfiBOb; Sun, 15 Jul 2018 12:42:58 -0600 X-Authority-Analysis: v=2.3 cv=BMcHU2YG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=CSz7DQG5eDtsI0kICj4A:9 a=tAd33UIhWrEktjdv:21 a=R_ztdkZfx0kpGRkD:21 a=CjuIK1q_8ugA:10 a=hDOnJyz3TxZynsWVIHgA:9 a=3dQZWuVdzU99YDHo:21 a=Lcd6fi8UkDo-vK6N:21 a=KazVbFF-DrvXHMnm:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.81.209.115] (S0106002401cb186f.gv.shawcable.net [70.67.125.17]) by spqr.komquats.com (Postfix) with ESMTPSA id 4965AE50; Sun, 15 Jul 2018 11:42:55 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: [PATCH] Recent libm additions Date: Sun, 15 Jul 2018 11:43:04 -0700 To: Ian Lepore , Warner Losh , "K. Macy" CC: Steve Kargl , FreeBSD Current Message-Id: <20180715184255.4965AE50@spqr.komquats.com> X-CMAE-Envelope: MS4wfCbE6tp6vLsZdig9OR7jhU1Fw3ddGoB3JJ7uU3xSkAIJlPolkpwlypK372l7b5/FIJbyPcJBnve1/Qx/x+21Tr9m9zHst8djLOgP36qRquCe0fs9NtlB Fm7Ruz2kr+0FhihTIrfRrX5E0l2UMKDEmGsPySZ+5ujwI8JA9g464ZArZwzsp8crUOMQuo/AsaTaUMwznndTfiJ5gXsJklGiCyJEHtkac+Lil4mjyrZHiOzE vDoo11ykROMdv73+sDdOfOT5tAb5BUdFU8n5/rymzTXrEOSXJSxSXRjGYxOWaFFxrETy88GlNhXlDNCIlzq7mnsc84ezyukdqB88LGqSgNEoftxV18fpb4Pu tK6dqwl1TpE5WXCDrqwbEn2SuPxuLw7ggsYRl9yTdLTsIzpj2pE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 18:43:07 -0000 I don't think it makes sense for a non-committer to have a lock on anything= in base. However a request for review makes a lot of sense. If a non-commi= tter or former committer is the SME on a particular subject it's best that = they be consulted even if they don't request it. IMO more input is better. = Where better to document this than in MAINTAINERS. Having said all this. If a person is a former committer and it's not docume= nted, how are we to know? If people agree, should we start documenting SMEs in MAINTAINERS? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Ian Lepore Sent: 15/07/2018 11:08 To: Warner Losh; K. Macy Cc: Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: >=20 > >=20 > > >=20 > > >=20 > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > >=20 > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. >=20 > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Sun Jul 15 19:09:43 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BD5D104B89E for ; Sun, 15 Jul 2018 19:09:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F5A993E60 for ; Sun, 15 Jul 2018 19:09:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id v71-v6so18155814itb.3 for ; Sun, 15 Jul 2018 12:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ygPDuz63ua8JDpGVg6WIHVj2M/tRJ0bpqXhDH2OXydM=; b=HHWK0t6t92v84p6U9SMZz4zLiUXTxet5lFM+UWZYvmF/4ZOEv6wTqBFiOQ/+wS3yrK cVvytKTJoB5jUvNGyCQToQoRNunfn0/merOeWTdKHnVh2BYzHS2GwRPK6I9aEFmMzlEt qHjEjXrMFLa41h3wxofCpbIa/mlAlCme3GxDdi0vvXNM0CApnspEVfSOcnkgMCfW+Pib qAFQwzZZvQoIskLl/Ww5h8Abin4yOh892IDStRpq9uryT8z2V3AFgjMXjJ/Zey5eAcFy yKLtr7DamQJZmznWTnAddN+C06ztAE2p5mC59iYR0j93OCgw4BR3dWAvdQRwtxElPyqx 1TBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ygPDuz63ua8JDpGVg6WIHVj2M/tRJ0bpqXhDH2OXydM=; b=Yoy8cqpU7ynvKJWEj8KCGa66825cOtX62fnaVtu5BRuOIiBluD8e2U3FgKiADLRii+ /oyzb9NhEBAQogOzytdr+jsN62MbWA6jL3+YgxQXnyIsV7CGJth62g4o2btFnioOs4Ur S14ycolNTPBVDi8RBkTsLZuNcyDXBKGq58KQQQd64R9x1v2sdU3Xt5nu5yvd0wjdBScy qC+1P6/YSlySoe5DqB20/IDxj8E3Y9q9Qzd8icPc3FGwJiqotbXYdeePRP6wjprt6yRB DtXg2iu//VncVnjx8AfYT98zizloMyKZsrPzpMcugQbflLIpwUeXHSQtmu1ONtuW6E3x kiAA== X-Gm-Message-State: AOUpUlEUx7u61Vx3D1ITa2yN44aG5hFKa5/YmkrUB0qwI7uRpyJPJYAJ rEX33bDULZlGYVf9wi5XQVv8Yp16kHAi806/ucGuRQ== X-Google-Smtp-Source: AAOMgpe+wzeHCdLqSIp5BIvdiVvOQ8eHOA79732WveNO0yVffZsNQQgvfphHIJagACZVLy4I1ZFKiUF1kZ+/GjvkiJ4= X-Received: by 2002:a02:3344:: with SMTP id k4-v6mr12337458jak.45.1531681782105; Sun, 15 Jul 2018 12:09:42 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 12:09:41 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180715184255.4965AE50@spqr.komquats.com> References: <20180715184255.4965AE50@spqr.komquats.com> From: Warner Losh Date: Sun, 15 Jul 2018 13:09:41 -0600 X-Google-Sender-Auth: IDl-3p7-GR8OnGuh6AOhBKj0tTg Message-ID: Subject: Re: [PATCH] Recent libm additions To: Cy Schubert Cc: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:09:43 -0000 I'm not saying that he has a lock. I'm saying he's are domain expert and many mistakes can be avoided by talking to him. I'm saying we have history here, and that history, while poorly documented, wasn't followed. To the extent it is poorly documented, we should fix that. Warner On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert wrote: > I don't think it makes sense for a non-committer to have a lock on > anything in base. However a request for review makes a lot of sense. If a > non-committer or former committer is the SME on a particular subject it's > best that they be consulted even if they don't request it. IMO more input > is better. Where better to document this than in MAINTAINERS. > > Having said all this. If a person is a former committer and it's not > documented, how are we to know? > > If people agree, should we start documenting SMEs in MAINTAINERS? > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > ------------------------------ > From: Ian Lepore > Sent: 15/07/2018 11:08 > To: Warner Losh; K. Macy > Cc: Steve Kargl; FreeBSD Current > Subject: Re: [PATCH] Recent libm additions > > On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: > > > > > > > > > > > > > > > > > Well, actually, the functions in polevll.c should have been > > > > copied > > > > into ld80/e_powl.c, and polevall.c should never have been > > > > committed. > > > > Unfortunately, the code was not reviewed for correctness. > > > That is not correct. Please stop repeating it. Bruce Evans and John > > > Baldwin were both looped in. Neither made this observation. > > > > > Steve is the fp guy these days. And it wasn't reviewed by him. He's > > mad you > > cut him out of the loop. Arguing about pedantic points of process > > does no > > one any good. > > > > Warner > > On the other hand, what information is there for someone to know that > Steve should be involved in a review? There is nothing in MAINTAINERS. > The review was on phab for almost a month, and phab is supposedly the > preferred way to do reviews these days. > > Steve is no longer a committer, but that doesn't preclude him having a > phab account and participating in reviews. If he doesn't like using > phab (and I can certainly understand that POV), an entry in MAINTAINERS > would still be helpful, unless we have a rule that only committers can > be listed in there. > > -- Ian > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > From owner-freebsd-current@freebsd.org Sun Jul 15 19:23:16 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79588104C2EF for ; Sun, 15 Jul 2018 19:23:16 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id C4AB6949D3; Sun, 15 Jul 2018 19:23:15 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id embrfrcMn5HxqembtfiG0t; Sun, 15 Jul 2018 13:23:09 -0600 X-Authority-Analysis: v=2.3 cv=BMcHU2YG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=6cOCMEzMwqMkX4QkEOkA:9 a=kfLs2cAFn_uC69ZS:21 a=lg1d0Vj4soVCZTHJ:21 a=QEXdDO2ut3YA:10 a=7hgpX3chCYp_noUmY68A:9 a=NaPjXXHmcOIR-qkB:21 a=3N1Da5-J6Q_uEzXN:21 a=6Ln06zNXtP8oIzB-:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.81.209.115] (d23-16-123-169.bchsia.telus.net [23.16.123.169]) by spqr.komquats.com (Postfix) with ESMTPSA id 45EE0ED6; Sun, 15 Jul 2018 12:23:07 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: [PATCH] Recent libm additions Date: Sun, 15 Jul 2018 12:23:06 -0700 To: Warner Losh CC: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Message-Id: <20180715192307.45EE0ED6@spqr.komquats.com> X-CMAE-Envelope: MS4wfJaye7UBdxJiS3GLNyuwd3B5rx1kXSyB1XlKsfXGw61aq0WtejdO4OutvoeM+U0LCi7PRTeK1LcmmDJXu2RohmUWWRJSsdcoNKWUX0R7aHm7bB/yl559 ovEHPRLb3dW4RJT3OGS0LZSXpb/jFZeSNVOhIAjEu2NnbQK2J9/SZVPAR19nhU5rma9djtjx1qbMbojA+WGYV6J2qpOmuIxlzq4F6/l51u3m7wrSgCHg8iW7 rGRNIrSGYnrV7cCRlHnsI7SOZTvEZ4pDzfjPogo8mCJvbV3qrginiGlHfnAmcJ72sBKItDQ+vdRxYi6Ui3wGRW0oGMdJFwOO+6vythBwIhHYEQlAKrk5ewBv NlgNWF1U6PucHgUJI0Of0yFvIC5XXOieAEOo1u++QxxKJSCmGVQ= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:23:16 -0000 I wasn't saying Steve has a lock however in case non-committers might feel = they do, addressing all points in my reply. Not saying anyone feels this wa= y today but we should consider this in whatever we decide here (considering= all possibilities). IMO adding subject matter experts to MAINTAINERS seems= like the easiest way to document who might be the go-to person. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Warner Losh Sent: 15/07/2018 12:09 To: Cy Schubert Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions I'm not saying that he has a lock. I'm saying he's are domain expert and ma= ny mistakes can be avoided by talking to him. I'm saying we have history here, and that history, while poorly documented,= wasn't followed. To the extent it is poorly documented, we should fix that= . Warner On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert w= rote: I don't think it makes sense for a non-committer to have a lock on anything= in base. However a request for review makes a lot of sense. If a non-commi= tter or former committer is the SME on a particular subject it's best that = they be consulted even if they don't request it. IMO more input is better. = Where better to document this than in MAINTAINERS. Having said all this. If a person is a former committer and it's not docume= nted, how are we to know? If people agree, should we start documenting SMEs in MAINTAINERS? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- From: Ian Lepore Sent: 15/07/2018 11:08 To: Warner Losh; K. Macy Cc: Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: >=20 > >=20 > > >=20 > > >=20 > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > >=20 > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. >=20 > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" = From owner-freebsd-current@freebsd.org Sun Jul 15 19:26:33 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2214104C4B2 for ; Sun, 15 Jul 2018 19:26:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 21B8994C4B for ; Sun, 15 Jul 2018 19:26:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x241.google.com with SMTP id v26-v6so35768648iog.5 for ; Sun, 15 Jul 2018 12:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=FFTf2O2BFsCJiilB/QnWNPqvlyK+BDdzpsuhgxHn6lk=; b=Q1K4WtwjZyK90IFwRPrypofORe/aq0VVBHRuEGPChdXHAfqKq46JcUrJ7OusZEJ3Z+ evkjDZOhasSrJjKUxYShMpx+MNvbRYxX98RIC8LsML7B/fPo57L+IMlfYejdNkkYhqEz PPLU6Qi++c8H9AeOm8f2hoAnttIzinLRw2emYXrfiNJZANKApamHB/vhcmXhyoGb0YjV gzHc8yvtr5ajz5mxT70XfOCcopP4Y5+uAZH+pSYXR7n3KXWlc6Keb+eybRgZnEUZgCuQ CTrrFVbWgS0s/XWCKD7XYvv96sagAw16D2n59aGvbA3Hkx1/e98+Jhdpyi49jH0YXhKU 4JTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=FFTf2O2BFsCJiilB/QnWNPqvlyK+BDdzpsuhgxHn6lk=; b=BKGh301zGPlvixAptZjecRSCgJxhltK7eZoCgWQLw2CUybT7dB1g3K1g2v7yXp5Bbi AuGoAZNmxSfPN5N2tEd7IIxBc05Qapi9N+JTvgPOrdPV5CNjwbJfYDgC+ZqUTYu5wcpw VlOPBbhwmUGfzVvpED9VZyD7jJ7nXh96v2/9MziFjPDy2p7brXbR5rVmQa75v0/9posG /Udv9FlW3/2hH9G0aSjCTnA0QK+GpO2Bhu4VVSRP616hEfagwSKinS57bqOZiFStdbU5 gNZXRnfA85pvGtA9fEENqlchX/rvJ/iz5VR4b8ugneccuipKXsM2bCqcJwmvOwN5qLkr oA8A== X-Gm-Message-State: AOUpUlEK9AWX3kgwc1y6H/wSWlHglxvz9W+QXab21cRlPN3W5lWr2asA NeG2pNvfYuDQ6HAIzR+cciFSfG9TlZdMOrn0UX7l7+b2 X-Google-Smtp-Source: AAOMgpd31itumu+pDc+G3OBACD4wddYpJ5hGyeiNVd9I5khkv28a/zV4LHTtK3rik5yeZ/mQEMN/lWOXsLpnTYvlZGo= X-Received: by 2002:a6b:f719:: with SMTP id k25-v6mr7107262iog.37.1531682792309; Sun, 15 Jul 2018 12:26:32 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:1183:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 12:26:31 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180715192307.45EE0ED6@spqr.komquats.com> References: <20180715192307.45EE0ED6@spqr.komquats.com> From: Warner Losh Date: Sun, 15 Jul 2018 13:26:31 -0600 X-Google-Sender-Auth: 1QqV60pAI7XOz22A9hH9A9z3cwE Message-ID: Subject: Re: [PATCH] Recent libm additions To: Cy Schubert Cc: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:26:33 -0000 So something like this: diff --git a/MAINTAINERS b/MAINTAINERS index 51d3688f8b8..3e6584f24a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -58,6 +58,7 @@ kqueue jmg Pre-commit review requested. Documentation Required. libdpv dteske Pre-commit review requested. Keep in sync with dpv(1). libfetch des Pre-commit review requested, email only. libfigpar dteske Pre-commit review requested. +libm freebsd-numerics Send email with patches to freebsd-numerics@ libpam des Pre-commit review requested, email only. linprocfs des Pre-commit review requested, email only. lpr gad Pre-commit review requested, particularly for is what you're suggesting? Warner On Sun, Jul 15, 2018 at 1:23 PM, Cy Schubert wrote: > I wasn't saying Steve has a lock however in case non-committers might feel > they do, addressing all points in my reply. Not saying anyone feels this > way today but we should consider this in whatever we decide here > (considering all possibilities). IMO adding subject matter experts to > MAINTAINERS seems like the easiest way to document who might be the go-to > person. > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > Also, this old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > ------------------------------ > From: Warner Losh > Sent: 15/07/2018 12:09 > To: Cy Schubert > Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current > > Subject: Re: [PATCH] Recent libm additions > > I'm not saying that he has a lock. I'm saying he's are domain expert and > many mistakes can be avoided by talking to him. > > I'm saying we have history here, and that history, while poorly > documented, wasn't followed. To the extent it is poorly documented, we > should fix that. > > Warner > > On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert > wrote: > >> I don't think it makes sense for a non-committer to have a lock on >> anything in base. However a request for review makes a lot of sense. If a >> non-committer or former committer is the SME on a particular subject it's >> best that they be consulted even if they don't request it. IMO more input >> is better. Where better to document this than in MAINTAINERS. >> >> Having said all this. If a person is a former committer and it's not >> documented, how are we to know? >> >> If people agree, should we start documenting SMEs in MAINTAINERS? >> >> --- >> Sent using a tiny phone keyboard. >> Apologies for any typos and autocorrect. >> Also, this old phone only supports top post. Apologies. >> >> Cy Schubert >> or >> The need of the many outweighs the greed of the few. >> --- >> ------------------------------ >> From: Ian Lepore >> Sent: 15/07/2018 11:08 >> To: Warner Losh; K. Macy >> Cc: Steve Kargl; FreeBSD Current >> Subject: Re: [PATCH] Recent libm additions >> >> On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: >> > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: >> > >> > > >> > > > >> > > > >> > > > Well, actually, the functions in polevll.c should have been >> > > > copied >> > > > into ld80/e_powl.c, and polevall.c should never have been >> > > > committed. >> > > > Unfortunately, the code was not reviewed for correctness. >> > > That is not correct. Please stop repeating it. Bruce Evans and John >> > > Baldwin were both looped in. Neither made this observation. >> > > >> > Steve is the fp guy these days. And it wasn't reviewed by him. He's >> > mad you >> > cut him out of the loop. Arguing about pedantic points of process >> > does no >> > one any good. >> > >> > Warner >> >> On the other hand, what information is there for someone to know that >> Steve should be involved in a review? There is nothing in MAINTAINERS. >> The review was on phab for almost a month, and phab is supposedly the >> preferred way to do reviews these days. >> >> Steve is no longer a committer, but that doesn't preclude him having a >> phab account and participating in reviews. If he doesn't like using >> phab (and I can certainly understand that POV), an entry in MAINTAINERS >> would still be helpful, unless we have a rule that only committers can >> be listed in there. >> >> -- Ian >> >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org >> " >> >> > From owner-freebsd-current@freebsd.org Sun Jul 15 19:43:58 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0586104CE67; Sun, 15 Jul 2018 19:43:58 +0000 (UTC) (envelope-from stephen@missouri.edu) Received: from um-kip6-missouri-out.um.umsystem.edu (um-kip6-missouri-out.um.umsystem.edu [209.106.229.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "um-tip1.um.umsystem.edu", Issuer "InCommon RSA Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C03E595584; Sun, 15 Jul 2018 19:43:54 +0000 (UTC) (envelope-from stephen@missouri.edu) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2ELCwB+o0tb/xY40cZcGgEBAQEBAgEBA?= =?us-ascii?q?QEIAQEBAYNJgWIyg3GUPIFgLIM4k3sBCiyEQAIXgjkhOBQBAgEBAgEBAgICaSi?= =?us-ascii?q?FOQEFIxE3DhACAQgOCgICJgICAjAVEAIEAQwBBwEBFYMHggCoeYEuh1sBB4Jag?= =?us-ascii?q?QuHd4IWgTiCaoUSgmqCVQKZXAkCjx+Na5FtAgICAgkCFIFYIoFSchODJZBSggS?= =?us-ascii?q?KJgGBGQEB?= X-IPAS-Result: =?us-ascii?q?A2ELCwB+o0tb/xY40cZcGgEBAQEBAgEBAQEIAQEBAYNJgWI?= =?us-ascii?q?yg3GUPIFgLIM4k3sBCiyEQAIXgjkhOBQBAgEBAgEBAgICaSiFOQEFIxE3DhACA?= =?us-ascii?q?QgOCgICJgICAjAVEAIEAQwBBwEBFYMHggCoeYEuh1sBB4JagQuHd4IWgTiCaoU?= =?us-ascii?q?SgmqCVQKZXAkCjx+Na5FtAgICAgkCFIFYIoFSchODJZBSggSKJgGBGQEB?= Received: from ex2-n14.um.umsystem.edu ([198.209.56.22]) by um-kip6-exch-relay.um.umsystem.edu with ESMTP; 15 Jul 2018 14:43:18 -0500 Received: from EX2-N14.um.umsystem.edu (198.209.56.22) by EX2-N14.um.umsystem.edu (198.209.56.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sun, 15 Jul 2018 14:43:18 -0500 Received: from EX2-N14.um.umsystem.edu ([198.209.56.22]) by EX2-N14.um.umsystem.edu ([198.209.56.22]) with mapi id 15.01.1466.003; Sun, 15 Jul 2018 14:43:18 -0500 From: "Montgomery-Smith, Stephen" To: Warner Losh , Cy Schubert CC: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current , "freebsd-numerics@freebsd.org" Subject: Re: [PATCH] Recent libm additions Thread-Topic: [PATCH] Recent libm additions Thread-Index: AQHUHGuqyzVLVIDtZUuDXyPfYCPMkaSQ+b6AgAAJY4A= Date: Sun, 15 Jul 2018 19:43:18 +0000 Message-ID: <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> References: <20180715184255.4965AE50@spqr.komquats.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 x-originating-ip: [128.206.49.160] Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:43:58 -0000 T24gMDcvMTUvMjAxOCAwMjowOSBQTSwgV2FybmVyIExvc2ggd3JvdGU6DQo+IEknbSBub3Qgc2F5 aW5nIHRoYXQgaGUgaGFzIGEgbG9jay4gSSdtIHNheWluZyBoZSdzIGFyZSBkb21haW4gZXhwZXJ0 IGFuZA0KPiBtYW55IG1pc3Rha2VzIGNhbiBiZSBhdm9pZGVkIGJ5IHRhbGtpbmcgdG8gaGltLg0K PiANCj4gSSdtIHNheWluZyB3ZSBoYXZlIGhpc3RvcnkgaGVyZSwgYW5kIHRoYXQgaGlzdG9yeSwg d2hpbGUgcG9vcmx5IGRvY3VtZW50ZWQsDQo+IHdhc24ndCBmb2xsb3dlZC4gVG8gdGhlIGV4dGVu dCBpdCBpcyBwb29ybHkgZG9jdW1lbnRlZCwgd2Ugc2hvdWxkIGZpeCB0aGF0Lg0KPiANCj4gV2Fy bmVyDQo+IA0KSSBhZ3JlZSB0aGF0IHdlIHNob3VsZCBkb2N1bWVudCB0aGUgcHJvY2Vzcy4gIE1h eWJlIGFsc28gaW5jbHVkZQ0KZnJlZWJzZC1udW1lcmljc0Agb24gdGhlc2UgZGlzY3Vzc2lvbnMs IGFzIHRoYXQgaXMgd2h5IGl0IHdhcyBjcmVhdGVkLg0KDQpCdXQgSSdtIHJlYWxseSBnbGFkIHRo ZXNlIGNoYW5nZXMgd2VyZSBjb21taXR0ZWQuICBJIGhhdmUgZm91bmQgdGhlDQpwZW9wbGUgdGVu ZCB0byBkcmFnIHRoZWlyIGZlZXQgYSBsb3Qgb24gbnVtZXJpY3MgaXNzdWVzLg0KDQpIYXMgYW55 b25lIGRvbmUgYW4gYW5hbHlzaXMgb2YgdGhlIE9wZW5CU0QgcG93bCBmdW5jdGlvbnMgZnJvbSBh bg0KYWNjdXJhY3kgcG9pbnQgb2Ygdmlldz8gIFRoYXQgaXMsIHRvIHRlc3QgaG93IG1hbnkgVUxQ IG9mIGVycm9yIHRoZXNlDQpmdW5jdGlvbnMgaGF2ZT8gIElmIG5vdCwgSSBjb3VsZCBnaXZlIGl0 IGEgZ28sIGFsdGhvdWdoIG5vdCBmb3Igc2V2ZXJhbA0KbW9udGhzIGJlY2F1c2UgbGlmZSBpcyB2 ZXJ5IGJ1c3ku From owner-freebsd-current@freebsd.org Sun Jul 15 19:44:53 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C644D104CEF0 for ; Sun, 15 Jul 2018 19:44:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 324C895647; Sun, 15 Jul 2018 19:44:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id emwpfrh7k5HxqemwrfiIKE; Sun, 15 Jul 2018 13:44:50 -0600 X-Authority-Analysis: v=2.3 cv=BMcHU2YG c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=j-cYqe4Q4CAtu6PqBi8A:9 a=9FAdu-jtmB8Lu_AZ:21 a=LewiLZnlzZ2qsfRg:21 a=QEXdDO2ut3YA:10 a=0VOg8hKvAAAA:8 a=wM3WXT1MRTogCF0UylIA:9 a=3b8huEmPdT0a8FxE:21 a=EkM985FYvPIFgsGF:21 a=SDMxCMvMkpTUL93d:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=I-efbNKAaAt4Mg394dr-:22 Received: from [25.81.209.115] (d23-16-123-169.bchsia.telus.net [23.16.123.169]) by spqr.komquats.com (Postfix) with ESMTPSA id 56B88F21; Sun, 15 Jul 2018 12:44:47 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: [PATCH] Recent libm additions Date: Sun, 15 Jul 2018 12:44:46 -0700 To: Warner Losh CC: Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Message-Id: <20180715194447.56B88F21@spqr.komquats.com> X-CMAE-Envelope: MS4wfETqnk1N/qeJvsxjp87G6ScRWqtF3bgGqNNIfEt0vxW03oJ+/+6lssIFAg5AwG4oD7CeHwvuITccorTSwzqLcytBUv5RULXDtgKvShMeVndgOdeHl/AD 8NEHyuoqZJ1ko1RQnBKazuxk8NxMdbs1CWsyc8nJld7EwHDpy0RR9m+DY9WovnIIN05ZPYlX4gOFNw743adZzWT9KODkwP80l8TKkNiID556oFhN/Z8uOO8B 9d4XdlrCjqy9ZPZV8Du7b3Vk8K1YtcJqFI8Njwgsn37Su3E/vhMvjMxpwPDzS6WQMQEFCmubSwD4gm64+dYKU5OETFI57QVncIcZ9aiL5zXOkib8EQFtneZe JCD3gG5yw9XJdW+sKlgF2IxhCIS+A2x93BE63XHZgIkabYGBU6A= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 19:44:53 -0000 That'll work too. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: Warner Losh Sent: 15/07/2018 12:26 To: Cy Schubert Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions So something like this: diff --git a/MAINTAINERS b/MAINTAINERS index 51d3688f8b8..3e6584f24a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -58,6 +58,7 @@ kqueue jmg Pre-commit review requested= . Documentation Required. libdpv dteske Pre-commit review requested. Keep in sync with dpv(= 1). libfetch des Pre-commit review requested, email only. libfigpar dteske Pre-commit review requested. +libm freebsd-numerics Send email with patches to freebsd-= numerics@ libpam des Pre-commit review requested, email only. linprocfs des Pre-commit review requested, email only. lpr gad Pre-commit review requested, particularly for is what you're suggesting? Warner On Sun, Jul 15, 2018 at 1:23 PM, Cy Schubert wr= ote: I wasn't saying Steve has a lock however in case non-committers might feel = they do, addressing all points in my reply. Not saying anyone feels this wa= y today but we should consider this in whatever we decide here (considering= all possibilities). IMO adding subject matter experts to MAINTAINERS seems= like the easiest way to document who might be the go-to person. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- From: Warner Losh Sent: 15/07/2018 12:09 To: Cy Schubert Cc: Ian Lepore; K. Macy; Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions I'm not saying that he has a lock. I'm saying he's are domain expert and ma= ny mistakes can be avoided by talking to him. I'm saying we have history here, and that history, while poorly documented,= wasn't followed. To the extent it is poorly documented, we should fix that= . Warner On Sun, Jul 15, 2018 at 12:43 PM, Cy Schubert w= rote: I don't think it makes sense for a non-committer to have a lock on anything= in base. However a request for review makes a lot of sense. If a non-commi= tter or former committer is the SME on a particular subject it's best that = they be consulted even if they don't request it. IMO more input is better. = Where better to document this than in MAINTAINERS. Having said all this. If a person is a former committer and it's not docume= nted, how are we to know? If people agree, should we start documenting SMEs in MAINTAINERS? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- From: Ian Lepore Sent: 15/07/2018 11:08 To: Warner Losh; K. Macy Cc: Steve Kargl; FreeBSD Current Subject: Re: [PATCH] Recent libm additions On Sun, 2018-07-15 at 11:55 -0600, Warner Losh wrote: > On Sun, Jul 15, 2018, 11:23 AM K. Macy wrote: >=20 > >=20 > > >=20 > > >=20 > > > Well, actually, the functions in polevll.c should have been > > > copied > > > into ld80/e_powl.c, and polevall.c should never have been > > > committed. > > > Unfortunately, the code was not reviewed for correctness. > > That is not correct. Please stop repeating it. Bruce Evans and John > > Baldwin were both looped in. Neither made this observation. > >=20 > Steve is the fp guy these days. And it wasn't reviewed by him. He's > mad you > cut him out of the loop. Arguing about pedantic points of process > does no > one any good. >=20 > Warner On the other hand, what information is there for someone to know that Steve should be involved in a review? There is nothing in MAINTAINERS. The review was on phab for almost a month, and phab is supposedly the preferred way to do reviews these days. Steve is no longer a committer, but that doesn't preclude him having a phab account and participating in reviews. If he doesn't like using phab (and I can certainly understand that POV), an entry in MAINTAINERS would still be helpful, unless we have a rule that only committers can be listed in there. -- Ian _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" = From owner-freebsd-current@freebsd.org Sun Jul 15 20:29:46 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75791102742D for ; Sun, 15 Jul 2018 20:29:46 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660067.outbound.protection.outlook.com [40.107.66.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0C04E969F5 for ; Sun, 15 Jul 2018 20:29:45 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM (52.132.44.24) by YTOPR0101MB1386.CANPRD01.PROD.OUTLOOK.COM (52.132.46.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.19; Sun, 15 Jul 2018 20:29:44 +0000 Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e]) by YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e%5]) with mapi id 15.20.0952.021; Sun, 15 Jul 2018 20:29:44 +0000 From: Rick Macklem To: "Rodney W. Grimes" CC: "freebsd-current@freebsd.org" , "andreas.nagy@frequentis.com" Subject: Re: NFSv4.1 server deficiencies fixed for ESXi client Thread-Topic: NFSv4.1 server deficiencies fixed for ESXi client Thread-Index: AQHUBjsXCbI4UKyOQkWL16OOOThmbqRkhj+AgCxegDg= Date: Sun, 15 Jul 2018 20:29:44 +0000 Message-ID: References: , <201806171442.w5HEg3pB060542@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201806171442.w5HEg3pB060542@pdx.rh.CN85.dnsmgr.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1386; 7:fLbdRWHkwfcFZ+YdsNjqfRqvJpBuCUCXbTqURxn29/u7tCQiDVFcZvFrqcE+1k+tqOxDb4XMKApNLRQ8OJ82cZrQBw5zP/iKHK6/lzqqaldjGO0YVADoMMeztm+HP0K2tCzwxd9cRDkzaZNTPJx/6KwRZ7H5nsyzWopuZurBO03QrgwrdjHPhmQ+OVZZNHffJ/UDy2LzsP7vwuuxUpTpXAebkmi/XxIj7YgIp63tXK5qlTgCS8diup6sZvr9uLgh x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1688dee4-55bd-4d32-6a02-08d5ea91b38b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1386; x-ms-traffictypediagnostic: YTOPR0101MB1386: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3002001)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:YTOPR0101MB1386; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1386; x-forefront-prvs: 07349BFAD2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(39850400004)(346002)(376002)(366004)(189003)(199004)(256004)(6246003)(8676002)(186003)(305945005)(2900100001)(9686003)(55016002)(229853002)(81156014)(99286004)(81166006)(14444005)(14454004)(26005)(6436002)(106356001)(316002)(5660300001)(105586002)(33656002)(8936002)(786003)(53936002)(7696005)(76176011)(25786009)(486006)(6506007)(74482002)(4326008)(446003)(478600001)(476003)(97736004)(6916009)(2906002)(86362001)(5250100002)(54906003)(74316002)(68736007)(102836004)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1386; H:YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: RsIXUUe/kjX56OsIhvB+/anHNpYkkbe43ZiVCw8Zvmeo0utg8U5Rv6uuCgMlqaZ0io9qHaYlnYaicTRr2OjF0mOpNEs/HYHpkPrjZOMOXdTxizm8bxsY8QgQGYwUlkKUpX9AKviX8Tne96/qQNhhsUUZOyhpCwsPNTtnAHzGWxylXTRFYkuf3Oek3HFcodxbqBAsFJcdchvPkUNXNxX+DTxkgLMECibVramGcVr7WHYFGvMQgRK8ujhTrxB7krimstlHKffRtw5Q4nHdloKPwsZQwId/xxNxvllQCO6mufCgI3pfFSnDcmfSO3Vimqt4EatmoBrJ0Z5MFvlMjbRQmoUmbPkmD28CIsixZgKtKXY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 1688dee4-55bd-4d32-6a02-08d5ea91b38b X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2018 20:29:44.4978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1386 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 20:29:46 -0000 Rodney W. Grimes wrote: >Have you any contact with VMWare so that they might fix the issues >in thier code, rather than having to put hacks in FreeBSD for these >issues? Well, Jim White (who is not in their file system area) submitted a PR on th= eir system and the response was along the lines of: Sorry to report the storage team punted the bug to a future release (which = could be indefinite). The stated reason is that FreeBSD isn't a supported= NFS 4.1 server. As such, it didn't sound too promising. However, recent tests have shown th= at ESXi6.7 is much better. The packet traces I've seen sofar for the ESXi 6.7 client show none of the = serious (and difficult to deal with without violating the RFC) problems. It still does a ReclaimComplete with rca_one_fs =3D=3D TRUE, but it also do= es the required ReclaimComplete with rca_one_fs =3D=3D FALSE. Although I believe t= he ReclaimComplete with rca_one_fs =3D=3D TRUE is only meant to be used after = a file system has been transferred to a different server (something the FreeB= SD server does not do at this time), the RFC is somewhat vague on when this is= used, so I think just replying NFS_OK to this without doing anything should be ac= ceptable. (I am going to look and see what the Linux server does for this case.) As such, I'm hoping that there will be no need for "dirty hacks" for the ES= Xi6.7 client and this might soon be resolved. Thanks go to those doing the testing (Andreas Nagy and Daniel Engel) and Ji= m White for submitting the PR that somehow got fixed in a matter of days, rick From owner-freebsd-current@freebsd.org Sun Jul 15 20:59:26 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FC9710288BF for ; Sun, 15 Jul 2018 20:59:26 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2528697A96; Sun, 15 Jul 2018 20:59:26 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FKxMip032933 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 13:59:22 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FKxMvT032932; Sun, 15 Jul 2018 13:59:22 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 13:59:22 -0700 From: Steve Kargl To: Cy Schubert Cc: Warner Losh , Ian Lepore , "K. Macy" , FreeBSD Current Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715205922.GA32747@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715192307.45EE0ED6@spqr.komquats.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180715192307.45EE0ED6@spqr.komquats.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 20:59:26 -0000 On Sun, Jul 15, 2018 at 12:23:06PM -0700, Cy Schubert wrote: > I wasn't saying Steve has a lock however in case non-committers > might feel they do, addressing all points in my reply. Not saying > anyone feels this way today but we should consider this in whatever > we decide here (considering all possibilities). IMO adding subject > matter experts to MAINTAINERS seems like the easiest way to document > who might be the go-to person. I don't have a lock, and I don't want one. I do, however, make a part of my living using FreeBSD for floating point intensive research. I think that changes, including the addition of new functions, to libm should be reviewed and preferably tested. Grabbing code from OpenBSD (or anywhere), getting it to compile and integrated into the build infrastructure does not constitute a code review. There is a mailing list dedicated to numerics (aka floating point) on FreeBSD: freebsd-numerics@freebsd.org. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 21:13:18 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4C5C102A14C; Sun, 15 Jul 2018 21:13:18 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 30AF670EAC; Sun, 15 Jul 2018 21:13:18 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FLBxuO033118 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 14:11:59 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FLBxtn033117; Sun, 15 Jul 2018 14:11:59 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 14:11:59 -0700 From: Steve Kargl To: Matthew Macy Cc: "Montgomery-Smith, Stephen" , Warner Losh , Cy Schubert , Ian Lepore , "K. Macy" , FreeBSD Current , "freebsd-numerics@freebsd.org" Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715211159.GB32747@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715184255.4965AE50@spqr.komquats.com> <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 21:13:18 -0000 On Sun, Jul 15, 2018 at 02:00:37PM -0700, Matthew Macy wrote: > On Sun, Jul 15, 2018 at 12:43 PM, Montgomery-Smith, Stephen > wrote: > > On 07/15/2018 02:09 PM, Warner Losh wrote: > >> I'm not saying that he has a lock. I'm saying he's are domain expert and > >> many mistakes can be avoided by talking to him. > >> > >> I'm saying we have history here, and that history, while poorly documented, > >> wasn't followed. To the extent it is poorly documented, we should fix that. > >> > >> Warner > >> > > I agree that we should document the process. Maybe also include > > freebsd-numerics@ on these discussions, as that is why it was created. > > > > But I'm really glad these changes were committed. I have found the > > people tend to drag their feet a lot on numerics issues. > > > > Has anyone done an analysis of the OpenBSD powl functions from an > > accuracy point of view? That is, to test how many ULP of error these > > functions have? If not, I could give it a go, although not for several > > months because life is very busy. > > They're also used by Julia. You might ask there first. The FPU on i686-class hardware is set to use 53-bit precision. powl.c likely has at least a 2**11 ULP for a (large?) number of arguments. Go read the msun/src/math_private.h. You'll find LD80C for constucting long double literal constants, ENTERI() and RETURNI() marcos that toggle the precision of the FPU. These are used in ld80 code, e.g., e_lgammal_r.c. So, it doesn't matter what the Julia developers say unless their testing was done on FreeBSD. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 21:14:46 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60A7A102A33B; Sun, 15 Jul 2018 21:14:46 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E75BC7103D; Sun, 15 Jul 2018 21:14:45 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6FLEg3U033181 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 15 Jul 2018 14:14:42 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6FLEgmS033180; Sun, 15 Jul 2018 14:14:42 -0700 (PDT) (envelope-from sgk) Date: Sun, 15 Jul 2018 14:14:42 -0700 From: Steve Kargl To: Matthew Macy Cc: "Montgomery-Smith, Stephen" , Warner Losh , Cy Schubert , Ian Lepore , "K. Macy" , FreeBSD Current , "freebsd-numerics@freebsd.org" Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715211442.GA33140@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715184255.4965AE50@spqr.komquats.com> <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 21:14:46 -0000 On Sun, Jul 15, 2018 at 02:00:37PM -0700, Matthew Macy wrote: > On Sun, Jul 15, 2018 at 12:43 PM, Montgomery-Smith, Stephen > wrote: > > On 07/15/2018 02:09 PM, Warner Losh wrote: > >> I'm not saying that he has a lock. I'm saying he's are domain expert and > >> many mistakes can be avoided by talking to him. > >> > >> I'm saying we have history here, and that history, while poorly documented, > >> wasn't followed. To the extent it is poorly documented, we should fix that. > >> > >> Warner > >> > > I agree that we should document the process. Maybe also include > > freebsd-numerics@ on these discussions, as that is why it was created. > > > > But I'm really glad these changes were committed. I have found the > > people tend to drag their feet a lot on numerics issues. > > > > Has anyone done an analysis of the OpenBSD powl functions from an > > accuracy point of view? That is, to test how many ULP of error these > > functions have? If not, I could give it a go, although not for several > > months because life is very busy. > > They're also used by Julia. You might ask there first. You also need to fix the pow.3 documentation. It currently states BUGS To conform with newer C/C++ standards, a stub implementation for powl was committed to the math library, where powl is mapped to pow. Thus, the numerical accuracy is at most that of the 53-bit double precision implementation. -- Steve From owner-freebsd-current@freebsd.org Sun Jul 15 21:00:40 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02EC01028ADE; Sun, 15 Jul 2018 21:00:40 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C9C397C88; Sun, 15 Jul 2018 21:00:39 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by mail-it0-x242.google.com with SMTP id j185-v6so18408981ite.1; Sun, 15 Jul 2018 14:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yzClGPKyL5USDaslOY3Vn9BcrYYhufIPOiV6UVDL2fU=; b=PHuUwdPTYBnz1F2UZCO8XkNb0ahI5JYiW6ANT4LzQiFK2LVtuyBfXChOE5Bz1WW7m2 5ACc7ceOH1lUqnEaN2MLxYmwqjPxF4rbaWhKUFoOBARcSKA+xZpB49r+i51iDvgJLHH7 Gn7AkwZbqwI2ijcXTiRs1wmKP9+z6ECamhsA3mz/eWLpVurm1b7qE9dZcbKNGqtJ+gRy 7e40ovp33QMuVFLk0M4eTZlUOT/AyaQmV0GpGCahQ6MpwPM/ICwohb/ZnI6t1UQ3rJKF U+JXVuFtKiKkevzgAjx5XYEBK41zwzkG/d/pjFq9+7unb0Q0INy7gjbXr6z/NfkOuVa0 cBAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yzClGPKyL5USDaslOY3Vn9BcrYYhufIPOiV6UVDL2fU=; b=SWnsRUACvkWT9XwvS4FOpyRvnTjzUsQerxAHesvtMtXeXuIUQeMIcZMC0Udjqai2y+ v3Zu7RGHMtDt+Ze20bbNhVZK8aXnUqGdSBOfv2zxXNXBPJhfwSMa7U5D1izRa0gMYLlL +9UZtviCvKwsiO3DIN6xNTes9tF6Jrx6WZdb6nWl4clvufGo4MzfVt1w7hrAk8x9gBp5 VsoA6tzwKDjdGdyN39wZHxZgJ6jNDpLwUg0aM1TDvhtnpR8R4EPbL2GepmhjBTg9OcSY s/1PnB7nwGGIKXV8XqDGBQGrkA97uxPnUmC73MDAPcxS+rpcvDbqpMKtTgWD0cyZi6Pp vOyA== X-Gm-Message-State: AOUpUlFdQAJG5GtOZP44jBBvCSxT43kX6NQoP+TjZhzl/YjDsXKDZnXe gwKHofdgEX62qa6gcbtbcNyw0EliHq/A2p8egL8= X-Google-Smtp-Source: AAOMgpe6vR0fg7OKPUoeka5JF6uXlc0Yc+pY9QkHJvOqFU23p4kZ2p7QZkon65nqh+VkYBqA2OWRDEVaDTc7DvKneb0= X-Received: by 2002:a02:8c94:: with SMTP id f20-v6mr12020487jak.98.1531688438369; Sun, 15 Jul 2018 14:00:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a02:8d2:0:0:0:0:0 with HTTP; Sun, 15 Jul 2018 14:00:37 -0700 (PDT) In-Reply-To: <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> References: <20180715184255.4965AE50@spqr.komquats.com> <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> From: Matthew Macy Date: Sun, 15 Jul 2018 14:00:37 -0700 Message-ID: Subject: Re: [PATCH] Recent libm additions To: "Montgomery-Smith, Stephen" Cc: Warner Losh , Cy Schubert , Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current , "freebsd-numerics@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 15 Jul 2018 22:17:21 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 21:00:40 -0000 On Sun, Jul 15, 2018 at 12:43 PM, Montgomery-Smith, Stephen wrote: > On 07/15/2018 02:09 PM, Warner Losh wrote: >> I'm not saying that he has a lock. I'm saying he's are domain expert and >> many mistakes can be avoided by talking to him. >> >> I'm saying we have history here, and that history, while poorly documented, >> wasn't followed. To the extent it is poorly documented, we should fix that. >> >> Warner >> > I agree that we should document the process. Maybe also include > freebsd-numerics@ on these discussions, as that is why it was created. > > But I'm really glad these changes were committed. I have found the > people tend to drag their feet a lot on numerics issues. > > Has anyone done an analysis of the OpenBSD powl functions from an > accuracy point of view? That is, to test how many ULP of error these > functions have? If not, I could give it a go, although not for several > months because life is very busy. They're also used by Julia. You might ask there first. -M From owner-freebsd-current@freebsd.org Sun Jul 15 22:49:18 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E398102DC97 for ; Sun, 15 Jul 2018 22:49:18 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (mail.soaustin.net [18.222.6.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.soaustin.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0A6D673CFF; Sun, 15 Jul 2018 22:49:17 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from lonesome.com (unknown [18.188.142.31]) by mail.soaustin.net (Postfix) with ESMTPSA id 20C8424935; Sun, 15 Jul 2018 22:49:11 +0000 (UTC) Date: Sun, 15 Jul 2018 22:49:10 +0000 From: Mark Linimon To: Warner Losh Cc: Cy Schubert , Ian Lepore , "K. Macy" , Steve Kargl , FreeBSD Current Subject: Re: [PATCH] Recent libm additions Message-ID: <20180715224909.GA3916@lonesome.com> References: <20180715184255.4965AE50@spqr.komquats.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 22:49:18 -0000 On Sun, Jul 15, 2018 at 01:09:41PM -0600, Warner Losh wrote: > I'm not saying that he has a lock. I'm saying he's are domain expert > and many mistakes can be avoided by talking to him. fwiw, substantially all the work done since at least 2013 is from kargl. (I am eliding the licensing, Makefile, and typo commits.) https://svnweb.freebsd.org/base/head/lib/msun/src/?sortby=date#dirlist mcl From owner-freebsd-current@freebsd.org Sun Jul 15 23:15:29 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7AD5102EE40 for ; Sun, 15 Jul 2018 23:15:29 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.protected-networks.net (mail.protected-networks.net [IPv6:2001:470:8d59:1::8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protected-networks.net", Issuer "Protected Networks CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 587D674AE4 for ; Sun, 15 Jul 2018 23:15:29 +0000 (UTC) (envelope-from imb@protected-networks.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= protected-networks.net; h=content-transfer-encoding :content-language:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:references:from :from:subject:subject; s=201508; t=1531696522; bh=jXcV7Lfn8a5gsu m5CKzz5OlO67F9KX/5oZnYZ1x2GPk=; b=f2j7mqjMIiJ1XszrCUcT11eFu/m6Ja nuKk5t+c28jdB2cXbFCta4/82tmIwcUmMtK+WE6oUiHguMH7jo8PM9TSKWSZnpZ+ rPL0ZgMCt5wCbdmhWGi1CEgniLfua8HRU+VKPrKh6i/6UXdzbBv5HgBrMlAGAjWt 1G+ZQ/JlnKaew= Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: imb@mail.protected-networks.net) by mail.protected-networks.net (Postfix) with ESMTPSA id E37833219; Sun, 15 Jul 2018 19:15:22 -0400 (EDT) Subject: Re: em0 link fail From: Michael Butler To: tech-lists , freebsd-current@freebsd.org References: <739ef71a-f29f-68ea-955a-fb53c57960a6@protected-networks.net> <8e2bf594-6d7e-477e-836b-4cc4483cb525@protected-networks.net> <64e462dd-16fc-b57f-7bf2-02068d0e24c8@zyxst.net> <7a4607ce-e212-5cba-bc04-1d0abf1a7824@protected-networks.net> Openpgp: preference=signencrypt Message-ID: Date: Sun, 15 Jul 2018 19:15:21 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <7a4607ce-e212-5cba-bc04-1d0abf1a7824@protected-networks.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 23:15:29 -0000 On 07/05/18 09:54, I wrote: > On 07/05/18 09:27, tech-lists wrote: >> On 03/07/2018 19:47, Michael Butler wrote: >>> That would've been .. >>> >>> Jun  1 09:56:15 toshi kernel: FreeBSD 12.0-CURRENT #35 r334484: Fri Jun >>> 1 08:25:58 EDT 2018 >>> >>> I'm going to build one with SVN r334862 reverted to see if that works, >> >> Hi, >> >> Is it working now? Am asking because a system I'd like to take from >> 11-stable to 12 uses the em driver. > > No :-( I haven't had the chance yet to revisit it, As it turns out, SVN r336313 (committed today) solves the issue I was having with the hardware stalling, imb From owner-freebsd-current@freebsd.org Sun Jul 15 23:55:40 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A5F410308CF for ; Sun, 15 Jul 2018 23:55:40 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660089.outbound.protection.outlook.com [40.107.66.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B44C376166 for ; Sun, 15 Jul 2018 23:55:39 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM (52.132.44.24) by YTOPR0101MB1433.CANPRD01.PROD.OUTLOOK.COM (52.132.47.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.18; Sun, 15 Jul 2018 23:55:37 +0000 Received: from YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e]) by YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM ([fe80::7098:a543:5be8:f30e%5]) with mapi id 15.20.0952.021; Sun, 15 Jul 2018 23:55:37 +0000 From: Rick Macklem To: "Rodney W. Grimes" CC: "freebsd-current@freebsd.org" , "andreas.nagy@frequentis.com" Subject: Re: NFSv4.1 server deficiencies fixed for ESXi client Thread-Topic: NFSv4.1 server deficiencies fixed for ESXi client Thread-Index: AQHUBjsXCbI4UKyOQkWL16OOOThmbqRkhj+AgCxegDiAADwmgw== Date: Sun, 15 Jul 2018 23:55:37 +0000 Message-ID: References: , <201806171442.w5HEg3pB060542@pdx.rh.CN85.dnsmgr.net>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1433; 7:Tu6H+HLrufo4PeJtjOINS/AVab1mBF1hjhKmqq+PM4/RhCuK9g24Wrooo5ByhC2i8HoekhzCArzggwwV/HEnfG0AQBfbvf+zUyUBgy382SafuwcpQCEKqgu/pMGk4h7Ua3GLA/NVt3ZdH1o/6esk0UNGBebff3Y9CdVDYPtYrOGawnznn41x3AYkN1/E1VNH7PT4HIHG6nMbrxo0iFZVNbqL3LaeiNZE2zbsiT+lI9F+uqCBx44r8ZI+J99cg+ht x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: e5bc6971-ee73-43c0-80f1-08d5eaae76b3 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1433; x-ms-traffictypediagnostic: YTOPR0101MB1433: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(3002001)(149027)(150027)(6041310)(20161123562045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123560045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:YTOPR0101MB1433; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1433; x-forefront-prvs: 07349BFAD2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(396003)(39850400004)(376002)(199004)(189003)(9686003)(55016002)(5660300001)(6436002)(229853002)(74482002)(486006)(478600001)(4326008)(97736004)(25786009)(476003)(11346002)(14454004)(256004)(446003)(53936002)(6246003)(6916009)(105586002)(106356001)(86362001)(186003)(26005)(7696005)(6506007)(102836004)(54906003)(2940100002)(76176011)(74316002)(5250100002)(81166006)(8676002)(81156014)(33656002)(305945005)(8936002)(68736007)(316002)(2900100001)(786003)(99286004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1433; H:YTOPR0101MB0953.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: eBjdimIGuyJgKhnYib1mexsfD+MsODdpJ0/HSjzbXMlLnD+9OuNDXOb4nyOG9MdTA5vtuA/lE4MoxpkWeztXnAqz9Zpz54nsdZIiaLs/YEGhIA9fFUwEEoLSrLMhbZymRNibfb9CVS1+bibh86XSM2WOYgayXLyefQyl0sfD04hR1X+iFlLkdJAQNk11WS9/Ai/dd3SI64SSQonAkdYLIXoK0rGVLa76qH0X2FVzERhTxueTwhR0nikRSK/PCMGJ5vGjNYtqimCYjm5x09eW+67L9tlMUfoET5nW6d8jFhnQxwiOiQUFk9qa/LLknC5kMjyf0RDYn+Gt0ajDsW49zewfPJmd65mNJedM2R1FpX0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: e5bc6971-ee73-43c0-80f1-08d5eaae76b3 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2018 23:55:37.8797 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1433 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jul 2018 23:55:40 -0000 I wrote: > (I am going to look and see what the Linux server does for this case.) I just looked and the Linux 4.17-rc2 kernel NFS server just returns NFS_OK for the rca_one_fs =3D=3D TRUE case. I have given a patch that does the sam= e thing for the FreeBSD server to Andreas and Daniel and think it is ok to commit, if it works. (I don't think it violates the RFC, since the RFC is v= ague w.r.t. when the rca_one_fs =3D=3D TRUE case is used and never mentions that an error should be returned when the server doesn't use it. rick From owner-freebsd-current@freebsd.org Mon Jul 16 12:18:00 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C3E0104DFCD; Mon, 16 Jul 2018 12:18:00 +0000 (UTC) (envelope-from dimpase@gmail.com) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C17AE8E3BB; Mon, 16 Jul 2018 12:17:59 +0000 (UTC) (envelope-from dimpase@gmail.com) Received: by mail-lj1-x243.google.com with SMTP id q5-v6so29736385ljh.12; Mon, 16 Jul 2018 05:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q0qgd+jQ4DNpLjWyQF5xgqLceE73/GS/KtspiISx7kY=; b=kQu23H5dSkNvCzEULeYLXd0N5m7FQN80KGF2zKAbkbrAQGTwDZfVcbGsuRvjxvwZAl 7kCshtN4ErD2DDNGX0akucex5FqUFSRXA4XttVgNuVuz2IgqNEsZZnSrJWplISwM6sNf 4QuW7fcrVys8jHYJwxK2GBaRMAjHW8Y5IS3p3tPzktJ4zxDHmGwlMW+zlSV2QL52TklR HuqpBbpkCanvDeoTd9Q+HOyk9TinKeF8BhyflSQhRQDon0RXHWxeCy0tJgzKv41URfEv OMBGk5WjWfDt6pBnJyjx6UINhnXNZIp4tc7Q8uvdOBwECLVorSyP7JY2R3PloAqO1pwG coyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q0qgd+jQ4DNpLjWyQF5xgqLceE73/GS/KtspiISx7kY=; b=ay/WH4rJAuR8oLA150uBzl9mYRIC7gTNFNRyrlzkEhapaBt0gnap0enyO9auaOp6Tw /TR1vcsSIRTaHTw+33YhNQT0jt+3xmesh5Xo3QJS9fdQmks+nDFZgjHqKUENGs7ntJm8 qCjNRVzHdeU3lIZXy3mSRuseE5vx+3GGnynrTZ4hWqC+VxEh7lLdmcwSF3cftdeA/itv 6ZZGn4SO3/cY8t3mJ9NepYBiDqIbz7MLW3bdrEInYApitpFnQR7AbAtkmgcImiUME+RL Deo6ODhNeCkk/NRVKo8JT4N/ipjEreZIb6y7axhxb5ATDbB3fUVBMWuKo92YYj5Z6FVE nR3g== X-Gm-Message-State: AOUpUlHVIaeXlwS4nX6psBIU5VQwvR93BrvPoNM61Absg08qqgpZVbeL Q8fHveqPugSgrVxnJrJmMqBZAirBA6oD9sT4Z1mmx3wH X-Google-Smtp-Source: AAOMgpcVV2/ypRqTFExc2l+wBh7acvZyvDwKA/KWY0UWup3Yaxt7MkHavTZnMkcDK/UUIuXJKCqYnOwm145k8hLbiHE= X-Received: by 2002:a2e:8346:: with SMTP id l6-v6mr10631807ljh.72.1531743478376; Mon, 16 Jul 2018 05:17:58 -0700 (PDT) MIME-Version: 1.0 References: <20180715184255.4965AE50@spqr.komquats.com> <4c91b1a4-ecaa-337e-c6d3-89e9d4fcaf83@missouri.edu> In-Reply-To: From: Dima Pasechnik Date: Mon, 16 Jul 2018 13:17:47 +0100 Message-ID: Subject: Re: [PATCH] Recent libm additions To: mat.macy@gmail.com Cc: "Montgomery-Smith, Stephen" , kmacy@freebsd.org, ian@freebsd.org, freebsd-numerics@freebsd.org, freebsd-current@freebsd.org, Steve Kargl , Cy.Schubert@cschubert.com, imp@bsdimp.com Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 16 Jul 2018 12:30:43 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 12:18:00 -0000 Julia's libm is https://github.com/JuliaMath/openlibm (or http://openlibm.org/) The do try merging latest from freebsd (msun), although it seems not the very latest. (see e.g. https://github.com/JuliaMath/openlibm/pull/118) I did try installing the master git branch of openlibm on FreeBSD 11.1 with clang, it builds and passes all tests they have. Does it make sense to contribute there more tests (if any --- they seem to have quite a list), to clear suspicions about precision? On Sun, Jul 15, 2018 at 10:03 PM Matthew Macy wrote: > > On Sun, Jul 15, 2018 at 12:43 PM, Montgomery-Smith, Stephen > wrote: > > On 07/15/2018 02:09 PM, Warner Losh wrote: > >> I'm not saying that he has a lock. I'm saying he's are domain expert and > >> many mistakes can be avoided by talking to him. > >> > >> I'm saying we have history here, and that history, while poorly documented, > >> wasn't followed. To the extent it is poorly documented, we should fix that. > >> > >> Warner > >> > > I agree that we should document the process. Maybe also include > > freebsd-numerics@ on these discussions, as that is why it was created. > > > > But I'm really glad these changes were committed. I have found the > > people tend to drag their feet a lot on numerics issues. > > > > Has anyone done an analysis of the OpenBSD powl functions from an > > accuracy point of view? That is, to test how many ULP of error these > > functions have? If not, I could give it a go, although not for several > > months because life is very busy. > > They're also used by Julia. You might ask there first. > -M > _______________________________________________ > freebsd-numerics@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-numerics > To unsubscribe, send any mail to "freebsd-numerics-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Mon Jul 16 20:12:29 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7250103B6B4 for ; Mon, 16 Jul 2018 20:12:29 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 7A5EE81A47 for ; Mon, 16 Jul 2018 20:12:29 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3D8F5103B6B0; Mon, 16 Jul 2018 20:12:29 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C3E1103B6AF for ; Mon, 16 Jul 2018 20:12:29 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DBEE381A46; Mon, 16 Jul 2018 20:12:28 +0000 (UTC) (envelope-from pstef@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1403) id D3EBD360B; Mon, 16 Jul 2018 20:12:28 +0000 (UTC) Date: Mon, 16 Jul 2018 22:12:28 +0200 From: "Piotr P. Stefaniak" To: Jeffrey Bouquet Cc: current Subject: Re: updates to HEAD online, RSS non-browser ?? Message-ID: <20180716201228.GE53055@freefall.freebsd.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.5 (2018-04-13) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 20:12:30 -0000 On 2018-07-14 04:36:05, Jeffrey Bouquet wrote: >secnetix.de used to let me read HEAD updates to src daily. About >several monhts ago, my browsers cannot reach it and the 2ndry site is >tedious to read in an equivalent manner. AFAIK the site is still up. >Recent EU laws or some other cause? Reachable by some legal VPN >trickery? RSS feed better serving to inform? legal web scraping >connects to site when browsers cannot? Would this suffice? https://github.com/freebsd/freebsd/commits/master.atom From owner-freebsd-current@freebsd.org Mon Jul 16 20:21:21 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 603FF103BBF2 for ; Mon, 16 Jul 2018 20:21:21 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic303-22.consmr.mail.ne1.yahoo.com (sonic303-22.consmr.mail.ne1.yahoo.com [66.163.188.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E3CCA81F9D for ; Mon, 16 Jul 2018 20:21:20 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: h6PNXIwVM1mSYpw4zImH43F289UVqTuWSw8565dQwDanFoasL_qxtrftIxgqDG1 KuEYSjL5JuQKT56odu3v7M28y8sEuAMEQYJa1CX4jYN0EnIlAg6ErCedpwLIM.1ZtO40all5ayxd 49YMJ3IpvybyG.OnhYhZ8GRoLn7YaPMXRLqDdfyUbQhi4kQ3p_Vaoyt8aJ6Z.qCwcHxTkf_oBrFK sAWfRhh8EXQguYouQA6ckbcQ1_mZj8.LYeevOqBNE.t8y2lR7XKjFl2nppv4sFsqQslWxfL_qOZm oEZe3njf0vPESW1VeK8mlSTNZYZiJK4p0fLOHfzjhJffupQC_m6ocwnXKGYaVt4smswUP318hYsz _74xKSZ1Pmc0fsoCq53I4hcAcIrMxySI00puZHkon_y22jXp8Z9350FEe_q316VbPEERzZw7GC2K xqi_KPr3zuJa2sMvAZP3HpvTucoq8EUkTclJFJr5txAksK.kmlrRR6mWIPoRLhTjHCnICsZFiTML 1DP_lPGRnLurw6PvFwZZUYIS1Ky0U.WSHKEFPthAChmOXJbe2X9yArKsWfH4UX0x6seo2VGCpHCj uKEVzDLdOPzVNE2NlIhS5haplYfH0AlEezzBmGw8Buxzmu2yHr_rOS6jkoYXbmTRVaoJ7HM96L4r AsLA.G0QrLM1j2s0bprmXE1Zk9WsiAsGOimXjKjqCN44HgwQ1CMNZWaJ8_B_kUrEVJbjQJXAdpbZ gL2.9notF4ER2lc2NZPU9wR4LIToc9fteH4jSSdcImsht7Aa0lUfQ1_lH7dcwUMPZWiV_tBA6MTd i5sl29SggK.j5Oxk9EBMs4.rDd0OAusGT9gUJomBFUzUoCws5ULsowO9NAcLtBg_Vg0MnaOgBmzi Lpkb9vmQfTcvNxuP8P3t5uOQPVWCseozolwljvHjj9Bda7T6.Fek4Eg.a3pCb01KfT1CPGSgJved pOiOfPyuUAvWpij7z1yu4smedkCGdvQuGTQp.P4GbG.XwK9c93wouwHnxMlTMiwFCnQ-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.ne1.yahoo.com with HTTP; Mon, 16 Jul 2018 20:21:14 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp428.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d9cae92556db746754479a1e18f61fa7; Mon, 16 Jul 2018 20:21:12 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd Message-Id: Date: Mon, 16 Jul 2018 13:21:10 -0700 Cc: Bryan Drewery To: FreeBSD Toolchain , freebsd-arm , FreeBSD Current X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 20:21:21 -0000 I attempted a from-scratch (. . ./arm64.aarch64/ empty) kernel-toolchain = buildkernel targeting aarch64 from amd64 based on head -r336349 . It failed by = ending up using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : . . . --- buildkernel --- Building = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-N= ODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld --- accf_data.kld --- ld: unrecognised emulation mode: aarch64elf Supported emulations: elf_x86_64_fbsd elf_i386_fbsd *** [accf_data.kld] Error code 1 make[4]: stopped in /usr/src/sys/modules/accf_data .ERROR_TARGET=3D'accf_data.kld' = .ERROR_META_FILE=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.a= arch64/sys/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data/accf_data.k= ld.meta' .MAKE.LEVEL=3D'4' MAKEFILE=3D'' .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' _ERROR_CMD=3D'ld -m aarch64elf -d -warn-common -r -d -o accf_data.kld = accf_data.o; ctfmerge -L VERSION -g -o accf_data.kld accf_data.o; :> = export_syms; awk -f /usr/src/sys/conf/kmod_syms.awk accf_data.kld = export_syms | xargs -J% objcopy % accf_data.kld;' .CURDIR=3D'/usr/src/sys/modules/accf_data' .MAKE=3D'make' = .OBJDIR=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sy= s/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data' .TARGETS=3D'all' DESTDIR=3D'' LD_LIBRARY_PATH=3D'' MACHINE=3D'arm64' MACHINE_ARCH=3D'aarch64' = MAKEOBJDIRPREFIX=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.a= arch64/sys/GENERIC-NODBG/modules' MAKESYSPATH=3D'/usr/src/share/mk' MAKE_VERSION=3D'20180512' = PATH=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/tmp/l= egacy/usr/sbin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch6= 4/tmp/legacy/usr/bin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.= aarch64/tmp/legacy/bin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm6= 4.aarch64/tmp/usr/sbin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm6= 4.aarch64/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin' SRCTOP=3D'/usr/src' = OBJTOP=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys= /GENERIC-NODBG/modules/usr/src' .MAKE.MAKEFILES=3D'/usr/src/share/mk/sys.mk = /usr/src/share/mk/local.sys.env.mk /usr/src/share/mk/src.sys.env.mk = /root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64-host = /usr/src/share/mk/bsd.mkopt.mk /usr/src/share/mk/src.sys.obj.mk = /usr/src/share/mk/auto.obj.mk /usr/src/share/mk/bsd.suffixes.mk = /root/src.configs/make.conf /usr/src/share/mk/local.sys.mk = /usr/src/share/mk/src.sys.mk /dev/null = /usr/src/sys/modules/accf_data/Makefile /usr/src/share/mk/bsd.kmod.mk = /usr/src/sys/conf/kmod.mk /usr/src/share/mk/bsd.init.mk = /usr/src/share/mk/bsd.opts.mk /usr/src/share/mk/bsd.cpu.mk = /usr/src/share/mk/local.init.mk /usr/src/share/mk/src.init.mk = /usr/src/sys/modules/accf_data/../Makefile.inc = /usr/src/share/mk/bsd.own.mk /usr/src/share/mk/bsd.compiler.mk = /usr/src/share/mk/bsd.linker.mk /usr/src/sys/conf/kern.opts.mk = /usr/src/sys/conf/config.mk /usr/src/share/mk/bsd.links.mk = /usr/src/share/mk/bsd.dep.mk /usr/src/share/mk/bsd.clang-analyze.mk = /usr/src/share/mk/bsd.obj.mk /usr/src/share/mk/bsd.subdir.mk = /usr/src/sys/conf/kern.mk' .PATH=3D'. /usr/src/sys/modules/accf_data /usr/src/sys/netinet = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-N= ODBG' 1 error Detailed context: # uname -apKU FreeBSD FBSDUSSD 12.0-CURRENT FreeBSD 12.0-CURRENT r336349M amd64 = amd64 1200073 1200073 The "M" is mostly for powerpc* family experiments: # svnlite status /usr/src/ | sort ? /usr/src/sys/amd64/conf/GENERIC-DBG ? /usr/src/sys/amd64/conf/GENERIC-NODBG ? /usr/src/sys/arm/conf/GENERIC-DBG ? /usr/src/sys/arm/conf/GENERIC-NODBG ? /usr/src/sys/arm64/conf/GENERIC-DBG ? /usr/src/sys/arm64/conf/GENERIC-NODBG ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-DBG ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-NODBG ? /usr/src/sys/powerpc/conf/GENERICvtsc-DBG ? /usr/src/sys/powerpc/conf/GENERICvtsc-NODBG M /usr/src/Makefile.libcompat M /usr/src/contrib/llvm/lib/Target/PowerPC/PPCFrameLowering.cpp M /usr/src/contrib/llvm/tools/lld/ELF/Arch/PPC64.cpp M /usr/src/crypto/openssl/crypto/armcap.c M /usr/src/lib/libkvm/kvm_powerpc.c M /usr/src/lib/libkvm/kvm_private.c M /usr/src/release/Makefile.vm M /usr/src/release/scripts/mk-vmimage.sh M /usr/src/release/tools/vmimage.subr M /usr/src/secure/lib/libcrypto/Makefile M /usr/src/stand/defs.mk M /usr/src/stand/powerpc/boot1.chrp/Makefile M /usr/src/stand/powerpc/kboot/Makefile M /usr/src/sys/arm64/arm64/identcpu.c M /usr/src/sys/conf/kmod.mk M /usr/src/sys/conf/ldscript.powerpc M /usr/src/sys/powerpc/aim/mmu_oea64.c M /usr/src/sys/powerpc/ofw/ofw_machdep.c # more /usr/src/sys/arm64/conf/GENERIC-NODBG # # GENERIC -- Custom configuration for the arm64/aarch64 # include "GENERIC" ident GENERIC-NODBG makeoptions DEBUG=3D-g # Build kernel with gdb(1) = debug symbols options ALT_BREAK_TO_DEBUGGER options KDB # Enable kernel debugger support # For minimum debugger support (stable branch) use: #options KDB_TRACE # Print a stack trace for a = panic options DDB # Enable the kernel debugger # Extra stuff: #options VERBOSE_SYSINIT # Enable verbose sysinit = messages #options BOOTVERBOSE=3D1 #options BOOTHOWTO=3DRB_VERBOSE #options KTR #options KTR_MASK=3DKTR_TRAP ##options KTR_CPUMASK=3D0xF #options KTR_VERBOSE # Disable any extra checking for. . . nooptions DEADLKRES # Enable the deadlock resolver nooptions INVARIANTS # Enable calls of extra sanity = checking nooptions INVARIANT_SUPPORT # Extra sanity checks of = internal structures, required by INVARIANTS nooptions WITNESS # Enable checks to detect = deadlocks and cycles nooptions WITNESS_SKIPSPIN # Don't run witness on spinlocks = for speed nooptions DIAGNOSTIC nooptions MALLOC_DEBUG_MAXZONES # Separate malloc(9) zones nooptions BUF_TRACKING nooptions FULL_BUF_TRACKING # more = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh -j4 kernel-toolchain buildkernel kldload -n filemon && \ script = ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-amd64-= host-$(date +%Y-%m-%d:%H:%M:%S) \ env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" = SRC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ WITH_META_MODE=3Dyes \ MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ make $* # more ~/src.configs/src.conf.cortexA53-clang-bootstrap.amd64-host TO_TYPE=3Daarch64 TOOLS_TO_TYPE=3D${TO_TYPE} VERSION_CONTEXT=3D12.0 # KERNCONF=3DGENERIC-NODBG TARGET=3Darm64 .if ${.MAKE.LEVEL} =3D=3D 0 TARGET_ARCH=3D${TO_TYPE} .export TARGET_ARCH .endif # WITH_CROSS_COMPILER=3D WITHOUT_SYSTEM_COMPILER=3D WITHOUT_SYSTEM_LINKER=3D # WITH_LIBCPLUSPLUS=3D WITH_LLD_BOOTSTRAP=3D WITHOUT_BINUTILS_BOOTSTRAP=3D WITH_ELFTOOLCHAIN_BOOTSTRAP=3D WITH_CLANG_BOOTSTRAP=3D WITH_CLANG=3D WITH_CLANG_IS_CC=3D WITH_CLANG_FULL=3D WITH_CLANG_EXTRAS=3D WITH_LLD=3D WITH_LLD_IS_LD=3D WITH_LLDB=3D # WITH_BOOT=3D WITHOUT_LIB32=3D # WITHOUT_GCC_BOOTSTRAP=3D WITHOUT_GCC=3D WITHOUT_GCC_IS_CC=3D WITHOUT_GNUCXX=3D # NO_WERROR=3D #WERROR=3D MALLOC_PRODUCTION=3D # WITH_REPRODUCIBLE_BUILD=3D WITH_DEBUG_FILES=3D # = #CROSS_BINUTILS_PREFIX=3D/usr/local/${TOOLS_TO_TYPE}-unknown-freebsd${VERS= ION_CONTEXT}/bin/ XCFLAGS+=3D -mcpu=3Dcortex-a53 XCXXFLAGS+=3D -mcpu=3Dcortex-a53 # There is no XCPPFLAGS but XCPP gets XCFLAGS content. ACFLAGS.arm64cpuid.S+=3D -mcpu=3Dcortex-a53+crypto ACFLAGS.aesv8-armx.S+=3D -mcpu=3Dcortex-a53+crypto ACFLAGS.ghashv8-armx.S+=3D -mcpu=3Dcortex-a53+crypto # more ~/src.configs/make.conf CFLAGS.gcc+=3D -v =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Mon Jul 16 22:32:02 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2A591040646; Mon, 16 Jul 2018 22:32:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8C4EF8602C; Mon, 16 Jul 2018 22:32:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 40B8D4DAE; Mon, 16 Jul 2018 22:32:01 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id CA94EAF35; Mon, 16 Jul 2018 22:31:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id yyc2kjbHF5jm; Mon, 16 Jul 2018 22:31:54 +0000 (UTC) Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 2DD27AF30 To: Mark Millard , FreeBSD Toolchain , freebsd-arm , FreeBSD Current References: From: Bryan Drewery Openpgp: preference=signencrypt Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8FAlJp hmsCGwwFCQlmAYAACgkQNddxu25Gl89UPggA2mGQp28yCUKsJ6KHFVy/lpHfoQrKF+s7HfKT U2ObVeVNX4I8ZdW1UO48mRqxEOwY8r5YSH6X06OmiqCX2aSMXg3N06/l+ztlB0+UGGlkXBjv l9/nii+bC6b8XWuu0X7Qpb9oYBK9YtoaoyuVplAmjdj/cPou65meKIaS1yDTjHh450DrW8Qg he6l0bFX4BHKTSm99U90ML7EY19B6iI2BZSqWutVsyD71oAREY6NGgDpCOIO6FS41+WeYCDR j8vsa/BiaoX2d2SBDsCwsEwe9fg5PYMi2uVIhvL6OrxnwOdB+TkgvOy5zZSNO29UG/JilZKo Ndz2wpEaUzChGGqLvcLAZQQYAQoADwIbDAUCWujOKAUJCmB7PQAKCRA113G7bkaXz6bkB/9H dUR3E0wBwMh6z0AOFDKh+PbRI9Xd4IncdhE55tNK410650a3gADIDwqz3i72GIinkgaxzpEO xP1bs7a+BeF3p5Xd6Jjk6J/nEshisgNW7VjUbJHFGs8Sf9A6oM3q4VkI/ArVo5qkZxgKs72U HSAy5NV+AdqdTrWuAL20xfQ6gA7JF35Xf8zyUM2GMl0X8ik7dJ1jMp+TB27LipqbDgamFzH9 F9hC9gur94OQ/x3nQ+mFZ1uipYHA1EdrKuhb/Ts4bN/Ezl8nmYGxc9Bw7ZBxGOTId/rEIzoe LWpAvg6dcw0T9lNfSWc6PX+kf3dOXNIdkw9NqKID8wEPe8axcGYG Organization: FreeBSD Message-ID: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> Date: Mon, 16 Jul 2018 15:31:50 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9hQNWkjsIiiFcIPhNDnsTlDwnzJBg9A99" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 22:32:02 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9hQNWkjsIiiFcIPhNDnsTlDwnzJBg9A99 Content-Type: multipart/mixed; boundary="B00CnU7wHsjjMXqvoeTfgybVZDaFqJEtr"; protected-headers="v1" From: Bryan Drewery To: Mark Millard , FreeBSD Toolchain , freebsd-arm , FreeBSD Current Message-ID: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd References: In-Reply-To: --B00CnU7wHsjjMXqvoeTfgybVZDaFqJEtr Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/16/18 1:21 PM, Mark Millard wrote: > I attempted a from-scratch (. . ./arm64.aarch64/ empty) kernel-toolchai= n buildkernel > targeting aarch64 from amd64 based on head -r336349 . It failed by endi= ng up > using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : I probably extended the LLVM_TARGET_ALL=3Dno in cross-compiler too far. I= thought I had left that out for kernel-toolchain but apparently not. Try this patch and kernel-toolchain after applying please: http://people.freebsd.org/~bdrewery/patches/cross-compiler-fix.diff >=20 > . . . > --- buildkernel --- > Building /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/s= ys/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld > --- accf_data.kld --- > ld: unrecognised emulation mode: aarch64elf > Supported emulations: elf_x86_64_fbsd elf_i386_fbsd > *** [accf_data.kld] Error code 1 >=20 > make[4]: stopped in /usr/src/sys/modules/accf_data > .ERROR_TARGET=3D'accf_data.kld' > .ERROR_META_FILE=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm6= 4.aarch64/sys/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data/accf_da= ta.kld.meta' > .MAKE.LEVEL=3D'4' > MAKEFILE=3D'' > .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dye= s verbose' > _ERROR_CMD=3D'ld -m aarch64elf -d -warn-common -r -d -o accf_data.kld a= ccf_data.o; ctfmerge -L VERSION -g -o accf_data.kld accf_data.o; :> expor= t_syms; awk -f /usr/src/sys/conf/kmod_syms.awk accf_data.kld export_syms= | xargs -J% objcopy % accf_data.kld;' > .CURDIR=3D'/usr/src/sys/modules/accf_data' > .MAKE=3D'make' > .OBJDIR=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64= /sys/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data' > .TARGETS=3D'all' > DESTDIR=3D'' > LD_LIBRARY_PATH=3D'' > MACHINE=3D'arm64' > MACHINE_ARCH=3D'aarch64' > MAKEOBJDIRPREFIX=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm6= 4.aarch64/sys/GENERIC-NODBG/modules' > MAKESYSPATH=3D'/usr/src/share/mk' > MAKE_VERSION=3D'20180512' > PATH=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/tm= p/legacy/usr/sbin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aa= rch64/tmp/legacy/usr/bin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/a= rm64.aarch64/tmp/legacy/bin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/sr= c/arm64.aarch64/tmp/usr/sbin:/usr/obj/cortexA53_clang/arm64.aarch64/usr/s= rc/arm64.aarch64/tmp/usr/bin:/sbin:/bin:/usr/sbin:/usr/bin' > SRCTOP=3D'/usr/src' > OBJTOP=3D'/usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/= sys/GENERIC-NODBG/modules/usr/src' > .MAKE.MAKEFILES=3D'/usr/src/share/mk/sys.mk /usr/src/share/mk/local.sys= =2Eenv.mk /usr/src/share/mk/src.sys.env.mk /root/src.configs/src.conf.cor= texA53-clang-bootstrap.amd64-host /usr/src/share/mk/bsd.mkopt.mk /usr/src= /share/mk/src.sys.obj.mk /usr/src/share/mk/auto.obj.mk /usr/src/share/mk/= bsd.suffixes.mk /root/src.configs/make.conf /usr/src/share/mk/local.sys.m= k /usr/src/share/mk/src.sys.mk /dev/null /usr/src/sys/modules/accf_data/M= akefile /usr/src/share/mk/bsd.kmod.mk /usr/src/sys/conf/kmod.mk /usr/src/= share/mk/bsd.init.mk /usr/src/share/mk/bsd.opts.mk /usr/src/share/mk/bsd.= cpu.mk /usr/src/share/mk/local.init.mk /usr/src/share/mk/src.init.mk /usr= /src/sys/modules/accf_data/../Makefile.inc /usr/src/share/mk/bsd.own.mk /= usr/src/share/mk/bsd.compiler.mk /usr/src/share/mk/bsd.linker.mk /usr/src= /sys/conf/kern.opts.mk /usr/src/sys/conf/config.mk /usr/src/share/mk/bsd.= links.mk /usr/src/share/mk/bsd.dep.mk /usr/src/share/mk/bsd.clang-analyze= =2Emk /usr/src/share/mk/bsd.obj.mk /usr/src/share/mk/bsd.subdir.mk /usr/s= rc/sys/conf/kern.mk' > .PATH=3D'. /usr/src/sys/modules/accf_data /usr/src/sys/netinet /usr/obj= /cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-NODBG' > 1 error >=20 >=20 >=20 > Detailed context: >=20 > # uname -apKU > FreeBSD FBSDUSSD 12.0-CURRENT FreeBSD 12.0-CURRENT r336349M amd64 amd= 64 1200073 1200073 >=20 > The "M" is mostly for powerpc* family experiments: >=20 > # svnlite status /usr/src/ | sort > ? /usr/src/sys/amd64/conf/GENERIC-DBG > ? /usr/src/sys/amd64/conf/GENERIC-NODBG > ? /usr/src/sys/arm/conf/GENERIC-DBG > ? /usr/src/sys/arm/conf/GENERIC-NODBG > ? /usr/src/sys/arm64/conf/GENERIC-DBG > ? /usr/src/sys/arm64/conf/GENERIC-NODBG > ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-DBG > ? /usr/src/sys/powerpc/conf/GENERIC64vtsc-NODBG > ? /usr/src/sys/powerpc/conf/GENERICvtsc-DBG > ? /usr/src/sys/powerpc/conf/GENERICvtsc-NODBG > M /usr/src/Makefile.libcompat > M /usr/src/contrib/llvm/lib/Target/PowerPC/PPCFrameLowering.cpp > M /usr/src/contrib/llvm/tools/lld/ELF/Arch/PPC64.cpp > M /usr/src/crypto/openssl/crypto/armcap.c > M /usr/src/lib/libkvm/kvm_powerpc.c > M /usr/src/lib/libkvm/kvm_private.c > M /usr/src/release/Makefile.vm > M /usr/src/release/scripts/mk-vmimage.sh > M /usr/src/release/tools/vmimage.subr > M /usr/src/secure/lib/libcrypto/Makefile > M /usr/src/stand/defs.mk > M /usr/src/stand/powerpc/boot1.chrp/Makefile > M /usr/src/stand/powerpc/kboot/Makefile > M /usr/src/sys/arm64/arm64/identcpu.c > M /usr/src/sys/conf/kmod.mk > M /usr/src/sys/conf/ldscript.powerpc > M /usr/src/sys/powerpc/aim/mmu_oea64.c > M /usr/src/sys/powerpc/ofw/ofw_machdep.c >=20 > # more /usr/src/sys/arm64/conf/GENERIC-NODBG > # > # GENERIC -- Custom configuration for the arm64/aarch64 > # >=20 > include "GENERIC" >=20 > ident GENERIC-NODBG >=20 > makeoptions DEBUG=3D-g # Build kernel with gdb(1) de= bug symbols >=20 > options ALT_BREAK_TO_DEBUGGER >=20 > options KDB # Enable kernel debugger suppor= t >=20 > # For minimum debugger support (stable branch) use: > #options KDB_TRACE # Print a stack trace for a pan= ic > options DDB # Enable the kernel debugger >=20 > # Extra stuff: > #options VERBOSE_SYSINIT # Enable verbose sysinit messag= es > #options BOOTVERBOSE=3D1 > #options BOOTHOWTO=3DRB_VERBOSE > #options KTR > #options KTR_MASK=3DKTR_TRAP > ##options KTR_CPUMASK=3D0xF > #options KTR_VERBOSE >=20 > # Disable any extra checking for. . . > nooptions DEADLKRES # Enable the deadlock resolver > nooptions INVARIANTS # Enable calls of extra sanity = checking > nooptions INVARIANT_SUPPORT # Extra sanity checks of intern= al structures, required by INVARIANTS > nooptions WITNESS # Enable checks to detect deadl= ocks and cycles > nooptions WITNESS_SKIPSPIN # Don't run witness on spinlock= s for speed > nooptions DIAGNOSTIC > nooptions MALLOC_DEBUG_MAXZONES # Separate malloc(9) zones > nooptions BUF_TRACKING > nooptions FULL_BUF_TRACKING >=20 >=20 > # more ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_boot= strap-amd64-host.sh -j4 kernel-toolchain buildkernel > kldload -n filemon && \ > script ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootst= rap-amd64-host-$(date +%Y-%m-%d:%H:%M:%S) \ > env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" S= RC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ > WITH_META_MODE=3Dyes \ > MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ > make $* >=20 >=20 > # more ~/src.configs/src.conf.cortexA53-clang-bootstrap.amd64-host > TO_TYPE=3Daarch64 > TOOLS_TO_TYPE=3D${TO_TYPE} > VERSION_CONTEXT=3D12.0 > # > KERNCONF=3DGENERIC-NODBG > TARGET=3Darm64 > .if ${.MAKE.LEVEL} =3D=3D 0 > TARGET_ARCH=3D${TO_TYPE} > .export TARGET_ARCH > .endif > # > WITH_CROSS_COMPILER=3D > WITHOUT_SYSTEM_COMPILER=3D > WITHOUT_SYSTEM_LINKER=3D > # > WITH_LIBCPLUSPLUS=3D > WITH_LLD_BOOTSTRAP=3D > WITHOUT_BINUTILS_BOOTSTRAP=3D > WITH_ELFTOOLCHAIN_BOOTSTRAP=3D > WITH_CLANG_BOOTSTRAP=3D > WITH_CLANG=3D > WITH_CLANG_IS_CC=3D > WITH_CLANG_FULL=3D > WITH_CLANG_EXTRAS=3D > WITH_LLD=3D > WITH_LLD_IS_LD=3D > WITH_LLDB=3D > # > WITH_BOOT=3D > WITHOUT_LIB32=3D > # > WITHOUT_GCC_BOOTSTRAP=3D > WITHOUT_GCC=3D > WITHOUT_GCC_IS_CC=3D > WITHOUT_GNUCXX=3D > # > NO_WERROR=3D > #WERROR=3D > MALLOC_PRODUCTION=3D > # > WITH_REPRODUCIBLE_BUILD=3D > WITH_DEBUG_FILES=3D > # > #CROSS_BINUTILS_PREFIX=3D/usr/local/${TOOLS_TO_TYPE}-unknown-freebsd${V= ERSION_CONTEXT}/bin/ > XCFLAGS+=3D -mcpu=3Dcortex-a53 > XCXXFLAGS+=3D -mcpu=3Dcortex-a53 > # There is no XCPPFLAGS but XCPP gets XCFLAGS content. > ACFLAGS.arm64cpuid.S+=3D -mcpu=3Dcortex-a53+crypto > ACFLAGS.aesv8-armx.S+=3D -mcpu=3Dcortex-a53+crypto > ACFLAGS.ghashv8-armx.S+=3D -mcpu=3Dcortex-a53+crypto >=20 >=20 > # more ~/src.configs/make.conf > CFLAGS.gcc+=3D -v >=20 >=20 >=20 > =3D=3D=3D > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) >=20 --=20 Regards, Bryan Drewery --B00CnU7wHsjjMXqvoeTfgybVZDaFqJEtr-- --9hQNWkjsIiiFcIPhNDnsTlDwnzJBg9A99 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAltNHNgACgkQNddxu25G l8+O9gf9Hz8QsXdsaRARH4qjLWrxuqAV11YV1w/VXG6+nb7fHwPItKOO7JtA8oAV SnNxU7b2F5iSxnZbWBD8g5tX+kZdL5eqNc8EYqGwxiaGsjFlSsocBivlI37OEZbQ oEiZrohHinMrt+iSUoPelRbXq7HoBJG9egzN3TUE/Yyeh7gKnfGmbp2tXDGrgbIT tWpGeiIPvFruh79tUzapGLktC9O7oYtC0cKuqY0aCJZf8T7/orHtAmnPUaAwBgrE NpRNQ3557r5Poqg823odO5Avx8GARbZ88xGlhy74lvp7YZiYU3Kx83FINaTMJfPR xFmX13AIMOy/RbcvQYoI0PLgMmZHrg== =XBV5 -----END PGP SIGNATURE----- --9hQNWkjsIiiFcIPhNDnsTlDwnzJBg9A99-- From owner-freebsd-current@freebsd.org Mon Jul 16 22:59:59 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DE991041506 for ; Mon, 16 Jul 2018 22:59:59 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-22.consmr.mail.gq1.yahoo.com (sonic301-22.consmr.mail.gq1.yahoo.com [98.137.64.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CFBE086C8C for ; Mon, 16 Jul 2018 22:59:58 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: elj_JTUVM1mqv2gDysdYu1WBwS4VSu0RMbgjHQhQYJ8DsW3s9.S_y7rOWt20pmh 7RufEnikmEzKJWB9AKLki42TfMgT_5AN.n6eYUA76sw1hLRbXZosxRuuYQy.Y.lCXQVi9V2ZLSOv 75PYJFJvJSB4g5gWQ13oAojL.LDgzALtB.a_rTg.arDjg0o.HM5a7370kER05QZ3WQsEDguxJ3T_ X0GvpmGnh.DRBmctZqQXEkDyc8jvEHaht0xQMwol4QfJJEwRe8eZ3QQPG2G8PDG8jr3coustsBzV T4tat87qQsNgN3eZJgURJAIe1fcUXxPPKsFQdiOSawpkIQl9LbMX9T2UEgOZ3n0BwbfKDeQkhH81 l2KNL_9.KFWJY.Fqu9LIWrmSGWQyRL8KZU059trNMIlb.R8Be5ae7Pcbm0PGal7_knSBAuAYW1_V RhNwMr6noKf79EgEvBPTam7x8GbEtdEeFz9mSBaDNu3cLgGdGztoZZlrwB6FctiIDhrdAL8lmnxT sJb3FaTnZnOq5eIWWOEMoxEZ1J.8TwSWK3.QSIH3KQLE8v2UlJLqWkX.EPuFN2LxiQ2YKgYsiAqJ ZkLukvXS8RnnRAknX6xdvvxiD2_Q0eMf6fJ6uYdAFganD8ewQpe7parYjfNggKFsi8R2auANw1V5 .up71ud22Zg6yQpQ06h4v4aw4_sWB8jTgFm2C.gP8a43BsXu9XXiiULLscCb2we3rBsDoGnPE6s2 grvgCJcYmxPgt96Iv5CbgPxy5gAKzo5wFaI5beDAQXMMXEMqAaYl3dbGdhmMlFi5RiiGERmf3QE0 9iH8BbDlY7y_2.ysuS8UiZK5u40kZTXUCyt_AofjVFjlS.k7DZoBvpaYeB_uPl4CwOMV5CGY48AS ZR8spu8Av1wPyu0f0B5J4Ej1mBzXN9Rfy6G_3BVIP6cFJJaAFTZ7mlt3KF2vKUiTN2AVbP9glTvR W5CB3zqLFDIhIirm4L3J3LJqaYQWgrOTmIjaEkIMD98hN_IAjY7yF0nvzSliGqYbwGEa1 Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Mon, 16 Jul 2018 22:59:51 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp417.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d7ba5ffb21bfc24edaae8b7218e52d27; Mon, 16 Jul 2018 22:49:42 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd From: Mark Millard In-Reply-To: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> Date: Mon, 16 Jul 2018 15:49:40 -0700 Cc: FreeBSD Toolchain , freebsd-arm , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> References: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 22:59:59 -0000 On 2018-Jul-16, at 3:31 PM, Bryan Drewery = wrote: > On 7/16/18 1:21 PM, Mark Millard wrote: >> I attempted a from-scratch (. . ./arm64.aarch64/ empty) = kernel-toolchain buildkernel >> targeting aarch64 from amd64 based on head -r336349 . It failed by = ending up >> using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : >=20 > I probably extended the LLVM_TARGET_ALL=3Dno in cross-compiler too = far. I > thought I had left that out for kernel-toolchain but apparently not. >=20 > Try this patch and kernel-toolchain after applying please: > http://people.freebsd.org/~bdrewery/patches/cross-compiler-fix.diff > . . . Result is unchanged. Details follow. With: # svnlite diff /usr/src/Makefile.inc1 Index: /usr/src/Makefile.inc1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- /usr/src/Makefile.inc1 (revision 336349) +++ /usr/src/Makefile.inc1 (working copy) @@ -666,7 +666,7 @@ BMAKE=3D \ ${BMAKEENV} ${MAKE} ${WORLD_FLAGS} -f Makefile.inc1 \ ${BSARGS} -.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) +.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) && !make(*toolchain*) BMAKE+=3D MK_LLVM_TARGET_ALL=3Dno .endif =20 used via: # rm -fr /usr/obj/cortexA53_clang/arm64.aarch64/* # = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh -j4 kernel-toolchain buildkernel I still get: --- buildkernel --- Building = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-N= ODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld --- accf_data.kld --- ld: unrecognised emulation mode: aarch64elf Supported emulations: elf_x86_64_fbsd elf_i386_fbsd *** [accf_data.kld] Error code 1 Reminder of what my .sh script does: # more = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh kldload -n filemon && \ script = ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-amd64-= host-$(date +%Y-%m-%d:%H:%M:%S) \ env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" = SRC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ WITH_META_MODE=3Dyes \ MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ make $* (I'll not repeat the other supporting material.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Mon Jul 16 23:48:03 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8ABFB1042EFB; Mon, 16 Jul 2018 23:48:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27355893CE; Mon, 16 Jul 2018 23:48:03 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id E3EB25FDB; Mon, 16 Jul 2018 23:48:02 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 8DAFBA00D; Mon, 16 Jul 2018 23:48:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id iyUPMC3Ti6S2; Mon, 16 Jul 2018 23:47:54 +0000 (UTC) Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 26314A008 To: Mark Millard Cc: FreeBSD Toolchain , freebsd-arm , FreeBSD Current References: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <0b5b2181-7335-325c-3e7a-f882a48fcd69@FreeBSD.org> Date: Mon, 16 Jul 2018 16:47:53 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7Rd8MBSaacApsny1CN7IoCbi05fTFLgZH" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 23:48:03 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7Rd8MBSaacApsny1CN7IoCbi05fTFLgZH Content-Type: multipart/mixed; boundary="YwE7MHjPBi2iZDHrPika8svfGIe9a5wF2"; protected-headers="v1" From: Bryan Drewery To: Mark Millard Cc: FreeBSD Toolchain , freebsd-arm , FreeBSD Current Message-ID: <0b5b2181-7335-325c-3e7a-f882a48fcd69@FreeBSD.org> Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd References: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> In-Reply-To: <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> --YwE7MHjPBi2iZDHrPika8svfGIe9a5wF2 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/16/2018 3:49 PM, Mark Millard wrote: >=20 >=20 > On 2018-Jul-16, at 3:31 PM, Bryan Drewery wro= te: >=20 >> On 7/16/18 1:21 PM, Mark Millard wrote: >>> I attempted a from-scratch (. . ./arm64.aarch64/ empty) kernel-toolch= ain buildkernel >>> targeting aarch64 from amd64 based on head -r336349 . It failed by en= ding up >>> using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : >> >> I probably extended the LLVM_TARGET_ALL=3Dno in cross-compiler too far= =2E I >> thought I had left that out for kernel-toolchain but apparently not. >> >> Try this patch and kernel-toolchain after applying please: >> http://people.freebsd.org/~bdrewery/patches/cross-compiler-fix.diff >> . . . >=20 > Result is unchanged. Details follow. Ok, I'll look more tomorrow. >=20 > With: >=20 > # svnlite diff /usr/src/Makefile.inc1 > Index: /usr/src/Makefile.inc1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- /usr/src/Makefile.inc1 (revision 336349) > +++ /usr/src/Makefile.inc1 (working copy) > @@ -666,7 +666,7 @@ > BMAKE=3D \ > ${BMAKEENV} ${MAKE} ${WORLD_FLAGS} -f Makefile.inc1 \ > ${BSARGS} > -.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) > +.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) && !make(*toolchain*) > BMAKE+=3D MK_LLVM_TARGET_ALL=3Dno > .endif > =20 > used via: >=20 > # rm -fr /usr/obj/cortexA53_clang/arm64.aarch64/* > # ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap= -amd64-host.sh -j4 kernel-toolchain buildkernel >=20 > I still get: >=20 > --- buildkernel --- > Building /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/s= ys/GENERIC-NODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld > --- accf_data.kld --- > ld: unrecognised emulation mode: aarch64elf > Supported emulations: elf_x86_64_fbsd elf_i386_fbsd > *** [accf_data.kld] Error code 1 >=20 >=20 >=20 > Reminder of what my .sh script does: >=20 > # more ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_boot= strap-amd64-host.sh > kldload -n filemon && \ > script ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootst= rap-amd64-host-$(date +%Y-%m-%d:%H:%M:%S) \ > env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" S= RC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ > WITH_META_MODE=3Dyes \ > MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ > make $* >=20 > (I'll not repeat the other supporting material.) >=20 > =3D=3D=3D > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) >=20 --=20 Regards, Bryan Drewery --YwE7MHjPBi2iZDHrPika8svfGIe9a5wF2-- --7Rd8MBSaacApsny1CN7IoCbi05fTFLgZH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE+Rc8ssOq6npcih8JNddxu25Gl88FAltNLq5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY5 MTczQ0IyQzNBQUVBN0E1QzhBMUYwOTM1RDc3MUJCNkU0Njk3Q0YACgkQNddxu25G l8+eKwf/Yg98Y1BAGfFWVVj85w5ii1FSLI7wqNOfXk9ZiPvQFfNtGfLoXOIuVbqI mB2gjclNTj10iO75IiiwsUZhXxIc2BMECFDYNE08erDu9wn9J0ifMlROGIlmhF3H x3yZyBBmsIW2b2c33Q0jWEU6Jx78HlK3Ijxuwbhs1u0ZyAXIyRVoqEpjhhxlF1lk 5ieZWTGDVykig8lPQo4Qih1iFROfWDhGwKGpYwkFa5H2jh6Y/paJgIk+KAjUcOa1 JO+PDhwEH9ocZnhQVOR/ptDLh+mxoM6whfCQtTI9r3RFphM1wMXQRTe/EpBjRnRE k+Rh94VKNDdgLfGXDZrGj9Sm5QEDCA== =bZ38 -----END PGP SIGNATURE----- --7Rd8MBSaacApsny1CN7IoCbi05fTFLgZH-- From owner-freebsd-current@freebsd.org Tue Jul 17 00:26:27 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A7971044872 for ; Tue, 17 Jul 2018 00:26:27 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DDD4D8A951 for ; Tue, 17 Jul 2018 00:26:26 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: by mailman.ysv.freebsd.org (Postfix) id 9B6FC1044871; Tue, 17 Jul 2018 00:26:26 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 887A21044870 for ; Tue, 17 Jul 2018 00:26:26 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: from aibo.runbox.com (aibo.runbox.com [91.220.196.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 241DB8A950; Tue, 17 Jul 2018 00:26:25 +0000 (UTC) (envelope-from jbtakk@iherebuywisely.com) Received: from [10.9.9.127] (helo=rmmprod05.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1ffDoo-0006NW-DX; Tue, 17 Jul 2018 02:26:18 +0200 Received: from mail by rmmprod05.runbox with local (Exim 4.86_2) (envelope-from ) id 1ffDoo-0003Fp-CH; Tue, 17 Jul 2018 02:26:18 +0200 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received: from [Authenticated user (846156)] by runbox.com with http (RMM6); Tue, 17 Jul 2018 00:26:18 GMT From: "Jeffrey Bouquet" To: "Piotr P. Stefaniak" CC: "current" Subject: Re: updates to HEAD online, RSS non-browser ?? Date: Mon, 16 Jul 2018 17:26:18 -0700 (PDT) X-Mailer: RMM6 In-Reply-To: <20180716201228.GE53055@freefall.freebsd.org> Message-Id: X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 00:26:27 -0000 On Mon, 16 Jul 2018 22:12:28 +0200, "Piotr P. Stefaniak" wrote: > On 2018-07-14 04:36:05, Jeffrey Bouquet wrote: > >secnetix.de used to let me read HEAD updates to src daily. About > >several monhts ago, my browsers cannot reach it and the 2ndry site is > >tedious to read in an equivalent manner. AFAIK the site is still up. > >Recent EU laws or some other cause? Reachable by some legal VPN > >trickery? RSS feed better serving to inform? legal web scraping > >connects to site when browsers cannot? >=20 > Would this suffice? > https://github.com/freebsd/freebsd/commits/master.atom > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" Looks good. Is it new? Have to get upto speed on RSS-to-pc methods ...= From owner-freebsd-current@freebsd.org Tue Jul 17 01:13:40 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E50231046854 for ; Tue, 17 Jul 2018 01:13:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-23.consmr.mail.ne1.yahoo.com (sonic312-23.consmr.mail.ne1.yahoo.com [66.163.191.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 77B098C46F for ; Tue, 17 Jul 2018 01:13:39 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: QRtfCPgVM1mcQtvFFW_joZs1XU4cUvd.oixvSkt8pPs37xl0SoR79SQQCUyFhQd Lo8CvdYIqyQzQDIMB7oeKVhWLklVsemISc7Cv7FcLgDzyLTdl_7GxXsdpRMgTUb_qodhTrB9QAIH zx2QyjsLQnotZtPhw9z2lwfvtjfg3hOZYG_nNiZjV3RXiChTS1HhZPFKxHfeZAFOC2DI5EscoCMf e5QwBHmmBkaBiH7Lpg1cP886fuRx8.WpnfXK7bOPlJJtPZnlVppF2Kkz5YpSh_WO_Ay4fexD6upM RAjInMbDI3LrDGMsiDKJ1OPMLPwvjQZS0mu6v0jzOPfRB4tUyCSG0oSMFpXEEVQ6JbNjJMpZiJq. SVi_dlkhGKideVJfg7TcKdds3cOxk5tlN2OtwrYZ9wnf8OA9lx4T7x5bfyLwh5ay8zLkx3C0LRcz jO2PmFeGqATQDWeqGIFXsDs3dmnDxtSwROZKfUZHq.NZTq.S8yMySPYEpWpVga2XLfmTaIX8mIxu XJYJRdjazRISrt9gg8qJ_X5jtJt38gFl2cN9BXAbMEQ96flJnqiMfyKXFMyLoFYhaRBoutMT0YnT vIrKScN5ppgRKAR6ICDhP8w8NBV3IjYBex7pcjVt0ps3ioKRTbbzSeEW63xxmEjHaXtJLDiL7Icc g4W3T7ZnxCcFTaQO7acTyfoLOAKS5SwnewJczKyOSsk8yplRDQCrpCEnEcACVKokysY8SdzVt1JC BE8Zy_fVf6raB2aRKSLwx7m2gDUn0BqHcWRActUIvELNXa5pBNvKNgarcICqQ8Xe8ByHO8P4ybLR EOzUTFqG.dj957iaTPU0GZMh77MekFytAa5dOI7t5xH_5yup52yW7bnBJvPFT7KN3jfMUF8cXENZ qp7_TZC.anBrYO.hwSDIlDrRwrvoRp2rOok1CtlY_fZW0vdsnyY1E5hqcMOr3ASgwzcQfhXOZ1kl PHZ1K_1beVsjpuzEeoNZs4gj_8eE10QrmVzdEd0OR7m5zgzlaKmnn3CppDiYGTItbmfM- Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Tue, 17 Jul 2018 01:13:32 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp403.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID e5586212203d50a7fb00ffe5e01ba5ed; Tue, 17 Jul 2018 01:13:29 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd From: Mark Millard In-Reply-To: <0b5b2181-7335-325c-3e7a-f882a48fcd69@FreeBSD.org> Date: Mon, 16 Jul 2018 18:13:27 -0700 Cc: FreeBSD Toolchain , freebsd-arm , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <2A128804-82FA-4315-9FD9-F109FAF7216B@yahoo.com> References: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> <0b5b2181-7335-325c-3e7a-f882a48fcd69@FreeBSD.org> To: Bryan Drewery X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 01:13:40 -0000 On 2018-Jul-16, at 4:47 PM, Bryan Drewery = wrote: > On 7/16/2018 3:49 PM, Mark Millard wrote: >>=20 >>=20 >> On 2018-Jul-16, at 3:31 PM, Bryan Drewery = wrote: >>=20 >>> On 7/16/18 1:21 PM, Mark Millard wrote: >>>> I attempted a from-scratch (. . ./arm64.aarch64/ empty) = kernel-toolchain buildkernel >>>> targeting aarch64 from amd64 based on head -r336349 . It failed by = ending up >>>> using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : >>>=20 >>> I probably extended the LLVM_TARGET_ALL=3Dno in cross-compiler too = far. I >>> thought I had left that out for kernel-toolchain but apparently not. >>>=20 >>> Try this patch and kernel-toolchain after applying please: >>> http://people.freebsd.org/~bdrewery/patches/cross-compiler-fix.diff >>> . . . >>=20 >> Result is unchanged. Details follow. >=20 > Ok, I'll look more tomorrow. >=20 >>=20 >> With: >>=20 >> # svnlite diff /usr/src/Makefile.inc1 >> Index: /usr/src/Makefile.inc1 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- /usr/src/Makefile.inc1 (revision 336349) >> +++ /usr/src/Makefile.inc1 (working copy) >> @@ -666,7 +666,7 @@ >> BMAKE=3D \ >> ${BMAKEENV} ${MAKE} ${WORLD_FLAGS} -f Makefile.inc1 \ >> ${BSARGS} >> -.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) >> +.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) && !make(*toolchain*) >> BMAKE+=3D MK_LLVM_TARGET_ALL=3Dno >> .endif >>=20 >> used via: >>=20 >> # rm -fr /usr/obj/cortexA53_clang/arm64.aarch64/* >> # = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh -j4 kernel-toolchain buildkernel >>=20 >> I still get: >>=20 >> --- buildkernel --- >> Building = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-N= ODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld >> --- accf_data.kld --- >> ld: unrecognised emulation mode: aarch64elf >> Supported emulations: elf_x86_64_fbsd elf_i386_fbsd >> *** [accf_data.kld] Error code 1 >>=20 >>=20 >>=20 >> Reminder of what my .sh script does: >>=20 >> # more = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh >> kldload -n filemon && \ >> script = ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-amd64-= host-$(date +%Y-%m-%d:%H:%M:%S) \ >> env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" = SRC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ >> WITH_META_MODE=3Dyes \ >> MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ >> make $* >>=20 >> (I'll not repeat the other supporting material.) In case it helps: # = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh test-system-linker Script started, output file is = /root/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-am= d64-host-2018-07-16:17:48:38 USING_SYSTEM_LINKER =3D no MK_SYSTEM_LINKER =3D no MK_LLD_BOOTSTRAP =3D yes MK_BINUTILS_BOOTSTRAP =3D no WANT_LINKER_TYPE =3D lld WANT_LINKER_VERSION =3D 60001 WANT_LINKER_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc WANT_LINKER_FREEBSD_VERSION =3D 335540-1200003 WANT_LINKER_FREEBSD_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc LD =3D ld LINKER_TYPE =3D bfd LINKER_FEATURES =3D filter LINKER_VERSION =3D 21750 LINKER_FREEBSD_VERSION =3D 0 XLD =3D ld X_LINKER_TYPE =3D bfd X_LINKER_FEATURES =3D filter X_LINKER_VERSION =3D 21750 X_LINKER_FREEBSD_VERSION =3D 0 Script done, output file is = /root/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-am= d64-host-2018-07-16:17:48:38 The part after the WANT_'s looks odd to me. (I think the above type of output would be good in ci.freebsd.org build logs for the likes of FreeBSD-head-*-build . Similarly for test-system-compiler output.) I get similar oddness for a self-hosted amd64 build via my usual .sh and src/make configuration files: # ~/sys_build_scripts.amd64-host/make_amd64_nodebug_clang-amd64-host.sh = test-system-linker Script started, output file is = /root/sys_typescripts/typescript_make_amd64_nodebug_clang-amd64-host-2018-= 07-16:18:00:52 USING_SYSTEM_LINKER =3D no MK_SYSTEM_LINKER =3D yes MK_LLD_BOOTSTRAP =3D yes MK_BINUTILS_BOOTSTRAP =3D yes WANT_LINKER_TYPE =3D lld WANT_LINKER_VERSION =3D 60001 WANT_LINKER_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc WANT_LINKER_FREEBSD_VERSION =3D 335540-1200003 WANT_LINKER_FREEBSD_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc LD =3D ld LINKER_TYPE =3D bfd LINKER_FEATURES =3D filter LINKER_VERSION =3D 21750 LINKER_FREEBSD_VERSION =3D 0 XLD =3D ld X_LINKER_TYPE =3D bfd X_LINKER_FEATURES =3D filter X_LINKER_VERSION =3D 21750 X_LINKER_FREEBSD_VERSION =3D 0 Script done, output file is = /root/sys_typescripts/typescript_make_amd64_nodebug_clang-amd64-host-2018-= 07-16:18:00:52 (In both contexts test-system-compiler output seemed reasonable to me.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Tue Jul 17 01:46:16 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DC73104965E for ; Tue, 17 Jul 2018 01:46:16 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-12.consmr.mail.ne1.yahoo.com (sonic313-12.consmr.mail.ne1.yahoo.com [66.163.185.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BEDDC8DFB2 for ; Tue, 17 Jul 2018 01:46:15 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: fZ8WGlcVM1k6fUW5g4R69iqDcu18ePoHe5hDyL49a2UOf_4XcPe4kBcCrvFtNkY 5xSSHKevpbA7LzcMQxfll4Z5J7r1DpvhNU9cXdbmojgalyXjDwmDMbLPGveMv7P398ckY_.95jIl 4xby.h3B5zfZ6gbaBAJOJ9uOpWowuEYUVI0ejMhQsWy5vQC.vYrPN6M4IuingETymJ6lcHwQdqrd E62Md4kulzTn3PJ_HGEnNBEuyvOsqiWOHGpalaaD8IAEDeI8qsustO6F45pKBeSUfECgaB1dFjtb .6lRYufkqpBrXoWNQXBZZDOE50mFOm9vks1DIeJsxbUbJHkrwfax4mXtaFcNSgctqfCWerTzZxlL txG3NpsATIuBaPJXluVqdNRvk1D5CIXO.ATgVI4u05pxiZ54tz6X.IAk.mgJ1HAJVjuRpU9x0Up0 vfB_Lbx4Xjy38bbqSzzr0W_V2eHTBFcLnlPrq3Zo4VSdeOMAB9teqMVNwXx_2lvJatozQW_fj7yX kHlf3_FHgZoZBxOgWwS6RBsJPVK6wVNoHZB2766HjLyT3A3pUhTGLyQwvt.upbx34.VVFR3cDX_L GwMtQRiKmvBRUBWjOiivYbWpspIGfWIyovPBt6MJR8BUASegTDwEtf7ah4ui.1TTMTsCPFlv8_7b 5ab6b0xoTx63MooN2JYtT.QskYb7tnDVpeZcwGvuXL7yOpwBsxukQ1D9dVr8b7Y_8g9_XFzWxckv 5bZCKNdRt_DMFhzxZ1rJE21eA5ZyiFSddoqBjUzBTGzOoJke.izx6VNmFPEVRdqekQwURX_IQTmW APhzWfzq4dGsacNAI7ZHj76QnzXqfUE_6_LFQhH.0KnVH4UDI1PsfLYTXml27UYFPKQwXU4G4Q3G 8eMlnGjokSi1bJwg3.W9DfEa4BJRWU0L9P8QGs9M4uzotL8vCYNndDADWANQBhenwlUPYwCKArk0 in4EsO7zMMYjHrQg49MysVvJurHxQon8JbxgMsgTiiMzc6UpVbPkBdg.Vox6UuG90pDCwfB96dA- - Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ne1.yahoo.com with HTTP; Tue, 17 Jul 2018 01:46:09 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp420.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID dfa1c5b26052016dc45f53d50b83c24c; Tue, 17 Jul 2018 01:46:04 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: New kernel-toolchain buildkernel problem for amd64 -> aarch64 cross build ( after -r336348 ) : ld used for addf_data only can target: elf_x86_64_fbsd elf_i386_fbsd From: Mark Millard In-Reply-To: <2A128804-82FA-4315-9FD9-F109FAF7216B@yahoo.com> Date: Mon, 16 Jul 2018 18:46:02 -0700 Cc: FreeBSD Toolchain , freebsd-arm , FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <22626F9B-4337-4C06-BB24-5BAB5AD52300@yahoo.com> References: <81184558-6b23-085b-19e3-b11569808174@FreeBSD.org> <09601A6A-C275-4B90-9A76-7C64E2CA7B32@yahoo.com> <0b5b2181-7335-325c-3e7a-f882a48fcd69@FreeBSD.org> <2A128804-82FA-4315-9FD9-F109FAF7216B@yahoo.com> To: Bryan Drewery X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 01:46:16 -0000 [ toolchain-metadata.mk is missing when kernel-toolchain is used. I've no clue if this is intentional or not. ] On 2018-Jul-16, at 6:13 PM, Mark Millard wrote: > On 2018-Jul-16, at 4:47 PM, Bryan Drewery = wrote: >=20 >> On 7/16/2018 3:49 PM, Mark Millard wrote: >>>=20 >>>=20 >>> On 2018-Jul-16, at 3:31 PM, Bryan Drewery = wrote: >>>=20 >>>> On 7/16/18 1:21 PM, Mark Millard wrote: >>>>> I attempted a from-scratch (. . ./arm64.aarch64/ empty) = kernel-toolchain buildkernel >>>>> targeting aarch64 from amd64 based on head -r336349 . It failed by = ending up >>>>> using an ld that can only target elf_x86_64_fbsd elf_i386_fbsd : >>>>=20 >>>> I probably extended the LLVM_TARGET_ALL=3Dno in cross-compiler too = far. I >>>> thought I had left that out for kernel-toolchain but apparently = not. >>>>=20 >>>> Try this patch and kernel-toolchain after applying please: >>>> http://people.freebsd.org/~bdrewery/patches/cross-compiler-fix.diff >>>> . . . >>>=20 >>> Result is unchanged. Details follow. >>=20 >> Ok, I'll look more tomorrow. >>=20 >>>=20 >>> With: >>>=20 >>> # svnlite diff /usr/src/Makefile.inc1 >>> Index: /usr/src/Makefile.inc1 >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- /usr/src/Makefile.inc1 (revision 336349) >>> +++ /usr/src/Makefile.inc1 (working copy) >>> @@ -666,7 +666,7 @@ >>> BMAKE=3D \ >>> ${BMAKEENV} ${MAKE} ${WORLD_FLAGS} -f Makefile.inc1 \ >>> ${BSARGS} >>> -.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) >>> +.if empty(.MAKEOVERRIDES:MMK_LLVM_TARGET_ALL) && !make(*toolchain*) >>> BMAKE+=3D MK_LLVM_TARGET_ALL=3Dno >>> .endif >>>=20 >>> used via: >>>=20 >>> # rm -fr /usr/obj/cortexA53_clang/arm64.aarch64/* >>> # = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh -j4 kernel-toolchain buildkernel >>>=20 >>> I still get: >>>=20 >>> --- buildkernel --- >>> Building = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys/GENERIC-N= ODBG/modules/usr/src/sys/modules/accf_data/accf_data.kld >>> --- accf_data.kld --- >>> ld: unrecognised emulation mode: aarch64elf >>> Supported emulations: elf_x86_64_fbsd elf_i386_fbsd >>> *** [accf_data.kld] Error code 1 >>>=20 >>>=20 >>>=20 >>> Reminder of what my .sh script does: >>>=20 >>> # more = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh >>> kldload -n filemon && \ >>> script = ~/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-amd64-= host-$(date +%Y-%m-%d:%H:%M:%S) \ >>> env __MAKE_CONF=3D"/root/src.configs/make.conf" SRCCONF=3D"/dev/null" = SRC_ENV_CONF=3D"/root/src.configs/src.conf.cortexA53-clang-bootstrap.amd64= -host" \ >>> WITH_META_MODE=3Dyes \ >>> MAKEOBJDIRPREFIX=3D"/usr/obj/cortexA53_clang/arm64.aarch64" \ >>> make $* >>>=20 >>> (I'll not repeat the other supporting material.) >=20 > In case it helps: >=20 > # = ~/sys_build_scripts.amd64-host/make_cortexA53_nodebug_clang_bootstrap-amd6= 4-host.sh test-system-linker > Script started, output file is = /root/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-am= d64-host-2018-07-16:17:48:38 > USING_SYSTEM_LINKER =3D no > MK_SYSTEM_LINKER =3D no > MK_LLD_BOOTSTRAP =3D yes > MK_BINUTILS_BOOTSTRAP =3D no > WANT_LINKER_TYPE =3D lld > WANT_LINKER_VERSION =3D 60001 > WANT_LINKER_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc > WANT_LINKER_FREEBSD_VERSION =3D 335540-1200003 > WANT_LINKER_FREEBSD_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc > LD =3D ld > LINKER_TYPE =3D bfd > LINKER_FEATURES =3D filter > LINKER_VERSION =3D 21750 > LINKER_FREEBSD_VERSION =3D 0 > XLD =3D ld > X_LINKER_TYPE =3D bfd > X_LINKER_FEATURES =3D filter > X_LINKER_VERSION =3D 21750 > X_LINKER_FREEBSD_VERSION =3D 0 >=20 > Script done, output file is = /root/sys_typescripts/typescript_make_cortexA53_nodebug_clang_bootstrap-am= d64-host-2018-07-16:17:48:38 >=20 > The part after the WANT_'s looks odd to me. >=20 > (I think the above type of output would be good in ci.freebsd.org > build logs for the likes of FreeBSD-head-*-build . Similarly for > test-system-compiler output.) >=20 > I get similar oddness for a self-hosted amd64 build via my > usual .sh and src/make configuration files: >=20 > # = ~/sys_build_scripts.amd64-host/make_amd64_nodebug_clang-amd64-host.sh = test-system-linker > Script started, output file is = /root/sys_typescripts/typescript_make_amd64_nodebug_clang-amd64-host-2018-= 07-16:18:00:52 > USING_SYSTEM_LINKER =3D no > MK_SYSTEM_LINKER =3D yes > MK_LLD_BOOTSTRAP =3D yes > MK_BINUTILS_BOOTSTRAP =3D yes > WANT_LINKER_TYPE =3D lld > WANT_LINKER_VERSION =3D 60001 > WANT_LINKER_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc > WANT_LINKER_FREEBSD_VERSION =3D 335540-1200003 > WANT_LINKER_FREEBSD_VERSION_FILE =3D = lib/clang/include/lld/Common/Version.inc > LD =3D ld > LINKER_TYPE =3D bfd > LINKER_FEATURES =3D filter > LINKER_VERSION =3D 21750 > LINKER_FREEBSD_VERSION =3D 0 > XLD =3D ld > X_LINKER_TYPE =3D bfd > X_LINKER_FEATURES =3D filter > X_LINKER_VERSION =3D 21750 > X_LINKER_FREEBSD_VERSION =3D 0 >=20 > Script done, output file is = /root/sys_typescripts/typescript_make_amd64_nodebug_clang-amd64-host-2018-= 07-16:18:00:52 >=20 >=20 > (In both contexts test-system-compiler output seemed reasonable to > me.) In looking around I find that the kernel-toolchain tree does not have a toolchain-metadata.mk : # ls -lTdt = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/* drwxr-xr-x 7 root wheel 512 Jul 16 15:41:41 2018 = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/tmp drwxr-xr-x 3 root wheel 512 Jul 16 15:41:41 2018 = /usr/obj/cortexA53_clang/arm64.aarch64/usr/src/arm64.aarch64/sys (Of course the build failed and so did not execute everything.) The buildworld based ones do have such files. For example, the amd64 self-hosted build that used buildworld has: # more = /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/toolchain-metadata.mk= .info Using cached toolchain metadata from build at FBSDUSSD on Mon Jul = 16 11:49:07 PDT 2018 _LOADED_TOOLCHAIN_METADATA=3Dt COMPILER_VERSION=3D60001 X_COMPILER_VERSION=3D60001 COMPILER_TYPE=3Dclang X_COMPILER_TYPE=3Dclang COMPILER_FEATURES=3D c++11 retpoline X_COMPILER_FEATURES=3D c++11 retpoline COMPILER_FREEBSD_VERSION=3D1200015 X_COMPILER_FREEBSD_VERSION=3D1200015 LINKER_VERSION=3D60001 X_LINKER_VERSION=3D60001 LINKER_FEATURES=3D build-id ifunc filter retpoline X_LINKER_FEATURES=3D build-id ifunc filter retpoline LINKER_TYPE=3Dlld X_LINKER_TYPE=3Dlld LINKER_FREEBSD_VERSION=3D335540-1200003 X_LINKER_FREEBSD_VERSION=3D335540-1200003 .export COMPILER_VERSION COMPILER_TYPE COMPILER_FEATURES = COMPILER_FREEBSD_VERSION LINKER_VERSION LINKER_FEATURES LINKER_TYPE = LINKER_FREEBSD_VERSION .export X_COMPILER_VERSION X_COMPILER_TYPE X_COMPILER_FEATURES = X_COMPILER_FREEBSD_VERSION X_LINKER_VERSION X_LINKER_FEATURES = X_LINKER_TYPE X_LINKER_FREEBSD_VERSION (This is despite what test-system-linker showed for that tree.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Tue Jul 17 03:20:18 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B650B104D2D4 for ; Tue, 17 Jul 2018 03:20:18 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 37F2571898 for ; Tue, 17 Jul 2018 03:20:18 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6H3KBTH062114 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 16 Jul 2018 20:20:11 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6H3KBf0062113 for freebsd-current@freebsd.org; Mon, 16 Jul 2018 20:20:11 -0700 (PDT) (envelope-from sgk) Date: Mon, 16 Jul 2018 20:20:11 -0700 From: Steve Kargl To: freebsd-current@freebsd.org Subject: Re: [PATCH] Recent libm additions Message-ID: <20180717032011.GA62070@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180715150638.GA30154@troutmask.apl.washington.edu> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 03:20:19 -0000 Version 2. After applying the patch, one can % svn delete libm/msun/src/polevll.c % svn commit libm/msun/src/polevll.c * lib/msun/Makefile: . Remove polevll.c * lib/msun/ld80/e_powl.c: . Copy contents of polevll.c to here. This is the only consumer of these functions. Make functions 'static inline'. . Make reducl a 'static inline' function. * lib/msun/man/exp.3: . Remove BUGS section that no longer applies. * lib/msun/src/math_private.h: . Remove prototypes of __p1evll() and __polevll() * lib/msun/src/s_cpow.c: * lib/msun/src/s_cpowf.c: * lib/msun/src/s_cpowl.c . Use the CMPLX macro from either C99 or math_private.h (depends of compiler support) instead of the problematic use of complex I. Index: lib/msun/Makefile =================================================================== --- lib/msun/Makefile (revision 336360) +++ lib/msun/Makefile (working copy) @@ -17,6 +17,8 @@ .include "${ARCH_SUBDIR}/Makefile.inc" +CFLAGS+=-msse + .PATH: ${.CURDIR}/${ARCH_SUBDIR} .if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" .PATH: ${.CURDIR}/x86 @@ -56,7 +58,6 @@ imprecise.c \ k_cos.c k_cosf.c k_exp.c k_expf.c k_rem_pio2.c k_sin.c k_sinf.c \ k_tan.c k_tanf.c \ - polevll.c \ s_asinh.c s_asinhf.c s_atan.c s_atanf.c s_carg.c s_cargf.c s_cargl.c \ s_cbrt.c s_cbrtf.c s_ceil.c s_ceilf.c s_clog.c s_clogf.c \ s_copysign.c s_copysignf.c s_cos.c s_cosf.c \ Index: lib/msun/ld80/e_powl.c =================================================================== --- lib/msun/ld80/e_powl.c (revision 336360) +++ lib/msun/ld80/e_powl.c (working copy) @@ -14,6 +14,52 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ +#include +__FBSDID("$FreeBSD$"); + +#include + +#include "math_private.h" + +/* + * Polynomial evaluator: + * P[0] x^n + P[1] x^(n-1) + ... + P[n] + */ +static inline long double +__polevll(long double x, long double *PP, int n) +{ + long double y; + long double *P; + + P = PP; + y = *P++; + do { + y = y * x + *P++; + } while (--n); + + return (y); +} + +/* + * Polynomial evaluator: + * x^n + P[0] x^(n-1) + P[1] x^(n-2) + ... + P[n] + */ +static inline long double +__p1evll(long double x, long double *PP, int n) +{ + long double y; + long double *P; + + P = PP; + n -= 1; + y = x + *P++; + do { + y = y * x + *P++; + } while (--n); + + return (y); +} + /* powl.c * * Power function, long double precision @@ -467,7 +513,7 @@ /* Find a multiple of 1/NXT that is within 1/NXT of x. */ -static long double +static inline long double reducl(long double x) { long double t; Index: lib/msun/man/exp.3 =================================================================== --- lib/msun/man/exp.3 (revision 336360) +++ lib/msun/man/exp.3 (working copy) @@ -180,16 +180,9 @@ then \*(Na**0 = 1 too because x**0 = 1 for all finite and infinite x, i.e., independently of x. .El -.Sh BUGS -To conform with newer C/C++ standards, a stub implementation for -.Nm powl -was committed to the math library, where -.Nm powl -is mapped to -.Nm pow . -Thus, the numerical accuracy is at most that of the 53-bit double -precision implementation. .Sh SEE ALSO +.Xr clog 3 +.Xr cpow 3 .Xr fenv 3 , .Xr ldexp 3 , .Xr log 3 , Index: lib/msun/src/math_private.h =================================================================== --- lib/msun/src/math_private.h (revision 336360) +++ lib/msun/src/math_private.h (working copy) @@ -828,7 +828,4 @@ long double __kernel_cosl(long double, long double); long double __kernel_tanl(long double, long double, int); -long double __p1evll(long double, void *, int); -long double __polevll(long double, void *, int); - #endif /* !_MATH_PRIVATE_H_ */ Index: lib/msun/src/s_cpow.c =================================================================== --- lib/msun/src/s_cpow.c (revision 336360) +++ lib/msun/src/s_cpow.c (working copy) @@ -60,7 +60,7 @@ y = cimag (z); absa = cabs (a); if (absa == 0.0) { - return (0.0 + 0.0 * I); + return (CMPLX(0.0, 0.0)); } arga = carg (a); r = pow (absa, x); @@ -69,6 +69,6 @@ r = r * exp (-y * arga); theta = theta + y * log (absa); } - w = r * cos (theta) + (r * sin (theta)) * I; + w = CMPLX(r * cos (theta), r * sin (theta)); return (w); } Index: lib/msun/src/s_cpowf.c =================================================================== --- lib/msun/src/s_cpowf.c (revision 336360) +++ lib/msun/src/s_cpowf.c (working copy) @@ -59,7 +59,7 @@ y = cimagf(z); absa = cabsf (a); if (absa == 0.0f) { - return (0.0f + 0.0f * I); + return (CMPLXF(0.0f, 0.0f)); } arga = cargf (a); r = powf (absa, x); @@ -68,6 +68,6 @@ r = r * expf (-y * arga); theta = theta + y * logf (absa); } - w = r * cosf (theta) + (r * sinf (theta)) * I; + w = CMPLXF(r * cosf (theta), r * sinf (theta)); return (w); } Index: lib/msun/src/s_cpowl.c =================================================================== --- lib/msun/src/s_cpowl.c (revision 336360) +++ lib/msun/src/s_cpowl.c (working copy) @@ -59,7 +59,7 @@ y = cimagl(z); absa = cabsl(a); if (absa == 0.0L) { - return (0.0L + 0.0L * I); + return (CMPLXL(0.0L, 0.0L)); } arga = cargl(a); r = powl(absa, x); @@ -68,6 +68,6 @@ r = r * expl(-y * arga); theta = theta + y * logl(absa); } - w = r * cosl(theta) + (r * sinl(theta)) * I; + w = CMPLXL(r * cosl(theta), r * sinl(theta)); return (w); } -- Steve From owner-freebsd-current@freebsd.org Tue Jul 17 06:27:29 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 138F3102BD74 for ; Tue, 17 Jul 2018 06:27:29 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic308-12.consmr.mail.ne1.yahoo.com (sonic308-12.consmr.mail.ne1.yahoo.com [66.163.187.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 96F1676751 for ; Tue, 17 Jul 2018 06:27:28 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 7NvtL4AVM1k.jXyQ10Eag6ofixLspV9qHoRFjIMi_ZDjqyfeaLSc2gjw.K6K20P ZPGkrd3EnTJpRnLQQjvv2Isp7cGumig8m4Lt0LPPRpLMGQHkMJSLAvLduXKokQ_2GREl8gp7ahuG R3RNc34Bfdo.qLEqt3F_Ts3I043o1g8ivmY.iHS8rBuwr7LxpDcRw0QwvLkWsodzKVLeN.DkQFSZ ZxaqzDturucD4z0vGVHEYM96nQPiX1pttqIfe5OCMPQVvnCdZaPB.dDqjzRvZ3TdQIswFFc4zGHm TASil.vJ.4nvQ51_dLvpX9HPBtnxdd83k2k4jgcstUMySR3mG63lEfKcb.9XRjHnCfhUgjW.ZEO_ 65ImkHy.HJUzo76R7Lj.WzRY_ljS6xk0XUsdUSIinTbOyJ53Ml8892m5su0OtHU3Kz1BzEDCsDZk x5FaB.fV57UDyZBZRQ0C1lLFDsU6Uljbx4ROc4q7LL6ZCyErF22kJV6yHmtjklQZjhENEoy2U5jP f6sTLmqTdZe8xBcVn0g33FWRYW7nbuaOxfXF3oYeA29gL6NPDEK.w3gGnapFNeHIMZ3mbydhGNNw 56rm0AvFO74N7Ihk.V1_B1o9qm4eoLDc0vA_TDU43.dllGftsMQLoHsLi35zHjIFDWKMXGmWFuQ9 VwKrNOz6d1ZNfTMM7c4u5ps1v9vjZgHRmA5enNS9ZSlW3jmkOSbraC2df4.BRkmRbddreeF.MEvr h8DuEWkQXm5FDFzGk86g6gcRw7O6wZVNYyopBtAqoOEH7w_1AFTnHvrEdlLtX1UHkvCb6.UrgcXz WtNSTNvRHvk7uUaLcgytNWJuytvk5k0mEU33UWdPSouFOJIXlfbiF62UwbAmePzHD9Ms73hir.Yw kiPjTzJeFhMS9T0tW27b9tUpQtedsw9qrNDgLrBY00CwLN6PIq5VZa9dhQU8I.NUGf_SZ7pyQErQ xhrx6JaEC_PNRwvQilRkjJZ_LoAjV2KcWuoEeTWrf3hbDIEIWQ7JP_L4fIDDbrcU- Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ne1.yahoo.com with HTTP; Tue, 17 Jul 2018 06:27:22 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp409.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 183b733193674b237cac0aae09e96821; Tue, 17 Jul 2018 06:27:21 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build) From: Mark Millard In-Reply-To: Date: Mon, 16 Jul 2018 23:27:19 -0700 Cc: Dimitry Andric , Bryan Drewery , svn-src-head@freebsd.org, FreeBSD Current Content-Transfer-Encoding: 7bit Message-Id: <9251BE92-A8CE-45E3-B4BF-706E7219321A@yahoo.com> References: <00D1127A-1F0E-4E0E-B86C-1C5AA5B2E085@yahoo.com> <7A845F2C-C994-4828-823D-33A97B7B6EB0@yahoo.com> <72081b02-cf23-82ec-32df-7f5793c35f57@FreeBSD.org> <003509F0-F2F4-4A43-82FE-3F6FC23D19D4@yahoo.com> <65b19cc4-eaf0-13ed-43e6-9f04a1f7f196@FreeBSD.org> <49BF6569-96A9-4104-BDE6-8BB94C0D9626@yahoo.com> To: John Baldwin X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 06:27:29 -0000 On 2018-Jul-1, at 6:34 AM, Mark Millard wrote: > My brain finally engaged for showing exactly what files are included > for the gcc builds: the .meta files include that information explicitly > (along with other files that are opened during the operation). > > amd64 is as I reported, just one header file from gcc: float.h . > > powerpc64 builds Lex/Lexer.cpp without defining __ALTIVEC__ and so > is not including . Building without __ALTIVEC__ might > be an error itself but would be a workaround for the altivec.h > file name aliasing vs. search-path problem. > > . . . Going in a different direction, what of the unchanged Makefile.inc1 code block: .if ${WANT_COMPILER_TYPE} == gcc || \ (defined(X_COMPILER_TYPE) && ${X_COMPILER_TYPE} == gcc) # GCC requires -isystem and -L when using a cross-compiler. --sysroot # won't set header path and -L is used to ensure the base library path # is added before the port PREFIX library path. CD2CFLAGS+= -isystem ${XDDESTDIR}/usr/include -L${XDDESTDIR}/usr/lib # GCC requires -B to find /usr/lib/crti.o when using a cross-compiler # combined with --sysroot. CD2CFLAGS+= -B${XDDESTDIR}/usr/lib # Force using libc++ for external GCC. .if defined(X_COMPILER_TYPE) && \ ${X_COMPILER_TYPE} == gcc && ${X_COMPILER_VERSION} >= 40800 CD2CXXFLAGS+= -isystem ${XDDESTDIR}/usr/include/c++/v1 -std=c++11 \ -nostdinc++ .endif .endif Why is that pair of -isystem uses that gives the old search order okay? Or was the block just missed? (Similarly for other options listed above.) Note: Locally I've reverted the -r335782 changes in order for my use of devel/*-gcc as cross compilers to work where they used to (hopefully: still building), restoring the historical search order for the directories for now. === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Tue Jul 17 11:41:38 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE431103B9B3 for ; Tue, 17 Jul 2018 11:41:38 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-oi0-x229.google.com (mail-oi0-x229.google.com [IPv6:2607:f8b0:4003:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F30B84C9F for ; Tue, 17 Jul 2018 11:41:38 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-oi0-x229.google.com with SMTP id i12-v6so1403117oik.2 for ; Tue, 17 Jul 2018 04:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=SBoshFNWhWD28dCaFhPUbEoUwahAuPb/zUeZ0BPrnDs=; b=Ck/Ca3DFyqyX1z8akTSzVCUC3qfMTinK+Aykk2rJrJVtANboD7JXof8q97aroEPBmD 35DEYmlEv/EMqtS1VzCa+99fgj4iIqIqwvesEbiZlHzS9sSwXAiC943tf+IBusQuHa7k tEn5PT77FBMWs1aSj9AJSx08woO1zGLroI4k0diDHQqS5BWxmGDl3dxFkw92MYfII1OE uxqJyjRScuHQ15NFqUaxnmVWd7k/sPuC77F39w1McyCuy9mIe5aiZM/WoahlnCf++0cF 7nZ9zFQC5/6gJIcW/EZzr2sdK3Yy0UwRwV5rVXjZHNuGkdQ+W02jNqGZdPX8CJt5k5X5 IzSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=SBoshFNWhWD28dCaFhPUbEoUwahAuPb/zUeZ0BPrnDs=; b=CbeWi2Jgjyx/jV3cwgpFY+dClJOpBDa5HWomvSw1D5/zaI519HYz6kwy6MHwm/NrAY yMECG+w+9iC6VYDeQ7aQUGbyWZJIpmunpu6BQMgNg8z/F0ztWRx9qgohdB1WOjhGCQ8y XpBzQL6rL5IuIS4IqQaUmmpFY1OXEZ9tnGz2JBeRk5RWrb4bhe/T6WlrGXoxiUWJ4HT7 N/VlCH2IyXI3M+ENxoFGMHFlWA5euULRI9q7a5wVYB+uTrKxQO0z/WmTQZI/oPqfNXtt uhX/+7juQnc/J0hOo1zTK/KRnrAgDt4EEpPaMlTwn3bmCUT/zVB/Zo9sWoIBNIxTy2j6 ozIw== X-Gm-Message-State: AOUpUlEEZRxzlNXfQ6qKsWfOCQ/HZ8oaJAkyNzg+widCgoHUqzUZII8p L7+7izKJDpbZsiOHXODi4aJMs1FIa/eWOQ4TTwOW5qMV X-Google-Smtp-Source: AAOMgpcjx4rUoyxzuacTayoySNN8PvjYRrkSt/wplmqRG0C3QGwUdX6DRSkSMi1IHBDExytMrJTtTjOf6enfoLE2wbo= X-Received: by 2002:aca:4c7:: with SMTP id 190-v6mr1284933oie.107.1531827697488; Tue, 17 Jul 2018 04:41:37 -0700 (PDT) MIME-Version: 1.0 From: Ali Abdallah Date: Tue, 17 Jul 2018 13:41:27 +0200 Message-ID: Subject: top -n -o res shows empty output To: freebsd-current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 11:41:39 -0000 Hello, >From around the revision r334918, the command 'top -n -o res' shows empty output. With best regards, Ali From owner-freebsd-current@freebsd.org Wed Jul 18 09:34:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5915010411A7 for ; Wed, 18 Jul 2018 09:34:52 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA6ED719FD for ; Wed, 18 Jul 2018 09:34:51 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-oi0-x232.google.com with SMTP id k81-v6so7547144oib.4 for ; Wed, 18 Jul 2018 02:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=buj0gFGodEvRw2fczCYz//d8+Q//txWg3iyKc7955zI=; b=piX3wOwJZHR9omfCynUKzAqU0ICi2Bgz/PSoDMotZ7aVt0mfigd72Z4pWKxkryZMF3 t9bflkJdIv7zNIPOHsZ8dAW+C9dCeiECAW9fP8bEzEeOvDONocwCLe3WNszGt/iruk8d kpMH+ov6bBbkeLdilOyuQx5zPXlZhw9akjAGwfp+YopkcrrM2jjCVGPPD+TbzFy3iHBt A9i9Xb4oOcITu4ROjyGkJp65aPnHQWsvJIaeafBEPUhW6WyO25UxAjNIUNFtM/0a/IbP CvMPW5GvCFbF6xym8nINnmK8N3M/NLfl87vGBxitVqMdl1TDgJawTXNqZP8Z0+pIWNNj OYrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=buj0gFGodEvRw2fczCYz//d8+Q//txWg3iyKc7955zI=; b=Le23yGN0wl51Gx0/vhBWTYUWI/QX7K96elehR5jc0ENiTacN3KAdq6kxt3sj/qUX7C uO0VZPL7Wr7jQmbLTDYWbta6PQv70eVWNYCo2PaKaD13y6N3AtUhKrG6Seodqd6jSgbQ pXCStZoniC6f6zRBgDr2wyd4RVizkljr+5ogU+LXANFI+ehYI2FiAq4WrMNZUFIIDiSp ed846VbhkT69RPS2l3LKHjGE1ipyp0IAkrFpLdqFvv4f8wwr4CccTqG471hkUyiHUQRB ZXzhchOLeOToWu/i39mz8Hwuf5nUfphoI90onAIkXcW8DSh/GfO5D3DCqoBfv++/p70c qZwQ== X-Gm-Message-State: AOUpUlFgz0ymkiCBjel+Tjd9lusotLVd7uZnRSBBQ22G4PouKESIzerA FIUO5CxI4LYt9oQTKoNvQ+KCFw62cXT3Q6tFmdRSPSf5 X-Google-Smtp-Source: AAOMgpe0xF6RxVWzzWlLjoCSSbX9rnorzXJuW1ihQ5JzXRt/T3kSS2ohCsil3SdpjkuT4F5po3Iq2n4v4apv/VunA0o= X-Received: by 2002:aca:adc6:: with SMTP id w189-v6mr5807841oie.174.1531906491157; Wed, 18 Jul 2018 02:34:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ali Abdallah Date: Wed, 18 Jul 2018 11:34:39 +0200 Message-ID: Subject: Re: top -n -o res shows empty output To: freebsd-current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 09:34:52 -0000 I have submitted a bug report with a patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229842 Best, Ali On Tue, Jul 17, 2018 at 1:41 PM Ali Abdallah wrote: > Hello, > > From around the revision r334918, the command 'top -n -o res' shows empty > output. > > With best regards, > Ali > From owner-freebsd-current@freebsd.org Wed Jul 18 14:22:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C993104BF3D for ; Wed, 18 Jul 2018 14:22:52 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from natial.ongs.co.jp (natial.ongs.co.jp [202.216.246.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CF2937C4E5 for ; Wed, 18 Jul 2018 14:22:51 +0000 (UTC) (envelope-from daichi@ongs.co.jp) Received: from [192.168.1.39] (dullmdaler.ongs.co.jp [202.216.246.94]) by natial.ongs.co.jp (Postfix) with ESMTPSA id 6F92E27438; Wed, 18 Jul 2018 23:22:30 +0900 (JST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: top -n -o res shows empty output From: Daichi GOTO In-Reply-To: Date: Wed, 18 Jul 2018 23:22:29 +0900 Cc: freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Ali Abdallah X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 14:22:52 -0000 Thank you. I=E2=80=99ll take it. > 2018/07/18 18:34=E3=80=81Ali Abdallah =E3=81=AE=E3=83=A1= =E3=83=BC=E3=83=AB: >=20 > I have submitted a bug report with a patch >=20 > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229842 >=20 > Best, > Ali >=20 > On Tue, Jul 17, 2018 at 1:41 PM Ali Abdallah wrote: >=20 >> Hello, >>=20 >> =46rom around the revision r334918, the command 'top -n -o res' shows = empty >> output. >>=20 >> With best regards, >> Ali >>=20 > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org" -- Daichi GOTO CEO | ONGS Inc. 81-42-316-7945 | daichi@ongs.co.jp | http://www.ongs.co.jp LinkedIn: http://linkedin.com/in/daichigoto From owner-freebsd-current@freebsd.org Wed Jul 18 17:50:42 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B317D102B428 for ; Wed, 18 Jul 2018 17:50:42 +0000 (UTC) (envelope-from mike.bergfors@newcontext.com) Received: from mail-qt0-x22d.google.com (mail-qt0-x22d.google.com [IPv6:2607:f8b0:400d:c0d::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5912E84DDF for ; Wed, 18 Jul 2018 17:50:42 +0000 (UTC) (envelope-from mike.bergfors@newcontext.com) Received: by mail-qt0-x22d.google.com with SMTP id q12-v6so4795847qtp.6 for ; Wed, 18 Jul 2018 10:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=newcontext.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=LxZXfY2YyaVw4nMG/LxXcYgeJ7UQgFuO0WFQI88PSBA=; b=ELVb0StpPaWpI78mw2ca4vfM/OLVx7rDySKncp9t6fooq9tn5o744+1WBF/EP5WUmO R1uLIqCrGJwFtikoMEvmQp8FIs6sxyT9UczOQgWFcUgxvCsZQ5JM/CGGPJkp5iOFde7i iRo7JWfuT4CaPNZpjAhOa7D3MB37FLDHQFWbjojrVrxBOW5XmepsRDoa4ijn/RTQRpud BSENizyqdnekNw441ALbSs6hoOai3g+f4bZOPw/BLg457x+bq+PT2fcgMYSPHrRHMCz4 8/9F3IfV0hpguIhMFhMQnBnC/xc8WzHC/XyGHRcDjLvExB2AXNEOJJ4GWeXBPuqtO69X 88hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=LxZXfY2YyaVw4nMG/LxXcYgeJ7UQgFuO0WFQI88PSBA=; b=gT7xXR1J1qQv89NdyTy47oBj9OlY2cOrCFFpr3Uc1F/L0T70OFVkAv7ituVJAqV/4Q rNPvoLXzYn8gXPDc+Vw3FzYZ4N7Xl96pI+0UXxPI/j+Ygh8LyS6S1P0K2HV1Px3Vb4W9 KzgrlUdOUBKIkU9J3QiULRiqdSk5zHJQvBKB4Z6/a08oRKevnQjRVMQnV1BHHV1G5WjJ Zj65PLaXHtm2PfitNUk2aarav0J+3KF2/BbuVCq/mspkdcwXXokhfoq/Eh9wEMybIAUv jOmtTyAz3K5sCJ6eppvQuKlPXWgEJfCBIzq7C+C7EVJ3Zgjzi6/kVTbj8Hlk0QF1k7c6 McKw== X-Gm-Message-State: AOUpUlEjLkZany5hk2D5KUZ/NsJwwi+IUbVFhNVTJii0PPYjWMpwiUbc ex76nTO3qSx7Sn5IxfnjbwoCvAcmqCFcvvqr3D2WEM08 X-Google-Smtp-Source: AAOMgpfRW4LNzkZWQe/vgBfFyxnmqz8iyX0sH95A22vr+KEDxMSwKSELt+Mnuuduww66Z0CUR2CHIGK4l3hRAwuOtTs= X-Received: by 2002:a0c:b525:: with SMTP id d37-v6mr7595097qve.34.1531936241654; Wed, 18 Jul 2018 10:50:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mike Bergfors Date: Wed, 18 Jul 2018 10:50:30 -0700 Message-ID: Subject: Re: freebsd-current Digest, Vol 768, Issue 3 To: freebsd-current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 17:50:42 -0000 unsubscribe On Wed, Jul 18, 2018 at 5:01 AM wrote: > Send freebsd-current mailing list submissions to > freebsd-current@freebsd.org > > To subscribe or unsubscribe via the World Wide Web, visit > https://lists.freebsd.org/mailman/listinfo/freebsd-current > or, via email, send a message with subject or body 'help' to > freebsd-current-request@freebsd.org > > You can reach the person managing the list at > freebsd-current-owner@freebsd.org > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of freebsd-current digest..." > > > Today's Topics: > > 1. Re: top -n -o res shows empty output (Ali Abdallah) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Wed, 18 Jul 2018 11:34:39 +0200 > From: Ali Abdallah > To: freebsd-current@freebsd.org > Subject: Re: top -n -o res shows empty output > Message-ID: > < > CAO3OKx934eKT9P8O5ja1BoCB-pWbgPMGm-K-r4tw1nfQSxU7WA@mail.gmail.com> > Content-Type: text/plain; charset="UTF-8" > > I have submitted a bug report with a patch > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229842 > > Best, > Ali > > On Tue, Jul 17, 2018 at 1:41 PM Ali Abdallah wrote: > > > Hello, > > > > From around the revision r334918, the command 'top -n -o res' shows empty > > output. > > > > With best regards, > > Ali > > > > > ------------------------------ > > Subject: Digest Footer > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > ------------------------------ > > End of freebsd-current Digest, Vol 768, Issue 3 > *********************************************** > -- [image: New Context] Mike Bergfors Director of Operations From owner-freebsd-current@freebsd.org Thu Jul 19 00:44:58 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC0D0103EACB for ; Thu, 19 Jul 2018 00:44:58 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 39EC07521B for ; Thu, 19 Jul 2018 00:44:58 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id w6J0ipaf017408 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 18 Jul 2018 17:44:51 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id w6J0ipK8017407 for freebsd-current@freebsd.org; Wed, 18 Jul 2018 17:44:51 -0700 (PDT) (envelope-from sgk) Date: Wed, 18 Jul 2018 17:44:50 -0700 From: Steve Kargl To: freebsd-current@freebsd.org Subject: Re: [PATCH] Recent libm additions Message-ID: <20180719004450.GA17384@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20180715150638.GA30154@troutmask.apl.washington.edu> <20180717032011.GA62070@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180717032011.GA62070@troutmask.apl.washington.edu> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 00:44:59 -0000 This is now PR 229876. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229876 -- steve On Mon, Jul 16, 2018 at 08:20:11PM -0700, Steve Kargl wrote: > Version 2. After applying the patch, one can > > % svn delete libm/msun/src/polevll.c > % svn commit libm/msun/src/polevll.c > > * lib/msun/Makefile: > . Remove polevll.c > > * lib/msun/ld80/e_powl.c: > . Copy contents of polevll.c to here. This is the only consumer of > these functions. Make functions 'static inline'. > . Make reducl a 'static inline' function. > > * lib/msun/man/exp.3: > . Remove BUGS section that no longer applies. > > * lib/msun/src/math_private.h: > . Remove prototypes of __p1evll() and __polevll() > > * lib/msun/src/s_cpow.c: > * lib/msun/src/s_cpowf.c: > * lib/msun/src/s_cpowl.c > . Use the CMPLX macro from either C99 or math_private.h (depends of > compiler support) instead of the problematic use of complex I. > > Index: lib/msun/Makefile > =================================================================== > --- lib/msun/Makefile (revision 336360) > +++ lib/msun/Makefile (working copy) > @@ -17,6 +17,8 @@ > > .include "${ARCH_SUBDIR}/Makefile.inc" > > +CFLAGS+=-msse > + > .PATH: ${.CURDIR}/${ARCH_SUBDIR} > .if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" > .PATH: ${.CURDIR}/x86 > @@ -56,7 +58,6 @@ > imprecise.c \ > k_cos.c k_cosf.c k_exp.c k_expf.c k_rem_pio2.c k_sin.c k_sinf.c \ > k_tan.c k_tanf.c \ > - polevll.c \ > s_asinh.c s_asinhf.c s_atan.c s_atanf.c s_carg.c s_cargf.c s_cargl.c \ > s_cbrt.c s_cbrtf.c s_ceil.c s_ceilf.c s_clog.c s_clogf.c \ > s_copysign.c s_copysignf.c s_cos.c s_cosf.c \ > Index: lib/msun/ld80/e_powl.c > =================================================================== > --- lib/msun/ld80/e_powl.c (revision 336360) > +++ lib/msun/ld80/e_powl.c (working copy) > @@ -14,6 +14,52 @@ > * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > */ > > +#include > +__FBSDID("$FreeBSD$"); > + > +#include > + > +#include "math_private.h" > + > +/* > + * Polynomial evaluator: > + * P[0] x^n + P[1] x^(n-1) + ... + P[n] > + */ > +static inline long double > +__polevll(long double x, long double *PP, int n) > +{ > + long double y; > + long double *P; > + > + P = PP; > + y = *P++; > + do { > + y = y * x + *P++; > + } while (--n); > + > + return (y); > +} > + > +/* > + * Polynomial evaluator: > + * x^n + P[0] x^(n-1) + P[1] x^(n-2) + ... + P[n] > + */ > +static inline long double > +__p1evll(long double x, long double *PP, int n) > +{ > + long double y; > + long double *P; > + > + P = PP; > + n -= 1; > + y = x + *P++; > + do { > + y = y * x + *P++; > + } while (--n); > + > + return (y); > +} > + > /* powl.c > * > * Power function, long double precision > @@ -467,7 +513,7 @@ > > > /* Find a multiple of 1/NXT that is within 1/NXT of x. */ > -static long double > +static inline long double > reducl(long double x) > { > long double t; > Index: lib/msun/man/exp.3 > =================================================================== > --- lib/msun/man/exp.3 (revision 336360) > +++ lib/msun/man/exp.3 (working copy) > @@ -180,16 +180,9 @@ > then \*(Na**0 = 1 too because x**0 = 1 for all finite > and infinite x, i.e., independently of x. > .El > -.Sh BUGS > -To conform with newer C/C++ standards, a stub implementation for > -.Nm powl > -was committed to the math library, where > -.Nm powl > -is mapped to > -.Nm pow . > -Thus, the numerical accuracy is at most that of the 53-bit double > -precision implementation. > .Sh SEE ALSO > +.Xr clog 3 > +.Xr cpow 3 > .Xr fenv 3 , > .Xr ldexp 3 , > .Xr log 3 , > Index: lib/msun/src/math_private.h > =================================================================== > --- lib/msun/src/math_private.h (revision 336360) > +++ lib/msun/src/math_private.h (working copy) > @@ -828,7 +828,4 @@ > long double __kernel_cosl(long double, long double); > long double __kernel_tanl(long double, long double, int); > > -long double __p1evll(long double, void *, int); > -long double __polevll(long double, void *, int); > - > #endif /* !_MATH_PRIVATE_H_ */ > Index: lib/msun/src/s_cpow.c > =================================================================== > --- lib/msun/src/s_cpow.c (revision 336360) > +++ lib/msun/src/s_cpow.c (working copy) > @@ -60,7 +60,7 @@ > y = cimag (z); > absa = cabs (a); > if (absa == 0.0) { > - return (0.0 + 0.0 * I); > + return (CMPLX(0.0, 0.0)); > } > arga = carg (a); > r = pow (absa, x); > @@ -69,6 +69,6 @@ > r = r * exp (-y * arga); > theta = theta + y * log (absa); > } > - w = r * cos (theta) + (r * sin (theta)) * I; > + w = CMPLX(r * cos (theta), r * sin (theta)); > return (w); > } > Index: lib/msun/src/s_cpowf.c > =================================================================== > --- lib/msun/src/s_cpowf.c (revision 336360) > +++ lib/msun/src/s_cpowf.c (working copy) > @@ -59,7 +59,7 @@ > y = cimagf(z); > absa = cabsf (a); > if (absa == 0.0f) { > - return (0.0f + 0.0f * I); > + return (CMPLXF(0.0f, 0.0f)); > } > arga = cargf (a); > r = powf (absa, x); > @@ -68,6 +68,6 @@ > r = r * expf (-y * arga); > theta = theta + y * logf (absa); > } > - w = r * cosf (theta) + (r * sinf (theta)) * I; > + w = CMPLXF(r * cosf (theta), r * sinf (theta)); > return (w); > } > Index: lib/msun/src/s_cpowl.c > =================================================================== > --- lib/msun/src/s_cpowl.c (revision 336360) > +++ lib/msun/src/s_cpowl.c (working copy) > @@ -59,7 +59,7 @@ > y = cimagl(z); > absa = cabsl(a); > if (absa == 0.0L) { > - return (0.0L + 0.0L * I); > + return (CMPLXL(0.0L, 0.0L)); > } > arga = cargl(a); > r = powl(absa, x); > @@ -68,6 +68,6 @@ > r = r * expl(-y * arga); > theta = theta + y * logl(absa); > } > - w = r * cosl(theta) + (r * sinl(theta)) * I; > + w = CMPLXL(r * cosl(theta), r * sinl(theta)); > return (w); > } > -- > Steve > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Steve 20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4 20161221 https://www.youtube.com/watch?v=IbCHE-hONow From owner-freebsd-current@freebsd.org Thu Jul 19 05:49:42 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CAE46104AD53 for ; Thu, 19 Jul 2018 05:49:42 +0000 (UTC) (envelope-from filippomore@yahoo.com) Received: from sonic310-15.consmr.mail.bf2.yahoo.com (sonic310-15.consmr.mail.bf2.yahoo.com [74.6.135.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70FA47E903 for ; Thu, 19 Jul 2018 05:49:42 +0000 (UTC) (envelope-from filippomore@yahoo.com) X-YMail-OSG: oHHJq0AVM1lE8.Itz3Lse_hUxfm0zweJbdCPXjl2RA1fBAhGAoQ7NYgNf0ZbzBR K1pS33Lk0rswrsTYd5jiKDyMh2zetplGbuU2n.E.JYz5ziNHK_C5_kAFEdrfpRIZ84Zdx6HkAdEJ I_b0OyuIJqjSlPexsWsX.CXgp6VbxFyBDqJUlqU.NRVG3ouXItjMiYLz3Np4atEHIHFjyvY.z.Cm OanwpGUWLHoROqspWFLDDp8wms.6wUEx8tXXTQ3WWoaB6eAzaHzmkw8hDUwZ1VUGz65RmrckTwhO YOSnbl5kFLH8pr2ezVcZGcvD_dPI3DJTIUl2u9u5yYWFlER8ggvBz9IfYYjFRX1rDNJGW2R_0D7T SK4aG2bH1Jq1vVHbZiGXcHGC5jZ3YMpVcvGQpeZt1AL4KUnRqeRn.IbGOiK.PrTFe1eLpEjBvqsb NoFo_ci8F4BXNSru6i4d6dcIO4FKjhiORkBT7vzjtvmCKdztFp8zaaThR2Ofy11OQ3OZ2WmvgM34 ZDZ0iF6.HO26aDTi5aegORLdlrrPDq8__yPNstq2tYcA22kJPPfhQf5cbGLr7dJlLw5qfiDE.K3G X87BdY5.qpWT3mVaVyK_UqYSYHX0hiXuaPnPDAvwi01intvwvRHeeMH2iGLGobzjPcEmxMT5EqSW iYklkvvdM8HemG0gWvcr0Dq.xCS9pXGOu4heZbuldyLUaEhYDSKhpogHwDHN5ZEqXl5Uli2H18gS 8ncX_T4Zbm6FrH1oK8GqeHlfaUaRANPVzSZkF3mk_U.I2F2sIXe4cRU1j2GQG_eefBBayF6tbUIF wlAU1EwiDe9UJSt4sEhlVjsTRBlDYr2i0iGM8TUvR0_lVMeqqMd8qv35q3PKeljPA5.kXtfteAxx zGjuzEQNmkT_uHbmJD9TwwWg.hUl7aVNWPfvRWLNniXrBdHLRP_eORojxGmAxJ0Bd0yw3REDOB1x qiabM9.hA Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Thu, 19 Jul 2018 05:49:41 +0000 Date: Thu, 19 Jul 2018 05:49:39 +0000 (UTC) From: Filippo Moretti To: FreeBSD Current Message-ID: <1280450387.6502118.1531979379575@mail.yahoo.com> Subject: Problem with Current amd64 MIME-Version: 1.0 References: <1280450387.6502118.1531979379575.ref@mail.yahoo.com> X-Mailer: WebService/1.1.12062 YMailNorrin Mozilla/5.0 (Windows NT 5.1; rv:52.0) Gecko/20100101 Firefox/52.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 05:49:43 -0000 I installed from the latest snapshot,made buildworld with custom kernel,installed bash and mc from ports.It was the first time I used zfs on 1 Tb sata III disk.When I rebooted the system I got a nasty surprise:my home directory,ports and src are no longer there.This never happened to me.Should I reinstall or any other suggestion really appreciated Sincerely Filippo From owner-freebsd-current@freebsd.org Thu Jul 19 07:41:58 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9714B104EA73 for ; Thu, 19 Jul 2018 07:41:58 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 37F79827CD for ; Thu, 19 Jul 2018 07:41:57 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fg3ZO-0003Ai-6o; Thu, 19 Jul 2018 09:41:50 +0200 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "FreeBSD Current" , "Filippo Moretti" Subject: Re: Problem with Current amd64 References: <1280450387.6502118.1531979379575.ref@mail.yahoo.com> <1280450387.6502118.1531979379575@mail.yahoo.com> Date: Thu, 19 Jul 2018 09:41:52 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: <1280450387.6502118.1531979379575@mail.yahoo.com> User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.2 X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED, BAYES_50 autolearn=disabled version=3.4.0 X-Scan-Signature: a8ecdd0179e5342c74548fafd5461917 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 07:41:58 -0000 On Thu, 19 Jul 2018 07:49:39 +0200, Filippo Moretti wrote: > I installed from the latest snapshot,made buildworld with custom > kernel,installed bash and mc from ports.It was the first time I used zfs > on 1 Tb sata III disk.When I rebooted the system I got a nasty > surprise:my home directory,ports and src are no longer there.This never > happened to me.Should I reinstall or any other suggestion really > appreciated > Sincerely > Filippo Reinstall sounds unlikely. Sounds like a mistake in the order of mounting. Something which worked when doing manual steps, but not after boot. Please mail your /etc/fstab and the output of zpool list, zpool status and zfs list. And /etc/rc.conf can be interesting too. Regards, Ronald. From owner-freebsd-current@freebsd.org Thu Jul 19 08:18:13 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9DCFA105025B for ; Thu, 19 Jul 2018 08:18:13 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2987684189 for ; Thu, 19 Jul 2018 08:18:13 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fg48Z-0002WC-Er; Thu, 19 Jul 2018 10:18:11 +0200 To: "FreeBSD Current" , "Filippo Moretti" Subject: Re: Problem with Current amd64 References: <1280450387.6502118.1531979379575.ref@mail.yahoo.com> <1280450387.6502118.1531979379575@mail.yahoo.com> <969514184.6520653.1531986976828@mail.yahoo.com> Date: Thu, 19 Jul 2018 10:18:13 +0200 MIME-Version: 1.0 From: "Ronald Klop" Message-ID: In-Reply-To: <969514184.6520653.1531986976828@mail.yahoo.com> User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.2 X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED, BAYES_50, HTML_MESSAGE autolearn=disabled version=3.4.0 X-Scan-Signature: ac7e290c1021e6491e133d15cfe88b06 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 08:18:13 -0000 On Thu, 19 Jul 2018 09:56:16 +0200, Filippo Moretti wrote: > I reinstalled src and ports via svnlite and it seems to work.I will post > the files required once I have the pkgs installed > thank you > Filippo Please keep the mailinglist in your reply addresses. Other people know much more than I do. ;-) Ronald. > > > > On Thursday, July 19, 2018, 9:44:28 AM GMT+2, Ronald Klop > wrote: > > On Thu, 19 Jul 2018 07:49:39 +0200, Filippo Moretti > wrote: > >> I installed from the latest snapshot,made buildworld with custom >> kernel,installed bash and mc from ports.It was the first time I used >> zfs on 1 Tb sata III disk.When I rebooted the system I got a nasty >> surprise:my home directory,ports and src are no longer there.This never >> happened to me.Should I reinstall or any other suggestion really >> appreciated >> Sincerely >> Filippo > > > Reinstall sounds unlikely. > > Sounds like a mistake in the order of mounting. Something which worked > when doing manual steps, but not after boot. > Please mail your /etc/fstab and the output of zpool list, zpool status > and zfs list. > And /etc/rc.conf can be interesting too. > > Regards, > > Ronald. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org > " From owner-freebsd-current@freebsd.org Fri Jul 20 11:36:30 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC34F104114A for ; Fri, 20 Jul 2018 11:36:30 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 57B6C78509 for ; Fri, 20 Jul 2018 11:36:30 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (124-169-199-167.dyn.iinet.net.au [124.169.199.167]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id w6KBWskB052209 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 20 Jul 2018 04:32:56 -0700 (PDT) (envelope-from julian@freebsd.org) To: freebsd-current From: Julian Elischer Subject: gcc/clang interoperability problem with a custom "samba" build in recent -current. Message-ID: Date: Fri, 20 Jul 2018 19:32:48 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 11:36:31 -0000 compiling our samba with gcc 4.2.1 in 12 gave us some off behaviour when lld became the linker I think.. 1/ linking needed some directories added to some of the build scripts because previously apparently it looked in $SYSROOT/usr/lib by default and now it doesn't. 2/ compiling our samba produces a libtdb.so that has various symbols in it, (according to nm(1) ), but when we try link against it we get complaints about those symbols not being defined. 3/ an attempt to switch to using clang to compile everything leads to: "--aes-accel=intelaesni selected and compiler rejects -Wp,-E,-lang-asm. One wonders whether there is a clang equivalent of "-Wp,-E,-lang-asm" The AES acceleration is a configure option for the samba package. Apparently turning it on requires -Wp,-E,-lang-asm. which apparently gcc 4.2.1 has, but clang doesn't have. FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM 6.0.1) Target: x86_64-unknown-freebsd12.0 Thread model: posix InstalledDir: /usr/bin anyone know if there is a clang equivalent of -Wp, -E,-lang-asm? possible work arrounds include: 1/ Get gcc/lld to produce a library from which lld can find the symbols 2/ find a way to compile this with clang but everything else with gcc? 3/ find a way to allow clang to use -Wp,-E,-lang-asm whatever that means Thoughts from any tools people? Julian From owner-freebsd-current@freebsd.org Sat Jul 21 14:32:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7A40104D5F5 for ; Sat, 21 Jul 2018 14:32:51 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 85BF78C104 for ; Sat, 21 Jul 2018 14:32:51 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (124-169-199-167.dyn.iinet.net.au [124.169.199.167]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id w6LEWe8G058337 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Sat, 21 Jul 2018 07:32:43 -0700 (PDT) (envelope-from julian@freebsd.org) Subject: Re: gcc/clang interoperability problem with a custom "samba" build in recent -current. From: Julian Elischer To: freebsd-current References: Message-ID: Date: Sat, 21 Jul 2018 22:32:34 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 14:32:52 -0000 I would really like ot get some pointers as to who are our tools committers at the moment, in particular who might know about these issues. The main issue for me at the moment is the ability to compile the aesni code in Samba from clang.. Julian On 20/7/18 7:32 pm, Julian Elischer wrote: > compiling our samba with gcc 4.2.1 in 12 gave us some off behaviour > when lld became the linker I think.. > > 1/ linking needed some directories added to some of the build > scripts because previously apparently it looked in $SYSROOT/usr/lib > by default and now it doesn't. > > 2/ compiling our samba produces a libtdb.so that has various symbols > in it, (according to nm(1) ), but when we try link against it we get > complaints about those symbols not being defined. > > 3/ an attempt to switch to using clang to compile everything leads to: > > > "--aes-accel=intelaesni selected and compiler rejects -Wp,-E,-lang-asm. > > One wonders whether there is a clang equivalent of "-Wp,-E,-lang-asm" > > The AES acceleration is a configure option for the samba package. > > Apparently turning it on requires -Wp,-E,-lang-asm. > > which apparently gcc 4.2.1 has, but clang doesn't have. > >    FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based >    on LLVM 6.0.1) >    Target: x86_64-unknown-freebsd12.0 >    Thread model: posix >    InstalledDir: /usr/bin > > anyone know if there is a clang equivalent of -Wp, -E,-lang-asm? > > possible work arrounds include: > > 1/ Get gcc/lld to produce a library from which lld can find the symbols > > 2/ find a way to compile this with clang but everything else with gcc? > > 3/ find a way to allow clang to use > -Wp,-E,-lang-asm > > whatever that means > > > Thoughts from any tools people? > > Julian > > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" > From owner-freebsd-current@freebsd.org Sat Jul 21 15:16:49 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C728E104E402 for ; Sat, 21 Jul 2018 15:16:49 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A1618D464; Sat, 21 Jul 2018 15:16:49 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0A548212A0; Sat, 21 Jul 2018 11:16:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 21 Jul 2018 11:16:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=GB+vBYyBCZHYDPbz0Xq/2hv3K+cNw Di0MjYmPwQMiak=; b=EmjbOM0wwlmZToojDqrBz6rBtLgpTJANZiKNBeVMVgFKa RDgrdK9MQ7AQq6cFMRHWxUsxjscRQuWYFDStjoEzta8mPazl3GB/ljCsb9efx3yP Gpjdwo0xPyT4VuWNSjUG4X4DmaaaYwo1/Y9T7jmTTDvDRylX08vjMmzFBLXEAMzI 8H2jgls+cPgrGLjekBsOU3vVEppgtfrGOtJ9sq8/KLZ3I+blAdpuG9bCclZVPv7g zOgJfMIex6PdgqmgJn9zkwpgDbUXgysmcM1z0o+jv6CdgpzHHjHofxorcvBr/45c ZuQ9BTxmeIqt/hfFmOx+Zb2ztF4y9wmfnLkoyHsaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=GB+vBY yBCZHYDPbz0Xq/2hv3K+cNwDi0MjYmPwQMiak=; b=S3kh/Z687KBjcSKZQhP1YS mpeCpVCTOyCkRbmsWVh6/Y1VdruBqPaffGY//IPWpXBv2Y+hsez0lBIphFcPhIKT ihdNbpPdxU51ieolPWkvdfZMjyMuYWajGlodo/WqQxpxmy5ojEZIui9XeWoSMDkS wrCBCa8Z7PVNT+WF3LVvQuhy9EgY/fA/uk1XkWbacumN0WRpdvoJ5yabKeLClaeP NYJjhrQeHM63ateIEbsoDTYy/kx6YF9LBset4rtgQWw6R9ugSt/EpAEbsq5AkXt4 EWvZWhrBBk42M+DfPJCd0AgGS0rd8ZVR5Ats5DDh6OhDmfpVla38JC4oyUqcxvZw == X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.2] (unknown [62.183.124.233]) by mail.messagingengine.com (Postfix) with ESMTPA id 82F3EE4513; Sat, 21 Jul 2018 11:16:46 -0400 (EDT) Subject: Re: gcc/clang interoperability problem with a custom "samba" build in recent -current. To: Julian Elischer , freebsd-current References: From: Yuri Pankov Message-ID: Date: Sat, 21 Jul 2018 18:16:40 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 15:16:50 -0000 Julian Elischer wrote: > I would really like ot get some pointers as to who are our tools > committers at the moment, in particular who might know about these issues. > The main issue for me at the moment is the ability to compile the > aesni code in Samba from clang.. > > Julian > > > On 20/7/18 7:32 pm, Julian Elischer wrote: >> compiling our samba with gcc 4.2.1 in 12 gave us some off behaviour >> when lld became the linker I think.. >> >> 1/ linking needed some directories added to some of the build >> scripts because previously apparently it looked in $SYSROOT/usr/lib >> by default and now it doesn't. >> >> 2/ compiling our samba produces a libtdb.so that has various symbols >> in it, (according to nm(1) ), but when we try link against it we get >> complaints about those symbols not being defined. >> >> 3/ an attempt to switch to using clang to compile everything leads to: >> >> >> "--aes-accel=intelaesni selected and compiler rejects -Wp,-E,-lang-asm. >> >> One wonders whether there is a clang equivalent of "-Wp,-E,-lang-asm" >> >> The AES acceleration is a configure option for the samba package. >> >> Apparently turning it on requires -Wp,-E,-lang-asm. >> >> which apparently gcc 4.2.1 has, but clang doesn't have. >> >>    FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based >>    on LLVM 6.0.1) >>    Target: x86_64-unknown-freebsd12.0 >>    Thread model: posix >>    InstalledDir: /usr/bin >> >> anyone know if there is a clang equivalent of -Wp, -E,-lang-asm? In later GCC versions the cpp's -lang-asm seems to be deprecated in favor of -x assembler-with-cpp as it conflicts with -l option. Could you try changing the -Wp,-E,-lang-asm to -Wp,-E,-xassembler-with-cpp? >> possible work arrounds include: >> >> 1/ Get gcc/lld to produce a library from which lld can find the symbols >> >> 2/ find a way to compile this with clang but everything else with gcc? >> >> 3/ find a way to allow clang to use >> -Wp,-E,-lang-asm >> >> whatever that means >> >> >> Thoughts from any tools people? From owner-freebsd-current@freebsd.org Sat Jul 21 16:41:32 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 669FD1050201 for ; Sat, 21 Jul 2018 16:41:32 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from vps-mail.nomadlogic.org (mail.nomadlogic.org [IPv6:2607:f2f8:a098::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DADE38F832 for ; Sat, 21 Jul 2018 16:41:31 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.106] (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by vps-mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 1c0c093e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Sat, 21 Jul 2018 09:41:28 -0700 (PDT) To: FreeBSD Current From: Pete Wright Subject: ntpd as ntpd user question Message-ID: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> Date: Sat, 21 Jul 2018 09:41:24 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 16:41:32 -0000 hello - i am testing out the new ntpd that was committed yesterday and am attempting to run as non-root.  i've created a ntpd user/group, and verified permissions look good on pertinent directories.  i am running into an issue with the rc script tho - it's complaining about multiple pid files being specified? $ sudo /etc/rc.d/ntpd start Starting ntpd. ntpd error:  only one pidfile option allowed ntpd - NTP daemon program - Ver. 4.2.8p11 Usage:  ntpd [ - [] | --[{=| }] ]... \         [ ... ] Try 'ntpd --help' for more information. /etc/rc.d/ntpd: WARNING: failed to start ntpd has anyone else seen this issue? not sure if this is an issue with my local config or not, i've read through the rc script and its not obvious to me yet why it may be getting multiple pid arguments passed.  the only relevant bit i have set in rc.conf is: $ grep ntpd /etc/rc.conf ntpd_enable="YES" thanks! -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-current@freebsd.org Sat Jul 21 16:47:47 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A910B1050520 for ; Sat, 21 Jul 2018 16:47:47 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2674F8FBE3 for ; Sat, 21 Jul 2018 16:47:47 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: c59813c2-8d05-11e8-aff6-0b9b8210da61 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id c59813c2-8d05-11e8-aff6-0b9b8210da61; Sat, 21 Jul 2018 16:47:37 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6LGladm008777; Sat, 21 Jul 2018 10:47:36 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532191655.1344.80.camel@freebsd.org> Subject: Re: ntpd as ntpd user question From: Ian Lepore To: Pete Wright , FreeBSD Current Date: Sat, 21 Jul 2018 10:47:35 -0600 In-Reply-To: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 16:47:47 -0000 On Sat, 2018-07-21 at 09:41 -0700, Pete Wright wrote: > hello - i am testing out the new ntpd that was committed yesterday and  > am attempting to run as non-root.  i've created a ntpd user/group, and  > verified permissions look good on pertinent directories.  i am running  > into an issue with the rc script tho - it's complaining about multiple  > pid files being specified? > > $ sudo /etc/rc.d/ntpd start > Starting ntpd. > ntpd error:  only one pidfile option allowed > ntpd - NTP daemon program - Ver. 4.2.8p11 > Usage:  ntpd [ - [] | --[{=| }] ]... \ >          [ ... ] > Try 'ntpd --help' for more information. > /etc/rc.d/ntpd: WARNING: failed to start ntpd > > > has anyone else seen this issue? not sure if this is an issue with my  > local config or not, i've read through the rc script and its not obvious  > to me yet why it may be getting multiple pid arguments passed.  the only  > relevant bit i have set in rc.conf is: > > $ grep ntpd /etc/rc.conf > ntpd_enable="YES" > > > thanks! > -pete > You say you created an ntpd user/group, that seems to imply you didn't run mergemaster (which would have done that). If that's the case, you probably also didn't get /etc/defaults/rc.conf updated, so it still has the old ntpd_flags that includes the pidfile (which is now provided by the startup script and shouldn't be set in ntpd_flags). If all of that is the wrong guess, let me know and we'll figure it out. -- Ian From owner-freebsd-current@freebsd.org Sat Jul 21 17:11:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 35A031050E8B for ; Sat, 21 Jul 2018 17:11:52 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from vps-mail.nomadlogic.org (mail.nomadlogic.org [IPv6:2607:f2f8:a098::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C23B2705A8; Sat, 21 Jul 2018 17:11:49 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [IPv6:2605:e000:1313:89:223:24ff:fea8:4fb5] (2605:e000:1313:89:223:24ff:fea8:4fb5 [IPv6:2605:e000:1313:89:223:24ff:fea8:4fb5]) by vps-mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 2f1d9056 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Sat, 21 Jul 2018 10:11:47 -0700 (PDT) Subject: Re: ntpd as ntpd user question To: Ian Lepore , FreeBSD Current References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> From: Pete Wright Message-ID: <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> Date: Sat, 21 Jul 2018 10:11:43 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1532191655.1344.80.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 17:11:52 -0000 On 07/21/2018 09:47, Ian Lepore wrote: > On Sat, 2018-07-21 at 09:41 -0700, Pete Wright wrote: >> hello - i am testing out the new ntpd that was committed yesterday and >> am attempting to run as non-root.  i've created a ntpd user/group, and >> verified permissions look good on pertinent directories.  i am running >> into an issue with the rc script tho - it's complaining about multiple >> pid files being specified? >> >> $ sudo /etc/rc.d/ntpd start >> Starting ntpd. >> ntpd error:  only one pidfile option allowed >> ntpd - NTP daemon program - Ver. 4.2.8p11 >> Usage:  ntpd [ - [] | --[{=| }] ]... \ >>          [ ... ] >> Try 'ntpd --help' for more information. >> /etc/rc.d/ntpd: WARNING: failed to start ntpd >> >> >> has anyone else seen this issue? not sure if this is an issue with my >> local config or not, i've read through the rc script and its not obvious >> to me yet why it may be getting multiple pid arguments passed.  the only >> relevant bit i have set in rc.conf is: >> >> $ grep ntpd /etc/rc.conf >> ntpd_enable="YES" >> >> >> thanks! >> -pete >> > You say you created an ntpd user/group, that seems to imply you didn't > run mergemaster (which would have done that). If that's the case, you > probably also didn't get /etc/defaults/rc.conf updated, so it still has > the old ntpd_flags that includes the pidfile (which is now provided by > the startup script and shouldn't be set in ntpd_flags). > > If all of that is the wrong guess, let me know and we'll figure it out. that's Ian - that's most likely it (defaults/rc.conf).  i did run mergemaster but i suspect i didn't run it correctly b/c it didn't copy over any files, nor create the ntpd uid/gid.  my buildworld script does a "mergemaster -m $CHECKOUT -a".  i'll re-read the man page today and update my scripts accordingly. thanks again for the bread-crumb! -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-current@freebsd.org Sat Jul 21 17:14:56 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D309C105100F for ; Sat, 21 Jul 2018 17:14:55 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5BFDD70A05 for ; Sat, 21 Jul 2018 17:14:55 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 90af3ade-8d09-11e8-93fa-f3ebd9db2b94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 90af3ade-8d09-11e8-93fa-f3ebd9db2b94; Sat, 21 Jul 2018 17:14:46 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6LHEjOo008823; Sat, 21 Jul 2018 11:14:45 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532193285.1344.83.camel@freebsd.org> Subject: Re: ntpd as ntpd user question From: Ian Lepore To: Pete Wright , FreeBSD Current Date: Sat, 21 Jul 2018 11:14:45 -0600 In-Reply-To: <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 17:14:56 -0000 On Sat, 2018-07-21 at 10:11 -0700, Pete Wright wrote: > > On 07/21/2018 09:47, Ian Lepore wrote: > > > > On Sat, 2018-07-21 at 09:41 -0700, Pete Wright wrote: > > > > > > hello - i am testing out the new ntpd that was committed > > > yesterday and > > > am attempting to run as non-root.  i've created a ntpd > > > user/group, and > > > verified permissions look good on pertinent directories.  i am > > > running > > > into an issue with the rc script tho - it's complaining about > > > multiple > > > pid files being specified? > > > > > > $ sudo /etc/rc.d/ntpd start > > > Starting ntpd. > > > ntpd error:  only one pidfile option allowed > > > ntpd - NTP daemon program - Ver. 4.2.8p11 > > > Usage:  ntpd [ - [] | --[{=| }] ]... \ > > >           [  ...  ] > > > Try 'ntpd --help' for more information. > > > /etc/rc.d/ntpd: WARNING: failed to start ntpd > > > > > > > > > has anyone else seen this issue? not sure if this is an issue > > > with my > > > local config or not, i've read through the rc script and its not > > > obvious > > > to me yet why it may be getting multiple pid arguments passed.  > > > the only > > > relevant bit i have set in rc.conf is: > > > > > > $ grep ntpd /etc/rc.conf > > > ntpd_enable="YES" > > > > > > > > > thanks! > > > -pete > > > > > You say you created an ntpd user/group, that seems to imply you > > didn't > > run mergemaster (which would have done that). If that's the case, > > you > > probably also didn't get /etc/defaults/rc.conf updated, so it still > > has > > the old ntpd_flags that includes the pidfile (which is now provided > > by > > the startup script and shouldn't be set in ntpd_flags). > > > > If all of that is the wrong guess, let me know and we'll figure it > > out. > that's Ian - that's most likely it (defaults/rc.conf).  i did run  > mergemaster but i suspect i didn't run it correctly b/c it didn't > copy  > over any files, nor create the ntpd uid/gid.  my buildworld script > does  > a "mergemaster -m $CHECKOUT -a".  i'll re-read the man page today > and  > update my scripts accordingly. > > thanks again for the bread-crumb! > -pete > There's a "pre-world" stage of mergemaster (-Fp option I think) which isn't needed often, but one of the times it is needed is apparently when new user ids are added.  (So I've been told, I've never much used mergemaster myself). I think there are some words about it at the very bottom of UPDATING. -- Ian From owner-freebsd-current@freebsd.org Sat Jul 21 17:47:14 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8AC310519E6 for ; Sat, 21 Jul 2018 17:47:14 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (www.zefox.net [50.1.20.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "www.zefox.org", Issuer "www.zefox.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FB5D719CA; Sat, 21 Jul 2018 17:47:13 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (localhost [127.0.0.1]) by www.zefox.net (8.15.2/8.15.2) with ESMTPS id w6LHlNiL040228 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 21 Jul 2018 10:47:24 -0700 (PDT) (envelope-from fbsd@www.zefox.net) Received: (from fbsd@localhost) by www.zefox.net (8.15.2/8.15.2/Submit) id w6LHlMVo040227; Sat, 21 Jul 2018 10:47:22 -0700 (PDT) (envelope-from fbsd) Date: Sat, 21 Jul 2018 10:47:22 -0700 From: bob prohaska To: Ian Lepore Cc: Pete Wright , FreeBSD Current , bob prohaska Subject: Re: ntpd as ntpd user question Message-ID: <20180721174722.GA40167@www.zefox.net> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532193285.1344.83.camel@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 17:47:15 -0000 On Sat, Jul 21, 2018 at 11:14:45AM -0600, Ian Lepore wrote: > > There's a "pre-world" stage of mergemaster (-Fp option I think) which > isn't needed often, but one of the times it is needed is apparently > when new user ids are added. ?(So I've been told, I've never much used > mergemaster myself). I think there are some words about it at the very > bottom of UPDATING. > FWIW, installkernel stopped with the note about needing an ntpd user/group. Never having been successful with mergemaster (couldn't make heads nor tails of the "what to do" prompts) I just ran adduser, creating a locked ntpd user and group. Nothing else special done. The machine is up to r336567 on arm64. Installkernel ran, I didn't touch anthing in /etc manually and reboot looked normal. For now it seems ignorance is bliss.... If there's something special I should do (beyond locking) to secure the ntpd account please warn me. Thanks for reading, bob prohaska From owner-freebsd-current@freebsd.org Sat Jul 21 17:56:59 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67B9C1051D56 for ; Sat, 21 Jul 2018 17:56:59 +0000 (UTC) (envelope-from rwmaillists@googlemail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7DD271F03 for ; Sat, 21 Jul 2018 17:56:58 +0000 (UTC) (envelope-from rwmaillists@googlemail.com) Received: by mail-wm0-x231.google.com with SMTP id c14-v6so12243617wmb.4 for ; Sat, 21 Jul 2018 10:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XVyI+wagf0RVMXPnTS4JoUJT7LPb0rixsadTSSdfitU=; b=A4NWtKtrBAW4ul7GA70xTBIFOI/SsdrLT1XHt/D7HTJ/VarqRsqIfpbWhKebUf1nLb r6GDIKXW2DYbaDW5VknBVDVJmwoxj3rbXGvP28FHrcMk489q5FEmNI+ntRXasdg/JUln zJ+9Jfnd9Eo/Sg+dyDdupnrMxHKUEMGxZAY2mqnLvbjqkaXXPQtz4CgnGiPdD/0vvfog DSukCwupwoWPORm79CdANAzA/QH0dTb5Rk3clvG0fqEwMH+KMrT9RV9YkDnxrcszcsCA izEQhZrmZtTcbj0JczN/58f/+eh7WGV/J4KdoHkXphdTI/5TC4Y/zBXQzQGT5jZLlZk1 M29Q== X-Gm-Message-State: AOUpUlEGk07KtnGW8EUCdjj5t2PVSnaWekHk7aUDMVy/K2xrtgVZ3I+G 9cJ9EMjDTT3ibdea7wQro6VGo5kzhYA= X-Google-Smtp-Source: AAOMgpcNIHQBsHUHiyXslgUaIJJ8fCCtzNaUBwxo1va97qq0H4SNJ2EVpgs9pOZ3sgCAWTyYMgMj1Q== X-Received: by 2002:a1c:ec1b:: with SMTP id k27-v6mr3916184wmh.157.1532195817502; Sat, 21 Jul 2018 10:56:57 -0700 (PDT) Received: from gumby.homeunix.com ([90.205.255.240]) by smtp.gmail.com with ESMTPSA id t19-v6sm4054439wmi.42.2018.07.21.10.56.56 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Jul 2018 10:56:56 -0700 (PDT) Date: Sat, 21 Jul 2018 18:56:54 +0100 From: RW To: freebsd-current@freebsd.org Subject: Re: ntpd as ntpd user question Message-ID: <20180721185654.239b4c8b@gumby.homeunix.com> In-Reply-To: <1532193285.1344.83.camel@freebsd.org> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; amd64-portbld-freebsd11.1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 17:56:59 -0000 On Sat, 21 Jul 2018 11:14:45 -0600 Ian Lepore wrote: > There's a "pre-world" stage of mergemaster (-Fp option I think) which > isn't needed often, but one of the times it is needed is apparently > when new user ids are added. =C2=A0 I wish mergemaster had an option to just add new users and groups, rather than merging the files.=20 From owner-freebsd-current@freebsd.org Sat Jul 21 18:14:14 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73F0610525D7 for ; Sat, 21 Jul 2018 18:14:14 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E1886728EE for ; Sat, 21 Jul 2018 18:14:13 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: dda41b38-8d11-11e8-93fa-f3ebd9db2b94 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id dda41b38-8d11-11e8-93fa-f3ebd9db2b94; Sat, 21 Jul 2018 18:14:11 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6LIEAQs008919; Sat, 21 Jul 2018 12:14:10 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532196850.1344.87.camel@freebsd.org> Subject: Re: ntpd as ntpd user question From: Ian Lepore To: bob prohaska Cc: Pete Wright , FreeBSD Current Date: Sat, 21 Jul 2018 12:14:10 -0600 In-Reply-To: <20180721174722.GA40167@www.zefox.net> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> <20180721174722.GA40167@www.zefox.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 18:14:14 -0000 On Sat, 2018-07-21 at 10:47 -0700, bob prohaska wrote: > On Sat, Jul 21, 2018 at 11:14:45AM -0600, Ian Lepore wrote: > > > > > > There's a "pre-world" stage of mergemaster (-Fp option I think) which > > isn't needed often, but one of the times it is needed is apparently > > when new user ids are added. ?(So I've been told, I've never much used > > mergemaster myself). I think there are some words about it at the very > > bottom of UPDATING. > > > FWIW, installkernel stopped with the note about needing an ntpd user/group. > Never having been successful with mergemaster (couldn't make heads nor tails > of the "what to do" prompts) I just ran adduser, creating a locked ntpd user > and group. Nothing else special done. The machine is up to r336567 on arm64. > > Installkernel ran, I didn't touch anthing in /etc manually and reboot looked normal. > For now it seems ignorance is bliss.... > > If there's something special I should do (beyond locking) to secure the ntpd  > account please warn me. > > Thanks for reading, > > bob prohaska I can't see any way that installkernel would lead to the complaint about the ntpd user not existing; that check is tied to the installworld target. A quick way to check whether ntpd is running as ntpd user:  procstat cred `pgrep ntpd` PID COMM  EUID  RUID SVUID  EGID  RGID SVGID UMASK FLAGS GROUPS 1176 ntpd   123   123   123   123   123   123   022 -     123 -- Ian From owner-freebsd-current@freebsd.org Sat Jul 21 18:23:45 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC0B31052A5D for ; Sat, 21 Jul 2018 18:23:45 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from vps-mail.nomadlogic.org (mail.nomadlogic.org [IPv6:2607:f2f8:a098::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2FDBD72EE5 for ; Sat, 21 Jul 2018 18:23:45 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [IPv6:2605:e000:1313:89:223:24ff:fea8:4fb5] (2605:e000:1313:89:223:24ff:fea8:4fb5 [IPv6:2605:e000:1313:89:223:24ff:fea8:4fb5]) by vps-mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 6b9d106e TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO for ; Sat, 21 Jul 2018 11:23:41 -0700 (PDT) Subject: Re: ntpd as ntpd user question To: freebsd-current@freebsd.org References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> From: Pete Wright Message-ID: Date: Sat, 21 Jul 2018 11:23:37 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1532193285.1344.83.camel@freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 18:23:46 -0000 On 07/21/2018 10:14, Ian Lepore wrote: > On Sat, 2018-07-21 at 10:11 -0700, Pete Wright wrote: >> On 07/21/2018 09:47, Ian Lepore wrote: >>> On Sat, 2018-07-21 at 09:41 -0700, Pete Wright wrote: >>>> hello - i am testing out the new ntpd that was committed >>>> yesterday and >>>> am attempting to run as non-root.  i've created a ntpd >>>> user/group, and >>>> verified permissions look good on pertinent directories.  i am >>>> running >>>> into an issue with the rc script tho - it's complaining about >>>> multiple >>>> pid files being specified? >>>> >>>> $ sudo /etc/rc.d/ntpd start >>>> Starting ntpd. >>>> ntpd error:  only one pidfile option allowed >>>> ntpd - NTP daemon program - Ver. 4.2.8p11 >>>> Usage:  ntpd [ - [] | --[{=| }] ]... \ >>>>           [  ...  ] >>>> Try 'ntpd --help' for more information. >>>> /etc/rc.d/ntpd: WARNING: failed to start ntpd >>>> >>>> >>>> has anyone else seen this issue? not sure if this is an issue >>>> with my >>>> local config or not, i've read through the rc script and its not >>>> obvious >>>> to me yet why it may be getting multiple pid arguments passed. >>>> the only >>>> relevant bit i have set in rc.conf is: >>>> >>>> $ grep ntpd /etc/rc.conf >>>> ntpd_enable="YES" >>>> >>>> >>>> thanks! >>>> -pete >>>> >>> You say you created an ntpd user/group, that seems to imply you >>> didn't >>> run mergemaster (which would have done that). If that's the case, >>> you >>> probably also didn't get /etc/defaults/rc.conf updated, so it still >>> has >>> the old ntpd_flags that includes the pidfile (which is now provided >>> by >>> the startup script and shouldn't be set in ntpd_flags). >>> >>> If all of that is the wrong guess, let me know and we'll figure it >>> out. >> that's Ian - that's most likely it (defaults/rc.conf).  i did run >> mergemaster but i suspect i didn't run it correctly b/c it didn't >> copy >> over any files, nor create the ntpd uid/gid.  my buildworld script >> does >> a "mergemaster -m $CHECKOUT -a".  i'll re-read the man page today >> and >> update my scripts accordingly. >> >> thanks again for the bread-crumb! >> -pete >> > There's a "pre-world" stage of mergemaster (-Fp option I think) which > isn't needed often, but one of the times it is needed is apparently > when new user ids are added.  (So I've been told, I've never much used > mergemaster myself). I think there are some words about it at the very > bottom of UPDATING. so i was running the "pre-world" mergemaster, but i think what bit me was relying on the "-a" switch.  after reading UPDATING as you suggested i re-ran mergemaster like so: "sudo mergemaster -m $CHECKOUT -rvF" which seems closer in-line with the documentation.  i had a ton of stuff missing, which would explain some funky behaviour i've seen in regards to devd, so glad i sorted this out. as someone RW mentions later in this thread, it would be sweet if mergemaster could auto add users/groups.  i missed this in the diff during my pre-installworld mergemaster run.  easily fixed - but def something i'll have to keep my eye out for. cheers, -pete -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-current@freebsd.org Sat Jul 21 19:01:57 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCAA0102952E for ; Sat, 21 Jul 2018 19:01:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2ED3D73DF7; Sat, 21 Jul 2018 19:01:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id gx8UfXWxCWppDgx8Vfyvmu; Sat, 21 Jul 2018 13:01:49 -0600 X-Authority-Analysis: v=2.3 cv=YIcrNiOx c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=JDqqk6rNJDqWOfoyh_sA:9 a=C2D_PKwzeTPLqmqM:21 a=GN2tWDss3UKUvtsR:21 a=CjuIK1q_8ugA:10 a=5t53oLBrB7TCmJWHBLsA:9 a=VBTD5Iz7giD7QUrf:21 a=3wAXxBWNPWRaiL9s:21 a=t-j_L2JC6m6kD0eV:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.81.206.140] (S0106002401cb186f.gv.shawcable.net [70.67.125.17]) by spqr.komquats.com (Postfix) with ESMTPSA id F088C797; Sat, 21 Jul 2018 12:01:47 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: ntpd as ntpd user question Date: Sat, 21 Jul 2018 12:01:49 -0700 To: bob prohaska , Ian Lepore CC: Pete Wright , FreeBSD Current Message-Id: <20180721190147.F088C797@spqr.komquats.com> X-CMAE-Envelope: MS4wfIkTmEB9288hCQl22hCqaS4LyBgPf+APBUU3eUsbiCAALKf6oovpK+gpmVfVB81M2WSeEepuaAa3xCjVeh/zKDLTt/N7FJgWNPXNlX9hVvQM9xf2wDb9 eTfWmGUo/Ch4r1k+RhJhSgifcaw+tgqbm2fQUEEOg5yw2/3bEHgOuiixpYejSoQBxuc0OYxU+tTDqml/3Iq8pm+xTSieNsZuV0I0GwcT3Bmy7DIrw20kY5j+ 46+tAkoW5jGqilXDGfw3gewB2jdtCC1jQE8n07PTQOg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 19:01:58 -0000 This is why you need to run pre-world mergemaster. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: bob prohaska Sent: 21/07/2018 10:49 To: Ian Lepore Cc: Pete Wright; FreeBSD Current; bob prohaska Subject: Re: ntpd as ntpd user question On Sat, Jul 21, 2018 at 11:14:45AM -0600, Ian Lepore wrote: >=20 > There's a "pre-world" stage of mergemaster (-Fp option I think) which > isn't needed often, but one of the times it is needed is apparently > when new user ids are added. ?(So I've been told, I've never much used > mergemaster myself). I think there are some words about it at the very > bottom of UPDATING. >=20 FWIW, installkernel stopped with the note about needing an ntpd user/group. Never having been successful with mergemaster (couldn't make heads nor tail= s of the "what to do" prompts) I just ran adduser, creating a locked ntpd use= r and group. Nothing else special done. The machine is up to r336567 on arm64= . Installkernel ran, I didn't touch anthing in /etc manually and reboot looke= d normal. For now it seems ignorance is bliss.... If there's something special I should do (beyond locking) to secure the ntp= d=20 account please warn me. Thanks for reading, bob prohaska _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Sat Jul 21 19:02:20 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95F3610296D1 for ; Sat, 21 Jul 2018 19:02:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BA3773E65 for ; Sat, 21 Jul 2018 19:02:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id gx8xfrmbSwyxUgx8yfOhye; Sat, 21 Jul 2018 13:02:18 -0600 X-Authority-Analysis: v=2.3 cv=NPJhBHyg c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=R9QF1RCXAYgA:10 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=bndtePL8q6Xl14ri9XkA:9 a=yXM7deOK8CQexruI:21 a=0SkMytwD6tQtsUpL:21 a=QEXdDO2ut3YA:10 a=1KCIKkMmG1i-milNgMAA:9 a=Bre6WzF-RHQcRg36:21 a=pf_xMiqmPt7ekcqP:21 a=CRTh7LuTzQIuZ_ak:21 a=_W_S_7VecoQA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [25.81.206.140] (S0106002401cb186f.gv.shawcable.net [70.67.125.17]) by spqr.komquats.com (Postfix) with ESMTPSA id 0EF0F79C; Sat, 21 Jul 2018 12:02:18 -0700 (PDT) MIME-Version: 1.0 From: Cy Schubert Subject: RE: ntpd as ntpd user question Date: Sat, 21 Jul 2018 12:02:19 -0700 To: RW , "freebsd-current@freebsd.org" Message-Id: <20180721190218.0EF0F79C@spqr.komquats.com> X-CMAE-Envelope: MS4wfHIOZ7n/y67j+ZsemM/YKlt+gnM79djclkwJXA2lx1hnlGPqlmuMZtGsaUJbAi1xNCIOqvTyzZzAxnAeWMp89e4luLItcGM8dVZC/1RbxJD0l2DHI/HY 07wfwp72uHqAqkLSii14wwKqgd8UpM9AoVnUzH6aupC+Wpd9WDTuVWNk0VxSyxr2XuiNusqmaDUSWzVjMnXH1aqKpb8xsvhZ587qXHOubZfspjafY07Y4GfO Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 19:02:20 -0000 What's the difference? --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert or The need of the many outweighs the greed of the few. --- -----Original Message----- From: RW Sent: 21/07/2018 10:59 To: freebsd-current@freebsd.org Subject: Re: ntpd as ntpd user question On Sat, 21 Jul 2018 11:14:45 -0600=0A= Ian Lepore wrote:=0A= =0A= =0A= > There's a "pre-world" stage of mergemaster (-Fp option I think) which=0A= > isn't needed often, but one of the times it is needed is apparently=0A= > when new user ids are added. =C2=A0=0A= =0A= I wish mergemaster had an option to just add new users and groups,=0A= rather than merging the files. =0A= _______________________________________________=0A= freebsd-current@freebsd.org mailing list=0A= https://lists.freebsd.org/mailman/listinfo/freebsd-current=0A= To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"= =0A= From owner-freebsd-current@freebsd.org Sat Jul 21 19:11:26 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67B731029A73 for ; Sat, 21 Jul 2018 19:11:26 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10097744DD; Sat, 21 Jul 2018 19:11:25 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 62B3920F20; Sat, 21 Jul 2018 15:11:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 21 Jul 2018 15:11:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=r1vRv5d0Hx9TS6t8bm3pI+g4UvWyG gBAIWxGpd4iSEw=; b=IRPrz/bL88cfmkobqKEx7RlTywo3HtFAtycmCZx5szX0X R5P23Ybm8VKtzOaXAGTU+isae0WLhZ0WoFpWFf/Y3SAwK8rhrIwgIYLhP4jf5IoV Moz41PDPEzYDva8R9usTk6lPMNoxq/7frqoxx9WigkONFJZLTjkc5D8wmFO3tcZt LJ3nqiphLJ8N+22O78cjE/+6+vTH9daXW6x7WY7TKBFIpAWWutQv8Ap25d1RSe+q DuChfKya9W+iSGt3i7+NElguBp0wwr+fRmEf1zPqXrkeD3SxjUxLwq9gM+jvo7ZO qpypQCa30ENVaFgq9ytvaWfMawozCmA4mlStz5s3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=r1vRv5 d0Hx9TS6t8bm3pI+g4UvWyGgBAIWxGpd4iSEw=; b=foVnd4yud2e20GvdLlsTAZ Nn1AzgbqKDlDIo2LFdjeSyTWRQ5R8I7fC+6W/Kr9pwWjh8lc7djcIa7F2s+vnXQG zftPUD/Rw6znaP/Y/0ysup8Vk25L0PAkhUgliZPK8pptkpUFDwthN4hCMiwIcBhy SeWxE7C9GbO5npepzmmbTE/iYB/dVgeFOz7oD3QwB5qRC9DjOS1bwRedF9PyZCmk gwcDaKOoZXOYbl2CQjn1jOuMWVVSj6LqZ5CAfA6kJ6RcjKnJ1LX1HROJ1k7ZhLT5 vvGJBqigqQYpZl74ytX2/5qUxxtFHRvoy1S+pXyAv4jeqJYgcdRThw/kDEO0Q7qQ == X-ME-Proxy: X-ME-Sender: Received: from [192.168.1.2] (unknown [62.183.124.233]) by mail.messagingengine.com (Postfix) with ESMTPA id 9E8D110268; Sat, 21 Jul 2018 15:11:23 -0400 (EDT) Subject: Re: gcc/clang interoperability problem with a custom "samba" build in recent -current. From: Yuri Pankov To: Julian Elischer , freebsd-current References: Message-ID: <3dd60a0d-7a5e-e9f0-3018-d09b5b8ac389@yuripv.net> Date: Sat, 21 Jul 2018 22:11:19 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 19:11:26 -0000 Yuri Pankov wrote: > Julian Elischer wrote: >> I would really like ot get some pointers as to who are our tools >> committers at the moment, in particular who might know about these issues. >> The main issue for me at the moment is the ability to compile the >> aesni code in Samba from clang.. >> >> Julian >> >> >> On 20/7/18 7:32 pm, Julian Elischer wrote: >>> compiling our samba with gcc 4.2.1 in 12 gave us some off behaviour >>> when lld became the linker I think.. >>> >>> 1/ linking needed some directories added to some of the build >>> scripts because previously apparently it looked in $SYSROOT/usr/lib >>> by default and now it doesn't. >>> >>> 2/ compiling our samba produces a libtdb.so that has various symbols >>> in it, (according to nm(1) ), but when we try link against it we get >>> complaints about those symbols not being defined. >>> >>> 3/ an attempt to switch to using clang to compile everything leads to: >>> >>> >>> "--aes-accel=intelaesni selected and compiler rejects -Wp,-E,-lang-asm. >>> >>> One wonders whether there is a clang equivalent of "-Wp,-E,-lang-asm" >>> >>> The AES acceleration is a configure option for the samba package. >>> >>> Apparently turning it on requires -Wp,-E,-lang-asm. >>> >>> which apparently gcc 4.2.1 has, but clang doesn't have. >>> >>>    FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based >>>    on LLVM 6.0.1) >>>    Target: x86_64-unknown-freebsd12.0 >>>    Thread model: posix >>>    InstalledDir: /usr/bin >>> >>> anyone know if there is a clang equivalent of -Wp, -E,-lang-asm? > > In later GCC versions the cpp's -lang-asm seems to be deprecated in > favor of -x assembler-with-cpp as it conflicts with -l option. > > Could you try changing the -Wp,-E,-lang-asm to -Wp,-E,-xassembler-with-cpp? Just tried it myself, and if you indeed mean the third_party/aesni-intel/aesni-intel_asm.c, the following seems to work for me: clang -xassembler-with-cpp -c third_party/aesni-intel/aesni-intel_asm.c >>> possible work arrounds include: >>> >>> 1/ Get gcc/lld to produce a library from which lld can find the symbols >>> >>> 2/ find a way to compile this with clang but everything else with gcc? >>> >>> 3/ find a way to allow clang to use >>> -Wp,-E,-lang-asm >>> >>> whatever that means >>> >>> >>> Thoughts from any tools people? From owner-freebsd-current@freebsd.org Sat Jul 21 20:32:55 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0162D102BD45 for ; Sat, 21 Jul 2018 20:32:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86C9176E1F; Sat, 21 Jul 2018 20:32:54 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 474903E946; Sat, 21 Jul 2018 22:32:53 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_D587C946-7DFB-45EE-ABE2-D5195FB547B8"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: gcc/clang interoperability problem with a custom "samba" build in recent -current. Date: Sat, 21 Jul 2018 22:32:49 +0200 In-Reply-To: <3dd60a0d-7a5e-e9f0-3018-d09b5b8ac389@yuripv.net> Cc: Julian Elischer , freebsd-current To: Yuri Pankov References: <3dd60a0d-7a5e-e9f0-3018-d09b5b8ac389@yuripv.net> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 20:32:55 -0000 --Apple-Mail=_D587C946-7DFB-45EE-ABE2-D5195FB547B8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 21 Jul 2018, at 21:11, Yuri Pankov wrote: >=20 > Yuri Pankov wrote: >> Julian Elischer wrote: ... >>>> anyone know if there is a clang equivalent of -Wp, -E,-lang-asm? >> In later GCC versions the cpp's -lang-asm seems to be deprecated in >> favor of -x assembler-with-cpp as it conflicts with -l option. >> Could you try changing the -Wp,-E,-lang-asm to = -Wp,-E,-xassembler-with-cpp? >=20 > Just tried it myself, and if you indeed mean the = third_party/aesni-intel/aesni-intel_asm.c, the following seems to work = for me: >=20 > clang -xassembler-with-cpp -c = third_party/aesni-intel/aesni-intel_asm.c Yes, that is exactly what I suggested to Julian on IRC. The point is that the ".c" extension is misleading, it should more likely be a ".S" extension. But maybe this source file is used for multiple purposes. Note that -x assembler-with-cpp should also work fine for gcc. -Dimitry --Apple-Mail=_D587C946-7DFB-45EE-ABE2-D5195FB547B8 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW1OYcQAKCRCwXqMKLiCW oxJBAKCOP+E/089rZVHE/wCWbR8aiOxLhACgybM3W388EkTQCV1qymf4vpzury4= =hotR -----END PGP SIGNATURE----- --Apple-Mail=_D587C946-7DFB-45EE-ABE2-D5195FB547B8-- From owner-freebsd-current@freebsd.org Sat Jul 21 22:09:12 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E658102DF90 for ; Sat, 21 Jul 2018 22:09:12 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (www.zefox.net [50.1.20.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "www.zefox.org", Issuer "www.zefox.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id CCBF079D56; Sat, 21 Jul 2018 22:09:11 +0000 (UTC) (envelope-from fbsd@www.zefox.net) Received: from www.zefox.net (localhost [127.0.0.1]) by www.zefox.net (8.15.2/8.15.2) with ESMTPS id w6LM9Qpj040994 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 21 Jul 2018 15:09:27 -0700 (PDT) (envelope-from fbsd@www.zefox.net) Received: (from fbsd@localhost) by www.zefox.net (8.15.2/8.15.2/Submit) id w6LM9QiM040993; Sat, 21 Jul 2018 15:09:26 -0700 (PDT) (envelope-from fbsd) Date: Sat, 21 Jul 2018 15:09:26 -0700 From: bob prohaska To: Ian Lepore Cc: Pete Wright , FreeBSD Current , bob prohaska Subject: Re: ntpd as ntpd user question Message-ID: <20180721220925.GA40238@www.zefox.net> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> <20180721174722.GA40167@www.zefox.net> <1532196850.1344.87.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532196850.1344.87.camel@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 22:09:12 -0000 On Sat, Jul 21, 2018 at 12:14:10PM -0600, Ian Lepore wrote: > > I can't see any way that installkernel would lead to the complaint > about the ntpd user not existing; that check is tied to the > installworld target. > My mistake. I was sleepy and in a hurry. The error message was in installworld and my attempt to adduser ntpd concluded with an error: Locked : yes OK? (yes/no): yes pw: Bad id 'ntpd': invalid adduser: ERROR: There was an error adding user (ntpd). On reboot the old ntpd set the clock and I thought all was well. The failure is a little surprising, is ntpd a reserved name? The machine is re-running buildworld/installworld from a clean start, so presumably it'll halt over the same error again. When that happens, what's the simplest way to recover? Mergemaster is a big hammer, something less comprehensive might suffice, even manual editing of files. There's minimal customization on the machine, basically /etc/fstab, /etc/rc.conf and /etc/passwd. Nothing else of real value, so if I kill it in the attempt it won't be a disaster. Thanks for waking me to my blunder... bob prohaska From owner-freebsd-current@freebsd.org Sat Jul 21 23:18:42 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77F37102F9EE for ; Sat, 21 Jul 2018 23:18:42 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 093B57BA8A for ; Sat, 21 Jul 2018 23:18:42 +0000 (UTC) (envelope-from kib@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B8916102F9EC; Sat, 21 Jul 2018 23:18:41 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A43B8102F9EB for ; Sat, 21 Jul 2018 23:18:41 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B4167BA88; Sat, 21 Jul 2018 23:18:40 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w6LNIWsL039227 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 22 Jul 2018 02:18:35 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w6LNIWsL039227 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w6LNIWxR039226; Sun, 22 Jul 2018 02:18:32 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Sun, 22 Jul 2018 02:18:32 +0300 From: Konstantin Belousov To: current@FreeBSD.org, br@freebsd.org Subject: Re: FreeBSD-head-riscv64-build - Build #9623 (r336573) - Failure Message-ID: <20180721231832.GC65334@kib.kiev.ua> References: <941706773.1.1532139392496.JavaMail.jenkins@jenkins.ci.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <941706773.1.1532139392496.JavaMail.jenkins@jenkins.ci.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 23:18:42 -0000 On Sat, Jul 21, 2018 at 02:16:17AM +0000, jenkins-admin@FreeBSD.org wrote: > --- lib/ofed/libmlx5__L --- > In file included from /workspace/src/contrib/ofed/libmlx5/mlx5.h:44:0, > from /workspace/src/contrib/ofed/libmlx5/buf.c:42: > /workspace/obj/workspace/src/riscv.riscv64/tmp/usr/include/infiniband/udma_barrier.h:108:2: error: #error No architecture specific memory barrier defines found! > #error No architecture specific memory barrier defines found! > ^~~~~ The patch below should be enough to fix the build, modulo the syntax errors which I cannot check. The reason is that it seems riscv is not cross-buildable from stable/11 host: --- includes_subdir_include/rpcsvc --- RPCGEN_CPP=cpp\ -target\ riscv64-unknown-freebsd12.0\ --sysroot=/usr/home/konstantinb/build/bsd/DEV/obj/usr/home/konstantinb/build/bsd/DEV/src/riscv.riscv64/tmp\ -B/usr/local rpcgen -C -h -DWANT_NFS3 /usr/home/konstantinb/build/bsd/DEV/src/include/rpcsvc/klm_prot.x -o klm_prot.h --- key_prot.h --- error: unknown target triple 'riscv64-unknown-freebsd12.0', please use -triple or -arch *** [key_prot.h] Error code 1 make[4]: stopped in /usr/home/konstantinb/build/bsd/DEV/src/include/rpcsvc So if somebody who care about riscv and can build the world could confirm the fix, I will commit it. diff --git a/contrib/ofed/include/udma_barrier.h b/contrib/ofed/include/udma_barrier.h index 71d264f8dce..6709d4433a7 100644 --- a/contrib/ofed/include/udma_barrier.h +++ b/contrib/ofed/include/udma_barrier.h @@ -104,6 +104,10 @@ #include #include #define udma_to_device_barrier() dmb() +#elif defined(__riscv__) +#include +#include +#define udma_to_device_barrier() fence() #else #error No architecture specific memory barrier defines found! #endif From owner-freebsd-current@freebsd.org Sat Jul 21 23:49:43 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4573103045F for ; Sat, 21 Jul 2018 23:49:43 +0000 (UTC) (envelope-from herbert@gojira.at) Received: from mail.bsd4all.net (mail.bsd4all.net [144.76.30.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.bsd4all.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 69ACC7CB25 for ; Sat, 21 Jul 2018 23:49:43 +0000 (UTC) (envelope-from herbert@gojira.at) Date: Sun, 22 Jul 2018 01:49:41 +0200 From: "Herbert J. Skuhra" To: freebsd-current@freebsd.org Subject: Re: ntpd as ntpd user question Message-ID: <20180721234941.2ojf76kxxqfhnys7@mail.bsd4all.net> References: <5b90c49f-4616-9ef7-28a1-6445137245ef@nomadlogic.org> <1532191655.1344.80.camel@freebsd.org> <4b7acbd2-0230-345c-4370-24a72d0b492a@nomadlogic.org> <1532193285.1344.83.camel@freebsd.org> <20180721174722.GA40167@www.zefox.net> <1532196850.1344.87.camel@freebsd.org> <20180721220925.GA40238@www.zefox.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180721220925.GA40238@www.zefox.net> User-Agent: NeoMutt/20180716 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2018 23:49:44 -0000 On Sat, Jul 21, 2018 at 03:09:26PM -0700, bob prohaska wrote: > On Sat, Jul 21, 2018 at 12:14:10PM -0600, Ian Lepore wrote: > > > > I can't see any way that installkernel would lead to the complaint > > about the ntpd user not existing; that check is tied to the > > installworld target. > > > My mistake. I was sleepy and in a hurry. The error message was in installworld > and my attempt to adduser ntpd concluded with an error: > Locked : yes > OK? (yes/no): yes > pw: Bad id 'ntpd': invalid > adduser: ERROR: There was an error adding user (ntpd). > On reboot the old ntpd set the clock and I thought all was well. > > The failure is a little surprising, is ntpd a reserved name? Why? You obviously entered the string "ntpd" instead of an integer when asked for the uid!? > The machine is re-running buildworld/installworld from a clean start, > so presumably it'll halt over the same error again. When that happens, > what's the simplest way to recover? Mergemaster is a big hammer, something > less comprehensive might suffice, even manual editing of files. In this case 'mergemaster -p' is enough. -- Herbert