From owner-freebsd-dtrace@freebsd.org Sun Jun 17 15:42:44 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0573710231FC for ; Sun, 17 Jun 2018 15:42:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8BF2A72BBA for ; Sun, 17 Jun 2018 15:42:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4B3F410231F9; Sun, 17 Jun 2018 15:42:43 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 39BE110231F8 for ; Sun, 17 Jun 2018 15:42:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CBCCF72BB3 for ; Sun, 17 Jun 2018 15:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C935816922 for ; Sun, 17 Jun 2018 15:42:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5HFgfBE069484 for ; Sun, 17 Jun 2018 15:42:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5HFgfCi069481 for dtrace@FreeBSD.org; Sun, 17 Jun 2018 15:42:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: dtrace@FreeBSD.org Subject: [Bug 224271] disable dtrace usdt on armv6, armv7 and aarch64 Date: Sun, 17 Jun 2018 15:42:41 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: mikael.urankar@gmail.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: linimon@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jun 2018 15:42:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224271 mikael.urankar@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188748|0 |1 is obsolete| | --- Comment #13 from mikael.urankar@gmail.com --- Created attachment 194336 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D194336&action= =3Dedit patch That's still an issue for: databases/libmemcached lang/erlang-runtime15 lang/erlang-runtime16 lang/php56 www/firefox www/node6 (only aarch64 is missing) --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-dtrace@freebsd.org Mon Jun 18 19:08:26 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CCE5B101ABBB for ; Mon, 18 Jun 2018 19:08:26 +0000 (UTC) (envelope-from dch@skunkwerks.at) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A80C6D1B2 for ; Mon, 18 Jun 2018 19:08:26 +0000 (UTC) (envelope-from dch@skunkwerks.at) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 7FD532203F for ; Mon, 18 Jun 2018 15:08:25 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute7.internal (MEProxy); Mon, 18 Jun 2018 15:08:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=skunkwerks.at; h=content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=o9VDK6ej9s3/mxdKICzSHLzG0POaTEvx1eCPUVasZJo=; b=mtWAeFF2 cN7rmsdyscy4LQad+DukHbhnD2//EHbkO7xaLdYl+ZG2yPbpcLURkpjrZZCjceAo hgn7gtPcHvUjzsdRAzOVbMrT/HT7va36dkyHttcZLPshD1ANDa+0b7cKh/krAtMK ZnK9892KhlJBTuAjR9rJpJKPfwD0bl80Kuar1KBhWVZ8KEIOZp/2N0u3L/sVG4Yg aHbwQuSlBulu3aL7m9I6Dd4L87Kyj9hAOEmAE7Lwdva4R5KkuJ00T87w1Tk0cwGs aRObrFOeOrx4npYPibtpSfpx8t6SeRLrVuCzyx/lEJMYMRsxDbo1E5H1mK1eXw5M DnFRnRv9WBqZOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=o9VDK6ej9s3/mxdKICzSHLzG0POaT Evx1eCPUVasZJo=; b=E/3nZYrtWsDhccaQmlglFjpHtQVeBce13xFAddEZrNt2R lvDIj4Ppk6keNhiw8gtbGRANlcyBBJj/I8HYCy4J4JjRG+xq5k65qR+ZXaJZxZ8c XcpxRXkItayaMIFKyMsAiF2uvbZKPY8AIj9CNfH3MZHgHGaEZAXH84+ad8f0s7ay We8zrT5dCEDv4m8VL53HU6S9QaBYOgPPtMn1Z5Y/pU0/ZvGFxSGPydLktECrVRkI XMwRXJ18P7Gw69CDQTaZZFv7WzZwHPWSXD4HRUnkA8EMBeDMACn3egFmD2s578GW RUv/Sbp+QAC66JV+gGoDyU1JKbWDqsWEie+yfzPfA== X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 40E2E410D; Mon, 18 Jun 2018 15:08:25 -0400 (EDT) Message-Id: <1529348905.2613088.1412091424.2D14994E@webmail.messagingengine.com> From: Dave Cottlehuber To: freebsd-dtrace@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-498d70f2 Subject: where did FreeBSD 11's syscall::lstat go? where do syscall probes get defined? Date: Mon, 18 Jun 2018 21:08:25 +0200 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 19:08:27 -0000 As a novice dtracer, I realised I don't know how dtrace probes for the base system are created, and why some syscalls seem to have probes and others don't. For example, 11.1 has syscall::lstat but 12.0 doesn't, although there is syscall::compat11.lstat, and syscall::stat has also disappeared. BTW I assume that this was related to the ino64 changes, where lib/libc/sys/stat.c and lstat.c were added: https://svnweb.freebsd.org/base?view=revision&revision=318736 But I don't see where the compat11 change was introduced. Can somebody enlighten me? http://dtrace.org/guide/chp-syscall.html#chp-syscall hasn't filled out the details, nor has the handbook. FWIW this is related to https://reviews.freebsd.org/D15879 where the changed probe list broke dtruss from sysutils/dtracetoolkit. A+ Dave From owner-freebsd-dtrace@freebsd.org Mon Jun 18 19:15:47 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 327A6101B296 for ; Mon, 18 Jun 2018 19:15:47 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-lf0-x229.google.com (mail-lf0-x229.google.com [IPv6:2a00:1450:4010:c07::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 956606D9A3 for ; Mon, 18 Jun 2018 19:15:46 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-lf0-x229.google.com with SMTP id i15-v6so26365178lfc.2 for ; Mon, 18 Jun 2018 12:15:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pycPcPpRGCbt1Zjy2xerjINXrO4CwU+FQ8eXEf4ot0g=; b=IYLLEn+hBt0Mtqfze9tNWStp57dj3VeSMrokwXnEndWcACCE3gO/XeeicJkLvxyKHD e/MH7ReL+tWS0mQiHyVAVNoq9HKo4dtBKu9wZUsOKlF8KD+x3o8p51TTggli0Zek6Sbv ozLbLbUWbv0DvsxqFbrcD7rcZ1FZTWRzZx+65GkqKNQoNDqHnmY7Gx04QfNBFCPRUrmd 9IPPVWdweWzN3ub8gIB9RL174N68hU4bLJVdeVZXJbvCmT7IFH+JvswacMd1friVXocu sGmXBhAbs25PB3/RmYBXDr6qmqrYcSc5wgcLNWp44Iw6A02kx3yBQR0Ji6s8YWEDyliS O23w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pycPcPpRGCbt1Zjy2xerjINXrO4CwU+FQ8eXEf4ot0g=; b=G+e/k/oHYz5vkNP0H9smxdbZLTfmjUxExRFV5oxNFExi4qZlq2Lq4Bew2nMHO9yorj ubig5FufzwMJJbQjj2ARkDbO+aCwZzGKpbxOQ/Uxi6mIs1vP0PAE1kPPVxFyQTtSj0tI ZFFbZ1G2ZuARvYD2Pzjx8exPeh1KlGez0kt0PD2oP8gpchsR99o/auYzGRe3T36BMZnG NlNw6O/P9or5PCzTtw430w59eReKpdijgBdYdUC/+0WHY3laA/y4h3z9tNYhrJPkvcbx 1PlB5BHgcT8lU654Rpf3oEZuW5L2qhpoubIiaANC3GYSC/53qijY8EoZjnm4sBfkdgkD hgJA== X-Gm-Message-State: APt69E2Veo02TRrUUdVsksvRulMx/Uo+7v3AH0IzHs76uml+0yIdpHqG FulunE0JPFqqbFMvZP7TlU36L7O2qiRP3inYuqY= X-Google-Smtp-Source: ADUXVKJ1olQmM9DKBIe9X8breindr2iC5ft8Hwn9j0FTjArwX/K3KP9UMQGU8NFdx38SGMlKgfQNwKCfoqzbcY92PTE= X-Received: by 2002:a19:b21c:: with SMTP id b28-v6mr6987046lff.20.1529349344463; Mon, 18 Jun 2018 12:15:44 -0700 (PDT) MIME-Version: 1.0 References: <1529348905.2613088.1412091424.2D14994E@webmail.messagingengine.com> In-Reply-To: <1529348905.2613088.1412091424.2D14994E@webmail.messagingengine.com> From: Ryan Stone Date: Mon, 18 Jun 2018 15:15:29 -0400 Message-ID: Subject: Re: where did FreeBSD 11's syscall::lstat go? where do syscall probes get defined? To: Dave Cottlehuber Cc: freebsd-dtrace@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 19:15:47 -0000 The syscall probes are automatically defined based off of the syscalls.master file. As a part of ino64, it seems that lstat() was retired as a system call. As you can see in lstat.c, lstat(3) is now implemented in terms of fstatat(2), so that's what new scripts should be used. You can also see that syscalls.master defines a compat11 version of lstat(), as this is necessary to maintain binary compatibility with pre-12.0 binaries. From owner-freebsd-dtrace@freebsd.org Mon Jun 18 21:18:08 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9664D1022BED for ; Mon, 18 Jun 2018 21:18:08 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 28D1173C7B for ; Mon, 18 Jun 2018 21:18:08 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D84721022BEC; Mon, 18 Jun 2018 21:18:07 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C698A1022BEB for ; Mon, 18 Jun 2018 21:18:07 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64D9773C7A for ; Mon, 18 Jun 2018 21:18:04 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2003:cd:6f3c:ba00:dd6f:25c3:cd1f:482e] (p200300CD6F3CBA00DD6F25C3CD1F482E.dip0.t-ipconnect.de [IPv6:2003:cd:6f3c:ba00:dd6f:25c3:cd1f:482e]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 1421072106C29 for ; Mon, 18 Jun 2018 23:17:56 +0200 (CEST) From: Michael Tuexen Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: receive probes Message-Id: Date: Mon, 18 Jun 2018 23:17:55 +0200 To: dtrace@freebsd.org X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 21:18:08 -0000 Dear all, when should receive probes for the TCP and UDP network provider fire? I would expect it to fire whenever a non-malformed packet is received. Is that the intention? Best regards Michael From owner-freebsd-dtrace@freebsd.org Mon Jun 18 23:43:05 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C4C31006502 for ; Mon, 18 Jun 2018 23:43:05 +0000 (UTC) (envelope-from ashfixit@gmail.com) Received: from mail-yw0-x22f.google.com (mail-yw0-x22f.google.com [IPv6:2607:f8b0:4002:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 123D77A258 for ; Mon, 18 Jun 2018 23:43:05 +0000 (UTC) (envelope-from ashfixit@gmail.com) Received: by mail-yw0-x22f.google.com with SMTP id p129-v6so6258862ywg.7 for ; Mon, 18 Jun 2018 16:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cGZ7sLsxVG8Ce/aGXWoPjqnUy0ATBbhu+XgdiHZDGa0=; b=KJd+6oO4Ku/kYQwu2BQFhUWhESmhKO1917NLmq1JY79Zbr0azevcAEv+lnrTNvgPaA d623a478OZk4LPnw83S3hnT8OBuKeYmr1pwKNnrwjh/ERQ3N+kJvoGdCMaSjQ68FQN6Z HFHM08a9lzdxPm2LBY/n6GawfkFn4CqGoC//kAVpCMHv3LONOMojiaIV7opWByohKMui hTyFO4B1lnM36Nb4LgSUZHRnJJu22OIleEIa03/f36CAtQnR87Q/KS37lhhDqfCTGvM4 ArOIcCHbPnPk4L2AhLMzpKX7zIKTBgzCoha/A/+A6bpIl0nPASZMY082W1ObLoLv/VXa bOuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cGZ7sLsxVG8Ce/aGXWoPjqnUy0ATBbhu+XgdiHZDGa0=; b=ub42azbAdjRS3GnkMMuZCt/GMRz92tW0Z4/g3etNVNCZ+Z7KUvZNUDxQTtmSfMGL6U wGZSo7le9X8cjckgpyHzEQ07xzCQ3GyfAAT5WlEYAO36CCp+5CzeQezuNNKAKOZXNAbJ DcHJK5xU5n2rsBzN7AfwzOtAVsUYObW6gC6mAx7Cqzb3n30i0EWNvMLnEF5oeSWmJYbX lg3ZFhkSxccpXG4E4lhstPNalC38cCkm/oZj1rzwuumcqRc+OYiTI1ZOZ2yFhc+fTgX3 I8/6DnHqWPUJqlVB6F37vmx6IQTusM7lTECt/H4nxe+q9Cj910yPPxbE+qSMk6oBXRoL 6qRA== X-Gm-Message-State: APt69E2CyuSRsVeGHRgVMDwcSjxXBQD+J4R1hab1nmIr0yuRYcATTn4k TkrPKcXJss+LWAUr18/5BukBWnQ/8msInFl/cfEAaA== X-Google-Smtp-Source: ADUXVKIDLW9CPRNZZv1vrXhipH/ejL3+YPqUj+/DRtpe8VABInEKfCetfBSpeSlbxXEBvYOkPiLWR3M5y26ojTdeoOA= X-Received: by 2002:a81:f95:: with SMTP id 143-v6mr7097296ywp.93.1529365383881; Mon, 18 Jun 2018 16:43:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a0d:d7c9:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 16:43:03 -0700 (PDT) In-Reply-To: References: <1529348905.2613088.1412091424.2D14994E@webmail.messagingengine.com> From: Ash Gokhale Date: Mon, 18 Jun 2018 19:43:03 -0400 Message-ID: Subject: Re: where did FreeBSD 11's syscall::lstat go? where do syscall probes get defined? To: Ryan Stone Cc: Dave Cottlehuber , freebsd-dtrace@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 23:43:05 -0000 On Mon, Jun 18, 2018 at 3:15 PM, Ryan Stone wrote: > The syscall probes are automatically defined based off of the > syscalls.master file. As a part of ino64, it seems that lstat() was > retired as a system call. As you can see in lstat.c, lstat(3) is now > implemented in terms of fstatat(2), so that's what new scripts should > be used. > > You can also see that syscalls.master defines a compat11 version of > lstat(), as this is necessary to maintain binary compatibility with > pre-12.0 binaries. > _______________________________________________ > freebsd-dtrace@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace > To unsubscribe, send any mail to "freebsd-dtrace-unsubscribe@freebsd.org" > Looks like lstat probe can hit as part of libc, pid provider, But unfortunately now you need to pretarget a process . #dtrace -p `pgrep foo` -ln 'pid$target::lstat*:entry { }' ID PROVIDER MODULE FUNCTION NAME 57364 pid33074 libc.so.7 lstat entry To understand the rework; grab all the syscalls and look for patterns that explain the program behaviour. syscall:::entry /execname =="wahtever"/ { @[probefunc]=count () ;}' This is an example of the principle that dtrace scripts are bespoke; writing them to be portable is not generally easy. The notion of probe stability classes attempts to answer for the need for durable interfaces, but automatically generated probes are going to fool us. From owner-freebsd-dtrace@freebsd.org Tue Jun 19 00:37:57 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA24210096E5 for ; Tue, 19 Jun 2018 00:37:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 610937C1B7 for ; Tue, 19 Jun 2018 00:37:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2500F10096E0; Tue, 19 Jun 2018 00:37:57 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0131810096DF for ; Tue, 19 Jun 2018 00:37:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D41C7C1AE for ; Tue, 19 Jun 2018 00:37:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C9EA227CE5 for ; Tue, 19 Jun 2018 00:37:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5J0btrK068788 for ; Tue, 19 Jun 2018 00:37:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5J0bt2H068787 for dtrace@FreeBSD.org; Tue, 19 Jun 2018 00:37:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: dtrace@FreeBSD.org Subject: [Bug 227850] www/firefox: update to 61.0 Date: Tue, 19 Jun 2018 00:37:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 00:37:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227850 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: jbeich Date: Tue Jun 19 00:37:46 UTC 2018 New revision: 472727 URL: https://svnweb.freebsd.org/changeset/ports/472727 Log: www/firefox: update to 61.0 - Drop DTRACE option, as it no longer builds https://bugzilla.mozilla.org/show_bug.cgi?id=3D1448659 https://bugzilla.mozilla.org/show_bug.cgi?id=3D702179#c33 - Stop using system hunspell per https://bugzilla.mozilla.org/show_bug.cgi?id=3D1460600 Changes: https://www.mozilla.org/firefox/61.0/releasenotes/ PR: 227850 Security: cd81806c-26e7-4d4a-8425-02724a2f48af MFH: 2018Q2 Differential Revision: https://reviews.freebsd.org/D15227 Changes: head/Mk/Uses/gecko.mk head/Mk/bsd.gecko.mk head/www/firefox/Makefile head/www/firefox/distinfo head/www/firefox/files/patch-addon-search head/www/firefox/files/patch-bug1021761 head/www/firefox/files/patch-bug1375074 head/www/firefox/files/patch-bug1411481 head/www/firefox/files/patch-bug1435212 head/www/firefox/files/patch-bug1438678 head/www/firefox/files/patch-bug1442583 head/www/firefox/files/patch-bug1444798 head/www/firefox/files/patch-bug1445907 head/www/firefox/files/patch-bug1447359 head/www/firefox/files/patch-bug1451292 head/www/firefox/files/patch-bug1456556 head/www/firefox/files/patch-bug702179 head/www/firefox/files/patch-dom_media_flac_FlacDecoder.cpp head/www/firefox/files/patch-u2f-hid-rs62 head/www/firefox/files/patch-z-bug1436911 head/www/firefox/files/patch-z-bug517422 head/www/firefox-i18n/Makefile head/www/firefox-i18n/distinfo --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-dtrace@freebsd.org Tue Jun 19 23:24:19 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FF1410154EC for ; Tue, 19 Jun 2018 23:24:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 345E17AB85 for ; Tue, 19 Jun 2018 23:24:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E644310154E5; Tue, 19 Jun 2018 23:24:18 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D40D710154E3 for ; Tue, 19 Jun 2018 23:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 720AA7AB81 for ; Tue, 19 Jun 2018 23:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id AEB0713EFC for ; Tue, 19 Jun 2018 23:24:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5JNOHEO018455 for ; Tue, 19 Jun 2018 23:24:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5JNOHbl018454 for dtrace@FreeBSD.org; Tue, 19 Jun 2018 23:24:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: dtrace@FreeBSD.org Subject: [Bug 227850] www/firefox: update to 61.0 Date: Tue, 19 Jun 2018 23:24:16 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gecko@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: blocked Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jun 2018 23:24:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227850 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |229168 Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229168 [Bug 229168] www/firefox: update to 62.0 --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-dtrace@freebsd.org Sat Jun 23 09:22:28 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2105E1019352 for ; Sat, 23 Jun 2018 09:22:28 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B73917B6B4 for ; Sat, 23 Jun 2018 09:22:27 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7A1921019351; Sat, 23 Jun 2018 09:22:27 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 689D01019350 for ; Sat, 23 Jun 2018 09:22:27 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [IPv6:2001:4b98:dc4:8:216:3eff:fe62:3650]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CDBD67B6B0; Sat, 23 Jun 2018 09:22:26 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from [10.0.1.2] (114-36-115-202.dynamic-ip.hinet.net [114.36.115.202]) (Authenticated sender: gnn@neville-neil.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 58C4724000D; Sat, 23 Jun 2018 09:22:16 +0000 (UTC) From: "George Neville-Neil" To: "Michael Tuexen" Cc: dtrace@freebsd.org Subject: Re: receive probes Date: Sat, 23 Jun 2018 17:21:32 +0800 X-Mailer: MailMate (1.11.2r5479) Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Spam-Level: X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 09:22:28 -0000 On 19 Jun 2018, at 5:17, Michael Tuexen wrote: > Dear all, > > when should receive probes for the TCP and UDP network provider fire? > > I would expect it to fire whenever a non-malformed packet is received. > Is that the intention? > Of the appropriate type of course, but yes. Best,. George From owner-freebsd-dtrace@freebsd.org Sat Jun 23 11:17:34 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00E19101CC0F for ; Sat, 23 Jun 2018 11:17:34 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 65A787E910 for ; Sat, 23 Jun 2018 11:17:33 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 29788101CC0E; Sat, 23 Jun 2018 11:17:33 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1574E101CC0C for ; Sat, 23 Jun 2018 11:17:33 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 93FCA7E90F for ; Sat, 23 Jun 2018 11:17:32 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2003:cd:6f20:4400:3d4a:dbbe:9e48:43bb] (p200300CD6F2044003D4ADBBE9E4843BB.dip0.t-ipconnect.de [IPv6:2003:cd:6f20:4400:3d4a:dbbe:9e48:43bb]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 3A15B721E2825; Sat, 23 Jun 2018 13:17:29 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: receive probes From: Michael Tuexen In-Reply-To: Date: Sat, 23 Jun 2018 13:17:28 +0200 Cc: dtrace@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: To: George Neville-Neil X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 11:17:34 -0000 > On 23. Jun 2018, at 11:21, George Neville-Neil = wrote: >=20 >=20 >=20 > On 19 Jun 2018, at 5:17, Michael Tuexen wrote: >=20 >> Dear all, >>=20 >> when should receive probes for the TCP and UDP network provider fire? >>=20 >> I would expect it to fire whenever a non-malformed packet is = received. >> Is that the intention? >>=20 >=20 > Of the appropriate type of course, but yes. OK. Let me propose a patch for UDP and TCP and put them on = Phabricator... Best regards Michael >=20 > Best,. > George From owner-freebsd-dtrace@freebsd.org Sat Jun 23 11:29:33 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD0F8101D11F for ; Sat, 23 Jun 2018 11:29:33 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 770907F23F for ; Sat, 23 Jun 2018 11:29:33 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: by mailman.ysv.freebsd.org (Postfix) id 30FD9101D11C; Sat, 23 Jun 2018 11:29:33 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E977101D11B for ; Sat, 23 Jun 2018 11:29:33 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A5D57F23C; Sat, 23 Jun 2018 11:29:32 +0000 (UTC) (envelope-from gnn@neville-neil.com) X-Originating-IP: 114.36.115.202 Received: from [10.0.1.2] (114-36-115-202.dynamic-ip.hinet.net [114.36.115.202]) (Authenticated sender: gnn@neville-neil.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id C24861C0004; Sat, 23 Jun 2018 11:29:23 +0000 (UTC) From: "George Neville-Neil" To: "Michael Tuexen" Cc: dtrace@freebsd.org Subject: Re: receive probes Date: Sat, 23 Jun 2018 19:28:38 +0800 X-Mailer: MailMate (1.11.2r5479) Message-ID: <88747828-2ECD-42A1-BB41-6108F37146DE@neville-neil.com> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Level: X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 11:29:34 -0000 On 23 Jun 2018, at 19:17, Michael Tuexen wrote: >> On 23. Jun 2018, at 11:21, George Neville-Neil >> wrote: >> >> >> >> On 19 Jun 2018, at 5:17, Michael Tuexen wrote: >> >>> Dear all, >>> >>> when should receive probes for the TCP and UDP network provider >>> fire? >>> >>> I would expect it to fire whenever a non-malformed packet is >>> received. >>> Is that the intention? >>> >> >> Of the appropriate type of course, but yes. > OK. Let me propose a patch for UDP and TCP and put them on > Phabricator... > I'm wondering what you're seeing that you think needs patching. Best,. George From owner-freebsd-dtrace@freebsd.org Sat Jun 23 11:57:27 2018 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF9B7101DD2C for ; Sat, 23 Jun 2018 11:57:26 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 702E07FDB5 for ; Sat, 23 Jun 2018 11:57:26 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 30F21101DD2A; Sat, 23 Jun 2018 11:57:26 +0000 (UTC) Delivered-To: dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E8BF101DD29 for ; Sat, 23 Jun 2018 11:57:26 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9125B7FDA6 for ; Sat, 23 Jun 2018 11:57:25 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2003:cd:6f20:4400:3d4a:dbbe:9e48:43bb] (p200300CD6F2044003D4ADBBE9E4843BB.dip0.t-ipconnect.de [IPv6:2003:cd:6f20:4400:3d4a:dbbe:9e48:43bb]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 9B93F721E2825; Sat, 23 Jun 2018 13:57:23 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: receive probes From: Michael Tuexen In-Reply-To: <88747828-2ECD-42A1-BB41-6108F37146DE@neville-neil.com> Date: Sat, 23 Jun 2018 13:57:22 +0200 Cc: dtrace@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4388B5A4-95EF-49E7-817E-E36B3E8E7CD4@freebsd.org> References: <88747828-2ECD-42A1-BB41-6108F37146DE@neville-neil.com> To: George Neville-Neil X-Mailer: Apple Mail (2.3445.8.2) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jun 2018 11:57:27 -0000 > On 23. Jun 2018, at 13:28, George Neville-Neil = wrote: >=20 >=20 >=20 > On 23 Jun 2018, at 19:17, Michael Tuexen wrote: >=20 >>> On 23. Jun 2018, at 11:21, George Neville-Neil = wrote: >>>=20 >>>=20 >>>=20 >>> On 19 Jun 2018, at 5:17, Michael Tuexen wrote: >>>=20 >>>> Dear all, >>>>=20 >>>> when should receive probes for the TCP and UDP network provider = fire? >>>>=20 >>>> I would expect it to fire whenever a non-malformed packet is = received. >>>> Is that the intention? >>>>=20 >>>=20 >>> Of the appropriate type of course, but yes. >> OK. Let me propose a patch for UDP and TCP and put them on = Phabricator... >>=20 >=20 > I'm wondering what you're seeing that you think needs patching. I found two things via testing to understand how things work: 1. The UDP receive provider only fires if udp_append() is called. So it does not fire, if a UDP packet is received and there is no endpoint handlign the data (in which you send out an ICMP packet indicating that the destination is unreachable because the port is unreachable). If the semantic is that the provider should fire if a packet is received it should fire. If the semantic is that the provider fires if data can be delivered to the user, it should not. But the TCP provider also fires for packets without user data, I = think the UDP provider should fire whenever a UDP packet is received. There are a couple of error cases: * We can't get the IP and UDP header in an mbuf. -> Don't fire. * Destination port is 0. -> Don't fire. * Length violation -> Don't fire. * Checksum error -> Don't fire. * In case of multicast and no enp-point point found -> Fire (needs a = fix) * In case of unicast and no end-point found -> Fire (needs a fix) * In case min TTL violated -> Fire (needs a fix) or not Fire? * In checksum coverage insufficient -> Don't fire While being there, separate out UDP and UDPLite, since they are = different protocols. So provide a UDPLite provider. 2. This is what I get when setting up and tearing down a TCP connection over lookback and using the tcpio.d script: 0 127.0.0.1:17024 -> 127.0.0.1:1234 38 (SYN) 3 127.0.0.1:17024 <- 127.0.0.1:1234 38 (SYN|ACK) 3 127.0.0.1:17024 -> 127.0.0.1:1234 30 (ACK) 5 127.0.0.1:17024 -> 127.0.0.1:1234 34 (PUSH|ACK) 0 127.0.0.1:1234 <- 127.0.0.1:17024 34 (PUSH|ACK) 1 127.0.0.1:1234 -> 127.0.0.1:17024 30 (ACK) 4 127.0.0.1:17024 <- 127.0.0.1:1234 30 (ACK) 5 127.0.0.1:17024 -> 127.0.0.1:1234 30 (FIN|ACK) 1 127.0.0.1:1234 <- 127.0.0.1:17024 30 (FIN|ACK) 1 127.0.0.1:1234 -> 127.0.0.1:17024 30 (ACK) 1 127.0.0.1:17024 <- 127.0.0.1:1234 30 (ACK) 2 127.0.0.1:1234 -> 127.0.0.1:17024 30 (FIN|ACK) 1 127.0.0.1:17024 <- 127.0.0.1:1234 30 (FIN|ACK) 1 127.0.0.1:1234 <- 127.0.0.1:17024 30 (ACK) The issues I see: * The initial SYN is not reported to be received. * The SYN|ACK is not show as being sent. * The ACK (third message of the handshake) is not reported to be = received. I guess this is related to the fact that within the TCP syn-cache = code no providers are triggered. * Also the last ACK is not reported to be sent. I would expected all of the above segments to be reported as sent and = received. Do you agree with the above expectations on the behaviour? Best regards Michael >=20 > Best,. > George