From owner-freebsd-stable@freebsd.org Sun Mar 4 05:48:11 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1419BF36FC3 for ; Sun, 4 Mar 2018 05:48:11 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660064.outbound.protection.outlook.com [40.107.66.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EC376AD15 for ; Sun, 4 Mar 2018 05:48:09 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM (52.132.66.153) by YQBPR0101MB1044.CANPRD01.PROD.OUTLOOK.COM (52.132.66.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Sun, 4 Mar 2018 05:48:08 +0000 Received: from YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::3531:c817:d6f:9b93]) by YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM ([fe80::3531:c817:d6f:9b93%13]) with mapi id 15.20.0548.014; Sun, 4 Mar 2018 05:48:08 +0000 From: Rick Macklem To: NAGY Andreas , "freebsd-stable@freebsd.org" Subject: =?iso-8859-1?Q?Re:_NFS_4.1_RECLAIM=5FCOMPLETE_FS=A0failed_error_in_combin?= =?iso-8859-1?Q?ation_with_ESXi_client?= Thread-Topic: =?iso-8859-1?Q?NFS_4.1_RECLAIM=5FCOMPLETE_FS=A0failed_error_in_combinatio?= =?iso-8859-1?Q?n_with_ESXi_client?= Thread-Index: AdOx8zAe5+TceuOWQkax+IhJZhNDgQAnzopHABn27/AAIBzCQg== Date: Sun, 4 Mar 2018 05:48:08 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YQBPR0101MB1044; 6:0MJ2JXGhOvjJ+o56bSeLsNSMVq4ewOm7HeVYbqSanKEISe+mxT/EMZHe/b/qSKi5y4yHS5D12zNuc30IIYMonQt6BB3LUEjksGS4vJvgVSFQOg71cal6nZ5iQQtUs5JcaEzjSp/jCXy1pINZSA4oAnKUOlPTzAEXY8PL6+rSKO+97jjjtU1vwlwt18mZlt554/OAJFvNFYGEOjWgLAFHxf2PhRgTOFXT3QD2QROsVE1lFWNapZ0fzGJTiYHmSnkIArd7b0yDSuU67ZTB7Iysuj8xYRmvrC4IkVHEVF8qxg0wES8QuQcNyRc+NiQsA7M0aBOW7bpAtE1jsBNCBuc2acxIb1HGqBsJ7s4n2mgwwYRbuRWIIF8XCI3d2FSX/yUE; 5:zdBNpfQlpe08PmfqaNUbZi2KhmO9v5+Y5KLtev9TgDlT79ykMTxNVB0wuj25xT/KlZWESJvqu6cPVpvjurbkpc2VM8IlcknjRSaPHuHXMiYlO6E1bB98ULiWUEr+WBvZiDsdv/RFr3HpEZTyJplitawThIe9LFYoZNNR63xbIDA=; 24:QtTTemXLaZ+1HqVrL9mPrBP+o/qk1JnHo0mG3YqDZg6K0I5aV0KX50clB1YfD3Bm86LOD1YHaKMfT9r0w4/c4z/c/GQB6ELTJ//T3QAyKrI=; 7:mFnuRk26KwX37+5xWRjoFle+Sen/Ue5fBjj2D3P/EkSvs+eOHmTt42TUOCPjlcxvQ2gzb6m1XpmsyStzDJDg9RmDutWuLucQvWkBQMtTgEHkKg5SnGhi7WrOVvdbvbeNqujahx+H4PK4fNvS0hN7egYdFA4TNbT1xMZI1haxKp19pZi0YFLFuoR/Edxj/8fvV6sxBPDy3BntYJgapGJ3dT+SC1qIDOYBdeeXjoTc0fA/SFe8zLLTRlJnREU1sJms x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 903119f5-68de-4591-f6b0-08d581938215 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(8989060)(4534165)(4627221)(201703031133081)(201702281549075)(8990040)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:YQBPR0101MB1044; x-ms-traffictypediagnostic: YQBPR0101MB1044: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(6041288)(20161123562045)(20161123560045)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:YQBPR0101MB1044; BCL:0; PCL:0; RULEID:; SRVR:YQBPR0101MB1044; x-forefront-prvs: 060166847D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39380400002)(376002)(396003)(39860400002)(366004)(189003)(377424004)(199004)(106356001)(6246003)(25786009)(305945005)(14454004)(74316002)(186003)(97736004)(105586002)(3660700001)(81166006)(81156014)(6436002)(8936002)(74482002)(68736007)(2900100001)(33656002)(3280700002)(55016002)(478600001)(6306002)(9686003)(86362001)(6506007)(76176011)(2950100002)(2906002)(966005)(99286004)(26005)(229853002)(102836004)(5250100002)(7696005)(316002)(2501003)(5660300001)(786003)(53936002)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:YQBPR0101MB1044; H:YQBPR0101MB1042.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8it4Jrw4oK8dWJQV54orYLWm34oPi0U5WrsFhlX7XC3wQZh8Go7y9+VGNeuQII0QjcbYy3QZTyfDdDEHLRM2ZuQGDVvXHVYC0/oN0EOSAebIaiea5w0Re5NQJM9QcbpSaLZ777YosiL83RaGmnvb9KwLV8D8Iy42jlFF4UWvsd689vOaQ24zWyrKhVRtrtQKs8YzXEbX0Yu/c4H5ytV3Ld6sYo7G4TS05FFLGZATRwRJpXTF+Mymvzyz9lsq2nXLC1IiSD9bZWOTp9FPvzvYSEqncaL4qvE5yDDlh5bMHljZ0t+6kH6ONIITHZLiAZgwsFnLLoN3Xq4N4pX3M9mexg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 903119f5-68de-4591-f6b0-08d581938215 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2018 05:48:08.4665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB1044 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Mar 2018 05:48:11 -0000 NAGY Andreas wrote: >Hi and thanks! > >First time using/needing a patch could you give me a short advise how to u= se it >and for which version? The only difference with kernel versions will be the line#s. >So far I have made a fresh FreeBSD 11.1 RELEASE install as a VM on a ESXi = host >updated the system and did a svn checkout http://svn.freebsd.org/base= /release/11.1.0/ > >Then tried to apply the patch in /usr/src/sys via patch < /tmp/reclaimcom2= .patch > >Output was: >Hmm... Looks like a unified diff to me... >The text leading up to this was: >-------------------------- >|--- fs/nfsserver/nfs_nfsdserv.c.savrecl 2018-02-10 20:34:31.166445= 000 -0500 >|+++ fs/nfsserver/nfs_nfsdserv.c 2018-02-10 20:36:07.947490000 -050= 0 >-------------------------- >Patching file fs/nfsserver/nfs_nfsdserv.c using Plan A... >No such line 4225 in input file, ignoring >Hunk #1 succeeded at 4019 (offset -207 lines). >done Since it says "Hunk #1 succeeded...", I think it patched ok. However, you can check by looking at nfsrvd_reclaimcomplete() in sys/fs/nfsserver/nfs_nfsdserv.c. Before the patch it would look like: if (*tl =3D=3D newnfs_true) nd->nd_repstat =3D NFSERR_NOTSUPP; else nd->nd_repstat =3D nfsrv_checkreclaimcomplete(nd); whereas after being patched, it will look like: nd->nd_repstat =3D nfsrv_checkreclaimcomplete(nd); if (*tl =3D=3D newnfs_true) nd->nd_repstat =3D 0; rick [stuff snipped]=