Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Feb 2018 16:59:31 -0800
From:      Eitan Adler <lists@eitanadler.com>
To:        cem@freebsd.org
Cc:        FreeBSD Hackers <freebsd-hackers@freebsd.org>,  FreeBSD Standards <freebsd-standards@freebsd.org>
Subject:   Re: Marking select(2) as restrict
Message-ID:  <CAF6rxgnOEegTYc0_Yi-wA7KR4wEjQAAuWAppdsKF6eQXEC4bew@mail.gmail.com>
In-Reply-To: <CAG6CVpV-YBfGsh5zDRuB7N43N4FW5X69BDyi_XF21fs7tOr5JQ@mail.gmail.com>
References:  <20180221032247.GA81670@ns.kevlo.org> <CAF6rxg=WwqeBnmJzfOZgtwrYesXPfvJFeaVmQwtTa_89_sxaJg@mail.gmail.com> <CANCZdfo46bhfaRpbqOmJjk4%2B=1R2c5kvmrJPENaxNgK==5M4kg@mail.gmail.com> <CAF6rxg=wNVgDUF9o744ngmzPNeHB3hqdrLufy=yS3D4osczxFQ@mail.gmail.com> <20180221104400.GU94212@kib.kiev.ua> <23181.46427.671514.319710@khavrinen.csail.mit.edu> <20180221185920.GA94212@kib.kiev.ua> <23181.50488.186767.579361@khavrinen.csail.mit.edu> <20180221201002.GC94212@kib.kiev.ua> <23181.54825.511195.393054@khavrinen.csail.mit.edu> <20180222212746.GB58772@stack.nl> <CAF6rxgkW=Fgh4%2B1-aJG=VUCYso9gcKnER17UOiBy8GtTMsJNYQ@mail.gmail.com> <CAF6rxg=-nBz8caa1Wn1Labn3DydpEO6B8W9PaLhNKYFwGvuZxw@mail.gmail.com> <CAG6CVpV-YBfGsh5zDRuB7N43N4FW5X69BDyi_XF21fs7tOr5JQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 24 February 2018 at 10:55, Conrad Meyer <cem@freebsd.org> wrote:
> On Sat, Feb 24, 2018 at 10:35 AM, Eitan Adler <lists@eitanadler.com> wrote:
>> After this entire thread here is the summary. If I've misrepresented
>> you here please let me know.
>> ...
>>
>> kib@ - no benefit; concerned fallout could be hard to observe
>> cem@ - concerned about warnings
>
> Consider me a +1 to kib@.  I did not voice those concerns explicitly
> in earlier email because kib did already and I didn't anticipate you
> would ignore him.

I am not ignoring him. As I stated above I do not believe fallout is
likely since most other major libc implementations have already done
this:

glibc: already done -
https://github.com/bminor/glibc/blob/master/misc/sys/select.h#L101
openbsd: already done
https://github.com/openbsd/src/blob/master/sys/sys/select.h#L128
dragonflyBSD: alredy done:
https://github.com/dragonflybsd/dragonflybsd/blob/master/sys/sys/select.h#L50
netbsd: already done:
https://github.com/NetBSD/src/blob/trunk/sys/sys/select.h#L69

As a further check I went through the search results on github for
select() and did not see any failures in the top few pages.

-- 
Eitan Adler



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnOEegTYc0_Yi-wA7KR4wEjQAAuWAppdsKF6eQXEC4bew>