From owner-svn-src-user@freebsd.org Sun Jul 1 00:07:42 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B91FFDFD1B for ; Sun, 1 Jul 2018 00:07:42 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E0BC69155C; Sun, 1 Jul 2018 00:07:41 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id BC9F817012; Sun, 1 Jul 2018 00:07:41 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w6107fGm072007; Sun, 1 Jul 2018 00:07:41 GMT (envelope-from cperciva@FreeBSD.org) Received: (from cperciva@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w6107fr3072006; Sun, 1 Jul 2018 00:07:41 GMT (envelope-from cperciva@FreeBSD.org) Message-Id: <201807010007.w6107fr3072006@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: cperciva set sender to cperciva@FreeBSD.org using -f From: Colin Percival Date: Sun, 1 Jul 2018 00:07:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r335829 - user/cperciva/panicmail X-SVN-Group: user X-SVN-Commit-Author: cperciva X-SVN-Commit-Paths: user/cperciva/panicmail X-SVN-Commit-Revision: 335829 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 00:07:42 -0000 Author: cperciva Date: Sun Jul 1 00:07:41 2018 New Revision: 335829 URL: https://svnweb.freebsd.org/changeset/base/335829 Log: Add /usr/local/bin to $PATH so that panicmail can use gdb from ports. Submitted by: sbruno Modified: user/cperciva/panicmail/panicmail Modified: user/cperciva/panicmail/panicmail ============================================================================== --- user/cperciva/panicmail/panicmail Sat Jun 30 21:36:35 2018 (r335828) +++ user/cperciva/panicmail/panicmail Sun Jul 1 00:07:41 2018 (r335829) @@ -60,6 +60,9 @@ rcvar="panicmail_enable" start_cmd="panicmail_run" stop_cmd=":" +# On HEAD, gdb will be installed from ports +PATH=${PATH}:/usr/local/bin + # Gather the data we want to include in a panic report. panicmail_gather() { From owner-svn-src-user@freebsd.org Mon Jul 2 16:06:00 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B2E4102DF65 for ; Mon, 2 Jul 2018 16:06:00 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B4F418EDFF; Mon, 2 Jul 2018 16:05:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 9C16110A87D; Mon, 2 Jul 2018 12:05:55 -0400 (EDT) Subject: Re: svn commit: r335829 - user/cperciva/panicmail To: Colin Percival , src-committers@freebsd.org, svn-src-user@freebsd.org References: <201807010007.w6107fr3072006@repo.freebsd.org> From: John Baldwin Message-ID: <575515de-523d-e0eb-ecc8-1aa517f5f34c@FreeBSD.org> Date: Mon, 2 Jul 2018 09:05:55 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807010007.w6107fr3072006@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 02 Jul 2018 12:05:56 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 16:06:00 -0000 On 6/30/18 5:07 PM, Colin Percival wrote: > Author: cperciva > Date: Sun Jul 1 00:07:41 2018 > New Revision: 335829 > URL: https://svnweb.freebsd.org/changeset/base/335829 > > Log: > Add /usr/local/bin to $PATH so that panicmail can use gdb from ports. > > Submitted by: sbruno If gdb from ports isn't installed, the old gdb will be present in /usr/libexec if it isn't present in /usr/bin. At some point /usr/libexec/gdb might go away, but it is present there for now. The crashinfo script prefers gdb from /usr/local/bin and falls back to /usr/libexec or /usr/bin. -- John Baldwin From owner-svn-src-user@freebsd.org Mon Jul 2 16:32:47 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA806102EB33 for ; Mon, 2 Jul 2018 16:32:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2CC5C8FF5E; Mon, 2 Jul 2018 16:32:47 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w62GWj3u034535; Mon, 2 Jul 2018 09:32:45 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w62GWjme034534; Mon, 2 Jul 2018 09:32:45 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201807021632.w62GWjme034534@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r335829 - user/cperciva/panicmail In-Reply-To: <575515de-523d-e0eb-ecc8-1aa517f5f34c@FreeBSD.org> To: John Baldwin Date: Mon, 2 Jul 2018 09:32:45 -0700 (PDT) CC: Colin Percival , src-committers@freebsd.org, svn-src-user@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 16:32:47 -0000 [ Charset UTF-8 unsupported, converting... ] > On 6/30/18 5:07 PM, Colin Percival wrote: > > Author: cperciva > > Date: Sun Jul 1 00:07:41 2018 > > New Revision: 335829 > > URL: https://svnweb.freebsd.org/changeset/base/335829 > > > > Log: > > Add /usr/local/bin to $PATH so that panicmail can use gdb from ports. > > > > Submitted by: sbruno > > If gdb from ports isn't installed, the old gdb will be present in /usr/libexec > if it isn't present in /usr/bin. At some point /usr/libexec/gdb might go away, > but it is present there for now. The crashinfo script prefers gdb from > /usr/local/bin and falls back to /usr/libexec or /usr/bin. Um, one is makeing an assumption even using /usr/local, our ports/pacakge system has allowed this to be some other place for over 2 decades. At one point all of base was irreadicated of /usr/local references, it is a mistake to be putting any back. -- Rod Grimes rgrimes@freebsd.org From owner-svn-src-user@freebsd.org Mon Jul 2 16:39:56 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C1E1102ED3E for ; Mon, 2 Jul 2018 16:39:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BF06A70170 for ; Mon, 2 Jul 2018 16:39:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x236.google.com with SMTP id a195-v6so12983384itd.3 for ; Mon, 02 Jul 2018 09:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5qmphCw76vAdq26KfgM8QJs8awNx2uFOmllRbrx62ZY=; b=qIJNOLN00ant+SM93sB4e1KYBGHfgzYsDMqn4wMeX+jCUipOohTx8Ugpolw6u5nqYU zNKqzdeWYO139zGw7xBs23SwmN8udOKORVVAtCdlbvYuIH5WtPJfBEQNIUiuUklnRzFr rgzVqWz9wF66PsJ8B+ADmOiDzlOHnz7tlgl33R4rsvy7BY0YHqHNwWPIp+3k1zLD1KDX /keIaF6fuIKj+GRMFwahShmRPShZYR2fK7ggIkvpNAFS1BdG6BGjuWR+VEo8gDiO65LR 5eCdqIeCo4T9IIN3QZ2VrgeXnh+clRX5m1ficEA2s0Im7p6vcTMZ5/1xyuYvDQc08g6K f/5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5qmphCw76vAdq26KfgM8QJs8awNx2uFOmllRbrx62ZY=; b=tJuzdszoYYsfQTNGPp/cfufELpO78q4NFe5Xi43R/cIoMP/49W5i0sLfPLJSUzZTN1 NjCNv0ruzu+75kH8+URHiO1KDak0+CubQKD9qTSvpiIAbtdrGihqB2kSoN/7XEA8qID6 mVjiZxK2kAsf2/UtbH07SdM6n8bvN5Jb8qILpEemwl/lvzQVeSGN2XjlNuqWWiMLi6V8 +vYpUfi0lR5Lz1JDpeCybFyQ6rI53ModaJX+TAg1X07XDy0cfonHfme8xZcmOjCFWCQP yFjizuhAL/aFs4IQ1FFTrJ/bk+sYJNwYgwvVFWXKJ/OolkcGDN6QcshJyq4JasKuWIjk CMzQ== X-Gm-Message-State: APt69E0t86jhTXZPdHN+jdjRDksocD58fhu3dOnlu1y+ApNa3t/s9iNX ZQSggtjIzieAUc0FLhXRFfSEWrOEKJ9a2F8zsGdbfA== X-Google-Smtp-Source: AAOMgpeMdgFc51j4bRi0isTN4NZN3jaEzuRlZHFgpnMnbEeJ9jhbiJaH5I4PkoZzHNqfbfUXcR8XUMv2E9A9GZzvNv8= X-Received: by 2002:a02:6348:: with SMTP id j69-v6mr21975361jac.45.1530549594740; Mon, 02 Jul 2018 09:39:54 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:5945:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 09:39:54 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <201807021632.w62GWjme034534@pdx.rh.CN85.dnsmgr.net> References: <575515de-523d-e0eb-ecc8-1aa517f5f34c@FreeBSD.org> <201807021632.w62GWjme034534@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 2 Jul 2018 10:39:54 -0600 X-Google-Sender-Auth: L-mCpVdRaMIlvl1p6ae6iMokO8A Message-ID: Subject: Re: svn commit: r335829 - user/cperciva/panicmail To: "Rodney W. Grimes" Cc: John Baldwin , Colin Percival , src-committers , svn-src-user@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 16:39:56 -0000 On Mon, Jul 2, 2018 at 10:32 AM, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > On 6/30/18 5:07 PM, Colin Percival wrote: > > > Author: cperciva > > > Date: Sun Jul 1 00:07:41 2018 > > > New Revision: 335829 > > > URL: https://svnweb.freebsd.org/changeset/base/335829 > > > > > > Log: > > > Add /usr/local/bin to $PATH so that panicmail can use gdb from ports. > > > > > > Submitted by: sbruno > > > > If gdb from ports isn't installed, the old gdb will be present in > /usr/libexec > > if it isn't present in /usr/bin. At some point /usr/libexec/gdb might > go away, > > but it is present there for now. The crashinfo script prefers gdb from > > /usr/local/bin and falls back to /usr/libexec or /usr/bin. > > Um, one is makeing an assumption even using /usr/local, our ports/pacakge > system has allowed this to be some other place for over 2 decades. At > one point all of base was irreadicated of /usr/local references, it is > a mistake to be putting any back. > While that may be a matter for debate (about a year or two before you came back we had a long discussions and started putting things back because it played better with, for example, people moving back and forth with Linux systems), it's not relevant here: the commit path started with user/cperciva. Warner