From owner-freebsd-current@freebsd.org Sun Jul 14 19:34:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6E89A444C for ; Sun, 14 Jul 2019 19:34:25 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EC968910A for ; Sun, 14 Jul 2019 19:34:25 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id g20so30783481ioc.12 for ; Sun, 14 Jul 2019 12:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=k+MSsjwfSD4w470i1Fs7zuMy2VXZE/j/EcPPFIbksuk=; b=po1i1/StN67UJHdLyCAZXO2TVDy9WgVdXbMTSbyjiYU2Ne1YMJvFWIlfOGZ7bxEeMk uED6d/grHYjq2D0m0j3eJf5yATxCHSDLn2H47fdehPIBHdxM2+eRG2ZZlcTRCvs21Hqm +ho2tummfCPFhYRQeIrMd9qhfFisPmpnqrvBme22KELLS+OTjW6FZaHdtPOK72Nfre+B ovnBNO8o351jtUD3XCu2cZYJO2JOjpCY+3i16614wkdUBpibm4CPJB34BaPDanddBUL8 vRdHaG7ngUJr00P8IzK9NONq8ApUauDP5sHq192h9MjZEgYvw2wt8ir0huFgp01RSU7E zt0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=k+MSsjwfSD4w470i1Fs7zuMy2VXZE/j/EcPPFIbksuk=; b=W4son3aat9Yr4HRVcKf1OwmnsVrYW188gJSQ2ER4SLtFyuUB/YsgwkXF2zc88NyFYD YwP2pnmJiqNvI8iOqHPniOZJV0qP8EHhIBTYrSPYNYyhhqM8WVc6CWj7Futhn1vTZqJ0 f73pbQjWOYjRbLkPIqHZh18dFE7pDmb9GhEQgKbL2q6OnQSnW1wbtWhr8Eo25/FF1skE v/z/wZ3Kb4FjtXKHuWrwmhnkpQOpBhimQ1o9d2PolnbcCBsPfY3x16tUUX89BPXwiir2 mmohho/8mmft3corid2gcTgNo/KrmNPJiF1Vd0xLMeq4ZKZhgewhNl7mHlvIxIiIJxJC LW6w== X-Gm-Message-State: APjAAAUmwlDG3ykzzV1Zc999W2x0hJrhLsD9OfdalhcH6ZcpXvPsSnXt qYGxeModkNqrCBogznGPRWUGSQnf X-Google-Smtp-Source: APXvYqx3pWG9MIEUCF7vbcKeti++q1LiUxzhlDZnRrI07NZinOvh3CaTv7coBQmssBRWy/P0MmHEMQ== X-Received: by 2002:a5d:915a:: with SMTP id y26mr21649025ioq.207.1563132863633; Sun, 14 Jul 2019 12:34:23 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id s2sm10768417ioj.8.2019.07.14.12.34.22 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 14 Jul 2019 12:34:22 -0700 (PDT) Sender: Mark Johnston Date: Sun, 14 Jul 2019 15:34:20 -0400 From: Mark Johnston To: Konstantin Belousov Cc: Larry Rosenman , Freebsd current Subject: Re: panic: vm_page_free_prep: freeing mapped page Message-ID: <20190714193420.GC82719@raichu> References: <20190713221457.GP47193@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190713221457.GP47193@kib.kiev.ua> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 8EC968910A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.995,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jul 2019 19:34:25 -0000 On Sun, Jul 14, 2019 at 01:14:57AM +0300, Konstantin Belousov wrote: > On Sat, Jul 13, 2019 at 04:50:57PM -0500, Larry Rosenman wrote: > > I have cores. Ideas? > > svn rev: r349976 > > > > [I] ➜ more core.txt.12 > > borg.lerctr.org dumped core - see /var/crash/vmcore.12 > > > > Sat Jul 13 16:47:03 CDT 2019 > > > > FreeBSD borg.lerctr.org 13.0-CURRENT FreeBSD 13.0-CURRENT r349976 > > LER-MINIMAL amd64 > > > > panic: vm_page_free_prep: freeing mapped page 0xfffff82031044790 > > What was the process which caused the panic ? Was it threaded ? I looked at some of the kernel dumps. In all cases the crashing process is postgres. We have: (kgdb) p/x *m->md.pv_list.tqh_first $20 = { pv_va = 0x801c00000, pv_next = { tqe_next = 0xfffff80b3aacb568, tqe_prev = 0xfffff81faf7ecbe8 } } (kgdb) p/x *m->md.pv_list.tqh_first->pv_next.tqe_next $21 = { pv_va = 0x801c00000, pv_next = { tqe_next = 0x0, tqe_prev = 0xfffff80b3ab905d0 } } We can find the corresponding pmaps for these mappings by going through the corresponding pv_chunks. Then I looked up the other processes with mappings of the page. They are also postgres processes. We have: $33 = { prev = 0xfffff818baa2be00, next = 0xfffff80e7e9875b0, left = 0xfffff814df7a6310, right = 0xfffff80e7e9875b0, start = 0x801c00000, end = 0x80aa4a000, next_read = 0x801c00000, max_free = 0x3000, object = { vm_object = 0xfffff80bbeb94400, sub_map = 0xfffff80bbeb94400 }, offset = 0x600000, eflags = 0x0, protection = 0x3, max_protection = 0x7, inheritance = 0x0, read_ahead = 0xf, wired_count = 0x0, cred = 0x0, wiring_thread = 0x0 } and (kgdb) p $33->object.vm_object->ref_count $34 = 0 (kgdb) p $33->object.vm_object->shadow_count $35 = 5 So it seems that there is some problem with vm_object reference counting; I'd expect a vm_map_entry reference to be counted in the ref_count field, and we have at least two such references. Larry, could you open a bugzilla PR for this panic? From owner-freebsd-current@freebsd.org Sun Jul 14 20:04:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BA8CEA4D66 for ; Sun, 14 Jul 2019 20:04:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 457038A1AD; Sun, 14 Jul 2019 20:04:02 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x6EK3seb075320 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sun, 14 Jul 2019 23:03:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x6EK3seb075320 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x6EK3sA7075319; Sun, 14 Jul 2019 23:03:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 14 Jul 2019 23:03:54 +0300 From: Konstantin Belousov To: Mark Johnston Cc: Larry Rosenman , Freebsd current Subject: Re: panic: vm_page_free_prep: freeing mapped page Message-ID: <20190714200354.GT47193@kib.kiev.ua> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190714193420.GC82719@raichu> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jul 2019 20:04:02 -0000 On Sun, Jul 14, 2019 at 03:34:20PM -0400, Mark Johnston wrote: > On Sun, Jul 14, 2019 at 01:14:57AM +0300, Konstantin Belousov wrote: > > On Sat, Jul 13, 2019 at 04:50:57PM -0500, Larry Rosenman wrote: > > > I have cores. Ideas? > > > svn rev: r349976 > > > > > > [I] ➜ more core.txt.12 > > > borg.lerctr.org dumped core - see /var/crash/vmcore.12 > > > > > > Sat Jul 13 16:47:03 CDT 2019 > > > > > > FreeBSD borg.lerctr.org 13.0-CURRENT FreeBSD 13.0-CURRENT r349976 > > > LER-MINIMAL amd64 > > > > > > panic: vm_page_free_prep: freeing mapped page 0xfffff82031044790 > > > > What was the process which caused the panic ? Was it threaded ? > > I looked at some of the kernel dumps. In all cases the crashing process > is postgres. We have: > > (kgdb) p/x *m->md.pv_list.tqh_first > $20 = { > pv_va = 0x801c00000, > pv_next = { > tqe_next = 0xfffff80b3aacb568, > tqe_prev = 0xfffff81faf7ecbe8 > } > } > (kgdb) p/x *m->md.pv_list.tqh_first->pv_next.tqe_next > $21 = { > pv_va = 0x801c00000, > pv_next = { > tqe_next = 0x0, > tqe_prev = 0xfffff80b3ab905d0 > } > } > > We can find the corresponding pmaps for these mappings by going > through the corresponding pv_chunks. Then I looked up the other > processes with mappings of the page. They are also postgres processes. > We have: > > $33 = { > prev = 0xfffff818baa2be00, > next = 0xfffff80e7e9875b0, > left = 0xfffff814df7a6310, > right = 0xfffff80e7e9875b0, > start = 0x801c00000, > end = 0x80aa4a000, > next_read = 0x801c00000, > max_free = 0x3000, > object = { > vm_object = 0xfffff80bbeb94400, > sub_map = 0xfffff80bbeb94400 > }, > offset = 0x600000, > eflags = 0x0, The eflags value is slightly strange. > protection = 0x3, > max_protection = 0x7, > inheritance = 0x0, > read_ahead = 0xf, > wired_count = 0x0, > cred = 0x0, > wiring_thread = 0x0 > } > > and > > (kgdb) p $33->object.vm_object->ref_count > $34 = 0 > (kgdb) p $33->object.vm_object->shadow_count > $35 = 5 What is the object type ? Can you please print the object(s) ? > > So it seems that there is some problem with vm_object reference > counting; I'd expect a vm_map_entry reference to be counted in the > ref_count field, and we have at least two such references. > > Larry, could you open a bugzilla PR for this panic? From owner-freebsd-current@freebsd.org Sun Jul 14 20:12:27 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 120F3A4F9D for ; Sun, 14 Jul 2019 20:12:27 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D69928A7A3 for ; Sun, 14 Jul 2019 20:12:26 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd42.google.com with SMTP id q22so30926452iog.4 for ; Sun, 14 Jul 2019 13:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=aZMDomoKzBkxVuO+R5biaMUtwJAnssFtwaV+3BE0tfk=; b=J9/j5G+HpVP/smZPVQ4EIbeYlp2mpKFXE8vRBzUM7EmhUSESCcMnEiE8t7tYF4+0db yNQBGuLBtL6t0Mjw/Lk2NZIzpijbeTdcg8WZ07jdDyJRIpP/KzUrXyk/18ncBilugVjW X8hEKD5AK+v2F5s+AESlbJCMoFcuDIf/ulaqQf578j4DDjKvRE2wJrm+8x1cGcgk5fIx uf3EWeztipKRe16BgVBi1QsZcQhwdtpfqFGoP340axAI9zGwDs1+lAEShtY7iweuApTk 87moIqorQFmiXbWybxgSKSEWLqwMdyQkBrM27tzvvgX7bAbyuvPdnuYT59shkvTfWBQY 9EOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=aZMDomoKzBkxVuO+R5biaMUtwJAnssFtwaV+3BE0tfk=; b=iKhnLJuoUgduf6Y2qFM4VpDOBK95sNymmyCx1WdZDi1umzzpkPaIVun7e3mqZ/nR0J LbmNLe6c5+6ECxhMu9Mm4fOE88n91MSxhPZfbqCbHbUh2ZvCozJ1dQhig1C9yhS1Fpwl humtbPLcYtOoPDuwZjRtuTn32PQn4J/gT510M+jbi7xqW/jXpENwaBHeyQZJkI4CH1Dx gyrUxDNbMAafLAhiyzjzab6+eUYyWjqsC4T2kBWQhadDNHm4IG7DazHzu5N16q3jT/3i 9g1Exm4PIujNKOTJavZYc1IP9qKyF0XFL9gFgn4MVPIZtBeW6pei1f7lKS4pvuOeslpl 70jg== X-Gm-Message-State: APjAAAW/+RdG4eIPi8/03PToQfwdhhCV8pNyJSCxQGmqkXcjGN/6CyHe REX2LB0wtMxmZJ9ljP5KUkat3f/A X-Google-Smtp-Source: APXvYqw+fkvsJ7Z8GBCptzi38xJnrgkRGrr5TrHBrDR1e3Ri6jNZhGPa5mi3LtHBu08eKhfqu8whfA== X-Received: by 2002:a6b:8bd1:: with SMTP id n200mr22280075iod.134.1563135146032; Sun, 14 Jul 2019 13:12:26 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id m4sm14681003iok.68.2019.07.14.13.12.25 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 14 Jul 2019 13:12:25 -0700 (PDT) Sender: Mark Johnston Date: Sun, 14 Jul 2019 16:12:23 -0400 From: Mark Johnston To: Konstantin Belousov Cc: Larry Rosenman , Freebsd current Subject: Re: panic: vm_page_free_prep: freeing mapped page Message-ID: <20190714201223.GD82719@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190714200354.GT47193@kib.kiev.ua> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: D69928A7A3 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jul 2019 20:12:27 -0000 On Sun, Jul 14, 2019 at 11:03:54PM +0300, Konstantin Belousov wrote: > On Sun, Jul 14, 2019 at 03:34:20PM -0400, Mark Johnston wrote: > > On Sun, Jul 14, 2019 at 01:14:57AM +0300, Konstantin Belousov wrote: > > > On Sat, Jul 13, 2019 at 04:50:57PM -0500, Larry Rosenman wrote: > > > > I have cores. Ideas? > > > > svn rev: r349976 > > > > > > > > [I] ➜ more core.txt.12 > > > > borg.lerctr.org dumped core - see /var/crash/vmcore.12 > > > > > > > > Sat Jul 13 16:47:03 CDT 2019 > > > > > > > > FreeBSD borg.lerctr.org 13.0-CURRENT FreeBSD 13.0-CURRENT r349976 > > > > LER-MINIMAL amd64 > > > > > > > > panic: vm_page_free_prep: freeing mapped page 0xfffff82031044790 > > > > > > What was the process which caused the panic ? Was it threaded ? > > > > I looked at some of the kernel dumps. In all cases the crashing process > > is postgres. We have: > > > > (kgdb) p/x *m->md.pv_list.tqh_first > > $20 = { > > pv_va = 0x801c00000, > > pv_next = { > > tqe_next = 0xfffff80b3aacb568, > > tqe_prev = 0xfffff81faf7ecbe8 > > } > > } > > (kgdb) p/x *m->md.pv_list.tqh_first->pv_next.tqe_next > > $21 = { > > pv_va = 0x801c00000, > > pv_next = { > > tqe_next = 0x0, > > tqe_prev = 0xfffff80b3ab905d0 > > } > > } > > > > We can find the corresponding pmaps for these mappings by going > > through the corresponding pv_chunks. Then I looked up the other > > processes with mappings of the page. They are also postgres processes. > > We have: > > > > $33 = { > > prev = 0xfffff818baa2be00, > > next = 0xfffff80e7e9875b0, > > left = 0xfffff814df7a6310, > > right = 0xfffff80e7e9875b0, > > start = 0x801c00000, > > end = 0x80aa4a000, > > next_read = 0x801c00000, > > max_free = 0x3000, > > object = { > > vm_object = 0xfffff80bbeb94400, > > sub_map = 0xfffff80bbeb94400 > > }, > > offset = 0x600000, > > eflags = 0x0, > The eflags value is slightly strange. Yeah, I'd expect MAP_ENTRY_COW. > > protection = 0x3, > > max_protection = 0x7, > > inheritance = 0x0, > > read_ahead = 0xf, > > wired_count = 0x0, > > cred = 0x0, > > wiring_thread = 0x0 > > } > > > > and > > > > (kgdb) p $33->object.vm_object->ref_count > > $34 = 0 > > (kgdb) p $33->object.vm_object->shadow_count > > $35 = 5 > What is the object type ? Can you please print the object(s) ? OBJT_DEFAULT. $34 = { lock = { lock_object = { lo_name = 0xffffffff808571d4 "vm object", lo_flags = 627245056, lo_data = 0, lo_witness = 0x0 }, rw_lock = 18446735366207213568 }, object_list = { tqe_next = 0xfffff80bbeb94500, tqe_prev = 0xfffff80bbeb94320 }, shadow_head = { lh_first = 0xfffff8066f43b600 }, shadow_list = { le_next = 0xfffff815ca45de00, le_prev = 0xfffff80665064438 }, memq = { tqh_first = 0xfffff81faf7ecbb0, tqh_last = 0xfffff81fb1719ec0 }, rtree = { rt_root = 18446735385885095616 }, size = 37995, domain = { dr_policy = 0x0, dr_iter = 0 }, generation = 1, ref_count = 0, shadow_count = 5, memattr = 6 '\006', type = 0 '\000', flags = 4104, pg_color = 5632, paging_in_progress = 0, resident_page_count = 26097, backing_object = 0x0, backing_object_offset = 0, pager_object_list = { tqe_next = 0x0, tqe_prev = 0x0 }, rvq = { lh_first = 0x0 }, handle = 0x0, un_pager = { vnp = { vnp_size = 81, writemappings = 0 }, devp = { devp_pglist = { tqh_first = 0x51, tqh_last = 0x0 }, ops = 0x0, dev = 0x0 }, sgp = { sgp_pglist = { tqh_first = 0x51, tqh_last = 0x0 } }, swp = { swp_tmpfs = 0x51, swp_blks = { pt_root = 0 } } }, cred = 0xfffff8104e939600, charge = 149336064, umtx_data = 0x0 } From owner-freebsd-current@freebsd.org Mon Jul 15 12:53:45 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9BDBB9406 for ; Mon, 15 Jul 2019 12:53:45 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3669B8EC0A; Mon, 15 Jul 2019 12:53:45 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=sAC52Hw9IP0YSHG3xQ8MmzvAXP+lSxh3pF9ZBHemv2U=; b=qHGrsbNJVnXWLOk71fMiy4q/1r q1DPvoTAdkex8wm5Ki1t22RsmeEgF9qRBU2T3WTdqwmFySvGCqj49Gc+JjwwJtHiAIwh6KbCSt1Jp F+9kOdqrA5oBbJKQrSeBfoxXSvmEbLXtB4V/8XCEd8jthHDXGsZRWbxHEdgR9sR43d5J//97Kl/8s /OwYaTsItyklSaA72sKzfD/Y8SC7DzUuzw7RX6VQSjbOVP6+wLltIyZIuA1ylOMspBsWmABGXoFom fUr1JwwzS1y/7mYlIsZa+ZpDDS7NvE2E8IOy4dGHhnj6Ri3mR7v6IzHfkBH5EI21dxyoTZaCUKtYC nN/6usQQ==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:10351 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hn0UB-000LNU-QM; Mon, 15 Jul 2019 07:53:43 -0500 Received: from 2600:1700:210:b180:bdaa:d9bf:e9eb:99de by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 15 Jul 2019 07:53:43 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Jul 2019 07:53:43 -0500 From: Larry Rosenman To: Mark Johnston Cc: Konstantin Belousov , Freebsd current , Mark Johnston Subject: Re: panic: vm_page_free_prep: freeing mapped page In-Reply-To: <20190714201223.GD82719@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> Message-ID: <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 12:53:45 -0000 I got another panic overnight while my bacula backups were running. It's probably postgres again. Mark, I've uploaded the dump/core.txt, info file to the same place on freefall (*17*). What else can I provide to help find this bug and eradicate it. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 From owner-freebsd-current@freebsd.org Mon Jul 15 15:14:19 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C2A0EBC68D for ; Mon, 15 Jul 2019 15:14:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 94CA895E33 for ; Mon, 15 Jul 2019 15:14:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id e20so4311137iob.9 for ; Mon, 15 Jul 2019 08:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=DKRKR7CHfVWW8kfFKSw2MVzckLHwG1PEherQbhrA60s=; b=o3WGzp4/dQ9S3uAKCW+u2dh4KjyX1QLAsr8GMtCTorCS8V5tQl/DcdkIvWX+i0OcFq ZcpIEQz6B7eEJqrmsn+fqcGlQcypaKP2zRZ99p4hnCzItaoTA+noAYNSOw0KChtMN23X 9HlsNXi3zV0iS0uoEjXkVTb5BuavFAZO/Fj0bWuu20bVJ2Y6NlGHwtCKqj6A6XyRtQ4x dJrENUnF0tbIkFBlm8h3INDtdBkkOgBc7ZRJCztZ/1OjrI9mNImqwLIxRCycFTmePBr9 v//c3y5Orxyzw6yLujlVDwJM62p4kzoFaR7eltQZ4pI6x6TjD+rowSwn9jFY8mau+8sL 6ohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=DKRKR7CHfVWW8kfFKSw2MVzckLHwG1PEherQbhrA60s=; b=Hrj+rdFV3EVYyo4pg+ggTbSlRha4Iu3lWOzD1UmF8dvaiqkZA38GRle+fIH/FgMLU7 fQfcPbn7LYwK55z1xovLOeWE84AQMs0fagLIF2QDozrz830GJVn2x+EqWphCk/S3yZhz g2xhmoQycgtsf7nI0IjbmByVkJ9jMmn8yj36j6IGo3DakosMd5kKGWpl0cLr0JsCu9hZ X16KlLXfxzO0ZJxY/o+oH85lH9WC5qZM5uytFx2mZWu4lUEmmHbF217tO9F4OWCJptiD 1ZUgFJX4u7oFsyv4LIrEN0Lv/4U3nds29hSz044PsPjYFE9bKBTi3vqX4rkvydILSE6P wa2A== X-Gm-Message-State: APjAAAXtSPgc+ffk2enDtDnS3WcsDkBkicgEnfF1VJzpAYTmAGXhU/9u C/k+7iX3rg53kZz2dPV9O3j3i+uq X-Google-Smtp-Source: APXvYqxqmD0/wdXtdqmaWxiXYuWfmrr8Tt9hfj+TG98i5JhFmhua0HW0yp61ckYpGjy62vvBpmkyYQ== X-Received: by 2002:a6b:cd86:: with SMTP id d128mr25216442iog.234.1563203658707; Mon, 15 Jul 2019 08:14:18 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id h19sm12774435iol.65.2019.07.15.08.14.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 08:14:17 -0700 (PDT) Sender: Mark Johnston Date: Mon, 15 Jul 2019 11:14:15 -0400 From: Mark Johnston To: Larry Rosenman Cc: Konstantin Belousov , Freebsd current Subject: Re: panic: vm_page_free_prep: freeing mapped page Message-ID: <20190715151415.GE82719@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 94CA895E33 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 15:14:19 -0000 On Mon, Jul 15, 2019 at 07:53:43AM -0500, Larry Rosenman wrote: > I got another panic overnight while my bacula backups were running. > It's > probably postgres again. > > Mark, > I've uploaded the dump/core.txt, info file to the same place on > freefall (*17*). > > What else can I provide to help find this bug and eradicate it. What's the last known good revision for this system? That is, at what revision was the last kernel where you didn't see the problem on this system? From owner-freebsd-current@freebsd.org Mon Jul 15 15:16:33 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E814ABC7C2 for ; Mon, 15 Jul 2019 15:16:33 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 774F5960AA; Mon, 15 Jul 2019 15:16:33 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=T1AixU+xK+t+bAbF4v/AMtRWRQTzlPQsajT/26JoIcY=; b=SJx3PbqovWYibmNLLIqPZWnRQO 9eiAmhNGDlHN3tqUX3nR3fgR4elDKrOJP1bk5a+57R3MUV0vFK6VmjDJAEKPmUyE7/tDkA6dIhKid 1d+tH5dpW7qm7qnrGJQS+QsepE2FUqW7er2kBnYQp3oC4xu4QI32Eu9Jn4SwEobv5+4b5gpnEwhW4 qPwGLBEAVSTSfvkwn1wwofN3rkKLXU8D7Q44IHZbB1h366K56vRSg5o5b1Clhi8w+oghsWtfdjq87 oH2ts0uiK9eN+X5VEiwWXCVtzB/mNaDxGVJ3OwX84lD2jOGw5qHSEAnI//Lu4FCRVswH4zv96OtAf aFWbNJ7A==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:51454 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hn2iN-000Ob4-2W; Mon, 15 Jul 2019 10:16:31 -0500 Received: from 2600:1700:210:b180:bdaa:d9bf:e9eb:99de by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 15 Jul 2019 10:16:30 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Jul 2019 10:16:30 -0500 From: Larry Rosenman To: Mark Johnston Cc: Konstantin Belousov , Freebsd current , Mark Johnston Subject: Re: panic: vm_page_free_prep: freeing mapped page In-Reply-To: <20190715151415.GE82719@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> <20190715151415.GE82719@raichu> Message-ID: <7d6ff6bc0bb623105750402b04db23c2@lerctr.org> X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 15:16:34 -0000 On 07/15/2019 10:14 am, Mark Johnston wrote: > On Mon, Jul 15, 2019 at 07:53:43AM -0500, Larry Rosenman wrote: >> I got another panic overnight while my bacula backups were running. >> It's >> probably postgres again. >> >> Mark, >> I've uploaded the dump/core.txt, info file to the same place on >> freefall (*17*). >> >> What else can I provide to help find this bug and eradicate it. > > What's the last known good revision for this system? That is, at what > revision was the last kernel where you didn't see the problem on this > system? r349858 on 2019-07-09. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 From owner-freebsd-current@freebsd.org Mon Jul 15 20:53:38 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71C6FC3B0C for ; Mon, 15 Jul 2019 20:53:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 495BF76D08 for ; Mon, 15 Jul 2019 20:53:38 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2b.google.com with SMTP id o9so36455482iom.3 for ; Mon, 15 Jul 2019 13:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=znJ+jQF+mvg6TgRb/blWgQz8PBmJPoa638NzJjRK1QQ=; b=naDtLGN2qv3Tck5eZcBAGVhN+t8ciT9HSnPkBkt1Rhcdsl09t2AQg/qp2gBota8s4y ujO/h6ynvW8uFjUliNKA0bE6g2+J3qoeezea3Kox/4uJCELueRF9ouBZLhKFWwuk+QFt G6ftLrcpMPUNSnq2MXlTGS+gSGVDEIfRnHMHjAI9ZvA4NU13zKSPIDFHSJTGZYdvOxvM zJt/TMNahJ8Lk9X7TbTtZxsTa/s15q9br6wC1FWII0oI3qqB1UcFsHHFkPBkKPsx+jgR jcPTJLlMKnse/vbbrozW78vW4tVjf019LhQB/VaSRcaDNcDuBZ7jdtj1Z4L5EunScROL RflA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=znJ+jQF+mvg6TgRb/blWgQz8PBmJPoa638NzJjRK1QQ=; b=jDzic8ncdQYp4bYqi0hM1nEJXTMPS+zbhzpgScx8H4iyz1M5zCLUp0b/tUXIH3b1Qr GmOn48SMQ6PAGltoTzshX00SlwKrlLV/MKb0L8DXhOzGpICBqbZ3ahCI8fduvl8s7X3O hNx6AyauZMfZq7bGkVviZv8W6tZ8e+UUYH30Jc3oyesmIXmKJMkU1hf9j8TCN66FHoy+ jM58rzLZuDUF3cybSQDihpW5SBey7Nhn+kWjuDXXGth/evSVowQrhNES6kEyoNbiQctE XnvSySDmzfU/VLXKi/+KHp6hjwQCagxWWesZ2nBMMBMzLODVUHyRMfPu+gt0m1cKhwtz aVHA== X-Gm-Message-State: APjAAAUwyoNJFGq/wsSebnpo73TDe+Bq5F1OXGeS2nAlYSzmlXrQBdjl HpbNd+cgZYy68+NMnggsYu4= X-Google-Smtp-Source: APXvYqy/Aci8WeLFASRrJlLklrpSAOh3DvVEA07B4A5i/gohn4x/n3+5zchCj6dnsqFI/pZSl8D3Eg== X-Received: by 2002:a6b:6409:: with SMTP id t9mr20235745iog.270.1563224017621; Mon, 15 Jul 2019 13:53:37 -0700 (PDT) Received: from raichu (toroon0560w-lp140-05-70-29-85-38.dsl.bell.ca. [70.29.85.38]) by smtp.gmail.com with ESMTPSA id e26sm15583071iod.10.2019.07.15.13.53.36 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 15 Jul 2019 13:53:36 -0700 (PDT) Sender: Mark Johnston Date: Mon, 15 Jul 2019 16:53:34 -0400 From: Mark Johnston To: Larry Rosenman Cc: Konstantin Belousov , Freebsd current Subject: Re: panic: vm_page_free_prep: freeing mapped page Message-ID: <20190715205334.GB10741@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 495BF76D08 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 20:53:38 -0000 On Mon, Jul 15, 2019 at 07:53:43AM -0500, Larry Rosenman wrote: > I got another panic overnight while my bacula backups were running. > It's > probably postgres again. > > Mark, > I've uploaded the dump/core.txt, info file to the same place on > freefall (*17*). > > What else can I provide to help find this bug and eradicate it. Just to follow up, the panic should be resolved by r350005. From owner-freebsd-current@freebsd.org Mon Jul 15 22:10:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6D6A8C513D for ; Mon, 15 Jul 2019 22:10:08 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EF8EB820CB; Mon, 15 Jul 2019 22:10:07 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5Ni9GtfSuhuBAHgtZ1mEBpCScWALEXY2bElaoTkvmdo=; b=Z0MptHQExVAIXGiRCvazjP9tWT YVKjUuVXZy8MlyxHAXURG4qd1/Bk+eOTu+mkm07c/ckCA1KHJhwLGGB2irMPdOkqzBaqm1VV/WO3w ydVC8FVKEHWN6FmW8xHy5CAZ+BbR1n8MMuPZ+W/Pci3L1CDaIxNURJOMRoSSAeXWABGtCdyBix5Qd byY5EBE09+Xq/GjBLa+1xgTwtiZFtN0BjwCW7Lqvt/UJpapjH30T7ULSRq9V/JKxq3wBHM7zYcpgv NtFT+n7pPwNRvKNXP1G3DTS0HeMZBHXTeW38scrmvseNBd2+JuH6Tj0wUYr50EqsvYlkLnbpmJ9Tb SCriOrcg==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:50141 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hn9Ab-0006lm-IJ; Mon, 15 Jul 2019 17:10:05 -0500 Received: from 2600:1700:210:b180:bdaa:d9bf:e9eb:99de by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 15 Jul 2019 17:10:05 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Jul 2019 17:10:05 -0500 From: Larry Rosenman To: Mark Johnston Cc: Konstantin Belousov , Freebsd current , Mark Johnston Subject: Re: panic: vm_page_free_prep: freeing mapped page In-Reply-To: <20190715205334.GB10741@raichu> References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> <20190715205334.GB10741@raichu> Message-ID: X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 22:10:08 -0000 On 07/15/2019 3:53 pm, Mark Johnston wrote: > On Mon, Jul 15, 2019 at 07:53:43AM -0500, Larry Rosenman wrote: >> I got another panic overnight while my bacula backups were running. >> It's >> probably postgres again. >> >> Mark, >> I've uploaded the dump/core.txt, info file to the same place on >> freefall (*17*). >> >> What else can I provide to help find this bug and eradicate it. > > Just to follow up, the panic should be resolved by r350005. Updated to r350011. We'll see how it does. Thank You for looking at it. -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 From owner-freebsd-current@freebsd.org Mon Jul 15 23:22:00 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F1FF6C64E4 for ; Mon, 15 Jul 2019 23:22:00 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 84E8E8523F; Mon, 15 Jul 2019 23:22:00 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LYrpm736hm/0hQNBFO/9ayxR6iQmj6sdTyujLJ/ILHE=; b=EdVxGdDkQYw0jB5kw6iMNvrYf/ 4ItNobDJVPxwptlxcynbvlrX88KqoL+n64we8HXFQ1sz+ukueBqdkUjRG2fwzKhlsvTTvlh/pbWEh ILAh4bdaJjZl/bIv+NfWqWoso8Ljl3+eUmvT4ri/p10TNVVZzlHwCymhsy0MuPdwaPVzZGkSQPoCj rkIKZHeVnYpnpbIbrqBg/PaSxUbZ5kYxZnoY0YzYgHgnanhT7dDRBMxZjxL5eAhzyWASgYuJKK4aP 5LWQOuqTZQOuKukkKaqw5sMlczTv2UFsFSBmvuh6G8pdDKLolAfyt03KuJkvuqGivQUJpTC2bfvVc BxYTQJDA==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:59587 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hnAI9-00088H-Hx; Mon, 15 Jul 2019 18:21:57 -0500 Received: from 2600:1700:210:b180:8d6b:2807:cf68:b7df by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 15 Jul 2019 18:21:57 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 15 Jul 2019 18:21:57 -0500 From: Larry Rosenman To: Mark Johnston Cc: Konstantin Belousov , Freebsd current , Mark Johnston Subject: Re: panic: vm_page_free_prep: freeing mapped page In-Reply-To: References: <20190713221457.GP47193@kib.kiev.ua> <20190714193420.GC82719@raichu> <20190714200354.GT47193@kib.kiev.ua> <20190714201223.GD82719@raichu> <57d05fd642ec5c688077ff63dff8fe63@lerctr.org> <20190715205334.GB10741@raichu> Message-ID: <350535e08a29ffc90261221879a97355@lerctr.org> X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2019 23:22:01 -0000 On 07/15/2019 5:10 pm, Larry Rosenman wrote: > On 07/15/2019 3:53 pm, Mark Johnston wrote: >> On Mon, Jul 15, 2019 at 07:53:43AM -0500, Larry Rosenman wrote: >>> I got another panic overnight while my bacula backups were running. >>> It's >>> probably postgres again. >>> >>> Mark, >>> I've uploaded the dump/core.txt, info file to the same place on >>> freefall (*17*). >>> >>> What else can I provide to help find this bug and eradicate it. >> >> Just to follow up, the panic should be resolved by r350005. > > Updated to r350011. We'll see how it does. Thank You for > looking at it. Well, it made it through the pgbuildfarm run. I think we're good. Thanks, all! -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 From owner-freebsd-current@freebsd.org Tue Jul 16 06:07:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CEFB6A6AC0 for ; Tue, 16 Jul 2019 06:07:02 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from atl4mhob23.registeredsite.com (atl4mhob23.registeredsite.com [209.17.115.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 336196C611 for ; Tue, 16 Jul 2019 06:07:01 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail01pod2.registeredsite.com [10.30.77.35]) by atl4mhob23.registeredsite.com (8.14.4/8.14.4) with ESMTP id x6G66sWa081336 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Jul 2019 02:06:54 -0400 Received: (qmail 38622 invoked by uid 0); 16 Jul 2019 06:06:54 -0000 X-TCPREMOTEIP: 99.253.177.25 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.3?) (dclarke@blastwave.org@99.253.177.25) by 0 with ESMTPA; 16 Jul 2019 06:06:54 -0000 To: freebsd-current@freebsd.org From: Dennis Clarke Subject: sbin/camcontrol/camcontrol.c error breaks buildworld Message-ID: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> Date: Tue, 16 Jul 2019 02:06:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 336196C611 X-Spamd-Bar: +++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [5.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.86)[0.858,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: mx1.netsolmail.net]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[117.115.17.209.list.dnswl.org : 127.0.5.0]; NEURAL_SPAM_MEDIUM(0.99)[0.987,0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:209.17.112.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(1.35)[ip: (3.66), ipnet: 209.17.112.0/21(1.74), asn: 19871(1.39), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 06:07:02 -0000 In r350018 for a buildworld I am running into : . . . cc --sysroot=/usr/obj/usr/src/r350018/powerpc.powerpc64/tmp -B/usr/obj/usr/src/r350018/powerpc.powerpc64/tmp/usr/bin -O2 -pipe -I/usr/src/r350018/sbin/nvmecontrol -DWITH_NVME -DRESCUE -MD -MF.depend.camcontrol.o -MTcamcontrol.o -std=gnu99 -fstack-protector-strong -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/r350018/sbin/camcontrol/camcontrol.c -o camcontrol.o cc1: warnings being treated as errors /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison of unsigned expression < 0 is always false *** Error code 1 Stop. make[6]: stopped in /usr/src/r350018/sbin/camcontrol *** Error code 1 Stop. make[5]: stopped in /usr/obj/usr/src/r350018/powerpc.powerpc64/rescue/rescue *** Error code 1 Stop. make[4]: stopped in /usr/src/r350018/rescue/rescue *** Error code 1 Stop. make[3]: stopped in /usr/src/r350018/rescue *** Error code 1 Stop. make[2]: stopped in /usr/src/r350018 *** Error code 1 Stop. make[1]: stopped in /usr/src/r350018 *** Error code 1 Stop. make: stopped in /usr/src/r350018 # Anyone else seeing this ? -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From owner-freebsd-current@freebsd.org Tue Jul 16 06:48:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F52AA752D for ; Tue, 16 Jul 2019 06:48:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DDE36D902 for ; Tue, 16 Jul 2019 06:48:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id d79so13669184qke.11 for ; Mon, 15 Jul 2019 23:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=El1hRo2zyt2TqcPMp1n/Jo2QOexEFdzQ0aVY1sfbuP0=; b=pwFKiMhDFgMYzmxZO8llbjebQp2OymSMyAGc/w4IQId9GhxRVrIjajzb8ksGYXZJ8D or0dFVEkGdwQKnF34fdKMxWjjcO1CwsshF4+nDsc3v1sURx6xxi8HE2DMXznDYHRvtQ0 KimwEgBdgv08ytOA13NNa/JzP2dfEga3tTIHk1IX6rw0Bxz5YnoEL71pqCNn12y/I2hW QHsin9oWfN79U3H4NICDhlQWvLzuRmy/mvZ5cms7rcDPcDG18GfWRhpm4jqkSF5ZPumb VDL0ZS/CsZuW4eWcmzlcyKoD3BKt9NB8ypC6jasPqA1xE6hBtrC1FjiARg0tA2/Gg657 0EHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=El1hRo2zyt2TqcPMp1n/Jo2QOexEFdzQ0aVY1sfbuP0=; b=k0BjS876yIF5q5vktnYDZVesW5c/2lNVnFQmt4mo+G9dXuO0wEToQAm8kqWxWXDFoT qz+LFRGJDDhJZaYc2iBLBoywrfmTml85Ekfc6+2hR1WjYzgjhX+xOtJtAIKUIbunSdxh Zx79+iZJUHE+DmR4O19XJQcLdiUUwY47HV92EVCvDroizaRkYxXRukDY6phrhc7YfxWH iPCZh81E1Cv48PiyCFu2BIpuCZ0aGctzLK3MUo/BJ6SIFKhoX9C48akzfDWCDPyTfbQA xMcTDUOKUBDpM++OTAi9t3aj5ExT/SjSgxBJ91a3SswozuKltCZFfM8Xycwe9tbtAhwQ HZUg== X-Gm-Message-State: APjAAAUEOeDB5MnDEgjRLFVkCpnnKXPxioT8ONoHeCiFuLTfRMnARawo IyxdBDnkLSOWJ+HRL1zKN9wxg/NeT8RWLsTGeSknFA== X-Google-Smtp-Source: APXvYqyRo2mHARDJ2kTRIWhuHK2a402iIO3GzP1nP/SZUhU2FridEzX1dBqQ+UhDCMVWcs9iwUBId//LLAPIqk8gLSE= X-Received: by 2002:ae9:f107:: with SMTP id k7mr20799857qkg.215.1563259712298; Mon, 15 Jul 2019 23:48:32 -0700 (PDT) MIME-Version: 1.0 References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> In-Reply-To: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> From: Warner Losh Date: Tue, 16 Jul 2019 00:48:21 -0600 Message-ID: Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: Dennis Clarke Cc: FreeBSD Current X-Rspamd-Queue-Id: 4DDE36D902 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=pwFKiMhD X-Spamd-Result: default: False [-4.87 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.981,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.14)[0.136,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[d.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-3.02)[ip: (-9.42), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.44), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 06:48:34 -0000 On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke wrote: > /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': > /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > of unsigned expression < 0 is always false > > Anyone else seeing this ? > Fixed hours ago in 350020. Warner From owner-freebsd-current@freebsd.org Tue Jul 16 10:36:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5372DABD5A for ; Tue, 16 Jul 2019 10:36:55 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from atl4mhob24.registeredsite.com (atl4mhob24.registeredsite.com [209.17.115.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A559076969 for ; Tue, 16 Jul 2019 10:36:54 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com ([10.30.77.35]) by atl4mhob24.registeredsite.com (8.14.4/8.14.4) with ESMTP id x6GAagXf005655 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Jul 2019 06:36:43 -0400 Received: (qmail 19227 invoked by uid 0); 16 Jul 2019 10:36:42 -0000 X-TCPREMOTEIP: 99.253.177.25 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.3?) (dclarke@blastwave.org@99.253.177.25) by 0 with ESMTPA; 16 Jul 2019 10:36:42 -0000 Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: freebsd-current@freebsd.org References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> From: Dennis Clarke Message-ID: <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> Date: Tue, 16 Jul 2019 06:36:41 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A559076969 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.17 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.76)[0.758,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: mx1.netsolmail.net]; NEURAL_SPAM_LONG(0.99)[0.994,0]; DMARC_NA(0.00)[blastwave.org]; NEURAL_SPAM_MEDIUM(0.90)[0.905,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:209.17.112.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.62)[ipnet: 209.17.112.0/21(1.76), asn: 19871(1.41), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 10:36:55 -0000 On 7/16/19 2:48 AM, Warner Losh wrote: > On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke > wrote: > >> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': >> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison >> of unsigned expression < 0 is always false >> >> Anyone else seeing this ? >> > > Fixed hours ago in 350020. Hours ago. Cool. However is there no CI testing on ppc64? Maybe a jenkins type of deal would be helpful but the code base is moving so fast that it may only catch a few things here and there. Regardless the ppc64 world has bigger problems this morning : r350018 will panic on ppc64 PowerMac G5 in vm_phys_enqueue_contig https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Another day another panic. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From owner-freebsd-current@freebsd.org Tue Jul 16 10:55:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AC9D4AC286 for ; Tue, 16 Jul 2019 10:55:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8EC92772C2; Tue, 16 Jul 2019 10:55:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 65CF6C274; Tue, 16 Jul 2019 10:55:08 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [192.168.1.58] (92-111-45-100.static.v4.ziggozakelijk.nl [92.111.45.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id DFFC368DB3; Tue, 16 Jul 2019 12:55:06 +0200 (CEST) From: Dimitry Andric Message-Id: Content-Type: multipart/signed; boundary="Apple-Mail=_BDA5EADF-E9AC-426B-8ED7-CACC89350A59"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld Date: Tue, 16 Jul 2019 12:55:02 +0200 In-Reply-To: <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> Cc: FreeBSD CURRENT To: Dennis Clarke References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 8EC92772C2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.93 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.93)[-0.934,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 10:55:08 -0000 --Apple-Mail=_BDA5EADF-E9AC-426B-8ED7-CACC89350A59 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > > On 7/16/19 2:48 AM, Warner Losh wrote: >> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke >> wrote: >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': >>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison >>> of unsigned expression < 0 is always false >>> >>> Anyone else seeing this ? >>> >> Fixed hours ago in 350020. > > Hours ago. Cool. However is there no CI testing on ppc64? There is a CI build, in any case: https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ It showed a failure for build #11532 (r350018): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ and also how it got fixed in build #11533 (r350020): https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ Unfortunately there is no test job which attempts to fire up a world inside e.g. qemu. -Dimitry --Apple-Mail=_BDA5EADF-E9AC-426B-8ED7-CACC89350A59 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXS2tBgAKCRCwXqMKLiCW o+RaAJ9CoktwBTEFxQr7zjgRoZsr2UzfnACfdyTg//PorOCz2Q95fgXcgCb+wKQ= =1dQr -----END PGP SIGNATURE----- --Apple-Mail=_BDA5EADF-E9AC-426B-8ED7-CACC89350A59-- From owner-freebsd-current@freebsd.org Tue Jul 16 11:03:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7A39AAC7D9 for ; Tue, 16 Jul 2019 11:03:55 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from atl4mhob22.registeredsite.com (atl4mhob22.registeredsite.com [209.17.115.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F21C477A4F for ; Tue, 16 Jul 2019 11:03:54 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail01pod2.registeredsite.com [10.30.77.35]) by atl4mhob22.registeredsite.com (8.14.4/8.14.4) with ESMTP id x6GB3qsu052076 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Jul 2019 07:03:52 -0400 Received: (qmail 15186 invoked by uid 0); 16 Jul 2019 11:03:52 -0000 X-TCPREMOTEIP: 99.253.177.25 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.3?) (dclarke@blastwave.org@99.253.177.25) by 0 with ESMTPA; 16 Jul 2019 11:03:51 -0000 Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: Dimitry Andric Cc: FreeBSD CURRENT References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> From: Dennis Clarke Message-ID: Date: Tue, 16 Jul 2019 07:03:50 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F21C477A4F X-Spamd-Bar: +++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [5.23 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.82)[0.820,0]; IP_SCORE(1.55)[ip: (4.62), ipnet: 209.17.112.0/21(1.76), asn: 19871(1.41), country: US(-0.06)]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[blastwave.org]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.98)[0.978,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[cached: mx1.netsolmail.net]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[116.115.17.209.list.dnswl.org : 127.0.5.0]; NEURAL_SPAM_LONG(1.00)[1.000,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:209.17.112.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 11:03:55 -0000 On 7/16/19 6:55 AM, Dimitry Andric wrote: > On 16 Jul 2019, at 12:36, Dennis Clarke wrote: >> >> On 7/16/19 2:48 AM, Warner Losh wrote: >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke >>> wrote: >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function 'getdevtype': >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison >>>> of unsigned expression < 0 is always false >>>> >>>> Anyone else seeing this ? >>>> >>> Fixed hours ago in 350020. >> >> Hours ago. Cool. However is there no CI testing on ppc64? > > There is a CI build, in any case: > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ > > It showed a failure for build #11532 (r350018): > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ > > and also how it got fixed in build #11533 (r350020): > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ > > Unfortunately there is no test job which attempts to fire up a world > inside e.g. qemu. Oh well, thank you for the info. Lucky me that I fell into the exact same build problem which only happens rarely. Hardly a lottery ticket win but I am happy to see the CI information. Dennis From owner-freebsd-current@freebsd.org Tue Jul 16 15:11:27 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33817B1EAC for ; Tue, 16 Jul 2019 15:11:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCF1789290 for ; Tue, 16 Jul 2019 15:11:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id s22so14838991qkj.12 for ; Tue, 16 Jul 2019 08:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HS6JEBn4eDljpRMZpFYlLCTWOpc+sB0X2g5gHu3LRZ0=; b=Sib0bWePJV/5jqdxu64IFDp0aol6Uiuy6C/M5rcR6vqkVqJku/shs+VFH5+dPB2i7r m2lWub2e3Tm/N62TTbmq96ocO+zqtZAfrgq3m7LSjDUmxJKpruthAP7/CvYGjgnorFTS IrQo3ZgV1aiQA+74Teeg9qKd4tP+940UH6zBDOjrhkOPrv65QW2ng7vE2iX5KOQUbShI /7NnClVM8pq3gCZDhFYIOS9Q7RfZ71LYJbDx+BxioZHGpGgBFhTx8qusDvTkaH9LpY8h jPuMeuy2pwnqivH453a8tlvbzC2wYOvq/d9UUsvXbKtH4T+HOO5d0im04Uh5Nq0cOdfr daJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HS6JEBn4eDljpRMZpFYlLCTWOpc+sB0X2g5gHu3LRZ0=; b=sONIG6QJA9TdF3sBn2h/PR5YxZGyNMpGvXHugrGf7RA95CgKck6090d9+BSwTo+2eo ZZx1/Kit1jL28A30gNj8y9c+I+vksfD3HaIAh/p8fQa0dBRUa+4DeCgPaMTd8LdOw0zU X68Jy5bL7j4VatPNjgKaUuWi6yTkM1B5iMM7whojW35ctmocxlNEzQoUQ4owNJ6F3ml6 JXSGG4DvfGaCsNEeBh+mKetPQdjz8l4jwYNU6Xo5vC1VolRZ0v71R5RW3qv2oRPgYP/2 iLiiYPAn4Tkoxx6H3qQUWfZrFdpfuQWZcWzPA0qXe/JYbo3Sa1Nawk+YvBdVseKtiLpi oB2g== X-Gm-Message-State: APjAAAXSGjkDJUHE+2M2uMs+d6KAmVeG4Y6AtjTxTSHdRUfupjQg4Zm7 uBtnpzY+h4jBCzNq8gnCdpJNjv3sq6TWFZZqI9Y= X-Google-Smtp-Source: APXvYqxc/WQGSPW/cweLE3mzlXMyiT+AXeOhWJS9gJvRfAcPoggmUyIUImlfaMR/0gnnqMb3AGLXXufFudCc79SCAwQ= X-Received: by 2002:ae9:f107:: with SMTP id k7mr22712164qkg.215.1563289885038; Tue, 16 Jul 2019 08:11:25 -0700 (PDT) MIME-Version: 1.0 References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> In-Reply-To: From: Warner Losh Date: Tue, 16 Jul 2019 09:11:13 -0600 Message-ID: Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: Dennis Clarke Cc: Dimitry Andric , FreeBSD CURRENT X-Rspamd-Queue-Id: CCF1789290 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Sib0bWeP X-Spamd-Result: default: False [-5.57 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.957,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[d.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.58)[-0.585,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-3.02)[ip: (-9.42), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.45), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 15:11:27 -0000 On Tue, Jul 16, 2019 at 5:04 AM Dennis Clarke wrote: > On 7/16/19 6:55 AM, Dimitry Andric wrote: > > On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > >> > >> On 7/16/19 2:48 AM, Warner Losh wrote: > >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke > >>> wrote: > >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function > 'getdevtype': > >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > >>>> of unsigned expression < 0 is always false > >>>> > >>>> Anyone else seeing this ? > >>>> > >>> Fixed hours ago in 350020. > >> > >> Hours ago. Cool. However is there no CI testing on ppc64? > > > > There is a CI build, in any case: > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ > > > > It showed a failure for build #11532 (r350018): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ > > > > and also how it got fixed in build #11533 (r350020): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ > > > > Unfortunately there is no test job which attempts to fire up a world > > inside e.g. qemu. > > Oh well, thank you for the info. Lucky me that I fell into the exact > same build problem which only happens rarely. Hardly a lottery ticket > win but I am happy to see the CI information. > The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Warner From owner-freebsd-current@freebsd.org Tue Jul 16 18:05:50 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6ABBB6673; Tue, 16 Jul 2019 18:05:50 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9817C6CF8D; Tue, 16 Jul 2019 18:05:50 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id 72DDD19CCB; Tue, 16 Jul 2019 18:05:50 +0000 (UTC) Date: Tue, 16 Jul 2019 18:05:50 +0000 From: Li-Wen Hsu To: freebsd-testing@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: FreeBSD CI Weekly Report 2019-07-14 Message-ID: <20190716180550.GA48239@freefall.freebsd.org> Reply-To: freebsd-testing@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 9817C6CF8D X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.88 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.970,0]; NEURAL_HAM_SHORT(-0.91)[-0.905,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 18:05:50 -0000 (Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2019-07-14 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2019-07-08 to 2019-07-14. During this period, we have: * 1628 builds (97.4% passed, 2.6% failed) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 317 test runs (54.3% passed, 37.5% unstable, 8.2% exception) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 48 doc builds (100% passed) (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/s/Bk5EdrMbB and archive is available at http://hackfoldr.org/freebsd-ci-report/, any help is welcome. ## Fixed Tests * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ * sys.opencrypto.runtests.main Fixed in [r349872](https://reviews.freebsd.org/rS349872) ## Failing Tests * https://ci.freebsd.org/job/FreeBSD-head-i386-test/ * sys.netpfil.pf.forward.v6 * sys.netpfil.pf.forward.v4 * sys.netpfil.pf.set_tos.v4 * Analysis from kp@: * https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001933.html * https://lists.freebsd.org/pipermail/freebsd-testing/2019-June/001934.html * https://ci.freebsd.org/job/FreeBSD-stable-12-i386-test/ * Same as -head: * sys.netpfil.pf.forward.v6 * sys.netpfil.pf.forward.v4 * sys.netpfil.pf.set_tos.v4 * sys.opencrypto.runtests.main * Needs MFC more than r349872. * lib.libregex.exhaust_test.regcomp_too_big * flaky, sometimes failed with: ``` /usr/src/contrib/netbsd-tests/lib/libc/regex/t_exhaust.c:72: p != NULL not met ``` * https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/ * local.kyua.* (31 cases) * local.lutok.* (3 cases) ## Failing and Flaky Tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d https://bugs.freebsd.org/237641 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~60 failing cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details ## Disabled Tests * lib.libc.sys.mmap_test.mmap_truncate_signal https://bugs.freebsd.org/211924 * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * usr.bin.procstat.procstat_test.command_loogle.com/ine_arguments https://bugs.freebsd.org/233587 * usr.bin.procstat.procstat_test.environment https://bugs.freebsd.org/233588 * sys.netinet.socket_afinet.socket_afinet_bind_zero (new) https://bugs.freebsd.org/238781 ## Issues ### Cause build fails * https://bugs.freebsd.org/233735 Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s * https://bugs.freebsd.org/238828 Possible build race: lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSHIPS' undeclared ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic Patch exists: * https://reviews.freebsd.org/D20868 * https://reviews.freebsd.org/D20869 ### Open * https://bugs.freebsd.org/237077 possible race in build: /usr/src/sys/amd64/linux/linux_support.s:38:2: error: expected relocatable expression * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237652 tests.hotspare.hotspare_test.hotspare_snapshot_001_pos timeout since somewhere in (r346814, r 346845] * https://bugs.freebsd.org/237655 Non-deterministic panic when running pf tests in interface ioctl code (NULL passed to strncmp) * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/237657 sys.kern.pdeathsig.signal_delivered_ptrace timing out periodically on i386 * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) * https://issues.tmatesoft.com/issue/SVNKIT-740 The patch is asked to be updated and help wanted. There is a new one at: https://github.com/jenkinsci/svnkit/pull/3/files * https://bugs.freebsd.org/235356 Help on how to reproduce and analyze is wanted. ## Other News * [FCP 20190401-ci_policy: CI policy ](https://github.com/freebsd/fcp/blob/master/fcp-20190401-ci_policy.md) is in "feedback" state, please check and provide comments. From owner-freebsd-current@freebsd.org Tue Jul 16 19:25:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AEBD7B8415 for ; Tue, 16 Jul 2019 19:25:51 +0000 (UTC) (envelope-from jdm7dv@uvawise.edu) Received: from mailout.uvawise.edu (mailout.uvawise.edu [143.60.16.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout.uvawise.edu", Issuer "InCommon RSA Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9A60C70A1F for ; Tue, 16 Jul 2019 19:25:50 +0000 (UTC) (envelope-from jdm7dv@uvawise.edu) Received: from mail.uvawise.edu (cas4.uvawise.edu [143.60.16.191]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailout.uvawise.edu (Postfix) with ESMTPS id 1CF11201FE for ; Tue, 16 Jul 2019 15:25:16 -0400 (EDT) Received: from cas4.uvawise.edu (2002:8f3c:10bf::8f3c:10bf) by cas4.uvawise.edu (2002:8f3c:10bf::8f3c:10bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P521) id 15.1.1713.5; Tue, 16 Jul 2019 15:25:43 -0400 Received: from cas4.uvawise.edu ([fe80::897f:5531:6997:2120]) by cas4.uvawise.edu ([fe80::897f:5531:6997:2120%15]) with mapi id 15.01.1713.007; Tue, 16 Jul 2019 15:25:43 -0400 From: Jonathan Moore To: "freebsd-current@freebsd.org" Subject: FreeBSD in Windows Thread-Topic: FreeBSD in Windows Thread-Index: AQHVPAwQm60w7KHQzEaBG+zTlh0QUg== Date: Tue, 16 Jul 2019 19:25:24 +0000 Message-ID: <2ae9f37d532f48f7bf65f6165be4da7a@uvawise.edu> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [96.69.119.218] MIME-Version: 1.0 X-Rspamd-Queue-Id: 9A60C70A1F X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of jdm7dv@uvawise.edu designates 143.60.16.29 as permitted sender) smtp.mailfrom=jdm7dv@uvawise.edu X-Spamd-Result: default: False [-1.68 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.52)[-0.517,0]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:143.60.16.29/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[uvawise.edu]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.99)[-0.994,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; NEURAL_SPAM_SHORT(0.15)[0.149,0]; MX_GOOD(-0.01)[mailin.uvawise.edu]; RCVD_IN_DNSWL_NONE(0.00)[29.16.60.143.list.dnswl.org : 127.0.10.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; IP_SCORE(-0.01)[country: US(-0.06)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:40723, ipnet:143.60.0.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 19:25:51 -0000 Hi, I need to know and with great detail how Microsoft uses FreeBSD in Windows. Thank You, Jonathan Moore From owner-freebsd-current@freebsd.org Tue Jul 16 19:31:32 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 58C98B8908 for ; Tue, 16 Jul 2019 19:31:32 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 76F1D710EF; Tue, 16 Jul 2019 19:31:30 +0000 (UTC) (envelope-from rea@codelabs.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:Content-Type:MIME-Version:Message-ID:Subject:To:From:Date; bh=UWfFeNlIKFV7CPqaLNPjKVplZ6GxJYI0/UvKss2OeRU=; b=f4ZcJ4DH//rTfC97zKG9+GBKhBl4mMottSCFgEHi36RtmlKW801y6+dix/M5n5VDddKw6WQKcUDFw1dfYMLzZpvuVmEmhO/TcgGsEaRx8ELSwC2pFeZuB2WbUUt+5cTCN6/ZwNzknZuxvBSm95DxJZ2FOIoeYMlDnTugyFe64ZyHNf567MKUSUnLYTeXgVoe5MMuM3JtPAUyUXDQ4WFyObW7s92n2ENSn2xLLO/MmGVvuP7h8ahgM5aTD4olaT89qfuQ0pW+nbtuWmWIFTwozOiK507X0iWCY4712p/lwPY4SgdJjI8+7pm+rsC+S+Afy7MDsQOfwmFMAeM5+t2n09aTlgrVkn5hiRrT0RowoGka1bYxWzG3kXsmYAGe9euYCW4Yy6OuOlv6BWfJdr+ifV6HQwxX/eHgKFEmxA9JrzdH2agNpFbHW7hPe5zplCd5+AzcLR/H8hOpmXu/jXYnlpQZCwYQORm+fxgiQcx7wU/kp66arnaABLbJPmjigmuGzVKzv/HECPY4XBG2xH96nwphkAvo/lPTGM1m1wb8k9OoeQCP3b5WiXG9xI3combIvaNbPOlPvjeVWO31zBWjyOgwKgDQcZwPtlhY/8m4Mwf4/azLYfh+zcbehD8Nm60fDDtwQPOaaZsFRw4kYirL1urfCXqRNE2N7iI8QVuHx1M=; Received: from 109-252-81-81.nat.spd-mgts.ru ([109.252.81.81]:3514 helo=phoenix.codelabs.ru) by mail.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (envelope-from ) id 1hnTAe-000Hqn-EI; Tue, 16 Jul 2019 22:31:28 +0300 Date: Tue, 16 Jul 2019 22:31:24 +0300 From: Eygene Ryabinkin To: freebsd-current@FreeBSD.org, bapt@FreeBSD.org Subject: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gz7utc52kvukndjs" Content-Disposition: inline Sender: rea@codelabs.ru X-Rspamd-Queue-Id: 76F1D710EF X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=codelabs.ru header.s=three header.b=f4ZcJ4DH X-Spamd-Result: default: False [4.26 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_ATTACHMENT(0.00)[]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[0.mx.codelabs.ru]; DKIM_TRACE(0.00)[codelabs.ru:+]; RCPT_COUNT_TWO(0.00)[2]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[rea@freebsd.org,rea@codelabs.ru]; RECEIVED_SPAMHAUS_PBL(0.00)[81.81.252.109.zen.spamhaus.org : 127.0.0.11]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:+]; IP_SCORE(0.55)[ip: (1.45), ipnet: 144.206.224.0/19(0.72), asn: 59624(0.58), country: RU(0.01)]; ASN(0.00)[asn:59624, ipnet:144.206.224.0/19, country:RU]; FROM_NEQ_ENVFROM(0.00)[rea@freebsd.org,rea@codelabs.ru]; MIME_UNKNOWN(0.10)[text/x-diff]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[codelabs.ru:s=three]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.32)[-0.322,0]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.69)[0.694,0]; HFILTER_HELO_BADIP(4.50)[0.mx.codelabs.ru,1]; NEURAL_SPAM_SHORT(0.85)[0.851,0]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 19:31:32 -0000 --gz7utc52kvukndjs Content-Type: multipart/mixed; boundary="cds6ufi5oa7zoiin" Content-Disposition: inline --cds6ufi5oa7zoiin Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Good day. Attached is the patch that makes built-in tbl(1) processor in mandoc to avoid dumping core when it renders the table with empty "T{ T}" block and horizontally-ruled table. The simplest way to reproduce the issue is to either - run 'man notmuch-config' with mail/notmuch installed; - run 'mandoc tests/empty-table-cdata.1' against the attached test-only manpage. With the patch applied, one can utilize 'make check': regression test was added. Perhaps an invocation of {{{ mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests }}} will be needed to run 'make check' without remaking/installing the world. The patch is for the fresh -CURRENT. Be interested in any results of its application and usage. Thanks! P.S.: please, CC me: I am not subscribed to the list. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --cds6ufi5oa7zoiin Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="mandoc-fix-empty-cdata-crash.patch" Content-Transfer-Encoding: quoted-printable mandoc: fix built-in tbl(1) processing of empty continuation blocks Empty "T{ T}" (continuation) blocks produce NULL-valued string for their data block: getdata() allocates structure with string set to NULL and tbl_cdata() will just return when it sees the end ("T}") of the block without any further manipulations with dat->string. This is completely legal; moreover, tbl.h specifies that for 'struct tbl_dat' the 'string' member is NULL when entry type is not TBL_DATA_DATA. This is not so all the time, but one shouldn't rely on this. The segfault in question was plain NULL pointer dereference triggered from tbl_term.c::tbl_hrule(). Added check for dpn->pos not being TBL_DATA_DATA. Also added regression test to find such problems in the future. The real-world case when manpage was provoking core dump is notmuch-config.1 for mail/notmuch port: it is auto-generated =66rom reStructuredText, so has empty blocks at the places where it would be enough just to specify the empty value. Index: usr.bin/mandoc/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/Makefile (revision 349971) +++ usr.bin/mandoc/Makefile (working copy) @@ -101,4 +101,7 @@ CFLAGS.gcc+=3D -Wno-format LIBADD=3D openbsd z =20 +HAS_TESTS=3D +SUBDIR.${MK_TESTS}+=3D tests + .include Index: usr.bin/mandoc/tests/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/Makefile (nonexistent) +++ usr.bin/mandoc/tests/Makefile (working copy) @@ -0,0 +1,11 @@ +# $FreeBSD$ + +PACKAGE=3D tests + +${PACKAGE}FILES+=3D empty-table-cdata.1 + +ATF_TESTS_SH+=3D regression-tests + +BINDIR=3D ${TESTSDIR} + +.include Property changes on: usr.bin/mandoc/tests/Makefile ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/Makefile.depend =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/Makefile.depend (nonexistent) +++ usr.bin/mandoc/tests/Makefile.depend (working copy) @@ -0,0 +1,11 @@ +# $FreeBSD$ +# Autogenerated - do NOT edit! + +DIRDEPS =3D \ + + +.include + +.if ${DEP_RELDIR} =3D=3D ${_DEP_RELDIR} +# local dependencies - needed for -jN in clean tree +.endif Property changes on: usr.bin/mandoc/tests/Makefile.depend ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/empty-table-cdata.1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/empty-table-cdata.1 (nonexistent) +++ usr.bin/mandoc/tests/empty-table-cdata.1 (working copy) @@ -0,0 +1,21 @@ +.\" $FreeBSD$ +. +.TH EMPTY-TABLE-CDATA 1 1970-01-01 +.SH Empty table cdata test for tbl processor +. +.PP +The following table should not make mandoc to dump core: +. +.TS +|l|l|. +_ +A test +_ +table T{ +T} +_ +.TE +. +.SH Author +.PP +Eygene Ryabinkin, . Property changes on: usr.bin/mandoc/tests/empty-table-cdata.1 ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/regression-tests.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/regression-tests.sh (nonexistent) +++ usr.bin/mandoc/tests/regression-tests.sh (working copy) @@ -0,0 +1,20 @@ +# $FreeBSD$ + + +SRCDIR=3D$(atf_get_srcdir) + + +atf_test_case empty_table_cdata +empty_table_cdata_head() { + atf_set "descr" "Normal processing of empty T{ T} blocks in tables" +} +empty_table_cdata_body() { + local mandoc=3D$(atf_config_get usr.bin.mandoc.test_mandoc /usr/bin/mando= c) + + atf_check -s exit: -o not-empty $mandoc "$SRCDIR"/empty-table-cdata.1 +} + + +atf_init_test_cases() { + atf_add_test_case empty_table_cdata +} Property changes on: usr.bin/mandoc/tests/regression-tests.sh ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:executable ## -0,0 +1 ## +* \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: etc/mtree/BSD.tests.dist =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- etc/mtree/BSD.tests.dist (revision 349971) +++ etc/mtree/BSD.tests.dist (working copy) @@ -1004,6 +1004,8 @@ .. m4 .. + mandoc + .. mkimg .. ncal Index: contrib/mandoc/tbl_term.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/mandoc/tbl_term.c (revision 349971) +++ contrib/mandoc/tbl_term.c (working copy) @@ -626,7 +626,8 @@ =20 lw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || (cpn->pos !=3D TBL_CELL_DOWN && - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) + (dpn =3D=3D NULL || dpn->pos !=3D TBL_DATA_DATA || + strcmp(dpn->string, "\\^") !=3D 0)) ? hw : 0; tbl_direct_border(tp, BHORIZ * lw, col->width + col->spacing / 2); @@ -670,7 +671,8 @@ =20 rw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || (cpn->pos !=3D TBL_CELL_DOWN && - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) + (dpn =3D=3D NULL || dpn->pos !=3D TBL_DATA_DATA || + strcmp(dpn->string, "\\^") !=3D 0)) ? hw : 0; =20 /* The line crossing at the end of this column. */ --cds6ufi5oa7zoiin Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="empty-table-cdata.1" .\" $FreeBSD$ . .TH EMPTY-TABLE-CDATA 1 1970-01-01 .SH Empty table cdata test for tbl processor . .PP The following table should not make mandoc to dump core: . .TS |l|l|. _ A test _ table T{ T} _ .TE . .SH Author .PP Eygene Ryabinkin, . --cds6ufi5oa7zoiin-- --gz7utc52kvukndjs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABEKAH0WIQSC/ga81JfA3knsT/AWr56ugVLs+wUCXS4mB18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0ODJG RTA2QkNENDk3QzBERTQ5RUM0RkYwMTZBRjlFQUU4MTUyRUNGQgAKCRAWr56ugVLs +3yMAP9Qi6AhAa+Te9ckPanrkwn1yQlkNJ7Ijzpk2uqLr6x5qQD/Wv9q8un/WYxm eaxYMUayUFoVumCdva9hBw9yPrTa5V4= =lWaK -----END PGP SIGNATURE----- --gz7utc52kvukndjs-- From owner-freebsd-current@freebsd.org Tue Jul 16 21:32:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0EE54BAF0A for ; Tue, 16 Jul 2019 21:32:31 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from atl4mhob09.registeredsite.com (atl4mhob09.registeredsite.com [209.17.115.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 62BA576160 for ; Tue, 16 Jul 2019 21:32:30 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail01pod2.registeredsite.com [10.30.77.35]) by atl4mhob09.registeredsite.com (8.14.4/8.14.4) with ESMTP id x6GLWRCG006691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Jul 2019 17:32:27 -0400 Received: (qmail 40413 invoked by uid 0); 16 Jul 2019 21:32:27 -0000 X-TCPREMOTEIP: 99.253.177.25 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.3?) (dclarke@blastwave.org@99.253.177.25) by 0 with ESMTPA; 16 Jul 2019 21:32:27 -0000 Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: freebsd-current@freebsd.org References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> From: Dennis Clarke Message-ID: <0c62bb43-8e61-512e-d2fd-1db3c4c036d6@blastwave.org> Date: Tue, 16 Jul 2019 17:32:26 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 62BA576160 X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.96 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(1.00)[0.997,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: mx1.netsolmail.net]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[47.115.17.209.list.dnswl.org : 127.0.5.0]; NEURAL_SPAM_MEDIUM(0.99)[0.985,0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:209.17.112.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(1.09)[ip: (2.26), ipnet: 209.17.112.0/21(1.80), asn: 19871(1.44), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 21:32:31 -0000 > The window would have been smaller. CI detected the breakage within 10 > minutes, but I was away from my email attending to some household things > for an hour more... > Ha! Sometimes I hear people even sleep ? I was just thinking the probability of landing in that one failed buildworld was real real small and somehow myself and a few others managed to do it. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From owner-freebsd-current@freebsd.org Tue Jul 16 21:37:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0A217BB1F0 for ; Tue, 16 Jul 2019 21:37:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5CF9C7653D for ; Tue, 16 Jul 2019 21:37:50 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x836.google.com with SMTP id d23so21222097qto.2 for ; Tue, 16 Jul 2019 14:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=db6gwSgtg2u78YzZUNsvKDAd3pg9o90E6XDy0jOD6aw=; b=vNInjdIBdS9D6WgNxapuOZLfbXZBCQAv/5DShBlOLSYzNh19NpdwVjQIhkAhHJEwR5 KcPL9ronfgkKDMgUqHUId7aCdDhaxxxZQ/A5f/OGZ5N27648u6vEOy9/afaVj8g/3hqV 9O4eQnjAeHLFqf4P5KAbEkB0mzSeMWpBBek4olERiYTUK+mN1kVYFcZ/Z0UgylJ3+IJ5 wnYvOZ5bDqVfPAJWpyt+koDmoe0aEJ4Y9qmyZaLPGMxpU48BW0qYcCTTWy2dVL4rFeF1 zbJiUfu95oPI6llbuGgTp3TislF/0Dok+J9IM0vg1D/6X49lrks2aup5/djAJFFsZsVt DUQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=db6gwSgtg2u78YzZUNsvKDAd3pg9o90E6XDy0jOD6aw=; b=rIMtcTLRU+HJEHih/qu0lvqOOmv/BohXT6epSB8gSAqV67RrII+kdN174TKXY02XL+ DZ6L74vAFcyXB+dJwz9vyfM+dCJ71j8y92DitxS+KZ40tTtbiAwBQyh/2LiqT9PLom1K MCKeOSTefzN3ILkySPCTZUtq12MdtyBF7WcZ2bbe9SyWkWtFSLwYx9FRbpJHZZjHNjzr 9d6gdGEfh1mIrVf3aQ5kZWNreYAXk98NMqmmPD0ROh9EJUeoezb+MYunuKMt/WihsMal qAPVIlKJns95Xw7Dq+JhMO4RTqBMTZi3+EppdtVbuOOpoAfQgU0GIs20rHVWI15Awsdx /ZOQ== X-Gm-Message-State: APjAAAVFqB2xs19ZvqeXve6LrsyjtZw9fzR6PzHgEbduo9WYJl4iEt00 AxvqOzbNDPaMyKZmnj4O4euAIsssjcHil25wzOWzRQ== X-Google-Smtp-Source: APXvYqzhH1AXDaMjuNcDIL76aaDn5Cy29KW3hY4Ypi0/TegynEzj0uG+sZKFPnKU98K1GJpNPd5PdXi4Xlwlb+CCLPo= X-Received: by 2002:a0c:acfb:: with SMTP id n56mr25873588qvc.87.1563313069538; Tue, 16 Jul 2019 14:37:49 -0700 (PDT) MIME-Version: 1.0 References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> <0c62bb43-8e61-512e-d2fd-1db3c4c036d6@blastwave.org> In-Reply-To: <0c62bb43-8e61-512e-d2fd-1db3c4c036d6@blastwave.org> From: Warner Losh Date: Tue, 16 Jul 2019 15:37:38 -0600 Message-ID: Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: Dennis Clarke Cc: FreeBSD Current X-Rspamd-Queue-Id: 5CF9C7653D X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=vNInjdIB X-Spamd-Result: default: False [-5.44 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.94)[-0.941,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_SHORT(-0.50)[-0.501,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[6.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-2.99)[ip: (-9.29), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.45), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 21:37:51 -0000 On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: > > > The window would have been smaller. CI detected the breakage within 10 > > minutes, but I was away from my email attending to some household things > > for an hour more... > > > > Ha! Sometimes I hear people even sleep ? > > I was just thinking the probability of landing in that one failed > buildworld was real real small and somehow myself and a few others > managed to do it. > The changes survived a buildworld on amd64. I had no reason to even suspect they might be troublesome on other archs. Since I have a busy day, I took a shortcut. I don't build universe for every change, there's simply not time. So it's more complicated than you're trying to paint. Warner From owner-freebsd-current@freebsd.org Tue Jul 16 21:43:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 10AEABB63C for ; Tue, 16 Jul 2019 21:43:25 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from atl4mhob02.registeredsite.com (atl4mhob02.registeredsite.com [209.17.115.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.registeredsite.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6BF4476AEA for ; Tue, 16 Jul 2019 21:43:24 +0000 (UTC) (envelope-from dclarke@blastwave.org) Received: from mailpod.hostingplatform.com (atl4qobmail02pod2.registeredsite.com [10.30.77.36]) by atl4mhob02.registeredsite.com (8.14.4/8.14.4) with ESMTP id x6GLhGx7002640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 16 Jul 2019 17:43:16 -0400 Received: (qmail 30955 invoked by uid 0); 16 Jul 2019 21:43:16 -0000 X-TCPREMOTEIP: 99.253.177.25 X-Authenticated-UID: dclarke@blastwave.org Received: from unknown (HELO ?172.16.35.3?) (dclarke@blastwave.org@99.253.177.25) by 0 with ESMTPA; 16 Jul 2019 21:43:16 -0000 Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: freebsd-current@freebsd.org References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> <0c62bb43-8e61-512e-d2fd-1db3c4c036d6@blastwave.org> From: Dennis Clarke Message-ID: <8528ddc7-e8dd-3daf-d8a0-95c78d850fcc@blastwave.org> Date: Tue, 16 Jul 2019 17:43:15 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6BF4476AEA X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [4.91 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.94)[0.943,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: mx1.netsolmail.net]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[40.115.17.209.list.dnswl.org : 127.0.5.0]; NEURAL_SPAM_MEDIUM(0.98)[0.980,0]; R_SPF_NA(0.00)[]; DMARC_NA(0.00)[blastwave.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:19871, ipnet:209.17.112.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(1.10)[ip: (2.30), ipnet: 209.17.112.0/21(1.80), asn: 19871(1.44), country: US(-0.06)] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 21:43:25 -0000 On 7/16/19 5:37 PM, Warner Losh wrote: > On Tue, Jul 16, 2019 at 3:32 PM Dennis Clarke wrote: > >> >>> The window would have been smaller. CI detected the breakage within 10 >>> minutes, but I was away from my email attending to some household things >>> for an hour more... >>> >> >> Ha! Sometimes I hear people even sleep ? >> >> I was just thinking the probability of landing in that one failed >> buildworld was real real small and somehow myself and a few others >> managed to do it. >> > > The changes survived a buildworld on amd64. I had no reason to even suspect > they might be troublesome on other archs. Since I have a busy day, I took a > shortcut. I don't build universe for every change, there's simply not time. > So it's more complicated than you're trying to paint. I am not trying to paint anything. I know there are a few of us with limited time and limited resources and we are all just doing what we can. In spite of this we have an open source UNIX with ZFS running. On more than just x86 little boxen. So we can expect bumps in the road : a typical bump in the road for ppc64 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239245 Yep .. changes happen and things break. Such is life. -- Dennis Clarke RISC-V/SPARC/PPC/ARM/CISC UNIX and Linux spoken GreyBeard and suspenders optional From owner-freebsd-current@freebsd.org Wed Jul 17 07:12:03 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E28EFA5322 for ; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C06186B523; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 99787150F9; Wed, 17 Jul 2019 07:12:03 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 1B7CCC0889; Wed, 17 Jul 2019 09:12:02 +0200 (CEST) Date: Wed, 17 Jul 2019 09:12:02 +0200 From: Baptiste Daroussin To: Eygene Ryabinkin Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190717071201.beem6et6dybhby7m@ivaldir.net> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="725xz2rmc4ukfxl2" Content-Disposition: inline In-Reply-To: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: C06186B523 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2019 07:12:03 -0000 --725xz2rmc4ukfxl2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote: > Good day. >=20 > Attached is the patch that makes built-in tbl(1) processor in mandoc > to avoid dumping core when it renders the table with empty "T{ T}" > block and horizontally-ruled table. >=20 > The simplest way to reproduce the issue is to either > - run 'man notmuch-config' with mail/notmuch installed; > - run 'mandoc tests/empty-table-cdata.1' against the attached > test-only manpage. >=20 > With the patch applied, one can utilize 'make check': regression > test was added. Perhaps an invocation of > {{{ > mtree -deU -f /usr/src/etc/mtree/BSD.tests.dist -p /usr/tests > }}} > will be needed to run 'make check' without remaking/installing > the world. >=20 > The patch is for the fresh -CURRENT. Be interested in any results > of its application and usage. >=20 > Thanks! >=20 > P.S.: please, CC me: I am not subscribed to the list. > --=20 > Eygene Ryabinkin ,,,^..^,,, > [ Life's unfair - but root password helps! | codelabs.ru ] > [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] Hello, Thank you for the patch! Have it been discussed with upstream? I kind of re= mind something like this being reported to upstream, but I haven't checked the status. Best regards, Bapt --725xz2rmc4ukfxl2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0uykEACgkQY4mL3PG3 PlplQQ/9HfYngYZrPKLVUczfqzkOfZHp/lm0N9QfvGgnuGePAMpiruLyvAF4Iaom g1mKM9FVmga40ccbg+GGeqrdPzqJBExrdgykfaiOYPzadJuuvGKMZTJXcpMUXhOP hasyw+uf8dY+PuA09uvRPhsaqTrHMf+qyKNIj2r+/+MOUV2bk1pRHQVXB7WxcYRm u0/oeW7Kkjm8LyMPR/2MNF4bhx5v4vupZfgXF99v4s3KV6L01BP6+sXNyhg+Pk0O FN+Uwzqq5FTcPFu4I+so8zU7ManuX0NHOGHK9eEIEP65wIh65BTGP2qexWtOsuyv VlOqn/Q4+ZjIACtZPhZx0rjPUOGG8SaqCJc3CS/HTKn4tWOAoPbHOvZT1XFlzmn6 +8kGLqZ9khIEiYfSmDDQxiZV4S1bNoNBDd/16CTFWUfUThJaJUocJ3dnAR4kv6Xq TGLoWtJ7lSqTrcWZMj3ulBv6xqrtsdU63MfFjnYIj2fXWD/cI1X79uMPD0omvQ/9 gtsOKgq8QEipvg2fewg2mdd8bFPNNq8vUZcBZ1sqBJVj8RJMmXJpIfexaWNNXI7a nQtbmal1eLOMvTrZh/W3NRUBKXArF6fTCVJHb5vUfzB6bdIiTR/V90rJVTnJ3afb bTcTENutdicIQlZvHhf761dkgguo9MCs9kK0ahyepLS/9AdBclw= =7Yds -----END PGP SIGNATURE----- --725xz2rmc4ukfxl2-- From owner-freebsd-current@freebsd.org Wed Jul 17 10:39:48 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B931A8E9A for ; Wed, 17 Jul 2019 10:39:48 +0000 (UTC) (envelope-from rea@codelabs.ru) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4423F7296E; Wed, 17 Jul 2019 10:39:45 +0000 (UTC) (envelope-from rea@codelabs.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=214ncPdR4JILLyUFw5SvoiuvsY8MbyY2HLMzcswiWBo=; b=xGU3uuMOURYG5up8wN15sAiwXvX6qSH7DscYnL9KMcDTgcv4h61vIS6HPSGi68/xrN6cnhzSKouzHNCc+LfeiK/5n2X7mnV7tzq52fopOMs/gZw59R4O4UXkoT+xii5KpK8VrZrUiInMkQmhwd+3vviJ3TgFy+JU0581WZruVbapaK3C0BXvq+XRxkWCAMu0a/hdPUJzJJKHy7GVAcSpJ6MD4b+W1kQlmVUEEgpTICECx6RQ6YbuFl9u3Cqw513JB++k8HuMsC0BYr49e2LwPJbgukNRZ7+pgkp05z/GhqzUw+x7MrPBDQvpY5JaR9gF7XQjt3DHYWyRzadyQP+TcFcnjX+mLTXrsOhf8wvW87EeQKBHjn1U7TIRVHWaV8WEWxlZdBZf2zo6w+hNFEzUVqtnqjdH8aKguMPYOvGmBihUkqZPkwvYw/dzEs3vIOjGb491vCk7Ne4Iep8nOyxDsFWAAlgQkxBBMz23ckQIVZRvKAMvRuok2Sq0eYTbAxwwNZ9LmB3ign8Y2UIuy988n2QAEC5SUYLtRhJ2VlU7fEM7L9bDSOc+0ycbhBOoFL3SFXKLvEH5owCKH2dvtrjDcuL5jID4L6patZH/uFhpKrQyqXNmkntpdjUHVgXextgpNidDz4vgEaOJtIctjovXuJi49I/YJRkjQISWUOvODTk=; Received: from void.codelabs.ru ([144.206.233.66]:35704) by mail.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (envelope-from ) id 1hnhLb-000Kvx-N9; Wed, 17 Jul 2019 13:39:43 +0300 Date: Wed, 17 Jul 2019 13:39:42 +0300 From: Eygene Ryabinkin To: Baptiste Daroussin Cc: freebsd-current@FreeBSD.org Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190717103942.fkunwe3utxvmdc5n@void.codelabs.ru> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> <20190717071201.beem6et6dybhby7m@ivaldir.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nzno7o2fwb6xlvhr" Content-Disposition: inline In-Reply-To: <20190717071201.beem6et6dybhby7m@ivaldir.net> Sender: rea@codelabs.ru X-Rspamd-Queue-Id: 4423F7296E X-Spamd-Bar: ++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=codelabs.ru header.s=three header.b=xGU3uuMO X-Spamd-Result: default: False [4.14 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[codelabs.ru:s=three]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.48)[-0.485,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.76)[0.763,0]; HFILTER_HELO_BADIP(4.50)[0.mx.codelabs.ru,1]; NEURAL_SPAM_SHORT(0.95)[0.954,0]; MX_GOOD(-0.01)[cached: 0.mx.codelabs.ru]; DKIM_TRACE(0.00)[codelabs.ru:+]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[rea@freebsd.org,rea@codelabs.ru]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:+]; IP_SCORE(0.52)[ip: (1.35), ipnet: 144.206.224.0/19(0.68), asn: 59624(0.54), country: RU(0.01)]; ASN(0.00)[asn:59624, ipnet:144.206.224.0/19, country:RU]; FROM_NEQ_ENVFROM(0.00)[rea@freebsd.org,rea@codelabs.ru]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2019 10:39:48 -0000 --nzno7o2fwb6xlvhr Content-Type: multipart/mixed; boundary="mg6b44fawrvf627e" Content-Disposition: inline --mg6b44fawrvf627e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Baptiste, good day. Wed, Jul 17, 2019 at 09:12:02AM +0200, Baptiste Daroussin wrote: > On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote: > > Attached is the patch that makes built-in tbl(1) processor in > > mandoc to avoid dumping core when it renders the table with empty > > "T{ T}" block and horizontally-ruled table. > > Thank you for the patch! Have it been discussed with upstream? I > kind of remind something like this being reported to upstream, but I > haven't checked the status. Was fixed: https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.69&r2=3D1.70 https://github.com/openbsd/src/commit/5f6e3232931ab08da9c8121d568c8207c0c= 4662c#diff-bc5842dc5d7897de7bdac08f74804c57 A bit differently: people just check for dpn->string being NULL. And there is another one NULL pointer fix, https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.70&r2=3D1.71 https://github.com/openbsd/src/commit/7514a273fe4561e94f1277f4ee5991c9af9= cba2e#diff-bc5842dc5d7897de7bdac08f74804c57 Can't trigger it with upstream's testcase, https://mandoc.bsd.lv/cgi-bin/cvsweb/regress/tbl/layout/shortlines.in?rev= =3D1.1&content-type=3Dtext/x-cvsweb-markup https://raw.githubusercontent.com/openbsd/src/7514a273fe4561e94f1277f4ee5= 991c9af9cba2e/regress/usr.bin/mandoc/tbl/layout/shortlines.in since current FreeBSD's mandoc lacks this modification, https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.68&r2=3D1.69 https://github.com/openbsd/src/commit/b3e6a3251dfa92e66aa539518119564bd19= 45cc0#diff-bc5842dc5d7897de7bdac08f74804c57 but I believe that 'cpp' still can be NULL and will try to see if it is triggerable. So, the patch that corresponds to the upstream change is attached. Nothing was released after 1.14.5 (yet). What will be the route? Will you - wait for the new release; - if yes, will you incorporate the testing part? - if no, I think you will use the closer-to-upstream patch? Thanks. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --mg6b44fawrvf627e Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="mandoc-fix-empty-cdata-crash--upstream-ver.patch" Content-Transfer-Encoding: quoted-printable mandoc: fix built-in tbl(1) processing of empty continuation blocks Empty "T{ T}" (continuation) blocks produce NULL-valued string for their data block: getdata() allocates structure with string set to NULL and tbl_cdata() will just return when it sees the end ("T}") of the block without any further manipulations with dat->string. This is completely legal; moreover, tbl.h specifies that for 'struct tbl_dat' the 'string' member is NULL when entry type is not TBL_DATA_DATA. This is not so all the time, but one shouldn't rely on this. The segfault in question was plain NULL pointer dereference triggered from tbl_term.c::tbl_hrule(). Added check for dpn->string not being NULL to be in sync with upstream, https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.69&r2=3D1.70 Also added regression test to find such problems in the future. The real-world case when manpage was provoking core dump is notmuch-config.1 for mail/notmuch port: it is auto-generated =66rom reStructuredText, so has empty blocks at the places where it would be enough just to specify the empty value. Index: usr.bin/mandoc/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/Makefile (revision 349971) +++ usr.bin/mandoc/Makefile (working copy) @@ -101,4 +101,7 @@ CFLAGS.gcc+=3D -Wno-format LIBADD=3D openbsd z =20 +HAS_TESTS=3D +SUBDIR.${MK_TESTS}+=3D tests + .include Index: usr.bin/mandoc/tests/Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/Makefile (nonexistent) +++ usr.bin/mandoc/tests/Makefile (working copy) @@ -0,0 +1,11 @@ +# $FreeBSD$ + +PACKAGE=3D tests + +${PACKAGE}FILES+=3D empty-table-cdata.1 + +ATF_TESTS_SH+=3D regression-tests + +BINDIR=3D ${TESTSDIR} + +.include Property changes on: usr.bin/mandoc/tests/Makefile ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/Makefile.depend =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/Makefile.depend (nonexistent) +++ usr.bin/mandoc/tests/Makefile.depend (working copy) @@ -0,0 +1,11 @@ +# $FreeBSD$ +# Autogenerated - do NOT edit! + +DIRDEPS =3D \ + + +.include + +.if ${DEP_RELDIR} =3D=3D ${_DEP_RELDIR} +# local dependencies - needed for -jN in clean tree +.endif Property changes on: usr.bin/mandoc/tests/Makefile.depend ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/empty-table-cdata.1 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/empty-table-cdata.1 (nonexistent) +++ usr.bin/mandoc/tests/empty-table-cdata.1 (working copy) @@ -0,0 +1,21 @@ +.\" $FreeBSD$ +. +.TH EMPTY-TABLE-CDATA 1 1970-01-01 +.SH Empty table cdata test for tbl processor +. +.PP +The following table should not make mandoc to dump core: +. +.TS +|l|l|. +_ +A test +_ +table T{ +T} +_ +.TE +. +.SH Author +.PP +Eygene Ryabinkin, . Property changes on: usr.bin/mandoc/tests/empty-table-cdata.1 ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: usr.bin/mandoc/tests/regression-tests.sh =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- usr.bin/mandoc/tests/regression-tests.sh (nonexistent) +++ usr.bin/mandoc/tests/regression-tests.sh (working copy) @@ -0,0 +1,20 @@ +# $FreeBSD$ + + +SRCDIR=3D$(atf_get_srcdir) + + +atf_test_case empty_table_cdata +empty_table_cdata_head() { + atf_set "descr" "Normal processing of empty T{ T} blocks in tables" +} +empty_table_cdata_body() { + local mandoc=3D$(atf_config_get usr.bin.mandoc.test_mandoc /usr/bin/mando= c) + + atf_check -s exit: -o not-empty $mandoc "$SRCDIR"/empty-table-cdata.1 +} + + +atf_init_test_cases() { + atf_add_test_case empty_table_cdata +} Property changes on: usr.bin/mandoc/tests/regression-tests.sh ___________________________________________________________________ Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:executable ## -0,0 +1 ## +* \ No newline at end of property Added: svn:keywords ## -0,0 +1 ## +FreeBSD=3D%H \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property Index: etc/mtree/BSD.tests.dist =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- etc/mtree/BSD.tests.dist (revision 349971) +++ etc/mtree/BSD.tests.dist (working copy) @@ -1004,6 +1004,8 @@ .. m4 .. + mandoc + .. mkimg .. ncal Index: contrib/mandoc/tbl_term.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- contrib/mandoc/tbl_term.c (revision 349971) +++ contrib/mandoc/tbl_term.c (working copy) @@ -626,7 +626,8 @@ =20 lw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || (cpn->pos !=3D TBL_CELL_DOWN && - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) + (dpn =3D=3D NULL || dpn->string =3D=3D NULL || + strcmp(dpn->string, "\\^") !=3D 0)) ? hw : 0; tbl_direct_border(tp, BHORIZ * lw, col->width + col->spacing / 2); @@ -670,7 +671,8 @@ =20 rw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || (cpn->pos !=3D TBL_CELL_DOWN && - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) + (dpn =3D=3D NULL || dpn->string =3D=3D NULL || + strcmp(dpn->string, "\\^") !=3D 0)) ? hw : 0; =20 /* The line crossing at the end of this column. */ --mg6b44fawrvf627e-- --nzno7o2fwb6xlvhr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABEKAH0WIQSC/ga81JfA3knsT/AWr56ugVLs+wUCXS766V8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0ODJG RTA2QkNENDk3QzBERTQ5RUM0RkYwMTZBRjlFQUU4MTUyRUNGQgAKCRAWr56ugVLs +7DYAQCYSOj28O7ejYIzX24D9QCfdJ0TOT3TekFAvf7PO8Ji9AD+J55WeU82unCy hp721dQnO+v65hpTl08ug2NWSVMT3GY= =Dqau -----END PGP SIGNATURE----- --nzno7o2fwb6xlvhr-- From owner-freebsd-current@freebsd.org Wed Jul 17 11:16:58 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17883A9E37 for ; Wed, 17 Jul 2019 11:16:58 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B19B074736; Wed, 17 Jul 2019 11:16:57 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 61B3F16E88; Wed, 17 Jul 2019 11:16:57 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 54FE1C097F; Wed, 17 Jul 2019 13:16:56 +0200 (CEST) Date: Wed, 17 Jul 2019 13:16:56 +0200 From: Baptiste Daroussin To: Eygene Ryabinkin Cc: freebsd-current@FreeBSD.org, tech@mandoc.bsd.lv Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190717111655.eyq673itr76fj224@ivaldir.net> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> <20190717071201.beem6et6dybhby7m@ivaldir.net> <20190717103942.fkunwe3utxvmdc5n@void.codelabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fqf72zv4xfpkmw3d" Content-Disposition: inline In-Reply-To: <20190717103942.fkunwe3utxvmdc5n@void.codelabs.ru> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: B19B074736 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jul 2019 11:16:58 -0000 --fqf72zv4xfpkmw3d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 17, 2019 at 01:39:42PM +0300, Eygene Ryabinkin wrote: > Baptiste, good day. >=20 > Wed, Jul 17, 2019 at 09:12:02AM +0200, Baptiste Daroussin wrote: > > On Tue, Jul 16, 2019 at 10:31:24PM +0300, Eygene Ryabinkin wrote: > > > Attached is the patch that makes built-in tbl(1) processor in > > > mandoc to avoid dumping core when it renders the table with empty > > > "T{ T}" block and horizontally-ruled table. > > > > Thank you for the patch! Have it been discussed with upstream? I > > kind of remind something like this being reported to upstream, but I > > haven't checked the status. >=20 > Was fixed: > https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.69&r2=3D1.70 > https://github.com/openbsd/src/commit/5f6e3232931ab08da9c8121d568c8207c= 0c4662c#diff-bc5842dc5d7897de7bdac08f74804c57 > A bit differently: people just check for dpn->string being NULL. >=20 > And there is another one NULL pointer fix, > https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.70&r2=3D1.71 > https://github.com/openbsd/src/commit/7514a273fe4561e94f1277f4ee5991c9a= f9cba2e#diff-bc5842dc5d7897de7bdac08f74804c57 > Can't trigger it with upstream's testcase, > https://mandoc.bsd.lv/cgi-bin/cvsweb/regress/tbl/layout/shortlines.in?r= ev=3D1.1&content-type=3Dtext/x-cvsweb-markup > https://raw.githubusercontent.com/openbsd/src/7514a273fe4561e94f1277f4e= e5991c9af9cba2e/regress/usr.bin/mandoc/tbl/layout/shortlines.in > since current FreeBSD's mandoc lacks this modification, > https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.68&r2=3D1.69 > https://github.com/openbsd/src/commit/b3e6a3251dfa92e66aa539518119564bd= 1945cc0#diff-bc5842dc5d7897de7bdac08f74804c57 > but I believe that 'cpp' still can be NULL and will try to see > if it is triggerable. >=20 > So, the patch that corresponds to the upstream change is attached. >=20 > Nothing was released after 1.14.5 (yet). What will be the route? > Will you > - wait for the new release; > - if yes, will you incorporate the testing part? > - if no, I think you will use the closer-to-upstream patch? >=20 > Thanks. Thank you for the patch and the test case, with mandoc, usually I try to be= as close as upstream as possible (targetting 100% ;). So my approach in such case is to move to a snapshot of their cvs tree (as = soon as it has the fix incorporated). As for the test case, the best would be that this test ends up incorporated= in the upstream testsuite (note that I need to plug it into our test framework one day) I added the tech mailing list of mandoc in CC to give a chance to = Ingo to step on this. I will be off for a week starting tonight, but I will update to the latest snapshot of mandoc once back.o We can still integrate some test case of our own as well, and I will be hap= py to integrate yours if not integrated in the upstream testsuite. Best regards, Bapt > --=20 > Eygene Ryabinkin ,,,^..^,,, > [ Life's unfair - but root password helps! | codelabs.ru ] > [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] > mandoc: fix built-in tbl(1) processing of empty continuation blocks >=20 > Empty "T{ T}" (continuation) blocks produce NULL-valued string > for their data block: getdata() allocates structure with string > set to NULL and tbl_cdata() will just return when it sees > the end ("T}") of the block without any further manipulations > with dat->string. >=20 > This is completely legal; moreover, tbl.h specifies that for > 'struct tbl_dat' the 'string' member is NULL when entry type > is not TBL_DATA_DATA. This is not so all the time, but one > shouldn't rely on this. >=20 > The segfault in question was plain NULL pointer dereference > triggered from tbl_term.c::tbl_hrule(). >=20 > Added check for dpn->string not being NULL to be in sync > with upstream, > https://mandoc.bsd.lv/cgi-bin/cvsweb/tbl_term.c.diff?r1=3D1.69&r2=3D1.70 > Also added regression test to find such problems in the future. >=20 > The real-world case when manpage was provoking core dump > is notmuch-config.1 for mail/notmuch port: it is auto-generated > from reStructuredText, so has empty blocks at the places where > it would be enough just to specify the empty value. >=20 > Index: usr.bin/mandoc/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.bin/mandoc/Makefile (revision 349971) > +++ usr.bin/mandoc/Makefile (working copy) > @@ -101,4 +101,7 @@ > CFLAGS.gcc+=3D -Wno-format > LIBADD=3D openbsd z > =20 > +HAS_TESTS=3D > +SUBDIR.${MK_TESTS}+=3D tests > + > .include > Index: usr.bin/mandoc/tests/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.bin/mandoc/tests/Makefile (nonexistent) > +++ usr.bin/mandoc/tests/Makefile (working copy) > @@ -0,0 +1,11 @@ > +# $FreeBSD$ > + > +PACKAGE=3D tests > + > +${PACKAGE}FILES+=3D empty-table-cdata.1 > + > +ATF_TESTS_SH+=3D regression-tests > + > +BINDIR=3D ${TESTSDIR} > + > +.include >=20 > Property changes on: usr.bin/mandoc/tests/Makefile > ___________________________________________________________________ > Added: svn:eol-style > ## -0,0 +1 ## > +native > \ No newline at end of property > Added: svn:keywords > ## -0,0 +1 ## > +FreeBSD=3D%H > \ No newline at end of property > Added: svn:mime-type > ## -0,0 +1 ## > +text/plain > \ No newline at end of property > Index: usr.bin/mandoc/tests/Makefile.depend > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.bin/mandoc/tests/Makefile.depend (nonexistent) > +++ usr.bin/mandoc/tests/Makefile.depend (working copy) > @@ -0,0 +1,11 @@ > +# $FreeBSD$ > +# Autogenerated - do NOT edit! > + > +DIRDEPS =3D \ > + > + > +.include > + > +.if ${DEP_RELDIR} =3D=3D ${_DEP_RELDIR} > +# local dependencies - needed for -jN in clean tree > +.endif >=20 > Property changes on: usr.bin/mandoc/tests/Makefile.depend > ___________________________________________________________________ > Added: svn:eol-style > ## -0,0 +1 ## > +native > \ No newline at end of property > Added: svn:keywords > ## -0,0 +1 ## > +FreeBSD=3D%H > \ No newline at end of property > Added: svn:mime-type > ## -0,0 +1 ## > +text/plain > \ No newline at end of property > Index: usr.bin/mandoc/tests/empty-table-cdata.1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.bin/mandoc/tests/empty-table-cdata.1 (nonexistent) > +++ usr.bin/mandoc/tests/empty-table-cdata.1 (working copy) > @@ -0,0 +1,21 @@ > +.\" $FreeBSD$ > +. > +.TH EMPTY-TABLE-CDATA 1 1970-01-01 > +.SH Empty table cdata test for tbl processor > +. > +.PP > +The following table should not make mandoc to dump core: > +. > +.TS > +|l|l|. > +_ > +A test > +_ > +table T{ > +T} > +_ > +.TE > +. > +.SH Author > +.PP > +Eygene Ryabinkin, . >=20 > Property changes on: usr.bin/mandoc/tests/empty-table-cdata.1 > ___________________________________________________________________ > Added: svn:eol-style > ## -0,0 +1 ## > +native > \ No newline at end of property > Added: svn:keywords > ## -0,0 +1 ## > +FreeBSD=3D%H > \ No newline at end of property > Added: svn:mime-type > ## -0,0 +1 ## > +text/plain > \ No newline at end of property > Index: usr.bin/mandoc/tests/regression-tests.sh > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- usr.bin/mandoc/tests/regression-tests.sh (nonexistent) > +++ usr.bin/mandoc/tests/regression-tests.sh (working copy) > @@ -0,0 +1,20 @@ > +# $FreeBSD$ > + > + > +SRCDIR=3D$(atf_get_srcdir) > + > + > +atf_test_case empty_table_cdata > +empty_table_cdata_head() { > + atf_set "descr" "Normal processing of empty T{ T} blocks in tables" > +} > +empty_table_cdata_body() { > + local mandoc=3D$(atf_config_get usr.bin.mandoc.test_mandoc /usr/bin/man= doc) > + > + atf_check -s exit: -o not-empty $mandoc "$SRCDIR"/empty-table-cdata.1 > +} > + > + > +atf_init_test_cases() { > + atf_add_test_case empty_table_cdata > +} >=20 > Property changes on: usr.bin/mandoc/tests/regression-tests.sh > ___________________________________________________________________ > Added: svn:eol-style > ## -0,0 +1 ## > +native > \ No newline at end of property > Added: svn:executable > ## -0,0 +1 ## > +* > \ No newline at end of property > Added: svn:keywords > ## -0,0 +1 ## > +FreeBSD=3D%H > \ No newline at end of property > Added: svn:mime-type > ## -0,0 +1 ## > +text/plain > \ No newline at end of property > Index: etc/mtree/BSD.tests.dist > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- etc/mtree/BSD.tests.dist (revision 349971) > +++ etc/mtree/BSD.tests.dist (working copy) > @@ -1004,6 +1004,8 @@ > .. > m4 > .. > + mandoc > + .. > mkimg > .. > ncal > Index: contrib/mandoc/tbl_term.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- contrib/mandoc/tbl_term.c (revision 349971) > +++ contrib/mandoc/tbl_term.c (working copy) > @@ -626,7 +626,8 @@ > =20 > lw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || > (cpn->pos !=3D TBL_CELL_DOWN && > - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) > + (dpn =3D=3D NULL || dpn->string =3D=3D NULL || > + strcmp(dpn->string, "\\^") !=3D 0)) > ? hw : 0; > tbl_direct_border(tp, BHORIZ * lw, > col->width + col->spacing / 2); > @@ -670,7 +671,8 @@ > =20 > rw =3D cpp =3D=3D NULL || cpn =3D=3D NULL || > (cpn->pos !=3D TBL_CELL_DOWN && > - (dpn =3D=3D NULL || strcmp(dpn->string, "\\^") !=3D 0)) > + (dpn =3D=3D NULL || dpn->string =3D=3D NULL || > + strcmp(dpn->string, "\\^") !=3D 0)) > ? hw : 0; > =20 > /* The line crossing at the end of this column. */ --fqf72zv4xfpkmw3d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl0vA6cACgkQY4mL3PG3 PlokVhAA1+VsMD3EOA9cP5fDlJOUvE08HMumeQaov32HxpZxSEat5SM82Pej1jTp ywRM9no0Bji+17pt5oNzXi6Jix+LEfnFl2UndAGzkQpfu+631VNySFMxcbGdVYEG UOIiIZBKMVqD2J4ew/d3FGIgesy84VaxU033nGBREskR1Z7WC54W7MPsFrPq0qri kbT3hOq2FA8L22pSgDx/eWNWBoasTJKqcgHQkBiNc+IQSDCFPOYKw1e3CP1W/vnx 7dOGN3gZ+1xy8rgk26cEcS2L1sKqklUDLlmMMPQuAyzyUtRjyIwjZAjKf2//ugHo rY73tCiKdt6/enYDLX+S4Ps8f24oFi+bwyBp8G45QiC8EVDVb/dVrStOxPhiNQCH iW0cTXJLKBd/e4gQcCzlJcR4Ddki2ua9yI1C4o9J7MzOY9Po1hCBFSjww94BpwdX nj2Zb+Uru8r134Bf1x/Mob8IfPjIRa5Ch3938MbcFl6/VKoisB5yncmEFaiHngOR jCI6KLtEmspD0pApUJndYFNaxfZYkfVW/2omcE8lB8hGVi4ZZ0jQQpO5qkXXnBwz OGs8UdEIrbLMUWUazf1YS9W+apCqSOJKeK7zrBhEi5ETIK0LYWIiMm15VggbRK+6 1rImFnZsdNN8PIHF4br/UovuzIapzSpRZGgdu6ZeMYbCCqi+rwE= =dzti -----END PGP SIGNATURE----- --fqf72zv4xfpkmw3d-- From owner-freebsd-current@freebsd.org Thu Jul 18 12:36:47 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 43637A7F26 for ; Thu, 18 Jul 2019 12:36:47 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) Received: from mail2.mands.hu (mail2.mands.hu [93.189.114.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.mands.hu", Issuer "e-Szigno SSL CA 2014" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DFA18881FE for ; Thu, 18 Jul 2019 12:36:45 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) From: =?iso-8859-1?Q?M=26S_-_Krasznai_Andr=E1s?= To: "freebsd-current@freebsd.org" Subject: undefined symbol: random_source_register during kernel compilation Thread-Topic: undefined symbol: random_source_register during kernel compilation Thread-Index: AQHVPWNVH9T9TPn6IEOBhfJPBHRNtA== Date: Thu, 18 Jul 2019 12:21:32 +0000 Message-ID: <1563452492662.7098@mands.hu> Accept-Language: en-US, hu-HU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.168.6.59] MIME-Version: 1.0 X-Rspamd-Queue-Id: DFA18881FE X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of Krasznai.Andras@mands.hu designates 93.189.114.146 as permitted sender) smtp.mailfrom=Krasznai.Andras@mands.hu X-Spamd-Result: default: False [-2.19 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.78)[-0.784,0]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[mands.hu]; NEURAL_HAM_LONG(-1.00)[-0.995,0]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[country: HU(0.02)]; MX_GOOD(-0.01)[mail2.mands.hu]; NEURAL_HAM_SHORT(-0.10)[-0.100,0]; RCVD_IN_DNSWL_NONE(0.00)[146.114.189.93.list.dnswl.org : 127.0.10.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:47116, ipnet:93.189.112.0/21, country:HU]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2019 12:36:47 -0000 Hi I have been trying to compile a freebsd-current kernel since the 16th of Ju= ly, and keep getting the following error during "make buildkernel": Building /usr/obj/usr/src/amd64.amd64/sys/G13NEW/kernel.full linking kernel.full ld: error: undefined symbol: random_source_register >>> referenced by ivy.c:108 (/usr/src/sys/dev/random/ivy.c:108) >>> ivy.o:(rdrand_modevent) ld: error: undefined symbol: random_source_deregister >>> referenced by ivy.c:115 (/usr/src/sys/dev/random/ivy.c:115) >>> ivy.o:(rdrand_modevent) ld: error: undefined symbol: random_source_register >>> referenced by nehemiah.c:124 (/usr/src/sys/dev/random/nehemiah.c:124) >>> nehemiah.o:(nehemiah_modevent) ld: error: undefined symbol: random_source_deregister >>> referenced by nehemiah.c:133 (/usr/src/sys/dev/random/nehemiah.c:133) >>> nehemiah.o:(nehemiah_modevent) *** Error code 1 Stop. make[2]: stopped in /usr/obj/usr/src/amd64.amd64/sys/G13NEW .ERROR_TARGET=3D'kernel.full' .ERROR_META_FILE=3D'/usr/obj/usr/src/amd64.amd64/sys/G13NEW/kernel.full.met= a' .MAKE.LEVEL=3D'2' MAKEFILE=3D'' .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes ve= rbose curdirOk=3D yes' I deleted and resynchronized the source tree and emptied the /usr/obj direc= tory, but it did not help. How could I get kernel compilation work again? I would like to say that the= make.conf, src.conf files as well as my kernel configuration file was not = changed since a couple of months (since I installed freebsd-current). rgds ? From owner-freebsd-current@freebsd.org Thu Jul 18 15:00:24 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D721DAA70C for ; Thu, 18 Jul 2019 15:00:24 +0000 (UTC) (envelope-from schwarze@usta.de) Received: from scc-mailout-kit-01.scc.kit.edu (scc-mailout-kit-01.scc.kit.edu [IPv6:2a00:1398:9:f712::810d:e751]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C75118C253; Thu, 18 Jul 2019 15:00:23 +0000 (UTC) (envelope-from schwarze@usta.de) Received: from asta-nat.asta.uni-karlsruhe.de ([172.22.63.82] helo=hekate.usta.de) by scc-mailout-kit-01.scc.kit.edu with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (envelope-from ) id 1ho7tL-0002Vw-Au; Thu, 18 Jul 2019 17:00:20 +0200 Received: from donnerwolke.usta.de ([172.24.96.3]) by hekate.usta.de with esmtp (Exim 4.77) (envelope-from ) id 1ho7tK-0000mc-Nx; Thu, 18 Jul 2019 17:00:18 +0200 Received: from athene.usta.de ([172.24.96.10]) by donnerwolke.usta.de with esmtp (Exim 4.84_2) (envelope-from ) id 1ho7tJ-0005dj-H6; Thu, 18 Jul 2019 17:00:17 +0200 Received: from localhost (athene.usta.de [local]) by athene.usta.de (OpenSMTPD) with ESMTPA id 593b7e10; Thu, 18 Jul 2019 17:00:18 +0200 (CEST) Date: Thu, 18 Jul 2019 17:00:18 +0200 From: Ingo Schwarze To: Baptiste Daroussin , Eygene Ryabinkin Cc: freebsd-current@FreeBSD.org, tech@mandoc.bsd.lv Subject: Re: [CFT][patch] mandoc: don't segfault on empty tbl(1) continuation blocks Message-ID: <20190718150018.GB67545@athene.usta.de> References: <20190716193124.yrrntrtah22aky5n@phoenix.codelabs.ru> <20190717071201.beem6et6dybhby7m@ivaldir.net> <20190717103942.fkunwe3utxvmdc5n@void.codelabs.ru> <20190717111655.eyq673itr76fj224@ivaldir.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190717111655.eyq673itr76fj224@ivaldir.net> User-Agent: Mutt/1.8.0 (2017-02-23) X-Rspamd-Queue-Id: C75118C253 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-0.79 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.70)[-0.696,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.968,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[usta.de]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.41)[0.411,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[1.5.7.e.d.0.1.8.0.0.0.0.0.0.0.0.2.1.7.f.9.0.0.0.8.9.3.1.0.0.a.2.list.dnswl.org : 127.0.11.2]; MX_GOOD(-0.01)[scc-spamtrap-always-defer.scc.kit.edu,scc-mailin-cn-01.scc.kit.edu,scc-mailin-cs-01.scc.kit.edu]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:34878, ipnet:2a00:1398::/32, country:DE]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-0.22)[ipnet: 2a00:1398::/32(-0.62), asn: 34878(-0.49), country: DE(-0.01)] X-Mailman-Approved-At: Thu, 18 Jul 2019 16:25:50 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2019 15:00:24 -0000 Hi Baptiste, hi Eygene, Baptiste Daroussin wrote on Wed, Jul 17, 2019 at 01:16:56PM +0200: > On Wed, Jul 17, 2019 at 01:39:42PM +0300, Eygene Ryabinkin wrote: >> but I believe that 'cpp' still can be NULL and will try to see >> if it is triggerable. I'm not sure what you mean here. Do you think that in tbl_hrule(), there is a possibility that *cpp might still be accessed even though cpp =3D=3D NULL? If so, where and how exactly? As far as i can see, cpp can indeed easily be NULL anywhere in=20 tbl_hrule(), but it seems to me that for each access, !=3D NULL is checked immediately before. If you still see a potential problem somewhere, please do speak up. The table formatting logic is indeed complicated, so it's not inconceivable that i still missed an edge case. > As for the test case, the best would be that this test ends up > incorporated in the upstream testsuite Done, see the commit below. Yours, Ingo Log Message: ----------- new test for an empty text block; from rea@ via bapt@ (FreeBSD) Modified Files: -------------- mandoc/regress/tbl/data: Makefile Added Files: ----------- mandoc/regress/tbl/data: block_empty.in block_empty.out_ascii Revision Data ------------- --- /dev/null +++ regress/tbl/data/block_empty.in @@ -0,0 +1,19 @@ +.\" $OpenBSD: block_empty.in,v 1.1 2019/07/18 14:38:47 schwarze Exp $ +.TH TBL-DATA-BLOCK_EMPTY 1 "July 17, 2019" +.SH NAME +tbl-data-block_empty \- empty text block +.SH DESCRIPTION +normal text +.TS +|l|l|. +_ +A test +_ +table T{ +T} +_ +.TE +.SH AUTHORS +.MT rea@FreeBSD.org +Eygene Ryabinkin +.ME --- /dev/null +++ regress/tbl/data/block_empty.out_ascii @@ -0,0 +1,22 @@ +TBL-DATA-BLOCK_EMPTY(1) General Commands Manual TBL-DATA-BLOCK_EMPT= Y(1) + + + +N=08NA=08AM=08ME=08E + tbl-data-block_empty - empty text block + +D=08DE=08ES=08SC=08CR=08RI=08IP=08PT=08TI=08IO=08ON=08N + normal text + + +------+------+ + |A | test | + +------+------+ + |table | | + +------+------+ + +A=08AU=08UT=08TH=08HO=08OR=08RS=08S + Eygene Ryabinkin + + + +OpenBSD July 17, 2019 TBL-DATA-BLOCK_EMPT= Y(1) Index: Makefile =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /home/cvs/mandoc/mandoc/regress/tbl/data/Makefile,v retrieving revision 1.4 retrieving revision 1.5 diff -Lregress/tbl/data/Makefile -Lregress/tbl/data/Makefile -u -p -r1.4 -r= 1.5 --- regress/tbl/data/Makefile +++ regress/tbl/data/Makefile @@ -1,6 +1,7 @@ -# $OpenBSD: Makefile,v 1.4 2017/07/04 20:59:17 schwarze Exp $ +# $OpenBSD: Makefile,v 1.5 2019/07/18 14:38:47 schwarze Exp $ =20 -REGRESS_TARGETS =3D blankline block_unclosed block_width block_wrap empty= insert +REGRESS_TARGETS =3D blankline block_empty block_unclosed block_width +REGRESS_TARGETS +=3D block_wrap empty insert LINT_TARGETS =3D block_unclosed empty insert =20 # groff-1.22.3 defect: From owner-freebsd-current@freebsd.org Thu Jul 18 17:10:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7EF0AD1E3 for ; Thu, 18 Jul 2019 17:10:02 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F9C269F06 for ; Thu, 18 Jul 2019 17:10:02 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.206] (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 0dd3e8e6 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Thu, 18 Jul 2019 17:09:55 +0000 (UTC) Subject: Re: undefined symbol: random_source_register during kernel compilation To: =?UTF-8?Q?M=26S_-_Krasznai_Andr=c3=a1s?= , "freebsd-current@freebsd.org" References: <1563452492662.7098@mands.hu> From: Pete Wright Message-ID: <2c1ad95b-ee79-f752-a66c-53a223dd00a7@nomadlogic.org> Date: Thu, 18 Jul 2019 10:09:49 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1563452492662.7098@mands.hu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 3F9C269F06 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-6.17 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MX_GOOD(-0.01)[mail.nomadlogic.org]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-2.88)[ip: (-9.42), ipnet: 174.136.96.0/20(-4.64), asn: 25795(-0.27), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jul 2019 17:10:03 -0000 On 7/18/19 5:21 AM, M&S - Krasznai András wrote: > Hi > > > I have been trying to compile a freebsd-current kernel since the 16th of July, and keep getting the following error during "make buildkernel": > > > Building /usr/obj/usr/src/amd64.amd64/sys/G13NEW/kernel.full > linking kernel.full > ld: error: undefined symbol: random_source_register >>>> referenced by ivy.c:108 (/usr/src/sys/dev/random/ivy.c:108) >>>> ivy.o:(rdrand_modevent) > ld: error: undefined symbol: random_source_deregister >>>> referenced by ivy.c:115 (/usr/src/sys/dev/random/ivy.c:115) >>>> ivy.o:(rdrand_modevent) > ld: error: undefined symbol: random_source_register >>>> referenced by nehemiah.c:124 (/usr/src/sys/dev/random/nehemiah.c:124) >>>> nehemiah.o:(nehemiah_modevent) > ld: error: undefined symbol: random_source_deregister >>>> referenced by nehemiah.c:133 (/usr/src/sys/dev/random/nehemiah.c:133) >>>> nehemiah.o:(nehemiah_modevent) > *** Error code 1 > > Stop. > make[2]: stopped in /usr/obj/usr/src/amd64.amd64/sys/G13NEW > .ERROR_TARGET='kernel.full' > .ERROR_META_FILE='/usr/obj/usr/src/amd64.amd64/sys/G13NEW/kernel.full.meta' > .MAKE.LEVEL='2' > MAKEFILE='' > .MAKE.MODE='meta missing-filemon=yes missing-meta=yes silent=yes verbose curdirOk= > yes' > > I deleted and resynchronized the source tree and emptied the /usr/obj directory, but it did not help. > > How could I get kernel compilation work again? I would like to say that the make.conf, src.conf files as well as my kernel configuration file was not changed since a couple of months (since I installed freebsd-current). are you able to build GENERIC?  if so might be worth looking at the delta's b/w GENERIC and your custom configuration and trying to zero in on what may be causing this to fail. -p -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-current@freebsd.org Fri Jul 19 06:51:52 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95C6CBAF22 for ; Fri, 19 Jul 2019 06:51:52 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) Received: from mail2.mands.hu (mail2.mands.hu [93.189.114.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.mands.hu", Issuer "e-Szigno SSL CA 2014" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0F3678981F for ; Fri, 19 Jul 2019 06:51:51 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) From: =?utf-8?B?TSZTIC0gS3Jhc3puYWkgQW5kcsOhcw==?= To: Pete Wright , "freebsd-current@freebsd.org" Subject: RE: undefined symbol: random_source_register during kernel compilation Thread-Topic: undefined symbol: random_source_register during kernel compilation Thread-Index: AQHVPWNVH9T9TPn6IEOBhfJPBHRNtKbQeuiAgAEFUsA= Date: Fri, 19 Jul 2019 06:51:47 +0000 Message-ID: References: <1563452492662.7098@mands.hu> <2c1ad95b-ee79-f752-a66c-53a223dd00a7@nomadlogic.org> In-Reply-To: <2c1ad95b-ee79-f752-a66c-53a223dd00a7@nomadlogic.org> Accept-Language: en-US, hu-HU Content-Language: hu-HU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.168.4.90] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Rspamd-Queue-Id: 0F3678981F X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of Krasznai.Andras@mands.hu designates 93.189.114.146 as permitted sender) smtp.mailfrom=Krasznai.Andras@mands.hu X-Spamd-Result: default: False [-2.38 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mands.hu]; NEURAL_HAM_MEDIUM(-0.98)[-0.978,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail2.mands.hu]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[146.114.189.93.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_SHORT(-0.20)[-0.203,0]; MIME_BASE64_TEXT(0.10)[]; IP_SCORE(0.00)[country: HU(0.02)]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:47116, ipnet:93.189.112.0/21, country:HU]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 06:51:52 -0000 SGksIHRoYW5rcyBmb3IgdGhlIGFkdmljZS4NCg0KTm93IEkgZW1wdGllZCB0aGUgL3Vzci9zcmMg YW5kIC91c3Ivb2JqIGRpcmVjdG9yaWVzLCBkb3dubG9hZGVkIHRoZSBDVVJSRU5UIHNvdXJjZXMg YWdhaW4sIGFuZCByZW1vdmVkIHRoZSAvZXRjL3NyYy5jb25mIGZpbGUuIA0KSSBjb21waWxlIHRo ZSBHRU5FUklDIGtlcm5lbCBub3csIC9ldGMvbWFrZS5jb25mIGNvbnRhaW5zIA0KDQoNCktFUk5D T05GPUdFTkVSSUMNCk1LX1BST0ZJTEU9Tk8NCkRFRkFVTFRfVkVSU0lPTlMrPWxpbnV4PWM2DQpN QUxMT0NfUFJPRFVDVElPTj1ZRVMNCklOU1RBTExfTk9ERUJVRz1ZRVMNCldJVEhfRkFTVF9ERVBF TkQ9WUVTDQoNCkNvbXBpbGF0aW9uIHRha2VzIGEgZmV3IGhvdXJzIHVzdWFsbHksIEkgd2lsbCB0 ZWxsIHlvdSB0aGUgcmVzdWx0Lg0KDQpiZXN0IHJlZ2FyZHMNCg0KQW5kcmFzIEtyYXN6bmFpDQoN Cg0KDQotLS0tLUVyZWRldGkgw7x6ZW5ldC0tLS0tDQpGZWxhZMOzOiBQZXRlIFdyaWdodCBbbWFp bHRvOnBldGVAbm9tYWRsb2dpYy5vcmddIA0KS8O8bGR2ZTogMjAxOS4gasO6bGl1cyAxOC4gMTk6 MTANCkPDrW16ZXR0OiBNJlMgLSBLcmFzem5haSBBbmRyw6FzOyBmcmVlYnNkLWN1cnJlbnRAZnJl ZWJzZC5vcmcNClTDoXJneTogUmU6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfcmVn aXN0ZXIgZHVyaW5nIGtlcm5lbCBjb21waWxhdGlvbg0KDQoNCg0KT24gNy8xOC8xOSA1OjIxIEFN LCBNJlMgLSBLcmFzem5haSBBbmRyw6FzIHdyb3RlOg0KPiBIaQ0KPg0KPg0KPiBJIGhhdmUgYmVl biB0cnlpbmcgdG8gY29tcGlsZSBhIGZyZWVic2QtY3VycmVudCBrZXJuZWwgc2luY2UgdGhlIDE2 dGggb2YgSnVseSwgYW5kIGtlZXAgZ2V0dGluZyB0aGUgZm9sbG93aW5nIGVycm9yIGR1cmluZyAi bWFrZSBidWlsZGtlcm5lbCI6DQo+DQo+DQo+IEJ1aWxkaW5nIC91c3Ivb2JqL3Vzci9zcmMvYW1k NjQuYW1kNjQvc3lzL0cxM05FVy9rZXJuZWwuZnVsbA0KPiBsaW5raW5nIGtlcm5lbC5mdWxsDQo+ IGxkOiBlcnJvcjogdW5kZWZpbmVkIHN5bWJvbDogcmFuZG9tX3NvdXJjZV9yZWdpc3Rlcg0KPj4+ PiByZWZlcmVuY2VkIGJ5IGl2eS5jOjEwOCAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vaXZ5LmM6 MTA4KQ0KPj4+PiAgICAgICAgICAgICAgICBpdnkubzoocmRyYW5kX21vZGV2ZW50KQ0KPiBsZDog ZXJyb3I6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfZGVyZWdpc3Rlcg0KPj4+PiBy ZWZlcmVuY2VkIGJ5IGl2eS5jOjExNSAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vaXZ5LmM6MTE1 KQ0KPj4+PiAgICAgICAgICAgICAgICBpdnkubzoocmRyYW5kX21vZGV2ZW50KQ0KPiBsZDogZXJy b3I6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfcmVnaXN0ZXINCj4+Pj4gcmVmZXJl bmNlZCBieSBuZWhlbWlhaC5jOjEyNCAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vbmVoZW1pYWgu YzoxMjQpDQo+Pj4+ICAgICAgICAgICAgICAgIG5laGVtaWFoLm86KG5laGVtaWFoX21vZGV2ZW50 KQ0KPiBsZDogZXJyb3I6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfZGVyZWdpc3Rl cg0KPj4+PiByZWZlcmVuY2VkIGJ5IG5laGVtaWFoLmM6MTMzICgvdXNyL3NyYy9zeXMvZGV2L3Jh bmRvbS9uZWhlbWlhaC5jOjEzMykNCj4+Pj4gICAgICAgICAgICAgICAgbmVoZW1pYWgubzoobmVo ZW1pYWhfbW9kZXZlbnQpDQo+ICoqKiBFcnJvciBjb2RlIDENCj4NCj4gU3RvcC4NCj4gbWFrZVsy XTogc3RvcHBlZCBpbiAvdXNyL29iai91c3Ivc3JjL2FtZDY0LmFtZDY0L3N5cy9HMTNORVcNCj4g LkVSUk9SX1RBUkdFVD0na2VybmVsLmZ1bGwnDQo+IC5FUlJPUl9NRVRBX0ZJTEU9Jy91c3Ivb2Jq L3Vzci9zcmMvYW1kNjQuYW1kNjQvc3lzL0cxM05FVy9rZXJuZWwuZnVsbC5tZXRhJw0KPiAuTUFL RS5MRVZFTD0nMicNCj4gTUFLRUZJTEU9JycNCj4gLk1BS0UuTU9ERT0nbWV0YSBtaXNzaW5nLWZp bGVtb249eWVzIG1pc3NpbmctbWV0YT15ZXMgc2lsZW50PXllcyB2ZXJib3NlIGN1cmRpck9rPQ0K PiB5ZXMnDQo+DQo+IEkgZGVsZXRlZCBhbmQgcmVzeW5jaHJvbml6ZWQgdGhlIHNvdXJjZSB0cmVl IGFuZCBlbXB0aWVkIHRoZSAvdXNyL29iaiBkaXJlY3RvcnksIGJ1dCBpdCBkaWQgbm90IGhlbHAu DQo+DQo+IEhvdyBjb3VsZCBJIGdldCBrZXJuZWwgY29tcGlsYXRpb24gd29yayBhZ2Fpbj8gSSB3 b3VsZCBsaWtlIHRvIHNheSB0aGF0IHRoZSBtYWtlLmNvbmYsIHNyYy5jb25mIGZpbGVzIGFzIHdl bGwgYXMgbXkga2VybmVsIGNvbmZpZ3VyYXRpb24gZmlsZSB3YXMgbm90IGNoYW5nZWQgc2luY2Ug YSBjb3VwbGUgb2YgbW9udGhzIChzaW5jZSBJIGluc3RhbGxlZCBmcmVlYnNkLWN1cnJlbnQpLg0K YXJlIHlvdSBhYmxlIHRvIGJ1aWxkIEdFTkVSSUM/wqAgaWYgc28gbWlnaHQgYmUgd29ydGggbG9v a2luZyBhdCB0aGUgDQpkZWx0YSdzIGIvdyBHRU5FUklDIGFuZCB5b3VyIGN1c3RvbSBjb25maWd1 cmF0aW9uIGFuZCB0cnlpbmcgdG8gemVybyBpbiANCm9uIHdoYXQgbWF5IGJlIGNhdXNpbmcgdGhp cyB0byBmYWlsLg0KDQotcA0KDQotLSANClBldGUgV3JpZ2h0DQpwZXRlQG5vbWFkbG9naWMub3Jn DQpAbm9tYWRsb2dpY0xBDQoNCg== From owner-freebsd-current@freebsd.org Fri Jul 19 07:22:28 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9F58FBB64D for ; Fri, 19 Jul 2019 07:22:28 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) Received: from mail2.mands.hu (mail2.mands.hu [93.189.114.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.mands.hu", Issuer "e-Szigno SSL CA 2014" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 229D68A528 for ; Fri, 19 Jul 2019 07:22:27 +0000 (UTC) (envelope-from Krasznai.Andras@mands.hu) From: =?utf-8?B?TSZTIC0gS3Jhc3puYWkgQW5kcsOhcw==?= To: Pete Wright , "freebsd-current@freebsd.org" Subject: RE: undefined symbol: random_source_register during kernel compilation Thread-Topic: undefined symbol: random_source_register during kernel compilation Thread-Index: AQHVPWNVH9T9TPn6IEOBhfJPBHRNtKbQeuiAgAELMOA= Date: Fri, 19 Jul 2019 07:22:25 +0000 Message-ID: <5da8f5c9f9074395b613ff517f2b0327@MSEXCH13.mands.hu> References: <1563452492662.7098@mands.hu> <2c1ad95b-ee79-f752-a66c-53a223dd00a7@nomadlogic.org> In-Reply-To: <2c1ad95b-ee79-f752-a66c-53a223dd00a7@nomadlogic.org> Accept-Language: en-US, hu-HU Content-Language: hu-HU X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.168.4.90] Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Rspamd-Queue-Id: 229D68A528 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of Krasznai.Andras@mands.hu designates 93.189.114.146 as permitted sender) smtp.mailfrom=Krasznai.Andras@mands.hu X-Spamd-Result: default: False [-2.37 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mands.hu]; NEURAL_HAM_MEDIUM(-0.98)[-0.978,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail2.mands.hu]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[146.114.189.93.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_SHORT(-0.19)[-0.192,0]; MIME_BASE64_TEXT(0.10)[]; IP_SCORE(0.00)[country: HU(0.02)]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:47116, ipnet:93.189.112.0/21, country:HU]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 07:22:28 -0000 R29vZCBtb3JuaW5nIQ0KSSBmb3VuZCBhIHByb2JsZW0gcmF0aGVyIHF1aWNrbHk6IHRoZSBjb21w aWxhdGlvbiBjb21wbGFpbnMgYWJvdXQgYSBtaXNzaW5nIGxpYmNhc3Blci5oIGZpbGUuICgvdXNy L2luY2x1ZGUvY2Fwc2ljdW1faGVscGVycy5oIHJlZmVyZW5jZXMgbGliY2FzcGVyLmgsIGFuZCBu b3QgZnJvbSB0aGUgc291cmNlcyBidXQgZnJvbSB0aGUgaW5zdGFsbGVkIHN5c3RlbS4NCg0KVGhl IHByb2JsZW0gaXMgdGhhdCBjYXNwZXIgaXMgYSBmZWF0dXJlIHdoaWNoIGNhbiBiZSBzd2l0Y2hl ZCBvZmYgKGFuZCBvbiBhZ2FpbikgaW4gL2V0Yy9zcmMuY29uZiwgYnV0IEkgc3VwcG9zZSB0aGF0 IGlmIEkgc3dpdGNoIGl0IEJBQ0ssIHRoYXRpcyBpZiBJIHdhbnQgaXQgdG8gY29tcGlsZSBjYXNw ZXIgYWdhaW4gKHJlbW92ZSB0aGUgV0lUSE9VVF9DQVNQRVI9WUVTIGxpbmUgZnJvbSBzcmMuY29u ZiwgZS5nLiksIHRoZW4gdGhlIHNvdXJjZXMgZm9yIGNhc3BlciBzaG91bGQgYmUgdGhlcmUgc29t ZXdoZXJlIGluIG15IGZyZXNobHkgc3luY2hvbml6ZWQgc291cmNlIHRyZWUuDQoNCihhbmQgaXQg aXM6IGxpYmNhc3Blci5oIGlzIGluIC91c3Ivc3JjL2xpYi9saWJjYXNwZXIvbGliY2FzcGVyICBi dXQgY29tcGlsYXRpb24gc3VwcG9zZXMgdGhhdCBpdCBoYXMgYWxyZWFkeSBiZWVuIGluc3RhbGxl ZCBpbnRvIC91c3IvaW5jbHVkZSkuDQoNCk5vdyBJIHRyeSB0byBjb21waWxlIEdFTkVSSUMgd2l0 aCBteSBvcmlnaW5hbCBzcmMuY29uZiwgd2hpY2ggc3dpdGNoZXMgb2ZmIHRoZSBDQVNQRVIsIGFu ZCBzZWUgd2hhdCBoYXBwZW5zLg0KDQpyZ2RzDQpBbmRyYXMgS3Jhc3puYWkNCg0KDQoNCg0KDQot LS0tLUVyZWRldGkgw7x6ZW5ldC0tLS0tDQpGZWxhZMOzOiBQZXRlIFdyaWdodCBbbWFpbHRvOnBl dGVAbm9tYWRsb2dpYy5vcmddIA0KS8O8bGR2ZTogMjAxOS4gasO6bGl1cyAxOC4gMTk6MTANCkPD rW16ZXR0OiBNJlMgLSBLcmFzem5haSBBbmRyw6FzOyBmcmVlYnNkLWN1cnJlbnRAZnJlZWJzZC5v cmcNClTDoXJneTogUmU6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfcmVnaXN0ZXIg ZHVyaW5nIGtlcm5lbCBjb21waWxhdGlvbg0KDQoNCg0KT24gNy8xOC8xOSA1OjIxIEFNLCBNJlMg LSBLcmFzem5haSBBbmRyw6FzIHdyb3RlOg0KPiBIaQ0KPg0KPg0KPiBJIGhhdmUgYmVlbiB0cnlp bmcgdG8gY29tcGlsZSBhIGZyZWVic2QtY3VycmVudCBrZXJuZWwgc2luY2UgdGhlIDE2dGggb2Yg SnVseSwgYW5kIGtlZXAgZ2V0dGluZyB0aGUgZm9sbG93aW5nIGVycm9yIGR1cmluZyAibWFrZSBi dWlsZGtlcm5lbCI6DQo+DQo+DQo+IEJ1aWxkaW5nIC91c3Ivb2JqL3Vzci9zcmMvYW1kNjQuYW1k NjQvc3lzL0cxM05FVy9rZXJuZWwuZnVsbA0KPiBsaW5raW5nIGtlcm5lbC5mdWxsDQo+IGxkOiBl cnJvcjogdW5kZWZpbmVkIHN5bWJvbDogcmFuZG9tX3NvdXJjZV9yZWdpc3Rlcg0KPj4+PiByZWZl cmVuY2VkIGJ5IGl2eS5jOjEwOCAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vaXZ5LmM6MTA4KQ0K Pj4+PiAgICAgICAgICAgICAgICBpdnkubzoocmRyYW5kX21vZGV2ZW50KQ0KPiBsZDogZXJyb3I6 IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfZGVyZWdpc3Rlcg0KPj4+PiByZWZlcmVu Y2VkIGJ5IGl2eS5jOjExNSAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vaXZ5LmM6MTE1KQ0KPj4+ PiAgICAgICAgICAgICAgICBpdnkubzoocmRyYW5kX21vZGV2ZW50KQ0KPiBsZDogZXJyb3I6IHVu ZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfcmVnaXN0ZXINCj4+Pj4gcmVmZXJlbmNlZCBi eSBuZWhlbWlhaC5jOjEyNCAoL3Vzci9zcmMvc3lzL2Rldi9yYW5kb20vbmVoZW1pYWguYzoxMjQp DQo+Pj4+ICAgICAgICAgICAgICAgIG5laGVtaWFoLm86KG5laGVtaWFoX21vZGV2ZW50KQ0KPiBs ZDogZXJyb3I6IHVuZGVmaW5lZCBzeW1ib2w6IHJhbmRvbV9zb3VyY2VfZGVyZWdpc3Rlcg0KPj4+ PiByZWZlcmVuY2VkIGJ5IG5laGVtaWFoLmM6MTMzICgvdXNyL3NyYy9zeXMvZGV2L3JhbmRvbS9u ZWhlbWlhaC5jOjEzMykNCj4+Pj4gICAgICAgICAgICAgICAgbmVoZW1pYWgubzoobmVoZW1pYWhf bW9kZXZlbnQpDQo+ICoqKiBFcnJvciBjb2RlIDENCj4NCj4gU3RvcC4NCj4gbWFrZVsyXTogc3Rv cHBlZCBpbiAvdXNyL29iai91c3Ivc3JjL2FtZDY0LmFtZDY0L3N5cy9HMTNORVcNCj4gLkVSUk9S X1RBUkdFVD0na2VybmVsLmZ1bGwnDQo+IC5FUlJPUl9NRVRBX0ZJTEU9Jy91c3Ivb2JqL3Vzci9z cmMvYW1kNjQuYW1kNjQvc3lzL0cxM05FVy9rZXJuZWwuZnVsbC5tZXRhJw0KPiAuTUFLRS5MRVZF TD0nMicNCj4gTUFLRUZJTEU9JycNCj4gLk1BS0UuTU9ERT0nbWV0YSBtaXNzaW5nLWZpbGVtb249 eWVzIG1pc3NpbmctbWV0YT15ZXMgc2lsZW50PXllcyB2ZXJib3NlIGN1cmRpck9rPQ0KPiB5ZXMn DQo+DQo+IEkgZGVsZXRlZCBhbmQgcmVzeW5jaHJvbml6ZWQgdGhlIHNvdXJjZSB0cmVlIGFuZCBl bXB0aWVkIHRoZSAvdXNyL29iaiBkaXJlY3RvcnksIGJ1dCBpdCBkaWQgbm90IGhlbHAuDQo+DQo+ IEhvdyBjb3VsZCBJIGdldCBrZXJuZWwgY29tcGlsYXRpb24gd29yayBhZ2Fpbj8gSSB3b3VsZCBs aWtlIHRvIHNheSB0aGF0IHRoZSBtYWtlLmNvbmYsIHNyYy5jb25mIGZpbGVzIGFzIHdlbGwgYXMg bXkga2VybmVsIGNvbmZpZ3VyYXRpb24gZmlsZSB3YXMgbm90IGNoYW5nZWQgc2luY2UgYSBjb3Vw bGUgb2YgbW9udGhzIChzaW5jZSBJIGluc3RhbGxlZCBmcmVlYnNkLWN1cnJlbnQpLg0KYXJlIHlv dSBhYmxlIHRvIGJ1aWxkIEdFTkVSSUM/wqAgaWYgc28gbWlnaHQgYmUgd29ydGggbG9va2luZyBh dCB0aGUgDQpkZWx0YSdzIGIvdyBHRU5FUklDIGFuZCB5b3VyIGN1c3RvbSBjb25maWd1cmF0aW9u IGFuZCB0cnlpbmcgdG8gemVybyBpbiANCm9uIHdoYXQgbWF5IGJlIGNhdXNpbmcgdGhpcyB0byBm YWlsLg0KDQotcA0KDQotLSANClBldGUgV3JpZ2h0DQpwZXRlQG5vbWFkbG9naWMub3JnDQpAbm9t YWRsb2dpY0xBDQoNCg== From owner-freebsd-current@freebsd.org Fri Jul 19 14:07:10 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C1A5A369F; Fri, 19 Jul 2019 14:07:10 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53B626E8FE; Fri, 19 Jul 2019 14:07:09 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pf1-f177.google.com with SMTP id t16so14220292pfe.11; Fri, 19 Jul 2019 07:07:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:openpgp:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=T9RrvYvhAhcSLjKsZlSwD2+Er3UKvp78vPRjyYmwq5U=; b=Jg/yTUJkHu8zSkpQ6HsPChV095M3K7MRkPgs6y5bXTifmvQc6GUXcbmgBPX+gG1/5w Ya0Qtfa41xFXRJz0iCN3Vr0NLgEOhCzQc5yyL0wFfWTf5TnO3claWLoVbGbcktPyuQ7j ij5V5m7ZgwvdcFdsI4nV5tLVZbZS7Gl9+eEPuWJTo+MAELeveROc6+50m+CxWOTSaDPR FQtg+h23hyLUbFk5oSwRjtkkLMf7OPqLKBAHueU80s+Szy60gbJrREyq1Sc/fKxGanKg tHKhaUfPp2IQpupjMcN1WeTh7rcZbIJ93fqCj0kYdB2+ILVFQFgvGPlxftvEjfrsRV9f qgRg== X-Gm-Message-State: APjAAAV6MjTAMx6e4DmlkOWrznWu51A1DKRa/mwkLWPLOYPjlfSd8jJ0 S5zHdVk2PsM/eL2j3H5Xpf5D2OAZ X-Google-Smtp-Source: APXvYqwFr/7mP65W/9Iql/cEaX6kZC9IHGcqsZAio1yN5HxgNsojEPiH+Ptn92iCpynlSyul5BzPkg== X-Received: by 2002:a17:90a:d791:: with SMTP id z17mr54288359pju.40.1563533544839; Fri, 19 Jul 2019 03:52:24 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-249-80.atc.tvcom.ru. [82.140.249.80]) by smtp.googlemail.com with ESMTPSA id r27sm36237322pgn.25.2019.07.19.03.52.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Jul 2019 03:52:23 -0700 (PDT) To: freebsd-net@freebsd.org, FreeBSD Current From: Andriy Gapon Subject: vmx0: watchdog timeout on queue 2, no interrupts on BSP Openpgp: preference=signencrypt Message-ID: <9c509f7b-8294-d2fe-ea3e-f10fd51f5736@FreeBSD.org> Date: Fri, 19 Jul 2019 13:52:18 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 53B626E8FE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.06 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[177.210.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.90)[-0.903,0]; IP_SCORE(-3.15)[ip: (-9.81), ipnet: 209.85.128.0/17(-3.45), asn: 15169(-2.43), country: US(-0.05)]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 14:07:10 -0000 Recently we experienced a strange problem. We noticed a lot of these messages in the logs: vmx0: watchdog timeout on queue 2 (always queue 2) Also, we noticed that connections to some end points did not work at all while others worked without problems. I assume that that was because specific flows got assigned to that queue 2. Further investigation has shown that none of interrupts assigned to the BSP has ever fired (since boot, of course). That included vmx0:rx2 and vmx0:tx2. But also interrupts for other drivers as well. Trying to get more information I rebooted the system and the problem disappeared. Has anyone seen anything like that? Any thoughts on possible causes? Any suggestions what to check if/when the problem reoccurs? Thanks! -- Andriy Gapon From owner-freebsd-current@freebsd.org Fri Jul 19 22:15:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0543CACFD9 for ; Fri, 19 Jul 2019 22:15:25 +0000 (UTC) (envelope-from cpogolsha@gmail.com) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF6DD8812D for ; Fri, 19 Jul 2019 22:15:23 +0000 (UTC) (envelope-from cpogolsha@gmail.com) Received: by mail-yb1-xb2e.google.com with SMTP id c202so11753119ybf.0 for ; Fri, 19 Jul 2019 15:15:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=JVgwQAgobIlXl3yeSKvkHbW8W7hrZu7z+8Npr1ujbiw=; b=kPl7sT6e6TUJgfQX3Iy5zkBWSsmRQYXKUpD9DmGAwzb5nF28GYxBNL7/xm+DGFXvr4 +nB4Z9aAiyg4dXuR6Mbg6JLGHoSkn0pWi5ezn58JoqUtn0p9f+A+PyKgomzM+hDalhiN BipMPIC1JjSBjQut9dBshFuj23fKiZ9AmWpYa3NC+qjnc0mfu4ihrjxMXoTBQIGxolwI 2YeUEOM9KE3JVKdHppTeWkjJmKu249h+caUOffvBKmF99r0i6uvp4dPvgwj88OprT2G0 ciPyJZBG8ZraBFQ4RsSQ/1c473KVAUF+0eAmOkzP4vc3VKK9AJnFw2R+xeo6/Rz3qdPk PccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JVgwQAgobIlXl3yeSKvkHbW8W7hrZu7z+8Npr1ujbiw=; b=ZU5HJ30ys+kE59K2UDZtC/IzBDfD30k3Sb53hblddjRidXjyitri8vwmxYOWsNCM7H 8S9iNFqIJEZWuRSq5+tvPYD2AA/HEhoAJsByEtStekdqMd8iRNUlu+/OfAs6MY+bZogU V9iOKojZx7/+Oo5W6HpGwqAflz/oVlSgefDzbe3KJA/A5Uwem4CsWwfmLcKpjgAaBfn3 Pjr0e2jR/AAsdlSaYikWPLg9yu8fv98mhPbI969CJsGt4b61YEmBsnFc6rt8kN8Te+NJ pVz0t47E8IFtWiJRkmoynv5RyjEiuV1yUGGeW0Urg+ZIOHv4My2VMhMZg+zz9OJwIfRt HBsg== X-Gm-Message-State: APjAAAVD4DSBzZNHLtbKcVd3WRE5gSkHdX+n2RWr7SsvWAnTBfzNcScT xHxjqX4Is1a5DanhUiJPkCKW5qm0eJoTOZ/AEwRdM38h X-Google-Smtp-Source: APXvYqy1ezjmuhR+85Obe0i5b9c4dd+6k1tcoQ45L47bNvO3+PQVn0xg9uUvJD30A/NjZapfR6BNHN9Xy8X9DlfP9vc= X-Received: by 2002:a25:bdcf:: with SMTP id g15mr33966347ybk.419.1563574522815; Fri, 19 Jul 2019 15:15:22 -0700 (PDT) MIME-Version: 1.0 From: Cristian Pogolsha Date: Sat, 20 Jul 2019 00:15:11 +0200 Message-ID: Subject: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 To: freebsd-current@freebsd.org X-Rspamd-Queue-Id: DF6DD8812D X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=kPl7sT6e; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of cpogolsha@gmail.com designates 2607:f8b0:4864:20::b2e as permitted sender) smtp.mailfrom=cpogolsha@gmail.com X-Spamd-Result: default: False [-7.05 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[e.2.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; IP_SCORE(-3.05)[ip: (-9.62), ipnet: 2607:f8b0::/32(-3.13), asn: 15169(-2.43), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 22:15:25 -0000 Hi, I tried recently to boot FreeBSD current r350103 on a Thinkpad A485. It's the AMD Ryzen equivalent of the T480. During the boot I encountered this ACPI related error https://drive.google.com/file/d/1dzgSonn6Cuc1YrDeAUYSqHZlcmzaDY2Y/view Sorry that I'm posting images instead of plain text. I have no idea how to do kernel dumps during the bootload of a live image. I would be happy to post more information if required, let me know how I can do it. Thank you, Cristian From owner-freebsd-current@freebsd.org Fri Jul 19 22:54:59 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BC4B4ADD3F for ; Fri, 19 Jul 2019 22:54:59 +0000 (UTC) (envelope-from contact@evilham.com) Received: from yggdrasil.evilham.com (yggdrasil.evilham.com [IPv6:2a02:2770::216:3eff:fee1:cf9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C7B2B898EC for ; Fri, 19 Jul 2019 22:54:58 +0000 (UTC) (envelope-from contact@evilham.com) Received: from yggdrasil.evilham.com (unknown [IPv6:2a0a:e5c1:121:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by yggdrasil.evilham.com (Postfix) with ESMTPSA id 45r5tL3l7Lz3x1q for ; Sat, 20 Jul 2019 00:54:50 +0200 (CEST) From: Evilham To: freebsd-current@freebsd.org Subject: Re: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 References: In-reply-to: Date: Sat, 20 Jul 2019 00:54:47 +0200 Message-ID: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Rspamd-Queue-Id: C7B2B898EC X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=evilham.com; spf=pass (mx1.freebsd.org: domain of contact@evilham.com designates 2a02:2770::216:3eff:fee1:cf9 as permitted sender) smtp.mailfrom=contact@evilham.com X-Spamd-Result: default: False [-5.47 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-1.71)[ipnet: 2a02:2770::/32(-4.92), asn: 196752(-3.66), country: NL(0.01)]; MX_GOOD(-0.01)[yggdrasil.evilham.com,mail.evilham.com]; DMARC_POLICY_ALLOW(-0.50)[evilham.com,none]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:196752, ipnet:2a02:2770::/32, country:NL]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 22:54:59 -0000 Hey, On ds., jul. 20 2019, Cristian Pogolsha wrote: > I tried recently to boot FreeBSD current r350103 on a Thinkpad > A485. It's > the AMD Ryzen equivalent of the T480. During the boot I > encountered this > ACPI related error > https://drive.google.com/file/d/1dzgSonn6Cuc1YrDeAUYSqHZlcmzaDY2Y/view I have the same laptop and recently spent a fair amount of time getting it to work, I've been wanting to document this in a more proper fashion (e.g. FreeBSD's wiki) but haven't gotten the time, maybe since this will save you time, you would be able to put this and your own findings together and do that? If not, at the very least people searching on the web will have now a better chance to find this email. Note: I run on a daily basis, 12-RELEASE but I tested 13-CURRENT about a month ago and everything applied verbatim. First things: in order to get the Thinkpad A485 to boot, wait until you see the logo and press 3 for boot options, once there type: set hw.pci.mcfg=0 boot It should work alright now, after installing the system, triple check that /boot/loader.conf contains this: # Ryzen hack: FreeBSD bug #231760 # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231760 hw.pci.mcfg=0 # Wireless Intel AC8265 # Not strictly necessary, but the Realtek that is shipped is not supported # You can easily (and carefully) change them. if_iwm_load="YES" iwm8265fw_load="YES" Now, if you want X, you should install drm-kmod and add following to your /etc/rc.conf: # Graphics kld_list="amdgpu" Those are the tricky bits to get the system to work IIRC (also: your ethernet is re1, not re0). After this, the system should work fine (it even suspends and resumes back to X!), with minor glitches and a serious issue. Take into account that I didn't research these too much because they are minor annoyances for me. Minor glitches: - xbacklight doesn't work, neither does intel-backlight because it's AMD - Speakers don't appear to work, audio input/output on 3.5 jack does. - SD card reader doesn't work (Bounty for 125 USD: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=204521) Serious issue: I was just debugging this right now, more infos with a proper bug report will come, but I think the system encounters a deadlock sometimes with the drm-kmod / amdgpu which results in a kernel panic. It is a serious issue, but it allows me to use the computer for work, it doesn't happen every couple hours, but it does happen a couple times a day. FWIW, this is part of the crashlog: WARNING !drm_modeset_is_locked(&plane->mutex) failed at /wrkdirs/usr/ports/graphics/drm-fbsd12.0-kmod/work/kms-drm-6365030/drivers/gpu/drm/drm_atomic_helper.c:821 [Multiple times...] kernel trap 22 with interrupts disabled kernel trap 22 with interrupts disabled kernel trap 22 with interrupts disabled kernel trap 22 with interrupts disabled panic: spin lock held too long > Sorry that I'm posting images instead of plain text. I have no > idea how to > do kernel dumps during the bootload of a live image. I would be > happy to > post more information if required, let me know how I can do it. No worries, it took me forever to find the bug that had the sysctl. I hope this helps you out, -- Evilham From owner-freebsd-current@freebsd.org Fri Jul 19 23:07:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1BBB6AE2D6 for ; Fri, 19 Jul 2019 23:07:34 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4683C8A9E2 for ; Fri, 19 Jul 2019 23:07:33 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from creek.local (ec2-34-214-251-129.us-west-2.compute.amazonaws.com [34.214.251.129]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 865ee9de TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Fri, 19 Jul 2019 23:07:25 +0000 (UTC) Subject: Re: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 To: Evilham , freebsd-current@freebsd.org References: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> From: Pete Wright Message-ID: <56603047-4997-1fb5-18e1-3752cdaf3a18@nomadlogic.org> Date: Fri, 19 Jul 2019 16:07:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 4683C8A9E2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-6.13 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MX_GOOD(-0.01)[mail.nomadlogic.org]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-2.84)[ip: (-9.28), ipnet: 174.136.96.0/20(-4.58), asn: 25795(-0.29), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 23:07:34 -0000 On 7/19/19 3:54 PM, Evilham wrote: > > Serious issue: > I was just debugging this right now, more infos with a proper bug > report will come, but I think the system encounters a deadlock > sometimes with the drm-kmod / amdgpu which results in a kernel panic. > It is a serious issue, but it allows me to use the computer for work, > it doesn't happen every couple hours, but it does happen a couple > times a day. > > FWIW, this is part of the crashlog: > > WARNING !drm_modeset_is_locked(&plane->mutex) failed at > /wrkdirs/usr/ports/graphics/drm-fbsd12.0-kmod/work/kms-drm-6365030/drivers/gpu/drm/drm_atomic_helper.c:821 > [Multiple times...] > kernel trap 22 with interrupts disabled >                            kernel trap 22 with interrupts >                            disabled > kernel trap 22 with interrupts disabled > kernel trap 22 with interrupts disabled >    panic: spin lock held too long > interesting.  can you post this kernel panic, and any backtraces you are able to get here: https://github.com/FreeBSDDesktop/kms-drm/issues also, are you using the xf86-video-amdgpu driver, or the stock modesetting driver to X? thanks! -pete -- Pete Wright pete@nomadlogic.org 310.309.9298 From owner-freebsd-current@freebsd.org Fri Jul 19 23:31:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8DC68AEAC0 for ; Fri, 19 Jul 2019 23:31:51 +0000 (UTC) (envelope-from cpogolsha@gmail.com) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B80B58BA7A for ; Fri, 19 Jul 2019 23:31:50 +0000 (UTC) (envelope-from cpogolsha@gmail.com) Received: by mail-yb1-xb36.google.com with SMTP id y123so10106692yby.10 for ; Fri, 19 Jul 2019 16:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SbehnBf8YorIjAQEGKgMy785jpAODIbg8IOqjRQ0+fY=; b=GdD9HD03GPpupu9HKppcqoBsNalrwfisidtn7Tal22i4gbnqyMw6j+ykBS16PhyP9r QPxd0AylKZILI4zYB2uT7YDdUAp1+9ord6BNKYIzAc0gwoyDpmyRrBwAZPemu+ta7hmU 6UA83TM4LA9bie4X8rxFMLlyo7dcMgf8gtlkSeD6jgTnmlPI2nbVLrdnAWXLeqVWF9/2 hhD/0t8MOErPp9hcZhpWuzkdgVyJ5uolD7RlXL7bxxXBjHmVuL0sR9JUgX18lgvset2h 81pQX2Fd9d+kFlvVpoW7BGzKxYobvnXJMgEc+/IWBFWSQo0dJR9X5a1rlrFS0ds8akSE vYcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SbehnBf8YorIjAQEGKgMy785jpAODIbg8IOqjRQ0+fY=; b=OaqOY4uwEV5YM5nImLKkiOpihHnclhH+5Le/yYi/NIjRHzQRtr+SYG7nhILLqErS7z +v5DoxHq+xMia9Nulgsgl4aP/AkTe683VZ1PQ7b5vkZcrAROgfeKb6dwD7c+y4WV4NM8 Zgh2fxiS66cMOziFjKxKBs4xDe2UMh5VP7LkNlHIM8NxvrIskaGbuj3SzZSpvW5j/3Bu hxwRTTppjUSVqOyLnNUf0+CwpVhtE1VXpu/qbftUN/u3Ky3kGlIHvxOK31W/dLHohzGx Umd+Y9gMBbVfPks0Znww2gAVh5qggpMdOt6o5yp6oIaFQbsIY9qhEbZDm1CLr+qFZ6dW Lmmg== X-Gm-Message-State: APjAAAVN9WAbNzDVRCglzcj/vDHv2D9U30wlhV0nJWWbsf0t06eMLiUM UUKy7jDciqagoGTPlWzllt/HAPyZe0kSXzrDK09ip54P X-Google-Smtp-Source: APXvYqyOjV74R5RNiYzlgdqPOdNKqE27U6u6z7VhTEX7DvJKOc9SV8dosTWwt76cPyWhQxQcYAvhMk5syjIWvnE1HCM= X-Received: by 2002:a25:bdcf:: with SMTP id g15mr34142718ybk.419.1563579109704; Fri, 19 Jul 2019 16:31:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Cristian Pogolsha Date: Sat, 20 Jul 2019 01:31:38 +0200 Message-ID: Subject: Re: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 To: Jordy van Wolferen Cc: freebsd-current@freebsd.org X-Rspamd-Queue-Id: B80B58BA7A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=GdD9HD03; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of cpogolsha@gmail.com designates 2607:f8b0:4864:20::b36 as permitted sender) smtp.mailfrom=cpogolsha@gmail.com X-Spamd-Result: default: False [-6.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[6.3.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-3.00)[ip: (-9.39), ipnet: 2607:f8b0::/32(-3.13), asn: 15169(-2.43), country: US(-0.05)]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2019 23:31:51 -0000 Hi Jordy, Thank you for your fast reply. Your links were very helpful. As per the bugzilla report https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231760, during the kernel load screen I dropped to shell prompt and changed the boot params with command 'set hw.pci.mcfg="0" I was successful booting and installing FreeBSD from there. Hope it works for you too! Kind regards, Cristian On Sat, Jul 20, 2019 at 12:35 AM Jordy van Wolferen wrote: > Hi, > > I have the Thinkpad E485 and I'm also unable to boot FreeBSD on it. > It has some UEFI firmware issues, for linux it needs some kernel arguments > to get it to boot: > "ivrs_ioapic[32]=00:14.0 ivrs_ioapic[33]=00:00.0 iommu=pt" > > https://forums.lenovo.com/t5/Other-Linux-Discussions/ThinkPad-E485-E585-Firmware-bug-ACPI-IVRS-table/td-p/4191484 > . > On linux I have to add the following kernel arguments: > "ivrs_ioapic[32]=00:14.0 ivrs_ioapic[33]=00:00.0 iommu=pt", I would like to > know what the equivalent for FreeBSD arguments are. > > There is also an open bug for Ryzen mobile on FreeBSD: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231760 > > Hope this helps a bit. > > Best regards, > Jordy > > On Sat, Jul 20, 2019 at 12:15 AM Cristian Pogolsha > wrote: > >> Hi, >> >> I tried recently to boot FreeBSD current r350103 on a Thinkpad A485. It's >> the AMD Ryzen equivalent of the T480. During the boot I encountered this >> ACPI related error >> https://drive.google.com/file/d/1dzgSonn6Cuc1YrDeAUYSqHZlcmzaDY2Y/view >> Sorry that I'm posting images instead of plain text. I have no idea how to >> do kernel dumps during the bootload of a live image. I would be happy to >> post more information if required, let me know how I can do it. >> >> Thank you, >> Cristian >> _______________________________________________ >> freebsd-current@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-current >> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org >> " >> > From owner-freebsd-current@freebsd.org Sat Jul 20 08:50:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AB6CAB89B0 for ; Sat, 20 Jul 2019 08:50:31 +0000 (UTC) (envelope-from greg@unrelenting.technology) Received: from out.migadu.com (out.migadu.com [91.121.223.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.migadu.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 39B3472876 for ; Sat, 20 Jul 2019 08:50:29 +0000 (UTC) (envelope-from greg@unrelenting.technology) Received: (Migadu outbound); Sat, 20 Jul 2019 08:50:22 +0000 Received: from [100.72.158.233] ([185.211.157.123]) by out.migadu.com (Haraka/2.8.16) with ESMTPSA id AC07BE06-7231-4836-91B2-2B671C1BD7E5.1 envelope-from (authenticated bits=0) (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 verify=FAIL); Sat, 20 Jul 2019 08:50:21 +0000 Date: Sat, 20 Jul 2019 11:50:18 +0300 User-Agent: K-9 Mail for Android In-Reply-To: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> References: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 To: freebsd-current@freebsd.org,Evilham From: Greg V Message-ID: <405A85A9-1076-4D68-BB85-45D5062BED15@unrelenting.technology> DKIM-Signature: v=1; a=rsa-sha256; bh=l7M53lC8ehnSaReZ+xyYvUJ4yVMexQjdM6Azm+YhPLo=; c=relaxed/simple; d=unrelenting.technology; h=from:subject:date:to; s=default; b=htimTv5NzlkqanfuqxugURE7Hjloy1MfVut4nMCmxmtm0yoaCbyGmN/TMNCIwBtSjKNSAz1aISX3OJPxgSFSaMG+ONfE3u++b0mDoXO6vW5Zcmn0/wFoMDybXTf+5wwAjYtzxRpTSHlmiTokZxMMMubZHUDLlTwN2Qn6jPxczcs= X-Rspamd-Queue-Id: 39B3472876 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=unrelenting.technology header.s=default header.b=htimTv5N; dmarc=pass (policy=none) header.from=unrelenting.technology; spf=pass (mx1.freebsd.org: domain of greg@unrelenting.technology designates 91.121.223.63 as permitted sender) smtp.mailfrom=greg@unrelenting.technology X-Spamd-Result: default: False [-5.92 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[unrelenting.technology:s=default]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:91.121.223.63]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[unrelenting.technology:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[63.223.121.91.list.dnswl.org : 127.0.10.0]; MX_GOOD(-0.01)[aspmx1.migadu.com,aspmx2.migadu.com]; DMARC_POLICY_ALLOW(-0.50)[unrelenting.technology,none]; NEURAL_HAM_SHORT(-0.29)[-0.289,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-2.63)[ip: (-9.90), ipnet: 91.121.0.0/16(-4.39), asn: 16276(1.17), country: FR(-0.01)]; ASN(0.00)[asn:16276, ipnet:91.121.0.0/16, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2019 08:50:31 -0000 On July 20, 2019 1:54:47 AM GMT+03:00, Evilham wrot= e: > it even suspends and resumes back to X Wow, that's great news! Desktop Ryzen+Vega doesn't (not that I need suspen= d very much on desktop haha) >- xbacklight doesn't work, neither does intel-backlight because=20 > it's AMD Since it's a Thinkpad, do the brightness keys work anyway? Does acpi_ibm w= ork? >Serious issue: >I was just debugging this right now, more infos with a proper bug=20 >report will come, but I think the system encounters a deadlock=20 >sometimes with the drm-kmod / amdgpu which results in a kernel=20 >panic=2E If you're on the packaged drm-kmod v4=2E16, it's amazing that Raven GPU wo= rks at all=2E You should try drm-v5=2E0 from git=2E >kld_list=3D"amdgpu" It even works when loaded this early? Interesting=2E Do you also not have = the EFI framebuffer conflict? i=2Ee=2E without disabling vt=2Esyscons, ever= ything just works reliably? From owner-freebsd-current@freebsd.org Sat Jul 20 17:08:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37733C2B9B; Sat, 20 Jul 2019 17:08:40 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A4F488F4B; Sat, 20 Jul 2019 17:08:39 +0000 (UTC) (envelope-from pkelsey@gmail.com) Received: by mail-io1-f49.google.com with SMTP id e20so34656278iob.9; Sat, 20 Jul 2019 10:08:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qwftr7hfAoPOc7UkDypV8VZ/E91Lm1eNDERdVKv3z+s=; b=O8eamPKdMczPcGKP0rdjwb2mBm4icndLorUJmKFLR+h1rPVDhplKCtZITcditw9rVN paV98KUt7u+YdnjG6Z9pDq0B/UmLs+kioukmghBoe0H10BjdQJV5CKJ+X879aYQNvxkM I5dZpij9DIHpmd1ylM1Tc8i50mEG7o5ZxBd1vPiao3XR0sWcqPfryAN2fF8Sgl360kbq j3VmVy+rW6WSGSQzpm+C7ua+kxuzzNcXjt0Xbn4zJLxytVA3NDRBON1v4UDxvcdE2V71 HlWh2Y1i+VP2XWHk5ZPD6VQ3gCaC+GWiNkgwS19pJOFK4qhHaJIeDfCEqwHYNlTCsLbt 5Xfw== X-Gm-Message-State: APjAAAVPJpxPbUTepA7E3ihUvJaJYnFj74zvRV8wDh22Vj5CQx28AoLV +XA/9vQZfXcoKJx26dIj7+jjLCCTu83h9uS2IlAbGEIW X-Google-Smtp-Source: APXvYqz6p5R6RvuZkpPtJ2KRUp57i0OsyvH7L6v4Mo7ls6F0s/B4aw4HArW7jm8c1rzFcLrqMLv3S04tYTytCOTQvyg= X-Received: by 2002:a02:ad15:: with SMTP id s21mr64118056jan.47.1563642512862; Sat, 20 Jul 2019 10:08:32 -0700 (PDT) MIME-Version: 1.0 References: <9c509f7b-8294-d2fe-ea3e-f10fd51f5736@FreeBSD.org> In-Reply-To: <9c509f7b-8294-d2fe-ea3e-f10fd51f5736@FreeBSD.org> From: Patrick Kelsey Date: Sat, 20 Jul 2019 13:08:21 -0400 Message-ID: Subject: Re: vmx0: watchdog timeout on queue 2, no interrupts on BSP To: Andriy Gapon Cc: freebsd-net@freebsd.org, FreeBSD Current X-Rspamd-Queue-Id: 8A4F488F4B X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of pkelsey@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=pkelsey@gmail.com X-Spamd-Result: default: False [-5.51 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.88)[-0.877,0]; FORGED_SENDER(0.30)[pkelsey@freebsd.org,pkelsey@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[pkelsey@freebsd.org,pkelsey@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MIME_TRACE(0.00)[0:+,1:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[49.166.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.62)[ip: (-7.18), ipnet: 209.85.128.0/17(-3.44), asn: 15169(-2.43), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2019 17:08:40 -0000 On Fri, Jul 19, 2019 at 10:07 AM Andriy Gapon wrote: > > Recently we experienced a strange problem. > We noticed a lot of these messages in the logs: > vmx0: watchdog timeout on queue 2 > (always queue 2) > Also, we noticed that connections to some end points did not work at all > while others worked without problems. I assume that that was because > specific flows got assigned to that queue 2. > > Further investigation has shown that none of interrupts assigned to the > BSP has ever fired (since boot, of course). That included vmx0:rx2 and > vmx0:tx2. But also interrupts for other drivers as well. > > Trying to get more information I rebooted the system and the problem > disappeared. > > Has anyone seen anything like that? > Any thoughts on possible causes? > Any suggestions what to check if/when the problem reoccurs? > > Thanks! > > If you are running head at or after r347221 or stable/12 at or after r349112, then this could be due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=239118 (see Comment 4 - short story is that an iflib change has broken the vmx driver). -Patrick From owner-freebsd-current@freebsd.org Sat Jul 20 17:20:22 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B0CF2C2F90 for ; Sat, 20 Jul 2019 17:20:22 +0000 (UTC) (envelope-from contact@evilham.com) Received: from yggdrasil.evilham.com (yggdrasil.evilham.com [46.19.33.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E18BB8955C for ; Sat, 20 Jul 2019 17:20:21 +0000 (UTC) (envelope-from contact@evilham.com) Received: from yggdrasil.evilham.com (unknown [IPv6:2a0a:e5c1:121:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by yggdrasil.evilham.com (Postfix) with ESMTPSA id 45rZPv62Kvz3x1q for ; Sat, 20 Jul 2019 19:20:19 +0200 (CEST) From: Evilham To: freebsd-current@freebsd.org Subject: Re: acpi issues on FreeBSD-current_r350103 on Thinkpad A485 References: <3b186187-c9f6-46d2-939a-eceb6fa0359c@yggdrasil.evilham.com> <56603047-4997-1fb5-18e1-3752cdaf3a18@nomadlogic.org> In-reply-to: <56603047-4997-1fb5-18e1-3752cdaf3a18@nomadlogic.org> Date: Sat, 20 Jul 2019 19:20:16 +0200 Message-ID: <64f3212b-cbe7-4c8f-84df-48f14a0bf44f@yggdrasil.evilham.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Rspamd-Queue-Id: E18BB8955C X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dmarc=pass (policy=none) header.from=evilham.com; spf=pass (mx1.freebsd.org: domain of contact@evilham.com designates 46.19.33.155 as permitted sender) smtp.mailfrom=contact@evilham.com X-Spamd-Result: default: False [-4.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-0.73)[asn: 196752(-3.69), country: NL(0.01)]; MX_GOOD(-0.01)[cached: yggdrasil.evilham.com]; DMARC_POLICY_ALLOW(-0.50)[evilham.com,none]; NEURAL_HAM_SHORT(-0.57)[-0.566,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:196752, ipnet:46.19.32.0/21, country:NL]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2019 17:20:22 -0000 Hey, thanks for the feedback and your work, didn't think this would be interesting for anyone but the laptop owners. On ds., jul. 20 2019, Greg V. wrote: > On July 20, 2019 1:54:47 AM GMT+03:00, Evilham > wrote: > >> it even suspends and resumes back to X > > Wow, that's great news! Desktop Ryzen+Vega doesn't (not that I > need suspend very much on desktop haha) Indeed, I was pleasantly surprised too >>- xbacklight doesn't work, neither does intel-backlight because >> it's AMD > > Since it's a Thinkpad, do the brightness keys work anyway? Does > acpi_ibm work? Forgot to mention brightness keys, they also don't work. I just tried acpi_ibm and it also didn't help. >>Serious issue: >>I was just debugging this right now, more infos with a proper >>bug >>report will come, but I think the system encounters a deadlock >>sometimes with the drm-kmod / amdgpu which results in a kernel >>panic. > > If you're on the packaged drm-kmod v4.16, it's amazing that > Raven GPU works at all. You should try drm-v5.0 from git. > >>kld_list="amdgpu" Huh, interesting, I'm trying to compile drm-v5.0 right now. This comment and Pete's made me re-visit the graphics settings, specifics below. > It even works when loaded this early? Interesting. Do you also > not have the EFI framebuffer conflict? i.e. without disabling > vt.syscons, everything just works reliably? Yes, with my previous laptop that was necessary, but this one has no need for those settings, it works just fine without and font size is according to the screen (i.e. it's not huge). On ds., jul. 20 2019, Pete Wright wrote: > On 7/19/19 3:54 PM, Evilham wrote: >> >> Serious issue: >> I was just debugging this right now, more infos with a proper >> bug >> report will come, but I think the system encounters a deadlock >> sometimes with the drm-kmod / amdgpu which results in a kernel >> panic. >> It is a serious issue, but it allows me to use the computer for >> work, >> it doesn't happen every couple hours, but it does happen a >> couple >> times a day. >> >> FWIW, this is part of the crashlog: >> >> WARNING !drm_modeset_is_locked(&plane->mutex) failed at >> /wrkdirs/usr/ports/graphics/drm-fbsd12.0-kmod/work/kms-drm-6365030/drivers/gpu/drm/drm_atomic_helper.c:821 >> [Multiple times...] >> kernel trap 22 with interrupts disabled >> kernel trap 22 with interrupts >> disabled >> kernel trap 22 with interrupts disabled >> kernel trap 22 with interrupts disabled >> panic: spin lock held too long >> > > interesting. can you post this kernel panic, and any backtraces > you are > able to get here: > > https://github.com/FreeBSDDesktop/kms-drm/issues > > also, are you using the xf86-video-amdgpu driver, or the stock > modesetting driver to X? That was my plan for when I manage to fully isolate that it is on drm-kmod, thank you for confirming the path! I noticed I did have xf86-video-amdgpu installed, but just removed it and all traces of drm-kmod as well as the kld_list="amdgpu" bit and X actually works without it and without the xf86-video packages. HDMI output won't work though, I guess that makes sense. We'll see if working like this the system doesn't crash at all, if it does it may be related to #231760 and not to drm-kmod. If it does not crash without drm-kmod, I'll try my build of drm-kmod v5.0 before opening an issue, that'd be more information :-). I did have the question as to why the packaged version is 4.16 but didn't quite find an answer to that on the wikis / documentation. Thank you again, -- Evilham