From owner-freebsd-drivers@freebsd.org Wed Mar 20 10:10:49 2019 Return-Path: Delivered-To: freebsd-drivers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3CDDA154E913; Wed, 20 Mar 2019 10:10:49 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: from mail-yw1-xc2e.google.com (mail-yw1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 384128ED7E; Wed, 20 Mar 2019 10:10:48 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: by mail-yw1-xc2e.google.com with SMTP id a199so1547480ywa.0; Wed, 20 Mar 2019 03:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=Ci1qgQz4rDm0cRtveWgwh1xHJ53OdowRG+7WytjSvO8=; b=k5aqLdrXdzN6x3zfns10VrkRWZTHsd5JV69syu8fhR8O5gwaUttCWf5/TIt5k3lnVU EkeaHMLBLgXsLdBVLIIQscCF+mzlvXNVijpB2m3hRnCYQ15SL8N4N7aFEKxBXWRT2yxd Ut6DEPC4Zc6dqflgXKDFVsCpxMJjpIggg/sRkebWp1x3BxxoGCguEq9dljTAp1ZTAzOx pIVL+9cU8FXZEcD9BqK8I4ijXkGjAYzi5bevjmv6UTioiNbDLu3iFqQBsqbWPEgdktHf VenWEpDT0lb6YpWoOJjmhyKk8b6jqxX3SKZ3RmND4qG1C5bezIfKC5C3DtgTAGiaQ5wU A34g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=Ci1qgQz4rDm0cRtveWgwh1xHJ53OdowRG+7WytjSvO8=; b=TUl3adMdC/OsI0eSOglh1nEkBjWUkdkmlpcslF5yok7HoncTIZGhHCWhuUOAIMLWh7 /pGAFiFBYHbIJbvBif3eqZ94lYCWOEOO8yJJHCbBdE4yDJnYPPCQkqDsEEsYMiG+kti1 RP3UyY1vsU8QAafE1lTkhJMhVfm5Ivcauxti6XVLCmMrUnRX2e8CqKPtHU41VKik5ppS LvPPc5quXdVBQ3HgXJTmtZuHAL+qldqZoQYwromC+4f4G0wCTJ9ugh+LXVi4ueWsxWyh irBCz8hESehTQsS+KTLJXsPHZ5inLowDzn/jKW1B5JzGbAjfawrGLS6XtVPiX2eghAF+ bBRw== X-Gm-Message-State: APjAAAWJF9StKanV2+5MIeGAZHNuQXszB/VqVIoW+diGuRf3sAwqnsiK pd7lMkh7JAqSlpwyjZZoXwBTjiuvcqLVRcycWnmQ X-Google-Smtp-Source: APXvYqwOH+5VDSIuCztfhyDxEj+SpAag3zsT7/p2sGyUNOwIEQtCt8wIX37HeIkeno3EHyVDDjGE0JJcg+JFLoW2P6A= X-Received: by 2002:a25:6151:: with SMTP id v78mr6192128ybb.359.1553076647286; Wed, 20 Mar 2019 03:10:47 -0700 (PDT) MIME-Version: 1.0 From: shreyank amartya Date: Wed, 20 Mar 2019 15:40:36 +0530 Message-ID: Subject: iflib To: freebsd-drivers@freebsd.org Cc: freebsd-hackers@freebsd.org, mmacy@mattmacy.io X-Rspamd-Queue-Id: 384128ED7E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=k5aqLdrX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of shreyankfbsd@gmail.com designates 2607:f8b0:4864:20::c2e as permitted sender) smtp.mailfrom=shreyankfbsd@gmail.com X-Spamd-Result: default: False [-6.65 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[e.2.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_SHORT(-0.88)[-0.875,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-2.77)[ip: (-8.88), ipnet: 2607:f8b0::/32(-2.79), asn: 15169(-2.11), country: US(-0.07)]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 10:10:49 -0000 Hi, I'm working on writing a device driver for xgbe using iflib. In the iflib interrupt allocation routine: iflib_irq_alloc_generic (sys/net/iflib.c), if the interrupt type is specified as IFLIB_INTR_ADMIN the variable tqrid is set to -1. Based on tqrid check there is a call to taskgroup_attach, but the function would not reach the condition check (if (tqrid != -1) if the type is IFLIB_INTR_ADMIN, which makes me think this might be an error. Can anyone please clarify if this behavior is intentional or this could be an error. Thanks Shreyank Amartya