From owner-freebsd-fs@freebsd.org Sun Jun 16 16:58:17 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A21315C4138 for ; Sun, 16 Jun 2019 16:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 02E98885B4 for ; Sun, 16 Jun 2019 16:58:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B81D415C4137; Sun, 16 Jun 2019 16:58:16 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A571C15C4135 for ; Sun, 16 Jun 2019 16:58:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4055F885AB for ; Sun, 16 Jun 2019 16:58:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8E0331AB23 for ; Sun, 16 Jun 2019 16:58:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5GGwF9k094915 for ; Sun, 16 Jun 2019 16:58:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5GGwFRM094907 for fs@FreeBSD.org; Sun, 16 Jun 2019 16:58:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238398] [zfs] zpool remove returns 'pool already exists' Date: Sun, 16 Jun 2019 16:58:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jun 2019 16:58:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238398 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |fs@FreeBSD.org Keywords| |patch --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Jun 16 21:02:55 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E489415C9BB8 for ; Sun, 16 Jun 2019 21:02:54 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 500D8683AA for ; Sun, 16 Jun 2019 21:02:54 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0F78D15C9BB6; Sun, 16 Jun 2019 21:02:54 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C459715C9BB4 for ; Sun, 16 Jun 2019 21:02:53 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A42D683A3 for ; Sun, 16 Jun 2019 21:02:53 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 62EF71CF35 for ; Sun, 16 Jun 2019 21:02:52 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5GL2qEj065263 for ; Sun, 16 Jun 2019 21:02:52 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5GL2qNZ065256 for fs@FreeBSD.org; Sun, 16 Jun 2019 21:02:52 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201906162102.x5GL2qNZ065256@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 16 Jun 2019 21:02:51 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jun 2019 21:02:55 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS Open | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data Open | 235665 | panic: handle_written_inodeblock: live inodedep Open | 237067 | ZFS: Crash in vdev_dtl_reassess when using GELI w 6 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Mon Jun 17 13:30:20 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0165515B9C50 for ; Mon, 17 Jun 2019 13:30:20 +0000 (UTC) (envelope-from ler@lerctr.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3EF36810F for ; Mon, 17 Jun 2019 13:30:18 +0000 (UTC) (envelope-from ler@lerctr.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:Subject:To:From:Date:Content-Transfer-Encoding: Content-Type:MIME-Version:Sender:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5m5QdqyKTMoQqmJG94o4NxhLCSEF0ATFUEHxUxHXtvs=; b=GeEJNaONPDZWz0Y4TVWrSHCoHa z2+H1ZvrkycKqUUgPhZF1VMVdi18YKHQq5SacnYtWDUKCuk5Gsx+1u61I50WtCDOvpF3xEA+eTETl Qh0XVXqte7SWTsks61q406pVYUttsviMeBql2HDPsvjOo+cawf05R5hv3LPs7C+xbNSUPZmIOhWzR Qv1u7AF+YNzIrtjSqdl0Rwuxi0M6p6LUOREwyhFkhZJXy8lszeynGZVcCoW7uNUIVnc/mNHESIAXw VrzCbHT9xIRiQPKKQQH0pq1OyGXZZ7i2qnFUbedPgF4VLOV8jgP9AN6ujs1m6Ricx2tsHzojqMszg xXcSY9Tw==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:35570 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hcriD-000H9T-HK for freebsd-fs@freebsd.org; Mon, 17 Jun 2019 08:30:17 -0500 Received: from 2600:1700:210:b180:2d19:36a0:28fe:dbb2 by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Mon, 17 Jun 2019 08:30:17 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 17 Jun 2019 08:30:17 -0500 From: Larry Rosenman To: Freebsd fs Subject: ZFS Crash/Pool in unhealthy state Message-ID: X-Sender: ler@lerctr.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 13:30:20 -0000 I had a power failure today and my big server no longer boots If I try to import the pool using the memstick image and -F -f I get a panic (see link). https://www.lerctr.org/~ler/ZFS_CRASH.png <--- Panic https://www.lerctr.org/~ler/ZFS_IMPORT.png <--- import tries. Ideas? Help? -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106 From owner-freebsd-fs@freebsd.org Tue Jun 18 09:42:43 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B35815B38F7 for ; Tue, 18 Jun 2019 09:42:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 108EC6C710 for ; Tue, 18 Jun 2019 09:42:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C2C7E15B38F4; Tue, 18 Jun 2019 09:42:42 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B182C15B38F3 for ; Tue, 18 Jun 2019 09:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 50DF76C70D for ; Tue, 18 Jun 2019 09:42:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 8D4CA10D64 for ; Tue, 18 Jun 2019 09:42:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5I9gfXg060211 for ; Tue, 18 Jun 2019 09:42:41 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5I9gflN060210 for fs@FreeBSD.org; Tue, 18 Jun 2019 09:42:41 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Tue, 18 Jun 2019 09:42:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 09:42:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Assignee|bugs@FreeBSD.org |fs@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Jun 18 17:48:18 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0E42D15C3ED7 for ; Tue, 18 Jun 2019 17:48:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9DCFD87114 for ; Tue, 18 Jun 2019 17:48:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5E4CF15C3ED5; Tue, 18 Jun 2019 17:48:17 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B7B815C3ED4 for ; Tue, 18 Jun 2019 17:48:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC23287111 for ; Tue, 18 Jun 2019 17:48:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 311D215219 for ; Tue, 18 Jun 2019 17:48:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5IHmGXs023065 for ; Tue, 18 Jun 2019 17:48:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5IHmGXk023063 for fs@FreeBSD.org; Tue, 18 Jun 2019 17:48:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Tue, 18 Jun 2019 17:48:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jun 2019 17:48:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 Kirk McKusick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mckusick@FreeBSD.org --- Comment #1 from Kirk McKusick --- Would it be possible for you to send me your tar file so that I can try to reproduce the problem? If so, please do so to me directly at mckusick@freebsd.org rather than posting it here. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Jun 19 05:03:35 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9833815D2473 for ; Wed, 19 Jun 2019 05:03:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 33B49750B8 for ; Wed, 19 Jun 2019 05:03:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id EB96915D2471; Wed, 19 Jun 2019 05:03:34 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D88CE15D246F for ; Wed, 19 Jun 2019 05:03:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 738DE750B4 for ; Wed, 19 Jun 2019 05:03:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id A1F931B31C for ; Wed, 19 Jun 2019 05:03:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5J53XH7000613 for ; Wed, 19 Jun 2019 05:03:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5J53XqX000612 for fs@FreeBSD.org; Wed, 19 Jun 2019 05:03:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238700] mmap bug when using file-systems with small blocks and seeking randomly to read from the file descriptor before mapping Date: Wed, 19 Jun 2019 05:03:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 05:03:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238700 Conrad Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |fs@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Jun 19 05:17:42 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AA0415D277D for ; Wed, 19 Jun 2019 05:17:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A27A675505 for ; Wed, 19 Jun 2019 05:17:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5DB3C15D277C; Wed, 19 Jun 2019 05:17:41 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BF3615D277B for ; Wed, 19 Jun 2019 05:17:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D5B1F75504 for ; Wed, 19 Jun 2019 05:17:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 211B51B482 for ; Wed, 19 Jun 2019 05:17:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5J5Hdux026713 for ; Wed, 19 Jun 2019 05:17:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5J5HdbE026712 for fs@FreeBSD.org; Wed, 19 Jun 2019 05:17:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238700] mmap bug when using file-systems with small blocks and seeking randomly to read from the file descriptor before mapping Date: Wed, 19 Jun 2019 05:17:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 05:17:42 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238700 --- Comment #1 from Conrad Meyer --- I would guess this is a bug in the ext2fs filesystem, although I'm not seei= ng the code you're referring to as "before" in either STABLE/12 or CURRENT. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Jun 19 23:56:06 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B1FA15CE132 for ; Wed, 19 Jun 2019 23:56:06 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660064.outbound.protection.outlook.com [40.107.66.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5C3268930E for ; Wed, 19 Jun 2019 23:56:03 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM (10.165.219.7) by YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM (10.165.219.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.13; Wed, 19 Jun 2019 23:56:02 +0000 Received: from YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM ([fe80::fdaa:6868:bd31:8b7d]) by YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM ([fe80::fdaa:6868:bd31:8b7d%5]) with mapi id 15.20.1987.014; Wed, 19 Jun 2019 23:56:02 +0000 From: Rick Macklem To: "freebsd-fs@freebsd.org" Subject: RFC: should a copy_file_range(2) syscall work across multiple file systems? Thread-Topic: RFC: should a copy_file_range(2) syscall work across multiple file systems? Thread-Index: AQHVJvnAX1ESpadgmUO7NE9/ivxBhQ== Date: Wed, 19 Jun 2019 23:56:02 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4826aeed-0915-4ac7-778a-08d6f511af31 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTXPR01MB0285; x-ms-traffictypediagnostic: YTXPR01MB0285: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0073BFEF03 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(39860400002)(366004)(376002)(346002)(199004)(189003)(81166006)(478600001)(86362001)(99286004)(8936002)(53936002)(2906002)(71190400001)(476003)(33656002)(52536014)(6436002)(316002)(786003)(6506007)(8676002)(81156014)(5660300002)(6306002)(186003)(66946007)(46003)(66476007)(64756008)(6916009)(9686003)(486006)(14454004)(76116006)(66446008)(7696005)(2351001)(305945005)(71200400001)(966005)(74316002)(4744005)(73956011)(74482002)(25786009)(55016002)(68736007)(66556008)(102836004)(2501003)(256004)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0285; H:YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dAKvJsDrx0NRNZdyoeWf1H93MEOuGL7C1H1Zza9om7ubadvdh2x31xjeDHyTLNLn6hqm0bX+W/FTVlfP3zBzNmMp7ItM7s1fjTWrFzJ4zQPuFS6ijiV2xqxV9rlh2OaHDAN4jqZDGfCdp4OQNNKy+LwB2wY2FadDvslakyk2jej311BqzyK4w0AyC6hmuVOKzyCjfXUbwbUDsSd20jx5jyhAIma5SKWMs+YgcRWjvkiffzE69YqV40WmzP3CSciVpDWIYn4APh4brcB5V43u9JTwcFXSAvdA7gaIVfISM8HAIGWWb2djXRZuKTtxK/2kMFQgyubKQkvw77bP5puMiL15m8olDqe3BhrRxyaN3LEZjYtZPr2Va7brVKsD73VQkI85eDFYQE7uuC02B2cpwzdREg3+0xDzPIiFt3ReGWA= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 4826aeed-0915-4ac7-778a-08d6f511af31 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2019 23:56:02.0956 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0285 X-Rspamd-Queue-Id: 5C3268930E X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.64 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-1.04 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.931,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.82)[-0.816,0]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.02)[0.018,0]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; RCVD_IN_DNSWL_NONE(0.00)[64.66.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 23:56:06 -0000 I have been working on a copy_file_range(2) syscall for FreeBSD, which is m= eant to be compatible with the Linux one. (Current patch is at https://reviews.freebsd.org/D20584) One thing the current patch does do is allow the kernel copy to be done acr= oss multiple file systems (ie. source and destination files on different file s= ystems). The Linux syscall *may* not allow this. The man page specifies EXDEV as an error return, but discussion of the Linux syscall suggests that it may be (= or has already been) modified to work across multiple file systems. I thought that this would be a useful feature, but does require the default code to be above the VOP_xxx() layer and *might* not be Linux compatible. (The incompatibility would be working for cases where the Linux syscall mig= ht not.) So, should it work across multiple file systems? rick From owner-freebsd-fs@freebsd.org Thu Jun 20 02:08:14 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 370DC15D0A42 for ; Thu, 20 Jun 2019 02:08:14 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 297338CB24 for ; Thu, 20 Jun 2019 02:08:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f67.google.com with SMTP id d11so1172010lfb.4 for ; Wed, 19 Jun 2019 19:08:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1bZ7yoTDcVdMOaKyMVVHS9VvPl0V0roPIi5MFusPC8U=; b=UZ09M6uLlWeOsKR0pT9B6oQlPiP8JqQXRauqH/BvFGtO75w5joGn57BFtn4dPOTJTs e0gYSrg+dyaTvwOCaOOWWMN2E9wEH/dOdllShHV+COEhluv9FI2MP5qFNvqTzrlJ4vRI kP1w3qwz93gcb5Vv6tQM6TqB7CjxrbdppetruHsit4UREVW57lJsnI4gukR/rWoZ0p4u f1g3S4L3K2J1N4YUXum3Ts9XDezRySiJfAY3HvJt2WEqFkBpBwsNV2PjpvIdW+JhoLig L4sVfKT4Baun0gz0rk8tw3h73G3sQTjvOG5GfRIluwqGN7TE2JbULT2VfcmWskMYyFl1 d0Tw== X-Gm-Message-State: APjAAAWk+ZwGvh9QMvAybOpm2awyTV2ukZWNl0mxWnZYxkGgyBq61YWx iR3ZIpG2xLDqk7POzexSFX/NbelTuB6RPWTGfNeZaQ== X-Google-Smtp-Source: APXvYqzvJqJ9HtbLuHi1bfOqbyyZ08Y6MvpuBhS8xBHZQpYnaE8t9Pwt3ExQWKBye2dFs+kloSjwou7XqDFUUDPeHAM= X-Received: by 2002:ac2:5609:: with SMTP id v9mr6995880lfd.27.1560992118198; Wed, 19 Jun 2019 17:55:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Wed, 19 Jun 2019 18:55:06 -0600 Message-ID: Subject: Re: RFC: should a copy_file_range(2) syscall work across multiple file systems? To: Rick Macklem Cc: "freebsd-fs@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 297338CB24 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.67 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.16 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.89)[-0.892,0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.26)[ip: (-0.52), ipnet: 209.85.128.0/17(-3.43), asn: 15169(-2.31), country: US(-0.06)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[67.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[67.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 02:08:14 -0000 On Wed, Jun 19, 2019 at 5:56 PM Rick Macklem wrote: > > I have been working on a copy_file_range(2) syscall for FreeBSD, which is meant > to be compatible with the Linux one. (Current patch is at > https://reviews.freebsd.org/D20584) > > One thing the current patch does do is allow the kernel copy to be done across > multiple file systems (ie. source and destination files on different file systems). > The Linux syscall *may* not allow this. The man page specifies EXDEV as an > error return, but discussion of the Linux syscall suggests that it may be (or has > already been) modified to work across multiple file systems. > > I thought that this would be a useful feature, but does require the default > code to be above the VOP_xxx() layer and *might* not be Linux compatible. > (The incompatibility would be working for cases where the Linux syscall might not.) > > So, should it work across multiple file systems? > rick I don't think there's anything wrong with it. Do it. From owner-freebsd-fs@freebsd.org Thu Jun 20 14:26:57 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C472815BD2F7 for ; Thu, 20 Jun 2019 14:26:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5BFC4838A9 for ; Thu, 20 Jun 2019 14:26:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1A45415BD2F6; Thu, 20 Jun 2019 14:26:57 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 076F315BD2F5 for ; Thu, 20 Jun 2019 14:26:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97646838A5 for ; Thu, 20 Jun 2019 14:26:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id F08CAD43E for ; Thu, 20 Jun 2019 14:26:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5KEQtcG026741 for ; Thu, 20 Jun 2019 14:26:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5KEQtqf026740 for fs@FreeBSD.org; Thu, 20 Jun 2019 14:26:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Thu, 20 Jun 2019 14:26:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nicolas.masse@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 14:26:57 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 --- Comment #2 from Masse Nicolas --- Created attachment 205236 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205236&action= =3Dedit script use to compute the md5 of the files stored in the archive. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Thu Jun 20 14:27:15 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A05EC15BD340 for ; Thu, 20 Jun 2019 14:27:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3C0AA838FE for ; Thu, 20 Jun 2019 14:27:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id F3B3C15BD33E; Thu, 20 Jun 2019 14:27:14 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E24F115BD33C for ; Thu, 20 Jun 2019 14:27:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7CDAA838F7 for ; Thu, 20 Jun 2019 14:27:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id ABBCFD43F for ; Thu, 20 Jun 2019 14:27:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5KERDNL027084 for ; Thu, 20 Jun 2019 14:27:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5KERDgp027083 for fs@FreeBSD.org; Thu, 20 Jun 2019 14:27:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Thu, 20 Jun 2019 14:27:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nicolas.masse@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 14:27:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 --- Comment #3 from Masse Nicolas --- In fact I can't give you the file I ran my tests with, but fortunately I was able to reproduce the issue with the archive llvm50-5.0.2_1.txz from pkg (t= ook that one because it was on my computer). I also update my scripts in order to have something more generic, so that I= can attach them to this issue. Here is how I did reproduce: - grab the file https://pkg.freebsd.org/FreeBSD:10:amd64/latest/All/llvm50-5.0.2_1.txz (oth= er archives should work too, but this is the one I used for my tests) - untar the archive and generate the md5 file using the script compute_md5.= sh - copy the tar/md5 files on a specific device* - run the test in loop using the command "./test_disk.sh llvm50-5.0.2_1.txz /dev/ md5_llvm5.txt" * only devices with a recent SSD did show the problem The number of retry to have the problem may vary from 3 up to more than 20 attempts (my last run got one corrupted file after 33 attempts). --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Thu Jun 20 14:28:36 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 463E515BD431 for ; Thu, 20 Jun 2019 14:28:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D5B0A83A1E for ; Thu, 20 Jun 2019 14:28:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9943B15BD42F; Thu, 20 Jun 2019 14:28:35 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 87C7715BD42C for ; Thu, 20 Jun 2019 14:28:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27B2883A1A for ; Thu, 20 Jun 2019 14:28:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6FDFBD441 for ; Thu, 20 Jun 2019 14:28:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5KESY4m028487 for ; Thu, 20 Jun 2019 14:28:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5KESYcG028486 for fs@FreeBSD.org; Thu, 20 Jun 2019 14:28:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Thu, 20 Jun 2019 14:28:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: nicolas.masse@stormshield.eu X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 14:28:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 --- Comment #4 from Masse Nicolas --- Created attachment 205237 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205237&action= =3Dedit script used to trigger the issue --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Thu Jun 20 17:29:43 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9062615C298B for ; Thu, 20 Jun 2019 17:29:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1E3A88CC2B for ; Thu, 20 Jun 2019 17:29:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CDCE915C2989; Thu, 20 Jun 2019 17:29:42 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAE6C15C2988 for ; Thu, 20 Jun 2019 17:29:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B2388CC22 for ; Thu, 20 Jun 2019 17:29:42 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9A068EE0D for ; Thu, 20 Jun 2019 17:29:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5KHTeJs042884 for ; Thu, 20 Jun 2019 17:29:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5KHTett042883 for fs@FreeBSD.org; Thu, 20 Jun 2019 17:29:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238663] [UFS] Corrupted files since migration to FreeBSD11 Date: Thu, 20 Jun 2019 17:29:40 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 17:29:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238663 Kirk McKusick changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #5 from Kirk McKusick --- Thanks. I will see if I am able to reproduce the problem. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Jun 21 18:31:32 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C32E15BB0EA for ; Fri, 21 Jun 2019 18:31:32 +0000 (UTC) (envelope-from coat@bitteragency.icu) Received: from bitteragency.icu (2y2zk2jg.ni.net.tr [89.252.172.163]) by mx1.freebsd.org (Postfix) with ESMTP id 5A14772D9D for ; Fri, 21 Jun 2019 18:31:31 +0000 (UTC) (envelope-from coat@bitteragency.icu) From: "Shark Tank Product Alert" Date: Fri, 21 Jun 2019 13:27:40 -0500 MIME-Version: 1.0 Subject: This drink is your solution to becoming skinny To: Message-ID: X-Rspamd-Queue-Id: 5A14772D9D X-Spamd-Bar: ++++ X-Spamd-Result: default: False [4.25 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bitteragency.icu:s=mail]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:89.252.172.163]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; HTML_SHORT_LINK_IMG_1(2.00)[]; NEURAL_SPAM_MEDIUM(0.89)[0.886,0]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_SHORT(0.85)[0.846,0]; DKIM_TRACE(0.00)[bitteragency.icu:+]; DMARC_POLICY_ALLOW(-0.50)[bitteragency.icu,quarantine]; NEURAL_SPAM_LONG(0.94)[0.942,0]; MX_GOOD(-0.01)[cached: aspmx.l.google.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; IP_SCORE(0.58)[asn: 51559(2.86), country: TR(0.06)]; ASN(0.00)[asn:51559, ipnet:89.252.172.0/24, country:TR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jun 2019 18:31:32 -0000 Shark Tank - ""Best Product Of 2019" Flatten Your Tummy This Amazing New Product Has Just Hit The Shark Tank! "I can't beleive it - I am proud of my body again. All I can say is THANK YOU!" You can forget diet and excercise - just drink THIS What's In The Drink? if you want to unsubscribe pleasego here. or can write to us at: 7648 Arnold St. Martinsville, VA 24112 From owner-freebsd-fs@freebsd.org Sat Jun 22 16:02:01 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6CCFC15D7C41 for ; Sat, 22 Jun 2019 16:02:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660043.outbound.protection.outlook.com [40.107.66.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5C3182E81; Sat, 22 Jun 2019 16:01:59 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM (10.165.219.7) by YTXPR01MB0669.CANPRD01.PROD.OUTLOOK.COM (10.165.221.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.13; Sat, 22 Jun 2019 16:01:57 +0000 Received: from YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM ([fe80::fdaa:6868:bd31:8b7d]) by YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM ([fe80::fdaa:6868:bd31:8b7d%5]) with mapi id 15.20.1987.014; Sat, 22 Jun 2019 16:01:57 +0000 From: Rick Macklem To: "freebsd-fs@freebsd.org" CC: Sean Fagan , Alan Somers Subject: RFC: What should a copy_file_range(2) syscall do by default? Thread-Topic: RFC: What should a copy_file_range(2) syscall do by default? Thread-Index: AQHVKREqKzvk0WaXu025/Chow1UOHQ== Date: Sat, 22 Jun 2019 16:01:57 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 41b9c767-b745-466b-ef58-08d6f72af412 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTXPR01MB0669; x-ms-traffictypediagnostic: YTXPR01MB0669: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0076F48C8A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(396003)(366004)(136003)(39860400002)(189003)(199004)(316002)(305945005)(52536014)(2501003)(486006)(9686003)(186003)(7696005)(102836004)(54906003)(8936002)(68736007)(6506007)(99286004)(14454004)(86362001)(786003)(478600001)(5660300002)(256004)(53936002)(74482002)(2906002)(476003)(6436002)(2351001)(33656002)(6916009)(81156014)(8676002)(74316002)(55016002)(81166006)(64756008)(66476007)(66556008)(66946007)(66446008)(4326008)(73956011)(46003)(25786009)(71190400001)(71200400001)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR01MB0669; H:YTXPR01MB0285.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: hYUV5kXkH2Vlc4UtiFxSjbDwICMlp9tihokuyA7vmCUU5GiM3jBwKdbSFCsdRlLutCJxaAe3XWU0Lf+UPwbakHrAv4TCljpQitIWVlFrTFuFmWFL8796dsvG+WrO6Do7VhKKsspqqqZcoLOx9ZnVsG/S5+Qj9IHiUMypbfxcvGKSLYIMePbSvhIcCDEG8IKU7yp83wz2NW9PLDuikjqk057/XXeIB57zeYWHzR3oA95CM5x/ZTBlftX6A3yw4PX4kFU6levItKWtkCRwN7MSDA6PEfGw5DnaKLE88Wp7zSUB6Bk10+6x5xK9tE5wCzr4Tp3fQrb3YwJVIlID4yKfTbv1Je49I8sc10PTh0lbR3DYQVr+rirqZZ/K0jZhugFew8FBj/pAumx5m3Sgj9PfeDln7NT5ORiWb9MycQZE3bU= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 41b9c767-b745-466b-ef58-08d6f72af412 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2019 16:01:57.4462 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR01MB0669 X-Rspamd-Queue-Id: B5C3182E81 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.43 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.13 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.79)[-0.795,0]; RCVD_IN_DNSWL_NONE(0.00)[43.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.02)[ipnet: 40.64.0.0/10(-2.89), asn: 8075(-2.17), country: US(-0.06)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; MIME_TRACE(0.00)[0:+] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2019 16:02:01 -0000 Hi, sef@ made this comment on phabricator. I don't believe phabricator is the c= orrect place for "big picture" discussions, so I'm posting it here (I'm assuming s= ef@ doesn't mind, since the phabricator comments are public). sef@ wrote: >This much work in the kernel for what //should// be user-space makes me tw= itchy... >but there is lots of precedent for it, so I obviously have to get= with the times. > =20 > I've done a quick review of the code; it seems most of the complexity is= in the hole->detection. I'm also annoyed that linux used size_t for the a= mount to copy, when >off_t would have been more appropriate. But not much = to do about that now. > =20 > Having a default implementation means that user-space can't fall back if= it's not >supported, and do it better (e.g., parallel I/O). Should we als= o have a pathconf for >the feature? > =20 > WRT your question on -fs, I have no objections to this working cross-fil= esystem, >although I think I might ask to have a flag to fail in that case. Well, all I am interested in is a system call/VOP call so the NFSv4.2 clien= t can do a file copy locally on the NFS server instead of doing Reads/Writes across = the wire. The current code has gotten fairly complex, so I'll try and ask "how comple= x" this syscall/VOP call should be? The range of variants I can think of are: 0) - Don't do it at all. 1) - The syscall could just do a VOP_COPY_FILE_RANGE() and return whatever = error it returns. --> This implies an error return for all file systems for now, with= support for=20 NFSv4.2mounts being added later (FreeBSD13 hopefully). 2) - The syscall could fall back on a simple copy loop, but not try to deal= with holes. --> The Linux man page mentions using copy_file_range(2) in a loop w= ith lseek(SEEK_DATA)/lseek(SEEK_HOLE) for sparse files. This sugge= sts that the Linux fallback code doesn't try to handle holes. 3) - The current patch which tries to handle holes and copy the entire byte= range in one call. As sef@ mentions, there is also the question of handling copying across mul= tiple file systems. I asked about this before and I only got the one response, wh= ich was "do it". I have seen a discussion of adding cross-mount to the syscall for = Linux, but I don't know if/when the Linux one might support that. (They have not creat= ed a "flag" option for this, as far as I've seen.) It happens without additional complexity for #2 and #3 above. Linux discussions have talked about improved performance for local file sys= tems based on reduced # of system calls, but I have not seen any data to show wh= at, if any, performance improvement has been observed. (The slow hardware I hav= e to test on won't be useful for performance evaluation.) So, what do others think w.r.t. the above? rick From owner-freebsd-fs@freebsd.org Sat Jun 22 17:17:37 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9AE615D8EB1 for ; Sat, 22 Jun 2019 17:17:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 6FF2084D56 for ; Sat, 22 Jun 2019 17:17:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 3114415D8EB0; Sat, 22 Jun 2019 17:17:37 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DAD015D8EAF for ; Sat, 22 Jun 2019 17:17:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A310584D53 for ; Sat, 22 Jun 2019 17:17:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CA8FA890D for ; Sat, 22 Jun 2019 17:17:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5MHHZW9069020 for ; Sat, 22 Jun 2019 17:17:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5MHHZRj069019 for fs@FreeBSD.org; Sat, 22 Jun 2019 17:17:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 238700] mmap bug when using file-systems with small blocks and seeking randomly to read from the file descriptor before mapping Date: Sat, 22 Jun 2019 17:17:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kib@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2019 17:17:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238700 Konstantin Belousov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kib@FreeBSD.org --- Comment #2 from Konstantin Belousov --- Why do you use ext fs at all ? Can you reproduce this with UFS ? (I think not because minimal fragment si= ze for UFS is 512 and block size is 4096). --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sat Jun 22 17:35:44 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4514615D92DF for ; Sat, 22 Jun 2019 17:35:44 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 218F9855B2 for ; Sat, 22 Jun 2019 17:35:43 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f68.google.com with SMTP id y13so7168159lfh.9 for ; Sat, 22 Jun 2019 10:35:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ui1qp2ejfWk6OW9XUP2aRDzPq7sbVCkuEZe924eHsWg=; b=TeGGzJVznDkF8QBFmJfFlvvz/cPxmZHUJJE3xyyJGr03DWrwg14YMII9TWcQVXZRZv 2m8stJw9NtIlfcdGAHibb4Gj+RclBfU7DokusocdaE1D26S1DoqM+P+6X9mOYkz/LTON wN0j7s8FyoJ2LOyMUK/J1fsDprdclXNfgsv4Doq7B0bIVfBk1tcE7TDQks1fiGC+IqVE VJ3PcL00jEJLADTpSB38tgIuJuS4LD62EhM6ukdm67u3wGnf4sjegx1+OxYHa5yF24sZ DBH2QiShljWv9PuD2qjz+2JcIKOYh/HRmlQ3tnNfkiH97yeFxNMzT24uyVC3Z+nycPQ8 Eb2A== X-Gm-Message-State: APjAAAU7v2DgBAakqfbdZiiEU/iLN3UhvqzaoK+oF7VOD8wImJ2gDMHo hBC34KHPsV6Fpv5Gzbc2uhswF6gTkSJ/dL95cKg= X-Google-Smtp-Source: APXvYqwSsBr5DUNx6dYcPA2BbD7hKQgUL5OAYqMQIxuG2RtYI320uAaDD/jScXHPkmVbg2WOkDXQ44EhqEBhVjuk4SE= X-Received: by 2002:a19:671c:: with SMTP id b28mr3644162lfc.164.1561224494787; Sat, 22 Jun 2019 10:28:14 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Sat, 22 Jun 2019 11:28:03 -0600 Message-ID: Subject: Re: RFC: What should a copy_file_range(2) syscall do by default? To: Rick Macklem Cc: "freebsd-fs@freebsd.org" , Sean Fagan Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 218F9855B2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.68 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.87)[-0.873,0]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; IP_SCORE(-1.12)[ip: (0.24), ipnet: 209.85.128.0/17(-3.44), asn: 15169(-2.33), country: US(-0.06)]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[68.167.85.209.list.dnswl.org : 127.0.5.0]; RCVD_TLS_LAST(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[68.167.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2019 17:35:44 -0000 On Sat, Jun 22, 2019 at 10:02 AM Rick Macklem wrote: > > Hi, > > sef@ made this comment on phabricator. I don't believe phabricator is the correct > place for "big picture" discussions, so I'm posting it here (I'm assuming sef@ doesn't > mind, since the phabricator comments are public). > sef@ wrote: > >This much work in the kernel for what //should// be user-space makes me twitchy... >but there is lots of precedent for it, so I obviously have to get with the times. > > > > I've done a quick review of the code; it seems most of the complexity is in the hole->detection. I'm also annoyed that linux used size_t for the amount to copy, when >off_t would have been more appropriate. But not much to do about that now. > > > > Having a default implementation means that user-space can't fall back if it's not >supported, and do it better (e.g., parallel I/O). Should we also have a pathconf for >the feature? > > > > WRT your question on -fs, I have no objections to this working cross-filesystem, >although I think I might ask to have a flag to fail in that case. > > Well, all I am interested in is a system call/VOP call so the NFSv4.2 client can do > a file copy locally on the NFS server instead of doing Reads/Writes across the wire. > The current code has gotten fairly complex, so I'll try and ask "how complex" this > syscall/VOP call should be? > > The range of variants I can think of are: > 0) - Don't do it at all. > 1) - The syscall could just do a VOP_COPY_FILE_RANGE() and return whatever error > it returns. > --> This implies an error return for all file systems for now, with support for > NFSv4.2mounts being added later (FreeBSD13 hopefully). This option would require applications or the C library to fallback to a copy loop. While doable, nothing in userland would be able to range-lock the file, making the copy loop non-atomic. So the in-kernel copy is superior. > 2) - The syscall could fall back on a simple copy loop, but not try to deal with holes. > --> The Linux man page mentions using copy_file_range(2) in a loop with > lseek(SEEK_DATA)/lseek(SEEK_HOLE) for sparse files. This suggests that > the Linux fallback code doesn't try to handle holes. Same problem as 1. Or if you do the copy loop in-kernel it would waste CPU time and expand sparse files, which isn't good either. > 3) - The current patch which tries to handle holes and copy the entire byte range > in one call. Definitely the best option, despite its complexity. I would argue that the complexity calls for a robust test suite, rather than abandoning the feature. -Alan From owner-freebsd-fs@freebsd.org Sat Jun 22 22:35:26 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23D9715BB932 for ; Sat, 22 Jun 2019 22:35:26 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 478F78FF58 for ; Sat, 22 Jun 2019 22:35:24 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id 6DF6514BC0; Sat, 22 Jun 2019 15:35:17 -0700 (PDT) To: rmacklem@uoguelph.ca Subject: Re: RFC: What should a copy_file_range(2) syscall do by default? Cc: freebsd-fs@freebsd.org Message-Id: <20190622223517.6DF6514BC0@kithrup.com> Date: Sat, 22 Jun 2019 15:35:17 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 478F78FF58 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-3.46 / 15.00]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[earth.kithrup.com,kithrup.com,backup-1.kithrup.com]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; IP_SCORE(-2.26)[ip: (-7.62), ipnet: 96.64.0.0/11(-3.65), asn: 7922(0.03), country: US(-0.06)]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2019 22:35:26 -0000 >Well, all I am interested in is a system call/VOP call so the NFSv4.2 >client can do >a file copy locally on the NFS server instead of doing Reads/Writes >across the wire. >The current code has gotten fairly complex, so I'll try and ask "how >complex" this >syscall/VOP call should be? In a previous life, I was responsible for one of the file copy libraries, so this is something I do have experience with. (I find the copy-range syscall interesting; AFP had a command to copy an entire hierachy on the server.) > --> The Linux man page mentions using copy_file_range(2) in a loop with > lseek(SEEK_DATA)/lseek(SEEK_HOLE) for sparse files. This >suggests that > the Linux fallback code doesn't try to handle holes. As far as I can tell, correct; instead, the copy routine looks for holes in user space, and copies the non-holes. >Linux discussions have talked about improved performance for local file systems >based on reduced # of system calls, but I have not seen any data to show what, >if any, performance improvement has been observed. (The slow hardware I have >to test on won't be useful for performance evaluation.) My experience shows that it's minimal, if all it will be copying is a single file. There would have to be a lot of system calls, and a *lot* of syscall overhead, for that to hold sway -- and they're also doing the checks for holes, which may end up increasing the number of system calls for them by a significant amount. I'm still skeptical. Alan mentioned locking, which does buy you something, but it also means *locking the file while it is being copied*. Which, for large files, is not so great. I also don't think you can call any large copy atomic, unless you're using a signle transaction for the entire copy. Anyway: I don't have a big objection to it, other than putting a lot of work into a system call, but as I said I'm clearly a couple decades behind on that sentiment :). From owner-freebsd-fs@freebsd.org Sat Jun 22 23:10:24 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB2D515BCB5D for ; Sat, 22 Jun 2019 23:10:23 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660075.outbound.protection.outlook.com [40.107.66.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D940B6A6AE for ; Sat, 22 Jun 2019 23:10:22 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB0278.CANPRD01.PROD.OUTLOOK.COM (10.165.131.138) by YQXPR01MB2728.CANPRD01.PROD.OUTLOOK.COM (52.132.92.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Sat, 22 Jun 2019 23:10:20 +0000 Received: from YQXPR01MB0278.CANPRD01.PROD.OUTLOOK.COM ([fe80::6061:d04a:9a88:62ce]) by YQXPR01MB0278.CANPRD01.PROD.OUTLOOK.COM ([fe80::6061:d04a:9a88:62ce%5]) with mapi id 15.20.1987.014; Sat, 22 Jun 2019 23:10:20 +0000 From: Rick Macklem To: Sean Eric Fagan CC: "freebsd-fs@freebsd.org" Subject: Re: RFC: What should a copy_file_range(2) syscall do by default? Thread-Topic: RFC: What should a copy_file_range(2) syscall do by default? Thread-Index: AQHVKUrHiWvL2+NTtUq87Jz5w0yVWaaoSFJI Date: Sat, 22 Jun 2019 23:10:20 +0000 Message-ID: References: <20190622223517.6DF6514BC0@kithrup.com> In-Reply-To: <20190622223517.6DF6514BC0@kithrup.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70f00759-84d6-43df-eee2-08d6f766cc60 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR01MB2728; x-ms-traffictypediagnostic: YQXPR01MB2728: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0076F48C8A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(136003)(346002)(39850400004)(396003)(199004)(189003)(53936002)(6246003)(33656002)(7696005)(786003)(229853002)(6436002)(4326008)(305945005)(55016002)(74316002)(9686003)(6506007)(5660300002)(186003)(66446008)(64756008)(66556008)(66476007)(52536014)(316002)(102836004)(81166006)(81156014)(8676002)(8936002)(76116006)(66946007)(73956011)(76176011)(99286004)(486006)(256004)(14454004)(478600001)(476003)(11346002)(446003)(6916009)(46003)(2906002)(68736007)(71190400001)(71200400001)(86362001)(74482002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB2728; H:YQXPR01MB0278.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 33oTTHTRVYXWktnl3/SPqzTFXbQgVvzbqqdsbT+OZ437Qrcx2QnKAMbIxm4erQp8SXKBh8WTHehbQ2oCLKcSQabzPzwiAiJM7PJHIUhbk5fkQxN0bv3MiBIaHNfTSmJ5IPG/qcRtkWs3FM4BeZA1oO75zUDl1f1Gbo4kkcHz+LF2bt08Nn9N7NfMY91LdJx00HW49UZa1tjLVS7IWct072FvVDaEz8kUfFUZd4pbFpUUtSF3A4DvDBsTtw8JoyNS2EZhf9RN2r6k8LYa2+5afTLsmT/Fm6SjIi0oozFKd0IZj/dXB3ddQy9NrsyiPirE1AGrqmdwomVSVvh/kK60ftlWDKv/oOL0fC8pWDx8XDdGoGd24r9dpvfs88Zr9y/efiK3DIgn51HWBWYf6A8lyG27i8ivSzFBAq1aERF2qwE= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 70f00759-84d6-43df-eee2-08d6f766cc60 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jun 2019 23:10:20.6362 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB2728 X-Rspamd-Queue-Id: D940B6A6AE X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.75 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-1.60 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.80)[-0.798,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-0.91)[-0.910,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[75.66.107.40.list.dnswl.org : 127.0.3.0]; NEURAL_HAM_SHORT(-0.58)[-0.577,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jun 2019 23:10:24 -0000 Sean Eric Fagan wrote: >>Well, all I am interested in is a system call/VOP call so the NFSv4.2 >>client can do >>a file copy locally on the NFS server instead of doing Reads/Writes >>across the wire. >>The current code has gotten fairly complex, so I'll try and ask "how >>complex" this >>syscall/VOP call should be? > >In a previous life, I was responsible for one of the file copy libraries, = so >this is something I do have experience with. (I find the copy-range sysca= ll >interesting; AFP had a command to copy an entire hierachy on the server.) > >> --> The Linux man page mentions using copy_file_range(2) in a loop= with >> lseek(SEEK_DATA)/lseek(SEEK_HOLE) for sparse files. This >>suggests that >> the Linux fallback code doesn't try to handle holes. > >As far as I can tell, correct; instead, the copy routine looks for holes i= n >user space, and copies the non-holes. For NFSv4.2, the client can do SEEK_DATA/SEEK_HOLE against the server, alth= ough it does imply extra RPC RTTs. >>Linux discussions have talked about improved performance for local file s= ystems >>based on reduced # of system calls, but I have not seen any data to show = what, >>if any, performance improvement has been observed. (The slow hardware I h= ave >>to test on won't be useful for performance evaluation.) > >My experience shows that it's minimal, if all it will be copying is a sing= le >file. There would have to be a lot of system calls, and a *lot* of syscal= l >overhead, for that to hold sway -- and they're also doing the checks for >holes, which may end up increasing the number of system calls for them by = a >significant amount. I'm still skeptical. Yes, my hunch is the same. However, I do expect a performance improvement for NFS (at least for large = files), due to savings w.r.t. RPC RTTs and avoiding data going server->client->serv= er. I suspect avoiding the kernel/userspace transitions may help w.r.t. fuse, t= oo. >Alan mentioned locking, which does buy you something, but it also means >*locking the file while it is being copied*. Which, for large files, is n= ot >so great. I also don't think you can call any large copy atomic, unless >you're using a signle transaction for the entire copy. I tried posting w.r.t. atomicity and didn't get a lot of responses. However= , although kib@ didn't exactly say it should be the case, he did point out that FreeBS= D has traditionally ensured atomicity of file updates for syscalls and felt that = was a good thing. As such, I've done the range locking of both files and created new p= rimitives to do that while avoiding deadlock. If others have opinions w.r.t. atomicity of file data updates within this s= yscall, please post to either that thread or this one. >Anyway: I don't have a big objection to it, other than putting a lot of w= ork >into a system call, but as I said I'm clearly a couple decades behind on t= hat >sentiment :). Thanks for your comments. However, you didn't seem to indicate your preferr= ed alternative? I, personally, don't care, but would like to find out what the "collective"= thinks, rick.