From owner-freebsd-hackers@freebsd.org Sun Sep 1 17:43:29 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C1A3E0298; Sun, 1 Sep 2019 17:43:29 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46M0tm4Nlpz4ZfY; Sun, 1 Sep 2019 17:43:28 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 24F602602FE; Sun, 1 Sep 2019 19:43:13 +0200 (CEST) Subject: Re: FCP 20190401-ci_policy: CI policy To: Warner Losh , Ed Maste Cc: FreeBSD Hackers , Li-Wen Hsu , fcp@freebsd.org References: <20190829114057.GZ71821@kib.kiev.ua> <20190830065534.GC71821@kib.kiev.ua> <73111.1567263258@kaos.jnpr.net> From: Hans Petter Selasky Message-ID: <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> Date: Sun, 1 Sep 2019 19:42:29 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46M0tm4Nlpz4ZfY X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-6.43 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.948,0]; IP_SCORE(-3.19)[ip: (-9.37), ipnet: 88.99.0.0/16(-4.75), asn: 24940(-1.81), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 17:43:29 -0000 Hi, If the fallouts could be better organized through some simple guidelines, that would be more accepted I think: 1) Don't commit stuff before going off work. Even though a change looks innocent, it might break something and you'll need to fix it. 2) Organize big changes going into the kernel, to ease debugging and getting things back on track again. 3) If your patch is risky, commit it on a Monday. Don't wait until Friday. Failure to follow the rules may have consequences like other senior developers kicking in and doing temporary reverts until issues are resolved. --HPS From owner-freebsd-hackers@freebsd.org Sun Sep 1 19:34:03 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAB73E2E13; Sun, 1 Sep 2019 19:34:03 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M3LL4tgLz3F7F; Sun, 1 Sep 2019 19:34:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x632.google.com with SMTP id m9so5600902pls.8; Sun, 01 Sep 2019 12:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=l63SofxVDdd784Vg8NAJW4Os6jIUWrx1WnY+YevpVQA=; b=qt4p0mMCsPkHG9aMTQ9D1pgWW1dFa/rwZS4ddMl8lg3edjbt7Tw+XRQbNAQ060n7Y7 EnvF2yH//DQkRgNj5jG+egP89tfBQ6HX9bT3fS9HcLiSjN+W5Fz3aVtKemh2XlpWYl+b cdBgcGu6zokTbeOsjT5QfJBwZsFdSRyQ7atxVOZMgRctHCkVj8l1/gtI0oThaazWYpIq 5hoH4FqtNw1WpWDCWNCt4jMbd5O5M7/R8r8PhlJ9oXLMO+R7JUNpV0e7smEvfg/uXyyq q5MTuhWhO37Q+9WqizOzUgG1l0FRsXBF9My9yYHQQQ8Cuw+N0855VaaiGL21OUejc8U/ kQzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=l63SofxVDdd784Vg8NAJW4Os6jIUWrx1WnY+YevpVQA=; b=n2BG9EKfq1YZdsanc6wlzC8rVG7JJWUJQ80eC0PmwZcMX99It097JkqDxY7TRGBvnm Bm8zg4sKbuDa+AKWy1ElrM74mG8OCt0KsKtNr/3EBJK3ySBatWSjXrJUwsUkWTOdaXdc yHYUc0Ndtudto9OLcWa3Ey9WVLO3oGjPEMtYObrVmyaZxUJ5gAb240fjFyUbG5mRTRKv 5ecc2Qxzdjyj3ioSUtn0xa4M6GS5DLp4fQWCvcwDGtkCzb/DBSKxWhm83/K5QFX7EgFS T+BBW3Di1I8+3YJ4sox9xVvuFqnaaSFVuaDYFU6VCc8IrWT/ghfnfxpOqQlO6R0O4MUf dSww== X-Gm-Message-State: APjAAAXvPuQQvWuXM0+G18vcB9mMwl0LOEDmOXPku5OZnfvcChXUXVkz VFmcu0haST3EfF5ooCtqT5U= X-Google-Smtp-Source: APXvYqzNdXi1saf7QuDNlXkLTtPiKk5QpC1hIfXhG0YspG4DaiqRLiA+yAqvBL4kVZ5GumeeneLF2Q== X-Received: by 2002:a17:902:b605:: with SMTP id b5mr26706199pls.103.1567366441112; Sun, 01 Sep 2019 12:34:01 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id ck8sm10242835pjb.25.2019.09.01.12.33.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Sep 2019 12:34:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: FCP 20190401-ci_policy: CI policy From: Enji Cooper In-Reply-To: <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> Date: Sun, 1 Sep 2019 12:33:59 -0700 Cc: Warner Losh , Ed Maste , FreeBSD Hackers , Li-Wen Hsu , fcp@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> References: <20190829114057.GZ71821@kib.kiev.ua> <20190830065534.GC71821@kib.kiev.ua> <73111.1567263258@kaos.jnpr.net> <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 46M3LL4tgLz3F7F X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qt4p0mMC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::632 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; RECEIVED_SPAMHAUS_PBL(0.00)[228.52.19.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-9.54), ipnet: 2607:f8b0::/32(-2.83), asn: 15169(-2.31), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 19:34:03 -0000 > On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky = wrote: >=20 > Hi, >=20 > If the fallouts could be better organized through some simple = guidelines, that would be more accepted I think: >=20 > 1) Don't commit stuff before going off work. Even though a change = looks innocent, it might break something and you'll need to fix it. >=20 > 2) Organize big changes going into the kernel, to ease debugging and = getting things back on track again. >=20 > 3) If your patch is risky, commit it on a Monday. Don't wait until = Friday. >=20 > Failure to follow the rules may have consequences like other senior = developers kicking in and doing temporary reverts until issues are = resolved. Agreed. There=E2=80=99s a reason why at my most former job (FB) we = generally knew better than to commit code on a Friday. It would cause = the weekend oncalls a lot of grief. Let=E2=80=99s put it this way: think of it like being oncall for code. = If you don=E2=80=99t have someone else to work with who can manage it, = would you like to be paged if something went south with your code = committed on a Friday? Cheers, -Enji= From owner-freebsd-hackers@freebsd.org Sun Sep 1 19:48:43 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EADBFE3434; Sun, 1 Sep 2019 19:48:43 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46M3gG25tNz3FkW; Sun, 1 Sep 2019 19:48:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 4Vq2iomg5SrVc4Vq3i7K7H; Sun, 01 Sep 2019 13:48:40 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=8nJEP1OIZ-IA:10 a=J70Eh1EUuV4A:10 a=pGLkceISAAAA:8 a=ndaoGXS1AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=Md3c0C-VMmJUd6EbHGwA:9 a=wPNLvfGTeEIA:10 a=mFeOnlTyF09QQMGr2mMI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id AC31F52F; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x81Jmb1F004577; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x81JmbS3004574; Sun, 1 Sep 2019 12:48:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201909011948.x81JmbS3004574@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Enji Cooper cc: Hans Petter Selasky , FreeBSD Hackers , Ed Maste , Li-Wen Hsu , Warner Losh , fcp@freebsd.org Subject: Re: FCP 20190401-ci_policy: CI policy In-reply-to: <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> References: <20190829114057.GZ71821@kib.kiev.ua> <20190830065534.GC71821@kib.kiev.ua> <73111.1567263258@kaos.jnpr.net> <44a1a905-9b35-620b-281c-cdbbee538bed@selasky.org> <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com> Comments: In-reply-to Enji Cooper message dated "Sun, 01 Sep 2019 12:33:59 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Sun, 01 Sep 2019 12:48:37 -0700 X-CMAE-Envelope: MS4wfCrMO035lM0dbVhdcElgsSQ9coc6bsGgGX45zxaPIrV21CXLnHDXA1RaxhNPq5QEvRCatJAvady2ql0i0cUPZ+WL+kFhoxmFl3BJ11di9I8PXC2vS379 9OAxUlERUBB1jTedeQQDrTyKXilU2KMLAtRoxMZe4n7PfG/3a8ZoyOmD6AGvLHedXM1wLKjUWvHZQiiFaXXA4VCs467pFJWgVxT4fpt/Eh5+X+fODCUSboka xOuCAHkVB/vUdXeQyVJSGmb32lKKH9L7bak7X6ZgKWwvurQwwa7KLmO5UYxMpuSbKvQn0ImfG+isKPg6JqVXYg== X-Rspamd-Queue-Id: 46M3gG25tNz3FkW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.138) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; RCVD_IN_DNSWL_NONE(0.00)[138.136.59.64.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.37)[ip: (-6.21), ipnet: 64.59.128.0/20(-3.12), asn: 6327(-2.42), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Sep 2019 19:48:44 -0000 In message <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com>, Enji Cooper writes : > > > > On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky wrote: > > > > Hi, > > > > If the fallouts could be better organized through some simple guidelines, t > hat would be more accepted I think: > > > > 1) Don't commit stuff before going off work. Even though a change looks inn > ocent, it might break something and you'll need to fix it. > > > > 2) Organize big changes going into the kernel, to ease debugging and gettin > g things back on track again. > > > > 3) If your patch is risky, commit it on a Monday. Don't wait until Friday. > > > > Failure to follow the rules may have consequences like other senior develop > ers kicking in and doing temporary reverts until issues are resolved. > > Agreed. There’s a reason why at my most former job (FB) we generally knew b > etter than to commit code on a Friday. It would cause the weekend oncalls a l > ot of grief. > > Let’s put it this way: think of it like being oncall for code. If you don†> ™t have someone else to work with who can manage it, would you like to be pag > ed if something went south with your code committed on a Friday? This is a good idea. Pinging someone to provide backup support is a good idea. phk@ has asked me in this regard once giving me authority to back out his commit should it cause any grief. It didn't break anything but he made contingency plans just in case. > > Cheers, > -Enji -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-freebsd-hackers@freebsd.org Mon Sep 2 15:12:20 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 80BE5E0A4E; Mon, 2 Sep 2019 15:12:20 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46MYTv1nHyz3Nr9; Mon, 2 Sep 2019 15:12:18 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x82FC9cD009674; Mon, 2 Sep 2019 08:12:09 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x82FC8ZD009673; Mon, 2 Sep 2019 08:12:08 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201909021512.x82FC8ZD009673@gndrsh.dnsmgr.net> Subject: Re: FCP 20190401-ci_policy: CI policy In-Reply-To: <201909011948.x81JmbS3004574@slippy.cwsent.com> To: Cy Schubert Date: Mon, 2 Sep 2019 08:12:08 -0700 (PDT) CC: Enji Cooper , Hans Petter Selasky , Ed Maste , FreeBSD Hackers , fcp@freebsd.org, Li-Wen Hsu X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 46MYTv1nHyz3Nr9 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.62 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.38)[0.377,0]; IP_SCORE(0.04)[ip: (0.15), ipnet: 69.59.192.0/19(0.07), asn: 13868(0.05), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.36)[0.364,0]; NEURAL_HAM_LONG(-0.07)[-0.067,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; FREEMAIL_CC(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Sep 2019 15:12:20 -0000 > In message <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com>, Enji Cooper > writes > : > > > > > > > On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky wrote: > > > > > > Hi, > > > > > > If the fallouts could be better organized through some simple guidelines, t > > hat would be more accepted I think: > > > > > > 1) Don't commit stuff before going off work. Even though a change looks inn > > ocent, it might break something and you'll need to fix it. > > > > > > 2) Organize big changes going into the kernel, to ease debugging and gettin > > g things back on track again. > > > > > > 3) If your patch is risky, commit it on a Monday. Don't wait until Friday. > > > > > > Failure to follow the rules may have consequences like other senior develop > > ers kicking in and doing temporary reverts until issues are resolved. > > > > Agreed. There???s a reason why at my most former job (FB) we generally knew b > > etter than to commit code on a Friday. It would cause the weekend oncalls a l > > ot of grief. > > > > Let???s put it this way: think of it like being oncall for code. If you don?? > > ?t have someone else to work with who can manage it, would you like to be pag > > ed if something went south with your code committed on a Friday? > > This is a good idea. Pinging someone to provide backup support is a good > idea. phk@ has asked me in this regard once giving me authority to back out > his commit should it cause any grief. It didn't break anything but he made > contingency plans just in case. All of these can be codified into "operational suggestions" and added to the committers guide, and does not necessarily need to be rules, policy or procedure, that should help move it forward past the high bar of trying to get changes like this codified some place that everyone can read. -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-hackers@freebsd.org Tue Sep 3 03:47:29 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 64AC0C8347 for ; Tue, 3 Sep 2019 03:47:29 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46MtFD36Jnz3Fsj for ; Tue, 3 Sep 2019 03:47:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72e.google.com with SMTP id q203so5160755qke.1 for ; Mon, 02 Sep 2019 20:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=sQdC/4msvGi9DKbli6i4kTmayJbHcrXLXZvFuVk1/Vs=; b=K5bHBcopur5JckZ2yB1wiZFxqaselJhFG7THcfOKD37uvx53c2gcv6xovIP2lb9CAA Va9B4YvIb2qiPeq0pqFOaQi1xl7r7nZS/8Zrd76g0SWTl86qB3LH8f/CpM3LSzLARcRe fDoDWlW5N33x/1BPKe/9vGTnzKShVMKRgHtSQg8yRIsSeuaZqZGYXacj/bH3BLHu3kFT 1QPAPso2R6gSU2T6Tiy8U1RRvhbep8qNZA6sLf1yC4iwcgN9lHfSBpaYIQkNQS0BKIZA NyzyJqZ3NSFU/fFQphCSwGSs5mpH9IyznhROKz+Ela/jWEmbPBJTiPOIvvJ2JCzdeTTb rJnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sQdC/4msvGi9DKbli6i4kTmayJbHcrXLXZvFuVk1/Vs=; b=Wgg8hoWNncTkalq61yOwlPUXjCwLKjBZwaurcGssoIPG+ZmwSUJordWTLTcsCWR+EL 3ODPkvdzu28YvsgfqRO8v9/otl/iii7lm/nEyZJA2WOp1Nf/ZYksxB/u9HdttEM3anKM qeIqB3TnEGeV/0G2emzZyzdSKmNtzV52EtW7GLLf157gWNMNfHF3Pyql+bWDTYqCysYT NoCVOe2lSaxx+qG1EjX//zQ7TNIYGw9heGcqWvAgeSwHMgQDfI1C/CvWxPNJitwB2mip XK0gFLiFBp2SNmwxTxzc9s5MbufNKy0uYm4xHQIqZcdbbaAO8juhuzgu5xGkgufru2Kf bl7A== X-Gm-Message-State: APjAAAX+mKuYgVZWu0s3pesi3Idhur1xKiIzj+qqM9MVE94QeDK4jqF9 ocav0qPTLaw7VlgDBKfAU5bVwsuZHUl79rJwrvY3nbX1vGcysA== X-Google-Smtp-Source: APXvYqyQHXN4nMb/jZkuzhZxqIWWuFbnuhwkwEpoI3pMwJcMklcNEmC9bipkrEkVkH31LUegQgnnxKj3baSEfPgqxA4= X-Received: by 2002:a37:8902:: with SMTP id l2mr30935950qkd.380.1567482446728; Mon, 02 Sep 2019 20:47:26 -0700 (PDT) MIME-Version: 1.0 From: Warner Losh Date: Mon, 2 Sep 2019 21:47:16 -0600 Message-ID: Subject: Looking for review / testing for nvme suspend / resume support To: FreeBSD Hackers X-Rspamd-Queue-Id: 46MtFD36Jnz3Fsj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=K5bHBcop; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::72e) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.90 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCVD_IN_DNSWL_NONE(0.00)[e.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.90)[ip: (-9.33), ipnet: 2607:f8b0::/32(-2.82), asn: 15169(-2.30), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 03:47:29 -0000 I've posted a review: https://reviews.freebsd.org/D21493 for NVMe suspend / resume support. This avoids issues where we come out of suspend and need to wait 30s for there to be a timeout and a reset of the device. It does so by completely shutting down the card before we suspend, and then assume it was in an unknown state when we come back up. Please leave comments about successful (or unsuccessful) tests and/or ways to improve the code. Thanks! Warner From owner-freebsd-hackers@freebsd.org Tue Sep 3 06:12:28 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 078D3CD062 for ; Tue, 3 Sep 2019 06:12:28 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46MxSV6257z3Nhx for ; Tue, 3 Sep 2019 06:12:26 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id A679C1581 for ; Tue, 3 Sep 2019 02:12:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 03 Sep 2019 02:12:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm1; bh=f tpZZvLLGw4PSS8eFr8JT73dWuejESoTvVnC9o+d2ow=; b=XtB1R/13JvvHNfM5b i26NLyOoBQ3qNCYvsPqC7/ODmYQrZqXKsL41GMdbMsFjzjldQ4avFqapui2b3WVp l2BJrncbVBMZx8XT81t+ruW2VAs6PsquEIm4bNECXMyG6EngSomUWyIJYU8QSHHT kzLCVT0d7ifV4CuYKYZ/VqusjwHpE/mdWozXy1LceX4rxfFVa1Grl6rDD+Iuq2Y2 EI4HCgvAjz0jhUPN4kl8R7tyth3XdIN8Q7sCjmkbWIYWXZt4hu6mmnVki/93qlpw Bqa6qcyt1ygRsUDonK6Dwwhr1JAaC6dY8dxhIXnSs4gH3TTmjKChwsntC6JHkeQj QbpGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=ftpZZvLLGw4PSS8eFr8JT73dWuejESoTvVnC9o+d2 ow=; b=BDjqc/ZqHUWY47r+/i//fs2XAvJBt5+ix+tfHEuYedhRwJUN5k+/SmBvR Ds6qfR8Ss22O2I5ePokLtth9kIVEY8KDdqvWPt8cRoydD1oC9QYrkjBbbJGmAt+v Q9P3TGOG2Y2V7N8vRDzjoKHLidz8zr8n0Dt9tn1m05nz9fzEC4u270+XU9/a2z1N dAP8+scBWU+9XcXYZOluXnTI3ZLHO6/fBHlgzpwdrj+6AXIyCdKBrkPJTrR8Cc0q kezq3ZPOgVJnIsjC9XU+LNfCKQWRVMNofP/z7ihlwWW8zNAATrvCc6ka7cIou25m sxBklJndcnEcnDG9jPcREBjNnCVsg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejuddguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefuvfhfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpegjuhhr ihcurfgrnhhkohhvuceohihurhhiphhvseihuhhrihhpvhdrnhgvtheqnecuffhomhgrih hnpehfrhgvvggsshgurdhorhhgnecukfhppeduleehrddvtdeirddukeefrdduieejnecu rfgrrhgrmhepmhgrihhlfhhrohhmpeihuhhrihhpvheshihurhhiphhvrdhnvghtnecuve hluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from [192.168.1.2] (unknown [195.206.183.167]) by mail.messagingengine.com (Postfix) with ESMTPA id CB25A80062 for ; Tue, 3 Sep 2019 02:12:24 -0400 (EDT) Subject: Re: Looking for review / testing for nvme suspend / resume support To: FreeBSD Hackers References: From: Yuri Pankov Message-ID: <41727448-9b0d-69dd-00f3-de30d9d5902b@yuripv.net> Date: Tue, 3 Sep 2019 09:12:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46MxSV6257z3Nhx X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.net header.s=fm1 header.b=XtB1R/13; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=BDjqc/Zq; dmarc=none; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.net designates 66.111.4.230 as permitted sender) smtp.mailfrom=yuripv@yuripv.net X-Spamd-Result: default: False [-7.08 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[yuripv.net:s=fm1,messagingengine.com:s=fm3]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.230]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[yuripv.net]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-0.99)[-0.991,0]; IP_SCORE(-3.49)[ip: (-9.87), ipnet: 66.111.4.0/24(-4.84), asn: 11403(-2.68), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[230.4.111.66.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 06:12:28 -0000 Warner Losh wrote: > I've posted a review: https://reviews.freebsd.org/D21493 for NVMe suspend / > resume support. This avoids issues where we come out of suspend and need to > wait 30s for there to be a timeout and a reset of the device. It does so by > completely shutting down the card before we suspend, and then assume it was > in an unknown state when we come back up. > > Please leave comments about successful (or unsuccessful) tests and/or ways > to improve the code. Not seeing any issues with "SAMSUNG MZVLB512HAJQ", both suspend/resume were almost instant, no messages from nvme/nvd logged, no errors from zpool status/scrub. From owner-freebsd-hackers@freebsd.org Tue Sep 3 18:03:47 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69C55E70A7; Tue, 3 Sep 2019 18:03:47 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NFFG4TQqz40Fl; Tue, 3 Sep 2019 18:03:46 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: by mail-yb1-xb36.google.com with SMTP id a17so6189593ybc.0; Tue, 03 Sep 2019 11:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=xG5fyneYlZoVAFs7kHrUX8N9v7dzITYHrvmdocIMmMo=; b=s4TfUmDqSXzlV1EM81tJ0JMqVWb4VV/C5ipeWetJaj21v6RT4S3UbC6ekdYB/LlFmj YEyj0snInLhTnk5f+gjugqJlCChCamlo1T8tsevDZrlsIXx8bqnU246ic6vosZg1bEY8 JB2b/zm2SCuL+ZiOyuYGY+xNukwRv3arysjzHfhesBQTcZWfxlCmolJwQrelEs/FYgX9 N/lzO8dQz1x5bNa8v31A8t8dEeKZZchyye6Ntk5GI1ulsp7oNSRWYpZqdvccscQS5/dW biJ2uRZq9iOeQKfEi+eJKD8ouh/CHWTShVW3U61cEZuuwX7pM6Jz61+feXwUZ0c8Tldq dCAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=xG5fyneYlZoVAFs7kHrUX8N9v7dzITYHrvmdocIMmMo=; b=GuEY3U6h4X58ibnohiaiNkVpCEuVMyD8JN2r+++K3uBjHxqfysvrQscnhh6MFy4T4u 0GSSAunYZ5TUrEBwc3KgolYOY4Pz1UvtI7R6VMZI2NE788034sH0z6nHesPQmWYBv8J5 8uGvUkhGQpz3M/sdisi3y8FuE8JqjNiR+c+GXHwQ6LIPQU319dAqcJ5aFREi4Q5xbkFr EO5bt941Ar8uY/Knki3y2woxZm7+GrgEx9muLwlSECQ0SkGVNwZobyzy1L0vr/bH+V7f u9qWFn8zFliBkzqwCtTYrNZ+SoCl12JHLBGfA5cqCamOXr3fPum1L36R8szHejLkzt1T zmGA== X-Gm-Message-State: APjAAAV/d0R635qJD2HljYNnI7wTnwS0x8GBro2Ktm7awwYJjMQpVfLr /l+xcQZNeMBiwohAxavTjfNHirboXojytf39L0UkT14= X-Google-Smtp-Source: APXvYqzI/dprtxi9F6cpFaUUNq9zf9ee/YZUCP35dfTwvSFqucaqcfoL8+f2lSY+evkoRMxpR9DPowp9DSlCSvdsgeQ= X-Received: by 2002:a25:244:: with SMTP id 65mr25689678ybc.469.1567533825223; Tue, 03 Sep 2019 11:03:45 -0700 (PDT) MIME-Version: 1.0 From: shreyank amartya Date: Tue, 3 Sep 2019 23:33:33 +0530 Message-ID: Subject: hwpmc: NMI cpuxx ... going to debugger To: freebsd-drivers@freebsd.org, freebsd-hackers@freebsd.org, avg@freebsd.org, mmacy@freebsd.org X-Rspamd-Queue-Id: 46NFFG4TQqz40Fl X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=s4TfUmDq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of shreyankfbsd@gmail.com designates 2607:f8b0:4864:20::b36 as permitted sender) smtp.mailfrom=shreyankfbsd@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_DN_NONE(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; IP_SCORE(0.00)[ip: (-9.48), ipnet: 2607:f8b0::/32(-2.77), asn: 15169(-2.28), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[6.3.b.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 18:03:47 -0000 Hi, I'm running a profiler which utilizes hwpmc and am frequently running into this situation: after a process context switch out I get an NMI. The NMI handler is unable to service it due to the fact that the pmc hardware is marked as free at the end of the process_csw_out() (hwpmc_mod.c) routine. Here are some logs I've collected when this happens: 1750 231 49360676470980 MDP:CFG:1: cpu=231 ri=0 pm=0xfffff801e7b2ea00 1749 231 49360676470360 CSW:SWI:1: cpu=231 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1748 249 49360676421260 CSW:SWO:3: cpu=249 ri=33 1748 249 49360676421260 CSW:SWO:3: cpu=249 ri=33 1747 249 49360676420320 MDP:SWO:1: pc=0xfffff8010a06c400 pp=0xfffff81077179000 enable-msr=0 1746 249 49360676419000 CSW:SWO:1: cpu=249 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1745 231 49360675789440 MDP:INT:2: retval=0 isnull=16 ovrflw=0 1744 231 49360675789240 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 1743 231 49360675788260 CSW:SWO:3: cpu=231 ri=33 1742 231 49360675788080 MDP:SWO:1: pc=0xfffff80106fe1400 pp=0xfffff81077179000 enable-msr=0 1741 231 49360675787880 MDP:CFG:1: cpu=231 ri=0 pm=0x0 1740 231 49360675787020 CSW:SWO:2: cpu=231 ri=17 val=-164 (samp) 1739 231 49360675786940 MDP:REA:2: amd-read (post-munge) id=0 -> -164 1738 231 49360675786880 MDP:REA:2: amd-read (pre-munge) id=0 -> 164 1737 231 49360675786720 MDP:REA:1: amd-read id=0 class=2 1736 231 49360675785180 MDP:STO:1: amd-stop ri=0 1735 231 49360675784160 CSW:SWO:1: cpu=231 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1734 231 49360675617080 MDP:INT:2: retval=1 isnull=0 ovrflw=0 1733 231 49360675615240 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 1732 231 49360675505160 MDP:SWI:1: pc=0xfffff80106fe1400 pp=0xfffff81077179000 enable-msr=0 1731 231 49360675503600 MDP:STA:2: amd-start config=0x530076 1730 231 49360675503060 MDP:STA:1: amd-start cpu=231 ri=0 1729 231 49360675500720 MDP:WRI:1: amd-write cpu=231 ri=0 v=fffffffffffd97d4 1728 231 49360675500240 CSW:SWI:1: cpu=231 ri=17 new=157740 1727 231 49360675498680 MDP:CFG:1: cpu=231 ri=0 pm=0xfffff801e7b2ea00 1726 231 49360675498060 CSW:SWI:1: cpu=231 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1725 154 49360675363180 CSW:SWO:3: cpu=154 ri=33 1724 154 49360675362020 MDP:SWO:1: pc=0xfffff80106d59600 pp=0xfffff81077179000 enable-msr=0 1723 154 49360675360220 CSW:SWO:1: cpu=154 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1722 231 49360675009200 CSW:SWO:3: cpu=231 ri=33 1721 231 49360675009020 MDP:SWO:1: pc=0xfffff80106fe1400 pp=0xfffff81077179000 enable-msr=0 1720 231 49360675008320 MDP:CFG:1: cpu=231 ri=0 pm=0x0 1719 231 49360675006220 CSW:SWO:2: cpu=231 ri=17 val=157740 (samp) 1718 231 49360675005700 MDP:REA:2: amd-read (post-munge) id=0 -> 157740 1717 231 49360675005240 MDP:REA:2: amd-read (pre-munge) id=0 -> 281474976552916 1716 231 49360675004140 MDP:REA:1: amd-read id=0 class=2 1715 231 49360675002660 MDP:STO:1: amd-stop ri=0 1714 231 49360675001460 CSW:SWO:1: cpu=231 proc=0xfffff813e80ff000 (5930, java) pp=0xfffff81077179000 1713 231 49360674941580 MDP:INT:2: retval=1 isnull=0 ovrflw=0 1712 231 49360674939500 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 1711 231 49360674793500 MDP:SWI:1: pc=0xfffff80106fe1400 pp=0xfffff81077179000 enable-msr=0 1710 231 49360674792680 MDP:STA:2: amd-start config=0x530076 1709 220 49360674792340 CSW:SWO:3: cpu=220 ri=33 1708 220 49360674791060 MDP:SWO:1: pc=0xfffff80106f8a600 pp=0xfffff81077179000 enable-msr=0 1707 231 49360674790840 MDP:STA:1: amd-start cpu=231 ri=0 The stray NMI is entry 1744 & 1745 (isnull=16). In entry 1741 when the context switch out occurs, the hardware is marked free (pm=0x0). The NMI handler is unable to find the hardware and ends up returning 0. Entry 1740 reports the val=-164, I'm not sure about the significance but the value always seems to be negative when this problem occurs. Once i get a stray NMI, I do not get any further interrupts which is results in loss of samples in the generated pmclog. I'm using hwpmc from the most recent stable/12 branch which is same as current (with a stable/12 kernel). I'm running it on a java application with a single event in sampling mode. Any idea on how to resolve/avoid this problem? Any pointers or suggestion are appreciated. Thanks Shreyank From owner-freebsd-hackers@freebsd.org Tue Sep 3 21:16:35 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E4CB0D8712; Tue, 3 Sep 2019 21:16:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NKWk4DsWz4Nw4; Tue, 3 Sep 2019 21:16:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x636.google.com with SMTP id y10so2587984pll.7; Tue, 03 Sep 2019 14:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w8Vx4d3esKc2z/JGyebJiyqldEjepkegxAZK6YCBasY=; b=fLml44ijyN6x6a1UVrybJ1hk5VFpUD8T9iVw1TD/DMaDh1EreulyiLzYrNXT4+eUvd yJxh1lXgJHKsQpma+wj85RWI/3BOPFgR7DPff3YUHrSNzq/82++nPosLz3IUIlut0OaD y7EbRgytKgKMqKrhGh1uu9G6ORXawuHy8OluDZF0b0GnGVjrPHUReCl9D7VsVsAmaMj+ /g2d6OPdmIstHYSrbh6DLmz1x4f9hV6UOZFEZyMYdO1jn7gWGxUh8qpS5GfT/yZcVu90 gLwiksnFPqElhehRncywa0xuQALuf+Mgj7hOLmgXFCvdIXNaqSsyaXMqLM++Ej2DkS5t SfkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=w8Vx4d3esKc2z/JGyebJiyqldEjepkegxAZK6YCBasY=; b=s5bagUuzMqAZo3oNveQIU5eUVSQrwvN3fjVjCUUxB0ZGVbCvy0u4zkVNgBRKwGxFCN bPgspnQJfkZkCInNyvNRtHUy+UTkmVbR7wmhCtBrsU+hmt6mNV+bChcHcMp4SuacqpIF w6bwwoh4CDFkjtFvsJTpErHjwljv8DbRfOuqQJMmaeqT9Q7VnBh4rC5mxpve0xP65gdT KYAdDr7QeMRBUINd4XwyBzbaIG4MxowandAFl7wYiEU86NrxuFNBQzidT4RtfJnPbSAB Ctjda7hahwIft6YiQuMV04rHA2sPD8fj0JQy7eNDxNW5HIhWfAn8ZrAkoTmZXW03Y6ol Ixxg== X-Gm-Message-State: APjAAAU9AA8OdBdW+nC+BYaEWRashOfz0i3gl7yV/sRAfpdfuXC3810D 1FgWcwr7rlEPJt8GkaT487v3UN9MXz4= X-Google-Smtp-Source: APXvYqyN6s5LsHpf6BjkraLhqPrWzWg2OMn86gzi8pMi02qKuKDXC1jnMmpw7bksQoZwP58/ce3NIw== X-Received: by 2002:a17:902:a506:: with SMTP id s6mr9802606plq.232.1567545392268; Tue, 03 Sep 2019 14:16:32 -0700 (PDT) Received: from ?IPv6:2607:fb90:b285:cd60:7950:2070:2ff0:7781? ([2607:fb90:b285:cd60:7950:2070:2ff0:7781]) by smtp.gmail.com with ESMTPSA id d18sm12189880pfr.133.2019.09.03.14.16.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Sep 2019 14:16:31 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: FCP 20190401-ci_policy: CI policy From: Enji Cooper X-Mailer: iPhone Mail (16G77) In-Reply-To: <201909021512.x82FC8ZD009673@gndrsh.dnsmgr.net> Date: Tue, 3 Sep 2019 14:16:30 -0700 Cc: Cy Schubert , Hans Petter Selasky , Ed Maste , FreeBSD Hackers , fcp@freebsd.org, Li-Wen Hsu Content-Transfer-Encoding: quoted-printable Message-Id: <911BCF8B-CF37-48A5-B3FE-B5959575A996@gmail.com> References: <201909021512.x82FC8ZD009673@gndrsh.dnsmgr.net> To: "Rodney W. Grimes" X-Rspamd-Queue-Id: 46NKWk4DsWz4Nw4 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=fLml44ij; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::636 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.49 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.99)[-0.987,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.21), ipnet: 2607:f8b0::/32(-2.77), asn: 15169(-2.28), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[6.3.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 21:16:36 -0000 On Sep 2, 2019, at 08:12, Rodney W. Grimes w= rote: >> In message <8350379A-30F8-4BBD-B9AE-A3A176CAE966@gmail.com>, Enji Cooper=20= >> writes >> : >>>=20 >>>=20 >>>> On Sep 1, 2019, at 10:42 AM, Hans Petter Selasky wrot= e: >>>>=20 >>>> Hi, >>>>=20 >>>> If the fallouts could be better organized through some simple guideline= s, t >>> hat would be more accepted I think: >>>>=20 >>>> 1) Don't commit stuff before going off work. Even though a change looks= inn >>> ocent, it might break something and you'll need to fix it. >>>>=20 >>>> 2) Organize big changes going into the kernel, to ease debugging and ge= ttin >>> g things back on track again. >>>>=20 >>>> 3) If your patch is risky, commit it on a Monday. Don't wait until Frid= ay. >>>>=20 >>>> Failure to follow the rules may have consequences like other senior dev= elop >>> ers kicking in and doing temporary reverts until issues are resolved. >>>=20 >>> Agreed. There???s a reason why at my most former job (FB) we generally k= new b >>> etter than to commit code on a Friday. It would cause the weekend oncall= s a l >>> ot of grief. >>>=20 >>> Let???s put it this way: think of it like being oncall for code. If you d= on?? >>> ?t have someone else to work with who can manage it, would you like to b= e pag >>> ed if something went south with your code committed on a Friday? >>=20 >> This is a good idea. Pinging someone to provide backup support is a good=20= >> idea. phk@ has asked me in this regard once giving me authority to back o= ut=20 >> his commit should it cause any grief. It didn't break anything but he mad= e=20 >> contingency plans just in case. >=20 > All of these can be codified into "operational suggestions" and added to t= he > committers guide, and does not necessarily need to be rules, policy or=20 > procedure, that should help move it forward past the high bar of trying to= > get changes like this codified some place that everyone can read. I agree with you in spirit. It just makes it easier if it=E2=80=99s implemen= ted in a structured process, so I don=E2=80=99t have to look up the committe= r=E2=80=99s guide to figure out what the rules are, then apply them. -Enji= From owner-freebsd-hackers@freebsd.org Wed Sep 4 12:00:07 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 80759EF5A9 for ; Wed, 4 Sep 2019 12:00:07 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46Nj7B3C5Tz4C4X for ; Wed, 4 Sep 2019 12:00:06 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (v-critter.freebsd.dk [192.168.55.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by phk.freebsd.dk (Postfix) with ESMTPS id 05AA61AF112; Wed, 4 Sep 2019 12:00:05 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id x84C04hY003883 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 4 Sep 2019 12:00:04 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id x84C040S003882; Wed, 4 Sep 2019 12:00:04 GMT (envelope-from phk) To: Warner Losh cc: FreeBSD Hackers Subject: Re: Looking for review / testing for nvme suspend / resume support In-reply-to: From: "Poul-Henning Kamp" References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3880.1567598403.1@critter.freebsd.dk> Content-Transfer-Encoding: quoted-printable Date: Wed, 04 Sep 2019 12:00:04 +0000 Message-ID: <3881.1567598404@critter.freebsd.dk> X-Rspamd-Queue-Id: 46Nj7B3C5Tz4C4X X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of phk@critter.freebsd.dk designates 130.225.244.222 as permitted sender) smtp.mailfrom=phk@critter.freebsd.dk X-Spamd-Result: default: False [-2.14 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.934,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx:c]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.dk]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.27)[-0.269,0]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(0.06)[ip: (0.08), ipnet: 130.225.0.0/16(0.11), asn: 1835(0.12), country: EU(-0.00)]; FORGED_SENDER(0.30)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:1835, ipnet:130.225.0.0/16, country:EU]; FROM_NEQ_ENVFROM(0.00)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 12:00:07 -0000 -------- In message , Warner Losh writes: >I've posted a review: https://reviews.freebsd.org/D21493 for NVMe suspend= / Tried the commited version (r351809M) and it seems to work. Thanks A LOT Warner! -- = Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe = Never attribute to malice what can adequately be explained by incompetence= . From owner-freebsd-hackers@freebsd.org Wed Sep 4 12:17:04 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A86FF0381; Wed, 4 Sep 2019 12:17:04 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: from mail-yw1-xc35.google.com (mail-yw1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NjVl3jKvz4DNm; Wed, 4 Sep 2019 12:17:03 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: by mail-yw1-xc35.google.com with SMTP id u141so7196843ywe.4; Wed, 04 Sep 2019 05:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQSudw3YiR1S8i3vweVzzCI95tPzIv4sgN4B3GJX9ZA=; b=SFYV/SPyrW6azhaUKjh0o5Xhu6qEanktr+hlTbecICB7mV/WozMPQgVtAsDj7PpVtd jCcpgCNZC30rgJ5TJusQ57s1q59Q6dSMLDao+Kp8gH0gVUYim+KUucQvdA17B1viKERW 0GJICTkXUguFgYy2iBkggddXXBXRTWBqTVJI35YIRKBAtnhaibRO7nc/jeNAjlLV7e1s TlUbP3MNMIAXr+YYoFN4Hf++Uyc2xcQeYeczzGfVCc8Ph7evFfHbPwzyOIl43P/BpDYL 6a7FOvo3IYfFz0SgKgeX2uxGnPzQIO92y1x2OIvG4R6KgYDjSV4avUeMAGSs3Ow8k/6R R2YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQSudw3YiR1S8i3vweVzzCI95tPzIv4sgN4B3GJX9ZA=; b=Qyc+bXaadmmiwVyb3BpSxknHW+koKOz05CzOvLK2TBSUTM6OwiWo+IgGaFpTMbTAye prMzGtWPpV8tZa4cuu1Bd+ZCb1+v+3texkN5SheQduGUv/W1lmqa1gngbL8bB8FxG/qo SYGu6XjSZYYVwne4PhJn+v+XyKoKY0cveix2mfbydQOVqjy98rg8WkqRsBqA8MGG35kc Cin37vX0kW6KGcnrT0fVLuKt5xu8Z/iSwk5X7JWwMGIzHVKM5ubzx5Ez76gjeSBk3Rst Ev0c6I0E+Yl2hk/VaEOgHEEIhhcY3MAQHB3go07IjslN0Y2QYvgt5O9UF5hXbNUWs/n9 XWvA== X-Gm-Message-State: APjAAAURyFkVwHk1F6upBTCeR6+KVYqmKp/TYc2CNR5cWsTeQ7Giv/Vu Q7L/1OQFbEXmz+RVZLZbbLEfYlPVWayk6xQQf4qy X-Google-Smtp-Source: APXvYqzpVxM6y/iukAsCNI/M1BqFdpmUmL7azlbU+76RSWZ1P9Wd0m2Xa42kHn0U3VuH2YkPBvfAE2bhrcuIleASHhs= X-Received: by 2002:a81:af21:: with SMTP id n33mr9670799ywh.131.1567599421305; Wed, 04 Sep 2019 05:17:01 -0700 (PDT) MIME-Version: 1.0 References: <9d9e8a91-6030-99d9-a57c-a75bd4f4302f@FreeBSD.org> In-Reply-To: <9d9e8a91-6030-99d9-a57c-a75bd4f4302f@FreeBSD.org> From: shreyank amartya Date: Wed, 4 Sep 2019 17:46:49 +0530 Message-ID: Subject: Re: hwpmc: NMI cpuxx ... going to debugger To: Andriy Gapon Cc: mmacy@freebsd.org, freebsd-drivers@freebsd.org, freebsd-hackers@freebsd.org X-Rspamd-Queue-Id: 46NjVl3jKvz4DNm X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=SFYV/SPy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of shreyankfbsd@gmail.com designates 2607:f8b0:4864:20::c35 as permitted sender) smtp.mailfrom=shreyankfbsd@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (-8.60), ipnet: 2607:f8b0::/32(-2.77), asn: 15169(-2.28), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[5.3.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 12:17:04 -0000 Hi, I have narrowed down the problem to this: - Inside process_csw_out() (during thread context switch out) routine in hwpmc_mod.c, we stop the pmc and record the current value for reloading it at a future time. here, I observe that the pmc has already overflowed while recording the value. The NMI handler is invoked near the end of the routine and it fails to service the interrupt. Now, is this expected behavior? Should I modify the code to deal with this situation? Or should this situation not occur at all, in which case this could be a hardware problem. If you could shed some light on this, I will be able to pursue this further. Thanks for your time Shreyank On Wed, Sep 4, 2019 at 12:09 PM Andriy Gapon wrote: > On 03/09/2019 21:03, shreyank amartya wrote: > > Hi, > > > > I'm running a profiler which utilizes hwpmc and am frequently running > into this > > situation: after a process context switch out I get an NMI. The NMI > handler is > > unable to service it due to the fact that the pmc hardware is marked as > free at > > the end of the process_csw_out() (hwpmc_mod.c) routine. > > > > Here are some logs I've collected when this happens: > > > > 1750 231 49360676470980 MDP:CFG:1: cpu=231 ri=0 pm=0xfffff801e7b2ea00 > > 1749 231 49360676470360 CSW:SWI:1: cpu=231 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1748 249 49360676421260 CSW:SWO:3: cpu=249 ri=33 > > 1748 249 49360676421260 CSW:SWO:3: cpu=249 ri=33 > > 1747 249 49360676420320 MDP:SWO:1: pc=0xfffff8010a06c400 > > pp=0xfffff81077179000 enable-msr=0 > > 1746 249 49360676419000 CSW:SWO:1: cpu=249 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1745 231 49360675789440 MDP:INT:2: retval=0 isnull=16 ovrflw=0 > > 1744 231 49360675789240 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 > > 1743 231 49360675788260 CSW:SWO:3: cpu=231 ri=33 > > 1742 231 49360675788080 MDP:SWO:1: pc=0xfffff80106fe1400 > > pp=0xfffff81077179000 enable-msr=0 > > 1741 231 49360675787880 MDP:CFG:1: cpu=231 ri=0 pm=0x0 > > 1740 231 49360675787020 CSW:SWO:2: cpu=231 ri=17 val=-164 (samp) > > 1739 231 49360675786940 MDP:REA:2: amd-read (post-munge) id=0 -> -164 > > 1738 231 49360675786880 MDP:REA:2: amd-read (pre-munge) id=0 -> 164 > > 1737 231 49360675786720 MDP:REA:1: amd-read id=0 class=2 > > 1736 231 49360675785180 MDP:STO:1: amd-stop ri=0 > > 1735 231 49360675784160 CSW:SWO:1: cpu=231 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1734 231 49360675617080 MDP:INT:2: retval=1 isnull=0 ovrflw=0 > > 1733 231 49360675615240 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 > > 1732 231 49360675505160 MDP:SWI:1: pc=0xfffff80106fe1400 > > pp=0xfffff81077179000 enable-msr=0 > > 1731 231 49360675503600 MDP:STA:2: amd-start config=0x530076 > > 1730 231 49360675503060 MDP:STA:1: amd-start cpu=231 ri=0 > > 1729 231 49360675500720 MDP:WRI:1: amd-write cpu=231 ri=0 > v=fffffffffffd97d4 > > 1728 231 49360675500240 CSW:SWI:1: cpu=231 ri=17 new=157740 > > 1727 231 49360675498680 MDP:CFG:1: cpu=231 ri=0 pm=0xfffff801e7b2ea00 > > 1726 231 49360675498060 CSW:SWI:1: cpu=231 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1725 154 49360675363180 CSW:SWO:3: cpu=154 ri=33 > > 1724 154 49360675362020 MDP:SWO:1: pc=0xfffff80106d59600 > > pp=0xfffff81077179000 enable-msr=0 > > 1723 154 49360675360220 CSW:SWO:1: cpu=154 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1722 231 49360675009200 CSW:SWO:3: cpu=231 ri=33 > > 1721 231 49360675009020 MDP:SWO:1: pc=0xfffff80106fe1400 > > pp=0xfffff81077179000 enable-msr=0 > > 1720 231 49360675008320 MDP:CFG:1: cpu=231 ri=0 pm=0x0 > > 1719 231 49360675006220 CSW:SWO:2: cpu=231 ri=17 val=157740 (samp) > > 1718 231 49360675005700 MDP:REA:2: amd-read (post-munge) id=0 -> > 157740 > > 1717 231 49360675005240 MDP:REA:2: amd-read (pre-munge) id=0 -> > 281474976552916 > > 1716 231 49360675004140 MDP:REA:1: amd-read id=0 class=2 > > 1715 231 49360675002660 MDP:STO:1: amd-stop ri=0 > > 1714 231 49360675001460 CSW:SWO:1: cpu=231 proc=0xfffff813e80ff000 > (5930, > > java) pp=0xfffff81077179000 > > 1713 231 49360674941580 MDP:INT:2: retval=1 isnull=0 ovrflw=0 > > 1712 231 49360674939500 MDP:INT:1: cpu=231 tf=0xfffffe0001577f30 um=0 > > 1711 231 49360674793500 MDP:SWI:1: pc=0xfffff80106fe1400 > > pp=0xfffff81077179000 enable-msr=0 > > 1710 231 49360674792680 MDP:STA:2: amd-start config=0x530076 > > 1709 220 49360674792340 CSW:SWO:3: cpu=220 ri=33 > > 1708 220 49360674791060 MDP:SWO:1: pc=0xfffff80106f8a600 > > pp=0xfffff81077179000 enable-msr=0 > > 1707 231 49360674790840 MDP:STA:1: amd-start cpu=231 ri=0 > > > > The stray NMI is entry 1744 & 1745 (isnull=16). In entry 1741 when the > context > > switch out occurs, the hardware is marked free (pm=0x0). The NMI handler > is > > unable to find the hardware and ends up returning 0. Entry 1740 reports > the > > val=-164, I'm not sure about the significance but the value always seems > to be > > negative when this problem occurs. > > > > Once i get a stray NMI, I do not get any further interrupts which is > results in > > loss of samples in the generated pmclog. > > > > I'm using hwpmc from the most recent stable/12 branch which is same as > current > > (with a stable/12 kernel). I'm running it on a java application with a > single > > event in sampling mode. > > > > Any idea on how to resolve/avoid this problem? > > Any pointers or suggestion are appreciated. > > Sorry, I do not have time to debug this. > It looks like there could be a discrepancy between the hardware state and > the > driver state, so the hardware thinks that it should generate the NMI, but > the > driver does not expect to get it. Or there could be a hardware problem, > errata > are not unheard of. > It seems that you already have some data on what's going on, so maybe you > will > be able to pursue this further and narrow down the possibilities. > > Sorry again for not being able to actually help. > > > -- > Andriy Gapon > From owner-freebsd-hackers@freebsd.org Wed Sep 4 13:18:40 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F046CF1A08 for ; Wed, 4 Sep 2019 13:18:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Nksq1DyDz4Hgd for ; Wed, 4 Sep 2019 13:18:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id u40so15688344qth.11 for ; Wed, 04 Sep 2019 06:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LcbdzMhrwD4lTFOWon+aeQIjrHzOpytFzk30FozGYy0=; b=ZpVotWcBfRQGcpmiAZliCm2ETKCj+KYOoDs5x3FekrwrpZW2vvgEFwywSMH566EnN1 /G5QtoL9eNNg99RtMY7wPeOsdUNL7XvymVpZqDvBOPEDJeAUfj9/qwfAP4tK3VTIzIZR bUsRKeU5tJjaFz5Mt50vmKE40XrdA/MThUlVcXO8iBe83+Ov51Cy8a5etnKuJ31dehsk T8c33YSjYGxX9RdjcY6gudcYaaL6FaSR94JYV/VcMxuLgNMKy9a435oqROzk3L9tE9nl V6btF/6YSsg7MOOfLgXxMVwL/WR8YYwh7ME56dgj1rJWVDbydYSMXmXebohXmcwIwsbc fpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LcbdzMhrwD4lTFOWon+aeQIjrHzOpytFzk30FozGYy0=; b=r5WRxKtbMZeXf50CxwXfNqVwER+SdzC1x0SQgVTuBZ+3WIJhIocYLveL2pEpFbF/z+ MMRLyLzMU7H/vzAPmUF5iA27Mz0HTVxr0Cb4PtUSHAc3rD2JeiJzh7xIjNXlo68+03jg qlbMq0hA8FRqxFmBK1ClwCvstsEc2FYvk38pyAtuO2vK9lVlTLBBTkvgmWRVw4/vz85P wVB219LCDafq0BQd/BY0E6yWl38vZXW/6wbQbpVODRbmc7TLpxw1neH8JTQPmxOpS59v MFBMjSb+Fl2TTXmp6jdfJRIPrjMu4bFUVRW+Wqbl1kNR9TQ+qcLm8gnvj2iqHaJhUFVn Qw+A== X-Gm-Message-State: APjAAAVAwwyCnWPI51yXXyaDfMCQ23qh6BUo1vulIQ0BZrPRFXpmV+Aa fh6UQREtxZFKvrn6uP3EXQEL/5DnmINa5UDYYZnZqhYS1H4= X-Google-Smtp-Source: APXvYqx/P7hN/HD/92o+HR3Dxco9LTolmJOPYcY7GSj9O3S26KfjY0vnbbmI9yefZpmQRjT1QJVLgqlxbIv4SHHMh6w= X-Received: by 2002:ad4:4152:: with SMTP id z18mr14833682qvp.236.1567603117795; Wed, 04 Sep 2019 06:18:37 -0700 (PDT) MIME-Version: 1.0 References: <3881.1567598404@critter.freebsd.dk> In-Reply-To: <3881.1567598404@critter.freebsd.dk> From: Warner Losh Date: Wed, 4 Sep 2019 07:18:25 -0600 Message-ID: Subject: Re: Looking for review / testing for nvme suspend / resume support To: Poul-Henning Kamp Cc: FreeBSD Hackers X-Rspamd-Queue-Id: 46Nksq1DyDz4Hgd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=ZpVotWcB; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::833) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.88 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[3.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.992,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.88)[ip: (-9.32), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.28), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 13:18:41 -0000 On Wed, Sep 4, 2019, 6:00 AM Poul-Henning Kamp wrote: > -------- > In message < > CANCZdfqPTLL0dL5Q+2FVLoZqBqP2v7qmCzMwjnmjvWTc7CD0GQ@mail.gmail.com>, > Warner Losh writes: > > >I've posted a review: https://reviews.freebsd.org/D21493 for NVMe > suspend / > > Tried the commited version (r351809M) and it seems to work. > > Thanks A LOT Warner! > Had several people try it with a similar report, so I pushed it in. Warner -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. > From owner-freebsd-hackers@freebsd.org Wed Sep 4 18:55:48 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C150ECA212 for ; Wed, 4 Sep 2019 18:55:48 +0000 (UTC) (envelope-from zbeeble@gmail.com) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NtLq6rsDz3GBW for ; Wed, 4 Sep 2019 18:55:47 +0000 (UTC) (envelope-from zbeeble@gmail.com) Received: by mail-io1-xd2d.google.com with SMTP id m11so14639996ioo.0 for ; Wed, 04 Sep 2019 11:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ZBL6t7XytcPNaK2hGN+LXnCW6Vb4Z+PM+2rMHyya/Gg=; b=nIqofBlNxlgkkC93Jgi6iIDeZJuWgWOE/Phm5IyksxSDJwAhS4DX+P0Ua9GggMNeEq bospWa2U8+bcQ7BXVhOc95STIWePvx69zDb/PfjnHSpif0UC/z7C8uMV/t7nquD/7upj zFe3rrvno22dQtZdh7OW/5FMBbyHGGXz818Vt8V25id6aRpupeRTmCakLTidwl1Rf4HY nojaFaZczijK/JkFRhtOEn7dHjtjbg0W5Ascbbjq7abLk5TElwvPB02/kD6NN7qKnU67 M71JIZPN2qgUl5DkRH5qJMaj66kwTeaUWw0eaEZiNpWXBnIbGHkii90VfSlNlnxWJTDP VNYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZBL6t7XytcPNaK2hGN+LXnCW6Vb4Z+PM+2rMHyya/Gg=; b=dqYDE+uzVjjZS3cSAgtazAPQY0VI8bd290rUnJj7EtWHl/Pf90Ir1zYC0Xg/DESKCy 4QCMeCFv6FY1bfW0rdN3TQUJIvjFPmDTqIN6g4UTzj29rnqmMit/LMtwVSGy6EuC9Dk6 vtkHIM7KabMpFNDyz3n07rXhLfU7tp0HES5IiaoMoOdaHtHIOPLOlQq4Euy8EWiK0eiW 4wqfP3GY5mpcw0acBZ3HXylODztvmhyTog7gtRBxbt4VgN5VqWI0TFyhd5wO+n834CdP hie3me1kIkOfG7PuLp0tTxDXEBAS9No+zJDYkEzYJK4Ur7MpbMwvqXc51zQXRvJ7lYlz q4fA== X-Gm-Message-State: APjAAAXd485eQlir5y6pNJzlP+mGfQdImHS3qaFvdeuxCPl2XQoFRapW PmYnv+8NecZU+hJQvpvVyUSEAsb7K036ggTNrdBL4sc= X-Google-Smtp-Source: APXvYqxw7XYF+8xmL/MEgAvNzeShVG8EM5WlTZrTpfJUJF+BUcvSo8Ovu/oCbqH26WlRzRGwS7nNZmUiFR3aQO1ndoA= X-Received: by 2002:a6b:c903:: with SMTP id z3mr38504574iof.204.1567623346598; Wed, 04 Sep 2019 11:55:46 -0700 (PDT) MIME-Version: 1.0 From: Zaphod Beeblebrox Date: Wed, 4 Sep 2019 14:55:34 -0400 Message-ID: Subject: A jail notion. To: FreeBSD Hackers X-Rspamd-Queue-Id: 46NtLq6rsDz3GBW X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=nIqofBlN; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of zbeeble@gmail.com designates 2607:f8b0:4864:20::d2d as permitted sender) smtp.mailfrom=zbeeble@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-5.92), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.28), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[d.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 18:55:48 -0000 So... in general, I put jails in /jail. I could, for instance, aggregate all unique userids and groupids into /etc/master.password and /etc/group by scanning /jail/*/etc/master.passwd, but then again, I could also run kerb. This could be further generalized by following the jail root configured in /etc/jail.conf. Now... I admit the fact that not all jails will have a password or group file, but looking at the fairly vast number of jails that I deploy, at least for me, they almost all have password and group files. What am I getting at? Running top on the host ... many of the jail users end up as numbers. It would be supremely helpful if top was jail-enabled in this manner. In fact, although I routinely consider kerberos ... I don't think it would solve this problem. What does the userid of a process look like under kerb? Anyways... food for thought. From owner-freebsd-hackers@freebsd.org Wed Sep 4 22:23:12 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E2BB2CF9AC for ; Wed, 4 Sep 2019 22:23:12 +0000 (UTC) (envelope-from dewayne.geraghty@heuristicsystems.com.au) Received: from hermes.heuristicsystems.com.au (hermes.heuristicsystems.com.au [203.41.22.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "hermes.heuristicsystems.com.au", Issuer "Heuristic Systems Type 4 Host CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Nyy56qPdz3xlL for ; Wed, 4 Sep 2019 22:23:09 +0000 (UTC) (envelope-from dewayne.geraghty@heuristicsystems.com.au) Received: from [10.0.5.3] (noddy.hs [10.0.5.3]) (authenticated bits=0) by hermes.heuristicsystems.com.au (8.15.2/8.15.2) with ESMTPSA id x84MMsvT067524 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Thu, 5 Sep 2019 08:22:55 +1000 (AEST) (envelope-from dewayne.geraghty@heuristicsystems.com.au) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=heuristicsystems.com.au; s=hsa; t=1567635775; x=1568240576; bh=WgyUr/Gy7yIu15M/jECS1G7jdDrJUvhWaGKw2ihhnJk=; h=Subject:To:From:Message-ID:Date; b=Ffewy36IEsvXMi5g7RIqNTFrBa6OvWN+oSyYoE9q3j/RUcYOwIVAFsY84m/d3azwE WquzKbfkUnU0HZiL7fD7Sps1PXOo83A02hRR7yHOn64btfuU27Zek+v0wEpARACwS4 Z01fG7HvYNee48oSGIwH9/6Vz1/8ZN/qLCxwkfmiGbfQZC0JsDFdi X-Authentication-Warning: b3.hs: Host noddy.hs [10.0.5.3] claimed to be [10.0.5.3] Subject: Re: A jail notion. To: Zaphod Beeblebrox , FreeBSD Hackers References: From: Dewayne Geraghty Openpgp: preference=signencrypt Message-ID: <84adec37-c0e8-5209-1da1-c05b77f02d82@heuristicsystems.com.au> Date: Thu, 5 Sep 2019 08:22:54 +1000 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46Nyy56qPdz3xlL X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=fail (rsa verify failed) header.d=heuristicsystems.com.au header.s=hsa header.b=Ffewy36I; dmarc=none; spf=pass (mx1.freebsd.org: domain of dewayne.geraghty@heuristicsystems.com.au designates 203.41.22.115 as permitted sender) smtp.mailfrom=dewayne.geraghty@heuristicsystems.com.au X-Spamd-Result: default: False [-3.65 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_DKIM_REJECT(1.00)[heuristicsystems.com.au:s=hsa]; R_SPF_ALLOW(-0.20)[+mx]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[heuristicsystems.com.au]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[heuristicsystems.com.au:-]; RCVD_IN_DNSWL_MED(-0.20)[115.22.41.203.list.dnswl.org : 127.0.4.2]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-1.17)[ipnet: 203.40.0.0/13(-3.87), asn: 1221(-1.99), country: AU(0.01)]; ASN(0.00)[asn:1221, ipnet:203.40.0.0/13, country:AU]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 22:23:12 -0000 Zaphond, I've had the same problem. Even after merging all UIDs, GIDs into the host environment (preferably with appropriate replacements of: /nonexistent:/usr/sbin/nologin), I was confronted with the same uid across multiple jails. So really "ps -o jid,pid,command" and "top -j" are useful - and it takes minor effort. However, the problem is with /var/audit logs - the subject really needs a jail id field, but that's not quite on-topic. Kerberos users still require/have a userid - either as a person (account) or an application (account); if you go this route linking heimdal and openldap work nicely - I used to use these together with pre-samba4.X but you still need an account; while post-samba3, you'll need to modify nsswitch.conf so the system can find a userid mapping. NIS was helpful but for our env, unsuitable, as we didn't want all xID's exposed in the jails. FWIW I added this to acquire jail id information in the /var/audit logs (a very long time ago-not my original idea, I just met the need) --- /usr/src/contrib/openbsm/bin/auditreduce/auditreduce.c (revision 351800) +++ /usr/src/contrib/openbsm/bin/auditreduce/auditreduce.c (working copy) @@ -172,6 +172,7 @@ fprintf(stderr, "\t\t pid=\n"); fprintf(stderr, "\t\t semid=\n"); fprintf(stderr, "\t\t shmid=\n"); + fprintf(stderr, "\t\t zone=\n"); fprintf(stderr, "\t-r : real user\n"); fprintf(stderr, "\t-u : audit user\n"); fprintf(stderr, "\t-v : select non-matching records\n"); @@ -593,6 +594,9 @@ } else if (!strcmp(name, SOCKOBJ)) { p_sockobj = val; SETOPT(opttochk, OPT_oso); + } else if (!strcmp(name, ZONEOBJ)) { + p_sockobj = val; + SETOPT(opttochk, OPT_z); } else usage("unknown value for -o"); } Index: /usr/src/contrib/openbsm/bin/auditreduce/auditreduce.h =================================================================== --- /usr/src/contrib/openbsm/bin/auditreduce/auditreduce.h (revision 351800) +++ /usr/src/contrib/openbsm/bin/auditreduce/auditreduce.h (working copy) @@ -57,6 +57,7 @@ #define OPT_u 0x00010000 #define OPT_A 0x00020000 #define OPT_v 0x00040000 +#define OPT_z 0x00080000 /* zone token */ #define FILEOBJ "file" #define MSGQIDOBJ "msgqid" @@ -64,6 +65,7 @@ #define SEMIDOBJ "semid" #define SHMIDOBJ "shmid" #define SOCKOBJ "sock" +#define ZONEOBJ "zonename" /* aka jail */ From owner-freebsd-hackers@freebsd.org Wed Sep 4 22:30:44 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B907CFBEC for ; Wed, 4 Sep 2019 22:30:44 +0000 (UTC) (envelope-from freebsd-lists@be-well.ilk.org) Received: from be-well.ilk.org (be-well.ilk.org [23.30.133.173]) by mx1.freebsd.org (Postfix) with ESMTP id 46Nz6n5Lydz3xxW for ; Wed, 4 Sep 2019 22:30:41 +0000 (UTC) (envelope-from freebsd-lists@be-well.ilk.org) Received: from lowell-desk.be-well.ilk.org (router.lan [172.30.250.2]) by be-well.ilk.org (Postfix) with ESMTP id 05BB033C27; Wed, 4 Sep 2019 18:30:27 -0400 (EDT) Received: by lowell-desk.be-well.ilk.org (Postfix, from userid 1147) id 3FAD31B2BC83; Wed, 4 Sep 2019 18:30:26 -0400 (EDT) From: Lowell Gilbert To: Zaphod Beeblebrox Cc: FreeBSD Hackers Subject: Re: A jail notion. References: Date: Wed, 04 Sep 2019 18:30:26 -0400 In-Reply-To: (Zaphod Beeblebrox's message of "Wed, 4 Sep 2019 14:55:34 -0400") Message-ID: <44zhjjsni5.fsf@be-well.ilk.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 46Nz6n5Lydz3xxW X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-lists@be-well.ilk.org has no SPF policy when checking 23.30.133.173) smtp.mailfrom=freebsd-lists@be-well.ilk.org X-Spamd-Result: default: False [-1.42 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.931,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-0.90)[-0.904,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[ilk.org]; AUTH_NA(1.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.46)[-0.463,0]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:23.30.0.0/15, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.13)[ip: (0.15), ipnet: 23.30.0.0/15(0.43), asn: 7922(-1.16), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 22:30:44 -0000 Zaphod Beeblebrox writes: > So... in general, I put jails in /jail. I could, for instance, aggregate > all unique userids and groupids into /etc/master.password and /etc/group by > scanning /jail/*/etc/master.passwd, but then again, I could also run kerb. > This could be further generalized by following the jail root configured in > /etc/jail.conf. > > Now... I admit the fact that not all jails will have a password or group > file, but looking at the fairly vast number of jails that I deploy, at > least for me, they almost all have password and group files. > > What am I getting at? Running top on the host ... many of the jail users > end up as numbers. It would be supremely helpful if top was jail-enabled > in this manner. In fact, although I routinely consider kerberos ... I > don't think it would solve this problem. What does the userid of a process > look like under kerb? > > Anyways... food for thought. A perl hacker could add that too sysutils/jtop... From owner-freebsd-hackers@freebsd.org Thu Sep 5 01:57:35 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95764D4736 for ; Thu, 5 Sep 2019 01:57:35 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46P3jV4ckpz46S3 for ; Thu, 5 Sep 2019 01:57:34 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-qk1-x72c.google.com with SMTP id o11so619829qkg.8 for ; Wed, 04 Sep 2019 18:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=ucGtVnS+wGGu+u1C9Mqq+dxbTtRkJ0evGK2snurYPxM=; b=rlNte6dUKh7yBV8GSwYdDQ/a4/j0Sc+t4nCItC69qZR14Ef8W5hJZFclAzFF0pi4MK qKfDEAhz/fnhSAdLJ8HuvIKT19HyhP9IwKn9gT8AkJyrXEg1PzmsFxv4esa+Zh776PMi KCvCbVjkh7tA9Z1xBi08ZYZFbCicKD253rBthUxb4P2ROkenUq37DHwuq/0Xvn4FlKSo 6vVCwJCeI6hHzSCUJc3pwS8blnb9Soq0//z/Hpa7jZEQ6RlRDrQ/P+vv/9R6K1IYeh9p 3rcysMMlOhgbGzRZKRkkIO4fiGqf+g+PENJsHRkm8aOPUaejSxPeKff/VPubdgNdNXXT dOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=ucGtVnS+wGGu+u1C9Mqq+dxbTtRkJ0evGK2snurYPxM=; b=dCHWsB0/ObmdwuWnyv0ySPG+8XgX4yQpDGXHEhoRwrTWE0byZhZZSM9ORZxfOPE9EG 7YcxBd3/C8UOf3mz9ZNrV2rQF5O6eKeX6ykiNi08TQFfUnBdSsiKAUU12yjWGy/RfZX6 Yy7rsHMEzS5ULqwpIIqlyhsu4MVIADq9Wdglz0qC5QaK3R6dOt/rUw7joscNxv0FtNLW qSzRVlw+1AJA2fV14P8VtfyfTi2lX2fNpjSpSJfbMIXUNwt2uvXiaLLwZ5ugTGxtg+Yy 1dDLfdlyCk9Sjk8oGre59ADZdUduiYy92S/K4bWGRDWvMeW/og+oU/XuX/JQC+i/UTuP NLnw== X-Gm-Message-State: APjAAAW99Z4EXxaiVk1Qu9wJWo6es/5yz4Z4Lan63QLSI//ZW4o3s1DH qstQZ6rJx7osODTR6awFhV4WzjztOrc= X-Google-Smtp-Source: APXvYqzj/WEywMI96n1aNBqrJ4Ael0tYw5L3PtW7g12VfUWJKsGoaKN5sC95FQOsIvGCI4oIax2lRA== X-Received: by 2002:ae9:e90c:: with SMTP id x12mr629597qkf.142.1567648653260; Wed, 04 Sep 2019 18:57:33 -0700 (PDT) Received: from [168.122.2.58] (dhcp-wifi-8021x-168-122-2-58.bu.edu. [168.122.2.58]) by smtp.gmail.com with ESMTPSA id d127sm440010qke.54.2019.09.04.18.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Sep 2019 18:57:32 -0700 (PDT) Sender: Theron Tarigo Subject: Re: Looking for review / testing for nvme suspend / resume support To: Warner Losh , Poul-Henning Kamp Cc: FreeBSD Hackers References: <3881.1567598404@critter.freebsd.dk> From: Theron Message-ID: <9b555564-d96e-c4a9-5f23-5ac775677faa@gmail.com> Date: Wed, 4 Sep 2019 21:57:31 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 46P3jV4ckpz46S3 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=rlNte6dU; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of therontarigo@gmail.com designates 2607:f8b0:4864:20::72c as permitted sender) smtp.mailfrom=therontarigo@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.32), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.28), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[c.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2019 01:57:35 -0000 On 2019-09-04 09:18, Warner Losh wrote: > Had several people try it with a similar report, so I pushed it in. > > Warner > I tried to port this to stable/12.  Since I have some other problem with resume on stable which I don't have time to debug just yet, I ended up copying all of stable's sys/dev/nvme (with resume patch) to 12.0-RELEASE, and: It works perfectly, thank you so much! Someone may want to try the patch on a real stable/12 kernel: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240340 Theron From owner-freebsd-hackers@freebsd.org Sat Sep 7 01:35:04 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 62397DE364 for ; Sat, 7 Sep 2019 01:35:04 +0000 (UTC) (envelope-from eric@metricspace.net) Received: from mail.metricspace.net (static-108-31-38-18.washdc.fios.verizon.net [108.31.38.18]) by mx1.freebsd.org (Postfix) with ESMTP id 46QH6b0YTgz3Q2j for ; Sat, 7 Sep 2019 01:35:02 +0000 (UTC) (envelope-from eric@metricspace.net) Received: from [192.168.43.57] (mobile-166-170-31-94.mycingular.net [166.170.31.94]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: eric) by mail.metricspace.net (Postfix) with ESMTPSA id 4A256A9D9 for ; Sat, 7 Sep 2019 01:27:17 +0000 (UTC) To: FreeBSD Hackers From: Eric McCorkle Autocrypt: addr=eric@metricspace.net; prefer-encrypt=mutual; keydata= mDMEXMXabRYJKwYBBAHaRw8BAQdAJ2yzSUUR7u7H/bLAFOzhPII7vvJ45zQeB60TxyCoio20 JEVyaWMgTWNDb3JrbGUgPGVyaWNAbWV0cmljc3BhY2UubmV0PoiWBBMWCAA+FiEEG/v8wt9b D9+AxsV/6Y4m2LfgVbIFAlzF2m0CGwMFCQHhM4AFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AA CgkQ6Y4m2LfgVbJ9mwD/YpSeQ5F9gpvKFS5Bs5w1Bw7zTOfO7zJQrh9NzDbWtd0BAOSGr/i5 zJer2pAjwambsyU0bhgHNy9IDQ7AGnidIyMHuDgEXMXabRIKKwYBBAGXVQEFAQEHQEBwYuBK iJPJEDtS6hbLgcDSUSbfUNA2rGp3TJ1G+7EqAwEIB4h+BBgWCAAmFiEEG/v8wt9bD9+AxsV/ 6Y4m2LfgVbIFAlzF2m0CGwwFCQHhM4AACgkQ6Y4m2LfgVbJ2kwEAlJj1z3zRJm3mmi6N81by nuwAxk3qcKa67WX2/F3C4soA/iwVuPMnx5RWaoX3i2eKXVNzNwzvTFfeGKxfQBOzMocM Subject: GRUB port refurbish patch Message-ID: Date: Fri, 6 Sep 2019 21:27:11 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eRpFVxelQ1DMrIyASvIhohwJ3X8ZZ2naV" X-Rspamd-Queue-Id: 46QH6b0YTgz3Q2j X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of eric@metricspace.net has no SPF policy when checking 108.31.38.18) smtp.mailfrom=eric@metricspace.net X-Spamd-Result: default: False [-4.37 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[94.31.170.166.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; HAS_ATTACHMENT(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[metricspace.net]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.77)[-0.770,0]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; ASN(0.00)[asn:701, ipnet:108.31.0.0/16, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-0.51)[ip: (-2.22), ipnet: 108.31.0.0/16(-1.11), asn: 701(0.84), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Sep 2019 01:35:04 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eRpFVxelQ1DMrIyASvIhohwJ3X8ZZ2naV Content-Type: multipart/mixed; boundary="BMOWnQN7yDMKIneGE2E8KYlALjnMXRHtk"; protected-headers="v1" From: Eric McCorkle To: FreeBSD Hackers Message-ID: Subject: GRUB port refurbish patch --BMOWnQN7yDMKIneGE2E8KYlALjnMXRHtk Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable I've posted a review for my work on refurbishing the GRUB port: https://reviews.freebsd.org/D21558 I don't consider this all the way ready at this point, but it can be tested by others at this point. As it currently stands, this fixes things to where grub-install will actually work again, and I have used the resulting install to boot on real UEFI hardware. The port also adds the QEMU target (which I haven't tested), as well as a Coreboot target (which can't really be tested right now) Current issues: At present, GRUB doesn't seem to be passing the necessary information to the kernel to initialize the EFI frame buffer, so the screen will be blank until my system switches to the intel graphics drivers. I suspect this is because GRUB lacks the ability to create the parameter modules used to do this (and also to pass in keys via keybufs). I will add this ability, but that's really more of a GRUB patch. Aside from that, the UEFI mode seems to work. grub-install doesn't auto-detect the modules to build into the grub image; you'll need to use the --modules argument to do that, or you'll end up with an unbootable system. grub-install also tries to use efibootmgr to set up efi vars, which isn't present on FreeBSD. You'll have to give it the --no-nvram argument (I'll probably add a patch to make that the default). --BMOWnQN7yDMKIneGE2E8KYlALjnMXRHtk-- --eRpFVxelQ1DMrIyASvIhohwJ3X8ZZ2naV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQb+/zC31sP34DGxX/pjibYt+BVsgUCXXMHdAAKCRDpjibYt+BV splMAP4+gSW89yuWWkoAgM33W9T5XYn+VrfO7JqwZeZElaiv4AD+Pa72UFwVDGZU qJTbpeVIlftxq7vQfRGuis4n/7Q/BAs= =vLEe -----END PGP SIGNATURE----- --eRpFVxelQ1DMrIyASvIhohwJ3X8ZZ2naV-- From owner-freebsd-hackers@freebsd.org Sat Sep 7 03:54:35 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B72BE31B9 for ; Sat, 7 Sep 2019 03:54:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46QLCZ35LGz43P5 for ; Sat, 7 Sep 2019 03:54:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82a.google.com with SMTP id u40so9661468qth.11 for ; Fri, 06 Sep 2019 20:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5PImHGuDMkZ+EQRbC8x7jUjFmWnBdrwrelRBJejRPz4=; b=EWWJ7Aq6Mv5yaf/bfeko9NsAye0/La9YKPJcEWhZ0FUjpaayMhnEYuMvEUn7UbL+o9 RRv4yGCj44wFoCQ+0E+zcXYgUh94hLbGCs067EUdmIqJhAaWnM3rV0dNgVJOOPpxFcHl ihv+2gFtZ4yJ7WoF8oJTnhq7NH+Q3EoEUZ18AKn0QExvC2K8LfocNlUu2t52iN6FGjvD 8cKUXSXzqYmrQ1wg+6b+J+5prwWI75bRB6iGqcKCGaCwqwButf6AQTCb99o0tGwPwDOP 1DOP0tt9VrORvkkuXeoAK7lmhNGbT3e9q4w8ujc3bp6xrJSvtwRDluqAbL4FoLUpt1Ur s41g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5PImHGuDMkZ+EQRbC8x7jUjFmWnBdrwrelRBJejRPz4=; b=mwVWpetfuoyK5bNwXBkJY02O48edtx0koShvAv8F0Uy51ShXhr0NdMv7kDgU2cFoMT Jd9Q1B1cuSpCu7Io7G2bYwdYkkXURXCijxCgH8lnWBRuYYpartFuWjmA4xKBgKX6ZnwU LLYO6Efczkaq4njzA/7Avx1BqsGk67SUlqQYSsYXK/ohWioS1Fw/JvMEx2uJsvvNQpCc hWMj7SDwFSAQayzvjy51NmEhMiS0F0zfhEHlgC5/HPflzqMbQ/PPDVqtH5cd/H/VoNly ibJeDDMB8W75wc0DDp4w9WcRgHhJsLn/jWYL1k6j655IGFXdaA09TXl5JWUJa4XTglBE BuRQ== X-Gm-Message-State: APjAAAUqoqxhZrKW+pkR9nSUyWB7NOhHh7Vs3FnODeR/4MrmhNeTJM7L EgJ4jlHxP3Q30GGXJYZ3ty2zB196t3DFg7LFwKCthMl0 X-Google-Smtp-Source: APXvYqwYcmE2GzKLRlqDQc2YT8OeRXFEKa7judYtZoMTLSQkwPmQgc6lCJiaWV7zJkYCv8bQTiVDJCMuk4+VBUVw+XE= X-Received: by 2002:ac8:760e:: with SMTP id t14mr12658533qtq.175.1567828472048; Fri, 06 Sep 2019 20:54:32 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Fri, 6 Sep 2019 21:54:21 -0600 Message-ID: Subject: Re: GRUB port refurbish patch To: Eric McCorkle Cc: FreeBSD Hackers X-Rspamd-Queue-Id: 46QLCZ35LGz43P5 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=EWWJ7Aq6; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82a) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.90 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[a.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.90)[ip: (-9.43), ipnet: 2607:f8b0::/32(-2.75), asn: 15169(-2.27), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Sep 2019 03:54:35 -0000 On Fri, Sep 6, 2019 at 7:35 PM Eric McCorkle wrote: > grub-install also tries to use efibootmgr to set up efi vars, which > isn't present on FreeBSD. You'll have to give it the --no-nvram > argument (I'll probably add a patch to make that the default). > I wrote a mostly Linux compatible efibootmgr on FreeBSD that works great. You do need efirt loaded or in your kernel. It's been in since before 12.0R, although there's been a number of bug fixes since then. Warner