From owner-freebsd-hackers@freebsd.org Tue Sep 10 17:51:59 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACA00DEF46 for ; Tue, 10 Sep 2019 17:51:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46SXfR45qhz3KBs for ; Tue, 10 Sep 2019 17:51:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (unknown [IPv6:2601:641:300:6e9f:3446:4894:7445:f1d2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 1AEAE15FFF for ; Tue, 10 Sep 2019 17:51:59 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.1c.0.190812 Date: Tue, 10 Sep 2019 10:51:50 -0700 Subject: `svn status' lists "sys/arm64/conf/LINT"? From: Ravi Pokala To: "freebsd-hackers@freebsd.org" Message-ID: <272585C7-50CF-4DBC-8F78-46CFFFA72D2F@freebsd.org> Thread-Topic: `svn status' lists "sys/arm64/conf/LINT"? Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Sep 2019 17:51:59 -0000 Hi folks, While it has long been an annoyance of mine that the "LINT" kernel config files are generated into the source tree rather than the build tree, at least they did not show up in `svn status', and did not cause the checkout to be considered un-clean. Note that I used the past tense. :-/ I recently noticed that, after running `make tinderbox', arm64's LINT *did* start being reported by `svn status', as an unknown file. Any ideas as to why? Can we fix it? Thanks, Ravi (rpokala@) From owner-freebsd-hackers@freebsd.org Wed Sep 11 08:28:38 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 588BCF32EE for ; Wed, 11 Sep 2019 08:28:38 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46Sw5x24dkz4bSs for ; Wed, 11 Sep 2019 08:28:36 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from sslproxy06.your-server.de ([78.46.172.3]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1i7xzO-0006TD-VA for freebsd-hackers@freebsd.org; Wed, 11 Sep 2019 10:28:34 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1i7xzO-000OU0-Px for freebsd-hackers@freebsd.org; Wed, 11 Sep 2019 10:28:34 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 44E042A000F for ; Wed, 11 Sep 2019 10:28:40 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id BSte-B8rvVKt for ; Wed, 11 Sep 2019 10:28:40 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 041CD2A1682 for ; Wed, 11 Sep 2019 10:28:40 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VcjrCmfNjnFn for ; Wed, 11 Sep 2019 10:28:39 +0200 (CEST) Received: from linux-diu0.suse (unknown [192.168.96.161]) by mail.embedded-brains.de (Postfix) with ESMTP id DC2A22A000F for ; Wed, 11 Sep 2019 10:28:39 +0200 (CEST) From: Sebastian Huber To: freebsd-hackers@freebsd.org Subject: [PATCH] nvmecontrol: Fix shortopts allocation Date: Wed, 11 Sep 2019 10:28:33 +0200 Message-Id: <20190911082833.32388-1-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 2.16.4 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.101.4/25568/Tue Sep 10 10:25:17 2019) X-Rspamd-Queue-Id: 46Sw5x24dkz4bSs X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sebastian.huber@embedded-brains.de designates 85.10.215.148 as permitted sender) smtp.mailfrom=sebastian.huber@embedded-brains.de X-Spamd-Result: default: False [-1.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.95)[-0.947,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:85.10.215.148]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.99)[-0.988,0]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[148.215.10.85.list.dnswl.org : 127.0.10.0]; MID_CONTAINS_FROM(1.00)[]; IP_SCORE(0.13)[ipnet: 85.10.192.0/18(2.46), asn: 24940(-1.78), country: DE(-0.01)]; DMARC_NA(0.00)[embedded-brains.de]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:85.10.192.0/18, country:DE]; RCVD_COUNT_SEVEN(0.00)[8]; HAS_X_AS(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2019 08:28:38 -0000 Account for potential ':' in the short options string. --- sbin/nvmecontrol/comnd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sbin/nvmecontrol/comnd.c b/sbin/nvmecontrol/comnd.c index d8d97ad11b5..a91969ff766 100644 --- a/sbin/nvmecontrol/comnd.c +++ b/sbin/nvmecontrol/comnd.c @@ -189,7 +189,7 @@ arg_parse(int argc, char * const * argv, const struct cmd *f) lopts = malloc((n + 2) * sizeof(struct option)); if (lopts == NULL) err(1, "option memory"); - p = shortopts = malloc((n + 3) * sizeof(char)); + p = shortopts = malloc((2 * n + 2) * sizeof(char)); if (shortopts == NULL) err(1, "shortopts memory"); idx = 0; -- 2.16.4 From owner-freebsd-hackers@freebsd.org Wed Sep 11 13:30:25 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AFB07D4146 for ; Wed, 11 Sep 2019 13:30:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46T2p85Qnkz3xCY for ; Wed, 11 Sep 2019 13:30:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82f.google.com with SMTP id g13so24810139qtj.4 for ; Wed, 11 Sep 2019 06:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o81AbNy5QkwIcb591v6oYyuRy+dtGV0Dp5xjOHbf1KM=; b=drdjYXWIFAq19rKzw0LSOD/MRa65+ek8MMXnjSh/Zg4HZzaZgQ/BmvmUpBiIAio/aj 24PpRVPWac7tTuVbphkFFhYmn4HtNjtv7yDNb7narZKnckaBGvs7Hw2xf0nDpoQDC+2Q 9FbUTU262O1wSP2ZAqIU2tFEA9Bh5xiuVwlOTgJfQj+k6KL7YDwq/gHsnH4MBWx8w/Ka tX+blSi9D+DduPz93cfCuRNiwVR6qwViRnOAWdLv5BvOeEUlQ54k6JIUs8OH/sNP3sQ5 NMJZ1tHM4U30MD81vPHG3ehYIAM5wXukFqLTdar7h4KPzbGIFd3aq0NIjeq52r3DN4cP S2Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o81AbNy5QkwIcb591v6oYyuRy+dtGV0Dp5xjOHbf1KM=; b=gxD88NDhrXGRyzd9xgI5pDLxWdL7aL8FJE8+e9EdcMXc5u4UmeqrBp562j6BU6lR61 J9S14NiDnBIg8c1baAZO6ORWgl4Rh1+39lPTcEZOGfcDJ7+CCvv8tTl872WP8z0gm7qI go1yCTkEDzyUso2S4w8QbmsaxXYhuOOZJwu2O6pD9J7zKUloNZRynJyAtVNmld/w7WPT OznR4dKobGS8eoj8YDCjVTxAcchtPAu01qnUq1rDK71rQta/KYiBrWf9VCun7GlUrbH6 2nKUjbixLpiPsSibh9iQQrBxMrGrse+J9k5/bEMGsE5R8EizftGKYWOUDpcChh2QTJuW tcqQ== X-Gm-Message-State: APjAAAWHZtP2CEzsiHDE5VHqcjha0x1TGQrUASkba//HEyzrVmO5diQS KZakQBaXbSqqnf5XtVo0rTTbKSmoWVFT8qUmydP76w== X-Google-Smtp-Source: APXvYqy58qsu0hxtXVt6D/qaqy+bY4TuQKKVU/BQ2vyzeCVjKUdOuAp0FAe6JZZcyXm9K/Kgibkw/6MO+mxMFG5Aupk= X-Received: by 2002:ac8:3364:: with SMTP id u33mr35329653qta.187.1568208623348; Wed, 11 Sep 2019 06:30:23 -0700 (PDT) MIME-Version: 1.0 References: <20190911082833.32388-1-sebastian.huber@embedded-brains.de> In-Reply-To: <20190911082833.32388-1-sebastian.huber@embedded-brains.de> From: Warner Losh Date: Wed, 11 Sep 2019 07:30:11 -0600 Message-ID: Subject: Re: [PATCH] nvmecontrol: Fix shortopts allocation To: Sebastian Huber Cc: "freebsd-hackers@freebsd.org" X-Rspamd-Queue-Id: 46T2p85Qnkz3xCY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=drdjYXWI; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82f) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.88 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[f.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.88)[ip: (-9.36), ipnet: 2607:f8b0::/32(-2.72), asn: 15169(-2.25), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Sep 2019 13:30:25 -0000 On Wed, Sep 11, 2019 at 2:28 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Account for potential ':' in the short options string. > --- > sbin/nvmecontrol/comnd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sbin/nvmecontrol/comnd.c b/sbin/nvmecontrol/comnd.c > index d8d97ad11b5..a91969ff766 100644 > --- a/sbin/nvmecontrol/comnd.c > +++ b/sbin/nvmecontrol/comnd.c > @@ -189,7 +189,7 @@ arg_parse(int argc, char * const * argv, const struct > cmd *f) > lopts = malloc((n + 2) * sizeof(struct option)); > if (lopts == NULL) > err(1, "option memory"); > - p = shortopts = malloc((n + 3) * sizeof(char)); > + p = shortopts = malloc((2 * n + 2) * sizeof(char)); > I'll apply, but I still think this needs to be + 3 to account for the NUL at the end (even though we kinda know that the 2 options we're adding don't have :. > if (shortopts == NULL) > err(1, "shortopts memory"); > idx = 0; > -- > 2.16.4 > > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" > From owner-freebsd-hackers@freebsd.org Thu Sep 12 06:58:31 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B6F69ED2B2 for ; Thu, 12 Sep 2019 06:58:31 +0000 (UTC) (envelope-from steevanxperia@gmail.com) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TV3V6jTtz3Pwc for ; Thu, 12 Sep 2019 06:58:30 +0000 (UTC) (envelope-from steevanxperia@gmail.com) Received: by mail-oi1-x22d.google.com with SMTP id 11so961834oix.4 for ; Wed, 11 Sep 2019 23:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=fmGqnO/QBwfiP+aKwAqtHx/n1amXA9jFHgWDVh0qHNQ=; b=B9qmrWLFgoRxavH+89U6fOnmmdNovZoMWZGj9eUudBHr8YS0+3B6BxC23Z+2IYjI9M JKb15mUiLbo4kgbEnCmuwGSN2BclU/QjX9Fr+5RaOY3Iph44yjF3PJX9ARHS0Wx5NOu9 +FbE6zVybtKUkzjyvuthizXYF7YUhEZzoo/wWO3x2sEr0yQuEFVtyagOnOEfcvGkT4x6 WpfkiVscH8XM1lqUZJrA4x/j4kcR4eoOBDHjuhVh9UdKqvpm6t9vmINICAyojxKGfnfY zeWxDg/dDdwvibJSVE1kuO/E6HKzph6iwruf9Iczdd1mIiIvK1KJf2KSNv0mqrYn1TnZ HgNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=fmGqnO/QBwfiP+aKwAqtHx/n1amXA9jFHgWDVh0qHNQ=; b=gzJTDeQB7J75UCJDEipviNEMkT4H90w9Lbye3Ds7e8ozL+pxjqSxdEhNlZfXxXCM6v PbbYEMuzoy9IteRNIyYgj0EnZ33r6wV5P9d27RKbNRy9wjmZan61h4rosoFR3rlNcMpo u/yP+C0JXNze6mmq1TS1W0FHeXNeBPoJLuBIpISwPdg9ZCbEUY87IS30GpY20/GlaPWh Z1uJp0oVIPSkerWTBYL0A93FrCdmDX5cHutO4UY2L6e9xzmfYcWytMXDyGOtKanCLSX9 0yy9xWayZKDgnwMakfNPzGowNwxHoxcooCS1ikufr7JfRMfXcfILrV6jcrui09gwihTH R+rQ== X-Gm-Message-State: APjAAAVShMDDPoeRp6O7WQUVUaMISFXf8i5VHhrqpiWGLMCA+L6t5QkG VduQ0Yk4eZwGdNg8eslI54h4bL1Oyu9yli7u9UK23Fvu X-Google-Smtp-Source: APXvYqwsYSwhN2/PdQoAmcCnd9hjiq+jBhf4IbGXyoio4zdeKfG3+JFqC6MMOOHSOjMrJIBwkRfZcqK+HqDCrFRjxWs= X-Received: by 2002:a05:6808:8e3:: with SMTP id d3mr7007180oic.153.1568271508965; Wed, 11 Sep 2019 23:58:28 -0700 (PDT) MIME-Version: 1.0 From: Steevan Rodrigues Date: Thu, 12 Sep 2019 12:28:18 +0530 Message-ID: Subject: kldload: unexpected relocation type 4 error in FreeBSD 11.2 To: freebsd-hackers@freebsd.org X-Rspamd-Queue-Id: 46TV3V6jTtz3Pwc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=B9qmrWLF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of steevanxperia@gmail.com designates 2607:f8b0:4864:20::22d as permitted sender) smtp.mailfrom=steevanxperia@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-7.97), ipnet: 2607:f8b0::/32(-2.72), asn: 15169(-2.25), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[d.2.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 06:58:31 -0000 Hi Folks, We have a driver for a PCIe card. We did a fresh clean install FreeBSD 11.2 and built our driver on that. When we load that driver we get following error: kldload: unexpected relocation type 4 link_elf_obj: symbol pmap_qremove undefined linker_load_file: Unsupported file type While searching I found following https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231451 Is this a known issue in 11.2 Release ? By the way I have a system with FreeBSD 11.1 release installed and I upgraded that to 11.2 Release and in this system I can build the same driver and it loads fine without any issue. Wonder why I see this difference between a clean install of 11.2 Release and 11.2 release that was upgraded from 11.1 . Regards, Steevan From owner-freebsd-hackers@freebsd.org Thu Sep 12 08:53:28 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C0CCEFE49; Thu, 12 Sep 2019 08:53:28 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: from mail-yw1-xc35.google.com (mail-yw1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TXc73lfzz40f5; Thu, 12 Sep 2019 08:53:27 +0000 (UTC) (envelope-from shreyankfbsd@gmail.com) Received: by mail-yw1-xc35.google.com with SMTP id u187so8848457ywa.11; Thu, 12 Sep 2019 01:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z49Wpsc+LlT1jzd6f69xdxnUZKkwxKbi2sCCm82dpz0=; b=LCiihPYIThjXIl3PLi/Nzj2CyIpiRD3qkpDRbA0D0Y5tJ/mzJC/c3RgZ+9gPlUMc8o KY/hRO+rpJ51R6GTPmdkHs5G0ay5VzFMbDqBFXSo+hHzNOPLaXrQOykIz2YqgF/kMal1 9KMErO4xXyLBgAM+aWlAqrfGxCPrVSX1gspJmhI79iE+ruObW04tDhmRsjly2JlX0qTU 0FLird1BJl87gagdIgCUPRnvopsJdQ8Rmv8IzAJ+1O+97zlyTySuau44e9voMWGQuv9S 0Qn7vVhOvkzZEM98dMBR6khQ7/KIxWNgEtzDQsxRQR751V9ObUbYGIfuKBvqTPlBvD1X DKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z49Wpsc+LlT1jzd6f69xdxnUZKkwxKbi2sCCm82dpz0=; b=GTXdVDgguR2H8CqLegfKpaLqhfg3/F62ylbsyWVb8nukeXA2lyRjFtVRjy8bUNktNd n194hu+lsG5m1FfTxXUjlxdHE8uBLwYJyDQ2CEM4A6safg/qk1QOVLCvYcv6M6CQSSKi Sq+1fW6p/VHKqBV0mxKx1mFp33x2oW17BXlMsYISW5r125MH5516hvdy9oo2ySA6VcHA DVvxPl9xjEDfrpBgXPXyNgzcYX/zQL4LOK82rkoIx2MQVfpaN5ZyoRojREkZaIsxSADL 5LPYQTcBTtU17XxZ0/8WcgMRJfEWibMoGo7d8dNUtjx4Vxut8af+pacnZt9Lw5t82mOa HRIA== X-Gm-Message-State: APjAAAWdeBH5/adhirCKYKCie3uwfSu8tyjJNyjzBNNXiSNfeZcbVjuP /tivSTgfREBrEf8VBfjzrnRseIgWX8Q3FR9J3Wax X-Google-Smtp-Source: APXvYqzxbm1AaYenvXclJeL4QaNnL4XJdBVP/2zslAhaftzMAWptFpTLQXQTDT2oPB0xp6UKw7GbPqODktGHmeaz/B8= X-Received: by 2002:a81:108f:: with SMTP id 137mr25958352ywq.324.1568278406209; Thu, 12 Sep 2019 01:53:26 -0700 (PDT) MIME-Version: 1.0 References: <0534e1a9-af57-96cf-9ea2-ec4b30021226@gmail.com> In-Reply-To: <0534e1a9-af57-96cf-9ea2-ec4b30021226@gmail.com> From: shreyank amartya Date: Thu, 12 Sep 2019 14:23:14 +0530 Message-ID: Subject: Re: hwpmc ktrdump: failed to resolve ktr symbols To: Navdeep Parhar Cc: freebsd-drivers@freebsd.org, freebsd-hackers@freebsd.org X-Rspamd-Queue-Id: 46TXc73lfzz40f5 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=LCiihPYI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of shreyankfbsd@gmail.com designates 2607:f8b0:4864:20::c35 as permitted sender) smtp.mailfrom=shreyankfbsd@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(0.00)[ip: (-8.67), ipnet: 2607:f8b0::/32(-2.72), asn: 15169(-2.25), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[5.3.c.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 08:53:28 -0000 Thanks, yes it seems I was missing both those options (KTR and DDB) in my kernel config. Now, I have a module (hwpmc) from which I intend to collect traces. However, when I build and load it, I don't see any ktraces when using it. But if I install it and load the module on boot, ktraces appear. Why does that happen? Anyway around that? Thanks Shreyank On Fri, Aug 30, 2019 at 9:37 PM Navdeep Parhar wrote: > On 2019-08-30 03:54, shreyank amartya wrote: > > Hi, > > > > I'm trying to collect traces from hwpmc module. I compiled the module > with > > -DHWPMC_DEBUG option and set the sysctl kern.hwpmc.debugflags but I'm > > unable to retrive the traces using ktrdump. I get this error message: > > > > ktrdump: failed to resolve ktr symbols > > > > I'm guessing that this error occurs because the symbols for hwpmc module > > (compiled and loaded separately) are not a part of kernel. If this is the > > case, then how do I get those symbols. In the ktr man page its also > > mentioned that ddb and gdb can retrieve ktraces. > > > > I found the ddb command show ktr. But how do I invoke ddb (without a > panic)? > > sysctl debug.kdb.enter=1 > > > > > I'm unable to find how can I use gdb to view the traces (I launched kgdb > > but could not find a command to show kernel traces). > > > > Any idea on how to get ktrdump working? Or get the kernel traces. > > You need a kernel with KTR support. See ktr(4) for a full list of > the options and other details. See "sysctl kern.conftxt" for what's > in your running kernel. > > Regards, > Navdeep > From owner-freebsd-hackers@freebsd.org Thu Sep 12 15:32:38 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2DC5BD171E for ; Thu, 12 Sep 2019 15:32:38 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TjSj064vz4Ntj for ; Thu, 12 Sep 2019 15:32:36 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qk1-x733.google.com with SMTP id 4so24874702qki.6 for ; Thu, 12 Sep 2019 08:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=PlSixtpgFKo2XWVg6iqx7Taakmu0EtNgscCsSSipqbk=; b=UHOG0ESrTTeczlOXXWrxbMR24mMhST/7bqpTrsS3a+ALWqzIJ5Fcbx7kHEFrOs8bFT EsSLusoPZjDA6AGC8aHssR6XXOLtvg2rE5FtBiJDnBzqFvQDzVO7J0HK8zEUmxRtSJsa XmXcs3X1fWOjUlb0keZMaF6dYG+WrLlBuDnAxRaJNVl1c3OsVudcPxBG3yTixhwdyXZm pB2dwMP0TxKTPJzOT4ASa9P0LJFpyp5WLcVvybOUJB/L8nsoi5rPQwDFIe3Ipf9vkbss nDjJfkaQBKTUI3K3pCVG3jzB6GnXqrhV7KqhsyR4OOOoGHPCTZeF6BBJMphBPXE07PI4 D+jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=PlSixtpgFKo2XWVg6iqx7Taakmu0EtNgscCsSSipqbk=; b=mCweb/SB+RLffrwqoBxuRDfMZUH32zLprgd1y1ieGYFbv57vr3a+LM9lp2d+Uqk5UB a1te9xRdHNJyD2C2c2ILUfYnCQBnoa9X7Ef8cmE64yTAked/XW1KsCKrx3xlSV5kK/MT k1c3DjANfO6ZfEBsACyTqVteXMw1GxD4PC5al2SGYxAfC+7OrCHhV9r+4fhb/3+aye4b OaRiCD5iHI3EFwNL7ZYvmAWd9WaVIwOjIAOhcw2yR6yfqEMj034n6kFihuRg46DFyIEF 1ksHV0Zb90qZVdDNcAX9fccy7NBko5CStQoXqH5g6fw9ZE93JWeUj5MZiYyhTZ3Mg+Nz 90HQ== X-Gm-Message-State: APjAAAUqP8T1McgMAidgghm78Xgd1SQRC3sqznL40H7+HP38sRxU0K/C H1AoLB78RGXvf5jptqDqYYbIgsJwtqdRobZjJ4m+tHwS X-Google-Smtp-Source: APXvYqz1v5H0hZwqOpxK0AGJ5Ws4obyg6IUNl8LwY01145xPxLYgf7F7R+C2UnJzxMYEWBfv3msG53Mnbf9cquVUTxU= X-Received: by 2002:a37:a858:: with SMTP id r85mr27067422qke.394.1568302354781; Thu, 12 Sep 2019 08:32:34 -0700 (PDT) MIME-Version: 1.0 From: Ryan Stone Date: Thu, 12 Sep 2019 11:32:23 -0400 Message-ID: Subject: /etc/rc.d/dumpon runs before netdump can be configured To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46TjSj064vz4Ntj X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=UHOG0ESr; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::733 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(0.00)[ip: (-9.32), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.25), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[3.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 15:32:38 -0000 Hi everyone, I recently tried enabling the netdump client on a system via rc.conf. However, this isn't working for me because dumpon runs before netif, and netdump requires the interface to have been ifconfig'ed up before it will allow netdump to be enabled on an interface. As a result, I get this message during boot, and have to manually run "service dumpon start" after boot to get netdump configured. dumpon: Unable to configure netdump because the interface's link is down. I'm not sure what the best way to clean this up is. Moving dumpon to later in the boot process would be a POLA violation for people dumping to disk. Perhaps we need a separate netdump_client rc.d script? Thanks, Ryan From owner-freebsd-hackers@freebsd.org Thu Sep 12 16:13:47 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7129D2E71 for ; Thu, 12 Sep 2019 16:13:47 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TkNC13BHz4RbG for ; Thu, 12 Sep 2019 16:13:46 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2b.google.com with SMTP id r4so56045777iop.4 for ; Thu, 12 Sep 2019 09:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZlaDp42iAVW5+b3WlzM5Zr16uIgRhR3O0wr9nYmsVm0=; b=pMz8O0mum2xqW04RtdKE3ksOcr4eCvATOI/U1lik/VSpCyqTEsVbIvgKNeLQnuit0G HSHwucm8Y4qkwLSheEkIUSqh9C7PmeLMu63L6fXDUfSxfBpJmXwt6w8I4cL7h1l6TZJx AvhZiT4o2fcYfBGEx2/u80xz/OAHtvssUno4qVLmpR5PI3jkxWP9RwxYLaiCjSPVbuRH 2Efqwe8CU5Z44bH8GDmaoV/ZgA53+4/mBtwnwmj8mLXXep28nN16ciwhoFybKiC5NEAA xdJr/J/f/ZlAPRXA+omnrwLLFevDo/Yazazs6l5Ck3opvD4aJAtl85J4TptwsxusdJFa SPAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ZlaDp42iAVW5+b3WlzM5Zr16uIgRhR3O0wr9nYmsVm0=; b=HgfADAThVbJ8mc3FGrzfMwUNmN+/snn4xEO0at4cLsQmfKfSLYHvzLWqMcyP6dqtcp BXbW3rFuDQQea1p3rQydA6Bl96nJkZIKYhB5owpvpoPtlnyQFxD9nOf11ZaoZ+k92g0U MQfOIeOCmJCo9+8fiVIMMcbqbiitXKqvV+hlhsmsh3HCIKGFQQuWoOiX6HJyUbm3objU 0cPhJYukq1R8yI4T2as+TBUmbEGW2sImxOMG7y/fc/ReaBzhpjUGGX9aQ9DLtgeLe9Ro GhC0yPuXvs7WjTFOjOIwPFcCrq18I7aio9pVcLxIz/ACkVueVdMVQXwFeoV4ecEnmM68 3TSQ== X-Gm-Message-State: APjAAAUjR5oPnqPpSMHR+Hu4TrJH1U1UYmT8SzraYaV76IQvYhIxQDrb b8V6u7sRXVIaJhV0ohNOVuGNaC+N X-Google-Smtp-Source: APXvYqx+YVVykEqFtVJ5BJuQUhMzwbRvwP0i1bElyuZzQPUTL4GnNb/du1ietcF7L94KrZCu1RegMA== X-Received: by 2002:a02:634c:: with SMTP id j73mr44739644jac.99.1568304825149; Thu, 12 Sep 2019 09:13:45 -0700 (PDT) Received: from raichu (toroon0560w-lp140-01-69-159-39-167.dsl.bell.ca. [69.159.39.167]) by smtp.gmail.com with ESMTPSA id i2sm3294933iom.68.2019.09.12.09.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 09:13:44 -0700 (PDT) Sender: Mark Johnston Date: Thu, 12 Sep 2019 12:13:42 -0400 From: Mark Johnston To: Ryan Stone Cc: freebsd-hackers@freebsd.org Subject: Re: /etc/rc.d/dumpon runs before netdump can be configured Message-ID: <20190912161342.GB8397@raichu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46TkNC13BHz4RbG X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pMz8O0mu; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d2b as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-3.63 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[b.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.93)[ip: (-4.63), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.25), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 16:13:48 -0000 On Thu, Sep 12, 2019 at 11:32:23AM -0400, Ryan Stone wrote: > Hi everyone, > > I recently tried enabling the netdump client on a system via rc.conf. > However, this isn't working for me because dumpon runs before netif, > and netdump requires the interface to have been ifconfig'ed up before > it will allow netdump to be enabled on an interface. > > As a result, I get this message during boot, and have to manually run > "service dumpon start" after boot to get netdump configured. > > dumpon: Unable to configure netdump because the interface's link is down. > > I'm not sure what the best way to clean this up is. Moving dumpon to > later in the boot process would be a POLA violation for people dumping > to disk. Perhaps we need a separate netdump_client rc.d script? What exactly is the POLA violation there? A separate rc script could be helpful for static network configurations. For DHCP, I don't see a good solution other than to use /etc/dhclient-exit-hooks; there is an example for this in the dumpon(8) man page. From owner-freebsd-hackers@freebsd.org Thu Sep 12 18:31:12 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0121BD64D4 for ; Thu, 12 Sep 2019 18:31:12 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46TnQl6Bx0z4ZWr; Thu, 12 Sep 2019 18:31:11 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-qk1-x730.google.com with SMTP id x134so25498544qkb.0; Thu, 12 Sep 2019 11:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PqC51Grddpqtns/+SI5Cor4SAF2Gy183NwNhNsQHQak=; b=gCP4Mz7UqnI08I6aMu9YBZGYwTHlcnlgdhBWJ/Rfs95xSjlSk4V6Kt2ZQTm3V+CbJQ 0jFDYBRbxUQxZ4B6T2pKKCiwJNOCvKcx7u0CRs1bHgYd1Kg9HHa9jnWUwbhKjBc0iWay O89KUBcfOKQZbdIy0CRYoAmxxjUUT2xV6Ll61E2g0r1F1259F4vQsVDWNxEgZOPnMz/j rKFUHfI0dCfwRcyhrXaruE1DlygShHFG8gAuzCJnKsKHNAAUIYY0qXVCCIC2dmKWL4di sV8ICtryR37XCz1N/Z7tMqIwveQC1M2u9Z5aZpEnEj/iHR2M1VwrUyD02IP7tVVcJStt +VCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PqC51Grddpqtns/+SI5Cor4SAF2Gy183NwNhNsQHQak=; b=csVPMBZ5hBw2GE2NsI7qUqeM3pMQMHvgkAYmTBIMZnXBs7WfgAJ2rZkUfadABkwUOX pv9fmRIIgfkE2L/nvqFef+sCCXLOc9Iv+LhHfdG4QAPdyDKqzWixt1GNdjYj7CxqmJnM Qn0f87Dwvlv0uaAinxU2r4V/1grLIFrdqdXFU/jEU2pR4P3FAr9DEqT2GHWcbTJKIDm5 9xrIn+TGjeJnOCzxbiJxbnodbvJ81VZc7leicCE+UTYWzN5FVUCYIh5wRsPSaJX+CHXO 5qsiiziUoctTSKfdIXYcx8+PUTiKiWqDwH1DvpKgyJX4VcIVJUGyv1l+yMNp3VHIVOMx gXMQ== X-Gm-Message-State: APjAAAVb4j391wco+fVYdNXvyAtFUXf0h7nw5IUdD+EKxbFp2jdCTTeM +FJfduWNEJ0lGi6Dc4PJwIUySxfY5WGBUTUfcQqiCg== X-Google-Smtp-Source: APXvYqymyKejXaafJbIDWUR5BEKyRTWefvqanmX4RebT4Aj/iZlkNU8uJDvfUPIUsWRwsNvc60ZZAImzOF14uhwAE+A= X-Received: by 2002:a37:af87:: with SMTP id y129mr23886628qke.98.1568313070311; Thu, 12 Sep 2019 11:31:10 -0700 (PDT) MIME-Version: 1.0 References: <20190912161342.GB8397@raichu> In-Reply-To: <20190912161342.GB8397@raichu> From: Ryan Stone Date: Thu, 12 Sep 2019 14:30:58 -0400 Message-ID: Subject: Re: /etc/rc.d/dumpon runs before netdump can be configured To: Mark Johnston Cc: freebsd-hackers@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46TnQl6Bx0z4ZWr X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Sep 2019 18:31:12 -0000 The POLA violation would be that kernel panics during some parts of the boot process, like during network configuration, wouldn't be captured. On Thu, Sep 12, 2019 at 12:13 PM Mark Johnston wrote: > > On Thu, Sep 12, 2019 at 11:32:23AM -0400, Ryan Stone wrote: > > Hi everyone, > > > > I recently tried enabling the netdump client on a system via rc.conf. > > However, this isn't working for me because dumpon runs before netif, > > and netdump requires the interface to have been ifconfig'ed up before > > it will allow netdump to be enabled on an interface. > > > > As a result, I get this message during boot, and have to manually run > > "service dumpon start" after boot to get netdump configured. > > > > dumpon: Unable to configure netdump because the interface's link is down. > > > > I'm not sure what the best way to clean this up is. Moving dumpon to > > later in the boot process would be a POLA violation for people dumping > > to disk. Perhaps we need a separate netdump_client rc.d script? > > What exactly is the POLA violation there? > > A separate rc script could be helpful for static network > configurations. For DHCP, I don't see a good solution other than to use > /etc/dhclient-exit-hooks; there is an example for this in the dumpon(8) > man page. From owner-freebsd-hackers@freebsd.org Fri Sep 13 00:12:23 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2B096DF557 for ; Fri, 13 Sep 2019 00:12:23 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Tx0Q2fXWz3wnT for ; Fri, 13 Sep 2019 00:12:22 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-io1-xd2e.google.com with SMTP id n197so59179980iod.9 for ; Thu, 12 Sep 2019 17:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MpBGxOsjSCLfs+fLMxANL0ej09nkV50Irz/FKzuT60k=; b=fHHP1FB5uEP7t0uSRkVGnEVpLL7ENLtjFaPb9RgAUZ9nPH976cvTBbFo6r+Al9s7dh RGTq/KDb2dGhSAC6gcggylMC1TNvsCeTsgcCGicCgGtB11EwN3G5UZO/D+CcE5ukN+yN berGbwmYFVAsjbDf6oxGIhfcYdleiDS8pgd5lbkTUYLLrnjQOqwrRBrrbSMnQN+t+ttP tuiP/zNg7hJyfUteBP/scWY7h+NInP8w28KUZZfPsmmcbhuW/IXL41Q6v9PDpm3xZ+yJ Nk1fXnOkY/pTjxYrR+5y4dRMq6EKMzhfQYkKhDbiPq0mnne4DpnNCVblBg5rM5B/ZJCt nGUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=MpBGxOsjSCLfs+fLMxANL0ej09nkV50Irz/FKzuT60k=; b=tszrgzJ33F7SsAlHfCBUeQAwIKbyiXo5b9cnx96lZTz+zLCSNPU0chInvH1XBueZX7 9SEX6d49ER7lw96YNa7EjaWaUizlhQBG6sUmql7SHdETeib2Nb9c+bvw1bdyLZK1eDwK N6B/PYspfiVgYwkU9baqtG8shsRPQ6jLnGGUr7taqUZwTgIPW9tE1yxZcda2vUN/nmB5 BEfQS38M5m2D8pN8c8XoTog8Sxeit60c7ZavI1J+SBFU6Gqrqs6tRnn6gJCG17gbusEY gw70rbvv+hgrXnYY9nnuF56F2FodSj7rIGBI6I7ceeRHewSMpbU9KwuA9fa1yfZscXWq Wceg== X-Gm-Message-State: APjAAAWRisYLpyesvmRA6+faxv6n3NwcIQusGdtmRS7UljNIH70xOUD1 76p75ZYWFaEHHCWfe3+KTvoj7GIk X-Google-Smtp-Source: APXvYqxM2X9L0OnTztfHBOWjLoI4bnMce4kGu7vT+aHdHEa7UBOV4TPO8BmX+xvVZFkJPqv+7gFrCw== X-Received: by 2002:a6b:f80f:: with SMTP id o15mr5016342ioh.174.1568333540998; Thu, 12 Sep 2019 17:12:20 -0700 (PDT) Received: from raichu (toroon0560w-lp140-01-69-159-39-167.dsl.bell.ca. [69.159.39.167]) by smtp.gmail.com with ESMTPSA id a13sm16719687ioh.8.2019.09.12.17.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2019 17:12:20 -0700 (PDT) Sender: Mark Johnston Date: Thu, 12 Sep 2019 20:12:18 -0400 From: Mark Johnston To: Ryan Stone Cc: freebsd-hackers@freebsd.org Subject: Re: /etc/rc.d/dumpon runs before netdump can be configured Message-ID: <20190913001218.GH8397@raichu> References: <20190912161342.GB8397@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46Tx0Q2fXWz3wnT X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=fHHP1FB5; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::d2e as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-3.70 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[e.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.00)[ip: (-5.01), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.25), country: US(-0.05)]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; MID_RHS_NOT_FQDN(0.50)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 00:12:23 -0000 On Thu, Sep 12, 2019 at 02:30:58PM -0400, Ryan Stone wrote: > The POLA violation would be that kernel panics during some parts of > the boot process, like during network configuration, wouldn't be > captured. I think it would reasonable to add a dumponlate, following the pattern of mountlate and swaplate, to handle this. > On Thu, Sep 12, 2019 at 12:13 PM Mark Johnston wrote: > > > > On Thu, Sep 12, 2019 at 11:32:23AM -0400, Ryan Stone wrote: > > > Hi everyone, > > > > > > I recently tried enabling the netdump client on a system via rc.conf. > > > However, this isn't working for me because dumpon runs before netif, > > > and netdump requires the interface to have been ifconfig'ed up before > > > it will allow netdump to be enabled on an interface. > > > > > > As a result, I get this message during boot, and have to manually run > > > "service dumpon start" after boot to get netdump configured. > > > > > > dumpon: Unable to configure netdump because the interface's link is down. > > > > > > I'm not sure what the best way to clean this up is. Moving dumpon to > > > later in the boot process would be a POLA violation for people dumping > > > to disk. Perhaps we need a separate netdump_client rc.d script? > > > > What exactly is the POLA violation there? > > > > A separate rc script could be helpful for static network > > configurations. For DHCP, I don't see a good solution other than to use > > /etc/dhclient-exit-hooks; there is an example for this in the dumpon(8) > > man page. From owner-freebsd-hackers@freebsd.org Fri Sep 13 05:53:51 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C12CE63CC for ; Fri, 13 Sep 2019 05:53:51 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46V4ZQ12dKz4BSJ for ; Fri, 13 Sep 2019 05:53:49 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from sslproxy06.your-server.de ([78.46.172.3]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1i8eWg-00064H-9J; Fri, 13 Sep 2019 07:53:46 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1i8eWg-0005Gl-4q; Fri, 13 Sep 2019 07:53:46 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 96ADC2A000F; Fri, 13 Sep 2019 07:53:53 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id dA-fUd93IEgW; Fri, 13 Sep 2019 07:53:53 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 29CAF2A1682; Fri, 13 Sep 2019 07:53:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6LGkP0X3Cshs; Fri, 13 Sep 2019 07:53:53 +0200 (CEST) Received: from huber-nb-linux.suse (unknown [192.168.96.161]) by mail.embedded-brains.de (Postfix) with ESMTPSA id 14FE22A000F; Fri, 13 Sep 2019 07:53:51 +0200 (CEST) Subject: Re: [PATCH] nvmecontrol: Fix shortopts allocation To: Warner Losh Cc: "freebsd-hackers@freebsd.org" References: <20190911082833.32388-1-sebastian.huber@embedded-brains.de> From: Sebastian Huber Message-ID: Date: Fri, 13 Sep 2019 07:53:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.101.4/25570/Thu Sep 12 10:22:52 2019) X-Rspamd-Queue-Id: 46V4ZQ12dKz4BSJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sebastian.huber@embedded-brains.de designates 85.10.215.148 as permitted sender) smtp.mailfrom=sebastian.huber@embedded-brains.de X-Spamd-Result: default: False [-2.29 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_COUNT_SEVEN(0.00)[8]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:85.10.215.148]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DMARC_NA(0.00)[embedded-brains.de]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[148.215.10.85.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; IP_SCORE(0.00)[ipnet: 85.10.192.0/18(1.82), asn: 24940(-1.79), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:85.10.192.0/18, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; HAS_X_AS(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 05:53:51 -0000 On 11/09/2019 15:30, Warner Losh wrote: >=20 >=20 > On Wed, Sep 11, 2019 at 2:28 AM Sebastian Huber=20 > > wrote: >=20 > Account for potential ':' in the short options string. > --- > =C2=A0sbin/nvmecontrol/comnd.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sbin/nvmecontrol/comnd.c b/sbin/nvmecontrol/comnd.c > index d8d97ad11b5..a91969ff766 100644 > --- a/sbin/nvmecontrol/comnd.c > +++ b/sbin/nvmecontrol/comnd.c > @@ -189,7 +189,7 @@ arg_parse(int argc, char * const * argv, const > struct cmd *f) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 lopts =3D malloc((n + 2) * sizeof(stru= ct option)); > =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (lopts =3D=3D NULL) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 err(1, "op= tion memory"); > -=C2=A0 =C2=A0 =C2=A0 =C2=A0p =3D shortopts =3D malloc((n + 3) * si= zeof(char)); > +=C2=A0 =C2=A0 =C2=A0 =C2=A0p =3D shortopts =3D malloc((2 * n + 2) = * sizeof(char)); >=20 >=20 > I'll apply, but I still think this needs to be=C2=A0+ 3 to account for = the=20 > NUL at the end (even though we kinda know that the 2 options we're=20 > adding don't have :. Thanks for checking it in. I wondered why there was a + 3, we have in=20 arg_parse() with unrelated code omitted: p =3D shortopts =3D malloc((2 * n + 3) * sizeof(char)); for (i =3D 0; i < n; i++) { if (isprint(opts[i].short_arg)) { *p++ =3D opts[i].short_arg; if (lopts[i].has_arg) *p++ =3D ':'; } } *p++ =3D '?'; *p++ =3D '\0'; while ((ch =3D getopt_long(argc, argv, shortopts, lopts, &idx)) !=3D -1) = { Looks like the last ++ is superfluous. --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG= . From owner-freebsd-hackers@freebsd.org Fri Sep 13 06:02:43 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CAE19E6A85 for ; Fri, 13 Sep 2019 06:02:43 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46V4mf6t0dz4C8h for ; Fri, 13 Sep 2019 06:02:42 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from sslproxy06.your-server.de ([78.46.172.3]) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1i8efH-0006cp-QP for freebsd-hackers@freebsd.org; Fri, 13 Sep 2019 08:02:39 +0200 Received: from [82.100.198.138] (helo=mail.embedded-brains.de) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1i8efH-000QOQ-M2 for freebsd-hackers@freebsd.org; Fri, 13 Sep 2019 08:02:39 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 221BB2A000F for ; Fri, 13 Sep 2019 08:02:47 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 47NpKIazSbE7 for ; Fri, 13 Sep 2019 08:02:46 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id B6E272A1682 for ; Fri, 13 Sep 2019 08:02:46 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id o_98KaV4SxoI for ; Fri, 13 Sep 2019 08:02:46 +0200 (CEST) Received: from huber-nb-linux.suse (unknown [192.168.96.161]) by mail.embedded-brains.de (Postfix) with ESMTPSA id A14752A000F for ; Fri, 13 Sep 2019 08:02:46 +0200 (CEST) To: FreeBSD From: Sebastian Huber Subject: Problems with port of NVMe support Message-ID: Date: Fri, 13 Sep 2019 08:02:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.101.4/25570/Thu Sep 12 10:22:52 2019) X-Rspamd-Queue-Id: 46V4mf6t0dz4C8h X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sebastian.huber@embedded-brains.de designates 85.10.215.148 as permitted sender) smtp.mailfrom=sebastian.huber@embedded-brains.de X-Spamd-Result: default: False [-2.42 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_SEVEN(0.00)[8]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:85.10.215.148:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[embedded-brains.de]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_TLS_LAST(0.00)[]; TO_DN_ALL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[148.215.10.85.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; IP_SCORE(-0.12)[ipnet: 85.10.192.0/18(1.19), asn: 24940(-1.79), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:85.10.192.0/18, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; HAS_X_AS(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 06:02:43 -0000 Hello, I port currently the NVMe support from FreeBSD to RTEMS. Basically, it=20 works. I can issue administration commands and some IO commands (e.g.=20 FLUSH). I use this SSD for testing: $ nvmecontrol identify nvme0 Controller Capabilities/Features =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D Vendor ID: 8086 Subsystem Vendor ID: 8086 Serial Number: PHM27390006S280AGN Model Number: INTEL SSDPE21D280GA Firmware Version: E2010325 Recommended Arb Burst: 0 IEEE OUI Identifier: e4 d2 5c Multi-Path I/O Capabilities: Not Supported Max Data Transfer Size: 131072 Controller ID: 0x0000 Version: 0.0.0 My problem is now, that every WRITE transfer ends up in a DATA TRANSFER=20 ERROR: nvme0: WRITE sqid:1 cid:127 nsid:1 lba:0 len:8 nvme0: DATA TRANSFER ERROR (00/04) sqid:1 cid:127 cdw0:0 nvme0: async event occurred (type 0x0, info 0x04, page 0x01) Every READ transfer ends up in a UNRECOVERED READ ERROR: nvme0: READ sqid:1 cid:127 nsid:1 lba:0 len:8 nvme0: UNRECOVERED READ ERROR (02/81) sqid:1 cid:127 cdw0:0 nvme0: async event occurred (type 0x0, info 0x04, page 0x01) I see the transfers in the error log: $ nvmecontrol logpage -p 1 nvme0=20 =20 Error Information Log=20 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=20 =20 Entry 01=20 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=20 =20 Error count: 2546=20 =20 Submission queue ID: 1=20 =20 Command ID: 32512=20 =20 Status:=20 =20 Phase tag: 0=20 =20 Status code: 129=20 =20 Status code type: 2=20 =20 More: 1=20 =20 DNR: 1=20 =20 Error location: 0=20 =20 LBA: 0=20 =20 Namespace ID: 1=20 =20 Vendor specific info: 0=20 =20 Transport type: 0=20 =20 Command specific info:0=20 =20 Transport specific: 0=20 =20 Entry 02=20 =20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=20 =20 Error count: 2545=20 =20 Submission queue ID: 1=20 =20 Command ID: 32512=20 =20 Status:=20 =20 Phase tag: 0=20 =20 Status code: 4=20 =20 Status code type: 0=20 =20 More: 1=20 =20 DNR: 1=20 =20 Error location: 0=20 =20 LBA: 0=20 =20 Namespace ID: 1=20 =20 Vendor specific info: 0=20 =20 Transport type: 0=20 =20 Command specific info:0=20 =20 Transport specific: 0 From the NVMe specification I didn't get any hints what the error=20 reason could be. Maybe someone has a hint for me. The platform is a=20 T4240 PowerPC (big-endian). --=20 Sebastian Huber, embedded brains GmbH Address : Dornierstr. 4, D-82178 Puchheim, Germany Phone : +49 89 189 47 41-16 Fax : +49 89 189 47 41-09 E-Mail : sebastian.huber@embedded-brains.de PGP : Public key available on request. Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG= . From owner-freebsd-hackers@freebsd.org Fri Sep 13 06:19:37 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD874E7184 for ; Fri, 13 Sep 2019 06:19:37 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46V5883YKnz4CnK for ; Fri, 13 Sep 2019 06:19:36 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: by mail-vk1-xa29.google.com with SMTP id t136so5694275vkt.9 for ; Thu, 12 Sep 2019 23:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9tclA750BDdvSOqHlSfhmp1VoLi8QazyWnfvlIhl1wY=; b=iM0KP17Q3BheQtwPy0YusLeu4+UhY/efWD8VKcRntCB2KoC3w997GoGcLqIJhn61DR TQl2nC6krQ7DMepZhot9kVpb5dzqWGmNXNgAd5bpNKoKj6toJ95zREk5+mO5bIW1gKB5 9CrHum6sCVvGrenWPXmM4/pTYbLzdz8BRv6SB1mrfMyV11dyL7dzPcQinHg/HQNoqH87 QzJu18bfRw36sZssD5kevWFROFPpjkgB3sxGwhD6VSJ52ApiMn1LFoCxngP5ruutv8iE JfKtHgerRrPt3kHVT2BFO86A/5tS0Sd4aHotq+CqDnafVOar+dotQUs2ag/W6HSvZ7Dz fdrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9tclA750BDdvSOqHlSfhmp1VoLi8QazyWnfvlIhl1wY=; b=XhBlSJBarukGK73DiZ2qxppa3UGoYkKgUjQRUGlZOBHjfqDWbpUMONZCd3VT1KhkZn 24ueERWQCH4eBkvpHe3F3lRMIjieIPxGfhZKhzF2ceNxleUeqruoJa20MOnn4VOOr7vr rn2uRqFkhjDW6pcij5UwEAI8TT0q125ijzfGf2xQB1OwLZkBIjK4lZqp6XAest/h1QgJ TMmKbs+WIjKBv9WcS1zf7/r9TKC/kTgRL6Ch5qzj6XKUzki7y74iEZmV4e7DqlgR+gqs 633TOnu5BCrhkZ5AZa4RA2rgPBMdCbkYMFh6XtD8fnL9p1xilOj2jCKDMJPmRdsBFiHh 7i9w== X-Gm-Message-State: APjAAAW8I6gEuHSxZWg/WdIQ+sXyXu6PZapfg38f3WdJ5x/a5zWBP9v0 CnBzZj30zUHoayK2jQUXev+jhewQN3vipJqMERgeUzQ+C1E= X-Google-Smtp-Source: APXvYqwbHGLOiOF+lmyW+vPa+A1nEBR0PbehsUCBKrCmTJWGpGf4GWkTeJ5+G0Gp3BRNqTeU4PIF0LS9Ci/BR8hwpiI= X-Received: by 2002:ac5:c4e9:: with SMTP id b9mr11713125vkl.83.1568355574786; Thu, 12 Sep 2019 23:19:34 -0700 (PDT) MIME-Version: 1.0 From: Mihir Luthra Date: Fri, 13 Sep 2019 11:49:23 +0530 Message-ID: Subject: correct ways to get code reviewed To: freebsd-hackers@freebsd.org X-Rspamd-Queue-Id: 46V5883YKnz4CnK X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=iM0KP17Q; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of luthramihir708@gmail.com designates 2607:f8b0:4864:20::a29 as permitted sender) smtp.mailfrom=luthramihir708@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.58), ipnet: 2607:f8b0::/32(-2.71), asn: 15169(-2.24), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[9.2.a.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 06:19:37 -0000 Hi everyone, I am a new contributor to FreeBSD projects. Recently I have started making changes in the source code by working on project ipv6 userland cleanup [1]. I did post one patch to phabrictor which got reviewed as well. I had some queries in my mind on which I wanted some advice. 1) Should I post another patch only after the first one has been approved or is it better to keep posting patches irrespective of review status of the first? 2) Should I ask commiters for review individually or should I post the link on the mailing lists? Or maybe should I simply wait for the patch to get reviewed without informing anyone? 3) If the patch gets approved, do I need to submit a pul request on github or is their some different procedure? [1] https://wiki.freebsd.org/SummerOfCodeIdeas#IPv6_Userland_Cleanup Thanks, Mihir From owner-freebsd-hackers@freebsd.org Fri Sep 13 14:05:46 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 059A6F26C3 for ; Fri, 13 Sep 2019 14:05:46 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46VHV11TVTz3C3D for ; Fri, 13 Sep 2019 14:05:44 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id C61F93C0199; Fri, 13 Sep 2019 14:05:43 +0000 (UTC) Date: Fri, 13 Sep 2019 14:05:43 +0000 From: Brooks Davis To: Mihir Luthra Cc: freebsd-hackers@freebsd.org Subject: Re: correct ways to get code reviewed Message-ID: <20190913140543.GC93439@spindle.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KFztAG8eRSV9hGtP" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 46VHV11TVTz3C3D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.49 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-3.59)[ip: (-9.37), ipnet: 199.48.128.0/22(-4.67), asn: 36236(-3.86), country: US(-0.05)]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; SIGNED_PGP(-2.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Sep 2019 14:05:46 -0000 --KFztAG8eRSV9hGtP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 13, 2019 at 11:49:23AM +0530, Mihir Luthra wrote: > Hi everyone, >=20 > I am a new contributor to FreeBSD projects. Recently I have started making > changes in the source code by working on project ipv6 userland cleanup [1= ]. > I did post one patch to phabrictor which got reviewed as well. >=20 > I had some queries in my mind on which I wanted some advice. > 1) Should I post another patch only after the first one has been approved > or is it better to keep posting patches irrespective of review status of > the first? It's fine to post multiple patches. If you have multiple patches that depend on each other you may find it useful to post both to let reviewers see the bigger picture. > 2) Should I ask commiters for review individually or should I post the li= nk > on the mailing lists? Or maybe should I simply wait for the patch to get > reviewed without informing anyone? Asking individual committers is a good approach if you can identify an active committers in the area. Mailing lists can also work. I don't recommend posting patching and hoping someone reviews them. That's all too likely to result in them being dropped. > 3) If the patch gets approved, do I need to submit a pul request on github > or is their some different procedure? If a patch is approved, you should ask the reviewer(s) to commit it. Can easily use "arc patch" to apply it and commit it. -- Brooks --KFztAG8eRSV9hGtP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJde6I2AAoJEKzQXbSebgfANTsH/i936fAJOUWM4tJRReB7hCl2 UGBsVwCdv1lVkS9W6ogMapzj+tglJqBVC60C+Jq/Qu8TpoSmPS6frcuSgZ6ulMyo uj7G0h6n+tqDAHJS5ZuyCiV/AD09BzOlEFHCwQkM9wNWRVlDVHjqL7CN3tTMTMhO Nib3tRwg9mO5ILo1k9Rt+gATJn+UzMNQ8FRAiXA2w9MjhKL0uGKPLXcQWUbcDcmS zOHDVes0f3TJa5dpcGqXmqndFeeJApqtN41VW2AKJ3Qh81kCZsOBzjsamXieeUiP XuZ0QtOjxNn/Df1BuInnTeAVpbC7BIP/3MgsJkpjYfrpL+ehbHI7Z79cAsS7HhA= =bk3w -----END PGP SIGNATURE----- --KFztAG8eRSV9hGtP-- From owner-freebsd-hackers@freebsd.org Sat Sep 14 05:08:36 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47B86DF2A6 for ; Sat, 14 Sep 2019 05:08:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46VgWl2bhHz4WJX for ; Sat, 14 Sep 2019 05:08:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x836.google.com with SMTP id n7so36584531qtb.6 for ; Fri, 13 Sep 2019 22:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sMk4s5+K/NrCXSQta4xceevmJWbNvDi9XWIbZT/XAMU=; b=zWBcmUAkfRyVyPHYBVPIav4xRbMVR8dneFhaZaMYtG3mlCnEDdt2vcHnT+7aoUaCOo 3xgSMuqiGt3QCiPp9OBZKNrr/IZRxRY3MkM3Hb5R9HKTIkYpUvV/pBeaJO0/GB/c09jR K+eiuAyRpBxBt4QVu2aNaozLuHmjI65wxv/Y9qpdUGP/xPDrOFk7fV0YiUiUSKt21Rjy SvBSIuDlC39Z3SoiCQby14T/eDSLTA2UTM7tgGiQLJTD8Y4jG02kKyovJ2KkIFz6hirP YjNHWUsd2tUj8MSlaQFl9qYfyrbVD0E96MywvO7eCDUiPcRUEGElOmBSjNDNUxZtebSn yDvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sMk4s5+K/NrCXSQta4xceevmJWbNvDi9XWIbZT/XAMU=; b=KVdgR06LVeOxDQdDmXGsc6H5De2xce2kMkE03yyyqerYqJ+7aVUOXXjT1P+YeJ2LN2 F7H8ex2aOZxvOsvPr1SCyqnkt7fLpqu8dEaNvazscJ3TKVKRdN8Nx60DiwBvUMkwMVLJ nCSw6yXMmEgbMaj88T/Ci6lhQuuL/JjHSIFdUMtWoy76QRjduHVcZwjblq0USGD5kYIo yvOwqDgsjxlJ8h/y4DUB3o7yevliLIIwRDT7BcfyGrGDUrRjrZtsaFWFLtPbq7YtOVup vAZgBIuZev+2yVbDBmSL44DB5MAgbMshs035RtgTIZyM4GMNg4EWSiaaVpUJRQhxGU0C 3pbQ== X-Gm-Message-State: APjAAAVcMtesg16JCnosX/KoM0OwMsE7uoJLu3YHGW4TIXZv/6DuKEop 0rYg2Y+bW1QgvzDa4SGsPG1SNBcPaATN1NuokVyRrBGBlxs= X-Google-Smtp-Source: APXvYqz+N2Zt9sxW/j6kDWEXDl3x0H3G3QPnyqtwB2k+ipxwjVU8NjG9Pf/M3Y64RVW1LPJU1ODjhHj1Fw0F95rUwT0= X-Received: by 2002:ac8:3564:: with SMTP id z33mr6913445qtb.291.1568437713831; Fri, 13 Sep 2019 22:08:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Warner Losh Date: Fri, 13 Sep 2019 23:08:22 -0600 Message-ID: Subject: Re: Problems with port of NVMe support To: Sebastian Huber Cc: FreeBSD Hackers X-Rspamd-Queue-Id: 46VgWl2bhHz4WJX X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=zWBcmUAk; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::836) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[6.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.85)[ip: (-9.26), ipnet: 2607:f8b0::/32(-2.70), asn: 15169(-2.24), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 05:08:36 -0000 On Fri, Sep 13, 2019, 12:02 AM Sebastian Huber < sebastian.huber@embedded-brains.de> wrote: > Hello, > > I port currently the NVMe support from FreeBSD to RTEMS. Basically, it > works. I can issue administration commands and some IO commands (e.g. > FLUSH). I use this SSD for testing: > > $ nvmecontrol identify nvme0 > Controller Capabilities/Features > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > Vendor ID: 8086 > Subsystem Vendor ID: 8086 > Serial Number: PHM27390006S280AGN > Model Number: INTEL SSDPE21D280GA > Firmware Version: E2010325 > Recommended Arb Burst: 0 > IEEE OUI Identifier: e4 d2 5c > Multi-Path I/O Capabilities: Not Supported > Max Data Transfer Size: 131072 > Controller ID: 0x0000 > Version: 0.0.0 > > My problem is now, that every WRITE transfer ends up in a DATA TRANSFER > ERROR: > > nvme0: WRITE sqid:1 cid:127 nsid:1 lba:0 len:8 > nvme0: DATA TRANSFER ERROR (00/04) sqid:1 cid:127 cdw0:0 > nvme0: async event occurred (type 0x0, info 0x04, page 0x01) > > Every READ transfer ends up in a UNRECOVERED READ ERROR: > > nvme0: READ sqid:1 cid:127 nsid:1 lba:0 len:8 > nvme0: UNRECOVERED READ ERROR (02/81) sqid:1 cid:127 cdw0:0 > nvme0: async event occurred (type 0x0, info 0x04, page 0x01) > > I see the transfers in the error log: > > $ nvmecontrol logpage -p 1 nvme0 > > > Error Information Log > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > Entry 01 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > Error count: 2546 > > > Submission queue ID: 1 > > > Command ID: 32512 > > > Status: > > > Phase tag: 0 > > > Status code: 129 > > > Status code type: 2 > > > More: 1 > > > DNR: 1 > > > Error location: 0 > > > LBA: 0 > > > Namespace ID: 1 > > > Vendor specific info: 0 > > > Transport type: 0 > > > Command specific info:0 > > > Transport specific: 0 > > > Entry 02 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D > > > Error count: 2545 > > > Submission queue ID: 1 > > > Command ID: 32512 > > > Status: > > > Phase tag: 0 > > > Status code: 4 > > > Status code type: 0 > > > More: 1 > > > DNR: 1 > > > Error location: 0 > > > LBA: 0 > > > Namespace ID: 1 > > > Vendor specific info: 0 > > > Transport type: 0 > > > Command specific info:0 > > > Transport specific: 0 > > From the NVMe specification I didn't get any hints what the error > reason could be. Maybe someone has a hint for me. The platform is a > T4240 PowerPC (big-endian). > Maybe the physaddr in the SG list for these commands doesn't translate right? Warner --=20 > Sebastian Huber, embedded brains GmbH > > Address : Dornierstr. 4, D-82178 Puchheim, Germany > Phone : +49 89 189 47 41-16 > Fax : +49 89 189 47 41-09 > E-Mail : sebastian.huber@embedded-brains.de > PGP : Public key available on request. > > Diese Nachricht ist keine gesch=C3=A4ftliche Mitteilung im Sinne des EHUG= . > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org= " >