From owner-freebsd-net@freebsd.org Sun Sep 15 02:18:24 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E2A4D963C for ; Sun, 15 Sep 2019 02:18:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WChw0ybmz3HcG for ; Sun, 15 Sep 2019 02:18:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 20ECBD963B; Sun, 15 Sep 2019 02:18:24 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20A43D9639 for ; Sun, 15 Sep 2019 02:18:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WChw054Gz3HcF for ; Sun, 15 Sep 2019 02:18:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DA68B1233 for ; Sun, 15 Sep 2019 02:18:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2INQW010365 for ; Sun, 15 Sep 2019 02:18:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2INZe010362 for net@FreeBSD.org; Sun, 15 Sep 2019 02:18:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 200185] [PATCH] Deprecate net.link.tap.user_open sysctl: opening by user is based on node permissions, no need for this variable Date: Sun, 15 Sep 2019 02:18:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kevans@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:18:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200185 Kyle Evans changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156767|0 |1 is obsolete| | --- Comment #6 from Kyle Evans --- Created attachment 207504 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207504&action= =3Dedit git(1) diff Attaching the route I'm planning to take after sorting out a method to mark this sysctl as deprecated beforehand in https://reviews.freebsd.org/D21662 = -- rip out the sysctl and add an option, TAP_OPEN_PRIVILEGED (OFF by default),= for letting interested parties re-enable super user policy on their kernel. Thi= s is a lightweight, low-maintenance option. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:29:12 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B382EDA5FA for ; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46WCxN4L4Kz3JSJ for ; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 94B24DA5F9; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94795DA5F7 for ; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WCxN3VQ9z3JSF for ; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5A7BB1417 for ; Sun, 15 Sep 2019 02:29:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2TCO4081182 for ; Sun, 15 Sep 2019 02:29:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2TClV081176 for net@FreeBSD.org; Sun, 15 Sep 2019 02:29:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 200185] if_tap: Deprecate net.link.tap.user_open sysctl Date: Sun, 15 Sep 2019 02:29:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: short_desc flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:29:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200185 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[PATCH] Deprecate |if_tap: Deprecate |net.link.tap.user_open |net.link.tap.user_open |sysctl: opening by user is |sysctl |based on node permissions, | |no need for this variable | Flags| |mfc-stable11?, | |mfc-stable12? --- Comment #7 from Kubilay Kocak --- Can/should this be merged or is is considered breaking (and relnotes) ? If not set mfc-stable* to - --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:30:17 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 92A8ADA7A5 for ; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WCyd3Kgmz3JYW for ; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 72389DA7A4; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71FFCDA7A3 for ; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WCyd2V18z3JYV for ; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3A4981425 for ; Sun, 15 Sep 2019 02:30:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2UHkA000566 for ; Sun, 15 Sep 2019 02:30:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2UHp9000560 for net@FreeBSD.org; Sun, 15 Sep 2019 02:30:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240539] tuntap: Getting "ifconfig: ioctl SIOCSIFNAME (set name): File exists" from `ifconfig tap create name tap0` Date: Sun, 15 Sep 2019 02:30:13 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:30:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240539 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|Closed |In Progress --- Comment #6 from Kubilay Kocak --- ^Triage: Remain in progress until MFC's complete (please reference PR:'s in commit message) --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:31:11 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D116ADAA23 for ; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46WCzg5Cccz3Jnc for ; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B2EB9DAA22; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2B32DAA21 for ; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WCzg4Kzkz3Jnb for ; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 785B1145D for ; Sun, 15 Sep 2019 02:31:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2VBTC020091 for ; Sun, 15 Sep 2019 02:31:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2VBIr020088 for net@FreeBSD.org; Sun, 15 Sep 2019 02:31:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240530] netgraph/ng_source: Allow ng_source to inject into any netgraph network Date: Sun, 15 Sep 2019 02:31:11 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: flagtypes.name bug_severity keywords bug_status cc short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:31:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240530 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |mfc-stable11?, | |mfc-stable12? Severity|Affects Only Me |Affects Some People Keywords|patch |needs-qa Status|New |Open CC| |net@FreeBSD.org Summary|Patch to allow ng_source to |netgraph/ng_source: Allow |inject into any netgraph |ng_source to inject into |network |any netgraph network --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:31:20 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AF42DAA70 for ; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WCzr28Lbz3JrV for ; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 47BDBDAA6F; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 47289DAA6E for ; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WCzr0ppRz3JrR for ; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 001CE1475 for ; Sun, 15 Sep 2019 02:31:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2VJN1023180 for ; Sun, 15 Sep 2019 02:31:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2VJrv023176 for net@FreeBSD.org; Sun, 15 Sep 2019 02:31:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240530] netgraph/ng_source: Allow ng_source to inject into any netgraph network Date: Sun, 15 Sep 2019 02:31:19 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: feature, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:31:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240530 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |feature --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:31:49 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8BBDDDAB7B for ; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46WD0P3FFxz3Jyt for ; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6F57ADAB7A; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6F20FDAB79 for ; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WD0P2R3Fz3Jys for ; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 387FC14A4 for ; Sun, 15 Sep 2019 02:31:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2Vnej038170 for ; Sun, 15 Sep 2019 02:31:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2VnkI038167 for net@FreeBSD.org; Sun, 15 Sep 2019 02:31:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 200185] if_tap: Deprecate net.link.tap.user_open sysctl Date: Sun, 15 Sep 2019 02:31:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: kevans@freebsd.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:31:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200185 --- Comment #8 from Kyle Evans --- (In reply to Kubilay Kocak from comment #7) Half of it gets MFC'd- the half where the sysctl gets marked as deprecated = to announce to anyone that views/tries to use it that it's deprecated. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:34:15 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 66A86DADC2 for ; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WD3C280Vz3K8d for ; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4983ADADC1; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 494E0DADC0 for ; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WD3C19bwz3K8c for ; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0C30615EF for ; Sun, 15 Sep 2019 02:34:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2YEgQ071288 for ; Sun, 15 Sep 2019 02:34:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2YEaj071287 for net@FreeBSD.org; Sun, 15 Sep 2019 02:34:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Sun, 15 Sep 2019 02:34:14 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: short_desc cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:34:15 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|jme NICs non functional |if_jme: Does not |after 11.2 to 12.0 upgrade |send/receive packets after | |11.2 to 12.0 upgrade CC| |net@FreeBSD.org --- Comment #4 from Kubilay Kocak --- (In reply to Armin Gruner from comment #3) Armin, could you please provide the following - uname -a output - /var/run/dmesg.boot output (as an attachment) - pciconf -lv output (as an attachment) --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 02:58:46 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 07427DC031 for ; Sun, 15 Sep 2019 02:58:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WDbT6TxPz3MWg for ; Sun, 15 Sep 2019 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id DEA51DC030; Sun, 15 Sep 2019 02:58:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DE700DC02F for ; Sun, 15 Sep 2019 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WDbT5dNtz3MWd for ; Sun, 15 Sep 2019 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A540E19C7 for ; Sun, 15 Sep 2019 02:58:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F2wjv5025805 for ; Sun, 15 Sep 2019 02:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F2wjMv025804 for net@FreeBSD.org; Sun, 15 Sep 2019 02:58:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 200185] if_tap: Deprecate net.link.tap.user_open sysctl Date: Sun, 15 Sep 2019 02:58:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 02:58:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200185 --- Comment #9 from Kubilay Kocak --- (In reply to Kyle Evans from comment #8) Roger that, thank you for clarifying --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 07:49:04 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D2B2AE4EE3 for ; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46WM2S5Fn8z45FH for ; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B290CE4EE1; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2544E4ED6 for ; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46WM2S4KLLz45FG for ; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 74E6F510D for ; Sun, 15 Sep 2019 07:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8F7n453079893 for ; Sun, 15 Sep 2019 07:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8F7n4xf079892 for net@FreeBSD.org; Sun, 15 Sep 2019 07:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 236394] gre(4): system crashes when deleting interfaces Date: Sun, 15 Sep 2019 07:49:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: crash, needs-qa, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: keywords bug_status cc short_desc flagtypes.name bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 07:49:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236394 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|panic |crash, needs-qa Status|New |Open CC| |ae@FreeBSD.org Summary|system crashes when |gre(4): system crashes when |deleting gre(4) interfaces |deleting interfaces Flags| |mfc-stable12? Severity|Affects Only Me |Affects Many People --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Sep 15 21:00:29 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A761EF7555 for ; Sun, 15 Sep 2019 21:00:29 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Whbd3lmYz3DTt for ; Sun, 15 Sep 2019 21:00:29 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7E07AF754D; Sun, 15 Sep 2019 21:00:29 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DA9AF754C for ; Sun, 15 Sep 2019 21:00:29 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Whbd244xz3DTg for ; Sun, 15 Sep 2019 21:00:29 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DDDE4DE25 for ; Sun, 15 Sep 2019 21:00:28 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8FL0SCK068984 for ; Sun, 15 Sep 2019 21:00:28 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8FL0SiL068977 for net@FreeBSD.org; Sun, 15 Sep 2019 21:00:28 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201909152100.x8FL0SiL068977@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: net@FreeBSD.org Subject: Problem reports for net@FreeBSD.org that need special attention Date: Sun, 15 Sep 2019 21:00:28 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2019 21:00:29 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 221146 | [ixgbe] Problem with second laggport In Progress | 235700 | oce(4) driver causes fatal trap 12 on boot with e New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 213410 | [carp] service netif restart causes hang only whe Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194485 | Userland cannot add IPv6 prefix routes Open | 200319 | Bridge+CARP crashes/freezes Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 222273 | igb(4): Kernel panic (fatal trap 12) due to netwo Open | 225438 | panic in6_unlink_ifa() due to race Open | 225792 | ECMP is broken since tryforward() Open | 227720 | Kernel panic in ppp server Open | 236888 | ppp daemon: Allow MTU to be overridden for PPPoE Open | 236983 | bnxt(4) VLAN not operational unless explicit "ifc Open | 237072 | netgraph(4): performance issue [on HardenedBSD]? Open | 237391 | route get returns no result for network addresses Open | 237840 | Removed dummynet dependency on ipfw Open | 238324 | Add XG-C100C/AQtion AQC107 10GbE NIC driver 19 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Sep 16 08:25:16 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE981F875C for ; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Wznm5Bb3z4KWf for ; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B2322F875B; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B1F8CF875A for ; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Wznm4MK7z4KWd for ; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 790321D8EF for ; Mon, 16 Sep 2019 08:25:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G8PG37000554 for ; Mon, 16 Sep 2019 08:25:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G8PGpo000553 for net@FreeBSD.org; Mon, 16 Sep 2019 08:25:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 232362] if_lagg(4)+if_vlan(4) panic: sleeping in an epoch section (igb, e1000_82575, actually 82576 in use) Date: Mon, 16 Sep 2019 08:25:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: IntelNetworking, crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bugzilla.freebsd@omnilan.de X-Bugzilla-Status: Closed X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 08:25:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232362 Harald Schmalzbauer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Open |Closed --- Comment #4 from Harald Schmalzbauer --- *** This bug has been marked as a duplicate of bug 240609 *** --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 09:34:53 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9FAC0FA1E8 for ; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46X1L53pFpz4NhH for ; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 82745FA1E6; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 823F0FA1E5 for ; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X1L52w9bz4NhF for ; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 433AE1E54A for ; Mon, 16 Sep 2019 09:34:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G9YrHF056674 for ; Mon, 16 Sep 2019 09:34:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G9YrFo056673 for net@FreeBSD.org; Mon, 16 Sep 2019 09:34:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240608] iflib: Panic with INVARIANTS: Memory modified after free (12.1-pre-QA) Date: Mon, 16 Sep 2019 09:34:51 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: short_desc flagtypes.name bug_status keywords assigned_to cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 09:34:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240608 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[iflib] [panic] with |iflib: Panic with |INVARIANTS: Memory modified |INVARIANTS: Memory modified |after free (12.1-pre-QA) |after free (12.1-pre-QA) Flags| |mfc-stable11?, | |mfc-stable12? Status|New |Open Keywords| |crash, needs-qa Assignee|bugs@FreeBSD.org |net@FreeBSD.org CC| |erj@freebsd.org, | |marius@FreeBSD.org, | |net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 09:36:35 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B9D5AFA2EB for ; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46X1N34ZcJz4NpH for ; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9B659FA2EA; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9B2BBFA2E9 for ; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X1N33gGYz4NpF for ; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5A7B81E54B for ; Mon, 16 Sep 2019 09:36:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G9aZTW058746 for ; Mon, 16 Sep 2019 09:36:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G9aZ1o058745 for net@FreeBSD.org; Mon, 16 Sep 2019 09:36:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240609] iflib: Ppanic with INVARIANTS: sleeping in an epoch section (12.1-pre-QA) (vlan + lagg involved) Date: Mon, 16 Sep 2019 09:36:35 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: cc flagtypes.name assigned_to keywords short_desc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 09:36:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240609 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |erj@freebsd.org, | |marius@FreeBSD.org, | |net@FreeBSD.org Flags| |mfc-stable11?, | |mfc-stable12? Assignee|bugs@FreeBSD.org |net@FreeBSD.org Keywords| |crash, needs-qa Summary|[iflib] [panic] with |iflib: Ppanic with |INVARIANTS: sleeping in an |INVARIANTS: sleeping in an |epoch section (12.1-pre-QA) |epoch section (12.1-pre-QA) |(vlan + lagg involved) |(vlan + lagg involved) Status|New |Open --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 09:36:52 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A25F6FA375 for ; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46X1NN3pYMz4NvR for ; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 82A20FA374; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 82688FA373 for ; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X1NN2xsKz4NvQ for ; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 486081E554 for ; Mon, 16 Sep 2019 09:36:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G9aqbP059082 for ; Mon, 16 Sep 2019 09:36:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G9aqmU059081 for net@FreeBSD.org; Mon, 16 Sep 2019 09:36:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240609] iflib: Panic with INVARIANTS: sleeping in an epoch section (12.1-pre-QA) (vlan + lagg involved) Date: Mon, 16 Sep 2019 09:36:52 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 09:36:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240609 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|iflib: Ppanic with |iflib: Panic with |INVARIANTS: sleeping in an |INVARIANTS: sleeping in an |epoch section (12.1-pre-QA) |epoch section (12.1-pre-QA) |(vlan + lagg involved) |(vlan + lagg involved) --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 09:37:50 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 51FF0FA496 for ; Mon, 16 Sep 2019 09:37:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46X1PV1VzGz4P1K for ; Mon, 16 Sep 2019 09:37:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 33B00FA490; Mon, 16 Sep 2019 09:37:50 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3374CFA48F for ; Mon, 16 Sep 2019 09:37:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X1PV0gVhz4P1H for ; Mon, 16 Sep 2019 09:37:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EF7651E55E for ; Mon, 16 Sep 2019 09:37:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G9bn7S060253 for ; Mon, 16 Sep 2019 09:37:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G9bnvD060252 for net@FreeBSD.org; Mon, 16 Sep 2019 09:37:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240610] iflib: Panic with INVARIANTS: general protection fault when kldunload'ing (12.1-pre-QA) Date: Mon, 16 Sep 2019 09:37:49 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: short_desc cc keywords flagtypes.name bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 09:37:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240610 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[iflib] [panic] with |iflib: Panic with |INVARIANTS: general |INVARIANTS: general |protection fault when |protection fault when |kldunloading (12.1-pre-QA) |kldunload'ing (12.1-pre-QA) CC| |erj@freebsd.org, | |marius@FreeBSD.org, | |net@FreeBSD.org Keywords| |crash, needs-qa Flags| |mfc-stable11?, | |mfc-stable12? Status|New |Open Assignee|bugs@FreeBSD.org |net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 09:43:06 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 00ED3FA7F0 for ; Mon, 16 Sep 2019 09:43:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46X1WY6HKcz4PSv for ; Mon, 16 Sep 2019 09:43:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D73ACFA7EF; Mon, 16 Sep 2019 09:43:05 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6FC9FA7EE for ; Mon, 16 Sep 2019 09:43:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X1WY4KRWz4PSs for ; Mon, 16 Sep 2019 09:43:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 785021E744 for ; Mon, 16 Sep 2019 09:43:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8G9h5PA077645 for ; Mon, 16 Sep 2019 09:43:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8G9h5pR077644 for net@FreeBSD.org; Mon, 16 Sep 2019 09:43:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240608] iflib: Panic with INVARIANTS: Memory modified after free (12.1-pre-QA) Date: Mon, 16 Sep 2019 09:43:04 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bugzilla.freebsd@omnilan.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 09:43:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240608 --- Comment #1 from Harald Schmalzbauer --- I guess this panic with an non-INVARIANTS kernel (wihtout any other debug OPTIONS) is related. This is happening quiet early after some traffic tests utilizing if_vmx(4). 12.1-prerelease without debug options: Fatal trap 12: page fault while in kernel mode=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 cpuid =3D 1; apic id =3D 01=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 fault virtual address =3D 0x0=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20 fault code =3D supervisor write data, page not present instruction pointer =3D 0x20:0xffffffff806ffdc2=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 stack pointer =3D 0x28:0xfffffe0040557900=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 frame pointer =3D 0x28:0xfffffe00405579e0=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 code segment =3D base 0x0, limit 0xfffff, type 0x1b=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 =3D DPL 0, pres 1, long 1, def32 0, gran 1=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20 processor eflags =3D interrupt enabled, resume, IOPL =3D 0=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 current process =3D 0 (if_io_tqg_1)=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20 trap number =3D 12=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20 panic: page fault=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 cpuid =3D 1=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 time =3D 1568626299=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 KDB: stack backtrace:=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 #0 0xffffffff8061f047 at kdb_backtrace+0x67=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20 #1 0xffffffff805d33bd at vpanic+0x19d=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 #2 0xffffffff805d3213 at panic+0x43=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 #3 0xffffffff80941d2c at trap_fatal+0x39c=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 #4 0xffffffff80941d79 at trap_pfault+0x49=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20 #5 0xffffffff8094136f at trap+0x29f=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20 #6 0xffffffff8091b92c at calltrap+0x8=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20 #7 0xffffffff8061d904 at gtaskqueue_run_locked+0x144 #8 0xffffffff8061d568 at gtaskqueue_thread_loop+0x98 #9 0xffffffff8059b103 at fork_exit+0x83 #10 0xffffffff8091c96e at fork_trampoline+0xe #3 0xffffffff805d3213 in panic (fmt=3D) at /usr/local/share/deploy-tools/RELENG_12/src/sys/kern/kern_shutdown.c:804 #4 0xffffffff80941d2c in trap_fatal (frame=3D, eva=3D= )=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 at /usr/local/share/deploy-tools/RELENG_12/src/sys/amd64/amd64/trap.c:9= 43=20=20=20 #5 0xffffffff80941d79 in trap_pfault (frame=3D0xfffffe0040557840, usermode= =3D0) at RELENG_12/src/sys/amd64/include/pcpu.h:234=20=20=20=20=20=20=20=20=20=20=20= =20=20 #6 0xffffffff8094136f in trap (frame=3D0xfffffe0040557840) at /usr/local/share/deploy-tools/RELENG_12/src/sys/amd64/amd64/trap.c:443=20= =20=20=20 #7 0xffffffff8091b92c in calltrap () at /usr/local/share/deploy-tools/RELENG_12/src/sys/amd64/amd64/exception.S:289= =20=20=20=20=20 #8 0xffffffff806ffdc2 in _task_fn_rx (context=3D)=20= =20=20=20=20=20=20=20=20=20=20 at /usr/local/share/deploy-tools/RELENG_12/src/sys/net/iflib.c:2614=20= =20=20=20=20=20=20=20=20 #9 0xffffffff8061d904 in gtaskqueue_run_locked (queue=3D0xfffff8000206c100= )=20=20=20=20=20=20 at /usr/local/share/deploy-tools/RELENG_12/src/sys/kern/subr_gtaskqueue.c:378= =20=20=20=20=20=20 #10 0xffffffff8061d568 in gtaskqueue_thread_loop (arg=3D)=20=20=20=20 at /usr/local/share/deploy-tools/RELENG_12/src/sys/kern/subr_gtaskqueue.c:559= =20=20=20=20=20=20 #11 0xffffffff8059b103 in fork_exit (callout=3D0xffffffff8061d4d0 , arg=3D0xfffffe00025fe020,=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20 frame=3D0xfffffe0040557ac0) at /usr/local/share/deploy-tools/RELENG_12/src/sys/kern/kern_fork.c:1065=20=20= =20=20=20=20=20=20=20=20=20 #12 0xffffffff8091c96e in fork_trampoline () at /usr/local/share/deploy-tools/RELENG_12/src/sys/amd64/amd64/exception.S:107= 7=20=20=20=20 #13 0x0000000000000000 in ?? () Thanks for any help, -harry --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Sep 16 12:32:39 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6E0F0FF3BC for ; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46X5HC2MNzz4Zw8 for ; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 51056FF3BB; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50CADFF3BA for ; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X5HC1WSDz4Zw7 for ; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1773920567 for ; Mon, 16 Sep 2019 12:32:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8GCWcuX055322 for ; Mon, 16 Sep 2019 12:32:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8GCWcYn055321 for net@FreeBSD.org; Mon, 16 Sep 2019 12:32:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 236394] gre(4): system crashes when deleting interfaces Date: Mon, 16 Sep 2019 12:32:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: crash, needs-qa, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 12:32:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D236394 --- Comment #4 from Andrey V. Elsukov --- I think this problem should be fixed in stable/12 after several epoch(9)- a= nd multicast-related fixes. Can you try stable/12? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 10:32:39 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0D30BFE6ED for ; Tue, 17 Sep 2019 10:32:39 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XfZG0gBcz3LVd for ; Tue, 17 Sep 2019 10:32:37 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd31.google.com with SMTP id f12so6239384iog.12 for ; Tue, 17 Sep 2019 03:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GOxBmchWnPLOtUTPIY4bzgwcwhfZ6kvArH45xPQy6Qs=; b=qqNhsCyoBZe7ycoxbRkZFV5P9I1MBU4LU+AI+X6mDqvmPbUFAkWkEuJLuVL5tN1eyy S9Si8LuEQBvEnDgsZZ2Kd0C6raiKB6BKOAi+H5Z9gNnePoFoEohS7K7aG/kalo2/TUys JP6Y5AO37XD7X9Gb5VIYuSLfTcF+NbOuHRHHqMedZmhK31NKizgYDvDWNj0W70fJnaIj p5cFsn2L0gKdaGXze40OlDvZhv+8T0QELdRz15nSLJvWZ3wEVd9bni+xzzjJeIiZ2x7w sZ73+k+XqQ1M0HDudwrfTStjNc+CBKwYZcRoyzBVRYlf0iwnCy2zPCeKAbYH8XqjMCj+ ZK8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GOxBmchWnPLOtUTPIY4bzgwcwhfZ6kvArH45xPQy6Qs=; b=JpXJCNXWrFPniiaNv6XP/hye0WZhYmX/nSf3MplpDgr0uLGZNMTIj04rA2uc2Xoh2X 5nZ10RYroxPidBEoWzfIpFH5or+RA6gefBLmDmcRcpJGNG3kpfxR+TRFrNehE8+y1NuD +4FLfu1Wew45eALDuzj2hl516a41iqQ4+R6sSMkmtcW8f5wNuMMHJUL4PPBe5lRLn9mc KY+l2oUcU/wR3naOjhq7bJh8/u+k1B+Df3pYmGaq8I4bljzptVYvzai44EFVMC38LMlL Wf5zkudJNMKA/QUpUMIe197XeqHRXlSNcNdPotBWvX2YbMZPo3eDSLs3i66l20s33fK8 yA8w== X-Gm-Message-State: APjAAAVw3FdLh8O3GArR0E+FgFquQ5wopPk9FnGCCtI4mAFc6shTgtV/ Sq1HqqsBBAq3MnNCHZtkabAnRaAiLd+LZ/Nk8Cc= X-Google-Smtp-Source: APXvYqyWExGHXmHFkhVwGIBCvwu9AcdpBIZ4XKr9LSvJDiLntzkbSFy6WIsvTNsTLxshRBh1liqHNhjmeEmqNPYKVuM= X-Received: by 2002:a6b:7a42:: with SMTP id k2mr2841467iop.303.1568716357291; Tue, 17 Sep 2019 03:32:37 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 03:32:25 -0700 Message-ID: Subject: Re: BBR patches? To: rrs@netflix.com Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46XfZG0gBcz3LVd X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=qqNhsCyo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d31 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-5.44), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 10:32:39 -0000 Hi Randall, Thanks for releasing BBR patch: https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq Could you please let me know what SVN/GIT label tag this is based on? I would like to patch and experiment with it. I couldn't find this info in the released patch. Thanks a lot! On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrote: > rrs@ has just posted the BBR patch to phabricator: > > https://reviews.freebsd.org/D21582 > From owner-freebsd-net@freebsd.org Tue Sep 17 12:39:53 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6A46122F21 for ; Tue, 17 Sep 2019 12:39:53 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XjP46ZH6z3y5X for ; Tue, 17 Sep 2019 12:39:52 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf1-x42b.google.com with SMTP id h195so2102566pfe.5 for ; Tue, 17 Sep 2019 05:39:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cUWzFxsAwnMKWgmcYJWjdj7YMVtQ5N0lQNWr9eZNsp0=; b=Zs/Xn++irMgJ3elp5fw0wrHnv+ethLLT+uwMBiWwKfMse2H9IVBxG+/2jTR/Q8phRD g1+3RIhcBq/5u9gW1RTpf2O/OFcUs+7Cky5Ga2DnN+FTfnVqTtnApQX/GIydy9TUxBVY gxI+0Xg/X2N3+gmdSW6Gm3HcnjVBgtiTBMebzCx3ZJr/9NXAyT8XmgZkAcJXGiHrIc00 tOzqv2erTCzZRqmD7Y7he2I1KW5w6aDbA1nEkiu4D6zbCoNTL5rO27YKsPhWTJtwioHo Cz21+RcORQO0TxxCWNFgY6MXt/csYy/1UriD72oJfB/vhEd7CY8F5Eor5jHFXsS87JJl w/fA== X-Gm-Message-State: APjAAAWC/Dxm2SCbbtVev4xpA5DPBA4y8Wmwd2JurElZIddRxX43hgrq JxHeGwjL9xId9kSOoYFL9GAGnw== X-Google-Smtp-Source: APXvYqwaQN716JY5ppN19dODN0ii0FPKMgmXw3+fIzxxjjdkv0+P1UT1NFnAlSrGRVKZSewlwJ2OTQ== X-Received: by 2002:a63:1f1b:: with SMTP id f27mr3047371pgf.233.1568723990421; Tue, 17 Sep 2019 05:39:50 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::b145? ([2607:fb10:7021:1::b145]) by smtp.gmail.com with ESMTPSA id i22sm2762704pfa.70.2019.09.17.05.39.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 05:39:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 05:39:48 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46XjP46ZH6z3y5X X-Spamd-Bar: -------------- X-Spamd-Result: default: False [-14.31 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[b.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.81)[ip: (-9.06), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 12:39:53 -0000 You should be able to compile it against the current head. I re-doing = that now (had an issue with my machine and had to roll it back to a backup). When I put the patch up on Sept 10th it complied with and without BBR on = whatever was that rev.. Looking in the commit logs that would have been around 352191 Hope that helps R > On Sep 17, 2019, at 3:32 AM, vm finance wrote: >=20 > Hi Randall, >=20 > Thanks for releasing BBR patch: > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 >=20 > Could you please let me know what SVN/GIT label tag this is based on? = I would like to patch and experiment with it. I couldn't find this info = in the released patch. >=20 > Thanks a lot!=20 >=20 > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrote: > rrs@ has just posted the BBR patch to phabricator: >=20 > https://reviews.freebsd.org/D21582 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Tue Sep 17 14:40:31 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9EB67125CC7 for ; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Xm4H3kY4z45WQ for ; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7E3F6125CC6; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E032125CC5 for ; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xm4H2l45z45WN for ; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 40FEA9D51 for ; Tue, 17 Sep 2019 14:40:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HEeVGv074237 for ; Tue, 17 Sep 2019 14:40:31 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HEeVWn074236 for net@FreeBSD.org; Tue, 17 Sep 2019 14:40:31 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 14:40:30 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 14:40:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #5 from Armin Gruner --- Sure: root@eeetop:~ # uname -a FreeBSD eeetop 12.0-RELEASE FreeBSD 12.0-RELEASE r341666 GENERIC amd64 Output of dmesg after boot and pciconf is attached; if I remove the disables from loader.conf, pciconf instead says "enabled" in the PCI device capability 11 of device jme0. Then, DHCP waits forever, and I don't see incoming packets, as described earlier. Cheers, Armin --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 14:41:11 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5D535125D30 for ; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Xm531r3yz45kg for ; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3EFE2125D2F; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3EC51125D2E for ; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xm530yqZz45kd for ; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 05E4D9D8E for ; Tue, 17 Sep 2019 14:41:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HEfAx7080719 for ; Tue, 17 Sep 2019 14:41:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HEfAqp080718 for net@FreeBSD.org; Tue, 17 Sep 2019 14:41:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 14:41:10 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 14:41:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #6 from Armin Gruner --- Created attachment 207576 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207576&action= =3Dedit dmesg.boot --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 14:41:36 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A07C7125DB4 for ; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Xm5X3qLHz45qh for ; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 83351125DB3; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 82FFB125DB2 for ; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xm5X2znmz45qg for ; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 49F2C9DBD for ; Tue, 17 Sep 2019 14:41:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HEfaN4083453 for ; Tue, 17 Sep 2019 14:41:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HEfaY7083452 for net@FreeBSD.org; Tue, 17 Sep 2019 14:41:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 14:41:35 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 14:41:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #7 from Armin Gruner --- Created attachment 207577 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207577&action= =3Dedit pciconf -l output --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 14:53:57 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 696EF12630B for ; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46XmMn2CJJz46j4 for ; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 49D2812630A; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 499AC126309 for ; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XmMn1D3Mz46j3 for ; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0D901A0F3 for ; Tue, 17 Sep 2019 14:53:57 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HErufL015840 for ; Tue, 17 Sep 2019 14:53:56 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HEru5O015839 for net@FreeBSD.org; Tue, 17 Sep 2019 14:53:56 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 14:53:56 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 14:53:57 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #8 from Armin Gruner --- BTW I know how to compile kernels; this box can be rebooted anytime, and I am happy to test snapshots (or build from 12-CURRENT, any git branch/tag, I sync with https://github.com/freebsd/freebsd.git After a quick glance into the kernel sources I see that there are changes in sys/dev/jme between stable/11 and master, though the diff is minimal. But the changes obviously affect programming the MSI/MSIX vectors.. If you like, I can just revert those changes and test with a newly built 12-HEAD kernel.. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 15:49:01 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB9EC127A75 for ; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46XnbK62Fkz49pN for ; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id CD47B127A73; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD100127A72 for ; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XnbK57NMz49pJ for ; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 90A11A9EC for ; Tue, 17 Sep 2019 15:49:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HFn17O027015 for ; Tue, 17 Sep 2019 15:49:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HFn1xk027014 for net@FreeBSD.org; Tue, 17 Sep 2019 15:49:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 15:49:00 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 15:49:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #9 from Armin Gruner --- > If you like, I can just revert those changes and test with a newly built = 12-HEAD kernel.. I answer myself: If I revert the changes in if_jme.c introduced between 11.3-RELEASE and 12.0-RELEASE, the jme0 ethernet interface is working again in 12.0-RELEASE --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 16:08:43 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 877591284AB for ; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Xp2337Hrz4C0x for ; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 68A591284AA; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 686B01284A9 for ; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xp2323dVz4C0v for ; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 29374AD75 for ; Tue, 17 Sep 2019 16:08:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HG8h1P075943 for ; Tue, 17 Sep 2019 16:08:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HG8hSh075942 for net@FreeBSD.org; Tue, 17 Sep 2019 16:08:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 16:08:42 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 16:08:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 Mark Johnston changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |markj@FreeBSD.org --- Comment #10 from Mark Johnston --- (In reply to Armin Gruner from comment #9) Can you narrow this down to a specific revision? --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 18:05:19 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4DAD912AB6C for ; Tue, 17 Sep 2019 18:05:19 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XrcY6xVvz4K2Z for ; Tue, 17 Sep 2019 18:05:17 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd32.google.com with SMTP id k5so9836063iol.5 for ; Tue, 17 Sep 2019 11:05:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sH4L8C0ZnviTcBG3aSQeaNa0cyHyIu2v4QGjxKcATjQ=; b=rqoDRxbSIpcKK6JNcKdyIHQbCRTpkfbSm2eUM8T29LOnWjCtGFinZRDxbGTcGE46qb Xsll3p1c8UfDpkaj033zpcONgyP62czEETR+k3nguYOzChudBZSeuvLUua83Ix3MYgao mNf6sh7pL0Lc48vLwJuOv0RodiHPiCtuK2L2dU4NQ+UFUpnBDUwqVk0kJEc/VIMxz8DC G1aFaR84/1q7wknHETrXYE9HWCUw/l/3SBFdolEvP4lrfTbqcpeMzDT2aM1tKSyd7ud1 xtNlnEalSWH6+XQAyS5HFvMyOyZ04uUT4Rab86tpGpEtU1VRgG5DDMwS2fazON+TGoil 9JIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sH4L8C0ZnviTcBG3aSQeaNa0cyHyIu2v4QGjxKcATjQ=; b=KXYLCTL9Mf6LEXnOIeVuvBa7CElKnoGh3kZ86wS2f9NyBnC1RTjg88OcaPttSj2FN5 Pj+MMyM0awB/+/qkYWM8AI2/B4D64RUilPMaG7F0plrLeZhz8F3NHkmMfXr5A+NNsoCw P0czMRVSmABIjkg1I2JIjqLcxHr+sLzqdM+rNFp2Fuilm97NxGJrt5esrtaQahOnywU2 sGLm1BGuJN2h5C9G5Ri3l0gAV6VpVF6Myk8HjVSM1AVbwWIeNpCIY1WlvMd4YknIe3cw ObxlT8BIDvvFIGCtF/JszBH1D+V51vZqYBrbedaolH2vQns+qx3TczXsbJ50uVaN2gDq dl+Q== X-Gm-Message-State: APjAAAWQ8EXKJJVDQ2YvmXkN18DkhbwLk3byu8z4pwJ7+O6ycTAkPJz9 p5fD57cRM2wcrQQFSnKYLu2OnivrhLpD3BEtO4s= X-Google-Smtp-Source: APXvYqzeMzuQtHOIJfXNxOkoReYk/2MLmfgvABa8lfvFBCHhEFASH/Y5U/Mms6KSgbe6DwLtrH2TF/bazoUWJjX09do= X-Received: by 2002:a02:ac82:: with SMTP id x2mr4413739jan.18.1568743516336; Tue, 17 Sep 2019 11:05:16 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 11:05:04 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46XrcY6xVvz4K2Z X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=rqoDRxbS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.46), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:05:19 -0000 Thanks Randall. I was able to apply the patch - now rebuilding the kernel. Would update on how it goes. BTW, is there any description on how lack of tc_fq under FreeBSD is compensated here? The original BBR patches on Linux show that as a must-have? Is that functionality implemented via tcp_ratelimit.[ch]? Any pointers to existing presentations/discussions highly appreciated? Thanks a lot. On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart wrote: > You should be able to compile it against the current head. I re-doing that > now (had an > issue with my machine and had to roll it back to a backup). > > When I put the patch up on Sept 10th it complied with and without BBR on > whatever > was that rev.. > > Looking in the commit logs that would have been around 352191 > > Hope that helps > > R > > > On Sep 17, 2019, at 3:32 AM, vm finance wrote: > > > > Hi Randall, > > > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > > Could you please let me know what SVN/GIT label tag this is based on? I > would like to patch and experiment with it. I couldn't find this info in > the released patch. > > > > Thanks a lot! > > > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrote: > > rrs@ has just posted the BBR patch to phabricator: > > > > https://reviews.freebsd.org/D21582 > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Tue Sep 17 18:27:33 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 36C8012B2EB for ; Tue, 17 Sep 2019 18:27:33 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Xs6D1Y4Dz4Vj5 for ; Tue, 17 Sep 2019 18:27:31 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x544.google.com with SMTP id i18so2432967pgl.11 for ; Tue, 17 Sep 2019 11:27:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8VCWUkkvxqKAf0XK37SN5yEXepzVqFlopI6ZVSVgw+s=; b=o6uek/zbLzCiEMXjPcH6l/70P5mYmxh+YGEx1Gj6ZbTNKE0t8GHcdeqaWt+CIN78S3 fmNyVqcBQLcBSP4Stt3TfQ/4faFceDtbxGjnZ75CJYoUmAiEV/pqI/1LJ46kw2/jJOA+ B+lGXdKGlhoAuNbtnhnmm8p8++J3Xo22tB1KCLyzuMa17gLwvpT4Yv5pBcIQHIJukbKJ 1NxNgKR/iTVHh9GNqTHtb8Ffqj+aRINpLvxMHENHtKUj1ryOC5yuEYT7ZqWqtzDPPW1L m4+U1+2CyVLd73U9EyQHPmOJg5ndkxf3XgwKXf15BF7nSZGGe/NUpJJR7xnzjDSBcEb8 +45A== X-Gm-Message-State: APjAAAU/PEudTl66rXGQIhvYTl6Bx3k0G9OMtcKpeLJZXx5XbKaIS1oP OAv382o93nrGUxRgZwN9/sOdVw== X-Google-Smtp-Source: APXvYqzvugMj9ZP/H3OOswR0X6ZcdO4hgZrwu3fbaGeT30zsS+lmet4S2KOwyCKHZ/FN40yF8IxmKw== X-Received: by 2002:a17:90a:9409:: with SMTP id r9mr6424891pjo.10.1568744850271; Tue, 17 Sep 2019 11:27:30 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::b145? ([2607:fb10:7021:1::b145]) by smtp.gmail.com with ESMTPSA id 127sm4610528pfy.56.2019.09.17.11.27.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 11:27:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 11:27:27 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46Xs6D1Y4Dz4Vj5 X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.54 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.04)[ip: (-0.22), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:27:33 -0000 Pacing is provided by tcp_hpts.c. The current linux patches do not have to have fq.. they built an alternate means of doing pacing into bbr. In either case our testing has shown that our pacing is more accurate = than either fq or the internal pacer :) R > On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >=20 > Thanks Randall. > I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. >=20 > BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? > The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? >=20 > Any pointers to existing presentations/discussions highly appreciated? >=20 > Thanks a lot. >=20 > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > You should be able to compile it against the current head. I re-doing = that now (had an > issue with my machine and had to roll it back to a backup). >=20 > When I put the patch up on Sept 10th it complied with and without BBR = on whatever > was that rev.. >=20 > Looking in the commit logs that would have been around 352191 >=20 > Hope that helps >=20 > R >=20 > > On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > >=20 > > Hi Randall, > >=20 > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 > >=20 > > Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. > >=20 > > Thanks a lot!=20 > >=20 > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > rrs@ has just posted the BBR patch to phabricator: > >=20 > > https://reviews.freebsd.org/D21582 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Tue Sep 17 18:36:45 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E164E12B827 for ; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46XsJs5grCz4XFp for ; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id C2D0A12B826; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C293612B825 for ; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XsJs4kQ3z4XFn for ; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 85B8118E79 for ; Tue, 17 Sep 2019 18:36:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HIajq6039069 for ; Tue, 17 Sep 2019 18:36:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HIajst039068 for net@FreeBSD.org; Tue, 17 Sep 2019 18:36:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 18:36:45 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:36:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #11 from Armin Gruner --- https://svnweb.freebsd.org/base?view=3Drevision&revision=3D316820 breaks it --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Sep 17 18:47:22 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3914812BC47 for ; Tue, 17 Sep 2019 18:47:22 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XsY51Tlgz4Xw8 for ; Tue, 17 Sep 2019 18:47:21 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2c.google.com with SMTP id r26so10058043ioh.8 for ; Tue, 17 Sep 2019 11:47:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ehebyxQbSMphs+8Ux6qXwme/XLGWRn4dhiwjyevXlUY=; b=DAhKksYReUbnvELrPd/cDlrcHvd7xuGEn2a+U0YMZWM2627HEIdzqvD+k+6gWHpgsK 6rT3hjrWectjxOHxEdcybOgliGOBB2M5eUK+FXDSWUuJoEc5i07tn4d8sm4OJ21jUMQN +QxOuJEi/1DFlMwMeG83MnSPCIpm88zlJmMH3aCiwYh5tDCsaxjUNqsfGHhWEIHAZWEI VdAtliLCBrrKgBsJVO5Agy3xzPpcj6SllexfBoxcC6TWxaNkuGKSkG2jpJR37n2e2eCq T2aiKZ4UiD5SR8xcRwKrmGiFxYpgIxXuZ+FPh+N9Ziwn70cfNmrrlV/dOCXBgkLO3WwN Eiww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehebyxQbSMphs+8Ux6qXwme/XLGWRn4dhiwjyevXlUY=; b=o0h8boz3lbmSX9mB8mQ+gE8hJFAdWIU36wjfzXZFMUJwo7LoeTGp51xQ3+6TEdEOEB 5/cTwOmisljQIfKWftLVHvabOabApb1oLo5fVi3KUZmV3dcpXs4deSPnjkCWDdc9ZLRq RU3SaLNfcmekovgnGnrQEmPCSoom0iTyz7mnfBpQ/W/47R2ZquYgy6h8OcU6JVAMmbuc ytxuak2H3XehKaegj9XDPX3hv9c7RWyUhN6yC2sZYVOA1UzBS1u/Pym2MbbWrF2vQZnv JS7KBxRIz4/d8hBcgsKHZuxwiG6VR2E7WxH3+3PKnKKMLgIv7mHnxHICG8TPSEAipLHX Tu8Q== X-Gm-Message-State: APjAAAW7q5azBOu0WdlH02rCYs7zFXmopT6+kFsbBi13tj43vIJPrYAp jt6aUITE8T3p5iK7tDSMtWj69Bdlv4wf2+Jrk9U= X-Google-Smtp-Source: APXvYqz3XtOle6ZixSpAVIaFC+aYNTPsadNo1vq9KINIi0xKMdVWLtqUTbKryU3Y/LRDyyhD0fHsE+pKjcYVXRRWQzg= X-Received: by 2002:a6b:2c8d:: with SMTP id s135mr252210ios.98.1568746040214; Tue, 17 Sep 2019 11:47:20 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 18:47:08 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46XsY51Tlgz4Xw8 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=DAhKksYR; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2c as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-5.37), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[c.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 18:47:22 -0000 Got it - thank you! btw, I tried to build the patch but its giving an error. Following is SVN info + make error mesg. Please let me know what am I missing here? Thanks! #svnlite revision Path: . Working Copy Root Path: /usr/src URL: svn://svn.freebsd.org/base/head Relative URL: ^/head Repository Root: svn://svn.freebsd.org/base Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f Revision: 352436 Node Kind: directory Schedule: normal Last Changed Author: jah Last Changed Rev: 352434 Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) root@osboxes:/usr/src # -------------------------------------------- snip ---------------------------- ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS ===> sys (cleandir) rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_kern_tls.h rm: x86: is a directory *** Error code 1 Stop. make[3]: stopped in /usr/src/sys *** Error code 1 Stop. make[2]: stopped in /usr/src *** Error code 1 Stop. make[1]: stopped in /usr/src *** Error code 1 Stop. make: stopped in /usr/src On Tue, Sep 17, 2019 at 6:41 PM vm finance wrote: > Got it - thank you! > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > I have also attached the entire build log...snippet is below > > Please let me know what am I missing here? > > Thanks! > > #svnlite revision > Path: . > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 352436 > Node Kind: directory > Schedule: normal > Last Changed Author: jah > Last Changed Rev: 352434 > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > root@osboxes:/usr/src # > > -------------------------------------------- snip > ---------------------------- > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > ===> sys (cleandir) > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > rm: x86: is a directory > *** Error code 1 > > Stop. > make[3]: stopped in /usr/src/sys > *** Error code 1 > > Stop. > make[2]: stopped in /usr/src > *** Error code 1 > > Stop. > make[1]: stopped in /usr/src > *** Error code 1 > > Stop. > make: stopped in /usr/src > > > On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrote: > >> Pacing is provided by tcp_hpts.c. The current linux patches do not have >> to have fq.. they built an alternate means of doing pacing into bbr. >> >> In either case our testing has shown that our pacing is more accurate than >> either fq or the internal pacer :) >> >> R >> >> > On Sep 17, 2019, at 11:05 AM, vm finance wrote: >> > >> > Thanks Randall. >> > I was able to apply the patch - now rebuilding the kernel. Would update >> on how it goes. >> > >> > BTW, is there any description on how lack of tc_fq under FreeBSD is >> compensated here? >> > The original BBR patches on Linux show that as a must-have? Is that >> functionality implemented via tcp_ratelimit.[ch]? >> > >> > Any pointers to existing presentations/discussions highly appreciated? >> > >> > Thanks a lot. >> > >> > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> > You should be able to compile it against the current head. I re-doing >> that now (had an >> > issue with my machine and had to roll it back to a backup). >> > >> > When I put the patch up on Sept 10th it complied with and without BBR >> on whatever >> > was that rev.. >> > >> > Looking in the commit logs that would have been around 352191 >> > >> > Hope that helps >> > >> > R >> > >> > > On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > >> > > Hi Randall, >> > > >> > > Thanks for releasing BBR patch: >> > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > >> > > Could you please let me know what SVN/GIT label tag this is based on? >> I would like to patch and experiment with it. I couldn't find this info in >> the released patch. >> > > >> > > Thanks a lot! >> > > >> > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > rrs@ has just posted the BBR patch to phabricator: >> > > >> > > https://reviews.freebsd.org/D21582 >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Tue Sep 17 20:11:03 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E234412D9D6 for ; Tue, 17 Sep 2019 20:11:03 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XvPg19Hyz4dfj for ; Tue, 17 Sep 2019 20:11:02 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x542.google.com with SMTP id a24so2587501pgj.2 for ; Tue, 17 Sep 2019 13:11:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=yphOu6ZqIKjZE8bB/zEEzYmgdwjwL/i5NyzCu4mnVRA=; b=pnovXUvx/E35Qylo/9KUnHip/3/h7SY3+zoAgydWjDeHzB0dQeXOd7oNi2ERQxajKG 3Ls471knaj+wFQwsG+ojnw3VLJKMSsOkg6l6kJWaWpMBADLvT91DrZp+yiUgdAn/bjey KUcNw/In7FNXARxb7NjvCXTi5OkQwxISo2sx1QtFSTXIiwxYiXxmHHIYoOPflYDQzq2Y 1OVxMq3r8u0raedSOpP8mP2tJWHlaJqUz1jGEYWHPcgPrpHRTttyLIeSYbUk1jeoszWU nN9VfqsS+tELzasnvha+BtUZQfpE7kRbRJks6YwGnaYyF0JaNwHlRZkOBd4iQ3TZaTuG 8e3g== X-Gm-Message-State: APjAAAVD7wZMoOsVj3p5hgjv83UzDcIcLjWV6PuMIAmkd5JejKXVTLML iAKLLMw7ey5ll8DK28VlVCALPg== X-Google-Smtp-Source: APXvYqyWyIN3NUeWZ/MCFvAJzoAn+SGcK1/ZR6cYz+v9uABfWdqJbOsc+DZQtWa6PoS5cXFqd2D3iQ== X-Received: by 2002:a63:fc19:: with SMTP id j25mr574294pgi.175.1568751061126; Tue, 17 Sep 2019 13:11:01 -0700 (PDT) Received: from [192.168.242.134] (soln-sr3455.solutionip.com. [70.233.112.2]) by smtp.gmail.com with ESMTPSA id z14sm2881050pgj.22.2019.09.17.13.11.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 13:11:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 13:10:11 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46XvPg19Hyz4dfj X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[2.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.10)[ip: (-0.54), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 20:11:03 -0000 Hmm Did you get the patch I updated too this am? I have built it both with and without the bbr stack and had no issue.. = there was an issue with KTLS before the update though. I don=E2=80=99t recognize what you have below there though=E2=80=A6 R > On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >=20 > Got it - thank you! >=20 > btw, I tried to build the patch but its giving an error. Following is = SVN info + make error mesg. >=20 > Please let me know what am I missing here? >=20 > Thanks! >=20 > #svnlite revision > Path: . > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 352436 > Node Kind: directory > Schedule: normal > Last Changed Author: jah > Last Changed Rev: 352434 > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >=20 > root@osboxes:/usr/src # >=20 > -------------------------------------------- snip = ---------------------------- >=20 > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > =3D=3D=3D> sys (cleandir) > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h > rm: x86: is a directory > *** Error code 1 >=20 > Stop. > make[3]: stopped in /usr/src/sys > *** Error code 1 >=20 > Stop. > make[2]: stopped in /usr/src > *** Error code 1 >=20 > Stop. > make[1]: stopped in /usr/src > *** Error code 1 >=20 > Stop. > make: stopped in /usr/src >=20 >=20 > On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > Got it - thank you! >=20 > btw, I tried to build the patch but its giving an error. Following is = SVN info + make error mesg. > I have also attached the entire build log...snippet is below >=20 > Please let me know what am I missing here? >=20 > Thanks! >=20 > #svnlite revision > Path: . > Working Copy Root Path: /usr/src > URL: svn://svn.freebsd.org/base/head > Relative URL: ^/head > Repository Root: svn://svn.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 352436 > Node Kind: directory > Schedule: normal > Last Changed Author: jah > Last Changed Rev: 352434 > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >=20 > root@osboxes:/usr/src # >=20 > -------------------------------------------- snip = ---------------------------- >=20 > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > =3D=3D=3D> sys (cleandir) > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h > rm: x86: is a directory > *** Error code 1 >=20 > Stop. > make[3]: stopped in /usr/src/sys > *** Error code 1 >=20 > Stop. > make[2]: stopped in /usr/src > *** Error code 1 >=20 > Stop. > make[1]: stopped in /usr/src > *** Error code 1 >=20 > Stop. > make: stopped in /usr/src >=20 >=20 > On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > Pacing is provided by tcp_hpts.c. The current linux patches do not = have > to have fq.. they built an alternate means of doing pacing into bbr. >=20 > In either case our testing has shown that our pacing is more accurate = than > either fq or the internal pacer :) >=20 > R >=20 > > On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > >=20 > > Thanks Randall. > > I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. > >=20 > > BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? > > The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? > >=20 > > Any pointers to existing presentations/discussions highly = appreciated? > >=20 > > Thanks a lot. > >=20 > > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > > You should be able to compile it against the current head. I = re-doing that now (had an > > issue with my machine and had to roll it back to a backup). > >=20 > > When I put the patch up on Sept 10th it complied with and without = BBR on whatever > > was that rev.. > >=20 > > Looking in the commit logs that would have been around 352191 > >=20 > > Hope that helps > >=20 > > R > >=20 > > > On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > > >=20 > > > Hi Randall, > > >=20 > > > Thanks for releasing BBR patch: > > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 > > >=20 > > > Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. > > >=20 > > > Thanks a lot!=20 > > >=20 > > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > > rrs@ has just posted the BBR patch to phabricator: > > >=20 > > > https://reviews.freebsd.org/D21582 > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Tue Sep 17 20:11:40 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1006912DB5B for ; Tue, 17 Sep 2019 20:11:40 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XvQM4C8Nz4dm8 for ; Tue, 17 Sep 2019 20:11:39 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf1-x442.google.com with SMTP id q12so2777019pff.9 for ; Tue, 17 Sep 2019 13:11:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=eu/cHKrhkZtsvny4f0yUeH/uE9UvxGr/LvM5UqxkbRM=; b=I+RewEIXJqveb5q/lz+8yykKqGQl3PjRZkFdJYwTprf67td75+4D+hSfVBmupWEiYa Oyjbhe6R8hjjjq/FXsjAET7vPMVNuOnwXVV1eo9qSdsd3K6NaBSV24ISg9bXMA7kXopf OsSaU6o0AZ6izgv5Nsil2edlj38q/yfqW2Y+O/l6VfRo+IPbPFQI/dp6RCu+/QlrWeq9 mfbRs1zofgoWcRIrEBasOcbjqHyAc/14TphmvGdp6XUMeSd+4B9PnIJ7pCkPxpIQ1jY7 vnv+N1huCJ7L07HfaDn1DFSEESa1u2VS7XMRvMsPCV73yyf9ZnPO1kvsnC0JJp0jsCoM BxnA== X-Gm-Message-State: APjAAAWnsgIWNw6r8m12ye2bEyL2RVAr1MNvZ2I9qOtNjMfN7Fr0Xc+G 783jEeqoC1fKbtuExeaNiIxq7g== X-Google-Smtp-Source: APXvYqyjbd2YgPgpX94OsZuHV9Mr4kaG1Z9Ae9MwE69PpONkUEEpLU5UWnLwHAaOgfRp0pc49BxWfw== X-Received: by 2002:a62:5fc1:: with SMTP id t184mr171388pfb.84.1568751098230; Tue, 17 Sep 2019 13:11:38 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::b145? ([2607:fb10:7021:1::b145]) by smtp.gmail.com with ESMTPSA id v12sm5932892pgr.31.2019.09.17.13.11.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 13:11:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 13:11:41 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46XvQM4C8Nz4dm8 X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[2.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.10)[ip: (-0.52), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 20:11:40 -0000 looking I was at 352408.. let me update and try it R > On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >=20 > Hmm >=20 > Did you get the patch I updated too this am? >=20 > I have built it both with and without the bbr stack and had no issue.. = there was > an issue with KTLS before the update though. >=20 > I don=E2=80=99t recognize what you have below there though=E2=80=A6 >=20 > R >=20 >> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>=20 >> Got it - thank you! >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN info + make error mesg. >>=20 >> Please let me know what am I missing here? >>=20 >> Thanks! >>=20 >> #svnlite revision >> Path: . >> Working Copy Root Path: /usr/src >> URL: svn://svn.freebsd.org/base/head >> Relative URL: ^/head >> Repository Root: svn://svn.freebsd.org/base >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> Revision: 352436 >> Node Kind: directory >> Schedule: normal >> Last Changed Author: jah >> Last Changed Rev: 352434 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >> root@osboxes:/usr/src # >>=20 >> -------------------------------------------- snip = ---------------------------- >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> =3D=3D=3D> sys (cleandir) >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h >> rm: x86: is a directory >> *** Error code 1 >>=20 >> Stop. >> make[3]: stopped in /usr/src/sys >> *** Error code 1 >>=20 >> Stop. >> make[2]: stopped in /usr/src >> *** Error code 1 >>=20 >> Stop. >> make[1]: stopped in /usr/src >> *** Error code 1 >>=20 >> Stop. >> make: stopped in /usr/src >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >> Got it - thank you! >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN info + make error mesg. >> I have also attached the entire build log...snippet is below >>=20 >> Please let me know what am I missing here? >>=20 >> Thanks! >>=20 >> #svnlite revision >> Path: . >> Working Copy Root Path: /usr/src >> URL: svn://svn.freebsd.org/base/head >> Relative URL: ^/head >> Repository Root: svn://svn.freebsd.org/base >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> Revision: 352436 >> Node Kind: directory >> Schedule: normal >> Last Changed Author: jah >> Last Changed Rev: 352434 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >> root@osboxes:/usr/src # >>=20 >> -------------------------------------------- snip = ---------------------------- >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> =3D=3D=3D> sys (cleandir) >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h >> rm: x86: is a directory >> *** Error code 1 >>=20 >> Stop. >> make[3]: stopped in /usr/src/sys >> *** Error code 1 >>=20 >> Stop. >> make[2]: stopped in /usr/src >> *** Error code 1 >>=20 >> Stop. >> make[1]: stopped in /usr/src >> *** Error code 1 >>=20 >> Stop. >> make: stopped in /usr/src >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >> to have fq.. they built an alternate means of doing pacing into bbr. >>=20 >> In either case our testing has shown that our pacing is more accurate = than >> either fq or the internal pacer :) >>=20 >> R >>=20 >>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>>=20 >>> Thanks Randall. >>> I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. >>>=20 >>> BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? >>> The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? >>>=20 >>> Any pointers to existing presentations/discussions highly = appreciated? >>>=20 >>> Thanks a lot. >>>=20 >>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>> You should be able to compile it against the current head. I = re-doing that now (had an >>> issue with my machine and had to roll it back to a backup). >>>=20 >>> When I put the patch up on Sept 10th it complied with and without = BBR on whatever >>> was that rev.. >>>=20 >>> Looking in the commit logs that would have been around 352191 >>>=20 >>> Hope that helps >>>=20 >>> R >>>=20 >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>>>=20 >>>> Hi Randall, >>>>=20 >>>> Thanks for releasing BBR patch: >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 >>>>=20 >>>> Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. >>>>=20 >>>> Thanks a lot!=20 >>>>=20 >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>>> rrs@ has just posted the BBR patch to phabricator: >>>>=20 >>>> https://reviews.freebsd.org/D21582 >>>=20 >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Tue Sep 17 20:33:13 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5CDD12E48D for ; Tue, 17 Sep 2019 20:33:13 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XvvD6RTXz4g25 for ; Tue, 17 Sep 2019 20:33:12 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf1-x443.google.com with SMTP id q10so2838804pfl.0 for ; Tue, 17 Sep 2019 13:33:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=kde6dLPnaUlY+DSdc+g1drPeaGnYEYOYENCRUd2z3gk=; b=sUhKfb4dJNOB+OANtPd7uSoDkI1uFzeag5WAo60sxAM/9aaM5emNzx7fPwrAmHQbB+ KiiX+I/mgPZKBIrry4437KwUOZ1vC3f1uUqEDO7A18vKGhB50LAKN9X5FvxdNdirK9I8 ks6iMxIGrlTq+fDyt/SCzDtIX+V2IRuKhWRWFy2gxFzzS+zrImRo/ufS1EUosezQO7WA Mp9sUZtErmFZAl2sy4AMlDXPkIDXXq4dftlHX3MCKGLYA/oSxmgixq17ZkKL2XC/GfvH hdeMyjRwPA543mh7aK0w0/TGG8Riz7GA+n4ob9t8zkmbe+0gvLTNYrzf7f4xJHnbaJeG QmRg== X-Gm-Message-State: APjAAAV48AGVYYxpiJQtVsn5FKAPKj6It2RUUWNTqNHSUCYAyFrDMccV s/6b5an6Nm/CATfwQaSpd8spZw== X-Google-Smtp-Source: APXvYqyWYn/bQV4hHqqNKr4Vk9jhGpKNsnQpIRZb2p9gc8ngdfW20uXzi50kJQyhcJS75/RsXIKXpg== X-Received: by 2002:a63:2f44:: with SMTP id v65mr657416pgv.380.1568752390965; Tue, 17 Sep 2019 13:33:10 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::b145? ([2607:fb10:7021:1::b145]) by smtp.gmail.com with ESMTPSA id x10sm5104371pfr.44.2019.09.17.13.33.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 13:33:10 -0700 (PDT) From: Randall Stewart Message-Id: <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_84E6C64B-3295-49FB-B7C7-5989CAFAE422" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? Date: Tue, 17 Sep 2019 13:33:08 -0700 In-Reply-To: Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net To: vm finance References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46XvvD6RTXz4g25 X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.59 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~,3:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.09)[ip: (-0.46), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 20:33:13 -0000 --Apple-Mail=_84E6C64B-3295-49FB-B7C7-5989CAFAE422 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Looking at your make file log I can=E2=80=99t really tell what you are = doing. Its not the BBR or Rack code that is blowing up=E2=80=A6=20 Are you cross compiling? I have done the old fashioned kernel make i.e.=20 cd src/sys/amd64/config config headvm cd ../compile/headvm make cleandepend ; make depend; make -j3 I have done cd src make buildkernel KERNCONF=3Dheadvm And even make buildkernel KERNCONF=3DGENERIC to make sure that the build works without bbr. I attach my headvm config.. What exactly are you building and how? kernel config too please? R --Apple-Mail=_84E6C64B-3295-49FB-B7C7-5989CAFAE422 Content-Disposition: attachment; filename=headvm Content-Type: application/octet-stream; x-unix-mode=0644; name="headvm" Content-Transfer-Encoding: 7bit # # GENERIC -- Generic kernel configuration file for FreeBSD/amd64 # # For more information on this file, please read the config(5) manual page, # and/or the handbook section on Kernel Configuration Files: # # http://www.FreeBSD.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig-config.html # # The handbook is also available locally in /usr/share/doc/handbook # if you've installed the doc distribution, otherwise always see the # FreeBSD World Wide Web server (http://www.FreeBSD.org/) for the # latest information. # # An exhaustive list of options and more detailed explanations of the # device lines is also present in the ../../conf/NOTES and NOTES files. # If you are in doubt as to the purpose or necessity of a line, check first # in NOTES. # # $FreeBSD$ include GENERIC ident GENERIC-NODEBUG nooptions VIMAGE #nooptions INVARIANTS #nooptions INVARIANT_SUPPORT #nooptions WITNESS #nooptions WITNESS_SKIPSPIN #nooptions BUF_TRACKING #nooptions DEADLKRES #nooptions FULL_BUF_TRACKING nooptions VIMAGE makeoptions WITH_EXTRA_TCP_STACKS=1 options TCPHPTS options KERN_TLS options RATELIMIT --Apple-Mail=_84E6C64B-3295-49FB-B7C7-5989CAFAE422 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >=20 > looking >=20 > I was at 352408.. let me update and try it >=20 > R >=20 >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >>=20 >> Hmm >>=20 >> Did you get the patch I updated too this am? >>=20 >> I have built it both with and without the bbr stack and had no = issue.. there was >> an issue with KTLS before the update though. >>=20 >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>=20 >> R >>=20 >>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>>=20 >>> Got it - thank you! >>>=20 >>> btw, I tried to build the patch but its giving an error. Following = is SVN info + make error mesg. >>>=20 >>> Please let me know what am I missing here? >>>=20 >>> Thanks! >>>=20 >>> #svnlite revision >>> Path: . >>> Working Copy Root Path: /usr/src >>> URL: svn://svn.freebsd.org/base/head >>> Relative URL: ^/head >>> Repository Root: svn://svn.freebsd.org/base >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> Revision: 352436 >>> Node Kind: directory >>> Schedule: normal >>> Last Changed Author: jah >>> Last Changed Rev: 352434 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>=20 >>> root@osboxes:/usr/src # >>>=20 >>> -------------------------------------------- snip = ---------------------------- >>>=20 >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> =3D=3D=3D> sys (cleandir) >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h >>> rm: x86: is a directory >>> *** Error code 1 >>>=20 >>> Stop. >>> make[3]: stopped in /usr/src/sys >>> *** Error code 1 >>>=20 >>> Stop. >>> make[2]: stopped in /usr/src >>> *** Error code 1 >>>=20 >>> Stop. >>> make[1]: stopped in /usr/src >>> *** Error code 1 >>>=20 >>> Stop. >>> make: stopped in /usr/src >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >>> Got it - thank you! >>>=20 >>> btw, I tried to build the patch but its giving an error. Following = is SVN info + make error mesg. >>> I have also attached the entire build log...snippet is below >>>=20 >>> Please let me know what am I missing here? >>>=20 >>> Thanks! >>>=20 >>> #svnlite revision >>> Path: . >>> Working Copy Root Path: /usr/src >>> URL: svn://svn.freebsd.org/base/head >>> Relative URL: ^/head >>> Repository Root: svn://svn.freebsd.org/base >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> Revision: 352436 >>> Node Kind: directory >>> Schedule: normal >>> Last Changed Author: jah >>> Last Changed Rev: 352434 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>=20 >>> root@osboxes:/usr/src # >>>=20 >>> -------------------------------------------- snip = ---------------------------- >>>=20 >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> =3D=3D=3D> sys (cleandir) >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h >>> rm: x86: is a directory >>> *** Error code 1 >>>=20 >>> Stop. >>> make[3]: stopped in /usr/src/sys >>> *** Error code 1 >>>=20 >>> Stop. >>> make[2]: stopped in /usr/src >>> *** Error code 1 >>>=20 >>> Stop. >>> make[1]: stopped in /usr/src >>> *** Error code 1 >>>=20 >>> Stop. >>> make: stopped in /usr/src >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >>> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >>> to have fq.. they built an alternate means of doing pacing into bbr. >>>=20 >>> In either case our testing has shown that our pacing is more = accurate than >>> either fq or the internal pacer :) >>>=20 >>> R >>>=20 >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>>>=20 >>>> Thanks Randall. >>>> I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. >>>>=20 >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is = compensated here? >>>> The original BBR patches on Linux show that as a must-have? Is that = functionality implemented via tcp_ratelimit.[ch]? >>>>=20 >>>> Any pointers to existing presentations/discussions highly = appreciated? >>>>=20 >>>> Thanks a lot. >>>>=20 >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>>> You should be able to compile it against the current head. I = re-doing that now (had an >>>> issue with my machine and had to roll it back to a backup). >>>>=20 >>>> When I put the patch up on Sept 10th it complied with and without = BBR on whatever >>>> was that rev.. >>>>=20 >>>> Looking in the commit logs that would have been around 352191 >>>>=20 >>>> Hope that helps >>>>=20 >>>> R >>>>=20 >>>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>>>>=20 >>>>> Hi Randall, >>>>>=20 >>>>> Thanks for releasing BBR patch: >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 >>>>>=20 >>>>> Could you please let me know what SVN/GIT label tag this is based = on? I would like to patch and experiment with it. I couldn't find this = info in the released patch. >>>>>=20 >>>>> Thanks a lot!=20 >>>>>=20 >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>>>> rrs@ has just posted the BBR patch to phabricator: >>>>>=20 >>>>> https://reviews.freebsd.org/D21582 >>>>=20 >>>> ------ >>>> Randall Stewart >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>=20 >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com --Apple-Mail=_84E6C64B-3295-49FB-B7C7-5989CAFAE422-- From owner-freebsd-net@freebsd.org Tue Sep 17 20:51:43 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5E4912ECC5 for ; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46XwJb4tltz4h6S for ; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A7B8312ECC4; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A77C612ECC3 for ; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46XwJb40RGz4h6Q for ; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6DF641A852 for ; Tue, 17 Sep 2019 20:51:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8HKphsH081992 for ; Tue, 17 Sep 2019 20:51:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8HKphsf081988 for net@FreeBSD.org; Tue, 17 Sep 2019 20:51:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Tue, 17 Sep 2019 20:51:43 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: needs-qa, regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: markj@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2019 20:51:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #12 from Mark Johnston --- (In reply to Armin Gruner from comment #11) I can't see a problem in that commit, and I haven't been able to find a programmer reference for the jmicron controllers with a quick search. Linux doesn't attempt to map the interrupt sources at all. I suspect that we sho= uld simply revert the change for 12.1. --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Sep 18 02:20:49 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0CE9EE30C for ; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Y3cK5DXKz3DBY for ; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B378BEE30B; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B33ECEE30A for ; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y3cK4MPdz3DBV for ; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 79C4B1E232 for ; Wed, 18 Sep 2019 02:20:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8I2Kn9J004825 for ; Wed, 18 Sep 2019 02:20:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8I2KnRW004778 for net@FreeBSD.org; Wed, 18 Sep 2019 02:20:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Wed, 18 Sep 2019 02:20:47 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: keywords bug_severity flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 02:20:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs-qa | Severity|Affects Some People |Affects Many People Flags|mfc-stable11? |maintainer-feedback?(yongar | |i@FreeBSD.org) --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Sep 18 02:26:48 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D1B10EE511 for ; Wed, 18 Sep 2019 02:26:48 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y3lC63K3z3DS9 for ; Wed, 18 Sep 2019 02:26:47 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id r26so12453275ioh.8 for ; Tue, 17 Sep 2019 19:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lG3Kej9wTp0Z+Jgn6wAUIVZsDGOSRZsNV0V1wuLAHv4=; b=cuyxfh1UVjlapZ+ZINASaWoj4ACIzvXPKhTsJkvinZ/UINAgn02E0IjKs0HaT7oiZf DrVOjoa8502+u/KY6LUegleZHslUDZnUWSRoC50g6sPtoquw3NFs+bBzo0FTDBp8rMMi 5EtLwTn/T0sJL3fWYzWCK9N+dfUkLKqwgQ+ZT32WC6CMex53Qq90DRpyaGv1QzyQv8YE 9OhMHWdV3OCHM908v6qtTc0JXcStwj/TVfVHji1049dxJ0h41yvDmeVQlLOYsIcsPDzu dFw6XITfnxLbh1pVnPMM96h9IzbrjzkLhrMIjn+2MzA6OUcwec9fkzgkR3JzESMOvxYL ydng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lG3Kej9wTp0Z+Jgn6wAUIVZsDGOSRZsNV0V1wuLAHv4=; b=QfAWzndJCdvXW7wuIi9/xCRASNJjBblEuE9WIcGBHd0qJdmaJFGYw0kDykEhhoWAx4 1aX3ENh7tlg1rP21oKtiith/YQvzsvg0hyJYIawExXlg//USRiX97bN4ljwyz4Gdrwgz fqPxmdMFdn32/NqV+7ijfDeIXxraVZI822+klJq1HO9aGFoC2dR5TZt6tURfBIC5PrKL 6g4ESfLx6urKbYrTppxPrCNoNdnIZF4Wvbfgf78rulYbpt284jqPnNPVY20y6BnINEOU D9q7ari83eaxwq1spFbXvx6ZjvWv82WJCttTllEtEKlsZr3lOtwcw3jiXR9ZGN2M57y5 rIyQ== X-Gm-Message-State: APjAAAVjwx9CYCbAqHYqWNR1yqViSLcTmKOp2k+rU6oA9ZHYBi4UHlVC tmvioLzc+/sP1mmQu0SkI88utUIFr8hC8nwS9cCrsTJ8tHQ= X-Google-Smtp-Source: APXvYqz7STa0GhXBuv37CxaMlNoq43HSVK3WYk++byqkEaXAWiijIrQq1mClS9XPRliv2KvWMhEDAZD42FaWuKZ5UDQ= X-Received: by 2002:a6b:7a42:: with SMTP id k2mr2503994iop.303.1568773606160; Tue, 17 Sep 2019 19:26:46 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> In-Reply-To: <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> From: vm finance Date: Tue, 17 Sep 2019 19:26:34 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46Y3lC63K3z3DS9 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=cuyxfh1U; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d43 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[15]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (2.08), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 02:26:48 -0000 Hi Randall, Could you please provide a pointer to the latest patch. I had applied the one you published Sep-10. Following is what I have done: 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org 2. Got VM up under VMPlayer on x86 laptop 3. Checked out latest codebase from freebsd repo: svn co svn://svn.freebsd.org/base/head /usr/src* cd /usr/src; make buildworld buildkernel [this is where make fails when patch is applied] I could try to build with your latest patch - please send me a pointer. Thanks for your help! On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: > Looking at your make file log I can=E2=80=99t really tell what you are do= ing. > > Its not the BBR or Rack code that is blowing up=E2=80=A6 > > Are you cross compiling? > > I have done the old fashioned kernel make > > i.e. > > cd src/sys/amd64/config > config headvm > cd ../compile/headvm > > make cleandepend ; make depend; make -j3 > > I have done > > cd src > make buildkernel KERNCONF=3Dheadvm > > And even > > make buildkernel KERNCONF=3DGENERIC > > to make sure that the build works without bbr. > > I attach my headvm config.. > > What exactly are you building and how? kernel config too please? > > R > > > > > > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: > > > > looking > > > > I was at 352408.. let me update and try it > > > > R > > > >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: > >> > >> Hmm > >> > >> Did you get the patch I updated too this am? > >> > >> I have built it both with and without the bbr stack and had no issue.. > there was > >> an issue with KTLS before the update though. > >> > >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 > >> > >> R > >> > >>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > >>> > >>> Got it - thank you! > >>> > >>> btw, I tried to build the patch but its giving an error. Following is > SVN info + make error mesg. > >>> > >>> Please let me know what am I missing here? > >>> > >>> Thanks! > >>> > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>> > >>> root@osboxes:/usr/src # > >>> > >>> -------------------------------------------- snip > ---------------------------- > >>> > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make: stopped in /usr/src > >>> > >>> > >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance > wrote: > >>> Got it - thank you! > >>> > >>> btw, I tried to build the patch but its giving an error. Following is > SVN info + make error mesg. > >>> I have also attached the entire build log...snippet is below > >>> > >>> Please let me know what am I missing here? > >>> > >>> Thanks! > >>> > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>> > >>> root@osboxes:/usr/src # > >>> > >>> -------------------------------------------- snip > ---------------------------- > >>> > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>> > >>> Stop. > >>> make: stopped in /usr/src > >>> > >>> > >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart > wrote: > >>> Pacing is provided by tcp_hpts.c. The current linux patches do not ha= ve > >>> to have fq.. they built an alternate means of doing pacing into bbr. > >>> > >>> In either case our testing has shown that our pacing is more accurate > than > >>> either fq or the internal pacer :) > >>> > >>> R > >>> > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > >>>> > >>>> Thanks Randall. > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on how it goes. > >>>> > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is > compensated here? > >>>> The original BBR patches on Linux show that as a must-have? Is that > functionality implemented via tcp_ratelimit.[ch]? > >>>> > >>>> Any pointers to existing presentations/discussions highly appreciate= d? > >>>> > >>>> Thanks a lot. > >>>> > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart > wrote: > >>>> You should be able to compile it against the current head. I re-doin= g > that now (had an > >>>> issue with my machine and had to roll it back to a backup). > >>>> > >>>> When I put the patch up on Sept 10th it complied with and without BB= R > on whatever > >>>> was that rev.. > >>>> > >>>> Looking in the commit logs that would have been around 352191 > >>>> > >>>> Hope that helps > >>>> > >>>> R > >>>> > >>>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > >>>>> > >>>>> Hi Randall, > >>>>> > >>>>> Thanks for releasing BBR patch: > >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > >>>>> > >>>>> Could you please let me know what SVN/GIT label tag this is based > on? I would like to patch and experiment with it. I couldn't find this in= fo > in the released patch. > >>>>> > >>>>> Thanks a lot! > >>>>> > >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > >>>>> rrs@ has just posted the BBR patch to phabricator: > >>>>> > >>>>> https://reviews.freebsd.org/D21582 > >>>> > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>> > >>> ------ > >>> Randall Stewart > >>> rrs@netflix.com > >>> > >>> > >>> > >> > >> ------ > >> Randall Stewart > >> rrs@netflix.com > >> > >> > >> > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Wed Sep 18 02:44:57 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 193FAEED31 for ; Wed, 18 Sep 2019 02:44:57 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y48831WVz3FCG for ; Wed, 18 Sep 2019 02:44:56 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd44.google.com with SMTP id d17so12486031ios.13 for ; Tue, 17 Sep 2019 19:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4r4NHdVQVdiystY6bjia2LP2HXfkyiQKmU5sX+opVt8=; b=Jftc/sdI+v5c2qAeXd45gTIj6lsJtaCOmOxO+2AwThtAjsKOiEIZClzH8d1B0zEgUT NI4tjWPj6/HA9MrykS7sqbGx7aAeeXs7F0azztVDFJ4+ZGgC103Jde2HRYn5vF/NzXmS oPrcZKYgPw/iNETBat/4N5jbV7TAYogrvEsik2rXKxIk/AA8IlBKTiN+gBDbvUTxBwnx qks4i/L/xcKS2PW7kwFCIyEXtgGtD+dyQVdYFMWPgMVH0hdEAEFrKfKPA2dWUAWwkHgR vsSRCOZmYd1ZYggiH/Da3i7HtIDIADXg4PjSsshOz9m+ixw5a2QDhmw8fJq8RC1/S00D OWdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4r4NHdVQVdiystY6bjia2LP2HXfkyiQKmU5sX+opVt8=; b=BL0YwUMSeQbEDTYT791RvGfN+HRjWjDbMgDQGj3wdLKaExrZZQ5awbLDiwbYLsBD4q FmmSMmnkk91FIjxOaJ3RWBTNNUdiJHZZbBtsFGkufyohLZaMbNo09UU+/l6dGHyJfg/C VmVj6I5vdojMBHQFTbtlrg85YIefJnV7ARIdX6yZrSVLNdwijJqJt/3DWogpOyMZXhCo uRhLoY1HC/GmCKFCtZAbr7SjH9XWfdff6Qj15seNOatV0JNW3x1bF2qkDnRDE64cXwp9 tqBKbopjy++PAAxCNa+MWl8mXtq06msxZr9Y5lp8/Ch6O0wi2+uhFEvyBHuz8ykIzIQw LAyQ== X-Gm-Message-State: APjAAAUYW7fy2EqrCm6XdsMfVKT87bV3xop9vnh+KCbyaFb0L3kQ+UCF Ye0NFsDVs+2zSd8AHiIQFnNq6SNKl4v2j1lPkZVHPjf/ X-Google-Smtp-Source: APXvYqx8S2bPaq0yzvsBF0M51JqAWBXJXunvRy6b50ABtHvExpZ9RWMIB2goASx49GC08+BcCXHjnDmqmLxKEk1M0Fo= X-Received: by 2002:a5e:da0a:: with SMTP id x10mr2769951ioj.286.1568774224715; Tue, 17 Sep 2019 19:37:04 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 23:36:50 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Type: multipart/mixed; boundary="00000000000065de770592cab622" X-Rspamd-Queue-Id: 46Y48831WVz3FCG X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Jftc/sdI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d44 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [10.49 / 15.00]; GREYLIST(0.00)[pass,body]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[multipart/mixed,multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[0.996,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[0.998,0]; RCVD_IN_DNSWL_NONE(0.00)[4.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (2.29), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 02:44:57 -0000 --00000000000065de770592cab622 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable My Kernel config is attached here. Thanks! On Wed, Sep 18, 2019 at 2:26 AM vm finance wrote: > Hi Randall, > > Could you please provide a pointer to the latest patch. I had applied the > one you published Sep-10. > > Following is what I have done: > 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > 2. Got VM up under VMPlayer on x86 laptop > 3. Checked out latest codebase from freebsd repo: > svn co svn://svn.freebsd.org/base/head /usr/src* > cd /usr/src; > make buildworld buildkernel > [this is where make fails when patch is applied] > > I could try to build with your latest patch - please send me a pointer. > > Thanks for your help! > > > On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: > >> Looking at your make file log I can=E2=80=99t really tell what you are d= oing. >> >> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> >> Are you cross compiling? >> >> I have done the old fashioned kernel make >> >> i.e. >> >> cd src/sys/amd64/config >> config headvm >> cd ../compile/headvm >> >> make cleandepend ; make depend; make -j3 >> >> I have done >> >> cd src >> make buildkernel KERNCONF=3Dheadvm >> >> And even >> >> make buildkernel KERNCONF=3DGENERIC >> >> to make sure that the build works without bbr. >> >> I attach my headvm config.. >> >> What exactly are you building and how? kernel config too please? >> >> R >> >> >> >> >> > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >> > >> > looking >> > >> > I was at 352408.. let me update and try it >> > >> > R >> > >> >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >> >> >> >> Hmm >> >> >> >> Did you get the patch I updated too this am? >> >> >> >> I have built it both with and without the bbr stack and had no issue.= . >> there was >> >> an issue with KTLS before the update though. >> >> >> >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >> >> >> >> R >> >> >> >>> On Sep 17, 2019, at 11:47 AM, vm finance >> wrote: >> >>> >> >>> Got it - thank you! >> >>> >> >>> btw, I tried to build the patch but its giving an error. Following i= s >> SVN info + make error mesg. >> >>> >> >>> Please let me know what am I missing here? >> >>> >> >>> Thanks! >> >>> >> >>> #svnlite revision >> >>> Path: . >> >>> Working Copy Root Path: /usr/src >> >>> URL: svn://svn.freebsd.org/base/head >> >>> Relative URL: ^/head >> >>> Repository Root: svn://svn.freebsd.org/base >> >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> >>> Revision: 352436 >> >>> Node Kind: directory >> >>> Schedule: normal >> >>> Last Changed Author: jah >> >>> Last Changed Rev: 352434 >> >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> >>> >> >>> root@osboxes:/usr/src # >> >>> >> >>> -------------------------------------------- snip >> ---------------------------- >> >>> >> >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >> >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> >>> =3D=3D=3D> sys (cleandir) >> >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h opt_kern_tls.h >> >>> rm: x86: is a directory >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[3]: stopped in /usr/src/sys >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[2]: stopped in /usr/src >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[1]: stopped in /usr/src >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make: stopped in /usr/src >> >>> >> >>> >> >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance >> wrote: >> >>> Got it - thank you! >> >>> >> >>> btw, I tried to build the patch but its giving an error. Following i= s >> SVN info + make error mesg. >> >>> I have also attached the entire build log...snippet is below >> >>> >> >>> Please let me know what am I missing here? >> >>> >> >>> Thanks! >> >>> >> >>> #svnlite revision >> >>> Path: . >> >>> Working Copy Root Path: /usr/src >> >>> URL: svn://svn.freebsd.org/base/head >> >>> Relative URL: ^/head >> >>> Repository Root: svn://svn.freebsd.org/base >> >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> >>> Revision: 352436 >> >>> Node Kind: directory >> >>> Schedule: normal >> >>> Last Changed Author: jah >> >>> Last Changed Rev: 352434 >> >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> >>> >> >>> root@osboxes:/usr/src # >> >>> >> >>> -------------------------------------------- snip >> ---------------------------- >> >>> >> >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo >> >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> >>> =3D=3D=3D> sys (cleandir) >> >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h opt_kern_tls.h >> >>> rm: x86: is a directory >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[3]: stopped in /usr/src/sys >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[2]: stopped in /usr/src >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make[1]: stopped in /usr/src >> >>> *** Error code 1 >> >>> >> >>> Stop. >> >>> make: stopped in /usr/src >> >>> >> >>> >> >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart >> wrote: >> >>> Pacing is provided by tcp_hpts.c. The current linux patches do not >> have >> >>> to have fq.. they built an alternate means of doing pacing into bbr. >> >>> >> >>> In either case our testing has shown that our pacing is more accurat= e >> than >> >>> either fq or the internal pacer :) >> >>> >> >>> R >> >>> >> >>>> On Sep 17, 2019, at 11:05 AM, vm finance >> wrote: >> >>>> >> >>>> Thanks Randall. >> >>>> I was able to apply the patch - now rebuilding the kernel. Would >> update on how it goes. >> >>>> >> >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is >> compensated here? >> >>>> The original BBR patches on Linux show that as a must-have? Is that >> functionality implemented via tcp_ratelimit.[ch]? >> >>>> >> >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> >>>> >> >>>> Thanks a lot. >> >>>> >> >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> >>>> You should be able to compile it against the current head. I >> re-doing that now (had an >> >>>> issue with my machine and had to roll it back to a backup). >> >>>> >> >>>> When I put the patch up on Sept 10th it complied with and without >> BBR on whatever >> >>>> was that rev.. >> >>>> >> >>>> Looking in the commit logs that would have been around 352191 >> >>>> >> >>>> Hope that helps >> >>>> >> >>>> R >> >>>> >> >>>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> >>>>> >> >>>>> Hi Randall, >> >>>>> >> >>>>> Thanks for releasing BBR patch: >> >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> >>>>> >> >>>>> Could you please let me know what SVN/GIT label tag this is based >> on? I would like to patch and experiment with it. I couldn't find this i= nfo >> in the released patch. >> >>>>> >> >>>>> Thanks a lot! >> >>>>> >> >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> >>>>> rrs@ has just posted the BBR patch to phabricator: >> >>>>> >> >>>>> https://reviews.freebsd.org/D21582 >> >>>> >> >>>> ------ >> >>>> Randall Stewart >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>> >> >>> ------ >> >>> Randall Stewart >> >>> rrs@netflix.com >> >>> >> >>> >> >>> >> >> >> >> ------ >> >> Randall Stewart >> >> rrs@netflix.com >> >> >> >> >> >> >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> --00000000000065de770592cab622 Content-Type: application/octet-stream; name=MYKERNEL Content-Disposition: attachment; filename=MYKERNEL Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0oh840h0 IwojIEdFTkVSSUMgLS0gR2VuZXJpYyBrZXJuZWwgY29uZmlndXJhdGlvbiBmaWxlIGZvciBGcmVl QlNEL2FtZDY0CiMKIyBGb3IgbW9yZSBpbmZvcm1hdGlvbiBvbiB0aGlzIGZpbGUsIHBsZWFzZSBy ZWFkIHRoZSBjb25maWcoNSkgbWFudWFsIHBhZ2UsCiMgYW5kL29yIHRoZSBoYW5kYm9vayBzZWN0 aW9uIG9uIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGVzOgojCiMgICAgaHR0cHM6Ly93d3cuRnJl ZUJTRC5vcmcvZG9jL2VuX1VTLklTTzg4NTktMS9ib29rcy9oYW5kYm9vay9rZXJuZWxjb25maWct Y29uZmlnLmh0bWwKIwojIFRoZSBoYW5kYm9vayBpcyBhbHNvIGF2YWlsYWJsZSBsb2NhbGx5IGlu IC91c3Ivc2hhcmUvZG9jL2hhbmRib29rCiMgaWYgeW91J3ZlIGluc3RhbGxlZCB0aGUgZG9jIGRp c3RyaWJ1dGlvbiwgb3RoZXJ3aXNlIGFsd2F5cyBzZWUgdGhlCiMgRnJlZUJTRCBXb3JsZCBXaWRl IFdlYiBzZXJ2ZXIgKGh0dHBzOi8vd3d3LkZyZWVCU0Qub3JnLykgZm9yIHRoZQojIGxhdGVzdCBp bmZvcm1hdGlvbi4KIwojIEFuIGV4aGF1c3RpdmUgbGlzdCBvZiBvcHRpb25zIGFuZCBtb3JlIGRl dGFpbGVkIGV4cGxhbmF0aW9ucyBvZiB0aGUKIyBkZXZpY2UgbGluZXMgaXMgYWxzbyBwcmVzZW50 IGluIHRoZSAuLi8uLi9jb25mL05PVEVTIGFuZCBOT1RFUyBmaWxlcy4KIyBJZiB5b3UgYXJlIGlu IGRvdWJ0IGFzIHRvIHRoZSBwdXJwb3NlIG9yIG5lY2Vzc2l0eSBvZiBhIGxpbmUsIGNoZWNrIGZp cnN0CiMgaW4gTk9URVMuCiMKIyAkRnJlZUJTRDogaGVhZC9zeXMvYW1kNjQvY29uZi9HRU5FUklD IDM0OTI1MyAyMDE5LTA2LTIxIDAwOjE2OjMwWiBjZW0gJAoKY3B1CQlIQU1NRVIKaWRlbnQJCUdF TkVSSUMKCm1ha2VvcHRpb25zCURFQlVHPS1nCQkjIEJ1aWxkIGtlcm5lbCB3aXRoIGdkYigxKSBk ZWJ1ZyBzeW1ib2xzCm1ha2VvcHRpb25zCVdJVEhfQ1RGPTEJCSMgUnVuIGN0ZmNvbnZlcnQoMSkg Zm9yIERUcmFjZSBzdXBwb3J0CgpvcHRpb25zIAlTQ0hFRF9VTEUJCSMgVUxFIHNjaGVkdWxlcgpv cHRpb25zIAlOVU1BCQkJIyBOb24tVW5pZm9ybSBNZW1vcnkgQXJjaGl0ZWN0dXJlIHN1cHBvcnQK b3B0aW9ucyAJUFJFRU1QVElPTgkJIyBFbmFibGUga2VybmVsIHRocmVhZCBwcmVlbXB0aW9uCm9w dGlvbnMgCVZJTUFHRQkJCSMgU3Vic3lzdGVtIHZpcnR1YWxpemF0aW9uLCBlLmcuIFZORVQKb3B0 aW9ucyAJSU5FVAkJCSMgSW50ZXJORVR3b3JraW5nCm9wdGlvbnMgCUlORVQ2CQkJIyBJUHY2IGNv bW11bmljYXRpb25zIHByb3RvY29scwpvcHRpb25zIAlJUFNFQ19TVVBQT1JUCQkjIEFsbG93IGts ZGxvYWQgb2YgaXBzZWMgYW5kIHRjcG1kNQpvcHRpb25zIAlUQ1BfT0ZGTE9BRAkJIyBUQ1Agb2Zm bG9hZApvcHRpb25zIAlUQ1BfQkxBQ0tCT1gJCSMgRW5oYW5jZWQgVENQIGV2ZW50IGxvZ2dpbmcK b3B0aW9ucyAJVENQX0hIT09LCQkjIGhob29rKDkpIGZyYW1ld29yayBmb3IgVENQCm9wdGlvbnMJ CVRDUF9SRkM3NDEzCQkjIFRDUCBGYXN0IE9wZW4Kb3B0aW9ucyAJU0NUUAkJCSMgU3RyZWFtIENv bnRyb2wgVHJhbnNtaXNzaW9uIFByb3RvY29sCm9wdGlvbnMgCUZGUwkJCSMgQmVya2VsZXkgRmFz dCBGaWxlc3lzdGVtCm9wdGlvbnMgCVNPRlRVUERBVEVTCQkjIEVuYWJsZSBGRlMgc29mdCB1cGRh dGVzIHN1cHBvcnQKb3B0aW9ucyAJVUZTX0FDTAkJCSMgU3VwcG9ydCBmb3IgYWNjZXNzIGNvbnRy b2wgbGlzdHMKb3B0aW9ucyAJVUZTX0RJUkhBU0gJCSMgSW1wcm92ZSBwZXJmb3JtYW5jZSBvbiBi aWcgZGlyZWN0b3JpZXMKb3B0aW9ucyAJVUZTX0dKT1VSTkFMCQkjIEVuYWJsZSBnam91cm5hbC1i YXNlZCBVRlMgam91cm5hbGluZwpvcHRpb25zIAlRVU9UQQkJCSMgRW5hYmxlIGRpc2sgcXVvdGFz IGZvciBVRlMKb3B0aW9ucyAJTURfUk9PVAkJCSMgTUQgaXMgYSBwb3RlbnRpYWwgcm9vdCBkZXZp Y2UKb3B0aW9ucyAJTkZTQ0wJCQkjIE5ldHdvcmsgRmlsZXN5c3RlbSBDbGllbnQKb3B0aW9ucyAJ TkZTRAkJCSMgTmV0d29yayBGaWxlc3lzdGVtIFNlcnZlcgpvcHRpb25zIAlORlNMT0NLRAkJIyBO ZXR3b3JrIExvY2sgTWFuYWdlcgpvcHRpb25zIAlORlNfUk9PVAkJIyBORlMgdXNhYmxlIGFzIC8s IHJlcXVpcmVzIE5GU0NMCm9wdGlvbnMgCU1TRE9TRlMJCQkjIE1TRE9TIEZpbGVzeXN0ZW0Kb3B0 aW9ucyAJQ0Q5NjYwCQkJIyBJU08gOTY2MCBGaWxlc3lzdGVtCm9wdGlvbnMgCVBST0NGUwkJCSMg UHJvY2VzcyBmaWxlc3lzdGVtIChyZXF1aXJlcyBQU0VVRE9GUykKb3B0aW9ucyAJUFNFVURPRlMJ CSMgUHNldWRvLWZpbGVzeXN0ZW0gZnJhbWV3b3JrCm9wdGlvbnMgCUdFT01fUkFJRAkJIyBTb2Z0 IFJBSUQgZnVuY3Rpb25hbGl0eS4Kb3B0aW9ucyAJR0VPTV9MQUJFTAkJIyBQcm92aWRlcyBsYWJl bGl6YXRpb24Kb3B0aW9ucyAJRUZJUlQJCQkjIEVGSSBSdW50aW1lIFNlcnZpY2VzIHN1cHBvcnQK b3B0aW9ucyAJQ09NUEFUX0ZSRUVCU0QzMgkjIENvbXBhdGlibGUgd2l0aCBpMzg2IGJpbmFyaWVz Cm9wdGlvbnMgCUNPTVBBVF9GUkVFQlNENAkJIyBDb21wYXRpYmxlIHdpdGggRnJlZUJTRDQKb3B0 aW9ucyAJQ09NUEFUX0ZSRUVCU0Q1CQkjIENvbXBhdGlibGUgd2l0aCBGcmVlQlNENQpvcHRpb25z IAlDT01QQVRfRlJFRUJTRDYJCSMgQ29tcGF0aWJsZSB3aXRoIEZyZWVCU0Q2Cm9wdGlvbnMgCUNP TVBBVF9GUkVFQlNENwkJIyBDb21wYXRpYmxlIHdpdGggRnJlZUJTRDcKb3B0aW9ucyAJQ09NUEFU X0ZSRUVCU0Q5CQkjIENvbXBhdGlibGUgd2l0aCBGcmVlQlNEOQpvcHRpb25zIAlDT01QQVRfRlJF RUJTRDEwCSMgQ29tcGF0aWJsZSB3aXRoIEZyZWVCU0QxMApvcHRpb25zIAlDT01QQVRfRlJFRUJT RDExCSMgQ29tcGF0aWJsZSB3aXRoIEZyZWVCU0QxMQpvcHRpb25zIAlDT01QQVRfRlJFRUJTRDEy CSMgQ29tcGF0aWJsZSB3aXRoIEZyZWVCU0QxMgpvcHRpb25zIAlTQ1NJX0RFTEFZPTUwMDAJCSMg RGVsYXkgKGluIG1zKSBiZWZvcmUgcHJvYmluZyBTQ1NJCm9wdGlvbnMgCUtUUkFDRQkJCSMga3Ry YWNlKDEpIHN1cHBvcnQKb3B0aW9ucyAJU1RBQ0sJCQkjIHN0YWNrKDkpIHN1cHBvcnQKb3B0aW9u cyAJU1lTVlNITQkJCSMgU1lTVi1zdHlsZSBzaGFyZWQgbWVtb3J5Cm9wdGlvbnMgCVNZU1ZNU0cJ CQkjIFNZU1Ytc3R5bGUgbWVzc2FnZSBxdWV1ZXMKb3B0aW9ucyAJU1lTVlNFTQkJCSMgU1lTVi1z dHlsZSBzZW1hcGhvcmVzCm9wdGlvbnMgCV9LUE9TSVhfUFJJT1JJVFlfU0NIRURVTElORyAjIFBP U0lYIFAxMDAzXzFCIHJlYWwtdGltZSBleHRlbnNpb25zCm9wdGlvbnMgCVBSSU5URl9CVUZSX1NJ WkU9MTI4CSMgUHJldmVudCBwcmludGYgb3V0cHV0IGJlaW5nIGludGVyc3BlcnNlZC4Kb3B0aW9u cyAJS0JEX0lOU1RBTExfQ0RFVgkjIGluc3RhbGwgYSBDREVWIGVudHJ5IGluIC9kZXYKb3B0aW9u cyAJSFdQTUNfSE9PS1MJCSMgTmVjZXNzYXJ5IGtlcm5lbCBob29rcyBmb3IgaHdwbWMoNCkKb3B0 aW9ucyAJQVVESVQJCQkjIFNlY3VyaXR5IGV2ZW50IGF1ZGl0aW5nCm9wdGlvbnMgCUNBUEFCSUxJ VFlfTU9ERQkJIyBDYXBzaWN1bSBjYXBhYmlsaXR5IG1vZGUKb3B0aW9ucyAJQ0FQQUJJTElUSUVT CQkjIENhcHNpY3VtIGNhcGFiaWxpdGllcwpvcHRpb25zIAlNQUMJCQkjIFRydXN0ZWRCU0QgTUFD IEZyYW1ld29yawpvcHRpb25zIAlLRFRSQUNFX0ZSQU1FCQkjIEVuc3VyZSBmcmFtZXMgYXJlIGNv bXBpbGVkIGluCm9wdGlvbnMgCUtEVFJBQ0VfSE9PS1MJCSMgS2VybmVsIERUcmFjZSBob29rcwpv cHRpb25zIAlEREJfQ1RGCQkJIyBLZXJuZWwgRUxGIGxpbmtlciBsb2FkcyBDVEYgZGF0YQpvcHRp b25zIAlJTkNMVURFX0NPTkZJR19GSUxFCSMgSW5jbHVkZSB0aGlzIGZpbGUgaW4ga2VybmVsCm9w dGlvbnMgCVJBQ0NUCQkJIyBSZXNvdXJjZSBhY2NvdW50aW5nIGZyYW1ld29yawpvcHRpb25zIAlS QUNDVF9ERUZBVUxUX1RPX0RJU0FCTEVEICMgU2V0IGtlcm4ucmFjY3QuZW5hYmxlPTAgYnkgZGVm YXVsdApvcHRpb25zIAlSQ1RMCQkJIyBSZXNvdXJjZSBsaW1pdHMKCiMgRGVidWdnaW5nIHN1cHBv cnQuICBBbHdheXMgbmVlZCB0aGlzOgpvcHRpb25zIAlLREIJCQkjIEVuYWJsZSBrZXJuZWwgZGVi dWdnZXIgc3VwcG9ydC4Kb3B0aW9ucyAJS0RCX1RSQUNFCQkjIFByaW50IGEgc3RhY2sgdHJhY2Ug Zm9yIGEgcGFuaWMuCiMgRm9yIGZ1bGwgZGVidWdnZXIgc3VwcG9ydCB1c2UgKHR1cm4gb2ZmIGlu IHN0YWJsZSBicmFuY2gpOgpvcHRpb25zIAlCVUZfVFJBQ0tJTkcJCSMgVHJhY2sgYnVmZmVyIGhp c3RvcnkKb3B0aW9ucyAJRERCCQkJIyBTdXBwb3J0IEREQi4Kb3B0aW9ucyAJRlVMTF9CVUZfVFJB Q0tJTkcJIyBUcmFjayBtb3JlIGJ1ZmZlciBoaXN0b3J5Cm9wdGlvbnMgCUdEQgkJCSMgU3VwcG9y dCByZW1vdGUgR0RCLgpvcHRpb25zIAlERUFETEtSRVMJCSMgRW5hYmxlIHRoZSBkZWFkbG9jayBy ZXNvbHZlcgpvcHRpb25zIAlJTlZBUklBTlRTCQkjIEVuYWJsZSBjYWxscyBvZiBleHRyYSBzYW5p dHkgY2hlY2tpbmcKb3B0aW9ucyAJSU5WQVJJQU5UX1NVUFBPUlQJIyBFeHRyYSBzYW5pdHkgY2hl Y2tzIG9mIGludGVybmFsIHN0cnVjdHVyZXMsIHJlcXVpcmVkIGJ5IElOVkFSSUFOVFMKb3B0aW9u cyAJV0lUTkVTUwkJCSMgRW5hYmxlIGNoZWNrcyB0byBkZXRlY3QgZGVhZGxvY2tzIGFuZCBjeWNs ZXMKb3B0aW9ucyAJV0lUTkVTU19TS0lQU1BJTgkjIERvbid0IHJ1biB3aXRuZXNzIG9uIHNwaW5s b2NrcyBmb3Igc3BlZWQKb3B0aW9ucyAJTUFMTE9DX0RFQlVHX01BWFpPTkVTPTgJIyBTZXBhcmF0 ZSBtYWxsb2MoOSkgem9uZXMKb3B0aW9ucyAJVkVSQk9TRV9TWVNJTklUPTAJIyBTdXBwb3J0IGRl YnVnLnZlcmJvc2Vfc3lzaW5pdCwgb2ZmIGJ5IGRlZmF1bHQKCiMgS2VybmVsIFNhbml0aXplcnMK I29wdGlvbnMgCUNPVkVSQUdFCQkjIEdlbmVyaWMga2VybmVsIGNvdmVyYWdlLiBVc2VkIGJ5IEtD T1YKI29wdGlvbnMgCUtDT1YJCQkjIEtlcm5lbCBDb3ZlcmFnZSBTYW5pdGl6ZXIKIyBXYXJuaW5n OiBLVUJTQU4gY2FuIHJlc3VsdCBpbiBhIGtlcm5lbCB0b28gbGFyZ2UgZm9yIGxvYWRlciB0byBs b2FkCiNvcHRpb25zIAlLVUJTQU4JCQkjIEtlcm5lbCBVbmRlZmluZWQgQmVoYXZpb3IgU2FuaXRp emVyCgojIEtlcm5lbCBkdW1wIGZlYXR1cmVzLgpvcHRpb25zIAlFS0NECQkJIyBTdXBwb3J0IGZv ciBlbmNyeXB0ZWQga2VybmVsIGR1bXBzCm9wdGlvbnMgCUdaSU8JCQkjIGd6aXAtY29tcHJlc3Nl ZCBrZXJuZWwgYW5kIHVzZXIgZHVtcHMKb3B0aW9ucyAJWlNURElPCQkJIyB6c3RkLWNvbXByZXNz ZWQga2VybmVsIGFuZCB1c2VyIGR1bXBzCm9wdGlvbnMgCU5FVERVTVAJCQkjIG5ldGR1bXAoNCkg Y2xpZW50IHN1cHBvcnQKCiMgTWFrZSBhbiBTTVAtY2FwYWJsZSBrZXJuZWwgYnkgZGVmYXVsdApv cHRpb25zIAlTTVAJCQkjIFN5bW1ldHJpYyBNdWx0aVByb2Nlc3NvciBLZXJuZWwKb3B0aW9ucyAJ RUFSTFlfQVBfU1RBUlRVUAoKIyBDUFUgZnJlcXVlbmN5IGNvbnRyb2wKZGV2aWNlCQljcHVmcmVx CgojIEJ1cyBzdXBwb3J0LgpkZXZpY2UJCWFjcGkKb3B0aW9ucyAJQUNQSV9ETUFSCmRldmljZQkJ cGNpCm9wdGlvbnMgCVBDSV9IUAkJCSMgUENJLUV4cHJlc3MgbmF0aXZlIEhvdFBsdWcKb3B0aW9u cwkJUENJX0lPVgkJCSMgUENJIFNSLUlPViBzdXBwb3J0CgojIEZsb3BweSBkcml2ZXMKZGV2aWNl CQlmZGMKCiMgQVRBIGNvbnRyb2xsZXJzCmRldmljZQkJYWhjaQkJCSMgQUhDSS1jb21wYXRpYmxl IFNBVEEgY29udHJvbGxlcnMKZGV2aWNlCQlhdGEJCQkjIExlZ2FjeSBBVEEvU0FUQSBjb250cm9s bGVycwpkZXZpY2UJCW12cwkJCSMgTWFydmVsbCA4OFNYNTBYWC84OFNYNjBYWC84OFNYNzBYWC9T b0MgU0FUQQpkZXZpY2UJCXNpaXMJCQkjIFNpbGljb25JbWFnZSBTaUkzMTI0L1NpSTMxMzIvU2lJ MzUzMSBTQVRBCgojIFNDU0kgQ29udHJvbGxlcnMKZGV2aWNlCQlhaGMJCQkjIEFIQTI5NDAgYW5k IG9uYm9hcmQgQUlDN3h4eCBkZXZpY2VzCmRldmljZQkJYWhkCQkJIyBBSEEzOTMyMC8yOTMyMCBh bmQgb25ib2FyZCBBSUM3OXh4IGRldmljZXMKZGV2aWNlCQllc3AJCQkjIEFNRCBBbTUzQzk3NCAo VGVrcmFtIERDLTM5MChUKSkKZGV2aWNlCQlocHRpb3AJCQkjIEhpZ2hwb2ludCBSb2NrZXRSYWlk IDN4eHggc2VyaWVzCmRldmljZQkJaXNwCQkJIyBRbG9naWMgZmFtaWx5CiNkZXZpY2UJCWlzcGZ3 CQkJIyBGaXJtd2FyZSBmb3IgUUxvZ2ljIEhCQXMtIG5vcm1hbGx5IGEgbW9kdWxlCmRldmljZQkJ bXB0CQkJIyBMU0ktTG9naWMgTVBULUZ1c2lvbgpkZXZpY2UJCW1wcwkJCSMgTFNJLUxvZ2ljIE1Q VC1GdXNpb24gMgpkZXZpY2UJCW1wcgkJCSMgTFNJLUxvZ2ljIE1QVC1GdXNpb24gMwpkZXZpY2UJ CXN5bQkJCSMgTkNSL1N5bWJpb3MgTG9naWMKZGV2aWNlCQl0cm0JCQkjIFRla3JhbSBEQzM5NVUv VVcvRiBEQzMxNVUgYWRhcHRlcnMKZGV2aWNlCQlpc2NpCQkJIyBJbnRlbCBDNjAwIFNBUyBjb250 cm9sbGVyCmRldmljZQkJb2NzX2ZjCQkJIyBFbXVsZXggRkMgYWRhcHRlcnMKCiMgQVRBL1NDU0kg cGVyaXBoZXJhbHMKZGV2aWNlCQlzY2J1cwkJCSMgU0NTSSBidXMgKHJlcXVpcmVkIGZvciBBVEEv U0NTSSkKZGV2aWNlCQljaAkJCSMgU0NTSSBtZWRpYSBjaGFuZ2VycwpkZXZpY2UJCWRhCQkJIyBE aXJlY3QgQWNjZXNzIChkaXNrcykKZGV2aWNlCQlzYQkJCSMgU2VxdWVudGlhbCBBY2Nlc3MgKHRh cGUgZXRjKQpkZXZpY2UJCWNkCQkJIyBDRApkZXZpY2UJCXBhc3MJCQkjIFBhc3N0aHJvdWdoIGRl dmljZSAoZGlyZWN0IEFUQS9TQ1NJIGFjY2VzcykKZGV2aWNlCQlzZXMJCQkjIEVuY2xvc3VyZSBT ZXJ2aWNlcyAoU0VTIGFuZCBTQUYtVEUpCiNkZXZpY2UJCWN0bAkJCSMgQ0FNIFRhcmdldCBMYXll cgoKIyBSQUlEIGNvbnRyb2xsZXJzIGludGVyZmFjZWQgdG8gdGhlIFNDU0kgc3Vic3lzdGVtCmRl dmljZQkJYW1yCQkJIyBBTUkgTWVnYVJBSUQKZGV2aWNlCQlhcmNtc3IJCQkjIEFyZWNhIFNBVEEg SUkgUkFJRApkZXZpY2UJCWNpc3MJCQkjIENvbXBhcSBTbWFydCBSQUlEIDUqCmRldmljZQkJaHB0 bXYJCQkjIEhpZ2hwb2ludCBSb2NrZXRSQUlEIDE4MngKZGV2aWNlCQlocHRucgkJCSMgSGlnaHBv aW50IERDNzI4MCwgUjc1MApkZXZpY2UJCWhwdHJyCQkJIyBIaWdocG9pbnQgUm9ja2V0UkFJRCAx N3h4LCAyMnh4LCAyM3h4LCAyNXh4CmRldmljZQkJaHB0Mjd4eAkJCSMgSGlnaHBvaW50IFJvY2tl dFJBSUQgMjd4eApkZXZpY2UJCWlpcgkJCSMgSW50ZWwgSW50ZWdyYXRlZCBSQUlECmRldmljZQkJ aXBzCQkJIyBJQk0gKEFkYXB0ZWMpIFNlcnZlUkFJRApkZXZpY2UJCW1seQkJCSMgTXlsZXggQWNj ZWxlUkFJRC9lWHRyZW1lUkFJRApkZXZpY2UJCXR3YQkJCSMgM3dhcmUgOTAwMCBzZXJpZXMgUEFU QS9TQVRBIFJBSUQKZGV2aWNlCQlzbWFydHBxaQkJIyBNaWNyb3NlbWkgc21hcnRwcWkgZHJpdmVy CmRldmljZQkJdHdzCQkJIyBMU0kgM3dhcmUgOTc1MCBTQVRBK1NBUyA2R2IvcyBSQUlEIGNvbnRy b2xsZXIKCiMgUkFJRCBjb250cm9sbGVycwpkZXZpY2UJCWFhYwkJCSMgQWRhcHRlYyBGU0EgUkFJ RApkZXZpY2UJCWFhY3AJCQkjIFNDU0kgcGFzc3Rocm91Z2ggZm9yIGFhYyAocmVxdWlyZXMgQ0FN KQpkZXZpY2UJCWFhY3JhaWQJCQkjIEFkYXB0ZWMgYnkgUE1DIFJBSUQKZGV2aWNlCQlpZGEJCQkj IENvbXBhcSBTbWFydCBSQUlECmRldmljZQkJbWZpCQkJIyBMU0kgTWVnYVJBSUQgU0FTCmRldmlj ZQkJbWx4CQkJIyBNeWxleCBEQUM5NjAgZmFtaWx5CmRldmljZQkJbXJzYXMJCQkjIExTSS9BdmFn byBNZWdhUkFJRCBTQVMvU0FUQSwgNkdiL3MgYW5kIDEyR2IvcwpkZXZpY2UJCXBtc3BjdgkJCSMg UE1DLVNpZXJyYSBTQVMvU0FUQSBDb250cm9sbGVyIGRyaXZlcgojWFhYIHBvaW50ZXIvaW50IHdh cm5pbmdzCiNkZXZpY2UJCXBzdAkJCSMgUHJvbWlzZSBTdXBlcnRyYWsgU1g2MDAwCmRldmljZQkJ dHdlCQkJIyAzd2FyZSBBVEEgUkFJRAoKIyBOVk0gRXhwcmVzcyAoTlZNZSkgc3VwcG9ydApkZXZp Y2UJCW52bWUJCQkjIGJhc2UgTlZNZSBkcml2ZXIKZGV2aWNlCQludmQJCQkjIGV4cG9zZSBOVk1l IG5hbWVzcGFjZXMgYXMgZGlza3MsIGRlcGVuZHMgb24gbnZtZQoKIyBhdGtiZGMwIGNvbnRyb2xz IGJvdGggdGhlIGtleWJvYXJkIGFuZCB0aGUgUFMvMiBtb3VzZQpkZXZpY2UJCWF0a2JkYwkJCSMg QVQga2V5Ym9hcmQgY29udHJvbGxlcgpkZXZpY2UJCWF0a2JkCQkJIyBBVCBrZXlib2FyZApkZXZp Y2UJCXBzbQkJCSMgUFMvMiBtb3VzZQoKZGV2aWNlCQlrYmRtdXgJCQkjIGtleWJvYXJkIG11bHRp cGxleGVyCgpkZXZpY2UJCXZnYQkJCSMgVkdBIHZpZGVvIGNhcmQgZHJpdmVyCm9wdGlvbnMgCVZF U0EJCQkjIEFkZCBzdXBwb3J0IGZvciBWRVNBIEJJT1MgRXh0ZW5zaW9ucyAoVkJFKQoKZGV2aWNl CQlzcGxhc2gJCQkjIFNwbGFzaCBzY3JlZW4gYW5kIHNjcmVlbiBzYXZlciBzdXBwb3J0CgojIHN5 c2NvbnMgaXMgdGhlIGRlZmF1bHQgY29uc29sZSBkcml2ZXIsIHJlc2VtYmxpbmcgYW4gU0NPIGNv bnNvbGUKZGV2aWNlCQlzYwpvcHRpb25zIAlTQ19QSVhFTF9NT0RFCQkjIGFkZCBzdXBwb3J0IGZv ciB0aGUgcmFzdGVyIHRleHQgbW9kZQoKIyB2dCBpcyB0aGUgbmV3IHZpZGVvIGNvbnNvbGUgZHJp dmVyCmRldmljZQkJdnQKZGV2aWNlCQl2dF92Z2EKZGV2aWNlCQl2dF9lZmlmYgoKZGV2aWNlCQlh Z3AJCQkjIHN1cHBvcnQgc2V2ZXJhbCBBR1AgY2hpcHNldHMKCiMgUENDQVJEIChQQ01DSUEpIHN1 cHBvcnQKIyBQQ01DSUEgYW5kIGNhcmRidXMgYnJpZGdlIHN1cHBvcnQKZGV2aWNlCQljYmIJCQkj IGNhcmRidXMgKHllbnRhKSBicmlkZ2UKZGV2aWNlCQlwY2NhcmQJCQkjIFBDIENhcmQgKDE2LWJp dCkgYnVzCmRldmljZQkJY2FyZGJ1cwkJCSMgQ2FyZEJ1cyAoMzItYml0KSBidXMKCiMgU2VyaWFs IChDT00pIHBvcnRzCmRldmljZQkJdWFydAkJCSMgR2VuZXJpYyBVQVJUIGRyaXZlcgoKIyBQYXJh bGxlbCBwb3J0CmRldmljZQkJcHBjCmRldmljZQkJcHBidXMJCQkjIFBhcmFsbGVsIHBvcnQgYnVz IChyZXF1aXJlZCkKZGV2aWNlCQlscHQJCQkjIFByaW50ZXIKZGV2aWNlCQlwcGkJCQkjIFBhcmFs bGVsIHBvcnQgaW50ZXJmYWNlIGRldmljZQojZGV2aWNlCQl2cG8JCQkjIFJlcXVpcmVzIHNjYnVz IGFuZCBkYQoKZGV2aWNlCQlwdWMJCQkjIE11bHRpIEkvTyBjYXJkcyBhbmQgbXVsdGktY2hhbm5l bCBVQVJUcwoKIyBQQ0kvUENJLVgvUENJZSBFdGhlcm5ldCBOSUNzIHRoYXQgdXNlIGlmbGliIGlu ZnJhc3RydWN0dXJlCmRldmljZQkJaWZsaWIKZGV2aWNlCQllbQkJCSMgSW50ZWwgUFJPLzEwMDAg R2lnYWJpdCBFdGhlcm5ldCBGYW1pbHkKZGV2aWNlCQlpeAkJCSMgSW50ZWwgUFJPLzEwR2JFIFBD SUUgUEYgRXRoZXJuZXQKZGV2aWNlCQlpeHYJCQkjIEludGVsIFBSTy8xMEdiRSBQQ0lFIFZGIEV0 aGVybmV0CmRldmljZQkJaXhsCQkJIyBJbnRlbCA3MDAgU2VyaWVzIFBoeXNpY2FsIEZ1bmN0aW9u CmRldmljZQkJaWF2ZgkJCSMgSW50ZWwgQWRhcHRpdmUgVmlydHVhbCBGdW5jdGlvbgpkZXZpY2UJ CXZteAkJCSMgVk13YXJlIFZNWE5FVDMgRXRoZXJuZXQKCiMgUENJIEV0aGVybmV0IE5JQ3MuCmRl dmljZQkJYnhlCQkJIyBCcm9hZGNvbSBOZXRYdHJlbWUgSUkgQkNNNTc3MVgvQkNNNTc4WFggMTBH YkUKZGV2aWNlCQlsZQkJCSMgQU1EIEFtNzkwMCBMQU5DRSBhbmQgQW03OUM5eHggUENuZXQKZGV2 aWNlCQl0aQkJCSMgQWx0ZW9uIE5ldHdvcmtzIFRpZ29uIEkvSUkgZ2lnYWJpdCBFdGhlcm5ldAoK IyBQQ0kgRXRoZXJuZXQgTklDcyB0aGF0IHVzZSB0aGUgY29tbW9uIE1JSSBidXMgY29udHJvbGxl ciBjb2RlLgojIE5PVEU6IEJlIHN1cmUgdG8ga2VlcCB0aGUgJ2RldmljZSBtaWlidXMnIGxpbmUg aW4gb3JkZXIgdG8gdXNlIHRoZXNlIE5JQ3MhCmRldmljZQkJbWlpYnVzCQkJIyBNSUkgYnVzIHN1 cHBvcnQKZGV2aWNlCQlhZQkJCSMgQXR0YW5zaWMvQXRoZXJvcyBMMiBGYXN0RXRoZXJuZXQKZGV2 aWNlCQlhZ2UJCQkjIEF0dGFuc2ljL0F0aGVyb3MgTDEgR2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJ CWFsYwkJCSMgQXRoZXJvcyBBUjgxMzEvQVI4MTMyIEV0aGVybmV0CmRldmljZQkJYWxlCQkJIyBB dGhlcm9zIEFSODEyMS9BUjgxMTMvQVI4MTE0IEV0aGVybmV0CmRldmljZQkJYmNlCQkJIyBCcm9h ZGNvbSBCQ001NzA2L0JDTTU3MDggR2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCWJmZQkJCSMgQnJv YWRjb20gQkNNNDQweCAxMC8xMDAgRXRoZXJuZXQKZGV2aWNlCQliZ2UJCQkjIEJyb2FkY29tIEJD TTU3MHh4IEdpZ2FiaXQgRXRoZXJuZXQKZGV2aWNlCQljYXMJCQkjIFN1biBDYXNzaW5pL0Nhc3Np bmkrIGFuZCBOUyBEUDgzMDY1IFNhdHVybgpkZXZpY2UJCWRjCQkJIyBERUMvSW50ZWwgMjExNDMg YW5kIHZhcmlvdXMgd29ya2FsaWtlcwpkZXZpY2UJCWV0CQkJIyBBZ2VyZSBFVDEzMTAgMTAvMTAw L0dpZ2FiaXQgRXRoZXJuZXQKZGV2aWNlCQlmeHAJCQkjIEludGVsIEV0aGVyRXhwcmVzcyBQUk8v MTAwQiAoODI1NTcsIDgyNTU4KQpkZXZpY2UJCWdlbQkJCSMgU3VuIEdFTS9TdW4gRVJJL0FwcGxl IEdNQUMKZGV2aWNlCQlobWUJCQkjIFN1biBITUUgKEhhcHB5IE1lYWwgRXRoZXJuZXQpCmRldmlj ZQkJam1lCQkJIyBKTWljcm9uIEpNQzI1MCBHaWdhYml0L0pNQzI2MCBGYXN0IEV0aGVybmV0CmRl dmljZQkJbGdlCQkJIyBMZXZlbCAxIExYVDEwMDEgZ2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCW1z awkJCSMgTWFydmVsbC9TeXNLb25uZWN0IFl1a29uIElJIEdpZ2FiaXQgRXRoZXJuZXQKZGV2aWNl CQluZmUJCQkjIG5WaWRpYSBuRm9yY2UgTUNQIG9uLWJvYXJkIEV0aGVybmV0CmRldmljZQkJbmdl CQkJIyBOYXRTZW1pIERQODM4MjAgZ2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCXJlCQkJIyBSZWFs VGVrIDgxMzlDKy84MTY5LzgxNjlTLzgxMTBTCmRldmljZQkJcmwJCQkjIFJlYWxUZWsgODEyOS84 MTM5CmRldmljZQkJc2dlCQkJIyBTaWxpY29uIEludGVncmF0ZWQgU3lzdGVtcyBTaVMxOTAvMTkx CmRldmljZQkJc2lzCQkJIyBTaWxpY29uIEludGVncmF0ZWQgU3lzdGVtcyBTaVMgOTAwL1NpUyA3 MDE2CmRldmljZQkJc2sJCQkjIFN5c0tvbm5lY3QgU0stOTg0eCAmIFNLLTk4MnggZ2lnYWJpdCBF dGhlcm5ldApkZXZpY2UJCXN0ZQkJCSMgU3VuZGFuY2UgU1QyMDEgKEQtTGluayBERkUtNTUwVFgp CmRldmljZQkJc3RnZQkJCSMgU3VuZGFuY2UvVGFtYXJhY2sgVEM5MDIxIGdpZ2FiaXQgRXRoZXJu ZXQKZGV2aWNlCQl2Z2UJCQkjIFZJQSBWVDYxMnggZ2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCXZy CQkJIyBWSUEgUmhpbmUsIFJoaW5lIElJCmRldmljZQkJeGwJCQkjIDNDb20gM2M5MHggKGBgQm9v bWVyYW5nJycsIGBgQ3ljbG9uZScnKQoKIyBXaXJlbGVzcyBOSUMgY2FyZHMKZGV2aWNlCQl3bGFu CQkJIyA4MDIuMTEgc3VwcG9ydApvcHRpb25zIAlJRUVFODAyMTFfREVCVUcJCSMgZW5hYmxlIGRl YnVnIG1zZ3MKb3B0aW9ucyAJSUVFRTgwMjExX1NVUFBPUlRfTUVTSAkjIGVuYWJsZSA4MDIuMTFz IGRyYWZ0IHN1cHBvcnQKZGV2aWNlCQl3bGFuX3dlcAkJIyA4MDIuMTEgV0VQIHN1cHBvcnQKZGV2 aWNlCQl3bGFuX2NjbXAJCSMgODAyLjExIENDTVAgc3VwcG9ydApkZXZpY2UJCXdsYW5fdGtpcAkJ IyA4MDIuMTEgVEtJUCBzdXBwb3J0CmRldmljZQkJd2xhbl9hbXJyCQkjIEFNUlIgdHJhbnNtaXQg cmF0ZSBjb250cm9sIGFsZ29yaXRobQpkZXZpY2UJCWFuCQkJIyBBaXJvbmV0IDQ1MDAvNDgwMCA4 MDIuMTEgd2lyZWxlc3MgTklDcy4KZGV2aWNlCQlhdGgJCQkjIEF0aGVyb3MgTklDcwpkZXZpY2UJ CWF0aF9wY2kJCQkjIEF0aGVyb3MgcGNpL2NhcmRidXMgZ2x1ZQpkZXZpY2UJCWF0aF9oYWwJCQkj IHBjaS9jYXJkYnVzIGNoaXAgc3VwcG9ydApvcHRpb25zIAlBSF9BUjU0MTZfSU5URVJSVVBUX01J VElHQVRJT04gIyBBUjU0MTYgaW50ZXJydXB0IG1pdGlnYXRpb24Kb3B0aW9ucyAJQVRIX0VOQUJM RV8xMU4JCSMgRW5hYmxlIDgwMi4xMW4gc3VwcG9ydCBmb3IgQVI1NDE2IGFuZCBsYXRlcgpkZXZp Y2UJCWF0aF9yYXRlX3NhbXBsZQkJIyBTYW1wbGVSYXRlIHR4IHJhdGUgY29udHJvbCBmb3IgYXRo CiNkZXZpY2UJCWJ3aQkJCSMgQnJvYWRjb20gQkNNNDMweC9CQ000MzF4IHdpcmVsZXNzIE5JQ3Mu CiNkZXZpY2UJCWJ3bgkJCSMgQnJvYWRjb20gQkNNNDN4eCB3aXJlbGVzcyBOSUNzLgpkZXZpY2UJ CWlwdwkJCSMgSW50ZWwgMjEwMCB3aXJlbGVzcyBOSUNzLgpkZXZpY2UJCWl3aQkJCSMgSW50ZWwg MjIwMEJHLzIyMjVCRy8yOTE1QUJHIHdpcmVsZXNzIE5JQ3MuCmRldmljZQkJaXduCQkJIyBJbnRl bCA0OTY1LzEwMDAvNTAwMC82MDAwIHdpcmVsZXNzIE5JQ3MuCmRldmljZQkJbWFsbwkJCSMgTWFy dmVsbCBMaWJlcnRhcyB3aXJlbGVzcyBOSUNzLgpkZXZpY2UJCW13bAkJCSMgTWFydmVsbCA4OFc4 MzYzIDgwMi4xMW4gd2lyZWxlc3MgTklDcy4KZGV2aWNlCQlyYWwJCQkjIFJhbGluayBUZWNobm9s b2d5IFJUMjUwMCB3aXJlbGVzcyBOSUNzLgpkZXZpY2UJCXdpCQkJIyBXYXZlTEFOL0ludGVyc2ls L1N5bWJvbCA4MDIuMTEgd2lyZWxlc3MgTklDcy4KZGV2aWNlCQl3cGkJCQkjIEludGVsIDM5NDVB Qkcgd2lyZWxlc3MgTklDcy4KCiMgUHNldWRvIGRldmljZXMuCmRldmljZQkJY3J5cHRvCQkJIyBj b3JlIGNyeXB0byBzdXBwb3J0CmRldmljZQkJbG9vcAkJCSMgTmV0d29yayBsb29wYmFjawpkZXZp Y2UJCXBhZGxvY2tfcm5nCQkjIFZJQSBQYWRsb2NrIFJORwpkZXZpY2UJCXJkcmFuZF9ybmcJCSMg SW50ZWwgQnVsbCBNb3VudGFpbiBSTkcKZGV2aWNlCQlldGhlcgkJCSMgRXRoZXJuZXQgc3VwcG9y dApkZXZpY2UJCXZsYW4JCQkjIDgwMi4xUSBWTEFOIHN1cHBvcnQKZGV2aWNlCQl0dW50YXAJCQkj IFBhY2tldCB0dW5uZWwuCmRldmljZQkJbWQJCQkjIE1lbW9yeSAiZGlza3MiCmRldmljZQkJZ2lm CQkJIyBJUHY2IGFuZCBJUHY0IHR1bm5lbGluZwpkZXZpY2UJCWZpcm13YXJlCQkjIGZpcm13YXJl IGFzc2lzdCBtb2R1bGUKCiMgVGhlIGBicGYnIGRldmljZSBlbmFibGVzIHRoZSBCZXJrZWxleSBQ YWNrZXQgRmlsdGVyLgojIEJlIGF3YXJlIG9mIHRoZSBhZG1pbmlzdHJhdGl2ZSBjb25zZXF1ZW5j ZXMgb2YgZW5hYmxpbmcgdGhpcyEKIyBOb3RlIHRoYXQgJ2JwZicgaXMgcmVxdWlyZWQgZm9yIERI Q1AuCmRldmljZQkJYnBmCQkJIyBCZXJrZWxleSBwYWNrZXQgZmlsdGVyCgojIFVTQiBzdXBwb3J0 Cm9wdGlvbnMgCVVTQl9ERUJVRwkJIyBlbmFibGUgZGVidWcgbXNncwpkZXZpY2UJCXVoY2kJCQkj IFVIQ0kgUENJLT5VU0IgaW50ZXJmYWNlCmRldmljZQkJb2hjaQkJCSMgT0hDSSBQQ0ktPlVTQiBp bnRlcmZhY2UKZGV2aWNlCQllaGNpCQkJIyBFSENJIFBDSS0+VVNCIGludGVyZmFjZSAoVVNCIDIu MCkKZGV2aWNlCQl4aGNpCQkJIyBYSENJIFBDSS0+VVNCIGludGVyZmFjZSAoVVNCIDMuMCkKZGV2 aWNlCQl1c2IJCQkjIFVTQiBCdXMgKHJlcXVpcmVkKQpkZXZpY2UJCXVrYmQJCQkjIEtleWJvYXJk CmRldmljZQkJdW1hc3MJCQkjIERpc2tzL01hc3Mgc3RvcmFnZSAtIFJlcXVpcmVzIHNjYnVzIGFu ZCBkYQoKIyBTb3VuZCBzdXBwb3J0CmRldmljZQkJc291bmQJCQkjIEdlbmVyaWMgc291bmQgZHJp dmVyIChyZXF1aXJlZCkKZGV2aWNlCQlzbmRfY21pCQkJIyBDTWVkaWEgQ01JODMzOC9DTUk4NzM4 CmRldmljZQkJc25kX2NzYQkJCSMgQ3J5c3RhbCBTZW1pY29uZHVjdG9yIENTNDYxeC80Mjh4CmRl dmljZQkJc25kX2VtdTEwa3gJCSMgQ3JlYXRpdmUgU291bmRCbGFzdGVyIExpdmUhIGFuZCBBdWRp Z3kKZGV2aWNlCQlzbmRfZXMxMzd4CQkjIEVuc29uaXEgQXVkaW9QQ0kgRVMxMzd4CmRldmljZQkJ c25kX2hkYQkJCSMgSW50ZWwgSGlnaCBEZWZpbml0aW9uIEF1ZGlvCmRldmljZQkJc25kX2ljaAkJ CSMgSW50ZWwsIE5WaWRpYSBhbmQgb3RoZXIgSUNIIEFDJzk3IEF1ZGlvCmRldmljZQkJc25kX3Zp YTgyMzMJCSMgVklBIFZUODIzM3ggQXVkaW8KCiMgTU1DL1NECmRldmljZQkJbW1jCQkJIyBNTUMv U0QgYnVzCmRldmljZQkJbW1jc2QJCQkjIE1NQy9TRCBtZW1vcnkgY2FyZApkZXZpY2UJCXNkaGNp CQkJIyBHZW5lcmljIFBDSSBTRCBIb3N0IENvbnRyb2xsZXIKCiMgVmlydElPIHN1cHBvcnQKZGV2 aWNlCQl2aXJ0aW8JCQkjIEdlbmVyaWMgVmlydElPIGJ1cyAocmVxdWlyZWQpCmRldmljZQkJdmly dGlvX3BjaQkJIyBWaXJ0SU8gUENJIGRldmljZQpkZXZpY2UJCXZ0bmV0CQkJIyBWaXJ0SU8gRXRo ZXJuZXQgZGV2aWNlCmRldmljZQkJdmlydGlvX2JsawkJIyBWaXJ0SU8gQmxvY2sgZGV2aWNlCmRl dmljZQkJdmlydGlvX3Njc2kJCSMgVmlydElPIFNDU0kgZGV2aWNlCmRldmljZQkJdmlydGlvX2Jh bGxvb24JCSMgVmlydElPIE1lbW9yeSBCYWxsb29uIGRldmljZQoKIyBIeXBlclYgZHJpdmVycyBh bmQgZW5oYW5jZW1lbnQgc3VwcG9ydApkZXZpY2UJCWh5cGVydgkJCSMgSHlwZXJWIGRyaXZlcnMg CgojIFhlbiBIVk0gR3Vlc3QgT3B0aW1pemF0aW9ucwojIE5PVEU6IFhFTkhWTSBkZXBlbmRzIG9u IHhlbnBjaS4gIFRoZXkgbXVzdCBiZSBhZGRlZCBvciByZW1vdmVkIHRvZ2V0aGVyLgpvcHRpb25z IAlYRU5IVk0JCQkjIFhlbiBIVk0ga2VybmVsIGluZnJhc3RydWN0dXJlCmRldmljZQkJeGVucGNp CQkJIyBYZW4gSFZNIEh5cGVydmlzb3Igc2VydmljZXMgZHJpdmVyCgojIE5ldG1hcCBwcm92aWRl cyBkaXJlY3QgYWNjZXNzIHRvIFRYL1JYIHJpbmdzIG9uIHN1cHBvcnRlZCBOSUNzCmRldmljZQkJ bmV0bWFwCQkJIyBuZXRtYXAoNCkgc3VwcG9ydAoKIyBldmRldiBpbnRlcmZhY2UKb3B0aW9ucyAJ RVZERVZfU1VQUE9SVAkJIyBldmRldiBzdXBwb3J0IGluIGxlZ2FjeSBkcml2ZXJzCmRldmljZQkJ ZXZkZXYJCQkjIGlucHV0IGV2ZW50IGRldmljZSBzdXBwb3J0CmRldmljZQkJdWlucHV0CQkJIyBp bnN0YWxsIC9kZXYvdWlucHV0IGNkZXYK --00000000000065de770592cab622-- From owner-freebsd-net@freebsd.org Wed Sep 18 03:26:55 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F4FBEFA9D for ; Wed, 18 Sep 2019 03:26:55 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y54Z1W9pz3H0p for ; Wed, 18 Sep 2019 03:26:53 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pl1-x644.google.com with SMTP id x6so961094plv.6 for ; Tue, 17 Sep 2019 20:26:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=HOt8BPQrv3WKG/Zpe3yRat4EFQ5/HIG1xsKQugU9ftE=; b=GGVV01qxPER4nyLi/SeQ20u5lsKg88Fw/hYlYvHd8it6hWpuPzbyuSpQH6LrYPksXY Nysdm412yCnQbqt3oiqQQF4N5NRBTR1XHlO/2Ak91i2tHKizpvTvPQYUX1tSozR7tcLb z1c3tW+eHUVAZZFaRD9JZtMWxGESBeXIG6NpXsgThDrmVk+SvrRHC55J1e3Ar6SdtpkZ +8U7xDEmzsuSqDpbFmkyTZ2mfibzCEsI7d7TpO/f1Q0sUG6zu8Em1GFQmkTrZWw01Fqa Lnxj4kq1Bc5FYMlNltJ7X0mG4k938RmQuWfTQUtDhTCk1t0gsPno87tbF5Fxh+wzsDcR OAJQ== X-Gm-Message-State: APjAAAVb27IINoOLFX5G56W1RlIBkivYtMqshXJKkP8p+IMJMhTTsoCi bbmlUGJLA961+9r5Jy0rjFCLUg== X-Google-Smtp-Source: APXvYqxMhuxff2Hk5q8Cmo4sMz6wRWV+IArTTny9H5rpitAGZWBlLAtGz85KDMyU4YRelL+EVHAAEg== X-Received: by 2002:a17:902:6b84:: with SMTP id p4mr2068924plk.168.1568777212204; Tue, 17 Sep 2019 20:26:52 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::c2ea? ([2607:fb10:7021:1::c2ea]) by smtp.gmail.com with ESMTPSA id u65sm4493951pfu.104.2019.09.17.20.26.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 20:26:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Tue, 17 Sep 2019 20:26:49 -0700 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Content-Transfer-Encoding: quoted-printable Message-Id: <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46Y54Z1W9pz3H0p X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.06 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(0.00)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.964,0]; R_DKIM_ALLOW(0.00)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-0.99)[-0.995,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-1.10)[ip: (-0.55), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 03:26:55 -0000 There have been several patches pre-this one that provide the infrastructure to support BBR. Release 12.0 will *not* have these patches and will *not* compile it. I have no intention at this point in doing a MFC of this work.. so if = you want to run BBR you need to run Head R > On Sep 17, 2019, at 7:26 PM, vm finance wrote: >=20 > Hi Randall, >=20 > Could you please provide a pointer to the latest patch. I had applied = the one you published Sep-10. >=20 > Following is what I have done: > 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > 2. Got VM up under VMPlayer on x86 laptop > 3. Checked out latest codebase from freebsd repo: > svn co svn://svn.freebsd.org/base/head /usr/src* > cd /usr/src; > make buildworld buildkernel =20 > [this is where make fails when patch is applied] >=20 > I could try to build with your latest patch - please send me a = pointer. >=20 > Thanks for your help! >=20 >=20 > On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: > Looking at your make file log I can=E2=80=99t really tell what you are = doing. >=20 > Its not the BBR or Rack code that is blowing up=E2=80=A6=20 >=20 > Are you cross compiling? >=20 > I have done the old fashioned kernel make >=20 > i.e.=20 >=20 > cd src/sys/amd64/config > config headvm > cd ../compile/headvm >=20 > make cleandepend ; make depend; make -j3 >=20 > I have done >=20 > cd src > make buildkernel KERNCONF=3Dheadvm >=20 > And even >=20 > make buildkernel KERNCONF=3DGENERIC >=20 > to make sure that the build works without bbr. >=20 > I attach my headvm config.. >=20 > What exactly are you building and how? kernel config too please? >=20 > R >=20 >=20 >=20 >=20 > > On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: > >=20 > > looking > >=20 > > I was at 352408.. let me update and try it > >=20 > > R > >=20 > >> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: > >>=20 > >> Hmm > >>=20 > >> Did you get the patch I updated too this am? > >>=20 > >> I have built it both with and without the bbr stack and had no = issue.. there was > >> an issue with KTLS before the update though. > >>=20 > >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 > >>=20 > >> R > >>=20 > >>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: > >>>=20 > >>> Got it - thank you! > >>>=20 > >>> btw, I tried to build the patch but its giving an error. Following = is SVN info + make error mesg. > >>>=20 > >>> Please let me know what am I missing here? > >>>=20 > >>> Thanks! > >>>=20 > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>=20 > >>> root@osboxes:/usr/src # > >>>=20 > >>> -------------------------------------------- snip = ---------------------------- > >>>=20 > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make: stopped in /usr/src > >>>=20 > >>>=20 > >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > >>> Got it - thank you! > >>>=20 > >>> btw, I tried to build the patch but its giving an error. Following = is SVN info + make error mesg. > >>> I have also attached the entire build log...snippet is below > >>>=20 > >>> Please let me know what am I missing here? > >>>=20 > >>> Thanks! > >>>=20 > >>> #svnlite revision > >>> Path: . > >>> Working Copy Root Path: /usr/src > >>> URL: svn://svn.freebsd.org/base/head > >>> Relative URL: ^/head > >>> Repository Root: svn://svn.freebsd.org/base > >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>> Revision: 352436 > >>> Node Kind: directory > >>> Schedule: normal > >>> Last Changed Author: jah > >>> Last Changed Rev: 352434 > >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>=20 > >>> root@osboxes:/usr/src # > >>>=20 > >>> -------------------------------------------- snip = ---------------------------- > >>>=20 > >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo bcache.llo interp_simple.llo zfs_cmd.llo > >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>> =3D=3D=3D> sys (cleandir) > >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h opt_kern_tls.h > >>> rm: x86: is a directory > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[3]: stopped in /usr/src/sys > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[2]: stopped in /usr/src > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make[1]: stopped in /usr/src > >>> *** Error code 1 > >>>=20 > >>> Stop. > >>> make: stopped in /usr/src > >>>=20 > >>>=20 > >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > >>> Pacing is provided by tcp_hpts.c. The current linux patches do not = have > >>> to have fq.. they built an alternate means of doing pacing into = bbr. > >>>=20 > >>> In either case our testing has shown that our pacing is more = accurate than > >>> either fq or the internal pacer :) > >>>=20 > >>> R > >>>=20 > >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > >>>>=20 > >>>> Thanks Randall. > >>>> I was able to apply the patch - now rebuilding the kernel. Would = update on how it goes. > >>>>=20 > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD = is compensated here? > >>>> The original BBR patches on Linux show that as a must-have? Is = that functionality implemented via tcp_ratelimit.[ch]? > >>>>=20 > >>>> Any pointers to existing presentations/discussions highly = appreciated? > >>>>=20 > >>>> Thanks a lot. > >>>>=20 > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > >>>> You should be able to compile it against the current head. I = re-doing that now (had an > >>>> issue with my machine and had to roll it back to a backup). > >>>>=20 > >>>> When I put the patch up on Sept 10th it complied with and without = BBR on whatever > >>>> was that rev.. > >>>>=20 > >>>> Looking in the commit logs that would have been around 352191 > >>>>=20 > >>>> Hope that helps > >>>>=20 > >>>> R > >>>>=20 > >>>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > >>>>>=20 > >>>>> Hi Randall, > >>>>>=20 > >>>>> Thanks for releasing BBR patch: > >>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 > >>>>>=20 > >>>>> Could you please let me know what SVN/GIT label tag this is = based on? I would like to patch and experiment with it. I couldn't find = this info in the released patch. > >>>>>=20 > >>>>> Thanks a lot!=20 > >>>>>=20 > >>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > >>>>> rrs@ has just posted the BBR patch to phabricator: > >>>>>=20 > >>>>> https://reviews.freebsd.org/D21582 > >>>>=20 > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>=20 > >>> ------ > >>> Randall Stewart > >>> rrs@netflix.com > >>>=20 > >>>=20 > >>>=20 > >>=20 > >> ------ > >> Randall Stewart > >> rrs@netflix.com > >>=20 > >>=20 > >>=20 > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Wed Sep 18 05:11:13 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7230EF1378 for ; Wed, 18 Sep 2019 05:11:13 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y7Nw3rWRz3LFw for ; Wed, 18 Sep 2019 05:11:12 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-pf1-x42d.google.com with SMTP id q12so3553853pff.9 for ; Tue, 17 Sep 2019 22:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U0UTNfP5Mev3gkw/3G/YxtdbpcqfPH4G9uwh2bhmydc=; b=NWVichQhmHctLNCNPLnupfrov9MaWZ/k7i7lvOf6A4M3QxkdOWsDyJSPipR74dNOEc 05+v2n9Yl9yiCbYECs8MLUV5UDTv9HUJfBfDrhb9x/cO7HASMeXRlXFAGMYHIMCwSwHy 9dcRX4Qbi+INrE55QXOSt27z6xOcTFfpsnF4OlxLPTn4RP3n0e+2PUK2Fm+Skvcs/QAY O9sNchkE7Bxl/TeBY5V1QxHNh77aYQXc5uOdG/XBaGkm8hapbYvwLHje4r1L7zK1x4pq fNDP3UIdmUthil5+k2bfwx1kSVJLpt+DzhJ+VF/xVJHSFiZWoKcgOJAMSDKi9f//fmRZ +qvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=U0UTNfP5Mev3gkw/3G/YxtdbpcqfPH4G9uwh2bhmydc=; b=o+nl9iJWJmaJNvRjllbY47XqjIFjO9QIb9tk1gNCbJnJmrpyPco3QhhYiBaqoP4GtP kdsFvn0q0H4Aembdl/udS5LxAFtWdusa6jZEcbscdTJLgEfAI8nViNDf2RnOfktOhyU6 CvbjbCMs7nR3+R8VHN6AG4Iw21i83FfHxyYmOLbe+E5Oizv57zjqoed+cVQddL6iYwF8 c+jsFG2BJyM7bzyprrLMQELlLZvIJTCxjuY3Dw7YvnAXOWUaOJLtxjw0WS24SSlVnoUc b4lEyZRyJaInN7bKtK4+3QgD5Ek4yv0SlM6m4HySaOmyJ4oAgAAhbRoYh/CC8M+//xES 6sag== X-Gm-Message-State: APjAAAUp9CRglgjoiUo15Lsx7bSR1qXQqm28Xnm3/J/geY54qrmnkKez xUO/BJr8b8rRiqYFK8wSFzg= X-Google-Smtp-Source: APXvYqw8tibJE6tjR5Tf745I4CYHzvQv5ua0tAit1GBWZ39M3QlbecbBzV1zJKmAXPVXnFouetOPsg== X-Received: by 2002:a65:4781:: with SMTP id e1mr2272263pgs.386.1568783470984; Tue, 17 Sep 2019 22:11:10 -0700 (PDT) Received: from [100.107.254.7] ([223.186.158.250]) by smtp.gmail.com with ESMTPSA id j1sm933527pjs.28.2019.09.17.22.11.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Sep 2019 22:11:10 -0700 (PDT) Mime-Version: 1.0 (1.0) Subject: Re: BBR patches? From: vm finance X-Mailer: iPhone Mail (16G102) In-Reply-To: <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> Date: Wed, 18 Sep 2019 10:41:07 +0530 Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> To: Randall Stewart X-Rspamd-Queue-Id: 46Y7Nw3rWRz3LFw X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NWVichQh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::42d as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [10.97 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(0.98)[0.983,0]; BAD_REP_POLICIES(0.10)[]; RECEIVED_SPAMHAUS_PBL(0.00)[250.158.186.223.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.98)[0.985,0]; RCVD_IN_DNSWL_NONE(0.00)[d.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (-9.02), ipnet: 2607:f8b0::/32(-2.69), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 05:11:13 -0000 Actually I am on head already as mentioned previously. Pulled it using yeste= rday: >> svn co svn://svn.freebsd.org/base/head /use/src If you could pls let me know the new patch, I can try that. Thanks=20 Sent from my iPhone > On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: >=20 > There have been several patches pre-this one that provide > the infrastructure to support BBR. >=20 > Release 12.0 will *not* have these patches and will *not* compile it. >=20 > I have no intention at this point in doing a MFC of this work.. so if you w= ant > to run BBR you need to run Head >=20 > R >=20 >> On Sep 17, 2019, at 7:26 PM, vm finance wrote: >>=20 >> Hi Randall, >>=20 >> Could you please provide a pointer to the latest patch. I had applied the= one you published Sep-10. >>=20 >> Following is what I have done: >> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> 2. Got VM up under VMPlayer on x86 laptop >> 3. Checked out latest codebase from freebsd repo: >> svn co svn://svn.freebsd.org/base/head /usr/src* >> cd /usr/src; >> make buildworld buildkernel =20 >> [this is where make fails when patch is applied] >>=20 >> I could try to build with your latest patch - please send me a pointer. >>=20 >> Thanks for your help! >>=20 >>=20 >> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: >> Looking at your make file log I can=E2=80=99t really tell what you are do= ing. >>=20 >> Its not the BBR or Rack code that is blowing up=E2=80=A6=20 >>=20 >> Are you cross compiling? >>=20 >> I have done the old fashioned kernel make >>=20 >> i.e.=20 >>=20 >> cd src/sys/amd64/config >> config headvm >> cd ../compile/headvm >>=20 >> make cleandepend ; make depend; make -j3 >>=20 >> I have done >>=20 >> cd src >> make buildkernel KERNCONF=3Dheadvm >>=20 >> And even >>=20 >> make buildkernel KERNCONF=3DGENERIC >>=20 >> to make sure that the build works without bbr. >>=20 >> I attach my headvm config.. >>=20 >> What exactly are you building and how? kernel config too please? >>=20 >> R >>=20 >>=20 >>=20 >>=20 >>> On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >>>=20 >>> looking >>>=20 >>> I was at 352408.. let me update and try it >>>=20 >>> R >>>=20 >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >>>>=20 >>>> Hmm >>>>=20 >>>> Did you get the patch I updated too this am? >>>>=20 >>>> I have built it both with and without the bbr stack and had no issue.. t= here was >>>> an issue with KTLS before the update though. >>>>=20 >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>>>=20 >>>> R >>>>=20 >>>>> On Sep 17, 2019, at 11:47 AM, vm finance wrote= : >>>>>=20 >>>>> Got it - thank you! >>>>>=20 >>>>> btw, I tried to build the patch but its giving an error. Following is S= VN info + make error mesg. >>>>>=20 >>>>> Please let me know what am I missing here? >>>>>=20 >>>>> Thanks! >>>>>=20 >>>>> #svnlite revision >>>>> Path: . >>>>> Working Copy Root Path: /usr/src >>>>> URL: svn://svn.freebsd.org/base/head >>>>> Relative URL: ^/head >>>>> Repository Root: svn://svn.freebsd.org/base >>>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>> Revision: 352436 >>>>> Node Kind: directory >>>>> Schedule: normal >>>>> Last Changed Author: jah >>>>> Last Changed Rev: 352434 >>>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>>=20 >>>>> root@osboxes:/usr/src # >>>>>=20 >>>>> -------------------------------------------- snip --------------------= -------- >>>>>=20 >>>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.l= lo bcache.llo interp_simple.llo zfs_cmd.llo >>>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>> =3D=3D=3D> sys (cleandir) >>>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter= .o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_k= ern_tls.h >>>>> rm: x86: is a directory >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[3]: stopped in /usr/src/sys >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[2]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[1]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make: stopped in /usr/src >>>>>=20 >>>>>=20 >>>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance wro= te: >>>>> Got it - thank you! >>>>>=20 >>>>> btw, I tried to build the patch but its giving an error. Following is S= VN info + make error mesg. >>>>> I have also attached the entire build log...snippet is below >>>>>=20 >>>>> Please let me know what am I missing here? >>>>>=20 >>>>> Thanks! >>>>>=20 >>>>> #svnlite revision >>>>> Path: . >>>>> Working Copy Root Path: /usr/src >>>>> URL: svn://svn.freebsd.org/base/head >>>>> Relative URL: ^/head >>>>> Repository Root: svn://svn.freebsd.org/base >>>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>> Revision: 352436 >>>>> Node Kind: directory >>>>> Schedule: normal >>>>> Last Changed Author: jah >>>>> Last Changed Rev: 352434 >>>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>>=20 >>>>> root@osboxes:/usr/src # >>>>>=20 >>>>> -------------------------------------------- snip --------------------= -------- >>>>>=20 >>>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.l= lo bcache.llo interp_simple.llo zfs_cmd.llo >>>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>> =3D=3D=3D> sys (cleandir) >>>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter= .o rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h opt_k= ern_tls.h >>>>> rm: x86: is a directory >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[3]: stopped in /usr/src/sys >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[2]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make[1]: stopped in /usr/src >>>>> *** Error code 1 >>>>>=20 >>>>> Stop. >>>>> make: stopped in /usr/src >>>>>=20 >>>>>=20 >>>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrot= e: >>>>> Pacing is provided by tcp_hpts.c. The current linux patches do not hav= e >>>>> to have fq.. they built an alternate means of doing pacing into bbr. >>>>>=20 >>>>> In either case our testing has shown that our pacing is more accurate t= han >>>>> either fq or the internal pacer :) >>>>>=20 >>>>> R >>>>>=20 >>>>>> On Sep 17, 2019, at 11:05 AM, vm finance wrot= e: >>>>>>=20 >>>>>> Thanks Randall. >>>>>> I was able to apply the patch - now rebuilding the kernel. Would upda= te on how it goes. >>>>>>=20 >>>>>> BTW, is there any description on how lack of tc_fq under FreeBSD is c= ompensated here? >>>>>> The original BBR patches on Linux show that as a must-have? Is that f= unctionality implemented via tcp_ratelimit.[ch]? >>>>>>=20 >>>>>> Any pointers to existing presentations/discussions highly appreciated= ? >>>>>>=20 >>>>>> Thanks a lot. >>>>>>=20 >>>>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart wro= te: >>>>>> You should be able to compile it against the current head. I re-doing= that now (had an >>>>>> issue with my machine and had to roll it back to a backup). >>>>>>=20 >>>>>> When I put the patch up on Sept 10th it complied with and without BBR= on whatever >>>>>> was that rev.. >>>>>>=20 >>>>>> Looking in the commit logs that would have been around 352191 >>>>>>=20 >>>>>> Hope that helps >>>>>>=20 >>>>>> R >>>>>>=20 >>>>>>> On Sep 17, 2019, at 3:32 AM, vm finance wrot= e: >>>>>>>=20 >>>>>>> Hi Randall, >>>>>>>=20 >>>>>>> Thanks for releasing BBR patch: >>>>>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq=20 >>>>>>>=20 >>>>>>> Could you please let me know what SVN/GIT label tag this is based on= ? I would like to patch and experiment with it. I couldn't find this info in= the released patch. >>>>>>>=20 >>>>>>> Thanks a lot!=20 >>>>>>>=20 >>>>>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrot= e: >>>>>>> rrs@ has just posted the BBR patch to phabricator: >>>>>>>=20 >>>>>>> https://reviews.freebsd.org/D21582 >>>>>>=20 >>>>>> ------ >>>>>> Randall Stewart >>>>>> rrs@netflix.com >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>> ------ >>>>> Randall Stewart >>>>> rrs@netflix.com >>>>>=20 >>>>>=20 >>>>>=20 >>>>=20 >>>> ------ >>>> Randall Stewart >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>=20 >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 From owner-freebsd-net@freebsd.org Wed Sep 18 06:19:48 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 11199F28BE for ; Wed, 18 Sep 2019 06:19:48 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y8w31ZCTz3Nd7 for ; Wed, 18 Sep 2019 06:19:46 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id v2so13409143iob.10 for ; Tue, 17 Sep 2019 23:19:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g1FU0Rc7ViQwbNgD2Ub3EyR8i3O1CDZgb5gqxjhm3Ow=; b=MIBeCGBQx4ZxuRgvAvPOKfn1uw0bUrEzAJL6BdOv9wz6RkBOEhSEOGW4NGeux0vMUh SFGag8B88kqjLTr8sE8QwaEbX7Wpghqp9ynlSvi5OrKto/ZtZbD92tyPhr6W+cFor2RN zQcmO6267F/sLvqb5ROi3Zuuh8S5cETV0zDyM2KijesVz3D/Bs3nP1BMVS3JF0QFvAqd l3m+oNbRWOA4Qf5KPh2pb8LMOiP9gvD6dkoBl4f1AkyPv3wsmzjKds2OylfsNQlMTNaH UEFXP/3VUiPSg1+32q+6fsOzZ7VX8bMEwLkX0WuHjMcszjfE+MgndI7eN1p2jE986AyB 8riA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g1FU0Rc7ViQwbNgD2Ub3EyR8i3O1CDZgb5gqxjhm3Ow=; b=h5QVgcQGA/UbjEvAoY0u+dTWcd1vaZRYjPOfKT9uH7xGtLPS/OHA/sQPj+iot3tnkf NmRDYXitt4JmaKX0DFyXrGNkKfPTM0XFBkXUkOwmTpyy1Jf4YT6Be+W1379iMgyxdzZC tGVImxT4+3YFKHoms1MxaQXh+qc+9iPe652Vw4lMd1PreD9nPQ+mK3WfgcvK8mSdGowY 0cU9Zxwc4ig6dne/ZwHCKpUrc7lBR3PjLMOPX/tOv/uvczy5nodF/wHHgI9UGWPcxI+r xc4W8UaKpuZX5nx2lH3IBWpHesJv+zmPVafXNyWTolBnY8U5xV8h9Gy1t80BxYSP2QAR SYOQ== X-Gm-Message-State: APjAAAXBhtDvF/2Ks+ctRtNbJQGWY72vWh3ggcFvZMyGmYRMCwOCawoe gpAQ+qN309taPSWjgdfNie9jpa2l7BpPIJOcJto= X-Google-Smtp-Source: APXvYqzCQJD3tpd6TkfCimOqle3PKCwJoP8VQP2Np60KoCWTaU7lkuGSGgqxSqicoNPYvtjWXsvv7N6VSW5NM9rLroU= X-Received: by 2002:a02:6616:: with SMTP id k22mr2990115jac.129.1568787585766; Tue, 17 Sep 2019 23:19:45 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> In-Reply-To: From: vm finance Date: Tue, 17 Sep 2019 23:19:32 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: Jamie Landeg-Jones , Ryan Stone , freebsd-net X-Rspamd-Queue-Id: 46Y8w31ZCTz3Nd7 X-Spamd-Bar: +++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=MIBeCGBQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2f as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [11.50 / 15.00]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[17]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[0.998,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (-6.04), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 06:19:48 -0000 correcting a typo: svn co svn://svn.freebsd.org/base/head /usr/src current revision: 352434 Thank you! On Tue, Sep 17, 2019 at 10:11 PM vm finance wrote: > Actually I am on head already as mentioned previously. Pulled it using > yesterday: > > svn co svn://svn.freebsd.org/base/head /use/src > > > If you could pls let me know the new patch, I can try that. > > Thanks > > Sent from my iPhone > > On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: > > There have been several patches pre-this one that provide > the infrastructure to support BBR. > > Release 12.0 will *not* have these patches and will *not* compile it. > > I have no intention at this point in doing a MFC of this work.. so if you > want > to run BBR you need to run Head > > R > > On Sep 17, 2019, at 7:26 PM, vm finance wrote: > > > Hi Randall, > > > Could you please provide a pointer to the latest patch. I had applied the > one you published Sep-10. > > > Following is what I have done: > > 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > 2. Got VM up under VMPlayer on x86 laptop > > 3. Checked out latest codebase from freebsd repo: > > svn co svn://svn.freebsd.org/base/head /usr/src* > > cd /usr/src; > > make buildworld buildkernel > > [this is where make fails when patch is applied] > > > I could try to build with your latest patch - please send me a pointer. > > > Thanks for your help! > > > > On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart wrote: > > Looking at your make file log I can=E2=80=99t really tell what you are do= ing. > > > Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > Are you cross compiling? > > > I have done the old fashioned kernel make > > > i.e. > > > cd src/sys/amd64/config > > config headvm > > cd ../compile/headvm > > > make cleandepend ; make depend; make -j3 > > > I have done > > > cd src > > make buildkernel KERNCONF=3Dheadvm > > > And even > > > make buildkernel KERNCONF=3DGENERIC > > > to make sure that the build works without bbr. > > > I attach my headvm config.. > > > What exactly are you building and how? kernel config too please? > > > R > > > > > > On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: > > > looking > > > I was at 352408.. let me update and try it > > > R > > > On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: > > > Hmm > > > Did you get the patch I updated too this am? > > > I have built it both with and without the bbr stack and had no issue.. > there was > > an issue with KTLS before the update though. > > > I don=E2=80=99t recognize what you have below there though=E2=80=A6 > > > R > > > On Sep 17, 2019, at 11:47 AM, vm finance wrote: > > > Got it - thank you! > > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > > > Please let me know what am I missing here? > > > Thanks! > > > #svnlite revision > > Path: . > > Working Copy Root Path: /usr/src > > URL: svn://svn.freebsd.org/base/head > > Relative URL: ^/head > > Repository Root: svn://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 352436 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: jah > > Last Changed Rev: 352434 > > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > root@osboxes:/usr/src # > > > -------------------------------------------- snip > ---------------------------- > > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > =3D=3D=3D> sys (cleandir) > > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > > rm: x86: is a directory > > *** Error code 1 > > > Stop. > > make[3]: stopped in /usr/src/sys > > *** Error code 1 > > > Stop. > > make[2]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make[1]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make: stopped in /usr/src > > > > On Tue, Sep 17, 2019 at 6:41 PM vm finance wrote: > > Got it - thank you! > > > btw, I tried to build the patch but its giving an error. Following is SVN > info + make error mesg. > > I have also attached the entire build log...snippet is below > > > Please let me know what am I missing here? > > > Thanks! > > > #svnlite revision > > Path: . > > Working Copy Root Path: /usr/src > > URL: svn://svn.freebsd.org/base/head > > Relative URL: ^/head > > Repository Root: svn://svn.freebsd.org/base > > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > Revision: 352436 > > Node Kind: directory > > Schedule: normal > > Last Changed Author: jah > > Last Changed Rev: 352434 > > Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > root@osboxes:/usr/src # > > > -------------------------------------------- snip > ---------------------------- > > > ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo dev_net.llo > bcache.llo interp_simple.llo zfs_cmd.llo > > rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > =3D=3D=3D> sys (cleandir) > > rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o sack_filter.o > rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > opt_kern_tls.h > > rm: x86: is a directory > > *** Error code 1 > > > Stop. > > make[3]: stopped in /usr/src/sys > > *** Error code 1 > > > Stop. > > make[2]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make[1]: stopped in /usr/src > > *** Error code 1 > > > Stop. > > make: stopped in /usr/src > > > > On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart wrote: > > Pacing is provided by tcp_hpts.c. The current linux patches do not have > > to have fq.. they built an alternate means of doing pacing into bbr. > > > In either case our testing has shown that our pacing is more accurate tha= n > > either fq or the internal pacer :) > > > R > > > On Sep 17, 2019, at 11:05 AM, vm finance wrote: > > > Thanks Randall. > > I was able to apply the patch - now rebuilding the kernel. Would update o= n > how it goes. > > > BTW, is there any description on how lack of tc_fq under FreeBSD is > compensated here? > > The original BBR patches on Linux show that as a must-have? Is that > functionality implemented via tcp_ratelimit.[ch]? > > > Any pointers to existing presentations/discussions highly appreciated? > > > Thanks a lot. > > > On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart wrote: > > You should be able to compile it against the current head. I re-doing tha= t > now (had an > > issue with my machine and had to roll it back to a backup). > > > When I put the patch up on Sept 10th it complied with and without BBR on > whatever > > was that rev.. > > > Looking in the commit logs that would have been around 352191 > > > Hope that helps > > > R > > > On Sep 17, 2019, at 3:32 AM, vm finance wrote: > > > Hi Randall, > > > Thanks for releasing BBR patch: > > https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > Could you please let me know what SVN/GIT label tag this is based on? I > would like to patch and experiment with it. I couldn't find this info in > the released patch. > > > Thanks a lot! > > > On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone wrote: > > rrs@ has just posted the BBR patch to phabricator: > > > https://reviews.freebsd.org/D21582 > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Wed Sep 18 06:21:53 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1008CF2B99 for ; Wed, 18 Sep 2019 06:21:53 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46Y8yR6DZ2z3Ntp for ; Wed, 18 Sep 2019 06:21:51 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [IPv6:2a00:e10:2800::a135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id x8I6LhNB007277 for ; Wed, 18 Sep 2019 08:21:43 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id AFC2F917 for ; Wed, 18 Sep 2019 08:21:43 +0200 (CEST) Subject: Re: if_em(4) carrier loss event not recognized with i217; while 82574 does recognize From: Harry Schmalzbauer To: "freebsd-net@freebsd.org" References: <5AF49AAF.9080305@omnilan.de> <5AF5D232.4080808@omnilan.de> Organization: OmniLAN Message-ID: <116a509f-e264-0b4d-d2e1-83f44d8c6c1c@omnilan.de> Date: Wed, 18 Sep 2019 08:21:43 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <5AF5D232.4080808@omnilan.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]); Wed, 18 Sep 2019 08:21:43 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: ; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 46Y8yR6DZ2z3Ntp X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-5.83 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[omnilan.de]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_EQ_ADDR_ALL(0.00)[]; IP_SCORE(-3.53)[ip: (-9.30), ipnet: 2a00:e10:2800::/38(-4.63), asn: 25074(-3.72), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25074, ipnet:2a00:e10:2800::/38, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 06:21:53 -0000 Am 11.05.2018 um 19:26 schrieb Harry Schmalzbauer: > Bezüglich Harry Schmalzbauer's Nachricht vom 10.05.2018 21:17 (localtime): >> Hello, >> >> if I pull the TP connection from my i217 Clarkville, HEAD still reports >> media >> 1000Base-T status "active". >> >> Doing the same with the other if_em(4) NIC in that box, a hartwell, >> 82574LM, the status correctly changes to "no carrier". >> >> This is not iflib related, since it's reproducable with FreeBSD >> 11-stable (some months old). >> >> Shall I file a PR? > Not reproducable anymore with r333469. Not sure if that post was correct. Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240658 12.1-PRERELEASE showes exaclty the same problem with a i211 (Powerville) MAC, while not reproducable with a i350. Thanks, -harry From owner-freebsd-net@freebsd.org Wed Sep 18 07:19:21 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EC7CEF469F for ; Wed, 18 Sep 2019 07:19:21 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YBDn0yw1z3xD2 for ; Wed, 18 Sep 2019 07:19:20 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from [IPv6:2a02:8109:1140:c3d:14c8:fd55:266f:848c] (unknown [IPv6:2a02:8109:1140:c3d:14c8:fd55:266f:848c]) (Authenticated sender: lurchi) by drew.franken.de (Postfix) with ESMTPSA id A1913721E281E; Wed, 18 Sep 2019 09:10:31 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: BBR patches? From: Michael Tuexen In-Reply-To: Date: Wed, 18 Sep 2019 09:10:30 +0200 Cc: Randall Stewart , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLACK autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 46YBDn0yw1z3xD2 X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of michael.tuexen@lurchi.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=michael.tuexen@lurchi.franken.de X-Spamd-Result: default: False [10.01 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[27.24.175.193.list.dnswl.org : 127.0.5.1]; IP_SCORE(-1.79)[ip: (-9.09), ipnet: 193.174.0.0/15(0.10), asn: 680(0.07), country: DE(-0.01)]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; SUBJECT_ENDS_QUESTION(1.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[franken.de]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; GREYLIST(0.00)[pass,body]; RCVD_TLS_ALL(0.00)[] X-Spam: Yes X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 07:19:22 -0000 > On 18. Sep 2019, at 08:19, vm finance wrote: >=20 > correcting a typo: >=20 > svn co svn://svn.freebsd.org/base/head /usr/src > current revision: 352434 I suggest to build/install head first without any patches. After that = has worked, apply the patches you are interested in. That way it is easy to separate = generic build issues and issue specific to a patch. Best regards Michael >=20 > Thank you! >=20 > On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: >=20 >> Actually I am on head already as mentioned previously. Pulled it = using >> yesterday: >>=20 >> svn co svn://svn.freebsd.org/base/head /use/src >>=20 >>=20 >> If you could pls let me know the new patch, I can try that. >>=20 >> Thanks >>=20 >> Sent from my iPhone >>=20 >> On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: >>=20 >> There have been several patches pre-this one that provide >> the infrastructure to support BBR. >>=20 >> Release 12.0 will *not* have these patches and will *not* compile it. >>=20 >> I have no intention at this point in doing a MFC of this work.. so if = you >> want >> to run BBR you need to run Head >>=20 >> R >>=20 >> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: >>=20 >>=20 >> Hi Randall, >>=20 >>=20 >> Could you please provide a pointer to the latest patch. I had applied = the >> one you published Sep-10. >>=20 >>=20 >> Following is what I have done: >>=20 >> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>=20 >> 2. Got VM up under VMPlayer on x86 laptop >>=20 >> 3. Checked out latest codebase from freebsd repo: >>=20 >> svn co svn://svn.freebsd.org/base/head /usr/src* >>=20 >> cd /usr/src; >>=20 >> make buildworld buildkernel >>=20 >> [this is where make fails when patch is applied] >>=20 >>=20 >> I could try to build with your latest patch - please send me a = pointer. >>=20 >>=20 >> Thanks for your help! >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: >>=20 >> Looking at your make file log I can=E2=80=99t really tell what you = are doing. >>=20 >>=20 >> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>=20 >>=20 >> Are you cross compiling? >>=20 >>=20 >> I have done the old fashioned kernel make >>=20 >>=20 >> i.e. >>=20 >>=20 >> cd src/sys/amd64/config >>=20 >> config headvm >>=20 >> cd ../compile/headvm >>=20 >>=20 >> make cleandepend ; make depend; make -j3 >>=20 >>=20 >> I have done >>=20 >>=20 >> cd src >>=20 >> make buildkernel KERNCONF=3Dheadvm >>=20 >>=20 >> And even >>=20 >>=20 >> make buildkernel KERNCONF=3DGENERIC >>=20 >>=20 >> to make sure that the build works without bbr. >>=20 >>=20 >> I attach my headvm config.. >>=20 >>=20 >> What exactly are you building and how? kernel config too please? >>=20 >>=20 >> R >>=20 >>=20 >>=20 >>=20 >>=20 >> On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote: >>=20 >>=20 >> looking >>=20 >>=20 >> I was at 352408.. let me update and try it >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote: >>=20 >>=20 >> Hmm >>=20 >>=20 >> Did you get the patch I updated too this am? >>=20 >>=20 >> I have built it both with and without the bbr stack and had no = issue.. >> there was >>=20 >> an issue with KTLS before the update though. >>=20 >>=20 >> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>=20 >>=20 >> Got it - thank you! >>=20 >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN >> info + make error mesg. >>=20 >>=20 >> Please let me know what am I missing here? >>=20 >>=20 >> Thanks! >>=20 >>=20 >> #svnlite revision >>=20 >> Path: . >>=20 >> Working Copy Root Path: /usr/src >>=20 >> URL: svn://svn.freebsd.org/base/head >>=20 >> Relative URL: ^/head >>=20 >> Repository Root: svn://svn.freebsd.org/base >>=20 >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>=20 >> Revision: 352436 >>=20 >> Node Kind: directory >>=20 >> Schedule: normal >>=20 >> Last Changed Author: jah >>=20 >> Last Changed Rev: 352434 >>=20 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >>=20 >> root@osboxes:/usr/src # >>=20 >>=20 >> -------------------------------------------- snip >> ---------------------------- >>=20 >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >> bcache.llo interp_simple.llo zfs_cmd.llo >>=20 >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>=20 >> =3D=3D=3D> sys (cleandir) >>=20 >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> opt_kern_tls.h >>=20 >> rm: x86: is a directory >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[3]: stopped in /usr/src/sys >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[2]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[1]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make: stopped in /usr/src >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >>=20 >> Got it - thank you! >>=20 >>=20 >> btw, I tried to build the patch but its giving an error. Following is = SVN >> info + make error mesg. >>=20 >> I have also attached the entire build log...snippet is below >>=20 >>=20 >> Please let me know what am I missing here? >>=20 >>=20 >> Thanks! >>=20 >>=20 >> #svnlite revision >>=20 >> Path: . >>=20 >> Working Copy Root Path: /usr/src >>=20 >> URL: svn://svn.freebsd.org/base/head >>=20 >> Relative URL: ^/head >>=20 >> Repository Root: svn://svn.freebsd.org/base >>=20 >> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>=20 >> Revision: 352436 >>=20 >> Node Kind: directory >>=20 >> Schedule: normal >>=20 >> Last Changed Author: jah >>=20 >> Last Changed Rev: 352434 >>=20 >> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>=20 >>=20 >> root@osboxes:/usr/src # >>=20 >>=20 >> -------------------------------------------- snip >> ---------------------------- >>=20 >>=20 >> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >> bcache.llo interp_simple.llo zfs_cmd.llo >>=20 >> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>=20 >> =3D=3D=3D> sys (cleandir) >>=20 >> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> opt_kern_tls.h >>=20 >> rm: x86: is a directory >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[3]: stopped in /usr/src/sys >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[2]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make[1]: stopped in /usr/src >>=20 >> *** Error code 1 >>=20 >>=20 >> Stop. >>=20 >> make: stopped in /usr/src >>=20 >>=20 >>=20 >> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >>=20 >> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >>=20 >> to have fq.. they built an alternate means of doing pacing into bbr. >>=20 >>=20 >> In either case our testing has shown that our pacing is more accurate = than >>=20 >> either fq or the internal pacer :) >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>=20 >>=20 >> Thanks Randall. >>=20 >> I was able to apply the patch - now rebuilding the kernel. Would = update on >> how it goes. >>=20 >>=20 >> BTW, is there any description on how lack of tc_fq under FreeBSD is >> compensated here? >>=20 >> The original BBR patches on Linux show that as a must-have? Is that >> functionality implemented via tcp_ratelimit.[ch]? >>=20 >>=20 >> Any pointers to existing presentations/discussions highly = appreciated? >>=20 >>=20 >> Thanks a lot. >>=20 >>=20 >> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>=20 >> You should be able to compile it against the current head. I re-doing = that >> now (had an >>=20 >> issue with my machine and had to roll it back to a backup). >>=20 >>=20 >> When I put the patch up on Sept 10th it complied with and without BBR = on >> whatever >>=20 >> was that rev.. >>=20 >>=20 >> Looking in the commit logs that would have been around 352191 >>=20 >>=20 >> Hope that helps >>=20 >>=20 >> R >>=20 >>=20 >> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>=20 >>=20 >> Hi Randall, >>=20 >>=20 >> Thanks for releasing BBR patch: >>=20 >> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>=20 >>=20 >> Could you please let me know what SVN/GIT label tag this is based on? = I >> would like to patch and experiment with it. I couldn't find this info = in >> the released patch. >>=20 >>=20 >> Thanks a lot! >>=20 >>=20 >> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>=20 >> rrs@ has just posted the BBR patch to phabricator: >>=20 >>=20 >> https://reviews.freebsd.org/D21582 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >>=20 >> Randall Stewart >>=20 >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 >>=20 >> ------ >> Randall Stewart >> rrs@netflix.com >>=20 >>=20 >>=20 >>=20 > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Wed Sep 18 07:32:36 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 70443F51A4 for ; Wed, 18 Sep 2019 07:32:36 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 46YBX327KJz40HF for ; Wed, 18 Sep 2019 07:32:34 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id x8I7WW3g008150 for ; Wed, 18 Sep 2019 09:32:32 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id D22E093E for ; Wed, 18 Sep 2019 09:32:32 +0200 (CEST) Subject: iflib NICs don't report/recognize link state changes [Was: Re: if_em(4) carrier loss event not recognized with i217; while 82574 does recognize] From: Harry Schmalzbauer To: "freebsd-net@freebsd.org" References: <5AF49AAF.9080305@omnilan.de> <5AF5D232.4080808@omnilan.de> <116a509f-e264-0b4d-d2e1-83f44d8c6c1c@omnilan.de> Organization: OmniLAN Message-ID: <0a576bd4-1da4-faf7-beaa-a4d7ebc872ad@omnilan.de> Date: Wed, 18 Sep 2019 09:32:32 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <116a509f-e264-0b4d-d2e1-83f44d8c6c1c@omnilan.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: ACL 136 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Wed, 18 Sep 2019 09:32:32 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 46YBX327KJz40HF X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of freebsd@omnilan.de designates 2a00:e10:2800::a130 as permitted sender) smtp.mailfrom=freebsd@omnilan.de X-Spamd-Result: default: False [-5.83 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[omnilan.de]; RCPT_COUNT_ONE(0.00)[1]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_EQ_ADDR_ALL(0.00)[]; IP_SCORE(-3.53)[ip: (-9.30), ipnet: 2a00:e10:2800::/38(-4.64), asn: 25074(-3.72), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25074, ipnet:2a00:e10:2800::/38, country:DE]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 07:32:36 -0000 Am 18.09.2019 um 08:21 schrieb Harry Schmalzbauer: > Am 11.05.2018 um 19:26 schrieb Harry Schmalzbauer: >>   Bezüglich Harry Schmalzbauer's Nachricht vom 10.05.2018 21:17 >> (localtime): >>>   Hello, >>> >>> if I pull the TP connection from my i217 Clarkville, HEAD still reports >>> media >>> 1000Base-T status "active". >>> >>> Doing the same with the other if_em(4) NIC in that box, a hartwell, >>> 82574LM, the status correctly changes to "no carrier". >>> >>> This is not iflib related, since it's reproducable with FreeBSD >>> 11-stable (some months old). >>> >>> Shall I file a PR? >> Not reproducable anymore with r333469. > > Not sure if that post was correct. > > Please see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240658 > 12.1-PRERELEASE showes exaclty the same problem with a i211 > (Powerville) MAC, while not reproducable with a i350. Nonsense, sorry. Haven't spent the appropriate attention before… But since this is a major issue for if_lagg(4) users,  I did at least a comperhensive state change test. All if_igb(4) NICs I have available for testing are affecetd, and also if_em(4) with 82574L (Hartwell). Please see the mentioned bug report, where I added all tested NICs. Couldn't remember where I used a i211 (Pearsonville, not Powerville), so this is missing the the latest test. Thanks, -Harry From owner-freebsd-net@freebsd.org Wed Sep 18 12:45:58 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5956BFCAAD for ; Wed, 18 Sep 2019 12:45:58 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YKTd2h6bz4Gsc for ; Wed, 18 Sep 2019 12:45:57 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lj1-f170.google.com with SMTP id m13so7020209ljj.11 for ; Wed, 18 Sep 2019 05:45:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=P1l4FaofJ7NBqnFzhErkLDRujRpeUXvODiFsTAek2Dk=; b=R5LLizIoEAcimerBP9aHOZr2JwM8i1baVzdgSs0xhsZSLHMSm21obP9L0NsSC7j3eZ 3HdB4eHMP9p5DXe+qp7Mf1dSohVeamMiVKoHSDrj6zcZUsnzJ4ZGuK4pv14pN+TjJ3f+ gX5UzkbByxAmWduxqlOH6fhyywY5tTwHzRvzWK88r6iCajKlvis5Rc06CZYh5TAjsm5M g3EWYobnFn3W3vpMP9mYnRTte3iZ5AT52jaCEJ+oGLkAbNGFP6EHzQSPp9Wuykqawogp 5B5YUx98YJF5/HRqWXpYbSHoCsFNK25Df807TyBS3o4ZlnuGXo68p3UUyuMee92hbF4K F3uQ== X-Gm-Message-State: APjAAAWSSAeaGqFnwXAc8DtL0hG+L2UX45WtkPwmkDoqrBh8BX65EUlj VaScgFn7eJ4EFrrjJz1mmxEIMcxt X-Google-Smtp-Source: APXvYqwYlqQCZs1a/zRWz6OT50pKeOTBbfesnRxeFICgEe+7x1wNvRtRtcIfmJlGSkaovfoi3Yf5xA== X-Received: by 2002:a05:651c:292:: with SMTP id b18mr2179114ljo.131.1568810755191; Wed, 18 Sep 2019 05:45:55 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id x76sm1185043ljb.81.2019.09.18.05.45.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Sep 2019 05:45:53 -0700 (PDT) Subject: Re: ixv + PCBGROUP + RSS: problem establishing an outgoing TCP connection From: Andriy Gapon To: "freebsd-net@freebsd.org" References: <29ed38c7-5835-b354-368a-f9ebaddc9a7d@FreeBSD.org> Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= mQINBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABtB5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz6JAlQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryLkCDQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAYkCPAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: <5196d3e2-5237-df5b-713c-1e0f84908238@FreeBSD.org> Date: Wed, 18 Sep 2019 15:45:52 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <29ed38c7-5835-b354-368a-f9ebaddc9a7d@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 46YKTd2h6bz4Gsc X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-3.23 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_COUNT_THREE(0.00)[3]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[96.151.72.93.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; DMARC_NA(0.00)[FreeBSD.org]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-1.23)[ip: (-0.53), ipnet: 209.85.128.0/17(-3.31), asn: 15169(-2.23), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[170.208.85.209.list.dnswl.org : 127.0.5.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[170.208.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 12:45:58 -0000 Here is a change that I would like to propose based on the earlier observations and findings: https://reviews.freebsd.org/D21705 On 11/09/2019 09:15, Andriy Gapon wrote: > On 10/09/2019 12:14, Andriy Gapon wrote: >> >> This happens on an EC2 instance with ixv driver. > > I wonder if anyone ever tested ixv with PCBGROUP... > I see a trivial but severe bug. > if_ixv.c does not include opt_rss.h. Because of this IXGBE_FEATURE_RSS gets > defined to zero (in ixgbe_features.h). So, instead of of using rss_getkey() to > get the RSS key, the driver just generates a random one. > No surprise then that the hardware (VF) produces totally different hashes. > But maybe that's not all. > > On top of that, I wonder why the driver enables RSS in the hardware when feat_en > does not have IXGBE_FEATURE_RSS. > Could anyone please explain the logic behind that? > Please see ixv_initialize_rss_mapping. > For example: > if (adapter->feat_en & IXGBE_FEATURE_RSS) { > /* Fetch the configured RSS key */ > rss_getkey((uint8_t *)&rss_key); > } else { > /* set up random bits */ > arc4rand(&rss_key, sizeof(rss_key), 0); > } > And so on. > > Additionally, I found this bit of information: > The limitation for VF RSS on Intel® 82599 10 Gigabit Ethernet Controller is: The > hash and key are shared among PF and all VF, the RETA table with 128 entries is > also shared among PF and all VF; So it could not to provide a method to query > the hash and reta content per VF on guest, while, if possible, please query them > on host for the shared RETA information. > > And my "hardware" is exactly 82599 VF. > I hacked the driver to not call ixv_initialize_rss_mapping() at all, but even > with that change the packet descriptors had IXGBE_RXDADV_RSSTYPE_IPV4_TCP in > pkt_info. Maybe it's because of how PF was configured. > So, I wonder if ixgbe_isc_rxd_pkt_get() should be modified to not set iri_flowid > and iri_rsstype under some conditions. > >> When I try to establish an outgoing TCP connection I see the following exchange. >> Local side sends SYN, it receives SYN+ACK and immediately sends RST. >> I tracked this down to in_pcblookup_mbuf() failing to find the corresponding inpcb. >> >> I dug a bit deeper and this is my understanding of the issue. >> >> When tcp_connect() calls in_pcbrehash() the inpcb gets placed into a group >> determined by in_pcbgroup_bytuple() [see in_pcbgroup_update and >> in_pcbgroup_byinpcb]. The inpcb does not have INP_RSS_BUCKET_SET. Both >> addresses and ports are populated at that time. >> >> When the reply packet is received, in_pcblookup_mbuf() uses in_pcbgroup_byhash() >> to look up the group because the packet has M_HASHTYPE_RSS_TCP_IPV4. >> The problem is that in_pcbgroup_byhash() returns a different group and the inpcb >> cannot be found. >> >> I am very new to this code, so I would appreciate any help with further >> debugging and root causing the problem. > > > > -- Andriy Gapon From owner-freebsd-net@freebsd.org Wed Sep 18 13:20:38 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5BF91FD546 for ; Wed, 18 Sep 2019 13:20:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46YLFf1pMRz4Jkq for ; Wed, 18 Sep 2019 13:20:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3DECEFD545; Wed, 18 Sep 2019 13:20:38 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3DB98FD544 for ; Wed, 18 Sep 2019 13:20:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YLFf0sw8z4Jkp for ; Wed, 18 Sep 2019 13:20:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F12DC25825 for ; Wed, 18 Sep 2019 13:20:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8IDKbcp031912 for ; Wed, 18 Sep 2019 13:20:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8IDKbtM031840 for net@FreeBSD.org; Wed, 18 Sep 2019 13:20:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240658] iflib: if_igb(4) and some if_em(4) devices don't recognize/report carrier loss. Date: Wed, 18 Sep 2019 13:20:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 13:20:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240658 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Sep 18 13:50:40 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7C296FDF20 for ; Wed, 18 Sep 2019 13:50:40 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YLwH5ZNPz4L7P for ; Wed, 18 Sep 2019 13:50:39 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x543.google.com with SMTP id w10so4144429pgj.7 for ; Wed, 18 Sep 2019 06:50:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=WyzKwGZaCpQ38Ijq2PjDwdKBIem0M+Nz/a1EPZ9iCdw=; b=hgHr18QwpnX4adMfiEoXRSYOlhqwFVZLlk0TpgIA11diTZNcnglC0RSr5xPbcmV05x I8eSGvYRBeNYEhm/evyr7hKZ5KPPM+fEAgrhO83/tj1Y+zHQ/kgIgttCJBOvXa5NSfmY UZS/Ty1ta1822GEXTaGru/1makUyhWoxd85vjPMhroSzj+m7OVqzGg99TBRaYDJ1Fakw c0nGMxuIFJFKz1ucXIR1bLCGnqCWnK22DrKM0ZuEYpmtcbWfNWPb6+GL8hEhU0ffsEum QS13mPrGybY4xRr1RL9N5rThlTdpuG/622DUtRMDv6fjdV1iMlk/oyhy0DT/AFhXmYB+ OIFg== X-Gm-Message-State: APjAAAUxWNkjmiTTTcd7U9Jz4lT6tX/zFdSNe9fX96eDDxe1H5zsDaRz dHt0khmI8pG63xbEXpsYQm1G5g== X-Google-Smtp-Source: APXvYqzrsLIVQ2HTX+abHa6vlAqVn4t1enJhBR5H+N3y+BMV4c7/b8CTEklFd6/FAQy5XEnoxflS/Q== X-Received: by 2002:aa7:98d2:: with SMTP id e18mr4339841pfm.188.1568814637630; Wed, 18 Sep 2019 06:50:37 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::c2ea? ([2607:fb10:7021:1::c2ea]) by smtp.gmail.com with ESMTPSA id f6sm5682535pga.50.2019.09.18.06.50.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 06:50:36 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Wed, 18 Sep 2019 06:50:35 -0700 Cc: vm finance , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> To: =?utf-8?Q?Michael_T=C3=BCxen?= X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46YLwH5ZNPz4L7P X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.11 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(0.00)[netflix.com,reject]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.964,0]; R_DKIM_ALLOW(0.00)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.995,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[3.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-1.15)[ip: (-0.77), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 13:50:40 -0000 Thats great idea Michael. =46rom the look fo the build log I was sent, his blow-up has nothing to = do with the patches. He should probably 1) Check out a fresh version of head. 2) Follow the instructions in UPDATING to get a clean build. =E2=80=94 make buildworld =E2=80=94 make buildkernel KERNCONF=3Dhis-conf =E2=80=94 make installkernel KERNCONF=3Dhis-conf =20 ** do the reboot and merge master ** Then after that he could 3) Apply the current patch in the review 4) do build that =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN = -DNO_CLEANDIR =E2=80=94 make install kernel KERNCONF=3Dhis_conf And he should have it all working :) I have done multiple builds with the latest head from yesterday both = with and without the extra stacks and hpts.. and I can=E2=80=99t get a build failure.. = this would verify he can at least build head.. R > On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: >=20 >> On 18. Sep 2019, at 08:19, vm finance wrote: >>=20 >> correcting a typo: >>=20 >> svn co svn://svn.freebsd.org/base/head /usr/src >> current revision: 352434 > I suggest to build/install head first without any patches. After that = has worked, > apply the patches you are interested in. That way it is easy to = separate generic > build issues and issue specific to a patch. >=20 > Best regards > Michael >>=20 >> Thank you! >>=20 >> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: >>=20 >>> Actually I am on head already as mentioned previously. Pulled it = using >>> yesterday: >>>=20 >>> svn co svn://svn.freebsd.org/base/head /use/src >>>=20 >>>=20 >>> If you could pls let me know the new patch, I can try that. >>>=20 >>> Thanks >>>=20 >>> Sent from my iPhone >>>=20 >>> On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: >>>=20 >>> There have been several patches pre-this one that provide >>> the infrastructure to support BBR. >>>=20 >>> Release 12.0 will *not* have these patches and will *not* compile = it. >>>=20 >>> I have no intention at this point in doing a MFC of this work.. so = if you >>> want >>> to run BBR you need to run Head >>>=20 >>> R >>>=20 >>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: >>>=20 >>>=20 >>> Hi Randall, >>>=20 >>>=20 >>> Could you please provide a pointer to the latest patch. I had = applied the >>> one you published Sep-10. >>>=20 >>>=20 >>> Following is what I have done: >>>=20 >>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>>=20 >>> 2. Got VM up under VMPlayer on x86 laptop >>>=20 >>> 3. Checked out latest codebase from freebsd repo: >>>=20 >>> svn co svn://svn.freebsd.org/base/head /usr/src* >>>=20 >>> cd /usr/src; >>>=20 >>> make buildworld buildkernel >>>=20 >>> [this is where make fails when patch is applied] >>>=20 >>>=20 >>> I could try to build with your latest patch - please send me a = pointer. >>>=20 >>>=20 >>> Thanks for your help! >>>=20 >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: >>>=20 >>> Looking at your make file log I can=E2=80=99t really tell what you = are doing. >>>=20 >>>=20 >>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>>=20 >>>=20 >>> Are you cross compiling? >>>=20 >>>=20 >>> I have done the old fashioned kernel make >>>=20 >>>=20 >>> i.e. >>>=20 >>>=20 >>> cd src/sys/amd64/config >>>=20 >>> config headvm >>>=20 >>> cd ../compile/headvm >>>=20 >>>=20 >>> make cleandepend ; make depend; make -j3 >>>=20 >>>=20 >>> I have done >>>=20 >>>=20 >>> cd src >>>=20 >>> make buildkernel KERNCONF=3Dheadvm >>>=20 >>>=20 >>> And even >>>=20 >>>=20 >>> make buildkernel KERNCONF=3DGENERIC >>>=20 >>>=20 >>> to make sure that the build works without bbr. >>>=20 >>>=20 >>> I attach my headvm config.. >>>=20 >>>=20 >>> What exactly are you building and how? kernel config too please? >>>=20 >>>=20 >>> R >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: >>>=20 >>>=20 >>> looking >>>=20 >>>=20 >>> I was at 352408.. let me update and try it >>>=20 >>>=20 >>> R >>>=20 >>>=20 >>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: >>>=20 >>>=20 >>> Hmm >>>=20 >>>=20 >>> Did you get the patch I updated too this am? >>>=20 >>>=20 >>> I have built it both with and without the bbr stack and had no = issue.. >>> there was >>>=20 >>> an issue with KTLS before the update though. >>>=20 >>>=20 >>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>>=20 >>>=20 >>> R >>>=20 >>>=20 >>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>>=20 >>>=20 >>> Got it - thank you! >>>=20 >>>=20 >>> btw, I tried to build the patch but its giving an error. Following = is SVN >>> info + make error mesg. >>>=20 >>>=20 >>> Please let me know what am I missing here? >>>=20 >>>=20 >>> Thanks! >>>=20 >>>=20 >>> #svnlite revision >>>=20 >>> Path: . >>>=20 >>> Working Copy Root Path: /usr/src >>>=20 >>> URL: svn://svn.freebsd.org/base/head >>>=20 >>> Relative URL: ^/head >>>=20 >>> Repository Root: svn://svn.freebsd.org/base >>>=20 >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>=20 >>> Revision: 352436 >>>=20 >>> Node Kind: directory >>>=20 >>> Schedule: normal >>>=20 >>> Last Changed Author: jah >>>=20 >>> Last Changed Rev: 352434 >>>=20 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>=20 >>>=20 >>> root@osboxes:/usr/src # >>>=20 >>>=20 >>> -------------------------------------------- snip >>> ---------------------------- >>>=20 >>>=20 >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >>> bcache.llo interp_simple.llo zfs_cmd.llo >>>=20 >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>=20 >>> =3D=3D=3D> sys (cleandir) >>>=20 >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >>> opt_kern_tls.h >>>=20 >>> rm: x86: is a directory >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[3]: stopped in /usr/src/sys >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[2]: stopped in /usr/src >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[1]: stopped in /usr/src >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make: stopped in /usr/src >>>=20 >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >>>=20 >>> Got it - thank you! >>>=20 >>>=20 >>> btw, I tried to build the patch but its giving an error. Following = is SVN >>> info + make error mesg. >>>=20 >>> I have also attached the entire build log...snippet is below >>>=20 >>>=20 >>> Please let me know what am I missing here? >>>=20 >>>=20 >>> Thanks! >>>=20 >>>=20 >>> #svnlite revision >>>=20 >>> Path: . >>>=20 >>> Working Copy Root Path: /usr/src >>>=20 >>> URL: svn://svn.freebsd.org/base/head >>>=20 >>> Relative URL: ^/head >>>=20 >>> Repository Root: svn://svn.freebsd.org/base >>>=20 >>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>=20 >>> Revision: 352436 >>>=20 >>> Node Kind: directory >>>=20 >>> Schedule: normal >>>=20 >>> Last Changed Author: jah >>>=20 >>> Last Changed Rev: 352434 >>>=20 >>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>=20 >>>=20 >>> root@osboxes:/usr/src # >>>=20 >>>=20 >>> -------------------------------------------- snip >>> ---------------------------- >>>=20 >>>=20 >>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >>> bcache.llo interp_simple.llo zfs_cmd.llo >>>=20 >>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>=20 >>> =3D=3D=3D> sys (cleandir) >>>=20 >>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >>> opt_kern_tls.h >>>=20 >>> rm: x86: is a directory >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[3]: stopped in /usr/src/sys >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[2]: stopped in /usr/src >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make[1]: stopped in /usr/src >>>=20 >>> *** Error code 1 >>>=20 >>>=20 >>> Stop. >>>=20 >>> make: stopped in /usr/src >>>=20 >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >>>=20 >>> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >>>=20 >>> to have fq.. they built an alternate means of doing pacing into bbr. >>>=20 >>>=20 >>> In either case our testing has shown that our pacing is more = accurate than >>>=20 >>> either fq or the internal pacer :) >>>=20 >>>=20 >>> R >>>=20 >>>=20 >>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>>=20 >>>=20 >>> Thanks Randall. >>>=20 >>> I was able to apply the patch - now rebuilding the kernel. Would = update on >>> how it goes. >>>=20 >>>=20 >>> BTW, is there any description on how lack of tc_fq under FreeBSD is >>> compensated here? >>>=20 >>> The original BBR patches on Linux show that as a must-have? Is that >>> functionality implemented via tcp_ratelimit.[ch]? >>>=20 >>>=20 >>> Any pointers to existing presentations/discussions highly = appreciated? >>>=20 >>>=20 >>> Thanks a lot. >>>=20 >>>=20 >>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>>=20 >>> You should be able to compile it against the current head. I = re-doing that >>> now (had an >>>=20 >>> issue with my machine and had to roll it back to a backup). >>>=20 >>>=20 >>> When I put the patch up on Sept 10th it complied with and without = BBR on >>> whatever >>>=20 >>> was that rev.. >>>=20 >>>=20 >>> Looking in the commit logs that would have been around 352191 >>>=20 >>>=20 >>> Hope that helps >>>=20 >>>=20 >>> R >>>=20 >>>=20 >>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>>=20 >>>=20 >>> Hi Randall, >>>=20 >>>=20 >>> Thanks for releasing BBR patch: >>>=20 >>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>>=20 >>>=20 >>> Could you please let me know what SVN/GIT label tag this is based = on? I >>> would like to patch and experiment with it. I couldn't find this = info in >>> the released patch. >>>=20 >>>=20 >>> Thanks a lot! >>>=20 >>>=20 >>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>>=20 >>> rrs@ has just posted the BBR patch to phabricator: >>>=20 >>>=20 >>> https://reviews.freebsd.org/D21582 >>>=20 >>>=20 >>> ------ >>>=20 >>> Randall Stewart >>>=20 >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> ------ >>>=20 >>> Randall Stewart >>>=20 >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> ------ >>>=20 >>> Randall Stewart >>>=20 >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> ------ >>>=20 >>> Randall Stewart >>>=20 >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> ------ >>>=20 >>> Randall Stewart >>>=20 >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>>=20 >>>=20 >>>=20 >>>=20 >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Wed Sep 18 13:53:34 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AC0ABFE115 for ; Wed, 18 Sep 2019 13:53:34 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YLzf27KBz4LQp for ; Wed, 18 Sep 2019 13:53:33 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pl1-x641.google.com with SMTP id s17so3229910plp.2 for ; Wed, 18 Sep 2019 06:53:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=X5ljNATsEgZqo1ZtnC/A/PaekYumL8m8yiLlu268MMY=; b=Er/6Bs682i15dPnoQr1stzcR57qWvCasSOjDm54mTQLKhCXUKBqIGWe5HqTt/ciZ8e BjZ1EXjphfIq5z7clEqbwd2S523kxoF7ciPd1VOWnBbcmdj/7+izIaV7okWzDTLptSTb 9+SagVnoj8axHJnJJ7b+yhkAO/v9/dO9s2RglbEstnZGVc2zgdYqwZwFR8rDlozN+Zus m+QR2u0xmujVZq3ETa7yxyDtxbKxFYnqgfSjGUgO1VyUFkiWoT+TMvK3RLrBLCo2jwLU egfzcXINLNg/8ZdgbDKs4rfkWIBcOmSOoUaK7xlQRIYvVyNOFraxmdNxyUgbCwBkGnHg 3vUw== X-Gm-Message-State: APjAAAU1Lit36/x6IgSfoDqiOY7Ylvbt5Q9sRlzZOIJYuxMvzcRMxVUa 1yGDHK4QIf199/kqKbXtXZHKpg== X-Google-Smtp-Source: APXvYqytwkuD/bTCYpbDLIW0inEnkmgVDAV+SLxCrBbI2rFs7cUOacV16H1OGjuVClpGyDksiwUbYg== X-Received: by 2002:a17:902:8d95:: with SMTP id v21mr4001383plo.77.1568814812650; Wed, 18 Sep 2019 06:53:32 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::c2ea? ([2607:fb10:7021:1::c2ea]) by smtp.gmail.com with ESMTPSA id b10sm6340129pfi.85.2019.09.18.06.53.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 06:53:32 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> Date: Wed, 18 Sep 2019 06:53:30 -0700 Cc: vm finance , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> To: =?utf-8?Q?Michael_T=C3=BCxen?= X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46YLzf27KBz4LQp X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.07 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36:c]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(0.00)[netflix.com,reject]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.973,0]; R_DKIM_ALLOW(0.00)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.997,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-1.10)[ip: (-0.54), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 13:53:34 -0000 One other note.. I notice his kernel conf he sent does not have the right things to get BBR even to attempt to build. I would suggest using that config for the first steps.. then he must add the additional tcp stacks and the hpts in order to get bbr/rack and any = other extra stack=E2=80=A6.=20 But I would suggest to build with his current config first and once he = has that in place and building a) apply the patch b) add the extra kernel options R > On Sep 18, 2019, at 6:50 AM, Randall Stewart wrote: >=20 > Thats great idea Michael. >=20 > =46rom the look fo the build log I was sent, his blow-up has nothing = to do > with the patches. >=20 > He should probably >=20 > 1) Check out a fresh version of head. > 2) Follow the instructions in UPDATING to get a clean build. > =E2=80=94 make buildworld > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >=20 > ** do the reboot and merge master ** >=20 > Then after that he could >=20 > 3) Apply the current patch in the review > 4) do build that > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN = -DNO_CLEANDIR > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >=20 > And he should have it all working :) >=20 > I have done multiple builds with the latest head from yesterday both = with and without > the extra stacks and hpts.. and I can=E2=80=99t get a build failure.. = this would verify he can > at least build head.. >=20 > R >=20 >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: >>=20 >>> On 18. Sep 2019, at 08:19, vm finance wrote: >>>=20 >>> correcting a typo: >>>=20 >>> svn co svn://svn.freebsd.org/base/head /usr/src >>> current revision: 352434 >> I suggest to build/install head first without any patches. After that = has worked, >> apply the patches you are interested in. That way it is easy to = separate generic >> build issues and issue specific to a patch. >>=20 >> Best regards >> Michael >>>=20 >>> Thank you! >>>=20 >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: >>>=20 >>>> Actually I am on head already as mentioned previously. Pulled it = using >>>> yesterday: >>>>=20 >>>> svn co svn://svn.freebsd.org/base/head /use/src >>>>=20 >>>>=20 >>>> If you could pls let me know the new patch, I can try that. >>>>=20 >>>> Thanks >>>>=20 >>>> Sent from my iPhone >>>>=20 >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart = wrote: >>>>=20 >>>> There have been several patches pre-this one that provide >>>> the infrastructure to support BBR. >>>>=20 >>>> Release 12.0 will *not* have these patches and will *not* compile = it. >>>>=20 >>>> I have no intention at this point in doing a MFC of this work.. so = if you >>>> want >>>> to run BBR you need to run Head >>>>=20 >>>> R >>>>=20 >>>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: >>>>=20 >>>>=20 >>>> Hi Randall, >>>>=20 >>>>=20 >>>> Could you please provide a pointer to the latest patch. I had = applied the >>>> one you published Sep-10. >>>>=20 >>>>=20 >>>> Following is what I have done: >>>>=20 >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>>>=20 >>>> 2. Got VM up under VMPlayer on x86 laptop >>>>=20 >>>> 3. Checked out latest codebase from freebsd repo: >>>>=20 >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >>>>=20 >>>> cd /usr/src; >>>>=20 >>>> make buildworld buildkernel >>>>=20 >>>> [this is where make fails when patch is applied] >>>>=20 >>>>=20 >>>> I could try to build with your latest patch - please send me a = pointer. >>>>=20 >>>>=20 >>>> Thanks for your help! >>>>=20 >>>>=20 >>>>=20 >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: >>>>=20 >>>> Looking at your make file log I can=E2=80=99t really tell what you = are doing. >>>>=20 >>>>=20 >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>>>=20 >>>>=20 >>>> Are you cross compiling? >>>>=20 >>>>=20 >>>> I have done the old fashioned kernel make >>>>=20 >>>>=20 >>>> i.e. >>>>=20 >>>>=20 >>>> cd src/sys/amd64/config >>>>=20 >>>> config headvm >>>>=20 >>>> cd ../compile/headvm >>>>=20 >>>>=20 >>>> make cleandepend ; make depend; make -j3 >>>>=20 >>>>=20 >>>> I have done >>>>=20 >>>>=20 >>>> cd src >>>>=20 >>>> make buildkernel KERNCONF=3Dheadvm >>>>=20 >>>>=20 >>>> And even >>>>=20 >>>>=20 >>>> make buildkernel KERNCONF=3DGENERIC >>>>=20 >>>>=20 >>>> to make sure that the build works without bbr. >>>>=20 >>>>=20 >>>> I attach my headvm config.. >>>>=20 >>>>=20 >>>> What exactly are you building and how? kernel config too please? >>>>=20 >>>>=20 >>>> R >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: >>>>=20 >>>>=20 >>>> looking >>>>=20 >>>>=20 >>>> I was at 352408.. let me update and try it >>>>=20 >>>>=20 >>>> R >>>>=20 >>>>=20 >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: >>>>=20 >>>>=20 >>>> Hmm >>>>=20 >>>>=20 >>>> Did you get the patch I updated too this am? >>>>=20 >>>>=20 >>>> I have built it both with and without the bbr stack and had no = issue.. >>>> there was >>>>=20 >>>> an issue with KTLS before the update though. >>>>=20 >>>>=20 >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >>>>=20 >>>>=20 >>>> R >>>>=20 >>>>=20 >>>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: >>>>=20 >>>>=20 >>>> Got it - thank you! >>>>=20 >>>>=20 >>>> btw, I tried to build the patch but its giving an error. Following = is SVN >>>> info + make error mesg. >>>>=20 >>>>=20 >>>> Please let me know what am I missing here? >>>>=20 >>>>=20 >>>> Thanks! >>>>=20 >>>>=20 >>>> #svnlite revision >>>>=20 >>>> Path: . >>>>=20 >>>> Working Copy Root Path: /usr/src >>>>=20 >>>> URL: svn://svn.freebsd.org/base/head >>>>=20 >>>> Relative URL: ^/head >>>>=20 >>>> Repository Root: svn://svn.freebsd.org/base >>>>=20 >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>=20 >>>> Revision: 352436 >>>>=20 >>>> Node Kind: directory >>>>=20 >>>> Schedule: normal >>>>=20 >>>> Last Changed Author: jah >>>>=20 >>>> Last Changed Rev: 352434 >>>>=20 >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>=20 >>>>=20 >>>> root@osboxes:/usr/src # >>>>=20 >>>>=20 >>>> -------------------------------------------- snip >>>> ---------------------------- >>>>=20 >>>>=20 >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>>>=20 >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>=20 >>>> =3D=3D=3D> sys (cleandir) >>>>=20 >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >>>> opt_kern_tls.h >>>>=20 >>>> rm: x86: is a directory >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[3]: stopped in /usr/src/sys >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[2]: stopped in /usr/src >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[1]: stopped in /usr/src >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make: stopped in /usr/src >>>>=20 >>>>=20 >>>>=20 >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: >>>>=20 >>>> Got it - thank you! >>>>=20 >>>>=20 >>>> btw, I tried to build the patch but its giving an error. Following = is SVN >>>> info + make error mesg. >>>>=20 >>>> I have also attached the entire build log...snippet is below >>>>=20 >>>>=20 >>>> Please let me know what am I missing here? >>>>=20 >>>>=20 >>>> Thanks! >>>>=20 >>>>=20 >>>> #svnlite revision >>>>=20 >>>> Path: . >>>>=20 >>>> Working Copy Root Path: /usr/src >>>>=20 >>>> URL: svn://svn.freebsd.org/base/head >>>>=20 >>>> Relative URL: ^/head >>>>=20 >>>> Repository Root: svn://svn.freebsd.org/base >>>>=20 >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>=20 >>>> Revision: 352436 >>>>=20 >>>> Node Kind: directory >>>>=20 >>>> Schedule: normal >>>>=20 >>>> Last Changed Author: jah >>>>=20 >>>> Last Changed Rev: 352434 >>>>=20 >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >>>>=20 >>>>=20 >>>> root@osboxes:/usr/src # >>>>=20 >>>>=20 >>>> -------------------------------------------- snip >>>> ---------------------------- >>>>=20 >>>>=20 >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>>>=20 >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>>>=20 >>>> =3D=3D=3D> sys (cleandir) >>>>=20 >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >>>> opt_kern_tls.h >>>>=20 >>>> rm: x86: is a directory >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[3]: stopped in /usr/src/sys >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[2]: stopped in /usr/src >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make[1]: stopped in /usr/src >>>>=20 >>>> *** Error code 1 >>>>=20 >>>>=20 >>>> Stop. >>>>=20 >>>> make: stopped in /usr/src >>>>=20 >>>>=20 >>>>=20 >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: >>>>=20 >>>> Pacing is provided by tcp_hpts.c. The current linux patches do not = have >>>>=20 >>>> to have fq.. they built an alternate means of doing pacing into = bbr. >>>>=20 >>>>=20 >>>> In either case our testing has shown that our pacing is more = accurate than >>>>=20 >>>> either fq or the internal pacer :) >>>>=20 >>>>=20 >>>> R >>>>=20 >>>>=20 >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: >>>>=20 >>>>=20 >>>> Thanks Randall. >>>>=20 >>>> I was able to apply the patch - now rebuilding the kernel. Would = update on >>>> how it goes. >>>>=20 >>>>=20 >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is >>>> compensated here? >>>>=20 >>>> The original BBR patches on Linux show that as a must-have? Is that >>>> functionality implemented via tcp_ratelimit.[ch]? >>>>=20 >>>>=20 >>>> Any pointers to existing presentations/discussions highly = appreciated? >>>>=20 >>>>=20 >>>> Thanks a lot. >>>>=20 >>>>=20 >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: >>>>=20 >>>> You should be able to compile it against the current head. I = re-doing that >>>> now (had an >>>>=20 >>>> issue with my machine and had to roll it back to a backup). >>>>=20 >>>>=20 >>>> When I put the patch up on Sept 10th it complied with and without = BBR on >>>> whatever >>>>=20 >>>> was that rev.. >>>>=20 >>>>=20 >>>> Looking in the commit logs that would have been around 352191 >>>>=20 >>>>=20 >>>> Hope that helps >>>>=20 >>>>=20 >>>> R >>>>=20 >>>>=20 >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: >>>>=20 >>>>=20 >>>> Hi Randall, >>>>=20 >>>>=20 >>>> Thanks for releasing BBR patch: >>>>=20 >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>>>=20 >>>>=20 >>>> Could you please let me know what SVN/GIT label tag this is based = on? I >>>> would like to patch and experiment with it. I couldn't find this = info in >>>> the released patch. >>>>=20 >>>>=20 >>>> Thanks a lot! >>>>=20 >>>>=20 >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: >>>>=20 >>>> rrs@ has just posted the BBR patch to phabricator: >>>>=20 >>>>=20 >>>> https://reviews.freebsd.org/D21582 >>>>=20 >>>>=20 >>>> ------ >>>>=20 >>>> Randall Stewart >>>>=20 >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> ------ >>>>=20 >>>> Randall Stewart >>>>=20 >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> ------ >>>>=20 >>>> Randall Stewart >>>>=20 >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> ------ >>>>=20 >>>> Randall Stewart >>>>=20 >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> ------ >>>>=20 >>>> Randall Stewart >>>>=20 >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> ------ >>>> Randall Stewart >>>> rrs@netflix.com >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Wed Sep 18 14:03:19 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42AC5FE635 for ; Wed, 18 Sep 2019 14:03:19 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YMBt5q6Dz4M1n for ; Wed, 18 Sep 2019 14:03:18 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id h144so16373431iof.7 for ; Wed, 18 Sep 2019 07:03:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VmOVhCqKZJfyfkoT9cuFMfg4yK2aW3n1hynvCOiLA9s=; b=sEurX5mv+u4lc/Z8xMf7qPCvYKb34rUzahgWeNSr0zoxWc6NJ3Hg9HSSb9VFvoNv/D 0PxZ9+4nnJ+02Enbl3744TpLiE7MdJ17YTm81CjAswO46D9zWRQ364vuLRcs5n9ndl+z zFFWl8hUcoxAHVQpbXiqN2x9CZ0HIU94fODBipxSKfwm4I7StarhJoexkkfC8Ra9C3mF PC4xDqorS0UkMI2Np58WU+KWNOBbk8cY6kutZfDhN27JmmVPYSEpvZ5K+Y/fprc3pSmq xdGc7HK4J0DoGgfW5O64P6ZKimJHr+K3jZl+EnXmvz3h4lC9SOWYOVYsm8PhZpN0xRTE E/2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VmOVhCqKZJfyfkoT9cuFMfg4yK2aW3n1hynvCOiLA9s=; b=aMBrhGGjOAsgSpH4/zE047px58fIKuk+chwHy3PuQY4LojNhdJbGKjk7qkGGgUMZOV rbEnHAGUJ4I+wNEKDicnnFH481V+fgy3fWo7NbjU7Dn1isfPdCJjXzDCRxN1qy9PxAZR pkxMFf44iXKfsKnvMkDDddBNj8i04KwpmkULusWwUP5cHcqs0pwtzVd1oHXUMB6Ka7eI JvWgT1rSKbbBteuqii9JPD5Kff/eR01GII3S6ohatE8pNL0XSxzqzP87xc/FupY9Xbec c6bkUIZD8yg8kgFqp0UVisYpt2mYS3/oHIoS30ZW589Ow95pMW824r1Q+95w71Ct14Td hlHg== X-Gm-Message-State: APjAAAVzTjnD2/BxnAT4j8uoEg3p811kYGXsjTe1qRPme6TKbKoOoZoQ oCf85VvqFm5KIqy+UZnn3WQUAqEazWm6u6CfNdA= X-Google-Smtp-Source: APXvYqzMEi/+5k3e/VX5lIGpfAUs9+yKWsukNPSIGEUl8R+Y/Y+JTaq4yqJqC7toRVOQ9D9UGlu6eK12rQJdIQVMvvg= X-Received: by 2002:a02:ac82:: with SMTP id x2mr5095456jan.18.1568815397008; Wed, 18 Sep 2019 07:03:17 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> In-Reply-To: <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> From: vm finance Date: Wed, 18 Sep 2019 07:03:05 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46YMBt5q6Dz4M1n X-Spamd-Bar: +++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=sEurX5mv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d43 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [11.50 / 15.00]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[21]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[3.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (2.08), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:03:19 -0000 Thanks Randall, Michael, I did "svn svn://svn.freebsd.org/base/head /usr/src" and now doing "make buildworld buildkernel" [I didn't change anything in configs - just whatever are the defaults] I would update as soon as its done. Thanks again! On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart wrote: > One other note.. I notice his kernel conf he sent does not have > the right things to get BBR even to attempt to build. > > I would suggest using that config for the first steps.. then he must add > the additional tcp stacks and the hpts in order to get bbr/rack and any > other > extra stack=E2=80=A6. > > But I would suggest to build with his current config first and once he ha= s > that in place and building > > a) apply the patch > b) add the extra kernel options > > R > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart wrote: > > > > Thats great idea Michael. > > > > From the look fo the build log I was sent, his blow-up has nothing to d= o > > with the patches. > > > > He should probably > > > > 1) Check out a fresh version of head. > > 2) Follow the instructions in UPDATING to get a clean build. > > =E2=80=94 make buildworld > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > ** do the reboot and merge master ** > > > > Then after that he could > > > > 3) Apply the current patch in the review > > 4) do build that > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DNO_CL= EANDIR > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > And he should have it all working :) > > > > I have done multiple builds with the latest head from yesterday both > with and without > > the extra stacks and hpts.. and I can=E2=80=99t get a build failure.. t= his would > verify he can > > at least build head.. > > > > R > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > >> > >>> On 18. Sep 2019, at 08:19, vm finance wrote: > >>> > >>> correcting a typo: > >>> > >>> svn co svn://svn.freebsd.org/base/head /usr/src > >>> current revision: 352434 > >> I suggest to build/install head first without any patches. After that > has worked, > >> apply the patches you are interested in. That way it is easy to > separate generic > >> build issues and issue specific to a patch. > >> > >> Best regards > >> Michael > >>> > >>> Thank you! > >>> > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance > wrote: > >>> > >>>> Actually I am on head already as mentioned previously. Pulled it usi= ng > >>>> yesterday: > >>>> > >>>> svn co svn://svn.freebsd.org/base/head /use/src > >>>> > >>>> > >>>> If you could pls let me know the new patch, I can try that. > >>>> > >>>> Thanks > >>>> > >>>> Sent from my iPhone > >>>> > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote: > >>>> > >>>> There have been several patches pre-this one that provide > >>>> the infrastructure to support BBR. > >>>> > >>>> Release 12.0 will *not* have these patches and will *not* compile it= . > >>>> > >>>> I have no intention at this point in doing a MFC of this work.. so i= f > you > >>>> want > >>>> to run BBR you need to run Head > >>>> > >>>> R > >>>> > >>>> On Sep 17, 2019, at 7:26 PM, vm finance > wrote: > >>>> > >>>> > >>>> Hi Randall, > >>>> > >>>> > >>>> Could you please provide a pointer to the latest patch. I had applie= d > the > >>>> one you published Sep-10. > >>>> > >>>> > >>>> Following is what I have done: > >>>> > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > >>>> > >>>> 2. Got VM up under VMPlayer on x86 laptop > >>>> > >>>> 3. Checked out latest codebase from freebsd repo: > >>>> > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > >>>> > >>>> cd /usr/src; > >>>> > >>>> make buildworld buildkernel > >>>> > >>>> [this is where make fails when patch is applied] > >>>> > >>>> > >>>> I could try to build with your latest patch - please send me a > pointer. > >>>> > >>>> > >>>> Thanks for your help! > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart > wrote: > >>>> > >>>> Looking at your make file log I can=E2=80=99t really tell what you a= re doing. > >>>> > >>>> > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > >>>> > >>>> > >>>> Are you cross compiling? > >>>> > >>>> > >>>> I have done the old fashioned kernel make > >>>> > >>>> > >>>> i.e. > >>>> > >>>> > >>>> cd src/sys/amd64/config > >>>> > >>>> config headvm > >>>> > >>>> cd ../compile/headvm > >>>> > >>>> > >>>> make cleandepend ; make depend; make -j3 > >>>> > >>>> > >>>> I have done > >>>> > >>>> > >>>> cd src > >>>> > >>>> make buildkernel KERNCONF=3Dheadvm > >>>> > >>>> > >>>> And even > >>>> > >>>> > >>>> make buildkernel KERNCONF=3DGENERIC > >>>> > >>>> > >>>> to make sure that the build works without bbr. > >>>> > >>>> > >>>> I attach my headvm config.. > >>>> > >>>> > >>>> What exactly are you building and how? kernel config too please? > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart wrote= : > >>>> > >>>> > >>>> looking > >>>> > >>>> > >>>> I was at 352408.. let me update and try it > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart wrote= : > >>>> > >>>> > >>>> Hmm > >>>> > >>>> > >>>> Did you get the patch I updated too this am? > >>>> > >>>> > >>>> I have built it both with and without the bbr stack and had no issue= .. > >>>> there was > >>>> > >>>> an issue with KTLS before the update though. > >>>> > >>>> > >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > >>>> > >>>> > >>>> Got it - thank you! > >>>> > >>>> > >>>> btw, I tried to build the patch but its giving an error. Following i= s > SVN > >>>> info + make error mesg. > >>>> > >>>> > >>>> Please let me know what am I missing here? > >>>> > >>>> > >>>> Thanks! > >>>> > >>>> > >>>> #svnlite revision > >>>> > >>>> Path: . > >>>> > >>>> Working Copy Root Path: /usr/src > >>>> > >>>> URL: svn://svn.freebsd.org/base/head > >>>> > >>>> Relative URL: ^/head > >>>> > >>>> Repository Root: svn://svn.freebsd.org/base > >>>> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>> > >>>> Revision: 352436 > >>>> > >>>> Node Kind: directory > >>>> > >>>> Schedule: normal > >>>> > >>>> Last Changed Author: jah > >>>> > >>>> Last Changed Rev: 352434 > >>>> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>> > >>>> > >>>> root@osboxes:/usr/src # > >>>> > >>>> > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>> > >>>> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>> > >>>> =3D=3D=3D> sys (cleandir) > >>>> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>> > >>>> rm: x86: is a directory > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[3]: stopped in /usr/src/sys > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[2]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[1]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make: stopped in /usr/src > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance > wrote: > >>>> > >>>> Got it - thank you! > >>>> > >>>> > >>>> btw, I tried to build the patch but its giving an error. Following i= s > SVN > >>>> info + make error mesg. > >>>> > >>>> I have also attached the entire build log...snippet is below > >>>> > >>>> > >>>> Please let me know what am I missing here? > >>>> > >>>> > >>>> Thanks! > >>>> > >>>> > >>>> #svnlite revision > >>>> > >>>> Path: . > >>>> > >>>> Working Copy Root Path: /usr/src > >>>> > >>>> URL: svn://svn.freebsd.org/base/head > >>>> > >>>> Relative URL: ^/head > >>>> > >>>> Repository Root: svn://svn.freebsd.org/base > >>>> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>> > >>>> Revision: 352436 > >>>> > >>>> Node Kind: directory > >>>> > >>>> Schedule: normal > >>>> > >>>> Last Changed Author: jah > >>>> > >>>> Last Changed Rev: 352434 > >>>> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>> > >>>> > >>>> root@osboxes:/usr/src # > >>>> > >>>> > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>> > >>>> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>> > >>>> =3D=3D=3D> sys (cleandir) > >>>> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>> > >>>> rm: x86: is a directory > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[3]: stopped in /usr/src/sys > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[2]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make[1]: stopped in /usr/src > >>>> > >>>> *** Error code 1 > >>>> > >>>> > >>>> Stop. > >>>> > >>>> make: stopped in /usr/src > >>>> > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart > wrote: > >>>> > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do not > have > >>>> > >>>> to have fq.. they built an alternate means of doing pacing into bbr. > >>>> > >>>> > >>>> In either case our testing has shown that our pacing is more accurat= e > than > >>>> > >>>> either fq or the internal pacer :) > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > >>>> > >>>> > >>>> Thanks Randall. > >>>> > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on > >>>> how it goes. > >>>> > >>>> > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is > >>>> compensated here? > >>>> > >>>> The original BBR patches on Linux show that as a must-have? Is that > >>>> functionality implemented via tcp_ratelimit.[ch]? > >>>> > >>>> > >>>> Any pointers to existing presentations/discussions highly appreciate= d? > >>>> > >>>> > >>>> Thanks a lot. > >>>> > >>>> > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart > wrote: > >>>> > >>>> You should be able to compile it against the current head. I re-doin= g > that > >>>> now (had an > >>>> > >>>> issue with my machine and had to roll it back to a backup). > >>>> > >>>> > >>>> When I put the patch up on Sept 10th it complied with and without BB= R > on > >>>> whatever > >>>> > >>>> was that rev.. > >>>> > >>>> > >>>> Looking in the commit logs that would have been around 352191 > >>>> > >>>> > >>>> Hope that helps > >>>> > >>>> > >>>> R > >>>> > >>>> > >>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > >>>> > >>>> > >>>> Hi Randall, > >>>> > >>>> > >>>> Thanks for releasing BBR patch: > >>>> > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > >>>> > >>>> > >>>> Could you please let me know what SVN/GIT label tag this is based on= ? > I > >>>> would like to patch and experiment with it. I couldn't find this inf= o > in > >>>> the released patch. > >>>> > >>>> > >>>> Thanks a lot! > >>>> > >>>> > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > >>>> > >>>> rrs@ has just posted the BBR patch to phabricator: > >>>> > >>>> > >>>> https://reviews.freebsd.org/D21582 > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> > >>>> Randall Stewart > >>>> > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>>> > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>> > >>>> > >>>> > >>>> > >>> _______________________________________________ > >>> freebsd-net@freebsd.org mailing list > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org= " > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Wed Sep 18 14:06:34 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 173EAFE723 for ; Wed, 18 Sep 2019 14:06:34 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YMGd2sZ5z4M7W for ; Wed, 18 Sep 2019 14:06:32 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd43.google.com with SMTP id m11so16507066ioo.0 for ; Wed, 18 Sep 2019 07:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w004+dXtixWqyCMi1P42rj78WgxLw8MgJLIFaw7/oEw=; b=WmVjXcXMHZliG8ZBgFcHwvMJKLTtTrpj4LpSSo+fjs5u9thY27pbC40eb6a5D272Cv 0dJbTCtleM47koGPjPee8Jln1cMp/3d3mh6/ACvmW+YKGbuJ7rzVuEivocKfpg8MjQ6r PzHN90JUZ2Fcow+80FxgYOEBty/PTSdZJSUw5QPQQFb+SBbMqsPoT8f5jET/AmkWytN/ 4ADzfVga/S9f1zc4p1Y4Ci7ROPPpp69OP4qx6KFkaCV9YKGfSMEVxvcPKQkuZ+QEFEDZ CTDNTdL8EmBh0WB4LUXcA5GJy6U6OVE+BydIuuY1DnSES5PSrnIp8I3/SzPrVF8c1xVe XlrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w004+dXtixWqyCMi1P42rj78WgxLw8MgJLIFaw7/oEw=; b=ICJaGDYLoYIXkJOdIRxpROFo2dwV5blnIYSHTL7kNP6fhqZmh7te5OEPndemp/W560 FdbzLyKdm3fTgiOz0zxL3Ft35cyL7Dnh58XAfloXWXOtCzjyF+NA/gf5o1NIL5pkH9Ko 36yr+/EYakrX5lbQUc1kRcJaneNStEccj70muTAShBLbuZJqLuiO28rxQ0KJIVCFr+gz 9SVmlcVj48LtfIkdzNKUOvfbjcrS5MD96Ls6Iry6pTR/wYb8Yvszr/hm4k1sj3PyR/PR 02ZX8msYpzPpWAPUHp6PlWohMRjRGLzLNTZnZEHjxrDN2Yo7gbs06pl878QFhUibxmzH DuYA== X-Gm-Message-State: APjAAAWvepskFSmXpoQ+VUYo86gPhLDJ+s4WKSJHnlIV6q+axytYP5Hw zbP2JaF0oRYvuZtDZYvKSgvGgZCBi3vSRXjTfKF96c8q X-Google-Smtp-Source: APXvYqwx4W7XiFoWf0bpHARSn6VefeNvPdgtTfcxYXvFlO+LKr+Vu3o4ysCtmsZMgn/vwqQZDekdXdErRXw3cbg8p/0= X-Received: by 2002:a6b:7615:: with SMTP id g21mr5076963iom.67.1568815592349; Wed, 18 Sep 2019 07:06:32 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> In-Reply-To: From: vm finance Date: Wed, 18 Sep 2019 07:06:21 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46YMGd2sZ5z4M7W X-Spamd-Bar: +++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=WmVjXcXM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d43 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [11.50 / 15.00]; GREYLIST(0.00)[pass,meta]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[21]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; BAD_REP_POLICIES(0.10)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000,0]; RCVD_IN_DNSWL_NONE(0.00)[3.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(0.00)[ip: (2.08), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-Spam: Yes Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:06:34 -0000 BTW, if you think I should be making any changes in configs, please do let me know. My goal is to build a freebsd image with BBR patches on x86 VM. Nothing fancy. thanks! On Wed, Sep 18, 2019 at 7:03 AM vm finance wrote: > Thanks Randall, Michael, > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > and now doing "make buildworld buildkernel" > [I didn't change anything in configs - just whatever are the defaults] > > I would update as soon as its done. > > Thanks again! > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart wrote: > >> One other note.. I notice his kernel conf he sent does not have >> the right things to get BBR even to attempt to build. >> >> I would suggest using that config for the first steps.. then he must add >> the additional tcp stacks and the hpts in order to get bbr/rack and any >> other >> extra stack=E2=80=A6. >> >> But I would suggest to build with his current config first and once he h= as >> that in place and building >> >> a) apply the patch >> b) add the extra kernel options >> >> R >> >> > On Sep 18, 2019, at 6:50 AM, Randall Stewart wrote: >> > >> > Thats great idea Michael. >> > >> > From the look fo the build log I was sent, his blow-up has nothing to = do >> > with the patches. >> > >> > He should probably >> > >> > 1) Check out a fresh version of head. >> > 2) Follow the instructions in UPDATING to get a clean build. >> > =E2=80=94 make buildworld >> > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > >> > ** do the reboot and merge master ** >> > >> > Then after that he could >> > >> > 3) Apply the current patch in the review >> > 4) do build that >> > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DNO_C= LEANDIR >> > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > >> > And he should have it all working :) >> > >> > I have done multiple builds with the latest head from yesterday both >> with and without >> > the extra stacks and hpts.. and I can=E2=80=99t get a build failure.. = this >> would verify he can >> > at least build head.. >> > >> > R >> > >> >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> >> >> >>> On 18. Sep 2019, at 08:19, vm finance wrote: >> >>> >> >>> correcting a typo: >> >>> >> >>> svn co svn://svn.freebsd.org/base/head /usr/src >> >>> current revision: 352434 >> >> I suggest to build/install head first without any patches. After that >> has worked, >> >> apply the patches you are interested in. That way it is easy to >> separate generic >> >> build issues and issue specific to a patch. >> >> >> >> Best regards >> >> Michael >> >>> >> >>> Thank you! >> >>> >> >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance >> wrote: >> >>> >> >>>> Actually I am on head already as mentioned previously. Pulled it >> using >> >>>> yesterday: >> >>>> >> >>>> svn co svn://svn.freebsd.org/base/head /use/src >> >>>> >> >>>> >> >>>> If you could pls let me know the new patch, I can try that. >> >>>> >> >>>> Thanks >> >>>> >> >>>> Sent from my iPhone >> >>>> >> >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart wrote= : >> >>>> >> >>>> There have been several patches pre-this one that provide >> >>>> the infrastructure to support BBR. >> >>>> >> >>>> Release 12.0 will *not* have these patches and will *not* compile i= t. >> >>>> >> >>>> I have no intention at this point in doing a MFC of this work.. so >> if you >> >>>> want >> >>>> to run BBR you need to run Head >> >>>> >> >>>> R >> >>>> >> >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> >>>> >> >>>> >> >>>> Hi Randall, >> >>>> >> >>>> >> >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> >>>> one you published Sep-10. >> >>>> >> >>>> >> >>>> Following is what I have done: >> >>>> >> >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> >>>> >> >>>> 2. Got VM up under VMPlayer on x86 laptop >> >>>> >> >>>> 3. Checked out latest codebase from freebsd repo: >> >>>> >> >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> >>>> >> >>>> cd /usr/src; >> >>>> >> >>>> make buildworld buildkernel >> >>>> >> >>>> [this is where make fails when patch is applied] >> >>>> >> >>>> >> >>>> I could try to build with your latest patch - please send me a >> pointer. >> >>>> >> >>>> >> >>>> Thanks for your help! >> >>>> >> >>>> >> >>>> >> >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart >> wrote: >> >>>> >> >>>> Looking at your make file log I can=E2=80=99t really tell what you = are doing. >> >>>> >> >>>> >> >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> >>>> >> >>>> >> >>>> Are you cross compiling? >> >>>> >> >>>> >> >>>> I have done the old fashioned kernel make >> >>>> >> >>>> >> >>>> i.e. >> >>>> >> >>>> >> >>>> cd src/sys/amd64/config >> >>>> >> >>>> config headvm >> >>>> >> >>>> cd ../compile/headvm >> >>>> >> >>>> >> >>>> make cleandepend ; make depend; make -j3 >> >>>> >> >>>> >> >>>> I have done >> >>>> >> >>>> >> >>>> cd src >> >>>> >> >>>> make buildkernel KERNCONF=3Dheadvm >> >>>> >> >>>> >> >>>> And even >> >>>> >> >>>> >> >>>> make buildkernel KERNCONF=3DGENERIC >> >>>> >> >>>> >> >>>> to make sure that the build works without bbr. >> >>>> >> >>>> >> >>>> I attach my headvm config.. >> >>>> >> >>>> >> >>>> What exactly are you building and how? kernel config too please? >> >>>> >> >>>> >> >>>> R >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> >>>> >> >>>> >> >>>> looking >> >>>> >> >>>> >> >>>> I was at 352408.. let me update and try it >> >>>> >> >>>> >> >>>> R >> >>>> >> >>>> >> >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> >>>> >> >>>> >> >>>> Hmm >> >>>> >> >>>> >> >>>> Did you get the patch I updated too this am? >> >>>> >> >>>> >> >>>> I have built it both with and without the bbr stack and had no >> issue.. >> >>>> there was >> >>>> >> >>>> an issue with KTLS before the update though. >> >>>> >> >>>> >> >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6 >> >>>> >> >>>> >> >>>> R >> >>>> >> >>>> >> >>>> On Sep 17, 2019, at 11:47 AM, vm finance >> wrote: >> >>>> >> >>>> >> >>>> Got it - thank you! >> >>>> >> >>>> >> >>>> btw, I tried to build the patch but its giving an error. Following >> is SVN >> >>>> info + make error mesg. >> >>>> >> >>>> >> >>>> Please let me know what am I missing here? >> >>>> >> >>>> >> >>>> Thanks! >> >>>> >> >>>> >> >>>> #svnlite revision >> >>>> >> >>>> Path: . >> >>>> >> >>>> Working Copy Root Path: /usr/src >> >>>> >> >>>> URL: svn://svn.freebsd.org/base/head >> >>>> >> >>>> Relative URL: ^/head >> >>>> >> >>>> Repository Root: svn://svn.freebsd.org/base >> >>>> >> >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> >>>> >> >>>> Revision: 352436 >> >>>> >> >>>> Node Kind: directory >> >>>> >> >>>> Schedule: normal >> >>>> >> >>>> Last Changed Author: jah >> >>>> >> >>>> Last Changed Rev: 352434 >> >>>> >> >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> >>>> >> >>>> >> >>>> root@osboxes:/usr/src # >> >>>> >> >>>> >> >>>> -------------------------------------------- snip >> >>>> ---------------------------- >> >>>> >> >>>> >> >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> >>>> >> >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> >>>> >> >>>> =3D=3D=3D> sys (cleandir) >> >>>> >> >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> >>>> opt_kern_tls.h >> >>>> >> >>>> rm: x86: is a directory >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[3]: stopped in /usr/src/sys >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[2]: stopped in /usr/src >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[1]: stopped in /usr/src >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make: stopped in /usr/src >> >>>> >> >>>> >> >>>> >> >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance >> wrote: >> >>>> >> >>>> Got it - thank you! >> >>>> >> >>>> >> >>>> btw, I tried to build the patch but its giving an error. Following >> is SVN >> >>>> info + make error mesg. >> >>>> >> >>>> I have also attached the entire build log...snippet is below >> >>>> >> >>>> >> >>>> Please let me know what am I missing here? >> >>>> >> >>>> >> >>>> Thanks! >> >>>> >> >>>> >> >>>> #svnlite revision >> >>>> >> >>>> Path: . >> >>>> >> >>>> Working Copy Root Path: /usr/src >> >>>> >> >>>> URL: svn://svn.freebsd.org/base/head >> >>>> >> >>>> Relative URL: ^/head >> >>>> >> >>>> Repository Root: svn://svn.freebsd.org/base >> >>>> >> >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> >>>> >> >>>> Revision: 352436 >> >>>> >> >>>> Node Kind: directory >> >>>> >> >>>> Schedule: normal >> >>>> >> >>>> Last Changed Author: jah >> >>>> >> >>>> Last Changed Rev: 352434 >> >>>> >> >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> >>>> >> >>>> >> >>>> root@osboxes:/usr/src # >> >>>> >> >>>> >> >>>> -------------------------------------------- snip >> >>>> ---------------------------- >> >>>> >> >>>> >> >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> >>>> >> >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> >>>> >> >>>> =3D=3D=3D> sys (cleandir) >> >>>> >> >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.h >> >>>> opt_kern_tls.h >> >>>> >> >>>> rm: x86: is a directory >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[3]: stopped in /usr/src/sys >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[2]: stopped in /usr/src >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make[1]: stopped in /usr/src >> >>>> >> >>>> *** Error code 1 >> >>>> >> >>>> >> >>>> Stop. >> >>>> >> >>>> make: stopped in /usr/src >> >>>> >> >>>> >> >>>> >> >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart >> wrote: >> >>>> >> >>>> Pacing is provided by tcp_hpts.c. The current linux patches do not >> have >> >>>> >> >>>> to have fq.. they built an alternate means of doing pacing into bbr= . >> >>>> >> >>>> >> >>>> In either case our testing has shown that our pacing is more >> accurate than >> >>>> >> >>>> either fq or the internal pacer :) >> >>>> >> >>>> >> >>>> R >> >>>> >> >>>> >> >>>> On Sep 17, 2019, at 11:05 AM, vm finance >> wrote: >> >>>> >> >>>> >> >>>> Thanks Randall. >> >>>> >> >>>> I was able to apply the patch - now rebuilding the kernel. Would >> update on >> >>>> how it goes. >> >>>> >> >>>> >> >>>> BTW, is there any description on how lack of tc_fq under FreeBSD is >> >>>> compensated here? >> >>>> >> >>>> The original BBR patches on Linux show that as a must-have? Is that >> >>>> functionality implemented via tcp_ratelimit.[ch]? >> >>>> >> >>>> >> >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> >>>> >> >>>> >> >>>> Thanks a lot. >> >>>> >> >>>> >> >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> >>>> >> >>>> You should be able to compile it against the current head. I >> re-doing that >> >>>> now (had an >> >>>> >> >>>> issue with my machine and had to roll it back to a backup). >> >>>> >> >>>> >> >>>> When I put the patch up on Sept 10th it complied with and without >> BBR on >> >>>> whatever >> >>>> >> >>>> was that rev.. >> >>>> >> >>>> >> >>>> Looking in the commit logs that would have been around 352191 >> >>>> >> >>>> >> >>>> Hope that helps >> >>>> >> >>>> >> >>>> R >> >>>> >> >>>> >> >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> >>>> >> >>>> >> >>>> Hi Randall, >> >>>> >> >>>> >> >>>> Thanks for releasing BBR patch: >> >>>> >> >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> >>>> >> >>>> >> >>>> Could you please let me know what SVN/GIT label tag this is based >> on? I >> >>>> would like to patch and experiment with it. I couldn't find this >> info in >> >>>> the released patch. >> >>>> >> >>>> >> >>>> Thanks a lot! >> >>>> >> >>>> >> >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> >>>> >> >>>> rrs@ has just posted the BBR patch to phabricator: >> >>>> >> >>>> >> >>>> https://reviews.freebsd.org/D21582 >> >>>> >> >>>> >> >>>> ------ >> >>>> >> >>>> Randall Stewart >> >>>> >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> ------ >> >>>> >> >>>> Randall Stewart >> >>>> >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> ------ >> >>>> >> >>>> Randall Stewart >> >>>> >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> ------ >> >>>> >> >>>> Randall Stewart >> >>>> >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> ------ >> >>>> >> >>>> Randall Stewart >> >>>> >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> ------ >> >>>> Randall Stewart >> >>>> rrs@netflix.com >> >>>> >> >>>> >> >>>> >> >>>> >> >>> _______________________________________________ >> >>> freebsd-net@freebsd.org mailing list >> >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.or= g >> " >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Wed Sep 18 14:09:40 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74591FE869 for ; Wed, 18 Sep 2019 14:09:40 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YMLC125Qz4MJM for ; Wed, 18 Sep 2019 14:09:38 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x529.google.com with SMTP id 4so4162964pgm.12 for ; Wed, 18 Sep 2019 07:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=vCUBcTr9iD5jSkfnUIMh6AS9GTQOxMRPGpYsatkcEeU=; b=sWPVzsURdxZRHHvYBmWAN0UF7sHxOahxoDG/wgaKvyhILOoXdymM6G/aQ5w42DCVts oNsuJGd7u6CUBk74TzWQehi+HddDHo0hTxj2Vub7R76pQ6AjjVdG/dNRx8j4PDjqz0mr vc71N7x+xDXJgz1nU8n5yEB9wiCbEzAzx7D8csdiTjo7VK+zDcbB6UPH5IJk3/b4h06/ 5AgIpHwlYesuE1JRJGPQYHWDxUtFLWEfP7VL3kpNEbBEhvbqAckJ1tiZkW08dq8hi6nP FjXw/THBgC/JvBo/WU4ycA3mKHqD2aNIFSFKoGsfLfU9AQvCWq0LSwQu04s6M+2cr4Mo jctw== X-Gm-Message-State: APjAAAVwqZrsNmv5nRgxV6IpQjXwvcRU+SBrP2F7kmotvnxXAZk3KErr fm8R5BDhhH1XlNCkTKA5+hjqbA== X-Google-Smtp-Source: APXvYqz6BlLS5hVv1Sk3zq2MV6fBuK3zmCpDZkB0dykZAjdz4c2hqac//srq96CB4KyFeJ1cqc0RGg== X-Received: by 2002:a17:90a:30e8:: with SMTP id h95mr4058292pjb.44.1568815776880; Wed, 18 Sep 2019 07:09:36 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::c2ea? ([2607:fb10:7021:1::c2ea]) by smtp.gmail.com with ESMTPSA id l72sm2861393pjb.7.2019.09.18.07.09.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 07:09:35 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Wed, 18 Sep 2019 07:09:33 -0700 Cc: =?utf-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46YMLC125Qz4MJM X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.85 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(0.00)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.982,0]; R_DKIM_ALLOW(0.00)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.998,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[9.2.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; URIBL_BLACK(7.50)[osboxes.org.multi.uribl.com]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-2.87)[ip: (-9.39), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:09:40 -0000 To get bbr running you will need to change your kernel config. Are you building i386 or amd64? After you have successfully did=20 1) buildworld 2) buildkernel 3) installkernel (you can look in UPDATING for instructions .. though the file is long = :D) successfully let me know.. and then I will give you the tweaks you need = to add to the kerneconf. It won=E2=80=99t take as long to build because at that point you can add = in the NO_CLEAN NO_CLEANDIR options as well since you will have built = everything the first time R > On Sep 18, 2019, at 7:06 AM, vm finance wrote: >=20 > BTW, if you think I should be making any changes in configs, please do = let me know. > My goal is to build a freebsd image with BBR patches on x86 VM.=20 > Nothing fancy. >=20 > thanks! >=20 > On Wed, Sep 18, 2019 at 7:03 AM vm finance = wrote: > Thanks Randall, Michael, >=20 > I did "svn svn://svn.freebsd.org/base/head /usr/src" > and now doing "make buildworld buildkernel"=20 > [I didn't change anything in configs - just whatever are the defaults] >=20 > I would update as soon as its done. >=20 > Thanks again! >=20 > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart = wrote: > One other note.. I notice his kernel conf he sent does not have > the right things to get BBR even to attempt to build. >=20 > I would suggest using that config for the first steps.. then he must = add > the additional tcp stacks and the hpts in order to get bbr/rack and = any other > extra stack=E2=80=A6.=20 >=20 > But I would suggest to build with his current config first and once he = has > that in place and building >=20 > a) apply the patch > b) add the extra kernel options >=20 > R >=20 > > On Sep 18, 2019, at 6:50 AM, Randall Stewart = wrote: > >=20 > > Thats great idea Michael. > >=20 > > =46rom the look fo the build log I was sent, his blow-up has nothing = to do > > with the patches. > >=20 > > He should probably > >=20 > > 1) Check out a fresh version of head. > > 2) Follow the instructions in UPDATING to get a clean build. > > =E2=80=94 make buildworld > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > >=20 > > ** do the reboot and merge master ** > >=20 > > Then after that he could > >=20 > > 3) Apply the current patch in the review > > 4) do build that > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN = -DNO_CLEANDIR > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > >=20 > > And he should have it all working :) > >=20 > > I have done multiple builds with the latest head from yesterday both = with and without > > the extra stacks and hpts.. and I can=E2=80=99t get a build = failure.. this would verify he can > > at least build head.. > >=20 > > R > >=20 > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: > >>=20 > >>> On 18. Sep 2019, at 08:19, vm finance = wrote: > >>>=20 > >>> correcting a typo: > >>>=20 > >>> svn co svn://svn.freebsd.org/base/head /usr/src > >>> current revision: 352434 > >> I suggest to build/install head first without any patches. After = that has worked, > >> apply the patches you are interested in. That way it is easy to = separate generic > >> build issues and issue specific to a patch. > >>=20 > >> Best regards > >> Michael > >>>=20 > >>> Thank you! > >>>=20 > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: > >>>=20 > >>>> Actually I am on head already as mentioned previously. Pulled it = using > >>>> yesterday: > >>>>=20 > >>>> svn co svn://svn.freebsd.org/base/head /use/src > >>>>=20 > >>>>=20 > >>>> If you could pls let me know the new patch, I can try that. > >>>>=20 > >>>> Thanks > >>>>=20 > >>>> Sent from my iPhone > >>>>=20 > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart = wrote: > >>>>=20 > >>>> There have been several patches pre-this one that provide > >>>> the infrastructure to support BBR. > >>>>=20 > >>>> Release 12.0 will *not* have these patches and will *not* compile = it. > >>>>=20 > >>>> I have no intention at this point in doing a MFC of this work.. = so if you > >>>> want > >>>> to run BBR you need to run Head > >>>>=20 > >>>> R > >>>>=20 > >>>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: > >>>>=20 > >>>>=20 > >>>> Hi Randall, > >>>>=20 > >>>>=20 > >>>> Could you please provide a pointer to the latest patch. I had = applied the > >>>> one you published Sep-10. > >>>>=20 > >>>>=20 > >>>> Following is what I have done: > >>>>=20 > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > >>>>=20 > >>>> 2. Got VM up under VMPlayer on x86 laptop > >>>>=20 > >>>> 3. Checked out latest codebase from freebsd repo: > >>>>=20 > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > >>>>=20 > >>>> cd /usr/src; > >>>>=20 > >>>> make buildworld buildkernel > >>>>=20 > >>>> [this is where make fails when patch is applied] > >>>>=20 > >>>>=20 > >>>> I could try to build with your latest patch - please send me a = pointer. > >>>>=20 > >>>>=20 > >>>> Thanks for your help! > >>>>=20 > >>>>=20 > >>>>=20 > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: > >>>>=20 > >>>> Looking at your make file log I can=E2=80=99t really tell what = you are doing. > >>>>=20 > >>>>=20 > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > >>>>=20 > >>>>=20 > >>>> Are you cross compiling? > >>>>=20 > >>>>=20 > >>>> I have done the old fashioned kernel make > >>>>=20 > >>>>=20 > >>>> i.e. > >>>>=20 > >>>>=20 > >>>> cd src/sys/amd64/config > >>>>=20 > >>>> config headvm > >>>>=20 > >>>> cd ../compile/headvm > >>>>=20 > >>>>=20 > >>>> make cleandepend ; make depend; make -j3 > >>>>=20 > >>>>=20 > >>>> I have done > >>>>=20 > >>>>=20 > >>>> cd src > >>>>=20 > >>>> make buildkernel KERNCONF=3Dheadvm > >>>>=20 > >>>>=20 > >>>> And even > >>>>=20 > >>>>=20 > >>>> make buildkernel KERNCONF=3DGENERIC > >>>>=20 > >>>>=20 > >>>> to make sure that the build works without bbr. > >>>>=20 > >>>>=20 > >>>> I attach my headvm config.. > >>>>=20 > >>>>=20 > >>>> What exactly are you building and how? kernel config too please? > >>>>=20 > >>>>=20 > >>>> R > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: > >>>>=20 > >>>>=20 > >>>> looking > >>>>=20 > >>>>=20 > >>>> I was at 352408.. let me update and try it > >>>>=20 > >>>>=20 > >>>> R > >>>>=20 > >>>>=20 > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: > >>>>=20 > >>>>=20 > >>>> Hmm > >>>>=20 > >>>>=20 > >>>> Did you get the patch I updated too this am? > >>>>=20 > >>>>=20 > >>>> I have built it both with and without the bbr stack and had no = issue.. > >>>> there was > >>>>=20 > >>>> an issue with KTLS before the update though. > >>>>=20 > >>>>=20 > >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6= > >>>>=20 > >>>>=20 > >>>> R > >>>>=20 > >>>>=20 > >>>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: > >>>>=20 > >>>>=20 > >>>> Got it - thank you! > >>>>=20 > >>>>=20 > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > >>>> info + make error mesg. > >>>>=20 > >>>>=20 > >>>> Please let me know what am I missing here? > >>>>=20 > >>>>=20 > >>>> Thanks! > >>>>=20 > >>>>=20 > >>>> #svnlite revision > >>>>=20 > >>>> Path: . > >>>>=20 > >>>> Working Copy Root Path: /usr/src > >>>>=20 > >>>> URL: svn://svn.freebsd.org/base/head > >>>>=20 > >>>> Relative URL: ^/head > >>>>=20 > >>>> Repository Root: svn://svn.freebsd.org/base > >>>>=20 > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>>=20 > >>>> Revision: 352436 > >>>>=20 > >>>> Node Kind: directory > >>>>=20 > >>>> Schedule: normal > >>>>=20 > >>>> Last Changed Author: jah > >>>>=20 > >>>> Last Changed Rev: 352434 > >>>>=20 > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>>=20 > >>>>=20 > >>>> root@osboxes:/usr/src # > >>>>=20 > >>>>=20 > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>>=20 > >>>>=20 > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>>=20 > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>>=20 > >>>> =3D=3D=3D> sys (cleandir) > >>>>=20 > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>>=20 > >>>> rm: x86: is a directory > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[3]: stopped in /usr/src/sys > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[2]: stopped in /usr/src > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[1]: stopped in /usr/src > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make: stopped in /usr/src > >>>>=20 > >>>>=20 > >>>>=20 > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > >>>>=20 > >>>> Got it - thank you! > >>>>=20 > >>>>=20 > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > >>>> info + make error mesg. > >>>>=20 > >>>> I have also attached the entire build log...snippet is below > >>>>=20 > >>>>=20 > >>>> Please let me know what am I missing here? > >>>>=20 > >>>>=20 > >>>> Thanks! > >>>>=20 > >>>>=20 > >>>> #svnlite revision > >>>>=20 > >>>> Path: . > >>>>=20 > >>>> Working Copy Root Path: /usr/src > >>>>=20 > >>>> URL: svn://svn.freebsd.org/base/head > >>>>=20 > >>>> Relative URL: ^/head > >>>>=20 > >>>> Repository Root: svn://svn.freebsd.org/base > >>>>=20 > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > >>>>=20 > >>>> Revision: 352436 > >>>>=20 > >>>> Node Kind: directory > >>>>=20 > >>>> Schedule: normal > >>>>=20 > >>>> Last Changed Author: jah > >>>>=20 > >>>> Last Changed Rev: 352434 > >>>>=20 > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > >>>>=20 > >>>>=20 > >>>> root@osboxes:/usr/src # > >>>>=20 > >>>>=20 > >>>> -------------------------------------------- snip > >>>> ---------------------------- > >>>>=20 > >>>>=20 > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > >>>>=20 > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > >>>>=20 > >>>> =3D=3D=3D> sys (cleandir) > >>>>=20 > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > >>>> opt_kern_tls.h > >>>>=20 > >>>> rm: x86: is a directory > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[3]: stopped in /usr/src/sys > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[2]: stopped in /usr/src > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make[1]: stopped in /usr/src > >>>>=20 > >>>> *** Error code 1 > >>>>=20 > >>>>=20 > >>>> Stop. > >>>>=20 > >>>> make: stopped in /usr/src > >>>>=20 > >>>>=20 > >>>>=20 > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > >>>>=20 > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do = not have > >>>>=20 > >>>> to have fq.. they built an alternate means of doing pacing into = bbr. > >>>>=20 > >>>>=20 > >>>> In either case our testing has shown that our pacing is more = accurate than > >>>>=20 > >>>> either fq or the internal pacer :) > >>>>=20 > >>>>=20 > >>>> R > >>>>=20 > >>>>=20 > >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > >>>>=20 > >>>>=20 > >>>> Thanks Randall. > >>>>=20 > >>>> I was able to apply the patch - now rebuilding the kernel. Would = update on > >>>> how it goes. > >>>>=20 > >>>>=20 > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD = is > >>>> compensated here? > >>>>=20 > >>>> The original BBR patches on Linux show that as a must-have? Is = that > >>>> functionality implemented via tcp_ratelimit.[ch]? > >>>>=20 > >>>>=20 > >>>> Any pointers to existing presentations/discussions highly = appreciated? > >>>>=20 > >>>>=20 > >>>> Thanks a lot. > >>>>=20 > >>>>=20 > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > >>>>=20 > >>>> You should be able to compile it against the current head. I = re-doing that > >>>> now (had an > >>>>=20 > >>>> issue with my machine and had to roll it back to a backup). > >>>>=20 > >>>>=20 > >>>> When I put the patch up on Sept 10th it complied with and without = BBR on > >>>> whatever > >>>>=20 > >>>> was that rev.. > >>>>=20 > >>>>=20 > >>>> Looking in the commit logs that would have been around 352191 > >>>>=20 > >>>>=20 > >>>> Hope that helps > >>>>=20 > >>>>=20 > >>>> R > >>>>=20 > >>>>=20 > >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > >>>>=20 > >>>>=20 > >>>> Hi Randall, > >>>>=20 > >>>>=20 > >>>> Thanks for releasing BBR patch: > >>>>=20 > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > >>>>=20 > >>>>=20 > >>>> Could you please let me know what SVN/GIT label tag this is based = on? I > >>>> would like to patch and experiment with it. I couldn't find this = info in > >>>> the released patch. > >>>>=20 > >>>>=20 > >>>> Thanks a lot! > >>>>=20 > >>>>=20 > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > >>>>=20 > >>>> rrs@ has just posted the BBR patch to phabricator: > >>>>=20 > >>>>=20 > >>>> https://reviews.freebsd.org/D21582 > >>>>=20 > >>>>=20 > >>>> ------ > >>>>=20 > >>>> Randall Stewart > >>>>=20 > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> ------ > >>>>=20 > >>>> Randall Stewart > >>>>=20 > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> ------ > >>>>=20 > >>>> Randall Stewart > >>>>=20 > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> ------ > >>>>=20 > >>>> Randall Stewart > >>>>=20 > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> ------ > >>>>=20 > >>>> Randall Stewart > >>>>=20 > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>>> ------ > >>>> Randall Stewart > >>>> rrs@netflix.com > >>>>=20 > >>>>=20 > >>>>=20 > >>>>=20 > >>> _______________________________________________ > >>> freebsd-net@freebsd.org mailing list > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Wed Sep 18 15:34:33 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 325F3121628 for ; Wed, 18 Sep 2019 15:34:33 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YPD82zJBz4Stp for ; Wed, 18 Sep 2019 15:34:32 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd32.google.com with SMTP id n197so145916iod.9 for ; Wed, 18 Sep 2019 08:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=btV5T1+euG7D2z4Gfxrbsw9WFS88ZLwBAsLJn3yUabA=; b=pdtTtrGALiUnJGjemZ1b8W2LZ8ArzMo85apClfFphP7gy9rtCAZxBL2V7pj4uw/4uF PWIzciuJv/bFp5UGcPQvfjX+ICctE6Whjmvc4XcdCQWVSYh2EkjgHUaaoUljE2tQzqtI bqJB7Nkf0FxgaTZz+vOP3hpVBmzXrMoVuL2PMnh5o8YLVtVMrlTNwR8uAbewQUG5WVh7 lAt0Moxm04LMU6MDVdgQQBVJoWY4Jjk1ltD+0HitpCbXfrfRGz5ThSESM8cFn6YqJQW1 z4E5IihPjP15fEOn/xlmjjS5Dn+3sBOQ89rcB7A4gFUXps34NJXKwvQrL6G05p7fv+Dk iFOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=btV5T1+euG7D2z4Gfxrbsw9WFS88ZLwBAsLJn3yUabA=; b=Q8JARTHi89ld0uxwXTWVvbs7j1c12vxcEAgaKdoEy4X8jeLn90HAD9A5nJEwkSu0jp +N0tek/xnKVcEeNnP1y4TSXOR3UsqhHOBiuMrj+z8RLFRuz5KV2tSVYjEQxpGdQFxo4l hrJyoDuYxWq2eE3++wwrhw7VDNCX9U6iN2ymqLxj/KaduLMfCmRBD+54zBOug4Ckb51E jRhBVu9DqnwdjtAFnEexhkD4klSiLlgn319R7/alXhNczc6c8egmcXCtBI/gWhpWabNz dKdLAnoiYNvgPKvJDpxzrPO25XEfQ5sZxT0A7d0d76oNMCPJIorOB279b6QZ3PW1bZQD Ypiw== X-Gm-Message-State: APjAAAX4gqdE8djSgZG+35SBXOCzjrXDvzvKXlf9o+UzMXw7SmNg6DUc dUOIGkTqHhsK4qgYrCA5no+iHszCm40A0Nw3YkI= X-Google-Smtp-Source: APXvYqwc5Ol+7J5VDdyJ2XoxnVMPNdoN+rBIr7AoYW3KXyFCHd+fcgZHEy++hEvSWZkw7VkXGrXAUDBnTUW2MQ1uSL8= X-Received: by 2002:a5e:da0a:: with SMTP id x10mr6059491ioj.286.1568820870984; Wed, 18 Sep 2019 08:34:30 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> In-Reply-To: From: vm finance Date: Wed, 18 Sep 2019 08:34:18 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46YPD82zJBz4Stp X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pdtTtrGA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[21]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.44), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 15:34:33 -0000 I'm using amd64. I'd get back as soon as base build is complete. Thanks! On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart wrote: > To get bbr running you will need to change your kernel config. > > Are you building i386 or amd64? > > After you have successfully did > > 1) buildworld > 2) buildkernel > 3) installkernel > > (you can look in UPDATING for instructions .. though the file is long :D) > > successfully let me know.. and then I will give you the tweaks you need t= o > add > to the kerneconf. > > It won=E2=80=99t take as long to build because at that point you can add = in the > NO_CLEAN NO_CLEANDIR options as well since you will have built everything > the first time > > R > > > On Sep 18, 2019, at 7:06 AM, vm finance wrote: > > > > BTW, if you think I should be making any changes in configs, please do > let me know. > > My goal is to build a freebsd image with BBR patches on x86 VM. > > Nothing fancy. > > > > thanks! > > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance > wrote: > > Thanks Randall, Michael, > > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > and now doing "make buildworld buildkernel" > > [I didn't change anything in configs - just whatever are the defaults] > > > > I would update as soon as its done. > > > > Thanks again! > > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart wrote= : > > One other note.. I notice his kernel conf he sent does not have > > the right things to get BBR even to attempt to build. > > > > I would suggest using that config for the first steps.. then he must ad= d > > the additional tcp stacks and the hpts in order to get bbr/rack and any > other > > extra stack=E2=80=A6. > > > > But I would suggest to build with his current config first and once he > has > > that in place and building > > > > a) apply the patch > > b) add the extra kernel options > > > > R > > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart wrote: > > > > > > Thats great idea Michael. > > > > > > From the look fo the build log I was sent, his blow-up has nothing to > do > > > with the patches. > > > > > > He should probably > > > > > > 1) Check out a fresh version of head. > > > 2) Follow the instructions in UPDATING to get a clean build. > > > =E2=80=94 make buildworld > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > > > ** do the reboot and merge master ** > > > > > > Then after that he could > > > > > > 3) Apply the current patch in the review > > > 4) do build that > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DNO_= CLEANDIR > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > > > And he should have it all working :) > > > > > > I have done multiple builds with the latest head from yesterday both > with and without > > > the extra stacks and hpts.. and I can=E2=80=99t get a build failure..= this > would verify he can > > > at least build head.. > > > > > > R > > > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > > >> > > >>> On 18. Sep 2019, at 08:19, vm finance wrote= : > > >>> > > >>> correcting a typo: > > >>> > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > >>> current revision: 352434 > > >> I suggest to build/install head first without any patches. After tha= t > has worked, > > >> apply the patches you are interested in. That way it is easy to > separate generic > > >> build issues and issue specific to a patch. > > >> > > >> Best regards > > >> Michael > > >>> > > >>> Thank you! > > >>> > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance > wrote: > > >>> > > >>>> Actually I am on head already as mentioned previously. Pulled it > using > > >>>> yesterday: > > >>>> > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > >>>> > > >>>> > > >>>> If you could pls let me know the new patch, I can try that. > > >>>> > > >>>> Thanks > > >>>> > > >>>> Sent from my iPhone > > >>>> > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart > wrote: > > >>>> > > >>>> There have been several patches pre-this one that provide > > >>>> the infrastructure to support BBR. > > >>>> > > >>>> Release 12.0 will *not* have these patches and will *not* compile > it. > > >>>> > > >>>> I have no intention at this point in doing a MFC of this work.. so > if you > > >>>> want > > >>>> to run BBR you need to run Head > > >>>> > > >>>> R > > >>>> > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance > wrote: > > >>>> > > >>>> > > >>>> Hi Randall, > > >>>> > > >>>> > > >>>> Could you please provide a pointer to the latest patch. I had > applied the > > >>>> one you published Sep-10. > > >>>> > > >>>> > > >>>> Following is what I have done: > > >>>> > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > >>>> > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > >>>> > > >>>> 3. Checked out latest codebase from freebsd repo: > > >>>> > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > >>>> > > >>>> cd /usr/src; > > >>>> > > >>>> make buildworld buildkernel > > >>>> > > >>>> [this is where make fails when patch is applied] > > >>>> > > >>>> > > >>>> I could try to build with your latest patch - please send me a > pointer. > > >>>> > > >>>> > > >>>> Thanks for your help! > > >>>> > > >>>> > > >>>> > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart > wrote: > > >>>> > > >>>> Looking at your make file log I can=E2=80=99t really tell what you= are > doing. > > >>>> > > >>>> > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > >>>> > > >>>> > > >>>> Are you cross compiling? > > >>>> > > >>>> > > >>>> I have done the old fashioned kernel make > > >>>> > > >>>> > > >>>> i.e. > > >>>> > > >>>> > > >>>> cd src/sys/amd64/config > > >>>> > > >>>> config headvm > > >>>> > > >>>> cd ../compile/headvm > > >>>> > > >>>> > > >>>> make cleandepend ; make depend; make -j3 > > >>>> > > >>>> > > >>>> I have done > > >>>> > > >>>> > > >>>> cd src > > >>>> > > >>>> make buildkernel KERNCONF=3Dheadvm > > >>>> > > >>>> > > >>>> And even > > >>>> > > >>>> > > >>>> make buildkernel KERNCONF=3DGENERIC > > >>>> > > >>>> > > >>>> to make sure that the build works without bbr. > > >>>> > > >>>> > > >>>> I attach my headvm config.. > > >>>> > > >>>> > > >>>> What exactly are you building and how? kernel config too please? > > >>>> > > >>>> > > >>>> R > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart > wrote: > > >>>> > > >>>> > > >>>> looking > > >>>> > > >>>> > > >>>> I was at 352408.. let me update and try it > > >>>> > > >>>> > > >>>> R > > >>>> > > >>>> > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart > wrote: > > >>>> > > >>>> > > >>>> Hmm > > >>>> > > >>>> > > >>>> Did you get the patch I updated too this am? > > >>>> > > >>>> > > >>>> I have built it both with and without the bbr stack and had no > issue.. > > >>>> there was > > >>>> > > >>>> an issue with KTLS before the update though. > > >>>> > > >>>> > > >>>> I don=E2=80=99t recognize what you have below there though=E2=80= =A6 > > >>>> > > >>>> > > >>>> R > > >>>> > > >>>> > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > > >>>> > > >>>> > > >>>> Got it - thank you! > > >>>> > > >>>> > > >>>> btw, I tried to build the patch but its giving an error. Following > is SVN > > >>>> info + make error mesg. > > >>>> > > >>>> > > >>>> Please let me know what am I missing here? > > >>>> > > >>>> > > >>>> Thanks! > > >>>> > > >>>> > > >>>> #svnlite revision > > >>>> > > >>>> Path: . > > >>>> > > >>>> Working Copy Root Path: /usr/src > > >>>> > > >>>> URL: svn://svn.freebsd.org/base/head > > >>>> > > >>>> Relative URL: ^/head > > >>>> > > >>>> Repository Root: svn://svn.freebsd.org/base > > >>>> > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > >>>> > > >>>> Revision: 352436 > > >>>> > > >>>> Node Kind: directory > > >>>> > > >>>> Schedule: normal > > >>>> > > >>>> Last Changed Author: jah > > >>>> > > >>>> Last Changed Rev: 352434 > > >>>> > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > >>>> > > >>>> > > >>>> root@osboxes:/usr/src # > > >>>> > > >>>> > > >>>> -------------------------------------------- snip > > >>>> ---------------------------- > > >>>> > > >>>> > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > >>>> > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > >>>> > > >>>> =3D=3D=3D> sys (cleandir) > > >>>> > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.= h > > >>>> opt_kern_tls.h > > >>>> > > >>>> rm: x86: is a directory > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[3]: stopped in /usr/src/sys > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[2]: stopped in /usr/src > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[1]: stopped in /usr/src > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make: stopped in /usr/src > > >>>> > > >>>> > > >>>> > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance > wrote: > > >>>> > > >>>> Got it - thank you! > > >>>> > > >>>> > > >>>> btw, I tried to build the patch but its giving an error. Following > is SVN > > >>>> info + make error mesg. > > >>>> > > >>>> I have also attached the entire build log...snippet is below > > >>>> > > >>>> > > >>>> Please let me know what am I missing here? > > >>>> > > >>>> > > >>>> Thanks! > > >>>> > > >>>> > > >>>> #svnlite revision > > >>>> > > >>>> Path: . > > >>>> > > >>>> Working Copy Root Path: /usr/src > > >>>> > > >>>> URL: svn://svn.freebsd.org/base/head > > >>>> > > >>>> Relative URL: ^/head > > >>>> > > >>>> Repository Root: svn://svn.freebsd.org/base > > >>>> > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > >>>> > > >>>> Revision: 352436 > > >>>> > > >>>> Node Kind: directory > > >>>> > > >>>> Schedule: normal > > >>>> > > >>>> Last Changed Author: jah > > >>>> > > >>>> Last Changed Rev: 352434 > > >>>> > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > >>>> > > >>>> > > >>>> root@osboxes:/usr/src # > > >>>> > > >>>> > > >>>> -------------------------------------------- snip > > >>>> ---------------------------- > > >>>> > > >>>> > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > >>>> > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > >>>> > > >>>> =3D=3D=3D> sys (cleandir) > > >>>> > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug.= h > > >>>> opt_kern_tls.h > > >>>> > > >>>> rm: x86: is a directory > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[3]: stopped in /usr/src/sys > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[2]: stopped in /usr/src > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make[1]: stopped in /usr/src > > >>>> > > >>>> *** Error code 1 > > >>>> > > >>>> > > >>>> Stop. > > >>>> > > >>>> make: stopped in /usr/src > > >>>> > > >>>> > > >>>> > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart > wrote: > > >>>> > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do not > have > > >>>> > > >>>> to have fq.. they built an alternate means of doing pacing into bb= r. > > >>>> > > >>>> > > >>>> In either case our testing has shown that our pacing is more > accurate than > > >>>> > > >>>> either fq or the internal pacer :) > > >>>> > > >>>> > > >>>> R > > >>>> > > >>>> > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > > >>>> > > >>>> > > >>>> Thanks Randall. > > >>>> > > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on > > >>>> how it goes. > > >>>> > > >>>> > > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD i= s > > >>>> compensated here? > > >>>> > > >>>> The original BBR patches on Linux show that as a must-have? Is tha= t > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > >>>> > > >>>> > > >>>> Any pointers to existing presentations/discussions highly > appreciated? > > >>>> > > >>>> > > >>>> Thanks a lot. > > >>>> > > >>>> > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart > wrote: > > >>>> > > >>>> You should be able to compile it against the current head. I > re-doing that > > >>>> now (had an > > >>>> > > >>>> issue with my machine and had to roll it back to a backup). > > >>>> > > >>>> > > >>>> When I put the patch up on Sept 10th it complied with and without > BBR on > > >>>> whatever > > >>>> > > >>>> was that rev.. > > >>>> > > >>>> > > >>>> Looking in the commit logs that would have been around 352191 > > >>>> > > >>>> > > >>>> Hope that helps > > >>>> > > >>>> > > >>>> R > > >>>> > > >>>> > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > > >>>> > > >>>> > > >>>> Hi Randall, > > >>>> > > >>>> > > >>>> Thanks for releasing BBR patch: > > >>>> > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > >>>> > > >>>> > > >>>> Could you please let me know what SVN/GIT label tag this is based > on? I > > >>>> would like to patch and experiment with it. I couldn't find this > info in > > >>>> the released patch. > > >>>> > > >>>> > > >>>> Thanks a lot! > > >>>> > > >>>> > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > > >>>> > > >>>> rrs@ has just posted the BBR patch to phabricator: > > >>>> > > >>>> > > >>>> https://reviews.freebsd.org/D21582 > > >>>> > > >>>> > > >>>> ------ > > >>>> > > >>>> Randall Stewart > > >>>> > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> ------ > > >>>> > > >>>> Randall Stewart > > >>>> > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> ------ > > >>>> > > >>>> Randall Stewart > > >>>> > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> ------ > > >>>> > > >>>> Randall Stewart > > >>>> > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> ------ > > >>>> > > >>>> Randall Stewart > > >>>> > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> > > >>>> ------ > > >>>> Randall Stewart > > >>>> rrs@netflix.com > > >>>> > > >>>> > > >>>> > > >>>> > > >>> _______________________________________________ > > >>> freebsd-net@freebsd.org mailing list > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > >>> To unsubscribe, send any mail to " > freebsd-net-unsubscribe@freebsd.org" > > > > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > > > > > > > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Thu Sep 19 05:48:17 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ADE82F6A7E for ; Thu, 19 Sep 2019 05:48:17 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Ym9D68fvz4GnX for ; Thu, 19 Sep 2019 05:48:16 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd41.google.com with SMTP id k5so4883048iol.5 for ; Wed, 18 Sep 2019 22:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e0mfLtlNJzvP0Y2gEerKqoWYzlvpoXLPj51Yymyszlg=; b=NV/UQMywqST08IXSQWB6TAM1dyq+L3sRL5LFnBYIwlZt1RfbDSUu5R0L+GEc4VT7eY qtMLbjsBCmbhH1ZQsdkF4Wat3Q3ySk9rvkMrAI3uHWule9bIBqKV5YsRnJE4+03Z3z5j OPCUcU0kfQNk0OYqEWOrvn6NSoS9kES1kv2NUnqy41DKi7g1uFdIfYjZLHgANR/gn7rY r7Q5wuFjpux1tLqJ2pasDWnHJGmORFS3o8W5PQ4r2XO4gg5xLZ3BP9JADtJ0DjMj6zkx MLx+L0Dvzb4PrCF/tXjvSVdNIbiznOtPfuawTFRqkDi2aTuEXNSaCXHomEkAA3wMQKBB SpmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e0mfLtlNJzvP0Y2gEerKqoWYzlvpoXLPj51Yymyszlg=; b=Pa7PN6btKpP0fmH4UDSmSnf4JUm3Q4MqsJtQaM4gyEZFCZl/tjjM3v+NhLJOkXcV8U fiv2N+Z9i3jWFJqtg6HO5BhTDRJY3bQcJFgsa/iZMptcP3Cl6WUSLa4h0Gb2UJIiuDDL nNOmG6Cxo62kalLVMf1ePkdhDdjAXdfxwdt+zSMJk9tv5cmy7Z+J2gYq0ZjFEGCLSWSo EUoZnti9FxrCkq+6eeVhthDML1+KKTCytwNmNBFXR7rm0klwDWwhoAh3u7XJdH+pDGPp TGMeP/Om6RmUlpr7J/OVQ36QyCBmq3b9snnNzKkQxhY1y+bLIbvF62KSJocbLg0batxC iU9A== X-Gm-Message-State: APjAAAUdtoc6NgVttX1LcklWrDXhess5Zi1OtF2HNAaQmRhaBfLnA4v8 K21SYpS4NStjJZoQbMKtIj6mgoZvjkg5maDMLXc= X-Google-Smtp-Source: APXvYqxwhb+bvtdyk2pHeeg6KacVWqLTHu9mqeXhPiXJ2IcELRU4jxkN3XPXasXUzPE8IhmkXsI7G7YZvPCvuxVvb5E= X-Received: by 2002:a6b:7615:: with SMTP id g21mr9535723iom.67.1568872095658; Wed, 18 Sep 2019 22:48:15 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> In-Reply-To: From: vm finance Date: Wed, 18 Sep 2019 21:31:22 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46Ym9D68fvz4GnX X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NV/UQMyw; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d41 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[21]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (2.04), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 05:48:17 -0000 Hi Randall, Michael, Build is done successfully. I would appreciate if you could share config changes needed for BBR. My svn revision is: 352483 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | xargs -J% objcopy % zlib.ko.full objcopy --only-keep-debug zlib.ko.full zlib.ko.debug objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.full zlib.ko -------------------------------------------------------------- >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 2019 -------------------------------------------------------------- >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D Thank you Vishal. On Wed, Sep 18, 2019 at 3:34 PM vm finance wrote: > I'm using amd64. I'd get back as soon as base build is complete. > > Thanks! > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart wrote: > >> To get bbr running you will need to change your kernel config. >> >> Are you building i386 or amd64? >> >> After you have successfully did >> >> 1) buildworld >> 2) buildkernel >> 3) installkernel >> >> (you can look in UPDATING for instructions .. though the file is long :D= ) >> >> successfully let me know.. and then I will give you the tweaks you need >> to add >> to the kerneconf. >> >> It won=E2=80=99t take as long to build because at that point you can add= in the >> NO_CLEAN NO_CLEANDIR options as well since you will have built everythin= g >> the first time >> >> R >> >> > On Sep 18, 2019, at 7:06 AM, vm finance wrote: >> > >> > BTW, if you think I should be making any changes in configs, please do >> let me know. >> > My goal is to build a freebsd image with BBR patches on x86 VM. >> > Nothing fancy. >> > >> > thanks! >> > >> > On Wed, Sep 18, 2019 at 7:03 AM vm finance >> wrote: >> > Thanks Randall, Michael, >> > >> > I did "svn svn://svn.freebsd.org/base/head /usr/src" >> > and now doing "make buildworld buildkernel" >> > [I didn't change anything in configs - just whatever are the defaults] >> > >> > I would update as soon as its done. >> > >> > Thanks again! >> > >> > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >> wrote: >> > One other note.. I notice his kernel conf he sent does not have >> > the right things to get BBR even to attempt to build. >> > >> > I would suggest using that config for the first steps.. then he must a= dd >> > the additional tcp stacks and the hpts in order to get bbr/rack and an= y >> other >> > extra stack=E2=80=A6. >> > >> > But I would suggest to build with his current config first and once he >> has >> > that in place and building >> > >> > a) apply the patch >> > b) add the extra kernel options >> > >> > R >> > >> > > On Sep 18, 2019, at 6:50 AM, Randall Stewart wrote= : >> > > >> > > Thats great idea Michael. >> > > >> > > From the look fo the build log I was sent, his blow-up has nothing t= o >> do >> > > with the patches. >> > > >> > > He should probably >> > > >> > > 1) Check out a fresh version of head. >> > > 2) Follow the instructions in UPDATING to get a clean build. >> > > =E2=80=94 make buildworld >> > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > > >> > > ** do the reboot and merge master ** >> > > >> > > Then after that he could >> > > >> > > 3) Apply the current patch in the review >> > > 4) do build that >> > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DNO= _CLEANDIR >> > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > > >> > > And he should have it all working :) >> > > >> > > I have done multiple builds with the latest head from yesterday both >> with and without >> > > the extra stacks and hpts.. and I can=E2=80=99t get a build failure.= . this >> would verify he can >> > > at least build head.. >> > > >> > > R >> > > >> > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> > >> >> > >>> On 18. Sep 2019, at 08:19, vm finance >> wrote: >> > >>> >> > >>> correcting a typo: >> > >>> >> > >>> svn co svn://svn.freebsd.org/base/head /usr/src >> > >>> current revision: 352434 >> > >> I suggest to build/install head first without any patches. After >> that has worked, >> > >> apply the patches you are interested in. That way it is easy to >> separate generic >> > >> build issues and issue specific to a patch. >> > >> >> > >> Best regards >> > >> Michael >> > >>> >> > >>> Thank you! >> > >>> >> > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance >> wrote: >> > >>> >> > >>>> Actually I am on head already as mentioned previously. Pulled it >> using >> > >>>> yesterday: >> > >>>> >> > >>>> svn co svn://svn.freebsd.org/base/head /use/src >> > >>>> >> > >>>> >> > >>>> If you could pls let me know the new patch, I can try that. >> > >>>> >> > >>>> Thanks >> > >>>> >> > >>>> Sent from my iPhone >> > >>>> >> > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >> wrote: >> > >>>> >> > >>>> There have been several patches pre-this one that provide >> > >>>> the infrastructure to support BBR. >> > >>>> >> > >>>> Release 12.0 will *not* have these patches and will *not* compile >> it. >> > >>>> >> > >>>> I have no intention at this point in doing a MFC of this work.. s= o >> if you >> > >>>> want >> > >>>> to run BBR you need to run Head >> > >>>> >> > >>>> R >> > >>>> >> > >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> > >>>> >> > >>>> >> > >>>> Hi Randall, >> > >>>> >> > >>>> >> > >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> > >>>> one you published Sep-10. >> > >>>> >> > >>>> >> > >>>> Following is what I have done: >> > >>>> >> > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> > >>>> >> > >>>> 2. Got VM up under VMPlayer on x86 laptop >> > >>>> >> > >>>> 3. Checked out latest codebase from freebsd repo: >> > >>>> >> > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> > >>>> >> > >>>> cd /usr/src; >> > >>>> >> > >>>> make buildworld buildkernel >> > >>>> >> > >>>> [this is where make fails when patch is applied] >> > >>>> >> > >>>> >> > >>>> I could try to build with your latest patch - please send me a >> pointer. >> > >>>> >> > >>>> >> > >>>> Thanks for your help! >> > >>>> >> > >>>> >> > >>>> >> > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart >> wrote: >> > >>>> >> > >>>> Looking at your make file log I can=E2=80=99t really tell what yo= u are >> doing. >> > >>>> >> > >>>> >> > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> > >>>> >> > >>>> >> > >>>> Are you cross compiling? >> > >>>> >> > >>>> >> > >>>> I have done the old fashioned kernel make >> > >>>> >> > >>>> >> > >>>> i.e. >> > >>>> >> > >>>> >> > >>>> cd src/sys/amd64/config >> > >>>> >> > >>>> config headvm >> > >>>> >> > >>>> cd ../compile/headvm >> > >>>> >> > >>>> >> > >>>> make cleandepend ; make depend; make -j3 >> > >>>> >> > >>>> >> > >>>> I have done >> > >>>> >> > >>>> >> > >>>> cd src >> > >>>> >> > >>>> make buildkernel KERNCONF=3Dheadvm >> > >>>> >> > >>>> >> > >>>> And even >> > >>>> >> > >>>> >> > >>>> make buildkernel KERNCONF=3DGENERIC >> > >>>> >> > >>>> >> > >>>> to make sure that the build works without bbr. >> > >>>> >> > >>>> >> > >>>> I attach my headvm config.. >> > >>>> >> > >>>> >> > >>>> What exactly are you building and how? kernel config too please? >> > >>>> >> > >>>> >> > >>>> R >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> > >>>> >> > >>>> >> > >>>> looking >> > >>>> >> > >>>> >> > >>>> I was at 352408.. let me update and try it >> > >>>> >> > >>>> >> > >>>> R >> > >>>> >> > >>>> >> > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> > >>>> >> > >>>> >> > >>>> Hmm >> > >>>> >> > >>>> >> > >>>> Did you get the patch I updated too this am? >> > >>>> >> > >>>> >> > >>>> I have built it both with and without the bbr stack and had no >> issue.. >> > >>>> there was >> > >>>> >> > >>>> an issue with KTLS before the update though. >> > >>>> >> > >>>> >> > >>>> I don=E2=80=99t recognize what you have below there though=E2=80= =A6 >> > >>>> >> > >>>> >> > >>>> R >> > >>>> >> > >>>> >> > >>>> On Sep 17, 2019, at 11:47 AM, vm finance >> wrote: >> > >>>> >> > >>>> >> > >>>> Got it - thank you! >> > >>>> >> > >>>> >> > >>>> btw, I tried to build the patch but its giving an error. Followin= g >> is SVN >> > >>>> info + make error mesg. >> > >>>> >> > >>>> >> > >>>> Please let me know what am I missing here? >> > >>>> >> > >>>> >> > >>>> Thanks! >> > >>>> >> > >>>> >> > >>>> #svnlite revision >> > >>>> >> > >>>> Path: . >> > >>>> >> > >>>> Working Copy Root Path: /usr/src >> > >>>> >> > >>>> URL: svn://svn.freebsd.org/base/head >> > >>>> >> > >>>> Relative URL: ^/head >> > >>>> >> > >>>> Repository Root: svn://svn.freebsd.org/base >> > >>>> >> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > >>>> >> > >>>> Revision: 352436 >> > >>>> >> > >>>> Node Kind: directory >> > >>>> >> > >>>> Schedule: normal >> > >>>> >> > >>>> Last Changed Author: jah >> > >>>> >> > >>>> Last Changed Rev: 352434 >> > >>>> >> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> > >>>> >> > >>>> >> > >>>> root@osboxes:/usr/src # >> > >>>> >> > >>>> >> > >>>> -------------------------------------------- snip >> > >>>> ---------------------------- >> > >>>> >> > >>>> >> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > >>>> >> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > >>>> >> > >>>> =3D=3D=3D> sys (cleandir) >> > >>>> >> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug= .h >> > >>>> opt_kern_tls.h >> > >>>> >> > >>>> rm: x86: is a directory >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[3]: stopped in /usr/src/sys >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[2]: stopped in /usr/src >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[1]: stopped in /usr/src >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make: stopped in /usr/src >> > >>>> >> > >>>> >> > >>>> >> > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance >> wrote: >> > >>>> >> > >>>> Got it - thank you! >> > >>>> >> > >>>> >> > >>>> btw, I tried to build the patch but its giving an error. Followin= g >> is SVN >> > >>>> info + make error mesg. >> > >>>> >> > >>>> I have also attached the entire build log...snippet is below >> > >>>> >> > >>>> >> > >>>> Please let me know what am I missing here? >> > >>>> >> > >>>> >> > >>>> Thanks! >> > >>>> >> > >>>> >> > >>>> #svnlite revision >> > >>>> >> > >>>> Path: . >> > >>>> >> > >>>> Working Copy Root Path: /usr/src >> > >>>> >> > >>>> URL: svn://svn.freebsd.org/base/head >> > >>>> >> > >>>> Relative URL: ^/head >> > >>>> >> > >>>> Repository Root: svn://svn.freebsd.org/base >> > >>>> >> > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > >>>> >> > >>>> Revision: 352436 >> > >>>> >> > >>>> Node Kind: directory >> > >>>> >> > >>>> Schedule: normal >> > >>>> >> > >>>> Last Changed Author: jah >> > >>>> >> > >>>> Last Changed Rev: 352434 >> > >>>> >> > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> > >>>> >> > >>>> >> > >>>> root@osboxes:/usr/src # >> > >>>> >> > >>>> >> > >>>> -------------------------------------------- snip >> > >>>> ---------------------------- >> > >>>> >> > >>>> >> > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > >>>> >> > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > >>>> >> > >>>> =3D=3D=3D> sys (cleandir) >> > >>>> >> > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h opt_tcpdebug= .h >> > >>>> opt_kern_tls.h >> > >>>> >> > >>>> rm: x86: is a directory >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[3]: stopped in /usr/src/sys >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[2]: stopped in /usr/src >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make[1]: stopped in /usr/src >> > >>>> >> > >>>> *** Error code 1 >> > >>>> >> > >>>> >> > >>>> Stop. >> > >>>> >> > >>>> make: stopped in /usr/src >> > >>>> >> > >>>> >> > >>>> >> > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart >> wrote: >> > >>>> >> > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do no= t >> have >> > >>>> >> > >>>> to have fq.. they built an alternate means of doing pacing into >> bbr. >> > >>>> >> > >>>> >> > >>>> In either case our testing has shown that our pacing is more >> accurate than >> > >>>> >> > >>>> either fq or the internal pacer :) >> > >>>> >> > >>>> >> > >>>> R >> > >>>> >> > >>>> >> > >>>> On Sep 17, 2019, at 11:05 AM, vm finance >> wrote: >> > >>>> >> > >>>> >> > >>>> Thanks Randall. >> > >>>> >> > >>>> I was able to apply the patch - now rebuilding the kernel. Would >> update on >> > >>>> how it goes. >> > >>>> >> > >>>> >> > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD = is >> > >>>> compensated here? >> > >>>> >> > >>>> The original BBR patches on Linux show that as a must-have? Is th= at >> > >>>> functionality implemented via tcp_ratelimit.[ch]? >> > >>>> >> > >>>> >> > >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> > >>>> >> > >>>> >> > >>>> Thanks a lot. >> > >>>> >> > >>>> >> > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> > >>>> >> > >>>> You should be able to compile it against the current head. I >> re-doing that >> > >>>> now (had an >> > >>>> >> > >>>> issue with my machine and had to roll it back to a backup). >> > >>>> >> > >>>> >> > >>>> When I put the patch up on Sept 10th it complied with and without >> BBR on >> > >>>> whatever >> > >>>> >> > >>>> was that rev.. >> > >>>> >> > >>>> >> > >>>> Looking in the commit logs that would have been around 352191 >> > >>>> >> > >>>> >> > >>>> Hope that helps >> > >>>> >> > >>>> >> > >>>> R >> > >>>> >> > >>>> >> > >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > >>>> >> > >>>> >> > >>>> Hi Randall, >> > >>>> >> > >>>> >> > >>>> Thanks for releasing BBR patch: >> > >>>> >> > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > >>>> >> > >>>> >> > >>>> Could you please let me know what SVN/GIT label tag this is based >> on? I >> > >>>> would like to patch and experiment with it. I couldn't find this >> info in >> > >>>> the released patch. >> > >>>> >> > >>>> >> > >>>> Thanks a lot! >> > >>>> >> > >>>> >> > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > >>>> >> > >>>> rrs@ has just posted the BBR patch to phabricator: >> > >>>> >> > >>>> >> > >>>> https://reviews.freebsd.org/D21582 >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> >> > >>>> Randall Stewart >> > >>>> >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> >> > >>>> Randall Stewart >> > >>>> >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> >> > >>>> Randall Stewart >> > >>>> >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> >> > >>>> Randall Stewart >> > >>>> >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> >> > >>>> Randall Stewart >> > >>>> >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>>> ------ >> > >>>> Randall Stewart >> > >>>> rrs@netflix.com >> > >>>> >> > >>>> >> > >>>> >> > >>>> >> > >>> _______________________________________________ >> > >>> freebsd-net@freebsd.org mailing list >> > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > >>> To unsubscribe, send any mail to " >> freebsd-net-unsubscribe@freebsd.org" >> > > >> > > ------ >> > > Randall Stewart >> > > rrs@netflix.com >> > > >> > > >> > > >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Thu Sep 19 12:19:19 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6D80B1218B5 for ; Thu, 19 Sep 2019 12:19:19 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YwrQ20L7z4dsX for ; Thu, 19 Sep 2019 12:19:17 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pg1-x541.google.com with SMTP id a3so1774154pgm.13 for ; Thu, 19 Sep 2019 05:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rf2Dq/2lV4iD6Hq2lvc6+NqfKWiNzOxhkcwm6Us7Ows=; b=fdUL+qgNNFc6EU7nDghAhGMnFE+kuzdez6TShF7lPEtPlhGtvKdcJM8RK+H6bH4z2a DlRMqV3iVDHkq7b6Qe6+VegwTqWEmoTtYPfiEoS4DbeX7qbjr+fLAwEepKamwpIUEWu0 lgl8Qz/vybzatboiItyJRxPY5DpBIoCtDEq2oS0Q4R6ko7eoHt5Ezp6vVuXmCyiSJYA6 5SGXpFPBlvCGAGxRQCaSADAKWozVcFTuW55AsJT9M/ThWPw/EtYVzCv3PzdbdSydcALz QqLb4ktzgVAyTOjC30usnS7TN/y8EzVh6H4zfRENcC10R6bwj7ioMYK9HhJ46CvlhE3w gI4Q== X-Gm-Message-State: APjAAAWb2XB5NYhxSyKMES/bnXTa0FCrRAr6OFxoFBi+jeC8G9ZBt9g1 rBjSEP2ZfpgTahEkRYx68D8iGPL9r10= X-Google-Smtp-Source: APXvYqw8R/4ggj02tPAtTz19Rr0ilYumuESxw29ungZFMh1jlob5FwRs7jKycZJpLsL/Vpu+Iq5MWQ== X-Received: by 2002:a63:4381:: with SMTP id q123mr2488698pga.169.1568895556363; Thu, 19 Sep 2019 05:19:16 -0700 (PDT) Received: from ?IPv6:2607:fb10:7021:1::c2ea? ([2607:fb10:7021:1::c2ea]) by smtp.gmail.com with ESMTPSA id g202sm17448167pfb.155.2019.09.19.05.19.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 05:19:15 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Thu, 19 Sep 2019 05:19:14 -0700 Cc: =?utf-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46YwrQ20L7z4dsX X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.10)[ip: (-0.57), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 12:19:19 -0000 You can look in the config I sent.. but here is what I have added to enable BBR and Rack to be built ***** makeoptions WITH_EXTRA_TCP_STACKS=3D1 options TCPHPTS=09 options RATELIMIT ****** So you should 1) Apply the current patch in phabricator 2) edit your config and add the above three lines 3) go to the src dir and type make buildkernel KERNCONF=3Dmyconf That should build and get you a kernel that will include bbr and rack. = You will need to, after it boots up type kldload tcp_bbr or kldload tcp_rack To get the modules loaded R > On Sep 18, 2019, at 2:31 PM, vm finance wrote: >=20 > Hi Randall, Michael, >=20 > Build is done successfully. I would appreciate if you could share = config changes needed for BBR. >=20 > My svn revision is: 352483 >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | = xargs -J% objcopy % zlib.ko.full > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug = zlib.ko.full zlib.ko > -------------------------------------------------------------- > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 2019 > -------------------------------------------------------------- > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D >=20 > Thank you > Vishal. >=20 >=20 > On Wed, Sep 18, 2019 at 3:34 PM vm finance = wrote: > I'm using amd64. I'd get back as soon as base build is complete. >=20 > Thanks! >=20 > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart = wrote: > To get bbr running you will need to change your kernel config. >=20 > Are you building i386 or amd64? >=20 > After you have successfully did=20 >=20 > 1) buildworld > 2) buildkernel > 3) installkernel >=20 > (you can look in UPDATING for instructions .. though the file is long = :D) >=20 > successfully let me know.. and then I will give you the tweaks you = need to add > to the kerneconf. >=20 > It won=E2=80=99t take as long to build because at that point you can = add in the > NO_CLEAN NO_CLEANDIR options as well since you will have built = everything > the first time >=20 > R >=20 > > On Sep 18, 2019, at 7:06 AM, vm finance = wrote: > >=20 > > BTW, if you think I should be making any changes in configs, please = do let me know. > > My goal is to build a freebsd image with BBR patches on x86 VM.=20 > > Nothing fancy. > >=20 > > thanks! > >=20 > > On Wed, Sep 18, 2019 at 7:03 AM vm finance = wrote: > > Thanks Randall, Michael, > >=20 > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > and now doing "make buildworld buildkernel"=20 > > [I didn't change anything in configs - just whatever are the = defaults] > >=20 > > I would update as soon as its done. > >=20 > > Thanks again! > >=20 > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart = wrote: > > One other note.. I notice his kernel conf he sent does not have > > the right things to get BBR even to attempt to build. > >=20 > > I would suggest using that config for the first steps.. then he must = add > > the additional tcp stacks and the hpts in order to get bbr/rack and = any other > > extra stack=E2=80=A6.=20 > >=20 > > But I would suggest to build with his current config first and once = he has > > that in place and building > >=20 > > a) apply the patch > > b) add the extra kernel options > >=20 > > R > >=20 > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart = wrote: > > >=20 > > > Thats great idea Michael. > > >=20 > > > =46rom the look fo the build log I was sent, his blow-up has = nothing to do > > > with the patches. > > >=20 > > > He should probably > > >=20 > > > 1) Check out a fresh version of head. > > > 2) Follow the instructions in UPDATING to get a clean build. > > > =E2=80=94 make buildworld > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > >=20 > > > ** do the reboot and merge master ** > > >=20 > > > Then after that he could > > >=20 > > > 3) Apply the current patch in the review > > > 4) do build that > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN = -DNO_CLEANDIR > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > >=20 > > > And he should have it all working :) > > >=20 > > > I have done multiple builds with the latest head from yesterday = both with and without > > > the extra stacks and hpts.. and I can=E2=80=99t get a build = failure.. this would verify he can > > > at least build head.. > > >=20 > > > R > > >=20 > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: > > >>=20 > > >>> On 18. Sep 2019, at 08:19, vm finance = wrote: > > >>>=20 > > >>> correcting a typo: > > >>>=20 > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > >>> current revision: 352434 > > >> I suggest to build/install head first without any patches. After = that has worked, > > >> apply the patches you are interested in. That way it is easy to = separate generic > > >> build issues and issue specific to a patch. > > >>=20 > > >> Best regards > > >> Michael > > >>>=20 > > >>> Thank you! > > >>>=20 > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: > > >>>=20 > > >>>> Actually I am on head already as mentioned previously. Pulled = it using > > >>>> yesterday: > > >>>>=20 > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > >>>>=20 > > >>>>=20 > > >>>> If you could pls let me know the new patch, I can try that. > > >>>>=20 > > >>>> Thanks > > >>>>=20 > > >>>> Sent from my iPhone > > >>>>=20 > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart = wrote: > > >>>>=20 > > >>>> There have been several patches pre-this one that provide > > >>>> the infrastructure to support BBR. > > >>>>=20 > > >>>> Release 12.0 will *not* have these patches and will *not* = compile it. > > >>>>=20 > > >>>> I have no intention at this point in doing a MFC of this work.. = so if you > > >>>> want > > >>>> to run BBR you need to run Head > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: > > >>>>=20 > > >>>>=20 > > >>>> Hi Randall, > > >>>>=20 > > >>>>=20 > > >>>> Could you please provide a pointer to the latest patch. I had = applied the > > >>>> one you published Sep-10. > > >>>>=20 > > >>>>=20 > > >>>> Following is what I have done: > > >>>>=20 > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > >>>>=20 > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > >>>>=20 > > >>>> 3. Checked out latest codebase from freebsd repo: > > >>>>=20 > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > >>>>=20 > > >>>> cd /usr/src; > > >>>>=20 > > >>>> make buildworld buildkernel > > >>>>=20 > > >>>> [this is where make fails when patch is applied] > > >>>>=20 > > >>>>=20 > > >>>> I could try to build with your latest patch - please send me a = pointer. > > >>>>=20 > > >>>>=20 > > >>>> Thanks for your help! > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: > > >>>>=20 > > >>>> Looking at your make file log I can=E2=80=99t really tell what = you are doing. > > >>>>=20 > > >>>>=20 > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > >>>>=20 > > >>>>=20 > > >>>> Are you cross compiling? > > >>>>=20 > > >>>>=20 > > >>>> I have done the old fashioned kernel make > > >>>>=20 > > >>>>=20 > > >>>> i.e. > > >>>>=20 > > >>>>=20 > > >>>> cd src/sys/amd64/config > > >>>>=20 > > >>>> config headvm > > >>>>=20 > > >>>> cd ../compile/headvm > > >>>>=20 > > >>>>=20 > > >>>> make cleandepend ; make depend; make -j3 > > >>>>=20 > > >>>>=20 > > >>>> I have done > > >>>>=20 > > >>>>=20 > > >>>> cd src > > >>>>=20 > > >>>> make buildkernel KERNCONF=3Dheadvm > > >>>>=20 > > >>>>=20 > > >>>> And even > > >>>>=20 > > >>>>=20 > > >>>> make buildkernel KERNCONF=3DGENERIC > > >>>>=20 > > >>>>=20 > > >>>> to make sure that the build works without bbr. > > >>>>=20 > > >>>>=20 > > >>>> I attach my headvm config.. > > >>>>=20 > > >>>>=20 > > >>>> What exactly are you building and how? kernel config too = please? > > >>>>=20 > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: > > >>>>=20 > > >>>>=20 > > >>>> looking > > >>>>=20 > > >>>>=20 > > >>>> I was at 352408.. let me update and try it > > >>>>=20 > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>>=20 > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: > > >>>>=20 > > >>>>=20 > > >>>> Hmm > > >>>>=20 > > >>>>=20 > > >>>> Did you get the patch I updated too this am? > > >>>>=20 > > >>>>=20 > > >>>> I have built it both with and without the bbr stack and had no = issue.. > > >>>> there was > > >>>>=20 > > >>>> an issue with KTLS before the update though. > > >>>>=20 > > >>>>=20 > > >>>> I don=E2=80=99t recognize what you have below there though=E2=80=A6= > > >>>>=20 > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>>=20 > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: > > >>>>=20 > > >>>>=20 > > >>>> Got it - thank you! > > >>>>=20 > > >>>>=20 > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > >>>> info + make error mesg. > > >>>>=20 > > >>>>=20 > > >>>> Please let me know what am I missing here? > > >>>>=20 > > >>>>=20 > > >>>> Thanks! > > >>>>=20 > > >>>>=20 > > >>>> #svnlite revision > > >>>>=20 > > >>>> Path: . > > >>>>=20 > > >>>> Working Copy Root Path: /usr/src > > >>>>=20 > > >>>> URL: svn://svn.freebsd.org/base/head > > >>>>=20 > > >>>> Relative URL: ^/head > > >>>>=20 > > >>>> Repository Root: svn://svn.freebsd.org/base > > >>>>=20 > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > >>>>=20 > > >>>> Revision: 352436 > > >>>>=20 > > >>>> Node Kind: directory > > >>>>=20 > > >>>> Schedule: normal > > >>>>=20 > > >>>> Last Changed Author: jah > > >>>>=20 > > >>>> Last Changed Rev: 352434 > > >>>>=20 > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > >>>>=20 > > >>>>=20 > > >>>> root@osboxes:/usr/src # > > >>>>=20 > > >>>>=20 > > >>>> -------------------------------------------- snip > > >>>> ---------------------------- > > >>>>=20 > > >>>>=20 > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > >>>>=20 > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > >>>>=20 > > >>>> =3D=3D=3D> sys (cleandir) > > >>>>=20 > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > >>>> opt_kern_tls.h > > >>>>=20 > > >>>> rm: x86: is a directory > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[3]: stopped in /usr/src/sys > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[2]: stopped in /usr/src > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[1]: stopped in /usr/src > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make: stopped in /usr/src > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > > >>>>=20 > > >>>> Got it - thank you! > > >>>>=20 > > >>>>=20 > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > >>>> info + make error mesg. > > >>>>=20 > > >>>> I have also attached the entire build log...snippet is below > > >>>>=20 > > >>>>=20 > > >>>> Please let me know what am I missing here? > > >>>>=20 > > >>>>=20 > > >>>> Thanks! > > >>>>=20 > > >>>>=20 > > >>>> #svnlite revision > > >>>>=20 > > >>>> Path: . > > >>>>=20 > > >>>> Working Copy Root Path: /usr/src > > >>>>=20 > > >>>> URL: svn://svn.freebsd.org/base/head > > >>>>=20 > > >>>> Relative URL: ^/head > > >>>>=20 > > >>>> Repository Root: svn://svn.freebsd.org/base > > >>>>=20 > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > >>>>=20 > > >>>> Revision: 352436 > > >>>>=20 > > >>>> Node Kind: directory > > >>>>=20 > > >>>> Schedule: normal > > >>>>=20 > > >>>> Last Changed Author: jah > > >>>>=20 > > >>>> Last Changed Rev: 352434 > > >>>>=20 > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > >>>>=20 > > >>>>=20 > > >>>> root@osboxes:/usr/src # > > >>>>=20 > > >>>>=20 > > >>>> -------------------------------------------- snip > > >>>> ---------------------------- > > >>>>=20 > > >>>>=20 > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > >>>>=20 > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > >>>>=20 > > >>>> =3D=3D=3D> sys (cleandir) > > >>>>=20 > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > >>>> opt_kern_tls.h > > >>>>=20 > > >>>> rm: x86: is a directory > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[3]: stopped in /usr/src/sys > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[2]: stopped in /usr/src > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make[1]: stopped in /usr/src > > >>>>=20 > > >>>> *** Error code 1 > > >>>>=20 > > >>>>=20 > > >>>> Stop. > > >>>>=20 > > >>>> make: stopped in /usr/src > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > > >>>>=20 > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do = not have > > >>>>=20 > > >>>> to have fq.. they built an alternate means of doing pacing into = bbr. > > >>>>=20 > > >>>>=20 > > >>>> In either case our testing has shown that our pacing is more = accurate than > > >>>>=20 > > >>>> either fq or the internal pacer :) > > >>>>=20 > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>>=20 > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > > >>>>=20 > > >>>>=20 > > >>>> Thanks Randall. > > >>>>=20 > > >>>> I was able to apply the patch - now rebuilding the kernel. = Would update on > > >>>> how it goes. > > >>>>=20 > > >>>>=20 > > >>>> BTW, is there any description on how lack of tc_fq under = FreeBSD is > > >>>> compensated here? > > >>>>=20 > > >>>> The original BBR patches on Linux show that as a must-have? Is = that > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > >>>>=20 > > >>>>=20 > > >>>> Any pointers to existing presentations/discussions highly = appreciated? > > >>>>=20 > > >>>>=20 > > >>>> Thanks a lot. > > >>>>=20 > > >>>>=20 > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > > >>>>=20 > > >>>> You should be able to compile it against the current head. I = re-doing that > > >>>> now (had an > > >>>>=20 > > >>>> issue with my machine and had to roll it back to a backup). > > >>>>=20 > > >>>>=20 > > >>>> When I put the patch up on Sept 10th it complied with and = without BBR on > > >>>> whatever > > >>>>=20 > > >>>> was that rev.. > > >>>>=20 > > >>>>=20 > > >>>> Looking in the commit logs that would have been around 352191 > > >>>>=20 > > >>>>=20 > > >>>> Hope that helps > > >>>>=20 > > >>>>=20 > > >>>> R > > >>>>=20 > > >>>>=20 > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > > >>>>=20 > > >>>>=20 > > >>>> Hi Randall, > > >>>>=20 > > >>>>=20 > > >>>> Thanks for releasing BBR patch: > > >>>>=20 > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > >>>>=20 > > >>>>=20 > > >>>> Could you please let me know what SVN/GIT label tag this is = based on? I > > >>>> would like to patch and experiment with it. I couldn't find = this info in > > >>>> the released patch. > > >>>>=20 > > >>>>=20 > > >>>> Thanks a lot! > > >>>>=20 > > >>>>=20 > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > >>>>=20 > > >>>> rrs@ has just posted the BBR patch to phabricator: > > >>>>=20 > > >>>>=20 > > >>>> https://reviews.freebsd.org/D21582 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>>=20 > > >>>> Randall Stewart > > >>>>=20 > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>>=20 > > >>>> Randall Stewart > > >>>>=20 > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>>=20 > > >>>> Randall Stewart > > >>>>=20 > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>>=20 > > >>>> Randall Stewart > > >>>>=20 > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>>=20 > > >>>> Randall Stewart > > >>>>=20 > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>> ------ > > >>>> Randall Stewart > > >>>> rrs@netflix.com > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>>>=20 > > >>> _______________________________________________ > > >>> freebsd-net@freebsd.org mailing list > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" > > >=20 > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > >=20 > > >=20 > > >=20 > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Thu Sep 19 14:41:41 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 108DC125323 for ; Thu, 19 Sep 2019 14:41:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Z00h6kdjz3KT9 for ; Thu, 19 Sep 2019 14:41:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E706E125322; Thu, 19 Sep 2019 14:41:40 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E6CC2125321 for ; Thu, 19 Sep 2019 14:41:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z00h5vmZz3KT7 for ; Thu, 19 Sep 2019 14:41:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id AE8C2EFA7 for ; Thu, 19 Sep 2019 14:41:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8JEfepr062434 for ; Thu, 19 Sep 2019 14:41:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8JEfeav062433 for net@FreeBSD.org; Thu, 19 Sep 2019 14:41:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240658] iflib: if_igb(4) and some if_em(4) devices don't recognize/report carrier loss. Date: Thu, 19 Sep 2019 14:41:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: krzysztof.galazka@intel.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 14:41:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240658 Krzysztof Galazka changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |krzysztof.galazka@intel.com --- Comment #2 from Krzysztof Galazka --- This issue was also reported in this PR:https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239240 We were able to reproduce it and are working on a fix. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Sep 19 16:58:45 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B5B3128A50 for ; Thu, 19 Sep 2019 16:58:45 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z32r2W43z40nV for ; Thu, 19 Sep 2019 16:58:44 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd34.google.com with SMTP id r26so9368686ioh.8 for ; Thu, 19 Sep 2019 09:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V7KJ/gJ0lc4R4pMoBSvlOpnQb1CzKxE9xCSvV2hpIjY=; b=DTu37js6DxI45Sd1ZQV2MsztXj78mBWhhNlBAz2LJVJ8yKp3kKOZyrNj3FZzzs3UU2 u8a3z19C2jLj3GdW426MO5TklgX9/dZCiky3g9+QIPOHcccHsdGFZpfiuCaZY6+SBFa8 BPhqSoX62ntC5tjPQkGZZvZDSELWOANWitalezLH7SWcLWAJDgfjwJUsDc3aTugl8bZB PktRLKDR7R+p1XVdpHON9PssBQOVC1+a6cFRH5XZjAQS+R9rLqOlAe8g6f/93hjpUHY9 uiz0dAQkzsQ4GNjCki1r48aaR0gXBBcHYneGx45Q9piCNKsjmqX4+5yRyL+Qu+SXB31j 4w+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V7KJ/gJ0lc4R4pMoBSvlOpnQb1CzKxE9xCSvV2hpIjY=; b=sxw4kHBCOTkzi93iX/bMt9TZQX+AZsdNMLGGVcJvzlYYtTi6zS2flG7VK1jIOTedjT +EUwvgI4WfeA1LG5YsztVocaslXVxjAYJPljhi9XV3gpxkB3k4SUB9uudTO6AKjjWVla LQgenS8OWfU5TsIq9A8iGKW+cbOHxII9qSl9gT8o2bs/c8iKVDmRqCywz9gyJjKsLsR/ FuUZ04jItiN4YMPZS9rB5z7o04DHqpDIjXTIP4zf8iIz70yloqAjdmu4tyMtIyTKO2/S x0qnQziHhKLcPfVSKRQ+k5uswRGzWi99kX+iCQ6+0x6RgkJSmL5KGAgL9dX4HGgAT2uF TBnA== X-Gm-Message-State: APjAAAVK1wnXWBTVQyKqPOe/E16qdTQHG9yLeQ2NgYtxlqkzUupEcnv+ y+E6HKxKHbDlHzsWA1TngdHLOeqlCpwjjxG2A4E= X-Google-Smtp-Source: APXvYqxlMXZivzPoe6Q2rccOxdjupJ9QYHgaz3ohogYpMEKkf3lvlggymdPGZNSKWdseDDdppApXzn5vIrCSPA6zo5w= X-Received: by 2002:a5e:da0a:: with SMTP id x10mr13753006ioj.286.1568912323022; Thu, 19 Sep 2019 09:58:43 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> From: vm finance Date: Thu, 19 Sep 2019 06:08:10 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Type: multipart/mixed; boundary="000000000000b31ec50592eadd1d" X-Rspamd-Queue-Id: 46Z32r2W43z40nV X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=DTu37js6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d34 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~,5:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/mixed,multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.24), ipnet: 2607:f8b0::/32(-2.67), asn: 15169(-2.22), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 16:58:45 -0000 --000000000000b31ec50592eadd1d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Randall, I applied the patch available at: https://reviews.freebsd.org/D21582?id=3D62213 NOTE: This raw patch seems to be exactly the same as the one I downloaded on Sep10...hope I'm not missing anything here... I clicked on "download raw diff" and saved it to bbr_patch.diff file on my local machine Step 1: Apply PATCH: cd /usr/src/sys patch < bbr_patch.diff Patch was applied successfully - no errors seen there. Step 2: Update kernel config: cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL Added three options to MYKERNEL (per ur email - I have also attached the compile MYKERNEL file) cd /usr/src/sys/amd64/compile/MYKERNEL make cleandepend =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ [pls find the attached log file for exact error] make depend =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" STEP 3: cd /usr/src/ make buildkernel KERNCONF=3DMYKERNEL This also fails due to prior errors in Step 2. Please find MYKERNEL config file + error logs. Many many thanks for taking time to help me through this! PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that successfully finished. On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart wrote: > You can look in the config I sent.. but here is what > I have added to enable BBR and Rack to be built > ***** > makeoptions WITH_EXTRA_TCP_STACKS=3D1 > options TCPHPTS > options RATELIMIT > ****** > > So you should > 1) Apply the current patch in phabricator > 2) edit your config and add the above three lines > 3) go to the src dir and type > make buildkernel KERNCONF=3Dmyconf > > That should build and get you a kernel that will include bbr and rack. Yo= u > will > need to, after it boots up type > > kldload tcp_bbr > > or > > kldload tcp_rack > > To get the modules loaded > > R > > > > > On Sep 18, 2019, at 2:31 PM, vm finance wrote: > > > > Hi Randall, Michael, > > > > Build is done successfully. I would appreciate if you could share confi= g > changes needed for BBR. > > > > My svn revision is: 352483 > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | xarg= s > -J% objcopy % zlib.ko.full > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.full > zlib.ko > > -------------------------------------------------------------- > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 2019 > > -------------------------------------------------------------- > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > Thank you > > Vishal. > > > > > > On Wed, Sep 18, 2019 at 3:34 PM vm finance > wrote: > > I'm using amd64. I'd get back as soon as base build is complete. > > > > Thanks! > > > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart wrote= : > > To get bbr running you will need to change your kernel config. > > > > Are you building i386 or amd64? > > > > After you have successfully did > > > > 1) buildworld > > 2) buildkernel > > 3) installkernel > > > > (you can look in UPDATING for instructions .. though the file is long := D) > > > > successfully let me know.. and then I will give you the tweaks you need > to add > > to the kerneconf. > > > > It won=E2=80=99t take as long to build because at that point you can ad= d in the > > NO_CLEAN NO_CLEANDIR options as well since you will have built everythi= ng > > the first time > > > > R > > > > > On Sep 18, 2019, at 7:06 AM, vm finance wrote= : > > > > > > BTW, if you think I should be making any changes in configs, please d= o > let me know. > > > My goal is to build a freebsd image with BBR patches on x86 VM. > > > Nothing fancy. > > > > > > thanks! > > > > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance > wrote: > > > Thanks Randall, Michael, > > > > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > > and now doing "make buildworld buildkernel" > > > [I didn't change anything in configs - just whatever are the defaults= ] > > > > > > I would update as soon as its done. > > > > > > Thanks again! > > > > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart > wrote: > > > One other note.. I notice his kernel conf he sent does not have > > > the right things to get BBR even to attempt to build. > > > > > > I would suggest using that config for the first steps.. then he must > add > > > the additional tcp stacks and the hpts in order to get bbr/rack and > any other > > > extra stack=E2=80=A6. > > > > > > But I would suggest to build with his current config first and once h= e > has > > > that in place and building > > > > > > a) apply the patch > > > b) add the extra kernel options > > > > > > R > > > > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart > wrote: > > > > > > > > Thats great idea Michael. > > > > > > > > From the look fo the build log I was sent, his blow-up has nothing > to do > > > > with the patches. > > > > > > > > He should probably > > > > > > > > 1) Check out a fresh version of head. > > > > 2) Follow the instructions in UPDATING to get a clean build. > > > > =E2=80=94 make buildworld > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > > > > > ** do the reboot and merge master ** > > > > > > > > Then after that he could > > > > > > > > 3) Apply the current patch in the review > > > > 4) do build that > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -DN= O_CLEANDIR > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > > > > > And he should have it all working :) > > > > > > > > I have done multiple builds with the latest head from yesterday bot= h > with and without > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build failure= .. this > would verify he can > > > > at least build head.. > > > > > > > > R > > > > > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > > > >> > > > >>> On 18. Sep 2019, at 08:19, vm finance > wrote: > > > >>> > > > >>> correcting a typo: > > > >>> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > > >>> current revision: 352434 > > > >> I suggest to build/install head first without any patches. After > that has worked, > > > >> apply the patches you are interested in. That way it is easy to > separate generic > > > >> build issues and issue specific to a patch. > > > >> > > > >> Best regards > > > >> Michael > > > >>> > > > >>> Thank you! > > > >>> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance > wrote: > > > >>> > > > >>>> Actually I am on head already as mentioned previously. Pulled it > using > > > >>>> yesterday: > > > >>>> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > > >>>> > > > >>>> > > > >>>> If you could pls let me know the new patch, I can try that. > > > >>>> > > > >>>> Thanks > > > >>>> > > > >>>> Sent from my iPhone > > > >>>> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart > wrote: > > > >>>> > > > >>>> There have been several patches pre-this one that provide > > > >>>> the infrastructure to support BBR. > > > >>>> > > > >>>> Release 12.0 will *not* have these patches and will *not* compil= e > it. > > > >>>> > > > >>>> I have no intention at this point in doing a MFC of this work.. > so if you > > > >>>> want > > > >>>> to run BBR you need to run Head > > > >>>> > > > >>>> R > > > >>>> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance > wrote: > > > >>>> > > > >>>> > > > >>>> Hi Randall, > > > >>>> > > > >>>> > > > >>>> Could you please provide a pointer to the latest patch. I had > applied the > > > >>>> one you published Sep-10. > > > >>>> > > > >>>> > > > >>>> Following is what I have done: > > > >>>> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > > >>>> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > > >>>> > > > >>>> 3. Checked out latest codebase from freebsd repo: > > > >>>> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > > >>>> > > > >>>> cd /usr/src; > > > >>>> > > > >>>> make buildworld buildkernel > > > >>>> > > > >>>> [this is where make fails when patch is applied] > > > >>>> > > > >>>> > > > >>>> I could try to build with your latest patch - please send me a > pointer. > > > >>>> > > > >>>> > > > >>>> Thanks for your help! > > > >>>> > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart > wrote: > > > >>>> > > > >>>> Looking at your make file log I can=E2=80=99t really tell what y= ou are > doing. > > > >>>> > > > >>>> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > >>>> > > > >>>> > > > >>>> Are you cross compiling? > > > >>>> > > > >>>> > > > >>>> I have done the old fashioned kernel make > > > >>>> > > > >>>> > > > >>>> i.e. > > > >>>> > > > >>>> > > > >>>> cd src/sys/amd64/config > > > >>>> > > > >>>> config headvm > > > >>>> > > > >>>> cd ../compile/headvm > > > >>>> > > > >>>> > > > >>>> make cleandepend ; make depend; make -j3 > > > >>>> > > > >>>> > > > >>>> I have done > > > >>>> > > > >>>> > > > >>>> cd src > > > >>>> > > > >>>> make buildkernel KERNCONF=3Dheadvm > > > >>>> > > > >>>> > > > >>>> And even > > > >>>> > > > >>>> > > > >>>> make buildkernel KERNCONF=3DGENERIC > > > >>>> > > > >>>> > > > >>>> to make sure that the build works without bbr. > > > >>>> > > > >>>> > > > >>>> I attach my headvm config.. > > > >>>> > > > >>>> > > > >>>> What exactly are you building and how? kernel config too please? > > > >>>> > > > >>>> > > > >>>> R > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart > wrote: > > > >>>> > > > >>>> > > > >>>> looking > > > >>>> > > > >>>> > > > >>>> I was at 352408.. let me update and try it > > > >>>> > > > >>>> > > > >>>> R > > > >>>> > > > >>>> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart > wrote: > > > >>>> > > > >>>> > > > >>>> Hmm > > > >>>> > > > >>>> > > > >>>> Did you get the patch I updated too this am? > > > >>>> > > > >>>> > > > >>>> I have built it both with and without the bbr stack and had no > issue.. > > > >>>> there was > > > >>>> > > > >>>> an issue with KTLS before the update though. > > > >>>> > > > >>>> > > > >>>> I don=E2=80=99t recognize what you have below there though=E2=80= =A6 > > > >>>> > > > >>>> > > > >>>> R > > > >>>> > > > >>>> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > > > >>>> > > > >>>> > > > >>>> Got it - thank you! > > > >>>> > > > >>>> > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > >>>> info + make error mesg. > > > >>>> > > > >>>> > > > >>>> Please let me know what am I missing here? > > > >>>> > > > >>>> > > > >>>> Thanks! > > > >>>> > > > >>>> > > > >>>> #svnlite revision > > > >>>> > > > >>>> Path: . > > > >>>> > > > >>>> Working Copy Root Path: /usr/src > > > >>>> > > > >>>> URL: svn://svn.freebsd.org/base/head > > > >>>> > > > >>>> Relative URL: ^/head > > > >>>> > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > >>>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > >>>> > > > >>>> Revision: 352436 > > > >>>> > > > >>>> Node Kind: directory > > > >>>> > > > >>>> Schedule: normal > > > >>>> > > > >>>> Last Changed Author: jah > > > >>>> > > > >>>> Last Changed Rev: 352434 > > > >>>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > >>>> > > > >>>> > > > >>>> root@osboxes:/usr/src # > > > >>>> > > > >>>> > > > >>>> -------------------------------------------- snip > > > >>>> ---------------------------- > > > >>>> > > > >>>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > >>>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > >>>> > > > >>>> =3D=3D=3D> sys (cleandir) > > > >>>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > >>>> opt_kern_tls.h > > > >>>> > > > >>>> rm: x86: is a directory > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[3]: stopped in /usr/src/sys > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[2]: stopped in /usr/src > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[1]: stopped in /usr/src > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make: stopped in /usr/src > > > >>>> > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance > wrote: > > > >>>> > > > >>>> Got it - thank you! > > > >>>> > > > >>>> > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > >>>> info + make error mesg. > > > >>>> > > > >>>> I have also attached the entire build log...snippet is below > > > >>>> > > > >>>> > > > >>>> Please let me know what am I missing here? > > > >>>> > > > >>>> > > > >>>> Thanks! > > > >>>> > > > >>>> > > > >>>> #svnlite revision > > > >>>> > > > >>>> Path: . > > > >>>> > > > >>>> Working Copy Root Path: /usr/src > > > >>>> > > > >>>> URL: svn://svn.freebsd.org/base/head > > > >>>> > > > >>>> Relative URL: ^/head > > > >>>> > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > >>>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > >>>> > > > >>>> Revision: 352436 > > > >>>> > > > >>>> Node Kind: directory > > > >>>> > > > >>>> Schedule: normal > > > >>>> > > > >>>> Last Changed Author: jah > > > >>>> > > > >>>> Last Changed Rev: 352434 > > > >>>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) > > > >>>> > > > >>>> > > > >>>> root@osboxes:/usr/src # > > > >>>> > > > >>>> > > > >>>> -------------------------------------------- snip > > > >>>> ---------------------------- > > > >>>> > > > >>>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > >>>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > >>>> > > > >>>> =3D=3D=3D> sys (cleandir) > > > >>>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > >>>> opt_kern_tls.h > > > >>>> > > > >>>> rm: x86: is a directory > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[3]: stopped in /usr/src/sys > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[2]: stopped in /usr/src > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make[1]: stopped in /usr/src > > > >>>> > > > >>>> *** Error code 1 > > > >>>> > > > >>>> > > > >>>> Stop. > > > >>>> > > > >>>> make: stopped in /usr/src > > > >>>> > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart > wrote: > > > >>>> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do > not have > > > >>>> > > > >>>> to have fq.. they built an alternate means of doing pacing into > bbr. > > > >>>> > > > >>>> > > > >>>> In either case our testing has shown that our pacing is more > accurate than > > > >>>> > > > >>>> either fq or the internal pacer :) > > > >>>> > > > >>>> > > > >>>> R > > > >>>> > > > >>>> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > > > >>>> > > > >>>> > > > >>>> Thanks Randall. > > > >>>> > > > >>>> I was able to apply the patch - now rebuilding the kernel. Would > update on > > > >>>> how it goes. > > > >>>> > > > >>>> > > > >>>> BTW, is there any description on how lack of tc_fq under FreeBSD > is > > > >>>> compensated here? > > > >>>> > > > >>>> The original BBR patches on Linux show that as a must-have? Is > that > > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > > >>>> > > > >>>> > > > >>>> Any pointers to existing presentations/discussions highly > appreciated? > > > >>>> > > > >>>> > > > >>>> Thanks a lot. > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart > wrote: > > > >>>> > > > >>>> You should be able to compile it against the current head. I > re-doing that > > > >>>> now (had an > > > >>>> > > > >>>> issue with my machine and had to roll it back to a backup). > > > >>>> > > > >>>> > > > >>>> When I put the patch up on Sept 10th it complied with and withou= t > BBR on > > > >>>> whatever > > > >>>> > > > >>>> was that rev.. > > > >>>> > > > >>>> > > > >>>> Looking in the commit logs that would have been around 352191 > > > >>>> > > > >>>> > > > >>>> Hope that helps > > > >>>> > > > >>>> > > > >>>> R > > > >>>> > > > >>>> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > > > >>>> > > > >>>> > > > >>>> Hi Randall, > > > >>>> > > > >>>> > > > >>>> Thanks for releasing BBR patch: > > > >>>> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > >>>> > > > >>>> > > > >>>> Could you please let me know what SVN/GIT label tag this is base= d > on? I > > > >>>> would like to patch and experiment with it. I couldn't find this > info in > > > >>>> the released patch. > > > >>>> > > > >>>> > > > >>>> Thanks a lot! > > > >>>> > > > >>>> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > > > >>>> > > > >>>> rrs@ has just posted the BBR patch to phabricator: > > > >>>> > > > >>>> > > > >>>> https://reviews.freebsd.org/D21582 > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> > > > >>>> Randall Stewart > > > >>>> > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> > > > >>>> Randall Stewart > > > >>>> > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> > > > >>>> Randall Stewart > > > >>>> > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> > > > >>>> Randall Stewart > > > >>>> > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> > > > >>>> Randall Stewart > > > >>>> > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>>> ------ > > > >>>> Randall Stewart > > > >>>> rrs@netflix.com > > > >>>> > > > >>>> > > > >>>> > > > >>>> > > > >>> _______________________________________________ > > > >>> freebsd-net@freebsd.org mailing list > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > > >>> To unsubscribe, send any mail to " > freebsd-net-unsubscribe@freebsd.org" > > > > > > > > ------ > > > > Randall Stewart > > > > rrs@netflix.com > > > > > > > > > > > > > > > > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > > > > > > > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > --000000000000b31ec50592eadd1d Content-Type: application/octet-stream; name=MYKERNEL Content-Disposition: attachment; filename=MYKERNEL Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0qajp8f0 IwojIEdFTkVSSUMgLS0gR2VuZXJpYyBrZXJuZWwgY29uZmlndXJhdGlvbiBmaWxlIGZvciBGcmVl QlNEL2FtZDY0CiMKIyBGb3IgbW9yZSBpbmZvcm1hdGlvbiBvbiB0aGlzIGZpbGUsIHBsZWFzZSBy ZWFkIHRoZSBjb25maWcoNSkgbWFudWFsIHBhZ2UsCiMgYW5kL29yIHRoZSBoYW5kYm9vayBzZWN0 aW9uIG9uIEtlcm5lbCBDb25maWd1cmF0aW9uIEZpbGVzOgojCiMgICAgaHR0cHM6Ly93d3cuRnJl ZUJTRC5vcmcvZG9jL2VuX1VTLklTTzg4NTktMS9ib29rcy9oYW5kYm9vay9rZXJuZWxjb25maWct Y29uZmlnLmh0bWwKIwojIFRoZSBoYW5kYm9vayBpcyBhbHNvIGF2YWlsYWJsZSBsb2NhbGx5IGlu IC91c3Ivc2hhcmUvZG9jL2hhbmRib29rCiMgaWYgeW91J3ZlIGluc3RhbGxlZCB0aGUgZG9jIGRp c3RyaWJ1dGlvbiwgb3RoZXJ3aXNlIGFsd2F5cyBzZWUgdGhlCiMgRnJlZUJTRCBXb3JsZCBXaWRl IFdlYiBzZXJ2ZXIgKGh0dHBzOi8vd3d3LkZyZWVCU0Qub3JnLykgZm9yIHRoZQojIGxhdGVzdCBp bmZvcm1hdGlvbi4KIwojIEFuIGV4aGF1c3RpdmUgbGlzdCBvZiBvcHRpb25zIGFuZCBtb3JlIGRl dGFpbGVkIGV4cGxhbmF0aW9ucyBvZiB0aGUKIyBkZXZpY2UgbGluZXMgaXMgYWxzbyBwcmVzZW50 IGluIHRoZSAuLi8uLi9jb25mL05PVEVTIGFuZCBOT1RFUyBmaWxlcy4KIyBJZiB5b3UgYXJlIGlu IGRvdWJ0IGFzIHRvIHRoZSBwdXJwb3NlIG9yIG5lY2Vzc2l0eSBvZiBhIGxpbmUsIGNoZWNrIGZp cnN0CiMgaW4gTk9URVMuCiMKIyAkRnJlZUJTRDogaGVhZC9zeXMvYW1kNjQvY29uZi9HRU5FUklD IDM0OTI1MyAyMDE5LTA2LTIxIDAwOjE2OjMwWiBjZW0gJAoKY3B1CQlIQU1NRVIKaWRlbnQJCUdF TkVSSUMKCm1ha2VvcHRpb25zCURFQlVHPS1nCQkjIEJ1aWxkIGtlcm5lbCB3aXRoIGdkYigxKSBk ZWJ1ZyBzeW1ib2xzCm1ha2VvcHRpb25zCVdJVEhfQ1RGPTEJCSMgUnVuIGN0ZmNvbnZlcnQoMSkg Zm9yIERUcmFjZSBzdXBwb3J0Cm1ha2VvcHRpb25zCVdJVEhfRVhUUkFfVENQX1NUQUNLUz0xICNW aXNoYWwgZm9yIEJCUgpvcHRpb25zICAgICAgICAgVENQSFBUUwpvcHRpb25zICAgICAgICAgUkFU RUxJTUlUCm9wdGlvbnMgCVNDSEVEX1VMRQkJIyBVTEUgc2NoZWR1bGVyCm9wdGlvbnMgCU5VTUEJ CQkjIE5vbi1Vbmlmb3JtIE1lbW9yeSBBcmNoaXRlY3R1cmUgc3VwcG9ydApvcHRpb25zIAlQUkVF TVBUSU9OCQkjIEVuYWJsZSBrZXJuZWwgdGhyZWFkIHByZWVtcHRpb24Kb3B0aW9ucyAJVklNQUdF CQkJIyBTdWJzeXN0ZW0gdmlydHVhbGl6YXRpb24sIGUuZy4gVk5FVApvcHRpb25zIAlJTkVUCQkJ IyBJbnRlck5FVHdvcmtpbmcKb3B0aW9ucyAJSU5FVDYJCQkjIElQdjYgY29tbXVuaWNhdGlvbnMg cHJvdG9jb2xzCm9wdGlvbnMgCUlQU0VDX1NVUFBPUlQJCSMgQWxsb3cga2xkbG9hZCBvZiBpcHNl YyBhbmQgdGNwbWQ1Cm9wdGlvbnMgCVRDUF9PRkZMT0FECQkjIFRDUCBvZmZsb2FkCm9wdGlvbnMg CVRDUF9CTEFDS0JPWAkJIyBFbmhhbmNlZCBUQ1AgZXZlbnQgbG9nZ2luZwpvcHRpb25zIAlUQ1Bf SEhPT0sJCSMgaGhvb2soOSkgZnJhbWV3b3JrIGZvciBUQ1AKb3B0aW9ucwkJVENQX1JGQzc0MTMJ CSMgVENQIEZhc3QgT3BlbgpvcHRpb25zIAlTQ1RQCQkJIyBTdHJlYW0gQ29udHJvbCBUcmFuc21p c3Npb24gUHJvdG9jb2wKb3B0aW9ucyAJRkZTCQkJIyBCZXJrZWxleSBGYXN0IEZpbGVzeXN0ZW0K b3B0aW9ucyAJU09GVFVQREFURVMJCSMgRW5hYmxlIEZGUyBzb2Z0IHVwZGF0ZXMgc3VwcG9ydApv cHRpb25zIAlVRlNfQUNMCQkJIyBTdXBwb3J0IGZvciBhY2Nlc3MgY29udHJvbCBsaXN0cwpvcHRp b25zIAlVRlNfRElSSEFTSAkJIyBJbXByb3ZlIHBlcmZvcm1hbmNlIG9uIGJpZyBkaXJlY3Rvcmll cwpvcHRpb25zIAlVRlNfR0pPVVJOQUwJCSMgRW5hYmxlIGdqb3VybmFsLWJhc2VkIFVGUyBqb3Vy bmFsaW5nCm9wdGlvbnMgCVFVT1RBCQkJIyBFbmFibGUgZGlzayBxdW90YXMgZm9yIFVGUwpvcHRp b25zIAlNRF9ST09UCQkJIyBNRCBpcyBhIHBvdGVudGlhbCByb290IGRldmljZQpvcHRpb25zIAlO RlNDTAkJCSMgTmV0d29yayBGaWxlc3lzdGVtIENsaWVudApvcHRpb25zIAlORlNECQkJIyBOZXR3 b3JrIEZpbGVzeXN0ZW0gU2VydmVyCm9wdGlvbnMgCU5GU0xPQ0tECQkjIE5ldHdvcmsgTG9jayBN YW5hZ2VyCm9wdGlvbnMgCU5GU19ST09UCQkjIE5GUyB1c2FibGUgYXMgLywgcmVxdWlyZXMgTkZT Q0wKb3B0aW9ucyAJTVNET1NGUwkJCSMgTVNET1MgRmlsZXN5c3RlbQpvcHRpb25zIAlDRDk2NjAJ CQkjIElTTyA5NjYwIEZpbGVzeXN0ZW0Kb3B0aW9ucyAJUFJPQ0ZTCQkJIyBQcm9jZXNzIGZpbGVz eXN0ZW0gKHJlcXVpcmVzIFBTRVVET0ZTKQpvcHRpb25zIAlQU0VVRE9GUwkJIyBQc2V1ZG8tZmls ZXN5c3RlbSBmcmFtZXdvcmsKb3B0aW9ucyAJR0VPTV9SQUlECQkjIFNvZnQgUkFJRCBmdW5jdGlv bmFsaXR5LgpvcHRpb25zIAlHRU9NX0xBQkVMCQkjIFByb3ZpZGVzIGxhYmVsaXphdGlvbgpvcHRp b25zIAlFRklSVAkJCSMgRUZJIFJ1bnRpbWUgU2VydmljZXMgc3VwcG9ydApvcHRpb25zIAlDT01Q QVRfRlJFRUJTRDMyCSMgQ29tcGF0aWJsZSB3aXRoIGkzODYgYmluYXJpZXMKb3B0aW9ucyAJQ09N UEFUX0ZSRUVCU0Q0CQkjIENvbXBhdGlibGUgd2l0aCBGcmVlQlNENApvcHRpb25zIAlDT01QQVRf RlJFRUJTRDUJCSMgQ29tcGF0aWJsZSB3aXRoIEZyZWVCU0Q1Cm9wdGlvbnMgCUNPTVBBVF9GUkVF QlNENgkJIyBDb21wYXRpYmxlIHdpdGggRnJlZUJTRDYKb3B0aW9ucyAJQ09NUEFUX0ZSRUVCU0Q3 CQkjIENvbXBhdGlibGUgd2l0aCBGcmVlQlNENwpvcHRpb25zIAlDT01QQVRfRlJFRUJTRDkJCSMg Q29tcGF0aWJsZSB3aXRoIEZyZWVCU0Q5Cm9wdGlvbnMgCUNPTVBBVF9GUkVFQlNEMTAJIyBDb21w YXRpYmxlIHdpdGggRnJlZUJTRDEwCm9wdGlvbnMgCUNPTVBBVF9GUkVFQlNEMTEJIyBDb21wYXRp YmxlIHdpdGggRnJlZUJTRDExCm9wdGlvbnMgCUNPTVBBVF9GUkVFQlNEMTIJIyBDb21wYXRpYmxl IHdpdGggRnJlZUJTRDEyCm9wdGlvbnMgCVNDU0lfREVMQVk9NTAwMAkJIyBEZWxheSAoaW4gbXMp IGJlZm9yZSBwcm9iaW5nIFNDU0kKb3B0aW9ucyAJS1RSQUNFCQkJIyBrdHJhY2UoMSkgc3VwcG9y dApvcHRpb25zIAlTVEFDSwkJCSMgc3RhY2soOSkgc3VwcG9ydApvcHRpb25zIAlTWVNWU0hNCQkJ IyBTWVNWLXN0eWxlIHNoYXJlZCBtZW1vcnkKb3B0aW9ucyAJU1lTVk1TRwkJCSMgU1lTVi1zdHls ZSBtZXNzYWdlIHF1ZXVlcwpvcHRpb25zIAlTWVNWU0VNCQkJIyBTWVNWLXN0eWxlIHNlbWFwaG9y ZXMKb3B0aW9ucyAJX0tQT1NJWF9QUklPUklUWV9TQ0hFRFVMSU5HICMgUE9TSVggUDEwMDNfMUIg cmVhbC10aW1lIGV4dGVuc2lvbnMKb3B0aW9ucyAJUFJJTlRGX0JVRlJfU0laRT0xMjgJIyBQcmV2 ZW50IHByaW50ZiBvdXRwdXQgYmVpbmcgaW50ZXJzcGVyc2VkLgpvcHRpb25zIAlLQkRfSU5TVEFM TF9DREVWCSMgaW5zdGFsbCBhIENERVYgZW50cnkgaW4gL2RldgpvcHRpb25zIAlIV1BNQ19IT09L UwkJIyBOZWNlc3Nhcnkga2VybmVsIGhvb2tzIGZvciBod3BtYyg0KQpvcHRpb25zIAlBVURJVAkJ CSMgU2VjdXJpdHkgZXZlbnQgYXVkaXRpbmcKb3B0aW9ucyAJQ0FQQUJJTElUWV9NT0RFCQkjIENh cHNpY3VtIGNhcGFiaWxpdHkgbW9kZQpvcHRpb25zIAlDQVBBQklMSVRJRVMJCSMgQ2Fwc2ljdW0g Y2FwYWJpbGl0aWVzCm9wdGlvbnMgCU1BQwkJCSMgVHJ1c3RlZEJTRCBNQUMgRnJhbWV3b3JrCm9w dGlvbnMgCUtEVFJBQ0VfRlJBTUUJCSMgRW5zdXJlIGZyYW1lcyBhcmUgY29tcGlsZWQgaW4Kb3B0 aW9ucyAJS0RUUkFDRV9IT09LUwkJIyBLZXJuZWwgRFRyYWNlIGhvb2tzCm9wdGlvbnMgCUREQl9D VEYJCQkjIEtlcm5lbCBFTEYgbGlua2VyIGxvYWRzIENURiBkYXRhCm9wdGlvbnMgCUlOQ0xVREVf Q09ORklHX0ZJTEUJIyBJbmNsdWRlIHRoaXMgZmlsZSBpbiBrZXJuZWwKb3B0aW9ucyAJUkFDQ1QJ CQkjIFJlc291cmNlIGFjY291bnRpbmcgZnJhbWV3b3JrCm9wdGlvbnMgCVJBQ0NUX0RFRkFVTFRf VE9fRElTQUJMRUQgIyBTZXQga2Vybi5yYWNjdC5lbmFibGU9MCBieSBkZWZhdWx0Cm9wdGlvbnMg CVJDVEwJCQkjIFJlc291cmNlIGxpbWl0cwoKIyBEZWJ1Z2dpbmcgc3VwcG9ydC4gIEFsd2F5cyBu ZWVkIHRoaXM6Cm9wdGlvbnMgCUtEQgkJCSMgRW5hYmxlIGtlcm5lbCBkZWJ1Z2dlciBzdXBwb3J0 LgpvcHRpb25zIAlLREJfVFJBQ0UJCSMgUHJpbnQgYSBzdGFjayB0cmFjZSBmb3IgYSBwYW5pYy4K IyBGb3IgZnVsbCBkZWJ1Z2dlciBzdXBwb3J0IHVzZSAodHVybiBvZmYgaW4gc3RhYmxlIGJyYW5j aCk6Cm9wdGlvbnMgCUJVRl9UUkFDS0lORwkJIyBUcmFjayBidWZmZXIgaGlzdG9yeQpvcHRpb25z IAlEREIJCQkjIFN1cHBvcnQgRERCLgpvcHRpb25zIAlGVUxMX0JVRl9UUkFDS0lORwkjIFRyYWNr IG1vcmUgYnVmZmVyIGhpc3RvcnkKb3B0aW9ucyAJR0RCCQkJIyBTdXBwb3J0IHJlbW90ZSBHREIu Cm9wdGlvbnMgCURFQURMS1JFUwkJIyBFbmFibGUgdGhlIGRlYWRsb2NrIHJlc29sdmVyCm9wdGlv bnMgCUlOVkFSSUFOVFMJCSMgRW5hYmxlIGNhbGxzIG9mIGV4dHJhIHNhbml0eSBjaGVja2luZwpv cHRpb25zIAlJTlZBUklBTlRfU1VQUE9SVAkjIEV4dHJhIHNhbml0eSBjaGVja3Mgb2YgaW50ZXJu YWwgc3RydWN0dXJlcywgcmVxdWlyZWQgYnkgSU5WQVJJQU5UUwpvcHRpb25zIAlXSVRORVNTCQkJ IyBFbmFibGUgY2hlY2tzIHRvIGRldGVjdCBkZWFkbG9ja3MgYW5kIGN5Y2xlcwpvcHRpb25zIAlX SVRORVNTX1NLSVBTUElOCSMgRG9uJ3QgcnVuIHdpdG5lc3Mgb24gc3BpbmxvY2tzIGZvciBzcGVl ZApvcHRpb25zIAlNQUxMT0NfREVCVUdfTUFYWk9ORVM9OAkjIFNlcGFyYXRlIG1hbGxvYyg5KSB6 b25lcwpvcHRpb25zIAlWRVJCT1NFX1NZU0lOSVQ9MAkjIFN1cHBvcnQgZGVidWcudmVyYm9zZV9z eXNpbml0LCBvZmYgYnkgZGVmYXVsdAoKIyBLZXJuZWwgU2FuaXRpemVycwojb3B0aW9ucyAJQ09W RVJBR0UJCSMgR2VuZXJpYyBrZXJuZWwgY292ZXJhZ2UuIFVzZWQgYnkgS0NPVgojb3B0aW9ucyAJ S0NPVgkJCSMgS2VybmVsIENvdmVyYWdlIFNhbml0aXplcgojIFdhcm5pbmc6IEtVQlNBTiBjYW4g cmVzdWx0IGluIGEga2VybmVsIHRvbyBsYXJnZSBmb3IgbG9hZGVyIHRvIGxvYWQKI29wdGlvbnMg CUtVQlNBTgkJCSMgS2VybmVsIFVuZGVmaW5lZCBCZWhhdmlvciBTYW5pdGl6ZXIKCiMgS2VybmVs IGR1bXAgZmVhdHVyZXMuCm9wdGlvbnMgCUVLQ0QJCQkjIFN1cHBvcnQgZm9yIGVuY3J5cHRlZCBr ZXJuZWwgZHVtcHMKb3B0aW9ucyAJR1pJTwkJCSMgZ3ppcC1jb21wcmVzc2VkIGtlcm5lbCBhbmQg dXNlciBkdW1wcwpvcHRpb25zIAlaU1RESU8JCQkjIHpzdGQtY29tcHJlc3NlZCBrZXJuZWwgYW5k IHVzZXIgZHVtcHMKb3B0aW9ucyAJTkVURFVNUAkJCSMgbmV0ZHVtcCg0KSBjbGllbnQgc3VwcG9y dAoKIyBNYWtlIGFuIFNNUC1jYXBhYmxlIGtlcm5lbCBieSBkZWZhdWx0Cm9wdGlvbnMgCVNNUAkJ CSMgU3ltbWV0cmljIE11bHRpUHJvY2Vzc29yIEtlcm5lbApvcHRpb25zIAlFQVJMWV9BUF9TVEFS VFVQCgojIENQVSBmcmVxdWVuY3kgY29udHJvbApkZXZpY2UJCWNwdWZyZXEKCiMgQnVzIHN1cHBv cnQuCmRldmljZQkJYWNwaQpvcHRpb25zIAlBQ1BJX0RNQVIKZGV2aWNlCQlwY2kKb3B0aW9ucyAJ UENJX0hQCQkJIyBQQ0ktRXhwcmVzcyBuYXRpdmUgSG90UGx1ZwpvcHRpb25zCQlQQ0lfSU9WCQkJ IyBQQ0kgU1ItSU9WIHN1cHBvcnQKCiMgRmxvcHB5IGRyaXZlcwpkZXZpY2UJCWZkYwoKIyBBVEEg Y29udHJvbGxlcnMKZGV2aWNlCQlhaGNpCQkJIyBBSENJLWNvbXBhdGlibGUgU0FUQSBjb250cm9s bGVycwpkZXZpY2UJCWF0YQkJCSMgTGVnYWN5IEFUQS9TQVRBIGNvbnRyb2xsZXJzCmRldmljZQkJ bXZzCQkJIyBNYXJ2ZWxsIDg4U1g1MFhYLzg4U1g2MFhYLzg4U1g3MFhYL1NvQyBTQVRBCmRldmlj ZQkJc2lpcwkJCSMgU2lsaWNvbkltYWdlIFNpSTMxMjQvU2lJMzEzMi9TaUkzNTMxIFNBVEEKCiMg U0NTSSBDb250cm9sbGVycwpkZXZpY2UJCWFoYwkJCSMgQUhBMjk0MCBhbmQgb25ib2FyZCBBSUM3 eHh4IGRldmljZXMKZGV2aWNlCQlhaGQJCQkjIEFIQTM5MzIwLzI5MzIwIGFuZCBvbmJvYXJkIEFJ Qzc5eHggZGV2aWNlcwpkZXZpY2UJCWVzcAkJCSMgQU1EIEFtNTNDOTc0IChUZWtyYW0gREMtMzkw KFQpKQpkZXZpY2UJCWhwdGlvcAkJCSMgSGlnaHBvaW50IFJvY2tldFJhaWQgM3h4eCBzZXJpZXMK ZGV2aWNlCQlpc3AJCQkjIFFsb2dpYyBmYW1pbHkKI2RldmljZQkJaXNwZncJCQkjIEZpcm13YXJl IGZvciBRTG9naWMgSEJBcy0gbm9ybWFsbHkgYSBtb2R1bGUKZGV2aWNlCQltcHQJCQkjIExTSS1M b2dpYyBNUFQtRnVzaW9uCmRldmljZQkJbXBzCQkJIyBMU0ktTG9naWMgTVBULUZ1c2lvbiAyCmRl dmljZQkJbXByCQkJIyBMU0ktTG9naWMgTVBULUZ1c2lvbiAzCmRldmljZQkJc3ltCQkJIyBOQ1Iv U3ltYmlvcyBMb2dpYwpkZXZpY2UJCXRybQkJCSMgVGVrcmFtIERDMzk1VS9VVy9GIERDMzE1VSBh ZGFwdGVycwpkZXZpY2UJCWlzY2kJCQkjIEludGVsIEM2MDAgU0FTIGNvbnRyb2xsZXIKZGV2aWNl CQlvY3NfZmMJCQkjIEVtdWxleCBGQyBhZGFwdGVycwoKIyBBVEEvU0NTSSBwZXJpcGhlcmFscwpk ZXZpY2UJCXNjYnVzCQkJIyBTQ1NJIGJ1cyAocmVxdWlyZWQgZm9yIEFUQS9TQ1NJKQpkZXZpY2UJ CWNoCQkJIyBTQ1NJIG1lZGlhIGNoYW5nZXJzCmRldmljZQkJZGEJCQkjIERpcmVjdCBBY2Nlc3Mg KGRpc2tzKQpkZXZpY2UJCXNhCQkJIyBTZXF1ZW50aWFsIEFjY2VzcyAodGFwZSBldGMpCmRldmlj ZQkJY2QJCQkjIENECmRldmljZQkJcGFzcwkJCSMgUGFzc3Rocm91Z2ggZGV2aWNlIChkaXJlY3Qg QVRBL1NDU0kgYWNjZXNzKQpkZXZpY2UJCXNlcwkJCSMgRW5jbG9zdXJlIFNlcnZpY2VzIChTRVMg YW5kIFNBRi1URSkKI2RldmljZQkJY3RsCQkJIyBDQU0gVGFyZ2V0IExheWVyCgojIFJBSUQgY29u dHJvbGxlcnMgaW50ZXJmYWNlZCB0byB0aGUgU0NTSSBzdWJzeXN0ZW0KZGV2aWNlCQlhbXIJCQkj IEFNSSBNZWdhUkFJRApkZXZpY2UJCWFyY21zcgkJCSMgQXJlY2EgU0FUQSBJSSBSQUlECmRldmlj ZQkJY2lzcwkJCSMgQ29tcGFxIFNtYXJ0IFJBSUQgNSoKZGV2aWNlCQlocHRtdgkJCSMgSGlnaHBv aW50IFJvY2tldFJBSUQgMTgyeApkZXZpY2UJCWhwdG5yCQkJIyBIaWdocG9pbnQgREM3MjgwLCBS NzUwCmRldmljZQkJaHB0cnIJCQkjIEhpZ2hwb2ludCBSb2NrZXRSQUlEIDE3eHgsIDIyeHgsIDIz eHgsIDI1eHgKZGV2aWNlCQlocHQyN3h4CQkJIyBIaWdocG9pbnQgUm9ja2V0UkFJRCAyN3h4CmRl dmljZQkJaWlyCQkJIyBJbnRlbCBJbnRlZ3JhdGVkIFJBSUQKZGV2aWNlCQlpcHMJCQkjIElCTSAo QWRhcHRlYykgU2VydmVSQUlECmRldmljZQkJbWx5CQkJIyBNeWxleCBBY2NlbGVSQUlEL2VYdHJl bWVSQUlECmRldmljZQkJdHdhCQkJIyAzd2FyZSA5MDAwIHNlcmllcyBQQVRBL1NBVEEgUkFJRApk ZXZpY2UJCXNtYXJ0cHFpCQkjIE1pY3Jvc2VtaSBzbWFydHBxaSBkcml2ZXIKZGV2aWNlCQl0d3MJ CQkjIExTSSAzd2FyZSA5NzUwIFNBVEErU0FTIDZHYi9zIFJBSUQgY29udHJvbGxlcgoKIyBSQUlE IGNvbnRyb2xsZXJzCmRldmljZQkJYWFjCQkJIyBBZGFwdGVjIEZTQSBSQUlECmRldmljZQkJYWFj cAkJCSMgU0NTSSBwYXNzdGhyb3VnaCBmb3IgYWFjIChyZXF1aXJlcyBDQU0pCmRldmljZQkJYWFj cmFpZAkJCSMgQWRhcHRlYyBieSBQTUMgUkFJRApkZXZpY2UJCWlkYQkJCSMgQ29tcGFxIFNtYXJ0 IFJBSUQKZGV2aWNlCQltZmkJCQkjIExTSSBNZWdhUkFJRCBTQVMKZGV2aWNlCQltbHgJCQkjIE15 bGV4IERBQzk2MCBmYW1pbHkKZGV2aWNlCQltcnNhcwkJCSMgTFNJL0F2YWdvIE1lZ2FSQUlEIFNB Uy9TQVRBLCA2R2IvcyBhbmQgMTJHYi9zCmRldmljZQkJcG1zcGN2CQkJIyBQTUMtU2llcnJhIFNB Uy9TQVRBIENvbnRyb2xsZXIgZHJpdmVyCiNYWFggcG9pbnRlci9pbnQgd2FybmluZ3MKI2Rldmlj ZQkJcHN0CQkJIyBQcm9taXNlIFN1cGVydHJhayBTWDYwMDAKZGV2aWNlCQl0d2UJCQkjIDN3YXJl IEFUQSBSQUlECgojIE5WTSBFeHByZXNzIChOVk1lKSBzdXBwb3J0CmRldmljZQkJbnZtZQkJCSMg YmFzZSBOVk1lIGRyaXZlcgpkZXZpY2UJCW52ZAkJCSMgZXhwb3NlIE5WTWUgbmFtZXNwYWNlcyBh cyBkaXNrcywgZGVwZW5kcyBvbiBudm1lCgojIGF0a2JkYzAgY29udHJvbHMgYm90aCB0aGUga2V5 Ym9hcmQgYW5kIHRoZSBQUy8yIG1vdXNlCmRldmljZQkJYXRrYmRjCQkJIyBBVCBrZXlib2FyZCBj b250cm9sbGVyCmRldmljZQkJYXRrYmQJCQkjIEFUIGtleWJvYXJkCmRldmljZQkJcHNtCQkJIyBQ Uy8yIG1vdXNlCgpkZXZpY2UJCWtiZG11eAkJCSMga2V5Ym9hcmQgbXVsdGlwbGV4ZXIKCmRldmlj ZQkJdmdhCQkJIyBWR0EgdmlkZW8gY2FyZCBkcml2ZXIKb3B0aW9ucyAJVkVTQQkJCSMgQWRkIHN1 cHBvcnQgZm9yIFZFU0EgQklPUyBFeHRlbnNpb25zIChWQkUpCgpkZXZpY2UJCXNwbGFzaAkJCSMg U3BsYXNoIHNjcmVlbiBhbmQgc2NyZWVuIHNhdmVyIHN1cHBvcnQKCiMgc3lzY29ucyBpcyB0aGUg ZGVmYXVsdCBjb25zb2xlIGRyaXZlciwgcmVzZW1ibGluZyBhbiBTQ08gY29uc29sZQpkZXZpY2UJ CXNjCm9wdGlvbnMgCVNDX1BJWEVMX01PREUJCSMgYWRkIHN1cHBvcnQgZm9yIHRoZSByYXN0ZXIg dGV4dCBtb2RlCgojIHZ0IGlzIHRoZSBuZXcgdmlkZW8gY29uc29sZSBkcml2ZXIKZGV2aWNlCQl2 dApkZXZpY2UJCXZ0X3ZnYQpkZXZpY2UJCXZ0X2VmaWZiCgpkZXZpY2UJCWFncAkJCSMgc3VwcG9y dCBzZXZlcmFsIEFHUCBjaGlwc2V0cwoKIyBQQ0NBUkQgKFBDTUNJQSkgc3VwcG9ydAojIFBDTUNJ QSBhbmQgY2FyZGJ1cyBicmlkZ2Ugc3VwcG9ydApkZXZpY2UJCWNiYgkJCSMgY2FyZGJ1cyAoeWVu dGEpIGJyaWRnZQpkZXZpY2UJCXBjY2FyZAkJCSMgUEMgQ2FyZCAoMTYtYml0KSBidXMKZGV2aWNl CQljYXJkYnVzCQkJIyBDYXJkQnVzICgzMi1iaXQpIGJ1cwoKIyBTZXJpYWwgKENPTSkgcG9ydHMK ZGV2aWNlCQl1YXJ0CQkJIyBHZW5lcmljIFVBUlQgZHJpdmVyCgojIFBhcmFsbGVsIHBvcnQKZGV2 aWNlCQlwcGMKZGV2aWNlCQlwcGJ1cwkJCSMgUGFyYWxsZWwgcG9ydCBidXMgKHJlcXVpcmVkKQpk ZXZpY2UJCWxwdAkJCSMgUHJpbnRlcgpkZXZpY2UJCXBwaQkJCSMgUGFyYWxsZWwgcG9ydCBpbnRl cmZhY2UgZGV2aWNlCiNkZXZpY2UJCXZwbwkJCSMgUmVxdWlyZXMgc2NidXMgYW5kIGRhCgpkZXZp Y2UJCXB1YwkJCSMgTXVsdGkgSS9PIGNhcmRzIGFuZCBtdWx0aS1jaGFubmVsIFVBUlRzCgojIFBD SS9QQ0ktWC9QQ0llIEV0aGVybmV0IE5JQ3MgdGhhdCB1c2UgaWZsaWIgaW5mcmFzdHJ1Y3R1cmUK ZGV2aWNlCQlpZmxpYgpkZXZpY2UJCWVtCQkJIyBJbnRlbCBQUk8vMTAwMCBHaWdhYml0IEV0aGVy bmV0IEZhbWlseQpkZXZpY2UJCWl4CQkJIyBJbnRlbCBQUk8vMTBHYkUgUENJRSBQRiBFdGhlcm5l dApkZXZpY2UJCWl4dgkJCSMgSW50ZWwgUFJPLzEwR2JFIFBDSUUgVkYgRXRoZXJuZXQKZGV2aWNl CQlpeGwJCQkjIEludGVsIDcwMCBTZXJpZXMgUGh5c2ljYWwgRnVuY3Rpb24KZGV2aWNlCQlpYXZm CQkJIyBJbnRlbCBBZGFwdGl2ZSBWaXJ0dWFsIEZ1bmN0aW9uCmRldmljZQkJdm14CQkJIyBWTXdh cmUgVk1YTkVUMyBFdGhlcm5ldAoKIyBQQ0kgRXRoZXJuZXQgTklDcy4KZGV2aWNlCQlieGUJCQkj IEJyb2FkY29tIE5ldFh0cmVtZSBJSSBCQ001NzcxWC9CQ001NzhYWCAxMEdiRQpkZXZpY2UJCWxl CQkJIyBBTUQgQW03OTAwIExBTkNFIGFuZCBBbTc5Qzl4eCBQQ25ldApkZXZpY2UJCXRpCQkJIyBB bHRlb24gTmV0d29ya3MgVGlnb24gSS9JSSBnaWdhYml0IEV0aGVybmV0CgojIFBDSSBFdGhlcm5l dCBOSUNzIHRoYXQgdXNlIHRoZSBjb21tb24gTUlJIGJ1cyBjb250cm9sbGVyIGNvZGUuCiMgTk9U RTogQmUgc3VyZSB0byBrZWVwIHRoZSAnZGV2aWNlIG1paWJ1cycgbGluZSBpbiBvcmRlciB0byB1 c2UgdGhlc2UgTklDcyEKZGV2aWNlCQltaWlidXMJCQkjIE1JSSBidXMgc3VwcG9ydApkZXZpY2UJ CWFlCQkJIyBBdHRhbnNpYy9BdGhlcm9zIEwyIEZhc3RFdGhlcm5ldApkZXZpY2UJCWFnZQkJCSMg QXR0YW5zaWMvQXRoZXJvcyBMMSBHaWdhYml0IEV0aGVybmV0CmRldmljZQkJYWxjCQkJIyBBdGhl cm9zIEFSODEzMS9BUjgxMzIgRXRoZXJuZXQKZGV2aWNlCQlhbGUJCQkjIEF0aGVyb3MgQVI4MTIx L0FSODExMy9BUjgxMTQgRXRoZXJuZXQKZGV2aWNlCQliY2UJCQkjIEJyb2FkY29tIEJDTTU3MDYv QkNNNTcwOCBHaWdhYml0IEV0aGVybmV0CmRldmljZQkJYmZlCQkJIyBCcm9hZGNvbSBCQ000NDB4 IDEwLzEwMCBFdGhlcm5ldApkZXZpY2UJCWJnZQkJCSMgQnJvYWRjb20gQkNNNTcweHggR2lnYWJp dCBFdGhlcm5ldApkZXZpY2UJCWNhcwkJCSMgU3VuIENhc3NpbmkvQ2Fzc2luaSsgYW5kIE5TIERQ ODMwNjUgU2F0dXJuCmRldmljZQkJZGMJCQkjIERFQy9JbnRlbCAyMTE0MyBhbmQgdmFyaW91cyB3 b3JrYWxpa2VzCmRldmljZQkJZXQJCQkjIEFnZXJlIEVUMTMxMCAxMC8xMDAvR2lnYWJpdCBFdGhl cm5ldApkZXZpY2UJCWZ4cAkJCSMgSW50ZWwgRXRoZXJFeHByZXNzIFBSTy8xMDBCICg4MjU1Nywg ODI1NTgpCmRldmljZQkJZ2VtCQkJIyBTdW4gR0VNL1N1biBFUkkvQXBwbGUgR01BQwpkZXZpY2UJ CWhtZQkJCSMgU3VuIEhNRSAoSGFwcHkgTWVhbCBFdGhlcm5ldCkKZGV2aWNlCQlqbWUJCQkjIEpN aWNyb24gSk1DMjUwIEdpZ2FiaXQvSk1DMjYwIEZhc3QgRXRoZXJuZXQKZGV2aWNlCQlsZ2UJCQkj IExldmVsIDEgTFhUMTAwMSBnaWdhYml0IEV0aGVybmV0CmRldmljZQkJbXNrCQkJIyBNYXJ2ZWxs L1N5c0tvbm5lY3QgWXVrb24gSUkgR2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCW5mZQkJCSMgblZp ZGlhIG5Gb3JjZSBNQ1Agb24tYm9hcmQgRXRoZXJuZXQKZGV2aWNlCQluZ2UJCQkjIE5hdFNlbWkg RFA4MzgyMCBnaWdhYml0IEV0aGVybmV0CmRldmljZQkJcmUJCQkjIFJlYWxUZWsgODEzOUMrLzgx NjkvODE2OVMvODExMFMKZGV2aWNlCQlybAkJCSMgUmVhbFRlayA4MTI5LzgxMzkKZGV2aWNlCQlz Z2UJCQkjIFNpbGljb24gSW50ZWdyYXRlZCBTeXN0ZW1zIFNpUzE5MC8xOTEKZGV2aWNlCQlzaXMJ CQkjIFNpbGljb24gSW50ZWdyYXRlZCBTeXN0ZW1zIFNpUyA5MDAvU2lTIDcwMTYKZGV2aWNlCQlz awkJCSMgU3lzS29ubmVjdCBTSy05ODR4ICYgU0stOTgyeCBnaWdhYml0IEV0aGVybmV0CmRldmlj ZQkJc3RlCQkJIyBTdW5kYW5jZSBTVDIwMSAoRC1MaW5rIERGRS01NTBUWCkKZGV2aWNlCQlzdGdl CQkJIyBTdW5kYW5jZS9UYW1hcmFjayBUQzkwMjEgZ2lnYWJpdCBFdGhlcm5ldApkZXZpY2UJCXZn ZQkJCSMgVklBIFZUNjEyeCBnaWdhYml0IEV0aGVybmV0CmRldmljZQkJdnIJCQkjIFZJQSBSaGlu ZSwgUmhpbmUgSUkKZGV2aWNlCQl4bAkJCSMgM0NvbSAzYzkweCAoYGBCb29tZXJhbmcnJywgYGBD eWNsb25lJycpCgojIFdpcmVsZXNzIE5JQyBjYXJkcwpkZXZpY2UJCXdsYW4JCQkjIDgwMi4xMSBz dXBwb3J0Cm9wdGlvbnMgCUlFRUU4MDIxMV9ERUJVRwkJIyBlbmFibGUgZGVidWcgbXNncwpvcHRp b25zIAlJRUVFODAyMTFfU1VQUE9SVF9NRVNICSMgZW5hYmxlIDgwMi4xMXMgZHJhZnQgc3VwcG9y dApkZXZpY2UJCXdsYW5fd2VwCQkjIDgwMi4xMSBXRVAgc3VwcG9ydApkZXZpY2UJCXdsYW5fY2Nt cAkJIyA4MDIuMTEgQ0NNUCBzdXBwb3J0CmRldmljZQkJd2xhbl90a2lwCQkjIDgwMi4xMSBUS0lQ IHN1cHBvcnQKZGV2aWNlCQl3bGFuX2FtcnIJCSMgQU1SUiB0cmFuc21pdCByYXRlIGNvbnRyb2wg YWxnb3JpdGhtCmRldmljZQkJYW4JCQkjIEFpcm9uZXQgNDUwMC80ODAwIDgwMi4xMSB3aXJlbGVz cyBOSUNzLgpkZXZpY2UJCWF0aAkJCSMgQXRoZXJvcyBOSUNzCmRldmljZQkJYXRoX3BjaQkJCSMg QXRoZXJvcyBwY2kvY2FyZGJ1cyBnbHVlCmRldmljZQkJYXRoX2hhbAkJCSMgcGNpL2NhcmRidXMg Y2hpcCBzdXBwb3J0Cm9wdGlvbnMgCUFIX0FSNTQxNl9JTlRFUlJVUFRfTUlUSUdBVElPTiAjIEFS NTQxNiBpbnRlcnJ1cHQgbWl0aWdhdGlvbgpvcHRpb25zIAlBVEhfRU5BQkxFXzExTgkJIyBFbmFi bGUgODAyLjExbiBzdXBwb3J0IGZvciBBUjU0MTYgYW5kIGxhdGVyCmRldmljZQkJYXRoX3JhdGVf c2FtcGxlCQkjIFNhbXBsZVJhdGUgdHggcmF0ZSBjb250cm9sIGZvciBhdGgKI2RldmljZQkJYndp CQkJIyBCcm9hZGNvbSBCQ000MzB4L0JDTTQzMXggd2lyZWxlc3MgTklDcy4KI2RldmljZQkJYndu CQkJIyBCcm9hZGNvbSBCQ000M3h4IHdpcmVsZXNzIE5JQ3MuCmRldmljZQkJaXB3CQkJIyBJbnRl bCAyMTAwIHdpcmVsZXNzIE5JQ3MuCmRldmljZQkJaXdpCQkJIyBJbnRlbCAyMjAwQkcvMjIyNUJH LzI5MTVBQkcgd2lyZWxlc3MgTklDcy4KZGV2aWNlCQlpd24JCQkjIEludGVsIDQ5NjUvMTAwMC81 MDAwLzYwMDAgd2lyZWxlc3MgTklDcy4KZGV2aWNlCQltYWxvCQkJIyBNYXJ2ZWxsIExpYmVydGFz IHdpcmVsZXNzIE5JQ3MuCmRldmljZQkJbXdsCQkJIyBNYXJ2ZWxsIDg4VzgzNjMgODAyLjExbiB3 aXJlbGVzcyBOSUNzLgpkZXZpY2UJCXJhbAkJCSMgUmFsaW5rIFRlY2hub2xvZ3kgUlQyNTAwIHdp cmVsZXNzIE5JQ3MuCmRldmljZQkJd2kJCQkjIFdhdmVMQU4vSW50ZXJzaWwvU3ltYm9sIDgwMi4x MSB3aXJlbGVzcyBOSUNzLgpkZXZpY2UJCXdwaQkJCSMgSW50ZWwgMzk0NUFCRyB3aXJlbGVzcyBO SUNzLgoKIyBQc2V1ZG8gZGV2aWNlcy4KZGV2aWNlCQljcnlwdG8JCQkjIGNvcmUgY3J5cHRvIHN1 cHBvcnQKZGV2aWNlCQlsb29wCQkJIyBOZXR3b3JrIGxvb3BiYWNrCmRldmljZQkJcGFkbG9ja19y bmcJCSMgVklBIFBhZGxvY2sgUk5HCmRldmljZQkJcmRyYW5kX3JuZwkJIyBJbnRlbCBCdWxsIE1v dW50YWluIFJORwpkZXZpY2UJCWV0aGVyCQkJIyBFdGhlcm5ldCBzdXBwb3J0CmRldmljZQkJdmxh bgkJCSMgODAyLjFRIFZMQU4gc3VwcG9ydApkZXZpY2UJCXR1bnRhcAkJCSMgUGFja2V0IHR1bm5l bC4KZGV2aWNlCQltZAkJCSMgTWVtb3J5ICJkaXNrcyIKZGV2aWNlCQlnaWYJCQkjIElQdjYgYW5k IElQdjQgdHVubmVsaW5nCmRldmljZQkJZmlybXdhcmUJCSMgZmlybXdhcmUgYXNzaXN0IG1vZHVs ZQoKIyBUaGUgYGJwZicgZGV2aWNlIGVuYWJsZXMgdGhlIEJlcmtlbGV5IFBhY2tldCBGaWx0ZXIu CiMgQmUgYXdhcmUgb2YgdGhlIGFkbWluaXN0cmF0aXZlIGNvbnNlcXVlbmNlcyBvZiBlbmFibGlu ZyB0aGlzIQojIE5vdGUgdGhhdCAnYnBmJyBpcyByZXF1aXJlZCBmb3IgREhDUC4KZGV2aWNlCQli cGYJCQkjIEJlcmtlbGV5IHBhY2tldCBmaWx0ZXIKCiMgVVNCIHN1cHBvcnQKb3B0aW9ucyAJVVNC X0RFQlVHCQkjIGVuYWJsZSBkZWJ1ZyBtc2dzCmRldmljZQkJdWhjaQkJCSMgVUhDSSBQQ0ktPlVT QiBpbnRlcmZhY2UKZGV2aWNlCQlvaGNpCQkJIyBPSENJIFBDSS0+VVNCIGludGVyZmFjZQpkZXZp Y2UJCWVoY2kJCQkjIEVIQ0kgUENJLT5VU0IgaW50ZXJmYWNlIChVU0IgMi4wKQpkZXZpY2UJCXho Y2kJCQkjIFhIQ0kgUENJLT5VU0IgaW50ZXJmYWNlIChVU0IgMy4wKQpkZXZpY2UJCXVzYgkJCSMg VVNCIEJ1cyAocmVxdWlyZWQpCmRldmljZQkJdWtiZAkJCSMgS2V5Ym9hcmQKZGV2aWNlCQl1bWFz cwkJCSMgRGlza3MvTWFzcyBzdG9yYWdlIC0gUmVxdWlyZXMgc2NidXMgYW5kIGRhCgojIFNvdW5k IHN1cHBvcnQKZGV2aWNlCQlzb3VuZAkJCSMgR2VuZXJpYyBzb3VuZCBkcml2ZXIgKHJlcXVpcmVk KQpkZXZpY2UJCXNuZF9jbWkJCQkjIENNZWRpYSBDTUk4MzM4L0NNSTg3MzgKZGV2aWNlCQlzbmRf Y3NhCQkJIyBDcnlzdGFsIFNlbWljb25kdWN0b3IgQ1M0NjF4LzQyOHgKZGV2aWNlCQlzbmRfZW11 MTBreAkJIyBDcmVhdGl2ZSBTb3VuZEJsYXN0ZXIgTGl2ZSEgYW5kIEF1ZGlneQpkZXZpY2UJCXNu ZF9lczEzN3gJCSMgRW5zb25pcSBBdWRpb1BDSSBFUzEzN3gKZGV2aWNlCQlzbmRfaGRhCQkJIyBJ bnRlbCBIaWdoIERlZmluaXRpb24gQXVkaW8KZGV2aWNlCQlzbmRfaWNoCQkJIyBJbnRlbCwgTlZp ZGlhIGFuZCBvdGhlciBJQ0ggQUMnOTcgQXVkaW8KZGV2aWNlCQlzbmRfdmlhODIzMwkJIyBWSUEg VlQ4MjMzeCBBdWRpbwoKIyBNTUMvU0QKZGV2aWNlCQltbWMJCQkjIE1NQy9TRCBidXMKZGV2aWNl CQltbWNzZAkJCSMgTU1DL1NEIG1lbW9yeSBjYXJkCmRldmljZQkJc2RoY2kJCQkjIEdlbmVyaWMg UENJIFNEIEhvc3QgQ29udHJvbGxlcgoKIyBWaXJ0SU8gc3VwcG9ydApkZXZpY2UJCXZpcnRpbwkJ CSMgR2VuZXJpYyBWaXJ0SU8gYnVzIChyZXF1aXJlZCkKZGV2aWNlCQl2aXJ0aW9fcGNpCQkjIFZp cnRJTyBQQ0kgZGV2aWNlCmRldmljZQkJdnRuZXQJCQkjIFZpcnRJTyBFdGhlcm5ldCBkZXZpY2UK ZGV2aWNlCQl2aXJ0aW9fYmxrCQkjIFZpcnRJTyBCbG9jayBkZXZpY2UKZGV2aWNlCQl2aXJ0aW9f c2NzaQkJIyBWaXJ0SU8gU0NTSSBkZXZpY2UKZGV2aWNlCQl2aXJ0aW9fYmFsbG9vbgkJIyBWaXJ0 SU8gTWVtb3J5IEJhbGxvb24gZGV2aWNlCgojIEh5cGVyViBkcml2ZXJzIGFuZCBlbmhhbmNlbWVu dCBzdXBwb3J0CmRldmljZQkJaHlwZXJ2CQkJIyBIeXBlclYgZHJpdmVycyAKCiMgWGVuIEhWTSBH dWVzdCBPcHRpbWl6YXRpb25zCiMgTk9URTogWEVOSFZNIGRlcGVuZHMgb24geGVucGNpLiAgVGhl eSBtdXN0IGJlIGFkZGVkIG9yIHJlbW92ZWQgdG9nZXRoZXIuCm9wdGlvbnMgCVhFTkhWTQkJCSMg WGVuIEhWTSBrZXJuZWwgaW5mcmFzdHJ1Y3R1cmUKZGV2aWNlCQl4ZW5wY2kJCQkjIFhlbiBIVk0g SHlwZXJ2aXNvciBzZXJ2aWNlcyBkcml2ZXIKCiMgTmV0bWFwIHByb3ZpZGVzIGRpcmVjdCBhY2Nl c3MgdG8gVFgvUlggcmluZ3Mgb24gc3VwcG9ydGVkIE5JQ3MKZGV2aWNlCQluZXRtYXAJCQkjIG5l dG1hcCg0KSBzdXBwb3J0CgojIGV2ZGV2IGludGVyZmFjZQpvcHRpb25zIAlFVkRFVl9TVVBQT1JU CQkjIGV2ZGV2IHN1cHBvcnQgaW4gbGVnYWN5IGRyaXZlcnMKZGV2aWNlCQlldmRldgkJCSMgaW5w dXQgZXZlbnQgZGV2aWNlIHN1cHBvcnQKZGV2aWNlCQl1aW5wdXQJCQkjIGluc3RhbGwgL2Rldi91 aW5wdXQgY2Rldgo= --000000000000b31ec50592eadd1d Content-Type: application/octet-stream; name="1.2" Content-Disposition: attachment; filename="1.2" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0qajyaf1 CnJvb3RAb3Nib3hlczovdXNyL3NyYy9zeXMvYW1kNjQvY29tcGlsZS9NWUtFUk5FTCAjIG1ha2Ug Y2xlYW5kZXBlbmQKClsuLi5zbmlwLi4uXQoKcm0gLWYgbWFjaGluZSB4ODYgLmRlcGVuZCAuZGVw ZW5kLiogR1BBVEggR1JUQUdTIEdTWU1TIEdUQUdTCj09PT4gdGNwIChjbGVhbmRlcGVuZCkKPT09 PiB0Y3AvYmJyIChjbGVhbmRlcGVuZCkKY2Q6IC91c3Ivc3JjL3N5cy9tb2R1bGVzL3RjcC9iYnI6 IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnkKKioqIEVycm9yIGNvZGUgMgoKU3RvcC4KbWFrZVsy XTogc3RvcHBlZCBpbiAvdXNyL3NyYy9zeXMvbW9kdWxlcy90Y3AKKioqIEVycm9yIGNvZGUgMQoK U3RvcC4KbWFrZVsxXTogc3RvcHBlZCBpbiAvdXNyL3NyYy9zeXMvbW9kdWxlcwoqKiogRXJyb3Ig Y29kZSAxCgpTdG9wLgptYWtlOiBzdG9wcGVkIGluIC91c3Ivc3JjL3N5cy9hbWQ2NC9jb21waWxl L01ZS0VSTkVMCgpyb290QG9zYm94ZXM6L3Vzci9zcmMvc3lzL2FtZDY0L2NvbXBpbGUvTVlLRVJO RUwgIyBscyAvdXNyL3NyYy9zeXMvbW9kdWxlcy90Y3AvCk1ha2VmaWxlICAgICAgICBNYWtlZmls ZS5vcmlnICAgcmFjayAgICAgICAgICAgIHRjcG1kNQoK --000000000000b31ec50592eadd1d-- From owner-freebsd-net@freebsd.org Thu Sep 19 17:42:40 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69406129EB1 for ; Thu, 19 Sep 2019 17:42:40 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z41W2nR6z44Tq for ; Thu, 19 Sep 2019 17:42:39 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2f.google.com with SMTP id b19so9804968iob.4 for ; Thu, 19 Sep 2019 10:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yqwBF+516nFOEactK7NPyfnaCZAeJoOwVrYiUbcJz9c=; b=OZiA9nXqvLzdA3g5UMLR6hf7upvz8J14sX9BTmCyFc+c5r1uk9+eewDF8cPJdYPF0Y PtMWrLKtadEUKNIE79jOsozSRF1r0RbFJeCWlnTWuaodmK0VMc6uaDwoIX5WLNPqNRTw 3WgMwfzYt5ZwqfY43fNHnt5rfj+YJssSvie5X1XIjj3O7GCBn0BYWXH1kj3joqCeSy7X NG7SSuK2tjiOYCwSktaIvyuF9j4Y0rKShJQGVL22fqZazzbqMxpKbJ2umUy6hyfnfFyO FRN1xes/QrqIYhQG76vOz+HhwNUKTyhA1MnziDzsW83YZcQFG2EyEDqsz919hxTeNnv5 boYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yqwBF+516nFOEactK7NPyfnaCZAeJoOwVrYiUbcJz9c=; b=qgmvIHr55z+1emCeNbDejufttm6MZ+LtBrC72gHlcTMST4yc07yAH+hTdq/bZHa2nb DqhL+mI0tF9jOkNPl+wY8uxMVwAjtSIMT0UdpBorYnxjv0w6W0JGUHit5WTnLNPYTYNi T9ajVcOckfgzOYoxXTRS4iAERpwgOMnWRTdTZLcloaTlqAWOx2U7DTolMC7X59QXCP4v rtuIgi9skvQVUeLqvrsCDwXA+labDD5V8OmjuDVoRzCGEqyNNve5B0HrYi7hYr6335Zk YSIUl7gHDOFm/BMuiQVyCkZ/Bv+SHO4CS/ZoAMrebCdy0YAjG+czwq5t+lvimj1uU/+B WGOw== X-Gm-Message-State: APjAAAUjbu5lk6jwxlztAGUbwNRApkOn270Ip2k42BSLH2ewlYX7R31e CXIyufuyPXCT6lHjOHhoto/WIrFuciS+81A9T7E= X-Google-Smtp-Source: APXvYqxoZxeqqCA9Prev5FIlGwR7R3yEt7sQ2QUOD929zVZv0aiOZQv0NjeQoiBGmhremRpoPdsyMP/PLQ4rkqsYx/c= X-Received: by 2002:a6b:7a42:: with SMTP id k2mr7069438iop.303.1568914958065; Thu, 19 Sep 2019 10:42:38 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 10:42:26 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46Z41W2nR6z44Tq X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=OZiA9nXq; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2f as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[f.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-6.02), ipnet: 2607:f8b0::/32(-2.67), asn: 15169(-2.22), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 17:42:40 -0000 Hello Randall, I just retried it with headvm config that you had shared but still see error while doing "make cleandepend" Any pointers highly appreciated. Thanks root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend [...snip...] =3D=3D=3D> sysvipc/sysvshm (obj) /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sysvs= hm created for /usr/src/sys/modules/sysvipc/sysvshm =3D=3D=3D> tcp (obj) =3D=3D=3D> tcp/bbr (obj) cd: /usr/src/sys/modules/tcp/bbr: No such file or directory *** Error code 2 Stop. make[2]: stopped in /usr/src/sys/modules/tcp *** Error code 1 Stop. make[1]: stopped in /usr/src/sys/modules *** Error code 1 Stop. make: stopped in /usr/src/sys/amd64/compile/headvm root@osboxes:/usr/src/sys/amd64/compile/headvm # On Wed, Sep 18, 2019 at 11:08 PM vm finance wrote: > Hi Randall, > > I applied the patch available at: > https://reviews.freebsd.org/D21582?id=3D62213 > NOTE: This raw patch seems to be exactly the same as the one I downloaded > on Sep10...hope I'm not missing anything here... > > I clicked on "download raw diff" and saved it to bbr_patch.diff file on m= y > local machine > Step 1: Apply PATCH: > cd /usr/src/sys > patch < bbr_patch.diff > Patch was applied successfully - no errors seen there. > > Step 2: Update kernel config: > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL > Added three options to MYKERNEL (per ur email - I have also attached the > compile MYKERNEL file) > cd /usr/src/sys/amd64/compile/MYKERNEL > make cleandepend > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ > [pls find the attached log file for exact error] > > make depend > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" > > STEP 3: > cd /usr/src/ > make buildkernel KERNCONF=3DMYKERNEL > This also fails due to prior errors in Step 2. > > Please find MYKERNEL config file + error logs. > > Many many thanks for taking time to help me through this! > > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that > successfully finished. > > > > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart wrote: > >> You can look in the config I sent.. but here is what >> I have added to enable BBR and Rack to be built >> ***** >> makeoptions WITH_EXTRA_TCP_STACKS=3D1 >> options TCPHPTS >> options RATELIMIT >> ****** >> >> So you should >> 1) Apply the current patch in phabricator >> 2) edit your config and add the above three lines >> 3) go to the src dir and type >> make buildkernel KERNCONF=3Dmyconf >> >> That should build and get you a kernel that will include bbr and rack. >> You will >> need to, after it boots up type >> >> kldload tcp_bbr >> >> or >> >> kldload tcp_rack >> >> To get the modules loaded >> >> R >> >> >> >> > On Sep 18, 2019, at 2:31 PM, vm finance wrote: >> > >> > Hi Randall, Michael, >> > >> > Build is done successfully. I would appreciate if you could share >> config changes needed for BBR. >> > >> > My svn revision is: 352483 >> > >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >> xargs -J% objcopy % zlib.ko.full >> > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >> > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.ful= l >> zlib.ko >> > -------------------------------------------------------------- >> > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 2019 >> > -------------------------------------------------------------- >> > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >> > >> > Thank you >> > Vishal. >> > >> > >> > On Wed, Sep 18, 2019 at 3:34 PM vm finance >> wrote: >> > I'm using amd64. I'd get back as soon as base build is complete. >> > >> > Thanks! >> > >> > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >> wrote: >> > To get bbr running you will need to change your kernel config. >> > >> > Are you building i386 or amd64? >> > >> > After you have successfully did >> > >> > 1) buildworld >> > 2) buildkernel >> > 3) installkernel >> > >> > (you can look in UPDATING for instructions .. though the file is long >> :D) >> > >> > successfully let me know.. and then I will give you the tweaks you nee= d >> to add >> > to the kerneconf. >> > >> > It won=E2=80=99t take as long to build because at that point you can a= dd in the >> > NO_CLEAN NO_CLEANDIR options as well since you will have built >> everything >> > the first time >> > >> > R >> > >> > > On Sep 18, 2019, at 7:06 AM, vm finance >> wrote: >> > > >> > > BTW, if you think I should be making any changes in configs, please >> do let me know. >> > > My goal is to build a freebsd image with BBR patches on x86 VM. >> > > Nothing fancy. >> > > >> > > thanks! >> > > >> > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >> wrote: >> > > Thanks Randall, Michael, >> > > >> > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >> > > and now doing "make buildworld buildkernel" >> > > [I didn't change anything in configs - just whatever are the default= s] >> > > >> > > I would update as soon as its done. >> > > >> > > Thanks again! >> > > >> > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >> wrote: >> > > One other note.. I notice his kernel conf he sent does not have >> > > the right things to get BBR even to attempt to build. >> > > >> > > I would suggest using that config for the first steps.. then he must >> add >> > > the additional tcp stacks and the hpts in order to get bbr/rack and >> any other >> > > extra stack=E2=80=A6. >> > > >> > > But I would suggest to build with his current config first and once >> he has >> > > that in place and building >> > > >> > > a) apply the patch >> > > b) add the extra kernel options >> > > >> > > R >> > > >> > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >> wrote: >> > > > >> > > > Thats great idea Michael. >> > > > >> > > > From the look fo the build log I was sent, his blow-up has nothing >> to do >> > > > with the patches. >> > > > >> > > > He should probably >> > > > >> > > > 1) Check out a fresh version of head. >> > > > 2) Follow the instructions in UPDATING to get a clean build. >> > > > =E2=80=94 make buildworld >> > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > > > >> > > > ** do the reboot and merge master ** >> > > > >> > > > Then after that he could >> > > > >> > > > 3) Apply the current patch in the review >> > > > 4) do build that >> > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -D= NO_CLEANDIR >> > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > > > >> > > > And he should have it all working :) >> > > > >> > > > I have done multiple builds with the latest head from yesterday >> both with and without >> > > > the extra stacks and hpts.. and I can=E2=80=99t get a build failur= e.. this >> would verify he can >> > > > at least build head.. >> > > > >> > > > R >> > > > >> > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> > > >> >> > > >>> On 18. Sep 2019, at 08:19, vm finance >> wrote: >> > > >>> >> > > >>> correcting a typo: >> > > >>> >> > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >> > > >>> current revision: 352434 >> > > >> I suggest to build/install head first without any patches. After >> that has worked, >> > > >> apply the patches you are interested in. That way it is easy to >> separate generic >> > > >> build issues and issue specific to a patch. >> > > >> >> > > >> Best regards >> > > >> Michael >> > > >>> >> > > >>> Thank you! >> > > >>> >> > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > >>> >> > > >>>> Actually I am on head already as mentioned previously. Pulled i= t >> using >> > > >>>> yesterday: >> > > >>>> >> > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >> > > >>>> >> > > >>>> >> > > >>>> If you could pls let me know the new patch, I can try that. >> > > >>>> >> > > >>>> Thanks >> > > >>>> >> > > >>>> Sent from my iPhone >> > > >>>> >> > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >> wrote: >> > > >>>> >> > > >>>> There have been several patches pre-this one that provide >> > > >>>> the infrastructure to support BBR. >> > > >>>> >> > > >>>> Release 12.0 will *not* have these patches and will *not* >> compile it. >> > > >>>> >> > > >>>> I have no intention at this point in doing a MFC of this work.. >> so if you >> > > >>>> want >> > > >>>> to run BBR you need to run Head >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> Hi Randall, >> > > >>>> >> > > >>>> >> > > >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> > > >>>> one you published Sep-10. >> > > >>>> >> > > >>>> >> > > >>>> Following is what I have done: >> > > >>>> >> > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> > > >>>> >> > > >>>> 2. Got VM up under VMPlayer on x86 laptop >> > > >>>> >> > > >>>> 3. Checked out latest codebase from freebsd repo: >> > > >>>> >> > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> > > >>>> >> > > >>>> cd /usr/src; >> > > >>>> >> > > >>>> make buildworld buildkernel >> > > >>>> >> > > >>>> [this is where make fails when patch is applied] >> > > >>>> >> > > >>>> >> > > >>>> I could try to build with your latest patch - please send me a >> pointer. >> > > >>>> >> > > >>>> >> > > >>>> Thanks for your help! >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart >> wrote: >> > > >>>> >> > > >>>> Looking at your make file log I can=E2=80=99t really tell what = you are >> doing. >> > > >>>> >> > > >>>> >> > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> > > >>>> >> > > >>>> >> > > >>>> Are you cross compiling? >> > > >>>> >> > > >>>> >> > > >>>> I have done the old fashioned kernel make >> > > >>>> >> > > >>>> >> > > >>>> i.e. >> > > >>>> >> > > >>>> >> > > >>>> cd src/sys/amd64/config >> > > >>>> >> > > >>>> config headvm >> > > >>>> >> > > >>>> cd ../compile/headvm >> > > >>>> >> > > >>>> >> > > >>>> make cleandepend ; make depend; make -j3 >> > > >>>> >> > > >>>> >> > > >>>> I have done >> > > >>>> >> > > >>>> >> > > >>>> cd src >> > > >>>> >> > > >>>> make buildkernel KERNCONF=3Dheadvm >> > > >>>> >> > > >>>> >> > > >>>> And even >> > > >>>> >> > > >>>> >> > > >>>> make buildkernel KERNCONF=3DGENERIC >> > > >>>> >> > > >>>> >> > > >>>> to make sure that the build works without bbr. >> > > >>>> >> > > >>>> >> > > >>>> I attach my headvm config.. >> > > >>>> >> > > >>>> >> > > >>>> What exactly are you building and how? kernel config too please= ? >> > > >>>> >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> looking >> > > >>>> >> > > >>>> >> > > >>>> I was at 352408.. let me update and try it >> > > >>>> >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> >> > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> Hmm >> > > >>>> >> > > >>>> >> > > >>>> Did you get the patch I updated too this am? >> > > >>>> >> > > >>>> >> > > >>>> I have built it both with and without the bbr stack and had no >> issue.. >> > > >>>> there was >> > > >>>> >> > > >>>> an issue with KTLS before the update though. >> > > >>>> >> > > >>>> >> > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 >> > > >>>> >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> >> > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> Got it - thank you! >> > > >>>> >> > > >>>> >> > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > >>>> info + make error mesg. >> > > >>>> >> > > >>>> >> > > >>>> Please let me know what am I missing here? >> > > >>>> >> > > >>>> >> > > >>>> Thanks! >> > > >>>> >> > > >>>> >> > > >>>> #svnlite revision >> > > >>>> >> > > >>>> Path: . >> > > >>>> >> > > >>>> Working Copy Root Path: /usr/src >> > > >>>> >> > > >>>> URL: svn://svn.freebsd.org/base/head >> > > >>>> >> > > >>>> Relative URL: ^/head >> > > >>>> >> > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > >>>> >> > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > >>>> >> > > >>>> Revision: 352436 >> > > >>>> >> > > >>>> Node Kind: directory >> > > >>>> >> > > >>>> Schedule: normal >> > > >>>> >> > > >>>> Last Changed Author: jah >> > > >>>> >> > > >>>> Last Changed Rev: 352434 >> > > >>>> >> > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> > > >>>> >> > > >>>> >> > > >>>> root@osboxes:/usr/src # >> > > >>>> >> > > >>>> >> > > >>>> -------------------------------------------- snip >> > > >>>> ---------------------------- >> > > >>>> >> > > >>>> >> > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > >>>> >> > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > >>>> >> > > >>>> =3D=3D=3D> sys (cleandir) >> > > >>>> >> > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > >>>> opt_kern_tls.h >> > > >>>> >> > > >>>> rm: x86: is a directory >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[3]: stopped in /usr/src/sys >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[2]: stopped in /usr/src >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[1]: stopped in /usr/src >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make: stopped in /usr/src >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > >>>> >> > > >>>> Got it - thank you! >> > > >>>> >> > > >>>> >> > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > >>>> info + make error mesg. >> > > >>>> >> > > >>>> I have also attached the entire build log...snippet is below >> > > >>>> >> > > >>>> >> > > >>>> Please let me know what am I missing here? >> > > >>>> >> > > >>>> >> > > >>>> Thanks! >> > > >>>> >> > > >>>> >> > > >>>> #svnlite revision >> > > >>>> >> > > >>>> Path: . >> > > >>>> >> > > >>>> Working Copy Root Path: /usr/src >> > > >>>> >> > > >>>> URL: svn://svn.freebsd.org/base/head >> > > >>>> >> > > >>>> Relative URL: ^/head >> > > >>>> >> > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > >>>> >> > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > >>>> >> > > >>>> Revision: 352436 >> > > >>>> >> > > >>>> Node Kind: directory >> > > >>>> >> > > >>>> Schedule: normal >> > > >>>> >> > > >>>> Last Changed Author: jah >> > > >>>> >> > > >>>> Last Changed Rev: 352434 >> > > >>>> >> > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019) >> > > >>>> >> > > >>>> >> > > >>>> root@osboxes:/usr/src # >> > > >>>> >> > > >>>> >> > > >>>> -------------------------------------------- snip >> > > >>>> ---------------------------- >> > > >>>> >> > > >>>> >> > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > >>>> >> > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > >>>> >> > > >>>> =3D=3D=3D> sys (cleandir) >> > > >>>> >> > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > >>>> opt_kern_tls.h >> > > >>>> >> > > >>>> rm: x86: is a directory >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[3]: stopped in /usr/src/sys >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[2]: stopped in /usr/src >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make[1]: stopped in /usr/src >> > > >>>> >> > > >>>> *** Error code 1 >> > > >>>> >> > > >>>> >> > > >>>> Stop. >> > > >>>> >> > > >>>> make: stopped in /usr/src >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart >> wrote: >> > > >>>> >> > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do >> not have >> > > >>>> >> > > >>>> to have fq.. they built an alternate means of doing pacing into >> bbr. >> > > >>>> >> > > >>>> >> > > >>>> In either case our testing has shown that our pacing is more >> accurate than >> > > >>>> >> > > >>>> either fq or the internal pacer :) >> > > >>>> >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> >> > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> Thanks Randall. >> > > >>>> >> > > >>>> I was able to apply the patch - now rebuilding the kernel. Woul= d >> update on >> > > >>>> how it goes. >> > > >>>> >> > > >>>> >> > > >>>> BTW, is there any description on how lack of tc_fq under FreeBS= D >> is >> > > >>>> compensated here? >> > > >>>> >> > > >>>> The original BBR patches on Linux show that as a must-have? Is >> that >> > > >>>> functionality implemented via tcp_ratelimit.[ch]? >> > > >>>> >> > > >>>> >> > > >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> > > >>>> >> > > >>>> >> > > >>>> Thanks a lot. >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart >> wrote: >> > > >>>> >> > > >>>> You should be able to compile it against the current head. I >> re-doing that >> > > >>>> now (had an >> > > >>>> >> > > >>>> issue with my machine and had to roll it back to a backup). >> > > >>>> >> > > >>>> >> > > >>>> When I put the patch up on Sept 10th it complied with and >> without BBR on >> > > >>>> whatever >> > > >>>> >> > > >>>> was that rev.. >> > > >>>> >> > > >>>> >> > > >>>> Looking in the commit logs that would have been around 352191 >> > > >>>> >> > > >>>> >> > > >>>> Hope that helps >> > > >>>> >> > > >>>> >> > > >>>> R >> > > >>>> >> > > >>>> >> > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > >>>> >> > > >>>> >> > > >>>> Hi Randall, >> > > >>>> >> > > >>>> >> > > >>>> Thanks for releasing BBR patch: >> > > >>>> >> > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > >>>> >> > > >>>> >> > > >>>> Could you please let me know what SVN/GIT label tag this is >> based on? I >> > > >>>> would like to patch and experiment with it. I couldn't find thi= s >> info in >> > > >>>> the released patch. >> > > >>>> >> > > >>>> >> > > >>>> Thanks a lot! >> > > >>>> >> > > >>>> >> > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > >>>> >> > > >>>> rrs@ has just posted the BBR patch to phabricator: >> > > >>>> >> > > >>>> >> > > >>>> https://reviews.freebsd.org/D21582 >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> >> > > >>>> Randall Stewart >> > > >>>> >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> >> > > >>>> Randall Stewart >> > > >>>> >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> >> > > >>>> Randall Stewart >> > > >>>> >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> >> > > >>>> Randall Stewart >> > > >>>> >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> >> > > >>>> Randall Stewart >> > > >>>> >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> ------ >> > > >>>> Randall Stewart >> > > >>>> rrs@netflix.com >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>>> >> > > >>> _______________________________________________ >> > > >>> freebsd-net@freebsd.org mailing list >> > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > > >>> To unsubscribe, send any mail to " >> freebsd-net-unsubscribe@freebsd.org" >> > > > >> > > > ------ >> > > > Randall Stewart >> > > > rrs@netflix.com >> > > > >> > > > >> > > > >> > > >> > > ------ >> > > Randall Stewart >> > > rrs@netflix.com >> > > >> > > >> > > >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Thu Sep 19 18:05:22 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50C6612A59C for ; Thu, 19 Sep 2019 18:05:22 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z4Wh3zqvz45Ls for ; Thu, 19 Sep 2019 18:05:20 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pl1-x644.google.com with SMTP id u12so1953233pls.12 for ; Thu, 19 Sep 2019 11:05:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ScIe1Hb+jLMn0wHd61qs70d1I/dFY5l0qa1S1lQReRM=; b=n5b30yQsFbgT6BSnW63QQHK8exqkoBIrawP/PTLRVmoLuWJLmrhkZApstIvD8mJFxl djQMsBBVeFOgW7HMjV3GMV2Xy0iuzI8rPNBDxKFaX3nJe0qvYiA2TZ5F/tfLiFvCIBHK P28hUj8jvMWV/oLdcRHe4HMYtnPeDOIQkQrDbK5a3DTSr4PWuuqG2VWxhk6Vs2zwIv5b Lpkj29nypYr+YzPGPlWMEwm0J4jup2rzd5Dmf+i8U+4DhJbqLm6lvJBgYr+2VlWb0k6e 4aDSyvXZdjK3qwXWR/jSNcIktgUVSPyapYbMOhIRiTM6JJXNfiqwyZWCanT0xJbJSZmW K0bA== X-Gm-Message-State: APjAAAVsViPbEFx+IFkE6nFTBb7d2vKOdJ3HpAssqU12BSfosqcEJsSJ JPbVaKo3KcOJZQQv8qWIxasdFQ== X-Google-Smtp-Source: APXvYqx08MSq0JTkhZos/quM1ORZ8HsdpSBbrj6MBRaLCm+cCW43iaCYYqHqJyEHOMZ+yKhScKOXag== X-Received: by 2002:a17:902:70c6:: with SMTP id l6mr1047175plt.77.1568916318722; Thu, 19 Sep 2019 11:05:18 -0700 (PDT) Received: from [192.168.3.229] ([12.169.213.226]) by smtp.gmail.com with ESMTPSA id d5sm16635076pfa.180.2019.09.19.11.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Sep 2019 11:05:17 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: BBR patches? From: Randall Stewart In-Reply-To: Date: Thu, 19 Sep 2019 11:05:21 -0700 Cc: =?utf-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.9.1) X-Rspamd-Queue-Id: 46Z4Wh3zqvz45Ls X-Spamd-Bar: ------------ X-Spamd-Result: default: False [-12.60 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[4.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.10)[ip: (-0.57), ipnet: 2607:f8b0::/32(-2.67), asn: 15169(-2.22), country: US(-0.05)]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 18:05:22 -0000 Ahh.. Look in your directory. You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the = right places When you load the patch (which was updated Sept 17th and should be = different slightly) you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the = local dir since for what every reason patch cannot figure out how to place it. You must move=20 bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks You must create sys/modules/tcp/bbr and=20 place the make file under there (just like rack=E2=80=99s). Do that and I think you will finally have it.. not sure why patch is not = able to put the new files in the right places :0 R > On Sep 19, 2019, at 10:42 AM, vm finance = wrote: >=20 > Hello Randall, >=20 > I just retried it with headvm config that you had shared but still see = error while doing > "make cleandepend" >=20 > Any pointers highly appreciated. >=20 > Thanks >=20 > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend=20 > [...snip...] >=20 > =3D=3D=3D> sysvipc/sysvshm (obj) > = /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sysv= shm created for /usr/src/sys/modules/sysvipc/sysvshm > =3D=3D=3D> tcp (obj) > =3D=3D=3D> tcp/bbr (obj) > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory > *** Error code 2 >=20 > Stop. > make[2]: stopped in /usr/src/sys/modules/tcp > *** Error code 1 >=20 > Stop. > make[1]: stopped in /usr/src/sys/modules > *** Error code 1 >=20 > Stop. > make: stopped in /usr/src/sys/amd64/compile/headvm > root@osboxes:/usr/src/sys/amd64/compile/headvm #=20 >=20 >=20 > On Wed, Sep 18, 2019 at 11:08 PM vm finance = wrote: > Hi Randall, >=20 > I applied the patch available at:=20 > https://reviews.freebsd.org/D21582?id=3D62213 > NOTE: This raw patch seems to be exactly the same as the one I = downloaded on Sep10...hope I'm not missing anything here... >=20 > I clicked on "download raw diff" and saved it to bbr_patch.diff file = on my local machine > Step 1: Apply PATCH: > cd /usr/src/sys > patch < bbr_patch.diff > Patch was applied successfully - no errors seen there. >=20 > Step 2: Update kernel config: > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL=20 > Added three options to MYKERNEL (per ur email - I have also attached = the compile MYKERNEL file) > cd /usr/src/sys/amd64/compile/MYKERNEL > make cleandepend > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ > [pls find the attached log file for exact error] >=20 > make depend > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >=20 > STEP 3: > cd /usr/src/ > make buildkernel KERNCONF=3DMYKERNEL > This also fails due to prior errors in Step 2. >=20 > Please find MYKERNEL config file + error logs. >=20 > Many many thanks for taking time to help me through this! >=20 > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that = successfully finished. >=20 >=20 >=20 > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart = wrote: > You can look in the config I sent.. but here is what > I have added to enable BBR and Rack to be built > ***** > makeoptions WITH_EXTRA_TCP_STACKS=3D1 > options TCPHPTS=20 > options RATELIMIT > ****** >=20 > So you should > 1) Apply the current patch in phabricator > 2) edit your config and add the above three lines > 3) go to the src dir and type > make buildkernel KERNCONF=3Dmyconf >=20 > That should build and get you a kernel that will include bbr and rack. = You will > need to, after it boots up type >=20 > kldload tcp_bbr >=20 > or >=20 > kldload tcp_rack >=20 > To get the modules loaded >=20 > R >=20 >=20 >=20 > > On Sep 18, 2019, at 2:31 PM, vm finance = wrote: > >=20 > > Hi Randall, Michael, > >=20 > > Build is done successfully. I would appreciate if you could share = config changes needed for BBR. > >=20 > > My svn revision is: 352483 > >=20 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | = xargs -J% objcopy % zlib.ko.full > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug = zlib.ko.full zlib.ko > > -------------------------------------------------------------- > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC = 2019 > > -------------------------------------------------------------- > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > >=20 > > Thank you > > Vishal. > >=20 > >=20 > > On Wed, Sep 18, 2019 at 3:34 PM vm finance = wrote: > > I'm using amd64. I'd get back as soon as base build is complete. > >=20 > > Thanks! > >=20 > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart = wrote: > > To get bbr running you will need to change your kernel config. > >=20 > > Are you building i386 or amd64? > >=20 > > After you have successfully did=20 > >=20 > > 1) buildworld > > 2) buildkernel > > 3) installkernel > >=20 > > (you can look in UPDATING for instructions .. though the file is = long :D) > >=20 > > successfully let me know.. and then I will give you the tweaks you = need to add > > to the kerneconf. > >=20 > > It won=E2=80=99t take as long to build because at that point you can = add in the > > NO_CLEAN NO_CLEANDIR options as well since you will have built = everything > > the first time > >=20 > > R > >=20 > > > On Sep 18, 2019, at 7:06 AM, vm finance = wrote: > > >=20 > > > BTW, if you think I should be making any changes in configs, = please do let me know. > > > My goal is to build a freebsd image with BBR patches on x86 VM.=20 > > > Nothing fancy. > > >=20 > > > thanks! > > >=20 > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance = wrote: > > > Thanks Randall, Michael, > > >=20 > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > > and now doing "make buildworld buildkernel"=20 > > > [I didn't change anything in configs - just whatever are the = defaults] > > >=20 > > > I would update as soon as its done. > > >=20 > > > Thanks again! > > >=20 > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart = wrote: > > > One other note.. I notice his kernel conf he sent does not have > > > the right things to get BBR even to attempt to build. > > >=20 > > > I would suggest using that config for the first steps.. then he = must add > > > the additional tcp stacks and the hpts in order to get bbr/rack = and any other > > > extra stack=E2=80=A6.=20 > > >=20 > > > But I would suggest to build with his current config first and = once he has > > > that in place and building > > >=20 > > > a) apply the patch > > > b) add the extra kernel options > > >=20 > > > R > > >=20 > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart = wrote: > > > >=20 > > > > Thats great idea Michael. > > > >=20 > > > > =46rom the look fo the build log I was sent, his blow-up has = nothing to do > > > > with the patches. > > > >=20 > > > > He should probably > > > >=20 > > > > 1) Check out a fresh version of head. > > > > 2) Follow the instructions in UPDATING to get a clean build. > > > > =E2=80=94 make buildworld > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > >=20 > > > > ** do the reboot and merge master ** > > > >=20 > > > > Then after that he could > > > >=20 > > > > 3) Apply the current patch in the review > > > > 4) do build that > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN = -DNO_CLEANDIR > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > >=20 > > > > And he should have it all working :) > > > >=20 > > > > I have done multiple builds with the latest head from yesterday = both with and without > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build = failure.. this would verify he can > > > > at least build head.. > > > >=20 > > > > R > > > >=20 > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: > > > >>=20 > > > >>> On 18. Sep 2019, at 08:19, vm finance = wrote: > > > >>>=20 > > > >>> correcting a typo: > > > >>>=20 > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > > >>> current revision: 352434 > > > >> I suggest to build/install head first without any patches. = After that has worked, > > > >> apply the patches you are interested in. That way it is easy to = separate generic > > > >> build issues and issue specific to a patch. > > > >>=20 > > > >> Best regards > > > >> Michael > > > >>>=20 > > > >>> Thank you! > > > >>>=20 > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: > > > >>>=20 > > > >>>> Actually I am on head already as mentioned previously. Pulled = it using > > > >>>> yesterday: > > > >>>>=20 > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > > >>>>=20 > > > >>>>=20 > > > >>>> If you could pls let me know the new patch, I can try that. > > > >>>>=20 > > > >>>> Thanks > > > >>>>=20 > > > >>>> Sent from my iPhone > > > >>>>=20 > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart = wrote: > > > >>>>=20 > > > >>>> There have been several patches pre-this one that provide > > > >>>> the infrastructure to support BBR. > > > >>>>=20 > > > >>>> Release 12.0 will *not* have these patches and will *not* = compile it. > > > >>>>=20 > > > >>>> I have no intention at this point in doing a MFC of this = work.. so if you > > > >>>> want > > > >>>> to run BBR you need to run Head > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> Hi Randall, > > > >>>>=20 > > > >>>>=20 > > > >>>> Could you please provide a pointer to the latest patch. I had = applied the > > > >>>> one you published Sep-10. > > > >>>>=20 > > > >>>>=20 > > > >>>> Following is what I have done: > > > >>>>=20 > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > > >>>>=20 > > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > > >>>>=20 > > > >>>> 3. Checked out latest codebase from freebsd repo: > > > >>>>=20 > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > > >>>>=20 > > > >>>> cd /usr/src; > > > >>>>=20 > > > >>>> make buildworld buildkernel > > > >>>>=20 > > > >>>> [this is where make fails when patch is applied] > > > >>>>=20 > > > >>>>=20 > > > >>>> I could try to build with your latest patch - please send me = a pointer. > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks for your help! > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: > > > >>>>=20 > > > >>>> Looking at your make file log I can=E2=80=99t really tell = what you are doing. > > > >>>>=20 > > > >>>>=20 > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > >>>>=20 > > > >>>>=20 > > > >>>> Are you cross compiling? > > > >>>>=20 > > > >>>>=20 > > > >>>> I have done the old fashioned kernel make > > > >>>>=20 > > > >>>>=20 > > > >>>> i.e. > > > >>>>=20 > > > >>>>=20 > > > >>>> cd src/sys/amd64/config > > > >>>>=20 > > > >>>> config headvm > > > >>>>=20 > > > >>>> cd ../compile/headvm > > > >>>>=20 > > > >>>>=20 > > > >>>> make cleandepend ; make depend; make -j3 > > > >>>>=20 > > > >>>>=20 > > > >>>> I have done > > > >>>>=20 > > > >>>>=20 > > > >>>> cd src > > > >>>>=20 > > > >>>> make buildkernel KERNCONF=3Dheadvm > > > >>>>=20 > > > >>>>=20 > > > >>>> And even > > > >>>>=20 > > > >>>>=20 > > > >>>> make buildkernel KERNCONF=3DGENERIC > > > >>>>=20 > > > >>>>=20 > > > >>>> to make sure that the build works without bbr. > > > >>>>=20 > > > >>>>=20 > > > >>>> I attach my headvm config.. > > > >>>>=20 > > > >>>>=20 > > > >>>> What exactly are you building and how? kernel config too = please? > > > >>>>=20 > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> looking > > > >>>>=20 > > > >>>>=20 > > > >>>> I was at 352408.. let me update and try it > > > >>>>=20 > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> Hmm > > > >>>>=20 > > > >>>>=20 > > > >>>> Did you get the patch I updated too this am? > > > >>>>=20 > > > >>>>=20 > > > >>>> I have built it both with and without the bbr stack and had = no issue.. > > > >>>> there was > > > >>>>=20 > > > >>>> an issue with KTLS before the update though. > > > >>>>=20 > > > >>>>=20 > > > >>>> I don=E2=80=99t recognize what you have below there though=E2=80= =A6 > > > >>>>=20 > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> Got it - thank you! > > > >>>>=20 > > > >>>>=20 > > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > > >>>> info + make error mesg. > > > >>>>=20 > > > >>>>=20 > > > >>>> Please let me know what am I missing here? > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks! > > > >>>>=20 > > > >>>>=20 > > > >>>> #svnlite revision > > > >>>>=20 > > > >>>> Path: . > > > >>>>=20 > > > >>>> Working Copy Root Path: /usr/src > > > >>>>=20 > > > >>>> URL: svn://svn.freebsd.org/base/head > > > >>>>=20 > > > >>>> Relative URL: ^/head > > > >>>>=20 > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > >>>>=20 > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > >>>>=20 > > > >>>> Revision: 352436 > > > >>>>=20 > > > >>>> Node Kind: directory > > > >>>>=20 > > > >>>> Schedule: normal > > > >>>>=20 > > > >>>> Last Changed Author: jah > > > >>>>=20 > > > >>>> Last Changed Rev: 352434 > > > >>>>=20 > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep = 2019) > > > >>>>=20 > > > >>>>=20 > > > >>>> root@osboxes:/usr/src # > > > >>>>=20 > > > >>>>=20 > > > >>>> -------------------------------------------- snip > > > >>>> ---------------------------- > > > >>>>=20 > > > >>>>=20 > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > >>>>=20 > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > >>>>=20 > > > >>>> =3D=3D=3D> sys (cleandir) > > > >>>>=20 > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > > >>>> opt_kern_tls.h > > > >>>>=20 > > > >>>> rm: x86: is a directory > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[3]: stopped in /usr/src/sys > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[2]: stopped in /usr/src > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[1]: stopped in /usr/src > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make: stopped in /usr/src > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > > > >>>>=20 > > > >>>> Got it - thank you! > > > >>>>=20 > > > >>>>=20 > > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > > >>>> info + make error mesg. > > > >>>>=20 > > > >>>> I have also attached the entire build log...snippet is below > > > >>>>=20 > > > >>>>=20 > > > >>>> Please let me know what am I missing here? > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks! > > > >>>>=20 > > > >>>>=20 > > > >>>> #svnlite revision > > > >>>>=20 > > > >>>> Path: . > > > >>>>=20 > > > >>>> Working Copy Root Path: /usr/src > > > >>>>=20 > > > >>>> URL: svn://svn.freebsd.org/base/head > > > >>>>=20 > > > >>>> Relative URL: ^/head > > > >>>>=20 > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > >>>>=20 > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > >>>>=20 > > > >>>> Revision: 352436 > > > >>>>=20 > > > >>>> Node Kind: directory > > > >>>>=20 > > > >>>> Schedule: normal > > > >>>>=20 > > > >>>> Last Changed Author: jah > > > >>>>=20 > > > >>>> Last Changed Rev: 352434 > > > >>>>=20 > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep = 2019) > > > >>>>=20 > > > >>>>=20 > > > >>>> root@osboxes:/usr/src # > > > >>>>=20 > > > >>>>=20 > > > >>>> -------------------------------------------- snip > > > >>>> ---------------------------- > > > >>>>=20 > > > >>>>=20 > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo = dev_net.llo > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > >>>>=20 > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > >>>>=20 > > > >>>> =3D=3D=3D> sys (cleandir) > > > >>>>=20 > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > > >>>> opt_kern_tls.h > > > >>>>=20 > > > >>>> rm: x86: is a directory > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[3]: stopped in /usr/src/sys > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[2]: stopped in /usr/src > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make[1]: stopped in /usr/src > > > >>>>=20 > > > >>>> *** Error code 1 > > > >>>>=20 > > > >>>>=20 > > > >>>> Stop. > > > >>>>=20 > > > >>>> make: stopped in /usr/src > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > > > >>>>=20 > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches = do not have > > > >>>>=20 > > > >>>> to have fq.. they built an alternate means of doing pacing = into bbr. > > > >>>>=20 > > > >>>>=20 > > > >>>> In either case our testing has shown that our pacing is more = accurate than > > > >>>>=20 > > > >>>> either fq or the internal pacer :) > > > >>>>=20 > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks Randall. > > > >>>>=20 > > > >>>> I was able to apply the patch - now rebuilding the kernel. = Would update on > > > >>>> how it goes. > > > >>>>=20 > > > >>>>=20 > > > >>>> BTW, is there any description on how lack of tc_fq under = FreeBSD is > > > >>>> compensated here? > > > >>>>=20 > > > >>>> The original BBR patches on Linux show that as a must-have? = Is that > > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > > >>>>=20 > > > >>>>=20 > > > >>>> Any pointers to existing presentations/discussions highly = appreciated? > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks a lot. > > > >>>>=20 > > > >>>>=20 > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > > > >>>>=20 > > > >>>> You should be able to compile it against the current head. I = re-doing that > > > >>>> now (had an > > > >>>>=20 > > > >>>> issue with my machine and had to roll it back to a backup). > > > >>>>=20 > > > >>>>=20 > > > >>>> When I put the patch up on Sept 10th it complied with and = without BBR on > > > >>>> whatever > > > >>>>=20 > > > >>>> was that rev.. > > > >>>>=20 > > > >>>>=20 > > > >>>> Looking in the commit logs that would have been around 352191 > > > >>>>=20 > > > >>>>=20 > > > >>>> Hope that helps > > > >>>>=20 > > > >>>>=20 > > > >>>> R > > > >>>>=20 > > > >>>>=20 > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > > > >>>>=20 > > > >>>>=20 > > > >>>> Hi Randall, > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks for releasing BBR patch: > > > >>>>=20 > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > >>>>=20 > > > >>>>=20 > > > >>>> Could you please let me know what SVN/GIT label tag this is = based on? I > > > >>>> would like to patch and experiment with it. I couldn't find = this info in > > > >>>> the released patch. > > > >>>>=20 > > > >>>>=20 > > > >>>> Thanks a lot! > > > >>>>=20 > > > >>>>=20 > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > > >>>>=20 > > > >>>> rrs@ has just posted the BBR patch to phabricator: > > > >>>>=20 > > > >>>>=20 > > > >>>> https://reviews.freebsd.org/D21582 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>>=20 > > > >>>> Randall Stewart > > > >>>>=20 > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>>=20 > > > >>>> Randall Stewart > > > >>>>=20 > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>>=20 > > > >>>> Randall Stewart > > > >>>>=20 > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>>=20 > > > >>>> Randall Stewart > > > >>>>=20 > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>>=20 > > > >>>> Randall Stewart > > > >>>>=20 > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>> ------ > > > >>>> Randall Stewart > > > >>>> rrs@netflix.com > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>>>=20 > > > >>> _______________________________________________ > > > >>> freebsd-net@freebsd.org mailing list > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > > >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" > > > >=20 > > > > ------ > > > > Randall Stewart > > > > rrs@netflix.com > > > >=20 > > > >=20 > > > >=20 > > >=20 > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > >=20 > > >=20 > > >=20 > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 ------ Randall Stewart rrs@netflix.com From owner-freebsd-net@freebsd.org Thu Sep 19 18:10:18 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17FEF12A6EB for ; Thu, 19 Sep 2019 18:10:18 +0000 (UTC) (envelope-from crapsh@monkeybrains.net) Received: from mail.monkeybrains.net (mail.monkeybrains.net [208.69.40.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.monkeybrains.net", Issuer "AlphaSSL CA - SHA256 - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z4dM4XJQz45Ss for ; Thu, 19 Sep 2019 18:10:15 +0000 (UTC) (envelope-from crapsh@monkeybrains.net) Received: from [10.2.86.115] (public.monkeybrains.net [208.69.41.107] (may be forged)) (authenticated bits=0) by mail.monkeybrains.net (8.15.2/8.15.2) with ESMTPSA id x8JIADge089803 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Thu, 19 Sep 2019 11:10:13 -0700 (PDT) (envelope-from crapsh@monkeybrains.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=monkeybrains.net; s=dkim; t=1568916613; bh=Qrq42lsLVvgrLbEShNF31drXR71ZDE42sRXRVtPqe78=; h=Subject:To:References:From:Date:In-Reply-To; b=sDmt5fp8l86szSswF+bBLk13Odwkz4WUWGdI4Hm8ugqkxEpY9d8RJram3CQTu28H9 WKBXZPMPEiHvypxGXWymZ7o+/qhP7Q+IxDLwEmPUD+Pr/aL2y4YJHYJ6BRT6d8BUTi zLmoeojtflcGjoni7BGLl6Zcg2Oar3rgUg1YW+Rc= X-Authentication-Warning: mail.monkeybrains.net: Host public.monkeybrains.net [208.69.41.107] (may be forged) claimed to be [10.2.86.115] Subject: Re: 10 Gbps NIC - advice needed To: freebsd-net@freebsd.org References: <380fff29-8df3-2671-69c3-ef47131aaf58@monkeybrains.net> <325FE312-A230-4BFB-B582-F61477CD1E46@heron.pl> From: BulkMailForRudy Message-ID: Date: Thu, 19 Sep 2019 11:10:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Virus-Scanned: clamav-milter 0.100.2 at mail.monkeybrains.net X-Virus-Status: Clean X-Rspamd-Queue-Id: 46Z4dM4XJQz45Ss X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=monkeybrains.net header.s=dkim header.b=sDmt5fp8; dmarc=pass (policy=none) header.from=monkeybrains.net; spf=pass (mx1.freebsd.org: domain of crapsh@monkeybrains.net designates 208.69.40.19 as permitted sender) smtp.mailfrom=crapsh@monkeybrains.net X-Spamd-Result: default: False [-5.86 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[monkeybrains.net:s=dkim]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ptr]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; DWL_DNSWL_LOW(-1.00)[monkeybrains.net.dwl.dnswl.org : 127.0.5.1]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[monkeybrains.net:+]; DMARC_POLICY_ALLOW(-0.50)[monkeybrains.net,none]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.76)[ipnet: 208.69.40.0/22(-4.85), asn: 32329(-3.91), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[19.40.69.208.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:32329, ipnet:208.69.40.0/22, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 18:10:18 -0000 Hot Lava makes some interesting cards using the Intel chipset:   https://www.hotlavasystems.com/products_40gbe.html You can get a 2x 40Gbps card, configure port1 as 40Gbps, and the second port as 4x 10Gbps ports with a breakout cable.  According to a quick call to their support number, the 4 ports on the break out will show up as separate devices (eg ix0, ix1, ix2, ix3).  My use case doesn't need a QSFP -> 4x 10Gbps breakout, but it would be need to try out. As other people noted, you would need kit with PCE 3.0 slots. Rudy On 9/9/19 1:41 AM, Dustin Marquess wrote: > I second the recommendation for Chelsio. I had brand new retail Intel > 40GE NICs (4 x 10GE) and I got so frustrated with the bugs that I sold > them used on eBay just to recoup some of the cost. > > -Dustin > > On Thu, Aug 29, 2019 at 6:41 AM Robert Heron wrote: >> Hi, >> >> I need to use a 10 Gbps, 2 port NIC (copper RJ-45) with FreeBSD 11.3R amd64. Which NIC (manufacturer and model) would you recommend as the most trouble-free and reliable? >> Maybe some Intel? >> >> Robert >> >> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@freebsd.org Thu Sep 19 20:50:35 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E06512E1A9 for ; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Z8BM3mx2z4GV6 for ; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 8190612E1A8; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8158E12E1A7 for ; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Z8BM2xjlz4GV5 for ; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4A07C1B00E for ; Thu, 19 Sep 2019 20:50:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8JKoZ7I031485 for ; Thu, 19 Sep 2019 20:50:35 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8JKoZPK031484 for net@FreeBSD.org; Thu, 19 Sep 2019 20:50:35 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Thu, 19 Sep 2019 20:50:33 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Sep 2019 20:50:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #13 from Armin Gruner --- I think that's the best resolution, perhaps the committer can bring any lig= ht into darkness? -> yongari --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 02:32:11 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CE39FEE1DC for ; Fri, 20 Sep 2019 02:32:11 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZHmV61mZz4Z5g for ; Fri, 20 Sep 2019 02:32:10 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd33.google.com with SMTP id r26so12648634ioh.8 for ; Thu, 19 Sep 2019 19:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P20qpq+yrOQ9QvKqROuIC35pzRx3tuphn8bVJhkIPm0=; b=SDWtkmYY57QEFHprIsbvWLwrzGehGLHpGVdIVbv/Dgyvkz+rVgeg6IdGYNLLU58UKz CQQMMXFQKxR7uVVEHwj0XsP8/8BGFbqRmKi4/qILvza/0aHJiPc4xmUNRM+wV1oxuVzU /IBCft3Kix8w/mLTrkS2Xrno5hRs2z5cSF4sGO0b4XwIG1buzofOHmu2iNnE/KYkfjhC MWIdXL7k+ywGVK29edGH/s8P700tL1oVZ57qL+F50u6f0ieMYY5zqCpmTMmhBwf8X5Cl uYe9wPLMnyy7ivQoKTFGqiLV3/Hcp83hpyoyhn2v1/wFSI4ZNtpnj8ph38Wk6GNXO53v II6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P20qpq+yrOQ9QvKqROuIC35pzRx3tuphn8bVJhkIPm0=; b=j9EHxOZQT/g38EdHtLY06iDn1LIBJctxnbveTaJzNUym/OSntjvQW9YSzT2zRhoal2 qiX4hjLNaFgaqpVQLk6jowFSck8kTByns/oEEr4IH88lehMZCB0Jj9W/TO1QIC34n5F5 ILYdfK/+rHoRXl6BPR0ahdXNjmtxxQgob8+vx9rPDi6NkYEiT984FQL1mV2oBRaOOpFH HY7h8sm3XYt4r9tXqDMB5O4y1HtnQORvFnIAAnDQr5VTR0yfrFV8WhM/zXT9tmwL5MMc K2c86fMGtU3kb5doD2/MUJ41imcL07p52fr7/5IQ7OKHT4Za82thnfsNWuMu1NQpOVUz BYfg== X-Gm-Message-State: APjAAAVNGpp6rLFUFfGXqpXnwbBHFp+1VNeDDeoNUg2NOc4M509Mf2Lm Xzvp8S2gRKSiTvY1TXbYJ7Z6sZOw/JuRcNyTn6g= X-Google-Smtp-Source: APXvYqzwcjw5EERpSoUXWuwD2EMj1HUJLkGni4APo61Fp0pyiroT7fjQA7cpZMGE7jAan0Q+I5xfeEMv+Ckg53wL8FY= X-Received: by 2002:a5e:c241:: with SMTP id w1mr15331719iop.36.1568946729589; Thu, 19 Sep 2019 19:32:09 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 19:31:57 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZHmV61mZz4Z5g X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=SDWtkmYY; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d33 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-1.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; URI_COUNT_ODD(1.00)[25]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.24), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 02:32:11 -0000 Hi Randall, I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ However, there is no "bbr" under sys/modules/tcp/. I created this directory manually. Question: Which Makefile do I need to copy/move under sys/modules/tcp/bbr? I see there are Makefile and Makefile.org under ~modules/tcp... root@osboxes:/usr/src/sys/modules/tcp # ls -R Makefile Makefile.orig bbr rack tcpmd5 ./bbr: ./rack: Makefile ./tcpmd5: Makefile Please let me know. Thanks for your help! On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote: > Ahh.. Look in your directory. > > You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the r= ight > places > > When you load the patch (which was updated Sept 17th and should be > different slightly) > you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the loca= l > dir since > for what every reason patch cannot figure out how to place it. > > You must move > > bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks > > You must create > > sys/modules/tcp/bbr > > and > > place the make file under there (just like rack=E2=80=99s). > > Do that and I think you will finally have it.. not sure why patch is not > able to > put the new files in the right places :0 > > R > > > On Sep 19, 2019, at 10:42 AM, vm finance wrote: > > > > Hello Randall, > > > > I just retried it with headvm config that you had shared but still see > error while doing > > "make cleandepend" > > > > Any pointers highly appreciated. > > > > Thanks > > > > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend > > [...snip...] > > > > =3D=3D=3D> sysvipc/sysvshm (obj) > > > /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sys= vshm > created for /usr/src/sys/modules/sysvipc/sysvshm > > =3D=3D=3D> tcp (obj) > > =3D=3D=3D> tcp/bbr (obj) > > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory > > *** Error code 2 > > > > Stop. > > make[2]: stopped in /usr/src/sys/modules/tcp > > *** Error code 1 > > > > Stop. > > make[1]: stopped in /usr/src/sys/modules > > *** Error code 1 > > > > Stop. > > make: stopped in /usr/src/sys/amd64/compile/headvm > > root@osboxes:/usr/src/sys/amd64/compile/headvm # > > > > > > On Wed, Sep 18, 2019 at 11:08 PM vm finance > wrote: > > Hi Randall, > > > > I applied the patch available at: > > https://reviews.freebsd.org/D21582?id=3D62213 > > NOTE: This raw patch seems to be exactly the same as the one I > downloaded on Sep10...hope I'm not missing anything here... > > > > I clicked on "download raw diff" and saved it to bbr_patch.diff file on > my local machine > > Step 1: Apply PATCH: > > cd /usr/src/sys > > patch < bbr_patch.diff > > Patch was applied successfully - no errors seen there. > > > > Step 2: Update kernel config: > > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL > > Added three options to MYKERNEL (per ur email - I have also attached th= e > compile MYKERNEL file) > > cd /usr/src/sys/amd64/compile/MYKERNEL > > make cleandepend > > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ > > [pls find the attached log file for exact error] > > > > make depend > > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" > > > > STEP 3: > > cd /usr/src/ > > make buildkernel KERNCONF=3DMYKERNEL > > This also fails due to prior errors in Step 2. > > > > Please find MYKERNEL config file + error logs. > > > > Many many thanks for taking time to help me through this! > > > > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that > successfully finished. > > > > > > > > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart > wrote: > > You can look in the config I sent.. but here is what > > I have added to enable BBR and Rack to be built > > ***** > > makeoptions WITH_EXTRA_TCP_STACKS=3D1 > > options TCPHPTS > > options RATELIMIT > > ****** > > > > So you should > > 1) Apply the current patch in phabricator > > 2) edit your config and add the above three lines > > 3) go to the src dir and type > > make buildkernel KERNCONF=3Dmyconf > > > > That should build and get you a kernel that will include bbr and rack. > You will > > need to, after it boots up type > > > > kldload tcp_bbr > > > > or > > > > kldload tcp_rack > > > > To get the modules loaded > > > > R > > > > > > > > > On Sep 18, 2019, at 2:31 PM, vm finance wrote= : > > > > > > Hi Randall, Michael, > > > > > > Build is done successfully. I would appreciate if you could share > config changes needed for BBR. > > > > > > My svn revision is: 352483 > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | > xargs -J% objcopy % zlib.ko.full > > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.fu= ll > zlib.ko > > > -------------------------------------------------------------- > > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 201= 9 > > > -------------------------------------------------------------- > > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > > Thank you > > > Vishal. > > > > > > > > > On Wed, Sep 18, 2019 at 3:34 PM vm finance > wrote: > > > I'm using amd64. I'd get back as soon as base build is complete. > > > > > > Thanks! > > > > > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart > wrote: > > > To get bbr running you will need to change your kernel config. > > > > > > Are you building i386 or amd64? > > > > > > After you have successfully did > > > > > > 1) buildworld > > > 2) buildkernel > > > 3) installkernel > > > > > > (you can look in UPDATING for instructions .. though the file is long > :D) > > > > > > successfully let me know.. and then I will give you the tweaks you > need to add > > > to the kerneconf. > > > > > > It won=E2=80=99t take as long to build because at that point you can = add in the > > > NO_CLEAN NO_CLEANDIR options as well since you will have built > everything > > > the first time > > > > > > R > > > > > > > On Sep 18, 2019, at 7:06 AM, vm finance > wrote: > > > > > > > > BTW, if you think I should be making any changes in configs, please > do let me know. > > > > My goal is to build a freebsd image with BBR patches on x86 VM. > > > > Nothing fancy. > > > > > > > > thanks! > > > > > > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance > wrote: > > > > Thanks Randall, Michael, > > > > > > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > > > and now doing "make buildworld buildkernel" > > > > [I didn't change anything in configs - just whatever are the > defaults] > > > > > > > > I would update as soon as its done. > > > > > > > > Thanks again! > > > > > > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart > wrote: > > > > One other note.. I notice his kernel conf he sent does not have > > > > the right things to get BBR even to attempt to build. > > > > > > > > I would suggest using that config for the first steps.. then he mus= t > add > > > > the additional tcp stacks and the hpts in order to get bbr/rack and > any other > > > > extra stack=E2=80=A6. > > > > > > > > But I would suggest to build with his current config first and once > he has > > > > that in place and building > > > > > > > > a) apply the patch > > > > b) add the extra kernel options > > > > > > > > R > > > > > > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart > wrote: > > > > > > > > > > Thats great idea Michael. > > > > > > > > > > From the look fo the build log I was sent, his blow-up has nothin= g > to do > > > > > with the patches. > > > > > > > > > > He should probably > > > > > > > > > > 1) Check out a fresh version of head. > > > > > 2) Follow the instructions in UPDATING to get a clean build. > > > > > =E2=80=94 make buildworld > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > > > > > > > ** do the reboot and merge master ** > > > > > > > > > > Then after that he could > > > > > > > > > > 3) Apply the current patch in the review > > > > > 4) do build that > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -= DNO_CLEANDIR > > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > > > > > > > And he should have it all working :) > > > > > > > > > > I have done multiple builds with the latest head from yesterday > both with and without > > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build failu= re.. this > would verify he can > > > > > at least build head.. > > > > > > > > > > R > > > > > > > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > > > > >> > > > > >>> On 18. Sep 2019, at 08:19, vm finance > wrote: > > > > >>> > > > > >>> correcting a typo: > > > > >>> > > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > > > >>> current revision: 352434 > > > > >> I suggest to build/install head first without any patches. After > that has worked, > > > > >> apply the patches you are interested in. That way it is easy to > separate generic > > > > >> build issues and issue specific to a patch. > > > > >> > > > > >> Best regards > > > > >> Michael > > > > >>> > > > > >>> Thank you! > > > > >>> > > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < > vm.finance2@gmail.com> wrote: > > > > >>> > > > > >>>> Actually I am on head already as mentioned previously. Pulled > it using > > > > >>>> yesterday: > > > > >>>> > > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > > > >>>> > > > > >>>> > > > > >>>> If you could pls let me know the new patch, I can try that. > > > > >>>> > > > > >>>> Thanks > > > > >>>> > > > > >>>> Sent from my iPhone > > > > >>>> > > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> There have been several patches pre-this one that provide > > > > >>>> the infrastructure to support BBR. > > > > >>>> > > > > >>>> Release 12.0 will *not* have these patches and will *not* > compile it. > > > > >>>> > > > > >>>> I have no intention at this point in doing a MFC of this work.= . > so if you > > > > >>>> want > > > > >>>> to run BBR you need to run Head > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hi Randall, > > > > >>>> > > > > >>>> > > > > >>>> Could you please provide a pointer to the latest patch. I had > applied the > > > > >>>> one you published Sep-10. > > > > >>>> > > > > >>>> > > > > >>>> Following is what I have done: > > > > >>>> > > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > > > >>>> > > > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > > > >>>> > > > > >>>> 3. Checked out latest codebase from freebsd repo: > > > > >>>> > > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > > > >>>> > > > > >>>> cd /usr/src; > > > > >>>> > > > > >>>> make buildworld buildkernel > > > > >>>> > > > > >>>> [this is where make fails when patch is applied] > > > > >>>> > > > > >>>> > > > > >>>> I could try to build with your latest patch - please send me a > pointer. > > > > >>>> > > > > >>>> > > > > >>>> Thanks for your help! > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> Looking at your make file log I can=E2=80=99t really tell what= you are > doing. > > > > >>>> > > > > >>>> > > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > > >>>> > > > > >>>> > > > > >>>> Are you cross compiling? > > > > >>>> > > > > >>>> > > > > >>>> I have done the old fashioned kernel make > > > > >>>> > > > > >>>> > > > > >>>> i.e. > > > > >>>> > > > > >>>> > > > > >>>> cd src/sys/amd64/config > > > > >>>> > > > > >>>> config headvm > > > > >>>> > > > > >>>> cd ../compile/headvm > > > > >>>> > > > > >>>> > > > > >>>> make cleandepend ; make depend; make -j3 > > > > >>>> > > > > >>>> > > > > >>>> I have done > > > > >>>> > > > > >>>> > > > > >>>> cd src > > > > >>>> > > > > >>>> make buildkernel KERNCONF=3Dheadvm > > > > >>>> > > > > >>>> > > > > >>>> And even > > > > >>>> > > > > >>>> > > > > >>>> make buildkernel KERNCONF=3DGENERIC > > > > >>>> > > > > >>>> > > > > >>>> to make sure that the build works without bbr. > > > > >>>> > > > > >>>> > > > > >>>> I attach my headvm config.. > > > > >>>> > > > > >>>> > > > > >>>> What exactly are you building and how? kernel config too pleas= e? > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> > > > > >>>> looking > > > > >>>> > > > > >>>> > > > > >>>> I was at 352408.. let me update and try it > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hmm > > > > >>>> > > > > >>>> > > > > >>>> Did you get the patch I updated too this am? > > > > >>>> > > > > >>>> > > > > >>>> I have built it both with and without the bbr stack and had no > issue.. > > > > >>>> there was > > > > >>>> > > > > >>>> an issue with KTLS before the update though. > > > > >>>> > > > > >>>> > > > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Got it - thank you! > > > > >>>> > > > > >>>> > > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > > >>>> info + make error mesg. > > > > >>>> > > > > >>>> > > > > >>>> Please let me know what am I missing here? > > > > >>>> > > > > >>>> > > > > >>>> Thanks! > > > > >>>> > > > > >>>> > > > > >>>> #svnlite revision > > > > >>>> > > > > >>>> Path: . > > > > >>>> > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>> > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>> > > > > >>>> Relative URL: ^/head > > > > >>>> > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>> > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>> > > > > >>>> Revision: 352436 > > > > >>>> > > > > >>>> Node Kind: directory > > > > >>>> > > > > >>>> Schedule: normal > > > > >>>> > > > > >>>> Last Changed Author: jah > > > > >>>> > > > > >>>> Last Changed Rev: 352434 > > > > >>>> > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019= ) > > > > >>>> > > > > >>>> > > > > >>>> root@osboxes:/usr/src # > > > > >>>> > > > > >>>> > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>> > > > > >>>> > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>> > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>> > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>> > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>> > > > > >>>> rm: x86: is a directory > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[2]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[1]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make: stopped in /usr/src > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < > vm.finance2@gmail.com> wrote: > > > > >>>> > > > > >>>> Got it - thank you! > > > > >>>> > > > > >>>> > > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > > >>>> info + make error mesg. > > > > >>>> > > > > >>>> I have also attached the entire build log...snippet is below > > > > >>>> > > > > >>>> > > > > >>>> Please let me know what am I missing here? > > > > >>>> > > > > >>>> > > > > >>>> Thanks! > > > > >>>> > > > > >>>> > > > > >>>> #svnlite revision > > > > >>>> > > > > >>>> Path: . > > > > >>>> > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>> > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>> > > > > >>>> Relative URL: ^/head > > > > >>>> > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>> > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>> > > > > >>>> Revision: 352436 > > > > >>>> > > > > >>>> Node Kind: directory > > > > >>>> > > > > >>>> Schedule: normal > > > > >>>> > > > > >>>> Last Changed Author: jah > > > > >>>> > > > > >>>> Last Changed Rev: 352434 > > > > >>>> > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019= ) > > > > >>>> > > > > >>>> > > > > >>>> root@osboxes:/usr/src # > > > > >>>> > > > > >>>> > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>> > > > > >>>> > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>> > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>> > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>> > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>> > > > > >>>> rm: x86: is a directory > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[2]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[1]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make: stopped in /usr/src > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do > not have > > > > >>>> > > > > >>>> to have fq.. they built an alternate means of doing pacing int= o > bbr. > > > > >>>> > > > > >>>> > > > > >>>> In either case our testing has shown that our pacing is more > accurate than > > > > >>>> > > > > >>>> either fq or the internal pacer :) > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Thanks Randall. > > > > >>>> > > > > >>>> I was able to apply the patch - now rebuilding the kernel. > Would update on > > > > >>>> how it goes. > > > > >>>> > > > > >>>> > > > > >>>> BTW, is there any description on how lack of tc_fq under > FreeBSD is > > > > >>>> compensated here? > > > > >>>> > > > > >>>> The original BBR patches on Linux show that as a must-have? Is > that > > > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > > > >>>> > > > > >>>> > > > > >>>> Any pointers to existing presentations/discussions highly > appreciated? > > > > >>>> > > > > >>>> > > > > >>>> Thanks a lot. > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> You should be able to compile it against the current head. I > re-doing that > > > > >>>> now (had an > > > > >>>> > > > > >>>> issue with my machine and had to roll it back to a backup). > > > > >>>> > > > > >>>> > > > > >>>> When I put the patch up on Sept 10th it complied with and > without BBR on > > > > >>>> whatever > > > > >>>> > > > > >>>> was that rev.. > > > > >>>> > > > > >>>> > > > > >>>> Looking in the commit logs that would have been around 352191 > > > > >>>> > > > > >>>> > > > > >>>> Hope that helps > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hi Randall, > > > > >>>> > > > > >>>> > > > > >>>> Thanks for releasing BBR patch: > > > > >>>> > > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > > >>>> > > > > >>>> > > > > >>>> Could you please let me know what SVN/GIT label tag this is > based on? I > > > > >>>> would like to patch and experiment with it. I couldn't find > this info in > > > > >>>> the released patch. > > > > >>>> > > > > >>>> > > > > >>>> Thanks a lot! > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > > > > >>>> > > > > >>>> rrs@ has just posted the BBR patch to phabricator: > > > > >>>> > > > > >>>> > > > > >>>> https://reviews.freebsd.org/D21582 > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> Randall Stewart > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>> _______________________________________________ > > > > >>> freebsd-net@freebsd.org mailing list > > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > > > >>> To unsubscribe, send any mail to " > freebsd-net-unsubscribe@freebsd.org" > > > > > > > > > > ------ > > > > > Randall Stewart > > > > > rrs@netflix.com > > > > > > > > > > > > > > > > > > > > > > > ------ > > > > Randall Stewart > > > > rrs@netflix.com > > > > > > > > > > > > > > > > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > > > > > > > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Fri Sep 20 02:39:44 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 596A0EE495 for ; Fri, 20 Sep 2019 02:39:44 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZHxC6D3hz4ZHf for ; Fri, 20 Sep 2019 02:39:43 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd33.google.com with SMTP id n197so12685398iod.9 for ; Thu, 19 Sep 2019 19:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/9N4OHUtgPDo3ZZy5IjMA6CeoQ3SQNypdlAGcbq+niA=; b=fzhna2FcbeyOrNUxbqH3cyyIsJXWmP5ZMMd99UVO2bY4+T98hql9ykToJrvOtn+5Gx h0CsuJePSg2R2YMOtdbSuB1xXHJ/nWBxz7def0kEAKxdWcAzEYA2bi7xzqmqP7h9GRpQ 6c35IadGjCMRL6eYMqplqJMWux44UNIxgK3G3Cg//+pnVICNaoriuYP/e2QgHkpo3M3n +nSdesBEfyN6XVJC24Z9BBUNsuoWeaXQ7fXAuVawuh/riCPKiDSZH3D5qacta8jopEKR nVzDb9jw+QxehYav/mDjttnWyiknQSHoMCJMIK6Ab+3ee2PqdLKdHAydL2A1OTEWCx0r Mfnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/9N4OHUtgPDo3ZZy5IjMA6CeoQ3SQNypdlAGcbq+niA=; b=ulgHHywwD+Ctc1W9Wx24MW4gX0Qp8kL5p4uBSy9eUMC29bXb7xAEIhP9MAd8FKlf4m aCXFGFeiA4xTjV5pgxWZf4AMx42iZh8TT5ZhfW11ohXtP1qdzEGYewSuPUg6znrUesTx NL7Nm8UYDqPQ67bXp9JQUnsLSta76a4M9FTWvdclB5vkiSsrv3c83BkmeUXw9vGYfJTM csYea6g7ZksgWkx7kIBx/HTiAaKUbJa6vJvr0yobbLAWMJ99lLRQv+0n2eydS9jaUEX/ keFogJRj7quEii6k7WYXv3SMJyZCHXlx1MNqrQDBpIimbgPvSSfng+w9isL6Bb9qHgTO Km3g== X-Gm-Message-State: APjAAAXoNZnPz+XNFypY9uv39Oy0wdv9uXeQoT6dSGzrWcwanWz7z69U NQCZkgh2YPdn/FJfAjvlHHDhKzxx7DVjI1Z9X6c= X-Google-Smtp-Source: APXvYqwuXdDRgC88AT9tdMIyXHB8e5dta0Ox+Ajh0DSoP9Cwr1O8x3+qorLXnSgzZmV8FfxJJoiKE4DTY6zxu5606Ic= X-Received: by 2002:a02:6616:: with SMTP id k22mr15873322jac.129.1568947182929; Thu, 19 Sep 2019 19:39:42 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 19:39:31 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZHxC6D3hz4ZHf X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=fzhna2Fc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d33 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-4.21), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SUBJECT_ENDS_QUESTION(1.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 02:39:44 -0000 Since you mentioned Sep17 vs Sep10 patches should be slightly different, I would appreciate if you could please check the one available at: https://reviews.freebsd.org/D21582?id=3D62213 Is that the correct one to download/use? Thank you! On Thu, Sep 19, 2019 at 7:31 PM vm finance wrote: > Hi Randall, > > I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ > > However, there is no "bbr" under sys/modules/tcp/. I created this > directory manually. > Question: > Which Makefile do I need to copy/move under sys/modules/tcp/bbr? > I see there are Makefile and Makefile.org under ~modules/tcp... > > root@osboxes:/usr/src/sys/modules/tcp # ls -R > Makefile Makefile.orig bbr rack tcpmd5 > ./bbr: > > ./rack: > Makefile > > ./tcpmd5: > Makefile > > Please let me know. > > Thanks for your help! > > On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote: > >> Ahh.. Look in your directory. >> >> You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the = right >> places >> >> When you load the patch (which was updated Sept 17th and should be >> different slightly) >> you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the >> local dir since >> for what every reason patch cannot figure out how to place it. >> >> You must move >> >> bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >> >> You must create >> >> sys/modules/tcp/bbr >> >> and >> >> place the make file under there (just like rack=E2=80=99s). >> >> Do that and I think you will finally have it.. not sure why patch is not >> able to >> put the new files in the right places :0 >> >> R >> >> > On Sep 19, 2019, at 10:42 AM, vm finance wrote= : >> > >> > Hello Randall, >> > >> > I just retried it with headvm config that you had shared but still see >> error while doing >> > "make cleandepend" >> > >> > Any pointers highly appreciated. >> > >> > Thanks >> > >> > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend >> > [...snip...] >> > >> > =3D=3D=3D> sysvipc/sysvshm (obj) >> > >> /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sy= svshm >> created for /usr/src/sys/modules/sysvipc/sysvshm >> > =3D=3D=3D> tcp (obj) >> > =3D=3D=3D> tcp/bbr (obj) >> > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory >> > *** Error code 2 >> > >> > Stop. >> > make[2]: stopped in /usr/src/sys/modules/tcp >> > *** Error code 1 >> > >> > Stop. >> > make[1]: stopped in /usr/src/sys/modules >> > *** Error code 1 >> > >> > Stop. >> > make: stopped in /usr/src/sys/amd64/compile/headvm >> > root@osboxes:/usr/src/sys/amd64/compile/headvm # >> > >> > >> > On Wed, Sep 18, 2019 at 11:08 PM vm finance >> wrote: >> > Hi Randall, >> > >> > I applied the patch available at: >> > https://reviews.freebsd.org/D21582?id=3D62213 >> > NOTE: This raw patch seems to be exactly the same as the one I >> downloaded on Sep10...hope I'm not missing anything here... >> > >> > I clicked on "download raw diff" and saved it to bbr_patch.diff file o= n >> my local machine >> > Step 1: Apply PATCH: >> > cd /usr/src/sys >> > patch < bbr_patch.diff >> > Patch was applied successfully - no errors seen there. >> > >> > Step 2: Update kernel config: >> > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL >> > Added three options to MYKERNEL (per ur email - I have also attached >> the compile MYKERNEL file) >> > cd /usr/src/sys/amd64/compile/MYKERNEL >> > make cleandepend >> > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ >> > [pls find the attached log file for exact error] >> > >> > make depend >> > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >> > >> > STEP 3: >> > cd /usr/src/ >> > make buildkernel KERNCONF=3DMYKERNEL >> > This also fails due to prior errors in Step 2. >> > >> > Please find MYKERNEL config file + error logs. >> > >> > Many many thanks for taking time to help me through this! >> > >> > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that >> successfully finished. >> > >> > >> > >> > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart >> wrote: >> > You can look in the config I sent.. but here is what >> > I have added to enable BBR and Rack to be built >> > ***** >> > makeoptions WITH_EXTRA_TCP_STACKS=3D1 >> > options TCPHPTS >> > options RATELIMIT >> > ****** >> > >> > So you should >> > 1) Apply the current patch in phabricator >> > 2) edit your config and add the above three lines >> > 3) go to the src dir and type >> > make buildkernel KERNCONF=3Dmyconf >> > >> > That should build and get you a kernel that will include bbr and rack. >> You will >> > need to, after it boots up type >> > >> > kldload tcp_bbr >> > >> > or >> > >> > kldload tcp_rack >> > >> > To get the modules loaded >> > >> > R >> > >> > >> > >> > > On Sep 18, 2019, at 2:31 PM, vm finance >> wrote: >> > > >> > > Hi Randall, Michael, >> > > >> > > Build is done successfully. I would appreciate if you could share >> config changes needed for BBR. >> > > >> > > My svn revision is: 352483 >> > > >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >> xargs -J% objcopy % zlib.ko.full >> > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >> > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.f= ull >> zlib.ko >> > > -------------------------------------------------------------- >> > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 20= 19 >> > > -------------------------------------------------------------- >> > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > >> > > Thank you >> > > Vishal. >> > > >> > > >> > > On Wed, Sep 18, 2019 at 3:34 PM vm finance >> wrote: >> > > I'm using amd64. I'd get back as soon as base build is complete. >> > > >> > > Thanks! >> > > >> > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >> wrote: >> > > To get bbr running you will need to change your kernel config. >> > > >> > > Are you building i386 or amd64? >> > > >> > > After you have successfully did >> > > >> > > 1) buildworld >> > > 2) buildkernel >> > > 3) installkernel >> > > >> > > (you can look in UPDATING for instructions .. though the file is lon= g >> :D) >> > > >> > > successfully let me know.. and then I will give you the tweaks you >> need to add >> > > to the kerneconf. >> > > >> > > It won=E2=80=99t take as long to build because at that point you can= add in >> the >> > > NO_CLEAN NO_CLEANDIR options as well since you will have built >> everything >> > > the first time >> > > >> > > R >> > > >> > > > On Sep 18, 2019, at 7:06 AM, vm finance >> wrote: >> > > > >> > > > BTW, if you think I should be making any changes in configs, pleas= e >> do let me know. >> > > > My goal is to build a freebsd image with BBR patches on x86 VM. >> > > > Nothing fancy. >> > > > >> > > > thanks! >> > > > >> > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >> wrote: >> > > > Thanks Randall, Michael, >> > > > >> > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >> > > > and now doing "make buildworld buildkernel" >> > > > [I didn't change anything in configs - just whatever are the >> defaults] >> > > > >> > > > I would update as soon as its done. >> > > > >> > > > Thanks again! >> > > > >> > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >> wrote: >> > > > One other note.. I notice his kernel conf he sent does not have >> > > > the right things to get BBR even to attempt to build. >> > > > >> > > > I would suggest using that config for the first steps.. then he >> must add >> > > > the additional tcp stacks and the hpts in order to get bbr/rack an= d >> any other >> > > > extra stack=E2=80=A6. >> > > > >> > > > But I would suggest to build with his current config first and onc= e >> he has >> > > > that in place and building >> > > > >> > > > a) apply the patch >> > > > b) add the extra kernel options >> > > > >> > > > R >> > > > >> > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >> wrote: >> > > > > >> > > > > Thats great idea Michael. >> > > > > >> > > > > From the look fo the build log I was sent, his blow-up has >> nothing to do >> > > > > with the patches. >> > > > > >> > > > > He should probably >> > > > > >> > > > > 1) Check out a fresh version of head. >> > > > > 2) Follow the instructions in UPDATING to get a clean build. >> > > > > =E2=80=94 make buildworld >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > > > > >> > > > > ** do the reboot and merge master ** >> > > > > >> > > > > Then after that he could >> > > > > >> > > > > 3) Apply the current patch in the review >> > > > > 4) do build that >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN >> -DNO_CLEANDIR >> > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > > > > >> > > > > And he should have it all working :) >> > > > > >> > > > > I have done multiple builds with the latest head from yesterday >> both with and without >> > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build fail= ure.. >> this would verify he can >> > > > > at least build head.. >> > > > > >> > > > > R >> > > > > >> > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> > > > >> >> > > > >>> On 18. Sep 2019, at 08:19, vm finance >> wrote: >> > > > >>> >> > > > >>> correcting a typo: >> > > > >>> >> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >> > > > >>> current revision: 352434 >> > > > >> I suggest to build/install head first without any patches. Afte= r >> that has worked, >> > > > >> apply the patches you are interested in. That way it is easy to >> separate generic >> > > > >> build issues and issue specific to a patch. >> > > > >> >> > > > >> Best regards >> > > > >> Michael >> > > > >>> >> > > > >>> Thank you! >> > > > >>> >> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>> >> > > > >>>> Actually I am on head already as mentioned previously. Pulled >> it using >> > > > >>>> yesterday: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >> > > > >>>> >> > > > >>>> >> > > > >>>> If you could pls let me know the new patch, I can try that. >> > > > >>>> >> > > > >>>> Thanks >> > > > >>>> >> > > > >>>> Sent from my iPhone >> > > > >>>> >> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> There have been several patches pre-this one that provide >> > > > >>>> the infrastructure to support BBR. >> > > > >>>> >> > > > >>>> Release 12.0 will *not* have these patches and will *not* >> compile it. >> > > > >>>> >> > > > >>>> I have no intention at this point in doing a MFC of this >> work.. so if you >> > > > >>>> want >> > > > >>>> to run BBR you need to run Head >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> > > > >>>> one you published Sep-10. >> > > > >>>> >> > > > >>>> >> > > > >>>> Following is what I have done: >> > > > >>>> >> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> > > > >>>> >> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop >> > > > >>>> >> > > > >>>> 3. Checked out latest codebase from freebsd repo: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> > > > >>>> >> > > > >>>> cd /usr/src; >> > > > >>>> >> > > > >>>> make buildworld buildkernel >> > > > >>>> >> > > > >>>> [this is where make fails when patch is applied] >> > > > >>>> >> > > > >>>> >> > > > >>>> I could try to build with your latest patch - please send me = a >> pointer. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for your help! >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Looking at your make file log I can=E2=80=99t really tell wha= t you are >> doing. >> > > > >>>> >> > > > >>>> >> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> Are you cross compiling? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done the old fashioned kernel make >> > > > >>>> >> > > > >>>> >> > > > >>>> i.e. >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src/sys/amd64/config >> > > > >>>> >> > > > >>>> config headvm >> > > > >>>> >> > > > >>>> cd ../compile/headvm >> > > > >>>> >> > > > >>>> >> > > > >>>> make cleandepend ; make depend; make -j3 >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3Dheadvm >> > > > >>>> >> > > > >>>> >> > > > >>>> And even >> > > > >>>> >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3DGENERIC >> > > > >>>> >> > > > >>>> >> > > > >>>> to make sure that the build works without bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> I attach my headvm config.. >> > > > >>>> >> > > > >>>> >> > > > >>>> What exactly are you building and how? kernel config too >> please? >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> looking >> > > > >>>> >> > > > >>>> >> > > > >>>> I was at 352408.. let me update and try it >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hmm >> > > > >>>> >> > > > >>>> >> > > > >>>> Did you get the patch I updated too this am? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have built it both with and without the bbr stack and had n= o >> issue.. >> > > > >>>> there was >> > > > >>>> >> > > > >>>> an issue with KTLS before the update though. >> > > > >>>> >> > > > >>>> >> > > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> I have also attached the entire build log...snippet is below >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches d= o >> not have >> > > > >>>> >> > > > >>>> to have fq.. they built an alternate means of doing pacing >> into bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> In either case our testing has shown that our pacing is more >> accurate than >> > > > >>>> >> > > > >>>> either fq or the internal pacer :) >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks Randall. >> > > > >>>> >> > > > >>>> I was able to apply the patch - now rebuilding the kernel. >> Would update on >> > > > >>>> how it goes. >> > > > >>>> >> > > > >>>> >> > > > >>>> BTW, is there any description on how lack of tc_fq under >> FreeBSD is >> > > > >>>> compensated here? >> > > > >>>> >> > > > >>>> The original BBR patches on Linux show that as a must-have? I= s >> that >> > > > >>>> functionality implemented via tcp_ratelimit.[ch]? >> > > > >>>> >> > > > >>>> >> > > > >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot. >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> You should be able to compile it against the current head. I >> re-doing that >> > > > >>>> now (had an >> > > > >>>> >> > > > >>>> issue with my machine and had to roll it back to a backup). >> > > > >>>> >> > > > >>>> >> > > > >>>> When I put the patch up on Sept 10th it complied with and >> without BBR on >> > > > >>>> whatever >> > > > >>>> >> > > > >>>> was that rev.. >> > > > >>>> >> > > > >>>> >> > > > >>>> Looking in the commit logs that would have been around 352191 >> > > > >>>> >> > > > >>>> >> > > > >>>> Hope that helps >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for releasing BBR patch: >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please let me know what SVN/GIT label tag this is >> based on? I >> > > > >>>> would like to patch and experiment with it. I couldn't find >> this info in >> > > > >>>> the released patch. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot! >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > > >>>> >> > > > >>>> rrs@ has just posted the BBR patch to phabricator: >> > > > >>>> >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582 >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> Randall Stewart >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>> _______________________________________________ >> > > > >>> freebsd-net@freebsd.org mailing list >> > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > > > >>> To unsubscribe, send any mail to " >> freebsd-net-unsubscribe@freebsd.org" >> > > > > >> > > > > ------ >> > > > > Randall Stewart >> > > > > rrs@netflix.com >> > > > > >> > > > > >> > > > > >> > > > >> > > > ------ >> > > > Randall Stewart >> > > > rrs@netflix.com >> > > > >> > > > >> > > > >> > > >> > > ------ >> > > Randall Stewart >> > > rrs@netflix.com >> > > >> > > >> > > >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Fri Sep 20 02:57:42 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9255EEEB47 for ; Fri, 20 Sep 2019 02:57:42 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZJKx1KRvz4Zvc for ; Fri, 20 Sep 2019 02:57:40 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd34.google.com with SMTP id n197so12757192iod.9 for ; Thu, 19 Sep 2019 19:57:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MRa+uD//NCJxeYeXP554DYFKno9dLQJxdi9hff64/C4=; b=ZSq68qN2c9GVNURoDTp5FQooPbZedBdXGm8YhZDRPg7qGMKvg1Wfuj+P8B4KnjcX3X d1cajHMHPom+ThH+xB9YVngDgNPdJL2RAWR1Ru5BCI+wBTeS3KIsXcMo7Hnc2Or+B27a 9UJ0YUSOsWnvZJH6KDqESCia/HQaP4HmBKfSTA4aHehNdl7+0lZZs/Rbc08UIV0ZrKVI c0UuvNQk7EIqhmwq2qyorKXqpBfHeG5BLH+W9rv/E8Dfio4chFjFgoQuQnPhEoKhbgeW Koo2Gwfwx1c7+w+X+DHkCQmw/n9cD37hpFRI5Z1ywHIaFIhGk4qCMpeoF5fBtQ57vJVc ttjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MRa+uD//NCJxeYeXP554DYFKno9dLQJxdi9hff64/C4=; b=lLRllxdHthTcDXZZpcdQ1F4DrocfcVE7fn9721VWXukc0o+ykqZYlEfO9zw5bDBeTd VzB5kfWL+0CU/A7ILG8noUxRJhQU3kVfjVKzcOduCDKqn1txf320ZysEDBMjaYspBqEQ kMNWVMBoKaIKH4CTcp9ocIXprjkeIamQc2v40UrMQVLiiwhfUz9eaol8pkqCecoHYtx5 FTa4Q6+y2U/LPqmQYBiiNf1pNVURfZ5lUC8cV/FfPet6/NBFMdl9bv5Y7S/yfwJQJ1lR XxwfQE9CKEvAnzLZvuRkoRO7ozsgO+IYYuE2huDpVav3UKQzPQsxgyCt+3eAfO/JNpLB KKQQ== X-Gm-Message-State: APjAAAWjr/jszLZyyGO1p3vGftBrTK7xuXw86UrSjqQ2KVRU5shazo+g XHANLzVl6wwR3tdP5xt9rA5TQ7j0Sw6Tg7ltauA= X-Google-Smtp-Source: APXvYqzHBq7dfTulZUW7hwyhl/TgLoQtXJhpVxRcbNs3LM2Dl7oF3AwSs9Bmb3wKyVRDcbXS9HQYY7DXG2njOZXW+Kw= X-Received: by 2002:a6b:7615:: with SMTP id g21mr4287359iom.67.1568948259754; Thu, 19 Sep 2019 19:57:39 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 19:57:27 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZJKx1KRvz4Zvc X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ZSq68qN2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d34 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.22), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 02:57:42 -0000 I manually extracted Makefile contents from the patch and added that as Makefile under ~modules/tcp/bbr... make cleandepend worked now trying make depend....would keep you posted. Thanks! On Thu, Sep 19, 2019 at 7:39 PM vm finance wrote: > Since you mentioned Sep17 vs Sep10 patches should be slightly different, = I > would appreciate if you could please check the one available at: > https://reviews.freebsd.org/D21582?id=3D62213 > > Is that the correct one to download/use? > > Thank you! > > > > On Thu, Sep 19, 2019 at 7:31 PM vm finance wrote: > >> Hi Randall, >> >> I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ >> >> However, there is no "bbr" under sys/modules/tcp/. I created this >> directory manually. >> Question: >> Which Makefile do I need to copy/move under sys/modules/tcp/bbr? >> I see there are Makefile and Makefile.org under ~modules/tcp... >> >> root@osboxes:/usr/src/sys/modules/tcp # ls -R >> Makefile Makefile.orig bbr rack tcpmd5 >> ./bbr: >> >> ./rack: >> Makefile >> >> ./tcpmd5: >> Makefile >> >> Please let me know. >> >> Thanks for your help! >> >> On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote= : >> >>> Ahh.. Look in your directory. >>> >>> You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the= right >>> places >>> >>> When you load the patch (which was updated Sept 17th and should be >>> different slightly) >>> you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the >>> local dir since >>> for what every reason patch cannot figure out how to place it. >>> >>> You must move >>> >>> bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >>> >>> You must create >>> >>> sys/modules/tcp/bbr >>> >>> and >>> >>> place the make file under there (just like rack=E2=80=99s). >>> >>> Do that and I think you will finally have it.. not sure why patch is no= t >>> able to >>> put the new files in the right places :0 >>> >>> R >>> >>> > On Sep 19, 2019, at 10:42 AM, vm finance >>> wrote: >>> > >>> > Hello Randall, >>> > >>> > I just retried it with headvm config that you had shared but still se= e >>> error while doing >>> > "make cleandepend" >>> > >>> > Any pointers highly appreciated. >>> > >>> > Thanks >>> > >>> > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend >>> > [...snip...] >>> > >>> > =3D=3D=3D> sysvipc/sysvshm (obj) >>> > >>> /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/s= ysvshm >>> created for /usr/src/sys/modules/sysvipc/sysvshm >>> > =3D=3D=3D> tcp (obj) >>> > =3D=3D=3D> tcp/bbr (obj) >>> > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory >>> > *** Error code 2 >>> > >>> > Stop. >>> > make[2]: stopped in /usr/src/sys/modules/tcp >>> > *** Error code 1 >>> > >>> > Stop. >>> > make[1]: stopped in /usr/src/sys/modules >>> > *** Error code 1 >>> > >>> > Stop. >>> > make: stopped in /usr/src/sys/amd64/compile/headvm >>> > root@osboxes:/usr/src/sys/amd64/compile/headvm # >>> > >>> > >>> > On Wed, Sep 18, 2019 at 11:08 PM vm finance >>> wrote: >>> > Hi Randall, >>> > >>> > I applied the patch available at: >>> > https://reviews.freebsd.org/D21582?id=3D62213 >>> > NOTE: This raw patch seems to be exactly the same as the one I >>> downloaded on Sep10...hope I'm not missing anything here... >>> > >>> > I clicked on "download raw diff" and saved it to bbr_patch.diff file >>> on my local machine >>> > Step 1: Apply PATCH: >>> > cd /usr/src/sys >>> > patch < bbr_patch.diff >>> > Patch was applied successfully - no errors seen there. >>> > >>> > Step 2: Update kernel config: >>> > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL >>> > Added three options to MYKERNEL (per ur email - I have also attached >>> the compile MYKERNEL file) >>> > cd /usr/src/sys/amd64/compile/MYKERNEL >>> > make cleandepend >>> > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ >>> > [pls find the attached log file for exact error] >>> > >>> > make depend >>> > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >>> > >>> > STEP 3: >>> > cd /usr/src/ >>> > make buildkernel KERNCONF=3DMYKERNEL >>> > This also fails due to prior errors in Step 2. >>> > >>> > Please find MYKERNEL config file + error logs. >>> > >>> > Many many thanks for taking time to help me through this! >>> > >>> > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and tha= t >>> successfully finished. >>> > >>> > >>> > >>> > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart >>> wrote: >>> > You can look in the config I sent.. but here is what >>> > I have added to enable BBR and Rack to be built >>> > ***** >>> > makeoptions WITH_EXTRA_TCP_STACKS=3D1 >>> > options TCPHPTS >>> > options RATELIMIT >>> > ****** >>> > >>> > So you should >>> > 1) Apply the current patch in phabricator >>> > 2) edit your config and add the above three lines >>> > 3) go to the src dir and type >>> > make buildkernel KERNCONF=3Dmyconf >>> > >>> > That should build and get you a kernel that will include bbr and rack= . >>> You will >>> > need to, after it boots up type >>> > >>> > kldload tcp_bbr >>> > >>> > or >>> > >>> > kldload tcp_rack >>> > >>> > To get the modules loaded >>> > >>> > R >>> > >>> > >>> > >>> > > On Sep 18, 2019, at 2:31 PM, vm finance >>> wrote: >>> > > >>> > > Hi Randall, Michael, >>> > > >>> > > Build is done successfully. I would appreciate if you could share >>> config changes needed for BBR. >>> > > >>> > > My svn revision is: 352483 >>> > > >>> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >>> > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >>> xargs -J% objcopy % zlib.ko.full >>> > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >>> > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug >>> zlib.ko.full zlib.ko >>> > > -------------------------------------------------------------- >>> > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC >>> 2019 >>> > > -------------------------------------------------------------- >>> > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >>> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >>> > > >>> > > Thank you >>> > > Vishal. >>> > > >>> > > >>> > > On Wed, Sep 18, 2019 at 3:34 PM vm finance >>> wrote: >>> > > I'm using amd64. I'd get back as soon as base build is complete. >>> > > >>> > > Thanks! >>> > > >>> > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >>> wrote: >>> > > To get bbr running you will need to change your kernel config. >>> > > >>> > > Are you building i386 or amd64? >>> > > >>> > > After you have successfully did >>> > > >>> > > 1) buildworld >>> > > 2) buildkernel >>> > > 3) installkernel >>> > > >>> > > (you can look in UPDATING for instructions .. though the file is >>> long :D) >>> > > >>> > > successfully let me know.. and then I will give you the tweaks you >>> need to add >>> > > to the kerneconf. >>> > > >>> > > It won=E2=80=99t take as long to build because at that point you ca= n add in >>> the >>> > > NO_CLEAN NO_CLEANDIR options as well since you will have built >>> everything >>> > > the first time >>> > > >>> > > R >>> > > >>> > > > On Sep 18, 2019, at 7:06 AM, vm finance >>> wrote: >>> > > > >>> > > > BTW, if you think I should be making any changes in configs, >>> please do let me know. >>> > > > My goal is to build a freebsd image with BBR patches on x86 VM. >>> > > > Nothing fancy. >>> > > > >>> > > > thanks! >>> > > > >>> > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >>> wrote: >>> > > > Thanks Randall, Michael, >>> > > > >>> > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >>> > > > and now doing "make buildworld buildkernel" >>> > > > [I didn't change anything in configs - just whatever are the >>> defaults] >>> > > > >>> > > > I would update as soon as its done. >>> > > > >>> > > > Thanks again! >>> > > > >>> > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >>> wrote: >>> > > > One other note.. I notice his kernel conf he sent does not have >>> > > > the right things to get BBR even to attempt to build. >>> > > > >>> > > > I would suggest using that config for the first steps.. then he >>> must add >>> > > > the additional tcp stacks and the hpts in order to get bbr/rack >>> and any other >>> > > > extra stack=E2=80=A6. >>> > > > >>> > > > But I would suggest to build with his current config first and >>> once he has >>> > > > that in place and building >>> > > > >>> > > > a) apply the patch >>> > > > b) add the extra kernel options >>> > > > >>> > > > R >>> > > > >>> > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >>> wrote: >>> > > > > >>> > > > > Thats great idea Michael. >>> > > > > >>> > > > > From the look fo the build log I was sent, his blow-up has >>> nothing to do >>> > > > > with the patches. >>> > > > > >>> > > > > He should probably >>> > > > > >>> > > > > 1) Check out a fresh version of head. >>> > > > > 2) Follow the instructions in UPDATING to get a clean build. >>> > > > > =E2=80=94 make buildworld >>> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >>> > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >>> > > > > >>> > > > > ** do the reboot and merge master ** >>> > > > > >>> > > > > Then after that he could >>> > > > > >>> > > > > 3) Apply the current patch in the review >>> > > > > 4) do build that >>> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN >>> -DNO_CLEANDIR >>> > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >>> > > > > >>> > > > > And he should have it all working :) >>> > > > > >>> > > > > I have done multiple builds with the latest head from yesterday >>> both with and without >>> > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build fai= lure.. >>> this would verify he can >>> > > > > at least build head.. >>> > > > > >>> > > > > R >>> > > > > >>> > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >>> michael.tuexen@lurchi.franken.de> wrote: >>> > > > >> >>> > > > >>> On 18. Sep 2019, at 08:19, vm finance >>> wrote: >>> > > > >>> >>> > > > >>> correcting a typo: >>> > > > >>> >>> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >>> > > > >>> current revision: 352434 >>> > > > >> I suggest to build/install head first without any patches. >>> After that has worked, >>> > > > >> apply the patches you are interested in. That way it is easy t= o >>> separate generic >>> > > > >> build issues and issue specific to a patch. >>> > > > >> >>> > > > >> Best regards >>> > > > >> Michael >>> > > > >>> >>> > > > >>> Thank you! >>> > > > >>> >>> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>> >>> > > > >>>> Actually I am on head already as mentioned previously. Pulle= d >>> it using >>> > > > >>>> yesterday: >>> > > > >>>> >>> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> If you could pls let me know the new patch, I can try that. >>> > > > >>>> >>> > > > >>>> Thanks >>> > > > >>>> >>> > > > >>>> Sent from my iPhone >>> > > > >>>> >>> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> There have been several patches pre-this one that provide >>> > > > >>>> the infrastructure to support BBR. >>> > > > >>>> >>> > > > >>>> Release 12.0 will *not* have these patches and will *not* >>> compile it. >>> > > > >>>> >>> > > > >>>> I have no intention at this point in doing a MFC of this >>> work.. so if you >>> > > > >>>> want >>> > > > >>>> to run BBR you need to run Head >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hi Randall, >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Could you please provide a pointer to the latest patch. I ha= d >>> applied the >>> > > > >>>> one you published Sep-10. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Following is what I have done: >>> > > > >>>> >>> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>> > > > >>>> >>> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop >>> > > > >>>> >>> > > > >>>> 3. Checked out latest codebase from freebsd repo: >>> > > > >>>> >>> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >>> > > > >>>> >>> > > > >>>> cd /usr/src; >>> > > > >>>> >>> > > > >>>> make buildworld buildkernel >>> > > > >>>> >>> > > > >>>> [this is where make fails when patch is applied] >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I could try to build with your latest patch - please send me >>> a pointer. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks for your help! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> Looking at your make file log I can=E2=80=99t really tell wh= at you >>> are doing. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Are you cross compiling? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have done the old fashioned kernel make >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> i.e. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> cd src/sys/amd64/config >>> > > > >>>> >>> > > > >>>> config headvm >>> > > > >>>> >>> > > > >>>> cd ../compile/headvm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> make cleandepend ; make depend; make -j3 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have done >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> cd src >>> > > > >>>> >>> > > > >>>> make buildkernel KERNCONF=3Dheadvm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> And even >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> make buildkernel KERNCONF=3DGENERIC >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> to make sure that the build works without bbr. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I attach my headvm config.. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> What exactly are you building and how? kernel config too >>> please? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> looking >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I was at 352408.. let me update and try it >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hmm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Did you get the patch I updated too this am? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have built it both with and without the bbr stack and had >>> no issue.. >>> > > > >>>> there was >>> > > > >>>> >>> > > > >>>> an issue with KTLS before the update though. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I don=E2=80=99t recognize what you have below there though= =E2=80=A6 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Got it - thank you! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> btw, I tried to build the patch but its giving an error. >>> Following is SVN >>> > > > >>>> info + make error mesg. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Please let me know what am I missing here? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> #svnlite revision >>> > > > >>>> >>> > > > >>>> Path: . >>> > > > >>>> >>> > > > >>>> Working Copy Root Path: /usr/src >>> > > > >>>> >>> > > > >>>> URL: svn://svn.freebsd.org/base/head >>> > > > >>>> >>> > > > >>>> Relative URL: ^/head >>> > > > >>>> >>> > > > >>>> Repository Root: svn://svn.freebsd.org/base >>> > > > >>>> >>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> > > > >>>> >>> > > > >>>> Revision: 352436 >>> > > > >>>> >>> > > > >>>> Node Kind: directory >>> > > > >>>> >>> > > > >>>> Schedule: normal >>> > > > >>>> >>> > > > >>>> Last Changed Author: jah >>> > > > >>>> >>> > > > >>>> Last Changed Rev: 352434 >>> > > > >>>> >>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep >>> 2019) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> root@osboxes:/usr/src # >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> -------------------------------------------- snip >>> > > > >>>> ---------------------------- >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >>> dev_net.llo >>> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>> > > > >>>> >>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> > > > >>>> >>> > > > >>>> =3D=3D=3D> sys (cleandir) >>> > > > >>>> >>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >>> sack_filter.o >>> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >>> opt_tcpdebug.h >>> > > > >>>> opt_kern_tls.h >>> > > > >>>> >>> > > > >>>> rm: x86: is a directory >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[3]: stopped in /usr/src/sys >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[2]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[1]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> Got it - thank you! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> btw, I tried to build the patch but its giving an error. >>> Following is SVN >>> > > > >>>> info + make error mesg. >>> > > > >>>> >>> > > > >>>> I have also attached the entire build log...snippet is below >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Please let me know what am I missing here? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> #svnlite revision >>> > > > >>>> >>> > > > >>>> Path: . >>> > > > >>>> >>> > > > >>>> Working Copy Root Path: /usr/src >>> > > > >>>> >>> > > > >>>> URL: svn://svn.freebsd.org/base/head >>> > > > >>>> >>> > > > >>>> Relative URL: ^/head >>> > > > >>>> >>> > > > >>>> Repository Root: svn://svn.freebsd.org/base >>> > > > >>>> >>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> > > > >>>> >>> > > > >>>> Revision: 352436 >>> > > > >>>> >>> > > > >>>> Node Kind: directory >>> > > > >>>> >>> > > > >>>> Schedule: normal >>> > > > >>>> >>> > > > >>>> Last Changed Author: jah >>> > > > >>>> >>> > > > >>>> Last Changed Rev: 352434 >>> > > > >>>> >>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep >>> 2019) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> root@osboxes:/usr/src # >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> -------------------------------------------- snip >>> > > > >>>> ---------------------------- >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >>> dev_net.llo >>> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>> > > > >>>> >>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> > > > >>>> >>> > > > >>>> =3D=3D=3D> sys (cleandir) >>> > > > >>>> >>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >>> sack_filter.o >>> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >>> opt_tcpdebug.h >>> > > > >>>> opt_kern_tls.h >>> > > > >>>> >>> > > > >>>> rm: x86: is a directory >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[3]: stopped in /usr/src/sys >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[2]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[1]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches >>> do not have >>> > > > >>>> >>> > > > >>>> to have fq.. they built an alternate means of doing pacing >>> into bbr. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> In either case our testing has shown that our pacing is more >>> accurate than >>> > > > >>>> >>> > > > >>>> either fq or the internal pacer :) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks Randall. >>> > > > >>>> >>> > > > >>>> I was able to apply the patch - now rebuilding the kernel. >>> Would update on >>> > > > >>>> how it goes. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> BTW, is there any description on how lack of tc_fq under >>> FreeBSD is >>> > > > >>>> compensated here? >>> > > > >>>> >>> > > > >>>> The original BBR patches on Linux show that as a must-have? >>> Is that >>> > > > >>>> functionality implemented via tcp_ratelimit.[ch]? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Any pointers to existing presentations/discussions highly >>> appreciated? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks a lot. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> You should be able to compile it against the current head. I >>> re-doing that >>> > > > >>>> now (had an >>> > > > >>>> >>> > > > >>>> issue with my machine and had to roll it back to a backup). >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> When I put the patch up on Sept 10th it complied with and >>> without BBR on >>> > > > >>>> whatever >>> > > > >>>> >>> > > > >>>> was that rev.. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Looking in the commit logs that would have been around 35219= 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hope that helps >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hi Randall, >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks for releasing BBR patch: >>> > > > >>>> >>> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Could you please let me know what SVN/GIT label tag this is >>> based on? I >>> > > > >>>> would like to patch and experiment with it. I couldn't find >>> this info in >>> > > > >>>> the released patch. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks a lot! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone < >>> rysto32@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> rrs@ has just posted the BBR patch to phabricator: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> https://reviews.freebsd.org/D21582 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> Randall Stewart >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>> _______________________________________________ >>> > > > >>> freebsd-net@freebsd.org mailing list >>> > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> > > > >>> To unsubscribe, send any mail to " >>> freebsd-net-unsubscribe@freebsd.org" >>> > > > > >>> > > > > ------ >>> > > > > Randall Stewart >>> > > > > rrs@netflix.com >>> > > > > >>> > > > > >>> > > > > >>> > > > >>> > > > ------ >>> > > > Randall Stewart >>> > > > rrs@netflix.com >>> > > > >>> > > > >>> > > > >>> > > >>> > > ------ >>> > > Randall Stewart >>> > > rrs@netflix.com >>> > > >>> > > >>> > > >>> > >>> > ------ >>> > Randall Stewart >>> > rrs@netflix.com >>> > >>> > >>> > >>> >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>> >>> >>> >>> From owner-freebsd-net@freebsd.org Fri Sep 20 03:12:32 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 96CD4EFD8C for ; Fri, 20 Sep 2019 03:12:32 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZJg325K5z4cTd for ; Fri, 20 Sep 2019 03:12:30 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-qt1-x82f.google.com with SMTP id d2so7026014qtr.4 for ; Thu, 19 Sep 2019 20:12:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:references:in-reply-to:date :message-id:subject:to:cc; bh=/9Zeqt/SddWLUYtBillPJSyx26fS27nbVf8bmJKnrWo=; b=NkqCqb9/Q7+Yvp11cwIFLxBGQ/HaIJ4YkRjrcrbLmNUSGj+CP6rIKepgitFZm+X0QP AoZan2Bf5n4udIUS7U8b8ZjM0Infi7y5ZW2tu2hCxenVQBFtW46Wm17RffTsoQp7+VqB HJHhAGqTR2Dg+Z4yGmWSK/Wo8fCjINc/RYFWnB+UunhLeU8GfkHReliJ6FMYgMFeUUeE Na+X8QZ68kPHeFx2b3yYRggoBsqzvM6JwpwKx2VhV7Mc1yPL3pVZA9rSPWYHpJSb2KcY VqVBWTyektL1z8t9oT7bGeJdP/rb3k9oR77o3cl3ivBeHtYLLC86k1ECBcuEiu+Br/1l fhBA== X-Gm-Message-State: APjAAAVvBKvkhqRR7opf9lgR4O8dpHKXvki7eDBnS09Eo3zF8/gHXAXA rJWcyQYV8o9HlFQJ1UN8JO1Tvh5L5VE+exzzM87MiA== X-Google-Smtp-Source: APXvYqzPfuPYu9ftVoP+aKfZavCC55uZq192vfCzNh8RAeh8PA1xmznQC8lua2kuzrK6L6I7QW/OspyKqKQnI8+8tG8= X-Received: by 2002:a0c:c541:: with SMTP id y1mr11229440qvi.116.1568949149377; Thu, 19 Sep 2019 20:12:29 -0700 (PDT) Received: from unknown named unknown by gmailapi.google.com with HTTPREST; Thu, 19 Sep 2019 20:12:28 -0700 From: Randall Stewart Mime-Version: 1.0 (1.0) References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: Date: Thu, 19 Sep 2019 20:12:28 -0700 Message-ID: Subject: Re: BBR patches? To: vm finance Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZJg325K5z4cTd X-Spamd-Bar: -------------- X-Spamd-Result: default: False [-14.36 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[netflix.com:+]; DMARC_POLICY_ALLOW(-0.50)[netflix.com,reject]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-2.86)[ip: (-9.36), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netflix.com:s=google]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_SOME(0.00)[]; WHITELIST_DMARC(-7.00)[netflix.com:D:+]; RCVD_IN_DNSWL_NONE(0.00)[f.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; WHITELIST_SPF_DKIM(-3.00)[netflix.com:d:+,netflix.com:s:+]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 03:12:32 -0000 There should have been some in the patch. Tomorrow I can send you a tar of the modules/tcp/bbr Dir. It=E2=80=99s similar to the rack setup if you can=E2=80=99t wait and want t= o be adventurous R Sent from my iPhone On Sep 19, 2019, at 7:31 PM, vm finance wrote: Hi Randall, I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ However, there is no "bbr" under sys/modules/tcp/. I created this directory manually. Question: Which Makefile do I need to copy/move under sys/modules/tcp/bbr? I see there are Makefile and Makefile.org under ~modules/tcp... root@osboxes:/usr/src/sys/modules/tcp # ls -R Makefile Makefile.orig bbr rack tcpmd5 ./bbr: ./rack: Makefile ./tcpmd5: Makefile Please let me know. Thanks for your help! On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote: > Ahh.. Look in your directory. > > You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the r= ight > places > > When you load the patch (which was updated Sept 17th and should be > different slightly) > you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the loca= l > dir since > for what every reason patch cannot figure out how to place it. > > You must move > > bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks > > You must create > > sys/modules/tcp/bbr > > and > > place the make file under there (just like rack=E2=80=99s). > > Do that and I think you will finally have it.. not sure why patch is not > able to > put the new files in the right places :0 > > R > > > On Sep 19, 2019, at 10:42 AM, vm finance wrote: > > > > Hello Randall, > > > > I just retried it with headvm config that you had shared but still see > error while doing > > "make cleandepend" > > > > Any pointers highly appreciated. > > > > Thanks > > > > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend > > [...snip...] > > > > =3D=3D=3D> sysvipc/sysvshm (obj) > > > /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sys= vshm > created for /usr/src/sys/modules/sysvipc/sysvshm > > =3D=3D=3D> tcp (obj) > > =3D=3D=3D> tcp/bbr (obj) > > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory > > *** Error code 2 > > > > Stop. > > make[2]: stopped in /usr/src/sys/modules/tcp > > *** Error code 1 > > > > Stop. > > make[1]: stopped in /usr/src/sys/modules > > *** Error code 1 > > > > Stop. > > make: stopped in /usr/src/sys/amd64/compile/headvm > > root@osboxes:/usr/src/sys/amd64/compile/headvm # > > > > > > On Wed, Sep 18, 2019 at 11:08 PM vm finance > wrote: > > Hi Randall, > > > > I applied the patch available at: > > https://reviews.freebsd.org/D21582?id=3D62213 > > NOTE: This raw patch seems to be exactly the same as the one I > downloaded on Sep10...hope I'm not missing anything here... > > > > I clicked on "download raw diff" and saved it to bbr_patch.diff file on > my local machine > > Step 1: Apply PATCH: > > cd /usr/src/sys > > patch < bbr_patch.diff > > Patch was applied successfully - no errors seen there. > > > > Step 2: Update kernel config: > > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL > > Added three options to MYKERNEL (per ur email - I have also attached th= e > compile MYKERNEL file) > > cd /usr/src/sys/amd64/compile/MYKERNEL > > make cleandepend > > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ > > [pls find the attached log file for exact error] > > > > make depend > > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" > > > > STEP 3: > > cd /usr/src/ > > make buildkernel KERNCONF=3DMYKERNEL > > This also fails due to prior errors in Step 2. > > > > Please find MYKERNEL config file + error logs. > > > > Many many thanks for taking time to help me through this! > > > > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that > successfully finished. > > > > > > > > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart > wrote: > > You can look in the config I sent.. but here is what > > I have added to enable BBR and Rack to be built > > ***** > > makeoptions WITH_EXTRA_TCP_STACKS=3D1 > > options TCPHPTS > > options RATELIMIT > > ****** > > > > So you should > > 1) Apply the current patch in phabricator > > 2) edit your config and add the above three lines > > 3) go to the src dir and type > > make buildkernel KERNCONF=3Dmyconf > > > > That should build and get you a kernel that will include bbr and rack. > You will > > need to, after it boots up type > > > > kldload tcp_bbr > > > > or > > > > kldload tcp_rack > > > > To get the modules loaded > > > > R > > > > > > > > > On Sep 18, 2019, at 2:31 PM, vm finance wrote= : > > > > > > Hi Randall, Michael, > > > > > > Build is done successfully. I would appreciate if you could share > config changes needed for BBR. > > > > > > My svn revision is: 352483 > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | > xargs -J% objcopy % zlib.ko.full > > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.fu= ll > zlib.ko > > > -------------------------------------------------------------- > > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 201= 9 > > > -------------------------------------------------------------- > > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > > Thank you > > > Vishal. > > > > > > > > > On Wed, Sep 18, 2019 at 3:34 PM vm finance > wrote: > > > I'm using amd64. I'd get back as soon as base build is complete. > > > > > > Thanks! > > > > > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart > wrote: > > > To get bbr running you will need to change your kernel config. > > > > > > Are you building i386 or amd64? > > > > > > After you have successfully did > > > > > > 1) buildworld > > > 2) buildkernel > > > 3) installkernel > > > > > > (you can look in UPDATING for instructions .. though the file is long > :D) > > > > > > successfully let me know.. and then I will give you the tweaks you > need to add > > > to the kerneconf. > > > > > > It won=E2=80=99t take as long to build because at that point you can = add in the > > > NO_CLEAN NO_CLEANDIR options as well since you will have built > everything > > > the first time > > > > > > R > > > > > > > On Sep 18, 2019, at 7:06 AM, vm finance > wrote: > > > > > > > > BTW, if you think I should be making any changes in configs, please > do let me know. > > > > My goal is to build a freebsd image with BBR patches on x86 VM. > > > > Nothing fancy. > > > > > > > > thanks! > > > > > > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance > wrote: > > > > Thanks Randall, Michael, > > > > > > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > > > and now doing "make buildworld buildkernel" > > > > [I didn't change anything in configs - just whatever are the > defaults] > > > > > > > > I would update as soon as its done. > > > > > > > > Thanks again! > > > > > > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart > wrote: > > > > One other note.. I notice his kernel conf he sent does not have > > > > the right things to get BBR even to attempt to build. > > > > > > > > I would suggest using that config for the first steps.. then he mus= t > add > > > > the additional tcp stacks and the hpts in order to get bbr/rack and > any other > > > > extra stack=E2=80=A6. > > > > > > > > But I would suggest to build with his current config first and once > he has > > > > that in place and building > > > > > > > > a) apply the patch > > > > b) add the extra kernel options > > > > > > > > R > > > > > > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart > wrote: > > > > > > > > > > Thats great idea Michael. > > > > > > > > > > From the look fo the build log I was sent, his blow-up has nothin= g > to do > > > > > with the patches. > > > > > > > > > > He should probably > > > > > > > > > > 1) Check out a fresh version of head. > > > > > 2) Follow the instructions in UPDATING to get a clean build. > > > > > =E2=80=94 make buildworld > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > > > > > > > ** do the reboot and merge master ** > > > > > > > > > > Then after that he could > > > > > > > > > > 3) Apply the current patch in the review > > > > > 4) do build that > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN -= DNO_CLEANDIR > > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > > > > > > > And he should have it all working :) > > > > > > > > > > I have done multiple builds with the latest head from yesterday > both with and without > > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build failu= re.. this > would verify he can > > > > > at least build head.. > > > > > > > > > > R > > > > > > > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < > michael.tuexen@lurchi.franken.de> wrote: > > > > >> > > > > >>> On 18. Sep 2019, at 08:19, vm finance > wrote: > > > > >>> > > > > >>> correcting a typo: > > > > >>> > > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > > > >>> current revision: 352434 > > > > >> I suggest to build/install head first without any patches. After > that has worked, > > > > >> apply the patches you are interested in. That way it is easy to > separate generic > > > > >> build issues and issue specific to a patch. > > > > >> > > > > >> Best regards > > > > >> Michael > > > > >>> > > > > >>> Thank you! > > > > >>> > > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < > vm.finance2@gmail.com> wrote: > > > > >>> > > > > >>>> Actually I am on head already as mentioned previously. Pulled > it using > > > > >>>> yesterday: > > > > >>>> > > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > > > >>>> > > > > >>>> > > > > >>>> If you could pls let me know the new patch, I can try that. > > > > >>>> > > > > >>>> Thanks > > > > >>>> > > > > >>>> Sent from my iPhone > > > > >>>> > > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> There have been several patches pre-this one that provide > > > > >>>> the infrastructure to support BBR. > > > > >>>> > > > > >>>> Release 12.0 will *not* have these patches and will *not* > compile it. > > > > >>>> > > > > >>>> I have no intention at this point in doing a MFC of this work.= . > so if you > > > > >>>> want > > > > >>>> to run BBR you need to run Head > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hi Randall, > > > > >>>> > > > > >>>> > > > > >>>> Could you please provide a pointer to the latest patch. I had > applied the > > > > >>>> one you published Sep-10. > > > > >>>> > > > > >>>> > > > > >>>> Following is what I have done: > > > > >>>> > > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > > > >>>> > > > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > > > >>>> > > > > >>>> 3. Checked out latest codebase from freebsd repo: > > > > >>>> > > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > > > >>>> > > > > >>>> cd /usr/src; > > > > >>>> > > > > >>>> make buildworld buildkernel > > > > >>>> > > > > >>>> [this is where make fails when patch is applied] > > > > >>>> > > > > >>>> > > > > >>>> I could try to build with your latest patch - please send me a > pointer. > > > > >>>> > > > > >>>> > > > > >>>> Thanks for your help! > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> Looking at your make file log I can=E2=80=99t really tell what= you are > doing. > > > > >>>> > > > > >>>> > > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > > >>>> > > > > >>>> > > > > >>>> Are you cross compiling? > > > > >>>> > > > > >>>> > > > > >>>> I have done the old fashioned kernel make > > > > >>>> > > > > >>>> > > > > >>>> i.e. > > > > >>>> > > > > >>>> > > > > >>>> cd src/sys/amd64/config > > > > >>>> > > > > >>>> config headvm > > > > >>>> > > > > >>>> cd ../compile/headvm > > > > >>>> > > > > >>>> > > > > >>>> make cleandepend ; make depend; make -j3 > > > > >>>> > > > > >>>> > > > > >>>> I have done > > > > >>>> > > > > >>>> > > > > >>>> cd src > > > > >>>> > > > > >>>> make buildkernel KERNCONF=3Dheadvm > > > > >>>> > > > > >>>> > > > > >>>> And even > > > > >>>> > > > > >>>> > > > > >>>> make buildkernel KERNCONF=3DGENERIC > > > > >>>> > > > > >>>> > > > > >>>> to make sure that the build works without bbr. > > > > >>>> > > > > >>>> > > > > >>>> I attach my headvm config.. > > > > >>>> > > > > >>>> > > > > >>>> What exactly are you building and how? kernel config too pleas= e? > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> > > > > >>>> looking > > > > >>>> > > > > >>>> > > > > >>>> I was at 352408.. let me update and try it > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hmm > > > > >>>> > > > > >>>> > > > > >>>> Did you get the patch I updated too this am? > > > > >>>> > > > > >>>> > > > > >>>> I have built it both with and without the bbr stack and had no > issue.. > > > > >>>> there was > > > > >>>> > > > > >>>> an issue with KTLS before the update though. > > > > >>>> > > > > >>>> > > > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Got it - thank you! > > > > >>>> > > > > >>>> > > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > > >>>> info + make error mesg. > > > > >>>> > > > > >>>> > > > > >>>> Please let me know what am I missing here? > > > > >>>> > > > > >>>> > > > > >>>> Thanks! > > > > >>>> > > > > >>>> > > > > >>>> #svnlite revision > > > > >>>> > > > > >>>> Path: . > > > > >>>> > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>> > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>> > > > > >>>> Relative URL: ^/head > > > > >>>> > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>> > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>> > > > > >>>> Revision: 352436 > > > > >>>> > > > > >>>> Node Kind: directory > > > > >>>> > > > > >>>> Schedule: normal > > > > >>>> > > > > >>>> Last Changed Author: jah > > > > >>>> > > > > >>>> Last Changed Rev: 352434 > > > > >>>> > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019= ) > > > > >>>> > > > > >>>> > > > > >>>> root@osboxes:/usr/src # > > > > >>>> > > > > >>>> > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>> > > > > >>>> > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>> > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>> > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>> > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>> > > > > >>>> rm: x86: is a directory > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[2]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[1]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make: stopped in /usr/src > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < > vm.finance2@gmail.com> wrote: > > > > >>>> > > > > >>>> Got it - thank you! > > > > >>>> > > > > >>>> > > > > >>>> btw, I tried to build the patch but its giving an error. > Following is SVN > > > > >>>> info + make error mesg. > > > > >>>> > > > > >>>> I have also attached the entire build log...snippet is below > > > > >>>> > > > > >>>> > > > > >>>> Please let me know what am I missing here? > > > > >>>> > > > > >>>> > > > > >>>> Thanks! > > > > >>>> > > > > >>>> > > > > >>>> #svnlite revision > > > > >>>> > > > > >>>> Path: . > > > > >>>> > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>> > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>> > > > > >>>> Relative URL: ^/head > > > > >>>> > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>> > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>> > > > > >>>> Revision: 352436 > > > > >>>> > > > > >>>> Node Kind: directory > > > > >>>> > > > > >>>> Schedule: normal > > > > >>>> > > > > >>>> Last Changed Author: jah > > > > >>>> > > > > >>>> Last Changed Rev: 352434 > > > > >>>> > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 2019= ) > > > > >>>> > > > > >>>> > > > > >>>> root@osboxes:/usr/src # > > > > >>>> > > > > >>>> > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>> > > > > >>>> > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo > dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>> > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>> > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>> > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o > sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h > opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>> > > > > >>>> rm: x86: is a directory > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[2]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make[1]: stopped in /usr/src > > > > >>>> > > > > >>>> *** Error code 1 > > > > >>>> > > > > >>>> > > > > >>>> Stop. > > > > >>>> > > > > >>>> make: stopped in /usr/src > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches do > not have > > > > >>>> > > > > >>>> to have fq.. they built an alternate means of doing pacing int= o > bbr. > > > > >>>> > > > > >>>> > > > > >>>> In either case our testing has shown that our pacing is more > accurate than > > > > >>>> > > > > >>>> either fq or the internal pacer :) > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Thanks Randall. > > > > >>>> > > > > >>>> I was able to apply the patch - now rebuilding the kernel. > Would update on > > > > >>>> how it goes. > > > > >>>> > > > > >>>> > > > > >>>> BTW, is there any description on how lack of tc_fq under > FreeBSD is > > > > >>>> compensated here? > > > > >>>> > > > > >>>> The original BBR patches on Linux show that as a must-have? Is > that > > > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > > > >>>> > > > > >>>> > > > > >>>> Any pointers to existing presentations/discussions highly > appreciated? > > > > >>>> > > > > >>>> > > > > >>>> Thanks a lot. > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < > rrs@netflix.com> wrote: > > > > >>>> > > > > >>>> You should be able to compile it against the current head. I > re-doing that > > > > >>>> now (had an > > > > >>>> > > > > >>>> issue with my machine and had to roll it back to a backup). > > > > >>>> > > > > >>>> > > > > >>>> When I put the patch up on Sept 10th it complied with and > without BBR on > > > > >>>> whatever > > > > >>>> > > > > >>>> was that rev.. > > > > >>>> > > > > >>>> > > > > >>>> Looking in the commit logs that would have been around 352191 > > > > >>>> > > > > >>>> > > > > >>>> Hope that helps > > > > >>>> > > > > >>>> > > > > >>>> R > > > > >>>> > > > > >>>> > > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance > wrote: > > > > >>>> > > > > >>>> > > > > >>>> Hi Randall, > > > > >>>> > > > > >>>> > > > > >>>> Thanks for releasing BBR patch: > > > > >>>> > > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > > >>>> > > > > >>>> > > > > >>>> Could you please let me know what SVN/GIT label tag this is > based on? I > > > > >>>> would like to patch and experiment with it. I couldn't find > this info in > > > > >>>> the released patch. > > > > >>>> > > > > >>>> > > > > >>>> Thanks a lot! > > > > >>>> > > > > >>>> > > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone > wrote: > > > > >>>> > > > > >>>> rrs@ has just posted the BBR patch to phabricator: > > > > >>>> > > > > >>>> > > > > >>>> https://reviews.freebsd.org/D21582 > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> > > > > >>>> Randall Stewart > > > > >>>> > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> ------ > > > > >>>> Randall Stewart > > > > >>>> rrs@netflix.com > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>>> > > > > >>> _______________________________________________ > > > > >>> freebsd-net@freebsd.org mailing list > > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > > > >>> To unsubscribe, send any mail to " > freebsd-net-unsubscribe@freebsd.org" > > > > > > > > > > ------ > > > > > Randall Stewart > > > > > rrs@netflix.com > > > > > > > > > > > > > > > > > > > > > > > ------ > > > > Randall Stewart > > > > rrs@netflix.com > > > > > > > > > > > > > > > > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > > > > > > > > > > > > ------ > > Randall Stewart > > rrs@netflix.com > > > > > > > > ------ > Randall Stewart > rrs@netflix.com > > > > From owner-freebsd-net@freebsd.org Fri Sep 20 04:24:18 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C710CF1338 for ; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZLFt4x8Rz4gHg for ; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id A79A1F1337; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A7645F1336 for ; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLFt412Jz4gHf for ; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6E5DA2021E for ; Fri, 20 Sep 2019 04:24:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8K4OI9v014186 for ; Fri, 20 Sep 2019 04:24:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8K4OIgx014183 for net@FreeBSD.org; Fri, 20 Sep 2019 04:24:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 239240] igb: TX(2) desc avail = 1024, pidx = 0 messages appear when the network card (igb/ixgbe/em) loses ethernet link Date: Fri, 20 Sep 2019 04:24:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: IntelNetworking, needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: flagtypes.name keywords short_desc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:24:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239240 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |mfc-stable12? Keywords| |needs-patch, needs-qa Summary|igb: TX(2) desc avail =3D |igb: TX(2) desc avail =3D |1024, pidx =3D 0 messages |1024, pidx =3D 0 messages |appear when the network |appear when the network |card loses ethernet link |card (igb/ixgbe/em) loses | |ethernet link Status|New |Open --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 04:24:43 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECFA8F13AA for ; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZLGM64p4z3BnY for ; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D0B1CF13A9; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D080EF13A8 for ; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLGM5DnWz3BnX for ; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 97EF22022A for ; Fri, 20 Sep 2019 04:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8K4Ohw1017688 for ; Fri, 20 Sep 2019 04:24:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8K4Ohw9017687 for net@FreeBSD.org; Fri, 20 Sep 2019 04:24:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240658] iflib: if_igb(4) and some if_em(4) devices don't recognize/report carrier loss. Date: Fri, 20 Sep 2019 04:24:43 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: DUPLICATE X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: koobs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_file_loc cc assigned_to resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:24:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240658 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://lists.freebsd.org/p | |ipermail/freebsd-net/2018-M | |ay/050497.html CC| |net@FreeBSD.org Assignee|net@FreeBSD.org |koobs@FreeBSD.org Resolution|--- |DUPLICATE Status|New |Closed --- Comment #3 from Kubilay Kocak --- Closing per comment 2 *** This bug has been marked as a duplicate of bug 239240 *** --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 04:24:45 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 37213F13BB for ; Fri, 20 Sep 2019 04:24:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZLGP0llFz3Bnq for ; Fri, 20 Sep 2019 04:24:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 19C23F13B7; Fri, 20 Sep 2019 04:24:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 19891F13B6 for ; Fri, 20 Sep 2019 04:24:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLGN70cCz3Bnn for ; Fri, 20 Sep 2019 04:24:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D24E520233 for ; Fri, 20 Sep 2019 04:24:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8K4OicA017727 for ; Fri, 20 Sep 2019 04:24:44 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8K4Oi1T017726 for net@FreeBSD.org; Fri, 20 Sep 2019 04:24:44 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 239240] igb: TX(2) desc avail = 1024, pidx = 0 messages appear when the network card (igb/ixgbe/em) loses ethernet link Date: Fri, 20 Sep 2019 04:24:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: IntelNetworking, needs-patch, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: mfc-stable12? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:24:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239240 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla.freebsd@omnilan.de --- Comment #12 from Kubilay Kocak --- *** Bug 240658 has been marked as a duplicate of this bug. *** --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 04:27:12 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B2D96F15B2 for ; Fri, 20 Sep 2019 04:27:12 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLKC4l0Lz3C1Q for ; Fri, 20 Sep 2019 04:27:11 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd33.google.com with SMTP id q10so13213611iop.2 for ; Thu, 19 Sep 2019 21:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jpeJfp0wA+xEpxV3LB9DP0ExyEAYDhk/4FF4kZ2v3xY=; b=u7Gtct5A8iJFizRILdmdppNsLf5su6o7OzHQj8zgg0mB8q8N5SqT7TPhME9jnNmcNa P+fGV8+nAdTbgKo3Np2NJJqf5fUCqWbP/4WhLn1IrW2HleluM2DZi86NbXEXELN21SXO LBlSxeqtkjvXMyre7Dimf8BQvsdQZC0J3XEttnFWd89948lxNMHQK/RfuzEjV0+x2JOl nEn3ZyGU8ekGYzb6AwN7pYzl3wx0woqyQVbQUWGyPKj2Cz37OqArjIDLz/q3QZtXUUvn fIiEj1e2z9fTE30gCEs+9w0R3uT49bFK0M0ye1pvLLatrzcFkX+ndkodPBrz0G50iE1H cAeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jpeJfp0wA+xEpxV3LB9DP0ExyEAYDhk/4FF4kZ2v3xY=; b=p1Bz/xSYgAVNPtssKbVvNAsOrS4dxpkSeIIHUR4bJCLsAvY3REnLvdKtcNjDEiVgtD yHvvho9GfH/Y16ynP90Y+Ul/CA9CxBsdPu0VhwlVPBg0S7+t9PZzDOHX0Z0jlSXqsvHR R+KLA43HC+1N1TBW9wHpGzqL5EtJ24cMX9g3lIPaSh/Rv5BhW5emJHYUCiXypsyQmMhC +AaMlt7LdyQ3KPyuATGHrq9USS3qvLQbBIsGm4FuvYkd25I3vPbYzm6O4/LHxVxgVn/E rz6xKByFAUzsUPutruSrj3f5xb5lrW+PRXOM4pizTFfGy1ps3iiKQqQ5H+DOcGRtaLux m8yg== X-Gm-Message-State: APjAAAUIgVIb9H8oZ9EbsFo+g4CZQynzR8TwA9BifcmB9kXgoDCha58r oxDmb3+Aze0IwbfK+Ijr1mC3o4XZO71W3m1o/AU= X-Google-Smtp-Source: APXvYqz+Vo+Qpx8E4w2vlrpw1hTEgSh3Du1gAbW03wN2IPe/6H4/mr0LyHO8Qub0hMyiONp248kT3b+H0qdaw2sc9zU= X-Received: by 2002:a02:6616:: with SMTP id k22mr16440073jac.129.1568953629905; Thu, 19 Sep 2019 21:27:09 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Thu, 19 Sep 2019 21:26:59 -0700 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZLKC4l0Lz3C1Q X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=u7Gtct5A; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d33 as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-4.19), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:27:12 -0000 finally ;) I was able to build it after manually extracting Makefile contents from patch. rebooting now ;) On Thu, Sep 19, 2019 at 8:12 PM Randall Stewart wrote: > There should have been some in the patch. Tomorrow I can send you a tar o= f > the modules/tcp/bbr Dir. > > It=E2=80=99s similar to the rack setup if you can=E2=80=99t wait and want= to be > adventurous > > R > > Sent from my iPhone > > On Sep 19, 2019, at 7:31 PM, vm finance wrote: > > Hi Randall, > > I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ > > However, there is no "bbr" under sys/modules/tcp/. I created this > directory manually. > Question: > Which Makefile do I need to copy/move under sys/modules/tcp/bbr? > I see there are Makefile and Makefile.org under ~modules/tcp... > > root@osboxes:/usr/src/sys/modules/tcp # ls -R > Makefile Makefile.orig bbr rack tcpmd5 > ./bbr: > > ./rack: > Makefile > > ./tcpmd5: > Makefile > > Please let me know. > > Thanks for your help! > > On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote: > >> Ahh.. Look in your directory. >> >> You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the = right >> places >> >> When you load the patch (which was updated Sept 17th and should be >> different slightly) >> you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the >> local dir since >> for what every reason patch cannot figure out how to place it. >> >> You must move >> >> bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >> >> You must create >> >> sys/modules/tcp/bbr >> >> and >> >> place the make file under there (just like rack=E2=80=99s). >> >> Do that and I think you will finally have it.. not sure why patch is not >> able to >> put the new files in the right places :0 >> >> R >> >> > On Sep 19, 2019, at 10:42 AM, vm finance wrote= : >> > >> > Hello Randall, >> > >> > I just retried it with headvm config that you had shared but still see >> error while doing >> > "make cleandepend" >> > >> > Any pointers highly appreciated. >> > >> > Thanks >> > >> > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend >> > [...snip...] >> > >> > =3D=3D=3D> sysvipc/sysvshm (obj) >> > >> /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sy= svshm >> created for /usr/src/sys/modules/sysvipc/sysvshm >> > =3D=3D=3D> tcp (obj) >> > =3D=3D=3D> tcp/bbr (obj) >> > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory >> > *** Error code 2 >> > >> > Stop. >> > make[2]: stopped in /usr/src/sys/modules/tcp >> > *** Error code 1 >> > >> > Stop. >> > make[1]: stopped in /usr/src/sys/modules >> > *** Error code 1 >> > >> > Stop. >> > make: stopped in /usr/src/sys/amd64/compile/headvm >> > root@osboxes:/usr/src/sys/amd64/compile/headvm # >> > >> > >> > On Wed, Sep 18, 2019 at 11:08 PM vm finance >> wrote: >> > Hi Randall, >> > >> > I applied the patch available at: >> > https://reviews.freebsd.org/D21582?id=3D62213 >> > NOTE: This raw patch seems to be exactly the same as the one I >> downloaded on Sep10...hope I'm not missing anything here... >> > >> > I clicked on "download raw diff" and saved it to bbr_patch.diff file o= n >> my local machine >> > Step 1: Apply PATCH: >> > cd /usr/src/sys >> > patch < bbr_patch.diff >> > Patch was applied successfully - no errors seen there. >> > >> > Step 2: Update kernel config: >> > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL >> > Added three options to MYKERNEL (per ur email - I have also attached >> the compile MYKERNEL file) >> > cd /usr/src/sys/amd64/compile/MYKERNEL >> > make cleandepend >> > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ >> > [pls find the attached log file for exact error] >> > >> > make depend >> > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >> > >> > STEP 3: >> > cd /usr/src/ >> > make buildkernel KERNCONF=3DMYKERNEL >> > This also fails due to prior errors in Step 2. >> > >> > Please find MYKERNEL config file + error logs. >> > >> > Many many thanks for taking time to help me through this! >> > >> > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and that >> successfully finished. >> > >> > >> > >> > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart >> wrote: >> > You can look in the config I sent.. but here is what >> > I have added to enable BBR and Rack to be built >> > ***** >> > makeoptions WITH_EXTRA_TCP_STACKS=3D1 >> > options TCPHPTS >> > options RATELIMIT >> > ****** >> > >> > So you should >> > 1) Apply the current patch in phabricator >> > 2) edit your config and add the above three lines >> > 3) go to the src dir and type >> > make buildkernel KERNCONF=3Dmyconf >> > >> > That should build and get you a kernel that will include bbr and rack. >> You will >> > need to, after it boots up type >> > >> > kldload tcp_bbr >> > >> > or >> > >> > kldload tcp_rack >> > >> > To get the modules loaded >> > >> > R >> > >> > >> > >> > > On Sep 18, 2019, at 2:31 PM, vm finance >> wrote: >> > > >> > > Hi Randall, Michael, >> > > >> > > Build is done successfully. I would appreciate if you could share >> config changes needed for BBR. >> > > >> > > My svn revision is: 352483 >> > > >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >> xargs -J% objcopy % zlib.ko.full >> > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >> > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug zlib.ko.f= ull >> zlib.ko >> > > -------------------------------------------------------------- >> > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC 20= 19 >> > > -------------------------------------------------------------- >> > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >> > > >> > > Thank you >> > > Vishal. >> > > >> > > >> > > On Wed, Sep 18, 2019 at 3:34 PM vm finance >> wrote: >> > > I'm using amd64. I'd get back as soon as base build is complete. >> > > >> > > Thanks! >> > > >> > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >> wrote: >> > > To get bbr running you will need to change your kernel config. >> > > >> > > Are you building i386 or amd64? >> > > >> > > After you have successfully did >> > > >> > > 1) buildworld >> > > 2) buildkernel >> > > 3) installkernel >> > > >> > > (you can look in UPDATING for instructions .. though the file is lon= g >> :D) >> > > >> > > successfully let me know.. and then I will give you the tweaks you >> need to add >> > > to the kerneconf. >> > > >> > > It won=E2=80=99t take as long to build because at that point you can= add in >> the >> > > NO_CLEAN NO_CLEANDIR options as well since you will have built >> everything >> > > the first time >> > > >> > > R >> > > >> > > > On Sep 18, 2019, at 7:06 AM, vm finance >> wrote: >> > > > >> > > > BTW, if you think I should be making any changes in configs, pleas= e >> do let me know. >> > > > My goal is to build a freebsd image with BBR patches on x86 VM. >> > > > Nothing fancy. >> > > > >> > > > thanks! >> > > > >> > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >> wrote: >> > > > Thanks Randall, Michael, >> > > > >> > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >> > > > and now doing "make buildworld buildkernel" >> > > > [I didn't change anything in configs - just whatever are the >> defaults] >> > > > >> > > > I would update as soon as its done. >> > > > >> > > > Thanks again! >> > > > >> > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >> wrote: >> > > > One other note.. I notice his kernel conf he sent does not have >> > > > the right things to get BBR even to attempt to build. >> > > > >> > > > I would suggest using that config for the first steps.. then he >> must add >> > > > the additional tcp stacks and the hpts in order to get bbr/rack an= d >> any other >> > > > extra stack=E2=80=A6. >> > > > >> > > > But I would suggest to build with his current config first and onc= e >> he has >> > > > that in place and building >> > > > >> > > > a) apply the patch >> > > > b) add the extra kernel options >> > > > >> > > > R >> > > > >> > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >> wrote: >> > > > > >> > > > > Thats great idea Michael. >> > > > > >> > > > > From the look fo the build log I was sent, his blow-up has >> nothing to do >> > > > > with the patches. >> > > > > >> > > > > He should probably >> > > > > >> > > > > 1) Check out a fresh version of head. >> > > > > 2) Follow the instructions in UPDATING to get a clean build. >> > > > > =E2=80=94 make buildworld >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >> > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >> > > > > >> > > > > ** do the reboot and merge master ** >> > > > > >> > > > > Then after that he could >> > > > > >> > > > > 3) Apply the current patch in the review >> > > > > 4) do build that >> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN >> -DNO_CLEANDIR >> > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >> > > > > >> > > > > And he should have it all working :) >> > > > > >> > > > > I have done multiple builds with the latest head from yesterday >> both with and without >> > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build fail= ure.. >> this would verify he can >> > > > > at least build head.. >> > > > > >> > > > > R >> > > > > >> > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >> michael.tuexen@lurchi.franken.de> wrote: >> > > > >> >> > > > >>> On 18. Sep 2019, at 08:19, vm finance >> wrote: >> > > > >>> >> > > > >>> correcting a typo: >> > > > >>> >> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >> > > > >>> current revision: 352434 >> > > > >> I suggest to build/install head first without any patches. Afte= r >> that has worked, >> > > > >> apply the patches you are interested in. That way it is easy to >> separate generic >> > > > >> build issues and issue specific to a patch. >> > > > >> >> > > > >> Best regards >> > > > >> Michael >> > > > >>> >> > > > >>> Thank you! >> > > > >>> >> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>> >> > > > >>>> Actually I am on head already as mentioned previously. Pulled >> it using >> > > > >>>> yesterday: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >> > > > >>>> >> > > > >>>> >> > > > >>>> If you could pls let me know the new patch, I can try that. >> > > > >>>> >> > > > >>>> Thanks >> > > > >>>> >> > > > >>>> Sent from my iPhone >> > > > >>>> >> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> There have been several patches pre-this one that provide >> > > > >>>> the infrastructure to support BBR. >> > > > >>>> >> > > > >>>> Release 12.0 will *not* have these patches and will *not* >> compile it. >> > > > >>>> >> > > > >>>> I have no intention at this point in doing a MFC of this >> work.. so if you >> > > > >>>> want >> > > > >>>> to run BBR you need to run Head >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please provide a pointer to the latest patch. I had >> applied the >> > > > >>>> one you published Sep-10. >> > > > >>>> >> > > > >>>> >> > > > >>>> Following is what I have done: >> > > > >>>> >> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >> > > > >>>> >> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop >> > > > >>>> >> > > > >>>> 3. Checked out latest codebase from freebsd repo: >> > > > >>>> >> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >> > > > >>>> >> > > > >>>> cd /usr/src; >> > > > >>>> >> > > > >>>> make buildworld buildkernel >> > > > >>>> >> > > > >>>> [this is where make fails when patch is applied] >> > > > >>>> >> > > > >>>> >> > > > >>>> I could try to build with your latest patch - please send me = a >> pointer. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for your help! >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Looking at your make file log I can=E2=80=99t really tell wha= t you are >> doing. >> > > > >>>> >> > > > >>>> >> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> Are you cross compiling? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done the old fashioned kernel make >> > > > >>>> >> > > > >>>> >> > > > >>>> i.e. >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src/sys/amd64/config >> > > > >>>> >> > > > >>>> config headvm >> > > > >>>> >> > > > >>>> cd ../compile/headvm >> > > > >>>> >> > > > >>>> >> > > > >>>> make cleandepend ; make depend; make -j3 >> > > > >>>> >> > > > >>>> >> > > > >>>> I have done >> > > > >>>> >> > > > >>>> >> > > > >>>> cd src >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3Dheadvm >> > > > >>>> >> > > > >>>> >> > > > >>>> And even >> > > > >>>> >> > > > >>>> >> > > > >>>> make buildkernel KERNCONF=3DGENERIC >> > > > >>>> >> > > > >>>> >> > > > >>>> to make sure that the build works without bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> I attach my headvm config.. >> > > > >>>> >> > > > >>>> >> > > > >>>> What exactly are you building and how? kernel config too >> please? >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> looking >> > > > >>>> >> > > > >>>> >> > > > >>>> I was at 352408.. let me update and try it >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hmm >> > > > >>>> >> > > > >>>> >> > > > >>>> Did you get the patch I updated too this am? >> > > > >>>> >> > > > >>>> >> > > > >>>> I have built it both with and without the bbr stack and had n= o >> issue.. >> > > > >>>> there was >> > > > >>>> >> > > > >>>> an issue with KTLS before the update though. >> > > > >>>> >> > > > >>>> >> > > > >>>> I don=E2=80=99t recognize what you have below there though=E2= =80=A6 >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> Got it - thank you! >> > > > >>>> >> > > > >>>> >> > > > >>>> btw, I tried to build the patch but its giving an error. >> Following is SVN >> > > > >>>> info + make error mesg. >> > > > >>>> >> > > > >>>> I have also attached the entire build log...snippet is below >> > > > >>>> >> > > > >>>> >> > > > >>>> Please let me know what am I missing here? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks! >> > > > >>>> >> > > > >>>> >> > > > >>>> #svnlite revision >> > > > >>>> >> > > > >>>> Path: . >> > > > >>>> >> > > > >>>> Working Copy Root Path: /usr/src >> > > > >>>> >> > > > >>>> URL: svn://svn.freebsd.org/base/head >> > > > >>>> >> > > > >>>> Relative URL: ^/head >> > > > >>>> >> > > > >>>> Repository Root: svn://svn.freebsd.org/base >> > > > >>>> >> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >> > > > >>>> >> > > > >>>> Revision: 352436 >> > > > >>>> >> > > > >>>> Node Kind: directory >> > > > >>>> >> > > > >>>> Schedule: normal >> > > > >>>> >> > > > >>>> Last Changed Author: jah >> > > > >>>> >> > > > >>>> Last Changed Rev: 352434 >> > > > >>>> >> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep 201= 9) >> > > > >>>> >> > > > >>>> >> > > > >>>> root@osboxes:/usr/src # >> > > > >>>> >> > > > >>>> >> > > > >>>> -------------------------------------------- snip >> > > > >>>> ---------------------------- >> > > > >>>> >> > > > >>>> >> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >> dev_net.llo >> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >> > > > >>>> >> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >> > > > >>>> >> > > > >>>> =3D=3D=3D> sys (cleandir) >> > > > >>>> >> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >> sack_filter.o >> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >> opt_tcpdebug.h >> > > > >>>> opt_kern_tls.h >> > > > >>>> >> > > > >>>> rm: x86: is a directory >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[3]: stopped in /usr/src/sys >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[2]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make[1]: stopped in /usr/src >> > > > >>>> >> > > > >>>> *** Error code 1 >> > > > >>>> >> > > > >>>> >> > > > >>>> Stop. >> > > > >>>> >> > > > >>>> make: stopped in /usr/src >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches d= o >> not have >> > > > >>>> >> > > > >>>> to have fq.. they built an alternate means of doing pacing >> into bbr. >> > > > >>>> >> > > > >>>> >> > > > >>>> In either case our testing has shown that our pacing is more >> accurate than >> > > > >>>> >> > > > >>>> either fq or the internal pacer :) >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance < >> vm.finance2@gmail.com> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks Randall. >> > > > >>>> >> > > > >>>> I was able to apply the patch - now rebuilding the kernel. >> Would update on >> > > > >>>> how it goes. >> > > > >>>> >> > > > >>>> >> > > > >>>> BTW, is there any description on how lack of tc_fq under >> FreeBSD is >> > > > >>>> compensated here? >> > > > >>>> >> > > > >>>> The original BBR patches on Linux show that as a must-have? I= s >> that >> > > > >>>> functionality implemented via tcp_ratelimit.[ch]? >> > > > >>>> >> > > > >>>> >> > > > >>>> Any pointers to existing presentations/discussions highly >> appreciated? >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot. >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < >> rrs@netflix.com> wrote: >> > > > >>>> >> > > > >>>> You should be able to compile it against the current head. I >> re-doing that >> > > > >>>> now (had an >> > > > >>>> >> > > > >>>> issue with my machine and had to roll it back to a backup). >> > > > >>>> >> > > > >>>> >> > > > >>>> When I put the patch up on Sept 10th it complied with and >> without BBR on >> > > > >>>> whatever >> > > > >>>> >> > > > >>>> was that rev.. >> > > > >>>> >> > > > >>>> >> > > > >>>> Looking in the commit logs that would have been around 352191 >> > > > >>>> >> > > > >>>> >> > > > >>>> Hope that helps >> > > > >>>> >> > > > >>>> >> > > > >>>> R >> > > > >>>> >> > > > >>>> >> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance >> wrote: >> > > > >>>> >> > > > >>>> >> > > > >>>> Hi Randall, >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks for releasing BBR patch: >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >> > > > >>>> >> > > > >>>> >> > > > >>>> Could you please let me know what SVN/GIT label tag this is >> based on? I >> > > > >>>> would like to patch and experiment with it. I couldn't find >> this info in >> > > > >>>> the released patch. >> > > > >>>> >> > > > >>>> >> > > > >>>> Thanks a lot! >> > > > >>>> >> > > > >>>> >> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone >> wrote: >> > > > >>>> >> > > > >>>> rrs@ has just posted the BBR patch to phabricator: >> > > > >>>> >> > > > >>>> >> > > > >>>> https://reviews.freebsd.org/D21582 >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> >> > > > >>>> Randall Stewart >> > > > >>>> >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> ------ >> > > > >>>> Randall Stewart >> > > > >>>> rrs@netflix.com >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>>> >> > > > >>> _______________________________________________ >> > > > >>> freebsd-net@freebsd.org mailing list >> > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> > > > >>> To unsubscribe, send any mail to " >> freebsd-net-unsubscribe@freebsd.org" >> > > > > >> > > > > ------ >> > > > > Randall Stewart >> > > > > rrs@netflix.com >> > > > > >> > > > > >> > > > > >> > > > >> > > > ------ >> > > > Randall Stewart >> > > > rrs@netflix.com >> > > > >> > > > >> > > > >> > > >> > > ------ >> > > Randall Stewart >> > > rrs@netflix.com >> > > >> > > >> > > >> > >> > ------ >> > Randall Stewart >> > rrs@netflix.com >> > >> > >> > >> >> ------ >> Randall Stewart >> rrs@netflix.com >> >> >> >> From owner-freebsd-net@freebsd.org Fri Sep 20 04:39:56 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7070FF1979 for ; Fri, 20 Sep 2019 04:39:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZLbw24bwz3CQx for ; Fri, 20 Sep 2019 04:39:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4580BF1978; Fri, 20 Sep 2019 04:39:56 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 453CCF1977 for ; Fri, 20 Sep 2019 04:39:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLbw0DpGz3CQw for ; Fri, 20 Sep 2019 04:39:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DCD522041E for ; Fri, 20 Sep 2019 04:39:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8K4dtpl048516 for ; Fri, 20 Sep 2019 04:39:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8K4dt4F048513 for net@FreeBSD.org; Fri, 20 Sep 2019 04:39:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Fri, 20 Sep 2019 04:39:55 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:39:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #14 from Kubilay Kocak --- With 12.1 imminent, I'd recommend preparing a patch (differential) for revi= ew as soon as possible, if reverting base r316820 is confirmed to resolve the issue @Armin, can you test reverting that patch, rebuilding your kernel (or just if_jme) and explicitly confirm that it resolves the issue? --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 04:52:21 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4173FF1EDE for ; Fri, 20 Sep 2019 04:52:21 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZLtD2ZlZz3D7f for ; Fri, 20 Sep 2019 04:52:19 +0000 (UTC) (envelope-from vm.finance2@gmail.com) Received: by mail-io1-xd2d.google.com with SMTP id h144so13213436iof.7 for ; Thu, 19 Sep 2019 21:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gNlNta/ZzryW2Ghmn/HwIwpw+MVPYm63/LNAKYeX2KA=; b=ta7pl5JDTpNH/DxeET3Nu1a9aNuwerlD45PUMSiX3gVxoaBY+UIdHbnyC4mYiG2C6S 7iSF+X/Akq8fdU+wXji0fhP1IsvR1p+aVyhm49smknIhQ/1EngrbJAQRw5cBQkQUvr3s bZeXUdKqDNYUXniSNSLnEoQzENIA1hjgaLCR5+r9NfgNbLhhkdYOh1g51zua24sXbHUn IPBF9sXS7u2SsibOjxgYGtVCjP0b6bR9iji5eLrJQzsEs0ARMTUbnOxyCngWgSHBF5ip vLqCvS9VDvY0b+xKwD8W90VItp8aKaxHVh6soAYlqTeDhZIos/WYV5J5/nGmD3VEg0Zt GL+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gNlNta/ZzryW2Ghmn/HwIwpw+MVPYm63/LNAKYeX2KA=; b=AgQGIBPJyDWIcxeANWCGnzwySpGpSE9BT7T0G+YuSqxdAUIU1TmnD5mYOPr8h3jrmU EkrG64jZEXJMUjtmg1gL9/NT1WjVrBn3cs+P1QnrHbX+8uRQ3jOtRL+kp14pmyU69Yub 2Cz55nbo9RUp8mNZ7QasH8+jgh3A81PRZs+bdfKKn79ANCGKlVK56yWqKRpfGT6R+KlP /YR1ZDs7W42DAq26ww8uxAnFa2v9duFZqgZjwBMqhM/YajKyouV7sB2JEvMWxQY2sqm9 lCrVA4cMkt52Cp2tIrqieMA2iXFRw3ayD4yfFlh33isY7/7UfFisGr7wK0g6sghHgr+O TUNg== X-Gm-Message-State: APjAAAWmlM7Fu3pf0ehoJF8/fnUCr8Wai5pe2CgFfOLG7AYP3FEIMttM 56mtRudgAWBjcFqpBvZ/upb5qKHYEpwamf3sYVw= X-Google-Smtp-Source: APXvYqzp0ekaM7llUPPaq8b3qsTmKHifNLca5uSjRJIjV/mGIy18E4mm8Wf33C2jVgjR3L8TXT/eTPgDclg3yBOyPq0= X-Received: by 2002:a02:608:: with SMTP id 8mr16794795jav.88.1568955138835; Thu, 19 Sep 2019 21:52:18 -0700 (PDT) MIME-Version: 1.0 References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> In-Reply-To: From: vm finance Date: Fri, 20 Sep 2019 04:52:07 +0000 Message-ID: Subject: Re: BBR patches? To: Randall Stewart Cc: =?UTF-8?Q?Michael_T=C3=BCxen?= , freebsd-net , Jamie Landeg-Jones , Ryan Stone X-Rspamd-Queue-Id: 46ZLtD2ZlZz3D7f X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ta7pl5JD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of vmfinance2@gmail.com designates 2607:f8b0:4864:20::d2d as permitted sender) smtp.mailfrom=vmfinance2@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[d.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-6.22), ipnet: 2607:f8b0::/32(-2.66), asn: 15169(-2.21), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 04:52:21 -0000 Ok - kernel booted, I loaded the module and it loaded successfully (kldstat shows tcp_bbr). So if I want to compare results between bbr and default cc algo, I just need to load/unload the bbr module - correct? Or is there another way to achieve that? Please let me know. Thanks for all your help. On Fri, Sep 20, 2019 at 4:26 AM vm finance wrote: > finally ;) I was able to build it after manually extracting Makefile > contents from patch. > rebooting now ;) > > On Thu, Sep 19, 2019 at 8:12 PM Randall Stewart wrote: > >> There should have been some in the patch. Tomorrow I can send you a tar >> of the modules/tcp/bbr Dir. >> >> It=E2=80=99s similar to the rack setup if you can=E2=80=99t wait and wan= t to be >> adventurous >> >> R >> >> Sent from my iPhone >> >> On Sep 19, 2019, at 7:31 PM, vm finance wrote: >> >> Hi Randall, >> >> I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ >> >> However, there is no "bbr" under sys/modules/tcp/. I created this >> directory manually. >> Question: >> Which Makefile do I need to copy/move under sys/modules/tcp/bbr? >> I see there are Makefile and Makefile.org under ~modules/tcp... >> >> root@osboxes:/usr/src/sys/modules/tcp # ls -R >> Makefile Makefile.orig bbr rack tcpmd5 >> ./bbr: >> >> ./rack: >> Makefile >> >> ./tcpmd5: >> Makefile >> >> Please let me know. >> >> Thanks for your help! >> >> On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart wrote= : >> >>> Ahh.. Look in your directory. >>> >>> You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into the= right >>> places >>> >>> When you load the patch (which was updated Sept 17th and should be >>> different slightly) >>> you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the >>> local dir since >>> for what every reason patch cannot figure out how to place it. >>> >>> You must move >>> >>> bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >>> >>> You must create >>> >>> sys/modules/tcp/bbr >>> >>> and >>> >>> place the make file under there (just like rack=E2=80=99s). >>> >>> Do that and I think you will finally have it.. not sure why patch is no= t >>> able to >>> put the new files in the right places :0 >>> >>> R >>> >>> > On Sep 19, 2019, at 10:42 AM, vm finance >>> wrote: >>> > >>> > Hello Randall, >>> > >>> > I just retried it with headvm config that you had shared but still se= e >>> error while doing >>> > "make cleandepend" >>> > >>> > Any pointers highly appreciated. >>> > >>> > Thanks >>> > >>> > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend >>> > [...snip...] >>> > >>> > =3D=3D=3D> sysvipc/sysvshm (obj) >>> > >>> /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/s= ysvshm >>> created for /usr/src/sys/modules/sysvipc/sysvshm >>> > =3D=3D=3D> tcp (obj) >>> > =3D=3D=3D> tcp/bbr (obj) >>> > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory >>> > *** Error code 2 >>> > >>> > Stop. >>> > make[2]: stopped in /usr/src/sys/modules/tcp >>> > *** Error code 1 >>> > >>> > Stop. >>> > make[1]: stopped in /usr/src/sys/modules >>> > *** Error code 1 >>> > >>> > Stop. >>> > make: stopped in /usr/src/sys/amd64/compile/headvm >>> > root@osboxes:/usr/src/sys/amd64/compile/headvm # >>> > >>> > >>> > On Wed, Sep 18, 2019 at 11:08 PM vm finance >>> wrote: >>> > Hi Randall, >>> > >>> > I applied the patch available at: >>> > https://reviews.freebsd.org/D21582?id=3D62213 >>> > NOTE: This raw patch seems to be exactly the same as the one I >>> downloaded on Sep10...hope I'm not missing anything here... >>> > >>> > I clicked on "download raw diff" and saved it to bbr_patch.diff file >>> on my local machine >>> > Step 1: Apply PATCH: >>> > cd /usr/src/sys >>> > patch < bbr_patch.diff >>> > Patch was applied successfully - no errors seen there. >>> > >>> > Step 2: Update kernel config: >>> > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL >>> > Added three options to MYKERNEL (per ur email - I have also attached >>> the compile MYKERNEL file) >>> > cd /usr/src/sys/amd64/compile/MYKERNEL >>> > make cleandepend >>> > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ >>> > [pls find the attached log file for exact error] >>> > >>> > make depend >>> > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" >>> > >>> > STEP 3: >>> > cd /usr/src/ >>> > make buildkernel KERNCONF=3DMYKERNEL >>> > This also fails due to prior errors in Step 2. >>> > >>> > Please find MYKERNEL config file + error logs. >>> > >>> > Many many thanks for taking time to help me through this! >>> > >>> > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and tha= t >>> successfully finished. >>> > >>> > >>> > >>> > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart >>> wrote: >>> > You can look in the config I sent.. but here is what >>> > I have added to enable BBR and Rack to be built >>> > ***** >>> > makeoptions WITH_EXTRA_TCP_STACKS=3D1 >>> > options TCPHPTS >>> > options RATELIMIT >>> > ****** >>> > >>> > So you should >>> > 1) Apply the current patch in phabricator >>> > 2) edit your config and add the above three lines >>> > 3) go to the src dir and type >>> > make buildkernel KERNCONF=3Dmyconf >>> > >>> > That should build and get you a kernel that will include bbr and rack= . >>> You will >>> > need to, after it boots up type >>> > >>> > kldload tcp_bbr >>> > >>> > or >>> > >>> > kldload tcp_rack >>> > >>> > To get the modules loaded >>> > >>> > R >>> > >>> > >>> > >>> > > On Sep 18, 2019, at 2:31 PM, vm finance >>> wrote: >>> > > >>> > > Hi Randall, Michael, >>> > > >>> > > Build is done successfully. I would appreciate if you could share >>> config changes needed for BBR. >>> > > >>> > > My svn revision is: 352483 >>> > > >>> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >>> > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | >>> xargs -J% objcopy % zlib.ko.full >>> > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug >>> > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug >>> zlib.ko.full zlib.ko >>> > > -------------------------------------------------------------- >>> > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC >>> 2019 >>> > > -------------------------------------------------------------- >>> > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 >>> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D >>> > > >>> > > Thank you >>> > > Vishal. >>> > > >>> > > >>> > > On Wed, Sep 18, 2019 at 3:34 PM vm finance >>> wrote: >>> > > I'm using amd64. I'd get back as soon as base build is complete. >>> > > >>> > > Thanks! >>> > > >>> > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart >>> wrote: >>> > > To get bbr running you will need to change your kernel config. >>> > > >>> > > Are you building i386 or amd64? >>> > > >>> > > After you have successfully did >>> > > >>> > > 1) buildworld >>> > > 2) buildkernel >>> > > 3) installkernel >>> > > >>> > > (you can look in UPDATING for instructions .. though the file is >>> long :D) >>> > > >>> > > successfully let me know.. and then I will give you the tweaks you >>> need to add >>> > > to the kerneconf. >>> > > >>> > > It won=E2=80=99t take as long to build because at that point you ca= n add in >>> the >>> > > NO_CLEAN NO_CLEANDIR options as well since you will have built >>> everything >>> > > the first time >>> > > >>> > > R >>> > > >>> > > > On Sep 18, 2019, at 7:06 AM, vm finance >>> wrote: >>> > > > >>> > > > BTW, if you think I should be making any changes in configs, >>> please do let me know. >>> > > > My goal is to build a freebsd image with BBR patches on x86 VM. >>> > > > Nothing fancy. >>> > > > >>> > > > thanks! >>> > > > >>> > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance >>> wrote: >>> > > > Thanks Randall, Michael, >>> > > > >>> > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" >>> > > > and now doing "make buildworld buildkernel" >>> > > > [I didn't change anything in configs - just whatever are the >>> defaults] >>> > > > >>> > > > I would update as soon as its done. >>> > > > >>> > > > Thanks again! >>> > > > >>> > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart >>> wrote: >>> > > > One other note.. I notice his kernel conf he sent does not have >>> > > > the right things to get BBR even to attempt to build. >>> > > > >>> > > > I would suggest using that config for the first steps.. then he >>> must add >>> > > > the additional tcp stacks and the hpts in order to get bbr/rack >>> and any other >>> > > > extra stack=E2=80=A6. >>> > > > >>> > > > But I would suggest to build with his current config first and >>> once he has >>> > > > that in place and building >>> > > > >>> > > > a) apply the patch >>> > > > b) add the extra kernel options >>> > > > >>> > > > R >>> > > > >>> > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart >>> wrote: >>> > > > > >>> > > > > Thats great idea Michael. >>> > > > > >>> > > > > From the look fo the build log I was sent, his blow-up has >>> nothing to do >>> > > > > with the patches. >>> > > > > >>> > > > > He should probably >>> > > > > >>> > > > > 1) Check out a fresh version of head. >>> > > > > 2) Follow the instructions in UPDATING to get a clean build. >>> > > > > =E2=80=94 make buildworld >>> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf >>> > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf >>> > > > > >>> > > > > ** do the reboot and merge master ** >>> > > > > >>> > > > > Then after that he could >>> > > > > >>> > > > > 3) Apply the current patch in the review >>> > > > > 4) do build that >>> > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf -DNO_CLEAN >>> -DNO_CLEANDIR >>> > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf >>> > > > > >>> > > > > And he should have it all working :) >>> > > > > >>> > > > > I have done multiple builds with the latest head from yesterday >>> both with and without >>> > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build fai= lure.. >>> this would verify he can >>> > > > > at least build head.. >>> > > > > >>> > > > > R >>> > > > > >>> > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen < >>> michael.tuexen@lurchi.franken.de> wrote: >>> > > > >> >>> > > > >>> On 18. Sep 2019, at 08:19, vm finance >>> wrote: >>> > > > >>> >>> > > > >>> correcting a typo: >>> > > > >>> >>> > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src >>> > > > >>> current revision: 352434 >>> > > > >> I suggest to build/install head first without any patches. >>> After that has worked, >>> > > > >> apply the patches you are interested in. That way it is easy t= o >>> separate generic >>> > > > >> build issues and issue specific to a patch. >>> > > > >> >>> > > > >> Best regards >>> > > > >> Michael >>> > > > >>> >>> > > > >>> Thank you! >>> > > > >>> >>> > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>> >>> > > > >>>> Actually I am on head already as mentioned previously. Pulle= d >>> it using >>> > > > >>>> yesterday: >>> > > > >>>> >>> > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> If you could pls let me know the new patch, I can try that. >>> > > > >>>> >>> > > > >>>> Thanks >>> > > > >>>> >>> > > > >>>> Sent from my iPhone >>> > > > >>>> >>> > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> There have been several patches pre-this one that provide >>> > > > >>>> the infrastructure to support BBR. >>> > > > >>>> >>> > > > >>>> Release 12.0 will *not* have these patches and will *not* >>> compile it. >>> > > > >>>> >>> > > > >>>> I have no intention at this point in doing a MFC of this >>> work.. so if you >>> > > > >>>> want >>> > > > >>>> to run BBR you need to run Head >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hi Randall, >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Could you please provide a pointer to the latest patch. I ha= d >>> applied the >>> > > > >>>> one you published Sep-10. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Following is what I have done: >>> > > > >>>> >>> > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org >>> > > > >>>> >>> > > > >>>> 2. Got VM up under VMPlayer on x86 laptop >>> > > > >>>> >>> > > > >>>> 3. Checked out latest codebase from freebsd repo: >>> > > > >>>> >>> > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* >>> > > > >>>> >>> > > > >>>> cd /usr/src; >>> > > > >>>> >>> > > > >>>> make buildworld buildkernel >>> > > > >>>> >>> > > > >>>> [this is where make fails when patch is applied] >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I could try to build with your latest patch - please send me >>> a pointer. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks for your help! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> Looking at your make file log I can=E2=80=99t really tell wh= at you >>> are doing. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Are you cross compiling? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have done the old fashioned kernel make >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> i.e. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> cd src/sys/amd64/config >>> > > > >>>> >>> > > > >>>> config headvm >>> > > > >>>> >>> > > > >>>> cd ../compile/headvm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> make cleandepend ; make depend; make -j3 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have done >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> cd src >>> > > > >>>> >>> > > > >>>> make buildkernel KERNCONF=3Dheadvm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> And even >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> make buildkernel KERNCONF=3DGENERIC >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> to make sure that the build works without bbr. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I attach my headvm config.. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> What exactly are you building and how? kernel config too >>> please? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> looking >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I was at 352408.. let me update and try it >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart >>> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hmm >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Did you get the patch I updated too this am? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I have built it both with and without the bbr stack and had >>> no issue.. >>> > > > >>>> there was >>> > > > >>>> >>> > > > >>>> an issue with KTLS before the update though. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> I don=E2=80=99t recognize what you have below there though= =E2=80=A6 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Got it - thank you! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> btw, I tried to build the patch but its giving an error. >>> Following is SVN >>> > > > >>>> info + make error mesg. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Please let me know what am I missing here? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> #svnlite revision >>> > > > >>>> >>> > > > >>>> Path: . >>> > > > >>>> >>> > > > >>>> Working Copy Root Path: /usr/src >>> > > > >>>> >>> > > > >>>> URL: svn://svn.freebsd.org/base/head >>> > > > >>>> >>> > > > >>>> Relative URL: ^/head >>> > > > >>>> >>> > > > >>>> Repository Root: svn://svn.freebsd.org/base >>> > > > >>>> >>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> > > > >>>> >>> > > > >>>> Revision: 352436 >>> > > > >>>> >>> > > > >>>> Node Kind: directory >>> > > > >>>> >>> > > > >>>> Schedule: normal >>> > > > >>>> >>> > > > >>>> Last Changed Author: jah >>> > > > >>>> >>> > > > >>>> Last Changed Rev: 352434 >>> > > > >>>> >>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep >>> 2019) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> root@osboxes:/usr/src # >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> -------------------------------------------- snip >>> > > > >>>> ---------------------------- >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >>> dev_net.llo >>> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>> > > > >>>> >>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> > > > >>>> >>> > > > >>>> =3D=3D=3D> sys (cleandir) >>> > > > >>>> >>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >>> sack_filter.o >>> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >>> opt_tcpdebug.h >>> > > > >>>> opt_kern_tls.h >>> > > > >>>> >>> > > > >>>> rm: x86: is a directory >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[3]: stopped in /usr/src/sys >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[2]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[1]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> Got it - thank you! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> btw, I tried to build the patch but its giving an error. >>> Following is SVN >>> > > > >>>> info + make error mesg. >>> > > > >>>> >>> > > > >>>> I have also attached the entire build log...snippet is below >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Please let me know what am I missing here? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> #svnlite revision >>> > > > >>>> >>> > > > >>>> Path: . >>> > > > >>>> >>> > > > >>>> Working Copy Root Path: /usr/src >>> > > > >>>> >>> > > > >>>> URL: svn://svn.freebsd.org/base/head >>> > > > >>>> >>> > > > >>>> Relative URL: ^/head >>> > > > >>>> >>> > > > >>>> Repository Root: svn://svn.freebsd.org/base >>> > > > >>>> >>> > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>> > > > >>>> >>> > > > >>>> Revision: 352436 >>> > > > >>>> >>> > > > >>>> Node Kind: directory >>> > > > >>>> >>> > > > >>>> Schedule: normal >>> > > > >>>> >>> > > > >>>> Last Changed Author: jah >>> > > > >>>> >>> > > > >>>> Last Changed Rev: 352434 >>> > > > >>>> >>> > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep >>> 2019) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> root@osboxes:/usr/src # >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> -------------------------------------------- snip >>> > > > >>>> ---------------------------- >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo vdisk.llo >>> dev_net.llo >>> > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo >>> > > > >>>> >>> > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS >>> > > > >>>> >>> > > > >>>> =3D=3D=3D> sys (cleandir) >>> > > > >>>> >>> > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o >>> sack_filter.o >>> > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h >>> opt_tcpdebug.h >>> > > > >>>> opt_kern_tls.h >>> > > > >>>> >>> > > > >>>> rm: x86: is a directory >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[3]: stopped in /usr/src/sys >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[2]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make[1]: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> *** Error code 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Stop. >>> > > > >>>> >>> > > > >>>> make: stopped in /usr/src >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches >>> do not have >>> > > > >>>> >>> > > > >>>> to have fq.. they built an alternate means of doing pacing >>> into bbr. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> In either case our testing has shown that our pacing is more >>> accurate than >>> > > > >>>> >>> > > > >>>> either fq or the internal pacer :) >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks Randall. >>> > > > >>>> >>> > > > >>>> I was able to apply the patch - now rebuilding the kernel. >>> Would update on >>> > > > >>>> how it goes. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> BTW, is there any description on how lack of tc_fq under >>> FreeBSD is >>> > > > >>>> compensated here? >>> > > > >>>> >>> > > > >>>> The original BBR patches on Linux show that as a must-have? >>> Is that >>> > > > >>>> functionality implemented via tcp_ratelimit.[ch]? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Any pointers to existing presentations/discussions highly >>> appreciated? >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks a lot. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart < >>> rrs@netflix.com> wrote: >>> > > > >>>> >>> > > > >>>> You should be able to compile it against the current head. I >>> re-doing that >>> > > > >>>> now (had an >>> > > > >>>> >>> > > > >>>> issue with my machine and had to roll it back to a backup). >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> When I put the patch up on Sept 10th it complied with and >>> without BBR on >>> > > > >>>> whatever >>> > > > >>>> >>> > > > >>>> was that rev.. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Looking in the commit logs that would have been around 35219= 1 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hope that helps >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> R >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance < >>> vm.finance2@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Hi Randall, >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks for releasing BBR patch: >>> > > > >>>> >>> > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Could you please let me know what SVN/GIT label tag this is >>> based on? I >>> > > > >>>> would like to patch and experiment with it. I couldn't find >>> this info in >>> > > > >>>> the released patch. >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> Thanks a lot! >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone < >>> rysto32@gmail.com> wrote: >>> > > > >>>> >>> > > > >>>> rrs@ has just posted the BBR patch to phabricator: >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> https://reviews.freebsd.org/D21582 >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> >>> > > > >>>> Randall Stewart >>> > > > >>>> >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> ------ >>> > > > >>>> Randall Stewart >>> > > > >>>> rrs@netflix.com >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>>> >>> > > > >>> _______________________________________________ >>> > > > >>> freebsd-net@freebsd.org mailing list >>> > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net >>> > > > >>> To unsubscribe, send any mail to " >>> freebsd-net-unsubscribe@freebsd.org" >>> > > > > >>> > > > > ------ >>> > > > > Randall Stewart >>> > > > > rrs@netflix.com >>> > > > > >>> > > > > >>> > > > > >>> > > > >>> > > > ------ >>> > > > Randall Stewart >>> > > > rrs@netflix.com >>> > > > >>> > > > >>> > > > >>> > > >>> > > ------ >>> > > Randall Stewart >>> > > rrs@netflix.com >>> > > >>> > > >>> > > >>> > >>> > ------ >>> > Randall Stewart >>> > rrs@netflix.com >>> > >>> > >>> > >>> >>> ------ >>> Randall Stewart >>> rrs@netflix.com >>> >>> >>> >>> From owner-freebsd-net@freebsd.org Fri Sep 20 09:40:59 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 893D3F8A18 for ; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZTHH37tTz3xpr for ; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 69740F8A17; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 693CBF8A16 for ; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZTHH2CX5z3xpq for ; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2FA7423A9E for ; Fri, 20 Sep 2019 09:40:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8K9ex5n013482 for ; Fri, 20 Sep 2019 09:40:59 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8K9exHQ013479 for net@FreeBSD.org; Fri, 20 Sep 2019 09:40:59 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Fri, 20 Sep 2019 09:40:58 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: freebsdbugs@hughobrien.ie X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 09:40:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #15 from Hugh O'Brien --- I can also test any patches. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 09:42:17 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id AF1ACF8AB1 for ; Fri, 20 Sep 2019 09:42:17 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZTJm3Hjhz3y51 for ; Fri, 20 Sep 2019 09:42:15 +0000 (UTC) (envelope-from michael.tuexen@lurchi.franken.de) Received: from [IPv6:2a02:8109:1140:c3d:ec77:d639:796f:bdd2] (unknown [IPv6:2a02:8109:1140:c3d:ec77:d639:796f:bdd2]) (Authenticated sender: lurchi) by drew.franken.de (Postfix) with ESMTPSA id 72E5672106C26; Fri, 20 Sep 2019 11:42:11 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: BBR patches? From: Michael Tuexen In-Reply-To: Date: Fri, 20 Sep 2019 11:42:10 +0200 Cc: Randall Stewart , freebsd-net , Jamie Landeg-Jones , Ryan Stone Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909091232.x89CWl4b047025@donotpassgo.dyslexicfish.net> <27AD43DA-3237-490A-B3A6-C1792F9674E5@netflix.com> <5B630235-ABC7-4122-9082-F59BCCCDE14A@netflix.com> <84C20AED-44B1-4673-A29E-1A6FA61D8F27@netflix.com> <98E195A0-AFE2-4182-BE90-493E76A0DB1C@netflix.com> <9F3B0B5B-EF6A-42E1-99B8-9644DD0B39AB@netflix.com> <8474687C-8E5D-45F0-A3DE-0BF62ED2D28B@netflix.com> To: vm finance X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 46ZTJm3Hjhz3y51 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of michael.tuexen@lurchi.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=michael.tuexen@lurchi.franken.de X-Spamd-Result: default: False [-1.41 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-0.99)[-0.985,0]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; IP_SCORE(-1.73)[ip: (-8.82), ipnet: 193.174.0.0/15(0.10), asn: 680(0.07), country: DE(-0.01)]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[franken.de]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.99)[-0.992,0]; MIME_TRACE(0.00)[0:+]; TO_DN_ALL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; RCVD_IN_DNSWL_LOW(-0.10)[27.24.175.193.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 09:42:17 -0000 > On 20. Sep 2019, at 06:52, vm finance wrote: >=20 > Ok - kernel booted, I loaded the module and it loaded successfully = (kldstat shows tcp_bbr). >=20 > So if I want to compare results between bbr and default cc algo, I = just need to load/unload the bbr module - correct? > Or is there another way to achieve that? One option is that your test application supports choosing the TCP stack = and you compare "freebsd" with "bbr". One tools which supports this is uperf and here is an example how to = select the (not existing anymore) stack called "fastack"): = https://github.com/uperf/uperf/blob/master/workloads/tcp-freebsd-change-st= ack.xml The other possibility is that you set your default TCP stack before = running your test app. You can so this by executing sudo sysctl -w net.inet.tcp.functions_default=3Dbbr or sudo sysctl -w net.inet.tcp.functions_default=3Dfreebsd Then you test application can be TCP stack agnostic. Best regards Michael >=20 > Please let me know. >=20 > Thanks for all your help. >=20 > On Fri, Sep 20, 2019 at 4:26 AM vm finance = wrote: > finally ;) I was able to build it after manually extracting Makefile = contents from patch. > rebooting now ;) >=20 > On Thu, Sep 19, 2019 at 8:12 PM Randall Stewart = wrote: > There should have been some in the patch. Tomorrow I can send you a = tar of the modules/tcp/bbr Dir.=20 >=20 > It=E2=80=99s similar to the rack setup if you can=E2=80=99t wait and = want to be adventurous=20 >=20 > R >=20 > Sent from my iPhone >=20 > On Sep 19, 2019, at 7:31 PM, vm finance wrote: >=20 > Hi Randall, >=20 > I already have tcp_bbr.h and bbr.c at ~sys/netinet/tcp_stacks/ >=20 > However, there is no "bbr" under sys/modules/tcp/. I created this = directory manually. > Question: > Which Makefile do I need to copy/move under sys/modules/tcp/bbr?=20 > I see there are Makefile and Makefile.org under ~modules/tcp... >=20 > root@osboxes:/usr/src/sys/modules/tcp # ls -R > Makefile Makefile.orig bbr rack tcpmd5 > ./bbr: >=20 > ./rack: > Makefile >=20 > ./tcpmd5: > Makefile >=20 > Please let me know. >=20 > Thanks for your help! >=20 > On Thu, Sep 19, 2019 at 11:05 AM Randall Stewart = wrote: > Ahh.. Look in your directory. >=20 > You did not create the sub=E2=80=99dirs or put rack.c or bbr.c into = the right places >=20 > When you load the patch (which was updated Sept 17th and should be = different slightly) > you will end up dropping a Makefile and bbr.c and tcp_bbr.h into the = local dir since > for what every reason patch cannot figure out how to place it. >=20 > You must move=20 >=20 > bbr.c/tcp_bbr.h to -> sys/netinet/tcp_stacks >=20 > You must create >=20 > sys/modules/tcp/bbr >=20 > and=20 >=20 > place the make file under there (just like rack=E2=80=99s). >=20 > Do that and I think you will finally have it.. not sure why patch is = not able to > put the new files in the right places :0 >=20 > R >=20 > > On Sep 19, 2019, at 10:42 AM, vm finance = wrote: > >=20 > > Hello Randall, > >=20 > > I just retried it with headvm config that you had shared but still = see error while doing > > "make cleandepend" > >=20 > > Any pointers highly appreciated. > >=20 > > Thanks > >=20 > > root@osboxes:/usr/src/sys/amd65/compile/headvm # make cleandepend=20 > > [...snip...] > >=20 > > =3D=3D=3D> sysvipc/sysvshm (obj) > > = /usr/src/sys/amd64/compile/headvm/modules/usr/src/sys/modules/sysvipc/sysv= shm created for /usr/src/sys/modules/sysvipc/sysvshm > > =3D=3D=3D> tcp (obj) > > =3D=3D=3D> tcp/bbr (obj) > > cd: /usr/src/sys/modules/tcp/bbr: No such file or directory > > *** Error code 2 > >=20 > > Stop. > > make[2]: stopped in /usr/src/sys/modules/tcp > > *** Error code 1 > >=20 > > Stop. > > make[1]: stopped in /usr/src/sys/modules > > *** Error code 1 > >=20 > > Stop. > > make: stopped in /usr/src/sys/amd64/compile/headvm > > root@osboxes:/usr/src/sys/amd64/compile/headvm #=20 > >=20 > >=20 > > On Wed, Sep 18, 2019 at 11:08 PM vm finance = wrote: > > Hi Randall, > >=20 > > I applied the patch available at:=20 > > https://reviews.freebsd.org/D21582?id=3D62213 > > NOTE: This raw patch seems to be exactly the same as the one I = downloaded on Sep10...hope I'm not missing anything here... > >=20 > > I clicked on "download raw diff" and saved it to bbr_patch.diff file = on my local machine > > Step 1: Apply PATCH: > > cd /usr/src/sys > > patch < bbr_patch.diff > > Patch was applied successfully - no errors seen there. > >=20 > > Step 2: Update kernel config: > > cp /usr/src/sys/amd64/conf/GENERIC /usr/src/sys/amd64/conf/MYKERNEL=20= > > Added three options to MYKERNEL (per ur email - I have also attached = the compile MYKERNEL file) > > cd /usr/src/sys/amd64/compile/MYKERNEL > > make cleandepend > > =3D>This fails due to missing "bbr" under /usr/src/sys/modules/tcp/ > > [pls find the attached log file for exact error] > >=20 > > make depend > > =3D> This also fails due to missing "/usr/src/sys/modules/tcp/bbr" > >=20 > > STEP 3: > > cd /usr/src/ > > make buildkernel KERNCONF=3DMYKERNEL > > This also fails due to prior errors in Step 2. > >=20 > > Please find MYKERNEL config file + error logs. > >=20 > > Many many thanks for taking time to help me through this! > >=20 > > PS: I did a make buildkernel without any KERNCONF=3DMYKERNEL, and = that successfully finished. > >=20 > >=20 > >=20 > > On Thu, Sep 19, 2019 at 12:19 PM Randall Stewart = wrote: > > You can look in the config I sent.. but here is what > > I have added to enable BBR and Rack to be built > > ***** > > makeoptions WITH_EXTRA_TCP_STACKS=3D1 > > options TCPHPTS=20 > > options RATELIMIT > > ****** > >=20 > > So you should > > 1) Apply the current patch in phabricator > > 2) edit your config and add the above three lines > > 3) go to the src dir and type > > make buildkernel KERNCONF=3Dmyconf > >=20 > > That should build and get you a kernel that will include bbr and = rack. You will > > need to, after it boots up type > >=20 > > kldload tcp_bbr > >=20 > > or > >=20 > > kldload tcp_rack > >=20 > > To get the modules loaded > >=20 > > R > >=20 > >=20 > >=20 > > > On Sep 18, 2019, at 2:31 PM, vm finance = wrote: > > >=20 > > > Hi Randall, Michael, > > >=20 > > > Build is done successfully. I would appreciate if you could share = config changes needed for BBR. > > >=20 > > > My svn revision is: 352483 > > >=20 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > awk -f /usr/src/sys/conf/kmod_syms.awk zlib.ko.full export_syms | = xargs -J% objcopy % zlib.ko.full > > > objcopy --only-keep-debug zlib.ko.full zlib.ko.debug > > > objcopy --strip-debug --add-gnu-debuglink=3Dzlib.ko.debug = zlib.ko.full zlib.ko > > > -------------------------------------------------------------- > > > >>> Kernel build for GENERIC completed on Wed Sep 18 21:08:31 UTC = 2019 > > > -------------------------------------------------------------- > > > >>> Kernel(s) GENERIC built in 1972 seconds, ncpu: 4 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > >=20 > > > Thank you > > > Vishal. > > >=20 > > >=20 > > > On Wed, Sep 18, 2019 at 3:34 PM vm finance = wrote: > > > I'm using amd64. I'd get back as soon as base build is complete. > > >=20 > > > Thanks! > > >=20 > > > On Wed, Sep 18, 2019 at 7:09 AM Randall Stewart = wrote: > > > To get bbr running you will need to change your kernel config. > > >=20 > > > Are you building i386 or amd64? > > >=20 > > > After you have successfully did=20 > > >=20 > > > 1) buildworld > > > 2) buildkernel > > > 3) installkernel > > >=20 > > > (you can look in UPDATING for instructions .. though the file is = long :D) > > >=20 > > > successfully let me know.. and then I will give you the tweaks you = need to add > > > to the kerneconf. > > >=20 > > > It won=E2=80=99t take as long to build because at that point you = can add in the > > > NO_CLEAN NO_CLEANDIR options as well since you will have built = everything > > > the first time > > >=20 > > > R > > >=20 > > > > On Sep 18, 2019, at 7:06 AM, vm finance = wrote: > > > >=20 > > > > BTW, if you think I should be making any changes in configs, = please do let me know. > > > > My goal is to build a freebsd image with BBR patches on x86 VM.=20= > > > > Nothing fancy. > > > >=20 > > > > thanks! > > > >=20 > > > > On Wed, Sep 18, 2019 at 7:03 AM vm finance = wrote: > > > > Thanks Randall, Michael, > > > >=20 > > > > I did "svn svn://svn.freebsd.org/base/head /usr/src" > > > > and now doing "make buildworld buildkernel"=20 > > > > [I didn't change anything in configs - just whatever are the = defaults] > > > >=20 > > > > I would update as soon as its done. > > > >=20 > > > > Thanks again! > > > >=20 > > > > On Wed, Sep 18, 2019 at 6:53 AM Randall Stewart = wrote: > > > > One other note.. I notice his kernel conf he sent does not have > > > > the right things to get BBR even to attempt to build. > > > >=20 > > > > I would suggest using that config for the first steps.. then he = must add > > > > the additional tcp stacks and the hpts in order to get bbr/rack = and any other > > > > extra stack=E2=80=A6.=20 > > > >=20 > > > > But I would suggest to build with his current config first and = once he has > > > > that in place and building > > > >=20 > > > > a) apply the patch > > > > b) add the extra kernel options > > > >=20 > > > > R > > > >=20 > > > > > On Sep 18, 2019, at 6:50 AM, Randall Stewart = wrote: > > > > >=20 > > > > > Thats great idea Michael. > > > > >=20 > > > > > =46rom the look fo the build log I was sent, his blow-up has = nothing to do > > > > > with the patches. > > > > >=20 > > > > > He should probably > > > > >=20 > > > > > 1) Check out a fresh version of head. > > > > > 2) Follow the instructions in UPDATING to get a clean build. > > > > > =E2=80=94 make buildworld > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis-conf > > > > > =E2=80=94 make installkernel KERNCONF=3Dhis-conf > > > > >=20 > > > > > ** do the reboot and merge master ** > > > > >=20 > > > > > Then after that he could > > > > >=20 > > > > > 3) Apply the current patch in the review > > > > > 4) do build that > > > > > =E2=80=94 make buildkernel KERNCONF=3Dhis_conf = -DNO_CLEAN -DNO_CLEANDIR > > > > > =E2=80=94 make install kernel KERNCONF=3Dhis_conf > > > > >=20 > > > > > And he should have it all working :) > > > > >=20 > > > > > I have done multiple builds with the latest head from = yesterday both with and without > > > > > the extra stacks and hpts.. and I can=E2=80=99t get a build = failure.. this would verify he can > > > > > at least build head.. > > > > >=20 > > > > > R > > > > >=20 > > > > >> On Sep 18, 2019, at 12:10 AM, Michael Tuexen = wrote: > > > > >>=20 > > > > >>> On 18. Sep 2019, at 08:19, vm finance = wrote: > > > > >>>=20 > > > > >>> correcting a typo: > > > > >>>=20 > > > > >>> svn co svn://svn.freebsd.org/base/head /usr/src > > > > >>> current revision: 352434 > > > > >> I suggest to build/install head first without any patches. = After that has worked, > > > > >> apply the patches you are interested in. That way it is easy = to separate generic > > > > >> build issues and issue specific to a patch. > > > > >>=20 > > > > >> Best regards > > > > >> Michael > > > > >>>=20 > > > > >>> Thank you! > > > > >>>=20 > > > > >>> On Tue, Sep 17, 2019 at 10:11 PM vm finance = wrote: > > > > >>>=20 > > > > >>>> Actually I am on head already as mentioned previously. = Pulled it using > > > > >>>> yesterday: > > > > >>>>=20 > > > > >>>> svn co svn://svn.freebsd.org/base/head /use/src > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> If you could pls let me know the new patch, I can try that. > > > > >>>>=20 > > > > >>>> Thanks > > > > >>>>=20 > > > > >>>> Sent from my iPhone > > > > >>>>=20 > > > > >>>> On 18-Sep-2019, at 8:56 AM, Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>> There have been several patches pre-this one that provide > > > > >>>> the infrastructure to support BBR. > > > > >>>>=20 > > > > >>>> Release 12.0 will *not* have these patches and will *not* = compile it. > > > > >>>>=20 > > > > >>>> I have no intention at this point in doing a MFC of this = work.. so if you > > > > >>>> want > > > > >>>> to run BBR you need to run Head > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 7:26 PM, vm finance = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Hi Randall, > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Could you please provide a pointer to the latest patch. I = had applied the > > > > >>>> one you published Sep-10. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Following is what I have done: > > > > >>>>=20 > > > > >>>> 1. Picked FreeBSD 12.0 RELEASE VM from osboxes.org > > > > >>>>=20 > > > > >>>> 2. Got VM up under VMPlayer on x86 laptop > > > > >>>>=20 > > > > >>>> 3. Checked out latest codebase from freebsd repo: > > > > >>>>=20 > > > > >>>> svn co svn://svn.freebsd.org/base/head /usr/src* > > > > >>>>=20 > > > > >>>> cd /usr/src; > > > > >>>>=20 > > > > >>>> make buildworld buildkernel > > > > >>>>=20 > > > > >>>> [this is where make fails when patch is applied] > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I could try to build with your latest patch - please send = me a pointer. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks for your help! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Tue, Sep 17, 2019 at 1:33 PM Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>> Looking at your make file log I can=E2=80=99t really tell = what you are doing. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Its not the BBR or Rack code that is blowing up=E2=80=A6 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Are you cross compiling? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I have done the old fashioned kernel make > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> i.e. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> cd src/sys/amd64/config > > > > >>>>=20 > > > > >>>> config headvm > > > > >>>>=20 > > > > >>>> cd ../compile/headvm > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> make cleandepend ; make depend; make -j3 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I have done > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> cd src > > > > >>>>=20 > > > > >>>> make buildkernel KERNCONF=3Dheadvm > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> And even > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> make buildkernel KERNCONF=3DGENERIC > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> to make sure that the build works without bbr. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I attach my headvm config.. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> What exactly are you building and how? kernel config too = please? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 1:11 PM, Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> looking > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I was at 352408.. let me update and try it > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 1:10 PM, Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Hmm > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Did you get the patch I updated too this am? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I have built it both with and without the bbr stack and had = no issue.. > > > > >>>> there was > > > > >>>>=20 > > > > >>>> an issue with KTLS before the update though. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> I don=E2=80=99t recognize what you have below there = though=E2=80=A6 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 11:47 AM, vm finance = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Got it - thank you! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > > > >>>> info + make error mesg. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Please let me know what am I missing here? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> #svnlite revision > > > > >>>>=20 > > > > >>>> Path: . > > > > >>>>=20 > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>>=20 > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>>=20 > > > > >>>> Relative URL: ^/head > > > > >>>>=20 > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>>=20 > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>>=20 > > > > >>>> Revision: 352436 > > > > >>>>=20 > > > > >>>> Node Kind: directory > > > > >>>>=20 > > > > >>>> Schedule: normal > > > > >>>>=20 > > > > >>>> Last Changed Author: jah > > > > >>>>=20 > > > > >>>> Last Changed Rev: 352434 > > > > >>>>=20 > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep = 2019) > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> root@osboxes:/usr/src # > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo = vdisk.llo dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>>=20 > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>>=20 > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>>=20 > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>>=20 > > > > >>>> rm: x86: is a directory > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[2]: stopped in /usr/src > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[1]: stopped in /usr/src > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make: stopped in /usr/src > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Tue, Sep 17, 2019 at 6:41 PM vm finance = wrote: > > > > >>>>=20 > > > > >>>> Got it - thank you! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> btw, I tried to build the patch but its giving an error. = Following is SVN > > > > >>>> info + make error mesg. > > > > >>>>=20 > > > > >>>> I have also attached the entire build log...snippet is = below > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Please let me know what am I missing here? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> #svnlite revision > > > > >>>>=20 > > > > >>>> Path: . > > > > >>>>=20 > > > > >>>> Working Copy Root Path: /usr/src > > > > >>>>=20 > > > > >>>> URL: svn://svn.freebsd.org/base/head > > > > >>>>=20 > > > > >>>> Relative URL: ^/head > > > > >>>>=20 > > > > >>>> Repository Root: svn://svn.freebsd.org/base > > > > >>>>=20 > > > > >>>> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > > > > >>>>=20 > > > > >>>> Revision: 352436 > > > > >>>>=20 > > > > >>>> Node Kind: directory > > > > >>>>=20 > > > > >>>> Schedule: normal > > > > >>>>=20 > > > > >>>> Last Changed Author: jah > > > > >>>>=20 > > > > >>>> Last Changed Rev: 352434 > > > > >>>>=20 > > > > >>>> Last Changed Date: 2019-09-17 03:39:31 +0000 (Tue, 17 Sep = 2019) > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> root@osboxes:/usr/src # > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> -------------------------------------------- snip > > > > >>>> ---------------------------- > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ad_elf64_obj.llo reloc_elf64.llo disk.llo part.llo = vdisk.llo dev_net.llo > > > > >>>> bcache.llo interp_simple.llo zfs_cmd.llo > > > > >>>>=20 > > > > >>>> rm -f .depend .depend.* GPATH GRTAGS GSYMS GTAGS > > > > >>>>=20 > > > > >>>> =3D=3D=3D> sys (cleandir) > > > > >>>>=20 > > > > >>>> rm -f export_syms machine x86 tcp_bbr.ko tcp_bbr.kld bbr.o = sack_filter.o > > > > >>>> rack_bbr_common.o opt_inet.h opt_inet6.h opt_ipsec.h = opt_tcpdebug.h > > > > >>>> opt_kern_tls.h > > > > >>>>=20 > > > > >>>> rm: x86: is a directory > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[3]: stopped in /usr/src/sys > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[2]: stopped in /usr/src > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make[1]: stopped in /usr/src > > > > >>>>=20 > > > > >>>> *** Error code 1 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Stop. > > > > >>>>=20 > > > > >>>> make: stopped in /usr/src > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Tue, Sep 17, 2019 at 6:27 PM Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>> Pacing is provided by tcp_hpts.c. The current linux patches = do not have > > > > >>>>=20 > > > > >>>> to have fq.. they built an alternate means of doing pacing = into bbr. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> In either case our testing has shown that our pacing is = more accurate than > > > > >>>>=20 > > > > >>>> either fq or the internal pacer :) > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 11:05 AM, vm finance = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks Randall. > > > > >>>>=20 > > > > >>>> I was able to apply the patch - now rebuilding the kernel. = Would update on > > > > >>>> how it goes. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> BTW, is there any description on how lack of tc_fq under = FreeBSD is > > > > >>>> compensated here? > > > > >>>>=20 > > > > >>>> The original BBR patches on Linux show that as a must-have? = Is that > > > > >>>> functionality implemented via tcp_ratelimit.[ch]? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Any pointers to existing presentations/discussions highly = appreciated? > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks a lot. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Tue, Sep 17, 2019 at 5:39 AM Randall Stewart = wrote: > > > > >>>>=20 > > > > >>>> You should be able to compile it against the current head. = I re-doing that > > > > >>>> now (had an > > > > >>>>=20 > > > > >>>> issue with my machine and had to roll it back to a backup). > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> When I put the patch up on Sept 10th it complied with and = without BBR on > > > > >>>> whatever > > > > >>>>=20 > > > > >>>> was that rev.. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Looking in the commit logs that would have been around = 352191 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Hope that helps > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> R > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Sep 17, 2019, at 3:32 AM, vm finance = wrote: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Hi Randall, > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks for releasing BBR patch: > > > > >>>>=20 > > > > >>>> https://reviews.freebsd.org/D21582#change-xcAWBif3E9Jq > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Could you please let me know what SVN/GIT label tag this is = based on? I > > > > >>>> would like to patch and experiment with it. I couldn't find = this info in > > > > >>>> the released patch. > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> Thanks a lot! > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> On Tue, Sep 10, 2019 at 10:26 AM Ryan Stone = wrote: > > > > >>>>=20 > > > > >>>> rrs@ has just posted the BBR patch to phabricator: > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> https://reviews.freebsd.org/D21582 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>>=20 > > > > >>>> Randall Stewart > > > > >>>>=20 > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>>=20 > > > > >>>> Randall Stewart > > > > >>>>=20 > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>>=20 > > > > >>>> Randall Stewart > > > > >>>>=20 > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>>=20 > > > > >>>> Randall Stewart > > > > >>>>=20 > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>>=20 > > > > >>>> Randall Stewart > > > > >>>>=20 > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>> ------ > > > > >>>> Randall Stewart > > > > >>>> rrs@netflix.com > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>>>=20 > > > > >>> _______________________________________________ > > > > >>> freebsd-net@freebsd.org mailing list > > > > >>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > > > > >>> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" > > > > >=20 > > > > > ------ > > > > > Randall Stewart > > > > > rrs@netflix.com > > > > >=20 > > > > >=20 > > > > >=20 > > > >=20 > > > > ------ > > > > Randall Stewart > > > > rrs@netflix.com > > > >=20 > > > >=20 > > > >=20 > > >=20 > > > ------ > > > Randall Stewart > > > rrs@netflix.com > > >=20 > > >=20 > > >=20 > >=20 > > ------ > > Randall Stewart > > rrs@netflix.com > >=20 > >=20 > >=20 >=20 > ------ > Randall Stewart > rrs@netflix.com >=20 >=20 >=20 From owner-freebsd-net@freebsd.org Fri Sep 20 10:12:18 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71AE1F941C for ; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZTzQ2WpGz40Rx for ; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5692EF941B; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 565C2F941A for ; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZTzQ1hdyz40Rt for ; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1F2DF24164 for ; Fri, 20 Sep 2019 10:12:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8KACI9H095979 for ; Fri, 20 Sep 2019 10:12:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8KACIdT095978 for net@FreeBSD.org; Fri, 20 Sep 2019 10:12:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Fri, 20 Sep 2019 10:12:17 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 10:12:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #16 from Kubilay Kocak --- (In reply to Hugh O'Brien from comment #15) The patch is a reversion of base r316820 --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Fri Sep 20 15:17:22 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B04DFF89E for ; Fri, 20 Sep 2019 15:17:22 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZclP3vrGz4JQd for ; Fri, 20 Sep 2019 15:17:21 +0000 (UTC) (envelope-from luthramihir708@gmail.com) Received: by mail-vs1-xe2b.google.com with SMTP id l2so4920454vsr.8 for ; Fri, 20 Sep 2019 08:17:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=vXMnjH5JHGLF7tJebDjjDvcKvFiHQucyCDBhzdS36i8=; b=X0QOHw1B5SOddb7VAD+ZpJdOdHbeYE2skulUK/jtOgyu/ApO9zBSN9m/9hrzxO+huT 3ny8wokRpi5kTnBvDa/6sQX/C0rEVSaJz39UZOq6F877FF6iYf7IBOMac8coDGoiOOpJ UlTNYseYYcQFWmfpO05ECZDqrTH48CSB23pd+SMv7pNugDc2wrtosGO9g19rBXF0mTwm z+B2WijlkRsTuj1JEh87G9j7o8Q6+SyfF1TAyBeX5eJOywgn75/XVFmmFOCzHemgaBvl FSohoL6g81aHuV6SiOhncafqVHzb++LWuRLQcJJeq8JXWUiMBlYz5fYkxI8BnUS3E36D yp3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=vXMnjH5JHGLF7tJebDjjDvcKvFiHQucyCDBhzdS36i8=; b=Xo2DgBjBRR7smp63XwYCnXS4WJN320kANP6HeaTj/PnzhRwQ71iMIJpnpuDDOYSoBw YOJuLt1NuqKQrBG91ixfLkmvEdAjh5QrsT9ojAdkAsYm5yEAEd7LbsSYKUA8MwxUTfWY YcUMRbwFdMl9aOLaopDv0HA7iF3+qJxSGA/UVhSmnQwBD8Kt7an8j1rLsq6jlyN2mkCv 2XtntH1uXGUQzVwqanhYxvpxiP/GOc5u7eAUBZfl1OlEQPTibyj2kXAOX1FpOUootXsZ rqhbqYEOEU3O0MenCV03kPhPO5jTSM7bfMohX2bD72wCZSqyNr3+3ajTf5LcQDZhOluy FsJQ== X-Gm-Message-State: APjAAAWaAx6Q7jCzy8+08mB5oJ5EFgg70ldf1j6ZTx9+WB2SG6HfOL5a dw0ePYHEvzLmJoH0GAtuGOL1R3euavfo8uCBoTYRv0z8 X-Google-Smtp-Source: APXvYqwJu/Hp9qfuWiu5IdMdFjIqo98C8AI4txYNpnlMySzuOYEBGzBuxQHL2gPUwBrRntT1LzPudwCG/WK/YrSjz8g= X-Received: by 2002:a67:fd63:: with SMTP id h3mr2845094vsa.102.1568992639983; Fri, 20 Sep 2019 08:17:19 -0700 (PDT) MIME-Version: 1.0 From: Mihir Luthra Date: Fri, 20 Sep 2019 20:47:08 +0530 Message-ID: Subject: testing rpc.statd To: freebsd-net X-Rspamd-Queue-Id: 46ZclP3vrGz4JQd X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=X0QOHw1B; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of luthramihir708@gmail.com designates 2607:f8b0:4864:20::e2b as permitted sender) smtp.mailfrom=luthramihir708@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.62), ipnet: 2607:f8b0::/32(-2.65), asn: 15169(-2.21), country: US(-0.05)]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[b.2.e.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 15:17:22 -0000 Hi, I was trying to make changes to usr.sbin/rpc.statd to make it ipv6 clean. I am looking for some good ways to test my changes, would be great if I could receive some help. Till now what I planned is setting a NFS client on another system and NFS server on FreeBSD machine and test its changes and then reverse. I am not sure if I could do it on the same machine by some way. Also, I am already running FreeBSD on virtualbox on macos, so another layer of virtual machine maybe heavy for the system to handle. Although I saw a test.c [1] file in the directory. I was wondering if this complete is the test suite for statd? I tried running `make test` but it said `No such file or dir: test.c`. Am I doing something wrong here? [1] https://github.com/freebsd/freebsd/tree/master/usr.sbin/rpc.statd Thanks, Mihir From owner-freebsd-net@freebsd.org Fri Sep 20 21:28:45 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA3EAE825C for ; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46Zmzx5Qgxz4g7r for ; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B8675E8259; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B827CE8258 for ; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Zmzx4Jvtz4g7q for ; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6E8773E42 for ; Fri, 20 Sep 2019 21:28:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8KLSjCY093360 for ; Fri, 20 Sep 2019 21:28:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8KLSjWc093349 for net@FreeBSD.org; Fri, 20 Sep 2019 21:28:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240539] tuntap: Getting "ifconfig: ioctl SIOCSIFNAME (set name): File exists" from `ifconfig tap create name tap0` Date: Fri, 20 Sep 2019 21:28:44 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Sep 2019 21:28:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240539 --- Comment #7 from commit-hook@freebsd.org --- A commit references this bug: Author: kevans Date: Fri Sep 20 21:27:42 UTC 2019 New revision: 352565 URL: https://svnweb.freebsd.org/changeset/base/352565 Log: MFC r352246: SIOCSIFNAME: Do nothing if we're not actually changing Instead of throwing EEXIST, just succeed if the name isn't actually changing. We don't need to trigger departure or any of that because there= 's no change from consumers' perspective. PR: 240539 Changes: _U stable/11/ stable/11/sys/net/if.c _U stable/12/ stable/12/sys/net/if.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sat Sep 21 01:34:37 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0B689EFD0F for ; Sat, 21 Sep 2019 01:34:37 +0000 (UTC) (envelope-from hrs@allbsd.org) Received: from mail.allbsd.org (mx.allbsd.org [IPv6:2001:2f0:104:e001::41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature ECDSA (P-384) client-digest SHA384) (Client CN "mail.allbsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZtRZ2l9vz3PxV for ; Sat, 21 Sep 2019 01:34:33 +0000 (UTC) (envelope-from hrs@allbsd.org) Received: from mail-d.allbsd.org ([IPv6:2409:11:a740:4700:58:65ff:fe00:b0b]) (authenticated bits=56) by mail.allbsd.org (8.15.2/8.15.2) with ESMTPSA id x8L1Y7rf094351 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=OK) (Client CN "/CN=mail-d.allbsd.org", Issuer "/C=US/O=Let's+20Encrypt/CN=Let's+20Encrypt+20Authority+20X3"); Sat, 21 Sep 2019 10:34:18 +0900 (JST) (envelope-from hrs@allbsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=allbsd.org; s=20190220; t=1569029668; bh=FgBSrH/Hc3yNKUjIGjP9nSmP6guk4UCPSE0isDZqDDM=; h=Date:To:Cc:From:In-Reply-To:References; b=PwyhF4A6+rSs9RsUuVNJZC0nZmZj+zPxajsOn0Nn5wWR3J6GWr4B0oJ7yWjp4LbTz JMK1Wxq5gvJxn/f38OWLv8LVoIxX6gDlHvcycLZ1L4m6JJdWOFvHyilBXicIGRN71K JjoZNsLufdc9LGm1uKjF6nLRRdHG7Rp37FIYp9Zw= Received: from alph.d.allbsd.org ([IPv6:2409:11:a740:4700:16:ceff:fe34:2700]) by mail-d.allbsd.org (8.15.2/8.15.2) with ESMTPS id x8L1Y2Ag015800 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Sat, 21 Sep 2019 10:34:02 +0900 (JST) (envelope-from hrs@allbsd.org) Received: from localhost (localhost [[UNIX: localhost]]) (authenticated bits=0) by alph.d.allbsd.org (8.15.2/8.15.2) with ESMTPA id x8L1XxWu015796; Sat, 21 Sep 2019 10:34:01 +0900 (JST) (envelope-from hrs@allbsd.org) Date: Sat, 21 Sep 2019 10:33:43 +0900 (JST) Message-Id: <20190921.103343.1733109691136798335.hrs@allbsd.org> To: luthramihir708@gmail.com Cc: freebsd-net@freebsd.org Subject: Re: testing rpc.statd From: Hiroki Sato In-Reply-To: References: X-Old-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-PGPkey-fingerprint: 6C0D 2353 27CF 80C7 901E FDD2 DBB0 7DC6 6F1F 737F X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha512; boundary="--Security_Multipart(Sat_Sep_21_10_33_43_2019_669)--" Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.allbsd.org [IPv6:2001:2f0:104:e001:0:0:0:41]); Sat, 21 Sep 2019 10:34:28 +0900 (JST) X-Rspamd-Queue-Id: 46ZtRZ2l9vz3PxV X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=allbsd.org header.s=20190220 header.b=PwyhF4A6; dmarc=none; spf=pass (mx1.freebsd.org: domain of hrs@allbsd.org designates 2001:2f0:104:e001::41 as permitted sender) smtp.mailfrom=hrs@allbsd.org X-Spamd-Result: default: False [-5.21 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[allbsd.org:s=20190220]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; MV_CASE(0.50)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[allbsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[allbsd.org:+]; RCPT_COUNT_TWO(0.00)[2]; MID_CONTAINS_FROM(1.00)[]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:7514, ipnet:2001:2f0::/32, country:JP]; IP_SCORE(-2.11)[ip: (-8.96), ipnet: 2001:2f0::/32(-4.11), asn: 7514(2.55), country: JP(-0.02)] X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 01:34:37 -0000 ----Security_Multipart(Sat_Sep_21_10_33_43_2019_669)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mihir Luthra wrote in : lu> Although I saw a test.c [1] file in the directory. I was wondering if this lu> complete is the test suite for statd? I tried running `make test` but it lu> said `No such file or dir: test.c`. Am I doing something wrong here? No, it was broken. I fixed test.c in r352570 just now. I do not think it is a complete functionality test but it can check if relevant RPC calls work or not. -- Hiroki ----Security_Multipart(Sat_Sep_21_10_33_43_2019_669)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMcEABMKAC0WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCXYV99w8caHJzQGFsbGJz ZC5vcmcACgkQ27B9xm8fc3+w7wII4273HL0l07v+0kzejYSfrZJJTbcuVkLP+Ljb +HerOKybPszDaS4+HrFaeTq5cwFUbB9Doi1fbEe6I4z58bdxJL8CB1aAgF7LmCbg FJxqh1A42cj5orqxapWWhFVh22zpZq2bCNVBz3UPThStdSEs7zonPuiLNYzvzlHl 50nCN6ZXSxUN =q08Y -----END PGP SIGNATURE----- ----Security_Multipart(Sat_Sep_21_10_33_43_2019_669)---- From owner-freebsd-net@freebsd.org Sat Sep 21 01:40:07 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 44FFAF032C for ; Sat, 21 Sep 2019 01:40:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46ZtYz1Bpkz3QK7 for ; Sat, 21 Sep 2019 01:40:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2901BF032B; Sat, 21 Sep 2019 01:40:07 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28C83F0329 for ; Sat, 21 Sep 2019 01:40:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46ZtYz0HrZz3QK6 for ; Sat, 21 Sep 2019 01:40:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E1A1C6BA3 for ; Sat, 21 Sep 2019 01:40:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8L1e6Gu040496 for ; Sat, 21 Sep 2019 01:40:06 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8L1e6Mc040495 for net@FreeBSD.org; Sat, 21 Sep 2019 01:40:06 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240539] tuntap: Getting "ifconfig: ioctl SIOCSIFNAME (set name): File exists" from `ifconfig tap create name tap0` Date: Sat, 21 Sep 2019 01:40:06 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 01:40:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240539 --- Comment #8 from commit-hook@freebsd.org --- A commit references this bug: Author: kevans Date: Sat Sep 21 01:39:50 UTC 2019 New revision: 352571 URL: https://svnweb.freebsd.org/changeset/base/352571 Log: MFS r352565: SIOCSIFNAME: Do nothing if we're not actually changing Instead of throwing EEXIST, just succeed if the name isn't actually changing. We don't need to trigger departure or any of that because there= 's no change from consumers' perspective. PR: 240539 Approved by: re (gjb) Changes: _U releng/12.1/ releng/12.1/sys/net/if.c --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sat Sep 21 01:41:04 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6852AF044F for ; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46Ztb42Cbqz3QRv for ; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4BE49F044D; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BA3BF044C for ; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Ztb416JGz3QRq for ; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0A6766BDA for ; Sat, 21 Sep 2019 01:41:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8L1f3P2042926 for ; Sat, 21 Sep 2019 01:41:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8L1f3Gt042925 for net@FreeBSD.org; Sat, 21 Sep 2019 01:41:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 240539] tuntap: Getting "ifconfig: ioctl SIOCSIFNAME (set name): File exists" from `ifconfig tap create name tap0` Date: Sat, 21 Sep 2019 01:41:03 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kevans@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable11+ mfc-stable12+ X-Bugzilla-Changed-Fields: bug_status resolution flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 01:41:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240539 Kyle Evans changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Progress |Closed Resolution|--- |FIXED Flags|mfc-stable11?, |mfc-stable11+, |mfc-stable12? |mfc-stable12+ --- Comment #9 from Kyle Evans --- Merged to stable and releng/12.1. Thanks for the report! --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sat Sep 21 15:20:04 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C8A791272F0 for ; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46bDm44N0mz4dQ1 for ; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 946541272EF; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 942F91272EE for ; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46bDm43RTtz4dQ0 for ; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 58A6C181A4 for ; Sat, 21 Sep 2019 15:20:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8LFK4t1053762 for ; Sat, 21 Sep 2019 15:20:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8LFK4pK053761 for net@FreeBSD.org; Sat, 21 Sep 2019 15:20:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Sat, 21 Sep 2019 15:20:03 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 15:20:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #17 from Armin Gruner --- Attached reverse patch fixes the problem, GENERIC compiles (under 12.0-RELE= ASE) -------------------------------------------------------------- >>> Kernel build for GENERIC completed on Sat Sep 21 17:13:53 CEST 2019 -------------------------------------------------------------- --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Sep 21 15:21:25 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7AF201273D3 for ; Sat, 21 Sep 2019 15:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46bDnd2NS4z4dkY for ; Sat, 21 Sep 2019 15:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 51B241273D1; Sat, 21 Sep 2019 15:21:25 +0000 (UTC) Delivered-To: net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 517771273D0 for ; Sat, 21 Sep 2019 15:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46bDnd0bCbz4dkT for ; Sat, 21 Sep 2019 15:21:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id EBFEA18206 for ; Sat, 21 Sep 2019 15:21:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8LFLOLf061286 for ; Sat, 21 Sep 2019 15:21:24 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8LFLOd7061285 for net@FreeBSD.org; Sat, 21 Sep 2019 15:21:24 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 233952] if_jme: Does not send/receive packets after 11.2 to 12.0 upgrade Date: Sat, 21 Sep 2019 15:21:25 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: ag-freebsd@muc.de X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 15:21:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233952 --- Comment #18 from Armin Gruner --- Created attachment 207686 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D207686&action= =3Dedit Fixes if_jme regression under 12.0-RELEASE --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sat Sep 21 23:01:26 2019 Return-Path: Delivered-To: freebsd-net@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C20B5E9239 for ; Sat, 21 Sep 2019 23:01:26 +0000 (UTC) (envelope-from hunreal@gmail.com) Received: from mail-qk1-x736.google.com (mail-qk1-x736.google.com [IPv6:2607:f8b0:4864:20::736]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46bR0P44ZDz44NN for ; Sat, 21 Sep 2019 23:01:25 +0000 (UTC) (envelope-from hunreal@gmail.com) Received: by mail-qk1-x736.google.com with SMTP id 4so11319738qki.6 for ; Sat, 21 Sep 2019 16:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=weVX6c1eT3fLf0FlCE6s62BJY3TAmWPr056VR2kxZ4M=; b=nVaE/dqIKeqEB+jB9pojh0NbapZ6bPxHGaqrlyqs3PpglA8je9ahLCNQ9woPVZJsx7 li+HF7RXFpTy0RJCnzkEWklHvMnI+cBI+UcP1PN0ojIVs8TNUdK5TvQwVXa1AVOD3aky Hj19ndqxhpR5gOMjYcKTGqYC+fAtv2uf89F+WFt+M6iu65Tn/jZ0XiCyAg7vPV7bxTya l2oF1M6o8bdbc1Fgrktsj5B0YkLJ/7pv1bUEuCbXaeBvS1sHyDbBEEtk+/4akpebP8Dy wtmMuw3HSkiDF21JEOMIXiJunHCoirez2DlzmIx75jzBbNeuPPDuSVftl06sGc5iHZz/ DXxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=weVX6c1eT3fLf0FlCE6s62BJY3TAmWPr056VR2kxZ4M=; b=J+VLTAoX7euX7//hQQF+V9vvEqjwBPNdjvD0u97DGUWmg2JOCkWYV+uXlYtMTAN8UK tvOzcVQ+svlQth7cFXqwsBpzg1wOmSviAQwh2sqRFoNLqrXMn8JUbWCUrTv66ahxKabE SHFFumOagtJV+Nww/jVdndjPGz+XQBBdPoiPxDZKMvy91VMxFEYkfpNlQqQXSKjyfbPQ 7Eb0Q2Z3gqxnI8/RRAnA0pobp1YBjEppQubEUmDhngMyEFuAeayBe7b/AhhZfxZNE1k4 PKPvOR+l47kjF5yIDtvfs1ts9BzdkeUQ13OY7etQIYF+qdVDAMEnXt6GpWhktArVzCaA xorA== X-Gm-Message-State: APjAAAXmRsMgJRywtNg1j52nZV9eS9p2oItUvNEjJqfdmYTV2gU9efRu 0C8hQqPeoXh1jrXOamKlMP43vrmA0AcGW8azMl7GzpV4Yb1M X-Google-Smtp-Source: APXvYqxPWX+wQOuo20B5Z0TWzeQUjgyOemEOXxzQVTkDv8kc/+e9tur8DvYRyPCwJ2KxTtB345jXC/1x2jl+jR5nEKs= X-Received: by 2002:a37:4802:: with SMTP id v2mr10639754qka.496.1569106883679; Sat, 21 Sep 2019 16:01:23 -0700 (PDT) MIME-Version: 1.0 From: hshh Date: Sun, 22 Sep 2019 07:00:47 +0800 Message-ID: Subject: BBR patch on latest src, build failed. To: freebsd-net@freebsd.org X-Rspamd-Queue-Id: 46bR0P44ZDz44NN X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=nVaE/dqI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of hunreal@gmail.com designates 2607:f8b0:4864:20::736 as permitted sender) smtp.mailfrom=hunreal@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-net@freebsd.org]; TO_DN_NONE(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(0.00)[ip: (-9.38), ipnet: 2607:f8b0::/32(-2.64), asn: 15169(-2.20), country: US(-0.05)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[6.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Sep 2019 23:01:26 -0000 Hi all, I patched D21582.id62213.diff to latest head src that revision 352587, kernel build failed. According to previous mail, I can build the kernel successfully with revision 352483. OS is 13.0-CURRENT amd64. Kernel config file, include GENERIC-NODEBUG ident hshh makeoptions WITH_EXTRA_TCP_STACKS=1 options TCPHPTS options RATELIMIT The error log, --- tcp_bbr.ko.full --- ld -m elf_x86_64_fbsd -d -warn-common --build-id=sha1 -d -warn-common --build-id=sha1 -d -warn-common --build-id=sha1 -d -warn-common --build-id=sha1 -r -d -o tcp_bbr.ko.full bbr.o sack_filter.o rack_bbr_common.o bbr.o sack_filter.o rack_bbr_common.o bbr.o sack_filter.o rack_bbr_common.o bbr.o sack_filter.o rack_bbr_common.o ld: error: duplicate symbol: __tcp_bbr >>> defined at bbr.c >>> bbr.o:(__tcp_bbr) >>> defined at bbr.c >>> bbr.o:(.data+0x8) .... Some messages similar above. -- @hshh