Date: Sun, 30 Jun 2019 04:09:19 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 238887] devel/py-llfuse: fix build with GCC-based architectures Message-ID: <bug-238887-21822-iFaEiZyfXd@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-238887-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-238887-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238887 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |python@FreeBSD.org Status|New |Open Assignee|ports-bugs@FreeBSD.org |pkubaj@FreeBSD.org Keywords| |needs-patch, needs-qa --- Comment #2 from Kubilay Kocak <koobs@FreeBSD.org> --- Reporter is committer, assign accordingly @Piotr -Werror should be patched out here too (it shouldn't be used/enabled= in packaged/distributed/released code. setup.py does the following: DEVELOPER_MODE =3D os.path.exists(os.path.join(basedir, 'MANIFEST.in')) if DEVELOPER_MODE: print('found MANIFEST.in, running in developer mode') <snip> compile_args.append('-Werror') compile_args.append('-Wfatal-errors') The conditional for DEVELOPER_MODE is too widely-scoped, as source distributions (sdists) are released to end-users, and the presence of a MANIFEST.in shouldn't mean DEVELOPER_MODE. A slightly better form might be to check for the presence of a git checkout, though this is also problematic, as users can depend on packages via their = git URL's.=20 The check should probably be an explicit opt-in via the presence of an environment variable DEVELOPER_MODE=3Dyes or similar. Either way, I'd patch the conditional to be False, along with the patch provided fixing the warning. If you can, please report this '-Werror should be opt-in, not based on MANIFEST.in' issue upstream, with a PR if you can manage it Note also, both the build (warning=3Derror) fix, and the -Werror removal ar= e: Approved by: portmgr (blanket(s): build fix, ports compliance) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-238887-21822-iFaEiZyfXd>