Date: Sun, 24 Mar 2019 10:44:18 +0900 From: Jason Tubnor <jtubnor@gmail.com> To: Chuck Tuffli <chuck@freebsd.org> Cc: "freebsd-virtualization@freebsd.org" <freebsd-virtualization@freebsd.org> Subject: Re: emulated PCI device BAR size Message-ID: <CACLnyCJuWmjbp8GcudtEPFZRO5Bo_BpUVH-43RuuPTMOOjfDmA@mail.gmail.com> In-Reply-To: <CAKAYmML9jAc4WfJ8NP9iiFWY4R7DgU9SKyF_ZiNxt5FvSXQfhA@mail.gmail.com> References: <CAKAYmMKd5o=f8Z5uzF6pQnZqWLzRLAL3U7iM5inuodQs92pudA@mail.gmail.com> <CAKAYmML9jAc4WfJ8NP9iiFWY4R7DgU9SKyF_ZiNxt5FvSXQfhA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun., 24 Mar. 2019, 6:35 am Chuck Tuffli, <chuck@freebsd.org> wrote: > On Mon, Mar 18, 2019 at 10:15 AM Chuck Tuffli <chuck@freebsd.org> wrote: > > > > > So my question is how to best fix this. The easiest would be to add a > > check to the BAR size calculation in pci_nvme.c along the lines of: > > #define NVME_MMIO_SPACE_MIN (1 << 14) > > ... > > pci_membar_sz = MAX( <calculation based on queue count>, > > NVME_MMIO_SPACE_MIN); > > I went down this route and have a patch up for review > (https://reviews.freebsd.org/D19676) if anyone is interested. > > --chuck > I've built and installed this patch on FreeBSD 12.0-STABLE-amd64-20190314-r345117. Testing occurred against Windows 10 Pro guest with a presented NVMe bhyve device and all IO transactions worked without issue. Can this be committed to head and MFD to 12-STABLE. Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACLnyCJuWmjbp8GcudtEPFZRO5Bo_BpUVH-43RuuPTMOOjfDmA>