Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Feb 2019 05:40:29 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r343947 - stable/12/sys/kern
Message-ID:  <201902100540.x1A5eTHH058807@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Sun Feb 10 05:40:28 2019
New Revision: 343947
URL: https://svnweb.freebsd.org/changeset/base/343947

Log:
  MFC r343724:
  Do not call PHOLD() while owning the allproc_lock sx.

Modified:
  stable/12/sys/kern/kern_proc.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/kern/kern_proc.c
==============================================================================
--- stable/12/sys/kern/kern_proc.c	Sat Feb  9 23:19:33 2019	(r343946)
+++ stable/12/sys/kern/kern_proc.c	Sun Feb 10 05:40:28 2019	(r343947)
@@ -3122,8 +3122,8 @@ allproc_loop:
 			PROC_UNLOCK(p);
 			continue;
 		}
-		_PHOLD(p);
 		sx_xunlock(&allproc_lock);
+		_PHOLD(p);
 		r = thread_single(p, SINGLE_ALLPROC);
 		if (r != 0)
 			restart = true;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201902100540.x1A5eTHH058807>