From owner-freebsd-arch@freebsd.org Wed Jun 17 04:19:34 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B9428342113 for ; Wed, 17 Jun 2020 04:19:34 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49msKK4tHbz4FFY for ; Wed, 17 Jun 2020 04:19:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2d.google.com with SMTP id g7so402148qvx.11 for ; Tue, 16 Jun 2020 21:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=2TDW1W8VBN/E1FHoP4cQnibsRbEc8lIxBGR0S09gYu0=; b=TrDwbn0yNxzq9Iwo5Ql6gkQHPibP7g8GfZ1vPDCEUSYlUYlPgqoe3e9CKEnEyPFpHe jwuQHdvLr6/zBxkSecMAe/NU5c7J1sZVX3yEVq61EXlLYFaXbuQRMFXV4zdl17IJyOiD 8kzFp6RwvhxLmQcV/kysbI6X+2mVKdMhdGjzlLER3LrBu6g+p1uaiM/lYm6GzpnMEBAz +vURCilk0Sx5aP+rraRe2Ty26rtM4myFYTrmaj3BpFp08VPpRGydEyX3fQQMR5UaHefM YITddu9Ywvn6Z7LfcClmV0N4fa+YUW3qsq7cMD1WjqJN0kItWNhZ1O1W5xrO5VzgO8ol uY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2TDW1W8VBN/E1FHoP4cQnibsRbEc8lIxBGR0S09gYu0=; b=fTilg98OJEFza4qBKyMfQ3MkrVj34Kubfr4qQRe7idgvID7ou8ZzpiWp1c8AZqrMxQ 0EJXCBfqyHNaNU6Ij43fGObOz6I1qy1JhF35acCeWC5CWGR+oonETYO+nWR5aX11jF3U DhRcynbABXHotvfXS+cPaHt6jAVjszkrMw/fcv6pMoIioY4IL4qrhYWFE8EhXRBOgsoX 9pev8eey/bnMyjLtyJuKKt+xSNqojKiUvG/kKDk6HA50cpiGZ8QETWr4iRUVgOy0Moiq 56z7jo6zLOxuKNLSSB2EQEAyEVlD5E+gEBipLx/qe99UzUKRwwwb9P1LlblHxM73okvT yo1Q== X-Gm-Message-State: AOAM530Ks16tWUu2zX1YIxGh20udRB6MtbElz/sAzqcN/YI3yoOame/g lT5SpTy9Sc2kUCUTKWHAzozyLln2IrUR3QVHpap7T/wBfW1j0Q== X-Google-Smtp-Source: ABdhPJz3hglzzZwOwRHXs74nc3na+FzzXWH9rWsqyn0hf2uNGNC6uw9pjgqhoKi5WIN9ktZqC9RRjlu6tfhV6Gvv4OU= X-Received: by 2002:a0c:f9c3:: with SMTP id j3mr5842716qvo.125.1592367572274; Tue, 16 Jun 2020 21:19:32 -0700 (PDT) MIME-Version: 1.0 From: Warner Losh Date: Tue, 16 Jun 2020 22:19:21 -0600 Message-ID: Subject: Style Update: Don't discourage nested scope variable declaration To: "freebsd-arch@freebsd.org" X-Rspamd-Queue-Id: 49msKK4tHbz4FFY X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=TrDwbn0y; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f2d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-0.47 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.68)[-0.682]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.32)[-0.316]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_SHORT(0.53)[0.531]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2d:from]; TO_DN_EQ_ADDR_ALL(0.00)[]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Jun 2020 04:19:34 -0000 Greetings, https://reviews.freebsd.org/D25312 This removes the rule that strongly discourages declaring variables in nested scopes. Times have moved on from the day when this prevented bugs due to variable shadowing. We have better tools today, and this is more the style in the rest of the industry. Make style.9 silent about the matter, leaving it to the discretion of developers and the usual custom of caution when introducing this to existing files. Comments? Please go to the review.... Warner