From nobody Tue Jul 27 21:05:14 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 13BD012AE2E3 for ; Tue, 27 Jul 2021 21:05:17 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZ8Ss04Pbz53B4 for ; Tue, 27 Jul 2021 21:05:17 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from ice.alameda.xse.com (unknown [IPv6:2600:1700:a570:e20:f2ad:4eff:fe09:150e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id AB5DB2AF10 for ; Tue, 27 Jul 2021 21:05:16 +0000 (UTC) (envelope-from leres@freebsd.org) From: Craig Leres To: freebsd-hackers@freebsd.org Subject: pkg/poudriere: dangling symlink to pkg.pkg.sig Message-ID: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> Date: Tue, 27 Jul 2021 14:05:14 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N For the last few days, approximately corresponding to when the pkg port upgraded to 1.17.0, the poudriere build process has been creating a dangling symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to github.com/freebsd/pkg did not prove useful; does anyone understand what broke (and how to fix it)? I ran into this because I use a cron job to archive poudriere build trees; the job does a diff -r of the latest pkg tree vs. the most recent archived tree (to decide if the new tree is worth archiving). Craig iron 32 # pwd /usr/local/poudriere/data/packages/12release-current-patched iron 33 # find . -name '*.sig' ./.real_1627222758/Latest/pkg.txz.sig iron 34 # ls -l .real_1627222758/Latest/pkg.txz.sig lrwxr-xr-x 1 root wheel 11 Jul 25 06:01 .real_1627222758/Latest/pkg.txz.sig -> pkg.pkg.sig iron 35 # : < .real_1627222758/Latest/pkg.txz.sig .real_1627222758/Latest/pkg.txz.sig: No such file or directory. From nobody Wed Jul 28 00:55:59 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E8BE212BB09A; Wed, 28 Jul 2021 00:56:16 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZFbM6x45z3LG3; Wed, 28 Jul 2021 00:56:15 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-lj1-x231.google.com with SMTP id a7so963440ljq.11; Tue, 27 Jul 2021 17:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=DCZeM1CKwiypSoWOdUXjCSR2nfKyUeRVNx+WMtfsmio=; b=pGBqprsQm2KD6+yThBleYUPrQ0bQ95CgzloyHs42ke5HgzwXAx0dDgv92MEUCuwri2 zPVJx+vSfpAgXS4qr8PmD/9gY7wrWl4JY3F24DI+jfkWKbUcnRDUpvkUVI8X8Vb01fVc hOGmBj6U9jicEr2+/7PEhWNwx5OUz6FBhdizRYK2wpfryqBe3mgbxKDmXGy6JiMCNxr3 XJI9Xq6QWMDOorKooOn9kP1Nt2YQFJVrkJN8GoH4M1KIFyUkefl+eOp7ezZzxX4E9rLt ABHQ0zUXolgE732sjcf2ADjqbVexW/Aq+yaO1vxv7qGZW6ZsBXNeIhT/WKYKTKYyzOaj +YAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:mime-version :content-transfer-encoding; bh=DCZeM1CKwiypSoWOdUXjCSR2nfKyUeRVNx+WMtfsmio=; b=ZQ6GlLdOBaCP9qwL0wBBBtBfgM1QcMdvsJqDHuevRpOMCV8gxPtrvDxEFPdVAygJli KbclLZbszoydKSdX7MFcw5ZVgcS4w3bS+0Q9uwzmsR6B/CZnvSElLTPocekVr3pDIJTK 1ugiWIlPeLuCi4EsWkEuaLCHCQ0lEym/8dH2S9yqrLTgrylzsmTis1Mh/gHN4PfG6ija XJAV0Bjmg8069EfiZUimJpG2+B2ZB/+sgO7sQnOjk5a8pDsGG/QXBaw8E1iL18nV3IE5 qSM1TzHJFtYqo/FMpT/tkDW9qc72WjTSJkNHo9gNPscoCtbvshZevZn4ePIoBrlvkw2w WByw== X-Gm-Message-State: AOAM531EJ6h6h2SOoqx2bHClEtR3FazECvR9o6x0P6RfZ53Pkh8DNuQU /3ZLUK6rhkWVTrlqW2Usm0IxjWVASdc= X-Google-Smtp-Source: ABdhPJx6a0Yy2V2S7WAt6b16weuzJh/apsbvh3VSdUXrlIUgtxZVrrYmj/530tf59eKsCWt2w5Kc9Q== X-Received: by 2002:a2e:a90b:: with SMTP id j11mr17507856ljq.338.1627433769211; Tue, 27 Jul 2021 17:56:09 -0700 (PDT) Received: from rimwks.local ([176.99.169.245]) by smtp.gmail.com with ESMTPSA id z13sm432865lfd.49.2021.07.27.17.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 17:56:08 -0700 (PDT) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Wed, 28 Jul 2021 03:55:59 +0300 To: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org Cc: Rozhuk Ivan Subject: pthread_mutex_lock(), EDEADLK and thread ID Message-ID: <20210728035559.3b885fb9@rimwks.local> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4GZFbM6x45z3LG3 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pGBqprsQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rozhukim@gmail.com designates 2a00:1450:4864:20::231 as permitted sender) smtp.mailfrom=rozhukim@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::231:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-current]; FREEMAIL_CC(0.00)[gmail.com] X-ThisMailContainsUnwantedMimeParts: N Hi! We have some product based on FreeBSD 12.2 that running in different places and environments, more than 5 years. At one place we got EDEADLK some times then calling pthread_mutex_lock(). This happen to often: 1-4 times per 10 minutes. Code designed to call abort() and generate coredump. So we mostly sure that this was not happen in other places in past. I know that we run as VmWare guest and can ask more details. In lib/libthr/thread/thr_mutex.c ... static int mutex_lock_sleep(struct pthread *curthread, struct pthread_mutex *m, const struct timespec *abstime) { uint32_t id, owner; int count, ret; id = TID(curthread); if (PMUTEX_OWNER_ID(m) == id) return (mutex_self_lock(m, abstime)); .... mutex_self_lock() may return EDEADLK for PTHREAD_MUTEX_ERRORCHECK mutex type, which is default. Is it possible that "id = TID(_get_curthread());" some how changed to ID some other thread that lock mutex in past? From nobody Wed Jul 28 13:05:17 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 37EA912BCEFC; Wed, 28 Jul 2021 13:05:27 +0000 (UTC) (envelope-from alfadev@protonmail.com) Received: from mail-4324.protonmail.ch (mail-4324.protonmail.ch [185.70.43.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "SwissSign Server Gold CA 2014 - G22" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GZYmk2Y1Jz3Bsm; Wed, 28 Jul 2021 13:05:26 +0000 (UTC) (envelope-from alfadev@protonmail.com) Date: Wed, 28 Jul 2021 13:05:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1627477519; bh=3+SeB5N6sUPqqjakBASjZmbHAsbSdwMJThUMjZhGoLo=; h=Date:To:From:Reply-To:Subject:From; b=PKkdPiAgq+YpLFzDQ10tbE49sMyfwXn9hrbJTUhi11qgbnwFYmiDkZA7mIf9OqoDd G/cWLrTbB0TD6IHv0oOzdyLq04cAZiugFIf5scswlF3jKVYqasjhy4xbHEKOs2VD3C 6oSQ1K+4oQJCr5W2uSNbRwSmksS0Nt1iVESyPpJY= To: "freebsd-hackers@FreeBSD.org" , "freebsd-ipfw@FreeBSD.org" Reply-To: alfadev Subject: is there a way to Port DragonflyBSD's IPFW3 to FreeBSD Message-ID: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_AMqN3XX1RVdK41m0VmNydYtiaFg8TlwDEY2n51GFs" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Rspamd-Queue-Id: 4GZYmk2Y1Jz3Bsm X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protonmail.com header.s=protonmail header.b=PKkdPiAg; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (mx1.freebsd.org: domain of alfadev@protonmail.com designates 185.70.43.24 as permitted sender) smtp.mailfrom=alfadev@protonmail.com X-Spamd-Result: default: False [0.10 / 15.00]; HAS_REPLYTO(0.00)[alfadev@protonmail.com]; R_SPF_ALLOW(-0.20)[+ip4:185.70.43.0/24:c]; FREEMAIL_FROM(0.00)[protonmail.com]; MIME_BASE64_TEXT_BOGUS(1.00)[]; DKIM_TRACE(0.00)[protonmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[protonmail.com,quarantine]; MIME_BASE64_TEXT(0.10)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[protonmail.com]; ASN(0.00)[asn:62371, ipnet:185.70.43.0/24, country:CH]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[protonmail.com:s=protonmail]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(1.00)[0.998]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_REPLYTO(0.00)[protonmail.com]; HAS_PHPMAILER_SIG(0.00)[]; TO_DN_EQ_ADDR_ALL(0.00)[]; RWL_MAILSPIKE_VERYGOOD(0.00)[185.70.43.24:from]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-ipfw] Reply-To: alfadev@protonmail.com From: alfadev via freebsd-hackers X-Original-From: alfadev X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: Y This is a multi-part message in MIME format. --b1_AMqN3XX1RVdK41m0VmNydYtiaFg8TlwDEY2n51GFs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGksCkkgYW0gcGxhbm5pbmcgdG8gbW92ZSBvbiBJUEZXIGZyb20gUEYgaSBoYXZlIG1lbnRpb25l ZCB3aHkgaW4gdGhpc1t0b3BpYy5dKGh0dHBzOi8vZm9ydW1zLmZyZWVic2Qub3JnL3RocmVhZHMv aG93LXRvLWNoYW5nZS1wYWNrZXQtdHJhdmVyc2FsLW9yZGVyLWluLWZyZWVic2QtaXBmdy1hbmQt cGYtZmlyZXdhbGxzLWluLWtlcm5lbC1sZXZlbC44MTQ4Mi8pCgpEcmFnb25mbHlCU0QncyBJUEZX MyBoYXMgYmVsb3cgcHJvcyB3aGljaCBhcmUgSVBGVzIgaGFzIG5vdAoKMSlMb2FkLWJhbGFuY2lu Zwpmb3J3YXJkLW9wdGlvbiBjYW4gYmUgYHJvdW5kLXJvYmluJyBvciBgc3RpY2t5Jy4KCkNvZGU6 CgppcGZ3MyBhZGQgZm9yd2FyZCAxOTIuMTY4LjEuMTo4MCwxOTIuMTY4LjEuMjo4MCByb3VuZC1y b2JpbiB0Y3AgZnJvbSAuLi4uCgpBYm92ZSBleGFtcGxlIGNhbiBmb3J3YXJkIHRoZSB0cmFmZmlj IHRvIDIgZGVzdGluYXRpb24gaW4gcm91bmQtcm9iaW4uCgoyKVN0YXRlcyBjYW4gYmUgYWRkZWQv ZGVsZXRlZCB1c2luZyB0aGUgaXBmdzMgdXRpbGl0eS4KCkNvZGU6CgppcGZ3MyBzdGF0ZSBkZWxl dGUgcnVsZW51bQoKMylTdGF0ZXMgY2FuIGJlIGV4cGlyZSBhZnRlciBzb21lIHRpbWUKCkNvZGU6 CgppcGZ3MyBzdGF0ZSBhZGQgcnVsZSAxMDAwIHVkcCAxOTIuMTY4LjEuMTAwOjAgOC44LjguODo1 MyBleHBpcnkgNjAwCgouLi4KClRoZXNlIGFyZSBzb21lIGhhcmQgcHJvYmxlbXMgdG8gbWUgd2hl biBpIHRyeSB0byBjb21wbGV0ZWx5IG1vdmUgb24gSVBGVy4KU28gaXMgdGhlcmUgYSB3YXkgdG8g cG9ydCBJUEZXMyB0byBGcmVlQlNELgpUaGFua3MgZm9yIGFueSBoZWxwIGFuZCBzdWdnZXN0aW9u cy4u --b1_AMqN3XX1RVdK41m0VmNydYtiaFg8TlwDEY2n51GFs-- From nobody Thu Jul 29 07:41:07 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D2EFE12BC256 for ; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gb2X65dsqz3Q75; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 964DEC364; Thu, 29 Jul 2021 07:41:10 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id CCFF0428E6; Thu, 29 Jul 2021 09:41:07 +0200 (CEST) Date: Thu, 29 Jul 2021 09:41:07 +0200 From: Baptiste Daroussin To: Craig Leres Cc: freebsd-hackers@freebsd.org Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig Message-ID: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Tue, Jul 27, 2021 at 02:05:14PM -0700, Craig Leres wrote: > > For the last few days, approximately corresponding to when the pkg port > upgraded to 1.17.0, the poudriere build process has been creating a dangling > symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to > github.com/freebsd/pkg did not prove useful; does anyone understand what > broke (and how to fix it)? > > I ran into this because I use a cron job to archive poudriere build trees; > the job does a diff -r of the latest pkg tree vs. the most recent archived > tree (to decide if the new tree is worth archiving). > > Craig > I told you to have a look at the commit in the ports tree in the github issue, which apparently you did not. In particular: https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=ec2764d5ec4933f52cb0718663f60f1e1b1eed7f This is not done by pkg, so this is not a pkg bug, neither done by poudriere, this is done by the ports tree, this is a transition so that when someone is signing his own repo, he has valid signature for FreeBSD 12.2 and 11.4 which are the 2 systems which do not know about .pkg extention for the bootstrap of pkg. The safest way to do that was to create a dead symlink so the when pkg.pkg.sig appears the symlink is not dead anymore and bootstrap signature can be checked. 1 improvements that can be done, (I don't have time to do it right now: limit this to only be created on FreeBSD 12 and 11, limit it to cluster package building) Best regards, Bapt From nobody Thu Jul 29 09:11:23 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 734D312A9D95 for ; Thu, 29 Jul 2021 09:11:25 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gb4XF2hw5z3nVn; Thu, 29 Jul 2021 09:11:25 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-449.fritz.box (p200300cd5f2742001d65c9b40f93eff9.dip0.t-ipconnect.de [IPv6:2003:cd:5f27:4200:1d65:c9b4:f93:eff9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id C36CFCAE3; Thu, 29 Jul 2021 09:11:24 +0000 (UTC) (envelope-from se@freebsd.org) To: Baptiste Daroussin Cc: freebsd-hackers@freebsd.org, Craig Leres References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> From: Stefan Esser Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig Message-ID: Date: Thu, 29 Jul 2021 11:11:23 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 In-Reply-To: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EMfT7LllNLLAwesktw1iiqX9XjeYWpdH0" X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EMfT7LllNLLAwesktw1iiqX9XjeYWpdH0 Content-Type: multipart/mixed; boundary="tn1CitlzSJyovAiXiGQNWWfUmwMtFz05U"; protected-headers="v1" From: Stefan Esser To: Baptiste Daroussin Cc: freebsd-hackers@freebsd.org, Craig Leres Message-ID: Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> In-Reply-To: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> --tn1CitlzSJyovAiXiGQNWWfUmwMtFz05U Content-Type: multipart/mixed; boundary="------------57853282F30EF0AE3ADE78E3" Content-Language: de-DE This is a multi-part message in MIME format. --------------57853282F30EF0AE3ADE78E3 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 29.07.21 um 09:41 schrieb Baptiste Daroussin: > On Tue, Jul 27, 2021 at 02:05:14PM -0700, Craig Leres wrote: >> >> For the last few days, approximately corresponding to when the pkg por= t >> upgraded to 1.17.0, the poudriere build process has been creating a da= ngling >> symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to >> github.com/freebsd/pkg did not prove useful; does anyone understand wh= at >> broke (and how to fix it)? >> >> I ran into this because I use a cron job to archive poudriere build tr= ees; >> the job does a diff -r of the latest pkg tree vs. the most recent arch= ived >> tree (to decide if the new tree is worth archiving). >> >> Craig >> > I told you to have a look at the commit in the ports tree in the github= issue, > which apparently you did not. >=20 > In particular: > https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=3Dec2764d5ec493= 3f52cb0718663f60f1e1b1eed7f >=20 > This is not done by pkg, so this is not a pkg bug, neither done by poud= riere, > this is done by the ports tree, this is a transition so that when someo= ne is > signing his own repo, he has valid signature for FreeBSD 12.2 and 11.4 = which are > the 2 systems which do not know about .pkg extention for the bootstrap = of pkg. >=20 > The safest way to do that was to create a dead symlink so the when pkg.= pkg.sig > appears the symlink is not dead anymore and bootstrap signature can be = checked. >=20 > 1 improvements that can be done, (I don't have time to do it right now:= limit > this to only be created on FreeBSD 12 and 11, limit it to cluster packa= ge > building) The attached patch limits the creation of the symlink to FreeBSD versions before 13. Inline version for easy review (white-space might be damaged): diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk index c9532fa5af2e..1a942e8abc0c 100644 --- a/Mk/bsd.port.mk +++ b/Mk/bsd.port.mk @@ -3461,7 +3461,10 @@ ${PKGLATESTFILE}: ${PKGFILE} ${PKGLATESTREPOSITORY= } ${INSTALL} -l rs ${PKGFILE} ${PKGLATESTFILE} .if !defined(_PKG_TRANSITIONING_TO_NEW_EXT) -_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDLATESTFILE} ${PKGOLDSIGFILE} +_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDLATESTFILE} +.if ${OSVERSION} < 1300000 +_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDSIGFILE} +.endif ${PKGOLDLATESTFILE}: ${PKGOLDFILE} ${PKGLATESTREPOSITORY} ${INSTALL} -l rs ${PKGOLDFILE} ${PKGOLDLATESTFILE} Do you approve the commit? Regards, STefan --------------57853282F30EF0AE3ADE78E3 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pkg-sig.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pkg-sig.diff" ZGlmZiAtLWdpdCBhL01rL2JzZC5wb3J0Lm1rIGIvTWsvYnNkLnBvcnQubWsKaW5kZXggYzk1 MzJmYTVhZjJlLi4xYTk0MmU4YWJjMGMgMTAwNjQ0Ci0tLSBhL01rL2JzZC5wb3J0Lm1rCisr KyBiL01rL2JzZC5wb3J0Lm1rCkBAIC0zNDYxLDcgKzM0NjEsMTAgQEAgJHtQS0dMQVRFU1RG SUxFfTogJHtQS0dGSUxFfSAke1BLR0xBVEVTVFJFUE9TSVRPUll9CiAJJHtJTlNUQUxMfSAt bCBycyAke1BLR0ZJTEV9ICR7UEtHTEFURVNURklMRX0KIAogLmlmICFkZWZpbmVkKF9QS0df VFJBTlNJVElPTklOR19UT19ORVdfRVhUKQotX0VYVFJBX1BBQ0tBR0VfVEFSR0VUX0RFUCs9 CSR7UEtHT0xETEFURVNURklMRX0gJHtQS0dPTERTSUdGSUxFfQorX0VYVFJBX1BBQ0tBR0Vf VEFSR0VUX0RFUCs9CSR7UEtHT0xETEFURVNURklMRX0KKy5pZiAke09TVkVSU0lPTn0gPCAx MzAwMDAwCitfRVhUUkFfUEFDS0FHRV9UQVJHRVRfREVQKz0JJHtQS0dPTERTSUdGSUxFfQor LmVuZGlmCiAKICR7UEtHT0xETEFURVNURklMRX06ICR7UEtHT0xERklMRX0gJHtQS0dMQVRF U1RSRVBPU0lUT1JZfQogCSR7SU5TVEFMTH0gLWwgcnMgJHtQS0dPTERGSUxFfSAke1BLR09M RExBVEVTVEZJTEV9Cg== --------------57853282F30EF0AE3ADE78E3-- --tn1CitlzSJyovAiXiGQNWWfUmwMtFz05U-- --EMfT7LllNLLAwesktw1iiqX9XjeYWpdH0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmECcLsFAwAAAAAACgkQR+u171r99UQQ /gf8DNxxbe8oeIWsSRWHUVHgR/kh7X/+dkDk3314DW8c7qxQDRyoR5wuynQYNw3ykiqT4DjZQ0NU znYiwEvGdeKFb5mY1754Tv64lgTbxWQoETywJ2Em1CTglR/D7+4ClBXduSkCIpqNR0KSWr5PbTHF hIlc0+UvUjuaBmpVAsn0thjBSXHNlt3ka9jF+KgKaCoFAR1SN7BMOaF+KDcmOsbHTeJ2xhEe/w9+ HX1dvWF1vEbZDJ/QSmfUu8iKDyKXH5jU+ZtzYgjqfFFmC0a4Z40+rZNkiae+ldZNJ2llhGV4kuuh D3Crv9tU3uDxZPb57bzsDmIZg6FN0RXcaWQqlzWC2A== =zKkg -----END PGP SIGNATURE----- --EMfT7LllNLLAwesktw1iiqX9XjeYWpdH0-- From nobody Thu Jul 29 09:18:19 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 957A312AA9FC for ; Thu, 29 Jul 2021 09:18:21 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gb4hF3cgpz3ptk; Thu, 29 Jul 2021 09:18:21 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-449.fritz.box (p200300cd5f2742001d65c9b40f93eff9.dip0.t-ipconnect.de [IPv6:2003:cd:5f27:4200:1d65:c9b4:f93:eff9]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id D970EC868; Thu, 29 Jul 2021 09:18:20 +0000 (UTC) (envelope-from se@freebsd.org) From: Stefan Esser To: Baptiste Daroussin Cc: freebsd-hackers@freebsd.org, Craig Leres References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig [inline patch fixed] Message-ID: <6c707473-9e1d-8ca9-6cd7-af21774a9f74@freebsd.org> Date: Thu, 29 Jul 2021 11:18:19 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 In-Reply-To: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tJ5uNZZEx7gEmGulTrx6qvSjoUSwCakK5" X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tJ5uNZZEx7gEmGulTrx6qvSjoUSwCakK5 Content-Type: multipart/mixed; boundary="pBVNSJMH52CyARz4dCSLASjP4ZZun32lP"; protected-headers="v1" From: Stefan Esser To: Baptiste Daroussin Cc: freebsd-hackers@freebsd.org, Craig Leres Message-ID: <6c707473-9e1d-8ca9-6cd7-af21774a9f74@freebsd.org> Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig [inline patch fixed] References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> In-Reply-To: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> --pBVNSJMH52CyARz4dCSLASjP4ZZun32lP Content-Type: multipart/mixed; boundary="------------E582BDCAAC691F7F19DCCA94" Content-Language: en-US This is a multi-part message in MIME format. --------------E582BDCAAC691F7F19DCCA94 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [Resending, the inline diff had significant white-space issues ...] Am 29.07.21 um 09:41 schrieb Baptiste Daroussin: > On Tue, Jul 27, 2021 at 02:05:14PM -0700, Craig Leres wrote: >> >> For the last few days, approximately corresponding to when the pkg por= t >> upgraded to 1.17.0, the poudriere build process has been creating a da= ngling >> symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to >> github.com/freebsd/pkg did not prove useful; does anyone understand wh= at >> broke (and how to fix it)? >> >> I ran into this because I use a cron job to archive poudriere build tr= ees; >> the job does a diff -r of the latest pkg tree vs. the most recent arch= ived >> tree (to decide if the new tree is worth archiving). >> >> Craig >> > I told you to have a look at the commit in the ports tree in the github= issue, > which apparently you did not. >=20 > In particular: > https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=3Dec2764d5ec493= 3f52cb0718663f60f1e1b1eed7f >=20 > This is not done by pkg, so this is not a pkg bug, neither done by poud= riere, > this is done by the ports tree, this is a transition so that when someo= ne is > signing his own repo, he has valid signature for FreeBSD 12.2 and 11.4 = which are > the 2 systems which do not know about .pkg extention for the bootstrap = of pkg. >=20 > The safest way to do that was to create a dead symlink so the when pkg.= pkg.sig > appears the symlink is not dead anymore and bootstrap signature can be = checked. >=20 > 1 improvements that can be done, (I don't have time to do it right now:= limit > this to only be created on FreeBSD 12 and 11, limit it to cluster packa= ge > building) The attached patch limits the creation of the symlink to FreeBSD versions before 13. Inline version for easy review (white-space might be damaged): diff --git a/Mk/bsd.port.mk b/Mk/bsd.port.mk index c9532fa5af2e..1a942e8abc0c 100644 --- a/Mk/bsd.port.mk +++ b/Mk/bsd.port.mk @@ -3461,7 +3461,10 @@ ${PKGLATESTFILE}: ${PKGFILE} ${PKGLATESTREPOSITORY= } ${INSTALL} -l rs ${PKGFILE} ${PKGLATESTFILE} .if !defined(_PKG_TRANSITIONING_TO_NEW_EXT) -_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDLATESTFILE} ${PKGOLDSIGFILE} +_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDLATESTFILE} +.if ${OSVERSION} < 1300000 +_EXTRA_PACKAGE_TARGET_DEP+=3D ${PKGOLDSIGFILE} +.endif ${PKGOLDLATESTFILE}: ${PKGOLDFILE} ${PKGLATESTREPOSITORY} ${INSTALL} -l rs ${PKGOLDFILE} ${PKGOLDLATESTFILE} Do you approve the commit? Regards, STefan --------------E582BDCAAC691F7F19DCCA94 Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="pkg-sig.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="pkg-sig.diff" ZGlmZiAtLWdpdCBhL01rL2JzZC5wb3J0Lm1rIGIvTWsvYnNkLnBvcnQubWsKaW5kZXggYzk1 MzJmYTVhZjJlLi4xYTk0MmU4YWJjMGMgMTAwNjQ0Ci0tLSBhL01rL2JzZC5wb3J0Lm1rCisr KyBiL01rL2JzZC5wb3J0Lm1rCkBAIC0zNDYxLDcgKzM0NjEsMTAgQEAgJHtQS0dMQVRFU1RG SUxFfTogJHtQS0dGSUxFfSAke1BLR0xBVEVTVFJFUE9TSVRPUll9CiAJJHtJTlNUQUxMfSAt bCBycyAke1BLR0ZJTEV9ICR7UEtHTEFURVNURklMRX0KIAogLmlmICFkZWZpbmVkKF9QS0df VFJBTlNJVElPTklOR19UT19ORVdfRVhUKQotX0VYVFJBX1BBQ0tBR0VfVEFSR0VUX0RFUCs9 CSR7UEtHT0xETEFURVNURklMRX0gJHtQS0dPTERTSUdGSUxFfQorX0VYVFJBX1BBQ0tBR0Vf VEFSR0VUX0RFUCs9CSR7UEtHT0xETEFURVNURklMRX0KKy5pZiAke09TVkVSU0lPTn0gPCAx MzAwMDAwCitfRVhUUkFfUEFDS0FHRV9UQVJHRVRfREVQKz0JJHtQS0dPTERTSUdGSUxFfQor LmVuZGlmCiAKICR7UEtHT0xETEFURVNURklMRX06ICR7UEtHT0xERklMRX0gJHtQS0dMQVRF U1RSRVBPU0lUT1JZfQogCSR7SU5TVEFMTH0gLWwgcnMgJHtQS0dPTERGSUxFfSAke1BLR09M RExBVEVTVEZJTEV9Cg== --------------E582BDCAAC691F7F19DCCA94-- --pBVNSJMH52CyARz4dCSLASjP4ZZun32lP-- --tJ5uNZZEx7gEmGulTrx6qvSjoUSwCakK5 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmECclsFAwAAAAAACgkQR+u171r99UT9 RwgAuPjbRSkSHGXqB6Am9mDB10VtOuS+DgRwWYmrFXCOzPoCIVoJ27MkS3eUCIY9+AAEimHvtSCL +sWFTPng/Ry/lDmczkCViQd3U7m3BUvwtFQn/kaj7+98yYEd5MK/o2f1RlYU3fPrp5fMwTEfgeSG ZveYXvq89U4cWi0YlDuuM5cVJNPfcvQGMCO+BLcu4m+3ZkHmO7s43yttqc9RZ4VwRhcGS6k8DyRS yiw+r0r1LmnqcK/DenGZXRCgB9l03E4SsQe4b8YxUdTnqP2WnNUnTjhyvIe5T9Em/sIZVIxa6A6k 1eJL6MxgAjtxOUDH7RmrhO0AXX3EhxxNZm0n+SNngQ== =oejC -----END PGP SIGNATURE----- --tJ5uNZZEx7gEmGulTrx6qvSjoUSwCakK5-- From nobody Thu Jul 29 11:20:13 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1281612B4607 for ; Thu, 29 Jul 2021 11:20:17 +0000 (UTC) (envelope-from sfaisal@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gb7Nw2wz5z4WPQ for ; Thu, 29 Jul 2021 11:20:16 +0000 (UTC) (envelope-from sfaisal@juniper.net) Received: from pps.filterd (m0108163.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16TBJ0I1013515 for ; Thu, 29 Jul 2021 04:20:16 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=PPS1017; bh=HrZVbUDKI6IEBlU4W8Yb8GlChGw3LOOjbTG6S66XuHg=; b=zfzzVmvpg8F3xHFByT1Ko+DreEXzLd9gNURx33YeJhB4QA5Dwo/6f+NCORM2Z5Ppl4Rs cfT32lx38/nBlE8VKTK7iQiTkFXJi6Ar/sXA26+FheMXP7rJfy8MO3gkSFgAQaBYxslL jPlpU5K2UqgTXcCHkNBdwrSsMibyJxWTUtEt/vzmMEq+3TDLnZMTS5m48YJXodtyMdaz pyWeGUTz6vCrpXJqQmPpvAnvtj+HixBSWBxRDlj8AzPrTvWJP1yNQ5fz7L0ttd6bvwE2 1SUzoJQPAEeOXDHIKEaDUmc490upICONmpRY0AOVScuYilHLUWwMwBwuhIeY22sCC4Oj 0g== Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by mx0b-00273201.pphosted.com with ESMTP id 3a3rhx0a3x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 29 Jul 2021 04:20:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nWsI6tZk5atKHzEhEEAF+Ioc8jqHP+nS9NntMXHypoee4DRIcN4SS8aW/3o0HfDrd4wbLRtA4GMwSMZ+BZ4C8+QAbI2tbSQaRqZGH1xsNnzvpSFmFdCtiQyaDP0gQxiA/BFFDWlbKyG0grR8FXtI2O7LNl9VOFInBk0oM5mxb/eeH6iRpSDaNGgkNvhKz6yBRvBP7bVSz9EIFNcjUuFs08u2byY/mv/otLmLREEo1bh5kbae2NACe3fRUT4X9VltO6vN7jug/shuNFSqZDu78rMZ9LmsotQejb+sAIktxFKvavG1eJFPRODw6ZvpqIYYeI9vTctyMyYaM+v+5IB14w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrZVbUDKI6IEBlU4W8Yb8GlChGw3LOOjbTG6S66XuHg=; b=CloYhm5Gprmu7hYzRuAKIoilxso9TC6Ig8fGqipOV1iUws59NsyA3xHmv4kjlKP5YW8IBLTESLwwwdjKFMHOtdH+rtCurTlUFs2ulP13xHIVoa/vXwxpRxeTPmiOjdf1yPru03OiNTryJs4dUR1lBfSkNOZ8DrvbYH44Z+Fo6O0BVXFkD3bI5qzwicFBrgYAETONPJwUnKhmi4fWfTW1qTbKHANRfKP7e38XvadXRJZnQvx/gToW7wT02AJMbh7RYuI2MlykTIGeQ+If6A2NTAD2oqvLj49LeK4rN/hWJRiiqy4X0Ek0ezqnr6vFjAoOd2OUvOZPq97udCN3wWvNvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=juniper.net; dmarc=pass action=none header.from=juniper.net; dkim=pass header.d=juniper.net; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=juniper.net; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HrZVbUDKI6IEBlU4W8Yb8GlChGw3LOOjbTG6S66XuHg=; b=jZZHqyfX4JjMh9DqPUJLHnZlUffevyuvTFD1l4BD5bn4dI3vQ4SFw3u7N29SZ2MHomXzSV4F/9v4AkjsyzENBZkKlt7rjm8rUteukxi3x5RU3V05/pVuz+OF5y0nw0gWShUvlzuOjEQNPAPgpqCEfdi9DRohyHkHu2x9BqTqRrY= Received: from BYAPR05MB6677.namprd05.prod.outlook.com (2603:10b6:a03:ec::28) by BY5PR05MB6769.namprd05.prod.outlook.com (2603:10b6:a03:1b5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.15; Thu, 29 Jul 2021 11:20:13 +0000 Received: from BYAPR05MB6677.namprd05.prod.outlook.com ([fe80::f0b1:1686:6972:54ac]) by BYAPR05MB6677.namprd05.prod.outlook.com ([fe80::f0b1:1686:6972:54ac%4]) with mapi id 15.20.4373.020; Thu, 29 Jul 2021 11:20:13 +0000 To: "freebsd-hackers@FreeBSD.org" CC: Justin Hibbits , Kumara N Babu , Vikram M Gadagkar Subject: Re: Generic-xhci driver issue and changes for 64-but physical memory space Thread-Topic: Generic-xhci driver issue and changes for 64-but physical memory space Thread-Index: AQHXg+FWYGOJ8Wf6NUCjq1ExzN3jxKtZGASAgAET0QA= Date: Thu, 29 Jul 2021 11:20:13 +0000 Message-ID: <1A9919BF-4D07-4D71-B795-D6CFF6CD0FF1@juniper.net> References: <5A15D0DF-6D41-4F17-B07A-D5A061057644@juniper.net> <30397365-BC3C-41C4-BF55-0D13778EF0A8@juniper.net> In-Reply-To: <30397365-BC3C-41C4-BF55-0D13778EF0A8@juniper.net> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ContentBits=0;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SiteId=bea78b3c-4cdb-4130-854a-1d193232e5f4;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_ActionId=f003fdcd-61bc-46ba-add0-da2bca3549ef;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_SetDate=2021-07-28T17:22:12Z;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Method=Standard;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Name=Juniper Business Use Only;MSIP_Label_0633b888-ae0d-4341-a75f-06e04137d755_Enabled=true; user-agent: Microsoft-MacOutlook/16.51.21071101 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08af06b0-5145-42fa-7d13-08d95282d5e1 x-ms-traffictypediagnostic: BY5PR05MB6769: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AEZypfm8Q0NrevgJq7xY8sNMNul8gmeUQ93lYnOXee8LAFTyS65qrcOCmehBT3ttM/D7rJp257loP2RkGqP7wgJvf7tr1iKf0EcwfFwGWAHkCQOVTQOgmzkq31wxYrrvTZn0bVcqv3IYtvOHmZR8YRu9yW6+2ki4IAEuQTxKkB1ps8fy41ORQwjLs65RdU8NWHUhTlrV61DVBlSI27c/vebSYeyVX+ArvasHlZQcAuSZmZLoiWZTJXonFSnopTe9ZBJXm9hJTJm1XzuDXGYOlJjeAE6SpS3Yqgb/QN7NItsalwmYkjBiaEBk4QoSTsDQWyQj1LeZcOxRF6XizoNC7enQPWLonwK3liJEeNOOyeQEV/4pdx0qGkCUFOrxphsX6DGwbCyao07/hUBxtO9Aje9bbrVMDbl68cAzHQIXGeUZmI7dOxa3MUCxzDQF0vgg8YXKSyR3a2HwXrJH9FY2XSpuz3DkIODtBt1msJytWqy32panqfQGxe1ZZtq2Ex94b0fkVdIdfm7RLRHBdg8dxYY9PhP1E9kJw0EGsSKUc45bRWRYW0gZw1tGcmS+a6XYIZNia+hntRi4fcyAtK08vza+1EvtnmYfX7xlNaBacS4QvmqmsyVu7rpTY3ga5FB13k7ioDxcffdPmh1eqbVOSU8tc9CH6hocpK0UB2Ywxm/jb10enoOxe6kRhNgjj6RLdTszQgVG1SIsO9arKjeEHU1Q2QUqV+UCanHFgZc+dtPqbWVviwmdGQKxvVdlK/pySdEuZ8EyI4AwYAiifYJW4g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR05MB6677.namprd05.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(8676002)(8936002)(4326008)(33656002)(107886003)(186003)(26005)(36756003)(6506007)(53546011)(2906002)(122000001)(6486002)(6512007)(2616005)(91956017)(86362001)(76116006)(38100700002)(5660300002)(66946007)(66446008)(71200400001)(66556008)(6916009)(54906003)(38070700005)(66476007)(64756008)(316002)(478600001)(41533002)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWloTzZWN0FTTnZ5a1dnNll6WkRPS1d2SzdGK21SbFI2cDdodW5JcUFvWHFw?= =?utf-8?B?QWRWOWhhMnpEbkdjMnZNZlNhcm0yR2JoOHl6OHdnVUw4QWJ2YTNqV0pUcG5S?= =?utf-8?B?SHFpMm1IaWNneGhxekpDcXorRFl3WHlJRTJQL0I5Ymk3bUlGbGVncXhOUGpv?= =?utf-8?B?S1RJTDBKb012VUkvU21iQVEwTXJYdUJBWGZrRWI5TVYxYWZvcThDTzUwaGtx?= =?utf-8?B?REFyeDlkMTVoQzhZeUp3aEd6NFhZNkpGdjdVNnprMDhOaDlLeVFyVVo1NU03?= =?utf-8?B?TG1TTGpQaEJSUHBLcyt6U0lldXA0czhrc1F1eTVxVm5zR1VubkNFT2xxR3Qr?= =?utf-8?B?M1F2anBQa0lSTnZRYnpWRVp5Vmc2Sm80TVdKbnRIUGh3c1VxZ2tPVEJ2NEgr?= =?utf-8?B?N0pGb3JoeVdVY1JWOExrMFc1M2dkTTVwb3hjTGVYSGNnM04xSDQ4WTN6bkJn?= =?utf-8?B?MUlibjFzK3lDOENkK0c5dU02dE1tbVZrTXdReHN6c3VPdUNMQ2VzYklYNGU2?= =?utf-8?B?TVVmdU0wQmUvMEhjUlF0bzNvUnh2S0RjclpIZ2pQcUEvTUhLbFNrb1pVSXFj?= =?utf-8?B?QkJFUmpNQkpSSHJTTmhkU2wyUlhRMk4rWlhqZjRCZmVWZ3kxcURTTmduaEFZ?= =?utf-8?B?QkRLMnNOUGFtTWtBaWZSaE1jaEp5dHhFS1UzU0MvcWlVcFhwWEh5bDk0N1ZR?= =?utf-8?B?UU9LVm91WHBvME5BZkJiWTRma29vWXRqcXJzTkFBeHRxZzl6RVR2UTFwbUtP?= =?utf-8?B?OUtuZ0hzR08xUGpUOUR6QUJLeWh1Kzh2V0Q1S3NYNkNUTWV3a0gwZk5PekNu?= =?utf-8?B?VWhpbFRMLzc1aGplU1R4eU1BSXdheWhCaEFxbk9kSmJpdHJmaDkyR3o0ak83?= =?utf-8?B?RDIwWXNkWVhrZ0cvZThiOWJCcGNKR1BrOEFJaUxzOCtMV2Q0L0E0RUJlZ2FB?= =?utf-8?B?TjhkV3UxRFZ5YitjK29GSmtoWTNSTkZ6YVNFQSs5QWNsYjdQWHdOTXNWWlUv?= =?utf-8?B?TnNXYlByZ211YXRBMjBnS0l2L1prbmg1eUZkbUlhY0pTcnY1eHZKUEJhNUVX?= =?utf-8?B?WldGWW5jNE4vZDBGSk94Y1h1MWxhOUNtN1FXNzNWelJjL1NHYllpejQva1Rp?= =?utf-8?B?MGc0SDRMMUEvR0FmbnhDbEt1bXVQRm1PT0FIKzIyZmVpa1NZU1ptOUZTTnpU?= =?utf-8?B?SVpUWTYyaU5VTEo2QUJOOFhlb3pGTXdvMlBUYWNNS3NXZnA0Qk9vY3V3TFBC?= =?utf-8?B?RTJlVkE1dk9Jc20za05UWjJCSTY2WDRiMjF1NG1idFhZUk5EeGRwU1hzbnJC?= =?utf-8?B?THdyT0d5MHdDeHQ2cDFtZTFONXhhdEtpOXdkaFhpTXdmR29qMDV3UStXWGZw?= =?utf-8?B?K3NPcW5CbEVkdjkwSkkxNnRQVXBmT1ppTDN1STh1QW11QTdCQzNxUFUxVlIz?= =?utf-8?B?Vmpld0o4RXZFQm9BZ3JGeWdQay9GWHdJbmxOVy91ZWIxR2ZTTTFlaWtCZm10?= =?utf-8?B?Rk9ZcWlLSmN6dzk2YkxDMkV2SzVrVHpWYkNESjI1Ni9WSWtnS2k0SHRRRkVW?= =?utf-8?B?dm9xUEtJUkNmQzJ6M2JTckxGWnBaNlFFYng4a29XQlgyRFdBNG9VMXdpWVNn?= =?utf-8?B?YWg5bzVVZ1BsVU5jcUdXZGw3aktObnIwaU95ZjRHaHhTV1BUcHU0VVlRdUZy?= =?utf-8?B?Z3ozbTQ3TEpWaGFNekFCOWsrUTgxTkJsNlRBV1RvRVdFSG9Wak5SeHZReStG?= =?utf-8?B?bFU5MjlQL0NvUXZKY25VTHdkY2U4MDBwTUJHTTg0cEw1WFhIZjgzWXZYOEI5?= =?utf-8?B?RitSaDV1a2w1UDcrRk5WUT09?= Content-Type: multipart/alternative; boundary="_000_1A9919BF4D074D71B795D6CFF6CD0FF1junipernet_" List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR05MB6677.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08af06b0-5145-42fa-7d13-08d95282d5e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2021 11:20:13.5757 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SEfu63RvYwrZLlcfRiLoA79Urv8q97+d5EFnUy5fiUBAg2Cjlq/kEtDlKl7qiZHsWf/5OxQdzSFoaXPxQBEmkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR05MB6769 X-Proofpoint-GUID: Si8jdv6xqPMtkQkZ_Q_v0JSNWwjhxmh6 X-Proofpoint-ORIG-GUID: Si8jdv6xqPMtkQkZ_Q_v0JSNWwjhxmh6 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-29_09:2021-07-29,2021-07-29 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2107290073 X-Rspamd-Queue-Id: 4Gb7Nw2wz5z4WPQ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=juniper.net header.s=PPS1017 header.b=zfzzVmvp; dkim=pass header.d=juniper.net header.s=selector1 header.b=jZZHqyfX; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=juniper.net; spf=pass (mx1.freebsd.org: domain of sfaisal@juniper.net designates 67.231.152.164 as permitted sender) smtp.mailfrom=sfaisal@juniper.net X-Spamd-Result: default: False [-5.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:67.231.152.164]; RWL_MAILSPIKE_EXCELLENT(0.00)[67.231.152.164:from]; DKIM_TRACE(0.00)[juniper.net:+]; MIME_BASE64_TEXT(0.10)[]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[67.231.152.164:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RCVD_COUNT_FIVE(0.00)[5]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017,juniper.net:s=selector1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[104.47.55.175:received]; MAILMAN_DEST(0.00)[freebsd-hackers] Reply-To: sfaisal@juniper.net From: Sha Faisal via freebsd-hackers X-Original-From: Sha Faisal X-ThisMailContainsUnwantedMimeParts: Y --_000_1A9919BF4D074D71B795D6CFF6CD0FF1junipernet_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 TWFpbGluZyB0byBmcmVlYnNkLWhhY2tlcnMsIGFmdGVyIGFkZGluZyBteSBlbWFpbCBpZCB0byBz dWJzY3JpYmVyIGxpc3QuDQpQbGVhc2UgYXNzaXN0IHdpdGggdGhlIGJlbG93IHF1ZXJ5Lg0KDQpS ZWdhcmRzDQpGYWlzYWwNCg0KRnJvbTogU2hhIEZhaXNhbCA8c2ZhaXNhbEBqdW5pcGVyLm5ldD4N CkRhdGU6IFRodXJzZGF5LCAyOSBKdWx5IDIwMjEgYXQgMTI6MTkgQU0NClRvOiAiaGFja2Vyc0Bm cmVlYnNkLm9yZyIgPGhhY2tlcnNAZnJlZWJzZC5vcmc+DQpDYzogSnVzdGluIEhpYmJpdHMgPGpo aWJiaXRzQGp1bmlwZXIubmV0PiwgS3VtYXJhIE4gQmFidSA8Ymt1bWFyYUBqdW5pcGVyLm5ldD4s IFZpa3JhbSBNIEdhZGFna2FyIDx2aWtyYW1nQGp1bmlwZXIubmV0Pg0KU3ViamVjdDogR2VuZXJp Yy14aGNpIGRyaXZlciBpc3N1ZSBhbmQgY2hhbmdlcyBmb3IgNjQtYnV0IHBoeXNpY2FsIG1lbW9y eSBzcGFjZQ0KDQpIZWxsbyBGcmVlQlNELWhhY2tlcnMNCg0KSW5uIG9uZSBvZiBvdXIgbmV3IHBs YXRmb3JtcyB3ZSBoYXZlIHBoeXNpY2FsIFJBTSBwbGFjZWQgYWJvdmUgdGhlIDRHQiBtYXJrLg0K QW5kIHRoZSBlVVNCIGRldmljZSBpcyBjYXBhYmxlIG9mIGRvaW5nIDY0LWJpdCBETUEuDQoNClRo ZSBVU0JQSFkgdXNlcyB0aGUgZ2VuZXJpYy14aGNpIGRyaXZlciBhbmQgd2hlbiB3ZSB3ZXJlIGJy aW5naW5nLXVwIHdlIGhpdCB0aGUgaXNzdWUgYmVsb3cgYW5kIHRoZSBjb2RlIHBhbmlj4oCZcw0K DQp4aGNpMDogPE1hcnZlbGwgSW50ZWdyYXRlZCBVU0IgMy4wIGNvbnRyb2xsZXI+IG1lbSAweDEw MjQzMDAwLTB4MTAyNDNmZmYgaXJxIDE1IG9uIHNpbXBsZWJ1czENCnhoY2kwOiA2NCBieXRlcyBj b250ZXh0IHNpemUsIDMyLWJpdCBETUENCnBhbmljOiB2bV93YWl0IGluIGVhcmx5IGJvb3QNCg0K SSBtb2RpZmllZCB0aGUgYmVsb3cgZnVuY3Rpb24gY2FsbCAsIGFuZCB0aGUgdXNiIGRyaXZlciBp cyB1cCBhbmQgaXQgd29ya3MgZmluZS4gUGxlYXNlIHN1Z2dlc3QgaWYgdGhpcyBjaGFuZ2UgaXMg ZmluZSBhbmQgY2FuIGJlIGluY29ycG9yYXRlZC4NCg0KDQojZGVmaW5lIElTX0RNQV8zMkIgICAg ICAxDQoNCiNkZWZpbmUgSVNfRE1BXzY0QiAgICAgIDANCg0KDQplcnIgPSB4aGNpX2luaXQoc2Ms IGRldiwgSVNfRE1BXzY0Qik7DQoNCg0KUmVnYXJkcw0KRmFpc2FsDQoNCg0KDQpKdW5pcGVyIEJ1 c2luZXNzIFVzZSBPbmx5DQo= --_000_1A9919BF4D074D71B795D6CFF6CD0FF1junipernet_-- From nobody Thu Jul 29 14:13:32 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E029B12BD98D for ; Thu, 29 Jul 2021 14:13:35 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GbCDv5j3sz4jHN for ; Thu, 29 Jul 2021 14:13:35 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-ed1-x52a.google.com with SMTP id y7so6191273eda.5 for ; Thu, 29 Jul 2021 07:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=uCQfBWBAVR89DjjlJMTmh+gcaAqn6/BDIY+G6w+Py6s=; b=ixpWQtZJvH4bC5mj+dDWvW8fHYNhxTBpb1750neLDIzhY2YsNS/s8jtI+7L14WCPST RAlqKFbDvT3eG8B+kiijg2T31ClsZRHsJydCUsZuhmMl9WJGA2b+IlVUayleJaLYw/zP euswUzmG9re0NGJx00tn1w9HDF1LnMLNQSQ7KOpZyLJ8uNYNCf5pSpu2m+mUVBIWinb4 3N9pfJzx4quwea45OMs0JJf7mdrs9wrMrRe9UIaPNbCW1AFSE9i7WOHo7X9ibFstvJGK flMpLWz5KW8D8BWlxD7DsK6yB6eV0ma+Hw3RAaNZjjqVhO+p8JW75/nu+pPERuIX725h N8HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=uCQfBWBAVR89DjjlJMTmh+gcaAqn6/BDIY+G6w+Py6s=; b=BcehN02iVi7CWHZmlhmef/gtf5UMfsTzpOAclVHp0WZtyz6isv3FEyx+UXKQxE4Ui7 I/3jL8qZqPuxqCVYr24EmKpP5HsaXIOc5d7JaYkYiGNyst6AjGScim3R59q+KtRy6Wcl kFtzdEq+OLghX5PHKMBd8QMbiam0POwoYiFnukBI6bmalK2rccXDbO+aEZt6Zm7dct9O 9yEkax0qOnEAc1yBQJJNQMpgcWgbBIgDm3bFG9SNDjQAkZSh+xFUeNC0qHLyhfXVBKTN r/eNFo0Ip2j4Wp8cuHzZ3NVSeN97siwjAw9PTYedTiG+0CGWZyN7fH+nqQfBgqnk0/lh q/gg== X-Gm-Message-State: AOAM532+WBuBgQ5YBeMSVITuJmA2iq+p7Dp/wzgDYCmt1ZY0QhVyxyr7 5pyV96XeTlDLhjvGFG8rK7fncV8DByY= X-Google-Smtp-Source: ABdhPJzy9FwPFI3U3ArWl2Lwnu0I5Ro9cqpqXyGIJyuc/2cNwDwzkkZMEG4r0Dode/J1ChG/b3ynFw== X-Received: by 2002:a05:6402:22b0:: with SMTP id cx16mr6286780edb.185.1627568014881; Thu, 29 Jul 2021 07:13:34 -0700 (PDT) Received: from ernst.home (pd9e2360f.dip0.t-ipconnect.de. [217.226.54.15]) by smtp.gmail.com with ESMTPSA id n11sm1036900ejg.111.2021.07.29.07.13.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 07:13:34 -0700 (PDT) Date: Thu, 29 Jul 2021 16:13:32 +0200 From: Gary Jennejohn To: Sha Faisal via freebsd-hackers Cc: sfaisal@juniper.net, Justin Hibbits , Kumara N Babu , Vikram M Gadagkar Subject: Re: Generic-xhci driver issue and changes for 64-but physical memory space Message-ID: <20210729141332.08d62f21@ernst.home> In-Reply-To: <1A9919BF-4D07-4D71-B795-D6CFF6CD0FF1@juniper.net> References: <5A15D0DF-6D41-4F17-B07A-D5A061057644@juniper.net> <30397365-BC3C-41C4-BF55-0D13778EF0A8@juniper.net> <1A9919BF-4D07-4D71-B795-D6CFF6CD0FF1@juniper.net> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4GbCDv5j3sz4jHN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Thu, 29 Jul 2021 11:20:13 +0000 Sha Faisal via freebsd-hackers wrote: > Mailing to freebsd-hackers, after adding my email id to subscriber list. > Please assist with the below query. > > Regards > Faisal > > From: Sha Faisal > Date: Thursday, 29 July 2021 at 12:19 AM > To: "hackers@freebsd.org" > Cc: Justin Hibbits , Kumara N Babu , Vikram M Gadagkar > Subject: Generic-xhci driver issue and changes for 64-but physical memory space > > Hello FreeBSD-hackers > > Inn one of our new platforms we have physical RAM placed above the 4GB mark. > And the eUSB device is capable of doing 64-bit DMA. > > The USBPHY uses the generic-xhci driver and when we were bringing-up we hit the issue below and the code panics > > xhci0: mem 0x10243000-0x10243fff irq 15 on simplebus1 > xhci0: 64 bytes context size, 32-bit DMA > panic: vm_wait in early boot > > I modified the below function call , and the usb driver is up and it works fine. Please suggest if this change is fine and can be incorporated. > > > #define IS_DMA_32B 1 > > #define IS_DMA_64B 0 > > > err = xhci_init(sc, dev, IS_DMA_64B); > As a locally maintained patch this would be acceptable. But I greatly doubt that this change would make it into the source tree as written. Since the generic-xhci driver knows basically nothing about the hardware it takes the conservative approach of always using 32-bit DMA. Strangely enough, the code in xhci.c, which tries to determine the DMA size by reading a register in the controller, thinks that this controller only supports 32-bit DMA. If I were the maintainer of this code the only way I would allow this change would be if it used the pci register values unique to this controller to set the dma32 flag in xhci_init() to 0 and otherwise keep the default value of 1. -- Gary Jennejohn From nobody Fri Jul 30 09:29:38 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1BC9C12DD7E1; Fri, 30 Jul 2021 09:29:50 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward103p.mail.yandex.net (forward103p.mail.yandex.net [77.88.28.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gbhv05mTCz4W5D; Fri, 30 Jul 2021 09:29:48 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from myt6-61e9e731de9c.qloud-c.yandex.net (myt6-61e9e731de9c.qloud-c.yandex.net [IPv6:2a02:6b8:c12:4ca0:0:640:61e9:e731]) by forward103p.mail.yandex.net (Yandex) with ESMTP id 69DBA18C24FF; Fri, 30 Jul 2021 12:29:39 +0300 (MSK) Received: from myt6-efff10c3476a.qloud-c.yandex.net (myt6-efff10c3476a.qloud-c.yandex.net [2a02:6b8:c12:13a3:0:640:efff:10c3]) by myt6-61e9e731de9c.qloud-c.yandex.net (mxback/Yandex) with ESMTP id YcvVnDnjD4-TdIi9foP; Fri, 30 Jul 2021 12:29:39 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1627637379; bh=ZrQ+nhe/ueOOQod26S1KHNJ2GeDQaGIV9dteVMDtBVk=; h=In-Reply-To:References:Date:Message-ID:From:To:Subject; b=KpnGc4rKzLL30KWOSJpt5GtZdIuxYm9qpaV5OwVSP7Ittj9mgKhH6JtRZQnMAn1AK RNCSxnK6UvqY2UFpEiMyO+Lg7Beys4CUFN6+I2hHukM1oezhHDHOE/Q3y+7TE5q0os AhbktRHyrzOIFCKYG5yGn55DFKjoCxzGR+plress= Received: by myt6-efff10c3476a.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id IY9LeMDmdS-Tc3KfkDi; Fri, 30 Jul 2021 12:29:39 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) Subject: Re: is there a way to Port DragonflyBSD's IPFW3 to FreeBSD To: alfadev , "freebsd-hackers@FreeBSD.org" , "freebsd-ipfw@FreeBSD.org" References: From: "Andrey V. Elsukov" Message-ID: Date: Fri, 30 Jul 2021 12:29:38 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NXyMaoWD3kZjbmiA7PmuA0M0b77oMGPVT" X-Rspamd-Queue-Id: 4Gbhv05mTCz4W5D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yandex.ru header.s=mail header.b=KpnGc4rK; dmarc=pass (policy=none) header.from=yandex.ru; spf=pass (mx1.freebsd.org: domain of bu7cher@yandex.ru designates 77.88.28.106 as permitted sender) smtp.mailfrom=bu7cher@yandex.ru X-Spamd-Result: default: False [-6.10 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yandex.ru]; R_SPF_ALLOW(-0.20)[+ip4:77.88.0.0/18]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[yandex.ru:+]; DMARC_POLICY_ALLOW(-0.50)[yandex.ru,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SIGNED_PGP(-2.00)[]; FREEMAIL_TO(0.00)[protonmail.com,FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~]; FREEMAIL_ENVFROM(0.00)[yandex.ru]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:13238, ipnet:77.88.0.0/18, country:RU]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[yandex.ru:s=mail]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DWL_DNSWL_NONE(0.00)[yandex.ru:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[77.88.28.106:from]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-ipfw] X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NXyMaoWD3kZjbmiA7PmuA0M0b77oMGPVT Content-Type: multipart/mixed; boundary="dnUbK2ktay7uPmN1ddWZTYtGuEFHHz6bn"; protected-headers="v1" From: "Andrey V. Elsukov" To: alfadev , "freebsd-hackers@FreeBSD.org" , "freebsd-ipfw@FreeBSD.org" Message-ID: Subject: Re: is there a way to Port DragonflyBSD's IPFW3 to FreeBSD References: In-Reply-To: --dnUbK2ktay7uPmN1ddWZTYtGuEFHHz6bn Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable 28.07.2021 16:05, alfadev via freebsd-hackers =D0=BF=D0=B8=D1=88=D0=B5=D1= =82: > These are some hard problems to me when i try to completely move on > IPFW. So is there a way to port IPFW3 to FreeBSD. Thanks for any help > and suggestions.. I think it is much easier just implement needed functional in the FreeBSD's ipfw, than doing porting ipfw from DragonFly. But you can try := ) --=20 WBR, Andrey V. Elsukov --dnUbK2ktay7uPmN1ddWZTYtGuEFHHz6bn-- --NXyMaoWD3kZjbmiA7PmuA0M0b77oMGPVT Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEE5lkeG0HaFRbwybwAAcXqBBDIoXoFAmEDxoIFAwAAAAAACgkQAcXqBBDIoXo+ cQgAkPq06UI152pF074j6OTPFGDPt7SnoqstDYz+6bQQpnBRc4sUDXSGZmIl6SekwfA0fzGA2YCM pIbz5u1qlEdILbSATQTgMKHFQoR/GYx4AqmZ6cB4kCSrUSHqiesA4nA8NJ9fp8eCB49hWxM6rllM J/aw80uqVLrcP+3i3wDuGIn37Ex2eih/12Ph6jvgqULkIuaCEMfJDDPUOPLRxIP64FcbErRu7qlq BFECIIxjLWz9O6XUL9ToTEDPUQtRS6HaMdN1j+iK5LVTyjn+R/+wrFFL/KvVcIcXP497dpXZgvDn h+MRz3ku+G1UG+Pc+rFVo4eZUboGHTP3oKRD5dNA7w== =dSeM -----END PGP SIGNATURE----- --NXyMaoWD3kZjbmiA7PmuA0M0b77oMGPVT-- From nobody Fri Jul 30 11:40:03 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E80D212AC96F for ; Fri, 30 Jul 2021 11:40:15 +0000 (UTC) (envelope-from alfadev@protonmail.com) Received: from mail-4318.protonmail.ch (mail-4318.protonmail.ch [185.70.43.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GblnV4rjlz4dlx for ; Fri, 30 Jul 2021 11:40:14 +0000 (UTC) (envelope-from alfadev@protonmail.com) Date: Fri, 30 Jul 2021 11:40:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1627645205; bh=bacK7lRtJuGXy94zDF4mrUy0QSbmNJZYOvY9WRREs2s=; h=Date:To:From:Reply-To:Subject:From; b=Kwyff9kz3j7g7YX12LVPwN3wqPfOTEbd5Lt03VAmZTz77mZtPw2xaWbLrG+rENKVq UCf3317FizWKmxYPGKQNCJIvoqL2vzks7RC8JFDMmHahF2BlQc7KdRQj0dgmO9GtdD iISi/R517HQnVO6dkTJnzAMAaNyCBOj/+TZoY5Zs= To: "freebsd-ipfw@FreeBSD.org" , "freebsd-hackers@FreeBSD.org" , "freebsd-pf@FreeBSD.org" Reply-To: alfadev Subject: How to Force Packet Traversal Order (IPFW2 => PF) Message-ID: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_MfD9JyWWconp94KOU5wo7jG9JdPQlzNcgZA5TJLhqQ" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Rspamd-Queue-Id: 4GblnV4rjlz4dlx X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protonmail.com header.s=protonmail header.b=Kwyff9kz; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (mx1.freebsd.org: domain of alfadev@protonmail.com designates 185.70.43.18 as permitted sender) smtp.mailfrom=alfadev@protonmail.com X-Spamd-Result: default: False [-2.41 / 15.00]; HAS_REPLYTO(0.00)[alfadev@protonmail.com]; RWL_MAILSPIKE_GOOD(0.00)[185.70.43.18:from]; FREEMAIL_FROM(0.00)[protonmail.com]; R_SPF_ALLOW(-0.20)[+ip4:185.70.43.0/24]; MIME_BASE64_TEXT_BOGUS(1.00)[]; DKIM_TRACE(0.00)[protonmail.com:+]; MIME_BASE64_TEXT(0.10)[]; DMARC_POLICY_ALLOW(-0.50)[protonmail.com,quarantine]; NEURAL_HAM_SHORT(-0.51)[-0.514]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[protonmail.com]; ASN(0.00)[asn:62371, ipnet:185.70.43.0/24, country:CH]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[protonmail.com:s=protonmail]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_REPLYTO(0.00)[protonmail.com]; HAS_PHPMAILER_SIG(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_EQ_ADDR_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers] Reply-To: alfadev@protonmail.com From: alfadev via freebsd-ipfw X-Original-From: alfadev X-ThisMailContainsUnwantedMimeParts: Y This is a multi-part message in MIME format. --b1_MfD9JyWWconp94KOU5wo7jG9JdPQlzNcgZA5TJLhqQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGksCkkgaGF2ZSB0byB1c2UgYm90aCBJUEZXIGFuZCBQRiBzYW1ldGltZSBpbiBteSBmcmVlYnNk IDEyLjIgZ2F0ZXdheQoKQWNjb3JkaW5nIHRvIG15IG9ic2VydmF0aW9ucyBmaXJld2FsbHMgYXJl IGZvbGxvd2luZyB0aGlzIG9yZGVyIGFsbCBvZiBteSBzY2VuYXJpb3MgUEYgPT4gSVBGVzIuIEkg c2VlIHRoaXMgZXhhY3RseSBXaGVuIGkgdXNlIFBGJ3Mgcm91dGUtdG8gb3B0aW9uIC4gV2hlbiBp IGNyZWF0ZSBMb2FkLUJhbGFuY2luZyBydWxlIHVzaW5nIFBGJ3Mgcm91dGUtdG8sIHBhY2tldHMg bm90IGVudGVyaW5nIGludG8gSVBGVy4gU28gd2hlbiBpIG1hZGUgUEJSLCBJUEZXIHJ1bGVzIGxp a2UgbWFjIGJhc2VkIHBpcGluZywgYmFuZHdpZHRoLCBjYXB0aXZlIHBvcnRhbCBldGMuIGRvZXMg bm90IHdvcmtzLgpTbyB0aGF0CmkgYW0gdHJ5aW5nIHRvIGRvIHRoaXMgb3JkZXI6CmlucHV0ID0+ IGlwZncgPT4gcGYKCmJ1dCBpIHRoaW5rIGkgY2Fubm90IGNoYW5nZSB0aGlzIG9yZGVyIHdpdGhv dXQgdG91Y2hpbmcga2VybmVsIGxldmVsIC4Kd2hlbiBpIG1hZGUgc29tZSByZXNlYXJjaCBpIGZv dW5kIFt0aGlzXShodHRwczovL3d3dy5vcGVubmV0LnJ1L3RpcHMvaW5mby8xNDMxLnNodG1sKSBo dHRwczovL3d3dy5vcGVubmV0LnJ1L3RpcHMvaW5mby8xNDMxLnNodG1sCgpJUEZXIGFuZCBQRiBz dGFydHVwIG9yZGVyIGRlZmluaXRpb25zIGFyZSBpbiB0aGlzIGZpbGVzCgpDb2RlOgoKL3Vzci9z cmMvc3lzL25ldHBmaWwvaXBmdy9pcF9mdzIuYwovdXNyL3NyYy9zeXMvbmV0cGZpbC9wZi9wZl9p b2N0bC5jCgpJIGhhdmUgbm90IHN1ZmZpY2llbnQgc2tpbGxzIHRvIGVkaXRpbmcga2VybmVsIGxl dmVsIGZpbGVzCmFuZCB0cmllZCBpbnN0cnVjdGlvbnMgYmVsb3cgYnV0IGkgY291bGRuJ3QgY2hh bmdlZCB0aGF0IG9yZGVyLgoKSSBhbSBzdHVjayBvbiB0aGlzIGZvciB3ZWVrcyBteSBtaW5kIGdv bm5hIGJsb3cKQW55IGhlbHAgd291bGQgYmUgYXBwcmVjaWF0ZWQgYXQgdGhpcyBwb2ludC4u --b1_MfD9JyWWconp94KOU5wo7jG9JdPQlzNcgZA5TJLhqQ-- From nobody Fri Jul 30 11:52:08 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3283112AE0DB; Fri, 30 Jul 2021 11:52:13 +0000 (UTC) (envelope-from alfadev@protonmail.com) Received: from mail-40130.protonmail.ch (mail-40130.protonmail.ch [185.70.40.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gbm3J3Whyz4gjJ; Fri, 30 Jul 2021 11:52:12 +0000 (UTC) (envelope-from alfadev@protonmail.com) Date: Fri, 30 Jul 2021 11:52:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1627645930; bh=KJWMAEo+aZD+MBRiFJJE5jgHTcS8pw5CnuDPDmitmdw=; h=Date:To:From:Reply-To:Subject:From; b=hcatDZ/5gBstHVP7iYAbmYEUW6QSOznMiSq2wpmiGxB9eC1yHsWnNVU9YsSTITKKD kFyT3fuN+T2RJY3au0KnxGESmf2q5QU6YpUbUfhLHZhPtquvJ08wMHGMq+5J86RYLn tgOksbuza4Sn/LgqVHeoL5RhsYGkSruGOj0xuCIo= To: "freebsd-hackers@FreeBSD.org" , "freebsd-ipfw@FreeBSD.org" Reply-To: alfadev Subject: How to Force Packet Traversal Order (IPFW2 => PF) Message-ID: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_r38PvVZMnKQWo4JZpDfn6WMcuSGWGBACi2bEkHK4w0M" X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Rspamd-Queue-Id: 4Gbm3J3Whyz4gjJ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protonmail.com header.s=protonmail header.b="hcatDZ/5"; dmarc=pass (policy=quarantine) header.from=protonmail.com; spf=pass (mx1.freebsd.org: domain of alfadev@protonmail.com designates 185.70.40.130 as permitted sender) smtp.mailfrom=alfadev@protonmail.com X-Spamd-Result: default: False [-1.05 / 15.00]; HAS_REPLYTO(0.00)[alfadev@protonmail.com]; R_SPF_ALLOW(-0.20)[+ip4:185.70.40.0/24:c]; FREEMAIL_FROM(0.00)[protonmail.com]; MIME_BASE64_TEXT_BOGUS(1.00)[]; DKIM_TRACE(0.00)[protonmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[protonmail.com,quarantine]; MIME_BASE64_TEXT(0.10)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[protonmail.com]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[protonmail.com:s=protonmail]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; FREEMAIL_REPLYTO(0.00)[protonmail.com]; HAS_PHPMAILER_SIG(0.00)[]; NEURAL_SPAM_SHORT(0.85)[0.853]; TO_DN_EQ_ADDR_ALL(0.00)[]; RWL_MAILSPIKE_VERYGOOD(0.00)[185.70.40.130:from]; MAILMAN_DEST(0.00)[freebsd-hackers,freebsd-ipfw] Reply-To: alfadev@protonmail.com From: alfadev via freebsd-hackers X-Original-From: alfadev X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: Y This is a multi-part message in MIME format. --b1_r38PvVZMnKQWo4JZpDfn6WMcuSGWGBACi2bEkHK4w0M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGksCkkgaGF2ZSB0byB1c2UgYm90aCBJUEZXIGFuZCBQRiBzYW1ldGltZSBpbiBteSBmcmVlYnNk IDEyLjIgZ2F0ZXdheQoKQWNjb3JkaW5nIHRvIG15IG9ic2VydmF0aW9ucyBmaXJld2FsbHMgYXJl IGZvbGxvd2luZyB0aGlzIG9yZGVyIGFsbCBvZiBteSBzY2VuYXJpb3MgUEYgPT4gSVBGVzIuIEkg c2VlIHRoaXMgZXhhY3RseSBXaGVuIGkgdXNlIFBGJ3Mgcm91dGUtdG8gb3B0aW9uIC4gV2hlbiBp IGNyZWF0ZSBMb2FkLUJhbGFuY2luZyBydWxlIHVzaW5nIFBGJ3Mgcm91dGUtdG8sIHBhY2tldHMg bm90IGVudGVyaW5nIGludG8gSVBGVy4gU28gd2hlbiBpIG1hZGUgUEJSLCBJUEZXIHJ1bGVzIGxp a2UgbWFjIGJhc2VkIHBpcGluZywgYmFuZHdpZHRoLCBjYXB0aXZlIHBvcnRhbCBldGMuIGRvZXMg bm90IHdvcmtzLgpTbyB0aGF0CmkgYW0gdHJ5aW5nIHRvIGRvIHRoaXMgb3JkZXI6CmlucHV0ID0+ IGlwZncgPT4gcGYKCmJ1dCBpIHRoaW5rIGkgY2Fubm90IGNoYW5nZSB0aGlzIG9yZGVyIHdpdGhv dXQgdG91Y2hpbmcga2VybmVsIGxldmVsIC4Kd2hlbiBpIG1hZGUgc29tZSByZXNlYXJjaCBpIGZv dW5kIFt0aGlzXShodHRwczovL3d3dy5vcGVubmV0LnJ1L3RpcHMvaW5mby8xNDMxLnNodG1sKSBo dHRwczovL3d3dy5vcGVubmV0LnJ1L3RpcHMvaW5mby8xNDMxLnNodG1sCgpJUEZXIGFuZCBQRiBz dGFydHVwIG9yZGVyIGRlZmluaXRpb25zIGFyZSBpbiB0aGlzIGZpbGVzCgpDb2RlOgoKL3Vzci9z cmMvc3lzL25ldHBmaWwvaXBmdy9pcF9mdzIuYwovdXNyL3NyYy9zeXMvbmV0cGZpbC9wZi9wZl9p b2N0bC5jCgpJIGhhdmUgbm90IHN1ZmZpY2llbnQgc2tpbGxzIHRvIGVkaXRpbmcga2VybmVsIGxl dmVsIGZpbGVzCmFuZCB0cmllZCBpbnN0cnVjdGlvbnMgYmVsb3cgYnV0IGkgY291bGRuJ3QgY2hh bmdlZCB0aGF0IG9yZGVyLgoKSSBhbSBzdHVjayBvbiB0aGlzIGZvciB3ZWVrcyBteSBtaW5kIGdv bm5hIGJsb3cKQW55IGhlbHAgd291bGQgYmUgYXBwcmVjaWF0ZWQgYXQgdGhpcyBwb2ludC4uCgpT ZW50IHdpdGggW1Byb3Rvbk1haWxdKGh0dHBzOi8vcHJvdG9ubWFpbC5jb20vKSBTZWN1cmUgRW1h aWwu --b1_r38PvVZMnKQWo4JZpDfn6WMcuSGWGBACi2bEkHK4w0M-- From eugen@grosbein.net Sat Jul 31 08:17:16 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 75DEE12B122D; Sat, 31 Jul 2021 08:17:42 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcHFK1cz7z3QWM; Sat, 31 Jul 2021 08:17:40 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 16V8HRLa094891 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 31 Jul 2021 08:17:28 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: alfadev@protonmail.com Received: from [10.58.0.10] (dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 16V8HRG1016192 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 31 Jul 2021 15:17:27 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: How to Force Packet Traversal Order (IPFW2 => PF) To: alfadev , "freebsd-ipfw@FreeBSD.org" , "freebsd-hackers@FreeBSD.org" , "freebsd-pf@FreeBSD.org" References: From: Eugene Grosbein Message-ID: <21339cbe-59c6-5b07-bf8b-8e8612ba64da@grosbein.net> Date: Sat, 31 Jul 2021 15:17:16 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=4.4 required=5.0 tests=BAYES_20,LOCAL_FROM, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -0.0 BAYES_20 BODY: Bayes spam probability is 5 to 20% * [score: 0.1508] * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS * -0.1 NICE_REPLY_A Looks like a legit reply (A) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Spam-Level: **** X-Rspamd-Queue-Id: 4GcHFK1cz7z3QWM X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=fail (mx1.freebsd.org: domain of eugen@grosbein.net does not designate 2a01:4f8:c2c:26d8::2 as permitted sender) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-0.99 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_SPF_FAIL(1.00)[-all]; FREEFALL_USER(0.00)[eugen]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; ARC_NA(0.00)[]; NEURAL_SPAM_SHORT(0.11)[0.111]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEMAIL_TO(0.00)[protonmail.com,FreeBSD.org]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-pf,freebsd-hackers,freebsd-ipfw] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N 30.07.2021 18:40, alfadev via freebsd-ipfw wrote: > Hi, > I have to use both IPFW and PF sametime in my freebsd 12.2 gateway > > According to my observations firewalls are following this order all of my scenarios PF => IPFW2. I see this exactly When i use PF's route-to option . When i create Load-Balancing rule using PF's route-to, packets not entering into IPFW. So when i made PBR, IPFW rules like mac based piping, bandwidth, captive portal etc. does not works. > So that > i am trying to do this order: > input => ipfw => pf > > but i think i cannot change this order without touching kernel level . > when i made some research i found [this](https://www.opennet.ru/tips/info/1431.shtml) https://www.opennet.ru/tips/info/1431.shtml > > IPFW and PF startup order definitions are in this files > > Code: > > /usr/src/sys/netpfil/ipfw/ip_fw2.c > /usr/src/sys/netpfil/pf/pf_ioctl.c > > I have not sufficient skills to editing kernel level files > and tried instructions below but i couldn't changed that order. > > I am stuck on this for weeks my mind gonna blow > Any help would be appreciated at this point.. You need not to edit kernel sources. AFAIK it is possible to achieve what you need building custom kernel with ipfw included but pf not included to the kernel and loaded as module. From nobody Sat Jul 31 13:10:47 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C604A12D1E03; Sat, 31 Jul 2021 13:10:58 +0000 (UTC) (envelope-from SRS0=zD/e=MX=FreeBSD.org=otis@ns2.wilbury.net) Received: from ns2.wilbury.net (ns2.wilbury.net [IPv6:2a01:b200:0:1:f816:3eff:fecd:13e6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "svc.wilbury.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcPlk4CVXz4TQV; Sat, 31 Jul 2021 13:10:58 +0000 (UTC) (envelope-from SRS0=zD/e=MX=FreeBSD.org=otis@ns2.wilbury.net) Received: from smtpclient.apple (gw-upc.owhome.net [188.167.168.254]) (Authenticated sender: juraj@lutter.sk) by svc.wilbury.net (Postfix) with ESMTPSA id 127F845CF6B; Sat, 31 Jul 2021 15:10:48 +0200 (CEST) Content-Type: text/plain; charset=utf-8 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: How to Force Packet Traversal Order (IPFW2 => PF) From: Juraj Lutter In-Reply-To: <21339cbe-59c6-5b07-bf8b-8e8612ba64da@grosbein.net> Date: Sat, 31 Jul 2021 15:10:47 +0200 Cc: alfadev , "freebsd-ipfw@FreeBSD.org" , "freebsd-hackers@FreeBSD.org" , "freebsd-pf@FreeBSD.org" Content-Transfer-Encoding: quoted-printable Message-Id: <741DA620-C7E0-4B9B-BC0A-FE1020D80D4C@FreeBSD.org> References: <21339cbe-59c6-5b07-bf8b-8e8612ba64da@grosbein.net> To: Eugene Grosbein X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, SPF_HELO_NONE,SPF_SOFTFAIL,TW_PF autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on ns2.wilbury.net X-Rspamd-Queue-Id: 4GcPlk4CVXz4TQV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 31 Jul 2021, at 10:17, Eugene Grosbein wrote: >>=20 >> IPFW and PF startup order definitions are in this files >>=20 >> Code: >>=20 >> /usr/src/sys/netpfil/ipfw/ip_fw2.c >> /usr/src/sys/netpfil/pf/pf_ioctl.c >>=20 >> I have not sufficient skills to editing kernel level files >> and tried instructions below but i couldn't changed that order. >>=20 >> I am stuck on this for weeks my mind gonna blow >> Any help would be appreciated at this point.. >=20 > You need not to edit kernel sources. AFAIK it is possible to achieve = what you need > building custom kernel with ipfw included but pf not included to the = kernel and loaded as module. >=20 I wonder if some tweaking using pfilctl(8) would do the trick. I don=E2=80= =99t have any pf+ipfw boxes. otis =E2=80=94 Juraj Lutter otis@FreeBSD.org From nobody Sat Jul 31 14:10:56 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9930512D571F for ; Sat, 31 Jul 2021 14:11:07 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound5b.ore.mailhop.org (outbound5b.ore.mailhop.org [54.190.72.79]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcR571vdmz4YqK for ; Sat, 31 Jul 2021 14:11:07 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1627740660; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=L7QjVDWhb8zVuDCba2ADxRl4CGfgTX8TTtWOT6KB3t8lITCmljNpxxcgaugBnUexvnnWcI009mr2W WrwTkR4uWtpvi61FSDzm2NaSkBfNBwBVDOkFrdWmD2k97r0D0EUS2JAcCD7MBDfKddvKsxbJvT/ydJ E1O/ada+aUNojokLglN3MHtaXqypvI3oZ/8yUQLBu3lu+byg++h3btNfzVlo8xVtodcUDJ3XnD76Rd OFlVKHbyu9x/h5QRqkvsBTPewMm0XUjIv7XIRh7CkZqWryKlqIruACjvm0vYjA0faIq4ezoJck1Aid XCpzM26+xweL7gIT2BhvX1az3+4F8lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=pQKnbUAMzuS7j/mlUGvowN+Y5YzqYyrnWlmSHMZYQS0=; b=OXQZfKYLT4mFFNkEZwaGlFrNakT//8NrkrffawvpIbYx41l9ZYYcKyyv9De+Z+Tixgjf16eFTIEbO wCrOPRhBPmjvtj0hnrKXvcv9xNBLVEZKxTGZ9tSQCZrQN8jjMTUprFgJj+l9Hz1VXXURpKnsrsBOiP gZQZbASwfyXlJRA+B/Xs3vjrRY6BbjQAwTqckg3PcRwbp6RRpuWXnDuzsw7BpBo3jGPv6f39R+DUFN iugFs8vmgiJqof4BJTimUswimUwSV3PM1CTReT/P1MMMXSUNrDz8w4sL70OTLDEjIat5DXM+730mUe +BGD/tLddqqzWLItd5fxUo4q6qCfrhw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=pQKnbUAMzuS7j/mlUGvowN+Y5YzqYyrnWlmSHMZYQS0=; b=pKbuimp3D+fvud9vagblS9f/7ZENvetM0UXax4NhUWS5csLxWfs0bRWjnoLDHIPqd4ZDS/wkYqfhd 3JrA3UPGPHp/RK5i2VPBf7KxpRPXFUwgRSsH+aYeWILSIUFBJk6LtoOBMdQt1B8QExvTuVraz1kyxf XFc9IasCg+9GN14Tz4oE88Vp6crhtFWlIiVL23jPILLJrFaCAsXCXHKbVYDqz8ZVNCZ33JAjFRhsS6 1f2kisGr+vO1DrgWof9K3TKHxIDVhXohKbEkPZvoCfF7Qum2pxIhM0BhInv6AwlTlYJ8eyB2x7A0D3 LJvML33b5nMqo8wchLRLl6EJWK8zn8A== X-Originating-IP: 67.177.211.60 X-MHO-RoutePath: aGlwcGll X-MHO-User: 1f8f7e43-f209-11eb-9343-bf9d68d023b6 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (c-67-177-211-60.hsd1.co.comcast.net [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 1f8f7e43-f209-11eb-9343-bf9d68d023b6; Sat, 31 Jul 2021 14:10:59 +0000 (UTC) Received: from [172.22.42.84] (rev2.hippie.lan [172.22.42.84]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 16VEAui8064151; Sat, 31 Jul 2021 08:10:56 -0600 (MDT) (envelope-from ian@freebsd.org) X-Authentication-Warning: paranoia.hippie.lan: Host rev2.hippie.lan [172.22.42.84] claimed to be [172.22.42.84] Message-ID: Subject: Re: How to Force Packet Traversal Order (IPFW2 => PF) From: Ian Lepore To: Juraj Lutter , Eugene Grosbein Cc: alfadev , "freebsd-ipfw@FreeBSD.org" , "freebsd-hackers@FreeBSD.org" , "freebsd-pf@FreeBSD.org" Date: Sat, 31 Jul 2021 08:10:56 -0600 In-Reply-To: <741DA620-C7E0-4B9B-BC0A-FE1020D80D4C@FreeBSD.org> References: <21339cbe-59c6-5b07-bf8b-8e8612ba64da@grosbein.net> <741DA620-C7E0-4B9B-BC0A-FE1020D80D4C@FreeBSD.org> Content-Type: text/plain; charset="windows-1251" User-Agent: Evolution 3.40.3 FreeBSD GNOME Team List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4GcR571vdmz4YqK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, 2021-07-31 at 15:10 +0200, Juraj Lutter wrote: > > > > On 31 Jul 2021, at 10:17, Eugene Grosbein > > wrote: > > > > > > IPFW and PF startup order definitions are in this files > > > > > > Code: > > > > > > /usr/src/sys/netpfil/ipfw/ip_fw2.c > > > /usr/src/sys/netpfil/pf/pf_ioctl.c > > > > > > I have not sufficient skills to editing kernel level files > > > and tried instructions below but i couldn't changed that order. > > > > > > I am stuck on this for weeks my mind gonna blow > > > Any help would be appreciated at this point.. > > > > You need not to edit kernel sources. AFAIK it is possible to > > achieve what you need > > building custom kernel with ipfw included but pf not included to > > the kernel and loaded as module. > > > > > I wonder if some tweaking using pfilctl(8) would do the trick. I > don’t have any pf+ipfw boxes. > > otis > > — > Juraj Lutter > otis@FreeBSD.org > > > I wonder if netgraph+ipfw might be a better combo than pf+ipfw to get round-robin load balancing. Or if not that directly, then maybe netgraph could help force the ordering the way you want. -- Ian From nobody Sat Jul 31 20:27:58 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 57ABA12B93CA for ; Sat, 31 Jul 2021 20:28:33 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcbSc2cWQz3DKD for ; Sat, 31 Jul 2021 20:28:32 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-lf1-f44.google.com with SMTP id r26so25596942lfp.5 for ; Sat, 31 Jul 2021 13:28:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nhleDu7ceAYxy7Qql/wEDmwCLZv5qMqa69sbSwYcCDw=; b=a9VGJHQmWohLlt17qPEEI+U5ZpPhctxbdNzJTLt1hE4jXnn3eqw+2gBTpu0miBT5Rs 5YWuhMMyS2mGgvBBCtcc3Z2jTk4gogurwOKAB2BkzD9IcCkUWPUahA0t6v6FCbp82Ofn xReD5Su6IEL7GZ/4VbaW9HlrOgXHC8FDbvPMrAqUR1Ys7KEmCdGrjnyOahkV6jSnqQ1I G+EK/iE1y0D1Mds55/14H0BctbIiuwO3K0V5iavJyrc0zJtm1xrlV+q792Y0qaCGfmc/ yVGHViK3Z1E6xFBY19hOQOOVEXDTqbllWvA6CmtStt+pPTxVr+yJbAqYdqNN7KHUyrE7 2+7g== X-Gm-Message-State: AOAM531MpAxrgKsi4sMuFd8szVjXYCZFITBQ6L9EGHT/CcylTIffZ2Va w79jHswWH4do0gTv71IK9EMiQT9i1ro3SQ== X-Google-Smtp-Source: ABdhPJyGLiywEW12sLf2i5mCACcIWXmym/xj2EHIKNnR00sh+66wyQVOaeD8W2Y9kzEoRHKwkZJ/fw== X-Received: by 2002:a05:6512:c15:: with SMTP id z21mr6842054lfu.614.1627763305095; Sat, 31 Jul 2021 13:28:25 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id o25sm422948ljc.105.2021.07.31.13.28.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 13:28:24 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id m9so18076765ljp.7 for ; Sat, 31 Jul 2021 13:28:24 -0700 (PDT) X-Received: by 2002:a2e:7305:: with SMTP id o5mr6169933ljc.280.1627763304508; Sat, 31 Jul 2021 13:28:24 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 From: Gleb Popov Date: Sat, 31 Jul 2021 23:27:58 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: acl_* API in presence of NFSv4-branded ACLs To: freebsd-hackers Content-Type: multipart/alternative; boundary="0000000000008b319705c8712d02" X-Rspamd-Queue-Id: 4GcbSc2cWQz3DKD X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of 6yearold@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=6yearold@gmail.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[freebsd.org]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[209.85.208.179:received,209.85.167.44:from]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FORGED_SENDER(0.30)[arrowd@freebsd.org,6yearold@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.44:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[arrowd@freebsd.org,6yearold@gmail.com]; MAILMAN_DEST(0.00)[freebsd-hackers]; TO_DOM_EQ_FROM_DOM(0.00)[] X-ThisMailContainsUnwantedMimeParts: Y --0000000000008b319705c8712d02 Content-Type: text/plain; charset="UTF-8" Hello hackers. While working on some Linux code that uses acl_* functions it turned out that some of them are failing for NFSv4-branded ACLs we have in FreeBSD. This looks correct in theory, as NFSv4 ACLs are not part of POSIX 1e, but in practice there is some software that assumes that "no POSIX ALCs" == "no ACLs at all". For instance, [1]: acl_t acl = acl_get_file(path.data(), ACL_TYPE_ACCESS); if (acl || defaultAcl) { // some work on acl } On FreeBSD when run on an NFSv4-branded file, the `acl_get_file` returns NULL, which makes the code believe that the file has no ACL at all. I worked this around by trying `acl_get_file` with ACL_TYPE_NFS4 first, and retrying with ACL_TYPE_ACCESS in case of failure. Another, more complicated example [2]: acl_t temp = acl_from_text(aclStr.toLatin1().constData()); if (acl_valid(temp) != 0) { // error out } else { // do useful things with temp } Reading NFSv4-branded ACL succeeds in `acl_from_text`, however, passing it into `acl_valid` results in failure, because it works only on POSIX-branded ACLs. I worked this around by checking the brand with `acl_get_brand_np` and shortcutting to 0 in !POSIX case. For both these examples I'm interested if my workarounds seem sane. Maybe something needs to be changed in our libc, instead? Thanks in advance. [1] https://invent.kde.org/frameworks/kio/-/blob/master/src/ioslaves/file/file_unix.cpp#L173 [2] https://invent.kde.org/frameworks/kio/-/blob/master/src/core/kacl.cpp#L616 --0000000000008b319705c8712d02-- From nobody Sat Jul 31 22:19:53 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4F84112BEFBA for ; Sat, 31 Jul 2021 22:20:11 +0000 (UTC) (envelope-from mber2015@gmail.com) Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcdxQ0XvJz3LCk for ; Sat, 31 Jul 2021 22:20:10 +0000 (UTC) (envelope-from mber2015@gmail.com) Received: by mail-vs1-xe32.google.com with SMTP id x66so4994938vsb.1 for ; Sat, 31 Jul 2021 15:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mber-cz.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=VpTZzIvF3PFqFZOYRqc1z727Tj7YVEzM/A2dKpNVQT4=; b=HzMENaLjpHAjQRln4GlkHH+fcadA/TTl0Qr7LnOJ/GXZUMtcnrzMVt//qYfHiaIuQP i/9H3MKiyO0sFNbZUSZiDpC68rHgUVU9EwYGcOm2PcnPH8rNgtuXjsP1CLs373HylZnR Oz9aH+eoKrKhOkRgQ4l0Y8IejJBm69fwTCz9/nrkLnyRZWI/ytmqUdw/0vbE/aTkFM5X bGz2ieo0baeUCkhryUVYdNaedsd97rErc7Mo3v8u0Hyo+6ezP9H5hjchP5qRapt+f7zg h9pmv1myV9aYtibxxAx9MCdPqxtpBIWL6UjYG2OglIpxuT6CuSRHd489pOFyWY28LJH7 H1WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=VpTZzIvF3PFqFZOYRqc1z727Tj7YVEzM/A2dKpNVQT4=; b=YJj0Z3z64rBF+UoBmsyBcpVA3uqq7IIdlNIYPy9uZs7YGi31dzkcf+ccCfvNrck2Cp hdMYoerz1xjB0wYjCJtz2wBAxoCTmCR8BNzyVz1IG0tljXBFs4J+bJXLGk6nHd2oBMT1 55l25VVhS05eYoznynmkuIWWm/xvj3CmwMwMUYzAhyeoKQBQjeJUeN8S7vsKVwbaewKl V3ep17pOEq2bOlhZqUAkxTtd86DEMH60LDJo9sTpJAwUPLHKNx8Ffz23mRly8nSAw3w4 K8zr4M6TLs7oVLrY3dZN5bQqrmorH3PQ4gvhIv04f+Qv+rEUruAm6d2p9GnK2QiqKyLE iaiw== X-Gm-Message-State: AOAM5333MRT4nfHygd4W2aPUJCMKAFxnxUKHIR7rRTXkdF/4Txu4Xgnr EsPFblCcAwSGZIOwATM/vEYdfnwYejMaElnMX+SxUAJk/6eU8g== X-Google-Smtp-Source: ABdhPJy5NvWQa9yKQg543PA+nleZ+I8Ay0PYnQsC9wlkvulsL1fzIEshayWLgU13nLQxneEfUTtij99Izm2gtLFkIW4= X-Received: by 2002:a05:6102:20c5:: with SMTP id i5mr1969435vsr.3.1627770009504; Sat, 31 Jul 2021 15:20:09 -0700 (PDT) List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Martin Beran Date: Sun, 1 Aug 2021 00:19:53 +0200 Message-ID: Subject: Re: How to Force Packet Traversal Order (IPFW2 => PF) Cc: "freebsd-hackers@FreeBSD.org" Content-Type: multipart/alternative; boundary="000000000000314f7705c872bdb6" X-Rspamd-Queue-Id: 4GcdxQ0XvJz3LCk X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mber-cz.20150623.gappssmtp.com header.s=20150623 header.b=HzMENaLj; dmarc=none; spf=pass (mx1.freebsd.org: domain of mber2015@gmail.com designates 2607:f8b0:4864:20::e32 as permitted sender) smtp.mailfrom=mber2015@gmail.com X-Spamd-Result: default: False [-0.87 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[mber-cz.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; DMARC_NA(0.00)[mber.cz]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_TRACE(0.00)[mber-cz.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.67)[-0.671]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::e32:from]; MISSING_TO(2.00)[]; TO_DN_EQ_ADDR_ALL(0.00)[]; FORGED_SENDER(0.30)[martin@mber.cz,mber2015@gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[martin@mber.cz,mber2015@gmail.com]; MAILMAN_DEST(0.00)[freebsd-hackers]; RCVD_COUNT_TWO(0.00)[2] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: Y --000000000000314f7705c872bdb6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable p=C3=A1 30. 7. 2021 v 13:41 odes=C3=ADlatel alfadev via freebsd-ipfw < freebsd-ipfw@freebsd.org> napsal: > Hi, > I have to use both IPFW and PF sametime in my freebsd 12.2 gateway > > According to my observations firewalls are following this order all of my > scenarios PF =3D> IPFW2. I see this exactly When i use PF's route-to opti= on . > When i create Load-Balancing rule using PF's route-to, packets not enteri= ng > into IPFW. So when i made PBR, IPFW rules like mac based piping, bandwidt= h, > captive portal etc. does not works. > So that > i am trying to do this order: > input =3D> ipfw =3D> pf > > but i think i cannot change this order without touching kernel level . > when i made some research i found [this]( > https://www.opennet.ru/tips/info/1431.shtml) > https://www.opennet.ru/tips/info/1431.shtml > I think that you do not need to touch kernel source, nor build a custom kernel. The order of calling packet filtering modules depends on the order of registering the modules to packet processing hooks. Instead of loading the modules by their respective startup scripts, you can load them in the required order by including them in /etc/rc.conf in variable kld_list. I do not remember if the order of calling is the same or the opposite of the order of module loading. Martin Beran --000000000000314f7705c872bdb6-- From nobody Sat Jul 31 23:48:40 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 330A312D49A0 for ; Sat, 31 Jul 2021 23:49:54 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.org (uucp.dinoex.org [IPv6:2a0b:f840::12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "uucp.dinoex.sub.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gcgwx26CDz3hrj for ; Sat, 31 Jul 2021 23:49:53 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp.dinoex.org [185.220.148.12]) by uucp.dinoex.org (8.16.1/8.16.0.50) with ESMTPS id 16VNnjPj005934 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 1 Aug 2021 01:49:45 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) X-MDaemon-Deliver-To: X-Authentication-Warning: uucp.dinoex.sub.de: Host uucp.dinoex.org [185.220.148.12] claimed to be uucp.dinoex.sub.de Received: (from uucp@localhost) by uucp.dinoex.sub.de (8.16.1/8.16.0.50/Submit) with UUCP id 16VNnjH5005933 for freebsd-hackers@freebsd.org; Sun, 1 Aug 2021 01:49:45 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from gate.intra.daemon.contact (gate-e [192.168.98.2]) by citylink.dinoex.sub.de (8.16.1/8.16.1) with ESMTP id 16VNnUeJ046825 for ; Sun, 1 Aug 2021 01:49:30 +0200 (CEST) (envelope-from peter@gate.intra.daemon.contact) Received: from gate.intra.daemon.contact (gate-e [192.168.98.2]) by gate.intra.daemon.contact (8.16.1/8.16.1) with ESMTPS id 16VNmeOa046613 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 1 Aug 2021 01:48:40 +0200 (CEST) (envelope-from peter@gate.intra.daemon.contact) Received: (from peter@localhost) by gate.intra.daemon.contact (8.16.1/8.16.1/Submit) id 16VNme32046612 for freebsd-hackers@freebsd.org; Sun, 1 Aug 2021 01:48:40 +0200 (CEST) (envelope-from peter) Date: Sun, 1 Aug 2021 01:48:40 +0200 From: Peter To: freebsd-hackers@freebsd.org Subject: (patch) Re: Periodic rant about SCHED_ULE Message-ID: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Milter: Spamilter (Reciever: uucp.dinoex.sub.de; Sender-ip: 185.220.148.12; Sender-helo: uucp.dinoex.sub.de;) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.4 (uucp.dinoex.org [185.220.148.12]); Sun, 01 Aug 2021 01:49:48 +0200 (CEST) X-Rspamd-Queue-Id: 4Gcgwx26CDz3hrj X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of pmc@citylink.dinoex.sub.org has no SPF policy when checking 2a0b:f840::12) smtp.mailfrom=pmc@citylink.dinoex.sub.org X-Spamd-Result: default: False [-0.45 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.40)[-0.401]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; TO_DN_NONE(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; NEURAL_SPAM_SHORT(0.05)[0.051]; DMARC_NA(0.00)[sub.org]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:205376, ipnet:2a0b:f840::/32, country:DE]; RCVD_TLS_LAST(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers] X-ThisMailContainsUnwantedMimeParts: N Hi all, let's hope I can post now. Somehow my subscriptions have been deleted and I cannot not post anymore to the lists, and *some* of them (e.g. "stable") have also ceased to deliver, since 3rd July. Neither can I find a notification about such change. Now I am trying to subsribe anew... hth (Such unsuspected changes are something that makes me angry) I was just seeing the discussion about Sched-ULE. I myself was once hit by a serious flaw in the performing of sched-ULE, so I went into the source and fixed that specific matter. It solves the issue that of multiple compute jobs the one with the least I/O gets starved; I don't know if there are side-effects or downsides. I don't notice a performance impact, but I have no idea how this might behave on e.g. networking routers or such. During fixing I found one or two other obvious bugs in the code. I tried to talk to the developer, but that communication somehow ended in mid-air. I don't know what to further do with this - a patch of mine lingers in the sendbug facility for some 12 years already without being reacted on, so it is pointless to send patches. And in this case I don't even know if this one does suit all conditions except solving my problem. (It's not about absolute performance, but about making things run evenly.) So here it is, here you have it and see to it. The thing is switchable in runtime, you get a new sysctl kern.sched.resume_preempted, "1" gives the default behaviour from distribution, "0" activates the patch. Maybe it helps for one or the other. Cheerio. diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 50f037076f4..f0bb6b38db4 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -38,7 +38,7 @@ */ #include -__FBSDID("$FreeBSD$"); +__FBSDID("$FreeBSD: releng/12.2/sys/kern/sched_ule.c 355610 2019-12-11 15:15:21Z mav $"); #include "opt_hwpmc_hooks.h" #include "opt_sched.h" @@ -223,6 +223,7 @@ static int __read_mostly preempt_thresh = 0; static int __read_mostly static_boost = PRI_MIN_BATCH; static int __read_mostly sched_idlespins = 10000; static int __read_mostly sched_idlespinthresh = -1; +static int __read_mostly resume_preempted = 1; /* * tdq - per processor runqs and statistics. All fields are protected by the @@ -483,7 +484,10 @@ tdq_runq_add(struct tdq *tdq, struct thread *td, int flags) * This queue contains only priorities between MIN and MAX * realtime. Use the whole queue to represent these values. */ - if ((flags & (SRQ_BORROWING|SRQ_PREEMPTED)) == 0) { + if (((flags & SRQ_PREEMPTED) && resume_preempted) || + (flags & SRQ_BORROWING)) + pri = tdq->tdq_ridx; + else { pri = RQ_NQS * (pri - PRI_MIN_BATCH) / PRI_BATCH_RANGE; pri = (pri + tdq->tdq_idx) % RQ_NQS; /* @@ -494,8 +498,7 @@ tdq_runq_add(struct tdq *tdq, struct thread *td, int flags) if (tdq->tdq_ridx != tdq->tdq_idx && pri == tdq->tdq_ridx) pri = (unsigned char)(pri - 1) % RQ_NQS; - } else - pri = tdq->tdq_ridx; + } runq_add_pri(ts->ts_runq, td, pri, flags); return; } else @@ -3073,6 +3076,9 @@ SYSCTL_INT(_kern_sched, OID_AUTO, interact, CTLFLAG_RW, &sched_interact, 0, SYSCTL_INT(_kern_sched, OID_AUTO, preempt_thresh, CTLFLAG_RW, &preempt_thresh, 0, "Maximal (lowest) priority for preemption"); +SYSCTL_INT(_kern_sched, OID_AUTO, resume_preempted, CTLFLAG_RW, + &resume_preempted, 0, + "Reinsert preemted threads at queue-head"); SYSCTL_INT(_kern_sched, OID_AUTO, static_boost, CTLFLAG_RW, &static_boost, 0, "Assign static kernel priorities to sleeping threads"); SYSCTL_INT(_kern_sched, OID_AUTO, idlespins, CTLFLAG_RW, &sched_idlespins, 0, From nobody Sat Jul 31 23:51:58 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 09C5C12D5463 for ; Sat, 31 Jul 2021 23:53:24 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.org (uucp.dinoex.org [IPv6:2a0b:f840::12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "uucp.dinoex.sub.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Gch0z2Lvzz3jnc for ; Sat, 31 Jul 2021 23:53:23 +0000 (UTC) (envelope-from pmc@citylink.dinoex.sub.org) Received: from uucp.dinoex.sub.de (uucp.dinoex.org [185.220.148.12]) by uucp.dinoex.org (8.16.1/8.16.0.50) with ESMTPS id 16VNqupR009131 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 1 Aug 2021 01:52:56 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) X-MDaemon-Deliver-To: X-Authentication-Warning: uucp.dinoex.sub.de: Host uucp.dinoex.org [185.220.148.12] claimed to be uucp.dinoex.sub.de Received: (from uucp@localhost) by uucp.dinoex.sub.de (8.16.1/8.16.0.50/Submit) with UUCP id 16VNquae009130 for freebsd-hackers@freebsd.org; Sun, 1 Aug 2021 01:52:56 +0200 (CEST) (envelope-from pmc@citylink.dinoex.sub.org) Received: from gate.intra.daemon.contact (gate-e [192.168.98.2]) by citylink.dinoex.sub.de (8.16.1/8.16.1) with ESMTP id 16VNqfZ7047363 for ; Sun, 1 Aug 2021 01:52:41 +0200 (CEST) (envelope-from peter@gate.intra.daemon.contact) Received: from gate.intra.daemon.contact (gate-e [192.168.98.2]) by gate.intra.daemon.contact (8.16.1/8.16.1) with ESMTPS id 16VNpwn7047253 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Sun, 1 Aug 2021 01:51:58 +0200 (CEST) (envelope-from peter@gate.intra.daemon.contact) Received: (from peter@localhost) by gate.intra.daemon.contact (8.16.1/8.16.1/Submit) id 16VNpw1T047252 for freebsd-hackers@freebsd.org; Sun, 1 Aug 2021 01:51:58 +0200 (CEST) (envelope-from peter) Date: Sun, 1 Aug 2021 01:51:58 +0200 From: Peter To: freebsd-hackers@freebsd.org Subject: TAP device deletes VLAN tag? (netgraph related) Message-ID: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Milter: Spamilter (Reciever: uucp.dinoex.sub.de; Sender-ip: 185.220.148.12; Sender-helo: uucp.dinoex.sub.de;) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.4 (uucp.dinoex.org [185.220.148.12]); Sun, 01 Aug 2021 01:52:58 +0200 (CEST) X-Rspamd-Queue-Id: 4Gch0z2Lvzz3jnc X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of pmc@citylink.dinoex.sub.org has no SPF policy when checking 2a0b:f840::12) smtp.mailfrom=pmc@citylink.dinoex.sub.org X-Spamd-Result: default: False [-0.92 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.81)[-0.811]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-hackers@freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_NONE(0.00)[]; NEURAL_HAM_SHORT(-0.01)[-0.012]; DMARC_NA(0.00)[sub.org]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:205376, ipnet:2a0b:f840::/32, country:DE]; RCVD_TLS_LAST(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[]; MAILMAN_DEST(0.00)[freebsd-hackers] X-ThisMailContainsUnwantedMimeParts: N Sending here since "stable" still doesn't work... Hi all, I found a problem when connecting tap devices. In the most straightforward way I would do # ngctl connect tap1: fxp0: lower lower Then doing tcpdump on both netifs, the originating (in my case tap0) has the VLAN tag, and the receiving doesn't show it anymore. The same happens when attaching a tap device to a ng_bridge or ng_hub: the tap device (and the bhyve behind it) will not see the VLAN tags arriving from elsewhere on the bridge. The tap device itself seems to support vlan tags. So the problem appears to be most likely related to the netgraph hook of the tap device (the lower, in my case). This is Rel. 12.2 running. Is this a known problem? Is there a patch or workaround known? rgds, PMc From nobody Sun Aug 1 22:02:33 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 58E7E12B5DD2 for ; Sun, 1 Aug 2021 22:02:35 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GdFVg22Cvz3sfX; Sun, 1 Aug 2021 22:02:35 +0000 (UTC) (envelope-from leres@freebsd.org) Received: from ice.alameda.xse.com (unknown [IPv6:2600:1700:a570:e20:f2ad:4eff:fe09:150e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: leres) by smtp.freebsd.org (Postfix) with ESMTPSA id CFA3B266C3; Sun, 1 Aug 2021 22:02:34 +0000 (UTC) (envelope-from leres@freebsd.org) Subject: Re: pkg/poudriere: dangling symlink to pkg.pkg.sig To: Baptiste Daroussin Cc: freebsd-hackers@freebsd.org References: <2adca193-dbeb-8b5a-47a6-9e40e56ee80d@freebsd.org> <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> From: Craig Leres Message-ID: <44e045d2-cd8c-f353-f8e5-31304330eb94@freebsd.org> Date: Sun, 1 Aug 2021 15:02:33 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 In-Reply-To: <20210729074107.yuv6a4tcj55wpbvt@aniel.nours.eu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 7/29/21 12:41 AM, Baptiste Daroussin wrote: > On Tue, Jul 27, 2021 at 02:05:14PM -0700, Craig Leres wrote: >> For the last few days, approximately corresponding to when the pkg port >> upgraded to 1.17.0, the poudriere build process has been creating a dangling >> symlink from pkg.txz.sig to pkg.pkg.sig. Posting an issue to >> github.com/freebsd/pkg did not prove useful; does anyone understand what >> broke (and how to fix it)? >> >> I ran into this because I use a cron job to archive poudriere build trees; >> the job does a diff -r of the latest pkg tree vs. the most recent archived >> tree (to decide if the new tree is worth archiving). >> >> Craig >> > I told you to have a look at the commit in the ports tree in the github issue, > which apparently you did not. > > In particular: > https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=ec2764d5ec4933f52cb0718663f60f1e1b1eed7f Thank you for providing the specific commit that caused the issue I was trying to understand. This is infinitely more helpful than the, "please read the commit logs in the ports tree" response I got when I opened a github issue with pkg. Craig