From nobody Wed Oct 13 18:35:18 2021 X-Original-To: pkg@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 158CF17FECEC for ; Wed, 13 Oct 2021 18:35:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HV1Rn73H4z4b5L for ; Wed, 13 Oct 2021 18:35:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D32F32C9D1 for ; Wed, 13 Oct 2021 18:35:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 19DIZHfb043205 for ; Wed, 13 Oct 2021 18:35:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 19DIZHNu043204 for pkg@FreeBSD.org; Wed, 13 Oct 2021 18:35:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: pkg@FreeBSD.org Subject: maintainer-feedback requested: [Bug 259150] ports-mgmt/pkg: pkg install does not check FreeBSD_version annotation Date: Wed, 13 Oct 2021 18:35:18 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: pkg@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Binary package management and package tools discussion List-Archive: https://lists.freebsd.org/archives/freebsd-pkg List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-pkg@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-pkg (Nobody) for maintainer-feedback: Bug 259150: ports-mgmt/pkg: pkg install does not check FreeBSD_version annotation https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D259150 --- Description --- Overview: Calling `pkg install $LOCAL_FILE`, where LOCAL_FILE is either a local pa= th to a valid package file or a file scheme URI, never checks the `FreeBSD_version` metadata to see if the package file is from a future version of FreeBSD. This check is always performed when installing a local file with the `pkg add` command, unless the `IGNORE_OSVER` option is set. Steps to Reproduce: 1) Download the attached MANIFEST file. 2) Create a test package by running: pkg create -M $PATH_TO_MANIFEST_FILE pkg-create will write a file in the current directory named `fromthefuture-0.pkg` 3) Attempt to install using pkg-add: `pkg add fromthefuture-0.pkg` This will fail with the error: "pkg: Newer FreeBSD version for package fromthefuture" 4) Attempt to install using pkg-install: `pkg install /absolute/path/to/fromthefuture-0.pkg` This will succeed, despite the FreeBSD version mismatch. 5) Don't forget to remove this bogus package: `pkg remove -y fromthefuture` Actual Results: `pkg install` succeeded where `pkg add` refused. Expected Results: Both entrypoints to installing a package should perform the same checks on local package files. Build Date & Hardware: pkg 1.17.2 on FreeBSD 13.0-STABLE Additional Information: This behavior occurs due to the condition on line 1110 of pkg_add.c, in pkg_add_common(): =20=20 https://github.com/freebsd/pkg/blob/ef8e71553deb048004d40b70806867d6fa05b26= b/li bpkg/pkg_add.c#L1107-L1118 `pkg install` reaches `pkg_add_common()` via the wrapper function `pkg_add_from_remote()`, while `pkg add` reaches it via the wrapper function `pkg_add()`. The latter NULLs the `remote` argument, while the former passes a `struct pkg` pointer. In either case, the effect is to install a package from a local file. I'm mulling over the right way to possibly fix this, because the job executor is involved in `pkg install`. Therefore, it's a question where the "local file" detection code should live. Food for thought.