From nobody Thu Jun 24 16:51:29 2021 X-Original-To: freebsd-scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DC1F211D999F for ; Thu, 24 Jun 2021 16:51:42 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G9mPV0Bvvz4r3H for ; Thu, 24 Jun 2021 16:51:41 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-pl1-x630.google.com with SMTP id h1so3274788plt.1 for ; Thu, 24 Jun 2021 09:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=9wTOgPghdT8Y11BLW3DRpAVinRTta+k7jwSWaluqXyo=; b=niJ7ZPcX2RIEQ8U0geXwv/69+C2K5QrEVMqAvNTDEZQ5x+GjU77SZ1ap3SaNweXGke KzUkc3TfkUfE2m+ye/jCviOctIhhACE3vnxL+jp+HjCXYRahKAIjM6mcX+eYZ8Sp3wby xTmeV99MbNHpC1NpeuZS2H07AsKbH44m8qA8xbc7tbinEof7NHfVz2rckl0Xfdy/4DSE knnGnIXrEi4iJv+d2rRv+lnXkQhWQ0INQru7Ws2WiRsIl3iHaLE94vrFTzeOT7U3o5Ug 2b4UTeOR37vIAIR7c+KqhOTL3P15cCIhMsvUirdHpneaggVu+tM920WeEvixMHvByAP2 k3hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=9wTOgPghdT8Y11BLW3DRpAVinRTta+k7jwSWaluqXyo=; b=S6UKfay30c3Pzk6SCWTnJ3mxCljTvdV3eMq2JfQnsG82VpBGKy864JRPchoIsF102i OyILG5zhsIrGkiLiDq3tH3RBy/omckScW5eM1Qk+xnNErOqUWODSaBwc7GgA+dzK9Cnc oVl+42lYXMsmFf12fuMU7hxnrkMzEUv1An0hVvUhFy8faJImRUpMzV3/AgGGq0iKS3qP SLmSk+uRn0BtWvcMs3QGyJFTXpmmWVMjrqV48Tg4ayQEmdOqEFSDpBMpMKsIP9M2ojRz 0Wm1FkCWx/FCNNYXcTDZj6AFOYcg9jQ+8nLZ5fRQ8Rf3THzfoQSV41TDJPB2ATniI3iL vMNQ== X-Gm-Message-State: AOAM5328Mz27hCExQiKsEHIo0kPZCsx4cwPrn3rzwbe25TudL+QMz8Tc 4L1Dd3KgQm6H5bGvQ5Q5CE1In1qGpGkesMKc0/olSFvG0aE= X-Google-Smtp-Source: ABdhPJwyW8l5wYH7edlgdIgqlC83Z9aU/x/ODde//PuQagm51LIti/LARVWXF7ueHjrVdjavcvr/lAVR2HAfaWWrZYk= X-Received: by 2002:a17:902:9b86:b029:127:e1f5:5e1b with SMTP id y6-20020a1709029b86b0290127e1f55e1bmr114922plp.77.1624553500286; Thu, 24 Jun 2021 09:51:40 -0700 (PDT) List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org MIME-Version: 1.0 From: Ryan Stone Date: Thu, 24 Jun 2021 12:51:29 -0400 Message-ID: Subject: Converting ctl.conf to UCL To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4G9mPV0Bvvz4r3H X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=niJ7ZPcX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::630 as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-3.83 / 15.00]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.83)[-0.830]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::630:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-scsi@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::630:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::630:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-scsi] X-ThisMailContainsUnwantedMimeParts: N I'm trying to use configure ctld to create virtual disks suitable for use with virtio-scsi (I'm working with a VM that is hardcoded to require scsi disks, so the other virtio disk providers unfortunately can't be used in my case). I would like to use ctl.conf in UCL format so I can use UCL's file inclusion facilities, which will simplify managing my configuration. Unfortunately, I'm having trouble converting a file to UCL format and I'm beginning to suspect that the manpage is missing something. Here is my test configuration, which does work for me: lun foo_test_storage0 { serial "f1-1-1"; path "/usr/local/vmrc/vm/foo-test/storageHDD0.img"; } lun foo_test_storage1 { serial "f1-1-2"; path "/usr/local/vmrc/vm/foo-test/storageHDD1.img"; } target "iqn.com.example:foo-test" { port "ioctl/11/1" lun 0 foo_test_storage0 lun 1 foo_test_storage1 } My attempt at a UCL version resulted in this: lun { foo_test_storage0 { serial = "f1-1-1" path = "/usr/local/vmrc/vm/foo-test/storageHDD0.img" } foo_test_storage1 { serial = "f1-1-2" path = "/usr/local/vmrc/vm/foo-test/storageHDD1.img" } } target { "iqn.com.example:foo-test" { port = "ioctl/11/1" lun = [ { number = 0, name = foo_test_storage0 }, { number = 1, name = foo_test_storage1 } , ] } } But I just get the error: Starting ctld. ctld: no LUNs defined for target "iqn.com.example:foo-test" This seems to match the sample in the manpage, so I'm confused as to what has gone wrong. Does anybody have any pointers? From nobody Thu Jun 24 17:37:46 2021 X-Original-To: freebsd-scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4E56D11DB9FA for ; Thu, 24 Jun 2021 17:38:00 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G9nQv3qSFz4tvl for ; Thu, 24 Jun 2021 17:37:59 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-pj1-x102f.google.com with SMTP id k5so3924504pjj.1 for ; Thu, 24 Jun 2021 10:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=o93lm0SEBc0+O7r2i4QlgWkRcI1DOCkhBlHgEa1wMD8=; b=k6JgYI9YrzQL4qJj1rzkPYW4afoXrXHtRPxH0Ed9uuVIkrf6s8zZ+ak5fJ47x1tAey YuhQrGLcOpJg5C1d2hDdi/mv0qhxhNvgkoC/5mQElV/gA1cRgX7db4NRY5tG+fGS0ts2 v8YaX/IFsUZ1V8Fmw6Ob7Iv7xPYK2rqzURjODcoEq3kSuVPIobHlR3sdco1KLAiPgdRm pyCU+iw+FZgR3io/Oz0H0WdjFhOA98wd3PzIqzZkpWvlR8jXGFpcTvZdWis5PCO5d0vV EyBhkizlB6hoGNOSCuQCRBdLc5k1ZT4JgFlRFoiwbz1zduQyr2wBtKv+d4mx3pI1n+TQ DnWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=o93lm0SEBc0+O7r2i4QlgWkRcI1DOCkhBlHgEa1wMD8=; b=coliyK67jcnB6Q8Ga93Kb9bOUhrrRXYKB1mqFzbAowQZ78g3i6+KoVFjANHC53slRh kLPyYcqhCFPEpqjCsdbbrGEuYI9X4CFe8zJretG5osSh2ihVzObLy/ACaKnReQFVE9q+ 2LSa5xj9ZvTASSjhA+TECMZ9blsx8Df400Yd1yNT3RvuBxVY5UgNkahlubXNOQsszZdR ws07lo5o4/FWl0KRScROcmpxHN4rrLknhiRXfKQRyuQAqbefk0uu/8Q51w/pWhT7p7zQ 6yas79nv2cMmi+jgTaBSy0ZPwvbtYmG7nyeXMpy+v7snRAqaNz+QU0v1h7clyg3X2QxF cIPQ== X-Gm-Message-State: AOAM532c0OQXBluMv2n5rOgIqfVUhh/CvpMK+He6mNr0pNuMAxdyIo3/ Fkp6vgh1RgsWc+AH667wrhOAuDC0w0ryz2TeWvLN6iLuedA= X-Google-Smtp-Source: ABdhPJxMJvGw+A3Th/cZ9StfjndhPN9vojITWoxUNwMd8hspS0A32se99Hg3BpPahgd20ofi282qzz0rlugOoKFqz9s= X-Received: by 2002:a17:903:304e:b029:11d:41c:fa73 with SMTP id u14-20020a170903304eb029011d041cfa73mr5214759pla.82.1624556277179; Thu, 24 Jun 2021 10:37:57 -0700 (PDT) List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Ryan Stone Date: Thu, 24 Jun 2021 13:37:46 -0400 Message-ID: Subject: Re: Converting ctl.conf to UCL To: freebsd-scsi@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4G9nQv3qSFz4tvl X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=k6JgYI9Y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rysto32@gmail.com designates 2607:f8b0:4864:20::102f as permitted sender) smtp.mailfrom=rysto32@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::102f:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-scsi@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::102f:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102f:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-scsi] X-ThisMailContainsUnwantedMimeParts: N I found the problem. My configuration falls into this special case for the target port config: https://cgit.freebsd.org/src/tree/usr.sbin/ctld/uclparse.c#n841 The early return in that block means that the lun property is never parsed. Moving the port property to the end fixes the issue, but this looks like a bug to me. I think that a continue is probably more appropriate here than a return 0. From nobody Sun Jun 27 21:00:39 2021 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2D55211E7592 for ; Sun, 27 Jun 2021 21:00:41 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GCjnN4HNJz4svc for ; Sun, 27 Jun 2021 21:00:40 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 169FD19115 for ; Sun, 27 Jun 2021 21:00:40 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 15RL0d6B042522 for ; Sun, 27 Jun 2021 21:00:40 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 15RL0dGJ042521 for scsi@FreeBSD.org; Sun, 27 Jun 2021 21:00:39 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <202106272100.15RL0dGJ042521@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: scsi@FreeBSD.org Subject: Problem reports for scsi@FreeBSD.org that need special attention Date: Sun, 27 Jun 2021 21:00:39 +0000 List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="16248276396.3ea29a22.41516" Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: Y --16248276396.3ea29a22.41516 Date: Sun, 27 Jun 2021 21:00:39 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 221952 | cam iosched: Fix trim statistics 1 problems total for which you should take action. --16248276396.3ea29a22.41516--