Date: Fri, 13 Jul 2012 11:15:39 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: sbruno@FreeBSD.org Cc: "freebsd-acpi@freebsd.org" <freebsd-acpi@FreeBSD.org>, Giovanni Trematerra <gianni@FreeBSD.org>, Sean Bruno <seanbru@yahoo-inc.com>, John Baldwin <jhb@FreeBSD.org>, Vitaly Magerya <vmagerya@gmail.com> Subject: Re: improve cx_lowest logic Message-ID: <4FFFD92B.8080600@FreeBSD.org> In-Reply-To: <1341935370.4493.4.camel@powernoodle> References: <4FF95F79.30309@FreeBSD.org> <1341935370.4493.4.camel@powernoodle>
next in thread | previous in thread | raw e-mail | index | archive | help
on 10/07/2012 18:49 Sean Bruno said the following: > On Sun, 2012-07-08 at 03:22 -0700, Andriy Gapon wrote: >> I would like to propose the following change for review and testing: >> http://people.freebsd.org/~avg/acpi_cpu_cx_lowest.diff > > Very nice. After a review I went ahead and applied it for testing. All > seems to be well on battery and A/C on my T520 so I'm very happy to see > this go into the tree. > > Let me know if you want me to do the man page update for acpi_cpu(4) Sean, I would appreciate this a lot as I am currently a little bit busier than usual. On a related note I also have this change for acpi.4: --- a/share/man/man4/acpi.4 +++ b/share/man/man4/acpi.4 @@ -80,8 +80,12 @@ A scheduling algorithm will select states between and this setting as system load dictates. To enable ACPI CPU idling control, -.Va machdep.cpu_idle_hlt -must be set to 1. +.Va machdep.idle +should be set to +.Li acpi +if it is listed in +.Va machdep.idle_available +. .It Va hw.acpi.cpu.cx_supported List of supported CPU idle states and their transition latency in microseconds. How does this look? -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FFFD92B.8080600>