Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Jul 2009 13:40:19 -0400
From:      Adam McDougall <mcdouga9@egr.msu.edu>
To:        Erwin Lansing <erwin@FreeBSD.org>
Cc:        cvs-ports@freebsd.org, Giorgos Keramidas <keramida@freebsd.org>, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/mail/postfix/files patch-src::util::sys_defs.h
Message-ID:  <4A5F6603.3010401@egr.msu.edu>
In-Reply-To: <20090709143714.GA86673@droso.net>
References:  <200907091315.n69DF7jL036835@repoman.freebsd.org>	<20090709140850.GZ86673@droso.net> <87iqi2x7st.fsf@kobe.laptop> <20090709143714.GA86673@droso.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Erwin Lansing wrote:
> On Thu, Jul 09, 2009 at 05:14:26PM +0300, Giorgos Keramidas wrote:
>   
>> On Thu, 9 Jul 2009 16:08:52 +0200, Erwin Lansing <erwin@FreeBSD.org> wrote:
>>     
>>> On Thu, Jul 09, 2009 at 01:15:07PM +0000, Giorgos Keramidas wrote:
>>>       
>>>> keramida    2009-07-09 13:15:07 UTC
>>>>
>>>>   FreeBSD ports repository (doc committer)
>>>>
>>>>   Added files:
>>>>     mail/postfix/files   patch-src::util::sys_defs.h
>>>>   Log:
>>>>   Patch the src/util/sys_defs.h file of Postfix to fix the build on
>>>>   FreeBSD-8.0 after the new closefrom() system call was added.
>>>>
>>>>   PR:             ports/136459
>>>>   Submitted by:   Eygene Ryabinkin
>>>>   Approved by:    erwin (portmgr), Sahil Tandon (maintainer)
>>>>         
>>> Well, I just confirmed that the ports tree isn't frozen yet before the
>>> 8.0 release, so that doesn't really warrent an approved by line.  I
>>> didn't actually review the diff, just noted that no explicit approval
>>> from portmgr was required.
>>>       
>> I misread the reply then.  I thought you had looked at the diff :/
>>
>>     
> No worries, thanks for taking care of this.
>
>
>   
I think this is now needed on 7-stable as well as of svn 195694 (702104):

cc -DDEF_CONFIG_DIR=\"/usr/local/etc/postfix\" 
-DDEF_DAEMON_DIR=\"/usr/local/libexec/postfix\" 
-DDEF_COMMAND_DIR=\"/usr/local/sbin\" 
-DDEF_SENDMAIL_PATH=\"/usr/local/sbin/sendmail\" 
-DDEF_NEWALIAS_PATH=\"/usr/local/bin/newaliases\" 
-DDEF_MAILQ_PATH=\"/usr/local/bin/mailq\" 
-DDEF_MANPAGE_DIR=\"/usr/local/man\" 
-DDEF_README_DIR=\"/usr/local/share/doc/postfix\" 
-DDEF_HTML_DIR=\"/usr/local/share/doc/postfix\" 
-DDEF_QUEUE_DIR=\"/var/spool/postfix\" 
-DDEF_DATA_DIR=\"/var/db/postfix\" -DDEF_MAIL_OWNER=\"postfix\" 
-DDEF_SGID_GROUP=\"maildrop\" -DHAS_PCRE -I/usr/local/include  -O2 
-fno-strict-aliasing -pipe -I. -DFREEBSD7 -c attr_clnt.c
In file included from attr_clnt.c:77:
/usr/include/unistd.h:329: error: conflicting types for 'closefrom'
./sys_defs.h:1404: error: previous declaration of 'closefrom' was here
*** Error code 1

Stop in /var/tmp/ports/usr/ports/mail/postfix/work/postfix-2.6.2/src/util.
*** Error code 1

Thanks



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A5F6603.3010401>