From owner-freebsd-stable Thu Jul 27 6: 7:55 2000 Delivered-To: freebsd-stable@freebsd.org Received: from privatecube.privatelabs.com (privatecube.privatelabs.com [198.143.31.30]) by hub.freebsd.org (Postfix) with ESMTP id 14E8337B6E0 for ; Thu, 27 Jul 2000 06:07:47 -0700 (PDT) (envelope-from mi@virtual-estates.net) Received: from misha.privatelabs.com (misha.privatelabs.com [198.143.31.6]) by privatecube.privatelabs.com (8.9.3/8.9.2) with ESMTP id IAA15846; Thu, 27 Jul 2000 08:06:44 -0400 Received: from virtual-estates.net (localhost [127.0.0.1]) by misha.privatelabs.com (8.9.3/8.9.3) with ESMTP id JAA10433; Thu, 27 Jul 2000 09:02:51 -0400 (EDT) (envelope-from mi@virtual-estates.net) Message-Id: <200007271302.JAA10433@misha.privatelabs.com> Date: Thu, 27 Jul 2000 09:02:48 -0400 (EDT) From: mi@aldan.algebra.com Subject: Re: [pcm0 play interrupt timeout, channel dead] and other problems To: Devin Butterfield Cc: Bill Fumerola , hdiwan@pobox.com, Hasan Diwan , stable@FreeBSD.ORG In-Reply-To: <00072700392500.20332@dbm.wireless.net> MIME-Version: 1.0 Content-Type: TEXT/plain; CHARSET=US-ASCII Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 27 Jul, Devin Butterfield wrote: = = > Index: channel.c = > =================================================================== = > RCS file: /home/ncvs/src/sys/dev/sound/pcm/channel.c,v = > retrieving revision 1.32 = > diff -u -r1.32 channel.c = > --- channel.c 2000/06/20 23:42:08 1.32 = > +++ channel.c 2000/07/22 17:36:34 = > @@ -234,7 +234,7 @@ = > b->fl = b->bufsize - b->rl; = > b->underflow = 0; = > } else { = > - /* chn_dmaupdate(c); */ = > + chn_dmaupdate(c); = > } = > } = > = = Very cool. Thanks Bill (and everyone else who replied), this patch = works great! Sound is working well now on my Sony Vaio. :) Congratulations! Now, could someone explain why is it a bad idea to commit this change -- evidently it was already there but got commented out? The new release (which, apparently, does not have this) will still mal-function for many people. Are we going to be circulating this patches like Linux world does? -mi To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message