Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 10 Aug 2016 11:44:45 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r303934 - head/usr.bin/truss
Message-ID:  <1114effc-e527-923d-b6fe-c6dda2f8407c@FreeBSD.org>
In-Reply-To: <20160810184102.GW83214@kib.kiev.ua>
References:  <201608101819.u7AIJHIh079589@repo.freebsd.org> <20160810184102.GW83214@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CcR3ANKfps1DDAGP0FkL6XVmlX6iSR5Og
Content-Type: multipart/mixed; boundary="T0EUKiFDXB7gxSunFUGudXqBwc8tp8FDp"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-ID: <1114effc-e527-923d-b6fe-c6dda2f8407c@FreeBSD.org>
Subject: Re: svn commit: r303934 - head/usr.bin/truss
References: <201608101819.u7AIJHIh079589@repo.freebsd.org>
 <20160810184102.GW83214@kib.kiev.ua>
In-Reply-To: <20160810184102.GW83214@kib.kiev.ua>

--T0EUKiFDXB7gxSunFUGudXqBwc8tp8FDp
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 8/10/16 11:41 AM, Konstantin Belousov wrote:
> On Wed, Aug 10, 2016 at 06:19:17PM +0000, Bryan Drewery wrote:
>> Author: bdrewery
>> Date: Wed Aug 10 18:19:17 2016
>> New Revision: 303934
>> URL: https://svnweb.freebsd.org/changeset/base/303934
>>
>> Log:
>>   Support rmdir(2).
>>  =20
>>   MFC after:	3 days
>>   Sponsored by:	EMC / Isilon Storage Division
>>
>> Modified:
>>   head/usr.bin/truss/syscalls.c
>>
>> Modified: head/usr.bin/truss/syscalls.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- head/usr.bin/truss/syscalls.c	Wed Aug 10 18:19:14 2016	(r303933)
>> +++ head/usr.bin/truss/syscalls.c	Wed Aug 10 18:19:17 2016	(r303934)
>> @@ -279,6 +279,8 @@ static struct syscall decoded_syscalls[]
>>  	  .args =3D { { Name, 0 }, { Name, 1 } } },
>>  	{ .name =3D "renameat", .ret_type =3D 1, .nargs =3D 4,
>>  	  .args =3D { { Atfd, 0 }, { Name, 1 }, { Atfd, 2 }, { Name, 3 } } }=
,
>> +	{ .name =3D "rmdir", .ret_type =3D 1, .nargs =3D 2,
>> +	  .args =3D { { Name, 0 }, { Octal, 1 } } },
> I do not quite follow this.  The table format is that nargs is the numb=
er
> of arguments to the syscall, and args describe each syscall' argument,
> are my assumptions right ?
>=20
> If yes, what is the second rmdir(2) argument for ?

You're right, it's a bug.  I had copied the wrong syscall and missed this=
=2E

Fixing it, thanks.

>=20
>>  	{ .name =3D "rfork", .ret_type =3D 1, .nargs =3D 1,
>>  	  .args =3D { { Rforkflags, 0 } } },
>>  	{ .name =3D "select", .ret_type =3D 1, .nargs =3D 5,


--=20
Regards,
Bryan Drewery


--T0EUKiFDXB7gxSunFUGudXqBwc8tp8FDp--

--CcR3ANKfps1DDAGP0FkL6XVmlX6iSR5Og
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJXq3YeAAoJEDXXcbtuRpfPPXcIAJ3kNKJN+EJVrxYL3Q4a2Mnm
qrx0vo1YMRf6gv0Rjn8jR3WlBeGQHQu8G2EgOhw898ryAriGBzwomPx5UTMYFcbU
X9JC8ySksL42cE3K+L5knSXwsjbNU0OFsCIWsLf/8iyYkdheHRd5xvqk0PusTQGO
mcZEAXdqdknp/ryRW6og87xl88j8LpPgmUWd/tYfQLf7YKOXOzGZxAu/Fe2Mlf38
7LTWqi2JnhKDHFJ/hkC2WL1Mjy3/6X1yrcE9vZvDB5rN/A0wLbGMPw6yJ9+tiZa5
TD61LjFMBbWHCBfQiMDTSHvcHkuf8rSYpXX+tglwq7ZmA4H86O6DRNhh4EHVIgs=
=kwuD
-----END PGP SIGNATURE-----

--CcR3ANKfps1DDAGP0FkL6XVmlX6iSR5Og--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1114effc-e527-923d-b6fe-c6dda2f8407c>