Date: Sun, 11 May 2014 16:25:22 -0600 From: Warner Losh <imp@bsdimp.com> To: Craig Rodrigues <rodrigc@FreeBSD.org> Cc: freebsd-current Current <freebsd-current@freebsd.org>, "jenkins-admin@freebsd.org" <jenkins-admin@freebsd.org> Subject: Re: Build failed in Jenkins: FreeBSD_HEAD-modules #386 Message-ID: <130417FC-CE39-43DE-B87F-DF2185FC94DC@bsdimp.com> In-Reply-To: <CAG=rPVd8JVLxV1pFUVWsZBX1OnFAEUU6MeBugO3JH7Yf0gSXnA@mail.gmail.com> References: <254143261.0.1399675169702.JavaMail.jenkins@jenkins-9.freebsd.org> <CAG=rPVdHR29qMsvZVfVxBgoX4Jg7sXXWePZ9%2BvvyPOcLqL5R8A@mail.gmail.com> <26E92F41-F849-43E2-AC1F-553F1AB7B11F@bsdimp.com> <CAG=rPVd8JVLxV1pFUVWsZBX1OnFAEUU6MeBugO3JH7Yf0gSXnA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_27C46898-C19A-432A-89C0-6F750A27E55A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On May 11, 2014, at 1:43 PM, Craig Rodrigues <rodrigc@FreeBSD.org> = wrote: > Hi, >=20 > No, that's not the problem, because we specifically check out > /usr/share/mk into $WORKSPACE/mk before running the build. >=20 > The problem is due to this commit: >=20 > = http://svnweb.freebsd.org/base/head/sys/conf/kern.mk?r1=3D265832&r2=3D2658= 41 >=20 > You didn't completely remove MK_FORMAT_EXTENSIONS from this file, I never tried. > so we are now getting this error message: >=20 > make[1]: = "/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.opts.mk" > line 24: Could not find ../../share/mk/bsd.mkopt.mk We assume a certain tree layout, which your script violates, so we can=92t= include this file. We simply don=92t support building the kernel with = such arbitrary system layouts. We have to include it this way, rather than other ways, because when you = are building out of tree you don=92t pass in the root. I don=92t think this is a valid test of the build system. You are = building with weird tree layouts. Please build with standard layouts. > make[1]: = "/builds/FreeBSD_HEAD-modules/sys/modules/aac/../../conf/kern.mk" > line 38: Malformed conditional (${MK_FORMAT_EXTENSIONS} =3D=3D "no=94) Since we can=92t include the file, anything downstream from that is just = noise and needs to be ignored. Warner > -- > Craig >=20 >=20 > On Sat, May 10, 2014 at 7:06 PM, Warner Losh <imp@bsdimp.com> wrote: >>=20 >> On May 10, 2014, at 6:27 PM, Craig Rodrigues <rodrigc@FreeBSD.org> = wrote: >>=20 >>> Warner, >>>=20 >>> It looks like your change broke the FreeBSD-HEAD-modules >>> build. >>>=20 >>> This build does the following: >>>=20 >>> export JFLAG=3D"-j4" >>> export MAKESYSPATH=3D"${WORKSPACE}/mk" >>=20 >> Shouldn't this be ${WORKSPACE}/share/mk? MAKESYSPATH needs to be = .../share/mk or $TOP/share/mk when building outside of make world-like = environments now. >>=20 >> Warner >>=20 >>> cd ${WORKSPACE}/sys/modules >>> echo "=3D=3D=3D make cleandir =3D=3D=3D" >>> make cleandir >>> echo "=3D=3D=3D make depend =3D=3D=3D" >>> make ${JFLAG} depend >>> echo "=3D=3D=3D make all =3D=3D=3D" >>> make ${JFLAG} all >>>=20 >>>=20 >>> Can you look into this? >>>=20 >>> Thanks. >>>=20 >>> -- >>> Craig >>>=20 >>>=20 >>> On Fri, May 9, 2014 at 3:39 PM, <jenkins-admin@freebsd.org> wrote: >>>> See = <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/386/changes>= >>>>=20 >>>> Changes: >>>>=20 >>>> [imp] Introduce kern.opts.mk to hold all the options for kernel = module >>>> builds. Include this in the right places. Make src.opts.mk optional = so >>>> that modules can be built outside of the tree in the ports system. >>>>=20 >>>> PR: 189520 >>>>=20 >>>> ------------------------------------------ >>>> Started by upstream project "FreeBSD_HEAD" build number 636 >>>> originally caused by: >>>> Started by an SCM change >>>> Building remotely on jenkins-10.freebsd.org (FreeBSD-10) in = workspace = <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/>; >>>> Updating svn://svn.freebsd.org/base/head/sys at revision = '2014-05-09T22:39:09.739 +0000' >>>> U conf/kmod.mk >>>> AU conf/kern.opts.mk >>>> U conf/kern.pre.mk >>>> At revision 265785 >>>> Updating svn://svn.freebsd.org/base/head/share/mk at revision = '2014-05-09T22:39:09.739 +0000' >>>> U src.opts.mk >>>> At revision 265785 >>>> [FreeBSD_HEAD-modules] $ /bin/sh -xe = /tmp/hudson6703688508778127870.sh >>>> + export JFLAG=3D-j4 >>>> + export = MAKESYSPATH=3D<https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-module= s/ws/mk> >>>> + cd = <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modul= es> >>>> + echo '=3D=3D=3D make cleandir =3D=3D=3D' >>>> =3D=3D=3D make cleandir =3D=3D=3D >>>> + make cleandir >>>> =3D=3D=3D> aac (cleandir) >>>> make[1]: = "<https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modu= les/aac/../../conf/kern.opts.mk"> line 24: Could not find = ../../share/mk/bsd.mkopt.mk >>>> make[1]: Fatal errors encountered -- cannot continue >>>> make[1]: stopped in = <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modul= es/aac> >>>> *** Error code 1 >>>>=20 >>>> Stop. >>>> make: stopped in = <https://jenkins.freebsd.org/jenkins/job/FreeBSD_HEAD-modules/ws/sys/modul= es> >>>> Build step 'Execute shell' marked build as failure >>=20 --Apple-Mail=_27C46898-C19A-432A-89C0-6F750A27E55A Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTb/jSAAoJEGwc0Sh9sBEA5csP/2/DunI5o2rAG/38+pC+KgTY zcJAIZArW/1RddW2j0q0AELRSNJlk5dZMS4buQVAQRv7+Tb7iHplXsUEyxFO7Lk/ m8QbJz95JhmDnFPA4eTllQP77k2AF1Pz0FV7Yw63Q1xuNh4SoYbyYTupq0Z4YSOc zjx0jG8fcn8bYKBYe8F7Kxw7AzVWZ/KtDkZQbcjm7NwmZCMiv5Xil1hCbDa3fn05 ajl3IhtSNpHX4GxwB9d2d5Uq1+kstAjLDAeTOUERH1gaHc1abArwncWuY5TK4QKF 6M6GWQFzQGzGa+NxJ77qeP0Fqcu0W0VWwkPqCCjc0zyQb7ev4hWT5oNYC6iyLXrS jlAK2NpDKZ66AdEVdCY13gKzCEqPkzo0Ms3+vqCbqFQ/MvA/YKoekdN1CS3Sie1r QZfAnMq87BqSLD4IWUO9xjkWCfN6yRNoO/5ri0mWVBsN7o31hv/8EJWb8DdGXL1I JHozxKSNVDlSw47nWSCSIDbSUriA4sX46WiC3J0Rgt4Yn9mEMN0TfPpSXp6N6eZi olkw9kRyKvbwCx0uNy713Y88FaOFSWCOiYnKc0cs/qPEKH/vZiAAM1j+UWlUyTgr BKd5pJ/qmoPcF/1cBCAMK5h1ITVhX72JGvwqwRwpq983hpoJc4VCMSdje8ZB1iKo Lgk8b40wrjHUjWiUtdbA =Pt0g -----END PGP SIGNATURE----- --Apple-Mail=_27C46898-C19A-432A-89C0-6F750A27E55A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?130417FC-CE39-43DE-B87F-DF2185FC94DC>