Date: Thu, 19 Aug 2010 01:04:36 +0000 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Alexey Dokuchaev <danfe@FreeBSD.ORG> Cc: cvs-ports@FreeBSD.ORG, cvs-all@FreeBSD.ORG, Andrej Zverev <az@FreeBSD.ORG>, ports-committers@FreeBSD.ORG Subject: Re: cvs commit: ports/devel/p5-Config-Model Makefile distinfo pkg-plist Message-ID: <4C6C8324.3030303@p6m7g8.com> In-Reply-To: <20100819005838.GA24811@FreeBSD.org> References: <201008181153.o7IBrvlo010634@repoman.freebsd.org> <20100818184746.GA43513@FreeBSD.org> <AANLkTinfDgHsyWPFHSg6c=HdOrbAA2qTFrEd-SxQ13P_@mail.gmail.com> <4C6C6159.5060800@p6m7g8.com> <20100819005838.GA24811@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/19/10 00:58, Alexey Dokuchaev wrote: > On Wed, Aug 18, 2010 at 10:40:25PM +0000, Philip M. Gollucci wrote: >> On 08/18/10 20:13, Andrej Zverev wrote: >>> 2010/8/18 Alexey Dokuchaev <danfe@freebsd.org>: >>>> Please assign RUN_DEPENDS correctly with := (immediate expansion >>>> operator). Right now it is polluted with `devel/p5-Module-Build' and >>>> extra one of `lang/perl5.10'. Consider attached patch. Point the >>>> original submitter to section 5.7.2 of PH. >>> >>> Wow, didn't know about it. I will read PH for sure (never read it >>> before actually). I thought that I don't need nothing except to check >>> the assembly in the tinderbox and blind faith in PR plus ignoring some >>> smarts guys like you. This will lead me to the hall of fame of the >>> best commiters. Immortality!!! >> >> We're actually moving away from that. Fewer then 100 ports use this >> right now. Whats prefered is to list the BUILD/RUN depends explicitly >> which portlint tells you to do. > > I actually indent to fix portlint(1) in that regard. I do not see we > should avoid doing handy things like bdels to rdeps assignment just > because someone(tm) believes it's too hard for maintainers/committers to > know make(1) well enough. > > This is, like, lets simplifay ze lenguidj, bicoz pipl hev hard taym > ridin it. That actually works both ways. := and X=Y Y+=Z expanding later with unwanted additions are (apparently) equally unknown features. I'm not contending one way is better then the other. What I'm saying is that 95% of the tree, the handbook, and portlint is already 1 way. Flipping it creates a ton of work to bring things in line [even over time]. That said do what you want. - -- - ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Consultant, P6M7G8 Inc. Sr. System Admin, Ridecharge Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iD8DBQFMbIMkdbiP+9ubjBwRAn1FAJ9JhIc1jMu7JDeGS/DyDeTZqwvCNwCfSaPH B6+S5aRvsrEW7z6AzGmtjAc= =qFAg -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C6C8324.3030303>