Date: Wed, 30 May 2001 09:22:34 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/xinstall xinstall.c Message-ID: <20010530092234.B32934@sunbay.com> In-Reply-To: <200105291841.f4TIfHJ95818@freefall.freebsd.org>; from imp@FreeBSD.org on Tue, May 29, 2001 at 11:41:16AM -0700 References: <200105291841.f4TIfHJ95818@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 29, 2001 at 11:41:16AM -0700, Warner Losh wrote:
> imp 2001/05/29 11:41:16 PDT
>
> Modified files:
> usr.bin/xinstall xinstall.c
> Log:
> Use use ${INSTALL} -d in our build process. If INSTALL is set to
> "install -C" then things will fail due to new checks. Relax the
> checks so that install -C -d works again.
>
> Revision Changes Path
> 1.42 +2 -2 src/usr.bin/xinstall/xinstall.c
>
Argh, couldn't this have waited before I speak up? :-(
I'm strongly objecting to this change and require it to be backed out.
Having INSTALL="install -C" is a bug, see usage() and SYNOPSIS before
my change, for example on 4.3-STABLE system. It was a bug in the code
that this combination was allowed. -C is to be used only with files,
not when installing directories (-d).
Moreover, relaxing the check for -S (safecopy), which is a new flag,
is bogus.
Are we required to support old bugs?
Cheers,
--
Ruslan Ermilov Oracle Developer/DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010530092234.B32934>