Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 24 Oct 2008 09:01:55 -0700
From:      Sam Leffler <sam@freebsd.org>
To:        marcel@freebsd.org
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@bsdimp.com>
Subject:   Re: svn commit: r184193 - in head/sys: arm/conf conf
Message-ID:  <4901F173.2070701@freebsd.org>
In-Reply-To: <20081023.190942.74668946.imp@bsdimp.com>
References:  <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Warner Losh wrote:
> From: Marcel Moolenaar <marcel@FreeBSD.org>
> Subject: svn commit: r184193 - in head/sys: arm/conf conf
> Date: Thu, 23 Oct 2008 01:51:55 +0000 (UTC)
>
>   
>> Author: marcel
>> Date: Thu Oct 23 01:51:55 2008
>> New Revision: 184193
>> URL: http://svn.freebsd.org/changeset/base/184193
>>
>> Log:
>>   Add arm/conf/DEFAULTS and populate it with:
>>           machine arm
>>           device  mem
>>           options GEOM_BSD
>>           options GEOM_MBR
>>   
>>   Remove the first two from all kernel configuration files and
>>   change geom_bsd and geom_mbr from standard to optional.
>>
>> Added:
>>   head/sys/arm/conf/DEFAULTS   (contents, props changed)
>>     
>
> We already have a better mechanism for including config files.  We
> should be using that instead of poluting another port with the
> DEFAULTS file.
>   
More importantly this change forces GEOM_BSD and GEOM_MBR on every 
target platform.  This is just wrong and clearly Marvel never discussed 
it with anyone working on arm systems or he'd have gotten an earful.

Marcel, please back this stuff out.

    Sam




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4901F173.2070701>